{"action":"created","issue":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/7821","repository_url":"https://api.github.com/repos/swagger-api/swagger-codegen","labels_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/7821/labels{/name}","comments_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/7821/comments","events_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/7821/events","html_url":"https://github.com/swagger-api/swagger-codegen/pull/7821","id":304279716,"number":7821,"title":"[Swift 4] Fix APIHelper to accept array parameter","user":{"login":"d-date","id":20222809,"avatar_url":"https://avatars3.githubusercontent.com/u/20222809?v=4","gravatar_id":"","url":"https://api.github.com/users/d-date","html_url":"https://github.com/d-date","followers_url":"https://api.github.com/users/d-date/followers","following_url":"https://api.github.com/users/d-date/following{/other_user}","gists_url":"https://api.github.com/users/d-date/gists{/gist_id}","starred_url":"https://api.github.com/users/d-date/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-date/subscriptions","organizations_url":"https://api.github.com/users/d-date/orgs","repos_url":"https://api.github.com/users/d-date/repos","events_url":"https://api.github.com/users/d-date/events{/privacy}","received_events_url":"https://api.github.com/users/d-date/received_events","type":"User","site_admin":false},"labels":[{"id":165466244,"url":"https://api.github.com/repos/swagger-api/swagger-codegen/labels/Client:%20Swift","name":"Client: Swift","color":"fad8c7","default":false},{"id":64180581,"url":"https://api.github.com/repos/swagger-api/swagger-codegen/labels/Issue:%20Bug","name":"Issue: Bug","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/milestones/16","html_url":"https://github.com/swagger-api/swagger-codegen/milestone/16","labels_url":"https://api.github.com/repos/swagger-api/swagger-codegen/milestones/16/labels","id":2981586,"number":16,"title":"v2.4.0","description":"","creator":{"login":"wing328","id":934260,"avatar_url":"https://avatars2.githubusercontent.com/u/934260?v=4","gravatar_id":"","url":"https://api.github.com/users/wing328","html_url":"https://github.com/wing328","followers_url":"https://api.github.com/users/wing328/followers","following_url":"https://api.github.com/users/wing328/following{/other_user}","gists_url":"https://api.github.com/users/wing328/gists{/gist_id}","starred_url":"https://api.github.com/users/wing328/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing328/subscriptions","organizations_url":"https://api.github.com/users/wing328/orgs","repos_url":"https://api.github.com/users/wing328/repos","events_url":"https://api.github.com/users/wing328/events{/privacy}","received_events_url":"https://api.github.com/users/wing328/received_events","type":"User","site_admin":false},"open_issues":170,"closed_issues":255,"state":"open","created_at":"2017-12-15T09:01:57Z","updated_at":"2018-03-18T14:00:47Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-03-12T08:36:15Z","updated_at":"2018-03-18T14:01:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/7821","html_url":"https://github.com/swagger-api/swagger-codegen/pull/7821","diff_url":"https://github.com/swagger-api/swagger-codegen/pull/7821.diff","patch_url":"https://github.com/swagger-api/swagger-codegen/pull/7821.patch"},"body":"### PR checklist\r\n\r\n- [x] Read the [contribution guidelines](https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md).\r\n- [x] Ran the shell script under `./bin/` to update Petstore sample so that CIs can verify the change. (For instance, only need to run `./bin/{LANG}-petstore.sh` and `./bin/security/{LANG}-petstore.sh` if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in `.\\bin\\windows\\`.\r\n- [x] Filed the PR against the correct branch: `3.0.0` branch for changes related to OpenAPI spec 3.0. Default: `master`.\r\n- [x] Copied the [technical committee](https://github.com/swagger-api/swagger-codegen/#swagger-codegen-technical-committee) to review the pull request if your PR is targeting a particular programming language.\r\n\r\n### Description of the PR\r\n\r\n(details of the change, additional tests that have been done, reference to the issue for tracking, etc)\r\nTo be fix #7796 ,Fix APIHelper to accept array parameter with joined comma separated string. Also to improve performance, APIHelper was replaced to using `reduce(into:)`.\r\n\r\n- [x] Fix APIHelper to accept array parameter with joined comma separated string\r\n- [x] Performance improvement using reduce(into:)\r\n- [x] replace `NSURLComponents` to `URLComponents`\r\n- [x] fix failing unit tests\r\n- [x] revise public initializers for Model Object to write unit test same as #7652 \r\n- [x] Add `APIHelperTest`\r\n"},"comment":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/comments/374001547","html_url":"https://github.com/swagger-api/swagger-codegen/pull/7821#issuecomment-374001547","issue_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/7821","id":374001547,"user":{"login":"wing328","id":934260,"avatar_url":"https://avatars2.githubusercontent.com/u/934260?v=4","gravatar_id":"","url":"https://api.github.com/users/wing328","html_url":"https://github.com/wing328","followers_url":"https://api.github.com/users/wing328/followers","following_url":"https://api.github.com/users/wing328/following{/other_user}","gists_url":"https://api.github.com/users/wing328/gists{/gist_id}","starred_url":"https://api.github.com/users/wing328/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing328/subscriptions","organizations_url":"https://api.github.com/users/wing328/orgs","repos_url":"https://api.github.com/users/wing328/repos","events_url":"https://api.github.com/users/wing328/events{/privacy}","received_events_url":"https://api.github.com/users/wing328/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T14:01:34Z","updated_at":"2018-03-18T14:01:34Z","author_association":"MEMBER","body":"@d-date sorry very busy these days. I'll review tomorrow"}}
{"actor":{"display_login":"wing328"}}