{"action":"created","comment":{"url":"https://api.github.com/repos/dashpay/dash/pulls/comments/224869524","pull_request_review_id":164349201,"id":224869524,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDg2OTUyNA==","diff_hunk":"@@ -0,0 +1,361 @@\n+// Copyright (c) 2018 The Dash Core developers\n+// Distributed under the MIT software license, see the accompanying\n+// file COPYING or http://www.opensource.org/licenses/mit-license.php.\n+\n+#include \"bench.h\"\n+#include \"random.h\"\n+#include \"crypto/bls_worker.h\"\n+#include \"utiltime.h\"\n+\n+#include <iostream>\n+\n+CBLSWorker blsWorker;\n+\n+void CleanupBLSTests()\n+{\n+    blsWorker.Stop();\n+}\n+\n+static void BuildTestVectors(size_t count, size_t invalidCount,\n+                             BLSPublicKeyVector& pubKeys, BLSSecretKeyVector& secKeys, BLSSignatureVector& sigs,\n+                             std::vector<uint256>& msgHashes,\n+                             std::vector<bool>& invalid)\n+{\n+    secKeys.resize(count);\n+    pubKeys.resize(count);\n+    sigs.resize(count);\n+    msgHashes.resize(count);\n+\n+    invalid.resize(count);\n+    for (size_t i = 0; i < invalidCount; i++) {","path":"src/bench/bls.cpp","position":null,"original_position":30,"commit_id":"aa1c9784987afc4a32950448bac6408669574abd","original_commit_id":"78675d9bb02523686abd9b1cf459b82c19bbc804","user":{"login":"UdjinM6","id":1935069,"node_id":"MDQ6VXNlcjE5MzUwNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1935069?v=4","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"body":"Agree, you can ignore this one :)","created_at":"2018-10-12T17:58:59Z","updated_at":"2018-10-12T17:58:59Z","html_url":"https://github.com/dashpay/dash/pull/2296#discussion_r224869524","pull_request_url":"https://api.github.com/repos/dashpay/dash/pulls/2296","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dashpay/dash/pulls/comments/224869524"},"html":{"href":"https://github.com/dashpay/dash/pull/2296#discussion_r224869524"},"pull_request":{"href":"https://api.github.com/repos/dashpay/dash/pulls/2296"}},"in_reply_to_id":223994063},"pull_request":{"url":"https://api.github.com/repos/dashpay/dash/pulls/2296","id":215647112,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjQ3MTEy","html_url":"https://github.com/dashpay/dash/pull/2296","diff_url":"https://github.com/dashpay/dash/pull/2296.diff","patch_url":"https://github.com/dashpay/dash/pull/2296.patch","issue_url":"https://api.github.com/repos/dashpay/dash/issues/2296","number":2296,"state":"open","locked":false,"title":"[WIP] Add BLS libraries, wrappers, helpers and benchmarks","user":{"login":"codablock","id":1884269,"node_id":"MDQ6VXNlcjE4ODQyNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1884269?v=4","gravatar_id":"","url":"https://api.github.com/users/codablock","html_url":"https://github.com/codablock","followers_url":"https://api.github.com/users/codablock/followers","following_url":"https://api.github.com/users/codablock/following{/other_user}","gists_url":"https://api.github.com/users/codablock/gists{/gist_id}","starred_url":"https://api.github.com/users/codablock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codablock/subscriptions","organizations_url":"https://api.github.com/users/codablock/orgs","repos_url":"https://api.github.com/users/codablock/repos","events_url":"https://api.github.com/users/codablock/events{/privacy}","received_events_url":"https://api.github.com/users/codablock/received_events","type":"User","site_admin":false},"body":"**UPDATE: Update description to only refer to the Chia BLS library** \r\n\r\nThis adds the BLS librariy https://github.com/Chia-Network/bls-signatures to depends.\r\n\r\nIt also adds the following things:\r\n1. Wrappers around the Chia lib so that we can stay independent from thes library. These wrappers also add Dash compatible serialization.\r\n2. A simple BLS+Diffie-Hellmann+AES-256CBC integrated encryption scheme implementation\r\n3. A highly paralellized worker/helper for all kinds of BLS related operations. These leverage aggregation and the \"correlation\" property of BLS as much as possible to speed up things.\r\n4. Add the ctpl header-only library which is used by the parallel BLS helper/worker.\r\n5. Benchmarks for BLS and the BLS worker\r\n6. ECDSA benchmarks for comparision\r\n\r\nI decided to separate them from the LLMQ work I've done. This allows other people to experiment with the BLS primitives beforehand.","created_at":"2018-09-14T16:26:10Z","updated_at":"2018-10-12T17:58:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01a7549496ec4018d914daebdfc1829821e254a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/dashpay/dash/milestones/9","html_url":"https://github.com/dashpay/dash/milestone/9","labels_url":"https://api.github.com/repos/dashpay/dash/milestones/9/labels","id":3287184,"node_id":"MDk6TWlsZXN0b25lMzI4NzE4NA==","number":9,"title":"12.4","description":null,"creator":{"login":"UdjinM6","id":1935069,"node_id":"MDQ6VXNlcjE5MzUwNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1935069?v=4","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":136,"state":"open","created_at":"2018-04-22T20:26:11Z","updated_at":"2018-10-12T16:34:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dashpay/dash/pulls/2296/commits","review_comments_url":"https://api.github.com/repos/dashpay/dash/pulls/2296/comments","review_comment_url":"https://api.github.com/repos/dashpay/dash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dashpay/dash/issues/2296/comments","statuses_url":"https://api.github.com/repos/dashpay/dash/statuses/aa1c9784987afc4a32950448bac6408669574abd","head":{"label":"codablock:pr_blsstuff","ref":"pr_blsstuff","sha":"aa1c9784987afc4a32950448bac6408669574abd","user":{"login":"codablock","id":1884269,"node_id":"MDQ6VXNlcjE4ODQyNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1884269?v=4","gravatar_id":"","url":"https://api.github.com/users/codablock","html_url":"https://github.com/codablock","followers_url":"https://api.github.com/users/codablock/followers","following_url":"https://api.github.com/users/codablock/following{/other_user}","gists_url":"https://api.github.com/users/codablock/gists{/gist_id}","starred_url":"https://api.github.com/users/codablock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codablock/subscriptions","organizations_url":"https://api.github.com/users/codablock/orgs","repos_url":"https://api.github.com/users/codablock/repos","events_url":"https://api.github.com/users/codablock/events{/privacy}","received_events_url":"https://api.github.com/users/codablock/received_events","type":"User","site_admin":false},"repo":{"id":95237461,"node_id":"MDEwOlJlcG9zaXRvcnk5NTIzNzQ2MQ==","name":"dash","full_name":"codablock/dash","private":false,"owner":{"login":"codablock","id":1884269,"node_id":"MDQ6VXNlcjE4ODQyNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1884269?v=4","gravatar_id":"","url":"https://api.github.com/users/codablock","html_url":"https://github.com/codablock","followers_url":"https://api.github.com/users/codablock/followers","following_url":"https://api.github.com/users/codablock/following{/other_user}","gists_url":"https://api.github.com/users/codablock/gists{/gist_id}","starred_url":"https://api.github.com/users/codablock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codablock/subscriptions","organizations_url":"https://api.github.com/users/codablock/orgs","repos_url":"https://api.github.com/users/codablock/repos","events_url":"https://api.github.com/users/codablock/events{/privacy}","received_events_url":"https://api.github.com/users/codablock/received_events","type":"User","site_admin":false},"html_url":"https://github.com/codablock/dash","description":"Dash - Reinventing Cryptocurrency","fork":true,"url":"https://api.github.com/repos/codablock/dash","forks_url":"https://api.github.com/repos/codablock/dash/forks","keys_url":"https://api.github.com/repos/codablock/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codablock/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codablock/dash/teams","hooks_url":"https://api.github.com/repos/codablock/dash/hooks","issue_events_url":"https://api.github.com/repos/codablock/dash/issues/events{/number}","events_url":"https://api.github.com/repos/codablock/dash/events","assignees_url":"https://api.github.com/repos/codablock/dash/assignees{/user}","branches_url":"https://api.github.com/repos/codablock/dash/branches{/branch}","tags_url":"https://api.github.com/repos/codablock/dash/tags","blobs_url":"https://api.github.com/repos/codablock/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codablock/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codablock/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/codablock/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codablock/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/codablock/dash/languages","stargazers_url":"https://api.github.com/repos/codablock/dash/stargazers","contributors_url":"https://api.github.com/repos/codablock/dash/contributors","subscribers_url":"https://api.github.com/repos/codablock/dash/subscribers","subscription_url":"https://api.github.com/repos/codablock/dash/subscription","commits_url":"https://api.github.com/repos/codablock/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/codablock/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/codablock/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/codablock/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/codablock/dash/contents/{+path}","compare_url":"https://api.github.com/repos/codablock/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codablock/dash/merges","archive_url":"https://api.github.com/repos/codablock/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codablock/dash/downloads","issues_url":"https://api.github.com/repos/codablock/dash/issues{/number}","pulls_url":"https://api.github.com/repos/codablock/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/codablock/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/codablock/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codablock/dash/labels{/name}","releases_url":"https://api.github.com/repos/codablock/dash/releases{/id}","deployments_url":"https://api.github.com/repos/codablock/dash/deployments","created_at":"2017-06-23T16:30:50Z","updated_at":"2018-08-21T18:59:21Z","pushed_at":"2018-10-12T17:39:45Z","git_url":"git://github.com/codablock/dash.git","ssh_url":"git@github.com:codablock/dash.git","clone_url":"https://github.com/codablock/dash.git","svn_url":"https://github.com/codablock/dash","homepage":"https://www.dash.org","size":105658,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dashpay:develop","ref":"develop","sha":"eaef9020256400171ac7521df8819b0c832a0b73","user":{"login":"dashpay","id":11511719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTExNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/11511719?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"repo":{"id":19352450,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM1MjQ1MA==","name":"dash","full_name":"dashpay/dash","private":false,"owner":{"login":"dashpay","id":11511719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTExNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/11511719?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dashpay/dash","description":"Dash - Reinventing Cryptocurrency","fork":true,"url":"https://api.github.com/repos/dashpay/dash","forks_url":"https://api.github.com/repos/dashpay/dash/forks","keys_url":"https://api.github.com/repos/dashpay/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashpay/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashpay/dash/teams","hooks_url":"https://api.github.com/repos/dashpay/dash/hooks","issue_events_url":"https://api.github.com/repos/dashpay/dash/issues/events{/number}","events_url":"https://api.github.com/repos/dashpay/dash/events","assignees_url":"https://api.github.com/repos/dashpay/dash/assignees{/user}","branches_url":"https://api.github.com/repos/dashpay/dash/branches{/branch}","tags_url":"https://api.github.com/repos/dashpay/dash/tags","blobs_url":"https://api.github.com/repos/dashpay/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashpay/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashpay/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashpay/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashpay/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dashpay/dash/languages","stargazers_url":"https://api.github.com/repos/dashpay/dash/stargazers","contributors_url":"https://api.github.com/repos/dashpay/dash/contributors","subscribers_url":"https://api.github.com/repos/dashpay/dash/subscribers","subscription_url":"https://api.github.com/repos/dashpay/dash/subscription","commits_url":"https://api.github.com/repos/dashpay/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashpay/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashpay/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashpay/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashpay/dash/contents/{+path}","compare_url":"https://api.github.com/repos/dashpay/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashpay/dash/merges","archive_url":"https://api.github.com/repos/dashpay/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashpay/dash/downloads","issues_url":"https://api.github.com/repos/dashpay/dash/issues{/number}","pulls_url":"https://api.github.com/repos/dashpay/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dashpay/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dashpay/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashpay/dash/labels{/name}","releases_url":"https://api.github.com/repos/dashpay/dash/releases{/id}","deployments_url":"https://api.github.com/repos/dashpay/dash/deployments","created_at":"2014-05-01T17:45:34Z","updated_at":"2018-10-12T12:36:57Z","pushed_at":"2018-10-12T17:39:49Z","git_url":"git://github.com/dashpay/dash.git","ssh_url":"git@github.com:dashpay/dash.git","clone_url":"https://github.com/dashpay/dash.git","svn_url":"https://github.com/dashpay/dash","homepage":"https://www.dash.org","size":105045,"stargazers_count":1090,"watchers_count":1090,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":891,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":891,"open_issues":79,"watchers":1090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dashpay/dash/pulls/2296"},"html":{"href":"https://github.com/dashpay/dash/pull/2296"},"issue":{"href":"https://api.github.com/repos/dashpay/dash/issues/2296"},"comments":{"href":"https://api.github.com/repos/dashpay/dash/issues/2296/comments"},"review_comments":{"href":"https://api.github.com/repos/dashpay/dash/pulls/2296/comments"},"review_comment":{"href":"https://api.github.com/repos/dashpay/dash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dashpay/dash/pulls/2296/commits"},"statuses":{"href":"https://api.github.com/repos/dashpay/dash/statuses/aa1c9784987afc4a32950448bac6408669574abd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"UdjinM6"}}