{"action":"closed","number":165,"pull_request":{"url":"https://api.github.com/repos/jtdaugherty/brick/pulls/165","id":177314739,"html_url":"https://github.com/jtdaugherty/brick/pull/165","diff_url":"https://github.com/jtdaugherty/brick/pull/165.diff","patch_url":"https://github.com/jtdaugherty/brick/pull/165.patch","issue_url":"https://api.github.com/repos/jtdaugherty/brick/issues/165","number":165,"state":"closed","locked":false,"title":"Dynamic borders take two","user":{"login":"dmwit","id":203613,"avatar_url":"https://avatars2.githubusercontent.com/u/203613?v=4","gravatar_id":"","url":"https://api.github.com/users/dmwit","html_url":"https://github.com/dmwit","followers_url":"https://api.github.com/users/dmwit/followers","following_url":"https://api.github.com/users/dmwit/following{/other_user}","gists_url":"https://api.github.com/users/dmwit/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwit/subscriptions","organizations_url":"https://api.github.com/users/dmwit/orgs","repos_url":"https://api.github.com/users/dmwit/repos","events_url":"https://api.github.com/users/dmwit/events{/privacy}","received_events_url":"https://api.github.com/users/dmwit/received_events","type":"User","site_admin":false},"body":"Currently brick borders have a visual oddity: neighboring borders do not connect. You can work around this in simple situations by computing ahead of time where the borders would meet, then manually breaking a single border widget into three pieces (the border before the meet, the single character that connects the two borders, then the border after the meet). This is super annoying and easy to get wrong; it doesn't scale well to complex layouts; and practically speaking it means that people don't do this and just deal with the visual oddity.\r\n\r\nThe patches below add support for automatically rewriting borders that meet in this way. Users can add a single function call to their top-level widget, and get dynamic borders that react to their neighbors appropriately.","created_at":"2018-03-25T22:16:42Z","updated_at":"2018-03-25T22:45:11Z","closed_at":"2018-03-25T22:45:11Z","merged_at":"2018-03-25T22:45:11Z","merge_commit_sha":"c0a3e47e69248bd6c9fd4f4429fd6dcabcba3330","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jtdaugherty/brick/pulls/165/commits","review_comments_url":"https://api.github.com/repos/jtdaugherty/brick/pulls/165/comments","review_comment_url":"https://api.github.com/repos/jtdaugherty/brick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jtdaugherty/brick/issues/165/comments","statuses_url":"https://api.github.com/repos/jtdaugherty/brick/statuses/0290362aaa941dcfb2b2455b04a6e47b62ee387e","head":{"label":"dmwit:dynamic-borders-take-two","ref":"dynamic-borders-take-two","sha":"0290362aaa941dcfb2b2455b04a6e47b62ee387e","user":{"login":"dmwit","id":203613,"avatar_url":"https://avatars2.githubusercontent.com/u/203613?v=4","gravatar_id":"","url":"https://api.github.com/users/dmwit","html_url":"https://github.com/dmwit","followers_url":"https://api.github.com/users/dmwit/followers","following_url":"https://api.github.com/users/dmwit/following{/other_user}","gists_url":"https://api.github.com/users/dmwit/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwit/subscriptions","organizations_url":"https://api.github.com/users/dmwit/orgs","repos_url":"https://api.github.com/users/dmwit/repos","events_url":"https://api.github.com/users/dmwit/events{/privacy}","received_events_url":"https://api.github.com/users/dmwit/received_events","type":"User","site_admin":false},"repo":{"id":116557843,"name":"brick","full_name":"dmwit/brick","owner":{"login":"dmwit","id":203613,"avatar_url":"https://avatars2.githubusercontent.com/u/203613?v=4","gravatar_id":"","url":"https://api.github.com/users/dmwit","html_url":"https://github.com/dmwit","followers_url":"https://api.github.com/users/dmwit/followers","following_url":"https://api.github.com/users/dmwit/following{/other_user}","gists_url":"https://api.github.com/users/dmwit/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwit/subscriptions","organizations_url":"https://api.github.com/users/dmwit/orgs","repos_url":"https://api.github.com/users/dmwit/repos","events_url":"https://api.github.com/users/dmwit/events{/privacy}","received_events_url":"https://api.github.com/users/dmwit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmwit/brick","description":"A declarative terminal UI programming library written in Haskell","fork":true,"url":"https://api.github.com/repos/dmwit/brick","forks_url":"https://api.github.com/repos/dmwit/brick/forks","keys_url":"https://api.github.com/repos/dmwit/brick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmwit/brick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmwit/brick/teams","hooks_url":"https://api.github.com/repos/dmwit/brick/hooks","issue_events_url":"https://api.github.com/repos/dmwit/brick/issues/events{/number}","events_url":"https://api.github.com/repos/dmwit/brick/events","assignees_url":"https://api.github.com/repos/dmwit/brick/assignees{/user}","branches_url":"https://api.github.com/repos/dmwit/brick/branches{/branch}","tags_url":"https://api.github.com/repos/dmwit/brick/tags","blobs_url":"https://api.github.com/repos/dmwit/brick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmwit/brick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmwit/brick/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmwit/brick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmwit/brick/statuses/{sha}","languages_url":"https://api.github.com/repos/dmwit/brick/languages","stargazers_url":"https://api.github.com/repos/dmwit/brick/stargazers","contributors_url":"https://api.github.com/repos/dmwit/brick/contributors","subscribers_url":"https://api.github.com/repos/dmwit/brick/subscribers","subscription_url":"https://api.github.com/repos/dmwit/brick/subscription","commits_url":"https://api.github.com/repos/dmwit/brick/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmwit/brick/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmwit/brick/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmwit/brick/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmwit/brick/contents/{+path}","compare_url":"https://api.github.com/repos/dmwit/brick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmwit/brick/merges","archive_url":"https://api.github.com/repos/dmwit/brick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmwit/brick/downloads","issues_url":"https://api.github.com/repos/dmwit/brick/issues{/number}","pulls_url":"https://api.github.com/repos/dmwit/brick/pulls{/number}","milestones_url":"https://api.github.com/repos/dmwit/brick/milestones{/number}","notifications_url":"https://api.github.com/repos/dmwit/brick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmwit/brick/labels{/name}","releases_url":"https://api.github.com/repos/dmwit/brick/releases{/id}","deployments_url":"https://api.github.com/repos/dmwit/brick/deployments","created_at":"2018-01-07T10:55:11Z","updated_at":"2018-01-07T10:55:14Z","pushed_at":"2018-03-25T22:11:32Z","git_url":"git://github.com/dmwit/brick.git","ssh_url":"git@github.com:dmwit/brick.git","clone_url":"https://github.com/dmwit/brick.git","svn_url":"https://github.com/dmwit/brick","homepage":"","size":1327,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jtdaugherty:master","ref":"master","sha":"aa5282b2b65dd9c5af5ff4350d897f496764aad7","user":{"login":"jtdaugherty","id":427221,"avatar_url":"https://avatars0.githubusercontent.com/u/427221?v=4","gravatar_id":"","url":"https://api.github.com/users/jtdaugherty","html_url":"https://github.com/jtdaugherty","followers_url":"https://api.github.com/users/jtdaugherty/followers","following_url":"https://api.github.com/users/jtdaugherty/following{/other_user}","gists_url":"https://api.github.com/users/jtdaugherty/gists{/gist_id}","starred_url":"https://api.github.com/users/jtdaugherty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtdaugherty/subscriptions","organizations_url":"https://api.github.com/users/jtdaugherty/orgs","repos_url":"https://api.github.com/users/jtdaugherty/repos","events_url":"https://api.github.com/users/jtdaugherty/events{/privacy}","received_events_url":"https://api.github.com/users/jtdaugherty/received_events","type":"User","site_admin":false},"repo":{"id":35321175,"name":"brick","full_name":"jtdaugherty/brick","owner":{"login":"jtdaugherty","id":427221,"avatar_url":"https://avatars0.githubusercontent.com/u/427221?v=4","gravatar_id":"","url":"https://api.github.com/users/jtdaugherty","html_url":"https://github.com/jtdaugherty","followers_url":"https://api.github.com/users/jtdaugherty/followers","following_url":"https://api.github.com/users/jtdaugherty/following{/other_user}","gists_url":"https://api.github.com/users/jtdaugherty/gists{/gist_id}","starred_url":"https://api.github.com/users/jtdaugherty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtdaugherty/subscriptions","organizations_url":"https://api.github.com/users/jtdaugherty/orgs","repos_url":"https://api.github.com/users/jtdaugherty/repos","events_url":"https://api.github.com/users/jtdaugherty/events{/privacy}","received_events_url":"https://api.github.com/users/jtdaugherty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtdaugherty/brick","description":"A declarative terminal UI programming library written in Haskell","fork":false,"url":"https://api.github.com/repos/jtdaugherty/brick","forks_url":"https://api.github.com/repos/jtdaugherty/brick/forks","keys_url":"https://api.github.com/repos/jtdaugherty/brick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtdaugherty/brick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtdaugherty/brick/teams","hooks_url":"https://api.github.com/repos/jtdaugherty/brick/hooks","issue_events_url":"https://api.github.com/repos/jtdaugherty/brick/issues/events{/number}","events_url":"https://api.github.com/repos/jtdaugherty/brick/events","assignees_url":"https://api.github.com/repos/jtdaugherty/brick/assignees{/user}","branches_url":"https://api.github.com/repos/jtdaugherty/brick/branches{/branch}","tags_url":"https://api.github.com/repos/jtdaugherty/brick/tags","blobs_url":"https://api.github.com/repos/jtdaugherty/brick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtdaugherty/brick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtdaugherty/brick/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtdaugherty/brick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtdaugherty/brick/statuses/{sha}","languages_url":"https://api.github.com/repos/jtdaugherty/brick/languages","stargazers_url":"https://api.github.com/repos/jtdaugherty/brick/stargazers","contributors_url":"https://api.github.com/repos/jtdaugherty/brick/contributors","subscribers_url":"https://api.github.com/repos/jtdaugherty/brick/subscribers","subscription_url":"https://api.github.com/repos/jtdaugherty/brick/subscription","commits_url":"https://api.github.com/repos/jtdaugherty/brick/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtdaugherty/brick/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtdaugherty/brick/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtdaugherty/brick/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtdaugherty/brick/contents/{+path}","compare_url":"https://api.github.com/repos/jtdaugherty/brick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtdaugherty/brick/merges","archive_url":"https://api.github.com/repos/jtdaugherty/brick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtdaugherty/brick/downloads","issues_url":"https://api.github.com/repos/jtdaugherty/brick/issues{/number}","pulls_url":"https://api.github.com/repos/jtdaugherty/brick/pulls{/number}","milestones_url":"https://api.github.com/repos/jtdaugherty/brick/milestones{/number}","notifications_url":"https://api.github.com/repos/jtdaugherty/brick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtdaugherty/brick/labels{/name}","releases_url":"https://api.github.com/repos/jtdaugherty/brick/releases{/id}","deployments_url":"https://api.github.com/repos/jtdaugherty/brick/deployments","created_at":"2015-05-09T08:23:44Z","updated_at":"2018-03-24T17:30:44Z","pushed_at":"2018-03-25T22:45:11Z","git_url":"git://github.com/jtdaugherty/brick.git","ssh_url":"git@github.com:jtdaugherty/brick.git","clone_url":"https://github.com/jtdaugherty/brick.git","svn_url":"https://github.com/jtdaugherty/brick","homepage":"","size":1247,"stargazers_count":457,"watchers_count":457,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":68,"open_issues":0,"watchers":457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jtdaugherty/brick/pulls/165"},"html":{"href":"https://github.com/jtdaugherty/brick/pull/165"},"issue":{"href":"https://api.github.com/repos/jtdaugherty/brick/issues/165"},"comments":{"href":"https://api.github.com/repos/jtdaugherty/brick/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/jtdaugherty/brick/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/jtdaugherty/brick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jtdaugherty/brick/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/jtdaugherty/brick/statuses/0290362aaa941dcfb2b2455b04a6e47b62ee387e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jtdaugherty","id":427221,"avatar_url":"https://avatars0.githubusercontent.com/u/427221?v=4","gravatar_id":"","url":"https://api.github.com/users/jtdaugherty","html_url":"https://github.com/jtdaugherty","followers_url":"https://api.github.com/users/jtdaugherty/followers","following_url":"https://api.github.com/users/jtdaugherty/following{/other_user}","gists_url":"https://api.github.com/users/jtdaugherty/gists{/gist_id}","starred_url":"https://api.github.com/users/jtdaugherty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtdaugherty/subscriptions","organizations_url":"https://api.github.com/users/jtdaugherty/orgs","repos_url":"https://api.github.com/users/jtdaugherty/repos","events_url":"https://api.github.com/users/jtdaugherty/events{/privacy}","received_events_url":"https://api.github.com/users/jtdaugherty/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":1194,"deletions":49,"changed_files":12}}
{"actor":{"display_login":"jtdaugherty"}}