{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1233","repository_url":"https://api.github.com/repos/kubevirt/kubevirt","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1233/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1233/comments","events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1233/events","html_url":"https://github.com/kubevirt/kubevirt/pull/1233","id":336180253,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Njk0MDE1","number":1233,"title":"VMI shutdown status","user":{"login":"slintes","id":1962082,"node_id":"MDQ6VXNlcjE5NjIwODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1962082?v=4","gravatar_id":"","url":"https://api.github.com/users/slintes","html_url":"https://github.com/slintes","followers_url":"https://api.github.com/users/slintes/followers","following_url":"https://api.github.com/users/slintes/following{/other_user}","gists_url":"https://api.github.com/users/slintes/gists{/gist_id}","starred_url":"https://api.github.com/users/slintes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slintes/subscriptions","organizations_url":"https://api.github.com/users/slintes/orgs","repos_url":"https://api.github.com/users/slintes/repos","events_url":"https://api.github.com/users/slintes/events{/privacy}","received_events_url":"https://api.github.com/users/slintes/received_events","type":"User","site_admin":false},"labels":[{"id":971140812,"node_id":"MDU6TGFiZWw5NzExNDA4MTI=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":583175137,"node_id":"MDU6TGFiZWw1ODMxNzUxMzc=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-06-27T10:59:36Z","updated_at":"2018-07-16T09:30:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1233","html_url":"https://github.com/kubevirt/kubevirt/pull/1233","diff_url":"https://github.com/kubevirt/kubevirt/pull/1233.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1233.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nAfter a shutdown, the VMI always has status \"Failed\". \r\n2 changes are needed:\r\n1. Only try a shutdown when the VM supports ACPI, else directly destroy the VM\r\n2. Set correct status: \r\n    - \"Succeeded\"  when\r\n        - the VM supports ACPI, and a shutdown was succesful\r\n        - or the VM doesn't support ACPI and was destroyed directly\r\n    - \"Failed\" when the VM was destroyed after the graceful shutdown period expired\r\n\r\n**Which issue(s) this PR fixes**\r\nFixes #1137\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\nImproved shutdown behaviour with fixed VMI status\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments/405193073","html_url":"https://github.com/kubevirt/kubevirt/pull/1233#issuecomment-405193073","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1233","id":405193073,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTE5MzA3Mw==","user":{"login":"slintes","id":1962082,"node_id":"MDQ6VXNlcjE5NjIwODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1962082?v=4","gravatar_id":"","url":"https://api.github.com/users/slintes","html_url":"https://github.com/slintes","followers_url":"https://api.github.com/users/slintes/followers","following_url":"https://api.github.com/users/slintes/following{/other_user}","gists_url":"https://api.github.com/users/slintes/gists{/gist_id}","starred_url":"https://api.github.com/users/slintes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slintes/subscriptions","organizations_url":"https://api.github.com/users/slintes/orgs","repos_url":"https://api.github.com/users/slintes/repos","events_url":"https://api.github.com/users/slintes/events{/privacy}","received_events_url":"https://api.github.com/users/slintes/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T09:30:20Z","updated_at":"2018-07-16T09:30:20Z","author_association":"MEMBER","body":"ok.\r\nJust squashed in smaller commits, let's see what openshift reports now."}}
{"actor":{"display_login":"slintes"}}