{"action":"closed","number":721,"pull_request":{"url":"https://api.github.com/repos/DoSomething/phoenix-next/pulls/721","id":172581054,"html_url":"https://github.com/DoSomething/phoenix-next/pull/721","diff_url":"https://github.com/DoSomething/phoenix-next/pull/721.diff","patch_url":"https://github.com/DoSomething/phoenix-next/pull/721.patch","issue_url":"https://api.github.com/repos/DoSomething/phoenix-next/issues/721","number":721,"state":"closed","locked":false,"title":"BUG FIX: moving Embed `isExternal` call","user":{"login":"mendelB","id":12417657,"avatar_url":"https://avatars3.githubusercontent.com/u/12417657?v=4","gravatar_id":"","url":"https://api.github.com/users/mendelB","html_url":"https://github.com/mendelB","followers_url":"https://api.github.com/users/mendelB/followers","following_url":"https://api.github.com/users/mendelB/following{/other_user}","gists_url":"https://api.github.com/users/mendelB/gists{/gist_id}","starred_url":"https://api.github.com/users/mendelB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendelB/subscriptions","organizations_url":"https://api.github.com/users/mendelB/orgs","repos_url":"https://api.github.com/users/mendelB/repos","events_url":"https://api.github.com/users/mendelB/events{/privacy}","received_events_url":"https://api.github.com/users/mendelB/received_events","type":"User","site_admin":false},"body":"## _PULL REQUEST OVERVIEW_\r\n\r\n\r\n### What does this PR do?\r\nThis PR moves the call to the `isExternal` helper function to after the `url` is set in `state`\r\n\r\nFixing a potential and inevitable breakage, when feeding `undefined` (non set url in state) to the helper function, and thus to `new URL` which would explode.\r\n\r\nAlso adding String casting before calling `new URL` in some helper functions for sanity check. (I didn't end up using `makeUrl` from `isExternal` since we have an extra param in `isExternal` in case of relative paths set in Contentful (I remember this issue popping up when we were adding this in))\r\n\r\n### What are the relevant tickets/cards?\r\n[Slack convo](https://dosomething.slack.com/archives/C3ASB4204/p1520016065000395)","created_at":"2018-03-02T19:12:02Z","updated_at":"2018-03-02T19:31:01Z","closed_at":"2018-03-02T19:31:01Z","merged_at":"2018-03-02T19:31:01Z","merge_commit_sha":"bae5fc94217628ba8f1bb07fc3ccc52df3b395aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/phoenix-next/pulls/721/commits","review_comments_url":"https://api.github.com/repos/DoSomething/phoenix-next/pulls/721/comments","review_comment_url":"https://api.github.com/repos/DoSomething/phoenix-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/phoenix-next/issues/721/comments","statuses_url":"https://api.github.com/repos/DoSomething/phoenix-next/statuses/b154398ccb1be3fce6765eb91b177abbf805ed4c","head":{"label":"DoSomething:common-sense-mendel","ref":"common-sense-mendel","sha":"b154398ccb1be3fce6765eb91b177abbf805ed4c","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":75642790,"name":"phoenix-next","full_name":"DoSomething/phoenix-next","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/phoenix-next","description":"🔥 The new DoSomething.org campaign template.","fork":false,"url":"https://api.github.com/repos/DoSomething/phoenix-next","forks_url":"https://api.github.com/repos/DoSomething/phoenix-next/forks","keys_url":"https://api.github.com/repos/DoSomething/phoenix-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/phoenix-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/phoenix-next/teams","hooks_url":"https://api.github.com/repos/DoSomething/phoenix-next/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/phoenix-next/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/phoenix-next/events","assignees_url":"https://api.github.com/repos/DoSomething/phoenix-next/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/phoenix-next/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/phoenix-next/tags","blobs_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/phoenix-next/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/phoenix-next/languages","stargazers_url":"https://api.github.com/repos/DoSomething/phoenix-next/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/phoenix-next/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/phoenix-next/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/phoenix-next/subscription","commits_url":"https://api.github.com/repos/DoSomething/phoenix-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/phoenix-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/phoenix-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/phoenix-next/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/phoenix-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/phoenix-next/merges","archive_url":"https://api.github.com/repos/DoSomething/phoenix-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/phoenix-next/downloads","issues_url":"https://api.github.com/repos/DoSomething/phoenix-next/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/phoenix-next/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/phoenix-next/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/phoenix-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/phoenix-next/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/phoenix-next/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/phoenix-next/deployments","created_at":"2016-12-05T16:08:36Z","updated_at":"2018-02-27T15:24:27Z","pushed_at":"2018-03-02T19:31:01Z","git_url":"git://github.com/DoSomething/phoenix-next.git","ssh_url":"git@github.com:DoSomething/phoenix-next.git","clone_url":"https://github.com/DoSomething/phoenix-next.git","svn_url":"https://github.com/DoSomething/phoenix-next","homepage":"https://next.dosomething.org","size":8166,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":7,"open_issues":18,"watchers":1,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"444aa90a8c8c3f285036613f2f9d8b2606fe4052","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":75642790,"name":"phoenix-next","full_name":"DoSomething/phoenix-next","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/phoenix-next","description":"🔥 The new DoSomething.org campaign template.","fork":false,"url":"https://api.github.com/repos/DoSomething/phoenix-next","forks_url":"https://api.github.com/repos/DoSomething/phoenix-next/forks","keys_url":"https://api.github.com/repos/DoSomething/phoenix-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/phoenix-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/phoenix-next/teams","hooks_url":"https://api.github.com/repos/DoSomething/phoenix-next/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/phoenix-next/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/phoenix-next/events","assignees_url":"https://api.github.com/repos/DoSomething/phoenix-next/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/phoenix-next/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/phoenix-next/tags","blobs_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/phoenix-next/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/phoenix-next/languages","stargazers_url":"https://api.github.com/repos/DoSomething/phoenix-next/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/phoenix-next/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/phoenix-next/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/phoenix-next/subscription","commits_url":"https://api.github.com/repos/DoSomething/phoenix-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/phoenix-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/phoenix-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/phoenix-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/phoenix-next/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/phoenix-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/phoenix-next/merges","archive_url":"https://api.github.com/repos/DoSomething/phoenix-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/phoenix-next/downloads","issues_url":"https://api.github.com/repos/DoSomething/phoenix-next/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/phoenix-next/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/phoenix-next/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/phoenix-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/phoenix-next/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/phoenix-next/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/phoenix-next/deployments","created_at":"2016-12-05T16:08:36Z","updated_at":"2018-02-27T15:24:27Z","pushed_at":"2018-03-02T19:31:01Z","git_url":"git://github.com/DoSomething/phoenix-next.git","ssh_url":"git@github.com:DoSomething/phoenix-next.git","clone_url":"https://github.com/DoSomething/phoenix-next.git","svn_url":"https://github.com/DoSomething/phoenix-next","homepage":"https://next.dosomething.org","size":8166,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":7,"open_issues":18,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/phoenix-next/pulls/721"},"html":{"href":"https://github.com/DoSomething/phoenix-next/pull/721"},"issue":{"href":"https://api.github.com/repos/DoSomething/phoenix-next/issues/721"},"comments":{"href":"https://api.github.com/repos/DoSomething/phoenix-next/issues/721/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/phoenix-next/pulls/721/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/phoenix-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/phoenix-next/pulls/721/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/phoenix-next/statuses/b154398ccb1be3fce6765eb91b177abbf805ed4c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mendelB","id":12417657,"avatar_url":"https://avatars3.githubusercontent.com/u/12417657?v=4","gravatar_id":"","url":"https://api.github.com/users/mendelB","html_url":"https://github.com/mendelB","followers_url":"https://api.github.com/users/mendelB/followers","following_url":"https://api.github.com/users/mendelB/following{/other_user}","gists_url":"https://api.github.com/users/mendelB/gists{/gist_id}","starred_url":"https://api.github.com/users/mendelB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendelB/subscriptions","organizations_url":"https://api.github.com/users/mendelB/orgs","repos_url":"https://api.github.com/users/mendelB/repos","events_url":"https://api.github.com/users/mendelB/events{/privacy}","received_events_url":"https://api.github.com/users/mendelB/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"mendelB"}}