{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/comments/201746917","pull_request_review_id":136306681,"id":201746917,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc0NjkxNw==","diff_hunk":"@@ -0,0 +1,46 @@\n+/*\n+Copyright 2018 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package iommu\n+\n+import (\n+\t\"io/ioutil\"\n+\n+\t\"github.com/golang/glog\"\n+)\n+\n+// Implement FeatureSource interface\n+type Source struct{}\n+\n+func (s Source) Name() string { return \"iommu\" }\n+\n+func (s Source) Discover() ([]string, error) {\n+\tfeatures := []string{}\n+\n+\t// Check if any iommu devices are available\n+\tdevices, err := ioutil.ReadDir(\"/sys/class/iommu/\")\n+\tif err == nil {\n+\t\tif len(devices) > 0 {\n+\t\t\tglog.Errorf(\"Detected %v IOMMU devices\", len(devices))","path":"source/iommu/iommu.go","position":37,"original_position":37,"commit_id":"d1cd9d1dcfde7b7d582161f3e658893f9e9e9c43","original_commit_id":"d1cd9d1dcfde7b7d582161f3e658893f9e9e9c43","user":{"login":"balajismaniam","id":4707353,"node_id":"MDQ6VXNlcjQ3MDczNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4707353?v=4","gravatar_id":"","url":"https://api.github.com/users/balajismaniam","html_url":"https://github.com/balajismaniam","followers_url":"https://api.github.com/users/balajismaniam/followers","following_url":"https://api.github.com/users/balajismaniam/following{/other_user}","gists_url":"https://api.github.com/users/balajismaniam/gists{/gist_id}","starred_url":"https://api.github.com/users/balajismaniam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajismaniam/subscriptions","organizations_url":"https://api.github.com/users/balajismaniam/orgs","repos_url":"https://api.github.com/users/balajismaniam/repos","events_url":"https://api.github.com/users/balajismaniam/events{/privacy}","received_events_url":"https://api.github.com/users/balajismaniam/received_events","type":"User","site_admin":false},"body":"This is not an error. Use `Infof` instead?","created_at":"2018-07-11T15:53:55Z","updated_at":"2018-07-11T15:56:10Z","html_url":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/137#discussion_r201746917","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/137","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/comments/201746917"},"html":{"href":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/137#discussion_r201746917"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/137","id":199461833,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDYxODMz","html_url":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/137","diff_url":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/137.diff","patch_url":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/137.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/137","number":137,"state":"open","locked":false,"title":"Implement detection of IOMMU (#136)","user":{"login":"marquiz","id":1035625,"node_id":"MDQ6VXNlcjEwMzU2MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1035625?v=4","gravatar_id":"","url":"https://api.github.com/users/marquiz","html_url":"https://github.com/marquiz","followers_url":"https://api.github.com/users/marquiz/followers","following_url":"https://api.github.com/users/marquiz/following{/other_user}","gists_url":"https://api.github.com/users/marquiz/gists{/gist_id}","starred_url":"https://api.github.com/users/marquiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marquiz/subscriptions","organizations_url":"https://api.github.com/users/marquiz/orgs","repos_url":"https://api.github.com/users/marquiz/repos","events_url":"https://api.github.com/users/marquiz/events{/privacy}","received_events_url":"https://api.github.com/users/marquiz/received_events","type":"User","site_admin":false},"body":"Add a new feature source, i.e. 'iommu', which detects if an IOMMU is\r\npresent and enabled in the kernel. The new node label is\r\n  node.alpha.kubernetes-incubator.io/nfd-iommu-present\r\n\r\nImplements #136 ","created_at":"2018-07-05T12:58:17Z","updated_at":"2018-07-11T15:56:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43286147a8f60729c5f1f74aa0f1e148d5fefc94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":459636937,"node_id":"MDU6TGFiZWw0NTk2MzY5Mzc=","url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":684971144,"node_id":"MDU6TGFiZWw2ODQ5NzExNDQ=","url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/137/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/137/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/137/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/statuses/d1cd9d1dcfde7b7d582161f3e658893f9e9e9c43","head":{"label":"marquiz:feature/iommu","ref":"feature/iommu","sha":"d1cd9d1dcfde7b7d582161f3e658893f9e9e9c43","user":{"login":"marquiz","id":1035625,"node_id":"MDQ6VXNlcjEwMzU2MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1035625?v=4","gravatar_id":"","url":"https://api.github.com/users/marquiz","html_url":"https://github.com/marquiz","followers_url":"https://api.github.com/users/marquiz/followers","following_url":"https://api.github.com/users/marquiz/following{/other_user}","gists_url":"https://api.github.com/users/marquiz/gists{/gist_id}","starred_url":"https://api.github.com/users/marquiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marquiz/subscriptions","organizations_url":"https://api.github.com/users/marquiz/orgs","repos_url":"https://api.github.com/users/marquiz/repos","events_url":"https://api.github.com/users/marquiz/events{/privacy}","received_events_url":"https://api.github.com/users/marquiz/received_events","type":"User","site_admin":false},"repo":{"id":119821623,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4MjE2MjM=","name":"node-feature-discovery","full_name":"marquiz/node-feature-discovery","owner":{"login":"marquiz","id":1035625,"node_id":"MDQ6VXNlcjEwMzU2MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1035625?v=4","gravatar_id":"","url":"https://api.github.com/users/marquiz","html_url":"https://github.com/marquiz","followers_url":"https://api.github.com/users/marquiz/followers","following_url":"https://api.github.com/users/marquiz/following{/other_user}","gists_url":"https://api.github.com/users/marquiz/gists{/gist_id}","starred_url":"https://api.github.com/users/marquiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marquiz/subscriptions","organizations_url":"https://api.github.com/users/marquiz/orgs","repos_url":"https://api.github.com/users/marquiz/repos","events_url":"https://api.github.com/users/marquiz/events{/privacy}","received_events_url":"https://api.github.com/users/marquiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marquiz/node-feature-discovery","description":"Node feature discovery for Kubernetes","fork":true,"url":"https://api.github.com/repos/marquiz/node-feature-discovery","forks_url":"https://api.github.com/repos/marquiz/node-feature-discovery/forks","keys_url":"https://api.github.com/repos/marquiz/node-feature-discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marquiz/node-feature-discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marquiz/node-feature-discovery/teams","hooks_url":"https://api.github.com/repos/marquiz/node-feature-discovery/hooks","issue_events_url":"https://api.github.com/repos/marquiz/node-feature-discovery/issues/events{/number}","events_url":"https://api.github.com/repos/marquiz/node-feature-discovery/events","assignees_url":"https://api.github.com/repos/marquiz/node-feature-discovery/assignees{/user}","branches_url":"https://api.github.com/repos/marquiz/node-feature-discovery/branches{/branch}","tags_url":"https://api.github.com/repos/marquiz/node-feature-discovery/tags","blobs_url":"https://api.github.com/repos/marquiz/node-feature-discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marquiz/node-feature-discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marquiz/node-feature-discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/marquiz/node-feature-discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marquiz/node-feature-discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/marquiz/node-feature-discovery/languages","stargazers_url":"https://api.github.com/repos/marquiz/node-feature-discovery/stargazers","contributors_url":"https://api.github.com/repos/marquiz/node-feature-discovery/contributors","subscribers_url":"https://api.github.com/repos/marquiz/node-feature-discovery/subscribers","subscription_url":"https://api.github.com/repos/marquiz/node-feature-discovery/subscription","commits_url":"https://api.github.com/repos/marquiz/node-feature-discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/marquiz/node-feature-discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/marquiz/node-feature-discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/marquiz/node-feature-discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/marquiz/node-feature-discovery/contents/{+path}","compare_url":"https://api.github.com/repos/marquiz/node-feature-discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marquiz/node-feature-discovery/merges","archive_url":"https://api.github.com/repos/marquiz/node-feature-discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marquiz/node-feature-discovery/downloads","issues_url":"https://api.github.com/repos/marquiz/node-feature-discovery/issues{/number}","pulls_url":"https://api.github.com/repos/marquiz/node-feature-discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/marquiz/node-feature-discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/marquiz/node-feature-discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marquiz/node-feature-discovery/labels{/name}","releases_url":"https://api.github.com/repos/marquiz/node-feature-discovery/releases{/id}","deployments_url":"https://api.github.com/repos/marquiz/node-feature-discovery/deployments","created_at":"2018-02-01T10:38:58Z","updated_at":"2018-02-01T10:38:59Z","pushed_at":"2018-07-10T13:06:25Z","git_url":"git://github.com/marquiz/node-feature-discovery.git","ssh_url":"git@github.com:marquiz/node-feature-discovery.git","clone_url":"https://github.com/marquiz/node-feature-discovery.git","svn_url":"https://github.com/marquiz/node-feature-discovery","homepage":"","size":74721,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"4f4b0867b9c4d8cc8eaf61e918827ca36c0f5a91","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":63999998,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzk5OTk5OA==","name":"node-feature-discovery","full_name":"kubernetes-incubator/node-feature-discovery","owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/node-feature-discovery","description":"Node feature discovery for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery","forks_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/deployments","created_at":"2016-07-23T05:07:52Z","updated_at":"2018-07-09T12:02:47Z","pushed_at":"2018-07-09T12:34:11Z","git_url":"git://github.com/kubernetes-incubator/node-feature-discovery.git","ssh_url":"git@github.com:kubernetes-incubator/node-feature-discovery.git","clone_url":"https://github.com/kubernetes-incubator/node-feature-discovery.git","svn_url":"https://github.com/kubernetes-incubator/node-feature-discovery","homepage":"","size":74429,"stargazers_count":81,"watchers_count":81,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":34,"open_issues":31,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/137"},"html":{"href":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/137"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/137"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/statuses/d1cd9d1dcfde7b7d582161f3e658893f9e9e9c43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"balajismaniam"}}