{"action":"created","issue":{"url":"https://api.github.com/repos/schibsted/account-sdk-browser/issues/90","repository_url":"https://api.github.com/repos/schibsted/account-sdk-browser","labels_url":"https://api.github.com/repos/schibsted/account-sdk-browser/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/schibsted/account-sdk-browser/issues/90/comments","events_url":"https://api.github.com/repos/schibsted/account-sdk-browser/issues/90/events","html_url":"https://github.com/schibsted/account-sdk-browser/pull/90","id":362044624,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODY0MjY0","number":90,"title":"Add locale param to login","user":{"login":"marjuszkiewicz","id":3206140,"node_id":"MDQ6VXNlcjMyMDYxNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3206140?v=4","gravatar_id":"","url":"https://api.github.com/users/marjuszkiewicz","html_url":"https://github.com/marjuszkiewicz","followers_url":"https://api.github.com/users/marjuszkiewicz/followers","following_url":"https://api.github.com/users/marjuszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/marjuszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/marjuszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marjuszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/marjuszkiewicz/orgs","repos_url":"https://api.github.com/users/marjuszkiewicz/repos","events_url":"https://api.github.com/users/marjuszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/marjuszkiewicz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-20T07:01:25Z","updated_at":"2018-09-20T08:16:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/schibsted/account-sdk-browser/pulls/90","html_url":"https://github.com/schibsted/account-sdk-browser/pull/90","diff_url":"https://github.com/schibsted/account-sdk-browser/pull/90.diff","patch_url":"https://github.com/schibsted/account-sdk-browser/pull/90.patch"},"body":"The most important change is https://github.com/schibsted/account-sdk-browser/compare/add-locale-param-to-login?expand=1#diff-b8139375bef5ea9da4706270fef9c716R183 . I believe that it shouldn't have big influence since it will skip only empty string query params."},"comment":{"url":"https://api.github.com/repos/schibsted/account-sdk-browser/issues/comments/423087549","html_url":"https://github.com/schibsted/account-sdk-browser/pull/90#issuecomment-423087549","issue_url":"https://api.github.com/repos/schibsted/account-sdk-browser/issues/90","id":423087549,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzA4NzU0OQ==","user":{"login":"torarvid","id":439758,"node_id":"MDQ6VXNlcjQzOTc1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/439758?v=4","gravatar_id":"","url":"https://api.github.com/users/torarvid","html_url":"https://github.com/torarvid","followers_url":"https://api.github.com/users/torarvid/followers","following_url":"https://api.github.com/users/torarvid/following{/other_user}","gists_url":"https://api.github.com/users/torarvid/gists{/gist_id}","starred_url":"https://api.github.com/users/torarvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torarvid/subscriptions","organizations_url":"https://api.github.com/users/torarvid/orgs","repos_url":"https://api.github.com/users/torarvid/repos","events_url":"https://api.github.com/users/torarvid/events{/privacy}","received_events_url":"https://api.github.com/users/torarvid/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T08:16:42Z","updated_at":"2018-09-20T08:16:42Z","author_association":"CONTRIBUTOR","body":"Sure, just saying the links generated by payment.js go to the BFF, and so they will direct the user to a BFF login flow before jumping onto the payment part. Feels like \"whenever new payment flows go live\" can be controlled on the backend with (possibly) no JS SDK changes?\r\n\r\nAnyway, feel free to merge this PR when/if you want to 👍 "}}
{"actor":{"display_login":"torarvid"}}