{"action":"created","issue":{"url":"https://api.github.com/repos/dotandimet/Mojolicious-Plugin-FeedReader/issues/3","repository_url":"https://api.github.com/repos/dotandimet/Mojolicious-Plugin-FeedReader","labels_url":"https://api.github.com/repos/dotandimet/Mojolicious-Plugin-FeedReader/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/dotandimet/Mojolicious-Plugin-FeedReader/issues/3/comments","events_url":"https://api.github.com/repos/dotandimet/Mojolicious-Plugin-FeedReader/issues/3/events","html_url":"https://github.com/dotandimet/Mojolicious-Plugin-FeedReader/pull/3","id":299970087,"number":3,"title":"Remove dependency on Mojolicious::Controller","user":{"login":"mdom","id":62118,"avatar_url":"https://avatars1.githubusercontent.com/u/62118?v=4","gravatar_id":"","url":"https://api.github.com/users/mdom","html_url":"https://github.com/mdom","followers_url":"https://api.github.com/users/mdom/followers","following_url":"https://api.github.com/users/mdom/following{/other_user}","gists_url":"https://api.github.com/users/mdom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdom/subscriptions","organizations_url":"https://api.github.com/users/mdom/orgs","repos_url":"https://api.github.com/users/mdom/repos","events_url":"https://api.github.com/users/mdom/events{/privacy}","received_events_url":"https://api.github.com/users/mdom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-24T20:26:46Z","updated_at":"2018-02-25T21:30:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dotandimet/Mojolicious-Plugin-FeedReader/pulls/3","html_url":"https://github.com/dotandimet/Mojolicious-Plugin-FeedReader/pull/3","diff_url":"https://github.com/dotandimet/Mojolicious-Plugin-FeedReader/pull/3.diff","patch_url":"https://github.com/dotandimet/Mojolicious-Plugin-FeedReader/pull/3.patch"},"body":"Hi! First i really want to thank you for this project, a feed reader based on Mojo::DOM was a long time item on my todo list and it's great to see that someone else has already done the work! :) Mojolicious::Plugin::FeedReader does an amazing job, but on my last project i had a little problem: This is the first time i don't want to use the module with Mojolicious but in a little command line app. Unfortunately the code depends on being called as helper from Mojolicious::Controller. \r\n\r\nThis commit removes this dependency, but there is a catch: The callback parse_rss() isn't called with the controller as first argument. It's now called like in find_feeds(). I haven't found a better way to do this. I'm not happy about this chance, but i haven't found a better way to solve that.\r\n\r\nCheers, Mario"},"comment":{"url":"https://api.github.com/repos/dotandimet/Mojolicious-Plugin-FeedReader/issues/comments/368346477","html_url":"https://github.com/dotandimet/Mojolicious-Plugin-FeedReader/pull/3#issuecomment-368346477","issue_url":"https://api.github.com/repos/dotandimet/Mojolicious-Plugin-FeedReader/issues/3","id":368346477,"user":{"login":"mdom","id":62118,"avatar_url":"https://avatars1.githubusercontent.com/u/62118?v=4","gravatar_id":"","url":"https://api.github.com/users/mdom","html_url":"https://github.com/mdom","followers_url":"https://api.github.com/users/mdom/followers","following_url":"https://api.github.com/users/mdom/following{/other_user}","gists_url":"https://api.github.com/users/mdom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdom/subscriptions","organizations_url":"https://api.github.com/users/mdom/orgs","repos_url":"https://api.github.com/users/mdom/repos","events_url":"https://api.github.com/users/mdom/events{/privacy}","received_events_url":"https://api.github.com/users/mdom/received_events","type":"User","site_admin":false},"created_at":"2018-02-25T21:30:36Z","updated_at":"2018-02-25T21:30:36Z","author_association":"NONE","body":"On Sat, Feb 24, 2018 at 10:15:02PM +0000, Dotan Dimet wrote:\n> In any case, could you help me write a test for your use case? A simple test of using FeedReader in a standalone form? \n\nYeah, sure i do that, should have done that from the start. It could\njust take me a few days, sorry for the delay. Coding time is rare! :)\n"}}
{"actor":{"display_login":"mdom"}}