{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls/1","id":174423103,"html_url":"https://github.com/YanDoroshenko/creativedock/pull/1","diff_url":"https://github.com/YanDoroshenko/creativedock/pull/1.diff","patch_url":"https://github.com/YanDoroshenko/creativedock/pull/1.patch","issue_url":"https://api.github.com/repos/YanDoroshenko/creativedock/issues/1","number":1,"state":"open","locked":false,"title":"feedback comments","user":{"login":"jancajthaml","id":2333883,"avatar_url":"https://avatars1.githubusercontent.com/u/2333883?v=4","gravatar_id":"","url":"https://api.github.com/users/jancajthaml","html_url":"https://github.com/jancajthaml","followers_url":"https://api.github.com/users/jancajthaml/followers","following_url":"https://api.github.com/users/jancajthaml/following{/other_user}","gists_url":"https://api.github.com/users/jancajthaml/gists{/gist_id}","starred_url":"https://api.github.com/users/jancajthaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancajthaml/subscriptions","organizations_url":"https://api.github.com/users/jancajthaml/orgs","repos_url":"https://api.github.com/users/jancajthaml/repos","events_url":"https://api.github.com/users/jancajthaml/events{/privacy}","received_events_url":"https://api.github.com/users/jancajthaml/received_events","type":"User","site_admin":false},"body":"pros:\r\n- simple and clean (like it)\r\n- usage of streams\r\n- usage of cats\r\n\r\ncons:\r\n- no tests (major failure)\r\n- unable to run `sbt run` crashes immediately (log attached in `FEEDBACK_SBT_RUN.log`)\r\n- wrong use of kafka as a queue (long description below)\r\n- eventually consistent forwarder instead of CRUD service\r\n- no application.conf, variables hardcoded\r\n- .asJava -> .asScala -> .asJava unnecessary value copying\r\n- wrong usage of http codes, uses 200 OK instead 201 ACCEPTED \r\n\r\nunknowns:\r\n- no secured connection (no certificates, no enforcing cyphers, not even sure if using https and not http connection)\r\n- coordinated graceful shutdown (if application is killed with SIGTERM will it flush all messages PUT into kafka or will it just stop and drop data that it holds in memory?)\r\n\r\n----\r\n\r\nKafka is a heavy framework that is used for cases when you need to have acknowledgment about delivery of event, this is one of the differentiator of this framework and one of reasons why it is so heavy compared to e.g. ZMQ, nanomsg, etc. so leaving this out from assignment and treating it as accepted request with no control about actual deliverance and eventual consistency is simplifying the assignment. 200ms Pooling is not enough, polling should be event based not time based (simple bbtest that would PUT message to group and GET it within 120ns delay (curl e.g.) would break the REST contract.\r\n","created_at":"2018-03-12T16:28:15Z","updated_at":"2018-03-12T16:28:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92ea0a2fb1eafef0e9a28825940852ae946a5f7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls/1/commits","review_comments_url":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls/1/comments","review_comment_url":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YanDoroshenko/creativedock/issues/1/comments","statuses_url":"https://api.github.com/repos/YanDoroshenko/creativedock/statuses/aadadaa5e1bd920a559a8066945e25e726af4c84","head":{"label":"jancajthaml:feature/pr","ref":"feature/pr","sha":"aadadaa5e1bd920a559a8066945e25e726af4c84","user":{"login":"jancajthaml","id":2333883,"avatar_url":"https://avatars1.githubusercontent.com/u/2333883?v=4","gravatar_id":"","url":"https://api.github.com/users/jancajthaml","html_url":"https://github.com/jancajthaml","followers_url":"https://api.github.com/users/jancajthaml/followers","following_url":"https://api.github.com/users/jancajthaml/following{/other_user}","gists_url":"https://api.github.com/users/jancajthaml/gists{/gist_id}","starred_url":"https://api.github.com/users/jancajthaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancajthaml/subscriptions","organizations_url":"https://api.github.com/users/jancajthaml/orgs","repos_url":"https://api.github.com/users/jancajthaml/repos","events_url":"https://api.github.com/users/jancajthaml/events{/privacy}","received_events_url":"https://api.github.com/users/jancajthaml/received_events","type":"User","site_admin":false},"repo":{"id":124913896,"name":"creativedock","full_name":"jancajthaml/creativedock","owner":{"login":"jancajthaml","id":2333883,"avatar_url":"https://avatars1.githubusercontent.com/u/2333883?v=4","gravatar_id":"","url":"https://api.github.com/users/jancajthaml","html_url":"https://github.com/jancajthaml","followers_url":"https://api.github.com/users/jancajthaml/followers","following_url":"https://api.github.com/users/jancajthaml/following{/other_user}","gists_url":"https://api.github.com/users/jancajthaml/gists{/gist_id}","starred_url":"https://api.github.com/users/jancajthaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancajthaml/subscriptions","organizations_url":"https://api.github.com/users/jancajthaml/orgs","repos_url":"https://api.github.com/users/jancajthaml/repos","events_url":"https://api.github.com/users/jancajthaml/events{/privacy}","received_events_url":"https://api.github.com/users/jancajthaml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jancajthaml/creativedock","description":"Simple REST + Apache Kafka CRUD application","fork":true,"url":"https://api.github.com/repos/jancajthaml/creativedock","forks_url":"https://api.github.com/repos/jancajthaml/creativedock/forks","keys_url":"https://api.github.com/repos/jancajthaml/creativedock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jancajthaml/creativedock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jancajthaml/creativedock/teams","hooks_url":"https://api.github.com/repos/jancajthaml/creativedock/hooks","issue_events_url":"https://api.github.com/repos/jancajthaml/creativedock/issues/events{/number}","events_url":"https://api.github.com/repos/jancajthaml/creativedock/events","assignees_url":"https://api.github.com/repos/jancajthaml/creativedock/assignees{/user}","branches_url":"https://api.github.com/repos/jancajthaml/creativedock/branches{/branch}","tags_url":"https://api.github.com/repos/jancajthaml/creativedock/tags","blobs_url":"https://api.github.com/repos/jancajthaml/creativedock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jancajthaml/creativedock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jancajthaml/creativedock/git/refs{/sha}","trees_url":"https://api.github.com/repos/jancajthaml/creativedock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jancajthaml/creativedock/statuses/{sha}","languages_url":"https://api.github.com/repos/jancajthaml/creativedock/languages","stargazers_url":"https://api.github.com/repos/jancajthaml/creativedock/stargazers","contributors_url":"https://api.github.com/repos/jancajthaml/creativedock/contributors","subscribers_url":"https://api.github.com/repos/jancajthaml/creativedock/subscribers","subscription_url":"https://api.github.com/repos/jancajthaml/creativedock/subscription","commits_url":"https://api.github.com/repos/jancajthaml/creativedock/commits{/sha}","git_commits_url":"https://api.github.com/repos/jancajthaml/creativedock/git/commits{/sha}","comments_url":"https://api.github.com/repos/jancajthaml/creativedock/comments{/number}","issue_comment_url":"https://api.github.com/repos/jancajthaml/creativedock/issues/comments{/number}","contents_url":"https://api.github.com/repos/jancajthaml/creativedock/contents/{+path}","compare_url":"https://api.github.com/repos/jancajthaml/creativedock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jancajthaml/creativedock/merges","archive_url":"https://api.github.com/repos/jancajthaml/creativedock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jancajthaml/creativedock/downloads","issues_url":"https://api.github.com/repos/jancajthaml/creativedock/issues{/number}","pulls_url":"https://api.github.com/repos/jancajthaml/creativedock/pulls{/number}","milestones_url":"https://api.github.com/repos/jancajthaml/creativedock/milestones{/number}","notifications_url":"https://api.github.com/repos/jancajthaml/creativedock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jancajthaml/creativedock/labels{/name}","releases_url":"https://api.github.com/repos/jancajthaml/creativedock/releases{/id}","deployments_url":"https://api.github.com/repos/jancajthaml/creativedock/deployments","created_at":"2018-03-12T15:52:57Z","updated_at":"2018-03-12T15:52:59Z","pushed_at":"2018-03-12T16:18:09Z","git_url":"git://github.com/jancajthaml/creativedock.git","ssh_url":"git@github.com:jancajthaml/creativedock.git","clone_url":"https://github.com/jancajthaml/creativedock.git","svn_url":"https://github.com/jancajthaml/creativedock","homepage":"","size":40,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"YanDoroshenko:master","ref":"master","sha":"79094083db750e9e2a36f2fa4c336780ff2619b2","user":{"login":"YanDoroshenko","id":13915536,"avatar_url":"https://avatars2.githubusercontent.com/u/13915536?v=4","gravatar_id":"","url":"https://api.github.com/users/YanDoroshenko","html_url":"https://github.com/YanDoroshenko","followers_url":"https://api.github.com/users/YanDoroshenko/followers","following_url":"https://api.github.com/users/YanDoroshenko/following{/other_user}","gists_url":"https://api.github.com/users/YanDoroshenko/gists{/gist_id}","starred_url":"https://api.github.com/users/YanDoroshenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanDoroshenko/subscriptions","organizations_url":"https://api.github.com/users/YanDoroshenko/orgs","repos_url":"https://api.github.com/users/YanDoroshenko/repos","events_url":"https://api.github.com/users/YanDoroshenko/events{/privacy}","received_events_url":"https://api.github.com/users/YanDoroshenko/received_events","type":"User","site_admin":false},"repo":{"id":124457133,"name":"creativedock","full_name":"YanDoroshenko/creativedock","owner":{"login":"YanDoroshenko","id":13915536,"avatar_url":"https://avatars2.githubusercontent.com/u/13915536?v=4","gravatar_id":"","url":"https://api.github.com/users/YanDoroshenko","html_url":"https://github.com/YanDoroshenko","followers_url":"https://api.github.com/users/YanDoroshenko/followers","following_url":"https://api.github.com/users/YanDoroshenko/following{/other_user}","gists_url":"https://api.github.com/users/YanDoroshenko/gists{/gist_id}","starred_url":"https://api.github.com/users/YanDoroshenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanDoroshenko/subscriptions","organizations_url":"https://api.github.com/users/YanDoroshenko/orgs","repos_url":"https://api.github.com/users/YanDoroshenko/repos","events_url":"https://api.github.com/users/YanDoroshenko/events{/privacy}","received_events_url":"https://api.github.com/users/YanDoroshenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YanDoroshenko/creativedock","description":"Simple REST + Apache Kafka CRUD application","fork":false,"url":"https://api.github.com/repos/YanDoroshenko/creativedock","forks_url":"https://api.github.com/repos/YanDoroshenko/creativedock/forks","keys_url":"https://api.github.com/repos/YanDoroshenko/creativedock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YanDoroshenko/creativedock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YanDoroshenko/creativedock/teams","hooks_url":"https://api.github.com/repos/YanDoroshenko/creativedock/hooks","issue_events_url":"https://api.github.com/repos/YanDoroshenko/creativedock/issues/events{/number}","events_url":"https://api.github.com/repos/YanDoroshenko/creativedock/events","assignees_url":"https://api.github.com/repos/YanDoroshenko/creativedock/assignees{/user}","branches_url":"https://api.github.com/repos/YanDoroshenko/creativedock/branches{/branch}","tags_url":"https://api.github.com/repos/YanDoroshenko/creativedock/tags","blobs_url":"https://api.github.com/repos/YanDoroshenko/creativedock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YanDoroshenko/creativedock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YanDoroshenko/creativedock/git/refs{/sha}","trees_url":"https://api.github.com/repos/YanDoroshenko/creativedock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YanDoroshenko/creativedock/statuses/{sha}","languages_url":"https://api.github.com/repos/YanDoroshenko/creativedock/languages","stargazers_url":"https://api.github.com/repos/YanDoroshenko/creativedock/stargazers","contributors_url":"https://api.github.com/repos/YanDoroshenko/creativedock/contributors","subscribers_url":"https://api.github.com/repos/YanDoroshenko/creativedock/subscribers","subscription_url":"https://api.github.com/repos/YanDoroshenko/creativedock/subscription","commits_url":"https://api.github.com/repos/YanDoroshenko/creativedock/commits{/sha}","git_commits_url":"https://api.github.com/repos/YanDoroshenko/creativedock/git/commits{/sha}","comments_url":"https://api.github.com/repos/YanDoroshenko/creativedock/comments{/number}","issue_comment_url":"https://api.github.com/repos/YanDoroshenko/creativedock/issues/comments{/number}","contents_url":"https://api.github.com/repos/YanDoroshenko/creativedock/contents/{+path}","compare_url":"https://api.github.com/repos/YanDoroshenko/creativedock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YanDoroshenko/creativedock/merges","archive_url":"https://api.github.com/repos/YanDoroshenko/creativedock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YanDoroshenko/creativedock/downloads","issues_url":"https://api.github.com/repos/YanDoroshenko/creativedock/issues{/number}","pulls_url":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls{/number}","milestones_url":"https://api.github.com/repos/YanDoroshenko/creativedock/milestones{/number}","notifications_url":"https://api.github.com/repos/YanDoroshenko/creativedock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YanDoroshenko/creativedock/labels{/name}","releases_url":"https://api.github.com/repos/YanDoroshenko/creativedock/releases{/id}","deployments_url":"https://api.github.com/repos/YanDoroshenko/creativedock/deployments","created_at":"2018-03-08T22:44:39Z","updated_at":"2018-03-11T16:16:09Z","pushed_at":"2018-03-12T16:28:16Z","git_url":"git://github.com/YanDoroshenko/creativedock.git","ssh_url":"git@github.com:YanDoroshenko/creativedock.git","clone_url":"https://github.com/YanDoroshenko/creativedock.git","svn_url":"https://github.com/YanDoroshenko/creativedock","homepage":"","size":40,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls/1"},"html":{"href":"https://github.com/YanDoroshenko/creativedock/pull/1"},"issue":{"href":"https://api.github.com/repos/YanDoroshenko/creativedock/issues/1"},"comments":{"href":"https://api.github.com/repos/YanDoroshenko/creativedock/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YanDoroshenko/creativedock/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/YanDoroshenko/creativedock/statuses/aadadaa5e1bd920a559a8066945e25e726af4c84"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":281,"deletions":11,"changed_files":6}}
{"actor":{"display_login":"jancajthaml"}}