{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/244772110","pull_request_review_id":188724335,"id":244772110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDc3MjExMA==","diff_hunk":"@@ -48,15 +82,6 @@ def run(test, params, env):\n     if guest_ip is None:\n         test.error(\"Could not get the guest ip address\")\n \n-    def get_ovs_ports(ovs):\n-        '''\n-        get the ovs bridge all Interface list.\n-\n-        :param ovs: Ovs bridge name\n-        '''\n-        cmd = \"ovs-vsctl list-ports %s\" % ovs\n-        return set(process.system_output(cmd, shell=True).splitlines())\n-\n     host_mtu_cmd = \"ifconfig %s mtu %s\"\n     netdst = params.get(\"netdst\", \"switch\")\n     host_bridges = utils_net.Bridge()","path":"generic/tests/jumbo.py","position":68,"original_position":68,"commit_id":"1a57e407d8d30478a4accf7b9dcebd3efeabb24b","original_commit_id":"1a57e407d8d30478a4accf7b9dcebd3efeabb24b","user":{"login":"PaulYuuu","id":24449429,"node_id":"MDQ6VXNlcjI0NDQ5NDI5","avatar_url":"https://avatars1.githubusercontent.com/u/24449429?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulYuuu","html_url":"https://github.com/PaulYuuu","followers_url":"https://api.github.com/users/PaulYuuu/followers","following_url":"https://api.github.com/users/PaulYuuu/following{/other_user}","gists_url":"https://api.github.com/users/PaulYuuu/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulYuuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulYuuu/subscriptions","organizations_url":"https://api.github.com/users/PaulYuuu/orgs","repos_url":"https://api.github.com/users/PaulYuuu/repos","events_url":"https://api.github.com/users/PaulYuuu/events{/privacy}","received_events_url":"https://api.github.com/users/PaulYuuu/received_events","type":"User","site_admin":false},"body":"I think use `host_bridges  = utils_net.find_bridge_manager(\"netdst\")` maybe better?\r\nThen you can get the bridge backend but not need to define a new function.","created_at":"2019-01-02T15:51:13Z","updated_at":"2019-01-02T15:51:37Z","html_url":"https://github.com/autotest/tp-qemu/pull/1611#discussion_r244772110","pull_request_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1611","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/244772110"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/1611#discussion_r244772110"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1611"}}},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1611","id":240851115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODUxMTE1","html_url":"https://github.com/autotest/tp-qemu/pull/1611","diff_url":"https://github.com/autotest/tp-qemu/pull/1611.diff","patch_url":"https://github.com/autotest/tp-qemu/pull/1611.patch","issue_url":"https://api.github.com/repos/autotest/tp-qemu/issues/1611","number":1611,"state":"open","locked":false,"title":"jumbo: remove redundant ports in ovs bridge and fix python3 issue","user":{"login":"xiywang","id":22315657,"node_id":"MDQ6VXNlcjIyMzE1NjU3","avatar_url":"https://avatars3.githubusercontent.com/u/22315657?v=4","gravatar_id":"","url":"https://api.github.com/users/xiywang","html_url":"https://github.com/xiywang","followers_url":"https://api.github.com/users/xiywang/followers","following_url":"https://api.github.com/users/xiywang/following{/other_user}","gists_url":"https://api.github.com/users/xiywang/gists{/gist_id}","starred_url":"https://api.github.com/users/xiywang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiywang/subscriptions","organizations_url":"https://api.github.com/users/xiywang/orgs","repos_url":"https://api.github.com/users/xiywang/repos","events_url":"https://api.github.com/users/xiywang/events{/privacy}","received_events_url":"https://api.github.com/users/xiywang/received_events","type":"User","site_admin":false},"body":"id: 1571613\r\n\r\n1. some case does not clean ovs ports after finished, this case\r\nwill error because of trying to set mtu to all the ports in ovs\r\nbridge but some of the ports are invalid.\r\n2. fix python3 compatibale issue\r\n\r\nSigned-off-by: Xiyue Wang <xiywang@redhat.com>","created_at":"2018-12-25T08:49:46Z","updated_at":"2019-01-02T15:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c5599ab122bcc903fba7c239e5395382719d1e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1611/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1611/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/issues/1611/comments","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/1a57e407d8d30478a4accf7b9dcebd3efeabb24b","head":{"label":"xiywang:jumbo_ovs_python3","ref":"jumbo_ovs_python3","sha":"1a57e407d8d30478a4accf7b9dcebd3efeabb24b","user":{"login":"xiywang","id":22315657,"node_id":"MDQ6VXNlcjIyMzE1NjU3","avatar_url":"https://avatars3.githubusercontent.com/u/22315657?v=4","gravatar_id":"","url":"https://api.github.com/users/xiywang","html_url":"https://github.com/xiywang","followers_url":"https://api.github.com/users/xiywang/followers","following_url":"https://api.github.com/users/xiywang/following{/other_user}","gists_url":"https://api.github.com/users/xiywang/gists{/gist_id}","starred_url":"https://api.github.com/users/xiywang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiywang/subscriptions","organizations_url":"https://api.github.com/users/xiywang/orgs","repos_url":"https://api.github.com/users/xiywang/repos","events_url":"https://api.github.com/users/xiywang/events{/privacy}","received_events_url":"https://api.github.com/users/xiywang/received_events","type":"User","site_admin":false},"repo":{"id":69521066,"node_id":"MDEwOlJlcG9zaXRvcnk2OTUyMTA2Ng==","name":"tp-qemu","full_name":"xiywang/tp-qemu","private":false,"owner":{"login":"xiywang","id":22315657,"node_id":"MDQ6VXNlcjIyMzE1NjU3","avatar_url":"https://avatars3.githubusercontent.com/u/22315657?v=4","gravatar_id":"","url":"https://api.github.com/users/xiywang","html_url":"https://github.com/xiywang","followers_url":"https://api.github.com/users/xiywang/followers","following_url":"https://api.github.com/users/xiywang/following{/other_user}","gists_url":"https://api.github.com/users/xiywang/gists{/gist_id}","starred_url":"https://api.github.com/users/xiywang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiywang/subscriptions","organizations_url":"https://api.github.com/users/xiywang/orgs","repos_url":"https://api.github.com/users/xiywang/repos","events_url":"https://api.github.com/users/xiywang/events{/privacy}","received_events_url":"https://api.github.com/users/xiywang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xiywang/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":true,"url":"https://api.github.com/repos/xiywang/tp-qemu","forks_url":"https://api.github.com/repos/xiywang/tp-qemu/forks","keys_url":"https://api.github.com/repos/xiywang/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiywang/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiywang/tp-qemu/teams","hooks_url":"https://api.github.com/repos/xiywang/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/xiywang/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/xiywang/tp-qemu/events","assignees_url":"https://api.github.com/repos/xiywang/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/xiywang/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/xiywang/tp-qemu/tags","blobs_url":"https://api.github.com/repos/xiywang/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiywang/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiywang/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiywang/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiywang/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/xiywang/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/xiywang/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/xiywang/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/xiywang/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/xiywang/tp-qemu/subscription","commits_url":"https://api.github.com/repos/xiywang/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiywang/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiywang/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiywang/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiywang/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/xiywang/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiywang/tp-qemu/merges","archive_url":"https://api.github.com/repos/xiywang/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiywang/tp-qemu/downloads","issues_url":"https://api.github.com/repos/xiywang/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/xiywang/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/xiywang/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/xiywang/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiywang/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/xiywang/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/xiywang/tp-qemu/deployments","created_at":"2016-09-29T02:05:08Z","updated_at":"2018-12-27T09:31:28Z","pushed_at":"2018-12-28T07:44:14Z","git_url":"git://github.com/xiywang/tp-qemu.git","ssh_url":"git@github.com:xiywang/tp-qemu.git","clone_url":"https://github.com/xiywang/tp-qemu.git","svn_url":"https://github.com/xiywang/tp-qemu","homepage":null,"size":35621,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"105bfd0de976ac304c606a8a48d3bd5bd5073991","user":{"login":"autotest","id":472856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180304,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE4MDMwNA==","name":"tp-qemu","full_name":"autotest/tp-qemu","private":false,"owner":{"login":"autotest","id":472856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/autotest/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-qemu","forks_url":"https://api.github.com/repos/autotest/tp-qemu/forks","keys_url":"https://api.github.com/repos/autotest/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-qemu/teams","hooks_url":"https://api.github.com/repos/autotest/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-qemu/events","assignees_url":"https://api.github.com/repos/autotest/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-qemu/tags","blobs_url":"https://api.github.com/repos/autotest/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-qemu/subscription","commits_url":"https://api.github.com/repos/autotest/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-qemu/merges","archive_url":"https://api.github.com/repos/autotest/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-qemu/downloads","issues_url":"https://api.github.com/repos/autotest/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/tp-qemu/deployments","created_at":"2014-01-23T17:51:34Z","updated_at":"2019-01-02T10:02:04Z","pushed_at":"2019-01-02T10:01:56Z","git_url":"git://github.com/autotest/tp-qemu.git","ssh_url":"git@github.com:autotest/tp-qemu.git","clone_url":"https://github.com/autotest/tp-qemu.git","svn_url":"https://github.com/autotest/tp-qemu","homepage":null,"size":35653,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":124,"open_issues":61,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1611"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/1611"},"issue":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/1611"},"comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/1611/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1611/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1611/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-qemu/statuses/1a57e407d8d30478a4accf7b9dcebd3efeabb24b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PaulYuuu"}}