{"action":"created","issue":{"url":"https://api.github.com/repos/cdk/cdk/issues/433","repository_url":"https://api.github.com/repos/cdk/cdk","labels_url":"https://api.github.com/repos/cdk/cdk/issues/433/labels{/name}","comments_url":"https://api.github.com/repos/cdk/cdk/issues/433/comments","events_url":"https://api.github.com/repos/cdk/cdk/issues/433/events","html_url":"https://github.com/cdk/cdk/pull/433","id":303768127,"number":433,"title":"Implementing output of EPS (and also PS) vector formats.","user":{"login":"sauliusg","id":10668420,"avatar_url":"https://avatars3.githubusercontent.com/u/10668420?v=4","gravatar_id":"","url":"https://api.github.com/users/sauliusg","html_url":"https://github.com/sauliusg","followers_url":"https://api.github.com/users/sauliusg/followers","following_url":"https://api.github.com/users/sauliusg/following{/other_user}","gists_url":"https://api.github.com/users/sauliusg/gists{/gist_id}","starred_url":"https://api.github.com/users/sauliusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauliusg/subscriptions","organizations_url":"https://api.github.com/users/sauliusg/orgs","repos_url":"https://api.github.com/users/sauliusg/repos","events_url":"https://api.github.com/users/sauliusg/events{/privacy}","received_events_url":"https://api.github.com/users/sauliusg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-03-09T08:57:20Z","updated_at":"2018-03-11T09:58:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cdk/cdk/pulls/433","html_url":"https://github.com/cdk/cdk/pull/433","diff_url":"https://github.com/cdk/cdk/pull/433.diff","patch_url":"https://github.com/cdk/cdk/pull/433.patch"},"body":"As of current CDK tip, requesting PS output from Depiction (toEpsStr()) would trigger exception, which is confusing since PS is listed among supported format.\r\nThis PR implements output in PostScript (PS) and Encapsulated PostScript (EPS) formats; EPS output contains %%BoundingBox: as required by EPS specification. Such files are handy when including into larger documents, e.g. into LaTeX (PS workflow) generated files."},"comment":{"url":"https://api.github.com/repos/cdk/cdk/issues/comments/372103055","html_url":"https://github.com/cdk/cdk/pull/433#issuecomment-372103055","issue_url":"https://api.github.com/repos/cdk/cdk/issues/433","id":372103055,"user":{"login":"sauliusg","id":10668420,"avatar_url":"https://avatars3.githubusercontent.com/u/10668420?v=4","gravatar_id":"","url":"https://api.github.com/users/sauliusg","html_url":"https://github.com/sauliusg","followers_url":"https://api.github.com/users/sauliusg/followers","following_url":"https://api.github.com/users/sauliusg/following{/other_user}","gists_url":"https://api.github.com/users/sauliusg/gists{/gist_id}","starred_url":"https://api.github.com/users/sauliusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauliusg/subscriptions","organizations_url":"https://api.github.com/users/sauliusg/orgs","repos_url":"https://api.github.com/users/sauliusg/repos","events_url":"https://api.github.com/users/sauliusg/events{/privacy}","received_events_url":"https://api.github.com/users/sauliusg/received_events","type":"User","site_admin":false},"created_at":"2018-03-11T09:58:10Z","updated_at":"2018-03-11T09:58:10Z","author_association":"CONTRIBUTOR","body":"> Step 1) - Add your citations to this BIBX file in a different project (cdk-build-util): https://github.com/cdk/cdk-build-util/blob/master/src/main/resources/net/sf/cdk/tools/doclets/cheminf.bibx. Also we manually keep this in sync with the cheminf.bibx in the main project.\r\nStep 2) - Now use the key you gave it in the BIBX file in an inline tag.\r\n\r\nI've updated the references, but still not sure if this is how you do them in CDK.\r\n\r\nIFAIU, the @cdk.cite tag works only in JavaDoc comments. You requested them at the beginning of the class. So I added them there.\r\n\r\nHowever, I feel appropriate to cite the references right next to the code that implements them. So I left the original comments in-line, with the custom reference designators.\r\n\r\nOr should I use {@cdk.cite} in the body of the method as well? Will they work in line comments ('//...')? Or should I change these comments to block ('/** ... */')? Will JavaDoc correctly find them inside the body of the method, or should I move them to the beginning of the method? Or to the beginning of the class?\r\n\r\nYour help is greatly appreciated here.\r\n\r\nRegards,\r\nSaulius"}}
{"actor":{"display_login":"sauliusg"}}