{"action":"created","issue":{"url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/289","repository_url":"https://api.github.com/repos/flowtype/flow-for-vscode","labels_url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/289/labels{/name}","comments_url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/289/comments","events_url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/289/events","html_url":"https://github.com/flowtype/flow-for-vscode/issues/289","id":379029876,"node_id":"MDU6SXNzdWUzNzkwMjk4NzY=","number":289,"title":"It only works before save","user":{"login":"rico345100","id":10347098,"node_id":"MDQ6VXNlcjEwMzQ3MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/10347098?v=4","gravatar_id":"","url":"https://api.github.com/users/rico345100","html_url":"https://github.com/rico345100","followers_url":"https://api.github.com/users/rico345100/followers","following_url":"https://api.github.com/users/rico345100/following{/other_user}","gists_url":"https://api.github.com/users/rico345100/gists{/gist_id}","starred_url":"https://api.github.com/users/rico345100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rico345100/subscriptions","organizations_url":"https://api.github.com/users/rico345100/orgs","repos_url":"https://api.github.com/users/rico345100/repos","events_url":"https://api.github.com/users/rico345100/events{/privacy}","received_events_url":"https://api.github.com/users/rico345100/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-09T05:38:05Z","updated_at":"2018-11-16T08:32:57Z","closed_at":null,"author_association":"NONE","body":"As title said, it works but only before save.\r\n\r\nFor example, if I access something non exists property in specific object type, flow gives me error like this:\r\n\r\n> [flow] Cannot get `user.wallet.a` because property `a` is missing in `UserEntityWallet` [1]. (References: [1])\r\n\r\nHowever when I save the file, it just changed to this:\r\n\r\n> [flow coverage] uncovered code\r\n\r\nIt's really annoying because I save the file a lot. Here's my flow config settings:\r\n\r\n```text\r\n[ignore]\r\n.*/dist/.*\r\n.*/node_modules/jsonlint/.*\r\n.*/node_modules/rc-util/.*\r\n.*/node_modules/react-apollo/node_modules/.*\r\n\r\n[include]\r\n\r\n[libs]\r\n./src/global.js\r\nflow-typed\r\n\r\n[options]\r\nesproposal.decorators=ignore\r\nmodule.name_mapper='^.*\\.css$' -> 'css-module-flow'\r\nmodule.name_mapper='^.*\\.scss$' -> 'css-module-flow'\r\nmodule.name_mapper='^.*\\.less$' -> 'css-module-flow'\r\nmodule.name_mapper='^components\\(.*\\)$' -> '<PROJECT_ROOT>/src/components/\\1'\r\nmodule.name_mapper='^containers\\(.*\\)$' -> '<PROJECT_ROOT>/src/containers/\\1'\r\nmodule.name_mapper='^types\\(.*\\)$' -> '<PROJECT_ROOT>/src/types/\\1'\r\nmodule.name_mapper='^helpers\\(.*\\)$' -> '<PROJECT_ROOT>/src/helpers/\\1'\r\nmodule.system=haste\r\nmodule.system.node.resolve_dirname=node_modules\r\nmodule.system.node.resolve_dirname=src\r\n\r\n\r\n[lints]\r\n```\r\n\r\nAnd here's the version I'm using:\r\n- Node@8.12.0\r\n- Flow@0.85.0\r\n- flow-for-vscode@0.8.5"},"comment":{"url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/comments/439319404","html_url":"https://github.com/flowtype/flow-for-vscode/issues/289#issuecomment-439319404","issue_url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/289","id":439319404,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTMxOTQwNA==","user":{"login":"bradennapier","id":15365418,"node_id":"MDQ6VXNlcjE1MzY1NDE4","avatar_url":"https://avatars3.githubusercontent.com/u/15365418?v=4","gravatar_id":"","url":"https://api.github.com/users/bradennapier","html_url":"https://github.com/bradennapier","followers_url":"https://api.github.com/users/bradennapier/followers","following_url":"https://api.github.com/users/bradennapier/following{/other_user}","gists_url":"https://api.github.com/users/bradennapier/gists{/gist_id}","starred_url":"https://api.github.com/users/bradennapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradennapier/subscriptions","organizations_url":"https://api.github.com/users/bradennapier/orgs","repos_url":"https://api.github.com/users/bradennapier/repos","events_url":"https://api.github.com/users/bradennapier/events{/privacy}","received_events_url":"https://api.github.com/users/bradennapier/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T08:32:57Z","updated_at":"2018-11-16T08:32:57Z","author_association":"NONE","body":"So I was doing a bunch of investigation and logging and things are def pretty weird as there are plenty of places that flow clearly sees the file and even does diagnostics on it... I have a repro setup to show the issue\r\n\r\n## [Repro of Issue](https://github.com/bradennapier/flow-modules-bug-repro)\r\n\r\nI can swear using `flow` from cli was still checking the `shared` directory but now i am realizing even flow is not... on review i've noticed that flow is treating it identical to `node_modules` \r\n\r\n@see https://github.com/facebook/flow/blob/master/src/common/files.ml#L523-L528\r\n\r\nIn this file you will find a few filters for `node_modules` which always includes the list of all provided.\r\n\r\n\r\n"}}
{"actor":{"display_login":"bradennapier"}}