{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/5672","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/5672/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/5672/comments","events_url":"https://api.github.com/repos/istio/istio/issues/5672/events","html_url":"https://github.com/istio/istio/pull/5672","id":324068403,"number":5672,"title":"Multicluster Adding Delete logic for dynamically created controllers","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"gyliu513","id":4461983,"avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},"assignees":[{"login":"gyliu513","id":4461983,"avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-05-17T15:14:23Z","updated_at":"2018-05-21T13:20:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5672","html_url":"https://github.com/istio/istio/pull/5672","diff_url":"https://github.com/istio/istio/pull/5672.diff","patch_url":"https://github.com/istio/istio/pull/5672.patch"},"body":"WIP... This PR adds delete logic to secret controller. On detection of remote cluster's secret removal, 1: corresponding service registry entry gets deleted, 2: Stop message sent to the controller, 3: remote cluster gets removed from the clusters store.\r\nCloses: #5629\r\nCloses: #5622\r\nCloses: #5606\r\nCloses: #5605"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/390651706","html_url":"https://github.com/istio/istio/pull/5672#issuecomment-390651706","issue_url":"https://api.github.com/repos/istio/istio/issues/5672","id":390651706,"user":{"login":"istio-testing","id":25311884,"avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T13:20:47Z","updated_at":"2018-05-21T13:20:47Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/5672#pullrequestreview-121793223\" title=\"LGTM\">gyliu513</a>*, *<a href=\"https://github.com/istio/istio/pull/5672#\" title=\"Author self-approved\">sbezverk</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **ayj**\n\nAssign the PR to them by writing `/assign @ayj` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pilot/OWNERS](https://github.com/istio/istio/blob/master/pilot/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"ayj\"]} -->"}}
{"actor":{"display_login":"istio-testing"}}