{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/web3.py/issues/893","repository_url":"https://api.github.com/repos/ethereum/web3.py","labels_url":"https://api.github.com/repos/ethereum/web3.py/issues/893/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/web3.py/issues/893/comments","events_url":"https://api.github.com/repos/ethereum/web3.py/issues/893/events","html_url":"https://github.com/ethereum/web3.py/pull/893","id":330915325,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzk0MDEz","number":893,"title":"[WIP]Permitted bytes addresses in web3","user":{"login":"voith","id":8171193,"node_id":"MDQ6VXNlcjgxNzExOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8171193?v=4","gravatar_id":"","url":"https://api.github.com/users/voith","html_url":"https://github.com/voith","followers_url":"https://api.github.com/users/voith/followers","following_url":"https://api.github.com/users/voith/following{/other_user}","gists_url":"https://api.github.com/users/voith/gists{/gist_id}","starred_url":"https://api.github.com/users/voith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voith/subscriptions","organizations_url":"https://api.github.com/users/voith/orgs","repos_url":"https://api.github.com/users/voith/repos","events_url":"https://api.github.com/users/voith/events{/privacy}","received_events_url":"https://api.github.com/users/voith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-09T20:01:11Z","updated_at":"2018-06-11T17:34:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ethereum/web3.py/pulls/893","html_url":"https://github.com/ethereum/web3.py/pull/893","diff_url":"https://github.com/ethereum/web3.py/pull/893.diff","patch_url":"https://github.com/ethereum/web3.py/pull/893.patch"},"body":"submitting early to keep track of my progress!\r\n### What was wrong?\r\nWeb3 did not permit bytes addresses.\r\nsee  #884\r\n\r\n### How was it fixed?\r\nPemitted bytes addresses in web3.\r\n\r\n#### TODO LIST\r\n\r\n- [ ]  Add tests\r\n\r\n- [ ]  update docs\r\n\r\n#### Cute Animal Picture\r\n\r\n![](https://i.imgur.com/vf0Kqe5.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/web3.py/issues/comments/396323179","html_url":"https://github.com/ethereum/web3.py/pull/893#issuecomment-396323179","issue_url":"https://api.github.com/repos/ethereum/web3.py/issues/893","id":396323179,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjMyMzE3OQ==","user":{"login":"carver","id":205327,"node_id":"MDQ6VXNlcjIwNTMyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/205327?v=4","gravatar_id":"","url":"https://api.github.com/users/carver","html_url":"https://github.com/carver","followers_url":"https://api.github.com/users/carver/followers","following_url":"https://api.github.com/users/carver/following{/other_user}","gists_url":"https://api.github.com/users/carver/gists{/gist_id}","starred_url":"https://api.github.com/users/carver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carver/subscriptions","organizations_url":"https://api.github.com/users/carver/orgs","repos_url":"https://api.github.com/users/carver/repos","events_url":"https://api.github.com/users/carver/events{/privacy}","received_events_url":"https://api.github.com/users/carver/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T17:34:20Z","updated_at":"2018-06-11T17:34:20Z","author_association":"COLLABORATOR","body":"> `w3.eth.getTransactionCount` doesn't seem to increment the count, once a transaction has been sent\r\n\r\nThat doesn't sound right. Something else must be going on. Can you leave in an example of a broken test with `getTransactionCount`?\r\n\r\n> I was getting this error with geth\r\n\r\nRight, I think the integration tests don't reset state in between tests.\r\n\r\n> In such cases I left the tests as is.\r\n\r\nThat should be fine, although it should be possible to parametrize non-state-changing tests with both kinds of addresses, like a `getBalance(address)` test."}}
{"actor":{"display_login":"carver"}}