{"action":"created","comment":{"url":"https://api.github.com/repos/assembl/assembl/pulls/comments/175834017","pull_request_review_id":105429900,"id":175834017,"diff_hunk":"@@ -7,25 +8,49 @@\n import React from 'react';\n import { ControlLabel, FormGroup, FormControl, HelpBlock } from 'react-bootstrap';\n import { I18n } from 'react-redux-i18n';\n+import { type rawContentState } from 'draft-js';\n \n import RichTextEditor from './richTextEditor';\n import { getValidationState } from '../administration/voteSession/voteProposalForm';\n \n-class FormControlWithLabel extends React.Component {\n-  constructor(props) {\n+type FormControlWithLabelProps = {\n+  value: string | rawContentState,\n+  required: boolean,\n+  onChange: Function,\n+  type: string,\n+  disabled: boolean,\n+  label: string,\n+  labelAlwaysVisible: boolean,\n+  componentClass: string,\n+  formControlProps: Object,\n+  id: string,\n+  validationErrors?: Array<ErrorDef>\n+};\n+\n+type FormControlWithLabelState = {\n+  errorMessage?: string,\n+  validationErrors?: Array<ErrorDef>,\n+  validationState: ?string\n+};\n+\n+class FormControlWithLabel extends React.Component<*, FormControlWithLabelProps, FormControlWithLabelState> {\n+  props: FormControlWithLabelProps;\n+\n+  state: FormControlWithLabelState;\n+\n+  constructor(props: FormControlWithLabelProps) {\n     super(props);\n     this.state = this.getStateFromProps(props);\n-    this.setValidationState = this.setValidationState.bind(this);\n   }\n \n-  componentWillReceiveProps(nextProps) {\n+  componentWillReceiveProps(nextProps: FormControlWithLabelProps) {\n     if (nextProps.validationErrors !== this.props.validationErrors) {\n       this.setState(this.getStateFromProps(nextProps));\n     }\n   }\n \n-  getStateFromProps = (props) => {\n-    const errors = props.validationErrors;\n+  getStateFromProps = ({ validationErrors }: FormControlWithLabelProps) => {\n+    const errors = validationErrors && validationErrors;","path":"assembl/static2/js/app/components/common/formControlWithLabel.jsx","position":65,"original_position":57,"commit_id":"ca5b7dbab8df125a9dbac8fdbe30ceeb06bc7015","original_commit_id":"afcbbf68816183feca00acf69a0986e7837d24ce","user":{"login":"cedricmessiant","id":405172,"avatar_url":"https://avatars1.githubusercontent.com/u/405172?v=4","gravatar_id":"","url":"https://api.github.com/users/cedricmessiant","html_url":"https://github.com/cedricmessiant","followers_url":"https://api.github.com/users/cedricmessiant/followers","following_url":"https://api.github.com/users/cedricmessiant/following{/other_user}","gists_url":"https://api.github.com/users/cedricmessiant/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricmessiant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricmessiant/subscriptions","organizations_url":"https://api.github.com/users/cedricmessiant/orgs","repos_url":"https://api.github.com/users/cedricmessiant/repos","events_url":"https://api.github.com/users/cedricmessiant/events{/privacy}","received_events_url":"https://api.github.com/users/cedricmessiant/received_events","type":"User","site_admin":false},"body":"ok so you should at least add a comment (and probably a link to the github issue). Can you tell me what is the flow error if you remove it please?","created_at":"2018-03-20T16:28:04Z","updated_at":"2018-03-20T16:28:04Z","html_url":"https://github.com/assembl/assembl/pull/369#discussion_r175834017","pull_request_url":"https://api.github.com/repos/assembl/assembl/pulls/369","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/assembl/assembl/pulls/comments/175834017"},"html":{"href":"https://github.com/assembl/assembl/pull/369#discussion_r175834017"},"pull_request":{"href":"https://api.github.com/repos/assembl/assembl/pulls/369"}},"in_reply_to_id":175784280},"pull_request":{"url":"https://api.github.com/repos/assembl/assembl/pulls/369","id":176150585,"html_url":"https://github.com/assembl/assembl/pull/369","diff_url":"https://github.com/assembl/assembl/pull/369.diff","patch_url":"https://github.com/assembl/assembl/pull/369.patch","issue_url":"https://api.github.com/repos/assembl/assembl/issues/369","number":369,"state":"open","locked":false,"title":"FormControlWithLabel update","user":{"login":"MilanBarande","id":25273007,"avatar_url":"https://avatars2.githubusercontent.com/u/25273007?v=4","gravatar_id":"","url":"https://api.github.com/users/MilanBarande","html_url":"https://github.com/MilanBarande","followers_url":"https://api.github.com/users/MilanBarande/followers","following_url":"https://api.github.com/users/MilanBarande/following{/other_user}","gists_url":"https://api.github.com/users/MilanBarande/gists{/gist_id}","starred_url":"https://api.github.com/users/MilanBarande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MilanBarande/subscriptions","organizations_url":"https://api.github.com/users/MilanBarande/orgs","repos_url":"https://api.github.com/users/MilanBarande/repos","events_url":"https://api.github.com/users/MilanBarande/events{/privacy}","received_events_url":"https://api.github.com/users/MilanBarande/received_events","type":"User","site_admin":false},"body":"A quick upgrade of the FormControlWithLabel component so that it adds a \"*\" next to the label/placeholder when the prop \"required\" is true.\r\nAlso added flow and cleaned the various files where we had manually added a \"*\" to a label","created_at":"2018-03-20T10:46:00Z","updated_at":"2018-03-20T16:28:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"505105efa24815d4e24d6efd01011c5e1b0d2962","assignee":null,"assignees":[],"requested_reviewers":[{"login":"paolina92","id":17748791,"avatar_url":"https://avatars2.githubusercontent.com/u/17748791?v=4","gravatar_id":"","url":"https://api.github.com/users/paolina92","html_url":"https://github.com/paolina92","followers_url":"https://api.github.com/users/paolina92/followers","following_url":"https://api.github.com/users/paolina92/following{/other_user}","gists_url":"https://api.github.com/users/paolina92/gists{/gist_id}","starred_url":"https://api.github.com/users/paolina92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolina92/subscriptions","organizations_url":"https://api.github.com/users/paolina92/orgs","repos_url":"https://api.github.com/users/paolina92/repos","events_url":"https://api.github.com/users/paolina92/events{/privacy}","received_events_url":"https://api.github.com/users/paolina92/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/assembl/assembl/pulls/369/commits","review_comments_url":"https://api.github.com/repos/assembl/assembl/pulls/369/comments","review_comment_url":"https://api.github.com/repos/assembl/assembl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/assembl/assembl/issues/369/comments","statuses_url":"https://api.github.com/repos/assembl/assembl/statuses/ca5b7dbab8df125a9dbac8fdbe30ceeb06bc7015","head":{"label":"assembl:formControlWithLabel_update","ref":"formControlWithLabel_update","sha":"ca5b7dbab8df125a9dbac8fdbe30ceeb06bc7015","user":{"login":"assembl","id":20449542,"avatar_url":"https://avatars3.githubusercontent.com/u/20449542?v=4","gravatar_id":"","url":"https://api.github.com/users/assembl","html_url":"https://github.com/assembl","followers_url":"https://api.github.com/users/assembl/followers","following_url":"https://api.github.com/users/assembl/following{/other_user}","gists_url":"https://api.github.com/users/assembl/gists{/gist_id}","starred_url":"https://api.github.com/users/assembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assembl/subscriptions","organizations_url":"https://api.github.com/users/assembl/orgs","repos_url":"https://api.github.com/users/assembl/repos","events_url":"https://api.github.com/users/assembl/events{/privacy}","received_events_url":"https://api.github.com/users/assembl/received_events","type":"Organization","site_admin":false},"repo":{"id":18962634,"name":"assembl","full_name":"assembl/assembl","owner":{"login":"assembl","id":20449542,"avatar_url":"https://avatars3.githubusercontent.com/u/20449542?v=4","gravatar_id":"","url":"https://api.github.com/users/assembl","html_url":"https://github.com/assembl","followers_url":"https://api.github.com/users/assembl/followers","following_url":"https://api.github.com/users/assembl/following{/other_user}","gists_url":"https://api.github.com/users/assembl/gists{/gist_id}","starred_url":"https://api.github.com/users/assembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assembl/subscriptions","organizations_url":"https://api.github.com/users/assembl/orgs","repos_url":"https://api.github.com/users/assembl/repos","events_url":"https://api.github.com/users/assembl/events{/privacy}","received_events_url":"https://api.github.com/users/assembl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assembl/assembl","description":"Assembl is an online debate and synthesis platform","fork":false,"url":"https://api.github.com/repos/assembl/assembl","forks_url":"https://api.github.com/repos/assembl/assembl/forks","keys_url":"https://api.github.com/repos/assembl/assembl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assembl/assembl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assembl/assembl/teams","hooks_url":"https://api.github.com/repos/assembl/assembl/hooks","issue_events_url":"https://api.github.com/repos/assembl/assembl/issues/events{/number}","events_url":"https://api.github.com/repos/assembl/assembl/events","assignees_url":"https://api.github.com/repos/assembl/assembl/assignees{/user}","branches_url":"https://api.github.com/repos/assembl/assembl/branches{/branch}","tags_url":"https://api.github.com/repos/assembl/assembl/tags","blobs_url":"https://api.github.com/repos/assembl/assembl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assembl/assembl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assembl/assembl/git/refs{/sha}","trees_url":"https://api.github.com/repos/assembl/assembl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assembl/assembl/statuses/{sha}","languages_url":"https://api.github.com/repos/assembl/assembl/languages","stargazers_url":"https://api.github.com/repos/assembl/assembl/stargazers","contributors_url":"https://api.github.com/repos/assembl/assembl/contributors","subscribers_url":"https://api.github.com/repos/assembl/assembl/subscribers","subscription_url":"https://api.github.com/repos/assembl/assembl/subscription","commits_url":"https://api.github.com/repos/assembl/assembl/commits{/sha}","git_commits_url":"https://api.github.com/repos/assembl/assembl/git/commits{/sha}","comments_url":"https://api.github.com/repos/assembl/assembl/comments{/number}","issue_comment_url":"https://api.github.com/repos/assembl/assembl/issues/comments{/number}","contents_url":"https://api.github.com/repos/assembl/assembl/contents/{+path}","compare_url":"https://api.github.com/repos/assembl/assembl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assembl/assembl/merges","archive_url":"https://api.github.com/repos/assembl/assembl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assembl/assembl/downloads","issues_url":"https://api.github.com/repos/assembl/assembl/issues{/number}","pulls_url":"https://api.github.com/repos/assembl/assembl/pulls{/number}","milestones_url":"https://api.github.com/repos/assembl/assembl/milestones{/number}","notifications_url":"https://api.github.com/repos/assembl/assembl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assembl/assembl/labels{/name}","releases_url":"https://api.github.com/repos/assembl/assembl/releases{/id}","deployments_url":"https://api.github.com/repos/assembl/assembl/deployments","created_at":"2014-04-20T10:52:11Z","updated_at":"2018-03-20T13:56:24Z","pushed_at":"2018-03-20T16:20:42Z","git_url":"git://github.com/assembl/assembl.git","ssh_url":"git@github.com:assembl/assembl.git","clone_url":"https://github.com/assembl/assembl.git","svn_url":"https://github.com/assembl/assembl","homepage":"http://assembl.bluenove.com","size":71381,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":28,"open_issues":20,"watchers":82,"default_branch":"develop"}},"base":{"label":"assembl:develop","ref":"develop","sha":"2031ca5c5c35b7478209aa6c2f6d240762e44276","user":{"login":"assembl","id":20449542,"avatar_url":"https://avatars3.githubusercontent.com/u/20449542?v=4","gravatar_id":"","url":"https://api.github.com/users/assembl","html_url":"https://github.com/assembl","followers_url":"https://api.github.com/users/assembl/followers","following_url":"https://api.github.com/users/assembl/following{/other_user}","gists_url":"https://api.github.com/users/assembl/gists{/gist_id}","starred_url":"https://api.github.com/users/assembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assembl/subscriptions","organizations_url":"https://api.github.com/users/assembl/orgs","repos_url":"https://api.github.com/users/assembl/repos","events_url":"https://api.github.com/users/assembl/events{/privacy}","received_events_url":"https://api.github.com/users/assembl/received_events","type":"Organization","site_admin":false},"repo":{"id":18962634,"name":"assembl","full_name":"assembl/assembl","owner":{"login":"assembl","id":20449542,"avatar_url":"https://avatars3.githubusercontent.com/u/20449542?v=4","gravatar_id":"","url":"https://api.github.com/users/assembl","html_url":"https://github.com/assembl","followers_url":"https://api.github.com/users/assembl/followers","following_url":"https://api.github.com/users/assembl/following{/other_user}","gists_url":"https://api.github.com/users/assembl/gists{/gist_id}","starred_url":"https://api.github.com/users/assembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assembl/subscriptions","organizations_url":"https://api.github.com/users/assembl/orgs","repos_url":"https://api.github.com/users/assembl/repos","events_url":"https://api.github.com/users/assembl/events{/privacy}","received_events_url":"https://api.github.com/users/assembl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assembl/assembl","description":"Assembl is an online debate and synthesis platform","fork":false,"url":"https://api.github.com/repos/assembl/assembl","forks_url":"https://api.github.com/repos/assembl/assembl/forks","keys_url":"https://api.github.com/repos/assembl/assembl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assembl/assembl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assembl/assembl/teams","hooks_url":"https://api.github.com/repos/assembl/assembl/hooks","issue_events_url":"https://api.github.com/repos/assembl/assembl/issues/events{/number}","events_url":"https://api.github.com/repos/assembl/assembl/events","assignees_url":"https://api.github.com/repos/assembl/assembl/assignees{/user}","branches_url":"https://api.github.com/repos/assembl/assembl/branches{/branch}","tags_url":"https://api.github.com/repos/assembl/assembl/tags","blobs_url":"https://api.github.com/repos/assembl/assembl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assembl/assembl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assembl/assembl/git/refs{/sha}","trees_url":"https://api.github.com/repos/assembl/assembl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assembl/assembl/statuses/{sha}","languages_url":"https://api.github.com/repos/assembl/assembl/languages","stargazers_url":"https://api.github.com/repos/assembl/assembl/stargazers","contributors_url":"https://api.github.com/repos/assembl/assembl/contributors","subscribers_url":"https://api.github.com/repos/assembl/assembl/subscribers","subscription_url":"https://api.github.com/repos/assembl/assembl/subscription","commits_url":"https://api.github.com/repos/assembl/assembl/commits{/sha}","git_commits_url":"https://api.github.com/repos/assembl/assembl/git/commits{/sha}","comments_url":"https://api.github.com/repos/assembl/assembl/comments{/number}","issue_comment_url":"https://api.github.com/repos/assembl/assembl/issues/comments{/number}","contents_url":"https://api.github.com/repos/assembl/assembl/contents/{+path}","compare_url":"https://api.github.com/repos/assembl/assembl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assembl/assembl/merges","archive_url":"https://api.github.com/repos/assembl/assembl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assembl/assembl/downloads","issues_url":"https://api.github.com/repos/assembl/assembl/issues{/number}","pulls_url":"https://api.github.com/repos/assembl/assembl/pulls{/number}","milestones_url":"https://api.github.com/repos/assembl/assembl/milestones{/number}","notifications_url":"https://api.github.com/repos/assembl/assembl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assembl/assembl/labels{/name}","releases_url":"https://api.github.com/repos/assembl/assembl/releases{/id}","deployments_url":"https://api.github.com/repos/assembl/assembl/deployments","created_at":"2014-04-20T10:52:11Z","updated_at":"2018-03-20T13:56:24Z","pushed_at":"2018-03-20T16:20:42Z","git_url":"git://github.com/assembl/assembl.git","ssh_url":"git@github.com:assembl/assembl.git","clone_url":"https://github.com/assembl/assembl.git","svn_url":"https://github.com/assembl/assembl","homepage":"http://assembl.bluenove.com","size":71381,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":28,"open_issues":20,"watchers":82,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/assembl/assembl/pulls/369"},"html":{"href":"https://github.com/assembl/assembl/pull/369"},"issue":{"href":"https://api.github.com/repos/assembl/assembl/issues/369"},"comments":{"href":"https://api.github.com/repos/assembl/assembl/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/assembl/assembl/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/assembl/assembl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/assembl/assembl/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/assembl/assembl/statuses/ca5b7dbab8df125a9dbac8fdbe30ceeb06bc7015"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cedricmessiant"}}