{"action":"created","comment":{"url":"https://api.github.com/repos/brandingbrand/flagship/pulls/comments/241460912","pull_request_review_id":184739192,"id":241460912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQ2MDkxMg==","diff_hunk":"@@ -84,24 +84,27 @@ export class MultiCarousel<ItemT> extends Component<MultiCarouselProps<ItemT>, M\n     this.state = {\n       currentIndex: 0,\n       containerWidth: 0,\n-      itemWidth: 0\n+      itemWidth: 0,\n+      opacity: new Animated.Value(0),\n+      initialized: false","path":"packages/fscomponents/src/components/MultiCarousel/MultiCarousel.tsx","position":29,"original_position":29,"commit_id":"9170de97c1177c35e3c1aa97e8f89d6fae004740","original_commit_id":"9170de97c1177c35e3c1aa97e8f89d6fae004740","user":{"login":"skyeckstrom","id":556070,"node_id":"MDQ6VXNlcjU1NjA3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/556070?v=4","gravatar_id":"","url":"https://api.github.com/users/skyeckstrom","html_url":"https://github.com/skyeckstrom","followers_url":"https://api.github.com/users/skyeckstrom/followers","following_url":"https://api.github.com/users/skyeckstrom/following{/other_user}","gists_url":"https://api.github.com/users/skyeckstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/skyeckstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyeckstrom/subscriptions","organizations_url":"https://api.github.com/users/skyeckstrom/orgs","repos_url":"https://api.github.com/users/skyeckstrom/repos","events_url":"https://api.github.com/users/skyeckstrom/events{/privacy}","received_events_url":"https://api.github.com/users/skyeckstrom/received_events","type":"User","site_admin":false},"body":"This is probably the wrong way to handle the animation. We should instead use [`componentDidUpdate `](https://reactjs.org/docs/react-component.html#componentdidupdate) to set the opacity to zero and animate in whenever the image changes. We shouldn't need to keep track of `initialized` at all.","created_at":"2018-12-13T16:07:29Z","updated_at":"2018-12-13T16:07:36Z","html_url":"https://github.com/brandingbrand/flagship/pull/307#discussion_r241460912","pull_request_url":"https://api.github.com/repos/brandingbrand/flagship/pulls/307","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brandingbrand/flagship/pulls/comments/241460912"},"html":{"href":"https://github.com/brandingbrand/flagship/pull/307#discussion_r241460912"},"pull_request":{"href":"https://api.github.com/repos/brandingbrand/flagship/pulls/307"}}},"pull_request":{"url":"https://api.github.com/repos/brandingbrand/flagship/pulls/307","id":238195683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTk1Njgz","html_url":"https://github.com/brandingbrand/flagship/pull/307","diff_url":"https://github.com/brandingbrand/flagship/pull/307.diff","patch_url":"https://github.com/brandingbrand/flagship/pull/307.patch","issue_url":"https://api.github.com/repos/brandingbrand/flagship/issues/307","number":307,"state":"open","locked":false,"title":"fix(fscomponents): Move Multicarousel opacity and initialized into state","user":{"login":"Cauldrath","id":1427204,"node_id":"MDQ6VXNlcjE0MjcyMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1427204?v=4","gravatar_id":"","url":"https://api.github.com/users/Cauldrath","html_url":"https://github.com/Cauldrath","followers_url":"https://api.github.com/users/Cauldrath/followers","following_url":"https://api.github.com/users/Cauldrath/following{/other_user}","gists_url":"https://api.github.com/users/Cauldrath/gists{/gist_id}","starred_url":"https://api.github.com/users/Cauldrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cauldrath/subscriptions","organizations_url":"https://api.github.com/users/Cauldrath/orgs","repos_url":"https://api.github.com/users/Cauldrath/repos","events_url":"https://api.github.com/users/Cauldrath/events{/privacy}","received_events_url":"https://api.github.com/users/Cauldrath/received_events","type":"User","site_admin":false},"body":"These values were not being updated properly when the properties changed, such as changing the images, so opacity was getting stuck set to zero.","created_at":"2018-12-12T21:56:32Z","updated_at":"2018-12-13T16:07:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4e764ea1c4400e2595ab3d215f17487713f48b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brandingbrand/flagship/pulls/307/commits","review_comments_url":"https://api.github.com/repos/brandingbrand/flagship/pulls/307/comments","review_comment_url":"https://api.github.com/repos/brandingbrand/flagship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brandingbrand/flagship/issues/307/comments","statuses_url":"https://api.github.com/repos/brandingbrand/flagship/statuses/9170de97c1177c35e3c1aa97e8f89d6fae004740","head":{"label":"Cauldrath:multicarousel_animation","ref":"multicarousel_animation","sha":"9170de97c1177c35e3c1aa97e8f89d6fae004740","user":{"login":"Cauldrath","id":1427204,"node_id":"MDQ6VXNlcjE0MjcyMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1427204?v=4","gravatar_id":"","url":"https://api.github.com/users/Cauldrath","html_url":"https://github.com/Cauldrath","followers_url":"https://api.github.com/users/Cauldrath/followers","following_url":"https://api.github.com/users/Cauldrath/following{/other_user}","gists_url":"https://api.github.com/users/Cauldrath/gists{/gist_id}","starred_url":"https://api.github.com/users/Cauldrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cauldrath/subscriptions","organizations_url":"https://api.github.com/users/Cauldrath/orgs","repos_url":"https://api.github.com/users/Cauldrath/repos","events_url":"https://api.github.com/users/Cauldrath/events{/privacy}","received_events_url":"https://api.github.com/users/Cauldrath/received_events","type":"User","site_admin":false},"repo":{"id":139478641,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0Nzg2NDE=","name":"flagship","full_name":"Cauldrath/flagship","private":false,"owner":{"login":"Cauldrath","id":1427204,"node_id":"MDQ6VXNlcjE0MjcyMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1427204?v=4","gravatar_id":"","url":"https://api.github.com/users/Cauldrath","html_url":"https://github.com/Cauldrath","followers_url":"https://api.github.com/users/Cauldrath/followers","following_url":"https://api.github.com/users/Cauldrath/following{/other_user}","gists_url":"https://api.github.com/users/Cauldrath/gists{/gist_id}","starred_url":"https://api.github.com/users/Cauldrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cauldrath/subscriptions","organizations_url":"https://api.github.com/users/Cauldrath/orgs","repos_url":"https://api.github.com/users/Cauldrath/repos","events_url":"https://api.github.com/users/Cauldrath/events{/privacy}","received_events_url":"https://api.github.com/users/Cauldrath/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Cauldrath/flagship","description":"🚢 A tool for building your best shopping app","fork":true,"url":"https://api.github.com/repos/Cauldrath/flagship","forks_url":"https://api.github.com/repos/Cauldrath/flagship/forks","keys_url":"https://api.github.com/repos/Cauldrath/flagship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cauldrath/flagship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cauldrath/flagship/teams","hooks_url":"https://api.github.com/repos/Cauldrath/flagship/hooks","issue_events_url":"https://api.github.com/repos/Cauldrath/flagship/issues/events{/number}","events_url":"https://api.github.com/repos/Cauldrath/flagship/events","assignees_url":"https://api.github.com/repos/Cauldrath/flagship/assignees{/user}","branches_url":"https://api.github.com/repos/Cauldrath/flagship/branches{/branch}","tags_url":"https://api.github.com/repos/Cauldrath/flagship/tags","blobs_url":"https://api.github.com/repos/Cauldrath/flagship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cauldrath/flagship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cauldrath/flagship/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cauldrath/flagship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cauldrath/flagship/statuses/{sha}","languages_url":"https://api.github.com/repos/Cauldrath/flagship/languages","stargazers_url":"https://api.github.com/repos/Cauldrath/flagship/stargazers","contributors_url":"https://api.github.com/repos/Cauldrath/flagship/contributors","subscribers_url":"https://api.github.com/repos/Cauldrath/flagship/subscribers","subscription_url":"https://api.github.com/repos/Cauldrath/flagship/subscription","commits_url":"https://api.github.com/repos/Cauldrath/flagship/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cauldrath/flagship/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cauldrath/flagship/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cauldrath/flagship/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cauldrath/flagship/contents/{+path}","compare_url":"https://api.github.com/repos/Cauldrath/flagship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cauldrath/flagship/merges","archive_url":"https://api.github.com/repos/Cauldrath/flagship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cauldrath/flagship/downloads","issues_url":"https://api.github.com/repos/Cauldrath/flagship/issues{/number}","pulls_url":"https://api.github.com/repos/Cauldrath/flagship/pulls{/number}","milestones_url":"https://api.github.com/repos/Cauldrath/flagship/milestones{/number}","notifications_url":"https://api.github.com/repos/Cauldrath/flagship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cauldrath/flagship/labels{/name}","releases_url":"https://api.github.com/repos/Cauldrath/flagship/releases{/id}","deployments_url":"https://api.github.com/repos/Cauldrath/flagship/deployments","created_at":"2018-07-02T18:16:51Z","updated_at":"2018-11-13T19:15:46Z","pushed_at":"2018-12-12T22:00:20Z","git_url":"git://github.com/Cauldrath/flagship.git","ssh_url":"git@github.com:Cauldrath/flagship.git","clone_url":"https://github.com/Cauldrath/flagship.git","svn_url":"https://github.com/Cauldrath/flagship","homepage":"","size":6244,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brandingbrand:master","ref":"master","sha":"bd76a08eb60947608d598931a979fae6501bdf8a","user":{"login":"brandingbrand","id":1302319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDIzMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1302319?v=4","gravatar_id":"","url":"https://api.github.com/users/brandingbrand","html_url":"https://github.com/brandingbrand","followers_url":"https://api.github.com/users/brandingbrand/followers","following_url":"https://api.github.com/users/brandingbrand/following{/other_user}","gists_url":"https://api.github.com/users/brandingbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/brandingbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandingbrand/subscriptions","organizations_url":"https://api.github.com/users/brandingbrand/orgs","repos_url":"https://api.github.com/users/brandingbrand/repos","events_url":"https://api.github.com/users/brandingbrand/events{/privacy}","received_events_url":"https://api.github.com/users/brandingbrand/received_events","type":"Organization","site_admin":false},"repo":{"id":139191140,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxOTExNDA=","name":"flagship","full_name":"brandingbrand/flagship","private":false,"owner":{"login":"brandingbrand","id":1302319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDIzMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1302319?v=4","gravatar_id":"","url":"https://api.github.com/users/brandingbrand","html_url":"https://github.com/brandingbrand","followers_url":"https://api.github.com/users/brandingbrand/followers","following_url":"https://api.github.com/users/brandingbrand/following{/other_user}","gists_url":"https://api.github.com/users/brandingbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/brandingbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandingbrand/subscriptions","organizations_url":"https://api.github.com/users/brandingbrand/orgs","repos_url":"https://api.github.com/users/brandingbrand/repos","events_url":"https://api.github.com/users/brandingbrand/events{/privacy}","received_events_url":"https://api.github.com/users/brandingbrand/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brandingbrand/flagship","description":"🚢 A tool for building your best shopping app","fork":false,"url":"https://api.github.com/repos/brandingbrand/flagship","forks_url":"https://api.github.com/repos/brandingbrand/flagship/forks","keys_url":"https://api.github.com/repos/brandingbrand/flagship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandingbrand/flagship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandingbrand/flagship/teams","hooks_url":"https://api.github.com/repos/brandingbrand/flagship/hooks","issue_events_url":"https://api.github.com/repos/brandingbrand/flagship/issues/events{/number}","events_url":"https://api.github.com/repos/brandingbrand/flagship/events","assignees_url":"https://api.github.com/repos/brandingbrand/flagship/assignees{/user}","branches_url":"https://api.github.com/repos/brandingbrand/flagship/branches{/branch}","tags_url":"https://api.github.com/repos/brandingbrand/flagship/tags","blobs_url":"https://api.github.com/repos/brandingbrand/flagship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandingbrand/flagship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandingbrand/flagship/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandingbrand/flagship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandingbrand/flagship/statuses/{sha}","languages_url":"https://api.github.com/repos/brandingbrand/flagship/languages","stargazers_url":"https://api.github.com/repos/brandingbrand/flagship/stargazers","contributors_url":"https://api.github.com/repos/brandingbrand/flagship/contributors","subscribers_url":"https://api.github.com/repos/brandingbrand/flagship/subscribers","subscription_url":"https://api.github.com/repos/brandingbrand/flagship/subscription","commits_url":"https://api.github.com/repos/brandingbrand/flagship/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandingbrand/flagship/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandingbrand/flagship/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandingbrand/flagship/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandingbrand/flagship/contents/{+path}","compare_url":"https://api.github.com/repos/brandingbrand/flagship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandingbrand/flagship/merges","archive_url":"https://api.github.com/repos/brandingbrand/flagship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandingbrand/flagship/downloads","issues_url":"https://api.github.com/repos/brandingbrand/flagship/issues{/number}","pulls_url":"https://api.github.com/repos/brandingbrand/flagship/pulls{/number}","milestones_url":"https://api.github.com/repos/brandingbrand/flagship/milestones{/number}","notifications_url":"https://api.github.com/repos/brandingbrand/flagship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandingbrand/flagship/labels{/name}","releases_url":"https://api.github.com/repos/brandingbrand/flagship/releases{/id}","deployments_url":"https://api.github.com/repos/brandingbrand/flagship/deployments","created_at":"2018-06-29T20:08:46Z","updated_at":"2018-12-12T20:43:25Z","pushed_at":"2018-12-13T10:31:35Z","git_url":"git://github.com/brandingbrand/flagship.git","ssh_url":"git@github.com:brandingbrand/flagship.git","clone_url":"https://github.com/brandingbrand/flagship.git","svn_url":"https://github.com/brandingbrand/flagship","homepage":"","size":8154,"stargazers_count":49,"watchers_count":49,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":74,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brandingbrand/flagship/pulls/307"},"html":{"href":"https://github.com/brandingbrand/flagship/pull/307"},"issue":{"href":"https://api.github.com/repos/brandingbrand/flagship/issues/307"},"comments":{"href":"https://api.github.com/repos/brandingbrand/flagship/issues/307/comments"},"review_comments":{"href":"https://api.github.com/repos/brandingbrand/flagship/pulls/307/comments"},"review_comment":{"href":"https://api.github.com/repos/brandingbrand/flagship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brandingbrand/flagship/pulls/307/commits"},"statuses":{"href":"https://api.github.com/repos/brandingbrand/flagship/statuses/9170de97c1177c35e3c1aa97e8f89d6fae004740"}},"author_association":"NONE"}}
{"actor":{"display_login":"skyeckstrom"}}