{"action":"created","comment":{"url":"https://api.github.com/repos/raintank/tsdb-gw/pulls/comments/178454944","pull_request_review_id":108515653,"id":178454944,"diff_hunk":"@@ -45,6 +47,8 @@ var (\n \n \ttracingEnabled = flag.Bool(\"tracing-enabled\", false, \"enable/disable distributed opentracing via jaeger\")\n \ttracingAddr    = flag.String(\"tracing-addr\", \"localhost:6831\", \"address of the jaeger agent to send data to\")\n+\n+\tmetricsAddr = flag.String(\"metrics-addr\", \"localhost:8001\", \"http service address for the /metrics endpoint\")","path":"main.go","position":21,"original_position":21,"commit_id":"5014fb27ed89e8105bc52b3856367e77418c91af","original_commit_id":"5014fb27ed89e8105bc52b3856367e77418c91af","user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars1.githubusercontent.com/u/444037?v=4","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"body":"Sensible defaults: no point in making it only listen on `localhost` as we'll be deploying this on k8s.","created_at":"2018-04-01T11:05:54Z","updated_at":"2018-04-01T11:05:54Z","html_url":"https://github.com/raintank/tsdb-gw/pull/83#discussion_r178454944","pull_request_url":"https://api.github.com/repos/raintank/tsdb-gw/pulls/83","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/raintank/tsdb-gw/pulls/comments/178454944"},"html":{"href":"https://github.com/raintank/tsdb-gw/pull/83#discussion_r178454944"},"pull_request":{"href":"https://api.github.com/repos/raintank/tsdb-gw/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/raintank/tsdb-gw/pulls/83","id":178698770,"html_url":"https://github.com/raintank/tsdb-gw/pull/83","diff_url":"https://github.com/raintank/tsdb-gw/pull/83.diff","patch_url":"https://github.com/raintank/tsdb-gw/pull/83.patch","issue_url":"https://api.github.com/repos/raintank/tsdb-gw/issues/83","number":83,"state":"open","locked":false,"title":"Add prometheus metrics to cortex endpoints","user":{"login":"gouthamve","id":7354143,"avatar_url":"https://avatars0.githubusercontent.com/u/7354143?v=4","gravatar_id":"","url":"https://api.github.com/users/gouthamve","html_url":"https://github.com/gouthamve","followers_url":"https://api.github.com/users/gouthamve/followers","following_url":"https://api.github.com/users/gouthamve/following{/other_user}","gists_url":"https://api.github.com/users/gouthamve/gists{/gist_id}","starred_url":"https://api.github.com/users/gouthamve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouthamve/subscriptions","organizations_url":"https://api.github.com/users/gouthamve/orgs","repos_url":"https://api.github.com/users/gouthamve/repos","events_url":"https://api.github.com/users/gouthamve/events{/privacy}","received_events_url":"https://api.github.com/users/gouthamve/received_events","type":"User","site_admin":false},"body":"This is basically the last two PRs but onto master.\r\n\r\nThe prometheus metrics server is always on, I can disable it with another flag if required.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/raintank/tsdb-gw/83)\n<!-- Reviewable:end -->\n","created_at":"2018-03-31T20:20:52Z","updated_at":"2018-04-01T11:05:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c08b4b5162fae103c452a50585265e4409c2e0d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jtlisi","id":6921077,"avatar_url":"https://avatars2.githubusercontent.com/u/6921077?v=4","gravatar_id":"","url":"https://api.github.com/users/jtlisi","html_url":"https://github.com/jtlisi","followers_url":"https://api.github.com/users/jtlisi/followers","following_url":"https://api.github.com/users/jtlisi/following{/other_user}","gists_url":"https://api.github.com/users/jtlisi/gists{/gist_id}","starred_url":"https://api.github.com/users/jtlisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtlisi/subscriptions","organizations_url":"https://api.github.com/users/jtlisi/orgs","repos_url":"https://api.github.com/users/jtlisi/repos","events_url":"https://api.github.com/users/jtlisi/events{/privacy}","received_events_url":"https://api.github.com/users/jtlisi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/raintank/tsdb-gw/pulls/83/commits","review_comments_url":"https://api.github.com/repos/raintank/tsdb-gw/pulls/83/comments","review_comment_url":"https://api.github.com/repos/raintank/tsdb-gw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raintank/tsdb-gw/issues/83/comments","statuses_url":"https://api.github.com/repos/raintank/tsdb-gw/statuses/5014fb27ed89e8105bc52b3856367e77418c91af","head":{"label":"raintank:add-prom-metrics-master","ref":"add-prom-metrics-master","sha":"5014fb27ed89e8105bc52b3856367e77418c91af","user":{"login":"raintank","id":8512431,"avatar_url":"https://avatars1.githubusercontent.com/u/8512431?v=4","gravatar_id":"","url":"https://api.github.com/users/raintank","html_url":"https://github.com/raintank","followers_url":"https://api.github.com/users/raintank/followers","following_url":"https://api.github.com/users/raintank/following{/other_user}","gists_url":"https://api.github.com/users/raintank/gists{/gist_id}","starred_url":"https://api.github.com/users/raintank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raintank/subscriptions","organizations_url":"https://api.github.com/users/raintank/orgs","repos_url":"https://api.github.com/users/raintank/repos","events_url":"https://api.github.com/users/raintank/events{/privacy}","received_events_url":"https://api.github.com/users/raintank/received_events","type":"Organization","site_admin":false},"repo":{"id":63413639,"name":"tsdb-gw","full_name":"raintank/tsdb-gw","owner":{"login":"raintank","id":8512431,"avatar_url":"https://avatars1.githubusercontent.com/u/8512431?v=4","gravatar_id":"","url":"https://api.github.com/users/raintank","html_url":"https://github.com/raintank","followers_url":"https://api.github.com/users/raintank/followers","following_url":"https://api.github.com/users/raintank/following{/other_user}","gists_url":"https://api.github.com/users/raintank/gists{/gist_id}","starred_url":"https://api.github.com/users/raintank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raintank/subscriptions","organizations_url":"https://api.github.com/users/raintank/orgs","repos_url":"https://api.github.com/users/raintank/repos","events_url":"https://api.github.com/users/raintank/events{/privacy}","received_events_url":"https://api.github.com/users/raintank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raintank/tsdb-gw","description":null,"fork":false,"url":"https://api.github.com/repos/raintank/tsdb-gw","forks_url":"https://api.github.com/repos/raintank/tsdb-gw/forks","keys_url":"https://api.github.com/repos/raintank/tsdb-gw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raintank/tsdb-gw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raintank/tsdb-gw/teams","hooks_url":"https://api.github.com/repos/raintank/tsdb-gw/hooks","issue_events_url":"https://api.github.com/repos/raintank/tsdb-gw/issues/events{/number}","events_url":"https://api.github.com/repos/raintank/tsdb-gw/events","assignees_url":"https://api.github.com/repos/raintank/tsdb-gw/assignees{/user}","branches_url":"https://api.github.com/repos/raintank/tsdb-gw/branches{/branch}","tags_url":"https://api.github.com/repos/raintank/tsdb-gw/tags","blobs_url":"https://api.github.com/repos/raintank/tsdb-gw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raintank/tsdb-gw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raintank/tsdb-gw/git/refs{/sha}","trees_url":"https://api.github.com/repos/raintank/tsdb-gw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raintank/tsdb-gw/statuses/{sha}","languages_url":"https://api.github.com/repos/raintank/tsdb-gw/languages","stargazers_url":"https://api.github.com/repos/raintank/tsdb-gw/stargazers","contributors_url":"https://api.github.com/repos/raintank/tsdb-gw/contributors","subscribers_url":"https://api.github.com/repos/raintank/tsdb-gw/subscribers","subscription_url":"https://api.github.com/repos/raintank/tsdb-gw/subscription","commits_url":"https://api.github.com/repos/raintank/tsdb-gw/commits{/sha}","git_commits_url":"https://api.github.com/repos/raintank/tsdb-gw/git/commits{/sha}","comments_url":"https://api.github.com/repos/raintank/tsdb-gw/comments{/number}","issue_comment_url":"https://api.github.com/repos/raintank/tsdb-gw/issues/comments{/number}","contents_url":"https://api.github.com/repos/raintank/tsdb-gw/contents/{+path}","compare_url":"https://api.github.com/repos/raintank/tsdb-gw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raintank/tsdb-gw/merges","archive_url":"https://api.github.com/repos/raintank/tsdb-gw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raintank/tsdb-gw/downloads","issues_url":"https://api.github.com/repos/raintank/tsdb-gw/issues{/number}","pulls_url":"https://api.github.com/repos/raintank/tsdb-gw/pulls{/number}","milestones_url":"https://api.github.com/repos/raintank/tsdb-gw/milestones{/number}","notifications_url":"https://api.github.com/repos/raintank/tsdb-gw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raintank/tsdb-gw/labels{/name}","releases_url":"https://api.github.com/repos/raintank/tsdb-gw/releases{/id}","deployments_url":"https://api.github.com/repos/raintank/tsdb-gw/deployments","created_at":"2016-07-15T10:25:42Z","updated_at":"2018-03-28T18:32:20Z","pushed_at":"2018-03-31T20:21:30Z","git_url":"git://github.com/raintank/tsdb-gw.git","ssh_url":"git@github.com:raintank/tsdb-gw.git","clone_url":"https://github.com/raintank/tsdb-gw.git","svn_url":"https://github.com/raintank/tsdb-gw","homepage":null,"size":27691,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":16,"watchers":4,"default_branch":"master"}},"base":{"label":"raintank:master","ref":"master","sha":"9cb94e0665e1bcfd7dc747197204e424544516af","user":{"login":"raintank","id":8512431,"avatar_url":"https://avatars1.githubusercontent.com/u/8512431?v=4","gravatar_id":"","url":"https://api.github.com/users/raintank","html_url":"https://github.com/raintank","followers_url":"https://api.github.com/users/raintank/followers","following_url":"https://api.github.com/users/raintank/following{/other_user}","gists_url":"https://api.github.com/users/raintank/gists{/gist_id}","starred_url":"https://api.github.com/users/raintank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raintank/subscriptions","organizations_url":"https://api.github.com/users/raintank/orgs","repos_url":"https://api.github.com/users/raintank/repos","events_url":"https://api.github.com/users/raintank/events{/privacy}","received_events_url":"https://api.github.com/users/raintank/received_events","type":"Organization","site_admin":false},"repo":{"id":63413639,"name":"tsdb-gw","full_name":"raintank/tsdb-gw","owner":{"login":"raintank","id":8512431,"avatar_url":"https://avatars1.githubusercontent.com/u/8512431?v=4","gravatar_id":"","url":"https://api.github.com/users/raintank","html_url":"https://github.com/raintank","followers_url":"https://api.github.com/users/raintank/followers","following_url":"https://api.github.com/users/raintank/following{/other_user}","gists_url":"https://api.github.com/users/raintank/gists{/gist_id}","starred_url":"https://api.github.com/users/raintank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raintank/subscriptions","organizations_url":"https://api.github.com/users/raintank/orgs","repos_url":"https://api.github.com/users/raintank/repos","events_url":"https://api.github.com/users/raintank/events{/privacy}","received_events_url":"https://api.github.com/users/raintank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raintank/tsdb-gw","description":null,"fork":false,"url":"https://api.github.com/repos/raintank/tsdb-gw","forks_url":"https://api.github.com/repos/raintank/tsdb-gw/forks","keys_url":"https://api.github.com/repos/raintank/tsdb-gw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raintank/tsdb-gw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raintank/tsdb-gw/teams","hooks_url":"https://api.github.com/repos/raintank/tsdb-gw/hooks","issue_events_url":"https://api.github.com/repos/raintank/tsdb-gw/issues/events{/number}","events_url":"https://api.github.com/repos/raintank/tsdb-gw/events","assignees_url":"https://api.github.com/repos/raintank/tsdb-gw/assignees{/user}","branches_url":"https://api.github.com/repos/raintank/tsdb-gw/branches{/branch}","tags_url":"https://api.github.com/repos/raintank/tsdb-gw/tags","blobs_url":"https://api.github.com/repos/raintank/tsdb-gw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raintank/tsdb-gw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raintank/tsdb-gw/git/refs{/sha}","trees_url":"https://api.github.com/repos/raintank/tsdb-gw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raintank/tsdb-gw/statuses/{sha}","languages_url":"https://api.github.com/repos/raintank/tsdb-gw/languages","stargazers_url":"https://api.github.com/repos/raintank/tsdb-gw/stargazers","contributors_url":"https://api.github.com/repos/raintank/tsdb-gw/contributors","subscribers_url":"https://api.github.com/repos/raintank/tsdb-gw/subscribers","subscription_url":"https://api.github.com/repos/raintank/tsdb-gw/subscription","commits_url":"https://api.github.com/repos/raintank/tsdb-gw/commits{/sha}","git_commits_url":"https://api.github.com/repos/raintank/tsdb-gw/git/commits{/sha}","comments_url":"https://api.github.com/repos/raintank/tsdb-gw/comments{/number}","issue_comment_url":"https://api.github.com/repos/raintank/tsdb-gw/issues/comments{/number}","contents_url":"https://api.github.com/repos/raintank/tsdb-gw/contents/{+path}","compare_url":"https://api.github.com/repos/raintank/tsdb-gw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raintank/tsdb-gw/merges","archive_url":"https://api.github.com/repos/raintank/tsdb-gw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raintank/tsdb-gw/downloads","issues_url":"https://api.github.com/repos/raintank/tsdb-gw/issues{/number}","pulls_url":"https://api.github.com/repos/raintank/tsdb-gw/pulls{/number}","milestones_url":"https://api.github.com/repos/raintank/tsdb-gw/milestones{/number}","notifications_url":"https://api.github.com/repos/raintank/tsdb-gw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raintank/tsdb-gw/labels{/name}","releases_url":"https://api.github.com/repos/raintank/tsdb-gw/releases{/id}","deployments_url":"https://api.github.com/repos/raintank/tsdb-gw/deployments","created_at":"2016-07-15T10:25:42Z","updated_at":"2018-03-28T18:32:20Z","pushed_at":"2018-03-31T20:21:30Z","git_url":"git://github.com/raintank/tsdb-gw.git","ssh_url":"git@github.com:raintank/tsdb-gw.git","clone_url":"https://github.com/raintank/tsdb-gw.git","svn_url":"https://github.com/raintank/tsdb-gw","homepage":null,"size":27691,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":16,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raintank/tsdb-gw/pulls/83"},"html":{"href":"https://github.com/raintank/tsdb-gw/pull/83"},"issue":{"href":"https://api.github.com/repos/raintank/tsdb-gw/issues/83"},"comments":{"href":"https://api.github.com/repos/raintank/tsdb-gw/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/raintank/tsdb-gw/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/raintank/tsdb-gw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raintank/tsdb-gw/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/raintank/tsdb-gw/statuses/5014fb27ed89e8105bc52b3856367e77418c91af"}},"author_association":"NONE"}}
{"actor":{"display_login":"tomwilkie"}}