{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/comments/209697897","pull_request_review_id":145761995,"id":209697897,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTY5Nzg5Nw==","diff_hunk":"@@ -71,7 +71,7 @@\n             \"null\"\n           ],\n           \"default\": null,\n-          \"description\": \"The full path of the clang-format executable.\",\n+          \"description\": \"The full path of the clang-format executable. Changing this setting requires a Reload Window if it contains environment variables.\",","path":"Extension/package.json","position":5,"original_position":5,"commit_id":"d2b61c0503dc178cd419fa33c7d94d5d5c796049","original_commit_id":"d2b61c0503dc178cd419fa33c7d94d5d5c796049","user":{"login":"bobbrow","id":12818240,"node_id":"MDQ6VXNlcjEyODE4MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/12818240?v=4","gravatar_id":"","url":"https://api.github.com/users/bobbrow","html_url":"https://github.com/bobbrow","followers_url":"https://api.github.com/users/bobbrow/followers","following_url":"https://api.github.com/users/bobbrow/following{/other_user}","gists_url":"https://api.github.com/users/bobbrow/gists{/gist_id}","starred_url":"https://api.github.com/users/bobbrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobbrow/subscriptions","organizations_url":"https://api.github.com/users/bobbrow/orgs","repos_url":"https://api.github.com/users/bobbrow/repos","events_url":"https://api.github.com/users/bobbrow/events{/privacy}","received_events_url":"https://api.github.com/users/bobbrow/received_events","type":"User","site_admin":false},"body":"did it not work to intercept the didChangeConfigurations message in protocallFilter.ts?","created_at":"2018-08-13T17:44:42Z","updated_at":"2018-08-13T17:45:24Z","html_url":"https://github.com/Microsoft/vscode-cpptools/pull/2380#discussion_r209697897","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/2380","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/comments/209697897"},"html":{"href":"https://github.com/Microsoft/vscode-cpptools/pull/2380#discussion_r209697897"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/2380"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/2380","id":207473920,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDczOTIw","html_url":"https://github.com/Microsoft/vscode-cpptools/pull/2380","diff_url":"https://github.com/Microsoft/vscode-cpptools/pull/2380.diff","patch_url":"https://github.com/Microsoft/vscode-cpptools/pull/2380.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/2380","number":2380,"state":"open","locked":false,"title":"Enable environment variables with clang_format_path.","user":{"login":"sean-mcmanus","id":19859882,"node_id":"MDQ6VXNlcjE5ODU5ODgy","avatar_url":"https://avatars0.githubusercontent.com/u/19859882?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-mcmanus","html_url":"https://github.com/sean-mcmanus","followers_url":"https://api.github.com/users/sean-mcmanus/followers","following_url":"https://api.github.com/users/sean-mcmanus/following{/other_user}","gists_url":"https://api.github.com/users/sean-mcmanus/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-mcmanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-mcmanus/subscriptions","organizations_url":"https://api.github.com/users/sean-mcmanus/orgs","repos_url":"https://api.github.com/users/sean-mcmanus/repos","events_url":"https://api.github.com/users/sean-mcmanus/events{/privacy}","received_events_url":"https://api.github.com/users/sean-mcmanus/received_events","type":"User","site_admin":false},"body":"For https://github.com/Microsoft/vscode-cpptools/issues/2344 .","created_at":"2018-08-09T23:52:46Z","updated_at":"2018-08-13T17:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5d067dc3f5f2640000fe5221267d2270dbea38e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"grdowns","id":35574547,"node_id":"MDQ6VXNlcjM1NTc0NTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/35574547?v=4","gravatar_id":"","url":"https://api.github.com/users/grdowns","html_url":"https://github.com/grdowns","followers_url":"https://api.github.com/users/grdowns/followers","following_url":"https://api.github.com/users/grdowns/following{/other_user}","gists_url":"https://api.github.com/users/grdowns/gists{/gist_id}","starred_url":"https://api.github.com/users/grdowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grdowns/subscriptions","organizations_url":"https://api.github.com/users/grdowns/orgs","repos_url":"https://api.github.com/users/grdowns/repos","events_url":"https://api.github.com/users/grdowns/events{/privacy}","received_events_url":"https://api.github.com/users/grdowns/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/2380/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/2380/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/2380/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/statuses/d2b61c0503dc178cd419fa33c7d94d5d5c796049","head":{"label":"Microsoft:seanmcm/fixClangFormatEnv","ref":"seanmcm/fixClangFormatEnv","sha":"d2b61c0503dc178cd419fa33c7d94d5d5c796049","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":54800346,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgwMDM0Ng==","name":"vscode-cpptools","full_name":"Microsoft/vscode-cpptools","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-cpptools","description":"Official repository for filing issues against and getting support for the Microsoft C/C++ extension for VS Code ","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-cpptools","forks_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/deployments","created_at":"2016-03-26T21:26:30Z","updated_at":"2018-08-13T13:45:23Z","pushed_at":"2018-08-13T15:30:33Z","git_url":"git://github.com/Microsoft/vscode-cpptools.git","ssh_url":"git@github.com:Microsoft/vscode-cpptools.git","clone_url":"https://github.com/Microsoft/vscode-cpptools.git","svn_url":"https://github.com/Microsoft/vscode-cpptools","homepage":"","size":1399,"stargazers_count":1304,"watchers_count":1304,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"archived":false,"open_issues_count":648,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":311,"open_issues":648,"watchers":1304,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"2388fa97f4efe366cfda7472263fd5e42c0eab58","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":54800346,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgwMDM0Ng==","name":"vscode-cpptools","full_name":"Microsoft/vscode-cpptools","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-cpptools","description":"Official repository for filing issues against and getting support for the Microsoft C/C++ extension for VS Code ","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-cpptools","forks_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/deployments","created_at":"2016-03-26T21:26:30Z","updated_at":"2018-08-13T13:45:23Z","pushed_at":"2018-08-13T15:30:33Z","git_url":"git://github.com/Microsoft/vscode-cpptools.git","ssh_url":"git@github.com:Microsoft/vscode-cpptools.git","clone_url":"https://github.com/Microsoft/vscode-cpptools.git","svn_url":"https://github.com/Microsoft/vscode-cpptools","homepage":"","size":1399,"stargazers_count":1304,"watchers_count":1304,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"archived":false,"open_issues_count":648,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":311,"open_issues":648,"watchers":1304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/2380"},"html":{"href":"https://github.com/Microsoft/vscode-cpptools/pull/2380"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/2380"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/2380/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/2380/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/2380/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/statuses/d2b61c0503dc178cd419fa33c7d94d5d5c796049"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bobbrow"}}