{"action":"created","issue":{"url":"https://api.github.com/repos/lxqt/pcmanfm-qt/issues/555","repository_url":"https://api.github.com/repos/lxqt/pcmanfm-qt","labels_url":"https://api.github.com/repos/lxqt/pcmanfm-qt/issues/555/labels{/name}","comments_url":"https://api.github.com/repos/lxqt/pcmanfm-qt/issues/555/comments","events_url":"https://api.github.com/repos/lxqt/pcmanfm-qt/issues/555/events","html_url":"https://github.com/lxqt/pcmanfm-qt/issues/555","id":246751186,"number":555,"title":"Crash on copying file to USB stick -- and more","user":{"login":"tsujan","id":981076,"avatar_url":"https://avatars3.githubusercontent.com/u/981076?v=4","gravatar_id":"","url":"https://api.github.com/users/tsujan","html_url":"https://github.com/tsujan","followers_url":"https://api.github.com/users/tsujan/followers","following_url":"https://api.github.com/users/tsujan/following{/other_user}","gists_url":"https://api.github.com/users/tsujan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsujan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsujan/subscriptions","organizations_url":"https://api.github.com/users/tsujan/orgs","repos_url":"https://api.github.com/users/tsujan/repos","events_url":"https://api.github.com/users/tsujan/events{/privacy}","received_events_url":"https://api.github.com/users/tsujan/received_events","type":"User","site_admin":false},"labels":[{"id":49068402,"url":"https://api.github.com/repos/lxqt/pcmanfm-qt/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-31T13:12:24Z","updated_at":"2018-05-17T21:39:13Z","closed_at":"2018-05-17T21:39:13Z","author_association":"MEMBER","body":"When I try to copy a file with `:` in its name (like `test:1`) to a USB stick, pcmanfm-qt crashes with this backtrace:\r\n```\r\n#0  0x00007f99b8044280 in QIcon::isNull() const () at /usr/lib/libQt5Gui.so.5\r\n#1  0x00007f99b90def31 in Fm::IconInfo::qicon() const () at /usr/lib/libfm-qt.so.3\r\n#2  0x00007f99b9141c5c in Fm::RenameDialog::RenameDialog(_FmFileInfo*, _FmFileInfo*, QWidget*, QFlags<Qt::WindowType>) () at /usr/lib/libfm-qt.so.3\r\n#3  0x00007f99b914079a in Fm::FileOperationDialog::askRename(_FmFileInfo*, _FmFileInfo*, QString&) ()\r\n    at /usr/lib/libfm-qt.so.3\r\n#4  0x00007f99b913ed52 in Fm::FileOperation::onFileOpsJobAskRename(_FmFileOpsJob*, _FmFileInfo*, _FmFileInfo*, char**, Fm::FileOperation*) () at /usr/lib/libfm-qt.so.3\r\n#5  0x00007f99b759f973 in fm_marshal_INT__POINTER_POINTER_POINTER () at /usr/lib/libfm.so.4\r\n#6  0x00007f99b6fa3ead in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0\r\n#7  0x00007f99b6fb64ae in  () at /usr/lib/libgobject-2.0.so.0\r\n#8  0x00007f99b6fbe61f in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0\r\n#9  0x00007f99b6fbf69f in g_signal_emit () at /usr/lib/libgobject-2.0.so.0\r\n#10 0x00007f99b75aa6c3 in  () at /usr/lib/libfm.so.4\r\n#11 0x00007f99b75ae86e in  () at /usr/lib/libfm.so.4\r\n#12 0x00007f99b75a7d2b in  () at /usr/lib/libfm.so.4\r\n#13 0x00007f99b6ccb8c5 in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0\r\n#14 0x00007f99b6ccbc88 in  () at /usr/lib/libglib-2.0.so.0\r\n#15 0x00007f99b6ccbd1c in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0\r\n#16 0x00007f99b7ab2061 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()\r\n    at /usr/lib/libQt5Core.so.5\r\n#17 0x00007f99b7a55ffb in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/libQt5Core.so.5\r\n#18 0x00007f99b7a5f048 in QCoreApplication::exec() () at /usr/lib/libQt5Core.so.5\r\n#19 0x000000cb19aecd38 in  ()\r\n#20 0x00007f99b634a4ca in __libc_start_main () at /usr/lib/libc.so.6\r\n#21 0x000000cb19aecd9a in _start ()\r\n```\r\n\r\nMoreover, when I fix the crash with a simple patch, the rename dialog stubbornly asks for an overwrite, which is wrong because there's no file with that name to be overwritten.\r\n\r\nOf course, after fixing the crash, if I change the name in the rename dialog, the file will be copied."},"comment":{"url":"https://api.github.com/repos/lxqt/pcmanfm-qt/issues/comments/390021198","html_url":"https://github.com/lxqt/pcmanfm-qt/issues/555#issuecomment-390021198","issue_url":"https://api.github.com/repos/lxqt/pcmanfm-qt/issues/555","id":390021198,"user":{"login":"tsujan","id":981076,"avatar_url":"https://avatars3.githubusercontent.com/u/981076?v=4","gravatar_id":"","url":"https://api.github.com/users/tsujan","html_url":"https://github.com/tsujan","followers_url":"https://api.github.com/users/tsujan/followers","following_url":"https://api.github.com/users/tsujan/following{/other_user}","gists_url":"https://api.github.com/users/tsujan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsujan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsujan/subscriptions","organizations_url":"https://api.github.com/users/tsujan/orgs","repos_url":"https://api.github.com/users/tsujan/repos","events_url":"https://api.github.com/users/tsujan/events{/privacy}","received_events_url":"https://api.github.com/users/tsujan/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T21:39:13Z","updated_at":"2018-05-17T21:39:13Z","author_association":"MEMBER","body":"Fixed after https://github.com/lxqt/libfm-qt/commit/2a6f344271e883e326a326ba89e48566a3a8c857"}}
{"actor":{"display_login":"tsujan"}}