{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments/170464539","pull_request_review_id":99153546,"id":170464539,"diff_hunk":"@@ -0,0 +1,141 @@\n+#!/bin/bash","path":"compare_style.sh","position":1,"original_position":1,"commit_id":"84171099f9b9d50521adf57df1f57717f9b55bbd","original_commit_id":"84171099f9b9d50521adf57df1f57717f9b55bbd","user":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars2.githubusercontent.com/u/4192761?v=4","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"body":"I appreciate being able to check my changes before submitting to an external service but it is optional for one to use. I would rather we have shared tooling than folks implementing their own ad-hoc methods. Indeed CodeClimate seems like a better service than Travis for tracking metrics on code quality though.","created_at":"2018-02-25T19:46:42Z","updated_at":"2018-02-25T19:46:42Z","html_url":"https://github.com/bloomberg/chef-bach/pull/1060#discussion_r170464539","pull_request_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1060","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments/170464539"},"html":{"href":"https://github.com/bloomberg/chef-bach/pull/1060#discussion_r170464539"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1060"}},"in_reply_to_id":160690362},"pull_request":{"url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1060","id":160682925,"html_url":"https://github.com/bloomberg/chef-bach/pull/1060","diff_url":"https://github.com/bloomberg/chef-bach/pull/1060.diff","patch_url":"https://github.com/bloomberg/chef-bach/pull/1060.patch","issue_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/1060","number":1060,"state":"open","locked":false,"title":"Travis Style Check Support","user":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars2.githubusercontent.com/u/4192761?v=4","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"body":"This provides for us to enable [Travis CI](http://travis-ci.org) for pull request checking. Particularly this adds support for us to start using `rake` along with a few tasks:\r\n\r\n* `rake clean` -- A stub to clean the repository up after a cluster build\r\n* `rake style` -- Runs all `style:*` verbos checks\r\n* `rake style:diff` -- Provides if your repo improves or degrades style (a quick go/no-go one can run)\r\n* `rake style:foodcritic` -- foodcritic for all cookbooks\r\n* `rake style:rubocop` -- RuboCop\r\n\r\nI have tested this with TravisCI ensuring we improve or at least maintain style quality every commit. As soon as this goes into master, I can work with the Bloomberg organization owners to enable chef-bach for TravisCI.","created_at":"2018-01-02T07:11:36Z","updated_at":"2018-02-25T19:46:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"273b120de79b46f1b5b3153d5729eb2d063c81d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":158548109,"url":"https://api.github.com/repos/bloomberg/chef-bach/labels/Chef","name":"Chef","color":"fbca04","default":false},{"id":223411940,"url":"https://api.github.com/repos/bloomberg/chef-bach/labels/Ready%20to%20Review","name":"Ready to Review","color":"cc317c","default":false},{"id":505051008,"url":"https://api.github.com/repos/bloomberg/chef-bach/labels/Ruby","name":"Ruby","color":"006b75","default":false},{"id":371372399,"url":"https://api.github.com/repos/bloomberg/chef-bach/labels/Test","name":"Test","color":"fbca04","default":false},{"id":354884503,"url":"https://api.github.com/repos/bloomberg/chef-bach/labels/Tools","name":"Tools","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1060/commits","review_comments_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1060/comments","review_comment_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/1060/comments","statuses_url":"https://api.github.com/repos/bloomberg/chef-bach/statuses/84171099f9b9d50521adf57df1f57717f9b55bbd","head":{"label":"cbaenziger:travis","ref":"travis","sha":"84171099f9b9d50521adf57df1f57717f9b55bbd","user":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars2.githubusercontent.com/u/4192761?v=4","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"repo":{"id":25824446,"name":"chef-bach","full_name":"cbaenziger/chef-bach","owner":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars2.githubusercontent.com/u/4192761?v=4","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbaenziger/chef-bach","description":"Chef recipes for Bloomberg's deployment of Hadoop and related components","fork":true,"url":"https://api.github.com/repos/cbaenziger/chef-bach","forks_url":"https://api.github.com/repos/cbaenziger/chef-bach/forks","keys_url":"https://api.github.com/repos/cbaenziger/chef-bach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbaenziger/chef-bach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbaenziger/chef-bach/teams","hooks_url":"https://api.github.com/repos/cbaenziger/chef-bach/hooks","issue_events_url":"https://api.github.com/repos/cbaenziger/chef-bach/issues/events{/number}","events_url":"https://api.github.com/repos/cbaenziger/chef-bach/events","assignees_url":"https://api.github.com/repos/cbaenziger/chef-bach/assignees{/user}","branches_url":"https://api.github.com/repos/cbaenziger/chef-bach/branches{/branch}","tags_url":"https://api.github.com/repos/cbaenziger/chef-bach/tags","blobs_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbaenziger/chef-bach/statuses/{sha}","languages_url":"https://api.github.com/repos/cbaenziger/chef-bach/languages","stargazers_url":"https://api.github.com/repos/cbaenziger/chef-bach/stargazers","contributors_url":"https://api.github.com/repos/cbaenziger/chef-bach/contributors","subscribers_url":"https://api.github.com/repos/cbaenziger/chef-bach/subscribers","subscription_url":"https://api.github.com/repos/cbaenziger/chef-bach/subscription","commits_url":"https://api.github.com/repos/cbaenziger/chef-bach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbaenziger/chef-bach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbaenziger/chef-bach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbaenziger/chef-bach/contents/{+path}","compare_url":"https://api.github.com/repos/cbaenziger/chef-bach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbaenziger/chef-bach/merges","archive_url":"https://api.github.com/repos/cbaenziger/chef-bach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbaenziger/chef-bach/downloads","issues_url":"https://api.github.com/repos/cbaenziger/chef-bach/issues{/number}","pulls_url":"https://api.github.com/repos/cbaenziger/chef-bach/pulls{/number}","milestones_url":"https://api.github.com/repos/cbaenziger/chef-bach/milestones{/number}","notifications_url":"https://api.github.com/repos/cbaenziger/chef-bach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbaenziger/chef-bach/labels{/name}","releases_url":"https://api.github.com/repos/cbaenziger/chef-bach/releases{/id}","deployments_url":"https://api.github.com/repos/cbaenziger/chef-bach/deployments","created_at":"2014-10-27T15:02:22Z","updated_at":"2016-02-09T02:12:36Z","pushed_at":"2018-02-23T23:47:18Z","git_url":"git://github.com/cbaenziger/chef-bach.git","ssh_url":"git@github.com:cbaenziger/chef-bach.git","clone_url":"https://github.com/cbaenziger/chef-bach.git","svn_url":"https://github.com/cbaenziger/chef-bach","homepage":null,"size":5270,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"5e18e6c018d3ec49e08442ab0b85fdaffd45916f","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars2.githubusercontent.com/u/1416818?v=4","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":24933148,"name":"chef-bach","full_name":"bloomberg/chef-bach","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars2.githubusercontent.com/u/1416818?v=4","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/chef-bach","description":"Chef recipes for Bloomberg's deployment of Hadoop and related components","fork":false,"url":"https://api.github.com/repos/bloomberg/chef-bach","forks_url":"https://api.github.com/repos/bloomberg/chef-bach/forks","keys_url":"https://api.github.com/repos/bloomberg/chef-bach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/chef-bach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/chef-bach/teams","hooks_url":"https://api.github.com/repos/bloomberg/chef-bach/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/chef-bach/events","assignees_url":"https://api.github.com/repos/bloomberg/chef-bach/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/chef-bach/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/chef-bach/tags","blobs_url":"https://api.github.com/repos/bloomberg/chef-bach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/chef-bach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/chef-bach/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/chef-bach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/chef-bach/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/chef-bach/languages","stargazers_url":"https://api.github.com/repos/bloomberg/chef-bach/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/chef-bach/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/chef-bach/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/chef-bach/subscription","commits_url":"https://api.github.com/repos/bloomberg/chef-bach/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/chef-bach/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/chef-bach/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/chef-bach/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/chef-bach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/chef-bach/merges","archive_url":"https://api.github.com/repos/bloomberg/chef-bach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/chef-bach/downloads","issues_url":"https://api.github.com/repos/bloomberg/chef-bach/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/chef-bach/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/chef-bach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/chef-bach/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/chef-bach/releases{/id}","deployments_url":"https://api.github.com/repos/bloomberg/chef-bach/deployments","created_at":"2014-10-08T09:16:26Z","updated_at":"2018-02-02T13:05:03Z","pushed_at":"2018-02-23T23:49:44Z","git_url":"git://github.com/bloomberg/chef-bach.git","ssh_url":"git@github.com:bloomberg/chef-bach.git","clone_url":"https://github.com/bloomberg/chef-bach.git","svn_url":"https://github.com/bloomberg/chef-bach","homepage":null,"size":6068,"stargazers_count":55,"watchers_count":55,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":55,"open_issues":146,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1060"},"html":{"href":"https://github.com/bloomberg/chef-bach/pull/1060"},"issue":{"href":"https://api.github.com/repos/bloomberg/chef-bach/issues/1060"},"comments":{"href":"https://api.github.com/repos/bloomberg/chef-bach/issues/1060/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1060/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1060/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/chef-bach/statuses/84171099f9b9d50521adf57df1f57717f9b55bbd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cbaenziger"}}