{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/comments/224991211","pull_request_review_id":164497025,"id":224991211,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk5MTIxMQ==","diff_hunk":"@@ -41,33 +44,40 @@\n     \"walk-sync\": \"^0.3.0\"\n   },\n   \"devDependencies\": {\n-    \"broccoli-asset-rev\": \"^2.4.5\",\n+    \"@ember/optional-features\": \"^0.6.3\",\n+    \"broccoli-asset-rev\": \"^2.7.0\",\n     \"chai\": \"^4.0.2\",\n-    \"ember-cli\": \"~2.16.0\",\n-    \"ember-cli-babel\": \"^6.8.2\",\n+    \"ember-cli\": \"~3.4.3\",\n+    \"ember-cli-babel\": \"^6.16.0\",\n     \"ember-cli-blueprint-test-helpers\": \"^0.18.0\",\n-    \"ember-cli-dependency-checker\": \"^2.0.0\",\n-    \"ember-cli-htmlbars\": \"^2.0.2\",\n-    \"ember-cli-htmlbars-inline-precompile\": \"^1.0.0\",\n-    \"ember-cli-inject-live-reload\": \"^1.4.1\",\n-    \"ember-cli-qunit\": \"^4.0.1\",\n-    \"ember-cli-shims\": \"^1.1.0\",\n-    \"ember-cli-sri\": \"^2.1.0\",\n-    \"ember-cli-uglify\": \"^2.0.0\",\n-    \"ember-disable-prototype-extensions\": \"^1.1.0\",\n+    \"ember-cli-dependency-checker\": \"^3.0.0\",\n+    \"ember-cli-htmlbars\": \"^3.0.0\",\n+    \"ember-cli-htmlbars-inline-precompile\": \"^1.0.3\",\n+    \"ember-cli-inject-live-reload\": \"^1.8.2\",\n+    \"ember-cli-qunit\": \"^4.3.2\",\n+    \"ember-cli-sri\": \"^2.1.1\",\n+    \"ember-cli-template-lint\": \"^1.0.0-beta.1\",\n+    \"ember-cli-uglify\": \"^2.1.0\",\n+    \"ember-disable-prototype-extensions\": \"^1.1.3\",\n     \"ember-export-application-global\": \"^2.0.0\",\n-    \"ember-load-initializers\": \"^1.0.0\",\n-    \"ember-resolver\": \"^4.0.0\",\n-    \"ember-source\": \"~2.18.0\",\n+    \"ember-load-initializers\": \"^1.1.0\",\n+    \"ember-maybe-import-regenerator\": \"^0.1.6\",\n+    \"ember-resolver\": \"^5.0.1\",\n+    \"ember-source\": \"~3.4.0\",\n+    \"ember-source-channel-url\": \"^1.1.0\",\n+    \"ember-try\": \"^1.0.0\",\n     \"es6-promise\": \"^4.0.0\",\n+    \"eslint-plugin-ember\": \"^5.2.0\",\n+    \"eslint-plugin-node\": \"^7.0.1\",\n     \"express\": \"^4.12.3\",\n     \"fs-extra\": \"^5.0.0\",\n-    \"loader.js\": \"^4.2.3\",\n+    \"loader.js\": \"^4.7.0\",\n     \"mocha\": \"^5.0.0\",\n+    \"qunit-dom\": \"^0.7.1\",\n     \"testdouble\": \"^3.1.0\"\n   },\n   \"engines\": {\n-    \"node\": \">= 4.0\"\n+    \"node\": \"6.* || 8.* || >= 10.*\"","path":"package.json","position":99,"original_position":99,"commit_id":"5a0f807fd61f06acb2a1f98c8089fed9725a53fe","original_commit_id":"5a0f807fd61f06acb2a1f98c8089fed9725a53fe","user":{"login":"Gaurav0","id":313960,"node_id":"MDQ6VXNlcjMxMzk2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/313960?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaurav0","html_url":"https://github.com/Gaurav0","followers_url":"https://api.github.com/users/Gaurav0/followers","following_url":"https://api.github.com/users/Gaurav0/following{/other_user}","gists_url":"https://api.github.com/users/Gaurav0/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaurav0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaurav0/subscriptions","organizations_url":"https://api.github.com/users/Gaurav0/orgs","repos_url":"https://api.github.com/users/Gaurav0/repos","events_url":"https://api.github.com/users/Gaurav0/events{/privacy}","received_events_url":"https://api.github.com/users/Gaurav0/received_events","type":"User","site_admin":false},"body":"Ok, will break out.","created_at":"2018-10-14T12:37:38Z","updated_at":"2018-10-14T12:37:39Z","html_url":"https://github.com/ember-cli/ember-cli-eslint/pull/251#discussion_r224991211","pull_request_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/251","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/comments/224991211"},"html":{"href":"https://github.com/ember-cli/ember-cli-eslint/pull/251#discussion_r224991211"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/251"}},"in_reply_to_id":224968065},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/251","id":222528959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTI4OTU5","html_url":"https://github.com/ember-cli/ember-cli-eslint/pull/251","diff_url":"https://github.com/ember-cli/ember-cli-eslint/pull/251.diff","patch_url":"https://github.com/ember-cli/ember-cli-eslint/pull/251.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/251","number":251,"state":"open","locked":false,"title":"Upgrade to ember cli 3.4 via ember-cli-update","user":{"login":"Gaurav0","id":313960,"node_id":"MDQ6VXNlcjMxMzk2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/313960?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaurav0","html_url":"https://github.com/Gaurav0","followers_url":"https://api.github.com/users/Gaurav0/followers","following_url":"https://api.github.com/users/Gaurav0/following{/other_user}","gists_url":"https://api.github.com/users/Gaurav0/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaurav0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaurav0/subscriptions","organizations_url":"https://api.github.com/users/Gaurav0/orgs","repos_url":"https://api.github.com/users/Gaurav0/repos","events_url":"https://api.github.com/users/Gaurav0/events{/privacy}","received_events_url":"https://api.github.com/users/Gaurav0/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-12T17:01:50Z","updated_at":"2018-10-14T12:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b96785f390ec557da8e9dc551146a2ce8c0a214b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":595620790,"node_id":"MDU6TGFiZWw1OTU2MjA3OTA=","url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/labels/breaking","name":"breaking","color":"fc2929","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/251/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/251/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/251/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/statuses/5a0f807fd61f06acb2a1f98c8089fed9725a53fe","head":{"label":"Gaurav0:upgrade_to_ember_cli_3_4","ref":"upgrade_to_ember_cli_3_4","sha":"5a0f807fd61f06acb2a1f98c8089fed9725a53fe","user":{"login":"Gaurav0","id":313960,"node_id":"MDQ6VXNlcjMxMzk2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/313960?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaurav0","html_url":"https://github.com/Gaurav0","followers_url":"https://api.github.com/users/Gaurav0/followers","following_url":"https://api.github.com/users/Gaurav0/following{/other_user}","gists_url":"https://api.github.com/users/Gaurav0/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaurav0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaurav0/subscriptions","organizations_url":"https://api.github.com/users/Gaurav0/orgs","repos_url":"https://api.github.com/users/Gaurav0/repos","events_url":"https://api.github.com/users/Gaurav0/events{/privacy}","received_events_url":"https://api.github.com/users/Gaurav0/received_events","type":"User","site_admin":false},"repo":{"id":152782509,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3ODI1MDk=","name":"ember-cli-eslint","full_name":"Gaurav0/ember-cli-eslint","private":false,"owner":{"login":"Gaurav0","id":313960,"node_id":"MDQ6VXNlcjMxMzk2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/313960?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaurav0","html_url":"https://github.com/Gaurav0","followers_url":"https://api.github.com/users/Gaurav0/followers","following_url":"https://api.github.com/users/Gaurav0/following{/other_user}","gists_url":"https://api.github.com/users/Gaurav0/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaurav0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaurav0/subscriptions","organizations_url":"https://api.github.com/users/Gaurav0/orgs","repos_url":"https://api.github.com/users/Gaurav0/repos","events_url":"https://api.github.com/users/Gaurav0/events{/privacy}","received_events_url":"https://api.github.com/users/Gaurav0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Gaurav0/ember-cli-eslint","description":"Ember CLI addon for linting Ember projects with ESLint","fork":true,"url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint","forks_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/forks","keys_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/teams","hooks_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/hooks","issue_events_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/events","assignees_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/tags","blobs_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/languages","stargazers_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/stargazers","contributors_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/contributors","subscribers_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/subscribers","subscription_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/subscription","commits_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/merges","archive_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/downloads","issues_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/labels{/name}","releases_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/Gaurav0/ember-cli-eslint/deployments","created_at":"2018-10-12T16:59:53Z","updated_at":"2018-10-12T16:59:55Z","pushed_at":"2018-10-12T17:23:13Z","git_url":"git://github.com/Gaurav0/ember-cli-eslint.git","ssh_url":"git@github.com:Gaurav0/ember-cli-eslint.git","clone_url":"https://github.com/Gaurav0/ember-cli-eslint.git","svn_url":"https://github.com/Gaurav0/ember-cli-eslint","homepage":"","size":1457,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"b8bb52c75c24681892414cc24bf831b3621fd3ca","user":{"login":"ember-cli","id":10262982,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjYyOTgy","avatar_url":"https://avatars3.githubusercontent.com/u/10262982?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":30788414,"node_id":"MDEwOlJlcG9zaXRvcnkzMDc4ODQxNA==","name":"ember-cli-eslint","full_name":"ember-cli/ember-cli-eslint","private":false,"owner":{"login":"ember-cli","id":10262982,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjYyOTgy","avatar_url":"https://avatars3.githubusercontent.com/u/10262982?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ember-cli/ember-cli-eslint","description":"Ember CLI addon for linting Ember projects with ESLint","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli-eslint","forks_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/deployments","created_at":"2015-02-14T05:45:40Z","updated_at":"2018-08-03T06:42:17Z","pushed_at":"2018-10-13T12:51:24Z","git_url":"git://github.com/ember-cli/ember-cli-eslint.git","ssh_url":"git@github.com:ember-cli/ember-cli-eslint.git","clone_url":"https://github.com/ember-cli/ember-cli-eslint.git","svn_url":"https://github.com/ember-cli/ember-cli-eslint","homepage":"","size":293,"stargazers_count":113,"watchers_count":113,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":48,"open_issues":19,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/251"},"html":{"href":"https://github.com/ember-cli/ember-cli-eslint/pull/251"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/251"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/statuses/5a0f807fd61f06acb2a1f98c8089fed9725a53fe"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Gaurav0"}}