{"action":"created","issue":{"url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/146","repository_url":"https://api.github.com/repos/Wohlstand/libADLMIDI","labels_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/146/comments","events_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/146/events","html_url":"https://github.com/Wohlstand/libADLMIDI/pull/146","id":345645060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzE4ODY0","number":146,"title":"hide private symbols","user":{"login":"jpcima","id":17614485,"node_id":"MDQ6VXNlcjE3NjE0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/17614485?v=4","gravatar_id":"","url":"https://api.github.com/users/jpcima","html_url":"https://github.com/jpcima","followers_url":"https://api.github.com/users/jpcima/followers","following_url":"https://api.github.com/users/jpcima/following{/other_user}","gists_url":"https://api.github.com/users/jpcima/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcima/subscriptions","organizations_url":"https://api.github.com/users/jpcima/orgs","repos_url":"https://api.github.com/users/jpcima/repos","events_url":"https://api.github.com/users/jpcima/events{/privacy}","received_events_url":"https://api.github.com/users/jpcima/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-30T07:40:02Z","updated_at":"2018-07-30T08:17:25Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/146","html_url":"https://github.com/Wohlstand/libADLMIDI/pull/146","diff_url":"https://github.com/Wohlstand/libADLMIDI/pull/146.diff","patch_url":"https://github.com/Wohlstand/libADLMIDI/pull/146.patch"},"body":"This makes the internal symbols of the library hidden.\r\n\r\nIt's an attempt for me to fix the case of having libADLMIDI and a copy of Measurer in the same program without clashes of symbols.\r\nWhen kode54 made the latest changes, importing them in VST has crashed it, because both my program and library have Dosbox OPL, but now they have differed and the structure layout was changed.\r\n(it suggest my program was picking the Dosbox OPL of libADLMIDI and has smashed my stack because of this)\r\n\r\nIn case of GCC, it forces the static library to emit only the public symbols. (needs CMake 3.3+, hence a bump of version)\r\nOn MSVC and others I don't know what can happen: there is not an equivalent to my knowledge of visibility attributes (it's only for DLL). Maybe you know better what to do about this."},"comment":{"url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/comments/408784245","html_url":"https://github.com/Wohlstand/libADLMIDI/pull/146#issuecomment-408784245","issue_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/146","id":408784245,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODc4NDI0NQ==","user":{"login":"jpcima","id":17614485,"node_id":"MDQ6VXNlcjE3NjE0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/17614485?v=4","gravatar_id":"","url":"https://api.github.com/users/jpcima","html_url":"https://github.com/jpcima","followers_url":"https://api.github.com/users/jpcima/followers","following_url":"https://api.github.com/users/jpcima/following{/other_user}","gists_url":"https://api.github.com/users/jpcima/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcima/subscriptions","organizations_url":"https://api.github.com/users/jpcima/orgs","repos_url":"https://api.github.com/users/jpcima/repos","events_url":"https://api.github.com/users/jpcima/events{/privacy}","received_events_url":"https://api.github.com/users/jpcima/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T08:17:25Z","updated_at":"2018-07-30T08:17:25Z","author_association":"COLLABORATOR","body":"Other strategy, in a way which is compatible with cmake 3.2.\r\nGCC and Clang support only"}}
{"actor":{"display_login":"jpcima"}}