{"action":"created","issue":{"url":"https://api.github.com/repos/lofar-astron/DP3/issues/44","repository_url":"https://api.github.com/repos/lofar-astron/DP3","labels_url":"https://api.github.com/repos/lofar-astron/DP3/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/lofar-astron/DP3/issues/44/comments","events_url":"https://api.github.com/repos/lofar-astron/DP3/issues/44/events","html_url":"https://github.com/lofar-astron/DP3/issues/44","id":365608020,"node_id":"MDU6SXNzdWUzNjU2MDgwMjA=","number":44,"title":"DPPP doesn't write flags in h5parm","user":{"login":"revoltek","id":4458741,"node_id":"MDQ6VXNlcjQ0NTg3NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/4458741?v=4","gravatar_id":"","url":"https://api.github.com/users/revoltek","html_url":"https://github.com/revoltek","followers_url":"https://api.github.com/users/revoltek/followers","following_url":"https://api.github.com/users/revoltek/following{/other_user}","gists_url":"https://api.github.com/users/revoltek/gists{/gist_id}","starred_url":"https://api.github.com/users/revoltek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revoltek/subscriptions","organizations_url":"https://api.github.com/users/revoltek/orgs","repos_url":"https://api.github.com/users/revoltek/repos","events_url":"https://api.github.com/users/revoltek/events{/privacy}","received_events_url":"https://api.github.com/users/revoltek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-01T19:28:31Z","updated_at":"2018-10-03T14:55:21Z","closed_at":null,"author_association":"NONE","body":"Some combinations of solver+mode do not properly handle flags (i.e. the solver doesn't write any flag). So far I noticed it in DDE+diag and in DIE+fulljones. A check of all modes in both solvers should be done to be sure that flags are always properly saved in h5parms.\r\n\r\nAt the same time, it would be good to also check if applycal properly propagates all flags back to the MS, this was not the case for a few modes, but needs to be there for all of them."},"comment":{"url":"https://api.github.com/repos/lofar-astron/DP3/issues/comments/426668191","html_url":"https://github.com/lofar-astron/DP3/issues/44#issuecomment-426668191","issue_url":"https://api.github.com/repos/lofar-astron/DP3/issues/44","id":426668191,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjY2ODE5MQ==","user":{"login":"revoltek","id":4458741,"node_id":"MDQ6VXNlcjQ0NTg3NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/4458741?v=4","gravatar_id":"","url":"https://api.github.com/users/revoltek","html_url":"https://github.com/revoltek","followers_url":"https://api.github.com/users/revoltek/followers","following_url":"https://api.github.com/users/revoltek/following{/other_user}","gists_url":"https://api.github.com/users/revoltek/gists{/gist_id}","starred_url":"https://api.github.com/users/revoltek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revoltek/subscriptions","organizations_url":"https://api.github.com/users/revoltek/orgs","repos_url":"https://api.github.com/users/revoltek/repos","events_url":"https://api.github.com/users/revoltek/events{/privacy}","received_events_url":"https://api.github.com/users/revoltek/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T14:55:21Z","updated_at":"2018-10-03T14:55:21Z","author_association":"NONE","body":"hum, that is something to discuss, I agree. But it would require some major change in the way h5parms are used. So fare we have always assumed that weight=0 is a flagged data. Now to use dppp-generated h5parms we need to manually set to weight=0 those nans."}}
{"actor":{"display_login":"revoltek"}}