{"action":"closed","number":1613,"pull_request":{"url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/1613","id":181225577,"html_url":"https://github.com/studentinsights/studentinsights/pull/1613","diff_url":"https://github.com/studentinsights/studentinsights/pull/1613.diff","patch_url":"https://github.com/studentinsights/studentinsights/pull/1613.patch","issue_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/1613","number":1613,"state":"closed","locked":false,"title":"Update Delayed::Job failures modes","user":{"login":"kevinrobinson","id":1056957,"avatar_url":"https://avatars3.githubusercontent.com/u/1056957?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinrobinson","html_url":"https://github.com/kevinrobinson","followers_url":"https://api.github.com/users/kevinrobinson/followers","following_url":"https://api.github.com/users/kevinrobinson/following{/other_user}","gists_url":"https://api.github.com/users/kevinrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrobinson/subscriptions","organizations_url":"https://api.github.com/users/kevinrobinson/orgs","repos_url":"https://api.github.com/users/kevinrobinson/repos","events_url":"https://api.github.com/users/kevinrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrobinson/received_events","type":"User","site_admin":false},"body":"# Who is this PR for?\r\nNB educators\r\n\r\n# What problem does this PR fix?\r\nNB import jobs have been failing, and repeatedly retrying and failing.  We haven't been notified of these, and they haven't healed themselves because the root problem is still active.\r\n\r\n# What does this PR do?\r\nChanges the tuning for Delayed::Job to get different behavior in failure modes (see comments in code) and adds in email notifications on import job failures (although these aren't currently working, which we need to look at separately).\r\n\r\nI'll verify this manually - deploy, run the import, clear the job queue, and then try killings some import tasks to see this behaves as expected.\r\n\r\nAfter that we should be stable and can look at the actual issue with the import and why it's running out of memory.","created_at":"2018-04-12T14:38:56Z","updated_at":"2018-04-13T00:46:34Z","closed_at":"2018-04-13T00:46:34Z","merged_at":"2018-04-13T00:46:34Z","merge_commit_sha":"57e51a0472c6ae81dccae75aef68bf18f0d7d34d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/1613/commits","review_comments_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/1613/comments","review_comment_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/comments{/number}","comments_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/1613/comments","statuses_url":"https://api.github.com/repos/studentinsights/studentinsights/statuses/81cdf096f9845a8d9eeda2c950a85c4d44481542","head":{"label":"studentinsights:tune/delayed-job-failure-modes","ref":"tune/delayed-job-failure-modes","sha":"81cdf096f9845a8d9eeda2c950a85c4d44481542","user":{"login":"studentinsights","id":17129837,"avatar_url":"https://avatars2.githubusercontent.com/u/17129837?v=4","gravatar_id":"","url":"https://api.github.com/users/studentinsights","html_url":"https://github.com/studentinsights","followers_url":"https://api.github.com/users/studentinsights/followers","following_url":"https://api.github.com/users/studentinsights/following{/other_user}","gists_url":"https://api.github.com/users/studentinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/studentinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studentinsights/subscriptions","organizations_url":"https://api.github.com/users/studentinsights/orgs","repos_url":"https://api.github.com/users/studentinsights/repos","events_url":"https://api.github.com/users/studentinsights/events{/privacy}","received_events_url":"https://api.github.com/users/studentinsights/received_events","type":"Organization","site_admin":false},"repo":{"id":51324046,"name":"studentinsights","full_name":"studentinsights/studentinsights","owner":{"login":"studentinsights","id":17129837,"avatar_url":"https://avatars2.githubusercontent.com/u/17129837?v=4","gravatar_id":"","url":"https://api.github.com/users/studentinsights","html_url":"https://github.com/studentinsights","followers_url":"https://api.github.com/users/studentinsights/followers","following_url":"https://api.github.com/users/studentinsights/following{/other_user}","gists_url":"https://api.github.com/users/studentinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/studentinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studentinsights/subscriptions","organizations_url":"https://api.github.com/users/studentinsights/orgs","repos_url":"https://api.github.com/users/studentinsights/repos","events_url":"https://api.github.com/users/studentinsights/events{/privacy}","received_events_url":"https://api.github.com/users/studentinsights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/studentinsights/studentinsights","description":"Student Insights for Somerville educators","fork":false,"url":"https://api.github.com/repos/studentinsights/studentinsights","forks_url":"https://api.github.com/repos/studentinsights/studentinsights/forks","keys_url":"https://api.github.com/repos/studentinsights/studentinsights/keys{/key_id}","collaborators_url":"https://api.github.com/repos/studentinsights/studentinsights/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/studentinsights/studentinsights/teams","hooks_url":"https://api.github.com/repos/studentinsights/studentinsights/hooks","issue_events_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/events{/number}","events_url":"https://api.github.com/repos/studentinsights/studentinsights/events","assignees_url":"https://api.github.com/repos/studentinsights/studentinsights/assignees{/user}","branches_url":"https://api.github.com/repos/studentinsights/studentinsights/branches{/branch}","tags_url":"https://api.github.com/repos/studentinsights/studentinsights/tags","blobs_url":"https://api.github.com/repos/studentinsights/studentinsights/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/studentinsights/studentinsights/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/studentinsights/studentinsights/git/refs{/sha}","trees_url":"https://api.github.com/repos/studentinsights/studentinsights/git/trees{/sha}","statuses_url":"https://api.github.com/repos/studentinsights/studentinsights/statuses/{sha}","languages_url":"https://api.github.com/repos/studentinsights/studentinsights/languages","stargazers_url":"https://api.github.com/repos/studentinsights/studentinsights/stargazers","contributors_url":"https://api.github.com/repos/studentinsights/studentinsights/contributors","subscribers_url":"https://api.github.com/repos/studentinsights/studentinsights/subscribers","subscription_url":"https://api.github.com/repos/studentinsights/studentinsights/subscription","commits_url":"https://api.github.com/repos/studentinsights/studentinsights/commits{/sha}","git_commits_url":"https://api.github.com/repos/studentinsights/studentinsights/git/commits{/sha}","comments_url":"https://api.github.com/repos/studentinsights/studentinsights/comments{/number}","issue_comment_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/comments{/number}","contents_url":"https://api.github.com/repos/studentinsights/studentinsights/contents/{+path}","compare_url":"https://api.github.com/repos/studentinsights/studentinsights/compare/{base}...{head}","merges_url":"https://api.github.com/repos/studentinsights/studentinsights/merges","archive_url":"https://api.github.com/repos/studentinsights/studentinsights/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/studentinsights/studentinsights/downloads","issues_url":"https://api.github.com/repos/studentinsights/studentinsights/issues{/number}","pulls_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls{/number}","milestones_url":"https://api.github.com/repos/studentinsights/studentinsights/milestones{/number}","notifications_url":"https://api.github.com/repos/studentinsights/studentinsights/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/studentinsights/studentinsights/labels{/name}","releases_url":"https://api.github.com/repos/studentinsights/studentinsights/releases{/id}","deployments_url":"https://api.github.com/repos/studentinsights/studentinsights/deployments","created_at":"2016-02-08T20:15:35Z","updated_at":"2018-04-13T00:38:49Z","pushed_at":"2018-04-13T00:46:34Z","git_url":"git://github.com/studentinsights/studentinsights.git","ssh_url":"git@github.com:studentinsights/studentinsights.git","clone_url":"https://github.com/studentinsights/studentinsights.git","svn_url":"https://github.com/studentinsights/studentinsights","homepage":"https://somerville-teacher-tool-demo.herokuapp.com/","size":17248,"stargazers_count":87,"watchers_count":87,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":84,"watchers":87,"default_branch":"master"}},"base":{"label":"studentinsights:master","ref":"master","sha":"d421eaa8d6d7e01d1076bc78a243c8042f9cbdf2","user":{"login":"studentinsights","id":17129837,"avatar_url":"https://avatars2.githubusercontent.com/u/17129837?v=4","gravatar_id":"","url":"https://api.github.com/users/studentinsights","html_url":"https://github.com/studentinsights","followers_url":"https://api.github.com/users/studentinsights/followers","following_url":"https://api.github.com/users/studentinsights/following{/other_user}","gists_url":"https://api.github.com/users/studentinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/studentinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studentinsights/subscriptions","organizations_url":"https://api.github.com/users/studentinsights/orgs","repos_url":"https://api.github.com/users/studentinsights/repos","events_url":"https://api.github.com/users/studentinsights/events{/privacy}","received_events_url":"https://api.github.com/users/studentinsights/received_events","type":"Organization","site_admin":false},"repo":{"id":51324046,"name":"studentinsights","full_name":"studentinsights/studentinsights","owner":{"login":"studentinsights","id":17129837,"avatar_url":"https://avatars2.githubusercontent.com/u/17129837?v=4","gravatar_id":"","url":"https://api.github.com/users/studentinsights","html_url":"https://github.com/studentinsights","followers_url":"https://api.github.com/users/studentinsights/followers","following_url":"https://api.github.com/users/studentinsights/following{/other_user}","gists_url":"https://api.github.com/users/studentinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/studentinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studentinsights/subscriptions","organizations_url":"https://api.github.com/users/studentinsights/orgs","repos_url":"https://api.github.com/users/studentinsights/repos","events_url":"https://api.github.com/users/studentinsights/events{/privacy}","received_events_url":"https://api.github.com/users/studentinsights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/studentinsights/studentinsights","description":"Student Insights for Somerville educators","fork":false,"url":"https://api.github.com/repos/studentinsights/studentinsights","forks_url":"https://api.github.com/repos/studentinsights/studentinsights/forks","keys_url":"https://api.github.com/repos/studentinsights/studentinsights/keys{/key_id}","collaborators_url":"https://api.github.com/repos/studentinsights/studentinsights/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/studentinsights/studentinsights/teams","hooks_url":"https://api.github.com/repos/studentinsights/studentinsights/hooks","issue_events_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/events{/number}","events_url":"https://api.github.com/repos/studentinsights/studentinsights/events","assignees_url":"https://api.github.com/repos/studentinsights/studentinsights/assignees{/user}","branches_url":"https://api.github.com/repos/studentinsights/studentinsights/branches{/branch}","tags_url":"https://api.github.com/repos/studentinsights/studentinsights/tags","blobs_url":"https://api.github.com/repos/studentinsights/studentinsights/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/studentinsights/studentinsights/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/studentinsights/studentinsights/git/refs{/sha}","trees_url":"https://api.github.com/repos/studentinsights/studentinsights/git/trees{/sha}","statuses_url":"https://api.github.com/repos/studentinsights/studentinsights/statuses/{sha}","languages_url":"https://api.github.com/repos/studentinsights/studentinsights/languages","stargazers_url":"https://api.github.com/repos/studentinsights/studentinsights/stargazers","contributors_url":"https://api.github.com/repos/studentinsights/studentinsights/contributors","subscribers_url":"https://api.github.com/repos/studentinsights/studentinsights/subscribers","subscription_url":"https://api.github.com/repos/studentinsights/studentinsights/subscription","commits_url":"https://api.github.com/repos/studentinsights/studentinsights/commits{/sha}","git_commits_url":"https://api.github.com/repos/studentinsights/studentinsights/git/commits{/sha}","comments_url":"https://api.github.com/repos/studentinsights/studentinsights/comments{/number}","issue_comment_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/comments{/number}","contents_url":"https://api.github.com/repos/studentinsights/studentinsights/contents/{+path}","compare_url":"https://api.github.com/repos/studentinsights/studentinsights/compare/{base}...{head}","merges_url":"https://api.github.com/repos/studentinsights/studentinsights/merges","archive_url":"https://api.github.com/repos/studentinsights/studentinsights/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/studentinsights/studentinsights/downloads","issues_url":"https://api.github.com/repos/studentinsights/studentinsights/issues{/number}","pulls_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls{/number}","milestones_url":"https://api.github.com/repos/studentinsights/studentinsights/milestones{/number}","notifications_url":"https://api.github.com/repos/studentinsights/studentinsights/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/studentinsights/studentinsights/labels{/name}","releases_url":"https://api.github.com/repos/studentinsights/studentinsights/releases{/id}","deployments_url":"https://api.github.com/repos/studentinsights/studentinsights/deployments","created_at":"2016-02-08T20:15:35Z","updated_at":"2018-04-13T00:38:49Z","pushed_at":"2018-04-13T00:46:34Z","git_url":"git://github.com/studentinsights/studentinsights.git","ssh_url":"git@github.com:studentinsights/studentinsights.git","clone_url":"https://github.com/studentinsights/studentinsights.git","svn_url":"https://github.com/studentinsights/studentinsights","homepage":"https://somerville-teacher-tool-demo.herokuapp.com/","size":17248,"stargazers_count":87,"watchers_count":87,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":84,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/studentinsights/studentinsights/pulls/1613"},"html":{"href":"https://github.com/studentinsights/studentinsights/pull/1613"},"issue":{"href":"https://api.github.com/repos/studentinsights/studentinsights/issues/1613"},"comments":{"href":"https://api.github.com/repos/studentinsights/studentinsights/issues/1613/comments"},"review_comments":{"href":"https://api.github.com/repos/studentinsights/studentinsights/pulls/1613/comments"},"review_comment":{"href":"https://api.github.com/repos/studentinsights/studentinsights/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/studentinsights/studentinsights/pulls/1613/commits"},"statuses":{"href":"https://api.github.com/repos/studentinsights/studentinsights/statuses/81cdf096f9845a8d9eeda2c950a85c4d44481542"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alexsoble","id":3209501,"avatar_url":"https://avatars3.githubusercontent.com/u/3209501?v=4","gravatar_id":"","url":"https://api.github.com/users/alexsoble","html_url":"https://github.com/alexsoble","followers_url":"https://api.github.com/users/alexsoble/followers","following_url":"https://api.github.com/users/alexsoble/following{/other_user}","gists_url":"https://api.github.com/users/alexsoble/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsoble/subscriptions","organizations_url":"https://api.github.com/users/alexsoble/orgs","repos_url":"https://api.github.com/users/alexsoble/repos","events_url":"https://api.github.com/users/alexsoble/events{/privacy}","received_events_url":"https://api.github.com/users/alexsoble/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":39,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"alexsoble"}}