{"action":"created","comment":{"url":"https://api.github.com/repos/Cognifide/knotx/pulls/comments/187953742","pull_request_review_id":119834544,"id":187953742,"diff_hunk":"@@ -131,4 +131,21 @@ clientOptions {\n \n ```\n In rare situation you can always consult the [Knot.x verticles cheatsheet](https://github.com/Cognifide/knotx/blob/master/documentation/src/main/cheatsheet/cheatsheets.adoc)\n-to find all available configuration options.\n\\ No newline at end of file\n+to find all available configuration options.\n+\n+### System properties","path":"documentation/src/main/wiki/Configuration.md","position":8,"original_position":8,"commit_id":"4c94c22b9b4fd0f2f71cee99a1e65f093f85e924","original_commit_id":"4c94c22b9b4fd0f2f71cee99a1e65f093f85e924","user":{"login":"Skejven","id":19705838,"avatar_url":"https://avatars3.githubusercontent.com/u/19705838?v=4","gravatar_id":"","url":"https://api.github.com/users/Skejven","html_url":"https://github.com/Skejven","followers_url":"https://api.github.com/users/Skejven/followers","following_url":"https://api.github.com/users/Skejven/following{/other_user}","gists_url":"https://api.github.com/users/Skejven/gists{/gist_id}","starred_url":"https://api.github.com/users/Skejven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skejven/subscriptions","organizations_url":"https://api.github.com/users/Skejven/orgs","repos_url":"https://api.github.com/users/Skejven/repos","events_url":"https://api.github.com/users/Skejven/events{/privacy}","received_events_url":"https://api.github.com/users/Skejven/received_events","type":"User","site_admin":false},"body":"Maybe this information is worth to be mentioned in changelog and upgrade notes?","created_at":"2018-05-14T13:33:48Z","updated_at":"2018-05-14T13:33:48Z","html_url":"https://github.com/Cognifide/knotx/pull/421#discussion_r187953742","pull_request_url":"https://api.github.com/repos/Cognifide/knotx/pulls/421","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Cognifide/knotx/pulls/comments/187953742"},"html":{"href":"https://github.com/Cognifide/knotx/pull/421#discussion_r187953742"},"pull_request":{"href":"https://api.github.com/repos/Cognifide/knotx/pulls/421"}}},"pull_request":{"url":"https://api.github.com/repos/Cognifide/knotx/pulls/421","id":187759307,"html_url":"https://github.com/Cognifide/knotx/pull/421","diff_url":"https://github.com/Cognifide/knotx/pull/421.diff","patch_url":"https://github.com/Cognifide/knotx/pull/421.patch","issue_url":"https://api.github.com/repos/Cognifide/knotx/issues/421","number":421,"state":"open","locked":false,"title":"Value resolver for hocon that converts the sys prop variable into int…","user":{"login":"marcinczeczko","id":4218395,"avatar_url":"https://avatars3.githubusercontent.com/u/4218395?v=4","gravatar_id":"","url":"https://api.github.com/users/marcinczeczko","html_url":"https://github.com/marcinczeczko","followers_url":"https://api.github.com/users/marcinczeczko/followers","following_url":"https://api.github.com/users/marcinczeczko/following{/other_user}","gists_url":"https://api.github.com/users/marcinczeczko/gists{/gist_id}","starred_url":"https://api.github.com/users/marcinczeczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcinczeczko/subscriptions","organizations_url":"https://api.github.com/users/marcinczeczko/orgs","repos_url":"https://api.github.com/users/marcinczeczko/repos","events_url":"https://api.github.com/users/marcinczeczko/events{/privacy}","received_events_url":"https://api.github.com/users/marcinczeczko/received_events","type":"User","site_admin":false},"body":"\r\n## Description\r\nA HOCON value resolver that's capable of doing value type detection. It should be able to detect Integer, Boolean and finally string based on the value. It's a must have in order to have an ability to merge with JSON having values in those types\r\n\r\n## Motivation and Context\r\nHOCON supports variables resolving from system properties. However, by design it always wraps it as String. However, we're using JSON extensively to configure verticles. Verticle implementations are looking forward for values in type of Integer (e.g. port) or boolean, so there is a need to be able to properly inject those values.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n- [x] My code follows the [code style](https://github.com/Cognifide/knotx/blob/master/CONTRIBUTING.md#coding-conventions) of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\n---\r\nI hereby agree to the terms of the Knot.x Contributor License Agreement.\r\n","created_at":"2018-05-14T08:56:21Z","updated_at":"2018-05-14T13:33:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbb5c0fbab6ed4d2f966ebb336a2bc4a331871f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cognifide/knotx/pulls/421/commits","review_comments_url":"https://api.github.com/repos/Cognifide/knotx/pulls/421/comments","review_comment_url":"https://api.github.com/repos/Cognifide/knotx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cognifide/knotx/issues/421/comments","statuses_url":"https://api.github.com/repos/Cognifide/knotx/statuses/4c94c22b9b4fd0f2f71cee99a1e65f093f85e924","head":{"label":"Cognifide:feature/sysprop-resolve-hocon","ref":"feature/sysprop-resolve-hocon","sha":"4c94c22b9b4fd0f2f71cee99a1e65f093f85e924","user":{"login":"Cognifide","id":932257,"avatar_url":"https://avatars3.githubusercontent.com/u/932257?v=4","gravatar_id":"","url":"https://api.github.com/users/Cognifide","html_url":"https://github.com/Cognifide","followers_url":"https://api.github.com/users/Cognifide/followers","following_url":"https://api.github.com/users/Cognifide/following{/other_user}","gists_url":"https://api.github.com/users/Cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/Cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cognifide/subscriptions","organizations_url":"https://api.github.com/users/Cognifide/orgs","repos_url":"https://api.github.com/users/Cognifide/repos","events_url":"https://api.github.com/users/Cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/Cognifide/received_events","type":"Organization","site_admin":false},"repo":{"id":60755660,"name":"knotx","full_name":"Cognifide/knotx","owner":{"login":"Cognifide","id":932257,"avatar_url":"https://avatars3.githubusercontent.com/u/932257?v=4","gravatar_id":"","url":"https://api.github.com/users/Cognifide","html_url":"https://github.com/Cognifide","followers_url":"https://api.github.com/users/Cognifide/followers","following_url":"https://api.github.com/users/Cognifide/following{/other_user}","gists_url":"https://api.github.com/users/Cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/Cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cognifide/subscriptions","organizations_url":"https://api.github.com/users/Cognifide/orgs","repos_url":"https://api.github.com/users/Cognifide/repos","events_url":"https://api.github.com/users/Cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/Cognifide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cognifide/knotx","description":"Knot.x is a highly-efficient and scalable integration tool for modern websites developed in Java on top of Vert.x framework.","fork":false,"url":"https://api.github.com/repos/Cognifide/knotx","forks_url":"https://api.github.com/repos/Cognifide/knotx/forks","keys_url":"https://api.github.com/repos/Cognifide/knotx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cognifide/knotx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cognifide/knotx/teams","hooks_url":"https://api.github.com/repos/Cognifide/knotx/hooks","issue_events_url":"https://api.github.com/repos/Cognifide/knotx/issues/events{/number}","events_url":"https://api.github.com/repos/Cognifide/knotx/events","assignees_url":"https://api.github.com/repos/Cognifide/knotx/assignees{/user}","branches_url":"https://api.github.com/repos/Cognifide/knotx/branches{/branch}","tags_url":"https://api.github.com/repos/Cognifide/knotx/tags","blobs_url":"https://api.github.com/repos/Cognifide/knotx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cognifide/knotx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cognifide/knotx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cognifide/knotx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cognifide/knotx/statuses/{sha}","languages_url":"https://api.github.com/repos/Cognifide/knotx/languages","stargazers_url":"https://api.github.com/repos/Cognifide/knotx/stargazers","contributors_url":"https://api.github.com/repos/Cognifide/knotx/contributors","subscribers_url":"https://api.github.com/repos/Cognifide/knotx/subscribers","subscription_url":"https://api.github.com/repos/Cognifide/knotx/subscription","commits_url":"https://api.github.com/repos/Cognifide/knotx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cognifide/knotx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cognifide/knotx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cognifide/knotx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cognifide/knotx/contents/{+path}","compare_url":"https://api.github.com/repos/Cognifide/knotx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cognifide/knotx/merges","archive_url":"https://api.github.com/repos/Cognifide/knotx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cognifide/knotx/downloads","issues_url":"https://api.github.com/repos/Cognifide/knotx/issues{/number}","pulls_url":"https://api.github.com/repos/Cognifide/knotx/pulls{/number}","milestones_url":"https://api.github.com/repos/Cognifide/knotx/milestones{/number}","notifications_url":"https://api.github.com/repos/Cognifide/knotx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cognifide/knotx/labels{/name}","releases_url":"https://api.github.com/repos/Cognifide/knotx/releases{/id}","deployments_url":"https://api.github.com/repos/Cognifide/knotx/deployments","created_at":"2016-06-09T07:00:31Z","updated_at":"2018-05-10T12:09:41Z","pushed_at":"2018-05-14T13:28:57Z","git_url":"git://github.com/Cognifide/knotx.git","ssh_url":"git@github.com:Cognifide/knotx.git","clone_url":"https://github.com/Cognifide/knotx.git","svn_url":"https://github.com/Cognifide/knotx","homepage":"","size":14591,"stargazers_count":88,"watchers_count":88,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":25,"watchers":88,"default_branch":"master"}},"base":{"label":"Cognifide:milestone/backpressure-and-configs","ref":"milestone/backpressure-and-configs","sha":"91818c6b10ba633c7f04a5552a4d5ec85cbf0e8a","user":{"login":"Cognifide","id":932257,"avatar_url":"https://avatars3.githubusercontent.com/u/932257?v=4","gravatar_id":"","url":"https://api.github.com/users/Cognifide","html_url":"https://github.com/Cognifide","followers_url":"https://api.github.com/users/Cognifide/followers","following_url":"https://api.github.com/users/Cognifide/following{/other_user}","gists_url":"https://api.github.com/users/Cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/Cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cognifide/subscriptions","organizations_url":"https://api.github.com/users/Cognifide/orgs","repos_url":"https://api.github.com/users/Cognifide/repos","events_url":"https://api.github.com/users/Cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/Cognifide/received_events","type":"Organization","site_admin":false},"repo":{"id":60755660,"name":"knotx","full_name":"Cognifide/knotx","owner":{"login":"Cognifide","id":932257,"avatar_url":"https://avatars3.githubusercontent.com/u/932257?v=4","gravatar_id":"","url":"https://api.github.com/users/Cognifide","html_url":"https://github.com/Cognifide","followers_url":"https://api.github.com/users/Cognifide/followers","following_url":"https://api.github.com/users/Cognifide/following{/other_user}","gists_url":"https://api.github.com/users/Cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/Cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cognifide/subscriptions","organizations_url":"https://api.github.com/users/Cognifide/orgs","repos_url":"https://api.github.com/users/Cognifide/repos","events_url":"https://api.github.com/users/Cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/Cognifide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cognifide/knotx","description":"Knot.x is a highly-efficient and scalable integration tool for modern websites developed in Java on top of Vert.x framework.","fork":false,"url":"https://api.github.com/repos/Cognifide/knotx","forks_url":"https://api.github.com/repos/Cognifide/knotx/forks","keys_url":"https://api.github.com/repos/Cognifide/knotx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cognifide/knotx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cognifide/knotx/teams","hooks_url":"https://api.github.com/repos/Cognifide/knotx/hooks","issue_events_url":"https://api.github.com/repos/Cognifide/knotx/issues/events{/number}","events_url":"https://api.github.com/repos/Cognifide/knotx/events","assignees_url":"https://api.github.com/repos/Cognifide/knotx/assignees{/user}","branches_url":"https://api.github.com/repos/Cognifide/knotx/branches{/branch}","tags_url":"https://api.github.com/repos/Cognifide/knotx/tags","blobs_url":"https://api.github.com/repos/Cognifide/knotx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cognifide/knotx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cognifide/knotx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cognifide/knotx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cognifide/knotx/statuses/{sha}","languages_url":"https://api.github.com/repos/Cognifide/knotx/languages","stargazers_url":"https://api.github.com/repos/Cognifide/knotx/stargazers","contributors_url":"https://api.github.com/repos/Cognifide/knotx/contributors","subscribers_url":"https://api.github.com/repos/Cognifide/knotx/subscribers","subscription_url":"https://api.github.com/repos/Cognifide/knotx/subscription","commits_url":"https://api.github.com/repos/Cognifide/knotx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cognifide/knotx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cognifide/knotx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cognifide/knotx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cognifide/knotx/contents/{+path}","compare_url":"https://api.github.com/repos/Cognifide/knotx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cognifide/knotx/merges","archive_url":"https://api.github.com/repos/Cognifide/knotx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cognifide/knotx/downloads","issues_url":"https://api.github.com/repos/Cognifide/knotx/issues{/number}","pulls_url":"https://api.github.com/repos/Cognifide/knotx/pulls{/number}","milestones_url":"https://api.github.com/repos/Cognifide/knotx/milestones{/number}","notifications_url":"https://api.github.com/repos/Cognifide/knotx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cognifide/knotx/labels{/name}","releases_url":"https://api.github.com/repos/Cognifide/knotx/releases{/id}","deployments_url":"https://api.github.com/repos/Cognifide/knotx/deployments","created_at":"2016-06-09T07:00:31Z","updated_at":"2018-05-10T12:09:41Z","pushed_at":"2018-05-14T13:28:57Z","git_url":"git://github.com/Cognifide/knotx.git","ssh_url":"git@github.com:Cognifide/knotx.git","clone_url":"https://github.com/Cognifide/knotx.git","svn_url":"https://github.com/Cognifide/knotx","homepage":"","size":14591,"stargazers_count":88,"watchers_count":88,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":25,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cognifide/knotx/pulls/421"},"html":{"href":"https://github.com/Cognifide/knotx/pull/421"},"issue":{"href":"https://api.github.com/repos/Cognifide/knotx/issues/421"},"comments":{"href":"https://api.github.com/repos/Cognifide/knotx/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/Cognifide/knotx/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/Cognifide/knotx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cognifide/knotx/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/Cognifide/knotx/statuses/4c94c22b9b4fd0f2f71cee99a1e65f093f85e924"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Skejven"}}