{"action":"created","comment":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/201060919","pull_request_review_id":135488964,"id":201060919,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTA2MDkxOQ==","diff_hunk":"@@ -204,10 +204,29 @@ protected Object getValueInternal(ProgressListener listener) throws Exception {\n             // actually parse the data\n             if (input != null) {\n                 CancellingInputStream is = new CancellingInputStream(input, listener);\n-                return complexPPIO.decode(is);\n+                Object result = complexPPIO.decode(is);\n+                if (result == null || complexPPIO.getType().isInstance(result)) {\n+                    return result;\n+                }\n+                // Some text parsers return a Map when it can not be converted to\n+                // the proper type.  Detect those errors here rather than later.\n+                throw new IllegalArgumentException(\n+                        \"Decoded result is not a \"\n+                                + complexPPIO.getType().getName()\n+                                + \", got a: \"\n+                                + result);","path":"src/extension/wps/wps-core/src/main/java/org/geoserver/wps/executor/RemoteRequestInputProvider.java","position":null,"original_position":15,"commit_id":"1c576a3f4836e6d413741cd81b306c750c307c40","original_commit_id":"37bf5455b2f8051d746b83b398660d8461e947ec","user":{"login":"sikeoka","id":11542093,"node_id":"MDQ6VXNlcjExNTQyMDkz","avatar_url":"https://avatars2.githubusercontent.com/u/11542093?v=4","gravatar_id":"","url":"https://api.github.com/users/sikeoka","html_url":"https://github.com/sikeoka","followers_url":"https://api.github.com/users/sikeoka/followers","following_url":"https://api.github.com/users/sikeoka/following{/other_user}","gists_url":"https://api.github.com/users/sikeoka/gists{/gist_id}","starred_url":"https://api.github.com/users/sikeoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikeoka/subscriptions","organizations_url":"https://api.github.com/users/sikeoka/orgs","repos_url":"https://api.github.com/users/sikeoka/repos","events_url":"https://api.github.com/users/sikeoka/events{/privacy}","received_events_url":"https://api.github.com/users/sikeoka/received_events","type":"User","site_admin":false},"body":"I changed it to show the type of result.","created_at":"2018-07-09T16:12:11Z","updated_at":"2018-07-09T16:12:11Z","html_url":"https://github.com/geoserver/geoserver/pull/2980#discussion_r201060919","pull_request_url":"https://api.github.com/repos/geoserver/geoserver/pulls/2980","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/201060919"},"html":{"href":"https://github.com/geoserver/geoserver/pull/2980#discussion_r201060919"},"pull_request":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/2980"}},"in_reply_to_id":200791147},"pull_request":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/2980","id":199790731,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NzkwNzMx","html_url":"https://github.com/geoserver/geoserver/pull/2980","diff_url":"https://github.com/geoserver/geoserver/pull/2980.diff","patch_url":"https://github.com/geoserver/geoserver/pull/2980.patch","issue_url":"https://api.github.com/repos/geoserver/geoserver/issues/2980","number":2980,"state":"open","locked":false,"title":"Reduced verbosity of error logging for remote WPS inputs.","user":{"login":"sikeoka","id":11542093,"node_id":"MDQ6VXNlcjExNTQyMDkz","avatar_url":"https://avatars2.githubusercontent.com/u/11542093?v=4","gravatar_id":"","url":"https://api.github.com/users/sikeoka","html_url":"https://github.com/sikeoka","followers_url":"https://api.github.com/users/sikeoka/followers","following_url":"https://api.github.com/users/sikeoka/following{/other_user}","gists_url":"https://api.github.com/users/sikeoka/gists{/gist_id}","starred_url":"https://api.github.com/users/sikeoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikeoka/subscriptions","organizations_url":"https://api.github.com/users/sikeoka/orgs","repos_url":"https://api.github.com/users/sikeoka/repos","events_url":"https://api.github.com/users/sikeoka/events{/privacy}","received_events_url":"https://api.github.com/users/sikeoka/received_events","type":"User","site_admin":false},"body":"This pull request updates error handling for loading remote WPS inputs to be similar to how org.geoserver.wms.map.GetMapKvpRequestReader handles errors when loading an SLD from a URL.\r\n\r\nThis pull request can be backported to 2.12.x and 2.13.x.","created_at":"2018-07-06T16:15:31Z","updated_at":"2018-07-09T16:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9feb63cfa166892b1ad0ae9f34ea6a9afb753ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geoserver/geoserver/pulls/2980/commits","review_comments_url":"https://api.github.com/repos/geoserver/geoserver/pulls/2980/comments","review_comment_url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoserver/geoserver/issues/2980/comments","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/1c576a3f4836e6d413741cd81b306c750c307c40","head":{"label":"sikeoka:remote-request-logging","ref":"remote-request-logging","sha":"1c576a3f4836e6d413741cd81b306c750c307c40","user":{"login":"sikeoka","id":11542093,"node_id":"MDQ6VXNlcjExNTQyMDkz","avatar_url":"https://avatars2.githubusercontent.com/u/11542093?v=4","gravatar_id":"","url":"https://api.github.com/users/sikeoka","html_url":"https://github.com/sikeoka","followers_url":"https://api.github.com/users/sikeoka/followers","following_url":"https://api.github.com/users/sikeoka/following{/other_user}","gists_url":"https://api.github.com/users/sikeoka/gists{/gist_id}","starred_url":"https://api.github.com/users/sikeoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikeoka/subscriptions","organizations_url":"https://api.github.com/users/sikeoka/orgs","repos_url":"https://api.github.com/users/sikeoka/repos","events_url":"https://api.github.com/users/sikeoka/events{/privacy}","received_events_url":"https://api.github.com/users/sikeoka/received_events","type":"User","site_admin":false},"repo":{"id":32470933,"node_id":"MDEwOlJlcG9zaXRvcnkzMjQ3MDkzMw==","name":"geoserver","full_name":"sikeoka/geoserver","owner":{"login":"sikeoka","id":11542093,"node_id":"MDQ6VXNlcjExNTQyMDkz","avatar_url":"https://avatars2.githubusercontent.com/u/11542093?v=4","gravatar_id":"","url":"https://api.github.com/users/sikeoka","html_url":"https://github.com/sikeoka","followers_url":"https://api.github.com/users/sikeoka/followers","following_url":"https://api.github.com/users/sikeoka/following{/other_user}","gists_url":"https://api.github.com/users/sikeoka/gists{/gist_id}","starred_url":"https://api.github.com/users/sikeoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikeoka/subscriptions","organizations_url":"https://api.github.com/users/sikeoka/orgs","repos_url":"https://api.github.com/users/sikeoka/repos","events_url":"https://api.github.com/users/sikeoka/events{/privacy}","received_events_url":"https://api.github.com/users/sikeoka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sikeoka/geoserver","description":"Official GeoServer repository","fork":true,"url":"https://api.github.com/repos/sikeoka/geoserver","forks_url":"https://api.github.com/repos/sikeoka/geoserver/forks","keys_url":"https://api.github.com/repos/sikeoka/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sikeoka/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sikeoka/geoserver/teams","hooks_url":"https://api.github.com/repos/sikeoka/geoserver/hooks","issue_events_url":"https://api.github.com/repos/sikeoka/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/sikeoka/geoserver/events","assignees_url":"https://api.github.com/repos/sikeoka/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/sikeoka/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/sikeoka/geoserver/tags","blobs_url":"https://api.github.com/repos/sikeoka/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sikeoka/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sikeoka/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/sikeoka/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sikeoka/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/sikeoka/geoserver/languages","stargazers_url":"https://api.github.com/repos/sikeoka/geoserver/stargazers","contributors_url":"https://api.github.com/repos/sikeoka/geoserver/contributors","subscribers_url":"https://api.github.com/repos/sikeoka/geoserver/subscribers","subscription_url":"https://api.github.com/repos/sikeoka/geoserver/subscription","commits_url":"https://api.github.com/repos/sikeoka/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/sikeoka/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/sikeoka/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/sikeoka/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/sikeoka/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/sikeoka/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sikeoka/geoserver/merges","archive_url":"https://api.github.com/repos/sikeoka/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sikeoka/geoserver/downloads","issues_url":"https://api.github.com/repos/sikeoka/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/sikeoka/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/sikeoka/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/sikeoka/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sikeoka/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/sikeoka/geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/sikeoka/geoserver/deployments","created_at":"2015-03-18T16:35:12Z","updated_at":"2018-07-09T14:41:46Z","pushed_at":"2018-07-09T16:08:06Z","git_url":"git://github.com/sikeoka/geoserver.git","ssh_url":"git@github.com:sikeoka/geoserver.git","clone_url":"https://github.com/sikeoka/geoserver.git","svn_url":"https://github.com/sikeoka/geoserver","homepage":"http://geoserver.org","size":187475,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geoserver:master","ref":"master","sha":"0e755cb0e7dc6af04a2dbbd1fc3b636e4c405e8e","user":{"login":"geoserver","id":186522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjUyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/186522?v=4","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"repo":{"id":2751199,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUxMTk5","name":"geoserver","full_name":"geoserver/geoserver","owner":{"login":"geoserver","id":186522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjUyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/186522?v=4","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoserver/geoserver","description":"Official GeoServer repository","fork":false,"url":"https://api.github.com/repos/geoserver/geoserver","forks_url":"https://api.github.com/repos/geoserver/geoserver/forks","keys_url":"https://api.github.com/repos/geoserver/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoserver/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoserver/geoserver/teams","hooks_url":"https://api.github.com/repos/geoserver/geoserver/hooks","issue_events_url":"https://api.github.com/repos/geoserver/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/geoserver/geoserver/events","assignees_url":"https://api.github.com/repos/geoserver/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/geoserver/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/geoserver/geoserver/tags","blobs_url":"https://api.github.com/repos/geoserver/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoserver/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoserver/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoserver/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/geoserver/geoserver/languages","stargazers_url":"https://api.github.com/repos/geoserver/geoserver/stargazers","contributors_url":"https://api.github.com/repos/geoserver/geoserver/contributors","subscribers_url":"https://api.github.com/repos/geoserver/geoserver/subscribers","subscription_url":"https://api.github.com/repos/geoserver/geoserver/subscription","commits_url":"https://api.github.com/repos/geoserver/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoserver/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoserver/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoserver/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoserver/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/geoserver/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoserver/geoserver/merges","archive_url":"https://api.github.com/repos/geoserver/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoserver/geoserver/downloads","issues_url":"https://api.github.com/repos/geoserver/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/geoserver/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/geoserver/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/geoserver/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoserver/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/geoserver/geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/geoserver/geoserver/deployments","created_at":"2011-11-10T19:56:06Z","updated_at":"2018-07-09T10:50:36Z","pushed_at":"2018-07-09T16:11:43Z","git_url":"git://github.com/geoserver/geoserver.git","ssh_url":"git@github.com:geoserver/geoserver.git","clone_url":"https://github.com/geoserver/geoserver.git","svn_url":"https://github.com/geoserver/geoserver","homepage":"http://geoserver.org/","size":195864,"stargazers_count":1200,"watchers_count":1200,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1092,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1092,"open_issues":16,"watchers":1200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/2980"},"html":{"href":"https://github.com/geoserver/geoserver/pull/2980"},"issue":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/2980"},"comments":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/2980/comments"},"review_comments":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/2980/comments"},"review_comment":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/2980/commits"},"statuses":{"href":"https://api.github.com/repos/geoserver/geoserver/statuses/1c576a3f4836e6d413741cd81b306c750c307c40"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sikeoka"}}