{"action":"created","comment":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/comments/219942081","pull_request_review_id":158236747,"id":219942081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk0MjA4MQ==","diff_hunk":"@@ -80,10 +89,10 @@ public synchronized boolean log() {\n         }\n     }\n \n-    @Override\n-    public synchronized boolean record(final String chrom, final int pos) {\n+    protected synchronized boolean record(final String chrom, final int pos, final String rname) {","path":"src/main/java/htsjdk/samtools/util/AbstractProgressLogger.java","position":34,"original_position":34,"commit_id":"7300d764c18bbfd553dc518edeaf9d67abe2cba8","original_commit_id":"7300d764c18bbfd553dc518edeaf9d67abe2cba8","user":{"login":"yfarjoun","id":2745554,"node_id":"MDQ6VXNlcjI3NDU1NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2745554?v=4","gravatar_id":"","url":"https://api.github.com/users/yfarjoun","html_url":"https://github.com/yfarjoun","followers_url":"https://api.github.com/users/yfarjoun/followers","following_url":"https://api.github.com/users/yfarjoun/following{/other_user}","gists_url":"https://api.github.com/users/yfarjoun/gists{/gist_id}","starred_url":"https://api.github.com/users/yfarjoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yfarjoun/subscriptions","organizations_url":"https://api.github.com/users/yfarjoun/orgs","repos_url":"https://api.github.com/users/yfarjoun/repos","events_url":"https://api.github.com/users/yfarjoun/events{/privacy}","received_events_url":"https://api.github.com/users/yfarjoun/received_events","type":"User","site_admin":false},"body":"this is clearly scope-creep. I would hold-off on requesting that from the OP","created_at":"2018-09-24T18:30:34Z","updated_at":"2018-09-24T18:30:34Z","html_url":"https://github.com/samtools/htsjdk/pull/1180#discussion_r219942081","pull_request_url":"https://api.github.com/repos/samtools/htsjdk/pulls/1180","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/comments/219942081"},"html":{"href":"https://github.com/samtools/htsjdk/pull/1180#discussion_r219942081"},"pull_request":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/1180"}},"in_reply_to_id":219666929},"pull_request":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/1180","id":216455298,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDU1Mjk4","html_url":"https://github.com/samtools/htsjdk/pull/1180","diff_url":"https://github.com/samtools/htsjdk/pull/1180.diff","patch_url":"https://github.com/samtools/htsjdk/pull/1180.patch","issue_url":"https://api.github.com/repos/samtools/htsjdk/issues/1180","number":1180,"state":"open","locked":false,"title":"progress logger logs read name too","user":{"login":"helgridly","id":775136,"node_id":"MDQ6VXNlcjc3NTEzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/775136?v=4","gravatar_id":"","url":"https://api.github.com/users/helgridly","html_url":"https://github.com/helgridly","followers_url":"https://api.github.com/users/helgridly/followers","following_url":"https://api.github.com/users/helgridly/following{/other_user}","gists_url":"https://api.github.com/users/helgridly/gists{/gist_id}","starred_url":"https://api.github.com/users/helgridly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgridly/subscriptions","organizations_url":"https://api.github.com/users/helgridly/orgs","repos_url":"https://api.github.com/users/helgridly/repos","events_url":"https://api.github.com/users/helgridly/events{/privacy}","received_events_url":"https://api.github.com/users/helgridly/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nRunning Picard SortSam to sort with queryname gave me output during that didn't tell me much about how done I was.\r\n\r\n### Checklist\r\n\r\n- [ ] Code compiles correctly\r\n- [ ] New tests covering changes and new functionality\r\n- [ ] All tests passing\r\n- [ ] Extended the README / documentation, if necessary\r\n- [ ] Is not backward compatible (breaks binary or source compatibility)\r\n\r\n","created_at":"2018-09-18T21:52:13Z","updated_at":"2018-09-24T18:30:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccc0984c066cf2f9f4bd3ed876932ff8d96d959c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1052097916,"node_id":"MDU6TGFiZWwxMDUyMDk3OTE2","url":"https://api.github.com/repos/samtools/htsjdk/labels/Waiting%20for%20revisions","name":"Waiting for revisions","color":"e1b7ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/samtools/htsjdk/pulls/1180/commits","review_comments_url":"https://api.github.com/repos/samtools/htsjdk/pulls/1180/comments","review_comment_url":"https://api.github.com/repos/samtools/htsjdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samtools/htsjdk/issues/1180/comments","statuses_url":"https://api.github.com/repos/samtools/htsjdk/statuses/7300d764c18bbfd553dc518edeaf9d67abe2cba8","head":{"label":"helgridly:progresslogger_rns","ref":"progresslogger_rns","sha":"7300d764c18bbfd553dc518edeaf9d67abe2cba8","user":{"login":"helgridly","id":775136,"node_id":"MDQ6VXNlcjc3NTEzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/775136?v=4","gravatar_id":"","url":"https://api.github.com/users/helgridly","html_url":"https://github.com/helgridly","followers_url":"https://api.github.com/users/helgridly/followers","following_url":"https://api.github.com/users/helgridly/following{/other_user}","gists_url":"https://api.github.com/users/helgridly/gists{/gist_id}","starred_url":"https://api.github.com/users/helgridly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgridly/subscriptions","organizations_url":"https://api.github.com/users/helgridly/orgs","repos_url":"https://api.github.com/users/helgridly/repos","events_url":"https://api.github.com/users/helgridly/events{/privacy}","received_events_url":"https://api.github.com/users/helgridly/received_events","type":"User","site_admin":false},"repo":{"id":149354790,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNTQ3OTA=","name":"htsjdk","full_name":"helgridly/htsjdk","private":false,"owner":{"login":"helgridly","id":775136,"node_id":"MDQ6VXNlcjc3NTEzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/775136?v=4","gravatar_id":"","url":"https://api.github.com/users/helgridly","html_url":"https://github.com/helgridly","followers_url":"https://api.github.com/users/helgridly/followers","following_url":"https://api.github.com/users/helgridly/following{/other_user}","gists_url":"https://api.github.com/users/helgridly/gists{/gist_id}","starred_url":"https://api.github.com/users/helgridly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgridly/subscriptions","organizations_url":"https://api.github.com/users/helgridly/orgs","repos_url":"https://api.github.com/users/helgridly/repos","events_url":"https://api.github.com/users/helgridly/events{/privacy}","received_events_url":"https://api.github.com/users/helgridly/received_events","type":"User","site_admin":false},"html_url":"https://github.com/helgridly/htsjdk","description":"A Java API for high-throughput sequencing data (HTS) formats.","fork":true,"url":"https://api.github.com/repos/helgridly/htsjdk","forks_url":"https://api.github.com/repos/helgridly/htsjdk/forks","keys_url":"https://api.github.com/repos/helgridly/htsjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helgridly/htsjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helgridly/htsjdk/teams","hooks_url":"https://api.github.com/repos/helgridly/htsjdk/hooks","issue_events_url":"https://api.github.com/repos/helgridly/htsjdk/issues/events{/number}","events_url":"https://api.github.com/repos/helgridly/htsjdk/events","assignees_url":"https://api.github.com/repos/helgridly/htsjdk/assignees{/user}","branches_url":"https://api.github.com/repos/helgridly/htsjdk/branches{/branch}","tags_url":"https://api.github.com/repos/helgridly/htsjdk/tags","blobs_url":"https://api.github.com/repos/helgridly/htsjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helgridly/htsjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helgridly/htsjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/helgridly/htsjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helgridly/htsjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/helgridly/htsjdk/languages","stargazers_url":"https://api.github.com/repos/helgridly/htsjdk/stargazers","contributors_url":"https://api.github.com/repos/helgridly/htsjdk/contributors","subscribers_url":"https://api.github.com/repos/helgridly/htsjdk/subscribers","subscription_url":"https://api.github.com/repos/helgridly/htsjdk/subscription","commits_url":"https://api.github.com/repos/helgridly/htsjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/helgridly/htsjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/helgridly/htsjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/helgridly/htsjdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/helgridly/htsjdk/contents/{+path}","compare_url":"https://api.github.com/repos/helgridly/htsjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helgridly/htsjdk/merges","archive_url":"https://api.github.com/repos/helgridly/htsjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helgridly/htsjdk/downloads","issues_url":"https://api.github.com/repos/helgridly/htsjdk/issues{/number}","pulls_url":"https://api.github.com/repos/helgridly/htsjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/helgridly/htsjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/helgridly/htsjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helgridly/htsjdk/labels{/name}","releases_url":"https://api.github.com/repos/helgridly/htsjdk/releases{/id}","deployments_url":"https://api.github.com/repos/helgridly/htsjdk/deployments","created_at":"2018-09-18T21:33:52Z","updated_at":"2018-09-18T21:34:44Z","pushed_at":"2018-09-19T01:02:56Z","git_url":"git://github.com/helgridly/htsjdk.git","ssh_url":"git@github.com:helgridly/htsjdk.git","clone_url":"https://github.com/helgridly/htsjdk.git","svn_url":"https://github.com/helgridly/htsjdk","homepage":"http://samtools.github.io/htsjdk/","size":67725,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samtools:master","ref":"master","sha":"a762262acefca73ea438e5165497e9d370f79bcf","user":{"login":"samtools","id":1518450,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTg0NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1518450?v=4","gravatar_id":"","url":"https://api.github.com/users/samtools","html_url":"https://github.com/samtools","followers_url":"https://api.github.com/users/samtools/followers","following_url":"https://api.github.com/users/samtools/following{/other_user}","gists_url":"https://api.github.com/users/samtools/gists{/gist_id}","starred_url":"https://api.github.com/users/samtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtools/subscriptions","organizations_url":"https://api.github.com/users/samtools/orgs","repos_url":"https://api.github.com/users/samtools/repos","events_url":"https://api.github.com/users/samtools/events{/privacy}","received_events_url":"https://api.github.com/users/samtools/received_events","type":"Organization","site_admin":false},"repo":{"id":19272315,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI3MjMxNQ==","name":"htsjdk","full_name":"samtools/htsjdk","private":false,"owner":{"login":"samtools","id":1518450,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTg0NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1518450?v=4","gravatar_id":"","url":"https://api.github.com/users/samtools","html_url":"https://github.com/samtools","followers_url":"https://api.github.com/users/samtools/followers","following_url":"https://api.github.com/users/samtools/following{/other_user}","gists_url":"https://api.github.com/users/samtools/gists{/gist_id}","starred_url":"https://api.github.com/users/samtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtools/subscriptions","organizations_url":"https://api.github.com/users/samtools/orgs","repos_url":"https://api.github.com/users/samtools/repos","events_url":"https://api.github.com/users/samtools/events{/privacy}","received_events_url":"https://api.github.com/users/samtools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/samtools/htsjdk","description":"A Java API for high-throughput sequencing data (HTS) formats.","fork":false,"url":"https://api.github.com/repos/samtools/htsjdk","forks_url":"https://api.github.com/repos/samtools/htsjdk/forks","keys_url":"https://api.github.com/repos/samtools/htsjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samtools/htsjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samtools/htsjdk/teams","hooks_url":"https://api.github.com/repos/samtools/htsjdk/hooks","issue_events_url":"https://api.github.com/repos/samtools/htsjdk/issues/events{/number}","events_url":"https://api.github.com/repos/samtools/htsjdk/events","assignees_url":"https://api.github.com/repos/samtools/htsjdk/assignees{/user}","branches_url":"https://api.github.com/repos/samtools/htsjdk/branches{/branch}","tags_url":"https://api.github.com/repos/samtools/htsjdk/tags","blobs_url":"https://api.github.com/repos/samtools/htsjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samtools/htsjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samtools/htsjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/samtools/htsjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samtools/htsjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/samtools/htsjdk/languages","stargazers_url":"https://api.github.com/repos/samtools/htsjdk/stargazers","contributors_url":"https://api.github.com/repos/samtools/htsjdk/contributors","subscribers_url":"https://api.github.com/repos/samtools/htsjdk/subscribers","subscription_url":"https://api.github.com/repos/samtools/htsjdk/subscription","commits_url":"https://api.github.com/repos/samtools/htsjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/samtools/htsjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/samtools/htsjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/samtools/htsjdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/samtools/htsjdk/contents/{+path}","compare_url":"https://api.github.com/repos/samtools/htsjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samtools/htsjdk/merges","archive_url":"https://api.github.com/repos/samtools/htsjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samtools/htsjdk/downloads","issues_url":"https://api.github.com/repos/samtools/htsjdk/issues{/number}","pulls_url":"https://api.github.com/repos/samtools/htsjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/samtools/htsjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/samtools/htsjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samtools/htsjdk/labels{/name}","releases_url":"https://api.github.com/repos/samtools/htsjdk/releases{/id}","deployments_url":"https://api.github.com/repos/samtools/htsjdk/deployments","created_at":"2014-04-29T10:11:28Z","updated_at":"2018-09-17T18:24:04Z","pushed_at":"2018-09-19T01:02:57Z","git_url":"git://github.com/samtools/htsjdk.git","ssh_url":"git@github.com:samtools/htsjdk.git","clone_url":"https://github.com/samtools/htsjdk.git","svn_url":"https://github.com/samtools/htsjdk","homepage":"http://samtools.github.io/htsjdk/","size":67802,"stargazers_count":170,"watchers_count":170,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":186,"mirror_url":null,"archived":false,"open_issues_count":234,"license":null,"forks":186,"open_issues":234,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/1180"},"html":{"href":"https://github.com/samtools/htsjdk/pull/1180"},"issue":{"href":"https://api.github.com/repos/samtools/htsjdk/issues/1180"},"comments":{"href":"https://api.github.com/repos/samtools/htsjdk/issues/1180/comments"},"review_comments":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/1180/comments"},"review_comment":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/1180/commits"},"statuses":{"href":"https://api.github.com/repos/samtools/htsjdk/statuses/7300d764c18bbfd553dc518edeaf9d67abe2cba8"}},"author_association":"NONE"}}
{"actor":{"display_login":"yfarjoun"}}