{"action":"created","comment":{"url":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/comments/171946905","pull_request_review_id":100893684,"id":171946905,"diff_hunk":"@@ -1,62 +1,193 @@\n 'use strict';\n \n+const _     = require(\"lodash\")","path":"src/lib/models/keyframe.js","position":3,"original_position":3,"commit_id":"bb92f61fb8332fd2bff52752159400e865fdcd3e","original_commit_id":"bb92f61fb8332fd2bff52752159400e865fdcd3e","user":{"login":"brownjohnf","id":1001049,"avatar_url":"https://avatars2.githubusercontent.com/u/1001049?v=4","gravatar_id":"","url":"https://api.github.com/users/brownjohnf","html_url":"https://github.com/brownjohnf","followers_url":"https://api.github.com/users/brownjohnf/followers","following_url":"https://api.github.com/users/brownjohnf/following{/other_user}","gists_url":"https://api.github.com/users/brownjohnf/gists{/gist_id}","starred_url":"https://api.github.com/users/brownjohnf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brownjohnf/subscriptions","organizations_url":"https://api.github.com/users/brownjohnf/orgs","repos_url":"https://api.github.com/users/brownjohnf/repos","events_url":"https://api.github.com/users/brownjohnf/events{/privacy}","received_events_url":"https://api.github.com/users/brownjohnf/received_events","type":"User","site_admin":false},"body":"Ah, leftover from when where were more requires I think.","created_at":"2018-03-02T19:51:45Z","updated_at":"2018-03-02T19:51:45Z","html_url":"https://github.com/resin-io-modules/keyfctl/pull/15#discussion_r171946905","pull_request_url":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/comments/171946905"},"html":{"href":"https://github.com/resin-io-modules/keyfctl/pull/15#discussion_r171946905"},"pull_request":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/15"}},"in_reply_to_id":171877505},"pull_request":{"url":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/15","id":171739913,"html_url":"https://github.com/resin-io-modules/keyfctl/pull/15","diff_url":"https://github.com/resin-io-modules/keyfctl/pull/15.diff","patch_url":"https://github.com/resin-io-modules/keyfctl/pull/15.patch","issue_url":"https://api.github.com/repos/resin-io-modules/keyfctl/issues/15","number":15,"state":"open","locked":false,"title":"Refactor keyfctl to improve usability and stability","user":{"login":"brownjohnf","id":1001049,"avatar_url":"https://avatars2.githubusercontent.com/u/1001049?v=4","gravatar_id":"","url":"https://api.github.com/users/brownjohnf","html_url":"https://github.com/brownjohnf","followers_url":"https://api.github.com/users/brownjohnf/followers","following_url":"https://api.github.com/users/brownjohnf/following{/other_user}","gists_url":"https://api.github.com/users/brownjohnf/gists{/gist_id}","starred_url":"https://api.github.com/users/brownjohnf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brownjohnf/subscriptions","organizations_url":"https://api.github.com/users/brownjohnf/orgs","repos_url":"https://api.github.com/users/brownjohnf/repos","events_url":"https://api.github.com/users/brownjohnf/events{/privacy}","received_events_url":"https://api.github.com/users/brownjohnf/received_events","type":"User","site_admin":false},"body":"This is almost a rewrite of keyfctl that *drastically* improves its usability and reliability. It also lays the foundation for direct deploy support from keyfctl via adapters. I've skeleton adapters as examples for fleet and k8s, but they don't actually do deploys yet. Presumably the fleet one would consume resinctl as a library to do its heavy lifting. I think I'll add that soon, since it should be pretty easy.\r\n\r\nChange-Type: major","created_at":"2018-02-27T18:01:15Z","updated_at":"2018-03-02T19:51:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"558f2a8119d2712613753e32b0861ee14bf0fdde","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mikesimos","id":3433256,"avatar_url":"https://avatars0.githubusercontent.com/u/3433256?v=4","gravatar_id":"","url":"https://api.github.com/users/mikesimos","html_url":"https://github.com/mikesimos","followers_url":"https://api.github.com/users/mikesimos/followers","following_url":"https://api.github.com/users/mikesimos/following{/other_user}","gists_url":"https://api.github.com/users/mikesimos/gists{/gist_id}","starred_url":"https://api.github.com/users/mikesimos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikesimos/subscriptions","organizations_url":"https://api.github.com/users/mikesimos/orgs","repos_url":"https://api.github.com/users/mikesimos/repos","events_url":"https://api.github.com/users/mikesimos/events{/privacy}","received_events_url":"https://api.github.com/users/mikesimos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/15/commits","review_comments_url":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/15/comments","review_comment_url":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io-modules/keyfctl/issues/15/comments","statuses_url":"https://api.github.com/repos/resin-io-modules/keyfctl/statuses/bb92f61fb8332fd2bff52752159400e865fdcd3e","head":{"label":"resin-io-modules:refactor","ref":"refactor","sha":"bb92f61fb8332fd2bff52752159400e865fdcd3e","user":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":89626834,"name":"keyfctl","full_name":"resin-io-modules/keyfctl","owner":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io-modules/keyfctl","description":"Library + cli for manipulating keyframes","fork":false,"url":"https://api.github.com/repos/resin-io-modules/keyfctl","forks_url":"https://api.github.com/repos/resin-io-modules/keyfctl/forks","keys_url":"https://api.github.com/repos/resin-io-modules/keyfctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-modules/keyfctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-modules/keyfctl/teams","hooks_url":"https://api.github.com/repos/resin-io-modules/keyfctl/hooks","issue_events_url":"https://api.github.com/repos/resin-io-modules/keyfctl/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-modules/keyfctl/events","assignees_url":"https://api.github.com/repos/resin-io-modules/keyfctl/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-modules/keyfctl/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-modules/keyfctl/tags","blobs_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-modules/keyfctl/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-modules/keyfctl/languages","stargazers_url":"https://api.github.com/repos/resin-io-modules/keyfctl/stargazers","contributors_url":"https://api.github.com/repos/resin-io-modules/keyfctl/contributors","subscribers_url":"https://api.github.com/repos/resin-io-modules/keyfctl/subscribers","subscription_url":"https://api.github.com/repos/resin-io-modules/keyfctl/subscription","commits_url":"https://api.github.com/repos/resin-io-modules/keyfctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-modules/keyfctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-modules/keyfctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-modules/keyfctl/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-modules/keyfctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-modules/keyfctl/merges","archive_url":"https://api.github.com/repos/resin-io-modules/keyfctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-modules/keyfctl/downloads","issues_url":"https://api.github.com/repos/resin-io-modules/keyfctl/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-modules/keyfctl/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-modules/keyfctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-modules/keyfctl/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-modules/keyfctl/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-modules/keyfctl/deployments","created_at":"2017-04-27T18:11:35Z","updated_at":"2018-01-24T11:31:14Z","pushed_at":"2018-02-28T16:34:36Z","git_url":"git://github.com/resin-io-modules/keyfctl.git","ssh_url":"git@github.com:resin-io-modules/keyfctl.git","clone_url":"https://github.com/resin-io-modules/keyfctl.git","svn_url":"https://github.com/resin-io-modules/keyfctl","homepage":null,"size":45,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":1,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"resin-io-modules:master","ref":"master","sha":"1ec5737bbb92700d30480842bc720cffdb6c9af0","user":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":89626834,"name":"keyfctl","full_name":"resin-io-modules/keyfctl","owner":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io-modules/keyfctl","description":"Library + cli for manipulating keyframes","fork":false,"url":"https://api.github.com/repos/resin-io-modules/keyfctl","forks_url":"https://api.github.com/repos/resin-io-modules/keyfctl/forks","keys_url":"https://api.github.com/repos/resin-io-modules/keyfctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-modules/keyfctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-modules/keyfctl/teams","hooks_url":"https://api.github.com/repos/resin-io-modules/keyfctl/hooks","issue_events_url":"https://api.github.com/repos/resin-io-modules/keyfctl/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-modules/keyfctl/events","assignees_url":"https://api.github.com/repos/resin-io-modules/keyfctl/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-modules/keyfctl/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-modules/keyfctl/tags","blobs_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-modules/keyfctl/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-modules/keyfctl/languages","stargazers_url":"https://api.github.com/repos/resin-io-modules/keyfctl/stargazers","contributors_url":"https://api.github.com/repos/resin-io-modules/keyfctl/contributors","subscribers_url":"https://api.github.com/repos/resin-io-modules/keyfctl/subscribers","subscription_url":"https://api.github.com/repos/resin-io-modules/keyfctl/subscription","commits_url":"https://api.github.com/repos/resin-io-modules/keyfctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-modules/keyfctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-modules/keyfctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-modules/keyfctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-modules/keyfctl/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-modules/keyfctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-modules/keyfctl/merges","archive_url":"https://api.github.com/repos/resin-io-modules/keyfctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-modules/keyfctl/downloads","issues_url":"https://api.github.com/repos/resin-io-modules/keyfctl/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-modules/keyfctl/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-modules/keyfctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-modules/keyfctl/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-modules/keyfctl/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-modules/keyfctl/deployments","created_at":"2017-04-27T18:11:35Z","updated_at":"2018-01-24T11:31:14Z","pushed_at":"2018-02-28T16:34:36Z","git_url":"git://github.com/resin-io-modules/keyfctl.git","ssh_url":"git@github.com:resin-io-modules/keyfctl.git","clone_url":"https://github.com/resin-io-modules/keyfctl.git","svn_url":"https://github.com/resin-io-modules/keyfctl","homepage":null,"size":45,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":1,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/15"},"html":{"href":"https://github.com/resin-io-modules/keyfctl/pull/15"},"issue":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/issues/15"},"comments":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io-modules/keyfctl/statuses/bb92f61fb8332fd2bff52752159400e865fdcd3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brownjohnf"}}