{"push_id":2890431133,"size":12,"distinct_size":0,"ref":"refs/heads/lkgr","head":"e1b0006b65ea5c8015d67e7ea1be6cfe5732057f","before":"8b1391794f25f6e7363771a43c1988b3c5b8e5a5","commits":[{"sha":"3b3e315db5ef3b1fa846dcdfd93c49948bae6e2e","author":{"name":"Chris Hamilton","email":"a9b0d80f44ccc0b90dc176c2e302be762dc1f8a5@chromium.org"},"message":"Add |auto_cancel| parameter to WebContents::DispatchBeforeUnload.\n\nThis exposes a parameter on WebContents::DispatchBeforeUnload which causes\nthe beforeunload dialog to automatically cancel itself if the beforeunload\nhandler returns a non-empty string.\n\nThis also adds plumbing to expose the value of |proceed| to the existing\nWebContentsObserver::BeforeUnloadFired.\n\nA follow-up CL will use these changes in order to create a \"beforeunload\"\nhelper to determine whether or not a page contains unsaved user data, and\nis therefore unsafe for proactive discarding.\n\nBUG=877550\n\nChange-Id: I3d7b09709985656dc48bbbf408f8b2bdf87b186c\nReviewed-on: https://chromium-review.googlesource.com/1220307\nCommit-Queue: Chris Hamilton <chrisha@chromium.org>\nReviewed-by: Dmitry Gozman <dgozman@chromium.org>\nReviewed-by: Scott Violet <sky@chromium.org>\nReviewed-by: Egor Pasko <pasko@chromium.org>\nReviewed-by: Alex Moshchuk <alexmos@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592378}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/3b3e315db5ef3b1fa846dcdfd93c49948bae6e2e"},{"sha":"5540a9cb7ec95a28dcfb97f9ce92520799a71647","author":{"name":"Elly Fong-Jones","email":"1693f95ea06ee6d7b2276cb599c3f4f33a951d9c@chromium.org"},"message":"views: use platform spacebar behavior in PageActionIconView\n\nOn Mac, the spacebar activates buttons on keydown; on other platforms it\nactivates them on keyup. Not implementing this behavior here caused the\nfollowing bug:\n\n1) User focuses the bookmark bar star\n2) User hits space to activate it, which opens the bubble\n3) User tabs to the \"Remove\" button\n4) User hits space to activate that button\n5) The \"Remove\" button activates on keydown and the bubble dismisses\n6) The star gets keyboard focus again\n7) The star immediately handles the keyup and reopens the bubble!\n\nThe fix is for PageActionIconView to honor the platform spacebar affinity. There\nis an old TODO in this code to merge it with views::Button but I would not want\nto merge such a change back to beta so this small fix seems more expedient.\n\nBug: 712341\nChange-Id: If932928bb069493e61f78f2d34e95a0aa45fb504\nReviewed-on: https://chromium-review.googlesource.com/1230437\nReviewed-by: Leonard Grey <lgrey@chromium.org>\nCommit-Queue: Elly Fong-Jones <ellyjones@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592379}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/5540a9cb7ec95a28dcfb97f9ce92520799a71647"},{"sha":"5d9b31e40e833ba98cfce1af3843443ecd04e3d3","author":{"name":"v8-ci-autoroll-builder","email":"6d90a40289372b9103173015041b0f8ee1cf3847@chops-service-accounts.iam.gserviceaccount.com"},"message":"Update V8 to version 7.1.137.\n\nSummary of changes available at:\nhttps://chromium.googlesource.com/v8/v8/+log/aa61ad05..e4c6d03d\n\nPlease follow these instructions for assigning/CC'ing issues:\nhttps://github.com/v8/v8/wiki/Triaging%20issues\n\nPlease close rolling in case of a roll revert:\nhttps://v8-roll.appspot.com/\nThis only works with a Google account.\n\nCQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel\n\nTBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com\n\nChange-Id: Ic6d71829b0d5861d8deaec7f1e019148ba15d395\nReviewed-on: https://chromium-review.googlesource.com/1233184\nReviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>\nCommit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>\nCr-Commit-Position: refs/heads/master@{#592380}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/5d9b31e40e833ba98cfce1af3843443ecd04e3d3"},{"sha":"8f9ac80abbd502800b8a77101482a1285f7fc9a8","author":{"name":"Matt Menke","email":"db2b536c538f3dbd8e890e06e08bcb9ec34adf6d@chromium.org"},"message":"Fix and re-enable TCPBoundSocketTest.ListenError and .BindError.\n\nThe tests perform operations on sockets that are expected to fail,\nand verifies they fail as expected. Unfortunately, some platforms\ncan return one of two errors. This CL updates the tests to allow\nboth errors.\n\nAlso removes a bunch of extraneous \"network::\"'s\n\nBug: 880492,880493\nCq-Include-Trybots: luci.chromium.try:linux_mojo\nChange-Id: Id085ece9ef0cf2e0b1581d6969f0295dd86910b8\nReviewed-on: https://chromium-review.googlesource.com/1231737\nReviewed-by: Maks Orlovich <morlovich@chromium.org>\nCommit-Queue: Matt Menke <mmenke@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592381}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/8f9ac80abbd502800b8a77101482a1285f7fc9a8"},{"sha":"32827a574ba7a555674a5ebfa3b78935aab9633d","author":{"name":"First-name Last-name","email":"c425b29a6e97729165926d3c3d03a24807a19abf@google.com"},"message":"Check dynamic module version before notify dynamic module on navigation event.\n\nBug: 886549\nChange-Id: Id0576ecc1e66b79e4dfeae708c1849231dad49ab\nReviewed-on: https://chromium-review.googlesource.com/1233696\nReviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>\nCommit-Queue: Anna Malova <amalova@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592382}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/32827a574ba7a555674a5ebfa3b78935aab9633d"},{"sha":"f7ef1c942101a6560f1d5487a3688d13eaa15be4","author":{"name":"Fredrik Söderquist","email":"3f4bb586f04a0c1d93eadab9363a8a3183b4860c@opera.com"},"message":"Use DEFINE_STATIC_LOCAL in CSSProperty::GetPropertyNameAtomicString\n\nThis avoids having a destructor being run when terminating the process.\nThese destructor could have ordering issues wrt to the destruction of\nthe AtomicStringTable. Using DEFINE_STATIC_LOCAL also shrinks the binary\na bit. (The android-binary-size bot says -16375 bytes.)\n\nRemove some redundant '\\0' characters for some additional (but minor)\nsavings.\n\nChange-Id: I4f5c19fceb9b668e74d3ef9bad58b104182ddb86\nReviewed-on: https://chromium-review.googlesource.com/1233700\nReviewed-by: Anders Ruud <andruud@chromium.org>\nCommit-Queue: Fredrik Söderquist <fs@opera.com>\nCr-Commit-Position: refs/heads/master@{#592383}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/f7ef1c942101a6560f1d5487a3688d13eaa15be4"},{"sha":"f0252116eab5af1a2fba125b1aebbfed08de96b7","author":{"name":"Christian Biesinger","email":"759fddd9b184808fafc5ed357cadee4efa0bd04c@chromium.org"},"message":"[layoutng] Store the constraint space as a pointer on LayoutBlock\n\nTo shrink LayoutBlock back to its previous size, store the\nconstraint space as a pointer again. This seems to actually have a\nslightly positive effect on performance according to pinpoint (?!)\n\nCq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng\nChange-Id: I9de7205eefbce457a9b7a82a6d5529adb13d58c4\nReviewed-on: https://chromium-review.googlesource.com/1232584\nReviewed-by: Morten Stenshorne <mstensho@chromium.org>\nCommit-Queue: Christian Biesinger <cbiesinger@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592384}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/f0252116eab5af1a2fba125b1aebbfed08de96b7"},{"sha":"8f6326484a8c1ad74f61585eb0bfc7b1126ce2fa","author":{"name":"Brian White","email":"ba5f5a0555dcac1826beb366d481a8e6d8a54b8a@chromium.org"},"message":"Revert \"Field crash if histogram bucket creation isn't as expected.\"\n\nThis reverts commit 673081e3d2e172e3875ffae881deab0d3f93e497.\n\nReason for revert: Test complete. One day in the field is sufficient.\n\nOriginal change's description:\n> Field crash if histogram bucket creation isn't as expected.\n> \n> There are reports from the field that the \"maximum\" of a histogram\n> does not match what was configured.  The working theory is that it is\n> due to rounding errors in the creation of exponential buckets.\n> Verify this assumption.  If it's behaving wrong, it should crash\n> during the creation.\n> \n> Bug: 836238\n> Change-Id: I4cf5e4bc3986e288c728ae37e2ff8cf841b7598d\n> Reviewed-on: https://chromium-review.googlesource.com/1228840\n> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>\n> Commit-Queue: Brian White <bcwhite@chromium.org>\n> Cr-Commit-Position: refs/heads/master@{#592128}\n\nTBR=asvitkine@chromium.org,bcwhite@chromium.org\n\nChange-Id: I0c7ecfc65d31aa2d161f1b689a178432a9364e27\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 836238\nReviewed-on: https://chromium-review.googlesource.com/1233893\nReviewed-by: Brian White <bcwhite@chromium.org>\nCommit-Queue: Brian White <bcwhite@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592385}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/8f6326484a8c1ad74f61585eb0bfc7b1126ce2fa"},{"sha":"02981447973468066f78d4da415f9bdd7e70bad5","author":{"name":"Dan Harrington","email":"2e8715460253355fb9e8bf01cf6fb682a6fd4c62@chromium.org"},"message":"Remove RequestQueueInMemoryStore\n\nRequestQueueStore and RequestQueueStoreSQL were combined.\n\nI went ahead and added a test fixture for request queue tasks. This ensures\nwe actually delete the database in TearDown.\n\nBug: 883938\nChange-Id: Ia56698061685440402d82b5a6836c827f30b546a\nReviewed-on: https://chromium-review.googlesource.com/1227134\nReviewed-by: Cathy Li <chili@chromium.org>\nCommit-Queue: Dan H <harringtond@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592386}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/02981447973468066f78d4da415f9bdd7e70bad5"},{"sha":"bdddf79675fa3e7b5f1549be87a690a706158191","author":{"name":"Rayan Kanso","email":"8467f9d4d02d7700f9bd1ddda04a874d839c2a48@chromium.org"},"message":"[Background Fetch] Report DatabaseTask errors to scheduler.\n\nThe scheduler assumes that all database tasks succeeded and continues\naccordingly. This change propagates the errors, and if there are any,\nthe scheduler will abandon the fetch.\n\nChange-Id: I813ab23107369799ada4cc39a5eee9944433ed44\nReviewed-on: https://chromium-review.googlesource.com/1228015\nCommit-Queue: Rayan Kanso <rayankans@chromium.org>\nReviewed-by: Mugdha Lakhani <nator@chromium.org>\nReviewed-by: Peter Beverloo <peter@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592387}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/bdddf79675fa3e7b5f1549be87a690a706158191"},{"sha":"ac93f6efa0eb1cef7990cc645a9e3e4858a526b0","author":{"name":"Fredrik Söderquist","email":"3f4bb586f04a0c1d93eadab9363a8a3183b4860c@opera.com"},"message":"Add bug component for blink_perf.svg\n\nChange-Id: I78b9172711cad010a754ad4d524758df39af5e61\nReviewed-on: https://chromium-review.googlesource.com/1233337\nCommit-Queue: Ned Nguyen <nednguyen@google.com>\nReviewed-by: Ned Nguyen <nednguyen@google.com>\nCr-Commit-Position: refs/heads/master@{#592388}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/ac93f6efa0eb1cef7990cc645a9e3e4858a526b0"},{"sha":"e1b0006b65ea5c8015d67e7ea1be6cfe5732057f","author":{"name":"Matthew Cary","email":"608ed6ff63978c667bb08845cf4c5239cfa2db0f@chromium.org"},"message":"Orderfile: fix bug in monochrome build.\n\nBug: 758566\nChange-Id: I9ec28cc5bb1be7baac6ac232bd9db1a10870b3cc\nReviewed-on: https://chromium-review.googlesource.com/1233595\nReviewed-by: Egor Pasko <pasko@chromium.org>\nCommit-Queue: Matthew Cary <mattcary@chromium.org>\nCr-Commit-Position: refs/heads/master@{#592389}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/e1b0006b65ea5c8015d67e7ea1be6cfe5732057f"}]}
{"actor":{"display_login":"aarongable"}}