{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6887","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6887/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6887/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6887/events","html_url":"https://github.com/NREL/EnergyPlus/pull/6887","id":347580152,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTcxNjcy","number":6887,"title":"First Set of Engineering Reference Comprehensive Edits","user":{"login":"RKStrand","id":5804989,"node_id":"MDQ6VXNlcjU4MDQ5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/5804989?v=4","gravatar_id":"","url":"https://api.github.com/users/RKStrand","html_url":"https://github.com/RKStrand","followers_url":"https://api.github.com/users/RKStrand/followers","following_url":"https://api.github.com/users/RKStrand/following{/other_user}","gists_url":"https://api.github.com/users/RKStrand/gists{/gist_id}","starred_url":"https://api.github.com/users/RKStrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RKStrand/subscriptions","organizations_url":"https://api.github.com/users/RKStrand/orgs","repos_url":"https://api.github.com/users/RKStrand/repos","events_url":"https://api.github.com/users/RKStrand/events{/privacy}","received_events_url":"https://api.github.com/users/RKStrand/received_events","type":"User","site_admin":false},"labels":[{"id":74843628,"node_id":"MDU6TGFiZWw3NDg0MzYyOA==","url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Defect","name":"Defect","color":"e11d21","default":false}],"state":"closed","locked":false,"assignee":{"login":"RKStrand","id":5804989,"node_id":"MDQ6VXNlcjU4MDQ5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/5804989?v=4","gravatar_id":"","url":"https://api.github.com/users/RKStrand","html_url":"https://github.com/RKStrand","followers_url":"https://api.github.com/users/RKStrand/followers","following_url":"https://api.github.com/users/RKStrand/following{/other_user}","gists_url":"https://api.github.com/users/RKStrand/gists{/gist_id}","starred_url":"https://api.github.com/users/RKStrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RKStrand/subscriptions","organizations_url":"https://api.github.com/users/RKStrand/orgs","repos_url":"https://api.github.com/users/RKStrand/repos","events_url":"https://api.github.com/users/RKStrand/events{/privacy}","received_events_url":"https://api.github.com/users/RKStrand/received_events","type":"User","site_admin":false},"assignees":[{"login":"RKStrand","id":5804989,"node_id":"MDQ6VXNlcjU4MDQ5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/5804989?v=4","gravatar_id":"","url":"https://api.github.com/users/RKStrand","html_url":"https://github.com/RKStrand","followers_url":"https://api.github.com/users/RKStrand/followers","following_url":"https://api.github.com/users/RKStrand/following{/other_user}","gists_url":"https://api.github.com/users/RKStrand/gists{/gist_id}","starred_url":"https://api.github.com/users/RKStrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RKStrand/subscriptions","organizations_url":"https://api.github.com/users/RKStrand/orgs","repos_url":"https://api.github.com/users/RKStrand/repos","events_url":"https://api.github.com/users/RKStrand/events{/privacy}","received_events_url":"https://api.github.com/users/RKStrand/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/8","html_url":"https://github.com/NREL/EnergyPlus/milestone/8","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/8/labels","id":3115951,"node_id":"MDk6TWlsZXN0b25lMzExNTk1MQ==","number":8,"title":"EnergyPlus 9.0","description":"","creator":{"login":"Myoldmopar","id":849824,"node_id":"MDQ6VXNlcjg0OTgyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":63,"closed_issues":68,"state":"open","created_at":"2018-02-14T10:31:29Z","updated_at":"2018-08-27T22:11:52Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-08-04T02:55:39Z","updated_at":"2018-08-27T22:12:21Z","closed_at":"2018-08-27T22:11:51Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6887","html_url":"https://github.com/NREL/EnergyPlus/pull/6887","diff_url":"https://github.com/NREL/EnergyPlus/pull/6887.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6887.patch"},"body":"Pull request overview\r\n---------------------\r\nThis work is the first of an anticipated six defects that look to fix a host of issues in the Engineering Reference including equation reference errors, equation inconsistencies and errors, figure and table reference issues, and a host of other mistakes, typos, formatting issues noted along the way.  This first defect covers the beginning of the document through p. 283 (the start of Section 7.7.4 Simple Window Model).  This work resolves GitHub Issue #6868 \r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ x ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ x ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue #6868 \r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/416386014","html_url":"https://github.com/NREL/EnergyPlus/pull/6887#issuecomment-416386014","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6887","id":416386014,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjM4NjAxNA==","user":{"login":"Myoldmopar","id":849824,"node_id":"MDQ6VXNlcjg0OTgyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T22:12:21Z","updated_at":"2018-08-27T22:12:21Z","author_association":"MEMBER","body":"This was technically closed as a part of #6932."}}
{"actor":{"display_login":"Myoldmopar"}}