{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/226799370","pull_request_review_id":166717753,"id":226799370,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjc5OTM3MA==","diff_hunk":"@@ -142,6 +150,13 @@ class Driver {\n     return this.evaluateAsync(`(${pageFunctions.ultradumbBenchmarkString})()`);\n   }\n \n+  /**\n+   * @param {number} timeout\n+   */\n+  setProtocolTimeout(timeout) {\n+    this._protocolTimeout = timeout;","path":"lighthouse-core/gather/driver.js","position":30,"original_position":30,"commit_id":"fafc3150d797c0aa22a1bb6bfe2df46210093f8c","original_commit_id":"fafc3150d797c0aa22a1bb6bfe2df46210093f8c","user":{"login":"Hoten","id":4071474,"node_id":"MDQ6VXNlcjQwNzE0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4071474?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoten","html_url":"https://github.com/Hoten","followers_url":"https://api.github.com/users/Hoten/followers","following_url":"https://api.github.com/users/Hoten/following{/other_user}","gists_url":"https://api.github.com/users/Hoten/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoten/subscriptions","organizations_url":"https://api.github.com/users/Hoten/orgs","repos_url":"https://api.github.com/users/Hoten/repos","events_url":"https://api.github.com/users/Hoten/events{/privacy}","received_events_url":"https://api.github.com/users/Hoten/received_events","type":"User","site_admin":false},"body":"We can move to that if it's really needed. It complicates calling it quite a bit. And due to the unique typing on the method, I think the best option would be this:\r\n\r\n```\r\nsendCommand(methodOrOpts, ...params) {\r\n  const {method, timeout} = typeof methodOrOpts === 'object' ? methodOrOpts : {\r\n    method,\r\n    timeout: DEFAULT_PROTOCOL_TIMEOUT\r\n  }\r\n}\r\n```\r\n\r\nThat way, the calling code for most use cases can remain the same.","created_at":"2018-10-19T22:45:52Z","updated_at":"2018-10-19T22:45:53Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/6347#discussion_r226799370","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6347","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/226799370"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/6347#discussion_r226799370"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6347"}},"in_reply_to_id":226797659},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6347","id":224415357,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDE1MzU3","html_url":"https://github.com/GoogleChrome/lighthouse/pull/6347","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/6347.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/6347.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6347","number":6347,"state":"open","locked":false,"title":"core: add timeout to all protocol commands","user":{"login":"Hoten","id":4071474,"node_id":"MDQ6VXNlcjQwNzE0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4071474?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoten","html_url":"https://github.com/Hoten","followers_url":"https://api.github.com/users/Hoten/followers","following_url":"https://api.github.com/users/Hoten/following{/other_user}","gists_url":"https://api.github.com/users/Hoten/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoten/subscriptions","organizations_url":"https://api.github.com/users/Hoten/orgs","repos_url":"https://api.github.com/users/Hoten/repos","events_url":"https://api.github.com/users/Hoten/events{/privacy}","received_events_url":"https://api.github.com/users/Hoten/received_events","type":"User","site_admin":false},"body":"Fixes #6296","created_at":"2018-10-19T21:30:46Z","updated_at":"2018-10-19T22:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db6fd01f022d899cd532fbffc2d0bfa5f3393b2f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"paulirish","id":39191,"node_id":"MDQ6VXNlcjM5MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/39191?v=4","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},{"login":"brendankenny","id":316891,"node_id":"MDQ6VXNlcjMxNjg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316891?v=4","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},{"login":"exterkamp","id":6392995,"node_id":"MDQ6VXNlcjYzOTI5OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/6392995?v=4","gravatar_id":"","url":"https://api.github.com/users/exterkamp","html_url":"https://github.com/exterkamp","followers_url":"https://api.github.com/users/exterkamp/followers","following_url":"https://api.github.com/users/exterkamp/following{/other_user}","gists_url":"https://api.github.com/users/exterkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/exterkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exterkamp/subscriptions","organizations_url":"https://api.github.com/users/exterkamp/orgs","repos_url":"https://api.github.com/users/exterkamp/repos","events_url":"https://api.github.com/users/exterkamp/events{/privacy}","received_events_url":"https://api.github.com/users/exterkamp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6347/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6347/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6347/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/fafc3150d797c0aa22a1bb6bfe2df46210093f8c","head":{"label":"GoogleChrome:issue-6296-protocol-timeout","ref":"issue-6296-protocol-timeout","sha":"fafc3150d797c0aa22a1bb6bfe2df46210093f8c","user":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM3MDk4OA==","name":"lighthouse","full_name":"GoogleChrome/lighthouse","private":false,"owner":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2018-10-19T18:29:22Z","pushed_at":"2018-10-19T21:30:47Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":25180,"stargazers_count":14911,"watchers_count":14911,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":4803,"mirror_url":null,"archived":false,"open_issues_count":374,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4803,"open_issues":374,"watchers":14911,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"fd7bc1832c35d2318eab354347a8f244710ad7f6","user":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM3MDk4OA==","name":"lighthouse","full_name":"GoogleChrome/lighthouse","private":false,"owner":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2018-10-19T18:29:22Z","pushed_at":"2018-10-19T21:30:47Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":25180,"stargazers_count":14911,"watchers_count":14911,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":4803,"mirror_url":null,"archived":false,"open_issues_count":374,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4803,"open_issues":374,"watchers":14911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6347"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/6347"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6347"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6347/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6347/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6347/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/fafc3150d797c0aa22a1bb6bfe2df46210093f8c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Hoten"}}