{"action":"created","issue":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2417","repository_url":"https://api.github.com/repos/KratosMultiphysics/Kratos","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2417/labels{/name}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2417/comments","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2417/events","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/2417","id":337298562,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTI4ODY3","number":2417,"title":"Model v3 - third iteration of the model redesign","user":{"login":"RiccardoRossi","id":8059665,"node_id":"MDQ6VXNlcjgwNTk2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/8059665?v=4","gravatar_id":"","url":"https://api.github.com/users/RiccardoRossi","html_url":"https://github.com/RiccardoRossi","followers_url":"https://api.github.com/users/RiccardoRossi/followers","following_url":"https://api.github.com/users/RiccardoRossi/following{/other_user}","gists_url":"https://api.github.com/users/RiccardoRossi/gists{/gist_id}","starred_url":"https://api.github.com/users/RiccardoRossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RiccardoRossi/subscriptions","organizations_url":"https://api.github.com/users/RiccardoRossi/orgs","repos_url":"https://api.github.com/users/RiccardoRossi/repos","events_url":"https://api.github.com/users/RiccardoRossi/events{/privacy}","received_events_url":"https://api.github.com/users/RiccardoRossi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2018-07-01T15:14:45Z","updated_at":"2018-07-26T20:10:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2417","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/2417","diff_url":"https://github.com/KratosMultiphysics/Kratos/pull/2417.diff","patch_url":"https://github.com/KratosMultiphysics/Kratos/pull/2417.patch"},"body":"this is third iteration of the model. It is now not registered in Kernel not it is a global object.\r\n\r\ni would say that the design is pretty clean now (there is nothing strange in the model object, in the sense that it is NOT a singleton any longer)\r\n\r\nthe problem is that this change is backward incompatible in that it hides the modelpart. Modelpart can now ONLY be created through the model interface.\r\n\r\nas of now, i ported all of the core, to the point at which all the tests pass (both python and c++).\r\n**If we go for this design i will need help in porting all of the applications**\r\n"},"comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments/408220350","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/2417#issuecomment-408220350","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2417","id":408220350,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODIyMDM1MA==","user":{"login":"RiccardoRossi","id":8059665,"node_id":"MDQ6VXNlcjgwNTk2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/8059665?v=4","gravatar_id":"","url":"https://api.github.com/users/RiccardoRossi","html_url":"https://github.com/RiccardoRossi","followers_url":"https://api.github.com/users/RiccardoRossi/followers","following_url":"https://api.github.com/users/RiccardoRossi/following{/other_user}","gists_url":"https://api.github.com/users/RiccardoRossi/gists{/gist_id}","starred_url":"https://api.github.com/users/RiccardoRossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RiccardoRossi/subscriptions","organizations_url":"https://api.github.com/users/RiccardoRossi/orgs","repos_url":"https://api.github.com/users/RiccardoRossi/repos","events_url":"https://api.github.com/users/RiccardoRossi/events{/privacy}","received_events_url":"https://api.github.com/users/RiccardoRossi/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T20:10:59Z","updated_at":"2018-07-26T20:10:59Z","author_association":"MEMBER","body":"@maceligueta as a part of this proposal Modelpart::Pointer was actually removed.A modelpart will live only as long as the model holds it since there are no shared pointers to it anywhere (only references are passed to python). this means that the problematic example i proposed would work just fine.\r\nNOW, the downisde is  of course that if you delete a modelpart, ** all the raw pointers to it become dangling**.\r\nMmy call is that this is ok, since you will get a segfault as soon as you try to use the modelpart, which is easy to debug (at least easier than finding out how to delete it in a complicated simulation, where anyone could be keeping it alive)\r\n\r\n@philbucher by doing DeleteModelPart you only delete nodes and elements if their shared count goes to zero (No change here)\r\n\r\nI am perfectly fine in merging the Model as it is now (model is the only owner, no smart Pointers), however i was trying to take into account mike's comments\r\n"}}
{"actor":{"display_login":"RiccardoRossi"}}