{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/comments/244530048","pull_request_review_id":188434863,"id":244530048,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUzMDA0OA==","diff_hunk":"@@ -91,35 +91,25 @@\n # See LICENSE file\n #\n class bird (\n-  $daemon_name_v4     = $bird::params::daemon_name_v4,\n-  $package_name_v4    = $bird::params::package_name_v4,\n-  $config_path_v4     = $bird::params::config_path_v4,\n-  $config_file_v4     = 'UNSET',\n-  $config_template_v4 = 'UNSET',\n-  $enable_v6          = false,\n-  $manage_conf        = false,\n-  $manage_service     = false,\n-  $service_v6_ensure  = 'running',\n-  $service_v6_enable  = false,\n-  $service_v4_ensure  = 'running',\n-  $service_v4_enable  = false,\n-  $daemon_name_v6     = $bird::params::daemon_name_v6,\n-  $package_name_v6    = $bird::params::package_name_v6,\n-  $config_path_v6     = $bird::params::config_path_v6,\n-  $config_file_v6     = 'UNSET',\n-  $config_template_v6 = 'UNSET',\n+  $daemon_name_v4                               = $bird::params::daemon_name_v4,\n+  $package_name_v4                              = $bird::params::package_name_v4,\n+  $config_path_v4                               = $bird::params::config_path_v4,\n+  $config_file_v4                               = 'UNSET',\n+  $config_template_v4                           = 'UNSET',\n+  $enable_v6                                    = false,","path":"manifests/init.pp","position":26,"original_position":26,"commit_id":"cc660ca111bfdad5453ac258bbddc1958369e7ec","original_commit_id":"cc660ca111bfdad5453ac258bbddc1958369e7ec","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"body":"And this too?","created_at":"2018-12-30T10:33:14Z","updated_at":"2018-12-30T10:33:23Z","html_url":"https://github.com/voxpupuli/puppet-bird/pull/23#discussion_r244530048","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/23","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/comments/244530048"},"html":{"href":"https://github.com/voxpupuli/puppet-bird/pull/23#discussion_r244530048"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/23","id":241469251,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDY5MjUx","html_url":"https://github.com/voxpupuli/puppet-bird/pull/23","diff_url":"https://github.com/voxpupuli/puppet-bird/pull/23.diff","patch_url":"https://github.com/voxpupuli/puppet-bird/pull/23.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-bird/issues/23","number":23,"state":"open","locked":false,"title":"replace validate_* with datatypes","user":{"login":"bastelfreak","id":341866,"node_id":"MDQ6VXNlcjM0MTg2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/341866?v=4","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to this project!\r\n\r\n- This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/\r\n- Please check that here is no existing issue or PR that addresses your problem.\r\n- Our vulnerabilities reporting process is at https://voxpupuli.org/security/\r\n\r\n-->\r\n#### Pull Request (PR) description\r\n<!--\r\n    Replace this comment with a description of your pull request.\r\n-->\r\n\r\n#### This Pull Request (PR) fixes the following issues\r\n<!--\r\n    Replace this comment with the list of issues or n/a.\r\n    Use format:\r\n    Fixes #123\r\n    Fixes #124\r\n-->\r\n","created_at":"2018-12-29T23:58:21Z","updated_at":"2018-12-30T10:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"378344275ce5d74aaf65bfb5ffd9450ca54cb9af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/23/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/23/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-bird/issues/23/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-bird/statuses/cc660ca111bfdad5453ac258bbddc1958369e7ec","head":{"label":"bastelfreak:puppet4","ref":"puppet4","sha":"cc660ca111bfdad5453ac258bbddc1958369e7ec","user":{"login":"bastelfreak","id":341866,"node_id":"MDQ6VXNlcjM0MTg2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/341866?v=4","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"repo":{"id":103535193,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1MzUxOTM=","name":"puppet-bird","full_name":"bastelfreak/puppet-bird","private":false,"owner":{"login":"bastelfreak","id":341866,"node_id":"MDQ6VXNlcjM0MTg2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/341866?v=4","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bastelfreak/puppet-bird","description":"Manage bird Internet routing daemon with puppet","fork":true,"url":"https://api.github.com/repos/bastelfreak/puppet-bird","forks_url":"https://api.github.com/repos/bastelfreak/puppet-bird/forks","keys_url":"https://api.github.com/repos/bastelfreak/puppet-bird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bastelfreak/puppet-bird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bastelfreak/puppet-bird/teams","hooks_url":"https://api.github.com/repos/bastelfreak/puppet-bird/hooks","issue_events_url":"https://api.github.com/repos/bastelfreak/puppet-bird/issues/events{/number}","events_url":"https://api.github.com/repos/bastelfreak/puppet-bird/events","assignees_url":"https://api.github.com/repos/bastelfreak/puppet-bird/assignees{/user}","branches_url":"https://api.github.com/repos/bastelfreak/puppet-bird/branches{/branch}","tags_url":"https://api.github.com/repos/bastelfreak/puppet-bird/tags","blobs_url":"https://api.github.com/repos/bastelfreak/puppet-bird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bastelfreak/puppet-bird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bastelfreak/puppet-bird/git/refs{/sha}","trees_url":"https://api.github.com/repos/bastelfreak/puppet-bird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bastelfreak/puppet-bird/statuses/{sha}","languages_url":"https://api.github.com/repos/bastelfreak/puppet-bird/languages","stargazers_url":"https://api.github.com/repos/bastelfreak/puppet-bird/stargazers","contributors_url":"https://api.github.com/repos/bastelfreak/puppet-bird/contributors","subscribers_url":"https://api.github.com/repos/bastelfreak/puppet-bird/subscribers","subscription_url":"https://api.github.com/repos/bastelfreak/puppet-bird/subscription","commits_url":"https://api.github.com/repos/bastelfreak/puppet-bird/commits{/sha}","git_commits_url":"https://api.github.com/repos/bastelfreak/puppet-bird/git/commits{/sha}","comments_url":"https://api.github.com/repos/bastelfreak/puppet-bird/comments{/number}","issue_comment_url":"https://api.github.com/repos/bastelfreak/puppet-bird/issues/comments{/number}","contents_url":"https://api.github.com/repos/bastelfreak/puppet-bird/contents/{+path}","compare_url":"https://api.github.com/repos/bastelfreak/puppet-bird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bastelfreak/puppet-bird/merges","archive_url":"https://api.github.com/repos/bastelfreak/puppet-bird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bastelfreak/puppet-bird/downloads","issues_url":"https://api.github.com/repos/bastelfreak/puppet-bird/issues{/number}","pulls_url":"https://api.github.com/repos/bastelfreak/puppet-bird/pulls{/number}","milestones_url":"https://api.github.com/repos/bastelfreak/puppet-bird/milestones{/number}","notifications_url":"https://api.github.com/repos/bastelfreak/puppet-bird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bastelfreak/puppet-bird/labels{/name}","releases_url":"https://api.github.com/repos/bastelfreak/puppet-bird/releases{/id}","deployments_url":"https://api.github.com/repos/bastelfreak/puppet-bird/deployments","created_at":"2017-09-14T13:23:51Z","updated_at":"2018-12-30T01:13:30Z","pushed_at":"2018-12-29T23:57:35Z","git_url":"git://github.com/bastelfreak/puppet-bird.git","ssh_url":"git@github.com:bastelfreak/puppet-bird.git","clone_url":"https://github.com/bastelfreak/puppet-bird.git","svn_url":"https://github.com/bastelfreak/puppet-bird","homepage":"http://forge.puppetlabs.com/sbadia/bird","size":127,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"d378a81ac90c70ad9675e74a66ec4d5e7b8d2218","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":11847731,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0NzczMQ==","name":"puppet-bird","full_name":"voxpupuli/puppet-bird","private":false,"owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voxpupuli/puppet-bird","description":"Manage bird Internet routing daemon with puppet","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-bird","forks_url":"https://api.github.com/repos/voxpupuli/puppet-bird/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-bird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-bird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-bird/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-bird/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-bird/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-bird/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-bird/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-bird/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-bird/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-bird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-bird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-bird/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-bird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-bird/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-bird/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-bird/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-bird/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-bird/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-bird/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-bird/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-bird/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-bird/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-bird/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-bird/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-bird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-bird/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-bird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-bird/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-bird/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-bird/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-bird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-bird/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-bird/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-bird/deployments","created_at":"2013-08-02T16:34:01Z","updated_at":"2018-12-26T00:11:48Z","pushed_at":"2018-12-29T23:58:22Z","git_url":"git://github.com/voxpupuli/puppet-bird.git","ssh_url":"git@github.com:voxpupuli/puppet-bird.git","clone_url":"https://github.com/voxpupuli/puppet-bird.git","svn_url":"https://github.com/voxpupuli/puppet-bird","homepage":"http://forge.puppetlabs.com/puppet/bird","size":126,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":8,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/23"},"html":{"href":"https://github.com/voxpupuli/puppet-bird/pull/23"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/issues/23"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-bird/statuses/cc660ca111bfdad5453ac258bbddc1958369e7ec"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexjfisher"}}