{"action":"created","issue":{"url":"https://api.github.com/repos/psychopy/psychopy/issues/2170","repository_url":"https://api.github.com/repos/psychopy/psychopy","labels_url":"https://api.github.com/repos/psychopy/psychopy/issues/2170/labels{/name}","comments_url":"https://api.github.com/repos/psychopy/psychopy/issues/2170/comments","events_url":"https://api.github.com/repos/psychopy/psychopy/issues/2170/events","html_url":"https://github.com/psychopy/psychopy/pull/2170","id":394907719,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTEyNzIw","number":2170,"title":"ENH/BF: New Experiment Setting – Flip after Routine is finished","user":{"login":"hoechenberger","id":2046265,"node_id":"MDQ6VXNlcjIwNDYyNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2046265?v=4","gravatar_id":"","url":"https://api.github.com/users/hoechenberger","html_url":"https://github.com/hoechenberger","followers_url":"https://api.github.com/users/hoechenberger/followers","following_url":"https://api.github.com/users/hoechenberger/following{/other_user}","gists_url":"https://api.github.com/users/hoechenberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hoechenberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoechenberger/subscriptions","organizations_url":"https://api.github.com/users/hoechenberger/orgs","repos_url":"https://api.github.com/users/hoechenberger/repos","events_url":"https://api.github.com/users/hoechenberger/events{/privacy}","received_events_url":"https://api.github.com/users/hoechenberger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-30T22:54:27Z","updated_at":"2018-12-30T23:10:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/psychopy/psychopy/pulls/2170","html_url":"https://github.com/psychopy/psychopy/pull/2170","diff_url":"https://github.com/psychopy/psychopy/pull/2170.diff","patch_url":"https://github.com/psychopy/psychopy/pull/2170.patch"},"body":"As described in #2169, Builder Components might have unexpected durations if they occur at the end of a Routine (or at the end of the experiment) as we currently skip the last screen flip.\r\n\r\nThis PR addresses the issue by introducing a new Experiment Setting (a checkbox `Screen -> Flip at Routine end`) which enables flipping after the last Component in a Routine has finished. The setting is **ON** by default, meaning this is a \"breaking\" change, if you will. Users can, however, uncheck the setting to restore previous behavior.\r\n\r\nCloses #2169."},"comment":{"url":"https://api.github.com/repos/psychopy/psychopy/issues/comments/450593165","html_url":"https://github.com/psychopy/psychopy/pull/2170#issuecomment-450593165","issue_url":"https://api.github.com/repos/psychopy/psychopy/issues/2170","id":450593165,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU5MzE2NQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T23:10:39Z","updated_at":"2018-12-30T23:10:39Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/psychopy/psychopy/pull/2170?src=pr&el=h1) Report\n> Merging [#2170](https://codecov.io/gh/psychopy/psychopy/pull/2170?src=pr&el=desc) into [master](https://codecov.io/gh/psychopy/psychopy/commit/7025ead6ef2383467ffdfa96f9d95184af795253?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/psychopy/psychopy/pull/2170/graphs/tree.svg?width=650&token=Byx9h1B6p3&height=150&src=pr)](https://codecov.io/gh/psychopy/psychopy/pull/2170?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #2170      +/-   ##\n==========================================\n+ Coverage   42.91%   42.93%   +0.02%     \n==========================================\n  Files         221      221              \n  Lines       38118    38121       +3     \n  Branches     6547     6548       +1     \n==========================================\n+ Hits        16358    16369      +11     \n+ Misses      20203    20199       -4     \n+ Partials     1557     1553       -4\n```\n\n\n| [Impacted Files](https://codecov.io/gh/psychopy/psychopy/pull/2170?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [psychopy/experiment/routine.py](https://codecov.io/gh/psychopy/psychopy/pull/2170/diff?src=pr&el=tree#diff-cHN5Y2hvcHkvZXhwZXJpbWVudC9yb3V0aW5lLnB5) | `84.54% <100%> (+3.07%)` | :arrow_up: |\n| [...sychopy/experiment/components/settings/\\_\\_init\\_\\_.py](https://codecov.io/gh/psychopy/psychopy/pull/2170/diff?src=pr&el=tree#diff-cHN5Y2hvcHkvZXhwZXJpbWVudC9jb21wb25lbnRzL3NldHRpbmdzL19faW5pdF9fLnB5) | `72.42% <100%> (+0.09%)` | :arrow_up: |\n| [psychopy/visual/textbox/fontmanager.py](https://codecov.io/gh/psychopy/psychopy/pull/2170/diff?src=pr&el=tree#diff-cHN5Y2hvcHkvdmlzdWFsL3RleHRib3gvZm9udG1hbmFnZXIucHk=) | `71.77% <0%> (+0.69%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/psychopy/psychopy/pull/2170?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/psychopy/psychopy/pull/2170?src=pr&el=footer). Last update [7025ead...5c7305d](https://codecov.io/gh/psychopy/psychopy/pull/2170?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}