{"action":"created","comment":{"url":"https://api.github.com/repos/r-lib/pkgdown/pulls/comments/232822927","pull_request_review_id":174107026,"id":232822927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjgyMjkyNw==","diff_hunk":"@@ -7,19 +7,49 @@ build_logo <- function(pkg = \".\") {\n \n   file_copy_to(pkg, logo_path, from_dir = path_dir(logo_path))\n \n-  if (!requireNamespace(\"magick\", quietly = TRUE)) {\n-    message(\"magick not available, using default pkgdown favicon.ico\")\n+  cat_line(\"Creating \", dst_path(\"favicon.ico\"))","path":"R/build-logo.R","position":6,"original_position":6,"commit_id":"ab1406b00cd80171df30cd290a5212cec6307b3c","original_commit_id":"0d0e8eb1d978d8c70cd9598f6b017f67ef6edda8","user":{"login":"hadley","id":4196,"node_id":"MDQ6VXNlcjQxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4196?v=4","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"body":":+1:","created_at":"2018-11-12T21:46:12Z","updated_at":"2018-11-12T21:46:12Z","html_url":"https://github.com/r-lib/pkgdown/pull/883#discussion_r232822927","pull_request_url":"https://api.github.com/repos/r-lib/pkgdown/pulls/883","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/comments/232822927"},"html":{"href":"https://github.com/r-lib/pkgdown/pull/883#discussion_r232822927"},"pull_request":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/883"}},"in_reply_to_id":232703268},"pull_request":{"url":"https://api.github.com/repos/r-lib/pkgdown/pulls/883","id":229963070,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTYzMDcw","html_url":"https://github.com/r-lib/pkgdown/pull/883","diff_url":"https://github.com/r-lib/pkgdown/pull/883.diff","patch_url":"https://github.com/r-lib/pkgdown/pull/883.patch","issue_url":"https://api.github.com/repos/r-lib/pkgdown/issues/883","number":883,"state":"open","locked":false,"title":"[WIP] Use realfavicongenerator API to build high-res PNG favicons","user":{"login":"Bisaloo","id":10783929,"node_id":"MDQ6VXNlcjEwNzgzOTI5","avatar_url":"https://avatars0.githubusercontent.com/u/10783929?v=4","gravatar_id":"","url":"https://api.github.com/users/Bisaloo","html_url":"https://github.com/Bisaloo","followers_url":"https://api.github.com/users/Bisaloo/followers","following_url":"https://api.github.com/users/Bisaloo/following{/other_user}","gists_url":"https://api.github.com/users/Bisaloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisaloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisaloo/subscriptions","organizations_url":"https://api.github.com/users/Bisaloo/orgs","repos_url":"https://api.github.com/users/Bisaloo/repos","events_url":"https://api.github.com/users/Bisaloo/events{/privacy}","received_events_url":"https://api.github.com/users/Bisaloo/received_events","type":"User","site_admin":false},"body":"fix #845, fix #869 \r\n\r\nThis is still WIP but I'm putting it here if you want to have a first look and tell me if I'm going in the wrong direction. I still need to:\r\n\r\n- [ ] Add tests\r\n- [x] Test with other input formats such as `svg`\r\n- [ ] Verify that docs are up to date everywhere\r\n- [ ] ??\r\n\r\nAmong others, I would like you to review:\r\n\r\n- verbosity: more / less?\r\n- paths: path of the template, path of the resulting favicons\r\n- API key. At the moment, I'm using the demo API key but we probably need to register our own. One for all `pkgdown` users, hardcoded in the code? Asking users to register one themselves would introduce more complexity.","created_at":"2018-11-11T16:40:45Z","updated_at":"2018-11-12T21:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"366f9b6231d35ceb32aae0003ab0dbd078a65fe9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/r-lib/pkgdown/pulls/883/commits","review_comments_url":"https://api.github.com/repos/r-lib/pkgdown/pulls/883/comments","review_comment_url":"https://api.github.com/repos/r-lib/pkgdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/r-lib/pkgdown/issues/883/comments","statuses_url":"https://api.github.com/repos/r-lib/pkgdown/statuses/ab1406b00cd80171df30cd290a5212cec6307b3c","head":{"label":"Bisaloo:png-favicons","ref":"png-favicons","sha":"ab1406b00cd80171df30cd290a5212cec6307b3c","user":{"login":"Bisaloo","id":10783929,"node_id":"MDQ6VXNlcjEwNzgzOTI5","avatar_url":"https://avatars0.githubusercontent.com/u/10783929?v=4","gravatar_id":"","url":"https://api.github.com/users/Bisaloo","html_url":"https://github.com/Bisaloo","followers_url":"https://api.github.com/users/Bisaloo/followers","following_url":"https://api.github.com/users/Bisaloo/following{/other_user}","gists_url":"https://api.github.com/users/Bisaloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisaloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisaloo/subscriptions","organizations_url":"https://api.github.com/users/Bisaloo/orgs","repos_url":"https://api.github.com/users/Bisaloo/repos","events_url":"https://api.github.com/users/Bisaloo/events{/privacy}","received_events_url":"https://api.github.com/users/Bisaloo/received_events","type":"User","site_admin":false},"repo":{"id":153683587,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2ODM1ODc=","name":"pkgdown","full_name":"Bisaloo/pkgdown","private":false,"owner":{"login":"Bisaloo","id":10783929,"node_id":"MDQ6VXNlcjEwNzgzOTI5","avatar_url":"https://avatars0.githubusercontent.com/u/10783929?v=4","gravatar_id":"","url":"https://api.github.com/users/Bisaloo","html_url":"https://github.com/Bisaloo","followers_url":"https://api.github.com/users/Bisaloo/followers","following_url":"https://api.github.com/users/Bisaloo/following{/other_user}","gists_url":"https://api.github.com/users/Bisaloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisaloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisaloo/subscriptions","organizations_url":"https://api.github.com/users/Bisaloo/orgs","repos_url":"https://api.github.com/users/Bisaloo/repos","events_url":"https://api.github.com/users/Bisaloo/events{/privacy}","received_events_url":"https://api.github.com/users/Bisaloo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bisaloo/pkgdown","description":"Generate static html documentation for an R package","fork":true,"url":"https://api.github.com/repos/Bisaloo/pkgdown","forks_url":"https://api.github.com/repos/Bisaloo/pkgdown/forks","keys_url":"https://api.github.com/repos/Bisaloo/pkgdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bisaloo/pkgdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bisaloo/pkgdown/teams","hooks_url":"https://api.github.com/repos/Bisaloo/pkgdown/hooks","issue_events_url":"https://api.github.com/repos/Bisaloo/pkgdown/issues/events{/number}","events_url":"https://api.github.com/repos/Bisaloo/pkgdown/events","assignees_url":"https://api.github.com/repos/Bisaloo/pkgdown/assignees{/user}","branches_url":"https://api.github.com/repos/Bisaloo/pkgdown/branches{/branch}","tags_url":"https://api.github.com/repos/Bisaloo/pkgdown/tags","blobs_url":"https://api.github.com/repos/Bisaloo/pkgdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bisaloo/pkgdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bisaloo/pkgdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bisaloo/pkgdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bisaloo/pkgdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Bisaloo/pkgdown/languages","stargazers_url":"https://api.github.com/repos/Bisaloo/pkgdown/stargazers","contributors_url":"https://api.github.com/repos/Bisaloo/pkgdown/contributors","subscribers_url":"https://api.github.com/repos/Bisaloo/pkgdown/subscribers","subscription_url":"https://api.github.com/repos/Bisaloo/pkgdown/subscription","commits_url":"https://api.github.com/repos/Bisaloo/pkgdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bisaloo/pkgdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bisaloo/pkgdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bisaloo/pkgdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bisaloo/pkgdown/contents/{+path}","compare_url":"https://api.github.com/repos/Bisaloo/pkgdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bisaloo/pkgdown/merges","archive_url":"https://api.github.com/repos/Bisaloo/pkgdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bisaloo/pkgdown/downloads","issues_url":"https://api.github.com/repos/Bisaloo/pkgdown/issues{/number}","pulls_url":"https://api.github.com/repos/Bisaloo/pkgdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Bisaloo/pkgdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Bisaloo/pkgdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bisaloo/pkgdown/labels{/name}","releases_url":"https://api.github.com/repos/Bisaloo/pkgdown/releases{/id}","deployments_url":"https://api.github.com/repos/Bisaloo/pkgdown/deployments","created_at":"2018-10-18T20:29:33Z","updated_at":"2018-11-07T10:36:20Z","pushed_at":"2018-11-12T20:32:10Z","git_url":"git://github.com/Bisaloo/pkgdown.git","ssh_url":"git@github.com:Bisaloo/pkgdown.git","clone_url":"https://github.com/Bisaloo/pkgdown.git","svn_url":"https://github.com/Bisaloo/pkgdown","homepage":"https://pkgdown.r-lib.org","size":4890,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"r-lib:master","ref":"master","sha":"8f543c2e962fc9c49de14ed9c7e349b6550c8eac","user":{"login":"r-lib","id":22618716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjE4NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/22618716?v=4","gravatar_id":"","url":"https://api.github.com/users/r-lib","html_url":"https://github.com/r-lib","followers_url":"https://api.github.com/users/r-lib/followers","following_url":"https://api.github.com/users/r-lib/following{/other_user}","gists_url":"https://api.github.com/users/r-lib/gists{/gist_id}","starred_url":"https://api.github.com/users/r-lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-lib/subscriptions","organizations_url":"https://api.github.com/users/r-lib/orgs","repos_url":"https://api.github.com/users/r-lib/repos","events_url":"https://api.github.com/users/r-lib/events{/privacy}","received_events_url":"https://api.github.com/users/r-lib/received_events","type":"Organization","site_admin":false},"repo":{"id":3723845,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIzODQ1","name":"pkgdown","full_name":"r-lib/pkgdown","private":false,"owner":{"login":"r-lib","id":22618716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjE4NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/22618716?v=4","gravatar_id":"","url":"https://api.github.com/users/r-lib","html_url":"https://github.com/r-lib","followers_url":"https://api.github.com/users/r-lib/followers","following_url":"https://api.github.com/users/r-lib/following{/other_user}","gists_url":"https://api.github.com/users/r-lib/gists{/gist_id}","starred_url":"https://api.github.com/users/r-lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-lib/subscriptions","organizations_url":"https://api.github.com/users/r-lib/orgs","repos_url":"https://api.github.com/users/r-lib/repos","events_url":"https://api.github.com/users/r-lib/events{/privacy}","received_events_url":"https://api.github.com/users/r-lib/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/r-lib/pkgdown","description":"Generate static html documentation for an R package","fork":false,"url":"https://api.github.com/repos/r-lib/pkgdown","forks_url":"https://api.github.com/repos/r-lib/pkgdown/forks","keys_url":"https://api.github.com/repos/r-lib/pkgdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r-lib/pkgdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r-lib/pkgdown/teams","hooks_url":"https://api.github.com/repos/r-lib/pkgdown/hooks","issue_events_url":"https://api.github.com/repos/r-lib/pkgdown/issues/events{/number}","events_url":"https://api.github.com/repos/r-lib/pkgdown/events","assignees_url":"https://api.github.com/repos/r-lib/pkgdown/assignees{/user}","branches_url":"https://api.github.com/repos/r-lib/pkgdown/branches{/branch}","tags_url":"https://api.github.com/repos/r-lib/pkgdown/tags","blobs_url":"https://api.github.com/repos/r-lib/pkgdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r-lib/pkgdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r-lib/pkgdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/r-lib/pkgdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r-lib/pkgdown/statuses/{sha}","languages_url":"https://api.github.com/repos/r-lib/pkgdown/languages","stargazers_url":"https://api.github.com/repos/r-lib/pkgdown/stargazers","contributors_url":"https://api.github.com/repos/r-lib/pkgdown/contributors","subscribers_url":"https://api.github.com/repos/r-lib/pkgdown/subscribers","subscription_url":"https://api.github.com/repos/r-lib/pkgdown/subscription","commits_url":"https://api.github.com/repos/r-lib/pkgdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/r-lib/pkgdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/r-lib/pkgdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/r-lib/pkgdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/r-lib/pkgdown/contents/{+path}","compare_url":"https://api.github.com/repos/r-lib/pkgdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r-lib/pkgdown/merges","archive_url":"https://api.github.com/repos/r-lib/pkgdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r-lib/pkgdown/downloads","issues_url":"https://api.github.com/repos/r-lib/pkgdown/issues{/number}","pulls_url":"https://api.github.com/repos/r-lib/pkgdown/pulls{/number}","milestones_url":"https://api.github.com/repos/r-lib/pkgdown/milestones{/number}","notifications_url":"https://api.github.com/repos/r-lib/pkgdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r-lib/pkgdown/labels{/name}","releases_url":"https://api.github.com/repos/r-lib/pkgdown/releases{/id}","deployments_url":"https://api.github.com/repos/r-lib/pkgdown/deployments","created_at":"2012-03-15T00:36:24Z","updated_at":"2018-11-12T20:38:24Z","pushed_at":"2018-11-12T20:38:21Z","git_url":"git://github.com/r-lib/pkgdown.git","ssh_url":"git@github.com:r-lib/pkgdown.git","clone_url":"https://github.com/r-lib/pkgdown.git","svn_url":"https://github.com/r-lib/pkgdown","homepage":"https://pkgdown.r-lib.org","size":5203,"stargazers_count":374,"watchers_count":374,"language":"R","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":180,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":180,"open_issues":45,"watchers":374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/883"},"html":{"href":"https://github.com/r-lib/pkgdown/pull/883"},"issue":{"href":"https://api.github.com/repos/r-lib/pkgdown/issues/883"},"comments":{"href":"https://api.github.com/repos/r-lib/pkgdown/issues/883/comments"},"review_comments":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/883/comments"},"review_comment":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/883/commits"},"statuses":{"href":"https://api.github.com/repos/r-lib/pkgdown/statuses/ab1406b00cd80171df30cd290a5212cec6307b3c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hadley"}}