{"action":"opened","number":1669,"pull_request":{"url":"https://api.github.com/repos/nipy/dipy/pulls/1669","id":233676436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjc2NDM2","html_url":"https://github.com/nipy/dipy/pull/1669","diff_url":"https://github.com/nipy/dipy/pull/1669.diff","patch_url":"https://github.com/nipy/dipy/pull/1669.patch","issue_url":"https://api.github.com/repos/nipy/dipy/issues/1669","number":1669,"state":"open","locked":false,"title":"Flow csd sh order","user":{"login":"arokem","id":118582,"node_id":"MDQ6VXNlcjExODU4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/118582?v=4","gravatar_id":"","url":"https://api.github.com/users/arokem","html_url":"https://github.com/arokem","followers_url":"https://api.github.com/users/arokem/followers","following_url":"https://api.github.com/users/arokem/following{/other_user}","gists_url":"https://api.github.com/users/arokem/gists{/gist_id}","starred_url":"https://api.github.com/users/arokem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arokem/subscriptions","organizations_url":"https://api.github.com/users/arokem/orgs","repos_url":"https://api.github.com/users/arokem/repos","events_url":"https://api.github.com/users/arokem/events{/privacy}","received_events_url":"https://api.github.com/users/arokem/received_events","type":"User","site_admin":false},"body":"In using the CSD workflow, I discovered that changing the `sh_order` input parameter doesn't seem to do anything. Tracking this down [in the code](https://github.com/nipy/dipy/blob/master/dipy/workflows/reconst.py#L523), I see that it was hard-coded as `sh_order = 8`. This PR changes that and also adds some testing around that. It also more flexibly checks the inputs, so that we are not making assumptions about the input data.\r\n","created_at":"2018-11-26T19:51:08Z","updated_at":"2018-11-26T19:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nipy/dipy/pulls/1669/commits","review_comments_url":"https://api.github.com/repos/nipy/dipy/pulls/1669/comments","review_comment_url":"https://api.github.com/repos/nipy/dipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/dipy/issues/1669/comments","statuses_url":"https://api.github.com/repos/nipy/dipy/statuses/3f3b33cbfd1f8ed142b6e32eeb49364ef3560b77","head":{"label":"arokem:flow_csd_sh_order","ref":"flow_csd_sh_order","sha":"3f3b33cbfd1f8ed142b6e32eeb49364ef3560b77","user":{"login":"arokem","id":118582,"node_id":"MDQ6VXNlcjExODU4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/118582?v=4","gravatar_id":"","url":"https://api.github.com/users/arokem","html_url":"https://github.com/arokem","followers_url":"https://api.github.com/users/arokem/followers","following_url":"https://api.github.com/users/arokem/following{/other_user}","gists_url":"https://api.github.com/users/arokem/gists{/gist_id}","starred_url":"https://api.github.com/users/arokem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arokem/subscriptions","organizations_url":"https://api.github.com/users/arokem/orgs","repos_url":"https://api.github.com/users/arokem/repos","events_url":"https://api.github.com/users/arokem/events{/privacy}","received_events_url":"https://api.github.com/users/arokem/received_events","type":"User","site_admin":false},"repo":{"id":2484790,"node_id":"MDEwOlJlcG9zaXRvcnkyNDg0Nzkw","name":"dipy","full_name":"arokem/dipy","private":false,"owner":{"login":"arokem","id":118582,"node_id":"MDQ6VXNlcjExODU4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/118582?v=4","gravatar_id":"","url":"https://api.github.com/users/arokem","html_url":"https://github.com/arokem","followers_url":"https://api.github.com/users/arokem/followers","following_url":"https://api.github.com/users/arokem/following{/other_user}","gists_url":"https://api.github.com/users/arokem/gists{/gist_id}","starred_url":"https://api.github.com/users/arokem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arokem/subscriptions","organizations_url":"https://api.github.com/users/arokem/orgs","repos_url":"https://api.github.com/users/arokem/repos","events_url":"https://api.github.com/users/arokem/events{/privacy}","received_events_url":"https://api.github.com/users/arokem/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arokem/dipy","description":"Diffusion MR Imaging in Python","fork":true,"url":"https://api.github.com/repos/arokem/dipy","forks_url":"https://api.github.com/repos/arokem/dipy/forks","keys_url":"https://api.github.com/repos/arokem/dipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arokem/dipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arokem/dipy/teams","hooks_url":"https://api.github.com/repos/arokem/dipy/hooks","issue_events_url":"https://api.github.com/repos/arokem/dipy/issues/events{/number}","events_url":"https://api.github.com/repos/arokem/dipy/events","assignees_url":"https://api.github.com/repos/arokem/dipy/assignees{/user}","branches_url":"https://api.github.com/repos/arokem/dipy/branches{/branch}","tags_url":"https://api.github.com/repos/arokem/dipy/tags","blobs_url":"https://api.github.com/repos/arokem/dipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arokem/dipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arokem/dipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/arokem/dipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arokem/dipy/statuses/{sha}","languages_url":"https://api.github.com/repos/arokem/dipy/languages","stargazers_url":"https://api.github.com/repos/arokem/dipy/stargazers","contributors_url":"https://api.github.com/repos/arokem/dipy/contributors","subscribers_url":"https://api.github.com/repos/arokem/dipy/subscribers","subscription_url":"https://api.github.com/repos/arokem/dipy/subscription","commits_url":"https://api.github.com/repos/arokem/dipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/arokem/dipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/arokem/dipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/arokem/dipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/arokem/dipy/contents/{+path}","compare_url":"https://api.github.com/repos/arokem/dipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arokem/dipy/merges","archive_url":"https://api.github.com/repos/arokem/dipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arokem/dipy/downloads","issues_url":"https://api.github.com/repos/arokem/dipy/issues{/number}","pulls_url":"https://api.github.com/repos/arokem/dipy/pulls{/number}","milestones_url":"https://api.github.com/repos/arokem/dipy/milestones{/number}","notifications_url":"https://api.github.com/repos/arokem/dipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arokem/dipy/labels{/name}","releases_url":"https://api.github.com/repos/arokem/dipy/releases{/id}","deployments_url":"https://api.github.com/repos/arokem/dipy/deployments","created_at":"2011-09-29T20:43:30Z","updated_at":"2018-11-26T18:37:57Z","pushed_at":"2018-11-26T19:48:57Z","git_url":"git://github.com/arokem/dipy.git","ssh_url":"git@github.com:arokem/dipy.git","clone_url":"https://github.com/arokem/dipy.git","svn_url":"https://github.com/arokem/dipy","homepage":"http://dipy.org","size":32502,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"a7bb518f034225be88d0bd6b51a67310b38b669f","user":{"login":"nipy","id":233707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":505209,"node_id":"MDEwOlJlcG9zaXRvcnk1MDUyMDk=","name":"dipy","full_name":"nipy/dipy","private":false,"owner":{"login":"nipy","id":233707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nipy/dipy","description":"Diffusion MR imaging in Python","fork":false,"url":"https://api.github.com/repos/nipy/dipy","forks_url":"https://api.github.com/repos/nipy/dipy/forks","keys_url":"https://api.github.com/repos/nipy/dipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/dipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/dipy/teams","hooks_url":"https://api.github.com/repos/nipy/dipy/hooks","issue_events_url":"https://api.github.com/repos/nipy/dipy/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/dipy/events","assignees_url":"https://api.github.com/repos/nipy/dipy/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/dipy/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/dipy/tags","blobs_url":"https://api.github.com/repos/nipy/dipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/dipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/dipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/dipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/dipy/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/dipy/languages","stargazers_url":"https://api.github.com/repos/nipy/dipy/stargazers","contributors_url":"https://api.github.com/repos/nipy/dipy/contributors","subscribers_url":"https://api.github.com/repos/nipy/dipy/subscribers","subscription_url":"https://api.github.com/repos/nipy/dipy/subscription","commits_url":"https://api.github.com/repos/nipy/dipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/dipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/dipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/dipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/dipy/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/dipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/dipy/merges","archive_url":"https://api.github.com/repos/nipy/dipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/dipy/downloads","issues_url":"https://api.github.com/repos/nipy/dipy/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/dipy/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/dipy/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/dipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/dipy/labels{/name}","releases_url":"https://api.github.com/repos/nipy/dipy/releases{/id}","deployments_url":"https://api.github.com/repos/nipy/dipy/deployments","created_at":"2010-02-06T11:43:08Z","updated_at":"2018-11-19T09:37:50Z","pushed_at":"2018-11-26T16:37:42Z","git_url":"git://github.com/nipy/dipy.git","ssh_url":"git@github.com:nipy/dipy.git","clone_url":"https://github.com/nipy/dipy.git","svn_url":"https://github.com/nipy/dipy","homepage":"http://dipy.org","size":33493,"stargazers_count":197,"watchers_count":197,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":233,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":233,"open_issues":153,"watchers":197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1669"},"html":{"href":"https://github.com/nipy/dipy/pull/1669"},"issue":{"href":"https://api.github.com/repos/nipy/dipy/issues/1669"},"comments":{"href":"https://api.github.com/repos/nipy/dipy/issues/1669/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1669/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1669/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/dipy/statuses/3f3b33cbfd1f8ed142b6e32eeb49364ef3560b77"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":80,"deletions":76,"changed_files":2}}
{"actor":{"display_login":"arokem"}}