{"action":"created","issue":{"url":"https://api.github.com/repos/mysuf/videojs-ima-player/issues/2","repository_url":"https://api.github.com/repos/mysuf/videojs-ima-player","labels_url":"https://api.github.com/repos/mysuf/videojs-ima-player/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/mysuf/videojs-ima-player/issues/2/comments","events_url":"https://api.github.com/repos/mysuf/videojs-ima-player/issues/2/events","html_url":"https://github.com/mysuf/videojs-ima-player/issues/2","id":319641926,"node_id":"MDU6SXNzdWUzMTk2NDE5MjY=","number":2,"title":"fix IOS skippable ads fullscreen toggle","user":{"login":"mysuf","id":16492403,"node_id":"MDQ6VXNlcjE2NDkyNDAz","avatar_url":"https://avatars3.githubusercontent.com/u/16492403?v=4","gravatar_id":"","url":"https://api.github.com/users/mysuf","html_url":"https://github.com/mysuf","followers_url":"https://api.github.com/users/mysuf/followers","following_url":"https://api.github.com/users/mysuf/following{/other_user}","gists_url":"https://api.github.com/users/mysuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mysuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysuf/subscriptions","organizations_url":"https://api.github.com/users/mysuf/orgs","repos_url":"https://api.github.com/users/mysuf/repos","events_url":"https://api.github.com/users/mysuf/events{/privacy}","received_events_url":"https://api.github.com/users/mysuf/received_events","type":"User","site_admin":false},"labels":[{"id":908535279,"node_id":"MDU6TGFiZWw5MDg1MzUyNzk=","url":"https://api.github.com/repos/mysuf/videojs-ima-player/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"open","locked":false,"assignee":{"login":"mysuf","id":16492403,"node_id":"MDQ6VXNlcjE2NDkyNDAz","avatar_url":"https://avatars3.githubusercontent.com/u/16492403?v=4","gravatar_id":"","url":"https://api.github.com/users/mysuf","html_url":"https://github.com/mysuf","followers_url":"https://api.github.com/users/mysuf/followers","following_url":"https://api.github.com/users/mysuf/following{/other_user}","gists_url":"https://api.github.com/users/mysuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mysuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysuf/subscriptions","organizations_url":"https://api.github.com/users/mysuf/orgs","repos_url":"https://api.github.com/users/mysuf/repos","events_url":"https://api.github.com/users/mysuf/events{/privacy}","received_events_url":"https://api.github.com/users/mysuf/received_events","type":"User","site_admin":false},"assignees":[{"login":"mysuf","id":16492403,"node_id":"MDQ6VXNlcjE2NDkyNDAz","avatar_url":"https://avatars3.githubusercontent.com/u/16492403?v=4","gravatar_id":"","url":"https://api.github.com/users/mysuf","html_url":"https://github.com/mysuf","followers_url":"https://api.github.com/users/mysuf/followers","following_url":"https://api.github.com/users/mysuf/following{/other_user}","gists_url":"https://api.github.com/users/mysuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mysuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysuf/subscriptions","organizations_url":"https://api.github.com/users/mysuf/orgs","repos_url":"https://api.github.com/users/mysuf/repos","events_url":"https://api.github.com/users/mysuf/events{/privacy}","received_events_url":"https://api.github.com/users/mysuf/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-02T17:23:02Z","updated_at":"2018-06-10T13:07:57Z","closed_at":null,"author_association":"OWNER","body":"Now, it behaves exactly how https://developers.google.com/interactive-media-ads/docs/sdks/html5/skippable-ads describes. It forces content player to enter/exit fullscreen which break fullscreen implementation on mobile IOS. The solution will be probably not supporting tech's fullscreen on IOS and to force full window instead. \r\n\r\nThe question is how it should work when content player is already in fullscreen - programatically exited fullscreen and switch to full window could lead to blinking and bad user experience..."},"comment":{"url":"https://api.github.com/repos/mysuf/videojs-ima-player/issues/comments/396047951","html_url":"https://github.com/mysuf/videojs-ima-player/issues/2#issuecomment-396047951","issue_url":"https://api.github.com/repos/mysuf/videojs-ima-player/issues/2","id":396047951,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjA0Nzk1MQ==","user":{"login":"mysuf","id":16492403,"node_id":"MDQ6VXNlcjE2NDkyNDAz","avatar_url":"https://avatars3.githubusercontent.com/u/16492403?v=4","gravatar_id":"","url":"https://api.github.com/users/mysuf","html_url":"https://github.com/mysuf","followers_url":"https://api.github.com/users/mysuf/followers","following_url":"https://api.github.com/users/mysuf/following{/other_user}","gists_url":"https://api.github.com/users/mysuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mysuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysuf/subscriptions","organizations_url":"https://api.github.com/users/mysuf/orgs","repos_url":"https://api.github.com/users/mysuf/repos","events_url":"https://api.github.com/users/mysuf/events{/privacy}","received_events_url":"https://api.github.com/users/mysuf/received_events","type":"User","site_admin":false},"created_at":"2018-06-10T13:07:57Z","updated_at":"2018-06-10T13:07:57Z","author_association":"OWNER","body":"One solution is adding browser-manager plugin to ima player. When iOS detected, it would add playsinline attribute to tech element and override content player's enter/exit fullscreen methods by passing enter/exit fullWindow methods instead. "}}
{"actor":{"display_login":"mysuf"}}