{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/245484285","pull_request_review_id":189603993,"id":245484285,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ4NDI4NQ==","diff_hunk":"@@ -1201,5 +1203,69 @@ uint ITypesDebugInfoWriter.GetMemberFunctionId(MemberFunctionIdTypeDescriptor me\n         {\n             return GetMemberFunctionIdTypeIndex(_nativeObjectWriter, memberIdDescriptor);\n         }\n+\n+        private static string GetLLVMTripleFromTarget(TargetDetails target)\n+        {\n+            // We create a triple based on the Target\n+            // Detect the LLVM arch\n+            string arch = null;\n+            // Not used\n+            string sub = string.Empty;\n+            switch (target.Architecture)\n+            {\n+                case TargetArchitecture.ARM:\n+                    arch = \"thumbv7\";\n+                    break;\n+                case TargetArchitecture.ARM64:\n+                    arch = \"aarch64\";\n+                    break;\n+                case TargetArchitecture.X64:\n+                    arch = \"x86_64\";\n+                    break;\n+                case TargetArchitecture.X86:\n+                    arch = \"x86\";\n+                    break;\n+                case TargetArchitecture.Wasm32:\n+                    arch = \"wasm32\";\n+                    break;\n+                default:\n+                    throw new InvalidOperationException($\"The architecture `{target.Architecture}` is not supported by ObjectWriter\");\n+            }\n+\n+            string vendor = null;","path":"src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/ObjectWriter.cs","position":53,"original_position":53,"commit_id":"cc48c5ba8f23e7bd8841780331de59d6e54d2eca","original_commit_id":"cc48c5ba8f23e7bd8841780331de59d6e54d2eca","user":{"login":"jkotas","id":6668460,"node_id":"MDQ6VXNlcjY2Njg0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Same here","created_at":"2019-01-05T18:03:34Z","updated_at":"2019-01-05T18:10:41Z","html_url":"https://github.com/dotnet/corert/pull/6772#discussion_r245484285","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/6772","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/245484285"},"html":{"href":"https://github.com/dotnet/corert/pull/6772#discussion_r245484285"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6772"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/6772","id":242430015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDMwMDE1","html_url":"https://github.com/dotnet/corert/pull/6772","diff_url":"https://github.com/dotnet/corert/pull/6772.diff","patch_url":"https://github.com/dotnet/corert/pull/6772.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/6772","number":6772,"state":"open","locked":false,"title":"Add cross-targeting support to ObjectWriter","user":{"login":"xoofx","id":715038,"node_id":"MDQ6VXNlcjcxNTAzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/715038?v=4","gravatar_id":"","url":"https://api.github.com/users/xoofx","html_url":"https://github.com/xoofx","followers_url":"https://api.github.com/users/xoofx/followers","following_url":"https://api.github.com/users/xoofx/following{/other_user}","gists_url":"https://api.github.com/users/xoofx/gists{/gist_id}","starred_url":"https://api.github.com/users/xoofx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoofx/subscriptions","organizations_url":"https://api.github.com/users/xoofx/orgs","repos_url":"https://api.github.com/users/xoofx/repos","events_url":"https://api.github.com/users/xoofx/events{/privacy}","received_events_url":"https://api.github.com/users/xoofx/received_events","type":"User","site_admin":false},"body":"This PR is for the following item from issue #2606 \r\n\r\n> - [ ]  Add cross-targeting support to ObjectWriter https://github.com/dotnet/llilc/tree/master/lib/ObjWriter (add a new argument to Initialize method to specify target platform)\r\n\r\nIt allows typically to generate ELF output from Windows directly\r\n\r\nThere is a TODO in this PR related to the ARM/ARM64 platforms/abi. It would require for example to add Tizen as a platform to be able to specify properly the `gnueabi`\r\n\r\ncc: @jkotas  @alpencolt","created_at":"2019-01-05T09:12:21Z","updated_at":"2019-01-05T18:10:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e8984c94f218583c313647da2244b01122b052b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/6772/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/6772/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/6772/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/cc48c5ba8f23e7bd8841780331de59d6e54d2eca","head":{"label":"xoofx:objwriter-multitarget","ref":"objwriter-multitarget","sha":"cc48c5ba8f23e7bd8841780331de59d6e54d2eca","user":{"login":"xoofx","id":715038,"node_id":"MDQ6VXNlcjcxNTAzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/715038?v=4","gravatar_id":"","url":"https://api.github.com/users/xoofx","html_url":"https://github.com/xoofx","followers_url":"https://api.github.com/users/xoofx/followers","following_url":"https://api.github.com/users/xoofx/following{/other_user}","gists_url":"https://api.github.com/users/xoofx/gists{/gist_id}","starred_url":"https://api.github.com/users/xoofx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoofx/subscriptions","organizations_url":"https://api.github.com/users/xoofx/orgs","repos_url":"https://api.github.com/users/xoofx/repos","events_url":"https://api.github.com/users/xoofx/events{/privacy}","received_events_url":"https://api.github.com/users/xoofx/received_events","type":"User","site_admin":false},"repo":{"id":164198893,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQxOTg4OTM=","name":"corert","full_name":"xoofx/corert","private":false,"owner":{"login":"xoofx","id":715038,"node_id":"MDQ6VXNlcjcxNTAzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/715038?v=4","gravatar_id":"","url":"https://api.github.com/users/xoofx","html_url":"https://github.com/xoofx","followers_url":"https://api.github.com/users/xoofx/followers","following_url":"https://api.github.com/users/xoofx/following{/other_user}","gists_url":"https://api.github.com/users/xoofx/gists{/gist_id}","starred_url":"https://api.github.com/users/xoofx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoofx/subscriptions","organizations_url":"https://api.github.com/users/xoofx/orgs","repos_url":"https://api.github.com/users/xoofx/repos","events_url":"https://api.github.com/users/xoofx/events{/privacy}","received_events_url":"https://api.github.com/users/xoofx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xoofx/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying compiler toolchain.","fork":true,"url":"https://api.github.com/repos/xoofx/corert","forks_url":"https://api.github.com/repos/xoofx/corert/forks","keys_url":"https://api.github.com/repos/xoofx/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xoofx/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xoofx/corert/teams","hooks_url":"https://api.github.com/repos/xoofx/corert/hooks","issue_events_url":"https://api.github.com/repos/xoofx/corert/issues/events{/number}","events_url":"https://api.github.com/repos/xoofx/corert/events","assignees_url":"https://api.github.com/repos/xoofx/corert/assignees{/user}","branches_url":"https://api.github.com/repos/xoofx/corert/branches{/branch}","tags_url":"https://api.github.com/repos/xoofx/corert/tags","blobs_url":"https://api.github.com/repos/xoofx/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xoofx/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xoofx/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/xoofx/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xoofx/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/xoofx/corert/languages","stargazers_url":"https://api.github.com/repos/xoofx/corert/stargazers","contributors_url":"https://api.github.com/repos/xoofx/corert/contributors","subscribers_url":"https://api.github.com/repos/xoofx/corert/subscribers","subscription_url":"https://api.github.com/repos/xoofx/corert/subscription","commits_url":"https://api.github.com/repos/xoofx/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/xoofx/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/xoofx/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/xoofx/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/xoofx/corert/contents/{+path}","compare_url":"https://api.github.com/repos/xoofx/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xoofx/corert/merges","archive_url":"https://api.github.com/repos/xoofx/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xoofx/corert/downloads","issues_url":"https://api.github.com/repos/xoofx/corert/issues{/number}","pulls_url":"https://api.github.com/repos/xoofx/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/xoofx/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/xoofx/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xoofx/corert/labels{/name}","releases_url":"https://api.github.com/repos/xoofx/corert/releases{/id}","deployments_url":"https://api.github.com/repos/xoofx/corert/deployments","created_at":"2019-01-05T09:04:43Z","updated_at":"2019-01-05T09:04:55Z","pushed_at":"2019-01-05T09:07:23Z","git_url":"git://github.com/xoofx/corert.git","ssh_url":"git@github.com:xoofx/corert.git","clone_url":"https://github.com/xoofx/corert.git","svn_url":"https://github.com/xoofx/corert","homepage":"http://dot.net","size":32696,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"3b92f3cef565364b0680ae65ff0532289b534b6d","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"node_id":"MDEwOlJlcG9zaXRvcnk0MjU1MjE0Mw==","name":"corert","full_name":"dotnet/corert","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2019-01-05T16:06:22Z","pushed_at":"2019-01-05T09:12:22Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dot.net","size":32896,"stargazers_count":1747,"watchers_count":1747,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":361,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":361,"open_issues":293,"watchers":1747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6772"},"html":{"href":"https://github.com/dotnet/corert/pull/6772"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/6772"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/6772/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6772/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6772/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/cc48c5ba8f23e7bd8841780331de59d6e54d2eca"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkotas"}}