{"action":"opened","number":341,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gporca/pulls/341","id":171151800,"html_url":"https://github.com/greenplum-db/gporca/pull/341","diff_url":"https://github.com/greenplum-db/gporca/pull/341.diff","patch_url":"https://github.com/greenplum-db/gporca/pull/341.patch","issue_url":"https://api.github.com/repos/greenplum-db/gporca/issues/341","number":341,"state":"open","locked":false,"title":"HashJoin rewindability should be identical to its outer child","user":{"login":"asubramanya","id":12837610,"avatar_url":"https://avatars1.githubusercontent.com/u/12837610?v=4","gravatar_id":"","url":"https://api.github.com/users/asubramanya","html_url":"https://github.com/asubramanya","followers_url":"https://api.github.com/users/asubramanya/followers","following_url":"https://api.github.com/users/asubramanya/following{/other_user}","gists_url":"https://api.github.com/users/asubramanya/gists{/gist_id}","starred_url":"https://api.github.com/users/asubramanya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asubramanya/subscriptions","organizations_url":"https://api.github.com/users/asubramanya/orgs","repos_url":"https://api.github.com/users/asubramanya/repos","events_url":"https://api.github.com/users/asubramanya/events{/privacy}","received_events_url":"https://api.github.com/users/asubramanya/received_events","type":"User","site_admin":false},"body":"Its inner child need not be rewindable for a hash join to be rewindable, unlike\r\na nested loop join. The logic to compute the derived and required properties\r\nwere out of sync.  Specifically the logic to derive the rewindablility for a\r\nhash join erraneously reported unrewindable when the inner child was not\r\nrewindable, even though the outer child was. This wasn't wrong logically, but\r\nit led to extraneous physical spool nodes in the plan, which might cause other\r\nissues for us. One such example is that the materialize might end up in between\r\na partition selector and a Dynamic table scan leading to wrong results.\r\n\r\nThis commit fixes that issue by simply returning the outer child's\r\nrewindability while deriving the rewindability.\r\n\r\n[#154605891]\r\nSigned-off-by: Abhijit Subramanya <asubramanya@pivotal.io>","created_at":"2018-02-24T01:19:29Z","updated_at":"2018-02-24T01:19:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gporca/pulls/341/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gporca/pulls/341/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gporca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gporca/issues/341/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gporca/statuses/2d7b0949a42d0137bf39a0d8aee2871ed599d8dd","head":{"label":"asubramanya:partition_selector_no_materialize3","ref":"partition_selector_no_materialize3","sha":"2d7b0949a42d0137bf39a0d8aee2871ed599d8dd","user":{"login":"asubramanya","id":12837610,"avatar_url":"https://avatars1.githubusercontent.com/u/12837610?v=4","gravatar_id":"","url":"https://api.github.com/users/asubramanya","html_url":"https://github.com/asubramanya","followers_url":"https://api.github.com/users/asubramanya/followers","following_url":"https://api.github.com/users/asubramanya/following{/other_user}","gists_url":"https://api.github.com/users/asubramanya/gists{/gist_id}","starred_url":"https://api.github.com/users/asubramanya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asubramanya/subscriptions","organizations_url":"https://api.github.com/users/asubramanya/orgs","repos_url":"https://api.github.com/users/asubramanya/repos","events_url":"https://api.github.com/users/asubramanya/events{/privacy}","received_events_url":"https://api.github.com/users/asubramanya/received_events","type":"User","site_admin":false},"repo":{"id":113254413,"name":"gporca","full_name":"asubramanya/gporca","owner":{"login":"asubramanya","id":12837610,"avatar_url":"https://avatars1.githubusercontent.com/u/12837610?v=4","gravatar_id":"","url":"https://api.github.com/users/asubramanya","html_url":"https://github.com/asubramanya","followers_url":"https://api.github.com/users/asubramanya/followers","following_url":"https://api.github.com/users/asubramanya/following{/other_user}","gists_url":"https://api.github.com/users/asubramanya/gists{/gist_id}","starred_url":"https://api.github.com/users/asubramanya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asubramanya/subscriptions","organizations_url":"https://api.github.com/users/asubramanya/orgs","repos_url":"https://api.github.com/users/asubramanya/repos","events_url":"https://api.github.com/users/asubramanya/events{/privacy}","received_events_url":"https://api.github.com/users/asubramanya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asubramanya/gporca","description":"A modular query optimizer for big data","fork":true,"url":"https://api.github.com/repos/asubramanya/gporca","forks_url":"https://api.github.com/repos/asubramanya/gporca/forks","keys_url":"https://api.github.com/repos/asubramanya/gporca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asubramanya/gporca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asubramanya/gporca/teams","hooks_url":"https://api.github.com/repos/asubramanya/gporca/hooks","issue_events_url":"https://api.github.com/repos/asubramanya/gporca/issues/events{/number}","events_url":"https://api.github.com/repos/asubramanya/gporca/events","assignees_url":"https://api.github.com/repos/asubramanya/gporca/assignees{/user}","branches_url":"https://api.github.com/repos/asubramanya/gporca/branches{/branch}","tags_url":"https://api.github.com/repos/asubramanya/gporca/tags","blobs_url":"https://api.github.com/repos/asubramanya/gporca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asubramanya/gporca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asubramanya/gporca/git/refs{/sha}","trees_url":"https://api.github.com/repos/asubramanya/gporca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asubramanya/gporca/statuses/{sha}","languages_url":"https://api.github.com/repos/asubramanya/gporca/languages","stargazers_url":"https://api.github.com/repos/asubramanya/gporca/stargazers","contributors_url":"https://api.github.com/repos/asubramanya/gporca/contributors","subscribers_url":"https://api.github.com/repos/asubramanya/gporca/subscribers","subscription_url":"https://api.github.com/repos/asubramanya/gporca/subscription","commits_url":"https://api.github.com/repos/asubramanya/gporca/commits{/sha}","git_commits_url":"https://api.github.com/repos/asubramanya/gporca/git/commits{/sha}","comments_url":"https://api.github.com/repos/asubramanya/gporca/comments{/number}","issue_comment_url":"https://api.github.com/repos/asubramanya/gporca/issues/comments{/number}","contents_url":"https://api.github.com/repos/asubramanya/gporca/contents/{+path}","compare_url":"https://api.github.com/repos/asubramanya/gporca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asubramanya/gporca/merges","archive_url":"https://api.github.com/repos/asubramanya/gporca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asubramanya/gporca/downloads","issues_url":"https://api.github.com/repos/asubramanya/gporca/issues{/number}","pulls_url":"https://api.github.com/repos/asubramanya/gporca/pulls{/number}","milestones_url":"https://api.github.com/repos/asubramanya/gporca/milestones{/number}","notifications_url":"https://api.github.com/repos/asubramanya/gporca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asubramanya/gporca/labels{/name}","releases_url":"https://api.github.com/repos/asubramanya/gporca/releases{/id}","deployments_url":"https://api.github.com/repos/asubramanya/gporca/deployments","created_at":"2017-12-06T01:45:26Z","updated_at":"2017-12-06T01:45:43Z","pushed_at":"2018-02-24T01:15:13Z","git_url":"git://github.com/asubramanya/gporca.git","ssh_url":"git@github.com:asubramanya/gporca.git","clone_url":"https://github.com/asubramanya/gporca.git","svn_url":"https://github.com/asubramanya/gporca","homepage":"","size":44188,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"dd0296734fcd7404a00a7573eac6a2f78f893439","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":47849203,"name":"gporca","full_name":"greenplum-db/gporca","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gporca","description":"A modular query optimizer for big data","fork":false,"url":"https://api.github.com/repos/greenplum-db/gporca","forks_url":"https://api.github.com/repos/greenplum-db/gporca/forks","keys_url":"https://api.github.com/repos/greenplum-db/gporca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gporca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gporca/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gporca/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gporca/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gporca/events","assignees_url":"https://api.github.com/repos/greenplum-db/gporca/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gporca/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gporca/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gporca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gporca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gporca/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gporca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gporca/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gporca/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gporca/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gporca/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gporca/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gporca/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gporca/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gporca/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gporca/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gporca/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gporca/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gporca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gporca/merges","archive_url":"https://api.github.com/repos/greenplum-db/gporca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gporca/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gporca/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gporca/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gporca/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gporca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gporca/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gporca/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gporca/deployments","created_at":"2015-12-11T20:24:47Z","updated_at":"2018-02-22T13:36:53Z","pushed_at":"2018-02-23T19:58:12Z","git_url":"git://github.com/greenplum-db/gporca.git","ssh_url":"git@github.com:greenplum-db/gporca.git","clone_url":"https://github.com/greenplum-db/gporca.git","svn_url":"https://github.com/greenplum-db/gporca","homepage":"","size":39869,"stargazers_count":123,"watchers_count":123,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":74,"open_issues":31,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gporca/pulls/341"},"html":{"href":"https://github.com/greenplum-db/gporca/pull/341"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gporca/issues/341"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gporca/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gporca/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gporca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gporca/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gporca/statuses/2d7b0949a42d0137bf39a0d8aee2871ed599d8dd"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1114,"deletions":490,"changed_files":29}}
{"actor":{"display_login":"asubramanya"}}