{"action":"created","comment":{"url":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/comments/234822929","pull_request_review_id":176547609,"id":234822929,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDgyMjkyOQ==","diff_hunk":"@@ -14,7 +14,10 @@ import qualified Data.Text as T\n personalLoansPage :: [Loan] -> HtmlPage (\"personalinformation\")\n personalLoansPage loans = page_ \"My loans\" (Just NavUser) $ do\n     let (bookLoans, boardgameLoans) = loanSorter loans\n-    unless (null bookLoans && null boardgameLoans) $ fullRow_ $ do\n+    if null bookLoans && null boardgameLoans then","path":"library-app/src/Futurice/App/Library/Pages/PersonalLoansPage.hs","position":5,"original_position":5,"commit_id":"459e847a41f2f45afff888c9259b73a470da32ca","original_commit_id":"459e847a41f2f45afff888c9259b73a470da32ca","user":{"login":"phadej","id":51087,"node_id":"MDQ6VXNlcjUxMDg3","avatar_url":"https://avatars2.githubusercontent.com/u/51087?v=4","gravatar_id":"","url":"https://api.github.com/users/phadej","html_url":"https://github.com/phadej","followers_url":"https://api.github.com/users/phadej/followers","following_url":"https://api.github.com/users/phadej/following{/other_user}","gists_url":"https://api.github.com/users/phadej/gists{/gist_id}","starred_url":"https://api.github.com/users/phadej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phadej/subscriptions","organizations_url":"https://api.github.com/users/phadej/orgs","repos_url":"https://api.github.com/users/phadej/repos","events_url":"https://api.github.com/users/phadej/events{/privacy}","received_events_url":"https://api.github.com/users/phadej/received_events","type":"User","site_admin":false},"body":"put the `then` on the next line","created_at":"2018-11-19T23:39:42Z","updated_at":"2018-11-19T23:40:08Z","html_url":"https://github.com/futurice/haskell-mega-repo/pull/632#discussion_r234822929","pull_request_url":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/comments/234822929"},"html":{"href":"https://github.com/futurice/haskell-mega-repo/pull/632#discussion_r234822929"},"pull_request":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/632"}}},"pull_request":{"url":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/632","id":231511582,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTExNTgy","html_url":"https://github.com/futurice/haskell-mega-repo/pull/632","diff_url":"https://github.com/futurice/haskell-mega-repo/pull/632.diff","patch_url":"https://github.com/futurice/haskell-mega-repo/pull/632.patch","issue_url":"https://api.github.com/repos/futurice/haskell-mega-repo/issues/632","number":632,"state":"open","locked":false,"title":"WIP: Library remainder","user":{"login":"neurogoo","id":7716973,"node_id":"MDQ6VXNlcjc3MTY5NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7716973?v=4","gravatar_id":"","url":"https://api.github.com/users/neurogoo","html_url":"https://github.com/neurogoo","followers_url":"https://api.github.com/users/neurogoo/followers","following_url":"https://api.github.com/users/neurogoo/following{/other_user}","gists_url":"https://api.github.com/users/neurogoo/gists{/gist_id}","starred_url":"https://api.github.com/users/neurogoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neurogoo/subscriptions","organizations_url":"https://api.github.com/users/neurogoo/orgs","repos_url":"https://api.github.com/users/neurogoo/repos","events_url":"https://api.github.com/users/neurogoo/events{/privacy}","received_events_url":"https://api.github.com/users/neurogoo/received_events","type":"User","site_admin":false},"body":"Current idea is, when sendRemainder is launched, it checks which loans are 30 days and over and have loantime `mod` 30 == 0. This is so that it doens't have to keep track which was the last time it send remainders to not spam people too much. Idea would be that this is launched once everyday.\r\n\r\nIf this sounds good then, next question is what next? I probably need to at this as Service? And what kind of authentication should I put here?","created_at":"2018-11-16T12:15:37Z","updated_at":"2018-11-19T23:40:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0daa45884b1b671b43e5ad57c242761ca9f3f2c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/632/commits","review_comments_url":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/632/comments","review_comment_url":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/futurice/haskell-mega-repo/issues/632/comments","statuses_url":"https://api.github.com/repos/futurice/haskell-mega-repo/statuses/459e847a41f2f45afff888c9259b73a470da32ca","head":{"label":"futurice:library-remainder","ref":"library-remainder","sha":"459e847a41f2f45afff888c9259b73a470da32ca","user":{"login":"futurice","id":852157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjE1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/852157?v=4","gravatar_id":"","url":"https://api.github.com/users/futurice","html_url":"https://github.com/futurice","followers_url":"https://api.github.com/users/futurice/followers","following_url":"https://api.github.com/users/futurice/following{/other_user}","gists_url":"https://api.github.com/users/futurice/gists{/gist_id}","starred_url":"https://api.github.com/users/futurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futurice/subscriptions","organizations_url":"https://api.github.com/users/futurice/orgs","repos_url":"https://api.github.com/users/futurice/repos","events_url":"https://api.github.com/users/futurice/events{/privacy}","received_events_url":"https://api.github.com/users/futurice/received_events","type":"Organization","site_admin":false},"repo":{"id":42568032,"node_id":"MDEwOlJlcG9zaXRvcnk0MjU2ODAzMg==","name":"haskell-mega-repo","full_name":"futurice/haskell-mega-repo","private":false,"owner":{"login":"futurice","id":852157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjE1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/852157?v=4","gravatar_id":"","url":"https://api.github.com/users/futurice","html_url":"https://github.com/futurice","followers_url":"https://api.github.com/users/futurice/followers","following_url":"https://api.github.com/users/futurice/following{/other_user}","gists_url":"https://api.github.com/users/futurice/gists{/gist_id}","starred_url":"https://api.github.com/users/futurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futurice/subscriptions","organizations_url":"https://api.github.com/users/futurice/orgs","repos_url":"https://api.github.com/users/futurice/repos","events_url":"https://api.github.com/users/futurice/events{/privacy}","received_events_url":"https://api.github.com/users/futurice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/futurice/haskell-mega-repo","description":"Sometimes you need to make a change across the package boundaries","fork":false,"url":"https://api.github.com/repos/futurice/haskell-mega-repo","forks_url":"https://api.github.com/repos/futurice/haskell-mega-repo/forks","keys_url":"https://api.github.com/repos/futurice/haskell-mega-repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/futurice/haskell-mega-repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/futurice/haskell-mega-repo/teams","hooks_url":"https://api.github.com/repos/futurice/haskell-mega-repo/hooks","issue_events_url":"https://api.github.com/repos/futurice/haskell-mega-repo/issues/events{/number}","events_url":"https://api.github.com/repos/futurice/haskell-mega-repo/events","assignees_url":"https://api.github.com/repos/futurice/haskell-mega-repo/assignees{/user}","branches_url":"https://api.github.com/repos/futurice/haskell-mega-repo/branches{/branch}","tags_url":"https://api.github.com/repos/futurice/haskell-mega-repo/tags","blobs_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/futurice/haskell-mega-repo/statuses/{sha}","languages_url":"https://api.github.com/repos/futurice/haskell-mega-repo/languages","stargazers_url":"https://api.github.com/repos/futurice/haskell-mega-repo/stargazers","contributors_url":"https://api.github.com/repos/futurice/haskell-mega-repo/contributors","subscribers_url":"https://api.github.com/repos/futurice/haskell-mega-repo/subscribers","subscription_url":"https://api.github.com/repos/futurice/haskell-mega-repo/subscription","commits_url":"https://api.github.com/repos/futurice/haskell-mega-repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/futurice/haskell-mega-repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/futurice/haskell-mega-repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/futurice/haskell-mega-repo/contents/{+path}","compare_url":"https://api.github.com/repos/futurice/haskell-mega-repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/futurice/haskell-mega-repo/merges","archive_url":"https://api.github.com/repos/futurice/haskell-mega-repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/futurice/haskell-mega-repo/downloads","issues_url":"https://api.github.com/repos/futurice/haskell-mega-repo/issues{/number}","pulls_url":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls{/number}","milestones_url":"https://api.github.com/repos/futurice/haskell-mega-repo/milestones{/number}","notifications_url":"https://api.github.com/repos/futurice/haskell-mega-repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/futurice/haskell-mega-repo/labels{/name}","releases_url":"https://api.github.com/repos/futurice/haskell-mega-repo/releases{/id}","deployments_url":"https://api.github.com/repos/futurice/haskell-mega-repo/deployments","created_at":"2015-09-16T06:06:42Z","updated_at":"2018-11-19T11:20:15Z","pushed_at":"2018-11-19T20:34:13Z","git_url":"git://github.com/futurice/haskell-mega-repo.git","ssh_url":"git@github.com:futurice/haskell-mega-repo.git","clone_url":"https://github.com/futurice/haskell-mega-repo.git","svn_url":"https://github.com/futurice/haskell-mega-repo","homepage":null,"size":46954,"stargazers_count":15,"watchers_count":15,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":46,"license":null,"forks":4,"open_issues":46,"watchers":15,"default_branch":"master"}},"base":{"label":"futurice:master","ref":"master","sha":"35f3fc3ce6678e54bb1b34f3f693d1ff09ba551a","user":{"login":"futurice","id":852157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjE1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/852157?v=4","gravatar_id":"","url":"https://api.github.com/users/futurice","html_url":"https://github.com/futurice","followers_url":"https://api.github.com/users/futurice/followers","following_url":"https://api.github.com/users/futurice/following{/other_user}","gists_url":"https://api.github.com/users/futurice/gists{/gist_id}","starred_url":"https://api.github.com/users/futurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futurice/subscriptions","organizations_url":"https://api.github.com/users/futurice/orgs","repos_url":"https://api.github.com/users/futurice/repos","events_url":"https://api.github.com/users/futurice/events{/privacy}","received_events_url":"https://api.github.com/users/futurice/received_events","type":"Organization","site_admin":false},"repo":{"id":42568032,"node_id":"MDEwOlJlcG9zaXRvcnk0MjU2ODAzMg==","name":"haskell-mega-repo","full_name":"futurice/haskell-mega-repo","private":false,"owner":{"login":"futurice","id":852157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjE1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/852157?v=4","gravatar_id":"","url":"https://api.github.com/users/futurice","html_url":"https://github.com/futurice","followers_url":"https://api.github.com/users/futurice/followers","following_url":"https://api.github.com/users/futurice/following{/other_user}","gists_url":"https://api.github.com/users/futurice/gists{/gist_id}","starred_url":"https://api.github.com/users/futurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futurice/subscriptions","organizations_url":"https://api.github.com/users/futurice/orgs","repos_url":"https://api.github.com/users/futurice/repos","events_url":"https://api.github.com/users/futurice/events{/privacy}","received_events_url":"https://api.github.com/users/futurice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/futurice/haskell-mega-repo","description":"Sometimes you need to make a change across the package boundaries","fork":false,"url":"https://api.github.com/repos/futurice/haskell-mega-repo","forks_url":"https://api.github.com/repos/futurice/haskell-mega-repo/forks","keys_url":"https://api.github.com/repos/futurice/haskell-mega-repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/futurice/haskell-mega-repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/futurice/haskell-mega-repo/teams","hooks_url":"https://api.github.com/repos/futurice/haskell-mega-repo/hooks","issue_events_url":"https://api.github.com/repos/futurice/haskell-mega-repo/issues/events{/number}","events_url":"https://api.github.com/repos/futurice/haskell-mega-repo/events","assignees_url":"https://api.github.com/repos/futurice/haskell-mega-repo/assignees{/user}","branches_url":"https://api.github.com/repos/futurice/haskell-mega-repo/branches{/branch}","tags_url":"https://api.github.com/repos/futurice/haskell-mega-repo/tags","blobs_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/futurice/haskell-mega-repo/statuses/{sha}","languages_url":"https://api.github.com/repos/futurice/haskell-mega-repo/languages","stargazers_url":"https://api.github.com/repos/futurice/haskell-mega-repo/stargazers","contributors_url":"https://api.github.com/repos/futurice/haskell-mega-repo/contributors","subscribers_url":"https://api.github.com/repos/futurice/haskell-mega-repo/subscribers","subscription_url":"https://api.github.com/repos/futurice/haskell-mega-repo/subscription","commits_url":"https://api.github.com/repos/futurice/haskell-mega-repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/futurice/haskell-mega-repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/futurice/haskell-mega-repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/futurice/haskell-mega-repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/futurice/haskell-mega-repo/contents/{+path}","compare_url":"https://api.github.com/repos/futurice/haskell-mega-repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/futurice/haskell-mega-repo/merges","archive_url":"https://api.github.com/repos/futurice/haskell-mega-repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/futurice/haskell-mega-repo/downloads","issues_url":"https://api.github.com/repos/futurice/haskell-mega-repo/issues{/number}","pulls_url":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls{/number}","milestones_url":"https://api.github.com/repos/futurice/haskell-mega-repo/milestones{/number}","notifications_url":"https://api.github.com/repos/futurice/haskell-mega-repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/futurice/haskell-mega-repo/labels{/name}","releases_url":"https://api.github.com/repos/futurice/haskell-mega-repo/releases{/id}","deployments_url":"https://api.github.com/repos/futurice/haskell-mega-repo/deployments","created_at":"2015-09-16T06:06:42Z","updated_at":"2018-11-19T11:20:15Z","pushed_at":"2018-11-19T20:34:13Z","git_url":"git://github.com/futurice/haskell-mega-repo.git","ssh_url":"git@github.com:futurice/haskell-mega-repo.git","clone_url":"https://github.com/futurice/haskell-mega-repo.git","svn_url":"https://github.com/futurice/haskell-mega-repo","homepage":null,"size":46954,"stargazers_count":15,"watchers_count":15,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":46,"license":null,"forks":4,"open_issues":46,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/632"},"html":{"href":"https://github.com/futurice/haskell-mega-repo/pull/632"},"issue":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/issues/632"},"comments":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/futurice/haskell-mega-repo/statuses/459e847a41f2f45afff888c9259b73a470da32ca"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"phadej"}}