{"action":"created","comment":{"url":"https://api.github.com/repos/serokell/disciplina/pulls/comments/174262223","pull_request_review_id":103586522,"id":174262223,"diff_hunk":"@@ -0,0 +1,63 @@\n+\n+-- | Common resources used by Disciplina nodes\n+\n+module Disciplina.Launcher.Resource\n+       ( BasicNodeResources (..)\n+       , bracketBasicNodeResources\n+       ) where\n+\n+import Universum\n+\n+import Mockable (Production)\n+import System.Wlog (LoggerConfig (..), LoggerName, WithLogger, maybeLogsDirB, parseLoggerConfig,\n+                    productionB, removeAllHandlers, setupLogging, showTidB)\n+\n+import Disciplina.Launcher.Params (BasicNodeParams (..), LoggingParams (..))\n+\n+-- | Datatype which contains resources required by all Disciplina nodes\n+-- to start working.\n+data BasicNodeResources = BasicNodeResources\n+    { bnrLoggerName :: !LoggerName\n+    }\n+\n+----------------------------------------------------------------------------\n+-- Logging\n+----------------------------------------------------------------------------\n+\n+readLoggerConfig :: MonadIO m => Maybe FilePath -> m LoggerConfig","path":"src/Disciplina/Launcher/Resource.hs","position":27,"original_position":27,"commit_id":"636e86fbb3e049eed21be57a8a93a193aa2a9576","original_commit_id":"636e86fbb3e049eed21be57a8a93a193aa2a9576","user":{"login":"lambda76","id":36677252,"avatar_url":"https://avatars2.githubusercontent.com/u/36677252?v=4","gravatar_id":"","url":"https://api.github.com/users/lambda76","html_url":"https://github.com/lambda76","followers_url":"https://api.github.com/users/lambda76/followers","following_url":"https://api.github.com/users/lambda76/following{/other_user}","gists_url":"https://api.github.com/users/lambda76/gists{/gist_id}","starred_url":"https://api.github.com/users/lambda76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambda76/subscriptions","organizations_url":"https://api.github.com/users/lambda76/orgs","repos_url":"https://api.github.com/users/lambda76/repos","events_url":"https://api.github.com/users/lambda76/events{/privacy}","received_events_url":"https://api.github.com/users/lambda76/received_events","type":"User","site_admin":false},"body":"Why use mtl-style MonadIO instead of concrete Production type with these logging functions, readLoggerConfig, getRealLoggerConfig and setupLoggers?","created_at":"2018-03-13T19:49:54Z","updated_at":"2018-03-13T19:49:54Z","html_url":"https://github.com/serokell/disciplina/pull/2#discussion_r174262223","pull_request_url":"https://api.github.com/repos/serokell/disciplina/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/serokell/disciplina/pulls/comments/174262223"},"html":{"href":"https://github.com/serokell/disciplina/pull/2#discussion_r174262223"},"pull_request":{"href":"https://api.github.com/repos/serokell/disciplina/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/serokell/disciplina/pulls/2","id":174650816,"html_url":"https://github.com/serokell/disciplina/pull/2","diff_url":"https://github.com/serokell/disciplina/pull/2.diff","patch_url":"https://github.com/serokell/disciplina/pull/2.patch","issue_url":"https://api.github.com/repos/serokell/disciplina/issues/2","number":2,"state":"open","locked":false,"title":"WIP [TMP-39] Init node launcher structure","user":{"login":"flyingleafe","id":1803963,"avatar_url":"https://avatars2.githubusercontent.com/u/1803963?v=4","gravatar_id":"","url":"https://api.github.com/users/flyingleafe","html_url":"https://github.com/flyingleafe","followers_url":"https://api.github.com/users/flyingleafe/followers","following_url":"https://api.github.com/users/flyingleafe/following{/other_user}","gists_url":"https://api.github.com/users/flyingleafe/gists{/gist_id}","starred_url":"https://api.github.com/users/flyingleafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flyingleafe/subscriptions","organizations_url":"https://api.github.com/users/flyingleafe/orgs","repos_url":"https://api.github.com/users/flyingleafe/repos","events_url":"https://api.github.com/users/flyingleafe/events{/privacy}","received_events_url":"https://api.github.com/users/flyingleafe/received_events","type":"User","site_admin":false},"body":"- [x] Define basic launcher structure (modules, brackets, etc.)\r\n- [x] Basic CLI params parsing\r\n- [x] Initiate logging\r\n- [ ] Workers initiation","created_at":"2018-03-13T12:55:34Z","updated_at":"2018-03-13T19:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"310cebc6a533e6735f0caa9bd37f605d39a69376","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Heimdell","id":1784505,"avatar_url":"https://avatars3.githubusercontent.com/u/1784505?v=4","gravatar_id":"","url":"https://api.github.com/users/Heimdell","html_url":"https://github.com/Heimdell","followers_url":"https://api.github.com/users/Heimdell/followers","following_url":"https://api.github.com/users/Heimdell/following{/other_user}","gists_url":"https://api.github.com/users/Heimdell/gists{/gist_id}","starred_url":"https://api.github.com/users/Heimdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heimdell/subscriptions","organizations_url":"https://api.github.com/users/Heimdell/orgs","repos_url":"https://api.github.com/users/Heimdell/repos","events_url":"https://api.github.com/users/Heimdell/events{/privacy}","received_events_url":"https://api.github.com/users/Heimdell/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/serokell/disciplina/pulls/2/commits","review_comments_url":"https://api.github.com/repos/serokell/disciplina/pulls/2/comments","review_comment_url":"https://api.github.com/repos/serokell/disciplina/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serokell/disciplina/issues/2/comments","statuses_url":"https://api.github.com/repos/serokell/disciplina/statuses/636e86fbb3e049eed21be57a8a93a193aa2a9576","head":{"label":"serokell:flyingleafe/tmp39-launcher-init","ref":"flyingleafe/tmp39-launcher-init","sha":"636e86fbb3e049eed21be57a8a93a193aa2a9576","user":{"login":"serokell","id":13840520,"avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"repo":{"id":113064771,"name":"disciplina","full_name":"serokell/disciplina","owner":{"login":"serokell","id":13840520,"avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serokell/disciplina","description":"Blockchain platform for the field of education","fork":false,"url":"https://api.github.com/repos/serokell/disciplina","forks_url":"https://api.github.com/repos/serokell/disciplina/forks","keys_url":"https://api.github.com/repos/serokell/disciplina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serokell/disciplina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serokell/disciplina/teams","hooks_url":"https://api.github.com/repos/serokell/disciplina/hooks","issue_events_url":"https://api.github.com/repos/serokell/disciplina/issues/events{/number}","events_url":"https://api.github.com/repos/serokell/disciplina/events","assignees_url":"https://api.github.com/repos/serokell/disciplina/assignees{/user}","branches_url":"https://api.github.com/repos/serokell/disciplina/branches{/branch}","tags_url":"https://api.github.com/repos/serokell/disciplina/tags","blobs_url":"https://api.github.com/repos/serokell/disciplina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serokell/disciplina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serokell/disciplina/git/refs{/sha}","trees_url":"https://api.github.com/repos/serokell/disciplina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serokell/disciplina/statuses/{sha}","languages_url":"https://api.github.com/repos/serokell/disciplina/languages","stargazers_url":"https://api.github.com/repos/serokell/disciplina/stargazers","contributors_url":"https://api.github.com/repos/serokell/disciplina/contributors","subscribers_url":"https://api.github.com/repos/serokell/disciplina/subscribers","subscription_url":"https://api.github.com/repos/serokell/disciplina/subscription","commits_url":"https://api.github.com/repos/serokell/disciplina/commits{/sha}","git_commits_url":"https://api.github.com/repos/serokell/disciplina/git/commits{/sha}","comments_url":"https://api.github.com/repos/serokell/disciplina/comments{/number}","issue_comment_url":"https://api.github.com/repos/serokell/disciplina/issues/comments{/number}","contents_url":"https://api.github.com/repos/serokell/disciplina/contents/{+path}","compare_url":"https://api.github.com/repos/serokell/disciplina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serokell/disciplina/merges","archive_url":"https://api.github.com/repos/serokell/disciplina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serokell/disciplina/downloads","issues_url":"https://api.github.com/repos/serokell/disciplina/issues{/number}","pulls_url":"https://api.github.com/repos/serokell/disciplina/pulls{/number}","milestones_url":"https://api.github.com/repos/serokell/disciplina/milestones{/number}","notifications_url":"https://api.github.com/repos/serokell/disciplina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serokell/disciplina/labels{/name}","releases_url":"https://api.github.com/repos/serokell/disciplina/releases{/id}","deployments_url":"https://api.github.com/repos/serokell/disciplina/deployments","created_at":"2017-12-04T16:10:46Z","updated_at":"2018-03-12T13:41:49Z","pushed_at":"2018-03-13T12:55:34Z","git_url":"git://github.com/serokell/disciplina.git","ssh_url":"git@github.com:serokell/disciplina.git","clone_url":"https://github.com/serokell/disciplina.git","svn_url":"https://github.com/serokell/disciplina","homepage":null,"size":2442,"stargazers_count":2,"watchers_count":2,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"serokell:master","ref":"master","sha":"812baf50d39952b000c13a29f86688004b5ba157","user":{"login":"serokell","id":13840520,"avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"repo":{"id":113064771,"name":"disciplina","full_name":"serokell/disciplina","owner":{"login":"serokell","id":13840520,"avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serokell/disciplina","description":"Blockchain platform for the field of education","fork":false,"url":"https://api.github.com/repos/serokell/disciplina","forks_url":"https://api.github.com/repos/serokell/disciplina/forks","keys_url":"https://api.github.com/repos/serokell/disciplina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serokell/disciplina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serokell/disciplina/teams","hooks_url":"https://api.github.com/repos/serokell/disciplina/hooks","issue_events_url":"https://api.github.com/repos/serokell/disciplina/issues/events{/number}","events_url":"https://api.github.com/repos/serokell/disciplina/events","assignees_url":"https://api.github.com/repos/serokell/disciplina/assignees{/user}","branches_url":"https://api.github.com/repos/serokell/disciplina/branches{/branch}","tags_url":"https://api.github.com/repos/serokell/disciplina/tags","blobs_url":"https://api.github.com/repos/serokell/disciplina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serokell/disciplina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serokell/disciplina/git/refs{/sha}","trees_url":"https://api.github.com/repos/serokell/disciplina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serokell/disciplina/statuses/{sha}","languages_url":"https://api.github.com/repos/serokell/disciplina/languages","stargazers_url":"https://api.github.com/repos/serokell/disciplina/stargazers","contributors_url":"https://api.github.com/repos/serokell/disciplina/contributors","subscribers_url":"https://api.github.com/repos/serokell/disciplina/subscribers","subscription_url":"https://api.github.com/repos/serokell/disciplina/subscription","commits_url":"https://api.github.com/repos/serokell/disciplina/commits{/sha}","git_commits_url":"https://api.github.com/repos/serokell/disciplina/git/commits{/sha}","comments_url":"https://api.github.com/repos/serokell/disciplina/comments{/number}","issue_comment_url":"https://api.github.com/repos/serokell/disciplina/issues/comments{/number}","contents_url":"https://api.github.com/repos/serokell/disciplina/contents/{+path}","compare_url":"https://api.github.com/repos/serokell/disciplina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serokell/disciplina/merges","archive_url":"https://api.github.com/repos/serokell/disciplina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serokell/disciplina/downloads","issues_url":"https://api.github.com/repos/serokell/disciplina/issues{/number}","pulls_url":"https://api.github.com/repos/serokell/disciplina/pulls{/number}","milestones_url":"https://api.github.com/repos/serokell/disciplina/milestones{/number}","notifications_url":"https://api.github.com/repos/serokell/disciplina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serokell/disciplina/labels{/name}","releases_url":"https://api.github.com/repos/serokell/disciplina/releases{/id}","deployments_url":"https://api.github.com/repos/serokell/disciplina/deployments","created_at":"2017-12-04T16:10:46Z","updated_at":"2018-03-12T13:41:49Z","pushed_at":"2018-03-13T12:55:34Z","git_url":"git://github.com/serokell/disciplina.git","ssh_url":"git@github.com:serokell/disciplina.git","clone_url":"https://github.com/serokell/disciplina.git","svn_url":"https://github.com/serokell/disciplina","homepage":null,"size":2442,"stargazers_count":2,"watchers_count":2,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serokell/disciplina/pulls/2"},"html":{"href":"https://github.com/serokell/disciplina/pull/2"},"issue":{"href":"https://api.github.com/repos/serokell/disciplina/issues/2"},"comments":{"href":"https://api.github.com/repos/serokell/disciplina/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/serokell/disciplina/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/serokell/disciplina/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serokell/disciplina/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/serokell/disciplina/statuses/636e86fbb3e049eed21be57a8a93a193aa2a9576"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lambda76"}}