{"action":"created","comment":{"url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/comments/202084216","pull_request_review_id":136712007,"id":202084216,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjA4NDIxNg==","diff_hunk":"@@ -0,0 +1,54 @@\n+#pragma once\n+\n+#include <vector>\n+#include <cstddef>\n+#include <memory>\n+\n+\n+namespace Baikal\n+{\n+    namespace PostEffects\n+    {\n+        class Buffer\n+        {\n+        public:\n+            using ValueType = float;\n+            using Data = std::unique_ptr<ValueType[]>;\n+            using Shape = std::tupel<size_t, size_t, size_t>;\n+\n+            Buffer(Data data, Shape shape) :\n+                m_data(std::move(data)),\n+                m_shape(std::move(shape)),\n+                m_size(std::get<0>(m_shape) *\n+                       std::get<1>(m_shape) *\n+                       std::get<2>(m_shape))\n+            {\n+            }\n+\n+            bool empty() const","path":"Baikal/PostEffects/ML/buffer.h","position":28,"original_position":28,"commit_id":"fe076397ad5aa389f6b77bfc0be3accf5e10cca8","original_commit_id":"fe076397ad5aa389f6b77bfc0be3accf5e10cca8","user":{"login":"AvKhokhlov","id":33451906,"node_id":"MDQ6VXNlcjMzNDUxOTA2","avatar_url":"https://avatars1.githubusercontent.com/u/33451906?v=4","gravatar_id":"","url":"https://api.github.com/users/AvKhokhlov","html_url":"https://github.com/AvKhokhlov","followers_url":"https://api.github.com/users/AvKhokhlov/followers","following_url":"https://api.github.com/users/AvKhokhlov/following{/other_user}","gists_url":"https://api.github.com/users/AvKhokhlov/gists{/gist_id}","starred_url":"https://api.github.com/users/AvKhokhlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvKhokhlov/subscriptions","organizations_url":"https://api.github.com/users/AvKhokhlov/orgs","repos_url":"https://api.github.com/users/AvKhokhlov/repos","events_url":"https://api.github.com/users/AvKhokhlov/events{/privacy}","received_events_url":"https://api.github.com/users/AvKhokhlov/received_events","type":"User","site_admin":false},"body":"I don't like this empty(), maybe use std::optional? Let's do this as separate project just like BaikalDataGenerator and use C++17","created_at":"2018-07-12T15:43:35Z","updated_at":"2018-07-12T15:51:44Z","html_url":"https://github.com/achernigin1987/RadeonProRender-Baikal/pull/1#discussion_r202084216","pull_request_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/comments/202084216"},"html":{"href":"https://github.com/achernigin1987/RadeonProRender-Baikal/pull/1#discussion_r202084216"},"pull_request":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/1","id":201016366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDE2MzY2","html_url":"https://github.com/achernigin1987/RadeonProRender-Baikal/pull/1","diff_url":"https://github.com/achernigin1987/RadeonProRender-Baikal/pull/1.diff","patch_url":"https://github.com/achernigin1987/RadeonProRender-Baikal/pull/1.patch","issue_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues/1","number":1,"state":"open","locked":false,"title":"Inrefence API draft","user":{"login":"dtarakanov1","id":39917536,"node_id":"MDQ6VXNlcjM5OTE3NTM2","avatar_url":"https://avatars0.githubusercontent.com/u/39917536?v=4","gravatar_id":"","url":"https://api.github.com/users/dtarakanov1","html_url":"https://github.com/dtarakanov1","followers_url":"https://api.github.com/users/dtarakanov1/followers","following_url":"https://api.github.com/users/dtarakanov1/following{/other_user}","gists_url":"https://api.github.com/users/dtarakanov1/gists{/gist_id}","starred_url":"https://api.github.com/users/dtarakanov1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtarakanov1/subscriptions","organizations_url":"https://api.github.com/users/dtarakanov1/orgs","repos_url":"https://api.github.com/users/dtarakanov1/repos","events_url":"https://api.github.com/users/dtarakanov1/events{/privacy}","received_events_url":"https://api.github.com/users/dtarakanov1/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-12T14:15:41Z","updated_at":"2018-07-12T15:51:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f906a3ab2e3712986cca19f37d2f42a45821517","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/1/commits","review_comments_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/1/comments","review_comment_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues/1/comments","statuses_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/statuses/fe076397ad5aa389f6b77bfc0be3accf5e10cca8","head":{"label":"achernigin1987:dtarakanov/inference-api-draft","ref":"dtarakanov/inference-api-draft","sha":"fe076397ad5aa389f6b77bfc0be3accf5e10cca8","user":{"login":"achernigin1987","id":22882667,"node_id":"MDQ6VXNlcjIyODgyNjY3","avatar_url":"https://avatars0.githubusercontent.com/u/22882667?v=4","gravatar_id":"","url":"https://api.github.com/users/achernigin1987","html_url":"https://github.com/achernigin1987","followers_url":"https://api.github.com/users/achernigin1987/followers","following_url":"https://api.github.com/users/achernigin1987/following{/other_user}","gists_url":"https://api.github.com/users/achernigin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/achernigin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achernigin1987/subscriptions","organizations_url":"https://api.github.com/users/achernigin1987/orgs","repos_url":"https://api.github.com/users/achernigin1987/repos","events_url":"https://api.github.com/users/achernigin1987/events{/privacy}","received_events_url":"https://api.github.com/users/achernigin1987/received_events","type":"User","site_admin":false},"repo":{"id":140715547,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3MTU1NDc=","name":"RadeonProRender-Baikal","full_name":"achernigin1987/RadeonProRender-Baikal","owner":{"login":"achernigin1987","id":22882667,"node_id":"MDQ6VXNlcjIyODgyNjY3","avatar_url":"https://avatars0.githubusercontent.com/u/22882667?v=4","gravatar_id":"","url":"https://api.github.com/users/achernigin1987","html_url":"https://github.com/achernigin1987","followers_url":"https://api.github.com/users/achernigin1987/followers","following_url":"https://api.github.com/users/achernigin1987/following{/other_user}","gists_url":"https://api.github.com/users/achernigin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/achernigin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achernigin1987/subscriptions","organizations_url":"https://api.github.com/users/achernigin1987/orgs","repos_url":"https://api.github.com/users/achernigin1987/repos","events_url":"https://api.github.com/users/achernigin1987/events{/privacy}","received_events_url":"https://api.github.com/users/achernigin1987/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achernigin1987/RadeonProRender-Baikal","description":null,"fork":true,"url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal","forks_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/forks","keys_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/teams","hooks_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/hooks","issue_events_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues/events{/number}","events_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/events","assignees_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/assignees{/user}","branches_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/branches{/branch}","tags_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/tags","blobs_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/refs{/sha}","trees_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/statuses/{sha}","languages_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/languages","stargazers_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/stargazers","contributors_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/contributors","subscribers_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/subscribers","subscription_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/subscription","commits_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/commits{/sha}","git_commits_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/commits{/sha}","comments_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/comments{/number}","issue_comment_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues/comments{/number}","contents_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/contents/{+path}","compare_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/merges","archive_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/downloads","issues_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues{/number}","pulls_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls{/number}","milestones_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/milestones{/number}","notifications_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/labels{/name}","releases_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/releases{/id}","deployments_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/deployments","created_at":"2018-07-12T13:17:40Z","updated_at":"2018-07-12T13:17:43Z","pushed_at":"2018-07-12T15:35:49Z","git_url":"git://github.com/achernigin1987/RadeonProRender-Baikal.git","ssh_url":"git@github.com:achernigin1987/RadeonProRender-Baikal.git","clone_url":"https://github.com/achernigin1987/RadeonProRender-Baikal.git","svn_url":"https://github.com/achernigin1987/RadeonProRender-Baikal","homepage":null,"size":50080,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"achernigin1987:master","ref":"master","sha":"465339c76da2a9c2ca9b5b615a3090dbd5eaeaca","user":{"login":"achernigin1987","id":22882667,"node_id":"MDQ6VXNlcjIyODgyNjY3","avatar_url":"https://avatars0.githubusercontent.com/u/22882667?v=4","gravatar_id":"","url":"https://api.github.com/users/achernigin1987","html_url":"https://github.com/achernigin1987","followers_url":"https://api.github.com/users/achernigin1987/followers","following_url":"https://api.github.com/users/achernigin1987/following{/other_user}","gists_url":"https://api.github.com/users/achernigin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/achernigin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achernigin1987/subscriptions","organizations_url":"https://api.github.com/users/achernigin1987/orgs","repos_url":"https://api.github.com/users/achernigin1987/repos","events_url":"https://api.github.com/users/achernigin1987/events{/privacy}","received_events_url":"https://api.github.com/users/achernigin1987/received_events","type":"User","site_admin":false},"repo":{"id":140715547,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3MTU1NDc=","name":"RadeonProRender-Baikal","full_name":"achernigin1987/RadeonProRender-Baikal","owner":{"login":"achernigin1987","id":22882667,"node_id":"MDQ6VXNlcjIyODgyNjY3","avatar_url":"https://avatars0.githubusercontent.com/u/22882667?v=4","gravatar_id":"","url":"https://api.github.com/users/achernigin1987","html_url":"https://github.com/achernigin1987","followers_url":"https://api.github.com/users/achernigin1987/followers","following_url":"https://api.github.com/users/achernigin1987/following{/other_user}","gists_url":"https://api.github.com/users/achernigin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/achernigin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achernigin1987/subscriptions","organizations_url":"https://api.github.com/users/achernigin1987/orgs","repos_url":"https://api.github.com/users/achernigin1987/repos","events_url":"https://api.github.com/users/achernigin1987/events{/privacy}","received_events_url":"https://api.github.com/users/achernigin1987/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achernigin1987/RadeonProRender-Baikal","description":null,"fork":true,"url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal","forks_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/forks","keys_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/teams","hooks_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/hooks","issue_events_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues/events{/number}","events_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/events","assignees_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/assignees{/user}","branches_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/branches{/branch}","tags_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/tags","blobs_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/refs{/sha}","trees_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/statuses/{sha}","languages_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/languages","stargazers_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/stargazers","contributors_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/contributors","subscribers_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/subscribers","subscription_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/subscription","commits_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/commits{/sha}","git_commits_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/git/commits{/sha}","comments_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/comments{/number}","issue_comment_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues/comments{/number}","contents_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/contents/{+path}","compare_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/merges","archive_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/downloads","issues_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues{/number}","pulls_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls{/number}","milestones_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/milestones{/number}","notifications_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/labels{/name}","releases_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/releases{/id}","deployments_url":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/deployments","created_at":"2018-07-12T13:17:40Z","updated_at":"2018-07-12T13:17:43Z","pushed_at":"2018-07-12T15:35:49Z","git_url":"git://github.com/achernigin1987/RadeonProRender-Baikal.git","ssh_url":"git@github.com:achernigin1987/RadeonProRender-Baikal.git","clone_url":"https://github.com/achernigin1987/RadeonProRender-Baikal.git","svn_url":"https://github.com/achernigin1987/RadeonProRender-Baikal","homepage":null,"size":50080,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/1"},"html":{"href":"https://github.com/achernigin1987/RadeonProRender-Baikal/pull/1"},"issue":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues/1"},"comments":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/achernigin1987/RadeonProRender-Baikal/statuses/fe076397ad5aa389f6b77bfc0be3accf5e10cca8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"AvKhokhlov"}}