{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/6480","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6480/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6480/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6480/events","html_url":"https://github.com/WordPress/gutenberg/pull/6480","id":318631516,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0NzgzMTk2","number":6480,"title":"Improve consistency of Shared and Permalink blocks UI.","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/WordPress/gutenberg/milestones/56","html_url":"https://github.com/WordPress/gutenberg/milestone/56","labels_url":"https://api.github.com/repos/WordPress/gutenberg/milestones/56/labels","id":3435331,"node_id":"MDk6TWlsZXN0b25lMzQzNTMzMQ==","number":56,"title":"3.2","description":"","creator":{"login":"gziolo","id":699132,"node_id":"MDQ6VXNlcjY5OTEzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/699132?v=4","gravatar_id":"","url":"https://api.github.com/users/gziolo","html_url":"https://github.com/gziolo","followers_url":"https://api.github.com/users/gziolo/followers","following_url":"https://api.github.com/users/gziolo/following{/other_user}","gists_url":"https://api.github.com/users/gziolo/gists{/gist_id}","starred_url":"https://api.github.com/users/gziolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gziolo/subscriptions","organizations_url":"https://api.github.com/users/gziolo/orgs","repos_url":"https://api.github.com/users/gziolo/repos","events_url":"https://api.github.com/users/gziolo/events{/privacy}","received_events_url":"https://api.github.com/users/gziolo/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":22,"state":"open","created_at":"2018-06-19T11:35:11Z","updated_at":"2018-06-26T19:05:37Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2018-04-28T12:19:44Z","updated_at":"2018-06-26T20:58:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6480","html_url":"https://github.com/WordPress/gutenberg/pull/6480","diff_url":"https://github.com/WordPress/gutenberg/pull/6480.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/6480.patch"},"body":"This PR tries to improve consistency of the Post Permalink and Shared Block UIs, specifically about buttons and interaction.\r\n\r\n- post permalink: changes \"OK\" to \"Save\"\r\n- shared block:\r\n  - removes primary style from the Save button\r\n  - removes the \"Cancel\" button\r\n  - closes the edit form when clicking outside of it, inspired by what [react-click-outside](https://github.com/kentor/react-click-outside/blob/e3e133799c51f896c1f65a799f0007827dd48248/index.js) does\r\n  - (for keyboard users, it already closes when pressing Escape)\r\n\r\nScreenshot:\r\n\r\n<img width=\"716\" alt=\"screen shot 2018-04-28 at 14 11 17\" src=\"https://user-images.githubusercontent.com/1682452/39396430-35cbe1a4-4aee-11e8-8863-9dca8d56500a.png\">\r\n\r\nFixes #6469 "},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/400460150","html_url":"https://github.com/WordPress/gutenberg/pull/6480#issuecomment-400460150","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6480","id":400460150,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQ2MDE1MA==","user":{"login":"gziolo","id":699132,"node_id":"MDQ6VXNlcjY5OTEzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/699132?v=4","gravatar_id":"","url":"https://api.github.com/users/gziolo","html_url":"https://github.com/gziolo","followers_url":"https://api.github.com/users/gziolo/followers","following_url":"https://api.github.com/users/gziolo/following{/other_user}","gists_url":"https://api.github.com/users/gziolo/gists{/gist_id}","starred_url":"https://api.github.com/users/gziolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gziolo/subscriptions","organizations_url":"https://api.github.com/users/gziolo/orgs","repos_url":"https://api.github.com/users/gziolo/repos","events_url":"https://api.github.com/users/gziolo/events{/privacy}","received_events_url":"https://api.github.com/users/gziolo/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T20:58:50Z","updated_at":"2018-06-26T20:58:50Z","author_association":"MEMBER","body":"Cool, we have time until 3.3 ships (2 weeks?) for breaking changes. In case we need them 😃 \r\n\r\nAnother thing we still didn’t agree on is if we should move a few general HOCs and related helpers from element module to its own module. This was raised a few times because sometimes you need to pull in all components to just use HOC which is a more general concept, on the other hand composing HOCs isn’t really an essential part of element package 🤔"}}
{"actor":{"display_login":"gziolo"}}