{"action":"created","issue":{"url":"https://api.github.com/repos/adfinis-sygroup/ember-validated-form/issues/93","repository_url":"https://api.github.com/repos/adfinis-sygroup/ember-validated-form","labels_url":"https://api.github.com/repos/adfinis-sygroup/ember-validated-form/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/adfinis-sygroup/ember-validated-form/issues/93/comments","events_url":"https://api.github.com/repos/adfinis-sygroup/ember-validated-form/issues/93/events","html_url":"https://github.com/adfinis-sygroup/ember-validated-form/issues/93","id":300282852,"number":93,"title":"Make setDirty more clever","user":{"login":"makepanic","id":1205444,"avatar_url":"https://avatars3.githubusercontent.com/u/1205444?v=4","gravatar_id":"","url":"https://api.github.com/users/makepanic","html_url":"https://github.com/makepanic","followers_url":"https://api.github.com/users/makepanic/followers","following_url":"https://api.github.com/users/makepanic/following{/other_user}","gists_url":"https://api.github.com/users/makepanic/gists{/gist_id}","starred_url":"https://api.github.com/users/makepanic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makepanic/subscriptions","organizations_url":"https://api.github.com/users/makepanic/orgs","repos_url":"https://api.github.com/users/makepanic/repos","events_url":"https://api.github.com/users/makepanic/events{/privacy}","received_events_url":"https://api.github.com/users/makepanic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-26T15:31:24Z","updated_at":"2018-02-26T17:55:42Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Right now setDirty always sets the `dirty` property to `true`.\r\nWe could make it more clever to only `dirty` the form if the [changeset `isDirty`](https://github.com/poteto/ember-changeset#isdirty) is `true`.\r\n\r\nThis also helps to prevents validating the form when removing focus of a form that uses `autofocus` to focus the first input element.\r\n\r\nIf you're fine with this solution, I could open a PR."},"comment":{"url":"https://api.github.com/repos/adfinis-sygroup/ember-validated-form/issues/comments/368589861","html_url":"https://github.com/adfinis-sygroup/ember-validated-form/issues/93#issuecomment-368589861","issue_url":"https://api.github.com/repos/adfinis-sygroup/ember-validated-form/issues/93","id":368589861,"user":{"login":"czosel","id":7962156,"avatar_url":"https://avatars2.githubusercontent.com/u/7962156?v=4","gravatar_id":"","url":"https://api.github.com/users/czosel","html_url":"https://github.com/czosel","followers_url":"https://api.github.com/users/czosel/followers","following_url":"https://api.github.com/users/czosel/following{/other_user}","gists_url":"https://api.github.com/users/czosel/gists{/gist_id}","starred_url":"https://api.github.com/users/czosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czosel/subscriptions","organizations_url":"https://api.github.com/users/czosel/orgs","repos_url":"https://api.github.com/users/czosel/repos","events_url":"https://api.github.com/users/czosel/events{/privacy}","received_events_url":"https://api.github.com/users/czosel/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T17:55:42Z","updated_at":"2018-02-26T17:55:42Z","author_association":"CONTRIBUTOR","body":"Hi @makepanic, that would mean that focussing and un-focussing an input element without changing it wouldn't mark it dirty, right? I think that's not great for UX - for example, you wouldn't immediately see required field validations anymore."}}
{"actor":{"display_login":"czosel"}}