{"action":"created","issue":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9194","repository_url":"https://api.github.com/repos/paritytech/parity-ethereum","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9194/labels{/name}","comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9194/comments","events_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9194/events","html_url":"https://github.com/paritytech/parity-ethereum/pull/9194","id":343573970,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMTczNjM1","number":9194,"title":"calculate gas_used of the transaction trace correctly, ","user":{"login":"debris","id":2613714,"node_id":"MDQ6VXNlcjI2MTM3MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2613714?v=4","gravatar_id":"","url":"https://api.github.com/users/debris","html_url":"https://github.com/debris","followers_url":"https://api.github.com/users/debris/followers","following_url":"https://api.github.com/users/debris/following{/other_user}","gists_url":"https://api.github.com/users/debris/gists{/gist_id}","starred_url":"https://api.github.com/users/debris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debris/subscriptions","organizations_url":"https://api.github.com/users/debris/orgs","repos_url":"https://api.github.com/users/debris/repos","events_url":"https://api.github.com/users/debris/events{/privacy}","received_events_url":"https://api.github.com/users/debris/received_events","type":"User","site_admin":false},"labels":[{"id":309708192,"node_id":"MDU6TGFiZWwzMDk3MDgxOTI=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/A8-looksgood","name":"A8-looksgood","color":"C0E7CC","default":false},{"id":424253226,"node_id":"MDU6TGFiZWw0MjQyNTMyMjY=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/B0-patchthis","name":"B0-patchthis","color":"f4f5f9","default":false},{"id":441816407,"node_id":"MDU6TGFiZWw0NDE4MTY0MDc=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/M4-core","name":"M4-core","color":"F5FCE6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones/22","html_url":"https://github.com/paritytech/parity-ethereum/milestone/22","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones/22/labels","id":3153051,"node_id":"MDk6TWlsZXN0b25lMzE1MzA1MQ==","number":22,"title":"2.1","description":"","creator":{"login":"5chdn","id":15729797,"node_id":"MDQ6VXNlcjE1NzI5Nzk3","avatar_url":"https://avatars3.githubusercontent.com/u/15729797?v=4","gravatar_id":"","url":"https://api.github.com/users/5chdn","html_url":"https://github.com/5chdn","followers_url":"https://api.github.com/users/5chdn/followers","following_url":"https://api.github.com/users/5chdn/following{/other_user}","gists_url":"https://api.github.com/users/5chdn/gists{/gist_id}","starred_url":"https://api.github.com/users/5chdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5chdn/subscriptions","organizations_url":"https://api.github.com/users/5chdn/orgs","repos_url":"https://api.github.com/users/5chdn/repos","events_url":"https://api.github.com/users/5chdn/events{/privacy}","received_events_url":"https://api.github.com/users/5chdn/received_events","type":"User","site_admin":false},"open_issues":150,"closed_issues":185,"state":"open","created_at":"2018-03-01T09:29:12Z","updated_at":"2018-07-27T06:27:06Z","due_on":"2018-08-27T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-07-23T10:22:33Z","updated_at":"2018-07-27T06:37:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9194","html_url":"https://github.com/paritytech/parity-ethereum/pull/9194","diff_url":"https://github.com/paritytech/parity-ethereum/pull/9194.diff","patch_url":"https://github.com/paritytech/parity-ethereum/pull/9194.patch"},"body":"- fixes #9178 \r\n- fixes #6964\r\n\r\ndescription of the issue: https://github.com/paritytech/parity-ethereum/issues/9178#issuecomment-406897257"},"comment":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/comments/408326151","html_url":"https://github.com/paritytech/parity-ethereum/pull/9194#issuecomment-408326151","issue_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9194","id":408326151,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODMyNjE1MQ==","user":{"login":"sorpaas","id":6277322,"node_id":"MDQ6VXNlcjYyNzczMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6277322?v=4","gravatar_id":"","url":"https://api.github.com/users/sorpaas","html_url":"https://github.com/sorpaas","followers_url":"https://api.github.com/users/sorpaas/followers","following_url":"https://api.github.com/users/sorpaas/following{/other_user}","gists_url":"https://api.github.com/users/sorpaas/gists{/gist_id}","starred_url":"https://api.github.com/users/sorpaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorpaas/subscriptions","organizations_url":"https://api.github.com/users/sorpaas/orgs","repos_url":"https://api.github.com/users/sorpaas/repos","events_url":"https://api.github.com/users/sorpaas/events{/privacy}","received_events_url":"https://api.github.com/users/sorpaas/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T06:37:26Z","updated_at":"2018-07-27T06:37:26Z","author_association":"MEMBER","body":"I don't quite understand the meaning of `entire_gas` here:\r\n\r\n* For top-level call/create, it makes sense -- those are invoked by a transaction, and it indeed has the concept of transaction \"entire gas\".\r\n* However, for sub call/create, I think this concept might not have much meaning? It's currently always set to equal to just `gas`, and remain unused except in tracing.\r\n\r\nGiven that this `entire_gas` value is only for tracing, would it be possible to move it out of `ActionParams` struct?"}}
{"actor":{"display_login":"sorpaas"}}