{"action":"created","issue":{"url":"https://api.github.com/repos/VIISON/shopware/issues/76","repository_url":"https://api.github.com/repos/VIISON/shopware","labels_url":"https://api.github.com/repos/VIISON/shopware/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/VIISON/shopware/issues/76/comments","events_url":"https://api.github.com/repos/VIISON/shopware/issues/76/events","html_url":"https://github.com/VIISON/shopware/pull/76","id":315100867,"number":76,"title":"Make saving an order robust against email template errors","user":{"login":"windaishi","id":6232639,"avatar_url":"https://avatars0.githubusercontent.com/u/6232639?v=4","gravatar_id":"","url":"https://api.github.com/users/windaishi","html_url":"https://github.com/windaishi","followers_url":"https://api.github.com/users/windaishi/followers","following_url":"https://api.github.com/users/windaishi/following{/other_user}","gists_url":"https://api.github.com/users/windaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/windaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windaishi/subscriptions","organizations_url":"https://api.github.com/users/windaishi/orgs","repos_url":"https://api.github.com/users/windaishi/repos","events_url":"https://api.github.com/users/windaishi/events{/privacy}","received_events_url":"https://api.github.com/users/windaishi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"fixpunkt","id":2817302,"avatar_url":"https://avatars1.githubusercontent.com/u/2817302?v=4","gravatar_id":"","url":"https://api.github.com/users/fixpunkt","html_url":"https://github.com/fixpunkt","followers_url":"https://api.github.com/users/fixpunkt/followers","following_url":"https://api.github.com/users/fixpunkt/following{/other_user}","gists_url":"https://api.github.com/users/fixpunkt/gists{/gist_id}","starred_url":"https://api.github.com/users/fixpunkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fixpunkt/subscriptions","organizations_url":"https://api.github.com/users/fixpunkt/orgs","repos_url":"https://api.github.com/users/fixpunkt/repos","events_url":"https://api.github.com/users/fixpunkt/events{/privacy}","received_events_url":"https://api.github.com/users/fixpunkt/received_events","type":"User","site_admin":false},"assignees":[{"login":"fixpunkt","id":2817302,"avatar_url":"https://avatars1.githubusercontent.com/u/2817302?v=4","gravatar_id":"","url":"https://api.github.com/users/fixpunkt","html_url":"https://github.com/fixpunkt","followers_url":"https://api.github.com/users/fixpunkt/followers","following_url":"https://api.github.com/users/fixpunkt/following{/other_user}","gists_url":"https://api.github.com/users/fixpunkt/gists{/gist_id}","starred_url":"https://api.github.com/users/fixpunkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fixpunkt/subscriptions","organizations_url":"https://api.github.com/users/fixpunkt/orgs","repos_url":"https://api.github.com/users/fixpunkt/repos","events_url":"https://api.github.com/users/fixpunkt/events{/privacy}","received_events_url":"https://api.github.com/users/fixpunkt/received_events","type":"User","site_admin":false},{"login":"windaishi","id":6232639,"avatar_url":"https://avatars0.githubusercontent.com/u/6232639?v=4","gravatar_id":"","url":"https://api.github.com/users/windaishi","html_url":"https://github.com/windaishi","followers_url":"https://api.github.com/users/windaishi/followers","following_url":"https://api.github.com/users/windaishi/following{/other_user}","gists_url":"https://api.github.com/users/windaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/windaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windaishi/subscriptions","organizations_url":"https://api.github.com/users/windaishi/orgs","repos_url":"https://api.github.com/users/windaishi/repos","events_url":"https://api.github.com/users/windaishi/events{/privacy}","received_events_url":"https://api.github.com/users/windaishi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-17T14:59:43Z","updated_at":"2018-05-14T13:04:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/VIISON/shopware/pulls/76","html_url":"https://github.com/VIISON/shopware/pull/76","diff_url":"https://github.com/VIISON/shopware/pull/76.diff","patch_url":"https://github.com/VIISON/shopware/pull/76.patch"},"body":"This PR is strongly related to https://github.com/shopware/shopware/pull/1496 and depends on it to be merged first.\r\n\r\n### 1. Why is this change necessary?\r\nWhen changing the status of an order to a status with an email template and this email template is corrupted, saving the order fails hard with an exception. The order gets saved correctly but no `after`-hooks are executed. Together with Shopware ERP (Powered by Pickware) this leads to serious stock errors that are hard to identify and recover from.\r\n\r\n### 2. What does this change do, exactly?\r\nIt improves the `Order/save` action so it catches any exceptions that occur during email generation and reports the problem to the backend user.\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\n1. Corrupt a status mail template, for example by adding an `{if}` tag without a corresponding closing `{/if}` tag.\r\n2. Change the status of an order that would send this mail template on status change.\r\n\r\nResult after applying this changeset:\r\n![image](https://user-images.githubusercontent.com/6232639/38878218-b832a920-4260-11e8-9b51-30e35d832e36.png)\r\n\r\n### 4. Please link to the relevant issues (if any).\r\nN/A\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\nN/A\r\n\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [x] I have squashed any insignificant commits\r\n- [x] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I have read the contribution requirements and fulfil them."},"comment":{"url":"https://api.github.com/repos/VIISON/shopware/issues/comments/388809062","html_url":"https://github.com/VIISON/shopware/pull/76#issuecomment-388809062","issue_url":"https://api.github.com/repos/VIISON/shopware/issues/76","id":388809062,"user":{"login":"windaishi","id":6232639,"avatar_url":"https://avatars0.githubusercontent.com/u/6232639?v=4","gravatar_id":"","url":"https://api.github.com/users/windaishi","html_url":"https://github.com/windaishi","followers_url":"https://api.github.com/users/windaishi/followers","following_url":"https://api.github.com/users/windaishi/following{/other_user}","gists_url":"https://api.github.com/users/windaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/windaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windaishi/subscriptions","organizations_url":"https://api.github.com/users/windaishi/orgs","repos_url":"https://api.github.com/users/windaishi/repos","events_url":"https://api.github.com/users/windaishi/events{/privacy}","received_events_url":"https://api.github.com/users/windaishi/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T13:04:38Z","updated_at":"2018-05-14T13:04:38Z","author_association":"NONE","body":"I am going to merge this PR into this one: https://github.com/shopware/shopware/pull/1496"}}
{"actor":{"display_login":"windaishi"}}