{"action":"created","comment":{"url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/comments/228293803","pull_request_review_id":168534614,"id":228293803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI5MzgwMw==","diff_hunk":"@@ -41,9 +41,6 @@ module.exports = {\n       }\n     ]\n   },\n-  externals: {","path":"webpack.config.js","position":4,"original_position":4,"commit_id":"8ace069ba3c02e7f40ab59eaa974944405acad8d","original_commit_id":"8ace069ba3c02e7f40ab59eaa974944405acad8d","user":{"login":"itsjavi","id":122741,"node_id":"MDQ6VXNlcjEyMjc0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/122741?v=4","gravatar_id":"","url":"https://api.github.com/users/itsjavi","html_url":"https://github.com/itsjavi","followers_url":"https://api.github.com/users/itsjavi/followers","following_url":"https://api.github.com/users/itsjavi/following{/other_user}","gists_url":"https://api.github.com/users/itsjavi/gists{/gist_id}","starred_url":"https://api.github.com/users/itsjavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsjavi/subscriptions","organizations_url":"https://api.github.com/users/itsjavi/orgs","repos_url":"https://api.github.com/users/itsjavi/repos","events_url":"https://api.github.com/users/itsjavi/events{/privacy}","received_events_url":"https://api.github.com/users/itsjavi/received_events","type":"User","site_admin":false},"body":"sorry I cannot accept this PR, removing this entirely makes webpack bundling jquery library inside the plugin dist js file.\r\n\r\nRead Webpack docs https://webpack.js.org/configuration/externals/\r\n\r\nAnd please check this solution: https://github.com/webpack/webpack/issues/4258#issuecomment-340240162\r\n\r\nI think this is the way to go:\r\n\r\n```js\r\nnew webpack.ProvidePlugin({\r\n  $: 'jquery',\r\n  jQuery: 'jquery'\r\n});\r\n```\r\n\r\nThen the src code may need some adjustements.","created_at":"2018-10-25T18:51:13Z","updated_at":"2018-10-25T18:56:18Z","html_url":"https://github.com/farbelous/bootstrap-colorpicker/pull/273#discussion_r228293803","pull_request_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/273","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/comments/228293803"},"html":{"href":"https://github.com/farbelous/bootstrap-colorpicker/pull/273#discussion_r228293803"},"pull_request":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/273","id":207913194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTEzMTk0","html_url":"https://github.com/farbelous/bootstrap-colorpicker/pull/273","diff_url":"https://github.com/farbelous/bootstrap-colorpicker/pull/273.diff","patch_url":"https://github.com/farbelous/bootstrap-colorpicker/pull/273.patch","issue_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/issues/273","number":273,"state":"open","locked":false,"title":"Change jQuery to jquery to avoid casing error","user":{"login":"antiseptikk","id":1520152,"node_id":"MDQ6VXNlcjE1MjAxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1520152?v=4","gravatar_id":"","url":"https://api.github.com/users/antiseptikk","html_url":"https://github.com/antiseptikk","followers_url":"https://api.github.com/users/antiseptikk/followers","following_url":"https://api.github.com/users/antiseptikk/following{/other_user}","gists_url":"https://api.github.com/users/antiseptikk/gists{/gist_id}","starred_url":"https://api.github.com/users/antiseptikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiseptikk/subscriptions","organizations_url":"https://api.github.com/users/antiseptikk/orgs","repos_url":"https://api.github.com/users/antiseptikk/repos","events_url":"https://api.github.com/users/antiseptikk/events{/privacy}","received_events_url":"https://api.github.com/users/antiseptikk/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nJust change \"jQuery\" to jquery to avoid casing error with other libraries.\r\n\r\n```\r\nThere are multiple modules with names that only differ in casing.\r\nThis can lead to unexpected behavior when compiling on a filesystem with other case-semantic.\r\n....\r\n``` \r\nref: https://github.com/farbelous/bootstrap-colorpicker/issues/272\r\n\r\n### Check list\r\n\r\nPlease fill this check list before submitting a pull request:\r\n\r\n- [x] The build process has been run (`npm run build`) and does not contain any errors.\r\n- [x] All tests are green after running `npm run test`.\r\n- [x] New tests have been added or modified for the introduced changes.\r\n- [x] New examples have been added for the newly introduced features.\r\n- [x] All the examples are still working as expected compared to the [official website](https://farbelous.io/bootstrap-colorpicker).\r\n- [x] This PR follows all other [`CONTRIBUTING.md`](.github/CONTRIBUTING.md#pull-requests) guidelines for Pull Requests.\r\n","created_at":"2018-08-13T09:08:00Z","updated_at":"2018-10-25T18:56:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f12c8aee994b6aa40a5f7544e9e51a5a07ad286","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/273/commits","review_comments_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/273/comments","review_comment_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/issues/273/comments","statuses_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/statuses/8ace069ba3c02e7f40ab59eaa974944405acad8d","head":{"label":"antiseptikk:master","ref":"master","sha":"8ace069ba3c02e7f40ab59eaa974944405acad8d","user":{"login":"antiseptikk","id":1520152,"node_id":"MDQ6VXNlcjE1MjAxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1520152?v=4","gravatar_id":"","url":"https://api.github.com/users/antiseptikk","html_url":"https://github.com/antiseptikk","followers_url":"https://api.github.com/users/antiseptikk/followers","following_url":"https://api.github.com/users/antiseptikk/following{/other_user}","gists_url":"https://api.github.com/users/antiseptikk/gists{/gist_id}","starred_url":"https://api.github.com/users/antiseptikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiseptikk/subscriptions","organizations_url":"https://api.github.com/users/antiseptikk/orgs","repos_url":"https://api.github.com/users/antiseptikk/repos","events_url":"https://api.github.com/users/antiseptikk/events{/privacy}","received_events_url":"https://api.github.com/users/antiseptikk/received_events","type":"User","site_admin":false},"repo":{"id":144552259,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1NTIyNTk=","name":"bootstrap-colorpicker","full_name":"antiseptikk/bootstrap-colorpicker","private":false,"owner":{"login":"antiseptikk","id":1520152,"node_id":"MDQ6VXNlcjE1MjAxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1520152?v=4","gravatar_id":"","url":"https://api.github.com/users/antiseptikk","html_url":"https://github.com/antiseptikk","followers_url":"https://api.github.com/users/antiseptikk/followers","following_url":"https://api.github.com/users/antiseptikk/following{/other_user}","gists_url":"https://api.github.com/users/antiseptikk/gists{/gist_id}","starred_url":"https://api.github.com/users/antiseptikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiseptikk/subscriptions","organizations_url":"https://api.github.com/users/antiseptikk/orgs","repos_url":"https://api.github.com/users/antiseptikk/repos","events_url":"https://api.github.com/users/antiseptikk/events{/privacy}","received_events_url":"https://api.github.com/users/antiseptikk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/antiseptikk/bootstrap-colorpicker","description":"Bootstrap Colorpicker is a modular color picker plugin for Bootstrap 4.","fork":true,"url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker","forks_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/forks","keys_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/teams","hooks_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/hooks","issue_events_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/issues/events{/number}","events_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/events","assignees_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/assignees{/user}","branches_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/branches{/branch}","tags_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/tags","blobs_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/statuses/{sha}","languages_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/languages","stargazers_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/stargazers","contributors_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/contributors","subscribers_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/subscribers","subscription_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/subscription","commits_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/contents/{+path}","compare_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/merges","archive_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/downloads","issues_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/issues{/number}","pulls_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/pulls{/number}","milestones_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/milestones{/number}","notifications_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/labels{/name}","releases_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/releases{/id}","deployments_url":"https://api.github.com/repos/antiseptikk/bootstrap-colorpicker/deployments","created_at":"2018-08-13T08:40:46Z","updated_at":"2018-08-27T18:52:12Z","pushed_at":"2018-08-27T18:52:10Z","git_url":"git://github.com/antiseptikk/bootstrap-colorpicker.git","ssh_url":"git@github.com:antiseptikk/bootstrap-colorpicker.git","clone_url":"https://github.com/antiseptikk/bootstrap-colorpicker.git","svn_url":"https://github.com/antiseptikk/bootstrap-colorpicker","homepage":"https://farbelous.io/bootstrap-colorpicker","size":3584,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"farbelous:master","ref":"master","sha":"98a11a57844b6d2f80823da3b4efdb02e2218122","user":{"login":"farbelous","id":29524115,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTI0MTE1","avatar_url":"https://avatars3.githubusercontent.com/u/29524115?v=4","gravatar_id":"","url":"https://api.github.com/users/farbelous","html_url":"https://github.com/farbelous","followers_url":"https://api.github.com/users/farbelous/followers","following_url":"https://api.github.com/users/farbelous/following{/other_user}","gists_url":"https://api.github.com/users/farbelous/gists{/gist_id}","starred_url":"https://api.github.com/users/farbelous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farbelous/subscriptions","organizations_url":"https://api.github.com/users/farbelous/orgs","repos_url":"https://api.github.com/users/farbelous/repos","events_url":"https://api.github.com/users/farbelous/events{/privacy}","received_events_url":"https://api.github.com/users/farbelous/received_events","type":"Organization","site_admin":false},"repo":{"id":4518517,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE4NTE3","name":"bootstrap-colorpicker","full_name":"farbelous/bootstrap-colorpicker","private":false,"owner":{"login":"farbelous","id":29524115,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTI0MTE1","avatar_url":"https://avatars3.githubusercontent.com/u/29524115?v=4","gravatar_id":"","url":"https://api.github.com/users/farbelous","html_url":"https://github.com/farbelous","followers_url":"https://api.github.com/users/farbelous/followers","following_url":"https://api.github.com/users/farbelous/following{/other_user}","gists_url":"https://api.github.com/users/farbelous/gists{/gist_id}","starred_url":"https://api.github.com/users/farbelous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farbelous/subscriptions","organizations_url":"https://api.github.com/users/farbelous/orgs","repos_url":"https://api.github.com/users/farbelous/repos","events_url":"https://api.github.com/users/farbelous/events{/privacy}","received_events_url":"https://api.github.com/users/farbelous/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/farbelous/bootstrap-colorpicker","description":"Bootstrap Colorpicker is a modular color picker plugin for Bootstrap 4.","fork":false,"url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker","forks_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/forks","keys_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/teams","hooks_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/hooks","issue_events_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/issues/events{/number}","events_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/events","assignees_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/assignees{/user}","branches_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/branches{/branch}","tags_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/tags","blobs_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/statuses/{sha}","languages_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/languages","stargazers_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/stargazers","contributors_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/contributors","subscribers_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/subscribers","subscription_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/subscription","commits_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/contents/{+path}","compare_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/merges","archive_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/downloads","issues_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/issues{/number}","pulls_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls{/number}","milestones_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/milestones{/number}","notifications_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/labels{/name}","releases_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/releases{/id}","deployments_url":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/deployments","created_at":"2012-06-01T10:30:19Z","updated_at":"2018-10-25T18:47:49Z","pushed_at":"2018-10-25T18:47:46Z","git_url":"git://github.com/farbelous/bootstrap-colorpicker.git","ssh_url":"git@github.com:farbelous/bootstrap-colorpicker.git","clone_url":"https://github.com/farbelous/bootstrap-colorpicker.git","svn_url":"https://github.com/farbelous/bootstrap-colorpicker","homepage":"https://farbelous.io/bootstrap-colorpicker","size":3581,"stargazers_count":1140,"watchers_count":1140,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":327,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":327,"open_issues":12,"watchers":1140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/273"},"html":{"href":"https://github.com/farbelous/bootstrap-colorpicker/pull/273"},"issue":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/issues/273"},"comments":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/farbelous/bootstrap-colorpicker/statuses/8ace069ba3c02e7f40ab59eaa974944405acad8d"}},"author_association":"NONE"}}
{"actor":{"display_login":"itsjavi"}}