{"action":"created","issue":{"url":"https://api.github.com/repos/scalvert/ember-es6-class-codemod/issues/12","repository_url":"https://api.github.com/repos/scalvert/ember-es6-class-codemod","labels_url":"https://api.github.com/repos/scalvert/ember-es6-class-codemod/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/scalvert/ember-es6-class-codemod/issues/12/comments","events_url":"https://api.github.com/repos/scalvert/ember-es6-class-codemod/issues/12/events","html_url":"https://github.com/scalvert/ember-es6-class-codemod/pull/12","id":356336645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjI1ODUx","number":12,"title":"Add transforms for service, route, controller and component","user":{"login":"ssutar","id":3048945,"node_id":"MDQ6VXNlcjMwNDg5NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3048945?v=4","gravatar_id":"","url":"https://api.github.com/users/ssutar","html_url":"https://github.com/ssutar","followers_url":"https://api.github.com/users/ssutar/followers","following_url":"https://api.github.com/users/ssutar/following{/other_user}","gists_url":"https://api.github.com/users/ssutar/gists{/gist_id}","starred_url":"https://api.github.com/users/ssutar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssutar/subscriptions","organizations_url":"https://api.github.com/users/ssutar/orgs","repos_url":"https://api.github.com/users/ssutar/repos","events_url":"https://api.github.com/users/ssutar/events{/privacy}","received_events_url":"https://api.github.com/users/ssutar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-03T02:06:59Z","updated_at":"2018-09-13T19:49:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/scalvert/ember-es6-class-codemod/pulls/12","html_url":"https://github.com/scalvert/ember-es6-class-codemod/pull/12","diff_url":"https://github.com/scalvert/ember-es6-class-codemod/pull/12.diff","patch_url":"https://github.com/scalvert/ember-es6-class-codemod/pull/12.patch"},"body":"- ember-route\r\n- ember-controller\r\n- ember-service\r\n- ember-component"},"comment":{"url":"https://api.github.com/repos/scalvert/ember-es6-class-codemod/issues/comments/421130716","html_url":"https://github.com/scalvert/ember-es6-class-codemod/pull/12#issuecomment-421130716","issue_url":"https://api.github.com/repos/scalvert/ember-es6-class-codemod/issues/12","id":421130716,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTEzMDcxNg==","user":{"login":"pzuraq","id":685518,"node_id":"MDQ6VXNlcjY4NTUxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/685518?v=4","gravatar_id":"","url":"https://api.github.com/users/pzuraq","html_url":"https://github.com/pzuraq","followers_url":"https://api.github.com/users/pzuraq/followers","following_url":"https://api.github.com/users/pzuraq/following{/other_user}","gists_url":"https://api.github.com/users/pzuraq/gists{/gist_id}","starred_url":"https://api.github.com/users/pzuraq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzuraq/subscriptions","organizations_url":"https://api.github.com/users/pzuraq/orgs","repos_url":"https://api.github.com/users/pzuraq/repos","events_url":"https://api.github.com/users/pzuraq/events{/privacy}","received_events_url":"https://api.github.com/users/pzuraq/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T19:49:07Z","updated_at":"2018-09-13T19:49:07Z","author_association":"COLLABORATOR","body":"I think that's the main thing, so far we aren't seeing any branching behavior between different types of objects _except_ for glob-path, and whether or not class-fields/decorators are enabled. And for class-fields/decorators, we have those as separate options anyways, since a user may want to transform all services that don't require decorators or class fields, for instance.\r\n\r\nI don't think it's that much extra overhead to add so @ssutar you can make the final call here. I definitely think tests should be consolidated, but other than that it can be either fully separate codemods, or an option."}}
{"actor":{"display_login":"pzuraq"}}