{"action":"created","comment":{"url":"https://api.github.com/repos/jhump/protoreflect/pulls/comments/181610592","pull_request_review_id":112266165,"id":181610592,"diff_hunk":"@@ -0,0 +1,88 @@\n+# TODO: run golint, errcheck, staticcheck, unused","path":"Makefile","position":1,"original_position":1,"commit_id":"ad5847cd010bc9dc180115b348578717d79353b8","original_commit_id":"ad5847cd010bc9dc180115b348578717d79353b8","user":{"login":"jhump","id":2035234,"avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"body":"and ineffassign?\r\n\r\nI assume these aren't in the target because there are too many failures in the codebase. Is that right?","created_at":"2018-04-16T02:28:56Z","updated_at":"2018-04-16T02:31:08Z","html_url":"https://github.com/jhump/protoreflect/pull/122#discussion_r181610592","pull_request_url":"https://api.github.com/repos/jhump/protoreflect/pulls/122","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/comments/181610592"},"html":{"href":"https://github.com/jhump/protoreflect/pull/122#discussion_r181610592"},"pull_request":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/jhump/protoreflect/pulls/122","id":181679492,"html_url":"https://github.com/jhump/protoreflect/pull/122","diff_url":"https://github.com/jhump/protoreflect/pull/122.diff","patch_url":"https://github.com/jhump/protoreflect/pull/122.patch","issue_url":"https://api.github.com/repos/jhump/protoreflect/issues/122","number":122,"state":"open","locked":false,"title":"ci enhancements","user":{"login":"prasek","id":284840,"avatar_url":"https://avatars1.githubusercontent.com/u/284840?v=4","gravatar_id":"","url":"https://api.github.com/users/prasek","html_url":"https://github.com/prasek","followers_url":"https://api.github.com/users/prasek/followers","following_url":"https://api.github.com/users/prasek/following{/other_user}","gists_url":"https://api.github.com/users/prasek/gists{/gist_id}","starred_url":"https://api.github.com/users/prasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasek/subscriptions","organizations_url":"https://api.github.com/users/prasek/orgs","repos_url":"https://api.github.com/users/prasek/repos","events_url":"https://api.github.com/users/prasek/events{/privacy}","received_events_url":"https://api.github.com/users/prasek/received_events","type":"User","site_admin":false},"body":"Added makefile, go vet, cleaner ci.sh output. Fixed go vet issues (e.g. made UnreadRune package scoped), added make generate, removed go 1.6 (go vet issue w/ mux copy) and added go 1.10 using the quoted strings so travis didn't get confused. Also regenerated testprotos with make generate and noticed a some minor changes to the generated files but nothing major.","created_at":"2018-04-15T03:59:04Z","updated_at":"2018-04-16T02:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"298aaaecaf1c7436749e77def742d61e67c84e85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhump/protoreflect/pulls/122/commits","review_comments_url":"https://api.github.com/repos/jhump/protoreflect/pulls/122/comments","review_comment_url":"https://api.github.com/repos/jhump/protoreflect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhump/protoreflect/issues/122/comments","statuses_url":"https://api.github.com/repos/jhump/protoreflect/statuses/ad5847cd010bc9dc180115b348578717d79353b8","head":{"label":"prasek:ci","ref":"ci","sha":"ad5847cd010bc9dc180115b348578717d79353b8","user":{"login":"prasek","id":284840,"avatar_url":"https://avatars1.githubusercontent.com/u/284840?v=4","gravatar_id":"","url":"https://api.github.com/users/prasek","html_url":"https://github.com/prasek","followers_url":"https://api.github.com/users/prasek/followers","following_url":"https://api.github.com/users/prasek/following{/other_user}","gists_url":"https://api.github.com/users/prasek/gists{/gist_id}","starred_url":"https://api.github.com/users/prasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasek/subscriptions","organizations_url":"https://api.github.com/users/prasek/orgs","repos_url":"https://api.github.com/users/prasek/repos","events_url":"https://api.github.com/users/prasek/events{/privacy}","received_events_url":"https://api.github.com/users/prasek/received_events","type":"User","site_admin":false},"repo":{"id":129488232,"name":"protoreflect","full_name":"prasek/protoreflect","owner":{"login":"prasek","id":284840,"avatar_url":"https://avatars1.githubusercontent.com/u/284840?v=4","gravatar_id":"","url":"https://api.github.com/users/prasek","html_url":"https://github.com/prasek","followers_url":"https://api.github.com/users/prasek/followers","following_url":"https://api.github.com/users/prasek/following{/other_user}","gists_url":"https://api.github.com/users/prasek/gists{/gist_id}","starred_url":"https://api.github.com/users/prasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasek/subscriptions","organizations_url":"https://api.github.com/users/prasek/orgs","repos_url":"https://api.github.com/users/prasek/repos","events_url":"https://api.github.com/users/prasek/events{/privacy}","received_events_url":"https://api.github.com/users/prasek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prasek/protoreflect","description":"Reflection (Rich Descriptors) for Go Protocol Buffers","fork":true,"url":"https://api.github.com/repos/prasek/protoreflect","forks_url":"https://api.github.com/repos/prasek/protoreflect/forks","keys_url":"https://api.github.com/repos/prasek/protoreflect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prasek/protoreflect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prasek/protoreflect/teams","hooks_url":"https://api.github.com/repos/prasek/protoreflect/hooks","issue_events_url":"https://api.github.com/repos/prasek/protoreflect/issues/events{/number}","events_url":"https://api.github.com/repos/prasek/protoreflect/events","assignees_url":"https://api.github.com/repos/prasek/protoreflect/assignees{/user}","branches_url":"https://api.github.com/repos/prasek/protoreflect/branches{/branch}","tags_url":"https://api.github.com/repos/prasek/protoreflect/tags","blobs_url":"https://api.github.com/repos/prasek/protoreflect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prasek/protoreflect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prasek/protoreflect/git/refs{/sha}","trees_url":"https://api.github.com/repos/prasek/protoreflect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prasek/protoreflect/statuses/{sha}","languages_url":"https://api.github.com/repos/prasek/protoreflect/languages","stargazers_url":"https://api.github.com/repos/prasek/protoreflect/stargazers","contributors_url":"https://api.github.com/repos/prasek/protoreflect/contributors","subscribers_url":"https://api.github.com/repos/prasek/protoreflect/subscribers","subscription_url":"https://api.github.com/repos/prasek/protoreflect/subscription","commits_url":"https://api.github.com/repos/prasek/protoreflect/commits{/sha}","git_commits_url":"https://api.github.com/repos/prasek/protoreflect/git/commits{/sha}","comments_url":"https://api.github.com/repos/prasek/protoreflect/comments{/number}","issue_comment_url":"https://api.github.com/repos/prasek/protoreflect/issues/comments{/number}","contents_url":"https://api.github.com/repos/prasek/protoreflect/contents/{+path}","compare_url":"https://api.github.com/repos/prasek/protoreflect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prasek/protoreflect/merges","archive_url":"https://api.github.com/repos/prasek/protoreflect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prasek/protoreflect/downloads","issues_url":"https://api.github.com/repos/prasek/protoreflect/issues{/number}","pulls_url":"https://api.github.com/repos/prasek/protoreflect/pulls{/number}","milestones_url":"https://api.github.com/repos/prasek/protoreflect/milestones{/number}","notifications_url":"https://api.github.com/repos/prasek/protoreflect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prasek/protoreflect/labels{/name}","releases_url":"https://api.github.com/repos/prasek/protoreflect/releases{/id}","deployments_url":"https://api.github.com/repos/prasek/protoreflect/deployments","created_at":"2018-04-14T06:23:02Z","updated_at":"2018-04-15T00:30:05Z","pushed_at":"2018-04-15T23:54:53Z","git_url":"git://github.com/prasek/protoreflect.git","ssh_url":"git@github.com:prasek/protoreflect.git","clone_url":"https://github.com/prasek/protoreflect.git","svn_url":"https://github.com/prasek/protoreflect","homepage":"","size":12066,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhump:master","ref":"master","sha":"cfdba734743d6b9685ff2e8d78c7e6c7e6ddad65","user":{"login":"jhump","id":2035234,"avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"repo":{"id":81850273,"name":"protoreflect","full_name":"jhump/protoreflect","owner":{"login":"jhump","id":2035234,"avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhump/protoreflect","description":"Reflection (Rich Descriptors) for Go Protocol Buffers","fork":false,"url":"https://api.github.com/repos/jhump/protoreflect","forks_url":"https://api.github.com/repos/jhump/protoreflect/forks","keys_url":"https://api.github.com/repos/jhump/protoreflect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhump/protoreflect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhump/protoreflect/teams","hooks_url":"https://api.github.com/repos/jhump/protoreflect/hooks","issue_events_url":"https://api.github.com/repos/jhump/protoreflect/issues/events{/number}","events_url":"https://api.github.com/repos/jhump/protoreflect/events","assignees_url":"https://api.github.com/repos/jhump/protoreflect/assignees{/user}","branches_url":"https://api.github.com/repos/jhump/protoreflect/branches{/branch}","tags_url":"https://api.github.com/repos/jhump/protoreflect/tags","blobs_url":"https://api.github.com/repos/jhump/protoreflect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhump/protoreflect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhump/protoreflect/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhump/protoreflect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhump/protoreflect/statuses/{sha}","languages_url":"https://api.github.com/repos/jhump/protoreflect/languages","stargazers_url":"https://api.github.com/repos/jhump/protoreflect/stargazers","contributors_url":"https://api.github.com/repos/jhump/protoreflect/contributors","subscribers_url":"https://api.github.com/repos/jhump/protoreflect/subscribers","subscription_url":"https://api.github.com/repos/jhump/protoreflect/subscription","commits_url":"https://api.github.com/repos/jhump/protoreflect/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhump/protoreflect/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhump/protoreflect/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhump/protoreflect/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhump/protoreflect/contents/{+path}","compare_url":"https://api.github.com/repos/jhump/protoreflect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhump/protoreflect/merges","archive_url":"https://api.github.com/repos/jhump/protoreflect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhump/protoreflect/downloads","issues_url":"https://api.github.com/repos/jhump/protoreflect/issues{/number}","pulls_url":"https://api.github.com/repos/jhump/protoreflect/pulls{/number}","milestones_url":"https://api.github.com/repos/jhump/protoreflect/milestones{/number}","notifications_url":"https://api.github.com/repos/jhump/protoreflect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhump/protoreflect/labels{/name}","releases_url":"https://api.github.com/repos/jhump/protoreflect/releases{/id}","deployments_url":"https://api.github.com/repos/jhump/protoreflect/deployments","created_at":"2017-02-13T17:11:38Z","updated_at":"2018-04-15T12:35:46Z","pushed_at":"2018-04-15T23:54:54Z","git_url":"git://github.com/jhump/protoreflect.git","ssh_url":"git@github.com:jhump/protoreflect.git","clone_url":"https://github.com/jhump/protoreflect.git","svn_url":"https://github.com/jhump/protoreflect","homepage":"","size":963,"stargazers_count":62,"watchers_count":62,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14,"open_issues":4,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/122"},"html":{"href":"https://github.com/jhump/protoreflect/pull/122"},"issue":{"href":"https://api.github.com/repos/jhump/protoreflect/issues/122"},"comments":{"href":"https://api.github.com/repos/jhump/protoreflect/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/jhump/protoreflect/statuses/ad5847cd010bc9dc180115b348578717d79353b8"}},"author_association":"NONE"}}
{"actor":{"display_login":"jhump"}}