{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/comments/183036257","pull_request_review_id":113959583,"id":183036257,"diff_hunk":"@@ -23,7 +23,7 @@ class JwkManagerTests: XCTestCase {\n \n         // create JWKS\n         let jwks = try? JSONSerialization.data(withJSONObject: getMockJwks(), options: [])\n-        let jwksString = String(data: jwks!, encoding: String.Encoding.ascii)\n+        let jwksString = String(data: jwks!, encoding: .utf8)","path":"example/AeroGearSdkExampleTests/auth/jwk/JwkManagerTests.swift","position":5,"original_position":5,"commit_id":"ff07f0e83d05a8c12702271083663f57aaf3f136","original_commit_id":"ff07f0e83d05a8c12702271083663f57aaf3f136","user":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars3.githubusercontent.com/u/981838?v=4","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"body":"I will avoid `jwks!` \r\nWe should unwrap optional. ","created_at":"2018-04-20T12:39:34Z","updated_at":"2018-04-20T12:39:34Z","html_url":"https://github.com/aerogear/aerogear-ios-sdk/pull/82#discussion_r183036257","pull_request_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/82","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/comments/183036257"},"html":{"href":"https://github.com/aerogear/aerogear-ios-sdk/pull/82#discussion_r183036257"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/82","id":182538548,"html_url":"https://github.com/aerogear/aerogear-ios-sdk/pull/82","diff_url":"https://github.com/aerogear/aerogear-ios-sdk/pull/82.diff","patch_url":"https://github.com/aerogear/aerogear-ios-sdk/pull/82.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/issues/82","number":82,"state":"open","locked":false,"title":"AEROGEAR-2091 - JWT validation implementation","user":{"login":"rachael-oregan","id":17702978,"avatar_url":"https://avatars2.githubusercontent.com/u/17702978?v=4","gravatar_id":"","url":"https://api.github.com/users/rachael-oregan","html_url":"https://github.com/rachael-oregan","followers_url":"https://api.github.com/users/rachael-oregan/followers","following_url":"https://api.github.com/users/rachael-oregan/following{/other_user}","gists_url":"https://api.github.com/users/rachael-oregan/gists{/gist_id}","starred_url":"https://api.github.com/users/rachael-oregan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachael-oregan/subscriptions","organizations_url":"https://api.github.com/users/rachael-oregan/orgs","repos_url":"https://api.github.com/users/rachael-oregan/repos","events_url":"https://api.github.com/users/rachael-oregan/events{/privacy}","received_events_url":"https://api.github.com/users/rachael-oregan/received_events","type":"User","site_admin":false},"body":"### Motivation\r\n\r\n\r\nJIRA: https://issues.jboss.org/browse/AEROGEAR-2091\r\n\r\n### Description\r\nThe [JSONWebToken](https://github.com/kreactive/JSONWebToken) library is used to verify JSON Web Tokens.  I'm using `JSONWebToken`@v2.0.0 because the latest version of the library (2.1.0) requires Swift v4.1.0 and our project uses 4.0.0.  \r\n\r\n### Progress\r\n\r\n- [x] `verifyClaims` function\r\n- [x] unit tests\r\n- [x] docs","created_at":"2018-04-18T16:41:10Z","updated_at":"2018-04-20T12:39:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3c9c437be2562cedd894eed044111d394c77d04","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielpassos","id":13337,"avatar_url":"https://avatars1.githubusercontent.com/u/13337?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpassos","html_url":"https://github.com/danielpassos","followers_url":"https://api.github.com/users/danielpassos/followers","following_url":"https://api.github.com/users/danielpassos/following{/other_user}","gists_url":"https://api.github.com/users/danielpassos/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpassos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpassos/subscriptions","organizations_url":"https://api.github.com/users/danielpassos/orgs","repos_url":"https://api.github.com/users/danielpassos/repos","events_url":"https://api.github.com/users/danielpassos/events{/privacy}","received_events_url":"https://api.github.com/users/danielpassos/received_events","type":"User","site_admin":false},{"login":"ziccardi","id":1125019,"avatar_url":"https://avatars3.githubusercontent.com/u/1125019?v=4","gravatar_id":"","url":"https://api.github.com/users/ziccardi","html_url":"https://github.com/ziccardi","followers_url":"https://api.github.com/users/ziccardi/followers","following_url":"https://api.github.com/users/ziccardi/following{/other_user}","gists_url":"https://api.github.com/users/ziccardi/gists{/gist_id}","starred_url":"https://api.github.com/users/ziccardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziccardi/subscriptions","organizations_url":"https://api.github.com/users/ziccardi/orgs","repos_url":"https://api.github.com/users/ziccardi/repos","events_url":"https://api.github.com/users/ziccardi/events{/privacy}","received_events_url":"https://api.github.com/users/ziccardi/received_events","type":"User","site_admin":false},{"login":"aidenkeating","id":8698527,"avatar_url":"https://avatars3.githubusercontent.com/u/8698527?v=4","gravatar_id":"","url":"https://api.github.com/users/aidenkeating","html_url":"https://github.com/aidenkeating","followers_url":"https://api.github.com/users/aidenkeating/followers","following_url":"https://api.github.com/users/aidenkeating/following{/other_user}","gists_url":"https://api.github.com/users/aidenkeating/gists{/gist_id}","starred_url":"https://api.github.com/users/aidenkeating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidenkeating/subscriptions","organizations_url":"https://api.github.com/users/aidenkeating/orgs","repos_url":"https://api.github.com/users/aidenkeating/repos","events_url":"https://api.github.com/users/aidenkeating/events{/privacy}","received_events_url":"https://api.github.com/users/aidenkeating/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/82/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/82/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/issues/82/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/statuses/ff07f0e83d05a8c12702271083663f57aaf3f136","head":{"label":"rachael-oregan:AEROGEAR-2091","ref":"AEROGEAR-2091","sha":"ff07f0e83d05a8c12702271083663f57aaf3f136","user":{"login":"rachael-oregan","id":17702978,"avatar_url":"https://avatars2.githubusercontent.com/u/17702978?v=4","gravatar_id":"","url":"https://api.github.com/users/rachael-oregan","html_url":"https://github.com/rachael-oregan","followers_url":"https://api.github.com/users/rachael-oregan/followers","following_url":"https://api.github.com/users/rachael-oregan/following{/other_user}","gists_url":"https://api.github.com/users/rachael-oregan/gists{/gist_id}","starred_url":"https://api.github.com/users/rachael-oregan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachael-oregan/subscriptions","organizations_url":"https://api.github.com/users/rachael-oregan/orgs","repos_url":"https://api.github.com/users/rachael-oregan/repos","events_url":"https://api.github.com/users/rachael-oregan/events{/privacy}","received_events_url":"https://api.github.com/users/rachael-oregan/received_events","type":"User","site_admin":false},"repo":{"id":123427378,"name":"aerogear-ios-sdk","full_name":"rachael-oregan/aerogear-ios-sdk","owner":{"login":"rachael-oregan","id":17702978,"avatar_url":"https://avatars2.githubusercontent.com/u/17702978?v=4","gravatar_id":"","url":"https://api.github.com/users/rachael-oregan","html_url":"https://github.com/rachael-oregan","followers_url":"https://api.github.com/users/rachael-oregan/followers","following_url":"https://api.github.com/users/rachael-oregan/following{/other_user}","gists_url":"https://api.github.com/users/rachael-oregan/gists{/gist_id}","starred_url":"https://api.github.com/users/rachael-oregan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachael-oregan/subscriptions","organizations_url":"https://api.github.com/users/rachael-oregan/orgs","repos_url":"https://api.github.com/users/rachael-oregan/repos","events_url":"https://api.github.com/users/rachael-oregan/events{/privacy}","received_events_url":"https://api.github.com/users/rachael-oregan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rachael-oregan/aerogear-ios-sdk","description":"AeroGear Services Swift SDK","fork":true,"url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk","forks_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/forks","keys_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/teams","hooks_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/events","assignees_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/tags","blobs_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/subscription","commits_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/merges","archive_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/downloads","issues_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/rachael-oregan/aerogear-ios-sdk/deployments","created_at":"2018-03-01T11:41:37Z","updated_at":"2018-03-01T11:41:39Z","pushed_at":"2018-04-20T10:55:11Z","git_url":"git://github.com/rachael-oregan/aerogear-ios-sdk.git","ssh_url":"git@github.com:rachael-oregan/aerogear-ios-sdk.git","clone_url":"https://github.com/rachael-oregan/aerogear-ios-sdk.git","svn_url":"https://github.com/rachael-oregan/aerogear-ios-sdk","homepage":"http://aerogear.org","size":652,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"b21ab885a4433b0b835feb9d58410f0da094f669","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":117979936,"name":"aerogear-ios-sdk","full_name":"aerogear/aerogear-ios-sdk","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-ios-sdk","description":"AeroGear Services Swift SDK","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk","forks_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/deployments","created_at":"2018-01-18T12:28:09Z","updated_at":"2018-04-17T19:25:15Z","pushed_at":"2018-04-20T12:17:36Z","git_url":"git://github.com/aerogear/aerogear-ios-sdk.git","ssh_url":"git@github.com:aerogear/aerogear-ios-sdk.git","clone_url":"https://github.com/aerogear/aerogear-ios-sdk.git","svn_url":"https://github.com/aerogear/aerogear-ios-sdk","homepage":"http://aerogear.org","size":642,"stargazers_count":3,"watchers_count":3,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/82"},"html":{"href":"https://github.com/aerogear/aerogear-ios-sdk/pull/82"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/issues/82"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-ios-sdk/statuses/ff07f0e83d05a8c12702271083663f57aaf3f136"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wtrocki"}}