{"action":"closed","number":2906,"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/2906","id":196459310,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDU5MzEw","html_url":"https://github.com/kubernetes-incubator/kubespray/pull/2906","diff_url":"https://github.com/kubernetes-incubator/kubespray/pull/2906.diff","patch_url":"https://github.com/kubernetes-incubator/kubespray/pull/2906.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/2906","number":2906,"state":"closed","locked":false,"title":"generate k8s certs bug","user":{"login":"elementyang","id":40225853,"node_id":"MDQ6VXNlcjQwMjI1ODUz","avatar_url":"https://avatars0.githubusercontent.com/u/40225853?v=4","gravatar_id":"","url":"https://api.github.com/users/elementyang","html_url":"https://github.com/elementyang","followers_url":"https://api.github.com/users/elementyang/followers","following_url":"https://api.github.com/users/elementyang/following{/other_user}","gists_url":"https://api.github.com/users/elementyang/gists{/gist_id}","starred_url":"https://api.github.com/users/elementyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementyang/subscriptions","organizations_url":"https://api.github.com/users/elementyang/orgs","repos_url":"https://api.github.com/users/elementyang/repos","events_url":"https://api.github.com/users/elementyang/events{/privacy}","received_events_url":"https://api.github.com/users/elementyang/received_events","type":"User","site_admin":false},"body":"Dear author,\r\n     Maybe there is a bug about generation k8s certificates in role/kubernetes/secrets/tasks/check_certs.yml.\r\n     The variable gen_certs equals true always since v2.1.2, so it always creates new certs. In face, it is necessary to create new certs only when certs not exists or changed.\r\n     It is maybe your slip. We should modify bracket ']' to comma ',', and add some comma ',' in proper position.\r\n     There are other bugs about generation certs in master branch, not in some old versions. For example, incomplete certificate verification, .... These bugs maybe have an impact on the final result, but this is another problem. If you need it, I can help to modify it.\r\n\r\nThanks.","created_at":"2018-06-21T13:50:51Z","updated_at":"2018-06-21T14:01:27Z","closed_at":"2018-06-21T14:01:27Z","merged_at":null,"merge_commit_sha":"732ec2afef1cd5d4583dc0e5508ac7e193341c9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":676230123,"node_id":"MDU6TGFiZWw2NzYyMzAxMjM=","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/size/S","name":"size/S","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/2906/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/2906/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/2906/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/7360885ff01d556288e161489678478f9e8d7e9f","head":{"label":"elementyang:test-pr","ref":"test-pr","sha":"7360885ff01d556288e161489678478f9e8d7e9f","user":{"login":"elementyang","id":40225853,"node_id":"MDQ6VXNlcjQwMjI1ODUz","avatar_url":"https://avatars0.githubusercontent.com/u/40225853?v=4","gravatar_id":"","url":"https://api.github.com/users/elementyang","html_url":"https://github.com/elementyang","followers_url":"https://api.github.com/users/elementyang/followers","following_url":"https://api.github.com/users/elementyang/following{/other_user}","gists_url":"https://api.github.com/users/elementyang/gists{/gist_id}","starred_url":"https://api.github.com/users/elementyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementyang/subscriptions","organizations_url":"https://api.github.com/users/elementyang/orgs","repos_url":"https://api.github.com/users/elementyang/repos","events_url":"https://api.github.com/users/elementyang/events{/privacy}","received_events_url":"https://api.github.com/users/elementyang/received_events","type":"User","site_admin":false},"repo":{"id":137166103,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNjYxMDM=","name":"kubespray","full_name":"elementyang/kubespray","owner":{"login":"elementyang","id":40225853,"node_id":"MDQ6VXNlcjQwMjI1ODUz","avatar_url":"https://avatars0.githubusercontent.com/u/40225853?v=4","gravatar_id":"","url":"https://api.github.com/users/elementyang","html_url":"https://github.com/elementyang","followers_url":"https://api.github.com/users/elementyang/followers","following_url":"https://api.github.com/users/elementyang/following{/other_user}","gists_url":"https://api.github.com/users/elementyang/gists{/gist_id}","starred_url":"https://api.github.com/users/elementyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementyang/subscriptions","organizations_url":"https://api.github.com/users/elementyang/orgs","repos_url":"https://api.github.com/users/elementyang/repos","events_url":"https://api.github.com/users/elementyang/events{/privacy}","received_events_url":"https://api.github.com/users/elementyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elementyang/kubespray","description":"Setup a kubernetes cluster","fork":true,"url":"https://api.github.com/repos/elementyang/kubespray","forks_url":"https://api.github.com/repos/elementyang/kubespray/forks","keys_url":"https://api.github.com/repos/elementyang/kubespray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elementyang/kubespray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elementyang/kubespray/teams","hooks_url":"https://api.github.com/repos/elementyang/kubespray/hooks","issue_events_url":"https://api.github.com/repos/elementyang/kubespray/issues/events{/number}","events_url":"https://api.github.com/repos/elementyang/kubespray/events","assignees_url":"https://api.github.com/repos/elementyang/kubespray/assignees{/user}","branches_url":"https://api.github.com/repos/elementyang/kubespray/branches{/branch}","tags_url":"https://api.github.com/repos/elementyang/kubespray/tags","blobs_url":"https://api.github.com/repos/elementyang/kubespray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elementyang/kubespray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elementyang/kubespray/git/refs{/sha}","trees_url":"https://api.github.com/repos/elementyang/kubespray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elementyang/kubespray/statuses/{sha}","languages_url":"https://api.github.com/repos/elementyang/kubespray/languages","stargazers_url":"https://api.github.com/repos/elementyang/kubespray/stargazers","contributors_url":"https://api.github.com/repos/elementyang/kubespray/contributors","subscribers_url":"https://api.github.com/repos/elementyang/kubespray/subscribers","subscription_url":"https://api.github.com/repos/elementyang/kubespray/subscription","commits_url":"https://api.github.com/repos/elementyang/kubespray/commits{/sha}","git_commits_url":"https://api.github.com/repos/elementyang/kubespray/git/commits{/sha}","comments_url":"https://api.github.com/repos/elementyang/kubespray/comments{/number}","issue_comment_url":"https://api.github.com/repos/elementyang/kubespray/issues/comments{/number}","contents_url":"https://api.github.com/repos/elementyang/kubespray/contents/{+path}","compare_url":"https://api.github.com/repos/elementyang/kubespray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elementyang/kubespray/merges","archive_url":"https://api.github.com/repos/elementyang/kubespray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elementyang/kubespray/downloads","issues_url":"https://api.github.com/repos/elementyang/kubespray/issues{/number}","pulls_url":"https://api.github.com/repos/elementyang/kubespray/pulls{/number}","milestones_url":"https://api.github.com/repos/elementyang/kubespray/milestones{/number}","notifications_url":"https://api.github.com/repos/elementyang/kubespray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elementyang/kubespray/labels{/name}","releases_url":"https://api.github.com/repos/elementyang/kubespray/releases{/id}","deployments_url":"https://api.github.com/repos/elementyang/kubespray/deployments","created_at":"2018-06-13T05:22:30Z","updated_at":"2018-06-20T15:16:53Z","pushed_at":"2018-06-21T13:21:44Z","git_url":"git://github.com/elementyang/kubespray.git","ssh_url":"git@github.com:elementyang/kubespray.git","clone_url":"https://github.com/elementyang/kubespray.git","svn_url":"https://github.com/elementyang/kubespray","homepage":"","size":7710,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"cbb959151c7bbc3da4a68bef2d631ae640026904","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":43613404,"node_id":"MDEwOlJlcG9zaXRvcnk0MzYxMzQwNA==","name":"kubespray","full_name":"kubernetes-incubator/kubespray","owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kubespray","description":"Setup a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kubespray","forks_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/deployments","created_at":"2015-10-03T20:18:11Z","updated_at":"2018-06-21T10:02:36Z","pushed_at":"2018-06-21T13:50:52Z","git_url":"git://github.com/kubernetes-incubator/kubespray.git","ssh_url":"git@github.com:kubernetes-incubator/kubespray.git","clone_url":"https://github.com/kubernetes-incubator/kubespray.git","svn_url":"https://github.com/kubernetes-incubator/kubespray","homepage":"","size":7723,"stargazers_count":3174,"watchers_count":3174,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1263,"mirror_url":null,"archived":false,"open_issues_count":480,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1263,"open_issues":480,"watchers":3174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/2906"},"html":{"href":"https://github.com/kubernetes-incubator/kubespray/pull/2906"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/2906"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/2906/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/2906/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/2906/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/7360885ff01d556288e161489678478f9e8d7e9f"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"elementyang"}}