{"action":"created","issue":{"url":"https://api.github.com/repos/prscX/react-native-tooltips/issues/16","repository_url":"https://api.github.com/repos/prscX/react-native-tooltips","labels_url":"https://api.github.com/repos/prscX/react-native-tooltips/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/prscX/react-native-tooltips/issues/16/comments","events_url":"https://api.github.com/repos/prscX/react-native-tooltips/issues/16/events","html_url":"https://github.com/prscX/react-native-tooltips/pull/16","id":360715704,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODY4MzMw","number":16,"title":"Add parent view reference","user":{"login":"StevenMasini","id":1907562,"node_id":"MDQ6VXNlcjE5MDc1NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1907562?v=4","gravatar_id":"","url":"https://api.github.com/users/StevenMasini","html_url":"https://github.com/StevenMasini","followers_url":"https://api.github.com/users/StevenMasini/followers","following_url":"https://api.github.com/users/StevenMasini/following{/other_user}","gists_url":"https://api.github.com/users/StevenMasini/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenMasini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenMasini/subscriptions","organizations_url":"https://api.github.com/users/StevenMasini/orgs","repos_url":"https://api.github.com/users/StevenMasini/repos","events_url":"https://api.github.com/users/StevenMasini/events{/privacy}","received_events_url":"https://api.github.com/users/StevenMasini/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"prscX","id":28862892,"node_id":"MDQ6VXNlcjI4ODYyODky","avatar_url":"https://avatars2.githubusercontent.com/u/28862892?v=4","gravatar_id":"","url":"https://api.github.com/users/prscX","html_url":"https://github.com/prscX","followers_url":"https://api.github.com/users/prscX/followers","following_url":"https://api.github.com/users/prscX/following{/other_user}","gists_url":"https://api.github.com/users/prscX/gists{/gist_id}","starred_url":"https://api.github.com/users/prscX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prscX/subscriptions","organizations_url":"https://api.github.com/users/prscX/orgs","repos_url":"https://api.github.com/users/prscX/repos","events_url":"https://api.github.com/users/prscX/events{/privacy}","received_events_url":"https://api.github.com/users/prscX/received_events","type":"User","site_admin":false},"assignees":[{"login":"prscX","id":28862892,"node_id":"MDQ6VXNlcjI4ODYyODky","avatar_url":"https://avatars2.githubusercontent.com/u/28862892?v=4","gravatar_id":"","url":"https://api.github.com/users/prscX","html_url":"https://github.com/prscX","followers_url":"https://api.github.com/users/prscX/followers","following_url":"https://api.github.com/users/prscX/following{/other_user}","gists_url":"https://api.github.com/users/prscX/gists{/gist_id}","starred_url":"https://api.github.com/users/prscX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prscX/subscriptions","organizations_url":"https://api.github.com/users/prscX/orgs","repos_url":"https://api.github.com/users/prscX/repos","events_url":"https://api.github.com/users/prscX/events{/privacy}","received_events_url":"https://api.github.com/users/prscX/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-09-17T03:52:31Z","updated_at":"2018-10-01T05:51:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/prscX/react-native-tooltips/pulls/16","html_url":"https://github.com/prscX/react-native-tooltips/pull/16","diff_url":"https://github.com/prscX/react-native-tooltips/pull/16.diff","patch_url":"https://github.com/prscX/react-native-tooltips/pull/16.patch"},"body":"# Change logs\r\n\r\n- Now users need to give a reference to the `parent` view where they want the tooltip to fit in. This avoid the tooltip to go off-screen.\r\n- Dismiss the tooltips when `componentWillUnmount()`.\r\n- Upgrade the version number of the dependency `com.github.florent37:viewtooltip` to `1.1.6` on Android to take benefit of method `on` that can retrieve its parent view by itself.\r\n\r\n## Notes\r\n\r\nOn Android `findNodeHandle` might not retrieve the right `viewId` which end up by having the `findViewById` to return `null`. This previously caused a crash which has been fixed in #13. \r\n\r\nIn order to avoid this bug, developers must set `collapsable={false}` in the props of their component.\r\n\r\n## Suggestion\r\n\r\nI would like to change the name of the props `reference` to `target` to make it more explicit for developers when they set the props to `RNTooltips`. "},"comment":{"url":"https://api.github.com/repos/prscX/react-native-tooltips/issues/comments/425796348","html_url":"https://github.com/prscX/react-native-tooltips/pull/16#issuecomment-425796348","issue_url":"https://api.github.com/repos/prscX/react-native-tooltips/issues/16","id":425796348,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTc5NjM0OA==","user":{"login":"prscX","id":28862892,"node_id":"MDQ6VXNlcjI4ODYyODky","avatar_url":"https://avatars2.githubusercontent.com/u/28862892?v=4","gravatar_id":"","url":"https://api.github.com/users/prscX","html_url":"https://github.com/prscX","followers_url":"https://api.github.com/users/prscX/followers","following_url":"https://api.github.com/users/prscX/following{/other_user}","gists_url":"https://api.github.com/users/prscX/gists{/gist_id}","starred_url":"https://api.github.com/users/prscX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prscX/subscriptions","organizations_url":"https://api.github.com/users/prscX/orgs","repos_url":"https://api.github.com/users/prscX/repos","events_url":"https://api.github.com/users/prscX/events{/privacy}","received_events_url":"https://api.github.com/users/prscX/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T05:51:16Z","updated_at":"2018-10-01T05:51:16Z","author_association":"OWNER","body":"Thanks a lot @StevenMasini for the Effort.\r\n\r\nI have merged the same. I will test and release the same.\r\n\r\nThanks\r\n</ Pranav >"}}
{"actor":{"display_login":"prscX"}}