{"action":"created","issue":{"url":"https://api.github.com/repos/open62541/open62541/issues/2263","repository_url":"https://api.github.com/repos/open62541/open62541","labels_url":"https://api.github.com/repos/open62541/open62541/issues/2263/labels{/name}","comments_url":"https://api.github.com/repos/open62541/open62541/issues/2263/comments","events_url":"https://api.github.com/repos/open62541/open62541/issues/2263/events","html_url":"https://github.com/open62541/open62541/pull/2263","id":386559359,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjU4Njgy","number":2263,"title":"Make logging a proper plugin with state and cleanup method","user":{"login":"jpfr","id":1726411,"node_id":"MDQ6VXNlcjE3MjY0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1726411?v=4","gravatar_id":"","url":"https://api.github.com/users/jpfr","html_url":"https://github.com/jpfr","followers_url":"https://api.github.com/users/jpfr/followers","following_url":"https://api.github.com/users/jpfr/following{/other_user}","gists_url":"https://api.github.com/users/jpfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfr/subscriptions","organizations_url":"https://api.github.com/users/jpfr/orgs","repos_url":"https://api.github.com/users/jpfr/repos","events_url":"https://api.github.com/users/jpfr/events{/privacy}","received_events_url":"https://api.github.com/users/jpfr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-02T13:23:52Z","updated_at":"2018-12-03T11:41:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/open62541/open62541/pulls/2263","html_url":"https://github.com/open62541/open62541/pull/2263","diff_url":"https://github.com/open62541/open62541/pull/2263.diff","patch_url":"https://github.com/open62541/open62541/pull/2263.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/open62541/open62541/issues/comments/443681619","html_url":"https://github.com/open62541/open62541/pull/2263#issuecomment-443681619","issue_url":"https://api.github.com/repos/open62541/open62541/issues/2263","id":443681619,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzY4MTYxOQ==","user":{"login":"jpfr","id":1726411,"node_id":"MDQ6VXNlcjE3MjY0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1726411?v=4","gravatar_id":"","url":"https://api.github.com/users/jpfr","html_url":"https://github.com/jpfr","followers_url":"https://api.github.com/users/jpfr/followers","following_url":"https://api.github.com/users/jpfr/following{/other_user}","gists_url":"https://api.github.com/users/jpfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfr/subscriptions","organizations_url":"https://api.github.com/users/jpfr/orgs","repos_url":"https://api.github.com/users/jpfr/repos","events_url":"https://api.github.com/users/jpfr/events{/privacy}","received_events_url":"https://api.github.com/users/jpfr/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T11:41:20Z","updated_at":"2018-12-03T11:41:20Z","author_association":"MEMBER","body":"> Couldn't we make the logger a singleton so that we can access it wherever we want to?\r\n\r\nSingletons in C are global variables.\r\nhttp://wiki.c2.com/?GlobalVariablesAreBad\r\n\r\nEspecially, global variables that are not a constant are bad...\r\nYou might have several instances of client / server in one process.\r\nAt which point can you shut down the (stateful) logger?"}}
{"actor":{"display_login":"jpfr"}}