{"action":"opened","number":27,"pull_request":{"url":"https://api.github.com/repos/jrochkind/attr_json/pulls/27","id":187271255,"html_url":"https://github.com/jrochkind/attr_json/pull/27","diff_url":"https://github.com/jrochkind/attr_json/pull/27.diff","patch_url":"https://github.com/jrochkind/attr_json/pull/27.patch","issue_url":"https://api.github.com/repos/jrochkind/attr_json/issues/27","number":27,"state":"open","locked":false,"title":"Track defaults as a change to container attribute","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars3.githubusercontent.com/u/149304?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"body":"Closes #26\n\nBy fixing AttrJson::Type::ContainerAttribute to properly account for defaults in changed_in_place?, which makes it more correct anyway. \n\nAnd adding an empty hash default to AR attribute for container attributes. This gets AR change-tracking to realize that the defaults being applied constitute a change, and the container column needs to be saved. Couldn't figure out another way to get to relevant AR change tracking method API more directly, from the places I am. \n\nTurns out attr_json even before this change wouldn't let you save nil/null in a container attribute column, it insisted on empty hash. Which is probably fine, and any rate is not a regression here.","created_at":"2018-05-10T18:34:52Z","updated_at":"2018-05-10T18:34:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jrochkind/attr_json/pulls/27/commits","review_comments_url":"https://api.github.com/repos/jrochkind/attr_json/pulls/27/comments","review_comment_url":"https://api.github.com/repos/jrochkind/attr_json/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jrochkind/attr_json/issues/27/comments","statuses_url":"https://api.github.com/repos/jrochkind/attr_json/statuses/50198b53eb9bd2eb285398c86d411279e90b2b63","head":{"label":"jrochkind:defaults_saving","ref":"defaults_saving","sha":"50198b53eb9bd2eb285398c86d411279e90b2b63","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars3.githubusercontent.com/u/149304?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"repo":{"id":90215567,"name":"attr_json","full_name":"jrochkind/attr_json","owner":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars3.githubusercontent.com/u/149304?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrochkind/attr_json","description":"Serialized json-hash-backed ActiveRecord attributes, super smooth ","fork":false,"url":"https://api.github.com/repos/jrochkind/attr_json","forks_url":"https://api.github.com/repos/jrochkind/attr_json/forks","keys_url":"https://api.github.com/repos/jrochkind/attr_json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrochkind/attr_json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrochkind/attr_json/teams","hooks_url":"https://api.github.com/repos/jrochkind/attr_json/hooks","issue_events_url":"https://api.github.com/repos/jrochkind/attr_json/issues/events{/number}","events_url":"https://api.github.com/repos/jrochkind/attr_json/events","assignees_url":"https://api.github.com/repos/jrochkind/attr_json/assignees{/user}","branches_url":"https://api.github.com/repos/jrochkind/attr_json/branches{/branch}","tags_url":"https://api.github.com/repos/jrochkind/attr_json/tags","blobs_url":"https://api.github.com/repos/jrochkind/attr_json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrochkind/attr_json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrochkind/attr_json/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrochkind/attr_json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrochkind/attr_json/statuses/{sha}","languages_url":"https://api.github.com/repos/jrochkind/attr_json/languages","stargazers_url":"https://api.github.com/repos/jrochkind/attr_json/stargazers","contributors_url":"https://api.github.com/repos/jrochkind/attr_json/contributors","subscribers_url":"https://api.github.com/repos/jrochkind/attr_json/subscribers","subscription_url":"https://api.github.com/repos/jrochkind/attr_json/subscription","commits_url":"https://api.github.com/repos/jrochkind/attr_json/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrochkind/attr_json/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrochkind/attr_json/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrochkind/attr_json/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrochkind/attr_json/contents/{+path}","compare_url":"https://api.github.com/repos/jrochkind/attr_json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrochkind/attr_json/merges","archive_url":"https://api.github.com/repos/jrochkind/attr_json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrochkind/attr_json/downloads","issues_url":"https://api.github.com/repos/jrochkind/attr_json/issues{/number}","pulls_url":"https://api.github.com/repos/jrochkind/attr_json/pulls{/number}","milestones_url":"https://api.github.com/repos/jrochkind/attr_json/milestones{/number}","notifications_url":"https://api.github.com/repos/jrochkind/attr_json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrochkind/attr_json/labels{/name}","releases_url":"https://api.github.com/repos/jrochkind/attr_json/releases{/id}","deployments_url":"https://api.github.com/repos/jrochkind/attr_json/deployments","created_at":"2017-05-04T03:00:42Z","updated_at":"2018-05-10T15:38:24Z","pushed_at":"2018-05-10T18:28:59Z","git_url":"git://github.com/jrochkind/attr_json.git","ssh_url":"git@github.com:jrochkind/attr_json.git","clone_url":"https://github.com/jrochkind/attr_json.git","svn_url":"https://github.com/jrochkind/attr_json","homepage":"","size":588,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":7,"watchers":21,"default_branch":"master"}},"base":{"label":"jrochkind:master","ref":"master","sha":"59c652e663f6f4caceabc4e031ff2110606d2e31","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars3.githubusercontent.com/u/149304?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"repo":{"id":90215567,"name":"attr_json","full_name":"jrochkind/attr_json","owner":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars3.githubusercontent.com/u/149304?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrochkind/attr_json","description":"Serialized json-hash-backed ActiveRecord attributes, super smooth ","fork":false,"url":"https://api.github.com/repos/jrochkind/attr_json","forks_url":"https://api.github.com/repos/jrochkind/attr_json/forks","keys_url":"https://api.github.com/repos/jrochkind/attr_json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrochkind/attr_json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrochkind/attr_json/teams","hooks_url":"https://api.github.com/repos/jrochkind/attr_json/hooks","issue_events_url":"https://api.github.com/repos/jrochkind/attr_json/issues/events{/number}","events_url":"https://api.github.com/repos/jrochkind/attr_json/events","assignees_url":"https://api.github.com/repos/jrochkind/attr_json/assignees{/user}","branches_url":"https://api.github.com/repos/jrochkind/attr_json/branches{/branch}","tags_url":"https://api.github.com/repos/jrochkind/attr_json/tags","blobs_url":"https://api.github.com/repos/jrochkind/attr_json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrochkind/attr_json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrochkind/attr_json/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrochkind/attr_json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrochkind/attr_json/statuses/{sha}","languages_url":"https://api.github.com/repos/jrochkind/attr_json/languages","stargazers_url":"https://api.github.com/repos/jrochkind/attr_json/stargazers","contributors_url":"https://api.github.com/repos/jrochkind/attr_json/contributors","subscribers_url":"https://api.github.com/repos/jrochkind/attr_json/subscribers","subscription_url":"https://api.github.com/repos/jrochkind/attr_json/subscription","commits_url":"https://api.github.com/repos/jrochkind/attr_json/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrochkind/attr_json/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrochkind/attr_json/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrochkind/attr_json/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrochkind/attr_json/contents/{+path}","compare_url":"https://api.github.com/repos/jrochkind/attr_json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrochkind/attr_json/merges","archive_url":"https://api.github.com/repos/jrochkind/attr_json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrochkind/attr_json/downloads","issues_url":"https://api.github.com/repos/jrochkind/attr_json/issues{/number}","pulls_url":"https://api.github.com/repos/jrochkind/attr_json/pulls{/number}","milestones_url":"https://api.github.com/repos/jrochkind/attr_json/milestones{/number}","notifications_url":"https://api.github.com/repos/jrochkind/attr_json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrochkind/attr_json/labels{/name}","releases_url":"https://api.github.com/repos/jrochkind/attr_json/releases{/id}","deployments_url":"https://api.github.com/repos/jrochkind/attr_json/deployments","created_at":"2017-05-04T03:00:42Z","updated_at":"2018-05-10T15:38:24Z","pushed_at":"2018-05-10T18:28:59Z","git_url":"git://github.com/jrochkind/attr_json.git","ssh_url":"git@github.com:jrochkind/attr_json.git","clone_url":"https://github.com/jrochkind/attr_json.git","svn_url":"https://github.com/jrochkind/attr_json","homepage":"","size":588,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":7,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jrochkind/attr_json/pulls/27"},"html":{"href":"https://github.com/jrochkind/attr_json/pull/27"},"issue":{"href":"https://api.github.com/repos/jrochkind/attr_json/issues/27"},"comments":{"href":"https://api.github.com/repos/jrochkind/attr_json/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/jrochkind/attr_json/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/jrochkind/attr_json/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jrochkind/attr_json/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/jrochkind/attr_json/statuses/50198b53eb9bd2eb285398c86d411279e90b2b63"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":46,"deletions":16,"changed_files":4}}
{"actor":{"display_login":"jrochkind"}}