{"action":"created","comment":{"url":"https://api.github.com/repos/ICTU/quality-report/pulls/comments/170249997","pull_request_review_id":98910329,"id":170249997,"diff_hunk":"@@ -30,45 +30,21 @@ def setUp(self):\n                                        metric_source_ids={self._jenkins: 'dummy'})\n         self._metric = CIJobs(subject=self._project, project=self._project)\n \n-    def test_format_text_with_links(self):\n-        \"\"\" Function returns unchanged text. \"\"\"\n-        self.assertEqual(\"Some text... \", self._metric.format_text_with_links(text=\"Some text... \"))\n-\n-    def test_format_text_with_links_escape(self):\n-        \"\"\" Function returns text with html escaped characters. \"\"\"\n-        self.assertEqual(\"Some &amp;text... \", self._metric.format_text_with_links(text=\"Some &text... \"))\n-\n-    def test_format_text_with_links_escape_(self):\n-        \"\"\" Function returns text with html escaped characters. \"\"\"\n-        self.assertEqual(\"Some &amp;text... \", self._metric.format_text_with_links(text=\"Some &text... \"))\n-\n-    def test_url(self):\n-        \"\"\" Test that the url of the metric equals the url of Jenkins. \"\"\"\n-        self.assertEqual(dict(), self._metric.url())\n-\n     def test_label(self):\n         \"\"\" Test that the label to use in the HTML report is correct. \"\"\"\n         self.assertEqual('', self._metric.url_label_text)\n \n-    def test_extra_info_is_none(self):\n-        \"\"\" Test that extra info is None when there is no metric source \"\"\"\n-        self._metric._metric_source = None\n-        self.assertEqual(None, self._metric.extra_info())\n+    def test_convertItemToExtraInfo(self):\n+        \"\"\" Test if ci job item is correctly converted to extra info record. \"\"\"\n+        expected = ({'href': 'http://xx.xl', 'text': 'Link Text'}, '42')\n+\n+        result = self._metric._convertItemToExtraInfo(('Link Text', 'http://xx.xl', '42'))\n \n-    @patch.object(CIJobs, '_jobs_url')\n-    def test_extra_info(self, mock_jobs_url):\n-        \"\"\" Test that extra info is correct. \"\"\"\n-        mock_jobs_url.return_value = [('name', 'http://url', '7')]\n-        expected_extra_info = domain.ExtraInfo(link=\"Job naam\", comment=\"Aantal dagen \")\n-        expected_extra_info += {'href': 'http://url', 'text': 'name'}, '7'\n+        self.assertEqual(expected, result)\n \n-        result = self._metric.extra_info()\n-        self.assertEqual(expected_extra_info.headers, result.headers)\n-        self.assertEqual(expected_extra_info.data, result.data)\n+    def test_convertItemToExtraInfo_none(self):","path":"backend/tests/unittests/metric/environment/ci_jobs_tests.py","position":45,"original_position":45,"commit_id":"1fbd4b37d62d20a41adc6d4c9a989cccaa31b368","original_commit_id":"1fbd4b37d62d20a41adc6d4c9a989cccaa31b368","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Method name \"test_convertItemToExtraInfo_none\" doesn't conform to '[a-z_][a-z0-9_]{2,50}$' pattern ('[a-z_][a-z0-9_]{2,50}$' pattern)](https://app.codacy.com/app/frank_10/quality-report/pullRequest?prid=1363223)","created_at":"2018-02-23T13:26:09Z","updated_at":"2018-02-23T13:26:09Z","html_url":"https://github.com/ICTU/quality-report/pull/291#discussion_r170249997","pull_request_url":"https://api.github.com/repos/ICTU/quality-report/pulls/291","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/comments/170249997"},"html":{"href":"https://github.com/ICTU/quality-report/pull/291#discussion_r170249997"},"pull_request":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/ICTU/quality-report/pulls/291","id":170794046,"html_url":"https://github.com/ICTU/quality-report/pull/291","diff_url":"https://github.com/ICTU/quality-report/pull/291.diff","patch_url":"https://github.com/ICTU/quality-report/pull/291.patch","issue_url":"https://api.github.com/repos/ICTU/quality-report/issues/291","number":291,"state":"open","locked":false,"title":"Feature 288 action activity metric detail pane","user":{"login":"milenk","id":32734752,"avatar_url":"https://avatars2.githubusercontent.com/u/32734752?v=4","gravatar_id":"","url":"https://api.github.com/users/milenk","html_url":"https://github.com/milenk","followers_url":"https://api.github.com/users/milenk/followers","following_url":"https://api.github.com/users/milenk/following{/other_user}","gists_url":"https://api.github.com/users/milenk/gists{/gist_id}","starred_url":"https://api.github.com/users/milenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milenk/subscriptions","organizations_url":"https://api.github.com/users/milenk/orgs","repos_url":"https://api.github.com/users/milenk/repos","events_url":"https://api.github.com/users/milenk/events{/privacy}","received_events_url":"https://api.github.com/users/milenk/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-22T16:09:35Z","updated_at":"2018-02-23T13:26:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18d65b09b1fbb4967ee1b98aa84dcfe1e40195d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ICTU/quality-report/pulls/291/commits","review_comments_url":"https://api.github.com/repos/ICTU/quality-report/pulls/291/comments","review_comment_url":"https://api.github.com/repos/ICTU/quality-report/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ICTU/quality-report/issues/291/comments","statuses_url":"https://api.github.com/repos/ICTU/quality-report/statuses/1fbd4b37d62d20a41adc6d4c9a989cccaa31b368","head":{"label":"ICTU:feature-288-action-activity-metric-detail-pane","ref":"feature-288-action-activity-metric-detail-pane","sha":"1fbd4b37d62d20a41adc6d4c9a989cccaa31b368","user":{"login":"ICTU","id":6009701,"avatar_url":"https://avatars1.githubusercontent.com/u/6009701?v=4","gravatar_id":"","url":"https://api.github.com/users/ICTU","html_url":"https://github.com/ICTU","followers_url":"https://api.github.com/users/ICTU/followers","following_url":"https://api.github.com/users/ICTU/following{/other_user}","gists_url":"https://api.github.com/users/ICTU/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTU/subscriptions","organizations_url":"https://api.github.com/users/ICTU/orgs","repos_url":"https://api.github.com/users/ICTU/repos","events_url":"https://api.github.com/users/ICTU/events{/privacy}","received_events_url":"https://api.github.com/users/ICTU/received_events","type":"Organization","site_admin":false},"repo":{"id":16836834,"name":"quality-report","full_name":"ICTU/quality-report","owner":{"login":"ICTU","id":6009701,"avatar_url":"https://avatars1.githubusercontent.com/u/6009701?v=4","gravatar_id":"","url":"https://api.github.com/users/ICTU","html_url":"https://github.com/ICTU","followers_url":"https://api.github.com/users/ICTU/followers","following_url":"https://api.github.com/users/ICTU/following{/other_user}","gists_url":"https://api.github.com/users/ICTU/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTU/subscriptions","organizations_url":"https://api.github.com/users/ICTU/orgs","repos_url":"https://api.github.com/users/ICTU/repos","events_url":"https://api.github.com/users/ICTU/events{/privacy}","received_events_url":"https://api.github.com/users/ICTU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ICTU/quality-report","description":"HQ - Holistic Software Quality Reporting","fork":false,"url":"https://api.github.com/repos/ICTU/quality-report","forks_url":"https://api.github.com/repos/ICTU/quality-report/forks","keys_url":"https://api.github.com/repos/ICTU/quality-report/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ICTU/quality-report/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ICTU/quality-report/teams","hooks_url":"https://api.github.com/repos/ICTU/quality-report/hooks","issue_events_url":"https://api.github.com/repos/ICTU/quality-report/issues/events{/number}","events_url":"https://api.github.com/repos/ICTU/quality-report/events","assignees_url":"https://api.github.com/repos/ICTU/quality-report/assignees{/user}","branches_url":"https://api.github.com/repos/ICTU/quality-report/branches{/branch}","tags_url":"https://api.github.com/repos/ICTU/quality-report/tags","blobs_url":"https://api.github.com/repos/ICTU/quality-report/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ICTU/quality-report/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ICTU/quality-report/git/refs{/sha}","trees_url":"https://api.github.com/repos/ICTU/quality-report/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ICTU/quality-report/statuses/{sha}","languages_url":"https://api.github.com/repos/ICTU/quality-report/languages","stargazers_url":"https://api.github.com/repos/ICTU/quality-report/stargazers","contributors_url":"https://api.github.com/repos/ICTU/quality-report/contributors","subscribers_url":"https://api.github.com/repos/ICTU/quality-report/subscribers","subscription_url":"https://api.github.com/repos/ICTU/quality-report/subscription","commits_url":"https://api.github.com/repos/ICTU/quality-report/commits{/sha}","git_commits_url":"https://api.github.com/repos/ICTU/quality-report/git/commits{/sha}","comments_url":"https://api.github.com/repos/ICTU/quality-report/comments{/number}","issue_comment_url":"https://api.github.com/repos/ICTU/quality-report/issues/comments{/number}","contents_url":"https://api.github.com/repos/ICTU/quality-report/contents/{+path}","compare_url":"https://api.github.com/repos/ICTU/quality-report/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ICTU/quality-report/merges","archive_url":"https://api.github.com/repos/ICTU/quality-report/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ICTU/quality-report/downloads","issues_url":"https://api.github.com/repos/ICTU/quality-report/issues{/number}","pulls_url":"https://api.github.com/repos/ICTU/quality-report/pulls{/number}","milestones_url":"https://api.github.com/repos/ICTU/quality-report/milestones{/number}","notifications_url":"https://api.github.com/repos/ICTU/quality-report/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ICTU/quality-report/labels{/name}","releases_url":"https://api.github.com/repos/ICTU/quality-report/releases{/id}","deployments_url":"https://api.github.com/repos/ICTU/quality-report/deployments","created_at":"2014-02-14T12:39:18Z","updated_at":"2018-01-29T16:19:20Z","pushed_at":"2018-02-23T13:23:25Z","git_url":"git://github.com/ICTU/quality-report.git","ssh_url":"git@github.com:ICTU/quality-report.git","clone_url":"https://github.com/ICTU/quality-report.git","svn_url":"https://github.com/ICTU/quality-report","homepage":"http://ictu.github.io/quality-report/","size":7001,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":49,"license":null,"forks":5,"open_issues":49,"watchers":12,"default_branch":"master"}},"base":{"label":"ICTU:master","ref":"master","sha":"1c780f01843c6e2c5e822f06df1349fd89342459","user":{"login":"ICTU","id":6009701,"avatar_url":"https://avatars1.githubusercontent.com/u/6009701?v=4","gravatar_id":"","url":"https://api.github.com/users/ICTU","html_url":"https://github.com/ICTU","followers_url":"https://api.github.com/users/ICTU/followers","following_url":"https://api.github.com/users/ICTU/following{/other_user}","gists_url":"https://api.github.com/users/ICTU/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTU/subscriptions","organizations_url":"https://api.github.com/users/ICTU/orgs","repos_url":"https://api.github.com/users/ICTU/repos","events_url":"https://api.github.com/users/ICTU/events{/privacy}","received_events_url":"https://api.github.com/users/ICTU/received_events","type":"Organization","site_admin":false},"repo":{"id":16836834,"name":"quality-report","full_name":"ICTU/quality-report","owner":{"login":"ICTU","id":6009701,"avatar_url":"https://avatars1.githubusercontent.com/u/6009701?v=4","gravatar_id":"","url":"https://api.github.com/users/ICTU","html_url":"https://github.com/ICTU","followers_url":"https://api.github.com/users/ICTU/followers","following_url":"https://api.github.com/users/ICTU/following{/other_user}","gists_url":"https://api.github.com/users/ICTU/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTU/subscriptions","organizations_url":"https://api.github.com/users/ICTU/orgs","repos_url":"https://api.github.com/users/ICTU/repos","events_url":"https://api.github.com/users/ICTU/events{/privacy}","received_events_url":"https://api.github.com/users/ICTU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ICTU/quality-report","description":"HQ - Holistic Software Quality Reporting","fork":false,"url":"https://api.github.com/repos/ICTU/quality-report","forks_url":"https://api.github.com/repos/ICTU/quality-report/forks","keys_url":"https://api.github.com/repos/ICTU/quality-report/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ICTU/quality-report/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ICTU/quality-report/teams","hooks_url":"https://api.github.com/repos/ICTU/quality-report/hooks","issue_events_url":"https://api.github.com/repos/ICTU/quality-report/issues/events{/number}","events_url":"https://api.github.com/repos/ICTU/quality-report/events","assignees_url":"https://api.github.com/repos/ICTU/quality-report/assignees{/user}","branches_url":"https://api.github.com/repos/ICTU/quality-report/branches{/branch}","tags_url":"https://api.github.com/repos/ICTU/quality-report/tags","blobs_url":"https://api.github.com/repos/ICTU/quality-report/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ICTU/quality-report/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ICTU/quality-report/git/refs{/sha}","trees_url":"https://api.github.com/repos/ICTU/quality-report/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ICTU/quality-report/statuses/{sha}","languages_url":"https://api.github.com/repos/ICTU/quality-report/languages","stargazers_url":"https://api.github.com/repos/ICTU/quality-report/stargazers","contributors_url":"https://api.github.com/repos/ICTU/quality-report/contributors","subscribers_url":"https://api.github.com/repos/ICTU/quality-report/subscribers","subscription_url":"https://api.github.com/repos/ICTU/quality-report/subscription","commits_url":"https://api.github.com/repos/ICTU/quality-report/commits{/sha}","git_commits_url":"https://api.github.com/repos/ICTU/quality-report/git/commits{/sha}","comments_url":"https://api.github.com/repos/ICTU/quality-report/comments{/number}","issue_comment_url":"https://api.github.com/repos/ICTU/quality-report/issues/comments{/number}","contents_url":"https://api.github.com/repos/ICTU/quality-report/contents/{+path}","compare_url":"https://api.github.com/repos/ICTU/quality-report/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ICTU/quality-report/merges","archive_url":"https://api.github.com/repos/ICTU/quality-report/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ICTU/quality-report/downloads","issues_url":"https://api.github.com/repos/ICTU/quality-report/issues{/number}","pulls_url":"https://api.github.com/repos/ICTU/quality-report/pulls{/number}","milestones_url":"https://api.github.com/repos/ICTU/quality-report/milestones{/number}","notifications_url":"https://api.github.com/repos/ICTU/quality-report/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ICTU/quality-report/labels{/name}","releases_url":"https://api.github.com/repos/ICTU/quality-report/releases{/id}","deployments_url":"https://api.github.com/repos/ICTU/quality-report/deployments","created_at":"2014-02-14T12:39:18Z","updated_at":"2018-01-29T16:19:20Z","pushed_at":"2018-02-23T13:23:25Z","git_url":"git://github.com/ICTU/quality-report.git","ssh_url":"git@github.com:ICTU/quality-report.git","clone_url":"https://github.com/ICTU/quality-report.git","svn_url":"https://github.com/ICTU/quality-report","homepage":"http://ictu.github.io/quality-report/","size":7001,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":49,"license":null,"forks":5,"open_issues":49,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/291"},"html":{"href":"https://github.com/ICTU/quality-report/pull/291"},"issue":{"href":"https://api.github.com/repos/ICTU/quality-report/issues/291"},"comments":{"href":"https://api.github.com/repos/ICTU/quality-report/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/ICTU/quality-report/statuses/1fbd4b37d62d20a41adc6d4c9a989cccaa31b368"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codacy-bot"}}