{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/241503396","pull_request_review_id":184793478,"id":241503396,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTUwMzM5Ng==","diff_hunk":"@@ -319,7 +318,7 @@ class _ChipDemoState extends State<ChipDemo> {\n       body: ChipTheme(\n         data: _showShapeBorder\n             ? theme.chipTheme.copyWith(\n-                shape: BeveledRectangleBorder(\n+              shape: BeveledRectangleBorder(","path":"examples/flutter_gallery/lib/demo/material/chip_demo.dart","position":66,"original_position":66,"commit_id":"1a32ac8f9dab317407b2d2b7d9f9bc5e750431c7","original_commit_id":"1a32ac8f9dab317407b2d2b7d9f9bc5e750431c7","user":{"login":"HansMuller","id":1377460,"node_id":"MDQ6VXNlcjEzNzc0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1377460?v=4","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"body":"The original indent should have been left alone: `shape` is a copyWith parameter.","created_at":"2018-12-13T18:00:53Z","updated_at":"2018-12-13T18:00:53Z","html_url":"https://github.com/flutter/flutter/pull/25251#discussion_r241503396","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/25251","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/241503396"},"html":{"href":"https://github.com/flutter/flutter/pull/25251#discussion_r241503396"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/25251"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/25251","id":237909009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTA5MDA5","html_url":"https://github.com/flutter/flutter/pull/25251","diff_url":"https://github.com/flutter/flutter/pull/25251.diff","patch_url":"https://github.com/flutter/flutter/pull/25251.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/25251","number":25251,"state":"open","locked":false,"title":"Run dartfmt on all flutter examples","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"body":"For discussion.\r\n\r\nI've run an experimental version of dartfmt that adds trailing commas where they are needed to maintain the existing indentation.\r\n\r\nThe goal is to reduce friction when users copy and paste code from the examples and then run dartfmt. Shipping a version of dartfmt with this optional `--fix-trailing-commas` could also help educate new flutter users on when to use trailing commas to get the desired formatting.\r\n\r\nFor comparison here is what the dartfmt does to this directory without the auto fix. \r\nhttps://github.com/flutter/flutter/compare/master...jacob314:format_baseline?expand=1\r\n\r\n","created_at":"2018-12-12T04:27:33Z","updated_at":"2018-12-13T18:00:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c69df9d4c7a69026753cb5abbaea9a6c6974122e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false},{"id":581964819,"node_id":"MDU6TGFiZWw1ODE5NjQ4MTk=","url":"https://api.github.com/repos/flutter/flutter/labels/d:%20examples","name":"d: examples","color":"0e8a16","default":false},{"id":283479307,"node_id":"MDU6TGFiZWwyODM0NzkzMDc=","url":"https://api.github.com/repos/flutter/flutter/labels/team","name":"team","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/25251/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/25251/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/25251/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/1a32ac8f9dab317407b2d2b7d9f9bc5e750431c7","head":{"label":"jacob314:dartfmt_fix","ref":"dartfmt_fix","sha":"1a32ac8f9dab317407b2d2b7d9f9bc5e750431c7","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"repo":{"id":80662565,"node_id":"MDEwOlJlcG9zaXRvcnk4MDY2MjU2NQ==","name":"flutter","full_name":"jacob314/flutter","private":false,"owner":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jacob314/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/jacob314/flutter","forks_url":"https://api.github.com/repos/jacob314/flutter/forks","keys_url":"https://api.github.com/repos/jacob314/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacob314/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacob314/flutter/teams","hooks_url":"https://api.github.com/repos/jacob314/flutter/hooks","issue_events_url":"https://api.github.com/repos/jacob314/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jacob314/flutter/events","assignees_url":"https://api.github.com/repos/jacob314/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jacob314/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jacob314/flutter/tags","blobs_url":"https://api.github.com/repos/jacob314/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacob314/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacob314/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacob314/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacob314/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jacob314/flutter/languages","stargazers_url":"https://api.github.com/repos/jacob314/flutter/stargazers","contributors_url":"https://api.github.com/repos/jacob314/flutter/contributors","subscribers_url":"https://api.github.com/repos/jacob314/flutter/subscribers","subscription_url":"https://api.github.com/repos/jacob314/flutter/subscription","commits_url":"https://api.github.com/repos/jacob314/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacob314/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacob314/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacob314/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacob314/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jacob314/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacob314/flutter/merges","archive_url":"https://api.github.com/repos/jacob314/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacob314/flutter/downloads","issues_url":"https://api.github.com/repos/jacob314/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jacob314/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jacob314/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jacob314/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacob314/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jacob314/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jacob314/flutter/deployments","created_at":"2017-02-01T20:47:00Z","updated_at":"2017-02-01T20:47:04Z","pushed_at":"2018-12-13T05:01:55Z","git_url":"git://github.com/jacob314/flutter.git","ssh_url":"git@github.com:jacob314/flutter.git","clone_url":"https://github.com/jacob314/flutter.git","svn_url":"https://github.com/jacob314/flutter","homepage":"https://flutter.io","size":50560,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"e6292c8da1595f1abd12354d0224f0d77b28b422","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-12-13T17:57:53Z","pushed_at":"2018-12-13T17:36:29Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":49944,"stargazers_count":46080,"watchers_count":46080,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4677,"mirror_url":null,"archived":false,"open_issues_count":4247,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4677,"open_issues":4247,"watchers":46080,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/25251"},"html":{"href":"https://github.com/flutter/flutter/pull/25251"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/25251"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/25251/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/25251/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/25251/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/1a32ac8f9dab317407b2d2b7d9f9bc5e750431c7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HansMuller"}}