{"action":"created","comment":{"url":"https://api.github.com/repos/lalrpop/lalrpop/pulls/comments/183212282","pull_request_review_id":114175668,"id":183212282,"diff_hunk":"@@ -24,7 +24,7 @@ itertools = \"0.7\"\n regex = \"0.2.1\"\n regex-syntax = \"0.4.0\"\n petgraph = \"0.4.4\"\n-string_cache = \"0.7.1\"\n+string_cache = \"0.7.1,<=0.7.1\"","path":"lalrpop-snap/Cargo.toml","position":5,"original_position":5,"commit_id":"dd39e0528848e59cd263ae626e4881c2d2b832d4","original_commit_id":"dd39e0528848e59cd263ae626e4881c2d2b832d4","user":{"login":"Dylan-DPC","id":12371125,"avatar_url":"https://avatars1.githubusercontent.com/u/12371125?v=4","gravatar_id":"","url":"https://api.github.com/users/Dylan-DPC","html_url":"https://github.com/Dylan-DPC","followers_url":"https://api.github.com/users/Dylan-DPC/followers","following_url":"https://api.github.com/users/Dylan-DPC/following{/other_user}","gists_url":"https://api.github.com/users/Dylan-DPC/gists{/gist_id}","starred_url":"https://api.github.com/users/Dylan-DPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dylan-DPC/subscriptions","organizations_url":"https://api.github.com/users/Dylan-DPC/orgs","repos_url":"https://api.github.com/users/Dylan-DPC/repos","events_url":"https://api.github.com/users/Dylan-DPC/events{/privacy}","received_events_url":"https://api.github.com/users/Dylan-DPC/received_events","type":"User","site_admin":false},"body":"I think =0.7.1 should be fine. I agree with matklad that dependencies shouldn't be locked to a specific version, but in this case there is no direct solution unless we specify a minimum compiler version. ","created_at":"2018-04-21T15:26:44Z","updated_at":"2018-04-21T15:26:44Z","html_url":"https://github.com/lalrpop/lalrpop/pull/366#discussion_r183212282","pull_request_url":"https://api.github.com/repos/lalrpop/lalrpop/pulls/366","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lalrpop/lalrpop/pulls/comments/183212282"},"html":{"href":"https://github.com/lalrpop/lalrpop/pull/366#discussion_r183212282"},"pull_request":{"href":"https://api.github.com/repos/lalrpop/lalrpop/pulls/366"}},"in_reply_to_id":183211817},"pull_request":{"url":"https://api.github.com/repos/lalrpop/lalrpop/pulls/366","id":183168376,"html_url":"https://github.com/lalrpop/lalrpop/pull/366","diff_url":"https://github.com/lalrpop/lalrpop/pull/366.diff","patch_url":"https://github.com/lalrpop/lalrpop/pull/366.patch","issue_url":"https://api.github.com/repos/lalrpop/lalrpop/issues/366","number":366,"state":"open","locked":false,"title":"fix: Improve compile times by reducing the size of the reduce actions ","user":{"login":"Marwes","id":957312,"avatar_url":"https://avatars3.githubusercontent.com/u/957312?v=4","gravatar_id":"","url":"https://api.github.com/users/Marwes","html_url":"https://github.com/Marwes","followers_url":"https://api.github.com/users/Marwes/followers","following_url":"https://api.github.com/users/Marwes/following{/other_user}","gists_url":"https://api.github.com/users/Marwes/gists{/gist_id}","starred_url":"https://api.github.com/users/Marwes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marwes/subscriptions","organizations_url":"https://api.github.com/users/Marwes/orgs","repos_url":"https://api.github.com/users/Marwes/repos","events_url":"https://api.github.com/users/Marwes/events{/privacy}","received_events_url":"https://api.github.com/users/Marwes/received_events","type":"User","site_admin":false},"body":"This vastly improves the compile times of generated parse table parsers. Apparently both rustc and llvm struggle with the huge `match` expression that gets created.\r\n\r\nFixes(?) #260 \r\n\r\n## time cargo build -p lalrpop\r\n\r\n(This includes compiling all of LALRPOPs dependencies as well which takes ~40s).\r\n\r\n### Before\r\n\r\n```\r\nreal    5m5.064s\r\nuser    0m0.000s\r\nsys     0m0.015s\r\n```\r\n\r\n### After\r\n\r\n```\r\nreal    2m20.169s\r\nuser    0m0.000s\r\nsys     0m0.015s\r\n```","created_at":"2018-04-20T20:54:52Z","updated_at":"2018-04-21T15:26:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11da83cd9dfa1672ecd79c91628f2f768bef8d27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lalrpop/lalrpop/pulls/366/commits","review_comments_url":"https://api.github.com/repos/lalrpop/lalrpop/pulls/366/comments","review_comment_url":"https://api.github.com/repos/lalrpop/lalrpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lalrpop/lalrpop/issues/366/comments","statuses_url":"https://api.github.com/repos/lalrpop/lalrpop/statuses/dd39e0528848e59cd263ae626e4881c2d2b832d4","head":{"label":"Marwes:compiletime","ref":"compiletime","sha":"dd39e0528848e59cd263ae626e4881c2d2b832d4","user":{"login":"Marwes","id":957312,"avatar_url":"https://avatars3.githubusercontent.com/u/957312?v=4","gravatar_id":"","url":"https://api.github.com/users/Marwes","html_url":"https://github.com/Marwes","followers_url":"https://api.github.com/users/Marwes/followers","following_url":"https://api.github.com/users/Marwes/following{/other_user}","gists_url":"https://api.github.com/users/Marwes/gists{/gist_id}","starred_url":"https://api.github.com/users/Marwes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marwes/subscriptions","organizations_url":"https://api.github.com/users/Marwes/orgs","repos_url":"https://api.github.com/users/Marwes/repos","events_url":"https://api.github.com/users/Marwes/events{/privacy}","received_events_url":"https://api.github.com/users/Marwes/received_events","type":"User","site_admin":false},"repo":{"id":73131401,"name":"lalrpop","full_name":"Marwes/lalrpop","owner":{"login":"Marwes","id":957312,"avatar_url":"https://avatars3.githubusercontent.com/u/957312?v=4","gravatar_id":"","url":"https://api.github.com/users/Marwes","html_url":"https://github.com/Marwes","followers_url":"https://api.github.com/users/Marwes/followers","following_url":"https://api.github.com/users/Marwes/following{/other_user}","gists_url":"https://api.github.com/users/Marwes/gists{/gist_id}","starred_url":"https://api.github.com/users/Marwes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marwes/subscriptions","organizations_url":"https://api.github.com/users/Marwes/orgs","repos_url":"https://api.github.com/users/Marwes/repos","events_url":"https://api.github.com/users/Marwes/events{/privacy}","received_events_url":"https://api.github.com/users/Marwes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Marwes/lalrpop","description":"LR(1) parser generator for Rust","fork":true,"url":"https://api.github.com/repos/Marwes/lalrpop","forks_url":"https://api.github.com/repos/Marwes/lalrpop/forks","keys_url":"https://api.github.com/repos/Marwes/lalrpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Marwes/lalrpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Marwes/lalrpop/teams","hooks_url":"https://api.github.com/repos/Marwes/lalrpop/hooks","issue_events_url":"https://api.github.com/repos/Marwes/lalrpop/issues/events{/number}","events_url":"https://api.github.com/repos/Marwes/lalrpop/events","assignees_url":"https://api.github.com/repos/Marwes/lalrpop/assignees{/user}","branches_url":"https://api.github.com/repos/Marwes/lalrpop/branches{/branch}","tags_url":"https://api.github.com/repos/Marwes/lalrpop/tags","blobs_url":"https://api.github.com/repos/Marwes/lalrpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Marwes/lalrpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Marwes/lalrpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/Marwes/lalrpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Marwes/lalrpop/statuses/{sha}","languages_url":"https://api.github.com/repos/Marwes/lalrpop/languages","stargazers_url":"https://api.github.com/repos/Marwes/lalrpop/stargazers","contributors_url":"https://api.github.com/repos/Marwes/lalrpop/contributors","subscribers_url":"https://api.github.com/repos/Marwes/lalrpop/subscribers","subscription_url":"https://api.github.com/repos/Marwes/lalrpop/subscription","commits_url":"https://api.github.com/repos/Marwes/lalrpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/Marwes/lalrpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/Marwes/lalrpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/Marwes/lalrpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/Marwes/lalrpop/contents/{+path}","compare_url":"https://api.github.com/repos/Marwes/lalrpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Marwes/lalrpop/merges","archive_url":"https://api.github.com/repos/Marwes/lalrpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Marwes/lalrpop/downloads","issues_url":"https://api.github.com/repos/Marwes/lalrpop/issues{/number}","pulls_url":"https://api.github.com/repos/Marwes/lalrpop/pulls{/number}","milestones_url":"https://api.github.com/repos/Marwes/lalrpop/milestones{/number}","notifications_url":"https://api.github.com/repos/Marwes/lalrpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Marwes/lalrpop/labels{/name}","releases_url":"https://api.github.com/repos/Marwes/lalrpop/releases{/id}","deployments_url":"https://api.github.com/repos/Marwes/lalrpop/deployments","created_at":"2016-11-07T23:49:10Z","updated_at":"2016-11-07T23:49:11Z","pushed_at":"2018-04-21T14:11:43Z","git_url":"git://github.com/Marwes/lalrpop.git","ssh_url":"git@github.com:Marwes/lalrpop.git","clone_url":"https://github.com/Marwes/lalrpop.git","svn_url":"https://github.com/Marwes/lalrpop","homepage":"","size":5575,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lalrpop:master","ref":"master","sha":"2694da775dd8535322f5add914d42bd4f377c01e","user":{"login":"lalrpop","id":35799982,"avatar_url":"https://avatars1.githubusercontent.com/u/35799982?v=4","gravatar_id":"","url":"https://api.github.com/users/lalrpop","html_url":"https://github.com/lalrpop","followers_url":"https://api.github.com/users/lalrpop/followers","following_url":"https://api.github.com/users/lalrpop/following{/other_user}","gists_url":"https://api.github.com/users/lalrpop/gists{/gist_id}","starred_url":"https://api.github.com/users/lalrpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lalrpop/subscriptions","organizations_url":"https://api.github.com/users/lalrpop/orgs","repos_url":"https://api.github.com/users/lalrpop/repos","events_url":"https://api.github.com/users/lalrpop/events{/privacy}","received_events_url":"https://api.github.com/users/lalrpop/received_events","type":"Organization","site_admin":false},"repo":{"id":37341121,"name":"lalrpop","full_name":"lalrpop/lalrpop","owner":{"login":"lalrpop","id":35799982,"avatar_url":"https://avatars1.githubusercontent.com/u/35799982?v=4","gravatar_id":"","url":"https://api.github.com/users/lalrpop","html_url":"https://github.com/lalrpop","followers_url":"https://api.github.com/users/lalrpop/followers","following_url":"https://api.github.com/users/lalrpop/following{/other_user}","gists_url":"https://api.github.com/users/lalrpop/gists{/gist_id}","starred_url":"https://api.github.com/users/lalrpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lalrpop/subscriptions","organizations_url":"https://api.github.com/users/lalrpop/orgs","repos_url":"https://api.github.com/users/lalrpop/repos","events_url":"https://api.github.com/users/lalrpop/events{/privacy}","received_events_url":"https://api.github.com/users/lalrpop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lalrpop/lalrpop","description":"LR(1) parser generator for Rust","fork":false,"url":"https://api.github.com/repos/lalrpop/lalrpop","forks_url":"https://api.github.com/repos/lalrpop/lalrpop/forks","keys_url":"https://api.github.com/repos/lalrpop/lalrpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lalrpop/lalrpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lalrpop/lalrpop/teams","hooks_url":"https://api.github.com/repos/lalrpop/lalrpop/hooks","issue_events_url":"https://api.github.com/repos/lalrpop/lalrpop/issues/events{/number}","events_url":"https://api.github.com/repos/lalrpop/lalrpop/events","assignees_url":"https://api.github.com/repos/lalrpop/lalrpop/assignees{/user}","branches_url":"https://api.github.com/repos/lalrpop/lalrpop/branches{/branch}","tags_url":"https://api.github.com/repos/lalrpop/lalrpop/tags","blobs_url":"https://api.github.com/repos/lalrpop/lalrpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lalrpop/lalrpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lalrpop/lalrpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/lalrpop/lalrpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lalrpop/lalrpop/statuses/{sha}","languages_url":"https://api.github.com/repos/lalrpop/lalrpop/languages","stargazers_url":"https://api.github.com/repos/lalrpop/lalrpop/stargazers","contributors_url":"https://api.github.com/repos/lalrpop/lalrpop/contributors","subscribers_url":"https://api.github.com/repos/lalrpop/lalrpop/subscribers","subscription_url":"https://api.github.com/repos/lalrpop/lalrpop/subscription","commits_url":"https://api.github.com/repos/lalrpop/lalrpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/lalrpop/lalrpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/lalrpop/lalrpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/lalrpop/lalrpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/lalrpop/lalrpop/contents/{+path}","compare_url":"https://api.github.com/repos/lalrpop/lalrpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lalrpop/lalrpop/merges","archive_url":"https://api.github.com/repos/lalrpop/lalrpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lalrpop/lalrpop/downloads","issues_url":"https://api.github.com/repos/lalrpop/lalrpop/issues{/number}","pulls_url":"https://api.github.com/repos/lalrpop/lalrpop/pulls{/number}","milestones_url":"https://api.github.com/repos/lalrpop/lalrpop/milestones{/number}","notifications_url":"https://api.github.com/repos/lalrpop/lalrpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lalrpop/lalrpop/labels{/name}","releases_url":"https://api.github.com/repos/lalrpop/lalrpop/releases{/id}","deployments_url":"https://api.github.com/repos/lalrpop/lalrpop/deployments","created_at":"2015-06-12T19:41:37Z","updated_at":"2018-04-18T11:09:16Z","pushed_at":"2018-04-21T14:11:44Z","git_url":"git://github.com/lalrpop/lalrpop.git","ssh_url":"git@github.com:lalrpop/lalrpop.git","clone_url":"https://github.com/lalrpop/lalrpop.git","svn_url":"https://github.com/lalrpop/lalrpop","homepage":"","size":6208,"stargazers_count":671,"watchers_count":671,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":90,"open_issues":70,"watchers":671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lalrpop/lalrpop/pulls/366"},"html":{"href":"https://github.com/lalrpop/lalrpop/pull/366"},"issue":{"href":"https://api.github.com/repos/lalrpop/lalrpop/issues/366"},"comments":{"href":"https://api.github.com/repos/lalrpop/lalrpop/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/lalrpop/lalrpop/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/lalrpop/lalrpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lalrpop/lalrpop/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/lalrpop/lalrpop/statuses/dd39e0528848e59cd263ae626e4881c2d2b832d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Dylan-DPC"}}