{"push_id":2618411868,"size":35,"distinct_size":35,"ref":"refs/heads/master","head":"992d516cec5b7e21154190ae121c3c85b73baa17","before":"64ca87273ef031b33c268e3dccfb50df91973ac2","commits":[{"sha":"4b70f805fb947e72eefcf024706a25b31878d22a","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Introduce a Context interface\n\nThe goal of this interface is to ease command testing.\n\nA new api package is also created, putting interfaces there lets\nimplementations share the same name without conflicting.\n\nLastly, an Environment is extracted from the Context implementation.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/4b70f805fb947e72eefcf024706a25b31878d22a"},{"sha":"8a34dd43923292a496da57d5f9c3d4010a3599a7","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Add a test for `dcos config show`\n\nThis tests running the `dcos config show core.dcos_url` while a DCOS_URL\nenvironment variable is defined.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/8a34dd43923292a496da57d5f9c3d4010a3599a7"},{"sha":"75a74189c5a6a3ed0c336ef12d768d58f4b1817b","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Add logs for HTTP requests and responses\n\nThis relies on the httputil package to dump requests and reponses, the\nINFO logging level displays requests/responses without the body while\nthe DEBUG level displays them.\n\nEg. :\n\n$ dcos -v auth list-providers https://dcos.example.com\nINFO[0000] Outgoing request:\nGET /acs/api/v1/auth/providers HTTP/1.1\nHost: dcos.example.com\nUser-Agent: Go-http-client/1.1\nAccept-Encoding: gzip\n\nINFO[0000] Incoming response:\nHTTP/1.1 200 OK\nContent-Length: 531\nConnection: keep-alive\nContent-Type: application/json; charset=utf-8\nDate: Fri, 20 Apr 2018 13:28:19 GMT\nServer: openresty\n\n   PROVIDER ID                           AUTHENTICATION TYPE\n  dcos-users     Log in using a standard DC/OS user account (username\nand password)\n  dcos-services  Log in using a DC/OS service user account (username and\nprivate key)","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/75a74189c5a6a3ed0c336ef12d768d58f4b1817b"},{"sha":"1220b05ec048ec182defefa91614d4cc739ac71f","author":{"name":"Armand Grillet","email":"25d46a51a6c82fc53ca69a613ab205b38a8d5e15@outlook.com"},"message":"Fix golint issue.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/1220b05ec048ec182defefa91614d4cc739ac71f"},{"sha":"a41e417d9e73270752f5afd43fd79b7dcc840c9b","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Fix bad rebase\n\n- Use ctx.Logger() instead of ctx.Logger\n- Update an incorrect log message","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/a41e417d9e73270752f5afd43fd79b7dcc840c9b"},{"sha":"f4ae0f6ff0b37ec4a293edf27532dc86143a093f","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Move subcommands to their own packages\n\nOtherwise the directory will contain many files in the future,\nespecially once tests are added.\n\nHaving a single command per file still allows to quickly jump to a\ncommand code, but they are now in sub-packages.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/f4ae0f6ff0b37ec4a293edf27532dc86143a093f"},{"sha":"c2a8c856437327b8ea0f9080d4ddf517398b3d3e","author":{"name":"Armand Grillet","email":"25d46a51a6c82fc53ca69a613ab205b38a8d5e15@outlook.com"},"message":"Revert fix for golint issue.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/c2a8c856437327b8ea0f9080d4ddf517398b3d3e"},{"sha":"fa2f1140671c3bf9d59e8ea2de7119746f0a2ce6","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Print a clear error when no cluster is attached\n\nThis came-up multiple times, when running `dcos config set` commands and\nno cluster is currently attached, a stack trace is shown :\n\n  TypeError: join() argument must be str or bytes, not 'NoneType'\n\nThis change prevents that stack trace to be shown.\n\nhttps://jira.mesosphere.com/browse/COPS-2857\nhttps://jira.mesosphere.com/browse/DCOS_OSS-2319","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/fa2f1140671c3bf9d59e8ea2de7119746f0a2ce6"},{"sha":"7c66457a2c2a365cb6397c624c55396e614a086a","author":{"name":"Armand Grillet","email":"25d46a51a6c82fc53ca69a613ab205b38a8d5e15@outlook.com"},"message":"Update README and change file format to Markdown.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/7c66457a2c2a365cb6397c624c55396e614a086a"},{"sha":"0b9050d7a61ac6c5520df2c6ff1a2bf9608fff18","author":{"name":"Armand Grillet","email":"25d46a51a6c82fc53ca69a613ab205b38a8d5e15@outlook.com"},"message":"Changed order of types parsed by jsonitem.\n\nAn additional test has been added to test a feature that was failing\nbefore this commit: the update of an app field that is a JSON (e.g.\nthe environment variables of an app).","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/0b9050d7a61ac6c5520df2c6ff1a2bf9608fff18"},{"sha":"352f6bfc726ed270bf6b430fca134ae4bccc659b","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Support the auth header challenge to detect login providers (#1224)\n\n* [httpclient] add an option to set the ACS token\r\n\r\nThis option sets the ACS token for a given http client.\r\n\r\nOnce set, all requests made through the client will have their\r\nAuthorization header populated accordingly.\r\n\r\n* Extract some code to a new login package\r\n\r\nThis extracts some code from the `dcos auth list-providers` command to a\r\nnew login package.\r\n\r\nIn general commands should be thin wrappers/glue on top of packages.\r\n\r\n* Use WWW-Authenticate as a fallback to detect login providers\r\n\r\nThis implements the auth challenge in order to detect which login\r\nprovider is available. This method is useful when\r\n/acs/api/v1/auth/providers is not present.\r\n\r\nOutput example with DC/OS Open Source:\r\n\r\n  $ dcos auth list-providers http://dcos.example.com\r\n  PROVIDER ID                     AUTHENTICATION TYPE\r\n\r\n  dcos-oidc    Log in using OpenID Connect (Google, GitHub, or\r\nMicrosoft)","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/352f6bfc726ed270bf6b430fca134ae4bccc659b"},{"sha":"08fad2e425666a63cc9602f1785ef487c2203cad","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Use the idiomatic testdata folder for test fixtures\n\nAccording to `go help test`:\n\n  The go tool will ignore a directory named \"testdata\", making it\n  available to hold ancillary data needed by the tests.\n\nhttps://github.com/golang/go/issues/14715","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/08fad2e425666a63cc9602f1785ef487c2203cad"},{"sha":"efc177ca8e4f7485b7a0337a9f367ec1cf4126c9","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Add stdin to the environment\n\nIt is currently missing, we only have stdout and stderr.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/efc177ca8e4f7485b7a0337a9f367ec1cf4126c9"},{"sha":"9b6e8f86199942f55dabd975ca527c7ccaede624","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Add a prompt package\n\nThis package provides helpers to ask for interactive input. It currently\nsupports text input, password and choosing from a list.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/9b6e8f86199942f55dabd975ca527c7ccaede624"},{"sha":"d2c4211cacde56dd1f800781d43b2d5b5cfc07d8","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Create a custom map type for login providers\n\nAs Go randomizes iteration over maps, the `dcos auth list-providers`\ncurrently lists providers in an unstable order. This can be confusing\nand error-prone for users in some cases (eg. if we are printing a list\nto select from).\n\nThis introduces a custom type with a `Slice()` method returning the\nproviders in a constant order (sorted by ID).","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/d2c4211cacde56dd1f800781d43b2d5b5cfc07d8"},{"sha":"3260b75252ba560a9a6facdae99f23f7a239838a","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Add an open package\n\nIt allows to open files or URLs in user's preferred application. It is\nmainly useful to trigger auth flow in browsers.\n\nThis implementation is based on what\nhttps://github.com/skratchdot/open-golang does, except that it\nintroduces an interface and has logging capabilities.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/3260b75252ba560a9a6facdae99f23f7a239838a"},{"sha":"b337a22f1816d072e034322061687c1cf1c36ce8","author":{"name":"Ken Sipe","email":"470bc578162732ac7f9d387d34c4af4ca6e1b6f7@mesosphere.io"},"message":"job_run_id OR --all flag is required.  one or the other.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/b337a22f1816d072e034322061687c1cf1c36ce8"},{"sha":"fb0d3724623d991a38a6e23128fff0f40eb5d264","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Fix the context interface and use it in commands\n\nopen.Opener is an interface, this also updates commands to use the\ninterface so that other mistakes like this get detected, it would also\nallow to pass mocks during tests.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/fb0d3724623d991a38a6e23128fff0f40eb5d264"},{"sha":"83be2b92d1768827725fe7358815afe467a216f9","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Update Go to 1.10.2","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/83be2b92d1768827725fe7358815afe467a216f9"},{"sha":"d203ab0a24ea679053f57f5b8b01202dee1299bf","author":{"name":"Bilal Amarni","email":"35032ed22b4c97b634b8ca4b28bb6ea86a4ac100@gmail.com"},"message":"Implement `dcos auth login` (#1231)\n\n* Add jwt-go as a dependency\r\n\r\nIt will be used to generate a service login token from a service account\r\nprovate key.\r\n\r\n* Add login flags\r\n\r\nLogin flags are represented in a struct. They can be resolved, meaning\r\nthat the files they point to will be read (--password-file,\r\n--private-key), the --password-env flag would also be looked-up from the\r\nenvironment. Based on a resolved flag set, one can also check whether or\r\nnot there is an implicit login provider.\r\n\r\n* Introduce a login flow\r\n\r\nIt allows to initiate a login flow from a terminal, based on login flags\r\nand an HTTP client.\r\n\r\nThe flow has to first select a login provider, either explicitly,\r\nimplicitly, or manually. It then triggers its client-method. Finally,\r\nthe ACS token returned by DC/OS is stored in the current config file.\r\n\r\n* Add a `dcos auth login` command\r\n\r\nThis commands relies on the login flow and flags. There is also a helper\r\nmethod in the context to initiate a flow and start it.","distinct":true,"url":"https://api.github.com/repos/PTC-Global/dcos-cli/commits/d203ab0a24ea679053f57f5b8b01202dee1299bf"}]}
{"actor":{"display_login":"luisdavim"}}