{"action":"created","comment":{"url":"https://api.github.com/repos/uber-go/dosa/pulls/comments/185992067","pull_request_review_id":117495078,"id":185992067,"diff_hunk":"@@ -53,11 +54,15 @@ func (e *RegisteredEntity) SetVersion(v int32) {\n \n // EntityInfo is a helper for accessing the registered entity's EntityInfo\n // instance which is required by clients to call connector methods.\n-func (e *RegisteredEntity) EntityInfo() *EntityInfo {\n+func (e *RegisteredEntity) EntityInfo(dynTTL *time.Duration) *EntityInfo {","path":"registrar.go","position":13,"original_position":13,"commit_id":"0948431c30f7363c036e1e8834c7688cdeb671a1","original_commit_id":"0948431c30f7363c036e1e8834c7688cdeb671a1","user":{"login":"junchaowu","id":3731781,"avatar_url":"https://avatars3.githubusercontent.com/u/3731781?v=4","gravatar_id":"","url":"https://api.github.com/users/junchaowu","html_url":"https://github.com/junchaowu","followers_url":"https://api.github.com/users/junchaowu/followers","following_url":"https://api.github.com/users/junchaowu/following{/other_user}","gists_url":"https://api.github.com/users/junchaowu/gists{/gist_id}","starred_url":"https://api.github.com/users/junchaowu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junchaowu/subscriptions","organizations_url":"https://api.github.com/users/junchaowu/orgs","repos_url":"https://api.github.com/users/junchaowu/repos","events_url":"https://api.github.com/users/junchaowu/events{/privacy}","received_events_url":"https://api.github.com/users/junchaowu/received_events","type":"User","site_admin":false},"body":"Keep the original EntityInfo method interface. Change the TTL after you get the entityinfo instance since anyway the TTL is a public field.","created_at":"2018-05-04T05:12:14Z","updated_at":"2018-05-04T05:12:18Z","html_url":"https://github.com/uber-go/dosa/pull/323#discussion_r185992067","pull_request_url":"https://api.github.com/repos/uber-go/dosa/pulls/323","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber-go/dosa/pulls/comments/185992067"},"html":{"href":"https://github.com/uber-go/dosa/pull/323#discussion_r185992067"},"pull_request":{"href":"https://api.github.com/repos/uber-go/dosa/pulls/323"}}},"pull_request":{"url":"https://api.github.com/repos/uber-go/dosa/pulls/323","id":185594339,"html_url":"https://github.com/uber-go/dosa/pull/323","diff_url":"https://github.com/uber-go/dosa/pull/323.diff","patch_url":"https://github.com/uber-go/dosa/pull/323.patch","issue_url":"https://api.github.com/repos/uber-go/dosa/issues/323","number":323,"state":"open","locked":false,"title":"Per-Entity dynamic TTL support","user":{"login":"MaxJTRice","id":8112625,"avatar_url":"https://avatars3.githubusercontent.com/u/8112625?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxJTRice","html_url":"https://github.com/MaxJTRice","followers_url":"https://api.github.com/users/MaxJTRice/followers","following_url":"https://api.github.com/users/MaxJTRice/following{/other_user}","gists_url":"https://api.github.com/users/MaxJTRice/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxJTRice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxJTRice/subscriptions","organizations_url":"https://api.github.com/users/MaxJTRice/orgs","repos_url":"https://api.github.com/users/MaxJTRice/repos","events_url":"https://api.github.com/users/MaxJTRice/events{/privacy}","received_events_url":"https://api.github.com/users/MaxJTRice/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-03T00:32:31Z","updated_at":"2018-05-04T05:12:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78061f0b0d9bbdbd05cf3b230ba5c269cac7da0f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"klnusbaum","id":495570,"avatar_url":"https://avatars1.githubusercontent.com/u/495570?v=4","gravatar_id":"","url":"https://api.github.com/users/klnusbaum","html_url":"https://github.com/klnusbaum","followers_url":"https://api.github.com/users/klnusbaum/followers","following_url":"https://api.github.com/users/klnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/klnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/klnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klnusbaum/subscriptions","organizations_url":"https://api.github.com/users/klnusbaum/orgs","repos_url":"https://api.github.com/users/klnusbaum/repos","events_url":"https://api.github.com/users/klnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/klnusbaum/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber-go/dosa/pulls/323/commits","review_comments_url":"https://api.github.com/repos/uber-go/dosa/pulls/323/comments","review_comment_url":"https://api.github.com/repos/uber-go/dosa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber-go/dosa/issues/323/comments","statuses_url":"https://api.github.com/repos/uber-go/dosa/statuses/0948431c30f7363c036e1e8834c7688cdeb671a1","head":{"label":"uber-go:dynamic_ttl","ref":"dynamic_ttl","sha":"0948431c30f7363c036e1e8834c7688cdeb671a1","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars2.githubusercontent.com/u/19262598?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":77975785,"name":"dosa","full_name":"uber-go/dosa","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars2.githubusercontent.com/u/19262598?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/dosa","description":"DOSA is a data object abstraction layer","fork":false,"url":"https://api.github.com/repos/uber-go/dosa","forks_url":"https://api.github.com/repos/uber-go/dosa/forks","keys_url":"https://api.github.com/repos/uber-go/dosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/dosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/dosa/teams","hooks_url":"https://api.github.com/repos/uber-go/dosa/hooks","issue_events_url":"https://api.github.com/repos/uber-go/dosa/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/dosa/events","assignees_url":"https://api.github.com/repos/uber-go/dosa/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/dosa/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/dosa/tags","blobs_url":"https://api.github.com/repos/uber-go/dosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/dosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/dosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/dosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/dosa/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/dosa/languages","stargazers_url":"https://api.github.com/repos/uber-go/dosa/stargazers","contributors_url":"https://api.github.com/repos/uber-go/dosa/contributors","subscribers_url":"https://api.github.com/repos/uber-go/dosa/subscribers","subscription_url":"https://api.github.com/repos/uber-go/dosa/subscription","commits_url":"https://api.github.com/repos/uber-go/dosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/dosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/dosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/dosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/dosa/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/dosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/dosa/merges","archive_url":"https://api.github.com/repos/uber-go/dosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/dosa/downloads","issues_url":"https://api.github.com/repos/uber-go/dosa/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/dosa/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/dosa/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/dosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/dosa/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/dosa/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/dosa/deployments","created_at":"2017-01-04T03:10:40Z","updated_at":"2018-05-03T18:26:17Z","pushed_at":"2018-05-04T00:56:53Z","git_url":"git://github.com/uber-go/dosa.git","ssh_url":"git@github.com:uber-go/dosa.git","clone_url":"https://github.com/uber-go/dosa.git","svn_url":"https://github.com/uber-go/dosa","homepage":null,"size":10836,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":10,"watchers":59,"default_branch":"master"}},"base":{"label":"uber-go:v3","ref":"v3","sha":"a9171b8a345f883af14f6fde5953221345f56452","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars2.githubusercontent.com/u/19262598?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":77975785,"name":"dosa","full_name":"uber-go/dosa","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars2.githubusercontent.com/u/19262598?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/dosa","description":"DOSA is a data object abstraction layer","fork":false,"url":"https://api.github.com/repos/uber-go/dosa","forks_url":"https://api.github.com/repos/uber-go/dosa/forks","keys_url":"https://api.github.com/repos/uber-go/dosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/dosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/dosa/teams","hooks_url":"https://api.github.com/repos/uber-go/dosa/hooks","issue_events_url":"https://api.github.com/repos/uber-go/dosa/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/dosa/events","assignees_url":"https://api.github.com/repos/uber-go/dosa/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/dosa/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/dosa/tags","blobs_url":"https://api.github.com/repos/uber-go/dosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/dosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/dosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/dosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/dosa/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/dosa/languages","stargazers_url":"https://api.github.com/repos/uber-go/dosa/stargazers","contributors_url":"https://api.github.com/repos/uber-go/dosa/contributors","subscribers_url":"https://api.github.com/repos/uber-go/dosa/subscribers","subscription_url":"https://api.github.com/repos/uber-go/dosa/subscription","commits_url":"https://api.github.com/repos/uber-go/dosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/dosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/dosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/dosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/dosa/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/dosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/dosa/merges","archive_url":"https://api.github.com/repos/uber-go/dosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/dosa/downloads","issues_url":"https://api.github.com/repos/uber-go/dosa/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/dosa/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/dosa/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/dosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/dosa/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/dosa/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/dosa/deployments","created_at":"2017-01-04T03:10:40Z","updated_at":"2018-05-03T18:26:17Z","pushed_at":"2018-05-04T00:56:53Z","git_url":"git://github.com/uber-go/dosa.git","ssh_url":"git@github.com:uber-go/dosa.git","clone_url":"https://github.com/uber-go/dosa.git","svn_url":"https://github.com/uber-go/dosa","homepage":null,"size":10836,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":10,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber-go/dosa/pulls/323"},"html":{"href":"https://github.com/uber-go/dosa/pull/323"},"issue":{"href":"https://api.github.com/repos/uber-go/dosa/issues/323"},"comments":{"href":"https://api.github.com/repos/uber-go/dosa/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/uber-go/dosa/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/uber-go/dosa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber-go/dosa/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/uber-go/dosa/statuses/0948431c30f7363c036e1e8834c7688cdeb671a1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"junchaowu"}}