{"action":"closed","number":113,"pull_request":{"url":"https://api.github.com/repos/Workiva/w_module/pulls/113","id":193651613,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjUxNjEz","html_url":"https://github.com/Workiva/w_module/pull/113","diff_url":"https://github.com/Workiva/w_module/pull/113.diff","patch_url":"https://github.com/Workiva/w_module/pull/113.patch","issue_url":"https://api.github.com/repos/Workiva/w_module/issues/113","number":113,"state":"closed","locked":false,"title":"AF-1387 Remove dart:mirrors & SerializableModule","user":{"login":"robbecker-wf","id":6053699,"node_id":"MDQ6VXNlcjYwNTM2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6053699?v=4","gravatar_id":"","url":"https://api.github.com/users/robbecker-wf","html_url":"https://github.com/robbecker-wf","followers_url":"https://api.github.com/users/robbecker-wf/followers","following_url":"https://api.github.com/users/robbecker-wf/following{/other_user}","gists_url":"https://api.github.com/users/robbecker-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/robbecker-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbecker-wf/subscriptions","organizations_url":"https://api.github.com/users/robbecker-wf/orgs","repos_url":"https://api.github.com/users/robbecker-wf/repos","events_url":"https://api.github.com/users/robbecker-wf/events{/privacy}","received_events_url":"https://api.github.com/users/robbecker-wf/received_events","type":"User","site_admin":false},"body":"# Overview\r\nDart 2 removes dart:mirrors support when compiled to JS. So we're removing usage of dart:mirrors\r\nThis is a **breaking change** since it is a removal of multiple publicly exposed classes. \r\n\r\nThe only affected consumers are updated. (w_viewer and w_viewer_mobile.)\r\nPRs are https://github.com/Workiva/w_viewer/pull/528 and https://github.com/Workiva/w_viewer_mobile/pull/32\r\n\r\n### Release plan (remove breaking change risk)\r\n - [x] Review, merge, and tag w_viewer major version 9.0.0\r\n - [x] Consume w_viewer 9 in w_viewer_mobile\r\n - [x] Release w_viewer_mobile\r\n - [x] Release mobile apps\r\n\r\n### Remove dart:mirrors from product lines + unified (unblock dart 2)\r\n - [ ] Review, merge this PR\r\n - [ ] Tag w_module 2.0\r\n - [ ] Consume w_module 2.0 in all tier 1 projects","created_at":"2018-06-08T15:37:44Z","updated_at":"2018-09-13T22:30:01Z","closed_at":"2018-09-13T22:30:01Z","merged_at":"2018-09-13T22:30:01Z","merge_commit_sha":"67aada203304a31eddc56ef057964eae81b81785","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":457776009,"node_id":"MDU6TGFiZWw0NTc3NzYwMDk=","url":"https://api.github.com/repos/Workiva/w_module/labels/Merge%20Requirements%20Met","name":"Merge Requirements Met","color":"159818","default":false},{"id":616136520,"node_id":"MDU6TGFiZWw2MTYxMzY1MjA=","url":"https://api.github.com/repos/Workiva/w_module/labels/RM%20Ready","name":"RM Ready","color":"159818","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/w_module/pulls/113/commits","review_comments_url":"https://api.github.com/repos/Workiva/w_module/pulls/113/comments","review_comment_url":"https://api.github.com/repos/Workiva/w_module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/w_module/issues/113/comments","statuses_url":"https://api.github.com/repos/Workiva/w_module/statuses/f03559981cbe827207d4adb8f06969cc7e0b716c","head":{"label":"Workiva:remove_mirrors","ref":"remove_mirrors","sha":"f03559981cbe827207d4adb8f06969cc7e0b716c","user":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":36083980,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA4Mzk4MA==","name":"w_module","full_name":"Workiva/w_module","owner":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/w_module","description":null,"fork":false,"url":"https://api.github.com/repos/Workiva/w_module","forks_url":"https://api.github.com/repos/Workiva/w_module/forks","keys_url":"https://api.github.com/repos/Workiva/w_module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/w_module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/w_module/teams","hooks_url":"https://api.github.com/repos/Workiva/w_module/hooks","issue_events_url":"https://api.github.com/repos/Workiva/w_module/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/w_module/events","assignees_url":"https://api.github.com/repos/Workiva/w_module/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/w_module/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/w_module/tags","blobs_url":"https://api.github.com/repos/Workiva/w_module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/w_module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/w_module/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/w_module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/w_module/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/w_module/languages","stargazers_url":"https://api.github.com/repos/Workiva/w_module/stargazers","contributors_url":"https://api.github.com/repos/Workiva/w_module/contributors","subscribers_url":"https://api.github.com/repos/Workiva/w_module/subscribers","subscription_url":"https://api.github.com/repos/Workiva/w_module/subscription","commits_url":"https://api.github.com/repos/Workiva/w_module/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/w_module/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/w_module/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/w_module/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/w_module/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/w_module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/w_module/merges","archive_url":"https://api.github.com/repos/Workiva/w_module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/w_module/downloads","issues_url":"https://api.github.com/repos/Workiva/w_module/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/w_module/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/w_module/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/w_module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/w_module/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/w_module/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/w_module/deployments","created_at":"2015-05-22T16:51:11Z","updated_at":"2018-09-11T00:30:01Z","pushed_at":"2018-09-13T22:30:01Z","git_url":"git://github.com/Workiva/w_module.git","ssh_url":"git@github.com:Workiva/w_module.git","clone_url":"https://github.com/Workiva/w_module.git","svn_url":"https://github.com/Workiva/w_module","homepage":null,"size":741,"stargazers_count":9,"watchers_count":9,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":5,"watchers":9,"default_branch":"master"}},"base":{"label":"Workiva:2.0.0-wip","ref":"2.0.0-wip","sha":"e2976ab1aead047db6645cb426346aa931a63625","user":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":36083980,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA4Mzk4MA==","name":"w_module","full_name":"Workiva/w_module","owner":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/w_module","description":null,"fork":false,"url":"https://api.github.com/repos/Workiva/w_module","forks_url":"https://api.github.com/repos/Workiva/w_module/forks","keys_url":"https://api.github.com/repos/Workiva/w_module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/w_module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/w_module/teams","hooks_url":"https://api.github.com/repos/Workiva/w_module/hooks","issue_events_url":"https://api.github.com/repos/Workiva/w_module/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/w_module/events","assignees_url":"https://api.github.com/repos/Workiva/w_module/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/w_module/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/w_module/tags","blobs_url":"https://api.github.com/repos/Workiva/w_module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/w_module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/w_module/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/w_module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/w_module/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/w_module/languages","stargazers_url":"https://api.github.com/repos/Workiva/w_module/stargazers","contributors_url":"https://api.github.com/repos/Workiva/w_module/contributors","subscribers_url":"https://api.github.com/repos/Workiva/w_module/subscribers","subscription_url":"https://api.github.com/repos/Workiva/w_module/subscription","commits_url":"https://api.github.com/repos/Workiva/w_module/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/w_module/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/w_module/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/w_module/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/w_module/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/w_module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/w_module/merges","archive_url":"https://api.github.com/repos/Workiva/w_module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/w_module/downloads","issues_url":"https://api.github.com/repos/Workiva/w_module/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/w_module/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/w_module/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/w_module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/w_module/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/w_module/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/w_module/deployments","created_at":"2015-05-22T16:51:11Z","updated_at":"2018-09-11T00:30:01Z","pushed_at":"2018-09-13T22:30:01Z","git_url":"git://github.com/Workiva/w_module.git","ssh_url":"git@github.com:Workiva/w_module.git","clone_url":"https://github.com/Workiva/w_module.git","svn_url":"https://github.com/Workiva/w_module","homepage":null,"size":741,"stargazers_count":9,"watchers_count":9,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":5,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/w_module/pulls/113"},"html":{"href":"https://github.com/Workiva/w_module/pull/113"},"issue":{"href":"https://api.github.com/repos/Workiva/w_module/issues/113"},"comments":{"href":"https://api.github.com/repos/Workiva/w_module/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/w_module/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/w_module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/w_module/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/w_module/statuses/f03559981cbe827207d4adb8f06969cc7e0b716c"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rmconsole4-wk","id":38507511,"node_id":"MDQ6VXNlcjM4NTA3NTEx","avatar_url":"https://avatars2.githubusercontent.com/u/38507511?v=4","gravatar_id":"","url":"https://api.github.com/users/rmconsole4-wk","html_url":"https://github.com/rmconsole4-wk","followers_url":"https://api.github.com/users/rmconsole4-wk/followers","following_url":"https://api.github.com/users/rmconsole4-wk/following{/other_user}","gists_url":"https://api.github.com/users/rmconsole4-wk/gists{/gist_id}","starred_url":"https://api.github.com/users/rmconsole4-wk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmconsole4-wk/subscriptions","organizations_url":"https://api.github.com/users/rmconsole4-wk/orgs","repos_url":"https://api.github.com/users/rmconsole4-wk/repos","events_url":"https://api.github.com/users/rmconsole4-wk/events{/privacy}","received_events_url":"https://api.github.com/users/rmconsole4-wk/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":2,"deletions":640,"changed_files":4}}
{"actor":{"display_login":"rmconsole4-wk"}}