{"action":"created","comment":{"url":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/comments/218682743","pull_request_review_id":156672766,"id":218682743,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODY4Mjc0Mw==","diff_hunk":"@@ -101,7 +101,7 @@ set(BUILD_FLAGS \"${BUILD_FLAGS} -Wold-style-cast\")\n set(BUILD_FLAGS \"${BUILD_FLAGS} -Woverloaded-virtual\")\n set(BUILD_FLAGS \"${BUILD_FLAGS} -Wswitch\")\n set(BUILD_FLAGS \"${BUILD_FLAGS} -Wunreachable-code\")\n-set(BUILD_FLAGS \"${BUILD_FLAGS} -pedantic -pedantic-errors\")\n+set(BUILD_FLAGS \"${BUILD_FLAGS} -pedantic\")","path":"node/CMakeLists.txt","position":5,"original_position":5,"commit_id":"412b88c535785ae4b1944a31f9f62ef5103317c4","original_commit_id":"52c04517efba078bc4e96faa67cab2f9a2e7a0ad","user":{"login":"shaitan","id":446423,"node_id":"MDQ6VXNlcjQ0NjQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/446423?v=4","gravatar_id":"","url":"https://api.github.com/users/shaitan","html_url":"https://github.com/shaitan","followers_url":"https://api.github.com/users/shaitan/followers","following_url":"https://api.github.com/users/shaitan/following{/other_user}","gists_url":"https://api.github.com/users/shaitan/gists{/gist_id}","starred_url":"https://api.github.com/users/shaitan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaitan/subscriptions","organizations_url":"https://api.github.com/users/shaitan/orgs","repos_url":"https://api.github.com/users/shaitan/repos","events_url":"https://api.github.com/users/shaitan/events{/privacy}","received_events_url":"https://api.github.com/users/shaitan/received_events","type":"User","site_admin":false},"body":"Why did you remove `-pedantic-errors`?","created_at":"2018-09-19T06:37:16Z","updated_at":"2018-09-19T06:37:17Z","html_url":"https://github.com/interiorem/cocaine-plugins/pull/33#discussion_r218682743","pull_request_url":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/33","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/comments/218682743"},"html":{"href":"https://github.com/interiorem/cocaine-plugins/pull/33#discussion_r218682743"},"pull_request":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/33","id":215586925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTg2OTI1","html_url":"https://github.com/interiorem/cocaine-plugins/pull/33","diff_url":"https://github.com/interiorem/cocaine-plugins/pull/33.diff","patch_url":"https://github.com/interiorem/cocaine-plugins/pull/33.patch","issue_url":"https://api.github.com/repos/interiorem/cocaine-plugins/issues/33","number":33,"state":"open","locked":false,"title":"Fix: external connect crash","user":{"login":"karitra","id":391972,"node_id":"MDQ6VXNlcjM5MTk3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/391972?v=4","gravatar_id":"","url":"https://api.github.com/users/karitra","html_url":"https://github.com/karitra","followers_url":"https://api.github.com/users/karitra/followers","following_url":"https://api.github.com/users/karitra/following{/other_user}","gists_url":"https://api.github.com/users/karitra/gists{/gist_id}","starred_url":"https://api.github.com/users/karitra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karitra/subscriptions","organizations_url":"https://api.github.com/users/karitra/orgs","repos_url":"https://api.github.com/users/karitra/repos","events_url":"https://api.github.com/users/karitra/events{/privacy}","received_events_url":"https://api.github.com/users/karitra/received_events","type":"User","site_admin":false},"body":"There is two async. handlers in `external_t::inner_t::connect`, one for connection, another for connection timeout, latter cancel's the socket, which happen to be unique pointer, the former cancels the timer and resets socket to null on error. But according to the `boost::deadline_timer` [documentation](https://www.boost.org/doc/libs/1_46_1/doc/html/boost_asio/reference/basic_deadline_timer/cancel/overload1.html#boost_asio.reference.basic_deadline_timer.cancel.overload1.remarks)\r\n\r\n```\r\nRemarks\r\n\r\nIf the timer has already expired when cancel() is called, then the handlers for asynchronous wait operations will:\r\n\r\n  -   have already been invoked; or\r\n  -   have been queued for invocation in the near future.\r\n\r\nThese handlers can no longer be cancelled, and therefore are passed an error code that indicates the successful completion of the wait operation. \r\n\r\n```\r\n\r\n### TODO:\r\n - [x] description of race.\r\n - [x] basic testing.","created_at":"2018-09-14T13:01:23Z","updated_at":"2018-09-19T06:37:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0749022c607e35a9a50626bdc482464a32b64947","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kletkavrubashku","id":13156550,"node_id":"MDQ6VXNlcjEzMTU2NTUw","avatar_url":"https://avatars0.githubusercontent.com/u/13156550?v=4","gravatar_id":"","url":"https://api.github.com/users/kletkavrubashku","html_url":"https://github.com/kletkavrubashku","followers_url":"https://api.github.com/users/kletkavrubashku/followers","following_url":"https://api.github.com/users/kletkavrubashku/following{/other_user}","gists_url":"https://api.github.com/users/kletkavrubashku/gists{/gist_id}","starred_url":"https://api.github.com/users/kletkavrubashku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kletkavrubashku/subscriptions","organizations_url":"https://api.github.com/users/kletkavrubashku/orgs","repos_url":"https://api.github.com/users/kletkavrubashku/repos","events_url":"https://api.github.com/users/kletkavrubashku/events{/privacy}","received_events_url":"https://api.github.com/users/kletkavrubashku/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/33/commits","review_comments_url":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/33/comments","review_comment_url":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interiorem/cocaine-plugins/issues/33/comments","statuses_url":"https://api.github.com/repos/interiorem/cocaine-plugins/statuses/412b88c535785ae4b1944a31f9f62ef5103317c4","head":{"label":"karitra:pr/fix/external_connect_crash","ref":"pr/fix/external_connect_crash","sha":"412b88c535785ae4b1944a31f9f62ef5103317c4","user":{"login":"karitra","id":391972,"node_id":"MDQ6VXNlcjM5MTk3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/391972?v=4","gravatar_id":"","url":"https://api.github.com/users/karitra","html_url":"https://github.com/karitra","followers_url":"https://api.github.com/users/karitra/followers","following_url":"https://api.github.com/users/karitra/following{/other_user}","gists_url":"https://api.github.com/users/karitra/gists{/gist_id}","starred_url":"https://api.github.com/users/karitra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karitra/subscriptions","organizations_url":"https://api.github.com/users/karitra/orgs","repos_url":"https://api.github.com/users/karitra/repos","events_url":"https://api.github.com/users/karitra/events{/privacy}","received_events_url":"https://api.github.com/users/karitra/received_events","type":"User","site_admin":false},"repo":{"id":78533847,"node_id":"MDEwOlJlcG9zaXRvcnk3ODUzMzg0Nw==","name":"cocaine-plugins","full_name":"karitra/cocaine-plugins","private":false,"owner":{"login":"karitra","id":391972,"node_id":"MDQ6VXNlcjM5MTk3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/391972?v=4","gravatar_id":"","url":"https://api.github.com/users/karitra","html_url":"https://github.com/karitra","followers_url":"https://api.github.com/users/karitra/followers","following_url":"https://api.github.com/users/karitra/following{/other_user}","gists_url":"https://api.github.com/users/karitra/gists{/gist_id}","starred_url":"https://api.github.com/users/karitra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karitra/subscriptions","organizations_url":"https://api.github.com/users/karitra/orgs","repos_url":"https://api.github.com/users/karitra/repos","events_url":"https://api.github.com/users/karitra/events{/privacy}","received_events_url":"https://api.github.com/users/karitra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/karitra/cocaine-plugins","description":"Cocaine Plugins","fork":true,"url":"https://api.github.com/repos/karitra/cocaine-plugins","forks_url":"https://api.github.com/repos/karitra/cocaine-plugins/forks","keys_url":"https://api.github.com/repos/karitra/cocaine-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karitra/cocaine-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karitra/cocaine-plugins/teams","hooks_url":"https://api.github.com/repos/karitra/cocaine-plugins/hooks","issue_events_url":"https://api.github.com/repos/karitra/cocaine-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/karitra/cocaine-plugins/events","assignees_url":"https://api.github.com/repos/karitra/cocaine-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/karitra/cocaine-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/karitra/cocaine-plugins/tags","blobs_url":"https://api.github.com/repos/karitra/cocaine-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karitra/cocaine-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karitra/cocaine-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/karitra/cocaine-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karitra/cocaine-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/karitra/cocaine-plugins/languages","stargazers_url":"https://api.github.com/repos/karitra/cocaine-plugins/stargazers","contributors_url":"https://api.github.com/repos/karitra/cocaine-plugins/contributors","subscribers_url":"https://api.github.com/repos/karitra/cocaine-plugins/subscribers","subscription_url":"https://api.github.com/repos/karitra/cocaine-plugins/subscription","commits_url":"https://api.github.com/repos/karitra/cocaine-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/karitra/cocaine-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/karitra/cocaine-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/karitra/cocaine-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/karitra/cocaine-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/karitra/cocaine-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karitra/cocaine-plugins/merges","archive_url":"https://api.github.com/repos/karitra/cocaine-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karitra/cocaine-plugins/downloads","issues_url":"https://api.github.com/repos/karitra/cocaine-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/karitra/cocaine-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/karitra/cocaine-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/karitra/cocaine-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karitra/cocaine-plugins/labels{/name}","releases_url":"https://api.github.com/repos/karitra/cocaine-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/karitra/cocaine-plugins/deployments","created_at":"2017-01-10T12:59:26Z","updated_at":"2017-01-10T12:59:29Z","pushed_at":"2018-09-18T17:07:24Z","git_url":"git://github.com/karitra/cocaine-plugins.git","ssh_url":"git@github.com:karitra/cocaine-plugins.git","clone_url":"https://github.com/karitra/cocaine-plugins.git","svn_url":"https://github.com/karitra/cocaine-plugins","homepage":null,"size":2933,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0.12.10"}},"base":{"label":"interiorem:v0.12.14","ref":"v0.12.14","sha":"9d3a5701095b69bd06a05059184b89723fdba016","user":{"login":"interiorem","id":17122620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTIyNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/17122620?v=4","gravatar_id":"","url":"https://api.github.com/users/interiorem","html_url":"https://github.com/interiorem","followers_url":"https://api.github.com/users/interiorem/followers","following_url":"https://api.github.com/users/interiorem/following{/other_user}","gists_url":"https://api.github.com/users/interiorem/gists{/gist_id}","starred_url":"https://api.github.com/users/interiorem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interiorem/subscriptions","organizations_url":"https://api.github.com/users/interiorem/orgs","repos_url":"https://api.github.com/users/interiorem/repos","events_url":"https://api.github.com/users/interiorem/events{/privacy}","received_events_url":"https://api.github.com/users/interiorem/received_events","type":"Organization","site_admin":false},"repo":{"id":133667324,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM2NjczMjQ=","name":"cocaine-plugins","full_name":"interiorem/cocaine-plugins","private":false,"owner":{"login":"interiorem","id":17122620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTIyNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/17122620?v=4","gravatar_id":"","url":"https://api.github.com/users/interiorem","html_url":"https://github.com/interiorem","followers_url":"https://api.github.com/users/interiorem/followers","following_url":"https://api.github.com/users/interiorem/following{/other_user}","gists_url":"https://api.github.com/users/interiorem/gists{/gist_id}","starred_url":"https://api.github.com/users/interiorem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interiorem/subscriptions","organizations_url":"https://api.github.com/users/interiorem/orgs","repos_url":"https://api.github.com/users/interiorem/repos","events_url":"https://api.github.com/users/interiorem/events{/privacy}","received_events_url":"https://api.github.com/users/interiorem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/interiorem/cocaine-plugins","description":"Cocaine Plugins","fork":true,"url":"https://api.github.com/repos/interiorem/cocaine-plugins","forks_url":"https://api.github.com/repos/interiorem/cocaine-plugins/forks","keys_url":"https://api.github.com/repos/interiorem/cocaine-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interiorem/cocaine-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interiorem/cocaine-plugins/teams","hooks_url":"https://api.github.com/repos/interiorem/cocaine-plugins/hooks","issue_events_url":"https://api.github.com/repos/interiorem/cocaine-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/interiorem/cocaine-plugins/events","assignees_url":"https://api.github.com/repos/interiorem/cocaine-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/interiorem/cocaine-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/interiorem/cocaine-plugins/tags","blobs_url":"https://api.github.com/repos/interiorem/cocaine-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interiorem/cocaine-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interiorem/cocaine-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/interiorem/cocaine-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interiorem/cocaine-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/interiorem/cocaine-plugins/languages","stargazers_url":"https://api.github.com/repos/interiorem/cocaine-plugins/stargazers","contributors_url":"https://api.github.com/repos/interiorem/cocaine-plugins/contributors","subscribers_url":"https://api.github.com/repos/interiorem/cocaine-plugins/subscribers","subscription_url":"https://api.github.com/repos/interiorem/cocaine-plugins/subscription","commits_url":"https://api.github.com/repos/interiorem/cocaine-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/interiorem/cocaine-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/interiorem/cocaine-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/interiorem/cocaine-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/interiorem/cocaine-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/interiorem/cocaine-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interiorem/cocaine-plugins/merges","archive_url":"https://api.github.com/repos/interiorem/cocaine-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interiorem/cocaine-plugins/downloads","issues_url":"https://api.github.com/repos/interiorem/cocaine-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/interiorem/cocaine-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/interiorem/cocaine-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interiorem/cocaine-plugins/labels{/name}","releases_url":"https://api.github.com/repos/interiorem/cocaine-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/interiorem/cocaine-plugins/deployments","created_at":"2018-05-16T13:08:36Z","updated_at":"2018-09-06T13:34:34Z","pushed_at":"2018-09-18T17:07:25Z","git_url":"git://github.com/interiorem/cocaine-plugins.git","ssh_url":"git@github.com:interiorem/cocaine-plugins.git","clone_url":"https://github.com/interiorem/cocaine-plugins.git","svn_url":"https://github.com/interiorem/cocaine-plugins","homepage":null,"size":2890,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"v0.12.14"}},"_links":{"self":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/33"},"html":{"href":"https://github.com/interiorem/cocaine-plugins/pull/33"},"issue":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/issues/33"},"comments":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/interiorem/cocaine-plugins/statuses/412b88c535785ae4b1944a31f9f62ef5103317c4"}},"author_association":"NONE"}}
{"actor":{"display_login":"shaitan"}}