{"action":"created","comment":{"url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/comments/230968421","pull_request_review_id":171826406,"id":230968421,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDk2ODQyMQ==","diff_hunk":"@@ -83,6 +83,30 @@ function RNCSConcatAddressDAP(infos) {\n   return address\n }\n \n+function concatNames (firstName, lastName, otherLastName) {\n+  let first, last = ''\n+  \n+  if (lastName) {\n+    last = lastName.toUpperCase()\n+  } else if (otherLastName) {\n+    last = otherLastName.toUpperCase()\n+  } else {\n+    return ''\n+  }\n+\n+  if (firstName) {\n+    first = firstName.capitalize()\n+  }\n+\n+  return `${first} ${last}`\n+}\n+\n+String.prototype.capitalize = function() {\n+  return this.toLowerCase().replace( /(?:^|[^\\wà-öø-ÿ])[\\wà-öø-ÿ]/g, function (match) {\n+    return match.toUpperCase();\n+  })\n+}","path":"src/components/mixins/formating.js","position":26,"original_position":26,"commit_id":"af7f891a2e073ff72b8386cb139c2b103c254457","original_commit_id":"af7f891a2e073ff72b8386cb139c2b103c254457","user":{"login":"Samuelfaure","id":14159757,"node_id":"MDQ6VXNlcjE0MTU5NzU3","avatar_url":"https://avatars2.githubusercontent.com/u/14159757?v=4","gravatar_id":"","url":"https://api.github.com/users/Samuelfaure","html_url":"https://github.com/Samuelfaure","followers_url":"https://api.github.com/users/Samuelfaure/followers","following_url":"https://api.github.com/users/Samuelfaure/following{/other_user}","gists_url":"https://api.github.com/users/Samuelfaure/gists{/gist_id}","starred_url":"https://api.github.com/users/Samuelfaure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samuelfaure/subscriptions","organizations_url":"https://api.github.com/users/Samuelfaure/orgs","repos_url":"https://api.github.com/users/Samuelfaure/repos","events_url":"https://api.github.com/users/Samuelfaure/events{/privacy}","received_events_url":"https://api.github.com/users/Samuelfaure/received_events","type":"User","site_admin":false},"body":"I dont get this part but i trust you about it","created_at":"2018-11-06T00:52:22Z","updated_at":"2018-11-06T00:52:29Z","html_url":"https://github.com/etalab/entreprise.data.gouv.fr/pull/222#discussion_r230968421","pull_request_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/222","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/comments/230968421"},"html":{"href":"https://github.com/etalab/entreprise.data.gouv.fr/pull/222#discussion_r230968421"},"pull_request":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/222"}}},"pull_request":{"url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/222","id":228538465,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTM4NDY1","html_url":"https://github.com/etalab/entreprise.data.gouv.fr/pull/222","diff_url":"https://github.com/etalab/entreprise.data.gouv.fr/pull/222.diff","patch_url":"https://github.com/etalab/entreprise.data.gouv.fr/pull/222.patch","issue_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/issues/222","number":222,"state":"open","locked":false,"title":"concatenate names, capitalize first name and uppercase last name","user":{"login":"thimy","id":1301085,"node_id":"MDQ6VXNlcjEzMDEwODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1301085?v=4","gravatar_id":"","url":"https://api.github.com/users/thimy","html_url":"https://github.com/thimy","followers_url":"https://api.github.com/users/thimy/followers","following_url":"https://api.github.com/users/thimy/following{/other_user}","gists_url":"https://api.github.com/users/thimy/gists{/gist_id}","starred_url":"https://api.github.com/users/thimy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thimy/subscriptions","organizations_url":"https://api.github.com/users/thimy/orgs","repos_url":"https://api.github.com/users/thimy/repos","events_url":"https://api.github.com/users/thimy/events{/privacy}","received_events_url":"https://api.github.com/users/thimy/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/1301085/48035422-2051a180-e164-11e8-8143-f029dcaaf86b.png)\r\n","created_at":"2018-11-06T00:34:48Z","updated_at":"2018-11-06T00:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52eb76a272e16d26927cb6c5836db5e9a45c21ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/222/commits","review_comments_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/222/comments","review_comment_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/issues/222/comments","statuses_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/statuses/af7f891a2e073ff72b8386cb139c2b103c254457","head":{"label":"thimy:concat-names","ref":"concat-names","sha":"af7f891a2e073ff72b8386cb139c2b103c254457","user":{"login":"thimy","id":1301085,"node_id":"MDQ6VXNlcjEzMDEwODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1301085?v=4","gravatar_id":"","url":"https://api.github.com/users/thimy","html_url":"https://github.com/thimy","followers_url":"https://api.github.com/users/thimy/followers","following_url":"https://api.github.com/users/thimy/following{/other_user}","gists_url":"https://api.github.com/users/thimy/gists{/gist_id}","starred_url":"https://api.github.com/users/thimy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thimy/subscriptions","organizations_url":"https://api.github.com/users/thimy/orgs","repos_url":"https://api.github.com/users/thimy/repos","events_url":"https://api.github.com/users/thimy/events{/privacy}","received_events_url":"https://api.github.com/users/thimy/received_events","type":"User","site_admin":false},"repo":{"id":95562081,"node_id":"MDEwOlJlcG9zaXRvcnk5NTU2MjA4MQ==","name":"sirene_as_api_front","full_name":"thimy/sirene_as_api_front","private":false,"owner":{"login":"thimy","id":1301085,"node_id":"MDQ6VXNlcjEzMDEwODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1301085?v=4","gravatar_id":"","url":"https://api.github.com/users/thimy","html_url":"https://github.com/thimy","followers_url":"https://api.github.com/users/thimy/followers","following_url":"https://api.github.com/users/thimy/following{/other_user}","gists_url":"https://api.github.com/users/thimy/gists{/gist_id}","starred_url":"https://api.github.com/users/thimy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thimy/subscriptions","organizations_url":"https://api.github.com/users/thimy/orgs","repos_url":"https://api.github.com/users/thimy/repos","events_url":"https://api.github.com/users/thimy/events{/privacy}","received_events_url":"https://api.github.com/users/thimy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thimy/sirene_as_api_front","description":"Front-end pour l'API sirene","fork":true,"url":"https://api.github.com/repos/thimy/sirene_as_api_front","forks_url":"https://api.github.com/repos/thimy/sirene_as_api_front/forks","keys_url":"https://api.github.com/repos/thimy/sirene_as_api_front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thimy/sirene_as_api_front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thimy/sirene_as_api_front/teams","hooks_url":"https://api.github.com/repos/thimy/sirene_as_api_front/hooks","issue_events_url":"https://api.github.com/repos/thimy/sirene_as_api_front/issues/events{/number}","events_url":"https://api.github.com/repos/thimy/sirene_as_api_front/events","assignees_url":"https://api.github.com/repos/thimy/sirene_as_api_front/assignees{/user}","branches_url":"https://api.github.com/repos/thimy/sirene_as_api_front/branches{/branch}","tags_url":"https://api.github.com/repos/thimy/sirene_as_api_front/tags","blobs_url":"https://api.github.com/repos/thimy/sirene_as_api_front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thimy/sirene_as_api_front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thimy/sirene_as_api_front/git/refs{/sha}","trees_url":"https://api.github.com/repos/thimy/sirene_as_api_front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thimy/sirene_as_api_front/statuses/{sha}","languages_url":"https://api.github.com/repos/thimy/sirene_as_api_front/languages","stargazers_url":"https://api.github.com/repos/thimy/sirene_as_api_front/stargazers","contributors_url":"https://api.github.com/repos/thimy/sirene_as_api_front/contributors","subscribers_url":"https://api.github.com/repos/thimy/sirene_as_api_front/subscribers","subscription_url":"https://api.github.com/repos/thimy/sirene_as_api_front/subscription","commits_url":"https://api.github.com/repos/thimy/sirene_as_api_front/commits{/sha}","git_commits_url":"https://api.github.com/repos/thimy/sirene_as_api_front/git/commits{/sha}","comments_url":"https://api.github.com/repos/thimy/sirene_as_api_front/comments{/number}","issue_comment_url":"https://api.github.com/repos/thimy/sirene_as_api_front/issues/comments{/number}","contents_url":"https://api.github.com/repos/thimy/sirene_as_api_front/contents/{+path}","compare_url":"https://api.github.com/repos/thimy/sirene_as_api_front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thimy/sirene_as_api_front/merges","archive_url":"https://api.github.com/repos/thimy/sirene_as_api_front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thimy/sirene_as_api_front/downloads","issues_url":"https://api.github.com/repos/thimy/sirene_as_api_front/issues{/number}","pulls_url":"https://api.github.com/repos/thimy/sirene_as_api_front/pulls{/number}","milestones_url":"https://api.github.com/repos/thimy/sirene_as_api_front/milestones{/number}","notifications_url":"https://api.github.com/repos/thimy/sirene_as_api_front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thimy/sirene_as_api_front/labels{/name}","releases_url":"https://api.github.com/repos/thimy/sirene_as_api_front/releases{/id}","deployments_url":"https://api.github.com/repos/thimy/sirene_as_api_front/deployments","created_at":"2017-06-27T13:37:28Z","updated_at":"2018-08-30T04:07:27Z","pushed_at":"2018-11-06T00:33:12Z","git_url":"git://github.com/thimy/sirene_as_api_front.git","ssh_url":"git@github.com:thimy/sirene_as_api_front.git","clone_url":"https://github.com/thimy/sirene_as_api_front.git","svn_url":"https://github.com/thimy/sirene_as_api_front","homepage":null,"size":4459,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"etalab:develop","ref":"develop","sha":"4afdc8d9a4f0c876a55c3b4c1249d9e637ee5ee4","user":{"login":"etalab","id":5313610,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTM2MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5313610?v=4","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"repo":{"id":94540491,"node_id":"MDEwOlJlcG9zaXRvcnk5NDU0MDQ5MQ==","name":"entreprise.data.gouv.fr","full_name":"etalab/entreprise.data.gouv.fr","private":false,"owner":{"login":"etalab","id":5313610,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTM2MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5313610?v=4","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/etalab/entreprise.data.gouv.fr","description":"Front-end pour les API open-data, notamment Sirene et RNA","fork":false,"url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr","forks_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/forks","keys_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/teams","hooks_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/hooks","issue_events_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/issues/events{/number}","events_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/events","assignees_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/assignees{/user}","branches_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/branches{/branch}","tags_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/tags","blobs_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/languages","stargazers_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/stargazers","contributors_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/contributors","subscribers_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/subscribers","subscription_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/subscription","commits_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/contents/{+path}","compare_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/merges","archive_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/downloads","issues_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/issues{/number}","pulls_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/labels{/name}","releases_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/releases{/id}","deployments_url":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/deployments","created_at":"2017-06-16T12:10:17Z","updated_at":"2018-10-23T09:04:45Z","pushed_at":"2018-11-06T00:34:48Z","git_url":"git://github.com/etalab/entreprise.data.gouv.fr.git","ssh_url":"git@github.com:etalab/entreprise.data.gouv.fr.git","clone_url":"https://github.com/etalab/entreprise.data.gouv.fr.git","svn_url":"https://github.com/etalab/entreprise.data.gouv.fr","homepage":"https://entreprise.data.gouv.fr/","size":4475,"stargazers_count":4,"watchers_count":4,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/222"},"html":{"href":"https://github.com/etalab/entreprise.data.gouv.fr/pull/222"},"issue":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/issues/222"},"comments":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/etalab/entreprise.data.gouv.fr/statuses/af7f891a2e073ff72b8386cb139c2b103c254457"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Samuelfaure"}}