{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/brainix/bloom-filter/pulls/18","id":161595133,"html_url":"https://github.com/brainix/bloom-filter/pull/18","diff_url":"https://github.com/brainix/bloom-filter/pull/18.diff","patch_url":"https://github.com/brainix/bloom-filter/pull/18.patch","issue_url":"https://api.github.com/repos/brainix/bloom-filter/issues/18","number":18,"state":"closed","locked":false,"title":"Implement Memcached RecentlyConsumed as set/deque","user":{"login":"brainix","id":1017698,"avatar_url":"https://avatars2.githubusercontent.com/u/1017698?v=4","gravatar_id":"","url":"https://api.github.com/users/brainix","html_url":"https://github.com/brainix","followers_url":"https://api.github.com/users/brainix/followers","following_url":"https://api.github.com/users/brainix/following{/other_user}","gists_url":"https://api.github.com/users/brainix/gists{/gist_id}","starred_url":"https://api.github.com/users/brainix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainix/subscriptions","organizations_url":"https://api.github.com/users/brainix/orgs","repos_url":"https://api.github.com/users/brainix/repos","events_url":"https://api.github.com/users/brainix/events{/privacy}","received_events_url":"https://api.github.com/users/brainix/received_events","type":"User","site_admin":false},"body":"On the consumer side, we want a data structure similar to a\r\n`collections.deque` (as we're appending a user's new consumed links to\r\nthe right and popping old consumed links from the left).  But on the\r\nlisting service side, we want a data structure similar to a `set` (as\r\nwe're testing many candidate links for membership within the user's\r\n`RecentlyConsumed`).\r\n\r\nTherefore, `RecentlyConsumed` (persisted in Memcache) implements a\r\nsubset of the `collections.deque` API and a subset of the `set` API.  As\r\nsuch, please note that `RecentlyConsumed` silently ignores duplicate\r\nvalues during `append()` and `extend()`.\r\n\r\nFurther, please note that `RecentlyConsumed` is neither thread-safe nor\r\nsafe to use across instances.  Please lock around your\r\n`RecentlyConsumed` instances/accesses.  A good choice for such a lock is\r\n[`.memlock.MemLock`](https://github.com/brainix/bloom-filter/pull/17).","created_at":"2018-01-08T10:13:52Z","updated_at":"2018-05-25T00:02:03Z","closed_at":"2018-05-25T00:02:03Z","merged_at":"2018-05-25T00:02:03Z","merge_commit_sha":"affd787cec3804fb806146eb464f77f37ed5b85e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brainix/bloom-filter/pulls/18/commits","review_comments_url":"https://api.github.com/repos/brainix/bloom-filter/pulls/18/comments","review_comment_url":"https://api.github.com/repos/brainix/bloom-filter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brainix/bloom-filter/issues/18/comments","statuses_url":"https://api.github.com/repos/brainix/bloom-filter/statuses/0713e523ad8a34cc9bbae701254a96fc544e39ac","head":{"label":"brainix:set-deque","ref":"set-deque","sha":"0713e523ad8a34cc9bbae701254a96fc544e39ac","user":{"login":"brainix","id":1017698,"avatar_url":"https://avatars2.githubusercontent.com/u/1017698?v=4","gravatar_id":"","url":"https://api.github.com/users/brainix","html_url":"https://github.com/brainix","followers_url":"https://api.github.com/users/brainix/followers","following_url":"https://api.github.com/users/brainix/following{/other_user}","gists_url":"https://api.github.com/users/brainix/gists{/gist_id}","starred_url":"https://api.github.com/users/brainix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainix/subscriptions","organizations_url":"https://api.github.com/users/brainix/orgs","repos_url":"https://api.github.com/users/brainix/repos","events_url":"https://api.github.com/users/brainix/events{/privacy}","received_events_url":"https://api.github.com/users/brainix/received_events","type":"User","site_admin":false},"repo":{"id":115407018,"name":"bloom-filter","full_name":"brainix/bloom-filter","owner":{"login":"brainix","id":1017698,"avatar_url":"https://avatars2.githubusercontent.com/u/1017698?v=4","gravatar_id":"","url":"https://api.github.com/users/brainix","html_url":"https://github.com/brainix","followers_url":"https://api.github.com/users/brainix/followers","following_url":"https://api.github.com/users/brainix/following{/other_user}","gists_url":"https://api.github.com/users/brainix/gists{/gist_id}","starred_url":"https://api.github.com/users/brainix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainix/subscriptions","organizations_url":"https://api.github.com/users/brainix/orgs","repos_url":"https://api.github.com/users/brainix/repos","events_url":"https://api.github.com/users/brainix/events{/privacy}","received_events_url":"https://api.github.com/users/brainix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brainix/bloom-filter","description":"Prototype of how we can use a Bloom filter for @reddit's recently consumed feature.","fork":false,"url":"https://api.github.com/repos/brainix/bloom-filter","forks_url":"https://api.github.com/repos/brainix/bloom-filter/forks","keys_url":"https://api.github.com/repos/brainix/bloom-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brainix/bloom-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brainix/bloom-filter/teams","hooks_url":"https://api.github.com/repos/brainix/bloom-filter/hooks","issue_events_url":"https://api.github.com/repos/brainix/bloom-filter/issues/events{/number}","events_url":"https://api.github.com/repos/brainix/bloom-filter/events","assignees_url":"https://api.github.com/repos/brainix/bloom-filter/assignees{/user}","branches_url":"https://api.github.com/repos/brainix/bloom-filter/branches{/branch}","tags_url":"https://api.github.com/repos/brainix/bloom-filter/tags","blobs_url":"https://api.github.com/repos/brainix/bloom-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brainix/bloom-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brainix/bloom-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/brainix/bloom-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brainix/bloom-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/brainix/bloom-filter/languages","stargazers_url":"https://api.github.com/repos/brainix/bloom-filter/stargazers","contributors_url":"https://api.github.com/repos/brainix/bloom-filter/contributors","subscribers_url":"https://api.github.com/repos/brainix/bloom-filter/subscribers","subscription_url":"https://api.github.com/repos/brainix/bloom-filter/subscription","commits_url":"https://api.github.com/repos/brainix/bloom-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/brainix/bloom-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/brainix/bloom-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/brainix/bloom-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/brainix/bloom-filter/contents/{+path}","compare_url":"https://api.github.com/repos/brainix/bloom-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brainix/bloom-filter/merges","archive_url":"https://api.github.com/repos/brainix/bloom-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brainix/bloom-filter/downloads","issues_url":"https://api.github.com/repos/brainix/bloom-filter/issues{/number}","pulls_url":"https://api.github.com/repos/brainix/bloom-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/brainix/bloom-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/brainix/bloom-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brainix/bloom-filter/labels{/name}","releases_url":"https://api.github.com/repos/brainix/bloom-filter/releases{/id}","deployments_url":"https://api.github.com/repos/brainix/bloom-filter/deployments","created_at":"2017-12-26T09:21:30Z","updated_at":"2018-02-19T13:45:58Z","pushed_at":"2018-05-25T00:02:03Z","git_url":"git://github.com/brainix/bloom-filter.git","ssh_url":"git@github.com:brainix/bloom-filter.git","clone_url":"https://github.com/brainix/bloom-filter.git","svn_url":"https://github.com/brainix/bloom-filter","homepage":null,"size":46,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"brainix:master","ref":"master","sha":"ac56f5fed98013bd1fbd4a8ce1a425dc5cab720d","user":{"login":"brainix","id":1017698,"avatar_url":"https://avatars2.githubusercontent.com/u/1017698?v=4","gravatar_id":"","url":"https://api.github.com/users/brainix","html_url":"https://github.com/brainix","followers_url":"https://api.github.com/users/brainix/followers","following_url":"https://api.github.com/users/brainix/following{/other_user}","gists_url":"https://api.github.com/users/brainix/gists{/gist_id}","starred_url":"https://api.github.com/users/brainix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainix/subscriptions","organizations_url":"https://api.github.com/users/brainix/orgs","repos_url":"https://api.github.com/users/brainix/repos","events_url":"https://api.github.com/users/brainix/events{/privacy}","received_events_url":"https://api.github.com/users/brainix/received_events","type":"User","site_admin":false},"repo":{"id":115407018,"name":"bloom-filter","full_name":"brainix/bloom-filter","owner":{"login":"brainix","id":1017698,"avatar_url":"https://avatars2.githubusercontent.com/u/1017698?v=4","gravatar_id":"","url":"https://api.github.com/users/brainix","html_url":"https://github.com/brainix","followers_url":"https://api.github.com/users/brainix/followers","following_url":"https://api.github.com/users/brainix/following{/other_user}","gists_url":"https://api.github.com/users/brainix/gists{/gist_id}","starred_url":"https://api.github.com/users/brainix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainix/subscriptions","organizations_url":"https://api.github.com/users/brainix/orgs","repos_url":"https://api.github.com/users/brainix/repos","events_url":"https://api.github.com/users/brainix/events{/privacy}","received_events_url":"https://api.github.com/users/brainix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brainix/bloom-filter","description":"Prototype of how we can use a Bloom filter for @reddit's recently consumed feature.","fork":false,"url":"https://api.github.com/repos/brainix/bloom-filter","forks_url":"https://api.github.com/repos/brainix/bloom-filter/forks","keys_url":"https://api.github.com/repos/brainix/bloom-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brainix/bloom-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brainix/bloom-filter/teams","hooks_url":"https://api.github.com/repos/brainix/bloom-filter/hooks","issue_events_url":"https://api.github.com/repos/brainix/bloom-filter/issues/events{/number}","events_url":"https://api.github.com/repos/brainix/bloom-filter/events","assignees_url":"https://api.github.com/repos/brainix/bloom-filter/assignees{/user}","branches_url":"https://api.github.com/repos/brainix/bloom-filter/branches{/branch}","tags_url":"https://api.github.com/repos/brainix/bloom-filter/tags","blobs_url":"https://api.github.com/repos/brainix/bloom-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brainix/bloom-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brainix/bloom-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/brainix/bloom-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brainix/bloom-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/brainix/bloom-filter/languages","stargazers_url":"https://api.github.com/repos/brainix/bloom-filter/stargazers","contributors_url":"https://api.github.com/repos/brainix/bloom-filter/contributors","subscribers_url":"https://api.github.com/repos/brainix/bloom-filter/subscribers","subscription_url":"https://api.github.com/repos/brainix/bloom-filter/subscription","commits_url":"https://api.github.com/repos/brainix/bloom-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/brainix/bloom-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/brainix/bloom-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/brainix/bloom-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/brainix/bloom-filter/contents/{+path}","compare_url":"https://api.github.com/repos/brainix/bloom-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brainix/bloom-filter/merges","archive_url":"https://api.github.com/repos/brainix/bloom-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brainix/bloom-filter/downloads","issues_url":"https://api.github.com/repos/brainix/bloom-filter/issues{/number}","pulls_url":"https://api.github.com/repos/brainix/bloom-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/brainix/bloom-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/brainix/bloom-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brainix/bloom-filter/labels{/name}","releases_url":"https://api.github.com/repos/brainix/bloom-filter/releases{/id}","deployments_url":"https://api.github.com/repos/brainix/bloom-filter/deployments","created_at":"2017-12-26T09:21:30Z","updated_at":"2018-02-19T13:45:58Z","pushed_at":"2018-05-25T00:02:03Z","git_url":"git://github.com/brainix/bloom-filter.git","ssh_url":"git@github.com:brainix/bloom-filter.git","clone_url":"https://github.com/brainix/bloom-filter.git","svn_url":"https://github.com/brainix/bloom-filter","homepage":null,"size":46,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brainix/bloom-filter/pulls/18"},"html":{"href":"https://github.com/brainix/bloom-filter/pull/18"},"issue":{"href":"https://api.github.com/repos/brainix/bloom-filter/issues/18"},"comments":{"href":"https://api.github.com/repos/brainix/bloom-filter/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/brainix/bloom-filter/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/brainix/bloom-filter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brainix/bloom-filter/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/brainix/bloom-filter/statuses/0713e523ad8a34cc9bbae701254a96fc544e39ac"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"brainix","id":1017698,"avatar_url":"https://avatars2.githubusercontent.com/u/1017698?v=4","gravatar_id":"","url":"https://api.github.com/users/brainix","html_url":"https://github.com/brainix","followers_url":"https://api.github.com/users/brainix/followers","following_url":"https://api.github.com/users/brainix/following{/other_user}","gists_url":"https://api.github.com/users/brainix/gists{/gist_id}","starred_url":"https://api.github.com/users/brainix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainix/subscriptions","organizations_url":"https://api.github.com/users/brainix/orgs","repos_url":"https://api.github.com/users/brainix/repos","events_url":"https://api.github.com/users/brainix/events{/privacy}","received_events_url":"https://api.github.com/users/brainix/received_events","type":"User","site_admin":false},"comments":2,"review_comments":4,"maintainer_can_modify":false,"commits":3,"additions":304,"deletions":4,"changed_files":7}}
{"actor":{"display_login":"brainix"}}