{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments/177142860","pull_request_review_id":106964933,"id":177142860,"diff_hunk":"@@ -14,13 +14,17 @@ import scala.annotation.tailrec\n   *                 This is useful to override configuration for each test, rather than to recreate the VM.\n   */\n class VMClient(\n+    externalVmConfig: VmConfig.ExternalConfig,\n     messageHandler: MessageHandler,\n     testMode: Boolean)\n   extends Logger {\n \n   def sendHello(version: String, blockchainConfig: BlockchainConfig): Unit = {\n     val config = BlockchainConfigForEvm(blockchainConfig)\n-    val configMsg = msg.Hello.Config.EthereumConfig(buildEthereumConfigMsg(BlockchainConfigForEvm(blockchainConfig)))\n+    val configMsg = externalVmConfig.vmType match {\n+      case VmConfig.ExternalConfig.VmTypeIele => msg.Hello.Config.IeleConfig(buildIeleConfigMsg())","path":"src/main/scala/io/iohk/ethereum/extvm/VMClient.scala","position":22,"original_position":22,"commit_id":"a8c3a99e2fd935c97828f373c519f243d9ac8fc7","original_commit_id":"a8c3a99e2fd935c97828f373c519f243d9ac8fc7","user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars0.githubusercontent.com/u/5104541?v=4","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"body":"based on our discussion on slack, weren't we planning for our near-term solution to be to make IeleConfig also be passed on every CallContext?","created_at":"2018-03-26T15:53:30Z","updated_at":"2018-03-26T15:53:30Z","html_url":"https://github.com/input-output-hk/mantis/pull/426#discussion_r177142860","pull_request_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/426","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments/177142860"},"html":{"href":"https://github.com/input-output-hk/mantis/pull/426#discussion_r177142860"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/426"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/mantis/pulls/426","id":175861217,"html_url":"https://github.com/input-output-hk/mantis/pull/426","diff_url":"https://github.com/input-output-hk/mantis/pull/426.diff","patch_url":"https://github.com/input-output-hk/mantis/pull/426.patch","issue_url":"https://api.github.com/repos/input-output-hk/mantis/issues/426","number":426,"state":"open","locked":false,"title":"Add testmode","user":{"login":"LukasGasior1","id":5664242,"avatar_url":"https://avatars1.githubusercontent.com/u/5664242?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasGasior1","html_url":"https://github.com/LukasGasior1","followers_url":"https://api.github.com/users/LukasGasior1/followers","following_url":"https://api.github.com/users/LukasGasior1/following{/other_user}","gists_url":"https://api.github.com/users/LukasGasior1/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasGasior1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasGasior1/subscriptions","organizations_url":"https://api.github.com/users/LukasGasior1/orgs","repos_url":"https://api.github.com/users/LukasGasior1/repos","events_url":"https://api.github.com/users/LukasGasior1/events{/privacy}","received_events_url":"https://api.github.com/users/LukasGasior1/received_events","type":"User","site_admin":false},"body":"- added JSON RPC via Unix Domain Socket\r\n- added testmode\r\n- 1831 out of 1837 Solidity test cases passing (6 failing)\r\n\r\nTODO:\r\n- unit tests (at least for IPC, test_ endpoints are kind of covered by those Solidity tests anyway)\r\n- fix remaining 6 Solidity tests (possibly another PR)\r\n","created_at":"2018-03-19T10:43:17Z","updated_at":"2018-03-26T15:53:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a67d8512ffd36618455b14bc9c57d9cc9d0f85c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/426/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/426/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/issues/426/comments","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/a8c3a99e2fd935c97828f373c519f243d9ac8fc7","head":{"label":"input-output-hk:feature/testmode","ref":"feature/testmode","sha":"a8c3a99e2fd935c97828f373c519f243d9ac8fc7","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"name":"mantis","full_name":"input-output-hk/mantis","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/mantis","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/mantis","forks_url":"https://api.github.com/repos/input-output-hk/mantis/forks","keys_url":"https://api.github.com/repos/input-output-hk/mantis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/mantis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/mantis/teams","hooks_url":"https://api.github.com/repos/input-output-hk/mantis/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/mantis/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/mantis/events","assignees_url":"https://api.github.com/repos/input-output-hk/mantis/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/mantis/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/mantis/tags","blobs_url":"https://api.github.com/repos/input-output-hk/mantis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/mantis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/mantis/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/mantis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/mantis/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/mantis/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/mantis/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/mantis/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/mantis/subscription","commits_url":"https://api.github.com/repos/input-output-hk/mantis/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/mantis/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/mantis/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/mantis/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/mantis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/mantis/merges","archive_url":"https://api.github.com/repos/input-output-hk/mantis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/mantis/downloads","issues_url":"https://api.github.com/repos/input-output-hk/mantis/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/mantis/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/mantis/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/mantis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/mantis/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/mantis/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/mantis/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2018-03-21T02:18:03Z","pushed_at":"2018-03-26T11:57:35Z","git_url":"git://github.com/input-output-hk/mantis.git","ssh_url":"git@github.com:input-output-hk/mantis.git","clone_url":"https://github.com/input-output-hk/mantis.git","svn_url":"https://github.com/input-output-hk/mantis","homepage":null,"size":14811,"stargazers_count":99,"watchers_count":99,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":34,"open_issues":16,"watchers":99,"default_branch":"master"}},"base":{"label":"input-output-hk:phase/iele_testnet","ref":"phase/iele_testnet","sha":"8adb1a8ef5105df8a540ce67fad2fc39c7ea38ab","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"name":"mantis","full_name":"input-output-hk/mantis","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/mantis","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/mantis","forks_url":"https://api.github.com/repos/input-output-hk/mantis/forks","keys_url":"https://api.github.com/repos/input-output-hk/mantis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/mantis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/mantis/teams","hooks_url":"https://api.github.com/repos/input-output-hk/mantis/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/mantis/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/mantis/events","assignees_url":"https://api.github.com/repos/input-output-hk/mantis/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/mantis/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/mantis/tags","blobs_url":"https://api.github.com/repos/input-output-hk/mantis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/mantis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/mantis/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/mantis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/mantis/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/mantis/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/mantis/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/mantis/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/mantis/subscription","commits_url":"https://api.github.com/repos/input-output-hk/mantis/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/mantis/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/mantis/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/mantis/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/mantis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/mantis/merges","archive_url":"https://api.github.com/repos/input-output-hk/mantis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/mantis/downloads","issues_url":"https://api.github.com/repos/input-output-hk/mantis/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/mantis/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/mantis/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/mantis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/mantis/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/mantis/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/mantis/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2018-03-21T02:18:03Z","pushed_at":"2018-03-26T11:57:35Z","git_url":"git://github.com/input-output-hk/mantis.git","ssh_url":"git@github.com:input-output-hk/mantis.git","clone_url":"https://github.com/input-output-hk/mantis.git","svn_url":"https://github.com/input-output-hk/mantis","homepage":null,"size":14811,"stargazers_count":99,"watchers_count":99,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":34,"open_issues":16,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/426"},"html":{"href":"https://github.com/input-output-hk/mantis/pull/426"},"issue":{"href":"https://api.github.com/repos/input-output-hk/mantis/issues/426"},"comments":{"href":"https://api.github.com/repos/input-output-hk/mantis/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/mantis/statuses/a8c3a99e2fd935c97828f373c519f243d9ac8fc7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dwightguth"}}