{"action":"closed","number":593,"pull_request":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/593","id":221928305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTI4MzA1","html_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/593","diff_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/593.diff","patch_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/593.patch","issue_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/593","number":593,"state":"closed","locked":false,"title":"fix(NetworkManager): IOS-1194 remove whitelist","user":{"login":"woudini","id":10579422,"node_id":"MDQ6VXNlcjEwNTc5NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/10579422?v=4","gravatar_id":"","url":"https://api.github.com/users/woudini","html_url":"https://github.com/woudini","followers_url":"https://api.github.com/users/woudini/followers","following_url":"https://api.github.com/users/woudini/following{/other_user}","gists_url":"https://api.github.com/users/woudini/gists{/gist_id}","starred_url":"https://api.github.com/users/woudini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woudini/subscriptions","organizations_url":"https://api.github.com/users/woudini/orgs","repos_url":"https://api.github.com/users/woudini/repos","events_url":"https://api.github.com/users/woudini/events{/privacy}","received_events_url":"https://api.github.com/users/woudini/received_events","type":"User","site_admin":false},"body":"## Objective\r\n\r\nRestore public key pinning.\r\n\r\n## Description\r\n\r\nRemoved whitelist from `didReceiveChallenge` delegate method.\r\n\r\n## How to Test\r\n\r\n- Go through KYC and send an exchange order on production. You should not see any \"Failure to validate certificate\" alerts.\r\n- See the \"Testing Certificate Pinning\" section on the iOS wiki page.\r\n\r\n## Screenshot/Design assessment\r\n\r\nN/A\r\n\r\n## Merge Checklist\r\n\r\n- [x] The PR uses a title supported by [.changelogrc](https://github.com/blockchain/My-Wallet-V3-iOS/blob/dev/.changelogrc#L6...L69).\r\n- [ ] Areas of technical debt are marked with a `// TICKET:` comment that includes a ticket number.\r\n- [x] All unit tests pass.\r\n- [ ] You have added unit tests.\r\n- [ ] You have added sufficient documentation (descriptive comments).\r\n- [ ] New files added are within the correct directory. (e.g. if a file is required for unit tests to compile, be sure it is added to the tests target.)\r\n","created_at":"2018-10-10T20:49:29Z","updated_at":"2018-10-10T22:21:03Z","closed_at":"2018-10-10T22:21:03Z","merged_at":"2018-10-10T22:21:03Z","merge_commit_sha":"8432db5db6ab4f68909ef1307fbd3e298e981ccc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/593/commits","review_comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/593/comments","review_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/593/comments","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/974879fef4cbbee9c4e3f34543ca9ea37a8a662b","head":{"label":"blockchain:kevin/IOS-1194/cert","ref":"kevin/IOS-1194/cert","sha":"974879fef4cbbee9c4e3f34543ca9ea37a8a662b","user":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":26277947,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI3Nzk0Nw==","name":"My-Wallet-V3-iOS","full_name":"blockchain/My-Wallet-V3-iOS","private":false,"owner":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/blockchain/My-Wallet-V3-iOS","description":"Blockchain iOS Wallet","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/deployments","created_at":"2014-11-06T16:07:58Z","updated_at":"2018-10-10T22:07:12Z","pushed_at":"2018-10-10T22:21:03Z","git_url":"git://github.com/blockchain/My-Wallet-V3-iOS.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3-iOS.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-iOS.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-iOS","homepage":"https://itunes.apple.com/us/app/blockchain-bitcoin-wallet/id493253309","size":92061,"stargazers_count":103,"watchers_count":103,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":62,"open_issues":9,"watchers":103,"default_branch":"dev"}},"base":{"label":"blockchain:dev","ref":"dev","sha":"d294f0ecacece266601d83a97adb16cf3aff56ff","user":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":26277947,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI3Nzk0Nw==","name":"My-Wallet-V3-iOS","full_name":"blockchain/My-Wallet-V3-iOS","private":false,"owner":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/blockchain/My-Wallet-V3-iOS","description":"Blockchain iOS Wallet","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/deployments","created_at":"2014-11-06T16:07:58Z","updated_at":"2018-10-10T22:07:12Z","pushed_at":"2018-10-10T22:21:03Z","git_url":"git://github.com/blockchain/My-Wallet-V3-iOS.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3-iOS.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-iOS.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-iOS","homepage":"https://itunes.apple.com/us/app/blockchain-bitcoin-wallet/id493253309","size":92061,"stargazers_count":103,"watchers_count":103,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":62,"open_issues":9,"watchers":103,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/593"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/593"},"issue":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/593"},"comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/593/comments"},"review_comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/593/comments"},"review_comment":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/593/commits"},"statuses":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/974879fef4cbbee9c4e3f34543ca9ea37a8a662b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"woudini","id":10579422,"node_id":"MDQ6VXNlcjEwNTc5NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/10579422?v=4","gravatar_id":"","url":"https://api.github.com/users/woudini","html_url":"https://github.com/woudini","followers_url":"https://api.github.com/users/woudini/followers","following_url":"https://api.github.com/users/woudini/following{/other_user}","gists_url":"https://api.github.com/users/woudini/gists{/gist_id}","starred_url":"https://api.github.com/users/woudini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woudini/subscriptions","organizations_url":"https://api.github.com/users/woudini/orgs","repos_url":"https://api.github.com/users/woudini/repos","events_url":"https://api.github.com/users/woudini/events{/privacy}","received_events_url":"https://api.github.com/users/woudini/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"woudini"}}