{"action":"closed","issue":{"url":"https://api.github.com/repos/glumpy/glumpy/issues/145","repository_url":"https://api.github.com/repos/glumpy/glumpy","labels_url":"https://api.github.com/repos/glumpy/glumpy/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/glumpy/glumpy/issues/145/comments","events_url":"https://api.github.com/repos/glumpy/glumpy/issues/145/events","html_url":"https://github.com/glumpy/glumpy/issues/145","id":310341250,"number":145,"title":"vsync option implemented?","user":{"login":"victor-shepardson","id":4522484,"avatar_url":"https://avatars0.githubusercontent.com/u/4522484?v=4","gravatar_id":"","url":"https://api.github.com/users/victor-shepardson","html_url":"https://github.com/victor-shepardson","followers_url":"https://api.github.com/users/victor-shepardson/followers","following_url":"https://api.github.com/users/victor-shepardson/following{/other_user}","gists_url":"https://api.github.com/users/victor-shepardson/gists{/gist_id}","starred_url":"https://api.github.com/users/victor-shepardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victor-shepardson/subscriptions","organizations_url":"https://api.github.com/users/victor-shepardson/orgs","repos_url":"https://api.github.com/users/victor-shepardson/repos","events_url":"https://api.github.com/users/victor-shepardson/events{/privacy}","received_events_url":"https://api.github.com/users/victor-shepardson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-01T17:50:23Z","updated_at":"2018-04-23T07:32:25Z","closed_at":"2018-04-23T07:32:25Z","author_association":"CONTRIBUTOR","body":"it seems that the --vsync option does not do anything. I can't find anywhere in the code it is extracted from the parsed options, and the backends appear hardcoded to set vsync to false.\r\n\r\nI'm able to turn vsync on manually, using GLFW for example: `glumpy.app.__backend__.glfw.glfwSwapInterval(1)` after window creation.\r\n\r\nWould the proper way be to add a `vsync` keyword argument to each backend's `Window.__init__`, and pass `options.vsync` to it from the abstract `Window.__new__` in `app/__init__.py`?\r\n\r\nHappy to make a PR, wanted to check if there is some reason it isn't done this way."}}
{"actor":{"display_login":"rougier"}}