{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/175785206","pull_request_review_id":105371304,"id":175785206,"diff_hunk":"@@ -61,18 +61,22 @@ const BUILT_IN_SECTIONS = {\n     icon: \"highlights\",\n     title: {id: \"header_highlights\"},\n     maxRows: 3,\n-    availableLinkMenuOptions: [\"CheckBookmarkOrArchive\", \"CheckSavedToPocket\", \"Separator\", \"OpenInNewWindow\", \"OpenInPrivateWindow\", \"Separator\", \"BlockUrl\", \"CheckDeleteHistoryOrEmpty\"],\n     emptyState: {\n       message: {id: \"highlights_empty_state\"},\n       icon: \"highlights\"\n     },\n     shouldSendImpressionStats: false\n   })\n };\n+const CONTEXT_MENU_OPTIONS_FOR_HIGHLIGHT_TYPES = {\n+  history: [\"CheckBookmark\", \"CheckSavedToPocket\", \"Separator\", \"OpenInNewWindow\", \"OpenInPrivateWindow\", \"Separator\", \"BlockUrl\", \"DeleteUrl\"],","path":"system-addon/lib/SectionsManager.jsm","position":13,"original_position":13,"commit_id":"d6bc6cb818db471e902ba5601a33ca78c79eecb0","original_commit_id":"d6bc6cb818db471e902ba5601a33ca78c79eecb0","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"body":"could write a mochitest for it as a follow up?","created_at":"2018-03-20T14:27:29Z","updated_at":"2018-03-20T14:27:30Z","html_url":"https://github.com/mozilla/activity-stream/pull/4045#discussion_r175785206","pull_request_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4045","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/175785206"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/4045#discussion_r175785206"},"pull_request":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4045"}},"in_reply_to_id":175781681},"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4045","id":176010415,"html_url":"https://github.com/mozilla/activity-stream/pull/4045","diff_url":"https://github.com/mozilla/activity-stream/pull/4045.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/4045.patch","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4045","number":4045,"state":"open","locked":false,"title":"Fix Bug 1446395 - Assign context menus in Highlights on a per card type basis","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"body":"Instead of assigning context menus to each card for an entire section type, this allows you to specify context menu options for each card type *only* for highlights. \r\n","created_at":"2018-03-19T20:04:21Z","updated_at":"2018-03-20T14:27:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88e0abbd39046e8f20a50f8f6776af26a7b5d8fd","assignee":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"assignees":[{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":324827449,"url":"https://api.github.com/repos/mozilla/activity-stream/labels/PR%20/%20Needs%20work","name":"PR / Needs work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4045/commits","review_comments_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4045/comments","review_comment_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4045/comments","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/d6bc6cb818db471e902ba5601a33ca78c79eecb0","head":{"label":"sarracini:bug_1446395","ref":"bug_1446395","sha":"d6bc6cb818db471e902ba5601a33ca78c79eecb0","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"repo":{"id":63179383,"name":"activity-stream","full_name":"sarracini/activity-stream","owner":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarracini/activity-stream","description":" MVP prototype add-on for activity streams","fork":true,"url":"https://api.github.com/repos/sarracini/activity-stream","forks_url":"https://api.github.com/repos/sarracini/activity-stream/forks","keys_url":"https://api.github.com/repos/sarracini/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarracini/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarracini/activity-stream/teams","hooks_url":"https://api.github.com/repos/sarracini/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/sarracini/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/sarracini/activity-stream/events","assignees_url":"https://api.github.com/repos/sarracini/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/sarracini/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/sarracini/activity-stream/tags","blobs_url":"https://api.github.com/repos/sarracini/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarracini/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarracini/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarracini/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarracini/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/sarracini/activity-stream/languages","stargazers_url":"https://api.github.com/repos/sarracini/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/sarracini/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/sarracini/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/sarracini/activity-stream/subscription","commits_url":"https://api.github.com/repos/sarracini/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarracini/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarracini/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarracini/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarracini/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/sarracini/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarracini/activity-stream/merges","archive_url":"https://api.github.com/repos/sarracini/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarracini/activity-stream/downloads","issues_url":"https://api.github.com/repos/sarracini/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/sarracini/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/sarracini/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/sarracini/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarracini/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/sarracini/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/sarracini/activity-stream/deployments","created_at":"2016-07-12T17:38:50Z","updated_at":"2018-03-19T20:11:21Z","pushed_at":"2018-03-19T20:11:20Z","git_url":"git://github.com/sarracini/activity-stream.git","ssh_url":"git@github.com:sarracini/activity-stream.git","clone_url":"https://github.com/sarracini/activity-stream.git","svn_url":"https://github.com/sarracini/activity-stream","homepage":"","size":8500,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"b746880c7674b2c7e7dbc42b0521a1d6c014b08d","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50695589,"name":"activity-stream","full_name":"mozilla/activity-stream","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/activity-stream","description":"A refreshed \"new tab page\" for Firefox","fork":false,"url":"https://api.github.com/repos/mozilla/activity-stream","forks_url":"https://api.github.com/repos/mozilla/activity-stream/forks","keys_url":"https://api.github.com/repos/mozilla/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/activity-stream/teams","hooks_url":"https://api.github.com/repos/mozilla/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/activity-stream/events","assignees_url":"https://api.github.com/repos/mozilla/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/activity-stream/tags","blobs_url":"https://api.github.com/repos/mozilla/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/activity-stream/languages","stargazers_url":"https://api.github.com/repos/mozilla/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/mozilla/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/mozilla/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/mozilla/activity-stream/subscription","commits_url":"https://api.github.com/repos/mozilla/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/activity-stream/merges","archive_url":"https://api.github.com/repos/mozilla/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/activity-stream/downloads","issues_url":"https://api.github.com/repos/mozilla/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/activity-stream/deployments","created_at":"2016-01-29T22:28:26Z","updated_at":"2018-03-19T17:55:55Z","pushed_at":"2018-03-20T14:02:41Z","git_url":"git://github.com/mozilla/activity-stream.git","ssh_url":"git@github.com:mozilla/activity-stream.git","clone_url":"https://github.com/mozilla/activity-stream.git","svn_url":"https://github.com/mozilla/activity-stream","homepage":"","size":9133,"stargazers_count":145,"watchers_count":145,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":93,"open_issues":48,"watchers":145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4045"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/4045"},"issue":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/4045"},"comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/4045/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4045/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4045/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/activity-stream/statuses/d6bc6cb818db471e902ba5601a33ca78c79eecb0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sarracini"}}