{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/235165110","pull_request_review_id":176969593,"id":235165110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTE2NTExMA==","diff_hunk":"@@ -219,7 +219,9 @@ let\n         // optionalAttrs (config.documentation != []) {\n           Documentation = toString config.documentation; }\n         // optionalAttrs (config.onFailure != []) {\n-          OnFailure = toString config.onFailure;\n+          OnFailure = toString config.onFailure; }\n+        // optionalAttrs (config.startLimitIntervalSec != []) {","path":"nixos/modules/system/boot/systemd.nix","position":6,"original_position":6,"commit_id":"d64d3ca67c65725929bcfcd80a4b3111dc58d150","original_commit_id":"d64d3ca67c65725929bcfcd80a4b3111dc58d150","user":{"login":"Infinisil","id":20525370,"node_id":"MDQ6VXNlcjIwNTI1Mzcw","avatar_url":"https://avatars0.githubusercontent.com/u/20525370?v=4","gravatar_id":"","url":"https://api.github.com/users/Infinisil","html_url":"https://github.com/Infinisil","followers_url":"https://api.github.com/users/Infinisil/followers","following_url":"https://api.github.com/users/Infinisil/following{/other_user}","gists_url":"https://api.github.com/users/Infinisil/gists{/gist_id}","starred_url":"https://api.github.com/users/Infinisil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Infinisil/subscriptions","organizations_url":"https://api.github.com/users/Infinisil/orgs","repos_url":"https://api.github.com/users/Infinisil/repos","events_url":"https://api.github.com/users/Infinisil/events{/privacy}","received_events_url":"https://api.github.com/users/Infinisil/received_events","type":"User","site_admin":false},"body":"Remove the default, add an `options` argument at line 196, then change this here to `options.startLimitIntervalSec.isDefined`","created_at":"2018-11-20T20:53:41Z","updated_at":"2018-11-20T20:53:44Z","html_url":"https://github.com/NixOS/nixpkgs/pull/50849#discussion_r235165110","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50849","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/235165110"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/50849#discussion_r235165110"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50849"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50849","id":232404099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDA0MDk5","html_url":"https://github.com/NixOS/nixpkgs/pull/50849","diff_url":"https://github.com/NixOS/nixpkgs/pull/50849.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/50849.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50849","number":50849,"state":"open","locked":false,"title":"nixos/systemd: add StartLimitIntervalSec to unit config","user":{"login":"cyounkins","id":346185,"node_id":"MDQ6VXNlcjM0NjE4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/346185?v=4","gravatar_id":"","url":"https://api.github.com/users/cyounkins","html_url":"https://github.com/cyounkins","followers_url":"https://api.github.com/users/cyounkins/followers","following_url":"https://api.github.com/users/cyounkins/following{/other_user}","gists_url":"https://api.github.com/users/cyounkins/gists{/gist_id}","starred_url":"https://api.github.com/users/cyounkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyounkins/subscriptions","organizations_url":"https://api.github.com/users/cyounkins/orgs","repos_url":"https://api.github.com/users/cyounkins/repos","events_url":"https://api.github.com/users/cyounkins/events{/privacy}","received_events_url":"https://api.github.com/users/cyounkins/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nAdds the new attribute to configure unit start rate limiting.\r\nDocumentation: https://www.freedesktop.org/software/systemd/man/systemd.unit.html\r\nRef #45785 \r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---","created_at":"2018-11-20T17:37:52Z","updated_at":"2018-11-20T20:53:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"682ce319b319beeb1605c88ded10c96200bda09f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50849/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50849/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50849/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d64d3ca67c65725929bcfcd80a4b3111dc58d150","head":{"label":"cyounkins:startlimitinterval","ref":"startlimitinterval","sha":"d64d3ca67c65725929bcfcd80a4b3111dc58d150","user":{"login":"cyounkins","id":346185,"node_id":"MDQ6VXNlcjM0NjE4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/346185?v=4","gravatar_id":"","url":"https://api.github.com/users/cyounkins","html_url":"https://github.com/cyounkins","followers_url":"https://api.github.com/users/cyounkins/followers","following_url":"https://api.github.com/users/cyounkins/following{/other_user}","gists_url":"https://api.github.com/users/cyounkins/gists{/gist_id}","starred_url":"https://api.github.com/users/cyounkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyounkins/subscriptions","organizations_url":"https://api.github.com/users/cyounkins/orgs","repos_url":"https://api.github.com/users/cyounkins/repos","events_url":"https://api.github.com/users/cyounkins/events{/privacy}","received_events_url":"https://api.github.com/users/cyounkins/received_events","type":"User","site_admin":false},"repo":{"id":158278739,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgyNzg3Mzk=","name":"nixpkgs","full_name":"cyounkins/nixpkgs","private":false,"owner":{"login":"cyounkins","id":346185,"node_id":"MDQ6VXNlcjM0NjE4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/346185?v=4","gravatar_id":"","url":"https://api.github.com/users/cyounkins","html_url":"https://github.com/cyounkins","followers_url":"https://api.github.com/users/cyounkins/followers","following_url":"https://api.github.com/users/cyounkins/following{/other_user}","gists_url":"https://api.github.com/users/cyounkins/gists{/gist_id}","starred_url":"https://api.github.com/users/cyounkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyounkins/subscriptions","organizations_url":"https://api.github.com/users/cyounkins/orgs","repos_url":"https://api.github.com/users/cyounkins/repos","events_url":"https://api.github.com/users/cyounkins/events{/privacy}","received_events_url":"https://api.github.com/users/cyounkins/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cyounkins/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/cyounkins/nixpkgs","forks_url":"https://api.github.com/repos/cyounkins/nixpkgs/forks","keys_url":"https://api.github.com/repos/cyounkins/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyounkins/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyounkins/nixpkgs/teams","hooks_url":"https://api.github.com/repos/cyounkins/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/cyounkins/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/cyounkins/nixpkgs/events","assignees_url":"https://api.github.com/repos/cyounkins/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/cyounkins/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/cyounkins/nixpkgs/tags","blobs_url":"https://api.github.com/repos/cyounkins/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyounkins/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyounkins/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyounkins/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyounkins/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/cyounkins/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/cyounkins/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/cyounkins/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/cyounkins/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/cyounkins/nixpkgs/subscription","commits_url":"https://api.github.com/repos/cyounkins/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyounkins/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyounkins/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyounkins/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyounkins/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/cyounkins/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyounkins/nixpkgs/merges","archive_url":"https://api.github.com/repos/cyounkins/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyounkins/nixpkgs/downloads","issues_url":"https://api.github.com/repos/cyounkins/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/cyounkins/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/cyounkins/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/cyounkins/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyounkins/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/cyounkins/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/cyounkins/nixpkgs/deployments","created_at":"2018-11-19T19:28:17Z","updated_at":"2018-11-19T19:28:56Z","pushed_at":"2018-11-20T20:36:30Z","git_url":"git://github.com/cyounkins/nixpkgs.git","ssh_url":"git@github.com:cyounkins/nixpkgs.git","clone_url":"https://github.com/cyounkins/nixpkgs.git","svn_url":"https://github.com/cyounkins/nixpkgs","homepage":null,"size":878243,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"d3bdf3fe985aa637fac79bac55a21f1f7a655269","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-11-20T20:52:41Z","pushed_at":"2018-11-20T20:51:28Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":887385,"stargazers_count":3016,"watchers_count":3016,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3203,"mirror_url":null,"archived":false,"open_issues_count":3441,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3203,"open_issues":3441,"watchers":3016,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50849"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/50849"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/50849"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/50849/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50849/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50849/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d64d3ca67c65725929bcfcd80a4b3111dc58d150"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Infinisil"}}