{"action":"created","comment":{"url":"https://api.github.com/repos/onfido/react-webcam/pulls/comments/194407242","pull_request_review_id":127569739,"id":194407242,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQwNzI0Mg==","diff_hunk":"@@ -100,26 +210,37 @@ <h2>CSS Filters</h2>\n                 <Webcam width='212' height='160'/>\n               </div>\n             </div>\n-            <div>\n-              <h2>Screenshots</h2>\n-              <div className='screenshots'>\n-                <div className='controls'>\n-                  <button onClick={this.screenshot}>capture</button>\n-                </div>\n-                { this.state.screenshot ? <img src={this.state.screenshot} /> : null }\n-              </div>\n-            </div>\n           </div>\n-        );\n+        )\n       }\n+    }\n \n-      screenshot = () => {\n-        var screenshot = this.webcam.getScreenshot();\n-        this.setState({screenshot: screenshot});\n+    const App = class App extends React.Component {\n+      options = () => {\n+        return window.location.search.slice(1).split('&')\n+          .reduce(function _reduce (/*Object*/ a, /*String*/ b) {","path":"examples/index.html","position":173,"original_position":173,"commit_id":"1458c1fb0b5ac2f52a080c82e6708a317676d477","original_commit_id":"1458c1fb0b5ac2f52a080c82e6708a317676d477","user":{"login":"stephencookdev","id":8496655,"node_id":"MDQ6VXNlcjg0OTY2NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8496655?v=4","gravatar_id":"","url":"https://api.github.com/users/stephencookdev","html_url":"https://github.com/stephencookdev","followers_url":"https://api.github.com/users/stephencookdev/followers","following_url":"https://api.github.com/users/stephencookdev/following{/other_user}","gists_url":"https://api.github.com/users/stephencookdev/gists{/gist_id}","starred_url":"https://api.github.com/users/stephencookdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephencookdev/subscriptions","organizations_url":"https://api.github.com/users/stephencookdev/orgs","repos_url":"https://api.github.com/users/stephencookdev/repos","events_url":"https://api.github.com/users/stephencookdev/events{/privacy}","received_events_url":"https://api.github.com/users/stephencookdev/received_events","type":"User","site_admin":false},"body":"why the funny variable names, and comments etc? I guess this was copy-pasted from somewhere?\r\n\r\nWhat do you think of making a bit more readable with something like:\r\n\r\n```\r\n.reduce((acc, queryParam) => {\r\n  const queryParamParts = queryParam.split('=');\r\n  return {\r\n    ...acc,\r\n    [queryParamParts[0]]: decodeURIComponent(queryParamParts[1]),\r\n  };\r\n}, {})\r\n```\r\n\r\n?","created_at":"2018-06-11T13:41:33Z","updated_at":"2018-06-11T13:43:22Z","html_url":"https://github.com/onfido/react-webcam/pull/18#discussion_r194407242","pull_request_url":"https://api.github.com/repos/onfido/react-webcam/pulls/18","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/onfido/react-webcam/pulls/comments/194407242"},"html":{"href":"https://github.com/onfido/react-webcam/pull/18#discussion_r194407242"},"pull_request":{"href":"https://api.github.com/repos/onfido/react-webcam/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/onfido/react-webcam/pulls/18","id":193105746,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTA1NzQ2","html_url":"https://github.com/onfido/react-webcam/pull/18","diff_url":"https://github.com/onfido/react-webcam/pull/18.diff","patch_url":"https://github.com/onfido/react-webcam/pull/18.patch","issue_url":"https://api.github.com/repos/onfido/react-webcam/issues/18","number":18,"state":"open","locked":false,"title":"Feature/record videos cx 2093","user":{"login":"stefaniacardenas","id":7127427,"node_id":"MDQ6VXNlcjcxMjc0Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/7127427?v=4","gravatar_id":"","url":"https://api.github.com/users/stefaniacardenas","html_url":"https://github.com/stefaniacardenas","followers_url":"https://api.github.com/users/stefaniacardenas/followers","following_url":"https://api.github.com/users/stefaniacardenas/following{/other_user}","gists_url":"https://api.github.com/users/stefaniacardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/stefaniacardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefaniacardenas/subscriptions","organizations_url":"https://api.github.com/users/stefaniacardenas/orgs","repos_url":"https://api.github.com/users/stefaniacardenas/repos","events_url":"https://api.github.com/users/stefaniacardenas/events{/privacy}","received_events_url":"https://api.github.com/users/stefaniacardenas/received_events","type":"User","site_admin":false},"body":"### New feature\r\nCamera should be able to record and return a video object reproducible on browsers.\r\n### Bug fixed\r\nReturn error if permission denied or if there is an error with the streaming\r\n\r\n","created_at":"2018-06-06T18:46:37Z","updated_at":"2018-06-11T13:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d18ee82c195f4ff7b96b6809b851c7e96d6362b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onfido/react-webcam/pulls/18/commits","review_comments_url":"https://api.github.com/repos/onfido/react-webcam/pulls/18/comments","review_comment_url":"https://api.github.com/repos/onfido/react-webcam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onfido/react-webcam/issues/18/comments","statuses_url":"https://api.github.com/repos/onfido/react-webcam/statuses/1458c1fb0b5ac2f52a080c82e6708a317676d477","head":{"label":"onfido:feature/record-videos-cx-2093","ref":"feature/record-videos-cx-2093","sha":"1458c1fb0b5ac2f52a080c82e6708a317676d477","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":72740611,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc0MDYxMQ==","name":"react-webcam","full_name":"onfido/react-webcam","owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onfido/react-webcam","description":"Webcam component","fork":true,"url":"https://api.github.com/repos/onfido/react-webcam","forks_url":"https://api.github.com/repos/onfido/react-webcam/forks","keys_url":"https://api.github.com/repos/onfido/react-webcam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/react-webcam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/react-webcam/teams","hooks_url":"https://api.github.com/repos/onfido/react-webcam/hooks","issue_events_url":"https://api.github.com/repos/onfido/react-webcam/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/react-webcam/events","assignees_url":"https://api.github.com/repos/onfido/react-webcam/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/react-webcam/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/react-webcam/tags","blobs_url":"https://api.github.com/repos/onfido/react-webcam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/react-webcam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/react-webcam/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/react-webcam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/react-webcam/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/react-webcam/languages","stargazers_url":"https://api.github.com/repos/onfido/react-webcam/stargazers","contributors_url":"https://api.github.com/repos/onfido/react-webcam/contributors","subscribers_url":"https://api.github.com/repos/onfido/react-webcam/subscribers","subscription_url":"https://api.github.com/repos/onfido/react-webcam/subscription","commits_url":"https://api.github.com/repos/onfido/react-webcam/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/react-webcam/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/react-webcam/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/react-webcam/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/react-webcam/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/react-webcam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/react-webcam/merges","archive_url":"https://api.github.com/repos/onfido/react-webcam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/react-webcam/downloads","issues_url":"https://api.github.com/repos/onfido/react-webcam/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/react-webcam/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/react-webcam/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/react-webcam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/react-webcam/labels{/name}","releases_url":"https://api.github.com/repos/onfido/react-webcam/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/react-webcam/deployments","created_at":"2016-11-03T11:54:41Z","updated_at":"2018-06-05T04:25:24Z","pushed_at":"2018-06-11T10:55:11Z","git_url":"git://github.com/onfido/react-webcam.git","ssh_url":"git@github.com:onfido/react-webcam.git","clone_url":"https://github.com/onfido/react-webcam.git","svn_url":"https://github.com/onfido/react-webcam","homepage":"https://cezary.github.io/react-webcam/examples","size":227,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"onfido:master","ref":"master","sha":"6aa814ac453447a3ad5030646ca49686415fc379","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":72740611,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc0MDYxMQ==","name":"react-webcam","full_name":"onfido/react-webcam","owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onfido/react-webcam","description":"Webcam component","fork":true,"url":"https://api.github.com/repos/onfido/react-webcam","forks_url":"https://api.github.com/repos/onfido/react-webcam/forks","keys_url":"https://api.github.com/repos/onfido/react-webcam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/react-webcam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/react-webcam/teams","hooks_url":"https://api.github.com/repos/onfido/react-webcam/hooks","issue_events_url":"https://api.github.com/repos/onfido/react-webcam/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/react-webcam/events","assignees_url":"https://api.github.com/repos/onfido/react-webcam/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/react-webcam/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/react-webcam/tags","blobs_url":"https://api.github.com/repos/onfido/react-webcam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/react-webcam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/react-webcam/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/react-webcam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/react-webcam/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/react-webcam/languages","stargazers_url":"https://api.github.com/repos/onfido/react-webcam/stargazers","contributors_url":"https://api.github.com/repos/onfido/react-webcam/contributors","subscribers_url":"https://api.github.com/repos/onfido/react-webcam/subscribers","subscription_url":"https://api.github.com/repos/onfido/react-webcam/subscription","commits_url":"https://api.github.com/repos/onfido/react-webcam/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/react-webcam/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/react-webcam/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/react-webcam/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/react-webcam/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/react-webcam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/react-webcam/merges","archive_url":"https://api.github.com/repos/onfido/react-webcam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/react-webcam/downloads","issues_url":"https://api.github.com/repos/onfido/react-webcam/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/react-webcam/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/react-webcam/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/react-webcam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/react-webcam/labels{/name}","releases_url":"https://api.github.com/repos/onfido/react-webcam/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/react-webcam/deployments","created_at":"2016-11-03T11:54:41Z","updated_at":"2018-06-05T04:25:24Z","pushed_at":"2018-06-11T10:55:11Z","git_url":"git://github.com/onfido/react-webcam.git","ssh_url":"git@github.com:onfido/react-webcam.git","clone_url":"https://github.com/onfido/react-webcam.git","svn_url":"https://github.com/onfido/react-webcam","homepage":"https://cezary.github.io/react-webcam/examples","size":227,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onfido/react-webcam/pulls/18"},"html":{"href":"https://github.com/onfido/react-webcam/pull/18"},"issue":{"href":"https://api.github.com/repos/onfido/react-webcam/issues/18"},"comments":{"href":"https://api.github.com/repos/onfido/react-webcam/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/onfido/react-webcam/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/onfido/react-webcam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onfido/react-webcam/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/onfido/react-webcam/statuses/1458c1fb0b5ac2f52a080c82e6708a317676d477"}},"author_association":"NONE"}}
{"actor":{"display_login":"stephencookdev"}}