{"action":"closed","number":978,"pull_request":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/978","id":192763747,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzYzNzQ3","html_url":"https://github.com/stratis-storage/stratisd/pull/978","diff_url":"https://github.com/stratis-storage/stratisd/pull/978.diff","patch_url":"https://github.com/stratis-storage/stratisd/pull/978.patch","issue_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/978","number":978,"state":"closed","locked":false,"title":"Verify both copies of BDA, correct if we can","user":{"login":"tasleson","id":2520480,"node_id":"MDQ6VXNlcjI1MjA0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2520480?v=4","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"body":"When we read up BDA from a device we will verify both copies and correct in\r\nthose cases where we have one good copy and one invalid copy.  This change also\r\ncorrects a bug where we would return no Stratis BDA if the magic on the first\r\ncopy contains an error even though we have a complete and valid second copy.\r\n\r\nPartially resolves: #210 , this doesn't address the MDA, just the BDA","created_at":"2018-06-05T16:18:47Z","updated_at":"2018-06-16T16:14:35Z","closed_at":"2018-06-16T16:14:35Z","merged_at":"2018-06-16T16:14:35Z","merge_commit_sha":"7911f0920929c31d9a7f752a257531ac4e2158ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":522134131,"node_id":"MDU6TGFiZWw1MjIxMzQxMzE=","url":"https://api.github.com/repos/stratis-storage/stratisd/labels/review-prelim","name":"review-prelim","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/978/commits","review_comments_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/978/comments","review_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/978/comments","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/81a06b6929b4e4e308fff5dfaae70150b6034af5","head":{"label":"tasleson:correct_bda","ref":"correct_bda","sha":"81a06b6929b4e4e308fff5dfaae70150b6034af5","user":{"login":"tasleson","id":2520480,"node_id":"MDQ6VXNlcjI1MjA0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2520480?v=4","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"repo":{"id":106866406,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4NjY0MDY=","name":"stratisd","full_name":"tasleson/stratisd","owner":{"login":"tasleson","id":2520480,"node_id":"MDQ6VXNlcjI1MjA0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2520480?v=4","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tasleson/stratisd","description":null,"fork":true,"url":"https://api.github.com/repos/tasleson/stratisd","forks_url":"https://api.github.com/repos/tasleson/stratisd/forks","keys_url":"https://api.github.com/repos/tasleson/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tasleson/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tasleson/stratisd/teams","hooks_url":"https://api.github.com/repos/tasleson/stratisd/hooks","issue_events_url":"https://api.github.com/repos/tasleson/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/tasleson/stratisd/events","assignees_url":"https://api.github.com/repos/tasleson/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/tasleson/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/tasleson/stratisd/tags","blobs_url":"https://api.github.com/repos/tasleson/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tasleson/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tasleson/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/tasleson/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tasleson/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/tasleson/stratisd/languages","stargazers_url":"https://api.github.com/repos/tasleson/stratisd/stargazers","contributors_url":"https://api.github.com/repos/tasleson/stratisd/contributors","subscribers_url":"https://api.github.com/repos/tasleson/stratisd/subscribers","subscription_url":"https://api.github.com/repos/tasleson/stratisd/subscription","commits_url":"https://api.github.com/repos/tasleson/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/tasleson/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/tasleson/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/tasleson/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/tasleson/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/tasleson/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tasleson/stratisd/merges","archive_url":"https://api.github.com/repos/tasleson/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tasleson/stratisd/downloads","issues_url":"https://api.github.com/repos/tasleson/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/tasleson/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/tasleson/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/tasleson/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tasleson/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/tasleson/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/tasleson/stratisd/deployments","created_at":"2017-10-13T19:40:47Z","updated_at":"2018-05-31T20:20:11Z","pushed_at":"2018-06-16T15:07:09Z","git_url":"git://github.com/tasleson/stratisd.git","ssh_url":"git@github.com:tasleson/stratisd.git","clone_url":"https://github.com/tasleson/stratisd.git","svn_url":"https://github.com/tasleson/stratisd","homepage":null,"size":2430,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratis-storage:master","ref":"master","sha":"3d9a661a87b2d03cea3b95224438529ab6afd232","user":{"login":"stratis-storage","id":21202300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyMzAw","avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"repo":{"id":66564704,"node_id":"MDEwOlJlcG9zaXRvcnk2NjU2NDcwNA==","name":"stratisd","full_name":"stratis-storage/stratisd","owner":{"login":"stratis-storage","id":21202300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyMzAw","avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratis-storage/stratisd","description":"Easy to use local storage management for Linux.","fork":false,"url":"https://api.github.com/repos/stratis-storage/stratisd","forks_url":"https://api.github.com/repos/stratis-storage/stratisd/forks","keys_url":"https://api.github.com/repos/stratis-storage/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratis-storage/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratis-storage/stratisd/teams","hooks_url":"https://api.github.com/repos/stratis-storage/stratisd/hooks","issue_events_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/stratis-storage/stratisd/events","assignees_url":"https://api.github.com/repos/stratis-storage/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/stratis-storage/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/stratis-storage/stratisd/tags","blobs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratis-storage/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratis-storage/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/stratis-storage/stratisd/languages","stargazers_url":"https://api.github.com/repos/stratis-storage/stratisd/stargazers","contributors_url":"https://api.github.com/repos/stratis-storage/stratisd/contributors","subscribers_url":"https://api.github.com/repos/stratis-storage/stratisd/subscribers","subscription_url":"https://api.github.com/repos/stratis-storage/stratisd/subscription","commits_url":"https://api.github.com/repos/stratis-storage/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratis-storage/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratis-storage/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/stratis-storage/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratis-storage/stratisd/merges","archive_url":"https://api.github.com/repos/stratis-storage/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratis-storage/stratisd/downloads","issues_url":"https://api.github.com/repos/stratis-storage/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/stratis-storage/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/stratis-storage/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratis-storage/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/stratis-storage/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/stratis-storage/stratisd/deployments","created_at":"2016-08-25T14:24:19Z","updated_at":"2018-06-16T14:32:57Z","pushed_at":"2018-06-16T16:14:35Z","git_url":"git://github.com/stratis-storage/stratisd.git","ssh_url":"git@github.com:stratis-storage/stratisd.git","clone_url":"https://github.com/stratis-storage/stratisd.git","svn_url":"https://github.com/stratis-storage/stratisd","homepage":"https://stratis-storage.github.io","size":2435,"stargazers_count":267,"watchers_count":267,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":19,"open_issues":112,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/978"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/978"},"issue":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/978"},"comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/978/comments"},"review_comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/978/comments"},"review_comment":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/978/commits"},"statuses":{"href":"https://api.github.com/repos/stratis-storage/stratisd/statuses/81a06b6929b4e4e308fff5dfaae70150b6034af5"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tasleson","id":2520480,"node_id":"MDQ6VXNlcjI1MjA0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2520480?v=4","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"comments":8,"review_comments":57,"maintainer_can_modify":false,"commits":2,"additions":261,"deletions":58,"changed_files":1}}
{"actor":{"display_login":"tasleson"}}