{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/175271033","pull_request_review_id":104779202,"id":175271033,"diff_hunk":"@@ -0,0 +1,15 @@\n+error[E0277]: the trait bound `&&&&&std::iter::Enumerate<std::slice::Iter<'_, {integer}>>: std::iter::Iterator` is not satisfied\n+  --> $DIR/suggest-remove-refs-2.rs:14:19\n+   |\n+LL |     for (i, n) in & & & & &v.iter().enumerate() {\n+   |                   ---------^^^^^^^^^^^^^^^^^^^^\n+   |                   |\n+   |                   `&&&&&std::iter::Enumerate<std::slice::Iter<'_, {integer}>>` is not an iterator; maybe try calling `.iter()` or a similar method\n+   |                   help: consider removing 5 leading `&`-references","path":"src/test/ui/suggest-remove-refs-2.stderr","position":8,"original_position":8,"commit_id":"311e9acf7bb18742f22631e3081b68b3da6a0456","original_commit_id":"311e9acf7bb18742f22631e3081b68b3da6a0456","user":{"login":"estebank","id":1606434,"avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"body":"The output is great!","created_at":"2018-03-17T21:44:29Z","updated_at":"2018-03-17T21:44:35Z","html_url":"https://github.com/rust-lang/rust/pull/48834#discussion_r175271033","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/48834","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/175271033"},"html":{"href":"https://github.com/rust-lang/rust/pull/48834#discussion_r175271033"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48834"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/48834","id":173619282,"html_url":"https://github.com/rust-lang/rust/pull/48834","diff_url":"https://github.com/rust-lang/rust/pull/48834.diff","patch_url":"https://github.com/rust-lang/rust/pull/48834.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/48834","number":48834,"state":"open","locked":false,"title":"Suggest removing `&`s","user":{"login":"ysiraichi","id":3337141,"avatar_url":"https://avatars3.githubusercontent.com/u/3337141?v=4","gravatar_id":"","url":"https://api.github.com/users/ysiraichi","html_url":"https://github.com/ysiraichi","followers_url":"https://api.github.com/users/ysiraichi/followers","following_url":"https://api.github.com/users/ysiraichi/following{/other_user}","gists_url":"https://api.github.com/users/ysiraichi/gists{/gist_id}","starred_url":"https://api.github.com/users/ysiraichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysiraichi/subscriptions","organizations_url":"https://api.github.com/users/ysiraichi/orgs","repos_url":"https://api.github.com/users/ysiraichi/repos","events_url":"https://api.github.com/users/ysiraichi/events{/privacy}","received_events_url":"https://api.github.com/users/ysiraichi/received_events","type":"User","site_admin":false},"body":"This implements the error message discussed in #47744.\r\nWe check whether removing each `&` yields a type that satisfies the requested obligation.\r\nAlso, it was created a new `NodeId` field in `ObligationCause` in order to iterate through the `&`s. The way it's implemented now, it iterates through the obligation snippet and counts the number of `&`.\r\n\r\nr? @estebank ","created_at":"2018-03-08T01:14:02Z","updated_at":"2018-03-17T21:44:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f73b2728a28141c342bcf71c23b06f3051a8edaa","assignee":{"login":"estebank","id":1606434,"avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"assignees":[{"login":"estebank","id":1606434,"avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583436937,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-author","name":"S-waiting-on-author","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/48834/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/48834/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/48834/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/311e9acf7bb18742f22631e3081b68b3da6a0456","head":{"label":"ysiraichi:suggest-remove-ref","ref":"suggest-remove-ref","sha":"311e9acf7bb18742f22631e3081b68b3da6a0456","user":{"login":"ysiraichi","id":3337141,"avatar_url":"https://avatars3.githubusercontent.com/u/3337141?v=4","gravatar_id":"","url":"https://api.github.com/users/ysiraichi","html_url":"https://github.com/ysiraichi","followers_url":"https://api.github.com/users/ysiraichi/followers","following_url":"https://api.github.com/users/ysiraichi/following{/other_user}","gists_url":"https://api.github.com/users/ysiraichi/gists{/gist_id}","starred_url":"https://api.github.com/users/ysiraichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysiraichi/subscriptions","organizations_url":"https://api.github.com/users/ysiraichi/orgs","repos_url":"https://api.github.com/users/ysiraichi/repos","events_url":"https://api.github.com/users/ysiraichi/events{/privacy}","received_events_url":"https://api.github.com/users/ysiraichi/received_events","type":"User","site_admin":false},"repo":{"id":118956099,"name":"rust","full_name":"ysiraichi/rust","owner":{"login":"ysiraichi","id":3337141,"avatar_url":"https://avatars3.githubusercontent.com/u/3337141?v=4","gravatar_id":"","url":"https://api.github.com/users/ysiraichi","html_url":"https://github.com/ysiraichi","followers_url":"https://api.github.com/users/ysiraichi/followers","following_url":"https://api.github.com/users/ysiraichi/following{/other_user}","gists_url":"https://api.github.com/users/ysiraichi/gists{/gist_id}","starred_url":"https://api.github.com/users/ysiraichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysiraichi/subscriptions","organizations_url":"https://api.github.com/users/ysiraichi/orgs","repos_url":"https://api.github.com/users/ysiraichi/repos","events_url":"https://api.github.com/users/ysiraichi/events{/privacy}","received_events_url":"https://api.github.com/users/ysiraichi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ysiraichi/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/ysiraichi/rust","forks_url":"https://api.github.com/repos/ysiraichi/rust/forks","keys_url":"https://api.github.com/repos/ysiraichi/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ysiraichi/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ysiraichi/rust/teams","hooks_url":"https://api.github.com/repos/ysiraichi/rust/hooks","issue_events_url":"https://api.github.com/repos/ysiraichi/rust/issues/events{/number}","events_url":"https://api.github.com/repos/ysiraichi/rust/events","assignees_url":"https://api.github.com/repos/ysiraichi/rust/assignees{/user}","branches_url":"https://api.github.com/repos/ysiraichi/rust/branches{/branch}","tags_url":"https://api.github.com/repos/ysiraichi/rust/tags","blobs_url":"https://api.github.com/repos/ysiraichi/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ysiraichi/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ysiraichi/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/ysiraichi/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ysiraichi/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/ysiraichi/rust/languages","stargazers_url":"https://api.github.com/repos/ysiraichi/rust/stargazers","contributors_url":"https://api.github.com/repos/ysiraichi/rust/contributors","subscribers_url":"https://api.github.com/repos/ysiraichi/rust/subscribers","subscription_url":"https://api.github.com/repos/ysiraichi/rust/subscription","commits_url":"https://api.github.com/repos/ysiraichi/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/ysiraichi/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/ysiraichi/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/ysiraichi/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/ysiraichi/rust/contents/{+path}","compare_url":"https://api.github.com/repos/ysiraichi/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ysiraichi/rust/merges","archive_url":"https://api.github.com/repos/ysiraichi/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ysiraichi/rust/downloads","issues_url":"https://api.github.com/repos/ysiraichi/rust/issues{/number}","pulls_url":"https://api.github.com/repos/ysiraichi/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/ysiraichi/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/ysiraichi/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ysiraichi/rust/labels{/name}","releases_url":"https://api.github.com/repos/ysiraichi/rust/releases{/id}","deployments_url":"https://api.github.com/repos/ysiraichi/rust/deployments","created_at":"2018-01-25T19:12:15Z","updated_at":"2018-03-17T18:54:50Z","pushed_at":"2018-03-17T18:54:41Z","git_url":"git://github.com/ysiraichi/rust.git","ssh_url":"git@github.com:ysiraichi/rust.git","clone_url":"https://github.com/ysiraichi/rust.git","svn_url":"https://github.com/ysiraichi/rust","homepage":"https://www.rust-lang.org","size":351632,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"61b6bf54fdf56195baf9a8ee7383551b0d468c81","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-03-17T20:44:50Z","pushed_at":"2018-03-17T21:38:52Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":351711,"stargazers_count":27081,"watchers_count":27081,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4771,"mirror_url":null,"archived":false,"open_issues_count":3518,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4771,"open_issues":3518,"watchers":27081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48834"},"html":{"href":"https://github.com/rust-lang/rust/pull/48834"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/48834"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/48834/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48834/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48834/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/311e9acf7bb18742f22631e3081b68b3da6a0456"}},"author_association":"NONE"}}
{"actor":{"display_login":"estebank"}}