{"action":"created","comment":{"url":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/comments/236091734","pull_request_review_id":178098973,"id":236091734,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA5MTczNA==","diff_hunk":"@@ -2,51 +2,14 @@\n \n import os\n \n-from setuptools import find_packages, setup\n+import setuptools\n \n-\n-def get_requirements():\n-    with open(\"./requirements.txt\") as file:\n-        return file.readlines()\n+# version = {}\n \n # https://packaging.python.org/guides/single-sourcing-package-version/\n-version = {}\n-with open(\"./ansible_bender/version.py\") as fp:\n-    exec(fp.read(), version)\n-\n-long_description = ''.join(open('README.md').readlines())\n-\n+# with open(\"./ansible_bender/version.py\") as fp:\n+#     exec(fp.read(), version)\n+# setup_params[\"use_scm_version\"] = True\n+# setup_params[\"version\"] = version[\"__version__\"]\n \n-setup(\n-    name='ansible-bender',\n-    version=version[\"__version__\"],\n-    description=\"A tool which builds container images using Ansible playbooks.\",\n-    long_description=long_description,\n-    # long_description_content_type='text/markdown',\n-    packages=find_packages(exclude=['tests']),\n-    python_requires='>=3.6',\n-    install_requires=get_requirements(),\n-    entry_points='''\n-        [console_scripts]\n-        ab=ansible_bender.cli:main\n-    ''',\n-    license='MIT',\n-    classifiers=[\n-        'Development Status :: 4 - Beta',\n-        'Environment :: Console',\n-        'Intended Audience :: Developers',\n-        'License :: OSI Approved :: MIT License',\n-        'Operating System :: POSIX :: Linux',\n-        'Programming Language :: Python',\n-        'Programming Language :: Python :: 3.5',\n-        'Programming Language :: Python :: 3.6',\n-        'Programming Language :: Python :: 3.7',\n-        'Topic :: Software Development',\n-        'Topic :: Utilities',\n-    ],\n-    keywords='containers,ansible,buildah',\n-    author='Tomas Tomecek',\n-    author_email='tomas@tomecek.net',\n-    url='https://github.com/TomasTomecek/ansible-bender',\n-    include_package_data=True,\n-)\n+setuptools.setup()","path":"setup.py","position":58,"original_position":58,"commit_id":"2ba35b6be8a4ae5bed93c14e037e5918899a544a","original_commit_id":"b8468f5bc75684e64f8147348154c7107b320939","user":{"login":"webknjaz","id":578543,"node_id":"MDQ6VXNlcjU3ODU0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/578543?v=4","gravatar_id":"","url":"https://api.github.com/users/webknjaz","html_url":"https://github.com/webknjaz","followers_url":"https://api.github.com/users/webknjaz/followers","following_url":"https://api.github.com/users/webknjaz/following{/other_user}","gists_url":"https://api.github.com/users/webknjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/webknjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webknjaz/subscriptions","organizations_url":"https://api.github.com/users/webknjaz/orgs","repos_url":"https://api.github.com/users/webknjaz/repos","events_url":"https://api.github.com/users/webknjaz/events{/privacy}","received_events_url":"https://api.github.com/users/webknjaz/received_events","type":"User","site_admin":false},"body":"You're welcome :)","created_at":"2018-11-25T21:54:31Z","updated_at":"2018-11-25T21:54:31Z","html_url":"https://github.com/TomasTomecek/ansible-bender/pull/29#discussion_r236091734","pull_request_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/29","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/comments/236091734"},"html":{"href":"https://github.com/TomasTomecek/ansible-bender/pull/29#discussion_r236091734"},"pull_request":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/29"}},"in_reply_to_id":236090067},"pull_request":{"url":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/29","id":232955657,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTU1NjU3","html_url":"https://github.com/TomasTomecek/ansible-bender/pull/29","diff_url":"https://github.com/TomasTomecek/ansible-bender/pull/29.diff","patch_url":"https://github.com/TomasTomecek/ansible-bender/pull/29.patch","issue_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues/29","number":29,"state":"open","locked":false,"title":"Better python packaging","user":{"login":"TomasTomecek","id":1662493,"node_id":"MDQ6VXNlcjE2NjI0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1662493?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasTomecek","html_url":"https://github.com/TomasTomecek","followers_url":"https://api.github.com/users/TomasTomecek/followers","following_url":"https://api.github.com/users/TomasTomecek/following{/other_user}","gists_url":"https://api.github.com/users/TomasTomecek/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasTomecek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasTomecek/subscriptions","organizations_url":"https://api.github.com/users/TomasTomecek/orgs","repos_url":"https://api.github.com/users/TomasTomecek/repos","events_url":"https://api.github.com/users/TomasTomecek/events{/privacy}","received_events_url":"https://api.github.com/users/TomasTomecek/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-22T12:02:07Z","updated_at":"2018-11-25T21:54:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f91b5f323a43ac1c381ec827fb811d3975b435e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/29/commits","review_comments_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/29/comments","review_comment_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues/29/comments","statuses_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/statuses/2ba35b6be8a4ae5bed93c14e037e5918899a544a","head":{"label":"TomasTomecek:better-python-packaging","ref":"better-python-packaging","sha":"2ba35b6be8a4ae5bed93c14e037e5918899a544a","user":{"login":"TomasTomecek","id":1662493,"node_id":"MDQ6VXNlcjE2NjI0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1662493?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasTomecek","html_url":"https://github.com/TomasTomecek","followers_url":"https://api.github.com/users/TomasTomecek/followers","following_url":"https://api.github.com/users/TomasTomecek/following{/other_user}","gists_url":"https://api.github.com/users/TomasTomecek/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasTomecek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasTomecek/subscriptions","organizations_url":"https://api.github.com/users/TomasTomecek/orgs","repos_url":"https://api.github.com/users/TomasTomecek/repos","events_url":"https://api.github.com/users/TomasTomecek/events{/privacy}","received_events_url":"https://api.github.com/users/TomasTomecek/received_events","type":"User","site_admin":false},"repo":{"id":144737452,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3Mzc0NTI=","name":"ansible-bender","full_name":"TomasTomecek/ansible-bender","private":false,"owner":{"login":"TomasTomecek","id":1662493,"node_id":"MDQ6VXNlcjE2NjI0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1662493?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasTomecek","html_url":"https://github.com/TomasTomecek","followers_url":"https://api.github.com/users/TomasTomecek/followers","following_url":"https://api.github.com/users/TomasTomecek/following{/other_user}","gists_url":"https://api.github.com/users/TomasTomecek/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasTomecek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasTomecek/subscriptions","organizations_url":"https://api.github.com/users/TomasTomecek/orgs","repos_url":"https://api.github.com/users/TomasTomecek/repos","events_url":"https://api.github.com/users/TomasTomecek/events{/privacy}","received_events_url":"https://api.github.com/users/TomasTomecek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TomasTomecek/ansible-bender","description":"ansible-playbook + buildah = a sweet container image","fork":false,"url":"https://api.github.com/repos/TomasTomecek/ansible-bender","forks_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/forks","keys_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/teams","hooks_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/hooks","issue_events_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues/events{/number}","events_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/events","assignees_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/assignees{/user}","branches_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/branches{/branch}","tags_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/tags","blobs_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/statuses/{sha}","languages_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/languages","stargazers_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/stargazers","contributors_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/contributors","subscribers_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/subscribers","subscription_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/subscription","commits_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/contents/{+path}","compare_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/merges","archive_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/downloads","issues_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues{/number}","pulls_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls{/number}","milestones_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/milestones{/number}","notifications_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/labels{/name}","releases_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/releases{/id}","deployments_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/deployments","created_at":"2018-08-14T15:16:14Z","updated_at":"2018-11-19T15:54:49Z","pushed_at":"2018-11-25T21:51:10Z","git_url":"git://github.com/TomasTomecek/ansible-bender.git","ssh_url":"git@github.com:TomasTomecek/ansible-bender.git","clone_url":"https://github.com/TomasTomecek/ansible-bender.git","svn_url":"https://github.com/TomasTomecek/ansible-bender","homepage":"","size":139,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":10,"watchers":26,"default_branch":"master"}},"base":{"label":"TomasTomecek:master","ref":"master","sha":"2a1656704487ee010d1b0f40dd260dc134133525","user":{"login":"TomasTomecek","id":1662493,"node_id":"MDQ6VXNlcjE2NjI0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1662493?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasTomecek","html_url":"https://github.com/TomasTomecek","followers_url":"https://api.github.com/users/TomasTomecek/followers","following_url":"https://api.github.com/users/TomasTomecek/following{/other_user}","gists_url":"https://api.github.com/users/TomasTomecek/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasTomecek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasTomecek/subscriptions","organizations_url":"https://api.github.com/users/TomasTomecek/orgs","repos_url":"https://api.github.com/users/TomasTomecek/repos","events_url":"https://api.github.com/users/TomasTomecek/events{/privacy}","received_events_url":"https://api.github.com/users/TomasTomecek/received_events","type":"User","site_admin":false},"repo":{"id":144737452,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3Mzc0NTI=","name":"ansible-bender","full_name":"TomasTomecek/ansible-bender","private":false,"owner":{"login":"TomasTomecek","id":1662493,"node_id":"MDQ6VXNlcjE2NjI0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1662493?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasTomecek","html_url":"https://github.com/TomasTomecek","followers_url":"https://api.github.com/users/TomasTomecek/followers","following_url":"https://api.github.com/users/TomasTomecek/following{/other_user}","gists_url":"https://api.github.com/users/TomasTomecek/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasTomecek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasTomecek/subscriptions","organizations_url":"https://api.github.com/users/TomasTomecek/orgs","repos_url":"https://api.github.com/users/TomasTomecek/repos","events_url":"https://api.github.com/users/TomasTomecek/events{/privacy}","received_events_url":"https://api.github.com/users/TomasTomecek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TomasTomecek/ansible-bender","description":"ansible-playbook + buildah = a sweet container image","fork":false,"url":"https://api.github.com/repos/TomasTomecek/ansible-bender","forks_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/forks","keys_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/teams","hooks_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/hooks","issue_events_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues/events{/number}","events_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/events","assignees_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/assignees{/user}","branches_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/branches{/branch}","tags_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/tags","blobs_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/statuses/{sha}","languages_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/languages","stargazers_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/stargazers","contributors_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/contributors","subscribers_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/subscribers","subscription_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/subscription","commits_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/contents/{+path}","compare_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/merges","archive_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/downloads","issues_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues{/number}","pulls_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls{/number}","milestones_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/milestones{/number}","notifications_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/labels{/name}","releases_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/releases{/id}","deployments_url":"https://api.github.com/repos/TomasTomecek/ansible-bender/deployments","created_at":"2018-08-14T15:16:14Z","updated_at":"2018-11-19T15:54:49Z","pushed_at":"2018-11-25T21:51:10Z","git_url":"git://github.com/TomasTomecek/ansible-bender.git","ssh_url":"git@github.com:TomasTomecek/ansible-bender.git","clone_url":"https://github.com/TomasTomecek/ansible-bender.git","svn_url":"https://github.com/TomasTomecek/ansible-bender","homepage":"","size":139,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":10,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/29"},"html":{"href":"https://github.com/TomasTomecek/ansible-bender/pull/29"},"issue":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues/29"},"comments":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/TomasTomecek/ansible-bender/statuses/2ba35b6be8a4ae5bed93c14e037e5918899a544a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"webknjaz"}}