{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/236096227","pull_request_review_id":178103534,"id":236096227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA5NjIyNw==","diff_hunk":"@@ -198,24 +197,26 @@ bool ControllerEngine::isReady() {\n \n void ControllerEngine::initializeScriptEngine() {\n     // Create the Script Engine\n-    m_pEngine = new QScriptEngine(this);\n+    m_pEngine = new QJSEngine(this);\n \n     // Make this ControllerEngine instance available to scripts as 'engine'.\n-    QScriptValue engineGlobalObject = m_pEngine->globalObject();\n-    engineGlobalObject.setProperty(\"engine\", m_pEngine->newQObject(this));\n+    QJSValue engineGlobalObject = m_pEngine->globalObject();\n+    ControllerEngineJSProxy* proxy = new ControllerEngineJSProxy(this);\n+    engineGlobalObject.setProperty(\"engine\", m_pEngine->newQObject(proxy));\n \n     if (m_pController) {\n         qDebug() << \"Controller in script engine is:\" << m_pController->getName();\n \n+        ControllerJSProxy* controllerProxy = new ControllerJSProxy(m_pController);","path":"src/controllers/engine/controllerengine.cpp","position":156,"original_position":149,"commit_id":"b69b9b934486d2569a9b94ce7ba9a855c57b74d3","original_commit_id":"6a8f52b916d93dbf9fc262965b2255956fa0378f","user":{"login":"Be-ing","id":9455094,"node_id":"MDQ6VXNlcjk0NTUwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9455094?v=4","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"body":"`m_pController` is private in ControllerJSProxy, so it shouldn't be accessible to subclasses anyway. You could store the MidiController* pointer as a different private member of MidiControllerJSProxy.","created_at":"2018-11-25T23:32:19Z","updated_at":"2018-11-25T23:32:19Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1795#discussion_r236096227","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1795","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/236096227"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1795#discussion_r236096227"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1795"}},"in_reply_to_id":235574396},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1795","id":212114405,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTE0NDA1","html_url":"https://github.com/mixxxdj/mixxx/pull/1795","diff_url":"https://github.com/mixxxdj/mixxx/pull/1795.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1795.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1795","number":1795,"state":"open","locked":false,"title":"[WIP] Migrate to QJSEngine","user":{"login":"ferranpujolcamins","id":6429775,"node_id":"MDQ6VXNlcjY0Mjk3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6429775?v=4","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"body":"### To do\r\n- [ ] Testing\r\n- [ ] Add unit tests?\r\n- [ ] Install svg extension manually\r\n- [x] Replace QByteArray\r\n- [ ] Completely remove QtScript classes\r\n- [ ] Check TODOs","created_at":"2018-08-30T15:10:20Z","updated_at":"2018-11-25T23:32:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcc260351affdeb2bb3f774764073ad5ec46f842","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1795/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1795/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1795/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/b69b9b934486d2569a9b94ce7ba9a855c57b74d3","head":{"label":"ferranpujolcamins:migrate-to-QJSEngine","ref":"migrate-to-QJSEngine","sha":"b69b9b934486d2569a9b94ce7ba9a855c57b74d3","user":{"login":"ferranpujolcamins","id":6429775,"node_id":"MDQ6VXNlcjY0Mjk3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6429775?v=4","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"repo":{"id":24024558,"node_id":"MDEwOlJlcG9zaXRvcnkyNDAyNDU1OA==","name":"mixxx","full_name":"ferranpujolcamins/mixxx","private":false,"owner":{"login":"ferranpujolcamins","id":6429775,"node_id":"MDQ6VXNlcjY0Mjk3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6429775?v=4","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ferranpujolcamins/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/ferranpujolcamins/mixxx","forks_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/forks","keys_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/teams","hooks_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/hooks","issue_events_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/events","assignees_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/tags","blobs_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/languages","stargazers_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/stargazers","contributors_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/contributors","subscribers_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/subscribers","subscription_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/subscription","commits_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/merges","archive_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/downloads","issues_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/deployments","created_at":"2014-09-14T14:51:40Z","updated_at":"2018-11-25T18:44:24Z","pushed_at":"2018-11-25T22:09:48Z","git_url":"git://github.com/ferranpujolcamins/mixxx.git","ssh_url":"git@github.com:ferranpujolcamins/mixxx.git","clone_url":"https://github.com/ferranpujolcamins/mixxx.git","svn_url":"https://github.com/ferranpujolcamins/mixxx","homepage":"http://mixxx.org","size":295834,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"fea7960b43655b607d637ae5b1902a84f7c6e189","user":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjAzMQ==","name":"mixxx","full_name":"mixxxdj/mixxx","private":false,"owner":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2018-11-24T16:32:16Z","pushed_at":"2018-11-25T22:09:50Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":299057,"stargazers_count":1156,"watchers_count":1156,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":542,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":542,"open_issues":98,"watchers":1156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1795"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1795"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1795"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1795/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1795/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1795/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/b69b9b934486d2569a9b94ce7ba9a855c57b74d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Be-ing"}}