{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/205930528","pull_request_review_id":141304982,"id":205930528,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTkzMDUyOA==","diff_hunk":"@@ -1281,7 +1269,7 @@ bool GMainWindow::ConfirmClose() {\n         return true;\n \n     QMessageBox::StandardButton answer =\n-        QMessageBox::question(this, tr(\"Citra\"), tr(\"Are you sure you want to close Citra?\"),\n+        QMessageBox::question(this, tr(\"Citra\"), tr(\"Would you like to exit now?\"),","path":"src/citra_qt/main.cpp","position":266,"original_position":266,"commit_id":"3f2363d0aa21ed7d564b1387a8fbfac3d83f5dd8","original_commit_id":"3f2363d0aa21ed7d564b1387a8fbfac3d83f5dd8","user":{"login":"Dragios","id":18496868,"node_id":"MDQ6VXNlcjE4NDk2ODY4","avatar_url":"https://avatars3.githubusercontent.com/u/18496868?v=4","gravatar_id":"","url":"https://api.github.com/users/Dragios","html_url":"https://github.com/Dragios","followers_url":"https://api.github.com/users/Dragios/followers","following_url":"https://api.github.com/users/Dragios/following{/other_user}","gists_url":"https://api.github.com/users/Dragios/gists{/gist_id}","starred_url":"https://api.github.com/users/Dragios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dragios/subscriptions","organizations_url":"https://api.github.com/users/Dragios/orgs","repos_url":"https://api.github.com/users/Dragios/repos","events_url":"https://api.github.com/users/Dragios/events{/privacy}","received_events_url":"https://api.github.com/users/Dragios/received_events","type":"User","site_admin":false},"body":"Ditto","created_at":"2018-07-28T02:51:47Z","updated_at":"2018-07-28T02:52:49Z","html_url":"https://github.com/citra-emu/citra/pull/4012#discussion_r205930528","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/4012","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/205930528"},"html":{"href":"https://github.com/citra-emu/citra/pull/4012#discussion_r205930528"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/4012"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/4012","id":204457456,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDU3NDU2","html_url":"https://github.com/citra-emu/citra/pull/4012","diff_url":"https://github.com/citra-emu/citra/pull/4012.diff","patch_url":"https://github.com/citra-emu/citra/pull/4012.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/4012","number":4012,"state":"open","locked":false,"title":"citra_qt: UI text improvements","user":{"login":"zhaowenlan1779","id":21307832,"node_id":"MDQ6VXNlcjIxMzA3ODMy","avatar_url":"https://avatars0.githubusercontent.com/u/21307832?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaowenlan1779","html_url":"https://github.com/zhaowenlan1779","followers_url":"https://api.github.com/users/zhaowenlan1779/followers","following_url":"https://api.github.com/users/zhaowenlan1779/following{/other_user}","gists_url":"https://api.github.com/users/zhaowenlan1779/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaowenlan1779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaowenlan1779/subscriptions","organizations_url":"https://api.github.com/users/zhaowenlan1779/orgs","repos_url":"https://api.github.com/users/zhaowenlan1779/repos","events_url":"https://api.github.com/users/zhaowenlan1779/events{/privacy}","received_events_url":"https://api.github.com/users/zhaowenlan1779/received_events","type":"User","site_admin":false},"body":"Changed a few texts that are not so good in the UI according to @neobrain.\r\n\r\nThis should just be a Part 1.\r\n\r\n# Principles I follow:\r\n1. Users do not read long text, so text should be as simple and short as possible\r\n1. Title should be in title case, and should not be sentences\r\n1. Provide some help/action for the users. For example I guided users to redump their games when the ROM is invalid, instead of just displaying the error message.\r\n\r\n# Major changes:\r\n## Telemetry\r\n### Old:\r\n![image](https://user-images.githubusercontent.com/21307832/43351143-774567ce-9240-11e8-850f-66389bb75958.png)\r\n### New:\r\n![image](https://user-images.githubusercontent.com/21307832/43351197-48683c6e-9241-11e8-9ed9-029342c4988a.png)\r\n### Note:\r\n1. Text too long.\r\n1. Not actionable.\r\n1. opt-out, not opt-in. \r\n\r\nalthough 2 and 3 seems to be @bunnei's design\r\n## Missing System Archives\r\n### Old:\r\n![image](https://user-images.githubusercontent.com/21307832/43351162-d00d36a2-9240-11e8-83fc-033e9e993eb8.png)\r\n### New:\r\n![image](https://user-images.githubusercontent.com/21307832/43351209-73099bc0-9241-11e8-9e0f-8b843279844c.png)\r\n### Note:\r\n1. Text too long.\r\n1. Icon not proper.\r\n## Fatal Error\r\n### Old:\r\n![image](https://user-images.githubusercontent.com/21307832/43351178-2e5317b8-9241-11e8-9db9-4abbd45addbb.png)\r\n### New:\r\n![image](https://user-images.githubusercontent.com/21307832/43351214-78ea2f14-9241-11e8-98d5-2e2f54e91536.png)\r\n### Note:\r\n1. Text too long.\r\n1. Icon not proper.\r\n## Invalid ROM Format\r\n### Old:\r\n![image](https://user-images.githubusercontent.com/21307832/43351252-dbb6f4f6-9241-11e8-8aad-998941d33bd3.png)\r\n### New:\r\n![image](https://user-images.githubusercontent.com/21307832/43351255-e6d70664-9241-11e8-89d5-68ad35594d77.png)\r\n### Note:\r\n1. No guidance on how to solve the problem.\r\n1. Title is not in title case.\r\n## Could not determine system mode\r\n### Old:\r\n![image](https://user-images.githubusercontent.com/21307832/43351267-097713da-9242-11e8-9089-e957940c553a.png)\r\n### New:\r\n![image](https://user-images.githubusercontent.com/21307832/43351271-10716fd2-9242-11e8-9fa1-599a0f23c66a.png)\r\n### Note:\r\n1. Users would not know what is \"system mode\"\r\n1. No guidance on how to solve the problem\r\n1. Title is not in title case.\r\n## Encrypted ROM\r\nSimilar to the above two, I guided the users to redump their ROMs with a short message.\r\n## OpenGL 3.3\r\nChanged the title. The message seems ok.\r\n## Video Core Error\r\nEdited the message to something similar to \"Fatal Error\". Changed the title to title case.\r\n## Misc.\r\nThere are also some other minor changes to the texts.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/citra-emu/citra/4012)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-07-27T15:00:10Z","updated_at":"2018-07-28T02:52:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02628dd8f01ae5bcff396343e8f3d8abfe6c6771","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/4012/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/4012/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/4012/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/3f2363d0aa21ed7d564b1387a8fbfac3d83f5dd8","head":{"label":"zhaowenlan1779:ui-retext","ref":"ui-retext","sha":"3f2363d0aa21ed7d564b1387a8fbfac3d83f5dd8","user":{"login":"zhaowenlan1779","id":21307832,"node_id":"MDQ6VXNlcjIxMzA3ODMy","avatar_url":"https://avatars0.githubusercontent.com/u/21307832?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaowenlan1779","html_url":"https://github.com/zhaowenlan1779","followers_url":"https://api.github.com/users/zhaowenlan1779/followers","following_url":"https://api.github.com/users/zhaowenlan1779/following{/other_user}","gists_url":"https://api.github.com/users/zhaowenlan1779/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaowenlan1779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaowenlan1779/subscriptions","organizations_url":"https://api.github.com/users/zhaowenlan1779/orgs","repos_url":"https://api.github.com/users/zhaowenlan1779/repos","events_url":"https://api.github.com/users/zhaowenlan1779/events{/privacy}","received_events_url":"https://api.github.com/users/zhaowenlan1779/received_events","type":"User","site_admin":false},"repo":{"id":125487547,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU0ODc1NDc=","name":"citra","full_name":"zhaowenlan1779/citra","owner":{"login":"zhaowenlan1779","id":21307832,"node_id":"MDQ6VXNlcjIxMzA3ODMy","avatar_url":"https://avatars0.githubusercontent.com/u/21307832?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaowenlan1779","html_url":"https://github.com/zhaowenlan1779","followers_url":"https://api.github.com/users/zhaowenlan1779/followers","following_url":"https://api.github.com/users/zhaowenlan1779/following{/other_user}","gists_url":"https://api.github.com/users/zhaowenlan1779/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaowenlan1779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaowenlan1779/subscriptions","organizations_url":"https://api.github.com/users/zhaowenlan1779/orgs","repos_url":"https://api.github.com/users/zhaowenlan1779/repos","events_url":"https://api.github.com/users/zhaowenlan1779/events{/privacy}","received_events_url":"https://api.github.com/users/zhaowenlan1779/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhaowenlan1779/citra","description":"A Nintendo 3DS Emulator","fork":true,"url":"https://api.github.com/repos/zhaowenlan1779/citra","forks_url":"https://api.github.com/repos/zhaowenlan1779/citra/forks","keys_url":"https://api.github.com/repos/zhaowenlan1779/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhaowenlan1779/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhaowenlan1779/citra/teams","hooks_url":"https://api.github.com/repos/zhaowenlan1779/citra/hooks","issue_events_url":"https://api.github.com/repos/zhaowenlan1779/citra/issues/events{/number}","events_url":"https://api.github.com/repos/zhaowenlan1779/citra/events","assignees_url":"https://api.github.com/repos/zhaowenlan1779/citra/assignees{/user}","branches_url":"https://api.github.com/repos/zhaowenlan1779/citra/branches{/branch}","tags_url":"https://api.github.com/repos/zhaowenlan1779/citra/tags","blobs_url":"https://api.github.com/repos/zhaowenlan1779/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhaowenlan1779/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhaowenlan1779/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhaowenlan1779/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhaowenlan1779/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/zhaowenlan1779/citra/languages","stargazers_url":"https://api.github.com/repos/zhaowenlan1779/citra/stargazers","contributors_url":"https://api.github.com/repos/zhaowenlan1779/citra/contributors","subscribers_url":"https://api.github.com/repos/zhaowenlan1779/citra/subscribers","subscription_url":"https://api.github.com/repos/zhaowenlan1779/citra/subscription","commits_url":"https://api.github.com/repos/zhaowenlan1779/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhaowenlan1779/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhaowenlan1779/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhaowenlan1779/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhaowenlan1779/citra/contents/{+path}","compare_url":"https://api.github.com/repos/zhaowenlan1779/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhaowenlan1779/citra/merges","archive_url":"https://api.github.com/repos/zhaowenlan1779/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhaowenlan1779/citra/downloads","issues_url":"https://api.github.com/repos/zhaowenlan1779/citra/issues{/number}","pulls_url":"https://api.github.com/repos/zhaowenlan1779/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/zhaowenlan1779/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/zhaowenlan1779/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhaowenlan1779/citra/labels{/name}","releases_url":"https://api.github.com/repos/zhaowenlan1779/citra/releases{/id}","deployments_url":"https://api.github.com/repos/zhaowenlan1779/citra/deployments","created_at":"2018-03-16T08:35:25Z","updated_at":"2018-07-26T06:21:52Z","pushed_at":"2018-07-28T02:39:43Z","git_url":"git://github.com/zhaowenlan1779/citra.git","ssh_url":"git@github.com:zhaowenlan1779/citra.git","clone_url":"https://github.com/zhaowenlan1779/citra.git","svn_url":"https://github.com/zhaowenlan1779/citra","homepage":"https://citra-emu.org","size":23620,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"5c52c6e64ace3df4990363dd959835ef56a450fd","user":{"login":"citra-emu","id":7605670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDU2NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg2NjczMA==","name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDU2NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"A Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2018-07-27T18:45:49Z","pushed_at":"2018-07-27T23:31:06Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":37385,"stargazers_count":4136,"watchers_count":4136,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":926,"mirror_url":null,"archived":false,"open_issues_count":373,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":926,"open_issues":373,"watchers":4136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/4012"},"html":{"href":"https://github.com/citra-emu/citra/pull/4012"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/4012"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/4012/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/4012/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/4012/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/3f2363d0aa21ed7d564b1387a8fbfac3d83f5dd8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Dragios"}}