{"action":"created","issue":{"url":"https://api.github.com/repos/runatlantis/atlantis/issues/338","repository_url":"https://api.github.com/repos/runatlantis/atlantis","labels_url":"https://api.github.com/repos/runatlantis/atlantis/issues/338/labels{/name}","comments_url":"https://api.github.com/repos/runatlantis/atlantis/issues/338/comments","events_url":"https://api.github.com/repos/runatlantis/atlantis/issues/338/events","html_url":"https://github.com/runatlantis/atlantis/pull/338","id":375624678,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDI3NjQy","number":338,"title":"Allow slashes in project names","user":{"login":"lkysow","id":1034429,"node_id":"MDQ6VXNlcjEwMzQ0Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1034429?v=4","gravatar_id":"","url":"https://api.github.com/users/lkysow","html_url":"https://github.com/lkysow","followers_url":"https://api.github.com/users/lkysow/followers","following_url":"https://api.github.com/users/lkysow/following{/other_user}","gists_url":"https://api.github.com/users/lkysow/gists{/gist_id}","starred_url":"https://api.github.com/users/lkysow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkysow/subscriptions","organizations_url":"https://api.github.com/users/lkysow/orgs","repos_url":"https://api.github.com/users/lkysow/repos","events_url":"https://api.github.com/users/lkysow/events{/privacy}","received_events_url":"https://api.github.com/users/lkysow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-30T18:08:55Z","updated_at":"2018-10-30T18:09:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/runatlantis/atlantis/pulls/338","html_url":"https://github.com/runatlantis/atlantis/pull/338","diff_url":"https://github.com/runatlantis/atlantis/pull/338.diff","patch_url":"https://github.com/runatlantis/atlantis/pull/338.patch"},"body":"Allow the project name in `atlantis.yaml` file to contain slashes:\r\n```yaml\r\nprojects:\r\n- dir: terraform/myservice\r\n  name: terraform/myservice\r\n```\r\n\r\nAlso in this PR:\r\n* Validate project names to ensure they don't contain invalid characters\r\n* Ensure the planfile names (which are generated from the project names) don't contain invalid filename chars\r\n\r\nNotes\r\n* With commit from @johnlinvc in #319. I've added the validation of the config file and also changed the allowed filename chars regex\r\n* Made change recommended by @kipkoan to only remove invalid filename chars\r\n* Fixes #253"},"comment":{"url":"https://api.github.com/repos/runatlantis/atlantis/issues/comments/434410987","html_url":"https://github.com/runatlantis/atlantis/pull/338#issuecomment-434410987","issue_url":"https://api.github.com/repos/runatlantis/atlantis/issues/338","id":434410987,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDQxMDk4Nw==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-30T18:09:50Z","updated_at":"2018-10-30T18:09:50Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/runatlantis/atlantis/pull/338?src=pr&el=h1) Report\n> Merging [#338](https://codecov.io/gh/runatlantis/atlantis/pull/338?src=pr&el=desc) into [master](https://codecov.io/gh/runatlantis/atlantis/commit/a91af8bc46f1b5064f3e20067925da5eefafe472?src=pr&el=desc) will **increase** coverage by `0.06%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/runatlantis/atlantis/pull/338/graphs/tree.svg?width=650&token=d8xUyu4k4B&height=150&src=pr)](https://codecov.io/gh/runatlantis/atlantis/pull/338?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #338      +/-   ##\n==========================================\n+ Coverage   70.57%   70.63%   +0.06%     \n==========================================\n  Files          61       61              \n  Lines        3643     3651       +8     \n==========================================\n+ Hits         2571     2579       +8     \n  Misses        893      893              \n  Partials      179      179\n```\n\n\n| [Impacted Files](https://codecov.io/gh/runatlantis/atlantis/pull/338?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [server/events/yaml/raw/project.go](https://codecov.io/gh/runatlantis/atlantis/pull/338/diff?src=pr&el=tree#diff-c2VydmVyL2V2ZW50cy95YW1sL3Jhdy9wcm9qZWN0Lmdv) | `100% <100%> (ø)` | :arrow_up: |\n| [server/events/runtime/runtime.go](https://codecov.io/gh/runatlantis/atlantis/pull/338/diff?src=pr&el=tree#diff-c2VydmVyL2V2ZW50cy9ydW50aW1lL3J1bnRpbWUuZ28=) | `83.33% <100%> (+5.55%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/runatlantis/atlantis/pull/338?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/runatlantis/atlantis/pull/338?src=pr&el=footer). Last update [a91af8b...2d214b2](https://codecov.io/gh/runatlantis/atlantis/pull/338?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}