{"action":"created","comment":{"url":"https://api.github.com/repos/sous-chefs/haproxy/pulls/comments/208709385","pull_request_review_id":144576459,"id":208709385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODcwOTM4NQ==","diff_hunk":"@@ -26,7 +26,7 @@ global\n   daemon\n <% end -%>\n   <%= @global['debug_option'] %>\n-<% @global['stats'].each do |option, value| -%>\n+<% @global['stats']&.each do |option, value| -%>","path":"templates/default/haproxy.cfg.erb","position":5,"original_position":5,"commit_id":"620318db408e9a2fabb30215b45b7d0e3a0d4b4b","original_commit_id":"620318db408e9a2fabb30215b45b7d0e3a0d4b4b","user":{"login":"damacus","id":40786,"node_id":"MDQ6VXNlcjQwNzg2","avatar_url":"https://avatars1.githubusercontent.com/u/40786?v=4","gravatar_id":"","url":"https://api.github.com/users/damacus","html_url":"https://github.com/damacus","followers_url":"https://api.github.com/users/damacus/followers","following_url":"https://api.github.com/users/damacus/following{/other_user}","gists_url":"https://api.github.com/users/damacus/gists{/gist_id}","starred_url":"https://api.github.com/users/damacus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damacus/subscriptions","organizations_url":"https://api.github.com/users/damacus/orgs","repos_url":"https://api.github.com/users/damacus/repos","events_url":"https://api.github.com/users/damacus/events{/privacy}","received_events_url":"https://api.github.com/users/damacus/received_events","type":"User","site_admin":false},"body":"Excuse my Ruby/IRB ignorance here, what do this do? ","created_at":"2018-08-08T19:40:42Z","updated_at":"2018-08-08T19:40:42Z","html_url":"https://github.com/sous-chefs/haproxy/pull/308#discussion_r208709385","pull_request_url":"https://api.github.com/repos/sous-chefs/haproxy/pulls/308","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sous-chefs/haproxy/pulls/comments/208709385"},"html":{"href":"https://github.com/sous-chefs/haproxy/pull/308#discussion_r208709385"},"pull_request":{"href":"https://api.github.com/repos/sous-chefs/haproxy/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/sous-chefs/haproxy/pulls/308","id":207020961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDIwOTYx","html_url":"https://github.com/sous-chefs/haproxy/pull/308","diff_url":"https://github.com/sous-chefs/haproxy/pull/308.diff","patch_url":"https://github.com/sous-chefs/haproxy/pull/308.patch","issue_url":"https://api.github.com/repos/sous-chefs/haproxy/issues/308","number":308,"state":"open","locked":false,"title":"removed a couple default values from resources properties ","user":{"login":"Stromweld","id":3476391,"node_id":"MDQ6VXNlcjM0NzYzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3476391?v=4","gravatar_id":"","url":"https://api.github.com/users/Stromweld","html_url":"https://github.com/Stromweld","followers_url":"https://api.github.com/users/Stromweld/followers","following_url":"https://api.github.com/users/Stromweld/following{/other_user}","gists_url":"https://api.github.com/users/Stromweld/gists{/gist_id}","starred_url":"https://api.github.com/users/Stromweld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stromweld/subscriptions","organizations_url":"https://api.github.com/users/Stromweld/orgs","repos_url":"https://api.github.com/users/Stromweld/repos","events_url":"https://api.github.com/users/Stromweld/events{/privacy}","received_events_url":"https://api.github.com/users/Stromweld/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nRemoved a couple of default values from resource properties and added reload example to haproxy_service section of readme. Default values were removed so if they are defined in the default section of the haproxy.cfg file they can be inherited automatically by listeners, frontends, etc... With property specifying a default then it would put that config piece in the listener even if you intended it to be inherited from the default config section.\r\n\r\n### Contribution Check List\r\n\r\n- [x] All tests pass.\r\n- [x] New functionality includes testing.\r\n- [x] New functionality has been documented in the README if applicable","created_at":"2018-08-08T14:08:55Z","updated_at":"2018-08-08T19:40:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a8e9756595ba1d882c72e6a8fec92daa4623bf1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rshade","id":131337,"node_id":"MDQ6VXNlcjEzMTMzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/131337?v=4","gravatar_id":"","url":"https://api.github.com/users/rshade","html_url":"https://github.com/rshade","followers_url":"https://api.github.com/users/rshade/followers","following_url":"https://api.github.com/users/rshade/following{/other_user}","gists_url":"https://api.github.com/users/rshade/gists{/gist_id}","starred_url":"https://api.github.com/users/rshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshade/subscriptions","organizations_url":"https://api.github.com/users/rshade/orgs","repos_url":"https://api.github.com/users/rshade/repos","events_url":"https://api.github.com/users/rshade/events{/privacy}","received_events_url":"https://api.github.com/users/rshade/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sous-chefs/haproxy/pulls/308/commits","review_comments_url":"https://api.github.com/repos/sous-chefs/haproxy/pulls/308/comments","review_comment_url":"https://api.github.com/repos/sous-chefs/haproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sous-chefs/haproxy/issues/308/comments","statuses_url":"https://api.github.com/repos/sous-chefs/haproxy/statuses/620318db408e9a2fabb30215b45b7d0e3a0d4b4b","head":{"label":"Stromweld:master","ref":"master","sha":"620318db408e9a2fabb30215b45b7d0e3a0d4b4b","user":{"login":"Stromweld","id":3476391,"node_id":"MDQ6VXNlcjM0NzYzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3476391?v=4","gravatar_id":"","url":"https://api.github.com/users/Stromweld","html_url":"https://github.com/Stromweld","followers_url":"https://api.github.com/users/Stromweld/followers","following_url":"https://api.github.com/users/Stromweld/following{/other_user}","gists_url":"https://api.github.com/users/Stromweld/gists{/gist_id}","starred_url":"https://api.github.com/users/Stromweld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stromweld/subscriptions","organizations_url":"https://api.github.com/users/Stromweld/orgs","repos_url":"https://api.github.com/users/Stromweld/repos","events_url":"https://api.github.com/users/Stromweld/events{/privacy}","received_events_url":"https://api.github.com/users/Stromweld/received_events","type":"User","site_admin":false},"repo":{"id":143917099,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MTcwOTk=","name":"haproxy","full_name":"Stromweld/haproxy","owner":{"login":"Stromweld","id":3476391,"node_id":"MDQ6VXNlcjM0NzYzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3476391?v=4","gravatar_id":"","url":"https://api.github.com/users/Stromweld","html_url":"https://github.com/Stromweld","followers_url":"https://api.github.com/users/Stromweld/followers","following_url":"https://api.github.com/users/Stromweld/following{/other_user}","gists_url":"https://api.github.com/users/Stromweld/gists{/gist_id}","starred_url":"https://api.github.com/users/Stromweld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stromweld/subscriptions","organizations_url":"https://api.github.com/users/Stromweld/orgs","repos_url":"https://api.github.com/users/Stromweld/repos","events_url":"https://api.github.com/users/Stromweld/events{/privacy}","received_events_url":"https://api.github.com/users/Stromweld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Stromweld/haproxy","description":"Development repository for the haproxy cookbook","fork":true,"url":"https://api.github.com/repos/Stromweld/haproxy","forks_url":"https://api.github.com/repos/Stromweld/haproxy/forks","keys_url":"https://api.github.com/repos/Stromweld/haproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stromweld/haproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stromweld/haproxy/teams","hooks_url":"https://api.github.com/repos/Stromweld/haproxy/hooks","issue_events_url":"https://api.github.com/repos/Stromweld/haproxy/issues/events{/number}","events_url":"https://api.github.com/repos/Stromweld/haproxy/events","assignees_url":"https://api.github.com/repos/Stromweld/haproxy/assignees{/user}","branches_url":"https://api.github.com/repos/Stromweld/haproxy/branches{/branch}","tags_url":"https://api.github.com/repos/Stromweld/haproxy/tags","blobs_url":"https://api.github.com/repos/Stromweld/haproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stromweld/haproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stromweld/haproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stromweld/haproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stromweld/haproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/Stromweld/haproxy/languages","stargazers_url":"https://api.github.com/repos/Stromweld/haproxy/stargazers","contributors_url":"https://api.github.com/repos/Stromweld/haproxy/contributors","subscribers_url":"https://api.github.com/repos/Stromweld/haproxy/subscribers","subscription_url":"https://api.github.com/repos/Stromweld/haproxy/subscription","commits_url":"https://api.github.com/repos/Stromweld/haproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stromweld/haproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stromweld/haproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stromweld/haproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stromweld/haproxy/contents/{+path}","compare_url":"https://api.github.com/repos/Stromweld/haproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stromweld/haproxy/merges","archive_url":"https://api.github.com/repos/Stromweld/haproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stromweld/haproxy/downloads","issues_url":"https://api.github.com/repos/Stromweld/haproxy/issues{/number}","pulls_url":"https://api.github.com/repos/Stromweld/haproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/Stromweld/haproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/Stromweld/haproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stromweld/haproxy/labels{/name}","releases_url":"https://api.github.com/repos/Stromweld/haproxy/releases{/id}","deployments_url":"https://api.github.com/repos/Stromweld/haproxy/deployments","created_at":"2018-08-07T19:18:14Z","updated_at":"2018-08-08T16:37:15Z","pushed_at":"2018-08-08T16:37:13Z","git_url":"git://github.com/Stromweld/haproxy.git","ssh_url":"git@github.com:Stromweld/haproxy.git","clone_url":"https://github.com/Stromweld/haproxy.git","svn_url":"https://github.com/Stromweld/haproxy","homepage":"https://supermarket.chef.io/cookbooks/haproxy","size":505,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sous-chefs:master","ref":"master","sha":"a698868023d8d3014305a9c06067828da278124a","user":{"login":"sous-chefs","id":12356028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzU2MDI4","avatar_url":"https://avatars3.githubusercontent.com/u/12356028?v=4","gravatar_id":"","url":"https://api.github.com/users/sous-chefs","html_url":"https://github.com/sous-chefs","followers_url":"https://api.github.com/users/sous-chefs/followers","following_url":"https://api.github.com/users/sous-chefs/following{/other_user}","gists_url":"https://api.github.com/users/sous-chefs/gists{/gist_id}","starred_url":"https://api.github.com/users/sous-chefs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sous-chefs/subscriptions","organizations_url":"https://api.github.com/users/sous-chefs/orgs","repos_url":"https://api.github.com/users/sous-chefs/repos","events_url":"https://api.github.com/users/sous-chefs/events{/privacy}","received_events_url":"https://api.github.com/users/sous-chefs/received_events","type":"Organization","site_admin":false},"repo":{"id":3720592,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIwNTky","name":"haproxy","full_name":"sous-chefs/haproxy","owner":{"login":"sous-chefs","id":12356028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzU2MDI4","avatar_url":"https://avatars3.githubusercontent.com/u/12356028?v=4","gravatar_id":"","url":"https://api.github.com/users/sous-chefs","html_url":"https://github.com/sous-chefs","followers_url":"https://api.github.com/users/sous-chefs/followers","following_url":"https://api.github.com/users/sous-chefs/following{/other_user}","gists_url":"https://api.github.com/users/sous-chefs/gists{/gist_id}","starred_url":"https://api.github.com/users/sous-chefs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sous-chefs/subscriptions","organizations_url":"https://api.github.com/users/sous-chefs/orgs","repos_url":"https://api.github.com/users/sous-chefs/repos","events_url":"https://api.github.com/users/sous-chefs/events{/privacy}","received_events_url":"https://api.github.com/users/sous-chefs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sous-chefs/haproxy","description":"Development repository for the haproxy cookbook","fork":false,"url":"https://api.github.com/repos/sous-chefs/haproxy","forks_url":"https://api.github.com/repos/sous-chefs/haproxy/forks","keys_url":"https://api.github.com/repos/sous-chefs/haproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sous-chefs/haproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sous-chefs/haproxy/teams","hooks_url":"https://api.github.com/repos/sous-chefs/haproxy/hooks","issue_events_url":"https://api.github.com/repos/sous-chefs/haproxy/issues/events{/number}","events_url":"https://api.github.com/repos/sous-chefs/haproxy/events","assignees_url":"https://api.github.com/repos/sous-chefs/haproxy/assignees{/user}","branches_url":"https://api.github.com/repos/sous-chefs/haproxy/branches{/branch}","tags_url":"https://api.github.com/repos/sous-chefs/haproxy/tags","blobs_url":"https://api.github.com/repos/sous-chefs/haproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sous-chefs/haproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sous-chefs/haproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sous-chefs/haproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sous-chefs/haproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/sous-chefs/haproxy/languages","stargazers_url":"https://api.github.com/repos/sous-chefs/haproxy/stargazers","contributors_url":"https://api.github.com/repos/sous-chefs/haproxy/contributors","subscribers_url":"https://api.github.com/repos/sous-chefs/haproxy/subscribers","subscription_url":"https://api.github.com/repos/sous-chefs/haproxy/subscription","commits_url":"https://api.github.com/repos/sous-chefs/haproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sous-chefs/haproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sous-chefs/haproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sous-chefs/haproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sous-chefs/haproxy/contents/{+path}","compare_url":"https://api.github.com/repos/sous-chefs/haproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sous-chefs/haproxy/merges","archive_url":"https://api.github.com/repos/sous-chefs/haproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sous-chefs/haproxy/downloads","issues_url":"https://api.github.com/repos/sous-chefs/haproxy/issues{/number}","pulls_url":"https://api.github.com/repos/sous-chefs/haproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/sous-chefs/haproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/sous-chefs/haproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sous-chefs/haproxy/labels{/name}","releases_url":"https://api.github.com/repos/sous-chefs/haproxy/releases{/id}","deployments_url":"https://api.github.com/repos/sous-chefs/haproxy/deployments","created_at":"2012-03-14T18:14:11Z","updated_at":"2018-08-03T20:44:17Z","pushed_at":"2018-08-08T16:37:15Z","git_url":"git://github.com/sous-chefs/haproxy.git","ssh_url":"git@github.com:sous-chefs/haproxy.git","clone_url":"https://github.com/sous-chefs/haproxy.git","svn_url":"https://github.com/sous-chefs/haproxy","homepage":"https://supermarket.chef.io/cookbooks/haproxy","size":564,"stargazers_count":128,"watchers_count":128,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":247,"open_issues":8,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sous-chefs/haproxy/pulls/308"},"html":{"href":"https://github.com/sous-chefs/haproxy/pull/308"},"issue":{"href":"https://api.github.com/repos/sous-chefs/haproxy/issues/308"},"comments":{"href":"https://api.github.com/repos/sous-chefs/haproxy/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/sous-chefs/haproxy/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/sous-chefs/haproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sous-chefs/haproxy/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/sous-chefs/haproxy/statuses/620318db408e9a2fabb30215b45b7d0e3a0d4b4b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"damacus"}}