{"action":"created","comment":{"url":"https://api.github.com/repos/trezor/trezor-core/pulls/comments/177359771","pull_request_review_id":107212707,"id":177359771,"diff_hunk":"@@ -311,6 +313,57 @@ STATIC mp_obj_t mod_trezorcrypto_HDNode_address(mp_obj_t self, mp_obj_t version)\n }\n STATIC MP_DEFINE_CONST_FUN_OBJ_2(mod_trezorcrypto_HDNode_address_obj, mod_trezorcrypto_HDNode_address);\n \n+/// def nem_address(self, network: int) -> str:\n+///     '''\n+///     Compute a NEM address string from the HD node.\n+///     '''\n+STATIC mp_obj_t mod_trezorcrypto_HDNode_nem_address(mp_obj_t self, mp_obj_t network) {\n+    mp_obj_HDNode_t *o = MP_OBJ_TO_PTR(self);\n+\n+    uint8_t n = mp_obj_get_int_truncated(network);\n+    char address[NEM_ADDRESS_SIZE];\n+    hdnode_get_nem_address(&o->hdnode, n, address);","path":"embed/extmod/modtrezorcrypto/modtrezorcrypto-bip32.h","position":29,"original_position":29,"commit_id":"b7542d394ffd28d98b99afbdc50c3977dd44b753","original_commit_id":"b7542d394ffd28d98b99afbdc50c3977dd44b753","user":{"login":"tsusanka","id":1835345,"avatar_url":"https://avatars1.githubusercontent.com/u/1835345?v=4","gravatar_id":"","url":"https://api.github.com/users/tsusanka","html_url":"https://github.com/tsusanka","followers_url":"https://api.github.com/users/tsusanka/followers","following_url":"https://api.github.com/users/tsusanka/following{/other_user}","gists_url":"https://api.github.com/users/tsusanka/gists{/gist_id}","starred_url":"https://api.github.com/users/tsusanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsusanka/subscriptions","organizations_url":"https://api.github.com/users/tsusanka/orgs","repos_url":"https://api.github.com/users/tsusanka/repos","events_url":"https://api.github.com/users/tsusanka/events{/privacy}","received_events_url":"https://api.github.com/users/tsusanka/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2018-03-27T09:22:05Z","updated_at":"2018-03-27T09:22:05Z","html_url":"https://github.com/trezor/trezor-core/pull/179#discussion_r177359771","pull_request_url":"https://api.github.com/repos/trezor/trezor-core/pulls/179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/trezor/trezor-core/pulls/comments/177359771"},"html":{"href":"https://github.com/trezor/trezor-core/pull/179#discussion_r177359771"},"pull_request":{"href":"https://api.github.com/repos/trezor/trezor-core/pulls/179"}},"in_reply_to_id":177323836},"pull_request":{"url":"https://api.github.com/repos/trezor/trezor-core/pulls/179","id":177496079,"html_url":"https://github.com/trezor/trezor-core/pull/179","diff_url":"https://github.com/trezor/trezor-core/pull/179.diff","patch_url":"https://github.com/trezor/trezor-core/pull/179.patch","issue_url":"https://api.github.com/repos/trezor/trezor-core/issues/179","number":179,"state":"open","locked":false,"title":"NEM","user":{"login":"tsusanka","id":1835345,"avatar_url":"https://avatars1.githubusercontent.com/u/1835345?v=4","gravatar_id":"","url":"https://api.github.com/users/tsusanka","html_url":"https://github.com/tsusanka","followers_url":"https://api.github.com/users/tsusanka/followers","following_url":"https://api.github.com/users/tsusanka/following{/other_user}","gists_url":"https://api.github.com/users/tsusanka/gists{/gist_id}","starred_url":"https://api.github.com/users/tsusanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsusanka/subscriptions","organizations_url":"https://api.github.com/users/tsusanka/orgs","repos_url":"https://api.github.com/users/tsusanka/repos","events_url":"https://api.github.com/users/tsusanka/events{/privacy}","received_events_url":"https://api.github.com/users/tsusanka/received_events","type":"User","site_admin":false},"body":"To be reviewed for the first time. Not completely finished (missing mosaics)","created_at":"2018-03-26T16:12:28Z","updated_at":"2018-03-27T09:22:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a4388ed9677afaffaeeec924b4e5392d591af23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trezor/trezor-core/pulls/179/commits","review_comments_url":"https://api.github.com/repos/trezor/trezor-core/pulls/179/comments","review_comment_url":"https://api.github.com/repos/trezor/trezor-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trezor/trezor-core/issues/179/comments","statuses_url":"https://api.github.com/repos/trezor/trezor-core/statuses/b7542d394ffd28d98b99afbdc50c3977dd44b753","head":{"label":"trezor:tsusanka/nem","ref":"tsusanka/nem","sha":"b7542d394ffd28d98b99afbdc50c3977dd44b753","user":{"login":"trezor","id":4146447,"avatar_url":"https://avatars1.githubusercontent.com/u/4146447?v=4","gravatar_id":"","url":"https://api.github.com/users/trezor","html_url":"https://github.com/trezor","followers_url":"https://api.github.com/users/trezor/followers","following_url":"https://api.github.com/users/trezor/following{/other_user}","gists_url":"https://api.github.com/users/trezor/gists{/gist_id}","starred_url":"https://api.github.com/users/trezor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trezor/subscriptions","organizations_url":"https://api.github.com/users/trezor/orgs","repos_url":"https://api.github.com/users/trezor/repos","events_url":"https://api.github.com/users/trezor/events{/privacy}","received_events_url":"https://api.github.com/users/trezor/received_events","type":"Organization","site_admin":false},"repo":{"id":46493241,"name":"trezor-core","full_name":"trezor/trezor-core","owner":{"login":"trezor","id":4146447,"avatar_url":"https://avatars1.githubusercontent.com/u/4146447?v=4","gravatar_id":"","url":"https://api.github.com/users/trezor","html_url":"https://github.com/trezor","followers_url":"https://api.github.com/users/trezor/followers","following_url":"https://api.github.com/users/trezor/following{/other_user}","gists_url":"https://api.github.com/users/trezor/gists{/gist_id}","starred_url":"https://api.github.com/users/trezor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trezor/subscriptions","organizations_url":"https://api.github.com/users/trezor/orgs","repos_url":"https://api.github.com/users/trezor/repos","events_url":"https://api.github.com/users/trezor/events{/privacy}","received_events_url":"https://api.github.com/users/trezor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trezor/trezor-core","description":":lock: TREZOR Core","fork":false,"url":"https://api.github.com/repos/trezor/trezor-core","forks_url":"https://api.github.com/repos/trezor/trezor-core/forks","keys_url":"https://api.github.com/repos/trezor/trezor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trezor/trezor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trezor/trezor-core/teams","hooks_url":"https://api.github.com/repos/trezor/trezor-core/hooks","issue_events_url":"https://api.github.com/repos/trezor/trezor-core/issues/events{/number}","events_url":"https://api.github.com/repos/trezor/trezor-core/events","assignees_url":"https://api.github.com/repos/trezor/trezor-core/assignees{/user}","branches_url":"https://api.github.com/repos/trezor/trezor-core/branches{/branch}","tags_url":"https://api.github.com/repos/trezor/trezor-core/tags","blobs_url":"https://api.github.com/repos/trezor/trezor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trezor/trezor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trezor/trezor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/trezor/trezor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trezor/trezor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/trezor/trezor-core/languages","stargazers_url":"https://api.github.com/repos/trezor/trezor-core/stargazers","contributors_url":"https://api.github.com/repos/trezor/trezor-core/contributors","subscribers_url":"https://api.github.com/repos/trezor/trezor-core/subscribers","subscription_url":"https://api.github.com/repos/trezor/trezor-core/subscription","commits_url":"https://api.github.com/repos/trezor/trezor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/trezor/trezor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/trezor/trezor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/trezor/trezor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/trezor/trezor-core/contents/{+path}","compare_url":"https://api.github.com/repos/trezor/trezor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trezor/trezor-core/merges","archive_url":"https://api.github.com/repos/trezor/trezor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trezor/trezor-core/downloads","issues_url":"https://api.github.com/repos/trezor/trezor-core/issues{/number}","pulls_url":"https://api.github.com/repos/trezor/trezor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/trezor/trezor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/trezor/trezor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trezor/trezor-core/labels{/name}","releases_url":"https://api.github.com/repos/trezor/trezor-core/releases{/id}","deployments_url":"https://api.github.com/repos/trezor/trezor-core/deployments","created_at":"2015-11-19T13:16:23Z","updated_at":"2018-03-27T04:31:40Z","pushed_at":"2018-03-26T16:12:28Z","git_url":"git://github.com/trezor/trezor-core.git","ssh_url":"git@github.com:trezor/trezor-core.git","clone_url":"https://github.com/trezor/trezor-core.git","svn_url":"https://github.com/trezor/trezor-core","homepage":"https://trezor.io/","size":6441,"stargazers_count":196,"watchers_count":196,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":62,"open_issues":27,"watchers":196,"default_branch":"master"}},"base":{"label":"trezor:master","ref":"master","sha":"25ae6bba5168d46d6bb8354ecd9cffb3fc80180b","user":{"login":"trezor","id":4146447,"avatar_url":"https://avatars1.githubusercontent.com/u/4146447?v=4","gravatar_id":"","url":"https://api.github.com/users/trezor","html_url":"https://github.com/trezor","followers_url":"https://api.github.com/users/trezor/followers","following_url":"https://api.github.com/users/trezor/following{/other_user}","gists_url":"https://api.github.com/users/trezor/gists{/gist_id}","starred_url":"https://api.github.com/users/trezor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trezor/subscriptions","organizations_url":"https://api.github.com/users/trezor/orgs","repos_url":"https://api.github.com/users/trezor/repos","events_url":"https://api.github.com/users/trezor/events{/privacy}","received_events_url":"https://api.github.com/users/trezor/received_events","type":"Organization","site_admin":false},"repo":{"id":46493241,"name":"trezor-core","full_name":"trezor/trezor-core","owner":{"login":"trezor","id":4146447,"avatar_url":"https://avatars1.githubusercontent.com/u/4146447?v=4","gravatar_id":"","url":"https://api.github.com/users/trezor","html_url":"https://github.com/trezor","followers_url":"https://api.github.com/users/trezor/followers","following_url":"https://api.github.com/users/trezor/following{/other_user}","gists_url":"https://api.github.com/users/trezor/gists{/gist_id}","starred_url":"https://api.github.com/users/trezor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trezor/subscriptions","organizations_url":"https://api.github.com/users/trezor/orgs","repos_url":"https://api.github.com/users/trezor/repos","events_url":"https://api.github.com/users/trezor/events{/privacy}","received_events_url":"https://api.github.com/users/trezor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trezor/trezor-core","description":":lock: TREZOR Core","fork":false,"url":"https://api.github.com/repos/trezor/trezor-core","forks_url":"https://api.github.com/repos/trezor/trezor-core/forks","keys_url":"https://api.github.com/repos/trezor/trezor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trezor/trezor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trezor/trezor-core/teams","hooks_url":"https://api.github.com/repos/trezor/trezor-core/hooks","issue_events_url":"https://api.github.com/repos/trezor/trezor-core/issues/events{/number}","events_url":"https://api.github.com/repos/trezor/trezor-core/events","assignees_url":"https://api.github.com/repos/trezor/trezor-core/assignees{/user}","branches_url":"https://api.github.com/repos/trezor/trezor-core/branches{/branch}","tags_url":"https://api.github.com/repos/trezor/trezor-core/tags","blobs_url":"https://api.github.com/repos/trezor/trezor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trezor/trezor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trezor/trezor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/trezor/trezor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trezor/trezor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/trezor/trezor-core/languages","stargazers_url":"https://api.github.com/repos/trezor/trezor-core/stargazers","contributors_url":"https://api.github.com/repos/trezor/trezor-core/contributors","subscribers_url":"https://api.github.com/repos/trezor/trezor-core/subscribers","subscription_url":"https://api.github.com/repos/trezor/trezor-core/subscription","commits_url":"https://api.github.com/repos/trezor/trezor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/trezor/trezor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/trezor/trezor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/trezor/trezor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/trezor/trezor-core/contents/{+path}","compare_url":"https://api.github.com/repos/trezor/trezor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trezor/trezor-core/merges","archive_url":"https://api.github.com/repos/trezor/trezor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trezor/trezor-core/downloads","issues_url":"https://api.github.com/repos/trezor/trezor-core/issues{/number}","pulls_url":"https://api.github.com/repos/trezor/trezor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/trezor/trezor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/trezor/trezor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trezor/trezor-core/labels{/name}","releases_url":"https://api.github.com/repos/trezor/trezor-core/releases{/id}","deployments_url":"https://api.github.com/repos/trezor/trezor-core/deployments","created_at":"2015-11-19T13:16:23Z","updated_at":"2018-03-27T04:31:40Z","pushed_at":"2018-03-26T16:12:28Z","git_url":"git://github.com/trezor/trezor-core.git","ssh_url":"git@github.com:trezor/trezor-core.git","clone_url":"https://github.com/trezor/trezor-core.git","svn_url":"https://github.com/trezor/trezor-core","homepage":"https://trezor.io/","size":6441,"stargazers_count":196,"watchers_count":196,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":62,"open_issues":27,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trezor/trezor-core/pulls/179"},"html":{"href":"https://github.com/trezor/trezor-core/pull/179"},"issue":{"href":"https://api.github.com/repos/trezor/trezor-core/issues/179"},"comments":{"href":"https://api.github.com/repos/trezor/trezor-core/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/trezor/trezor-core/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/trezor/trezor-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trezor/trezor-core/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/trezor/trezor-core/statuses/b7542d394ffd28d98b99afbdc50c3977dd44b753"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tsusanka"}}