{"action":"created","issue":{"url":"https://api.github.com/repos/gusty/FsPad/issues/6","repository_url":"https://api.github.com/repos/gusty/FsPad","labels_url":"https://api.github.com/repos/gusty/FsPad/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/gusty/FsPad/issues/6/comments","events_url":"https://api.github.com/repos/gusty/FsPad/issues/6/events","html_url":"https://github.com/gusty/FsPad/pull/6","id":306325876,"number":6,"title":"Added HTML encoding to FsHtml library and mechanism for including raw…","user":{"login":"sgoguen","id":60516,"avatar_url":"https://avatars2.githubusercontent.com/u/60516?v=4","gravatar_id":"","url":"https://api.github.com/users/sgoguen","html_url":"https://github.com/sgoguen","followers_url":"https://api.github.com/users/sgoguen/followers","following_url":"https://api.github.com/users/sgoguen/following{/other_user}","gists_url":"https://api.github.com/users/sgoguen/gists{/gist_id}","starred_url":"https://api.github.com/users/sgoguen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgoguen/subscriptions","organizations_url":"https://api.github.com/users/sgoguen/orgs","repos_url":"https://api.github.com/users/sgoguen/repos","events_url":"https://api.github.com/users/sgoguen/events{/privacy}","received_events_url":"https://api.github.com/users/sgoguen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-19T03:55:37Z","updated_at":"2018-03-19T13:21:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gusty/FsPad/pulls/6","html_url":"https://github.com/gusty/FsPad/pull/6","diff_url":"https://github.com/gusty/FsPad/pull/6.diff","patch_url":"https://github.com/gusty/FsPad/pull/6.patch"},"body":"@scrwtp I added some default HTML encoding in the FsHtml library itself and included an extension point to the Html union type to accommodate inserting the raw HTML (For the the static header)\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/gusty/FsPad/issues/comments/374209133","html_url":"https://github.com/gusty/FsPad/pull/6#issuecomment-374209133","issue_url":"https://api.github.com/repos/gusty/FsPad/issues/6","id":374209133,"user":{"login":"scrwtp","id":1717007,"avatar_url":"https://avatars0.githubusercontent.com/u/1717007?v=4","gravatar_id":"","url":"https://api.github.com/users/scrwtp","html_url":"https://github.com/scrwtp","followers_url":"https://api.github.com/users/scrwtp/followers","following_url":"https://api.github.com/users/scrwtp/following{/other_user}","gists_url":"https://api.github.com/users/scrwtp/gists{/gist_id}","starred_url":"https://api.github.com/users/scrwtp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrwtp/subscriptions","organizations_url":"https://api.github.com/users/scrwtp/orgs","repos_url":"https://api.github.com/users/scrwtp/repos","events_url":"https://api.github.com/users/scrwtp/events{/privacy}","received_events_url":"https://api.github.com/users/scrwtp/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T13:21:32Z","updated_at":"2018-03-19T13:21:32Z","author_association":"COLLABORATOR","body":"FsHtml was lifted from https://github.com/ptrelford/FsHtml and I was planning to remove the file from FsPad and reference it through Paket. So in general that would be a more suitable place to send this PR to.\r\n\r\nI think the idea is good, but the implementation of these changes doesn't go in the right direction. I'm not the author, but I think FsHtml treats encoding as a separate concern and leaves that to the client on purpose, as to not force an opinion whether the strings used should or shouldn't be already encoded. And `RawHtml` is only necessary when you start encoding text in FsHtml. Otherwise it's not different to what you can already express with `Text` case.\r\n\r\nWhat I could see working (and perhaps merged back to the original FsHtml repo) would be including a helper function or static member on `Html` type for encoding text that would do the encoding and yield the result as a `Text`.\r\n"}}
{"actor":{"display_login":"scrwtp"}}