{"push_id":2724095385,"size":16,"distinct_size":2,"ref":"refs/heads/staging","head":"16cf2966c86c244e9bf91d6e25b617c5d2242b46","before":"faabc77885bed49af3b90bfbef83afbc854b4e22","commits":[{"sha":"1835d7f1f0348e0b65916f4ee1f43e2ca651926a","author":{"name":"Rebecca Taft","email":"29d26ecf7dc14afc1fca64f3cda0a97b1ec0f7f3@cockroachlabs.com"},"message":"opt: add type to Tuple expression to preserve labels\n\nPreviously, the optimizer inferred the type of a Tuple expression from\nthe types of its elements. However, the type of a Tuple expression\nmay also include the labels of its elements. In order to ensure\nthese labels are passed through the optimizer correctly, this\ncommit adds the type as a Private of Tuple.\n\nFixes #27398\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/1835d7f1f0348e0b65916f4ee1f43e2ca651926a"},{"sha":"ea49965db8ff9d75ea04cb3ef44842643073ce95","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"server: Fix race in TestPlainHTTPServer\n\nThis test was mutating the rpc.Context while it was in use, leading to\nrare races (probably new since the introduction of nodedialer).\nSimplify the test by using a brand-new external HTTP client instead of\nmutating the TestServer's context.\n\nFixes #27609\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/ea49965db8ff9d75ea04cb3ef44842643073ce95"},{"sha":"bf09d66d2ad1485f8e1666340399632389d60a5d","author":{"name":"Andrew Woods","email":"e3579b1e47f273529f0f929453e939a68ede9fd1@cockroachlabs.com"},"message":"release: version 2.0.4\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/bf09d66d2ad1485f8e1666340399632389d60a5d"},{"sha":"8a24187b029d0649412ed02eb3ac7a9f62ee2b4f","author":{"name":"Rebecca Taft","email":"29d26ecf7dc14afc1fca64f3cda0a97b1ec0f7f3@cockroachlabs.com"},"message":"optbuilder: Fix optbuilder to build correctly typed subqueries\n\nThe typing of some subqueries was incorrect because the ORDER BY\ncolumns were being projected along with the output columns of the\nsubquery. This commit adds logic to detect when the ORDER BY columns\nshould not be projected, and wraps the underlying expression in a\nProject operation to remove the excess columns. This fixes the\nissue with incorrect typing.\n\nFixes #27330\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/8a24187b029d0649412ed02eb3ac7a9f62ee2b4f"},{"sha":"5cae137d5cf16971d49c6707cfc3a6132569488a","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #27614\n\n27614: server: Fix race in TestPlainHTTPServer r=nvanbenschoten a=bdarnell\n\nThis test was mutating the rpc.Context while it was in use, leading to\r\nrare races (probably new since the introduction of nodedialer).\r\nSimplify the test by using a brand-new external HTTP client instead of\r\nmutating the TestServer's context.\r\n\r\nFixes #27609\r\n\r\nRelease note: None\n\nCo-authored-by: Ben Darnell <ben@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/5cae137d5cf16971d49c6707cfc3a6132569488a"},{"sha":"63e6c0a437f49777766be22853fb2132dd962485","author":{"name":"yuzefovich","email":"41a4422ea0196d94bb8402972d1e94c23f34d26f@cockroachlabs.com"},"message":"sql: Add efficient min, max, sum, avg when used as window functions\n\nAdds linear-time implementations of min, max, sum, and avg\n(using sliding window approach) instead of naive quadratic\nversion.\n\nAddresses: #26464.\n\nBonus: min and max are an order of magnitude faster than PG\n(when window frame doesn't include the whole partition).\n\nRelease note (performance improvement): min, max, sum, avg\nnow take linear time when used for aggregation as window\nfunctions for all supported window frame options.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/63e6c0a437f49777766be22853fb2132dd962485"},{"sha":"63ec3a81b8e6c96e227f6b4d811238e1e1f227ac","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #27524 #27604\n\n27524: optbuilder: Fix optbuilder to build correctly typed subqueries r=rytaft a=rytaft\n\nThe typing of some subqueries was incorrect because the `ORDER BY`\r\ncolumns were being projected along with the output columns of the\r\nsubquery. This commit adds logic to detect when the `ORDER BY` columns\r\nshould not be projected, and wraps the underlying expression in a\r\n`Project` operation to remove the excess columns. This fixes the\r\nissue with incorrect typing.\r\n\r\nFixes #27330\r\n\r\nRelease note: None\n\n27604: opt: add type to Tuple expression to preserve labels r=rytaft a=rytaft\n\nPreviously, the optimizer inferred the type of a Tuple expression from\r\nthe types of its elements. However, the type of a Tuple expression\r\nmay also include the labels of its elements. In order to ensure\r\nthese labels are passed through the optimizer correctly, this\r\ncommit adds the type as a Private of Tuple.\r\n\r\nFixes #27398\r\n\r\nRelease note: None\n\nCo-authored-by: Rebecca Taft <becca@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/63ec3a81b8e6c96e227f6b4d811238e1e1f227ac"},{"sha":"c974dfb4f2970bf537334688f11406684f6f468a","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #26988\n\n26988: sql: Add more efficient implementation of min, max, sum, avg aggregates when used as window functions. r=yuzefovich a=yuzefovich\n\nAdds linear-time implementations of min, max, sum, and avg\r\n(using sliding window approach) instead of naive quadratic\r\nversion.\r\n\r\nAddresses: #26464.\r\n\r\nBonus: min and max is order of magnitude faster that PG\r\n(when window frame doesn't include the whole partition).\r\n\r\nRelease note (performance improvement): min, max, sum, avg\r\nnow take linear time when used for aggregation as window\r\nfunctions.\n\nCo-authored-by: yuzefovich <yahor@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c974dfb4f2970bf537334688f11406684f6f468a"},{"sha":"960868d393db787bc31bdb88400e877448ed3cf8","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"storage: quiesce less aggressively\n\nPR #26911 added a mechanism which during quiescence decisions ignored\nnodes which (at some recent point in time) seemed non-live.\nUnfortunately, the corresponding mechanism introduced to unquiesce when\nthe node becomes live is quite racy, at least when tormented with the\nwild timings we throw at it in unit testing.  The basic discrepancy is\nthat unquiescing is triggered by an explicit liveness event (i.e. the kv\nrecord being overwritten), whereas a node may seem non-live for mere\nreasons of timing inbetween. In effect this means that quiescence is\nmore aggressive than unquiescence.\n\nI explored various venues to address this (going as far as introducing\nan unquiesce message to the Raft scheduler and serializing unquiescence\nthrough the store Raft ticker goroutine), but it's hopeless. It's an\nequally idle diversion to try to adjust the test liveness durations.\n\nSo, in this commit, the liveness check becomes more lenient: even when a\nnode seems non-live, we count it as live if there's a healthy connection\nestablished to it. This effectively deals with issues in tests but also\nseems like a good addition for real world workloads: when the liveness\nrange breaks down, we don't want to aggressively quiesce.\n\nFixes #27545.\nFixes #27607.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/960868d393db787bc31bdb88400e877448ed3cf8"},{"sha":"d0bf94f5e44e84ecb7bf9f050a4386785626040b","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #27617\n\n27617: storage: quiesce less aggressively r=nvanbenschoten,bdarnell a=tschottdorf\n\nPR #26911 added a mechanism which during quiescence decisions ignored\nnodes which (at some recent point in time) seemed non-live.\nUnfortunately, the corresponding mechanism introduced to unquiesce when\nthe node becomes live is quite racy, at least when tormented with the\nwild timings we throw at it in unit testing.  The basic discrepancy is\nthat unquiescing is triggered by an explicit liveness event (i.e. the kv\nrecord being overwritten), whereas a node may seem non-live for mere\nreasons of timing inbetween. In effect this means that quiescence is\nmore aggressive than unquiescence.\n\nI explored various venues to address this (going as far as introducing\nan unquiesce message to the Raft scheduler and serializing unquiescence\nthrough the store Raft ticker goroutine), but it's hopeless. It's an\nequally idle diversion to try to adjust the test liveness durations.\n\nSo, in this commit, the liveness check becomes more lenient: even when a\nnode seems non-live, we count it as live if there's a healthy connection\nestablished to it. This effectively deals with issues in tests but also\nseems like a good addition for real world workloads: when the liveness\nrange breaks down, we don't want to aggressively quiesce.\n\nFixes #27545.\nFixes #27607.\n\nRelease note: None\n\nCo-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/d0bf94f5e44e84ecb7bf9f050a4386785626040b"},{"sha":"69a92a9fb293f9bac1e38b5aef66c1df47c3aa3a","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"kv: Remove rpc.Context from \"legacy\" test interface\n\nRename this interface from \"legacy\" to \"simple\" because it's clearly\nnot going away (nor should it, I think).  The Context, SendOptions,\nand ReplicaSlice arguments go unused in nearly all tests so there\nmay be some room to simplify this interface further if those tests are\nported to a different interface.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/69a92a9fb293f9bac1e38b5aef66c1df47c3aa3a"},{"sha":"a9b7463e866d128c5ff1094c7ffe75428dc2eba8","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"gossip: Move storage.GossipAddressResolver to gossip.AddressResolver\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/a9b7463e866d128c5ff1094c7ffe75428dc2eba8"},{"sha":"6d066cadef69b7d3a81d1f1511efa006cdf39624","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"kv: Use NodeDialer in kv.Transport\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/6d066cadef69b7d3a81d1f1511efa006cdf39624"},{"sha":"3b9e256ef10340aae3f24b00c29079524a338bb2","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"distsqlrun: Use nodedialer instead of GRPCDial\n\nDue to the distribution of planning and the fact that node addresses\nare sent over the wire, the old interface is still supported for\nmixed-version clusters.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/3b9e256ef10340aae3f24b00c29079524a338bb2"},{"sha":"049bd12cc591ebf09e1d20546ba536548fa90614","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #27452\n\n27452: distsql: Use nodedialer instead of GRPCDial r=tschottdorf a=bdarnell\n\nDue to the distribution of planning and the fact that node addresses\r\nare sent over the wire, the old interface is still supported for\r\nmixed-version clusters.\r\n\r\nRelease note: None\r\n\r\nFirst three commits are #27423.\n\nCo-authored-by: Ben Darnell <ben@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/049bd12cc591ebf09e1d20546ba536548fa90614"},{"sha":"16cf2966c86c244e9bf91d6e25b617c5d2242b46","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #27616\n\n27616: release: version 2.0.4 r=a-robinson a=awoods187\n\nRelease note: None\n\nCo-authored-by: Andrew Woods <andy@cockroachlabs.com>","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/16cf2966c86c244e9bf91d6e25b617c5d2242b46"}]}
{"actor":{"display_login":"craig"}}