{"action":"created","issue":{"url":"https://api.github.com/repos/ActiveLogin/ActiveLogin.Identity/issues/17","repository_url":"https://api.github.com/repos/ActiveLogin/ActiveLogin.Identity","labels_url":"https://api.github.com/repos/ActiveLogin/ActiveLogin.Identity/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/ActiveLogin/ActiveLogin.Identity/issues/17/comments","events_url":"https://api.github.com/repos/ActiveLogin/ActiveLogin.Identity/issues/17/events","html_url":"https://github.com/ActiveLogin/ActiveLogin.Identity/issues/17","id":371717113,"node_id":"MDU6SXNzdWUzNzE3MTcxMTM=","number":17,"title":"Failing tests when environment is not windows","user":{"login":"viktorvan","id":5772158,"node_id":"MDQ6VXNlcjU3NzIxNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5772158?v=4","gravatar_id":"","url":"https://api.github.com/users/viktorvan","html_url":"https://github.com/viktorvan","followers_url":"https://api.github.com/users/viktorvan/followers","following_url":"https://api.github.com/users/viktorvan/following{/other_user}","gists_url":"https://api.github.com/users/viktorvan/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorvan/subscriptions","organizations_url":"https://api.github.com/users/viktorvan/orgs","repos_url":"https://api.github.com/users/viktorvan/repos","events_url":"https://api.github.com/users/viktorvan/events{/privacy}","received_events_url":"https://api.github.com/users/viktorvan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-18T21:16:47Z","updated_at":"2018-10-20T09:05:40Z","closed_at":null,"author_association":"NONE","body":"Some unit tests are failing on my mac because the exception messages will only use \"\\n\" to indicate a new line instead of \\r\\n which is hard coded into the test assertions.\r\n\r\nAn improvement would be to use Environment.NewLine instead of \"\\r\\n\" in the assertions, but I am wondering if we really should be doing exact assertions on the exception messages anyways? It seems too fragile in my opinion\r\n\r\ne.g.\r\n`Assert.Equal($\"Invalid year.{Environment.NewLine}Parameter name: year{Environment.NewLine}Actual value was {year}.\", ex.Message);`\r\n\r\ninstead of\r\n\r\n`Assert.Equal($\"Invalid year.\\r\\nParameter name: year\\r\\nActual value was {year}.\", ex.Message);`\r\n"},"comment":{"url":"https://api.github.com/repos/ActiveLogin/ActiveLogin.Identity/issues/comments/431563190","html_url":"https://github.com/ActiveLogin/ActiveLogin.Identity/issues/17#issuecomment-431563190","issue_url":"https://api.github.com/repos/ActiveLogin/ActiveLogin.Identity/issues/17","id":431563190,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTU2MzE5MA==","user":{"login":"PeterOrneholm","id":1662918,"node_id":"MDQ6VXNlcjE2NjI5MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1662918?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterOrneholm","html_url":"https://github.com/PeterOrneholm","followers_url":"https://api.github.com/users/PeterOrneholm/followers","following_url":"https://api.github.com/users/PeterOrneholm/following{/other_user}","gists_url":"https://api.github.com/users/PeterOrneholm/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterOrneholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterOrneholm/subscriptions","organizations_url":"https://api.github.com/users/PeterOrneholm/orgs","repos_url":"https://api.github.com/users/PeterOrneholm/repos","events_url":"https://api.github.com/users/PeterOrneholm/events{/privacy}","received_events_url":"https://api.github.com/users/PeterOrneholm/received_events","type":"User","site_admin":false},"created_at":"2018-10-20T09:05:40Z","updated_at":"2018-10-20T09:05:40Z","author_association":"MEMBER","body":"Now green on all platforms :)\r\n\r\n![image](https://user-images.githubusercontent.com/1662918/47253755-0f144f80-d458-11e8-9575-c76c76a48777.png)"}}
{"actor":{"display_login":"PeterOrneholm"}}