{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls/2","id":190487917,"html_url":"https://github.com/4mile/custom_visualizations_v2/pull/2","diff_url":"https://github.com/4mile/custom_visualizations_v2/pull/2.diff","patch_url":"https://github.com/4mile/custom_visualizations_v2/pull/2.patch","issue_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues/2","number":2,"state":"closed","locked":false,"title":"Fill Gauge fixes & more","user":{"login":"statico","id":137158,"avatar_url":"https://avatars3.githubusercontent.com/u/137158?v=4","gravatar_id":"","url":"https://api.github.com/users/statico","html_url":"https://github.com/statico","followers_url":"https://api.github.com/users/statico/followers","following_url":"https://api.github.com/users/statico/following{/other_user}","gists_url":"https://api.github.com/users/statico/gists{/gist_id}","starred_url":"https://api.github.com/users/statico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statico/subscriptions","organizations_url":"https://api.github.com/users/statico/orgs","repos_url":"https://api.github.com/users/statico/repos","events_url":"https://api.github.com/users/statico/events{/privacy}","received_events_url":"https://api.github.com/users/statico/received_events","type":"User","site_admin":false},"body":"## In this PR:\r\n\r\n- Fix Liquid Fill Gauge to use a bundled version of D3 v4\r\n- Improve error messages (see below)\r\n- Various other fixes\r\n\r\nTested on both Looker-hosted and self-hosted instances.\r\n\r\n**Not working:** Chord visualization is still having trouble. Not sure why yet.\r\n\r\n## New errors\r\n\r\nNote that plurality is handled correctly.\r\n\r\n<img width=\"289\" alt=\"screen shot 2018-05-24 at 10 06 01 pm\" src=\"https://user-images.githubusercontent.com/137158/40528189-d8df4df2-5fa4-11e8-8fb7-374eda02c578.png\">\r\n<img width=\"296\" alt=\"screen shot 2018-05-24 at 10 06 11 pm\" src=\"https://user-images.githubusercontent.com/137158/40528190-d8f66604-5fa4-11e8-8572-e792edea07f8.png\">\r\n\r\nThere's also an \"at least\" variant too.\r\n\r\ncc @pascal4mile ","created_at":"2018-05-25T05:51:46Z","updated_at":"2018-05-25T17:08:09Z","closed_at":"2018-05-25T17:08:09Z","merged_at":"2018-05-25T17:08:09Z","merge_commit_sha":"a5acb330b9b99a24e8f844db5b781cc19251a266","assignee":{"login":"nickfogler","id":1134542,"avatar_url":"https://avatars3.githubusercontent.com/u/1134542?v=4","gravatar_id":"","url":"https://api.github.com/users/nickfogler","html_url":"https://github.com/nickfogler","followers_url":"https://api.github.com/users/nickfogler/followers","following_url":"https://api.github.com/users/nickfogler/following{/other_user}","gists_url":"https://api.github.com/users/nickfogler/gists{/gist_id}","starred_url":"https://api.github.com/users/nickfogler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickfogler/subscriptions","organizations_url":"https://api.github.com/users/nickfogler/orgs","repos_url":"https://api.github.com/users/nickfogler/repos","events_url":"https://api.github.com/users/nickfogler/events{/privacy}","received_events_url":"https://api.github.com/users/nickfogler/received_events","type":"User","site_admin":false},"assignees":[{"login":"nickfogler","id":1134542,"avatar_url":"https://avatars3.githubusercontent.com/u/1134542?v=4","gravatar_id":"","url":"https://api.github.com/users/nickfogler","html_url":"https://github.com/nickfogler","followers_url":"https://api.github.com/users/nickfogler/followers","following_url":"https://api.github.com/users/nickfogler/following{/other_user}","gists_url":"https://api.github.com/users/nickfogler/gists{/gist_id}","starred_url":"https://api.github.com/users/nickfogler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickfogler/subscriptions","organizations_url":"https://api.github.com/users/nickfogler/orgs","repos_url":"https://api.github.com/users/nickfogler/repos","events_url":"https://api.github.com/users/nickfogler/events{/privacy}","received_events_url":"https://api.github.com/users/nickfogler/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls/2/commits","review_comments_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls/2/comments","review_comment_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues/2/comments","statuses_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/statuses/8e0f88434093ffc0b8c11a318a3a9cf34aa4f6e1","head":{"label":"4mile:ian/fill-gauge-fixes","ref":"ian/fill-gauge-fixes","sha":"8e0f88434093ffc0b8c11a318a3a9cf34aa4f6e1","user":{"login":"4mile","id":36552956,"avatar_url":"https://avatars1.githubusercontent.com/u/36552956?v=4","gravatar_id":"","url":"https://api.github.com/users/4mile","html_url":"https://github.com/4mile","followers_url":"https://api.github.com/users/4mile/followers","following_url":"https://api.github.com/users/4mile/following{/other_user}","gists_url":"https://api.github.com/users/4mile/gists{/gist_id}","starred_url":"https://api.github.com/users/4mile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4mile/subscriptions","organizations_url":"https://api.github.com/users/4mile/orgs","repos_url":"https://api.github.com/users/4mile/repos","events_url":"https://api.github.com/users/4mile/events{/privacy}","received_events_url":"https://api.github.com/users/4mile/received_events","type":"Organization","site_admin":false},"repo":{"id":130785012,"name":"custom_visualizations_v2","full_name":"4mile/custom_visualizations_v2","owner":{"login":"4mile","id":36552956,"avatar_url":"https://avatars1.githubusercontent.com/u/36552956?v=4","gravatar_id":"","url":"https://api.github.com/users/4mile","html_url":"https://github.com/4mile","followers_url":"https://api.github.com/users/4mile/followers","following_url":"https://api.github.com/users/4mile/following{/other_user}","gists_url":"https://api.github.com/users/4mile/gists{/gist_id}","starred_url":"https://api.github.com/users/4mile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4mile/subscriptions","organizations_url":"https://api.github.com/users/4mile/orgs","repos_url":"https://api.github.com/users/4mile/repos","events_url":"https://api.github.com/users/4mile/events{/privacy}","received_events_url":"https://api.github.com/users/4mile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4mile/custom_visualizations_v2","description":null,"fork":true,"url":"https://api.github.com/repos/4mile/custom_visualizations_v2","forks_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/forks","keys_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/teams","hooks_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/hooks","issue_events_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues/events{/number}","events_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/events","assignees_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/assignees{/user}","branches_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/branches{/branch}","tags_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/tags","blobs_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/statuses/{sha}","languages_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/languages","stargazers_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/stargazers","contributors_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/contributors","subscribers_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/subscribers","subscription_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/subscription","commits_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/contents/{+path}","compare_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/merges","archive_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/downloads","issues_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues{/number}","pulls_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls{/number}","milestones_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/milestones{/number}","notifications_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/labels{/name}","releases_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/releases{/id}","deployments_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/deployments","created_at":"2018-04-24T02:31:39Z","updated_at":"2018-05-23T19:06:21Z","pushed_at":"2018-05-25T17:08:08Z","git_url":"git://github.com/4mile/custom_visualizations_v2.git","ssh_url":"git@github.com:4mile/custom_visualizations_v2.git","clone_url":"https://github.com/4mile/custom_visualizations_v2.git","svn_url":"https://github.com/4mile/custom_visualizations_v2","homepage":null,"size":64314,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"4mile:master","ref":"master","sha":"4380a5224fc5c004fd1ec5ec445c3f5cc7fa5081","user":{"login":"4mile","id":36552956,"avatar_url":"https://avatars1.githubusercontent.com/u/36552956?v=4","gravatar_id":"","url":"https://api.github.com/users/4mile","html_url":"https://github.com/4mile","followers_url":"https://api.github.com/users/4mile/followers","following_url":"https://api.github.com/users/4mile/following{/other_user}","gists_url":"https://api.github.com/users/4mile/gists{/gist_id}","starred_url":"https://api.github.com/users/4mile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4mile/subscriptions","organizations_url":"https://api.github.com/users/4mile/orgs","repos_url":"https://api.github.com/users/4mile/repos","events_url":"https://api.github.com/users/4mile/events{/privacy}","received_events_url":"https://api.github.com/users/4mile/received_events","type":"Organization","site_admin":false},"repo":{"id":130785012,"name":"custom_visualizations_v2","full_name":"4mile/custom_visualizations_v2","owner":{"login":"4mile","id":36552956,"avatar_url":"https://avatars1.githubusercontent.com/u/36552956?v=4","gravatar_id":"","url":"https://api.github.com/users/4mile","html_url":"https://github.com/4mile","followers_url":"https://api.github.com/users/4mile/followers","following_url":"https://api.github.com/users/4mile/following{/other_user}","gists_url":"https://api.github.com/users/4mile/gists{/gist_id}","starred_url":"https://api.github.com/users/4mile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4mile/subscriptions","organizations_url":"https://api.github.com/users/4mile/orgs","repos_url":"https://api.github.com/users/4mile/repos","events_url":"https://api.github.com/users/4mile/events{/privacy}","received_events_url":"https://api.github.com/users/4mile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4mile/custom_visualizations_v2","description":null,"fork":true,"url":"https://api.github.com/repos/4mile/custom_visualizations_v2","forks_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/forks","keys_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/teams","hooks_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/hooks","issue_events_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues/events{/number}","events_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/events","assignees_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/assignees{/user}","branches_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/branches{/branch}","tags_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/tags","blobs_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/statuses/{sha}","languages_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/languages","stargazers_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/stargazers","contributors_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/contributors","subscribers_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/subscribers","subscription_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/subscription","commits_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/contents/{+path}","compare_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/merges","archive_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/downloads","issues_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues{/number}","pulls_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls{/number}","milestones_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/milestones{/number}","notifications_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/labels{/name}","releases_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/releases{/id}","deployments_url":"https://api.github.com/repos/4mile/custom_visualizations_v2/deployments","created_at":"2018-04-24T02:31:39Z","updated_at":"2018-05-23T19:06:21Z","pushed_at":"2018-05-25T17:08:08Z","git_url":"git://github.com/4mile/custom_visualizations_v2.git","ssh_url":"git@github.com:4mile/custom_visualizations_v2.git","clone_url":"https://github.com/4mile/custom_visualizations_v2.git","svn_url":"https://github.com/4mile/custom_visualizations_v2","homepage":null,"size":64314,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls/2"},"html":{"href":"https://github.com/4mile/custom_visualizations_v2/pull/2"},"issue":{"href":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues/2"},"comments":{"href":"https://api.github.com/repos/4mile/custom_visualizations_v2/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/4mile/custom_visualizations_v2/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/4mile/custom_visualizations_v2/statuses/8e0f88434093ffc0b8c11a318a3a9cf34aa4f6e1"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"statico","id":137158,"avatar_url":"https://avatars3.githubusercontent.com/u/137158?v=4","gravatar_id":"","url":"https://api.github.com/users/statico","html_url":"https://github.com/statico","followers_url":"https://api.github.com/users/statico/followers","following_url":"https://api.github.com/users/statico/following{/other_user}","gists_url":"https://api.github.com/users/statico/gists{/gist_id}","starred_url":"https://api.github.com/users/statico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statico/subscriptions","organizations_url":"https://api.github.com/users/statico/orgs","repos_url":"https://api.github.com/users/statico/repos","events_url":"https://api.github.com/users/statico/events{/privacy}","received_events_url":"https://api.github.com/users/statico/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":8331,"deletions":6193,"changed_files":15}}
{"actor":{"display_login":"statico"}}