{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/comments/221344519","pull_request_review_id":159976651,"id":221344519,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTM0NDUxOQ==","diff_hunk":"@@ -3,6 +3,8 @@ Param(\n   [string] $configuration = \"Debug\",\n   [string] $projects = \"\",\n   [string] $verbosity = \"minimal\",\n+  [bool] $warnaserror = $true,","path":"eng/common/build.ps1","position":4,"original_position":4,"commit_id":"e3754916a9650045858ade721de71fdb5bdae601","original_commit_id":"e3754916a9650045858ade721de71fdb5bdae601","user":{"login":"tmat","id":41759,"node_id":"MDQ6VXNlcjQxNzU5","avatar_url":"https://avatars0.githubusercontent.com/u/41759?v=4","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"I don't like the inconsistency. ","created_at":"2018-09-28T18:34:37Z","updated_at":"2018-09-28T18:34:37Z","html_url":"https://github.com/dotnet/arcade/pull/845#discussion_r221344519","pull_request_url":"https://api.github.com/repos/dotnet/arcade/pulls/845","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments/221344519"},"html":{"href":"https://github.com/dotnet/arcade/pull/845#discussion_r221344519"},"pull_request":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/845"}},"in_reply_to_id":221115545},"pull_request":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/845","id":217779656,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Nzc5NjU2","html_url":"https://github.com/dotnet/arcade/pull/845","diff_url":"https://github.com/dotnet/arcade/pull/845.diff","patch_url":"https://github.com/dotnet/arcade/pull/845.patch","issue_url":"https://api.github.com/repos/dotnet/arcade/issues/845","number":845,"state":"open","locked":false,"title":"Refactor build scripts","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"This change splits build.ps1/sh into three scripts:\r\n\r\n1) init-tools.ps1/sh which is sets up the toolset and is intended\r\nto be sourced into wrapper scripts for initializing.\r\n2) msbuild.ps1/sh which allows for directly calling msbuild with\r\nthe bootstrapped toolset\r\n3) build.ps1/sh does what it used to using the new refactored\r\nbuild scripts.\r\n\r\nThis allows for more scenarios to be able to run on top of the\r\nbootstrapped toolset beyond just the root level build.\r\n\r\n@tmat @mmitche PTAL\r\n","created_at":"2018-09-24T20:33:45Z","updated_at":"2018-09-28T18:34:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"374588aebabd53012d90f2ca8427383eccf99658","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/arcade/pulls/845/commits","review_comments_url":"https://api.github.com/repos/dotnet/arcade/pulls/845/comments","review_comment_url":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/845/comments","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/e3754916a9650045858ade721de71fdb5bdae601","head":{"label":"weshaggard:RefactorBuildScript","ref":"RefactorBuildScript","sha":"e3754916a9650045858ade721de71fdb5bdae601","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"repo":{"id":138654237,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2NTQyMzc=","name":"arcade","full_name":"weshaggard/arcade","private":false,"owner":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/weshaggard/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":true,"url":"https://api.github.com/repos/weshaggard/arcade","forks_url":"https://api.github.com/repos/weshaggard/arcade/forks","keys_url":"https://api.github.com/repos/weshaggard/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weshaggard/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weshaggard/arcade/teams","hooks_url":"https://api.github.com/repos/weshaggard/arcade/hooks","issue_events_url":"https://api.github.com/repos/weshaggard/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/weshaggard/arcade/events","assignees_url":"https://api.github.com/repos/weshaggard/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/weshaggard/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/weshaggard/arcade/tags","blobs_url":"https://api.github.com/repos/weshaggard/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weshaggard/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weshaggard/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/weshaggard/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weshaggard/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/weshaggard/arcade/languages","stargazers_url":"https://api.github.com/repos/weshaggard/arcade/stargazers","contributors_url":"https://api.github.com/repos/weshaggard/arcade/contributors","subscribers_url":"https://api.github.com/repos/weshaggard/arcade/subscribers","subscription_url":"https://api.github.com/repos/weshaggard/arcade/subscription","commits_url":"https://api.github.com/repos/weshaggard/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/weshaggard/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/weshaggard/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/weshaggard/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/weshaggard/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/weshaggard/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weshaggard/arcade/merges","archive_url":"https://api.github.com/repos/weshaggard/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weshaggard/arcade/downloads","issues_url":"https://api.github.com/repos/weshaggard/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/weshaggard/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/weshaggard/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/weshaggard/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weshaggard/arcade/labels{/name}","releases_url":"https://api.github.com/repos/weshaggard/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/weshaggard/arcade/deployments","created_at":"2018-06-25T21:56:12Z","updated_at":"2018-09-24T20:05:58Z","pushed_at":"2018-09-28T00:25:06Z","git_url":"git://github.com/weshaggard/arcade.git","ssh_url":"git@github.com:weshaggard/arcade.git","clone_url":"https://github.com/weshaggard/arcade.git","svn_url":"https://github.com/weshaggard/arcade","homepage":"","size":4027,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"2d6b719c0f4fc4a1a7a66e43450d5e1267617340","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":121444325,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NDQzMjU=","name":"arcade","full_name":"dotnet/arcade","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":false,"url":"https://api.github.com/repos/dotnet/arcade","forks_url":"https://api.github.com/repos/dotnet/arcade/forks","keys_url":"https://api.github.com/repos/dotnet/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/arcade/teams","hooks_url":"https://api.github.com/repos/dotnet/arcade/hooks","issue_events_url":"https://api.github.com/repos/dotnet/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/arcade/events","assignees_url":"https://api.github.com/repos/dotnet/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/arcade/tags","blobs_url":"https://api.github.com/repos/dotnet/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/arcade/languages","stargazers_url":"https://api.github.com/repos/dotnet/arcade/stargazers","contributors_url":"https://api.github.com/repos/dotnet/arcade/contributors","subscribers_url":"https://api.github.com/repos/dotnet/arcade/subscribers","subscription_url":"https://api.github.com/repos/dotnet/arcade/subscription","commits_url":"https://api.github.com/repos/dotnet/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/arcade/merges","archive_url":"https://api.github.com/repos/dotnet/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/arcade/downloads","issues_url":"https://api.github.com/repos/dotnet/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/arcade/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/arcade/deployments","created_at":"2018-02-13T22:29:54Z","updated_at":"2018-09-28T16:41:02Z","pushed_at":"2018-09-28T16:40:59Z","git_url":"git://github.com/dotnet/arcade.git","ssh_url":"git@github.com:dotnet/arcade.git","clone_url":"https://github.com/dotnet/arcade.git","svn_url":"https://github.com/dotnet/arcade","homepage":"","size":3911,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":274,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":274,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/845"},"html":{"href":"https://github.com/dotnet/arcade/pull/845"},"issue":{"href":"https://api.github.com/repos/dotnet/arcade/issues/845"},"comments":{"href":"https://api.github.com/repos/dotnet/arcade/issues/845/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/845/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/845/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/arcade/statuses/e3754916a9650045858ade721de71fdb5bdae601"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tmat"}}