{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/261","repository_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node","labels_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/261/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/261/events","html_url":"https://github.com/Microsoft/vscode-languageserver-node/pull/261","id":263719795,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQ1MzM2MDc5","number":261,"title":"Add proposed window/progress extension","user":{"login":"Xanewok","id":3093213,"node_id":"MDQ6VXNlcjMwOTMyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3093213?v=4","gravatar_id":"","url":"https://api.github.com/users/Xanewok","html_url":"https://github.com/Xanewok","followers_url":"https://api.github.com/users/Xanewok/followers","following_url":"https://api.github.com/users/Xanewok/following{/other_user}","gists_url":"https://api.github.com/users/Xanewok/gists{/gist_id}","starred_url":"https://api.github.com/users/Xanewok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xanewok/subscriptions","organizations_url":"https://api.github.com/users/Xanewok/orgs","repos_url":"https://api.github.com/users/Xanewok/repos","events_url":"https://api.github.com/users/Xanewok/events{/privacy}","received_events_url":"https://api.github.com/users/Xanewok/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2017-10-08T13:57:12Z","updated_at":"2018-11-12T13:47:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/pulls/261","html_url":"https://github.com/Microsoft/vscode-languageserver-node/pull/261","diff_url":"https://github.com/Microsoft/vscode-languageserver-node/pull/261.diff","patch_url":"https://github.com/Microsoft/vscode-languageserver-node/pull/261.patch"},"body":"This proposes a simple `window/progress` server -> client notification that's been described in https://github.com/Microsoft/language-server-protocol/pull/245. I tried to follow [contributing.md](https://github.com/Microsoft/language-server-protocol/blob/master/contributing.md) as closely as possible, however it's possible I missed something. Additionally I'm not a TS/JS dev, so if there are any concerns for the client implementation, I'm more than open to changing it accordingly.\r\n\r\nI think it's a simple but often requested feature and it'd be good to land it, at least with a simple initial version to gather proposal and improve upon it.\r\n\r\ncc @felixfbecker this proposes the https://github.com/sourcegraph/language-server-protocol/commit/8986486a61f50bfe8ed449d1fd0b8e2f42656a5a."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/comments/437886469","html_url":"https://github.com/Microsoft/vscode-languageserver-node/pull/261#issuecomment-437886469","issue_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/261","id":437886469,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzg4NjQ2OQ==","user":{"login":"felixfbecker","id":10532611,"node_id":"MDQ6VXNlcjEwNTMyNjEx","avatar_url":"https://avatars0.githubusercontent.com/u/10532611?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfbecker","html_url":"https://github.com/felixfbecker","followers_url":"https://api.github.com/users/felixfbecker/followers","following_url":"https://api.github.com/users/felixfbecker/following{/other_user}","gists_url":"https://api.github.com/users/felixfbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfbecker/subscriptions","organizations_url":"https://api.github.com/users/felixfbecker/orgs","repos_url":"https://api.github.com/users/felixfbecker/repos","events_url":"https://api.github.com/users/felixfbecker/events{/privacy}","received_events_url":"https://api.github.com/users/felixfbecker/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T13:47:04Z","updated_at":"2018-11-12T13:47:04Z","author_association":"NONE","body":"This proposal has been sitting for a while, seems functional and the concerns discussed here feel like bikeshedding. Given that the [official Rust language server already implements this proposal on the server side](https://github.com/rust-lang-nursery/rls/blob/0e7432a4ff58bf3584c44bdb390d557cee846968/src/lsp_data.rs#L366-L393), we intend to ship a client implementation that [conforms to the interfaces in this proposal in its current state](https://github.com/Microsoft/vscode-languageserver-node/blob/38429afa03bdf5e878ec988b4ddd6ee483953a4d/protocol/src/protocol.progress.proposed.ts) (which is also what the Rust LS sends) in the Sourcegraph web client and some language servers.\r\n\r\nhttps://github.com/sourcegraph/sourcegraph/issues/947"}}
{"actor":{"display_login":"felixfbecker"}}