{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/216206036","pull_request_review_id":153633611,"id":216206036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIwNjAzNg==","diff_hunk":"@@ -48,18 +48,20 @@\n  \n +    private int loadTexture(Stitcher stitcher, IResourceManager p_110571_1_, ResourceLocation location, TextureAtlasSprite textureatlassprite, net.minecraftforge.fml.common.ProgressManager.ProgressBar bar, int j, int k)\n +    {\n-+        if (loadedSprites.contains(location)) {\n++        if (loadedSprites.contains(location))\n++        {","path":"patches/minecraft/net/minecraft/client/renderer/texture/TextureMap.java.patch","position":15,"original_position":15,"commit_id":"2216ec685af5dad661fbe01fd359e4423eb5c2ad","original_commit_id":"2216ec685af5dad661fbe01fd359e4423eb5c2ad","user":{"login":"tterrag1098","id":3751664,"node_id":"MDQ6VXNlcjM3NTE2NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3751664?v=4","gravatar_id":"","url":"https://api.github.com/users/tterrag1098","html_url":"https://github.com/tterrag1098","followers_url":"https://api.github.com/users/tterrag1098/followers","following_url":"https://api.github.com/users/tterrag1098/following{/other_user}","gists_url":"https://api.github.com/users/tterrag1098/gists{/gist_id}","starred_url":"https://api.github.com/users/tterrag1098/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tterrag1098/subscriptions","organizations_url":"https://api.github.com/users/tterrag1098/orgs","repos_url":"https://api.github.com/users/tterrag1098/repos","events_url":"https://api.github.com/users/tterrag1098/events{/privacy}","received_events_url":"https://api.github.com/users/tterrag1098/received_events","type":"User","site_admin":false},"body":"Avoid formatting and whitespace changes, there are a few here.","created_at":"2018-09-10T06:04:16Z","updated_at":"2018-09-10T06:06:54Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/5121#discussion_r216206036","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5121","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/216206036"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/5121#discussion_r216206036"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5121"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5121","id":210988304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTg4MzA0","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/5121","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/5121.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/5121.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/5121","number":5121,"state":"open","locked":false,"title":"Prevent some texture loading errors from crashing the game","user":{"login":"bs2609","id":1447117,"node_id":"MDQ6VXNlcjE0NDcxMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1447117?v=4","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"body":"This PR contains a couple of small fixes for texture loading to better align with how model loading is handled.\r\n\r\nFirstly, loading is halted when a dependency cycle is detected. At present this error is tracked, but loading continues regardless.\r\n\r\nSecondly, the code to support custom texture loaders is moved inside the `try` block covering the vanilla handling.\r\n\r\nThe intention here is to prevent these resource loading errors from abruptly crashing the game, instead logging the error and using the fallback \"missing\" resource, much like how model loading is handled.","created_at":"2018-08-27T02:03:53Z","updated_at":"2018-09-10T06:06:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5b0824928c44b5f653a62e6d0b3c6f4cce0beb1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5121/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5121/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/5121/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/2216ec685af5dad661fbe01fd359e4423eb5c2ad","head":{"label":"bs2609:texture-loader-handling","ref":"texture-loader-handling","sha":"2216ec685af5dad661fbe01fd359e4423eb5c2ad","user":{"login":"bs2609","id":1447117,"node_id":"MDQ6VXNlcjE0NDcxMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1447117?v=4","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"repo":{"id":69063094,"node_id":"MDEwOlJlcG9zaXRvcnk2OTA2MzA5NA==","name":"MinecraftForge","full_name":"bs2609/MinecraftForge","owner":{"login":"bs2609","id":1447117,"node_id":"MDQ6VXNlcjE0NDcxMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1447117?v=4","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bs2609/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/bs2609/MinecraftForge","forks_url":"https://api.github.com/repos/bs2609/MinecraftForge/forks","keys_url":"https://api.github.com/repos/bs2609/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bs2609/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bs2609/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/bs2609/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/bs2609/MinecraftForge/events","assignees_url":"https://api.github.com/repos/bs2609/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/bs2609/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/bs2609/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bs2609/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/bs2609/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/bs2609/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/bs2609/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/bs2609/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/bs2609/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/bs2609/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/bs2609/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/bs2609/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/bs2609/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bs2609/MinecraftForge/merges","archive_url":"https://api.github.com/repos/bs2609/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bs2609/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/bs2609/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/bs2609/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/bs2609/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bs2609/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/bs2609/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/bs2609/MinecraftForge/deployments","created_at":"2016-09-23T21:50:44Z","updated_at":"2016-09-23T21:50:49Z","pushed_at":"2018-08-29T09:00:42Z","git_url":"git://github.com/bs2609/MinecraftForge.git","ssh_url":"git@github.com:bs2609/MinecraftForge.git","clone_url":"https://github.com/bs2609/MinecraftForge.git","svn_url":"https://github.com/bs2609/MinecraftForge","homepage":"","size":92665,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.11.x"}},"base":{"label":"MinecraftForge:1.12.x","ref":"1.12.x","sha":"f2da4be93e436258aaa52f3b053b842838dd33d2","user":{"login":"MinecraftForge","id":1390178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTAxNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAxNDAw","name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTAxNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2018-09-10T05:58:04Z","pushed_at":"2018-09-10T03:39:47Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":93273,"stargazers_count":2408,"watchers_count":2408,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1200,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1200,"open_issues":154,"watchers":2408,"default_branch":"1.12.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5121"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/5121"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/5121"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/5121/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5121/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5121/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/2216ec685af5dad661fbe01fd359e4423eb5c2ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tterrag1098"}}