{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16934","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16934/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16934/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16934/events","html_url":"https://github.com/ManageIQ/manageiq/pull/16934","id":293651996,"number":16934,"title":"[FINE] Filter out duplicates from fog response during refresh","user":{"login":"mansam","id":628956,"avatar_url":"https://avatars3.githubusercontent.com/u/628956?v=4","gravatar_id":"","url":"https://api.github.com/users/mansam","html_url":"https://github.com/mansam","followers_url":"https://api.github.com/users/mansam/followers","following_url":"https://api.github.com/users/mansam/following{/other_user}","gists_url":"https://api.github.com/users/mansam/gists{/gist_id}","starred_url":"https://api.github.com/users/mansam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansam/subscriptions","organizations_url":"https://api.github.com/users/mansam/orgs","repos_url":"https://api.github.com/users/mansam/repos","events_url":"https://api.github.com/users/mansam/events{/privacy}","received_events_url":"https://api.github.com/users/mansam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"simaishi","id":12955530,"avatar_url":"https://avatars2.githubusercontent.com/u/12955530?v=4","gravatar_id":"","url":"https://api.github.com/users/simaishi","html_url":"https://github.com/simaishi","followers_url":"https://api.github.com/users/simaishi/followers","following_url":"https://api.github.com/users/simaishi/following{/other_user}","gists_url":"https://api.github.com/users/simaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/simaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simaishi/subscriptions","organizations_url":"https://api.github.com/users/simaishi/orgs","repos_url":"https://api.github.com/users/simaishi/repos","events_url":"https://api.github.com/users/simaishi/events{/privacy}","received_events_url":"https://api.github.com/users/simaishi/received_events","type":"User","site_admin":false},"assignees":[{"login":"simaishi","id":12955530,"avatar_url":"https://avatars2.githubusercontent.com/u/12955530?v=4","gravatar_id":"","url":"https://api.github.com/users/simaishi","html_url":"https://github.com/simaishi","followers_url":"https://api.github.com/users/simaishi/followers","following_url":"https://api.github.com/users/simaishi/following{/other_user}","gists_url":"https://api.github.com/users/simaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/simaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simaishi/subscriptions","organizations_url":"https://api.github.com/users/simaishi/orgs","repos_url":"https://api.github.com/users/simaishi/repos","events_url":"https://api.github.com/users/simaishi/events{/privacy}","received_events_url":"https://api.github.com/users/simaishi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-01T19:21:01Z","updated_at":"2018-02-01T19:38:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16934","html_url":"https://github.com/ManageIQ/manageiq/pull/16934","diff_url":"https://github.com/ManageIQ/manageiq/pull/16934.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/16934.patch"},"body":"This is the Fine version of https://github.com/ManageIQ/manageiq-providers-openstack/pull/212 to fix https://bugzilla.redhat.com/show_bug.cgi?id=1528663. Needs to be merged along with https://github.com/ManageIQ/manageiq-gems-pending/pull/334."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/362378331","html_url":"https://github.com/ManageIQ/manageiq/pull/16934#issuecomment-362378331","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16934","id":362378331,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T19:38:56Z","updated_at":"2018-02-01T19:38:56Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/mansam/manageiq/compare/91d086d66b18c14bda47d7a63080194d5aaa6616~...ec0c07ef611e9dd24182348b2d7f7a4c472f4c66 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0\n20 files checked, 4 offenses detected\n\n**\\*\\***\n- [ ] :bomb: :boom: :fire: :fire_engine: - Linter/Yaml - missing config files\n\n**app/models/manageiq/providers/openstack/refresh_parser_common/helper_methods.rb**\n- [ ] :exclamation: - [Line 13](https://github.com/mansam/manageiq/blob/ec0c07ef611e9dd24182348b2d7f7a4c472f4c66/app/models/manageiq/providers/openstack/refresh_parser_common/helper_methods.rb#L13), Col 44 - [Style/ParenthesesAroundCondition](http://rubydoc.info/gems/rubocop/0.52.0/RuboCop/Cop/Style/ParenthesesAroundCondition) - Don't use parentheses around the condition of an `if`.\n- [ ] :exclamation: - [Line 13](https://github.com/mansam/manageiq/blob/ec0c07ef611e9dd24182348b2d7f7a4c472f4c66/app/models/manageiq/providers/openstack/refresh_parser_common/helper_methods.rb#L13), Col 45 - [Style/NumericPredicate](http://rubydoc.info/gems/rubocop/0.52.0/RuboCop/Cop/Style/NumericPredicate) - Use `unique_objs.size.positive?` instead of `unique_objs.size > 0`.\n- [ ] :exclamation: - [Line 13](https://github.com/mansam/manageiq/blob/ec0c07ef611e9dd24182348b2d7f7a4c472f4c66/app/models/manageiq/providers/openstack/refresh_parser_common/helper_methods.rb#L13), Col 45 - [Style/ZeroLengthPredicate](http://rubydoc.info/gems/rubocop/0.52.0/RuboCop/Cop/Style/ZeroLengthPredicate) - Use `!empty?` instead of `size > 0`.\n"}}
{"actor":{"display_login":"miq-bot"}}