{"action":"created","issue":{"url":"https://api.github.com/repos/koajs/koa/issues/1232","repository_url":"https://api.github.com/repos/koajs/koa","labels_url":"https://api.github.com/repos/koajs/koa/issues/1232/labels{/name}","comments_url":"https://api.github.com/repos/koajs/koa/issues/1232/comments","events_url":"https://api.github.com/repos/koajs/koa/issues/1232/events","html_url":"https://github.com/koajs/koa/pull/1232","id":349606580,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjgyODQ4","number":1232,"title":"fix: redirect failed when not match rfc7230","user":{"login":"XadillaX","id":2842176,"node_id":"MDQ6VXNlcjI4NDIxNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/2842176?v=4","gravatar_id":"","url":"https://api.github.com/users/XadillaX","html_url":"https://github.com/XadillaX","followers_url":"https://api.github.com/users/XadillaX/followers","following_url":"https://api.github.com/users/XadillaX/following{/other_user}","gists_url":"https://api.github.com/users/XadillaX/gists{/gist_id}","starred_url":"https://api.github.com/users/XadillaX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XadillaX/subscriptions","organizations_url":"https://api.github.com/users/XadillaX/orgs","repos_url":"https://api.github.com/users/XadillaX/repos","events_url":"https://api.github.com/users/XadillaX/events{/privacy}","received_events_url":"https://api.github.com/users/XadillaX/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-10T18:01:12Z","updated_at":"2018-08-10T18:06:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/koajs/koa/pulls/1232","html_url":"https://github.com/koajs/koa/pull/1232","diff_url":"https://github.com/koajs/koa/pull/1232.diff","patch_url":"https://github.com/koajs/koa/pull/1232.patch"},"body":"When I write:\r\n\r\n```js\r\nctx.redirect('你好世界');\r\n```\r\n\r\nNode.js will throw an error due to https://github.com/nodejs/node/blob/862389b0aacfd41770c3fa6f692aed11c2a4b3ed/lib/_http_common.js#L245.\r\n\r\nThis PR is to encode the uri to match [rfc7230](https://tools.ietf.org/html/rfc7230#section-3.2.6).\r\n\r\n> Needs backward."},"comment":{"url":"https://api.github.com/repos/koajs/koa/issues/comments/412161331","html_url":"https://github.com/koajs/koa/pull/1232#issuecomment-412161331","issue_url":"https://api.github.com/repos/koajs/koa/issues/1232","id":412161331,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjE2MTMzMQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-08-10T18:06:02Z","updated_at":"2018-08-10T18:06:02Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/koajs/koa/pull/1232?src=pr&el=h1) Report\n> Merging [#1232](https://codecov.io/gh/koajs/koa/pull/1232?src=pr&el=desc) into [master](https://codecov.io/gh/koajs/koa/commit/2180839eda2cb16edcfda46ccfe24711680af850?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/koajs/koa/pull/1232/graphs/tree.svg?width=650&height=150&src=pr&token=cvMfaQw3td)](https://codecov.io/gh/koajs/koa/pull/1232?src=pr&el=tree)\n\n```diff\n@@          Coverage Diff           @@\n##           master   #1232   +/-   ##\n======================================\n  Coverage     100%    100%           \n======================================\n  Files           5       5           \n  Lines         391     393    +2     \n======================================\n+ Hits          391     393    +2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/koajs/koa/pull/1232?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [lib/response.js](https://codecov.io/gh/koajs/koa/pull/1232/diff?src=pr&el=tree#diff-bGliL3Jlc3BvbnNlLmpz) | `100% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/koajs/koa/pull/1232?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/koajs/koa/pull/1232?src=pr&el=footer). Last update [2180839...5c90dd5](https://codecov.io/gh/koajs/koa/pull/1232?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}