{"action":"created","issue":{"url":"https://api.github.com/repos/ulaval/modul-components/issues/478","repository_url":"https://api.github.com/repos/ulaval/modul-components","labels_url":"https://api.github.com/repos/ulaval/modul-components/issues/478/labels{/name}","comments_url":"https://api.github.com/repos/ulaval/modul-components/issues/478/comments","events_url":"https://api.github.com/repos/ulaval/modul-components/issues/478/events","html_url":"https://github.com/ulaval/modul-components/pull/478","id":362221711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTk4Nzc2","number":478,"title":"Feature/modul 99 ajout entry point et typing a la distribution","user":{"login":"chuckmah","id":581365,"node_id":"MDQ6VXNlcjU4MTM2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/581365?v=4","gravatar_id":"","url":"https://api.github.com/users/chuckmah","html_url":"https://github.com/chuckmah","followers_url":"https://api.github.com/users/chuckmah/followers","following_url":"https://api.github.com/users/chuckmah/following{/other_user}","gists_url":"https://api.github.com/users/chuckmah/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckmah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckmah/subscriptions","organizations_url":"https://api.github.com/users/chuckmah/orgs","repos_url":"https://api.github.com/users/chuckmah/repos","events_url":"https://api.github.com/users/chuckmah/events{/privacy}","received_events_url":"https://api.github.com/users/chuckmah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ulaval/modul-components/milestones/42","html_url":"https://github.com/ulaval/modul-components/milestone/42","labels_url":"https://api.github.com/repos/ulaval/modul-components/milestones/42/labels","id":3712937,"node_id":"MDk6TWlsZXN0b25lMzcxMjkzNw==","number":42,"title":"1.0.0-beta.62","description":"","creator":{"login":"vidal7","id":33458053,"node_id":"MDQ6VXNlcjMzNDU4MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/33458053?v=4","gravatar_id":"","url":"https://api.github.com/users/vidal7","html_url":"https://github.com/vidal7","followers_url":"https://api.github.com/users/vidal7/followers","following_url":"https://api.github.com/users/vidal7/following{/other_user}","gists_url":"https://api.github.com/users/vidal7/gists{/gist_id}","starred_url":"https://api.github.com/users/vidal7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidal7/subscriptions","organizations_url":"https://api.github.com/users/vidal7/orgs","repos_url":"https://api.github.com/users/vidal7/repos","events_url":"https://api.github.com/users/vidal7/events{/privacy}","received_events_url":"https://api.github.com/users/vidal7/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2018-10-04T17:46:41Z","updated_at":"2018-10-11T20:31:47Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-09-20T14:43:19Z","updated_at":"2018-10-12T14:54:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ulaval/modul-components/pulls/478","html_url":"https://github.com/ulaval/modul-components/pull/478","diff_url":"https://github.com/ulaval/modul-components/pull/478.diff","patch_url":"https://github.com/ulaval/modul-components/pull/478.patch"},"body":"## `@ulaval/modul-components`\r\n# PR Checklist\r\n\r\n\r\n<!-- REQUIRED -->\r\n- [x] Provide a small description of the changes introduced by this PR\r\n\r\nProposition pour l'ajout d'un \"main\" au package.json afin de définir un entry point a modul afin de permettre l'importation des module de modul sans mettre le chemin complet. Ceci permet entre-autre de faciliter les changement au niveau de modul sans impacter les projets.\r\n\r\npar example au lieu d'importer les plugin comme \r\n``` typescript \r\nimport ComponentsPlugin from '@ulaval/modul-components/dist/components';\r\nimport DirectivesPlugin from '@ulaval/modul-components/dist/directives';\r\n```\r\n\r\non peut maintenant faire \r\n``` typescript \r\nimport { DirectivesPlugin , ComponentsPlugin } from '@ulaval/modul-components';\r\n```\r\n\r\nIl ne devrait pas avoir de regression et aucun changement pour les projet utilisant les deux type d'import.\r\n\r\n<!-- Description here... -->\r\n- [x] Include links to issues\r\nhttps://jira.dti.ulaval.ca/browse/MODUL-99\r\n\r\n\r\n<!-- END_REQUIRED -->\r\n\r\n<!-- OPTIONAL, remove unused -->\r\n- [ ] Include this section in the release notes\r\n<!-- Release notes here... -->\r\n- [ ] Other info\r\n<!-- Any other relevant information here... -->\r\n\r\n<!-- END_OPTIONAL -->\r\n\r\n<!-- Thanks for contributing! -->\r\n"},"comment":{"url":"https://api.github.com/repos/ulaval/modul-components/issues/comments/429353700","html_url":"https://github.com/ulaval/modul-components/pull/478#issuecomment-429353700","issue_url":"https://api.github.com/repos/ulaval/modul-components/issues/478","id":429353700,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTM1MzcwMA==","user":{"login":"chuckmah","id":581365,"node_id":"MDQ6VXNlcjU4MTM2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/581365?v=4","gravatar_id":"","url":"https://api.github.com/users/chuckmah","html_url":"https://github.com/chuckmah","followers_url":"https://api.github.com/users/chuckmah/followers","following_url":"https://api.github.com/users/chuckmah/following{/other_user}","gists_url":"https://api.github.com/users/chuckmah/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckmah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckmah/subscriptions","organizations_url":"https://api.github.com/users/chuckmah/orgs","repos_url":"https://api.github.com/users/chuckmah/repos","events_url":"https://api.github.com/users/chuckmah/events{/privacy}","received_events_url":"https://api.github.com/users/chuckmah/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T14:54:24Z","updated_at":"2018-10-12T14:54:24Z","author_association":"CONTRIBUTOR","body":"@jipigi : tel que discuté faudrait voir si c'est un comportement que l'on veut, a savoir si on veut utiliser la librairie en single file (modul.js) sinon on devrait simplement ne pas l'inclure dans la distribution a voir avec @vidal7  @simardo .\r\n\r\nSelon la décision je peux remettre le code a jours pour m'assurer que le PR ne cause aucun breaking change."}}
{"actor":{"display_login":"chuckmah"}}