{"action":"created","comment":{"url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/comments/213217864","pull_request_review_id":150004285,"id":213217864,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzIxNzg2NA==","diff_hunk":"@@ -121,14 +121,12 @@ De URLs in dit voorbeeld zijn uiteraard fictief.\n   ```\n \n \n-## Gerelateerde objecten zonder eigen resource / Groepsattributen\n+## Groepsattributen\n \n-Indien een (hoofd)object een gerelateerd object (of lijst van objecten) heeft,\n-dat **geen** eigen resource URL nodig heeft, dan wordt het (child)object inline\n-(binnen het hoofdobject) ontsloten. Deze child objecten zijn binnen RGBZ\n-ook wel gedefinieerd als *groepsattributen*. Typische voorbeelden zijn\n-(zaak-)kenmerken of (zaak-)eigenschappen waarin `Zaak` het hoofdobject betreft,\n-en `Kenmerk` en `Eigenschap` de child objecten.\n+Indien een object een groepattribuutsoort heeft (een groep van bij elkaar behorende attribuutsoorten), al dan niet herhalend d.w.z. kardinaliteit 1 of meer (een 'lijst' van waarden van de attributen van het groepattribuut), dan wordt het groepattribuut inline\n+(binnen het object) ontsloten. Het krijgt dus geen eigen resource, het heeft immers geen zelfstandig bestaantsrecht. Het heeft alleen bestaansrecht als eigenschap van het object, net zoals attribuutsoorten. ","path":"docs/content/developers/design-keuzes.md","position":23,"original_position":23,"commit_id":"58560542ff2fefcbe29a852dcee82be3ec3f0675","original_commit_id":"58560542ff2fefcbe29a852dcee82be3ec3f0675","user":{"login":"sergei-maertens","id":5518550,"node_id":"MDQ6VXNlcjU1MTg1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5518550?v=4","gravatar_id":"","url":"https://api.github.com/users/sergei-maertens","html_url":"https://github.com/sergei-maertens","followers_url":"https://api.github.com/users/sergei-maertens/followers","following_url":"https://api.github.com/users/sergei-maertens/following{/other_user}","gists_url":"https://api.github.com/users/sergei-maertens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergei-maertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergei-maertens/subscriptions","organizations_url":"https://api.github.com/users/sergei-maertens/orgs","repos_url":"https://api.github.com/users/sergei-maertens/repos","events_url":"https://api.github.com/users/sergei-maertens/events{/privacy}","received_events_url":"https://api.github.com/users/sergei-maertens/received_events","type":"User","site_admin":false},"body":"Met de regel hieronder, denk ik eigenlijk dat deze lijn zelfs helemaal weggelaten kan worden. Het gaat m.i. te veel in op de semantiek van RGBZ, en als developer die met REST/json bezig is, heb ik hier eigenlijk niet echt wat aan.","created_at":"2018-08-28T08:03:13Z","updated_at":"2018-08-28T08:04:10Z","html_url":"https://github.com/VNG-Realisatie/gemma-zaken/pull/329#discussion_r213217864","pull_request_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/329","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/comments/213217864"},"html":{"href":"https://github.com/VNG-Realisatie/gemma-zaken/pull/329#discussion_r213217864"},"pull_request":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/329"}},"in_reply_to_id":213217460},"pull_request":{"url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/329","id":211331081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzMxMDgx","html_url":"https://github.com/VNG-Realisatie/gemma-zaken/pull/329","diff_url":"https://github.com/VNG-Realisatie/gemma-zaken/pull/329.diff","patch_url":"https://github.com/VNG-Realisatie/gemma-zaken/pull/329.patch","issue_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues/329","number":329,"state":"open","locked":false,"title":"Gerelateerde objecten zonder eigen resource / Groepsattributen","user":{"login":"ArjanKloosterboer","id":23450232,"node_id":"MDQ6VXNlcjIzNDUwMjMy","avatar_url":"https://avatars0.githubusercontent.com/u/23450232?v=4","gravatar_id":"","url":"https://api.github.com/users/ArjanKloosterboer","html_url":"https://github.com/ArjanKloosterboer","followers_url":"https://api.github.com/users/ArjanKloosterboer/followers","following_url":"https://api.github.com/users/ArjanKloosterboer/following{/other_user}","gists_url":"https://api.github.com/users/ArjanKloosterboer/gists{/gist_id}","starred_url":"https://api.github.com/users/ArjanKloosterboer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArjanKloosterboer/subscriptions","organizations_url":"https://api.github.com/users/ArjanKloosterboer/orgs","repos_url":"https://api.github.com/users/ArjanKloosterboer/repos","events_url":"https://api.github.com/users/ArjanKloosterboer/events{/privacy}","received_events_url":"https://api.github.com/users/ArjanKloosterboer/received_events","type":"User","site_admin":false},"body":"Dit is een rare en m.i. onjuiste ontwerpkeuze. Er is, in het RGBZ, geen sprake van \"een (hoofd)object [dat] een gerelateerd object (of lijst van objecten) heeft, dat geen eigen resource URL nodig heeft\". Dit is een misvatting. Het RGBZ kent objecttypen die relaties met elkaar hebben. Indien een objecttype een eigen bestaansrecht heeft dan vraagt dat om uitwerking in een eigen resource. Kenmerken van dat objecttype maken deel uit van die resource. Kenmerken zijn attribuutsoorten. En die kunnen genest zijn: groepattributen. Maar ook dat blijven kenmerken van het objecttype, Dus geen enkele reden om dat uit te werken in een eigen resource.","created_at":"2018-08-28T07:49:11Z","updated_at":"2018-08-28T08:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c59bd2655ff4b3e400846d613b6a585aa37e3af6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/329/commits","review_comments_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/329/comments","review_comment_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues/329/comments","statuses_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/statuses/58560542ff2fefcbe29a852dcee82be3ec3f0675","head":{"label":"VNG-Realisatie:ArjanKloosterboer-groepattr","ref":"ArjanKloosterboer-groepattr","sha":"58560542ff2fefcbe29a852dcee82be3ec3f0675","user":{"login":"VNG-Realisatie","id":34739001,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzM5MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/34739001?v=4","gravatar_id":"","url":"https://api.github.com/users/VNG-Realisatie","html_url":"https://github.com/VNG-Realisatie","followers_url":"https://api.github.com/users/VNG-Realisatie/followers","following_url":"https://api.github.com/users/VNG-Realisatie/following{/other_user}","gists_url":"https://api.github.com/users/VNG-Realisatie/gists{/gist_id}","starred_url":"https://api.github.com/users/VNG-Realisatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VNG-Realisatie/subscriptions","organizations_url":"https://api.github.com/users/VNG-Realisatie/orgs","repos_url":"https://api.github.com/users/VNG-Realisatie/repos","events_url":"https://api.github.com/users/VNG-Realisatie/events{/privacy}","received_events_url":"https://api.github.com/users/VNG-Realisatie/received_events","type":"Organization","site_admin":false},"repo":{"id":124386532,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzODY1MzI=","name":"gemma-zaken","full_name":"VNG-Realisatie/gemma-zaken","owner":{"login":"VNG-Realisatie","id":34739001,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzM5MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/34739001?v=4","gravatar_id":"","url":"https://api.github.com/users/VNG-Realisatie","html_url":"https://github.com/VNG-Realisatie","followers_url":"https://api.github.com/users/VNG-Realisatie/followers","following_url":"https://api.github.com/users/VNG-Realisatie/following{/other_user}","gists_url":"https://api.github.com/users/VNG-Realisatie/gists{/gist_id}","starred_url":"https://api.github.com/users/VNG-Realisatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VNG-Realisatie/subscriptions","organizations_url":"https://api.github.com/users/VNG-Realisatie/orgs","repos_url":"https://api.github.com/users/VNG-Realisatie/repos","events_url":"https://api.github.com/users/VNG-Realisatie/events{/privacy}","received_events_url":"https://api.github.com/users/VNG-Realisatie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VNG-Realisatie/gemma-zaken","description":"Samen ontwikkelen van Zaak- Documentservices 2.0","fork":false,"url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken","forks_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/forks","keys_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/teams","hooks_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/hooks","issue_events_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues/events{/number}","events_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/events","assignees_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/assignees{/user}","branches_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/branches{/branch}","tags_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/tags","blobs_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/refs{/sha}","trees_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/statuses/{sha}","languages_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/languages","stargazers_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/stargazers","contributors_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/contributors","subscribers_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/subscribers","subscription_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/subscription","commits_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/commits{/sha}","git_commits_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/commits{/sha}","comments_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/comments{/number}","issue_comment_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues/comments{/number}","contents_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/contents/{+path}","compare_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/merges","archive_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/downloads","issues_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues{/number}","pulls_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls{/number}","milestones_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/milestones{/number}","notifications_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/labels{/name}","releases_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/releases{/id}","deployments_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/deployments","created_at":"2018-03-08T12:13:15Z","updated_at":"2018-08-27T07:57:24Z","pushed_at":"2018-08-28T07:49:11Z","git_url":"git://github.com/VNG-Realisatie/gemma-zaken.git","ssh_url":"git@github.com:VNG-Realisatie/gemma-zaken.git","clone_url":"https://github.com/VNG-Realisatie/gemma-zaken.git","svn_url":"https://github.com/VNG-Realisatie/gemma-zaken","homepage":"","size":15047,"stargazers_count":10,"watchers_count":10,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":160,"watchers":10,"default_branch":"master"}},"base":{"label":"VNG-Realisatie:master","ref":"master","sha":"1824bb073075ec0a5a2f9f0743f03e0d404de8eb","user":{"login":"VNG-Realisatie","id":34739001,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzM5MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/34739001?v=4","gravatar_id":"","url":"https://api.github.com/users/VNG-Realisatie","html_url":"https://github.com/VNG-Realisatie","followers_url":"https://api.github.com/users/VNG-Realisatie/followers","following_url":"https://api.github.com/users/VNG-Realisatie/following{/other_user}","gists_url":"https://api.github.com/users/VNG-Realisatie/gists{/gist_id}","starred_url":"https://api.github.com/users/VNG-Realisatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VNG-Realisatie/subscriptions","organizations_url":"https://api.github.com/users/VNG-Realisatie/orgs","repos_url":"https://api.github.com/users/VNG-Realisatie/repos","events_url":"https://api.github.com/users/VNG-Realisatie/events{/privacy}","received_events_url":"https://api.github.com/users/VNG-Realisatie/received_events","type":"Organization","site_admin":false},"repo":{"id":124386532,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzODY1MzI=","name":"gemma-zaken","full_name":"VNG-Realisatie/gemma-zaken","owner":{"login":"VNG-Realisatie","id":34739001,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzM5MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/34739001?v=4","gravatar_id":"","url":"https://api.github.com/users/VNG-Realisatie","html_url":"https://github.com/VNG-Realisatie","followers_url":"https://api.github.com/users/VNG-Realisatie/followers","following_url":"https://api.github.com/users/VNG-Realisatie/following{/other_user}","gists_url":"https://api.github.com/users/VNG-Realisatie/gists{/gist_id}","starred_url":"https://api.github.com/users/VNG-Realisatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VNG-Realisatie/subscriptions","organizations_url":"https://api.github.com/users/VNG-Realisatie/orgs","repos_url":"https://api.github.com/users/VNG-Realisatie/repos","events_url":"https://api.github.com/users/VNG-Realisatie/events{/privacy}","received_events_url":"https://api.github.com/users/VNG-Realisatie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VNG-Realisatie/gemma-zaken","description":"Samen ontwikkelen van Zaak- Documentservices 2.0","fork":false,"url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken","forks_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/forks","keys_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/teams","hooks_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/hooks","issue_events_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues/events{/number}","events_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/events","assignees_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/assignees{/user}","branches_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/branches{/branch}","tags_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/tags","blobs_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/refs{/sha}","trees_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/statuses/{sha}","languages_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/languages","stargazers_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/stargazers","contributors_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/contributors","subscribers_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/subscribers","subscription_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/subscription","commits_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/commits{/sha}","git_commits_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/git/commits{/sha}","comments_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/comments{/number}","issue_comment_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues/comments{/number}","contents_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/contents/{+path}","compare_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/merges","archive_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/downloads","issues_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues{/number}","pulls_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls{/number}","milestones_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/milestones{/number}","notifications_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/labels{/name}","releases_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/releases{/id}","deployments_url":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/deployments","created_at":"2018-03-08T12:13:15Z","updated_at":"2018-08-27T07:57:24Z","pushed_at":"2018-08-28T07:49:11Z","git_url":"git://github.com/VNG-Realisatie/gemma-zaken.git","ssh_url":"git@github.com:VNG-Realisatie/gemma-zaken.git","clone_url":"https://github.com/VNG-Realisatie/gemma-zaken.git","svn_url":"https://github.com/VNG-Realisatie/gemma-zaken","homepage":"","size":15047,"stargazers_count":10,"watchers_count":10,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":160,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/329"},"html":{"href":"https://github.com/VNG-Realisatie/gemma-zaken/pull/329"},"issue":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues/329"},"comments":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/VNG-Realisatie/gemma-zaken/statuses/58560542ff2fefcbe29a852dcee82be3ec3f0675"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sergei-maertens"}}