{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/192572103","pull_request_review_id":125378544,"id":192572103,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU3MjEwMw==","diff_hunk":"@@ -71,6 +71,13 @@ ERROR(class_var_not_in_class,none,\n       \"class properties are only allowed within classes; \"\n       \"use 'static' to declare a static property\", ())\n \n+ERROR(class_func_not_in_class_protocol,none,\n+      \"class methods are only allowed within classes; \"\n+      \"use 'static' to declare a requirement fulfilled by either a class or static method\", ())\n+ERROR(class_var_not_in_class_protocol,none,\n+      \"class properties are only allowed within classes; \"\n+      \"use 'static' to declare a requirement fulfilled by either a class or static property\", ())","path":"include/swift/AST/DiagnosticsCommon.def","position":9,"original_position":9,"commit_id":"2398d127ca2283f415efcd5228476298c95fe526","original_commit_id":"2398d127ca2283f415efcd5228476298c95fe526","user":{"login":"xwu","id":13952,"node_id":"MDQ6VXNlcjEzOTUy","avatar_url":"https://avatars2.githubusercontent.com/u/13952?v=4","gravatar_id":"","url":"https://api.github.com/users/xwu","html_url":"https://github.com/xwu","followers_url":"https://api.github.com/users/xwu/followers","following_url":"https://api.github.com/users/xwu/following{/other_user}","gists_url":"https://api.github.com/users/xwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwu/subscriptions","organizations_url":"https://api.github.com/users/xwu/orgs","repos_url":"https://api.github.com/users/xwu/repos","events_url":"https://api.github.com/users/xwu/events{/privacy}","received_events_url":"https://api.github.com/users/xwu/received_events","type":"User","site_admin":false},"body":"The last diagnostic in this file begins: “Generic requirement...” I doesn’t strike me as unfriendly.","created_at":"2018-06-02T22:37:46Z","updated_at":"2018-06-02T22:37:46Z","html_url":"https://github.com/apple/swift/pull/16965#discussion_r192572103","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/16965","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/192572103"},"html":{"href":"https://github.com/apple/swift/pull/16965#discussion_r192572103"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/16965"}},"in_reply_to_id":192571967},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/16965","id":192214124,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjE0MTI0","html_url":"https://github.com/apple/swift/pull/16965","diff_url":"https://github.com/apple/swift/pull/16965.diff","patch_url":"https://github.com/apple/swift/pull/16965.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/16965","number":16965,"state":"open","locked":false,"title":"Better error message for 'class func/var' usage in protocols","user":{"login":"Moximillian","id":5013136,"node_id":"MDQ6VXNlcjUwMTMxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5013136?v=4","gravatar_id":"","url":"https://api.github.com/users/Moximillian","html_url":"https://github.com/Moximillian","followers_url":"https://api.github.com/users/Moximillian/followers","following_url":"https://api.github.com/users/Moximillian/following{/other_user}","gists_url":"https://api.github.com/users/Moximillian/gists{/gist_id}","starred_url":"https://api.github.com/users/Moximillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moximillian/subscriptions","organizations_url":"https://api.github.com/users/Moximillian/orgs","repos_url":"https://api.github.com/users/Moximillian/repos","events_url":"https://api.github.com/users/Moximillian/events{/privacy}","received_events_url":"https://api.github.com/users/Moximillian/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nClarify how to use protocols in relation to class funcs. This has been discussed in https://forums.swift.org/t/class-constrained-protocols-dont-allow-for-class-methods/13031\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n","created_at":"2018-06-02T19:31:26Z","updated_at":"2018-06-02T22:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c10e4513d8b61ddce0e38b7d2c5e1cb969cc522","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/16965/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/16965/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/16965/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/2398d127ca2283f415efcd5228476298c95fe526","head":{"label":"Moximillian:class-method-protocol-error-clarification","ref":"class-method-protocol-error-clarification","sha":"2398d127ca2283f415efcd5228476298c95fe526","user":{"login":"Moximillian","id":5013136,"node_id":"MDQ6VXNlcjUwMTMxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5013136?v=4","gravatar_id":"","url":"https://api.github.com/users/Moximillian","html_url":"https://github.com/Moximillian","followers_url":"https://api.github.com/users/Moximillian/followers","following_url":"https://api.github.com/users/Moximillian/following{/other_user}","gists_url":"https://api.github.com/users/Moximillian/gists{/gist_id}","starred_url":"https://api.github.com/users/Moximillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moximillian/subscriptions","organizations_url":"https://api.github.com/users/Moximillian/orgs","repos_url":"https://api.github.com/users/Moximillian/repos","events_url":"https://api.github.com/users/Moximillian/events{/privacy}","received_events_url":"https://api.github.com/users/Moximillian/received_events","type":"User","site_admin":false},"repo":{"id":79818362,"node_id":"MDEwOlJlcG9zaXRvcnk3OTgxODM2Mg==","name":"swift","full_name":"Moximillian/swift","owner":{"login":"Moximillian","id":5013136,"node_id":"MDQ6VXNlcjUwMTMxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5013136?v=4","gravatar_id":"","url":"https://api.github.com/users/Moximillian","html_url":"https://github.com/Moximillian","followers_url":"https://api.github.com/users/Moximillian/followers","following_url":"https://api.github.com/users/Moximillian/following{/other_user}","gists_url":"https://api.github.com/users/Moximillian/gists{/gist_id}","starred_url":"https://api.github.com/users/Moximillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moximillian/subscriptions","organizations_url":"https://api.github.com/users/Moximillian/orgs","repos_url":"https://api.github.com/users/Moximillian/repos","events_url":"https://api.github.com/users/Moximillian/events{/privacy}","received_events_url":"https://api.github.com/users/Moximillian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Moximillian/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/Moximillian/swift","forks_url":"https://api.github.com/repos/Moximillian/swift/forks","keys_url":"https://api.github.com/repos/Moximillian/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Moximillian/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Moximillian/swift/teams","hooks_url":"https://api.github.com/repos/Moximillian/swift/hooks","issue_events_url":"https://api.github.com/repos/Moximillian/swift/issues/events{/number}","events_url":"https://api.github.com/repos/Moximillian/swift/events","assignees_url":"https://api.github.com/repos/Moximillian/swift/assignees{/user}","branches_url":"https://api.github.com/repos/Moximillian/swift/branches{/branch}","tags_url":"https://api.github.com/repos/Moximillian/swift/tags","blobs_url":"https://api.github.com/repos/Moximillian/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Moximillian/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Moximillian/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/Moximillian/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Moximillian/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/Moximillian/swift/languages","stargazers_url":"https://api.github.com/repos/Moximillian/swift/stargazers","contributors_url":"https://api.github.com/repos/Moximillian/swift/contributors","subscribers_url":"https://api.github.com/repos/Moximillian/swift/subscribers","subscription_url":"https://api.github.com/repos/Moximillian/swift/subscription","commits_url":"https://api.github.com/repos/Moximillian/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/Moximillian/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/Moximillian/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/Moximillian/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/Moximillian/swift/contents/{+path}","compare_url":"https://api.github.com/repos/Moximillian/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Moximillian/swift/merges","archive_url":"https://api.github.com/repos/Moximillian/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Moximillian/swift/downloads","issues_url":"https://api.github.com/repos/Moximillian/swift/issues{/number}","pulls_url":"https://api.github.com/repos/Moximillian/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/Moximillian/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/Moximillian/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Moximillian/swift/labels{/name}","releases_url":"https://api.github.com/repos/Moximillian/swift/releases{/id}","deployments_url":"https://api.github.com/repos/Moximillian/swift/deployments","created_at":"2017-01-23T15:40:52Z","updated_at":"2018-06-02T18:51:06Z","pushed_at":"2018-06-02T21:39:38Z","git_url":"git://github.com/Moximillian/swift.git","ssh_url":"git@github.com:Moximillian/swift.git","clone_url":"https://github.com/Moximillian/swift.git","svn_url":"https://github.com/Moximillian/swift","homepage":"https://swift.org/","size":275147,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"feb385736ba862819c6b2267b2a8d576a20419c4","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-06-02T20:51:06Z","pushed_at":"2018-06-02T21:39:40Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":293850,"stargazers_count":44031,"watchers_count":44031,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6936,"mirror_url":null,"archived":false,"open_issues_count":340,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6936,"open_issues":340,"watchers":44031,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/16965"},"html":{"href":"https://github.com/apple/swift/pull/16965"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/16965"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/16965/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/16965/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/16965/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/2398d127ca2283f415efcd5228476298c95fe526"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xwu"}}