{"action":"created","issue":{"url":"https://api.github.com/repos/datto/dattobd/issues/162","repository_url":"https://api.github.com/repos/datto/dattobd","labels_url":"https://api.github.com/repos/datto/dattobd/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/datto/dattobd/issues/162/comments","events_url":"https://api.github.com/repos/datto/dattobd/issues/162/events","html_url":"https://github.com/datto/dattobd/issues/162","id":378667249,"node_id":"MDU6SXNzdWUzNzg2NjcyNDk=","number":162,"title":"fix strncpy problem","user":{"login":"nixomose","id":13739626,"node_id":"MDQ6VXNlcjEzNzM5NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/13739626?v=4","gravatar_id":"","url":"https://api.github.com/users/nixomose","html_url":"https://github.com/nixomose","followers_url":"https://api.github.com/users/nixomose/followers","following_url":"https://api.github.com/users/nixomose/following{/other_user}","gists_url":"https://api.github.com/users/nixomose/gists{/gist_id}","starred_url":"https://api.github.com/users/nixomose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixomose/subscriptions","organizations_url":"https://api.github.com/users/nixomose/orgs","repos_url":"https://api.github.com/users/nixomose/repos","events_url":"https://api.github.com/users/nixomose/events{/privacy}","received_events_url":"https://api.github.com/users/nixomose/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-08T10:25:45Z","updated_at":"2018-11-11T12:56:56Z","closed_at":"2018-11-11T12:56:56Z","author_association":"CONTRIBUTOR","body":"this is in my list of things to do that I'm realistically never going to get to, so I wanted to at least write it down here so it doesn't get lost.\r\n\r\nthe strncpys are not safe if the source string is longer than the max length it doesn't add a \\0 string terminator and everything go boom.\r\n\r\nll_pathname[pathname1_len + need_leading_slash + pathname2_len] = '\\0';\r\n 1389 \r\n 1390         strncpy(full_pathname, pathname1, pathname1_len);\r\n 1391         if(need_leading_slash) full_pathname[pathname1_len] = '/';\r\n 1392 //      xxxz\r\n 1393         strncpy(full_pathname + pathname1_len + need_leading_slash, pathname2, pathname2_len);\r\n 1394 \r\n 1395         *path_out = full_pathn"},"comment":{"url":"https://api.github.com/repos/datto/dattobd/issues/comments/437668060","html_url":"https://github.com/datto/dattobd/issues/162#issuecomment-437668060","issue_url":"https://api.github.com/repos/datto/dattobd/issues/162","id":437668060,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzY2ODA2MA==","user":{"login":"nixomose","id":13739626,"node_id":"MDQ6VXNlcjEzNzM5NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/13739626?v=4","gravatar_id":"","url":"https://api.github.com/users/nixomose","html_url":"https://github.com/nixomose","followers_url":"https://api.github.com/users/nixomose/followers","following_url":"https://api.github.com/users/nixomose/following{/other_user}","gists_url":"https://api.github.com/users/nixomose/gists{/gist_id}","starred_url":"https://api.github.com/users/nixomose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixomose/subscriptions","organizations_url":"https://api.github.com/users/nixomose/orgs","repos_url":"https://api.github.com/users/nixomose/repos","events_url":"https://api.github.com/users/nixomose/events{/privacy}","received_events_url":"https://api.github.com/users/nixomose/received_events","type":"User","site_admin":false},"created_at":"2018-11-11T12:56:56Z","updated_at":"2018-11-11T12:56:56Z","author_association":"CONTRIBUTOR","body":"cool, then it's all taken care of, thanks.\r\n"}}
{"actor":{"display_login":"nixomose"}}