{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/tambo/issues/18","repository_url":"https://api.github.com/repos/phetsims/tambo","labels_url":"https://api.github.com/repos/phetsims/tambo/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/tambo/issues/18/comments","events_url":"https://api.github.com/repos/phetsims/tambo/issues/18/events","html_url":"https://github.com/phetsims/tambo/issues/18","id":337678174,"node_id":"MDU6SXNzdWUzMzc2NzgxNzQ=","number":18,"title":"Should the sonification support be added to all sims, or just the sims where it is being used?","user":{"login":"jbphet","id":3082831,"node_id":"MDQ6VXNlcjMwODI4MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3082831?v=4","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jbphet","id":3082831,"node_id":"MDQ6VXNlcjMwODI4MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3082831?v=4","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbphet","id":3082831,"node_id":"MDQ6VXNlcjMwODI4MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3082831?v=4","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-07-02T21:58:42Z","updated_at":"2018-07-17T16:58:53Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The title states the essential question.  The tradeoffs are:\r\n\r\n+ Adding it to all sims will increase the size by some amount and possibly the load time, since the sound manager will be creating an audio context, some gain stages, and convolver, etc.  This could be moved into the initialize call if desired.\r\n+ Adding it only to simulations that use it will cause Sim.js to be a bit more complicated, and the main file for the sim (e.g. build-an-atom-main.js) will have additional code as well to pass in the sonification manager.\r\n\r\nI'll gather some data, then put this on the agenda for the next framework design meeting.  For now, I'm going with the \"add it only when it is being used\" approach to minimize impact on existing sims."},"comment":{"url":"https://api.github.com/repos/phetsims/tambo/issues/comments/405653566","html_url":"https://github.com/phetsims/tambo/issues/18#issuecomment-405653566","issue_url":"https://api.github.com/repos/phetsims/tambo/issues/18","id":405653566,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTY1MzU2Ng==","user":{"login":"samreid","id":679486,"node_id":"MDQ6VXNlcjY3OTQ4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/679486?v=4","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T16:58:53Z","updated_at":"2018-07-17T16:58:53Z","author_association":"MEMBER","body":"> I find it difficult to believe that the small number of icons that we're using are responsible for 4MB\r\n\r\nIndeed FontAwesome.js includes 21 icons and is only 14KB."}}
{"actor":{"display_login":"samreid"}}