{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/comments/231398944","pull_request_review_id":172360200,"id":231398944,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTM5ODk0NA==","diff_hunk":"@@ -46,19 +58,20 @@ instance FromJSON Config where\n --                                                                                          ,(\"maxNumberOfProblems\",Number 100.0)]))])}}\n \n instance ToJSON Config where\n-  toJSON (Config h m l c) = object [ \"languageServerHaskell\" .= r ]\n+  toJSON (Config h m l c f) = object [ \"languageServerHaskell\" .= r ]\n     where\n       r = object [ \"hlintOn\"              .= h\n                  , \"maxNumberOfProblems\"  .= m\n                  , \"liquidOn\"             .= l\n                  , \"completionSnippetsOn\" .= c\n+                 , \"formatOnImportOn\"     .= f\n                  ]\n \n -- ---------------------------------------------------------------------\n \n -- | For the diagnostic providers in the config, return a map of\n -- current enabled state, indexed by the plugin id.\n-getDiagnosticProvidersConfig :: Config -> Map.Map PluginId Bool\n+getDiagnosticProvidersConfig :: Config -> Map.Map T.Text Bool","path":"hie-plugin-api/Haskell/Ide/Engine/Config.hs","position":65,"original_position":65,"commit_id":"00827595b8f0a6c4bbc41eabe3a792d4b6ad825e","original_commit_id":"b5c11fd9d2ddd365f240dfb90f5709fcd184f191","user":{"login":"alanz","id":409607,"node_id":"MDQ6VXNlcjQwOTYwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/409607?v=4","gravatar_id":"","url":"https://api.github.com/users/alanz","html_url":"https://github.com/alanz","followers_url":"https://api.github.com/users/alanz/followers","following_url":"https://api.github.com/users/alanz/following{/other_user}","gists_url":"https://api.github.com/users/alanz/gists{/gist_id}","starred_url":"https://api.github.com/users/alanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanz/subscriptions","organizations_url":"https://api.github.com/users/alanz/orgs","repos_url":"https://api.github.com/users/alanz/repos","events_url":"https://api.github.com/users/alanz/events{/privacy}","received_events_url":"https://api.github.com/users/alanz/received_events","type":"User","site_admin":false},"body":"Should we not keep it as a PluginId, just define it in a different place? I am not all that happy with it sudennly being `Text`, we are losing coherence.","created_at":"2018-11-07T07:09:17Z","updated_at":"2018-11-07T07:09:17Z","html_url":"https://github.com/haskell/haskell-ide-engine/pull/783#discussion_r231398944","pull_request_url":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/783","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/comments/231398944"},"html":{"href":"https://github.com/haskell/haskell-ide-engine/pull/783#discussion_r231398944"},"pull_request":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/783"}},"in_reply_to_id":231100163},"pull_request":{"url":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/783","id":210879212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODc5MjEy","html_url":"https://github.com/haskell/haskell-ide-engine/pull/783","diff_url":"https://github.com/haskell/haskell-ide-engine/pull/783.diff","patch_url":"https://github.com/haskell/haskell-ide-engine/pull/783.patch","issue_url":"https://api.github.com/repos/haskell/haskell-ide-engine/issues/783","number":783,"state":"open","locked":false,"title":"Use Brittany with hsimport when needed","user":{"login":"bubba","id":2488460,"node_id":"MDQ6VXNlcjI0ODg0NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2488460?v=4","gravatar_id":"","url":"https://api.github.com/users/bubba","html_url":"https://github.com/bubba","followers_url":"https://api.github.com/users/bubba/followers","following_url":"https://api.github.com/users/bubba/following{/other_user}","gists_url":"https://api.github.com/users/bubba/gists{/gist_id}","starred_url":"https://api.github.com/users/bubba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bubba/subscriptions","organizations_url":"https://api.github.com/users/bubba/orgs","repos_url":"https://api.github.com/users/bubba/repos","events_url":"https://api.github.com/users/bubba/events{/privacy}","received_events_url":"https://api.github.com/users/bubba/received_events","type":"User","site_admin":false},"body":"This does a spartan check to see if the imports are formatted the way Brittany formats it, and if so then applies a coat of Brittany to the import code action.\r\nCloses #772 \r\n\r\n# Todo\r\n- [x] Add LSP config option to disable this","created_at":"2018-08-25T01:42:20Z","updated_at":"2018-11-07T07:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6761242a82baf268af52d569a9d31bb659e04a0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alanz","id":409607,"node_id":"MDQ6VXNlcjQwOTYwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/409607?v=4","gravatar_id":"","url":"https://api.github.com/users/alanz","html_url":"https://github.com/alanz","followers_url":"https://api.github.com/users/alanz/followers","following_url":"https://api.github.com/users/alanz/following{/other_user}","gists_url":"https://api.github.com/users/alanz/gists{/gist_id}","starred_url":"https://api.github.com/users/alanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanz/subscriptions","organizations_url":"https://api.github.com/users/alanz/orgs","repos_url":"https://api.github.com/users/alanz/repos","events_url":"https://api.github.com/users/alanz/events{/privacy}","received_events_url":"https://api.github.com/users/alanz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":283072205,"node_id":"MDU6TGFiZWwyODMwNzIyMDU=","url":"https://api.github.com/repos/haskell/haskell-ide-engine/labels/type:%20enhancement","name":"type: enhancement","color":"fad8c7","default":false},{"id":1002396098,"node_id":"MDU6TGFiZWwxMDAyMzk2MDk4","url":"https://api.github.com/repos/haskell/haskell-ide-engine/labels/type:%20refactor","name":"type: refactor","color":"4b5cbc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/783/commits","review_comments_url":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/783/comments","review_comment_url":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/haskell-ide-engine/issues/783/comments","statuses_url":"https://api.github.com/repos/haskell/haskell-ide-engine/statuses/00827595b8f0a6c4bbc41eabe3a792d4b6ad825e","head":{"label":"bubba:brittany-hsimport","ref":"brittany-hsimport","sha":"00827595b8f0a6c4bbc41eabe3a792d4b6ad825e","user":{"login":"bubba","id":2488460,"node_id":"MDQ6VXNlcjI0ODg0NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2488460?v=4","gravatar_id":"","url":"https://api.github.com/users/bubba","html_url":"https://github.com/bubba","followers_url":"https://api.github.com/users/bubba/followers","following_url":"https://api.github.com/users/bubba/following{/other_user}","gists_url":"https://api.github.com/users/bubba/gists{/gist_id}","starred_url":"https://api.github.com/users/bubba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bubba/subscriptions","organizations_url":"https://api.github.com/users/bubba/orgs","repos_url":"https://api.github.com/users/bubba/repos","events_url":"https://api.github.com/users/bubba/events{/privacy}","received_events_url":"https://api.github.com/users/bubba/received_events","type":"User","site_admin":false},"repo":{"id":129435383,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MzUzODM=","name":"haskell-ide-engine","full_name":"bubba/haskell-ide-engine","private":false,"owner":{"login":"bubba","id":2488460,"node_id":"MDQ6VXNlcjI0ODg0NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2488460?v=4","gravatar_id":"","url":"https://api.github.com/users/bubba","html_url":"https://github.com/bubba","followers_url":"https://api.github.com/users/bubba/followers","following_url":"https://api.github.com/users/bubba/following{/other_user}","gists_url":"https://api.github.com/users/bubba/gists{/gist_id}","starred_url":"https://api.github.com/users/bubba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bubba/subscriptions","organizations_url":"https://api.github.com/users/bubba/orgs","repos_url":"https://api.github.com/users/bubba/repos","events_url":"https://api.github.com/users/bubba/events{/privacy}","received_events_url":"https://api.github.com/users/bubba/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bubba/haskell-ide-engine","description":"The engine for haskell ide-integration. Not an IDE","fork":true,"url":"https://api.github.com/repos/bubba/haskell-ide-engine","forks_url":"https://api.github.com/repos/bubba/haskell-ide-engine/forks","keys_url":"https://api.github.com/repos/bubba/haskell-ide-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bubba/haskell-ide-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bubba/haskell-ide-engine/teams","hooks_url":"https://api.github.com/repos/bubba/haskell-ide-engine/hooks","issue_events_url":"https://api.github.com/repos/bubba/haskell-ide-engine/issues/events{/number}","events_url":"https://api.github.com/repos/bubba/haskell-ide-engine/events","assignees_url":"https://api.github.com/repos/bubba/haskell-ide-engine/assignees{/user}","branches_url":"https://api.github.com/repos/bubba/haskell-ide-engine/branches{/branch}","tags_url":"https://api.github.com/repos/bubba/haskell-ide-engine/tags","blobs_url":"https://api.github.com/repos/bubba/haskell-ide-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bubba/haskell-ide-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bubba/haskell-ide-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/bubba/haskell-ide-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bubba/haskell-ide-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/bubba/haskell-ide-engine/languages","stargazers_url":"https://api.github.com/repos/bubba/haskell-ide-engine/stargazers","contributors_url":"https://api.github.com/repos/bubba/haskell-ide-engine/contributors","subscribers_url":"https://api.github.com/repos/bubba/haskell-ide-engine/subscribers","subscription_url":"https://api.github.com/repos/bubba/haskell-ide-engine/subscription","commits_url":"https://api.github.com/repos/bubba/haskell-ide-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/bubba/haskell-ide-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/bubba/haskell-ide-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/bubba/haskell-ide-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/bubba/haskell-ide-engine/contents/{+path}","compare_url":"https://api.github.com/repos/bubba/haskell-ide-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bubba/haskell-ide-engine/merges","archive_url":"https://api.github.com/repos/bubba/haskell-ide-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bubba/haskell-ide-engine/downloads","issues_url":"https://api.github.com/repos/bubba/haskell-ide-engine/issues{/number}","pulls_url":"https://api.github.com/repos/bubba/haskell-ide-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/bubba/haskell-ide-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/bubba/haskell-ide-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bubba/haskell-ide-engine/labels{/name}","releases_url":"https://api.github.com/repos/bubba/haskell-ide-engine/releases{/id}","deployments_url":"https://api.github.com/repos/bubba/haskell-ide-engine/deployments","created_at":"2018-04-13T17:43:54Z","updated_at":"2018-09-27T10:04:15Z","pushed_at":"2018-11-06T16:43:08Z","git_url":"git://github.com/bubba/haskell-ide-engine.git","ssh_url":"git@github.com:bubba/haskell-ide-engine.git","clone_url":"https://github.com/bubba/haskell-ide-engine.git","svn_url":"https://github.com/bubba/haskell-ide-engine","homepage":"","size":4558,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"a6fd3449580b48a953770f4617b81fb5f086848f","user":{"login":"haskell","id":450574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MDU3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/450574?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":44727837,"node_id":"MDEwOlJlcG9zaXRvcnk0NDcyNzgzNw==","name":"haskell-ide-engine","full_name":"haskell/haskell-ide-engine","private":false,"owner":{"login":"haskell","id":450574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MDU3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/450574?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/haskell/haskell-ide-engine","description":"The engine for haskell ide-integration. Not an IDE","fork":false,"url":"https://api.github.com/repos/haskell/haskell-ide-engine","forks_url":"https://api.github.com/repos/haskell/haskell-ide-engine/forks","keys_url":"https://api.github.com/repos/haskell/haskell-ide-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/haskell-ide-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/haskell-ide-engine/teams","hooks_url":"https://api.github.com/repos/haskell/haskell-ide-engine/hooks","issue_events_url":"https://api.github.com/repos/haskell/haskell-ide-engine/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/haskell-ide-engine/events","assignees_url":"https://api.github.com/repos/haskell/haskell-ide-engine/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/haskell-ide-engine/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/haskell-ide-engine/tags","blobs_url":"https://api.github.com/repos/haskell/haskell-ide-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/haskell-ide-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/haskell-ide-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/haskell-ide-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/haskell-ide-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/haskell-ide-engine/languages","stargazers_url":"https://api.github.com/repos/haskell/haskell-ide-engine/stargazers","contributors_url":"https://api.github.com/repos/haskell/haskell-ide-engine/contributors","subscribers_url":"https://api.github.com/repos/haskell/haskell-ide-engine/subscribers","subscription_url":"https://api.github.com/repos/haskell/haskell-ide-engine/subscription","commits_url":"https://api.github.com/repos/haskell/haskell-ide-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/haskell-ide-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/haskell-ide-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/haskell-ide-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/haskell-ide-engine/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/haskell-ide-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/haskell-ide-engine/merges","archive_url":"https://api.github.com/repos/haskell/haskell-ide-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/haskell-ide-engine/downloads","issues_url":"https://api.github.com/repos/haskell/haskell-ide-engine/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/haskell-ide-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/haskell-ide-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/haskell-ide-engine/labels{/name}","releases_url":"https://api.github.com/repos/haskell/haskell-ide-engine/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/haskell-ide-engine/deployments","created_at":"2015-10-22T06:59:33Z","updated_at":"2018-11-07T07:04:28Z","pushed_at":"2018-11-07T07:04:25Z","git_url":"git://github.com/haskell/haskell-ide-engine.git","ssh_url":"git@github.com:haskell/haskell-ide-engine.git","clone_url":"https://github.com/haskell/haskell-ide-engine.git","svn_url":"https://github.com/haskell/haskell-ide-engine","homepage":"","size":4434,"stargazers_count":1271,"watchers_count":1271,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":132,"open_issues":185,"watchers":1271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/783"},"html":{"href":"https://github.com/haskell/haskell-ide-engine/pull/783"},"issue":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/issues/783"},"comments":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/issues/783/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/783/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/pulls/783/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/haskell-ide-engine/statuses/00827595b8f0a6c4bbc41eabe3a792d4b6ad825e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alanz"}}