{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20830","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20830/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20830/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20830/events","html_url":"https://github.com/nodejs/node/pull/20830","id":324580020,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MTU2NTI3","number":20830,"title":"lib,src: replace all C++ promises with JS promises","user":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"labels":[{"id":754449534,"node_id":"MDU6TGFiZWw3NTQ0NDk1MzQ=","url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":364533783,"node_id":"MDU6TGFiZWwzNjQ1MzM3ODM=","url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":575600232,"node_id":"MDU6TGFiZWw1NzU2MDAyMzI=","url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v8.x","name":"dont-land-on-v8.x","color":"1d76db","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":326905670,"node_id":"MDU6TGFiZWwzMjY5MDU2NzA=","url":"https://api.github.com/repos/nodejs/node/labels/performance","name":"performance","color":"5319e7","default":false},{"id":169485478,"node_id":"MDU6TGFiZWwxNjk0ODU0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":41,"created_at":"2018-05-18T23:36:27Z","updated_at":"2018-06-25T11:45:23Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20830","html_url":"https://github.com/nodejs/node/pull/20830","diff_url":"https://github.com/nodejs/node/pull/20830.diff","patch_url":"https://github.com/nodejs/node/pull/20830.patch"},"body":"C++ promises can not be properly optimized by V8. They also behave\r\na tiny bit different than \"regular\" promises (they can not be monkey patched).\r\n\r\nThis was requested by @nodejs/v8.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/399923504","html_url":"https://github.com/nodejs/node/pull/20830#issuecomment-399923504","issue_url":"https://api.github.com/repos/nodejs/node/issues/20830","id":399923504,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTkyMzUwNA==","user":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T11:45:22Z","updated_at":"2018-06-25T11:45:22Z","author_association":"MEMBER","body":"@ChALkeR I changed it to being semver-minor."}}
{"actor":{"display_login":"BridgeAR"}}