{"action":"created","issue":{"url":"https://api.github.com/repos/ASIDataScience/dash-bootstrap-components/issues/58","repository_url":"https://api.github.com/repos/ASIDataScience/dash-bootstrap-components","labels_url":"https://api.github.com/repos/ASIDataScience/dash-bootstrap-components/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/ASIDataScience/dash-bootstrap-components/issues/58/comments","events_url":"https://api.github.com/repos/ASIDataScience/dash-bootstrap-components/issues/58/events","html_url":"https://github.com/ASIDataScience/dash-bootstrap-components/pull/58","id":380198051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDUzODU0","number":58,"title":"Document Tabs","user":{"login":"tcbegley","id":15220906,"node_id":"MDQ6VXNlcjE1MjIwOTA2","avatar_url":"https://avatars1.githubusercontent.com/u/15220906?v=4","gravatar_id":"","url":"https://api.github.com/users/tcbegley","html_url":"https://github.com/tcbegley","followers_url":"https://api.github.com/users/tcbegley/followers","following_url":"https://api.github.com/users/tcbegley/following{/other_user}","gists_url":"https://api.github.com/users/tcbegley/gists{/gist_id}","starred_url":"https://api.github.com/users/tcbegley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcbegley/subscriptions","organizations_url":"https://api.github.com/users/tcbegley/orgs","repos_url":"https://api.github.com/users/tcbegley/repos","events_url":"https://api.github.com/users/tcbegley/events{/privacy}","received_events_url":"https://api.github.com/users/tcbegley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-13T12:16:02Z","updated_at":"2018-11-21T07:42:44Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ASIDataScience/dash-bootstrap-components/pulls/58","html_url":"https://github.com/ASIDataScience/dash-bootstrap-components/pull/58","diff_url":"https://github.com/ASIDataScience/dash-bootstrap-components/pull/58.diff","patch_url":"https://github.com/ASIDataScience/dash-bootstrap-components/pull/58.patch"},"body":"This PR adds documentation for tabs.\r\n\r\n@pbugnion I would be particularly interested if you could take a look at the modifications in `helpers.py`, I had to pass some module imports into `exec` in order to get the callbacks to work, previously it was complaining about `dbc` not being recognised etc. What I've got works, but there may be better ways to do it."},"comment":{"url":"https://api.github.com/repos/ASIDataScience/dash-bootstrap-components/issues/comments/440567251","html_url":"https://github.com/ASIDataScience/dash-bootstrap-components/pull/58#issuecomment-440567251","issue_url":"https://api.github.com/repos/ASIDataScience/dash-bootstrap-components/issues/58","id":440567251,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDU2NzI1MQ==","user":{"login":"pbugnion","id":1392879,"node_id":"MDQ6VXNlcjEzOTI4Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1392879?v=4","gravatar_id":"","url":"https://api.github.com/users/pbugnion","html_url":"https://github.com/pbugnion","followers_url":"https://api.github.com/users/pbugnion/followers","following_url":"https://api.github.com/users/pbugnion/following{/other_user}","gists_url":"https://api.github.com/users/pbugnion/gists{/gist_id}","starred_url":"https://api.github.com/users/pbugnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbugnion/subscriptions","organizations_url":"https://api.github.com/users/pbugnion/orgs","repos_url":"https://api.github.com/users/pbugnion/repos","events_url":"https://api.github.com/users/pbugnion/events{/privacy}","received_events_url":"https://api.github.com/users/pbugnion/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T07:42:44Z","updated_at":"2018-11-21T07:42:44Z","author_association":"MEMBER","body":"I was originally thinking of passing the variables as locals to exec, not globals, hence the name. According to the docstring on exec, though:\r\n\r\n> The globals must be a dictionary and locals can be any mapping,\r\ndefaulting to the current globals and locals.\r\n> If only globals is given, locals defaults to it.\r\n\r\nThus, we can't pass just locals. I think we should just rename the function to `load_source_with_globals`, or `load_source_with_environment`?"}}
{"actor":{"display_login":"pbugnion"}}