{"action":"created","issue":{"url":"https://api.github.com/repos/mchorse/metamorph/issues/81","repository_url":"https://api.github.com/repos/mchorse/metamorph","labels_url":"https://api.github.com/repos/mchorse/metamorph/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/mchorse/metamorph/issues/81/comments","events_url":"https://api.github.com/repos/mchorse/metamorph/issues/81/events","html_url":"https://github.com/mchorse/metamorph/pull/81","id":270197390,"number":81,"title":"More entity morph sounds and squid breath bar","user":{"login":"asanetargoss","id":12486152,"avatar_url":"https://avatars0.githubusercontent.com/u/12486152?v=4","gravatar_id":"","url":"https://api.github.com/users/asanetargoss","html_url":"https://github.com/asanetargoss","followers_url":"https://api.github.com/users/asanetargoss/followers","following_url":"https://api.github.com/users/asanetargoss/following{/other_user}","gists_url":"https://api.github.com/users/asanetargoss/gists{/gist_id}","starred_url":"https://api.github.com/users/asanetargoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asanetargoss/subscriptions","organizations_url":"https://api.github.com/users/asanetargoss/orgs","repos_url":"https://api.github.com/users/asanetargoss/repos","events_url":"https://api.github.com/users/asanetargoss/events{/privacy}","received_events_url":"https://api.github.com/users/asanetargoss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-11-01T05:24:00Z","updated_at":"2018-04-20T06:02:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mchorse/metamorph/pulls/81","html_url":"https://github.com/mchorse/metamorph/pull/81","diff_url":"https://github.com/mchorse/metamorph/pull/81.diff","patch_url":"https://github.com/mchorse/metamorph/pull/81.patch"},"body":"Entity morphs now make step/hurt sounds like the actual entities. Death sounds should play in principle, but from my investigation, it seems they don't due to a vanilla bug involving player sounds.\r\n\r\nPlayers in morphs with the Swim ability no longer immediately take damage while in air. Instead, they display a breath bar which depletes while in air. When the bar drops to zero, the player takes drowning damage.\r\n\r\nA coremod is added. Currently, this is used for displaying the \"squid air\" bar. In 1.12, a coremod patch would also be needed for hurt sounds. ~~I have created the git tag \"1.12_hurt_sound_fix\" which should in theory implement the fix. Bug me if it doesn't.~~\r\n\r\n~~Edit: I forgot Metamorph has a 1.12 branch; those changes don't belong in a tag. I'll test 1.12 when I get the chance.~~\r\n\r\nEdit 2: Oh yea, this PR also fixes a bug with aquatic entity morphs making drowning sounds."},"comment":{"url":"https://api.github.com/repos/mchorse/metamorph/issues/comments/382988018","html_url":"https://github.com/mchorse/metamorph/pull/81#issuecomment-382988018","issue_url":"https://api.github.com/repos/mchorse/metamorph/issues/81","id":382988018,"user":{"login":"asanetargoss","id":12486152,"avatar_url":"https://avatars0.githubusercontent.com/u/12486152?v=4","gravatar_id":"","url":"https://api.github.com/users/asanetargoss","html_url":"https://github.com/asanetargoss","followers_url":"https://api.github.com/users/asanetargoss/followers","following_url":"https://api.github.com/users/asanetargoss/following{/other_user}","gists_url":"https://api.github.com/users/asanetargoss/gists{/gist_id}","starred_url":"https://api.github.com/users/asanetargoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asanetargoss/subscriptions","organizations_url":"https://api.github.com/users/asanetargoss/orgs","repos_url":"https://api.github.com/users/asanetargoss/repos","events_url":"https://api.github.com/users/asanetargoss/events{/privacy}","received_events_url":"https://api.github.com/users/asanetargoss/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T06:02:42Z","updated_at":"2018-04-20T06:02:42Z","author_association":"CONTRIBUTOR","body":"Much better. I guess all that remains is making sure the morph world-syncing code is in the right place."}}
{"actor":{"display_login":"asanetargoss"}}