{"action":"created","issue":{"url":"https://api.github.com/repos/abergs/fido2-net-lib/issues/35","repository_url":"https://api.github.com/repos/abergs/fido2-net-lib","labels_url":"https://api.github.com/repos/abergs/fido2-net-lib/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/abergs/fido2-net-lib/issues/35/comments","events_url":"https://api.github.com/repos/abergs/fido2-net-lib/issues/35/events","html_url":"https://github.com/abergs/fido2-net-lib/pull/35","id":355829367,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjY3Mjcx","number":35,"title":"Fixed userVerification logic to pass conformance tests","user":{"login":"aseigler","id":6605560,"node_id":"MDQ6VXNlcjY2MDU1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6605560?v=4","gravatar_id":"","url":"https://api.github.com/users/aseigler","html_url":"https://github.com/aseigler","followers_url":"https://api.github.com/users/aseigler/followers","following_url":"https://api.github.com/users/aseigler/following{/other_user}","gists_url":"https://api.github.com/users/aseigler/gists{/gist_id}","starred_url":"https://api.github.com/users/aseigler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseigler/subscriptions","organizations_url":"https://api.github.com/users/aseigler/orgs","repos_url":"https://api.github.com/users/aseigler/repos","events_url":"https://api.github.com/users/aseigler/events{/privacy}","received_events_url":"https://api.github.com/users/aseigler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-31T03:45:55Z","updated_at":"2018-09-03T22:00:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/abergs/fido2-net-lib/pulls/35","html_url":"https://github.com/abergs/fido2-net-lib/pull/35","diff_url":"https://github.com/abergs/fido2-net-lib/pull/35.diff","patch_url":"https://github.com/abergs/fido2-net-lib/pull/35.patch"},"body":"@abergs, please check AssertionOptionsTest in particular and the other related to ensure what I have done is acceptable.  It seems that the conformance test is pushing authenticatorSelection -> userVerification and we were not set up to do anything with that, which was causing lost data resulting in some confusion.\r\n\r\nThere is some inconsistency and in some cases direct conflict between the conformance tests and the published specification, I am hoping that this will be resolved at some point soon."},"comment":{"url":"https://api.github.com/repos/abergs/fido2-net-lib/issues/comments/418198088","html_url":"https://github.com/abergs/fido2-net-lib/pull/35#issuecomment-418198088","issue_url":"https://api.github.com/repos/abergs/fido2-net-lib/issues/35","id":418198088,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODE5ODA4OA==","user":{"login":"abergs","id":357283,"node_id":"MDQ6VXNlcjM1NzI4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/357283?v=4","gravatar_id":"","url":"https://api.github.com/users/abergs","html_url":"https://github.com/abergs","followers_url":"https://api.github.com/users/abergs/followers","following_url":"https://api.github.com/users/abergs/following{/other_user}","gists_url":"https://api.github.com/users/abergs/gists{/gist_id}","starred_url":"https://api.github.com/users/abergs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abergs/subscriptions","organizations_url":"https://api.github.com/users/abergs/orgs","repos_url":"https://api.github.com/users/abergs/repos","events_url":"https://api.github.com/users/abergs/events{/privacy}","received_events_url":"https://api.github.com/users/abergs/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T22:00:57Z","updated_at":"2018-09-03T22:00:57Z","author_association":"OWNER","body":"Yeah it seems all good now (weirdly enough?). I agree with the tests being a bit off spec. Might try to get Ackermans opinion on them. Also we push the settings (from authenticatorSelection) in our controller which will not transfer to any consuming clients. Not feeling 100% sure what's the right thing to do, but will take a look tomorrow when I'm not on my phone.."}}
{"actor":{"display_login":"abergs"}}