{"action":"created","comment":{"url":"https://api.github.com/repos/Selleo/merit-money-api/pulls/comments/195901465","pull_request_review_id":129361696,"id":195901465,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTkwMTQ2NQ==","diff_hunk":"@@ -3,53 +3,56 @@\n describe Api::V1::UsersController do\n   describe 'GET /api/users' do\n     it 'returns all users' do\n-      10.times do\n-        create(:user)\n+      3.times do |i|\n+        create(:user, name: \"name_#{i}\", email: \"email_#{i}@example.com\")\n       end\n-      create(:user, name: 'Janusz', email: 'fake.mail@example.com')\n \n       get '/api/v1/users'\n \n       expect(response.status).to eq(200)\n-      expect(JSON.parse(response.body).count).to eq 11\n-      expect(JSON.parse(response.body).last['name']).to eq 'Janusz'\n-      expect(JSON.parse(response.body).last['email']).to eq 'fake.mail@example.com'\n+      expect(JSON.parse(response.body).count).to eq 3","path":"spec/api/v1/users_controller_spec.rb","position":null,"original_position":17,"commit_id":"58871efbaee138bb6b27805c7928ae7a3ddca93a","original_commit_id":"58871efbaee138bb6b27805c7928ae7a3ddca93a","user":{"login":"sznajdermariusz","id":30269442,"node_id":"MDQ6VXNlcjMwMjY5NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/30269442?v=4","gravatar_id":"","url":"https://api.github.com/users/sznajdermariusz","html_url":"https://github.com/sznajdermariusz","followers_url":"https://api.github.com/users/sznajdermariusz/followers","following_url":"https://api.github.com/users/sznajdermariusz/following{/other_user}","gists_url":"https://api.github.com/users/sznajdermariusz/gists{/gist_id}","starred_url":"https://api.github.com/users/sznajdermariusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sznajdermariusz/subscriptions","organizations_url":"https://api.github.com/users/sznajdermariusz/orgs","repos_url":"https://api.github.com/users/sznajdermariusz/repos","events_url":"https://api.github.com/users/sznajdermariusz/events{/privacy}","received_events_url":"https://api.github.com/users/sznajdermariusz/received_events","type":"User","site_admin":false},"body":"I do not see benefits. With module I have to use sth like:\r\n```JsonResponse.json_response(response)``` (which looks weird for me)\r\ninstead of\r\n```JSON.parse(response.body)```","created_at":"2018-06-16T11:56:55Z","updated_at":"2018-06-16T11:56:55Z","html_url":"https://github.com/Selleo/merit-money-api/pull/20#discussion_r195901465","pull_request_url":"https://api.github.com/repos/Selleo/merit-money-api/pulls/20","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Selleo/merit-money-api/pulls/comments/195901465"},"html":{"href":"https://github.com/Selleo/merit-money-api/pull/20#discussion_r195901465"},"pull_request":{"href":"https://api.github.com/repos/Selleo/merit-money-api/pulls/20"}},"in_reply_to_id":195642067},"pull_request":{"url":"https://api.github.com/repos/Selleo/merit-money-api/pulls/20","id":193790779,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzkwNzc5","html_url":"https://github.com/Selleo/merit-money-api/pull/20","diff_url":"https://github.com/Selleo/merit-money-api/pull/20.diff","patch_url":"https://github.com/Selleo/merit-money-api/pull/20.patch","issue_url":"https://api.github.com/repos/Selleo/merit-money-api/issues/20","number":20,"state":"open","locked":false,"title":"Create-user-model","user":{"login":"sznajdermariusz","id":30269442,"node_id":"MDQ6VXNlcjMwMjY5NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/30269442?v=4","gravatar_id":"","url":"https://api.github.com/users/sznajdermariusz","html_url":"https://github.com/sznajdermariusz","followers_url":"https://api.github.com/users/sznajdermariusz/followers","following_url":"https://api.github.com/users/sznajdermariusz/following{/other_user}","gists_url":"https://api.github.com/users/sznajdermariusz/gists{/gist_id}","starred_url":"https://api.github.com/users/sznajdermariusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sznajdermariusz/subscriptions","organizations_url":"https://api.github.com/users/sznajdermariusz/orgs","repos_url":"https://api.github.com/users/sznajdermariusz/repos","events_url":"https://api.github.com/users/sznajdermariusz/events{/privacy}","received_events_url":"https://api.github.com/users/sznajdermariusz/received_events","type":"User","site_admin":false},"body":"-setup stuff\r\n-create User model\r\n-set API for User\r\n-error handling","created_at":"2018-06-09T18:35:37Z","updated_at":"2018-06-16T11:56:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f9a62bf315eb1d8ecca337aabd49c7e3df4c3ab","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kantorm","id":17920007,"node_id":"MDQ6VXNlcjE3OTIwMDA3","avatar_url":"https://avatars0.githubusercontent.com/u/17920007?v=4","gravatar_id":"","url":"https://api.github.com/users/kantorm","html_url":"https://github.com/kantorm","followers_url":"https://api.github.com/users/kantorm/followers","following_url":"https://api.github.com/users/kantorm/following{/other_user}","gists_url":"https://api.github.com/users/kantorm/gists{/gist_id}","starred_url":"https://api.github.com/users/kantorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kantorm/subscriptions","organizations_url":"https://api.github.com/users/kantorm/orgs","repos_url":"https://api.github.com/users/kantorm/repos","events_url":"https://api.github.com/users/kantorm/events{/privacy}","received_events_url":"https://api.github.com/users/kantorm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Selleo/merit-money-api/pulls/20/commits","review_comments_url":"https://api.github.com/repos/Selleo/merit-money-api/pulls/20/comments","review_comment_url":"https://api.github.com/repos/Selleo/merit-money-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Selleo/merit-money-api/issues/20/comments","statuses_url":"https://api.github.com/repos/Selleo/merit-money-api/statuses/58871efbaee138bb6b27805c7928ae7a3ddca93a","head":{"label":"Selleo:create-models","ref":"create-models","sha":"58871efbaee138bb6b27805c7928ae7a3ddca93a","user":{"login":"Selleo","id":430976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMDk3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/430976?v=4","gravatar_id":"","url":"https://api.github.com/users/Selleo","html_url":"https://github.com/Selleo","followers_url":"https://api.github.com/users/Selleo/followers","following_url":"https://api.github.com/users/Selleo/following{/other_user}","gists_url":"https://api.github.com/users/Selleo/gists{/gist_id}","starred_url":"https://api.github.com/users/Selleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Selleo/subscriptions","organizations_url":"https://api.github.com/users/Selleo/orgs","repos_url":"https://api.github.com/users/Selleo/repos","events_url":"https://api.github.com/users/Selleo/events{/privacy}","received_events_url":"https://api.github.com/users/Selleo/received_events","type":"Organization","site_admin":false},"repo":{"id":111077346,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEwNzczNDY=","name":"merit-money-api","full_name":"Selleo/merit-money-api","owner":{"login":"Selleo","id":430976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMDk3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/430976?v=4","gravatar_id":"","url":"https://api.github.com/users/Selleo","html_url":"https://github.com/Selleo","followers_url":"https://api.github.com/users/Selleo/followers","following_url":"https://api.github.com/users/Selleo/following{/other_user}","gists_url":"https://api.github.com/users/Selleo/gists{/gist_id}","starred_url":"https://api.github.com/users/Selleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Selleo/subscriptions","organizations_url":"https://api.github.com/users/Selleo/orgs","repos_url":"https://api.github.com/users/Selleo/repos","events_url":"https://api.github.com/users/Selleo/events{/privacy}","received_events_url":"https://api.github.com/users/Selleo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Selleo/merit-money-api","description":"Express + Mongo + GraphQL = :fire:","fork":false,"url":"https://api.github.com/repos/Selleo/merit-money-api","forks_url":"https://api.github.com/repos/Selleo/merit-money-api/forks","keys_url":"https://api.github.com/repos/Selleo/merit-money-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Selleo/merit-money-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Selleo/merit-money-api/teams","hooks_url":"https://api.github.com/repos/Selleo/merit-money-api/hooks","issue_events_url":"https://api.github.com/repos/Selleo/merit-money-api/issues/events{/number}","events_url":"https://api.github.com/repos/Selleo/merit-money-api/events","assignees_url":"https://api.github.com/repos/Selleo/merit-money-api/assignees{/user}","branches_url":"https://api.github.com/repos/Selleo/merit-money-api/branches{/branch}","tags_url":"https://api.github.com/repos/Selleo/merit-money-api/tags","blobs_url":"https://api.github.com/repos/Selleo/merit-money-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Selleo/merit-money-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Selleo/merit-money-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Selleo/merit-money-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Selleo/merit-money-api/statuses/{sha}","languages_url":"https://api.github.com/repos/Selleo/merit-money-api/languages","stargazers_url":"https://api.github.com/repos/Selleo/merit-money-api/stargazers","contributors_url":"https://api.github.com/repos/Selleo/merit-money-api/contributors","subscribers_url":"https://api.github.com/repos/Selleo/merit-money-api/subscribers","subscription_url":"https://api.github.com/repos/Selleo/merit-money-api/subscription","commits_url":"https://api.github.com/repos/Selleo/merit-money-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Selleo/merit-money-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Selleo/merit-money-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Selleo/merit-money-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Selleo/merit-money-api/contents/{+path}","compare_url":"https://api.github.com/repos/Selleo/merit-money-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Selleo/merit-money-api/merges","archive_url":"https://api.github.com/repos/Selleo/merit-money-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Selleo/merit-money-api/downloads","issues_url":"https://api.github.com/repos/Selleo/merit-money-api/issues{/number}","pulls_url":"https://api.github.com/repos/Selleo/merit-money-api/pulls{/number}","milestones_url":"https://api.github.com/repos/Selleo/merit-money-api/milestones{/number}","notifications_url":"https://api.github.com/repos/Selleo/merit-money-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Selleo/merit-money-api/labels{/name}","releases_url":"https://api.github.com/repos/Selleo/merit-money-api/releases{/id}","deployments_url":"https://api.github.com/repos/Selleo/merit-money-api/deployments","created_at":"2017-11-17T08:21:48Z","updated_at":"2018-06-09T20:57:54Z","pushed_at":"2018-06-15T05:16:02Z","git_url":"git://github.com/Selleo/merit-money-api.git","ssh_url":"git@github.com:Selleo/merit-money-api.git","clone_url":"https://github.com/Selleo/merit-money-api.git","svn_url":"https://github.com/Selleo/merit-money-api","homepage":null,"size":111,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"Selleo:rails","ref":"rails","sha":"c55bec37eaf8bf0cc958875730d952b4aa6c6c83","user":{"login":"Selleo","id":430976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMDk3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/430976?v=4","gravatar_id":"","url":"https://api.github.com/users/Selleo","html_url":"https://github.com/Selleo","followers_url":"https://api.github.com/users/Selleo/followers","following_url":"https://api.github.com/users/Selleo/following{/other_user}","gists_url":"https://api.github.com/users/Selleo/gists{/gist_id}","starred_url":"https://api.github.com/users/Selleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Selleo/subscriptions","organizations_url":"https://api.github.com/users/Selleo/orgs","repos_url":"https://api.github.com/users/Selleo/repos","events_url":"https://api.github.com/users/Selleo/events{/privacy}","received_events_url":"https://api.github.com/users/Selleo/received_events","type":"Organization","site_admin":false},"repo":{"id":111077346,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEwNzczNDY=","name":"merit-money-api","full_name":"Selleo/merit-money-api","owner":{"login":"Selleo","id":430976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMDk3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/430976?v=4","gravatar_id":"","url":"https://api.github.com/users/Selleo","html_url":"https://github.com/Selleo","followers_url":"https://api.github.com/users/Selleo/followers","following_url":"https://api.github.com/users/Selleo/following{/other_user}","gists_url":"https://api.github.com/users/Selleo/gists{/gist_id}","starred_url":"https://api.github.com/users/Selleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Selleo/subscriptions","organizations_url":"https://api.github.com/users/Selleo/orgs","repos_url":"https://api.github.com/users/Selleo/repos","events_url":"https://api.github.com/users/Selleo/events{/privacy}","received_events_url":"https://api.github.com/users/Selleo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Selleo/merit-money-api","description":"Express + Mongo + GraphQL = :fire:","fork":false,"url":"https://api.github.com/repos/Selleo/merit-money-api","forks_url":"https://api.github.com/repos/Selleo/merit-money-api/forks","keys_url":"https://api.github.com/repos/Selleo/merit-money-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Selleo/merit-money-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Selleo/merit-money-api/teams","hooks_url":"https://api.github.com/repos/Selleo/merit-money-api/hooks","issue_events_url":"https://api.github.com/repos/Selleo/merit-money-api/issues/events{/number}","events_url":"https://api.github.com/repos/Selleo/merit-money-api/events","assignees_url":"https://api.github.com/repos/Selleo/merit-money-api/assignees{/user}","branches_url":"https://api.github.com/repos/Selleo/merit-money-api/branches{/branch}","tags_url":"https://api.github.com/repos/Selleo/merit-money-api/tags","blobs_url":"https://api.github.com/repos/Selleo/merit-money-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Selleo/merit-money-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Selleo/merit-money-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Selleo/merit-money-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Selleo/merit-money-api/statuses/{sha}","languages_url":"https://api.github.com/repos/Selleo/merit-money-api/languages","stargazers_url":"https://api.github.com/repos/Selleo/merit-money-api/stargazers","contributors_url":"https://api.github.com/repos/Selleo/merit-money-api/contributors","subscribers_url":"https://api.github.com/repos/Selleo/merit-money-api/subscribers","subscription_url":"https://api.github.com/repos/Selleo/merit-money-api/subscription","commits_url":"https://api.github.com/repos/Selleo/merit-money-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Selleo/merit-money-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Selleo/merit-money-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Selleo/merit-money-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Selleo/merit-money-api/contents/{+path}","compare_url":"https://api.github.com/repos/Selleo/merit-money-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Selleo/merit-money-api/merges","archive_url":"https://api.github.com/repos/Selleo/merit-money-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Selleo/merit-money-api/downloads","issues_url":"https://api.github.com/repos/Selleo/merit-money-api/issues{/number}","pulls_url":"https://api.github.com/repos/Selleo/merit-money-api/pulls{/number}","milestones_url":"https://api.github.com/repos/Selleo/merit-money-api/milestones{/number}","notifications_url":"https://api.github.com/repos/Selleo/merit-money-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Selleo/merit-money-api/labels{/name}","releases_url":"https://api.github.com/repos/Selleo/merit-money-api/releases{/id}","deployments_url":"https://api.github.com/repos/Selleo/merit-money-api/deployments","created_at":"2017-11-17T08:21:48Z","updated_at":"2018-06-09T20:57:54Z","pushed_at":"2018-06-15T05:16:02Z","git_url":"git://github.com/Selleo/merit-money-api.git","ssh_url":"git@github.com:Selleo/merit-money-api.git","clone_url":"https://github.com/Selleo/merit-money-api.git","svn_url":"https://github.com/Selleo/merit-money-api","homepage":null,"size":111,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Selleo/merit-money-api/pulls/20"},"html":{"href":"https://github.com/Selleo/merit-money-api/pull/20"},"issue":{"href":"https://api.github.com/repos/Selleo/merit-money-api/issues/20"},"comments":{"href":"https://api.github.com/repos/Selleo/merit-money-api/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/Selleo/merit-money-api/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/Selleo/merit-money-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Selleo/merit-money-api/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/Selleo/merit-money-api/statuses/58871efbaee138bb6b27805c7928ae7a3ddca93a"}},"author_association":"NONE"}}
{"actor":{"display_login":"sznajdermariusz"}}