{"action":"created","comment":{"url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments/188964841","pull_request_review_id":121045590,"id":188964841,"diff_hunk":"@@ -782,6 +784,41 @@ describe('VASTParser', function() {\n       });\n     });\n \n+    describe('#For the wrapper-1 ad', function() {\n+      this.response = null;\n+      this.templateFilterCalls = [];\n+\n+      before(done => {\n+        vastParser.addURLTemplateFilter(url => {\n+          this.templateFilterCalls.push(url);\n+          return url;\n+        });\n+        vastParser.getAndParse(\n+          urlfor('wrapper-sequence.xml'),\n+          (err, response) => {\n+            if (err) {\n+              console.log(err);","path":"test/vast_parser.js","position":26,"original_position":26,"commit_id":"fd08ac6fefafbac87e91628b48a0cc454af12f12","original_commit_id":"fd08ac6fefafbac87e91628b48a0cc454af12f12","user":{"login":"eliamaino-fp","id":25059869,"avatar_url":"https://avatars2.githubusercontent.com/u/25059869?v=4","gravatar_id":"","url":"https://api.github.com/users/eliamaino-fp","html_url":"https://github.com/eliamaino-fp","followers_url":"https://api.github.com/users/eliamaino-fp/followers","following_url":"https://api.github.com/users/eliamaino-fp/following{/other_user}","gists_url":"https://api.github.com/users/eliamaino-fp/gists{/gist_id}","starred_url":"https://api.github.com/users/eliamaino-fp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliamaino-fp/subscriptions","organizations_url":"https://api.github.com/users/eliamaino-fp/orgs","repos_url":"https://api.github.com/users/eliamaino-fp/repos","events_url":"https://api.github.com/users/eliamaino-fp/events{/privacy}","received_events_url":"https://api.github.com/users/eliamaino-fp/received_events","type":"User","site_admin":false},"body":"no need for this log","created_at":"2018-05-17T13:51:42Z","updated_at":"2018-05-17T13:53:06Z","html_url":"https://github.com/dailymotion/vast-client-js/pull/220#discussion_r188964841","pull_request_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/220","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments/188964841"},"html":{"href":"https://github.com/dailymotion/vast-client-js/pull/220#discussion_r188964841"},"pull_request":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/220","id":188725011,"html_url":"https://github.com/dailymotion/vast-client-js/pull/220","diff_url":"https://github.com/dailymotion/vast-client-js/pull/220.diff","patch_url":"https://github.com/dailymotion/vast-client-js/pull/220.patch","issue_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/220","number":220,"state":"open","locked":false,"title":"Back port work from #214 to 2.x branch","user":{"login":"rumesh","id":1483549,"avatar_url":"https://avatars2.githubusercontent.com/u/1483549?v=4","gravatar_id":"","url":"https://api.github.com/users/rumesh","html_url":"https://github.com/rumesh","followers_url":"https://api.github.com/users/rumesh/followers","following_url":"https://api.github.com/users/rumesh/following{/other_user}","gists_url":"https://api.github.com/users/rumesh/gists{/gist_id}","starred_url":"https://api.github.com/users/rumesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rumesh/subscriptions","organizations_url":"https://api.github.com/users/rumesh/orgs","repos_url":"https://api.github.com/users/rumesh/repos","events_url":"https://api.github.com/users/rumesh/events{/privacy}","received_events_url":"https://api.github.com/users/rumesh/received_events","type":"User","site_admin":false},"body":"Original commit from master https://github.com/dailymotion/vast-client-js/commit/6d3e2b547f262995b44a5e51c2e0b2c2fbf34e1c (thanks @walkerflocker )","created_at":"2018-05-17T12:46:23Z","updated_at":"2018-05-17T13:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f97cbeda79bfb09c528c5285484e0f1d4a0b64fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":872043328,"url":"https://api.github.com/repos/dailymotion/vast-client-js/labels/2.x","name":"2.x","color":"9146ce","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/220/commits","review_comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/220/comments","review_comment_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/220/comments","statuses_url":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/fd08ac6fefafbac87e91628b48a0cc454af12f12","head":{"label":"dailymotion:sequence-on-wrapper-2.x","ref":"sequence-on-wrapper-2.x","sha":"fd08ac6fefafbac87e91628b48a0cc454af12f12","user":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars2.githubusercontent.com/u/115313?v=4","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"repo":{"id":8641521,"name":"vast-client-js","full_name":"dailymotion/vast-client-js","owner":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars2.githubusercontent.com/u/115313?v=4","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dailymotion/vast-client-js","description":"VAST 3.0 client library for JavaScript","fork":false,"url":"https://api.github.com/repos/dailymotion/vast-client-js","forks_url":"https://api.github.com/repos/dailymotion/vast-client-js/forks","keys_url":"https://api.github.com/repos/dailymotion/vast-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dailymotion/vast-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dailymotion/vast-client-js/teams","hooks_url":"https://api.github.com/repos/dailymotion/vast-client-js/hooks","issue_events_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/dailymotion/vast-client-js/events","assignees_url":"https://api.github.com/repos/dailymotion/vast-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/dailymotion/vast-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/tags","blobs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/dailymotion/vast-client-js/languages","stargazers_url":"https://api.github.com/repos/dailymotion/vast-client-js/stargazers","contributors_url":"https://api.github.com/repos/dailymotion/vast-client-js/contributors","subscribers_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscribers","subscription_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscription","commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dailymotion/vast-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/dailymotion/vast-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dailymotion/vast-client-js/merges","archive_url":"https://api.github.com/repos/dailymotion/vast-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dailymotion/vast-client-js/downloads","issues_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/dailymotion/vast-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/dailymotion/vast-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dailymotion/vast-client-js/labels{/name}","releases_url":"https://api.github.com/repos/dailymotion/vast-client-js/releases{/id}","deployments_url":"https://api.github.com/repos/dailymotion/vast-client-js/deployments","created_at":"2013-03-08T02:37:23Z","updated_at":"2018-05-14T11:45:14Z","pushed_at":"2018-05-17T12:46:24Z","git_url":"git://github.com/dailymotion/vast-client-js.git","ssh_url":"git@github.com:dailymotion/vast-client-js.git","clone_url":"https://github.com/dailymotion/vast-client-js.git","svn_url":"https://github.com/dailymotion/vast-client-js","homepage":"https://www.iab.com/wp-content/uploads/2015/06/VASTv3_0.pdf","size":1238,"stargazers_count":202,"watchers_count":202,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":141,"open_issues":12,"watchers":202,"default_branch":"master"}},"base":{"label":"dailymotion:v2.x","ref":"v2.x","sha":"25efe4c184db38a5649886aaa36d6c551709cc98","user":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars2.githubusercontent.com/u/115313?v=4","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"repo":{"id":8641521,"name":"vast-client-js","full_name":"dailymotion/vast-client-js","owner":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars2.githubusercontent.com/u/115313?v=4","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dailymotion/vast-client-js","description":"VAST 3.0 client library for JavaScript","fork":false,"url":"https://api.github.com/repos/dailymotion/vast-client-js","forks_url":"https://api.github.com/repos/dailymotion/vast-client-js/forks","keys_url":"https://api.github.com/repos/dailymotion/vast-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dailymotion/vast-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dailymotion/vast-client-js/teams","hooks_url":"https://api.github.com/repos/dailymotion/vast-client-js/hooks","issue_events_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/dailymotion/vast-client-js/events","assignees_url":"https://api.github.com/repos/dailymotion/vast-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/dailymotion/vast-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/tags","blobs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/dailymotion/vast-client-js/languages","stargazers_url":"https://api.github.com/repos/dailymotion/vast-client-js/stargazers","contributors_url":"https://api.github.com/repos/dailymotion/vast-client-js/contributors","subscribers_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscribers","subscription_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscription","commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dailymotion/vast-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/dailymotion/vast-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dailymotion/vast-client-js/merges","archive_url":"https://api.github.com/repos/dailymotion/vast-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dailymotion/vast-client-js/downloads","issues_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/dailymotion/vast-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/dailymotion/vast-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dailymotion/vast-client-js/labels{/name}","releases_url":"https://api.github.com/repos/dailymotion/vast-client-js/releases{/id}","deployments_url":"https://api.github.com/repos/dailymotion/vast-client-js/deployments","created_at":"2013-03-08T02:37:23Z","updated_at":"2018-05-14T11:45:14Z","pushed_at":"2018-05-17T12:46:24Z","git_url":"git://github.com/dailymotion/vast-client-js.git","ssh_url":"git@github.com:dailymotion/vast-client-js.git","clone_url":"https://github.com/dailymotion/vast-client-js.git","svn_url":"https://github.com/dailymotion/vast-client-js","homepage":"https://www.iab.com/wp-content/uploads/2015/06/VASTv3_0.pdf","size":1238,"stargazers_count":202,"watchers_count":202,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":141,"open_issues":12,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/220"},"html":{"href":"https://github.com/dailymotion/vast-client-js/pull/220"},"issue":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/issues/220"},"comments":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/fd08ac6fefafbac87e91628b48a0cc454af12f12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eliamaino-fp"}}