{"action":"opened","number":109,"pull_request":{"url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls/109","id":208871558,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODcxNTU4","html_url":"https://github.com/RedHatOfficial/miq-Utilities/pull/109","diff_url":"https://github.com/RedHatOfficial/miq-Utilities/pull/109.diff","patch_url":"https://github.com/RedHatOfficial/miq-Utilities/pull/109.patch","issue_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/issues/109","number":109,"state":"open","locked":false,"title":"Jw stdlib","user":{"login":"jeffwarnica","id":1540402,"node_id":"MDQ6VXNlcjE1NDA0MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1540402?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffwarnica","html_url":"https://github.com/jeffwarnica","followers_url":"https://api.github.com/users/jeffwarnica/followers","following_url":"https://api.github.com/users/jeffwarnica/following{/other_user}","gists_url":"https://api.github.com/users/jeffwarnica/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwarnica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwarnica/subscriptions","organizations_url":"https://api.github.com/users/jeffwarnica/orgs","repos_url":"https://api.github.com/users/jeffwarnica/repos","events_url":"https://api.github.com/users/jeffwarnica/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwarnica/received_events","type":"User","site_admin":false},"body":"Hopefully this is relatively clean. It is too long, sorry for that.\r\n\r\n* converted add_tags_to_lans, vmware_drs_cluster_best_fit_with_scope to class method\r\n* some additional logging, nil checks in vmware_drs_cluster_best_fit_with_scope\r\n* documented unitesting\r\n* added testing for core.rb, and the above converted methods. (converted method have very limited coverage from lack of existing mocks in the manageiq repos)","created_at":"2018-08-16T14:06:28Z","updated_at":"2018-08-16T14:06:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls/109/commits","review_comments_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls/109/comments","review_comment_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/issues/109/comments","statuses_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/statuses/23a6f45527d8ab7ad60563d1412d7af32065f609","head":{"label":"jeffwarnica:JW_Stdlib","ref":"JW_Stdlib","sha":"23a6f45527d8ab7ad60563d1412d7af32065f609","user":{"login":"jeffwarnica","id":1540402,"node_id":"MDQ6VXNlcjE1NDA0MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1540402?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffwarnica","html_url":"https://github.com/jeffwarnica","followers_url":"https://api.github.com/users/jeffwarnica/followers","following_url":"https://api.github.com/users/jeffwarnica/following{/other_user}","gists_url":"https://api.github.com/users/jeffwarnica/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwarnica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwarnica/subscriptions","organizations_url":"https://api.github.com/users/jeffwarnica/orgs","repos_url":"https://api.github.com/users/jeffwarnica/repos","events_url":"https://api.github.com/users/jeffwarnica/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwarnica/received_events","type":"User","site_admin":false},"repo":{"id":135327143,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMjcxNDM=","name":"miq-Utilities","full_name":"jeffwarnica/miq-Utilities","owner":{"login":"jeffwarnica","id":1540402,"node_id":"MDQ6VXNlcjE1NDA0MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1540402?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffwarnica","html_url":"https://github.com/jeffwarnica","followers_url":"https://api.github.com/users/jeffwarnica/followers","following_url":"https://api.github.com/users/jeffwarnica/following{/other_user}","gists_url":"https://api.github.com/users/jeffwarnica/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwarnica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwarnica/subscriptions","organizations_url":"https://api.github.com/users/jeffwarnica/orgs","repos_url":"https://api.github.com/users/jeffwarnica/repos","events_url":"https://api.github.com/users/jeffwarnica/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwarnica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffwarnica/miq-Utilities","description":"ManageIQ Automate Domain of shared utilities to be used by other ManageIQ domains developed by Red Hat Consulting.","fork":true,"url":"https://api.github.com/repos/jeffwarnica/miq-Utilities","forks_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/forks","keys_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/teams","hooks_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/hooks","issue_events_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/issues/events{/number}","events_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/events","assignees_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/assignees{/user}","branches_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/branches{/branch}","tags_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/tags","blobs_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/languages","stargazers_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/stargazers","contributors_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/contributors","subscribers_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/subscribers","subscription_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/subscription","commits_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/contents/{+path}","compare_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/merges","archive_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/downloads","issues_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/issues{/number}","pulls_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/labels{/name}","releases_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/releases{/id}","deployments_url":"https://api.github.com/repos/jeffwarnica/miq-Utilities/deployments","created_at":"2018-05-29T16:57:13Z","updated_at":"2018-05-29T16:57:15Z","pushed_at":"2018-08-16T14:05:44Z","git_url":"git://github.com/jeffwarnica/miq-Utilities.git","ssh_url":"git@github.com:jeffwarnica/miq-Utilities.git","clone_url":"https://github.com/jeffwarnica/miq-Utilities.git","svn_url":"https://github.com/jeffwarnica/miq-Utilities","homepage":"","size":334,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RedHatOfficial:master","ref":"master","sha":"dab1ae4efe7f57dd0737a20e4167c086f5efca3f","user":{"login":"RedHatOfficial","id":33972111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTcyMTEx","avatar_url":"https://avatars2.githubusercontent.com/u/33972111?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatOfficial","html_url":"https://github.com/RedHatOfficial","followers_url":"https://api.github.com/users/RedHatOfficial/followers","following_url":"https://api.github.com/users/RedHatOfficial/following{/other_user}","gists_url":"https://api.github.com/users/RedHatOfficial/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatOfficial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatOfficial/subscriptions","organizations_url":"https://api.github.com/users/RedHatOfficial/orgs","repos_url":"https://api.github.com/users/RedHatOfficial/repos","events_url":"https://api.github.com/users/RedHatOfficial/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatOfficial/received_events","type":"Organization","site_admin":false},"repo":{"id":93072700,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA3MjcwMA==","name":"miq-Utilities","full_name":"RedHatOfficial/miq-Utilities","owner":{"login":"RedHatOfficial","id":33972111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTcyMTEx","avatar_url":"https://avatars2.githubusercontent.com/u/33972111?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatOfficial","html_url":"https://github.com/RedHatOfficial","followers_url":"https://api.github.com/users/RedHatOfficial/followers","following_url":"https://api.github.com/users/RedHatOfficial/following{/other_user}","gists_url":"https://api.github.com/users/RedHatOfficial/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatOfficial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatOfficial/subscriptions","organizations_url":"https://api.github.com/users/RedHatOfficial/orgs","repos_url":"https://api.github.com/users/RedHatOfficial/repos","events_url":"https://api.github.com/users/RedHatOfficial/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatOfficial/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHatOfficial/miq-Utilities","description":"ManageIQ Automate Domain of shared utilities to be used by other ManageIQ domains developed by Red Hat Consulting.","fork":false,"url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities","forks_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/forks","keys_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/teams","hooks_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/hooks","issue_events_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/events","assignees_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/tags","blobs_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/languages","stargazers_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/stargazers","contributors_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/contributors","subscribers_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/subscribers","subscription_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/subscription","commits_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/merges","archive_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/downloads","issues_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/labels{/name}","releases_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/deployments","created_at":"2017-06-01T15:34:48Z","updated_at":"2018-07-26T11:52:19Z","pushed_at":"2018-08-15T22:54:04Z","git_url":"git://github.com/RedHatOfficial/miq-Utilities.git","ssh_url":"git@github.com:RedHatOfficial/miq-Utilities.git","clone_url":"https://github.com/RedHatOfficial/miq-Utilities.git","svn_url":"https://github.com/RedHatOfficial/miq-Utilities","homepage":"","size":289,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":11,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls/109"},"html":{"href":"https://github.com/RedHatOfficial/miq-Utilities/pull/109"},"issue":{"href":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/issues/109"},"comments":{"href":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatOfficial/miq-Utilities/statuses/23a6f45527d8ab7ad60563d1412d7af32065f609"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":47,"additions":815,"deletions":421,"changed_files":10}}
{"actor":{"display_login":"jeffwarnica"}}