{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/8288","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/8288/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/8288/comments","events_url":"https://api.github.com/repos/istio/istio/issues/8288/events","html_url":"https://github.com/istio/istio/pull/8288","id":354508508,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjU1MjY4","number":8288,"title":"add opencensus metrics to mcp/server","user":{"login":"tangiel","id":22239483,"node_id":"MDQ6VXNlcjIyMjM5NDgz","avatar_url":"https://avatars3.githubusercontent.com/u/22239483?v=4","gravatar_id":"","url":"https://api.github.com/users/tangiel","html_url":"https://github.com/tangiel","followers_url":"https://api.github.com/users/tangiel/followers","following_url":"https://api.github.com/users/tangiel/following{/other_user}","gists_url":"https://api.github.com/users/tangiel/gists{/gist_id}","starred_url":"https://api.github.com/users/tangiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangiel/subscriptions","organizations_url":"https://api.github.com/users/tangiel/orgs","repos_url":"https://api.github.com/users/tangiel/repos","events_url":"https://api.github.com/users/tangiel/events{/privacy}","received_events_url":"https://api.github.com/users/tangiel/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-27T23:00:19Z","updated_at":"2018-09-07T21:06:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8288","html_url":"https://github.com/istio/istio/pull/8288","diff_url":"https://github.com/istio/istio/pull/8288.diff","patch_url":"https://github.com/istio/istio/pull/8288.patch"},"body":"This is the first CL for adding metrics to Galley. I just want feedback here to make sure the code is correctly structured. I'll probably batch other modules together once this is reviewed. I am by no means a Go expert, so go nuts. @douglas-reid I included you since you did the opencensus refactor."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/419565860","html_url":"https://github.com/istio/istio/pull/8288#issuecomment-419565860","issue_url":"https://api.github.com/repos/istio/istio/issues/8288","id":419565860,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTU2NTg2MA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-07T21:06:46Z","updated_at":"2018-09-07T21:06:46Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/istio/istio/pull/8288?src=pr&el=h1) Report\n> Merging [#8288](https://codecov.io/gh/istio/istio/pull/8288?src=pr&el=desc) into [master](https://codecov.io/gh/istio/istio/commit/c886b50523ed570217f3d5c97f90d47ca69a9d8c?src=pr&el=desc) will **decrease** coverage by `1%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/istio/istio/pull/8288/graphs/tree.svg?width=650&token=nYtepj7fDQ&height=150&src=pr)](https://codecov.io/gh/istio/istio/pull/8288?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master   #8288    +/-   ##\n=======================================\n- Coverage      72%     71%   -<1%     \n=======================================\n  Files         372     370     -2     \n  Lines       33041   32807   -234     \n=======================================\n- Hits        23466   23274   -192     \n+ Misses       8509    8467    -42     \n  Partials     1066    1066\n```\n\n\n| [Impacted Files](https://codecov.io/gh/istio/istio/pull/8288?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [mixer/adapter/solarwinds/metrics\\_handler.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zb2xhcndpbmRzL21ldHJpY3NfaGFuZGxlci5nbw==) | `70% <0%> (-13%)` | :arrow_down: |\n| [mixer/adapter/rbac/rbacStore.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9yYmFjL3JiYWNTdG9yZS5nbw==) | `76% <0%> (-3%)` | :arrow_down: |\n| [mixer/adapter/signalfx/tracing.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zaWduYWxmeC90cmFjaW5nLmdv) | `80% <0%> (-2%)` | :arrow_down: |\n| [security/pkg/cmd/probe.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-c2VjdXJpdHkvcGtnL2NtZC9wcm9iZS5nbw==) | `63% <0%> (-2%)` | :arrow_down: |\n| [mixer/adapter/opa/opa.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9vcGEvb3BhLmdv) | `79% <0%> (-1%)` | :arrow_down: |\n| [mixer/adapter/bypass/util.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9ieXBhc3MvdXRpbC5nbw==) | `7% <0%> (-1%)` | :arrow_down: |\n| [mixer/adapter/bypass/bypass.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9ieXBhc3MvYnlwYXNzLmdv) | `63% <0%> (-1%)` | :arrow_down: |\n| [mixer/adapter/list/list.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9saXN0L2xpc3QuZ28=) | `100% <0%> (ø)` | :arrow_down: |\n| [mixer/pkg/protobuf/yaml/encoder.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvcGtnL3Byb3RvYnVmL3lhbWwvZW5jb2Rlci5nbw==) | `99% <0%> (ø)` | :arrow_down: |\n| [mixer/adapter/dogstatsd/dogstatsd.go](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9kb2dzdGF0c2QvZG9nc3RhdHNkLmdv) | `100% <0%> (ø)` | :arrow_up: |\n| ... and [24 more](https://codecov.io/gh/istio/istio/pull/8288/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/istio/istio/pull/8288?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/istio/istio/pull/8288?src=pr&el=footer). Last update [c886b50...22df2f7](https://codecov.io/gh/istio/istio/pull/8288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}