{"action":"created","issue":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/404","repository_url":"https://api.github.com/repos/aws/sagemaker-python-sdk","labels_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/404/labels{/name}","comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/404/comments","events_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/404/events","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/404","id":363816025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTU4MzI5","number":404,"title":"Allow TensorFlow json serializer to accept dicts with ndarray values","user":{"login":"winstonaws","id":31297115,"node_id":"MDQ6VXNlcjMxMjk3MTE1","avatar_url":"https://avatars2.githubusercontent.com/u/31297115?v=4","gravatar_id":"","url":"https://api.github.com/users/winstonaws","html_url":"https://github.com/winstonaws","followers_url":"https://api.github.com/users/winstonaws/followers","following_url":"https://api.github.com/users/winstonaws/following{/other_user}","gists_url":"https://api.github.com/users/winstonaws/gists{/gist_id}","starred_url":"https://api.github.com/users/winstonaws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winstonaws/subscriptions","organizations_url":"https://api.github.com/users/winstonaws/orgs","repos_url":"https://api.github.com/users/winstonaws/repos","events_url":"https://api.github.com/users/winstonaws/events{/privacy}","received_events_url":"https://api.github.com/users/winstonaws/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-26T00:38:46Z","updated_at":"2018-09-26T01:09:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/404","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/404","diff_url":"https://github.com/aws/sagemaker-python-sdk/pull/404.diff","patch_url":"https://github.com/aws/sagemaker-python-sdk/pull/404.patch"},"body":"*Issue #, if available:*\r\nhttps://github.com/aws/sagemaker-python-sdk/issues/394\r\n\r\n*Description of changes:*\r\nAllows the tf json serializer (which is the default for the tf predictor) to accept dicts with ndarray values. This only makes sense, since currently we accept lists, dicts of lists, and ndarrays, but not dicts of ndarrays.\r\n\r\nAlso did a small refactor to remove redundancy from the existing implementation of the Json serializer class.\r\n\r\n## Merge Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)\r\n- [ ] I have updated the [changelog](https://github.com/aws/sagemaker-python-sdk/blob/master/CHANGELOG.rst) with a description of my changes (if appropriate)\r\n- [x] I have updated any necessary [documentation](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) (if appropriate)\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n"},"comment":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/comments/424551240","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/404#issuecomment-424551240","issue_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/404","id":424551240,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDU1MTI0MA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T01:09:36Z","updated_at":"2018-09-26T01:09:36Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404?src=pr&el=h1) Report\n> Merging [#404](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404?src=pr&el=desc) into [master](https://codecov.io/gh/aws/sagemaker-python-sdk/commit/eb685407ca5ef6139cf2a5a7d9381faa1beac7bf?src=pr&el=desc) will **decrease** coverage by `0.16%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404/graphs/tree.svg?width=650&token=2snJKHzl2x&height=150&src=pr)](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #404      +/-   ##\n==========================================\n- Coverage   93.11%   92.94%   -0.17%     \n==========================================\n  Files          51       51              \n  Lines        3572     3559      -13     \n==========================================\n- Hits         3326     3308      -18     \n- Misses        246      251       +5\n```\n\n\n| [Impacted Files](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/sagemaker/predictor.py](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404/diff?src=pr&el=tree#diff-c3JjL3NhZ2VtYWtlci9wcmVkaWN0b3IucHk=) | `96.59% <100%> (+0.34%)` | :arrow_up: |\n| [src/sagemaker/local/image.py](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404/diff?src=pr&el=tree#diff-c3JjL3NhZ2VtYWtlci9sb2NhbC9pbWFnZS5weQ==) | `87.42% <0%> (-1.8%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404?src=pr&el=footer). Last update [eb68540...ba20915](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/404?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}