{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/199184748","pull_request_review_id":133258254,"id":199184748,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTE4NDc0OA==","diff_hunk":"@@ -20,13 +20,13 @@\n      * If two transactions write to the same cell the one that was committed later will win.  We\n      * are ignoring write conflicts in this case.\n      */\n-    IGNORE_ALL,\n+    IGNORE_ALL(false, false, false),","path":"atlasdb-api/src/main/java/com/palantir/atlasdb/transaction/api/ConflictHandler.java","position":5,"original_position":5,"commit_id":"f821705261f993ca0d1e39c5e2ee2096fcdace3f","original_commit_id":"f821705261f993ca0d1e39c5e2ee2096fcdace3f","user":{"login":"j-baker","id":42533,"node_id":"MDQ6VXNlcjQyNTMz","avatar_url":"https://avatars2.githubusercontent.com/u/42533?v=4","gravatar_id":"","url":"https://api.github.com/users/j-baker","html_url":"https://github.com/j-baker","followers_url":"https://api.github.com/users/j-baker/followers","following_url":"https://api.github.com/users/j-baker/following{/other_user}","gists_url":"https://api.github.com/users/j-baker/gists{/gist_id}","starred_url":"https://api.github.com/users/j-baker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-baker/subscriptions","organizations_url":"https://api.github.com/users/j-baker/orgs","repos_url":"https://api.github.com/users/j-baker/repos","events_url":"https://api.github.com/users/j-baker/events{/privacy}","received_events_url":"https://api.github.com/users/j-baker/received_events","type":"User","site_admin":false},"body":"think for online upgrades you specifically need a 'lock on cells', 'lock on rows' thing for migration","created_at":"2018-06-29T14:51:14Z","updated_at":"2018-06-29T14:51:15Z","html_url":"https://github.com/palantir/atlasdb/pull/3267#discussion_r199184748","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3267","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/199184748"},"html":{"href":"https://github.com/palantir/atlasdb/pull/3267#discussion_r199184748"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3267"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/3267","id":195128074,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTI4MDc0","html_url":"https://github.com/palantir/atlasdb/pull/3267","diff_url":"https://github.com/palantir/atlasdb/pull/3267.diff","patch_url":"https://github.com/palantir/atlasdb/pull/3267.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/3267","number":3267,"state":"open","locked":false,"title":"serializable_cell conflict handler","user":{"login":"gokcanozakdag","id":9950842,"node_id":"MDQ6VXNlcjk5NTA4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9950842?v=4","gravatar_id":"","url":"https://api.github.com/users/gokcanozakdag","html_url":"https://github.com/gokcanozakdag","followers_url":"https://api.github.com/users/gokcanozakdag/followers","following_url":"https://api.github.com/users/gokcanozakdag/following{/other_user}","gists_url":"https://api.github.com/users/gokcanozakdag/gists{/gist_id}","starred_url":"https://api.github.com/users/gokcanozakdag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokcanozakdag/subscriptions","organizations_url":"https://api.github.com/users/gokcanozakdag/orgs","repos_url":"https://api.github.com/users/gokcanozakdag/repos","events_url":"https://api.github.com/users/gokcanozakdag/events{/privacy}","received_events_url":"https://api.github.com/users/gokcanozakdag/received_events","type":"User","site_admin":false},"body":"**Goals (and why)**:\r\nWe have retry_on_write_write_cell; but we don't have an serializable analogue of this conflict handler. This PR is adding `SERIALIZABLE_CELL` aiming to give clients the ability to lock at cell level in their serializable transactions.\r\n\r\n**Implementation Description (bullets)**:\r\nConflict handler enums are keeping the information of whether it is locking at cell level or row level, and if checking w/r and w/w conflicts. SERIALIZABLE_CELL locks at cell level and checks both w/w and w/r conflicts.\r\n\r\n**Concerns (what feedback would you like?)**:\r\nIs there any other test that can be useful to add?\r\n\r\n**Where should we start reviewing?**:\r\n`ConflictHandler.java`\r\n\r\n**Priority (whenever / two weeks / yesterday)**:\r\n\r\n<!---\r\nPlease remember to:\r\n- Add any necessary release notes (including breaking changes)\r\n- Make sure the documentation is up to date for your change\r\n--->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/3267)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-06-15T09:55:12Z","updated_at":"2018-06-29T14:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e99c9a923b2d1a90634f827fb218bfcc38f1821","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3267/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3267/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/3267/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/f821705261f993ca0d1e39c5e2ee2096fcdace3f","head":{"label":"palantir:gozakdag/serializable-cell-level-conflict","ref":"gozakdag/serializable-cell-level-conflict","sha":"f821705261f993ca0d1e39c5e2ee2096fcdace3f","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk2MDYzNw==","name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2018-06-29T11:13:30Z","pushed_at":"2018-06-29T14:43:05Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":70657,"stargazers_count":598,"watchers_count":598,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":306,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":306,"watchers":598,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"d09ac51c0faf8b81262f9fb30d2118c99f4dae44","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk2MDYzNw==","name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2018-06-29T11:13:30Z","pushed_at":"2018-06-29T14:43:05Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":70657,"stargazers_count":598,"watchers_count":598,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":306,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":306,"watchers":598,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3267"},"html":{"href":"https://github.com/palantir/atlasdb/pull/3267"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/3267"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/3267/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3267/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3267/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/f821705261f993ca0d1e39c5e2ee2096fcdace3f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"j-baker"}}