{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly/pulls/comments/195396626","pull_request_review_id":128756866,"id":195396626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTM5NjYyNg==","diff_hunk":"@@ -36,3 +36,75 @@\n     }\n   }\n }\n+\n+// Message Dialog Component - built on top of PatternFly Modal\n+.message-dialog-pf {\n+  // message-dialog header\n+  .modal-header {\n+    align-items: center;\n+    display: flex;\n+    height: 40px;\n+    justify-content: space-between;\n+    padding-bottom: 0;\n+    padding-left: 20px;\n+    padding-right: 18px;","path":"src/less/modals.less","position":15,"original_position":15,"commit_id":"9699229b2ad6791081bf2eb968ac07833a06089e","original_commit_id":"9699229b2ad6791081bf2eb968ac07833a06089e","user":{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},"body":"There are alot of things here that I don't think are necessary. We should not apply height here. I'm curious why we are reapply any of this when the modal already has it? Shouldn't the styles be consistent with what we already have?","created_at":"2018-06-14T12:06:04Z","updated_at":"2018-06-14T12:06:04Z","html_url":"https://github.com/patternfly/patternfly/pull/1074#discussion_r195396626","pull_request_url":"https://api.github.com/repos/patternfly/patternfly/pulls/1074","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/comments/195396626"},"html":{"href":"https://github.com/patternfly/patternfly/pull/1074#discussion_r195396626"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/1074"}},"in_reply_to_id":195373341},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly/pulls/1074","id":194558149,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTU4MTQ5","html_url":"https://github.com/patternfly/patternfly/pull/1074","diff_url":"https://github.com/patternfly/patternfly/pull/1074.diff","patch_url":"https://github.com/patternfly/patternfly/pull/1074.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly/issues/1074","number":1074,"state":"open","locked":false,"title":"feat(message-dialog): Add the message-dialog pattern","user":{"login":"michaelkro","id":15141412,"node_id":"MDQ6VXNlcjE1MTQxNDEy","avatar_url":"https://avatars3.githubusercontent.com/u/15141412?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkro","html_url":"https://github.com/michaelkro","followers_url":"https://api.github.com/users/michaelkro/followers","following_url":"https://api.github.com/users/michaelkro/following{/other_user}","gists_url":"https://api.github.com/users/michaelkro/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkro/subscriptions","organizations_url":"https://api.github.com/users/michaelkro/orgs","repos_url":"https://api.github.com/users/michaelkro/repos","events_url":"https://api.github.com/users/michaelkro/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkro/received_events","type":"User","site_admin":false},"body":"## Description\r\nThe message dialog pattern is built on `modal`, and consequently, almost all of the introduced CSS are overrides to `modal` styles dictated by [the specs outlined here](https://github.com/patternfly/patternfly-design/issues/632#issuecomment-396402810)\r\n\r\n**Notes**\r\n1. SASS/LESS nesting is used here to scope all styles/overrides to `.message-dialog-pf`\r\n2. Test examples based on [original samples](https://github.com/patternfly/patternfly-react/issues/360#issuecomment-392789901)\r\n3. Closes https://github.com/patternfly/patternfly/issues/1064\r\n\r\n## Link to rawgit\r\n\r\n[rawgit](https://rawgit.com/michaelkro/patternfly/message-dialog-rawgit/message-dialog-dist/dist/tests/message-dialogs.html)\r\n\r\n## PR checklist (if relevant)\r\n\r\n- [ ] **Cross browser**: works in IE9\r\n- [ ] **Cross browser**: works in IE10\r\n- [ ] **Cross browser**: works in IE11\r\n- [ ] **Cross browser**: works in Edge\r\n- [x] **Cross browser**: works in Chrome\r\n- [x] **Cross browser**: works in Firefox\r\n- [x] **Cross browser**: works in Safari\r\n- [ ] **Cross browser**: works in Opera\r\n- [x] **Responsive**: works in extra small, small, medium and large view ports.\r\n- [x] **Preview the PR**: An image or a URL for designer to preview this PR is provided.\r\n","created_at":"2018-06-13T11:42:53Z","updated_at":"2018-06-14T12:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f07a093c5740db89f8df8cf7f35f95c6b55c958","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly/pulls/1074/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly/pulls/1074/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly/issues/1074/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly/statuses/9699229b2ad6791081bf2eb968ac07833a06089e","head":{"label":"michaelkro:message-dialog","ref":"message-dialog","sha":"9699229b2ad6791081bf2eb968ac07833a06089e","user":{"login":"michaelkro","id":15141412,"node_id":"MDQ6VXNlcjE1MTQxNDEy","avatar_url":"https://avatars3.githubusercontent.com/u/15141412?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkro","html_url":"https://github.com/michaelkro","followers_url":"https://api.github.com/users/michaelkro/followers","following_url":"https://api.github.com/users/michaelkro/following{/other_user}","gists_url":"https://api.github.com/users/michaelkro/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkro/subscriptions","organizations_url":"https://api.github.com/users/michaelkro/orgs","repos_url":"https://api.github.com/users/michaelkro/repos","events_url":"https://api.github.com/users/michaelkro/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkro/received_events","type":"User","site_admin":false},"repo":{"id":108904162,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg5MDQxNjI=","name":"patternfly","full_name":"michaelkro/patternfly","owner":{"login":"michaelkro","id":15141412,"node_id":"MDQ6VXNlcjE1MTQxNDEy","avatar_url":"https://avatars3.githubusercontent.com/u/15141412?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkro","html_url":"https://github.com/michaelkro","followers_url":"https://api.github.com/users/michaelkro/followers","following_url":"https://api.github.com/users/michaelkro/following{/other_user}","gists_url":"https://api.github.com/users/michaelkro/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkro/subscriptions","organizations_url":"https://api.github.com/users/michaelkro/orgs","repos_url":"https://api.github.com/users/michaelkro/repos","events_url":"https://api.github.com/users/michaelkro/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelkro/patternfly","description":"PatternFly open interface project","fork":true,"url":"https://api.github.com/repos/michaelkro/patternfly","forks_url":"https://api.github.com/repos/michaelkro/patternfly/forks","keys_url":"https://api.github.com/repos/michaelkro/patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelkro/patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelkro/patternfly/teams","hooks_url":"https://api.github.com/repos/michaelkro/patternfly/hooks","issue_events_url":"https://api.github.com/repos/michaelkro/patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/michaelkro/patternfly/events","assignees_url":"https://api.github.com/repos/michaelkro/patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/michaelkro/patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/michaelkro/patternfly/tags","blobs_url":"https://api.github.com/repos/michaelkro/patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelkro/patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelkro/patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelkro/patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelkro/patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelkro/patternfly/languages","stargazers_url":"https://api.github.com/repos/michaelkro/patternfly/stargazers","contributors_url":"https://api.github.com/repos/michaelkro/patternfly/contributors","subscribers_url":"https://api.github.com/repos/michaelkro/patternfly/subscribers","subscription_url":"https://api.github.com/repos/michaelkro/patternfly/subscription","commits_url":"https://api.github.com/repos/michaelkro/patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelkro/patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelkro/patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelkro/patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelkro/patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/michaelkro/patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelkro/patternfly/merges","archive_url":"https://api.github.com/repos/michaelkro/patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelkro/patternfly/downloads","issues_url":"https://api.github.com/repos/michaelkro/patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/michaelkro/patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelkro/patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelkro/patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelkro/patternfly/labels{/name}","releases_url":"https://api.github.com/repos/michaelkro/patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/michaelkro/patternfly/deployments","created_at":"2017-10-30T20:22:14Z","updated_at":"2018-05-29T12:06:32Z","pushed_at":"2018-06-13T14:47:42Z","git_url":"git://github.com/michaelkro/patternfly.git","ssh_url":"git@github.com:michaelkro/patternfly.git","clone_url":"https://github.com/michaelkro/patternfly.git","svn_url":"https://github.com/michaelkro/patternfly","homepage":"https://www.patternfly.org/","size":90805,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"2b793ba3c0d957e2cd0d9aaa4944495dddf2a298","user":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":16493298,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ5MzI5OA==","name":"patternfly","full_name":"patternfly/patternfly","owner":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/patternfly","description":"This repo contains instructions and the HTML, CSS, and JQuery for the PatternFly project.","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly","forks_url":"https://api.github.com/repos/patternfly/patternfly/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly/deployments","created_at":"2014-02-03T21:18:00Z","updated_at":"2018-06-13T17:02:14Z","pushed_at":"2018-06-13T17:19:14Z","git_url":"git://github.com/patternfly/patternfly.git","ssh_url":"git@github.com:patternfly/patternfly.git","clone_url":"https://github.com/patternfly/patternfly.git","svn_url":"https://github.com/patternfly/patternfly","homepage":"https://www.patternfly.org/","size":94853,"stargazers_count":956,"watchers_count":956,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":224,"open_issues":65,"watchers":956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/1074"},"html":{"href":"https://github.com/patternfly/patternfly/pull/1074"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly/issues/1074"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly/issues/1074/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/1074/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/1074/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly/statuses/9699229b2ad6791081bf2eb968ac07833a06089e"}},"author_association":"NONE"}}
{"actor":{"display_login":"matthewcarleton"}}