{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls/11","id":208179272,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTc5Mjcy","html_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket/pull/11","diff_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket/pull/11.diff","patch_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket/pull/11.patch","issue_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues/11","number":11,"state":"closed","locked":false,"title":"Moises: Implemented Firebase Auth: Email-Password on FrontEnd.","user":{"login":"designerexpert","id":20391435,"node_id":"MDQ6VXNlcjIwMzkxNDM1","avatar_url":"https://avatars0.githubusercontent.com/u/20391435?v=4","gravatar_id":"","url":"https://api.github.com/users/designerexpert","html_url":"https://github.com/designerexpert","followers_url":"https://api.github.com/users/designerexpert/followers","following_url":"https://api.github.com/users/designerexpert/following{/other_user}","gists_url":"https://api.github.com/users/designerexpert/gists{/gist_id}","starred_url":"https://api.github.com/users/designerexpert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designerexpert/subscriptions","organizations_url":"https://api.github.com/users/designerexpert/orgs","repos_url":"https://api.github.com/users/designerexpert/repos","events_url":"https://api.github.com/users/designerexpert/events{/privacy}","received_events_url":"https://api.github.com/users/designerexpert/received_events","type":"User","site_admin":false},"body":"# Description\r\n Please include a summary of the change and a link to which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.\r\n Fixes # (issue)\r\n ## Type of change\r\n Please delete options that are not relevant.\r\n - [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [x] This change requires a documentation update\r\n # How Has This Been Tested?\r\n Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration\r\n - [x] Tested Authentication with registering a dummy user, and logging it in, to see it update data.\r\n # Checklist:\r\n- [x] My code follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code\r\n- [x] My code has been reviewed by at least one peer\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [ ] I have made corresponding changes to the documentation\r\n- [x] My changes generate no new warnings\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] New and existing unit tests pass locally with my changes","created_at":"2018-08-14T06:20:15Z","updated_at":"2018-08-15T00:07:12Z","closed_at":"2018-08-15T00:07:12Z","merged_at":"2018-08-15T00:07:12Z","merge_commit_sha":"13a1c14d813b8552925f3c424d823b1a2fb68e76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls/11/commits","review_comments_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls/11/comments","review_comment_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues/11/comments","statuses_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/statuses/13a1c14d813b8552925f3c424d823b1a2fb68e76","head":{"label":"Lambda-School-Labs:moises","ref":"moises","sha":"13a1c14d813b8552925f3c424d823b1a2fb68e76","user":{"login":"Lambda-School-Labs","id":32200850,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAwODUw","avatar_url":"https://avatars0.githubusercontent.com/u/32200850?v=4","gravatar_id":"","url":"https://api.github.com/users/Lambda-School-Labs","html_url":"https://github.com/Lambda-School-Labs","followers_url":"https://api.github.com/users/Lambda-School-Labs/followers","following_url":"https://api.github.com/users/Lambda-School-Labs/following{/other_user}","gists_url":"https://api.github.com/users/Lambda-School-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lambda-School-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lambda-School-Labs/subscriptions","organizations_url":"https://api.github.com/users/Lambda-School-Labs/orgs","repos_url":"https://api.github.com/users/Lambda-School-Labs/repos","events_url":"https://api.github.com/users/Lambda-School-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/Lambda-School-Labs/received_events","type":"Organization","site_admin":false},"repo":{"id":144505430,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1MDU0MzA=","name":"CS9-KnowledgeRocket","full_name":"Lambda-School-Labs/CS9-KnowledgeRocket","owner":{"login":"Lambda-School-Labs","id":32200850,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAwODUw","avatar_url":"https://avatars0.githubusercontent.com/u/32200850?v=4","gravatar_id":"","url":"https://api.github.com/users/Lambda-School-Labs","html_url":"https://github.com/Lambda-School-Labs","followers_url":"https://api.github.com/users/Lambda-School-Labs/followers","following_url":"https://api.github.com/users/Lambda-School-Labs/following{/other_user}","gists_url":"https://api.github.com/users/Lambda-School-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lambda-School-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lambda-School-Labs/subscriptions","organizations_url":"https://api.github.com/users/Lambda-School-Labs/orgs","repos_url":"https://api.github.com/users/Lambda-School-Labs/repos","events_url":"https://api.github.com/users/Lambda-School-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/Lambda-School-Labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket","description":null,"fork":false,"url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket","forks_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/forks","keys_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/teams","hooks_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/hooks","issue_events_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues/events{/number}","events_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/events","assignees_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/assignees{/user}","branches_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/branches{/branch}","tags_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/tags","blobs_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/statuses/{sha}","languages_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/languages","stargazers_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/stargazers","contributors_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/contributors","subscribers_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/subscribers","subscription_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/subscription","commits_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/contents/{+path}","compare_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/merges","archive_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/downloads","issues_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues{/number}","pulls_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls{/number}","milestones_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/milestones{/number}","notifications_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/labels{/name}","releases_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/releases{/id}","deployments_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/deployments","created_at":"2018-08-12T22:33:27Z","updated_at":"2018-08-14T23:45:44Z","pushed_at":"2018-08-15T00:07:11Z","git_url":"git://github.com/Lambda-School-Labs/CS9-KnowledgeRocket.git","ssh_url":"git@github.com:Lambda-School-Labs/CS9-KnowledgeRocket.git","clone_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket.git","svn_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket","homepage":null,"size":2185,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"Lambda-School-Labs:master","ref":"master","sha":"2653e1f1a7780443c5e5133e6874ff8abd79ffa4","user":{"login":"Lambda-School-Labs","id":32200850,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAwODUw","avatar_url":"https://avatars0.githubusercontent.com/u/32200850?v=4","gravatar_id":"","url":"https://api.github.com/users/Lambda-School-Labs","html_url":"https://github.com/Lambda-School-Labs","followers_url":"https://api.github.com/users/Lambda-School-Labs/followers","following_url":"https://api.github.com/users/Lambda-School-Labs/following{/other_user}","gists_url":"https://api.github.com/users/Lambda-School-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lambda-School-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lambda-School-Labs/subscriptions","organizations_url":"https://api.github.com/users/Lambda-School-Labs/orgs","repos_url":"https://api.github.com/users/Lambda-School-Labs/repos","events_url":"https://api.github.com/users/Lambda-School-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/Lambda-School-Labs/received_events","type":"Organization","site_admin":false},"repo":{"id":144505430,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1MDU0MzA=","name":"CS9-KnowledgeRocket","full_name":"Lambda-School-Labs/CS9-KnowledgeRocket","owner":{"login":"Lambda-School-Labs","id":32200850,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAwODUw","avatar_url":"https://avatars0.githubusercontent.com/u/32200850?v=4","gravatar_id":"","url":"https://api.github.com/users/Lambda-School-Labs","html_url":"https://github.com/Lambda-School-Labs","followers_url":"https://api.github.com/users/Lambda-School-Labs/followers","following_url":"https://api.github.com/users/Lambda-School-Labs/following{/other_user}","gists_url":"https://api.github.com/users/Lambda-School-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lambda-School-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lambda-School-Labs/subscriptions","organizations_url":"https://api.github.com/users/Lambda-School-Labs/orgs","repos_url":"https://api.github.com/users/Lambda-School-Labs/repos","events_url":"https://api.github.com/users/Lambda-School-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/Lambda-School-Labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket","description":null,"fork":false,"url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket","forks_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/forks","keys_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/teams","hooks_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/hooks","issue_events_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues/events{/number}","events_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/events","assignees_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/assignees{/user}","branches_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/branches{/branch}","tags_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/tags","blobs_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/statuses/{sha}","languages_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/languages","stargazers_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/stargazers","contributors_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/contributors","subscribers_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/subscribers","subscription_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/subscription","commits_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/contents/{+path}","compare_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/merges","archive_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/downloads","issues_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues{/number}","pulls_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls{/number}","milestones_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/milestones{/number}","notifications_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/labels{/name}","releases_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/releases{/id}","deployments_url":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/deployments","created_at":"2018-08-12T22:33:27Z","updated_at":"2018-08-14T23:45:44Z","pushed_at":"2018-08-15T00:07:11Z","git_url":"git://github.com/Lambda-School-Labs/CS9-KnowledgeRocket.git","ssh_url":"git@github.com:Lambda-School-Labs/CS9-KnowledgeRocket.git","clone_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket.git","svn_url":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket","homepage":null,"size":2185,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls/11"},"html":{"href":"https://github.com/Lambda-School-Labs/CS9-KnowledgeRocket/pull/11"},"issue":{"href":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues/11"},"comments":{"href":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/Lambda-School-Labs/CS9-KnowledgeRocket/statuses/13a1c14d813b8552925f3c424d823b1a2fb68e76"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sharp0111","id":5162496,"node_id":"MDQ6VXNlcjUxNjI0OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5162496?v=4","gravatar_id":"","url":"https://api.github.com/users/sharp0111","html_url":"https://github.com/sharp0111","followers_url":"https://api.github.com/users/sharp0111/followers","following_url":"https://api.github.com/users/sharp0111/following{/other_user}","gists_url":"https://api.github.com/users/sharp0111/gists{/gist_id}","starred_url":"https://api.github.com/users/sharp0111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharp0111/subscriptions","organizations_url":"https://api.github.com/users/sharp0111/orgs","repos_url":"https://api.github.com/users/sharp0111/repos","events_url":"https://api.github.com/users/sharp0111/events{/privacy}","received_events_url":"https://api.github.com/users/sharp0111/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":373,"deletions":31,"changed_files":8}}
{"actor":{"display_login":"sharp0111"}}