{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/224624844","pull_request_review_id":164041323,"id":224624844,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDYyNDg0NA==","diff_hunk":"@@ -9753,6 +9753,7 @@ VersionedObjectList basicRemoveAll(final Collection<Object> keys,\n           txException = txException.getCause();\n         }\n         if (runtimeException == null) {\n+          runtimeException = getCancelCriterion().generateCancelledException(e.getFailure());","path":"geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java","position":8,"original_position":4,"commit_id":"37aa8269f6b220b6cf9ea5059ae5e6f6a5854daa","original_commit_id":"3d5bcc2e3dba751958d362a9f9c0e78ae97bbc88","user":{"login":"pivotal-eshu","id":11180099,"node_id":"MDQ6VXNlcjExMTgwMDk5","avatar_url":"https://avatars0.githubusercontent.com/u/11180099?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-eshu","html_url":"https://github.com/pivotal-eshu","followers_url":"https://api.github.com/users/pivotal-eshu/followers","following_url":"https://api.github.com/users/pivotal-eshu/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-eshu/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-eshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-eshu/subscriptions","organizations_url":"https://api.github.com/users/pivotal-eshu/orgs","repos_url":"https://api.github.com/users/pivotal-eshu/repos","events_url":"https://api.github.com/users/pivotal-eshu/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-eshu/received_events","type":"User","site_admin":false},"body":"Actually, the method may not throw CacheClosedException but return CacheClosedException instead. Made the change necessary.","created_at":"2018-10-11T22:33:28Z","updated_at":"2018-10-11T22:33:28Z","html_url":"https://github.com/apache/geode/pull/2594#discussion_r224624844","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/2594","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/224624844"},"html":{"href":"https://github.com/apache/geode/pull/2594#discussion_r224624844"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/2594"}},"in_reply_to_id":224580532},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2594","id":222247771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjQ3Nzcx","html_url":"https://github.com/apache/geode/pull/2594","diff_url":"https://github.com/apache/geode/pull/2594.diff","patch_url":"https://github.com/apache/geode/pull/2594.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/2594","number":2594,"state":"open","locked":false,"title":"GEODE-5849: Do not wrap CacheClosedException if client cache is closing.","user":{"login":"pivotal-eshu","id":11180099,"node_id":"MDQ6VXNlcjExMTgwMDk5","avatar_url":"https://avatars0.githubusercontent.com/u/11180099?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-eshu","html_url":"https://github.com/pivotal-eshu","followers_url":"https://api.github.com/users/pivotal-eshu/followers","following_url":"https://api.github.com/users/pivotal-eshu/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-eshu/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-eshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-eshu/subscriptions","organizations_url":"https://api.github.com/users/pivotal-eshu/orgs","repos_url":"https://api.github.com/users/pivotal-eshu/repos","events_url":"https://api.github.com/users/pivotal-eshu/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-eshu/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-10-11T19:10:28Z","updated_at":"2018-10-11T22:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"544e25a5560266379ae3cadeb68fdda2e30e1a9f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kirklund","id":1444301,"node_id":"MDQ6VXNlcjE0NDQzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1444301?v=4","gravatar_id":"","url":"https://api.github.com/users/kirklund","html_url":"https://github.com/kirklund","followers_url":"https://api.github.com/users/kirklund/followers","following_url":"https://api.github.com/users/kirklund/following{/other_user}","gists_url":"https://api.github.com/users/kirklund/gists{/gist_id}","starred_url":"https://api.github.com/users/kirklund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirklund/subscriptions","organizations_url":"https://api.github.com/users/kirklund/orgs","repos_url":"https://api.github.com/users/kirklund/repos","events_url":"https://api.github.com/users/kirklund/events{/privacy}","received_events_url":"https://api.github.com/users/kirklund/received_events","type":"User","site_admin":false},{"login":"agingade","id":8432880,"node_id":"MDQ6VXNlcjg0MzI4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/8432880?v=4","gravatar_id":"","url":"https://api.github.com/users/agingade","html_url":"https://github.com/agingade","followers_url":"https://api.github.com/users/agingade/followers","following_url":"https://api.github.com/users/agingade/following{/other_user}","gists_url":"https://api.github.com/users/agingade/gists{/gist_id}","starred_url":"https://api.github.com/users/agingade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agingade/subscriptions","organizations_url":"https://api.github.com/users/agingade/orgs","repos_url":"https://api.github.com/users/agingade/repos","events_url":"https://api.github.com/users/agingade/events{/privacy}","received_events_url":"https://api.github.com/users/agingade/received_events","type":"User","site_admin":false},{"login":"gesterzhou","id":10713950,"node_id":"MDQ6VXNlcjEwNzEzOTUw","avatar_url":"https://avatars2.githubusercontent.com/u/10713950?v=4","gravatar_id":"","url":"https://api.github.com/users/gesterzhou","html_url":"https://github.com/gesterzhou","followers_url":"https://api.github.com/users/gesterzhou/followers","following_url":"https://api.github.com/users/gesterzhou/following{/other_user}","gists_url":"https://api.github.com/users/gesterzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/gesterzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gesterzhou/subscriptions","organizations_url":"https://api.github.com/users/gesterzhou/orgs","repos_url":"https://api.github.com/users/gesterzhou/repos","events_url":"https://api.github.com/users/gesterzhou/events{/privacy}","received_events_url":"https://api.github.com/users/gesterzhou/received_events","type":"User","site_admin":false},{"login":"lgallinat","id":11180732,"node_id":"MDQ6VXNlcjExMTgwNzMy","avatar_url":"https://avatars1.githubusercontent.com/u/11180732?v=4","gravatar_id":"","url":"https://api.github.com/users/lgallinat","html_url":"https://github.com/lgallinat","followers_url":"https://api.github.com/users/lgallinat/followers","following_url":"https://api.github.com/users/lgallinat/following{/other_user}","gists_url":"https://api.github.com/users/lgallinat/gists{/gist_id}","starred_url":"https://api.github.com/users/lgallinat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgallinat/subscriptions","organizations_url":"https://api.github.com/users/lgallinat/orgs","repos_url":"https://api.github.com/users/lgallinat/repos","events_url":"https://api.github.com/users/lgallinat/events{/privacy}","received_events_url":"https://api.github.com/users/lgallinat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/2594/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/2594/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/2594/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/37aa8269f6b220b6cf9ea5059ae5e6f6a5854daa","head":{"label":"apache:feature/GEODE-5849","ref":"feature/GEODE-5849","sha":"37aa8269f6b220b6cf9ea5059ae5e6f6a5854daa","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgzOTM4Mw==","name":"geode","full_name":"apache/geode","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2018-10-11T22:06:56Z","pushed_at":"2018-10-11T22:31:54Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":162017,"stargazers_count":1353,"watchers_count":1353,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":467,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":467,"open_issues":28,"watchers":1353,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"50efe8a87ccc71203f31ae871f04bfd9f9e38c83","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgzOTM4Mw==","name":"geode","full_name":"apache/geode","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2018-10-11T22:06:56Z","pushed_at":"2018-10-11T22:31:54Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":162017,"stargazers_count":1353,"watchers_count":1353,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":467,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":467,"open_issues":28,"watchers":1353,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/2594"},"html":{"href":"https://github.com/apache/geode/pull/2594"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/2594"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/2594/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/2594/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/2594/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/37aa8269f6b220b6cf9ea5059ae5e6f6a5854daa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pivotal-eshu"}}