{"action":"created","comment":{"url":"https://api.github.com/repos/openfaas/faas-netes/pulls/comments/216977204","pull_request_review_id":154581555,"id":216977204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjk3NzIwNA==","diff_hunk":"@@ -27,14 +27,24 @@ spec:\n           - \"--config.file=/alertmanager.yml\"\n           - \"--storage.path=/alertmanager\"\n         livenessProbe:\n-          httpGet:\n-            path: /#/status\n-            port: 9093\n+          exec:","path":"chart/openfaas/templates/alertmanager-dep.yaml","position":7,"original_position":7,"commit_id":"8de9dd3beafd55ce9ed9f9fd54af365659352941","original_commit_id":"9495619210d29a14156e9af03c73fb2dcca3fc18","user":{"login":"stefanprodan","id":3797675,"node_id":"MDQ6VXNlcjM3OTc2NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3797675?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanprodan","html_url":"https://github.com/stefanprodan","followers_url":"https://api.github.com/users/stefanprodan/followers","following_url":"https://api.github.com/users/stefanprodan/following{/other_user}","gists_url":"https://api.github.com/users/stefanprodan/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanprodan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanprodan/subscriptions","organizations_url":"https://api.github.com/users/stefanprodan/orgs","repos_url":"https://api.github.com/users/stefanprodan/repos","events_url":"https://api.github.com/users/stefanprodan/events{/privacy}","received_events_url":"https://api.github.com/users/stefanprodan/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-09-12T10:26:57Z","updated_at":"2018-09-12T10:26:57Z","html_url":"https://github.com/openfaas/faas-netes/pull/279#discussion_r216977204","pull_request_url":"https://api.github.com/repos/openfaas/faas-netes/pulls/279","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openfaas/faas-netes/pulls/comments/216977204"},"html":{"href":"https://github.com/openfaas/faas-netes/pull/279#discussion_r216977204"},"pull_request":{"href":"https://api.github.com/repos/openfaas/faas-netes/pulls/279"}},"in_reply_to_id":216967484},"pull_request":{"url":"https://api.github.com/repos/openfaas/faas-netes/pulls/279","id":212741639,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzQxNjM5","html_url":"https://github.com/openfaas/faas-netes/pull/279","diff_url":"https://github.com/openfaas/faas-netes/pull/279.diff","patch_url":"https://github.com/openfaas/faas-netes/pull/279.patch","issue_url":"https://api.github.com/repos/openfaas/faas-netes/issues/279","number":279,"state":"open","locked":false,"title":"Helm chart: Istio compatibility and CRD validation","user":{"login":"stefanprodan","id":3797675,"node_id":"MDQ6VXNlcjM3OTc2NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3797675?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanprodan","html_url":"https://github.com/stefanprodan","followers_url":"https://api.github.com/users/stefanprodan/followers","following_url":"https://api.github.com/users/stefanprodan/following{/other_user}","gists_url":"https://api.github.com/users/stefanprodan/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanprodan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanprodan/subscriptions","organizations_url":"https://api.github.com/users/stefanprodan/orgs","repos_url":"https://api.github.com/users/stefanprodan/repos","events_url":"https://api.github.com/users/stefanprodan/events{/privacy}","received_events_url":"https://api.github.com/users/stefanprodan/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis PR does the following:\r\n\r\n* add openAPIV3Schema validation to CRD, port from https://github.com/openfaas-incubator/openfaas-operator/pull/40 \r\n* move basic auth setup in the main install section to encourage users to secure the Gateway when using the Helm chart\r\n\r\nIstio compatibility:\r\n\r\n* move the Gateway security context from pod to container level\r\n* remove the last dot from the domain name so that Envoy can resolve the destination\r\n* use a named port for the Gateway service to enable Istio L7 HTTP/S routing and tracing\r\n* use wget for health checks (mTLS)\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n- [x] I have raised an issue to propose this change ([required](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))\r\n\r\n\r\n## How Has This Been Tested?\r\nThe  security context change and the CRD validation have been tested on GKE 1.10 and Istio 1.0.1\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I've read the [CONTRIBUTION](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md) guide\r\n- [x] I have signed-off my commits with `git commit -s`\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n","created_at":"2018-09-03T13:00:03Z","updated_at":"2018-09-12T10:26:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddd034669685bddad287119c6ca6372aae11c833","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1047778527,"node_id":"MDU6TGFiZWwxMDQ3Nzc4NTI3","url":"https://api.github.com/repos/openfaas/faas-netes/labels/design/review","name":"design/review","color":"edce78","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openfaas/faas-netes/pulls/279/commits","review_comments_url":"https://api.github.com/repos/openfaas/faas-netes/pulls/279/comments","review_comment_url":"https://api.github.com/repos/openfaas/faas-netes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openfaas/faas-netes/issues/279/comments","statuses_url":"https://api.github.com/repos/openfaas/faas-netes/statuses/8de9dd3beafd55ce9ed9f9fd54af365659352941","head":{"label":"stefanprodan:helm","ref":"helm","sha":"8de9dd3beafd55ce9ed9f9fd54af365659352941","user":{"login":"stefanprodan","id":3797675,"node_id":"MDQ6VXNlcjM3OTc2NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3797675?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanprodan","html_url":"https://github.com/stefanprodan","followers_url":"https://api.github.com/users/stefanprodan/followers","following_url":"https://api.github.com/users/stefanprodan/following{/other_user}","gists_url":"https://api.github.com/users/stefanprodan/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanprodan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanprodan/subscriptions","organizations_url":"https://api.github.com/users/stefanprodan/orgs","repos_url":"https://api.github.com/users/stefanprodan/repos","events_url":"https://api.github.com/users/stefanprodan/events{/privacy}","received_events_url":"https://api.github.com/users/stefanprodan/received_events","type":"User","site_admin":false},"repo":{"id":147201340,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyMDEzNDA=","name":"faas-netes","full_name":"stefanprodan/faas-netes","owner":{"login":"stefanprodan","id":3797675,"node_id":"MDQ6VXNlcjM3OTc2NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3797675?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanprodan","html_url":"https://github.com/stefanprodan","followers_url":"https://api.github.com/users/stefanprodan/followers","following_url":"https://api.github.com/users/stefanprodan/following{/other_user}","gists_url":"https://api.github.com/users/stefanprodan/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanprodan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanprodan/subscriptions","organizations_url":"https://api.github.com/users/stefanprodan/orgs","repos_url":"https://api.github.com/users/stefanprodan/repos","events_url":"https://api.github.com/users/stefanprodan/events{/privacy}","received_events_url":"https://api.github.com/users/stefanprodan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanprodan/faas-netes","description":"Serverless Kubernetes with OpenFaaS (Functions as a Service)","fork":true,"url":"https://api.github.com/repos/stefanprodan/faas-netes","forks_url":"https://api.github.com/repos/stefanprodan/faas-netes/forks","keys_url":"https://api.github.com/repos/stefanprodan/faas-netes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanprodan/faas-netes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanprodan/faas-netes/teams","hooks_url":"https://api.github.com/repos/stefanprodan/faas-netes/hooks","issue_events_url":"https://api.github.com/repos/stefanprodan/faas-netes/issues/events{/number}","events_url":"https://api.github.com/repos/stefanprodan/faas-netes/events","assignees_url":"https://api.github.com/repos/stefanprodan/faas-netes/assignees{/user}","branches_url":"https://api.github.com/repos/stefanprodan/faas-netes/branches{/branch}","tags_url":"https://api.github.com/repos/stefanprodan/faas-netes/tags","blobs_url":"https://api.github.com/repos/stefanprodan/faas-netes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanprodan/faas-netes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanprodan/faas-netes/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanprodan/faas-netes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanprodan/faas-netes/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanprodan/faas-netes/languages","stargazers_url":"https://api.github.com/repos/stefanprodan/faas-netes/stargazers","contributors_url":"https://api.github.com/repos/stefanprodan/faas-netes/contributors","subscribers_url":"https://api.github.com/repos/stefanprodan/faas-netes/subscribers","subscription_url":"https://api.github.com/repos/stefanprodan/faas-netes/subscription","commits_url":"https://api.github.com/repos/stefanprodan/faas-netes/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanprodan/faas-netes/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanprodan/faas-netes/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanprodan/faas-netes/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanprodan/faas-netes/contents/{+path}","compare_url":"https://api.github.com/repos/stefanprodan/faas-netes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanprodan/faas-netes/merges","archive_url":"https://api.github.com/repos/stefanprodan/faas-netes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanprodan/faas-netes/downloads","issues_url":"https://api.github.com/repos/stefanprodan/faas-netes/issues{/number}","pulls_url":"https://api.github.com/repos/stefanprodan/faas-netes/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanprodan/faas-netes/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanprodan/faas-netes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanprodan/faas-netes/labels{/name}","releases_url":"https://api.github.com/repos/stefanprodan/faas-netes/releases{/id}","deployments_url":"https://api.github.com/repos/stefanprodan/faas-netes/deployments","created_at":"2018-09-03T12:23:06Z","updated_at":"2018-09-03T12:23:08Z","pushed_at":"2018-09-12T10:25:18Z","git_url":"git://github.com/stefanprodan/faas-netes.git","ssh_url":"git@github.com:stefanprodan/faas-netes.git","clone_url":"https://github.com/stefanprodan/faas-netes.git","svn_url":"https://github.com/stefanprodan/faas-netes","homepage":"https://github.com/openfaas/faas","size":4618,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openfaas:master","ref":"master","sha":"0810d7e17bd13ceca1bfb07005fbda9de57b9078","user":{"login":"openfaas","id":27013154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDEzMTU0","avatar_url":"https://avatars3.githubusercontent.com/u/27013154?v=4","gravatar_id":"","url":"https://api.github.com/users/openfaas","html_url":"https://github.com/openfaas","followers_url":"https://api.github.com/users/openfaas/followers","following_url":"https://api.github.com/users/openfaas/following{/other_user}","gists_url":"https://api.github.com/users/openfaas/gists{/gist_id}","starred_url":"https://api.github.com/users/openfaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfaas/subscriptions","organizations_url":"https://api.github.com/users/openfaas/orgs","repos_url":"https://api.github.com/users/openfaas/repos","events_url":"https://api.github.com/users/openfaas/events{/privacy}","received_events_url":"https://api.github.com/users/openfaas/received_events","type":"Organization","site_admin":false},"repo":{"id":98119127,"node_id":"MDEwOlJlcG9zaXRvcnk5ODExOTEyNw==","name":"faas-netes","full_name":"openfaas/faas-netes","owner":{"login":"openfaas","id":27013154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDEzMTU0","avatar_url":"https://avatars3.githubusercontent.com/u/27013154?v=4","gravatar_id":"","url":"https://api.github.com/users/openfaas","html_url":"https://github.com/openfaas","followers_url":"https://api.github.com/users/openfaas/followers","following_url":"https://api.github.com/users/openfaas/following{/other_user}","gists_url":"https://api.github.com/users/openfaas/gists{/gist_id}","starred_url":"https://api.github.com/users/openfaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfaas/subscriptions","organizations_url":"https://api.github.com/users/openfaas/orgs","repos_url":"https://api.github.com/users/openfaas/repos","events_url":"https://api.github.com/users/openfaas/events{/privacy}","received_events_url":"https://api.github.com/users/openfaas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openfaas/faas-netes","description":"Serverless Kubernetes with OpenFaaS (Functions as a Service)","fork":false,"url":"https://api.github.com/repos/openfaas/faas-netes","forks_url":"https://api.github.com/repos/openfaas/faas-netes/forks","keys_url":"https://api.github.com/repos/openfaas/faas-netes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfaas/faas-netes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfaas/faas-netes/teams","hooks_url":"https://api.github.com/repos/openfaas/faas-netes/hooks","issue_events_url":"https://api.github.com/repos/openfaas/faas-netes/issues/events{/number}","events_url":"https://api.github.com/repos/openfaas/faas-netes/events","assignees_url":"https://api.github.com/repos/openfaas/faas-netes/assignees{/user}","branches_url":"https://api.github.com/repos/openfaas/faas-netes/branches{/branch}","tags_url":"https://api.github.com/repos/openfaas/faas-netes/tags","blobs_url":"https://api.github.com/repos/openfaas/faas-netes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfaas/faas-netes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfaas/faas-netes/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfaas/faas-netes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfaas/faas-netes/statuses/{sha}","languages_url":"https://api.github.com/repos/openfaas/faas-netes/languages","stargazers_url":"https://api.github.com/repos/openfaas/faas-netes/stargazers","contributors_url":"https://api.github.com/repos/openfaas/faas-netes/contributors","subscribers_url":"https://api.github.com/repos/openfaas/faas-netes/subscribers","subscription_url":"https://api.github.com/repos/openfaas/faas-netes/subscription","commits_url":"https://api.github.com/repos/openfaas/faas-netes/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfaas/faas-netes/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfaas/faas-netes/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfaas/faas-netes/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfaas/faas-netes/contents/{+path}","compare_url":"https://api.github.com/repos/openfaas/faas-netes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfaas/faas-netes/merges","archive_url":"https://api.github.com/repos/openfaas/faas-netes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfaas/faas-netes/downloads","issues_url":"https://api.github.com/repos/openfaas/faas-netes/issues{/number}","pulls_url":"https://api.github.com/repos/openfaas/faas-netes/pulls{/number}","milestones_url":"https://api.github.com/repos/openfaas/faas-netes/milestones{/number}","notifications_url":"https://api.github.com/repos/openfaas/faas-netes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfaas/faas-netes/labels{/name}","releases_url":"https://api.github.com/repos/openfaas/faas-netes/releases{/id}","deployments_url":"https://api.github.com/repos/openfaas/faas-netes/deployments","created_at":"2017-07-23T19:03:06Z","updated_at":"2018-09-12T08:53:30Z","pushed_at":"2018-09-12T10:25:20Z","git_url":"git://github.com/openfaas/faas-netes.git","ssh_url":"git@github.com:openfaas/faas-netes.git","clone_url":"https://github.com/openfaas/faas-netes.git","svn_url":"https://github.com/openfaas/faas-netes","homepage":"https://github.com/openfaas/faas","size":4606,"stargazers_count":1126,"watchers_count":1126,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":135,"open_issues":27,"watchers":1126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openfaas/faas-netes/pulls/279"},"html":{"href":"https://github.com/openfaas/faas-netes/pull/279"},"issue":{"href":"https://api.github.com/repos/openfaas/faas-netes/issues/279"},"comments":{"href":"https://api.github.com/repos/openfaas/faas-netes/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/openfaas/faas-netes/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/openfaas/faas-netes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openfaas/faas-netes/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/openfaas/faas-netes/statuses/8de9dd3beafd55ce9ed9f9fd54af365659352941"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stefanprodan"}}