{"push_id":2769432561,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"284964f1179e1f55f24e56377f95274207f2ec23","before":"540fef1f6a07a92a4cdd7467bf1d8161bd683d88","commits":[{"sha":"0d8f87a6a3e8d64c85e53e288fb9a53c73868425","author":{"name":"Clayton Coleman","email":"4f499256fd2260f9682a9d9e63c3f1d668ee5cdf@redhat.com"},"message":"Break command and args in description by newline\n\nInline scripts may use newlines in these fields, and properly indenting makes the output more readable:\n\n```\n  Command:\n    /bin/bash\n    -c\n    #!/bin/bash\n    echo \"inline script should be indented\"\n```","distinct":true,"url":"https://api.github.com/repos/ii/kubernetes/commits/0d8f87a6a3e8d64c85e53e288fb9a53c73868425"},{"sha":"dca79aadddf7be2570f637302e3e020f43ca156b","author":{"name":"Clayton Coleman","email":"4f499256fd2260f9682a9d9e63c3f1d668ee5cdf@redhat.com"},"message":"Environment vars with newlines should be indented\n\nBreak env var values with newlines so they form a consistent left alignment.","distinct":true,"url":"https://api.github.com/repos/ii/kubernetes/commits/dca79aadddf7be2570f637302e3e020f43ca156b"},{"sha":"b8809dcd6772a892a8b4d4d6f10c9d0275a86aa4","author":{"name":"Clayton Coleman","email":"4f499256fd2260f9682a9d9e63c3f1d668ee5cdf@redhat.com"},"message":"Add tests for newline in command, arg, and env","distinct":true,"url":"https://api.github.com/repos/ii/kubernetes/commits/b8809dcd6772a892a8b4d4d6f10c9d0275a86aa4"},{"sha":"a23465426db94ef2008be94dff7c036b7d34fda8","author":{"name":"Clayton Coleman","email":"4f499256fd2260f9682a9d9e63c3f1d668ee5cdf@redhat.com"},"message":"Break annotations with newlines and shorten length\n\nMake annotations with newlines display a more consistent left edge, and indent the value\nwhen the annotation is too long to give the value more space. Shorten the width of the\ntrimmed annotation to a value more consistent with our `-o wide` value.\n\nInstead of putting the key and value flush with a `=` separator, make annotations closer\nto fields than to labels by using `: ` as a separator.","distinct":true,"url":"https://api.github.com/repos/ii/kubernetes/commits/a23465426db94ef2008be94dff7c036b7d34fda8"},{"sha":"284964f1179e1f55f24e56377f95274207f2ec23","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #66841 from smarterclayton/multiline\n\nAutomatic merge from submit-queue (batch tested with PRs 66911, 66841). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nMake kubectl describe more tolerant of newlines\n\nNewlines in the `command`, `args`, `env.value`, or `annotations` fields are not uncommon. Wrap and indent these fields so that describe is more readable.\r\n\r\nBefore:\r\n\r\n```\r\n    Host Port:     <none>\r\n    Command:\r\n      /bin/bash\r\n      -c\r\n      #!/bin/bash\r\nset -euo pipefail\r\n\r\n# set by the node image\r\nunset KUBECONFIG\r\n\r\ntrap 'kill $(jobs -p); exit 0' TERM\r\n\r\n# track the current state of the config\r\n```\r\n\r\nAfter:\r\n\r\n```\r\n    Host Port:     <none>\r\n    Command:\r\n      /bin/bash\r\n      -c\r\n      #!/bin/bash\r\n      set -euo pipefail\r\n\r\n      # set by the node image\r\n      unset KUBECONFIG\r\n\r\n      trap 'kill $(jobs -p); exit 0' TERM\r\n\r\n      # track the current state of the config\r\n```\r\n\r\nAnnotations when wrapping:\r\n\r\n```\r\nAnnotations:  kubectl.kubernetes.io/desired-replicas: 1\r\n              openshift.io/deployer-pod.completed-at: 2018-07-31 22:47:15 +0000 UTC\r\n              openshift.io/deployer-pod.created-at: 2018-07-31 22:37:11 +0000 UTC\r\n              openshift.io/deployer-pod.name: test-3-deploy\r\n              openshift.io/deployment-config.latest-version: 3\r\n              openshift.io/deployment-config.name: test\r\n              openshift.io/deployment.phase: Failed\r\n              openshift.io/deployment.replicas: 0\r\n              openshift.io/deployment.status-reason: manual change\r\n              openshift.io/encoded-deployment-config:\r\n                {\"kind\":\"DeploymentConfig\",\"apiVersion\":\"apps.openshift.io/v1\",\"metadata\":{\"name\":\"test\",\"namespace\":\"clayton-dev\",\"selfLink\":\"/apis/apps.op...\r\n```\r\n\r\n```release-note\r\nHandle newlines for `command`, `args`, `env`, and `annotations` in `kubectl describe` wrapping\r\n```","distinct":true,"url":"https://api.github.com/repos/ii/kubernetes/commits/284964f1179e1f55f24e56377f95274207f2ec23"}]}
{"actor":{"display_login":"hh"}}