{"action":"created","comment":{"url":"https://api.github.com/repos/scalacenter/bloop/pulls/comments/174525449","pull_request_review_id":103898448,"id":174525449,"diff_hunk":"@@ -73,12 +73,23 @@ object PluginImplementation {\n       val aggregates = project.aggregate.map(agg => makeName(agg.project, configuration))\n       val dependenciesAndAggregates = dependencies ++ aggregates\n \n+      val bloopConfigDir = BloopKeys.bloopConfigDir.value\n       val scalaName = \"scala-compiler\"\n       val scalaVersion = Keys.scalaVersion.value\n       val scalaOrg = Keys.ivyScala.value.map(_.scalaOrganization).getOrElse(\"org.scala-lang\")\n       val allScalaJars = Keys.scalaInstance.value.allJars.map(_.getAbsoluteFile)\n       val classpath = PluginDefaults.emulateDependencyClasspath.value.map(_.getAbsoluteFile)\n-      val classesDir = Keys.classDirectory.value.getAbsoluteFile\n+      val bloopTarget = Defaults.makeCrossTarget(\n+        bloopConfigDir,\n+        Keys.scalaBinaryVersion.value,\n+        (Keys.sbtBinaryVersion in Keys.pluginCrossBuild).value,\n+        Keys.sbtPlugin.value,\n+        Keys.crossPaths.value\n+      )\n+\n+      val classesDir = bloopTarget / (Defaults.prefix(configuration.name) + \"classes\")","path":"integrations/sbt-bloop/src/main/scala/bloop/integrations/sbt/SbtBloop.scala","position":28,"original_position":28,"commit_id":"44ce89877b8cbcc2cb94a1c117116a06cbf1116a","original_commit_id":"44ce89877b8cbcc2cb94a1c117116a06cbf1116a","user":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"body":"Will the classes directories live in `.bloop/` or in some nested directory? I would like to be able to easily remove all `classes` directories without removing `.bloop/*.config` files","created_at":"2018-03-14T16:34:52Z","updated_at":"2018-03-14T16:34:53Z","html_url":"https://github.com/scalacenter/bloop/pull/348#discussion_r174525449","pull_request_url":"https://api.github.com/repos/scalacenter/bloop/pulls/348","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/comments/174525449"},"html":{"href":"https://github.com/scalacenter/bloop/pull/348#discussion_r174525449"},"pull_request":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/348"}}},"pull_request":{"url":"https://api.github.com/repos/scalacenter/bloop/pulls/348","id":175006921,"html_url":"https://github.com/scalacenter/bloop/pull/348","diff_url":"https://github.com/scalacenter/bloop/pull/348.diff","patch_url":"https://github.com/scalacenter/bloop/pull/348.patch","issue_url":"https://api.github.com/repos/scalacenter/bloop/issues/348","number":348,"state":"open","locked":false,"title":"Use different classes directory than sbt","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars0.githubusercontent.com/u/2462974?v=4","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/scalacenter/bloop/issues/344.\n\nWe don't do what the ticket describes yet because that's something left\nfor the future. So far, reusing the `.bloop` directory (which should\nalready be in .gitignore) for the target makes sense.\n\nIn the future, we'll get the sbt integration to talk to the bsp server\nof bloop and compile to that directory, making the experience of\nswitching from sbt to bloop and back and forth smooth.","created_at":"2018-03-14T16:10:51Z","updated_at":"2018-03-14T16:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1500c2683156c78da19072e1968505dfe6c4c1c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":747209081,"url":"https://api.github.com/repos/scalacenter/bloop/labels/enhancement","name":"enhancement","color":"76fcb0","default":true},{"id":785624098,"url":"https://api.github.com/repos/scalacenter/bloop/labels/integrations","name":"integrations","color":"fbca04","default":false},{"id":867028252,"url":"https://api.github.com/repos/scalacenter/bloop/labels/workflow","name":"workflow","color":"dd54a4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scalacenter/bloop/pulls/348/commits","review_comments_url":"https://api.github.com/repos/scalacenter/bloop/pulls/348/comments","review_comment_url":"https://api.github.com/repos/scalacenter/bloop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalacenter/bloop/issues/348/comments","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/44ce89877b8cbcc2cb94a1c117116a06cbf1116a","head":{"label":"scalacenter:ticket/344","ref":"ticket/344","sha":"44ce89877b8cbcc2cb94a1c117116a06cbf1116a","user":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":110334159,"name":"bloop","full_name":"scalacenter/bloop","owner":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalacenter/bloop","description":"A hot bloop for your productivity","fork":false,"url":"https://api.github.com/repos/scalacenter/bloop","forks_url":"https://api.github.com/repos/scalacenter/bloop/forks","keys_url":"https://api.github.com/repos/scalacenter/bloop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/bloop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/bloop/teams","hooks_url":"https://api.github.com/repos/scalacenter/bloop/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/bloop/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/bloop/events","assignees_url":"https://api.github.com/repos/scalacenter/bloop/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/bloop/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/bloop/tags","blobs_url":"https://api.github.com/repos/scalacenter/bloop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/bloop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/bloop/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/bloop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/bloop/languages","stargazers_url":"https://api.github.com/repos/scalacenter/bloop/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/bloop/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/bloop/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/bloop/subscription","commits_url":"https://api.github.com/repos/scalacenter/bloop/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/bloop/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/bloop/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/bloop/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/bloop/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/bloop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/bloop/merges","archive_url":"https://api.github.com/repos/scalacenter/bloop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/bloop/downloads","issues_url":"https://api.github.com/repos/scalacenter/bloop/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/bloop/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/bloop/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/bloop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/bloop/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/bloop/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/bloop/deployments","created_at":"2017-11-11T09:39:34Z","updated_at":"2018-03-14T15:51:37Z","pushed_at":"2018-03-14T16:28:03Z","git_url":"git://github.com/scalacenter/bloop.git","ssh_url":"git@github.com:scalacenter/bloop.git","clone_url":"https://github.com/scalacenter/bloop.git","svn_url":"https://github.com/scalacenter/bloop","homepage":"https://scalacenter.github.io/bloop/","size":2789,"stargazers_count":152,"watchers_count":152,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":51,"watchers":152,"default_branch":"master"}},"base":{"label":"scalacenter:master","ref":"master","sha":"072b2fe908970658d112db844d0062eb4c0ee596","user":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":110334159,"name":"bloop","full_name":"scalacenter/bloop","owner":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalacenter/bloop","description":"A hot bloop for your productivity","fork":false,"url":"https://api.github.com/repos/scalacenter/bloop","forks_url":"https://api.github.com/repos/scalacenter/bloop/forks","keys_url":"https://api.github.com/repos/scalacenter/bloop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/bloop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/bloop/teams","hooks_url":"https://api.github.com/repos/scalacenter/bloop/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/bloop/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/bloop/events","assignees_url":"https://api.github.com/repos/scalacenter/bloop/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/bloop/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/bloop/tags","blobs_url":"https://api.github.com/repos/scalacenter/bloop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/bloop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/bloop/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/bloop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/bloop/languages","stargazers_url":"https://api.github.com/repos/scalacenter/bloop/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/bloop/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/bloop/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/bloop/subscription","commits_url":"https://api.github.com/repos/scalacenter/bloop/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/bloop/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/bloop/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/bloop/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/bloop/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/bloop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/bloop/merges","archive_url":"https://api.github.com/repos/scalacenter/bloop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/bloop/downloads","issues_url":"https://api.github.com/repos/scalacenter/bloop/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/bloop/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/bloop/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/bloop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/bloop/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/bloop/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/bloop/deployments","created_at":"2017-11-11T09:39:34Z","updated_at":"2018-03-14T15:51:37Z","pushed_at":"2018-03-14T16:28:03Z","git_url":"git://github.com/scalacenter/bloop.git","ssh_url":"git@github.com:scalacenter/bloop.git","clone_url":"https://github.com/scalacenter/bloop.git","svn_url":"https://github.com/scalacenter/bloop","homepage":"https://scalacenter.github.io/bloop/","size":2789,"stargazers_count":152,"watchers_count":152,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":51,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/348"},"html":{"href":"https://github.com/scalacenter/bloop/pull/348"},"issue":{"href":"https://api.github.com/repos/scalacenter/bloop/issues/348"},"comments":{"href":"https://api.github.com/repos/scalacenter/bloop/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/scalacenter/bloop/statuses/44ce89877b8cbcc2cb94a1c117116a06cbf1116a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"olafurpg"}}