{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript-TmLanguage/issues/588","repository_url":"https://api.github.com/repos/Microsoft/TypeScript-TmLanguage","labels_url":"https://api.github.com/repos/Microsoft/TypeScript-TmLanguage/issues/588/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript-TmLanguage/issues/588/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript-TmLanguage/issues/588/events","html_url":"https://github.com/Microsoft/TypeScript-TmLanguage/pull/588","id":307944036,"number":588,"title":"Add s (single line) flag to js/ts regex","user":{"login":"Titansmasher","id":7736591,"avatar_url":"https://avatars0.githubusercontent.com/u/7736591?v=4","gravatar_id":"","url":"https://api.github.com/users/Titansmasher","html_url":"https://github.com/Titansmasher","followers_url":"https://api.github.com/users/Titansmasher/followers","following_url":"https://api.github.com/users/Titansmasher/following{/other_user}","gists_url":"https://api.github.com/users/Titansmasher/gists{/gist_id}","starred_url":"https://api.github.com/users/Titansmasher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Titansmasher/subscriptions","organizations_url":"https://api.github.com/users/Titansmasher/orgs","repos_url":"https://api.github.com/users/Titansmasher/repos","events_url":"https://api.github.com/users/Titansmasher/events{/privacy}","received_events_url":"https://api.github.com/users/Titansmasher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-23T08:45:56Z","updated_at":"2018-03-23T20:29:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript-TmLanguage/pulls/588","html_url":"https://github.com/Microsoft/TypeScript-TmLanguage/pull/588","diff_url":"https://github.com/Microsoft/TypeScript-TmLanguage/pull/588.diff","patch_url":"https://github.com/Microsoft/TypeScript-TmLanguage/pull/588.patch"},"body":"While not in the js/ts documentation, Chrome 64.0.3282.186 and Node 8.9.4 do support the `s` regex flag, as well as it being a suggested flag for [regex101](https://regex101.com). I feel that these are popular enough to justify adding it to the styling for the js/ts extensions.\r\nI have tested IE, Edge and Firefox, however none of them appear to support the `s` flag.\r\n\r\nI originally made this as a [PR for vscode](https://github.com/Microsoft/vscode/pull/46358) and was directed to this one"},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript-TmLanguage/issues/comments/375789241","html_url":"https://github.com/Microsoft/TypeScript-TmLanguage/pull/588#issuecomment-375789241","issue_url":"https://api.github.com/repos/Microsoft/TypeScript-TmLanguage/issues/588","id":375789241,"user":{"login":"Titansmasher","id":7736591,"avatar_url":"https://avatars0.githubusercontent.com/u/7736591?v=4","gravatar_id":"","url":"https://api.github.com/users/Titansmasher","html_url":"https://github.com/Titansmasher","followers_url":"https://api.github.com/users/Titansmasher/followers","following_url":"https://api.github.com/users/Titansmasher/following{/other_user}","gists_url":"https://api.github.com/users/Titansmasher/gists{/gist_id}","starred_url":"https://api.github.com/users/Titansmasher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Titansmasher/subscriptions","organizations_url":"https://api.github.com/users/Titansmasher/orgs","repos_url":"https://api.github.com/users/Titansmasher/repos","events_url":"https://api.github.com/users/Titansmasher/events{/privacy}","received_events_url":"https://api.github.com/users/Titansmasher/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T20:29:17Z","updated_at":"2018-03-23T20:29:17Z","author_association":"NONE","body":"In the test case for #346 (the one that is failing) if you replace the `s` character with a `g`,`i`,`m`,`u` or `y` then the same issue that was originally documented in #346 will occur. \r\n```javascript\r\nfor (let i = 0; i < b.length; i++) b[i] = Math.sin(TAU440 * t++^^/s * Math.sin(t++^^/s*.5))\r\n```\r\nto\r\n```javascript\r\nfor (let i = 0; i < b.length; i++) b[i] = Math.sin(TAU440 * t++^^/s * Math.sin(t++^^/g*.5))\r\n```\r\nI dont think this introduces a new issue, rather accidentally highlighted an existing one. I dont feel I have the knowledge to be able to fix that underlying issue, should I open up a bug report for that and submit the `s` flag as a suggestion instead?"}}
{"actor":{"display_login":"Titansmasher"}}