{"action":"created","issue":{"url":"https://api.github.com/repos/James-Yu/LaTeX-Workshop/issues/848","repository_url":"https://api.github.com/repos/James-Yu/LaTeX-Workshop","labels_url":"https://api.github.com/repos/James-Yu/LaTeX-Workshop/issues/848/labels{/name}","comments_url":"https://api.github.com/repos/James-Yu/LaTeX-Workshop/issues/848/comments","events_url":"https://api.github.com/repos/James-Yu/LaTeX-Workshop/issues/848/events","html_url":"https://github.com/James-Yu/LaTeX-Workshop/pull/848","id":366833994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDExNTY2","number":848,"title":"Merge latex-utilities with LaTeX-Workshop","user":{"login":"viktorstrate","id":4233458,"node_id":"MDQ6VXNlcjQyMzM0NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4233458?v=4","gravatar_id":"","url":"https://api.github.com/users/viktorstrate","html_url":"https://github.com/viktorstrate","followers_url":"https://api.github.com/users/viktorstrate/followers","following_url":"https://api.github.com/users/viktorstrate/following{/other_user}","gists_url":"https://api.github.com/users/viktorstrate/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorstrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorstrate/subscriptions","organizations_url":"https://api.github.com/users/viktorstrate/orgs","repos_url":"https://api.github.com/users/viktorstrate/repos","events_url":"https://api.github.com/users/viktorstrate/events{/privacy}","received_events_url":"https://api.github.com/users/viktorstrate/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-04T15:01:44Z","updated_at":"2018-10-06T15:35:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/James-Yu/LaTeX-Workshop/pulls/848","html_url":"https://github.com/James-Yu/LaTeX-Workshop/pull/848","diff_url":"https://github.com/James-Yu/LaTeX-Workshop/pull/848.diff","patch_url":"https://github.com/James-Yu/LaTeX-Workshop/pull/848.patch"},"body":"> This pull request is a result of the discussions in issue #841\r\n\r\nThis pull request currently merges the code from [latex-utilities](https://github.com/viktorstrate/vscode-latex-utilities) which handles shortcuts for keywords like `\\textbf`, `\\textit`, `\\underline`.\r\n\r\nFor latex-utilities to be fully merged, we should find a solution to automatically add `\\item` when enter is pressed. But I think @jlelong is working on that, on the 'item' branch, see #847.\r\n\r\n### I've updated the yarn.lock\r\nI have also regenerated the yarn.lock, as I could not download all the packages, because my version of node was too new. Below is the output before I updated the file. I haven't thoroughly tested the extension though.\r\n\r\n```\r\nyarn install v1.10.1\r\n[1/5] 🔍  Validating package.json...\r\nwarning latex-workshop@5.10.2: The engine \"vscode\" appears to be invalid.\r\n[2/5] 🔍  Resolving packages...\r\n[3/5] 🚚  Fetching packages...\r\nerror upath@1.0.4: The engine \"node\" is incompatible with this module. Expected version \">=4 <=9\". Got \"10.11.0\"\r\nerror Found incompatible module\r\n```"},"comment":{"url":"https://api.github.com/repos/James-Yu/LaTeX-Workshop/issues/comments/427583336","html_url":"https://github.com/James-Yu/LaTeX-Workshop/pull/848#issuecomment-427583336","issue_url":"https://api.github.com/repos/James-Yu/LaTeX-Workshop/issues/848","id":427583336,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzU4MzMzNg==","user":{"login":"viktorstrate","id":4233458,"node_id":"MDQ6VXNlcjQyMzM0NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4233458?v=4","gravatar_id":"","url":"https://api.github.com/users/viktorstrate","html_url":"https://github.com/viktorstrate","followers_url":"https://api.github.com/users/viktorstrate/followers","following_url":"https://api.github.com/users/viktorstrate/following{/other_user}","gists_url":"https://api.github.com/users/viktorstrate/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorstrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorstrate/subscriptions","organizations_url":"https://api.github.com/users/viktorstrate/orgs","repos_url":"https://api.github.com/users/viktorstrate/repos","events_url":"https://api.github.com/users/viktorstrate/events{/privacy}","received_events_url":"https://api.github.com/users/viktorstrate/received_events","type":"User","site_admin":false},"created_at":"2018-10-06T15:35:44Z","updated_at":"2018-10-06T15:35:44Z","author_association":"NONE","body":"I have merged with master and fixed removing of tags with nested tags inside.\r\n\r\nThe code doesn't search further than the current line. If it finds a tag that is not closed off on the same line, then the closing bracket will not be removed. And if the cursor is inside a tag that is opened on a previous line, then it will not register it, and theirfore add a new tag.\r\n\r\nI do not want to search the whole file for tags as it might be slow, but maybe an incremental approach could be used to check previous lines, only if it sees a dangling end bracket, or check the next lines, if `getLongestBalancedString` doesn't find the matching bracket."}}
{"actor":{"display_login":"viktorstrate"}}