{"action":"closed","issue":{"url":"https://api.github.com/repos/nasa-gibs/worldview-components/issues/50","repository_url":"https://api.github.com/repos/nasa-gibs/worldview-components","labels_url":"https://api.github.com/repos/nasa-gibs/worldview-components/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/nasa-gibs/worldview-components/issues/50/comments","events_url":"https://api.github.com/repos/nasa-gibs/worldview-components/issues/50/events","html_url":"https://github.com/nasa-gibs/worldview-components/issues/50","id":318732305,"node_id":"MDU6SXNzdWUzMTg3MzIzMDU=","number":50,"title":"Remove set ids from reusable components","user":{"login":"Benjaki2","id":3605988,"node_id":"MDQ6VXNlcjM2MDU5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/3605988?v=4","gravatar_id":"","url":"https://api.github.com/users/Benjaki2","html_url":"https://github.com/Benjaki2","followers_url":"https://api.github.com/users/Benjaki2/followers","following_url":"https://api.github.com/users/Benjaki2/following{/other_user}","gists_url":"https://api.github.com/users/Benjaki2/gists{/gist_id}","starred_url":"https://api.github.com/users/Benjaki2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benjaki2/subscriptions","organizations_url":"https://api.github.com/users/Benjaki2/orgs","repos_url":"https://api.github.com/users/Benjaki2/repos","events_url":"https://api.github.com/users/Benjaki2/events{/privacy}","received_events_url":"https://api.github.com/users/Benjaki2/received_events","type":"User","site_admin":false},"labels":[{"id":421352872,"node_id":"MDU6TGFiZWw0MjEzNTI4NzI=","url":"https://api.github.com/repos/nasa-gibs/worldview-components/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":{"login":"Benjaki2","id":3605988,"node_id":"MDQ6VXNlcjM2MDU5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/3605988?v=4","gravatar_id":"","url":"https://api.github.com/users/Benjaki2","html_url":"https://github.com/Benjaki2","followers_url":"https://api.github.com/users/Benjaki2/followers","following_url":"https://api.github.com/users/Benjaki2/following{/other_user}","gists_url":"https://api.github.com/users/Benjaki2/gists{/gist_id}","starred_url":"https://api.github.com/users/Benjaki2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benjaki2/subscriptions","organizations_url":"https://api.github.com/users/Benjaki2/orgs","repos_url":"https://api.github.com/users/Benjaki2/repos","events_url":"https://api.github.com/users/Benjaki2/events{/privacy}","received_events_url":"https://api.github.com/users/Benjaki2/received_events","type":"User","site_admin":false},"assignees":[{"login":"Benjaki2","id":3605988,"node_id":"MDQ6VXNlcjM2MDU5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/3605988?v=4","gravatar_id":"","url":"https://api.github.com/users/Benjaki2","html_url":"https://github.com/Benjaki2","followers_url":"https://api.github.com/users/Benjaki2/followers","following_url":"https://api.github.com/users/Benjaki2/following{/other_user}","gists_url":"https://api.github.com/users/Benjaki2/gists{/gist_id}","starred_url":"https://api.github.com/users/Benjaki2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benjaki2/subscriptions","organizations_url":"https://api.github.com/users/Benjaki2/orgs","repos_url":"https://api.github.com/users/Benjaki2/repos","events_url":"https://api.github.com/users/Benjaki2/events{/privacy}","received_events_url":"https://api.github.com/users/Benjaki2/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-04-29T16:59:57Z","updated_at":"2018-06-26T20:37:09Z","closed_at":"2018-06-26T20:37:09Z","author_association":"CONTRIBUTOR","body":"### Description\r\nID's are meant to be unique so reusable components should not set IDs unless props are passed. Date selectors components currently have the same same ID's all over the app so they are not good selectors.\r\n ### How to fix\r\nreplace `id={this.props.type + '-input-group'}`\r\nhttps://github.com/nasa-gibs/worldview-components/blob/master/src/scripts/components/date-selector/input.js#L236\r\nwith `id={(this.props.id) ? this.props.id : ''}`"}}
{"actor":{"display_login":"minniewong"}}