{"action":"closed","issue":{"url":"https://api.github.com/repos/YuriiSalimov/NTC_Thermistor/issues/2","repository_url":"https://api.github.com/repos/YuriiSalimov/NTC_Thermistor","labels_url":"https://api.github.com/repos/YuriiSalimov/NTC_Thermistor/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/YuriiSalimov/NTC_Thermistor/issues/2/comments","events_url":"https://api.github.com/repos/YuriiSalimov/NTC_Thermistor/issues/2/events","html_url":"https://github.com/YuriiSalimov/NTC_Thermistor/issues/2","id":381937112,"node_id":"MDU6SXNzdWUzODE5MzcxMTI=","number":2,"title":"setReadingsNumber in constructor doesn't take the given parameter","user":{"login":"akonings","id":6292086,"node_id":"MDQ6VXNlcjYyOTIwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/6292086?v=4","gravatar_id":"","url":"https://api.github.com/users/akonings","html_url":"https://github.com/akonings","followers_url":"https://api.github.com/users/akonings/followers","following_url":"https://api.github.com/users/akonings/following{/other_user}","gists_url":"https://api.github.com/users/akonings/gists{/gist_id}","starred_url":"https://api.github.com/users/akonings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akonings/subscriptions","organizations_url":"https://api.github.com/users/akonings/orgs","repos_url":"https://api.github.com/users/akonings/repos","events_url":"https://api.github.com/users/akonings/events{/privacy}","received_events_url":"https://api.github.com/users/akonings/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-18T07:43:56Z","updated_at":"2018-11-20T21:15:20Z","closed_at":"2018-11-20T21:15:20Z","author_association":"NONE","body":"\r\nHi Yuri,\r\n\r\nI came across your NTC library, and I liked it, because a lot of nasty calculations on NTC's is handled by it. But I ran across one litle thing; which is a result of a typo I think.\r\n\r\nPlease have a look at class function setReadmingsNumber, which takes a parameter newReadingsNumber.\r\nThe validate function is called with the class variable readingsNumber; which isn't initialized at that moment yet. \r\nIn my setup the library worked great when I corrected the typo: \r\n\r\nBefore:\r\nvoid NTC_Thermistor::setReadingsNumber(const int newReadingsNumber) {\r\n\tthis->readingsNumber = validate(readingsNumber, NTC_DEFAULT_READINGS_NUMBER);\r\n}\r\n\r\n( you see that newReadingsNumber parameter isn't used in the function ! ) \r\n\r\nAfter:\r\nvoid NTC_Thermistor::setReadingsNumber(const int newReadingsNumber) {\r\n\tthis->readingsNumber = validate(newReadingsNumber, NTC_DEFAULT_READINGS_NUMBER);\r\n}\r\n\r\nBecause readingsNumber is the name of the class variable; the compiler doesn't give an error.\r\n\r\nHope this  helps you,\r\n\r\nRegards, \r\n\r\nArian.\r\n"}}
{"actor":{"display_login":"YuriiSalimov"}}