{"action":"created","issue":{"url":"https://api.github.com/repos/line/armeria/issues/1246","repository_url":"https://api.github.com/repos/line/armeria","labels_url":"https://api.github.com/repos/line/armeria/issues/1246/labels{/name}","comments_url":"https://api.github.com/repos/line/armeria/issues/1246/comments","events_url":"https://api.github.com/repos/line/armeria/issues/1246/events","html_url":"https://github.com/line/armeria/pull/1246","id":329361778,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjM0NzA4","number":1246,"title":"Only compute advertised encodings header once since it doesn't change.","user":{"login":"anuraaga","id":198344,"node_id":"MDQ6VXNlcjE5ODM0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/198344?v=4","gravatar_id":"","url":"https://api.github.com/users/anuraaga","html_url":"https://github.com/anuraaga","followers_url":"https://api.github.com/users/anuraaga/followers","following_url":"https://api.github.com/users/anuraaga/following{/other_user}","gists_url":"https://api.github.com/users/anuraaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anuraaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuraaga/subscriptions","organizations_url":"https://api.github.com/users/anuraaga/orgs","repos_url":"https://api.github.com/users/anuraaga/repos","events_url":"https://api.github.com/users/anuraaga/events{/privacy}","received_events_url":"https://api.github.com/users/anuraaga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-05T08:57:18Z","updated_at":"2018-06-05T09:29:20Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/1246","html_url":"https://github.com/line/armeria/pull/1246","diff_url":"https://github.com/line/armeria/pull/1246.diff","patch_url":"https://github.com/line/armeria/pull/1246.patch"},"body":"The advertised encodings of a server or client are constant throughout multiple calls, so we don't need to do slightly expensive computation of the header string every time.\r\n\r\nJust a micro-optimization\r\n\r\nAfter (only 1 fork isn't enough for a reliable measurement)\r\n```\r\nBenchmark                                           (clientType)   Mode  Cnt      Score     Error  Units\r\nc.l.a.g.downstream.DownstreamSimpleBenchmark.empty        OKHTTP  thrpt   20  17927.598 ± 670.447  ops/s\r\nc.l.a.g.upstream.UpstreamSimpleBenchmark.empty            OKHTTP  thrpt   20  22614.173 ± 705.504  ops/s\r\n```\r\n\r\nBefore\r\n```\r\nBenchmark                                           (clientType)   Mode  Cnt      Score      Error  Units\r\nc.l.a.g.downstream.DownstreamSimpleBenchmark.empty        OKHTTP  thrpt   20  17344.866 ±  568.339  ops/s\r\nc.l.a.g.upstream.UpstreamSimpleBenchmark.empty            OKHTTP  thrpt   20  21301.553 ± 1204.546  ops/s\r\n```"},"comment":{"url":"https://api.github.com/repos/line/armeria/issues/comments/394644286","html_url":"https://github.com/line/armeria/pull/1246#issuecomment-394644286","issue_url":"https://api.github.com/repos/line/armeria/issues/1246","id":394644286,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDY0NDI4Ng==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-05T09:29:20Z","updated_at":"2018-06-05T09:29:20Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/line/armeria/pull/1246?src=pr&el=h1) Report\n> Merging [#1246](https://codecov.io/gh/line/armeria/pull/1246?src=pr&el=desc) into [master](https://codecov.io/gh/line/armeria/commit/b3b0f27baf99ca957d072a0b15d4f1a90ce17c0d?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `83.33%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/line/armeria/pull/1246/graphs/tree.svg?token=3lXj2zLDWu&src=pr&height=150&width=650)](https://codecov.io/gh/line/armeria/pull/1246?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1246      +/-   ##\n==========================================\n+ Coverage   72.45%   72.46%   +<.01%     \n==========================================\n  Files         552      552              \n  Lines       23991    23992       +1     \n  Branches     2923     2923              \n==========================================\n+ Hits        17383    17386       +3     \n+ Misses       5080     5077       -3     \n- Partials     1528     1529       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/line/armeria/pull/1246?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...m/linecorp/armeria/client/grpc/ArmeriaChannel.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Z3JwYy9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL2NsaWVudC9ncnBjL0FybWVyaWFDaGFubmVsLmphdmE=) | `97.5% <100%> (+0.13%)` | :arrow_up: |\n| [.../com/linecorp/armeria/server/grpc/GrpcService.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Z3JwYy9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL3NlcnZlci9ncnBjL0dycGNTZXJ2aWNlLmphdmE=) | `94.73% <100%> (+0.07%)` | :arrow_up: |\n| [...inecorp/armeria/client/grpc/ArmeriaClientCall.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Z3JwYy9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL2NsaWVudC9ncnBjL0FybWVyaWFDbGllbnRDYWxsLmphdmE=) | `77.77% <75%> (-0.19%)` | :arrow_down: |\n| [...inecorp/armeria/server/grpc/ArmeriaServerCall.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Z3JwYy9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL3NlcnZlci9ncnBjL0FybWVyaWFTZXJ2ZXJDYWxsLmphdmE=) | `85.18% <75%> (-0.07%)` | :arrow_down: |\n| [...com/linecorp/armeria/internal/grpc/GrpcStatus.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Z3JwYy9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL2ludGVybmFsL2dycGMvR3JwY1N0YXR1cy5qYXZh) | `32.14% <0%> (-7.15%)` | :arrow_down: |\n| [...om/linecorp/armeria/client/HttpClientDelegate.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL2NsaWVudC9IdHRwQ2xpZW50RGVsZWdhdGUuamF2YQ==) | `79.76% <0%> (-2.39%)` | :arrow_down: |\n| [.../linecorp/armeria/internal/Http1ObjectEncoder.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL2ludGVybmFsL0h0dHAxT2JqZWN0RW5jb2Rlci5qYXZh) | `61.69% <0%> (-1.5%)` | :arrow_down: |\n| [...com/linecorp/armeria/server/HttpServerHandler.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL3NlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `77.44% <0%> (+0.33%)` | :arrow_up: |\n| [...corp/armeria/common/logging/DefaultRequestLog.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL2NvbW1vbi9sb2dnaW5nL0RlZmF1bHRSZXF1ZXN0TG9nLmphdmE=) | `81.31% <0%> (+0.75%)` | :arrow_up: |\n| [...corp/armeria/common/stream/FixedStreamMessage.java](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5lY29ycC9hcm1lcmlhL2NvbW1vbi9zdHJlYW0vRml4ZWRTdHJlYW1NZXNzYWdlLmphdmE=) | `92.85% <0%> (+1.78%)` | :arrow_up: |\n| ... and [3 more](https://codecov.io/gh/line/armeria/pull/1246/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/line/armeria/pull/1246?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/line/armeria/pull/1246?src=pr&el=footer). Last update [b3b0f27...49145b0](https://codecov.io/gh/line/armeria/pull/1246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}