{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66041","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66041/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66041/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66041/events","html_url":"https://github.com/kubernetes/kubernetes/pull/66041","id":340014006,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTI5MTM2","number":66041,"title":"Remove manually written typed registries","user":{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-07-10T21:29:54Z","updated_at":"2018-07-13T13:57:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66041","html_url":"https://github.com/kubernetes/kubernetes/pull/66041","diff_url":"https://github.com/kubernetes/kubernetes/pull/66041.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66041.patch"},"body":"These were only used in a handful of places, and were not consistently available for all types.\r\n\r\nThey add a lot of call sites for PRs like https://github.com/kubernetes/kubernetes/pull/65105 and are not generally useful (very few callers have the ability to construct the underlying store).\r\n\r\nThis PR switches the scale subresources to use the underlying store directly (like the status subresources already were), and removes the manually written Registry impls.\r\n\r\n/sig api-machinery\r\n/kind cleanup\r\n/assign @deads2k\r\n\r\n/hold\r\nwill hold for https://github.com/kubernetes/kubernetes/pull/65105 and rebase after that\r\n\r\n```release-note\r\nNONE\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/404841097","html_url":"https://github.com/kubernetes/kubernetes/pull/66041#issuecomment-404841097","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66041","id":404841097,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDg0MTA5Nw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T13:57:11Z","updated_at":"2018-07-13T13:57:11Z","author_association":"COLLABORATOR","body":"@liggitt: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-test | c6747091531eb7dd78a4387ad9e7fb08c3deee4f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66041/pull-kubernetes-bazel-test/52312/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-kops-aws | c6747091531eb7dd78a4387ad9e7fb08c3deee4f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66041/pull-kubernetes-e2e-kops-aws/96719/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-verify | c6747091531eb7dd78a4387ad9e7fb08c3deee4f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66041/pull-kubernetes-verify/98335/) | `/test pull-kubernetes-verify`\npull-kubernetes-typecheck | 1a43e9b18031a299c3558a8528fe40345107c32a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66041/pull-kubernetes-typecheck/17118/) | `/test pull-kubernetes-typecheck`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/66041). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liggitt). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}