{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/1024","repository_url":"https://api.github.com/repos/alphagov/govuk-frontend","labels_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/1024/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/1024/comments","events_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/1024/events","html_url":"https://github.com/alphagov/govuk-frontend/pull/1024","id":367541333,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTM5NjA2","number":1024,"title":"Add important parameter to visually hidden sass mixins","user":{"login":"David-Way","id":6078452,"node_id":"MDQ6VXNlcjYwNzg0NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6078452?v=4","gravatar_id":"","url":"https://api.github.com/users/David-Way","html_url":"https://github.com/David-Way","followers_url":"https://api.github.com/users/David-Way/followers","following_url":"https://api.github.com/users/David-Way/following{/other_user}","gists_url":"https://api.github.com/users/David-Way/gists{/gist_id}","starred_url":"https://api.github.com/users/David-Way/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/David-Way/subscriptions","organizations_url":"https://api.github.com/users/David-Way/orgs","repos_url":"https://api.github.com/users/David-Way/repos","events_url":"https://api.github.com/users/David-Way/events{/privacy}","received_events_url":"https://api.github.com/users/David-Way/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-07T10:30:45Z","updated_at":"2018-10-16T15:54:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/pulls/1024","html_url":"https://github.com/alphagov/govuk-frontend/pull/1024","diff_url":"https://github.com/alphagov/govuk-frontend/pull/1024.diff","patch_url":"https://github.com/alphagov/govuk-frontend/pull/1024.patch"},"body":"Closes #997\r\n\r\n# Proposed changes\r\n- Optional parameter added to `govuk-visually-hidden` and `govuk-visually-hidden-focusable` mixins (defaults to true)"},"comment":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/comments/430292871","html_url":"https://github.com/alphagov/govuk-frontend/pull/1024#issuecomment-430292871","issue_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/1024","id":430292871,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDI5Mjg3MQ==","user":{"login":"igloosi","id":3758555,"node_id":"MDQ6VXNlcjM3NTg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3758555?v=4","gravatar_id":"","url":"https://api.github.com/users/igloosi","html_url":"https://github.com/igloosi","followers_url":"https://api.github.com/users/igloosi/followers","following_url":"https://api.github.com/users/igloosi/following{/other_user}","gists_url":"https://api.github.com/users/igloosi/gists{/gist_id}","starred_url":"https://api.github.com/users/igloosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igloosi/subscriptions","organizations_url":"https://api.github.com/users/igloosi/orgs","repos_url":"https://api.github.com/users/igloosi/repos","events_url":"https://api.github.com/users/igloosi/events{/privacy}","received_events_url":"https://api.github.com/users/igloosi/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T15:54:42Z","updated_at":"2018-10-16T15:54:42Z","author_association":"CONTRIBUTOR","body":"Hi David, i've tried to push a rebase to your branch, but do not have access rights.\r\nYou might need to allow contributors on the forked repository in its `/settings/collaboration`\r\n\r\nAlternatively, if you prefer to drop [this commit](https://github.com/alphagov/govuk-frontend/pull/1024/commits/06cdf65e78e5e4170755f78d34745617e5861957) and fixup [this](https://github.com/alphagov/govuk-frontend/pull/1024/commits/12472e627ed28ce371465a18f1d2f1344ab2955d) to the [first one](https://github.com/alphagov/govuk-frontend/pull/1024/commits/dc4a46a9daf2413f6e80038471c3d0f75b2a3b31) we'll be all set. \r\n\r\nAbove can be done by [rebasing](https://git-scm.com/docs/git-rebase) current 4 commits with \r\n`git rebase head~4 --interactive`\r\n\r\nDoing above would, you would end up with \r\n```\r\npick dc4a46a9 Add important parameter to govuk-visually-hidden and govuk-visually-hidden-focusable mixins\r\nfixup 12472e62 Undo un-needed package changes\r\npick 8f94319f Update changelog\r\ndrop 06cdf65e Visually hidden important parameters default to false\r\n```\r\nsaving that and finishing rebase and finally pushing to the branch with `git push --force-with-lease`\r\n"}}
{"actor":{"display_login":"igloosi"}}