{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58282","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58282/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58282/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58282/events","html_url":"https://github.com/kubernetes/kubernetes/pull/58282","id":288553257,"number":58282,"title":"Invoke preStart RPC call before container start, if desired by plugin","user":{"login":"vikaschoudhary16","id":11936386,"avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"labels":[{"id":644163893,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/hw-accelerators","name":"area/hw-accelerators","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493665,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"mindprince","id":695290,"avatar_url":"https://avatars2.githubusercontent.com/u/695290?v=4","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},"assignees":[{"login":"mindprince","id":695290,"avatar_url":"https://avatars2.githubusercontent.com/u/695290?v=4","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},{"login":"RenaudWasTaken","id":2519571,"avatar_url":"https://avatars1.githubusercontent.com/u/2519571?v=4","gravatar_id":"","url":"https://api.github.com/users/RenaudWasTaken","html_url":"https://github.com/RenaudWasTaken","followers_url":"https://api.github.com/users/RenaudWasTaken/followers","following_url":"https://api.github.com/users/RenaudWasTaken/following{/other_user}","gists_url":"https://api.github.com/users/RenaudWasTaken/gists{/gist_id}","starred_url":"https://api.github.com/users/RenaudWasTaken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RenaudWasTaken/subscriptions","organizations_url":"https://api.github.com/users/RenaudWasTaken/orgs","repos_url":"https://api.github.com/users/RenaudWasTaken/repos","events_url":"https://api.github.com/users/RenaudWasTaken/events{/privacy}","received_events_url":"https://api.github.com/users/RenaudWasTaken/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"avatar_url":"https://avatars2.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"milestone":null,"comments":38,"created_at":"2018-01-15T10:52:50Z","updated_at":"2018-02-08T11:41:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58282","html_url":"https://github.com/kubernetes/kubernetes/pull/58282","diff_url":"https://github.com/kubernetes/kubernetes/pull/58282.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/58282.patch"},"body":"**What this PR does / why we need it**:\r\n1. Adds a new RPC `preStart` to device plugin API\r\n2. Update `Register` RPC handling to receive a flag from the Device plugins as an indicator if kubelet should invoke `preStart` RPC before starting container.\r\n3. Changes in device manager to invoke `preStart` before container start\r\n4. Test case updates\r\n\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #56943 #56307 \r\n\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNone\r\n```\r\n/sig node\r\n\r\n/area hw-accelerators\r\n/cc @jiayingz @RenaudWasTaken @vishh @ScorpioCPH @sjenning @derekwaynecarr @jeremyeder @lichuqiang @tengqm \r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/364086587","html_url":"https://github.com/kubernetes/kubernetes/pull/58282#issuecomment-364086587","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58282","id":364086587,"user":{"login":"vikaschoudhary16","id":11936386,"avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T11:41:11Z","updated_at":"2018-02-08T11:41:11Z","author_association":"MEMBER","body":"/retest"}}
{"actor":{"display_login":"vikaschoudhary16"}}