{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaWeb/HttpServer.jl/issues/138","repository_url":"https://api.github.com/repos/JuliaWeb/HttpServer.jl","labels_url":"https://api.github.com/repos/JuliaWeb/HttpServer.jl/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/JuliaWeb/HttpServer.jl/issues/138/comments","events_url":"https://api.github.com/repos/JuliaWeb/HttpServer.jl/issues/138/events","html_url":"https://github.com/JuliaWeb/HttpServer.jl/pull/138","id":330995418,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODQyMTk5","number":138,"title":"More progress toward v0.7","user":{"login":"rdeits","id":591886,"node_id":"MDQ6VXNlcjU5MTg4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/591886?v=4","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-06-10T19:27:02Z","updated_at":"2018-06-14T14:18:01Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JuliaWeb/HttpServer.jl/pulls/138","html_url":"https://github.com/JuliaWeb/HttpServer.jl/pull/138","diff_url":"https://github.com/JuliaWeb/HttpServer.jl/pull/138.diff","patch_url":"https://github.com/JuliaWeb/HttpServer.jl/pull/138.patch"},"body":"@MikeInnes this is a PR against the branch from #135 \r\n\r\nI got most of the way towards making the tests work until I realized that the tests themselves require Requests.jl which is deprecated and not currently working on v0.7. I'm not sure what the path forward is: HTTP.jl has similar functionality to Requests, but that's a totally separate ecosystem, right? \r\n\r\nAnyway, assuming the tests can be fixed, I did the following: \r\n* Switched from FactCheck to (Base.)Test, since FactCheck is broken on v0.7 and no longer necessary\r\n* Got rid of the `initcbs()` function entirely. As far as I can tell there's no reason to defer generating those callbacks until `run()` is called. Does `initcbs` predate the existence of module `__init__()` functions? I also changed from doing a `global const` inside the function (which wasn't actually const in v0.6 and is disallowed in v0.7+) to setting a global const `Ref`."},"comment":{"url":"https://api.github.com/repos/JuliaWeb/HttpServer.jl/issues/comments/397312424","html_url":"https://github.com/JuliaWeb/HttpServer.jl/pull/138#issuecomment-397312424","issue_url":"https://api.github.com/repos/JuliaWeb/HttpServer.jl/issues/138","id":397312424,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzMxMjQyNA==","user":{"login":"quinnj","id":2896623,"node_id":"MDQ6VXNlcjI4OTY2MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2896623?v=4","gravatar_id":"","url":"https://api.github.com/users/quinnj","html_url":"https://github.com/quinnj","followers_url":"https://api.github.com/users/quinnj/followers","following_url":"https://api.github.com/users/quinnj/following{/other_user}","gists_url":"https://api.github.com/users/quinnj/gists{/gist_id}","starred_url":"https://api.github.com/users/quinnj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinnj/subscriptions","organizations_url":"https://api.github.com/users/quinnj/orgs","repos_url":"https://api.github.com/users/quinnj/repos","events_url":"https://api.github.com/users/quinnj/events{/privacy}","received_events_url":"https://api.github.com/users/quinnj/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T14:18:01Z","updated_at":"2018-06-14T14:18:01Z","author_association":"CONTRIBUTOR","body":"Some progress here: https://github.com/JuliaWeb/Mux.jl/pull/57"}}
{"actor":{"display_login":"quinnj"}}