{"action":"created","issue":{"url":"https://api.github.com/repos/eBay/ebayui-core/issues/433","repository_url":"https://api.github.com/repos/eBay/ebayui-core","labels_url":"https://api.github.com/repos/eBay/ebayui-core/issues/433/labels{/name}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/issues/433/comments","events_url":"https://api.github.com/repos/eBay/ebayui-core/issues/433/events","html_url":"https://github.com/eBay/ebayui-core/pull/433","id":367016456,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNTUzMzM4","number":433,"title":"Carousel: Sizing & Native scroll animation","user":{"login":"DylanPiercey","id":4985201,"node_id":"MDQ6VXNlcjQ5ODUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false},"labels":[{"id":941360706,"node_id":"MDU6TGFiZWw5NDEzNjA3MDY=","url":"https://api.github.com/repos/eBay/ebayui-core/labels/squash:%20YES%20please","name":"squash: YES please","color":"2cbe4e","default":false}],"state":"open","locked":false,"assignee":{"login":"DylanPiercey","id":4985201,"node_id":"MDQ6VXNlcjQ5ODUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false},"assignees":[{"login":"DylanPiercey","id":4985201,"node_id":"MDQ6VXNlcjQ5ODUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-10-05T00:21:49Z","updated_at":"2018-10-11T18:05:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eBay/ebayui-core/pulls/433","html_url":"https://github.com/eBay/ebayui-core/pull/433","diff_url":"https://github.com/eBay/ebayui-core/pull/433.diff","patch_url":"https://github.com/eBay/ebayui-core/pull/433.patch"},"body":"## Description\r\nIf desired I can separate these out into two PR's.\r\n\r\n1. switched to using `width` instead of `flex-basis` to size `carousel-items`. This resolves #431 with no apparent change in appearance.\r\n\r\n2. added an additional timeout to the `onScrollEnd` handler. Chrome doesn't seem to be working properly with the previous 1 animation frame polling, not sure if this is something that has changed recently but causes the scroll animation to start too early.\r\n\r\n# Details\r\n\r\nFor the timeout change I just noticed while fixing #431 that this was happening. This could be what is causing #432 and I will confirm with @scttdavs.\r\n\r\n## References\r\nfixes #431"},"comment":{"url":"https://api.github.com/repos/eBay/ebayui-core/issues/comments/429060196","html_url":"https://github.com/eBay/ebayui-core/pull/433#issuecomment-429060196","issue_url":"https://api.github.com/repos/eBay/ebayui-core/issues/433","id":429060196,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTA2MDE5Ng==","user":{"login":"ianmcburnie","id":38065,"node_id":"MDQ6VXNlcjM4MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T18:05:36Z","updated_at":"2018-10-11T18:05:36Z","author_association":"MEMBER","body":"Maybe switching to using width instead of flex-basis can be applied as a modifier/attribute if we are worried about it breaking touch scrolling?"}}
{"actor":{"display_login":"ianmcburnie"}}