{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/readinglists-extension-safari/issues/5","repository_url":"https://api.github.com/repos/wikimedia/readinglists-extension-safari","labels_url":"https://api.github.com/repos/wikimedia/readinglists-extension-safari/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/readinglists-extension-safari/issues/5/comments","events_url":"https://api.github.com/repos/wikimedia/readinglists-extension-safari/issues/5/events","html_url":"https://github.com/wikimedia/readinglists-extension-safari/pull/5","id":327809834,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTEzODkw","number":5,"title":"Moved most of the cookie and network interaction to the injected page","user":{"login":"berndsi","id":1875419,"node_id":"MDQ6VXNlcjE4NzU0MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1875419?v=4","gravatar_id":"","url":"https://api.github.com/users/berndsi","html_url":"https://github.com/berndsi","followers_url":"https://api.github.com/users/berndsi/followers","following_url":"https://api.github.com/users/berndsi/following{/other_user}","gists_url":"https://api.github.com/users/berndsi/gists{/gist_id}","starred_url":"https://api.github.com/users/berndsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndsi/subscriptions","organizations_url":"https://api.github.com/users/berndsi/orgs","repos_url":"https://api.github.com/users/berndsi/repos","events_url":"https://api.github.com/users/berndsi/events{/privacy}","received_events_url":"https://api.github.com/users/berndsi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-30T16:38:22Z","updated_at":"2018-05-30T20:58:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wikimedia/readinglists-extension-safari/pulls/5","html_url":"https://github.com/wikimedia/readinglists-extension-safari/pull/5","diff_url":"https://github.com/wikimedia/readinglists-extension-safari/pull/5.diff","patch_url":"https://github.com/wikimedia/readinglists-extension-safari/pull/5.patch"},"body":"When \"keep me logged in\" was not used during log in, the session cookie\r\nis not accessible in the global page. By moving the network request to\r\nfetch the CSRF token to the injected/content page (popups.js) this\r\nworks now.\r\n\r\nSo, the structure is more like this:\r\n* global page: for UI + I18N\r\n* injected page: network requests + DOM handling of current wiki page\r\n\r\nBetween those messages have to be dispatched. Care has to be taken that\r\nonly simple, cloneable objects are passed with the message as message\r\ndata.\r\n\r\nBug: T191998"},"comment":{"url":"https://api.github.com/repos/wikimedia/readinglists-extension-safari/issues/comments/393317298","html_url":"https://github.com/wikimedia/readinglists-extension-safari/pull/5#issuecomment-393317298","issue_url":"https://api.github.com/repos/wikimedia/readinglists-extension-safari/issues/5","id":393317298,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzMxNzI5OA==","user":{"login":"mdholloway","id":6295242,"node_id":"MDQ6VXNlcjYyOTUyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6295242?v=4","gravatar_id":"","url":"https://api.github.com/users/mdholloway","html_url":"https://github.com/mdholloway","followers_url":"https://api.github.com/users/mdholloway/followers","following_url":"https://api.github.com/users/mdholloway/following{/other_user}","gists_url":"https://api.github.com/users/mdholloway/gists{/gist_id}","starred_url":"https://api.github.com/users/mdholloway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdholloway/subscriptions","organizations_url":"https://api.github.com/users/mdholloway/orgs","repos_url":"https://api.github.com/users/mdholloway/repos","events_url":"https://api.github.com/users/mdholloway/events{/privacy}","received_events_url":"https://api.github.com/users/mdholloway/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T20:58:50Z","updated_at":"2018-05-30T20:58:50Z","author_association":"MEMBER","body":"This PR allows me to save exactly one page in the case where I don't check \"keep me logged in\" and have \"prevent cross-site tracking\" checked in the privacy settings.  Then after clicking a link I'm logged out.  And if I uncheck \"prevent cross-site tracking,\" then I can keep navigating and saving pages.  So we're on the right track!  Nice find on those docs/writeups.\r\n\r\nI wonder if the remaining issues are because of the i18n message fetch that's still happening in `popup.js`, in the function `geti18nMessages`."}}
{"actor":{"display_login":"mdholloway"}}