{"action":"created","comment":{"url":"https://api.github.com/repos/thumbor/thumbor/pulls/comments/187820676","pull_request_review_id":119675153,"id":187820676,"diff_hunk":"@@ -15,20 +15,28 @@\n \n from thumbor.optimizers import BaseOptimizer\n from thumbor.utils import logger\n+from os.path import exists\n \n \n class Optimizer(BaseOptimizer):\n \n     def should_run(self, image_extension, buffer):\n-        return 'gif' in image_extension and 'gifv' in self.context.request.filters\n+        if 'gif' in image_extension and 'gifv' in self.context.request.filters:\n+            if not exists(self.context.config.FFMPEG_PATH):\n+                logger.warn(\n+                    'gifv optimize enabled but binary JPEGTRAN_PATH does not exist')","path":"thumbor/optimizers/gifv.py","position":14,"original_position":14,"commit_id":"05a2a99b013f1d33c165049b11500f7a15d19930","original_commit_id":"05a2a99b013f1d33c165049b11500f7a15d19930","user":{"login":"heynemann","id":60965,"avatar_url":"https://avatars2.githubusercontent.com/u/60965?v=4","gravatar_id":"","url":"https://api.github.com/users/heynemann","html_url":"https://github.com/heynemann","followers_url":"https://api.github.com/users/heynemann/followers","following_url":"https://api.github.com/users/heynemann/following{/other_user}","gists_url":"https://api.github.com/users/heynemann/gists{/gist_id}","starred_url":"https://api.github.com/users/heynemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heynemann/subscriptions","organizations_url":"https://api.github.com/users/heynemann/orgs","repos_url":"https://api.github.com/users/heynemann/repos","events_url":"https://api.github.com/users/heynemann/events{/privacy}","received_events_url":"https://api.github.com/users/heynemann/received_events","type":"User","site_admin":false},"body":"Also gifv optimizeR, instead of optimize.","created_at":"2018-05-14T01:19:32Z","updated_at":"2018-05-14T01:19:32Z","html_url":"https://github.com/thumbor/thumbor/pull/1065#discussion_r187820676","pull_request_url":"https://api.github.com/repos/thumbor/thumbor/pulls/1065","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/comments/187820676"},"html":{"href":"https://github.com/thumbor/thumbor/pull/1065#discussion_r187820676"},"pull_request":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/1065"}},"in_reply_to_id":187820656},"pull_request":{"url":"https://api.github.com/repos/thumbor/thumbor/pulls/1065","id":187584381,"html_url":"https://github.com/thumbor/thumbor/pull/1065","diff_url":"https://github.com/thumbor/thumbor/pull/1065.diff","patch_url":"https://github.com/thumbor/thumbor/pull/1065.patch","issue_url":"https://api.github.com/repos/thumbor/thumbor/issues/1065","number":1065,"state":"open","locked":false,"title":"Defensive code to run optimizers","user":{"login":"caeugusmao","id":2955469,"avatar_url":"https://avatars0.githubusercontent.com/u/2955469?v=4","gravatar_id":"","url":"https://api.github.com/users/caeugusmao","html_url":"https://github.com/caeugusmao","followers_url":"https://api.github.com/users/caeugusmao/followers","following_url":"https://api.github.com/users/caeugusmao/following{/other_user}","gists_url":"https://api.github.com/users/caeugusmao/gists{/gist_id}","starred_url":"https://api.github.com/users/caeugusmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caeugusmao/subscriptions","organizations_url":"https://api.github.com/users/caeugusmao/orgs","repos_url":"https://api.github.com/users/caeugusmao/repos","events_url":"https://api.github.com/users/caeugusmao/events{/privacy}","received_events_url":"https://api.github.com/users/caeugusmao/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-11T22:35:35Z","updated_at":"2018-05-14T01:19:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa909d0785bbf3520be662907393176d0dfb5875","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thumbor/thumbor/pulls/1065/commits","review_comments_url":"https://api.github.com/repos/thumbor/thumbor/pulls/1065/comments","review_comment_url":"https://api.github.com/repos/thumbor/thumbor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thumbor/thumbor/issues/1065/comments","statuses_url":"https://api.github.com/repos/thumbor/thumbor/statuses/05a2a99b013f1d33c165049b11500f7a15d19930","head":{"label":"caeugusmao:housekeeping","ref":"housekeeping","sha":"05a2a99b013f1d33c165049b11500f7a15d19930","user":{"login":"caeugusmao","id":2955469,"avatar_url":"https://avatars0.githubusercontent.com/u/2955469?v=4","gravatar_id":"","url":"https://api.github.com/users/caeugusmao","html_url":"https://github.com/caeugusmao","followers_url":"https://api.github.com/users/caeugusmao/followers","following_url":"https://api.github.com/users/caeugusmao/following{/other_user}","gists_url":"https://api.github.com/users/caeugusmao/gists{/gist_id}","starred_url":"https://api.github.com/users/caeugusmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caeugusmao/subscriptions","organizations_url":"https://api.github.com/users/caeugusmao/orgs","repos_url":"https://api.github.com/users/caeugusmao/repos","events_url":"https://api.github.com/users/caeugusmao/events{/privacy}","received_events_url":"https://api.github.com/users/caeugusmao/received_events","type":"User","site_admin":false},"repo":{"id":133042937,"name":"thumbor","full_name":"caeugusmao/thumbor","owner":{"login":"caeugusmao","id":2955469,"avatar_url":"https://avatars0.githubusercontent.com/u/2955469?v=4","gravatar_id":"","url":"https://api.github.com/users/caeugusmao","html_url":"https://github.com/caeugusmao","followers_url":"https://api.github.com/users/caeugusmao/followers","following_url":"https://api.github.com/users/caeugusmao/following{/other_user}","gists_url":"https://api.github.com/users/caeugusmao/gists{/gist_id}","starred_url":"https://api.github.com/users/caeugusmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caeugusmao/subscriptions","organizations_url":"https://api.github.com/users/caeugusmao/orgs","repos_url":"https://api.github.com/users/caeugusmao/repos","events_url":"https://api.github.com/users/caeugusmao/events{/privacy}","received_events_url":"https://api.github.com/users/caeugusmao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caeugusmao/thumbor","description":"thumbor is an open-source photo thumbnail service by globo.com","fork":true,"url":"https://api.github.com/repos/caeugusmao/thumbor","forks_url":"https://api.github.com/repos/caeugusmao/thumbor/forks","keys_url":"https://api.github.com/repos/caeugusmao/thumbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caeugusmao/thumbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caeugusmao/thumbor/teams","hooks_url":"https://api.github.com/repos/caeugusmao/thumbor/hooks","issue_events_url":"https://api.github.com/repos/caeugusmao/thumbor/issues/events{/number}","events_url":"https://api.github.com/repos/caeugusmao/thumbor/events","assignees_url":"https://api.github.com/repos/caeugusmao/thumbor/assignees{/user}","branches_url":"https://api.github.com/repos/caeugusmao/thumbor/branches{/branch}","tags_url":"https://api.github.com/repos/caeugusmao/thumbor/tags","blobs_url":"https://api.github.com/repos/caeugusmao/thumbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caeugusmao/thumbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caeugusmao/thumbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/caeugusmao/thumbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caeugusmao/thumbor/statuses/{sha}","languages_url":"https://api.github.com/repos/caeugusmao/thumbor/languages","stargazers_url":"https://api.github.com/repos/caeugusmao/thumbor/stargazers","contributors_url":"https://api.github.com/repos/caeugusmao/thumbor/contributors","subscribers_url":"https://api.github.com/repos/caeugusmao/thumbor/subscribers","subscription_url":"https://api.github.com/repos/caeugusmao/thumbor/subscription","commits_url":"https://api.github.com/repos/caeugusmao/thumbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/caeugusmao/thumbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/caeugusmao/thumbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/caeugusmao/thumbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/caeugusmao/thumbor/contents/{+path}","compare_url":"https://api.github.com/repos/caeugusmao/thumbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caeugusmao/thumbor/merges","archive_url":"https://api.github.com/repos/caeugusmao/thumbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caeugusmao/thumbor/downloads","issues_url":"https://api.github.com/repos/caeugusmao/thumbor/issues{/number}","pulls_url":"https://api.github.com/repos/caeugusmao/thumbor/pulls{/number}","milestones_url":"https://api.github.com/repos/caeugusmao/thumbor/milestones{/number}","notifications_url":"https://api.github.com/repos/caeugusmao/thumbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caeugusmao/thumbor/labels{/name}","releases_url":"https://api.github.com/repos/caeugusmao/thumbor/releases{/id}","deployments_url":"https://api.github.com/repos/caeugusmao/thumbor/deployments","created_at":"2018-05-11T13:26:41Z","updated_at":"2018-05-11T13:26:44Z","pushed_at":"2018-05-11T22:48:08Z","git_url":"git://github.com/caeugusmao/thumbor.git","ssh_url":"git@github.com:caeugusmao/thumbor.git","clone_url":"https://github.com/caeugusmao/thumbor.git","svn_url":"https://github.com/caeugusmao/thumbor","homepage":"http://thumbor.org","size":43174,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thumbor:master","ref":"master","sha":"991f13c9fb7c01fec47338b38ce3734819cbea36","user":{"login":"thumbor","id":6918711,"avatar_url":"https://avatars3.githubusercontent.com/u/6918711?v=4","gravatar_id":"","url":"https://api.github.com/users/thumbor","html_url":"https://github.com/thumbor","followers_url":"https://api.github.com/users/thumbor/followers","following_url":"https://api.github.com/users/thumbor/following{/other_user}","gists_url":"https://api.github.com/users/thumbor/gists{/gist_id}","starred_url":"https://api.github.com/users/thumbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thumbor/subscriptions","organizations_url":"https://api.github.com/users/thumbor/orgs","repos_url":"https://api.github.com/users/thumbor/repos","events_url":"https://api.github.com/users/thumbor/events{/privacy}","received_events_url":"https://api.github.com/users/thumbor/received_events","type":"Organization","site_admin":false},"repo":{"id":1488139,"name":"thumbor","full_name":"thumbor/thumbor","owner":{"login":"thumbor","id":6918711,"avatar_url":"https://avatars3.githubusercontent.com/u/6918711?v=4","gravatar_id":"","url":"https://api.github.com/users/thumbor","html_url":"https://github.com/thumbor","followers_url":"https://api.github.com/users/thumbor/followers","following_url":"https://api.github.com/users/thumbor/following{/other_user}","gists_url":"https://api.github.com/users/thumbor/gists{/gist_id}","starred_url":"https://api.github.com/users/thumbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thumbor/subscriptions","organizations_url":"https://api.github.com/users/thumbor/orgs","repos_url":"https://api.github.com/users/thumbor/repos","events_url":"https://api.github.com/users/thumbor/events{/privacy}","received_events_url":"https://api.github.com/users/thumbor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thumbor/thumbor","description":"thumbor is an open-source photo thumbnail service by globo.com","fork":false,"url":"https://api.github.com/repos/thumbor/thumbor","forks_url":"https://api.github.com/repos/thumbor/thumbor/forks","keys_url":"https://api.github.com/repos/thumbor/thumbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thumbor/thumbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thumbor/thumbor/teams","hooks_url":"https://api.github.com/repos/thumbor/thumbor/hooks","issue_events_url":"https://api.github.com/repos/thumbor/thumbor/issues/events{/number}","events_url":"https://api.github.com/repos/thumbor/thumbor/events","assignees_url":"https://api.github.com/repos/thumbor/thumbor/assignees{/user}","branches_url":"https://api.github.com/repos/thumbor/thumbor/branches{/branch}","tags_url":"https://api.github.com/repos/thumbor/thumbor/tags","blobs_url":"https://api.github.com/repos/thumbor/thumbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thumbor/thumbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thumbor/thumbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/thumbor/thumbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thumbor/thumbor/statuses/{sha}","languages_url":"https://api.github.com/repos/thumbor/thumbor/languages","stargazers_url":"https://api.github.com/repos/thumbor/thumbor/stargazers","contributors_url":"https://api.github.com/repos/thumbor/thumbor/contributors","subscribers_url":"https://api.github.com/repos/thumbor/thumbor/subscribers","subscription_url":"https://api.github.com/repos/thumbor/thumbor/subscription","commits_url":"https://api.github.com/repos/thumbor/thumbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/thumbor/thumbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/thumbor/thumbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/thumbor/thumbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/thumbor/thumbor/contents/{+path}","compare_url":"https://api.github.com/repos/thumbor/thumbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thumbor/thumbor/merges","archive_url":"https://api.github.com/repos/thumbor/thumbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thumbor/thumbor/downloads","issues_url":"https://api.github.com/repos/thumbor/thumbor/issues{/number}","pulls_url":"https://api.github.com/repos/thumbor/thumbor/pulls{/number}","milestones_url":"https://api.github.com/repos/thumbor/thumbor/milestones{/number}","notifications_url":"https://api.github.com/repos/thumbor/thumbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thumbor/thumbor/labels{/name}","releases_url":"https://api.github.com/repos/thumbor/thumbor/releases{/id}","deployments_url":"https://api.github.com/repos/thumbor/thumbor/deployments","created_at":"2011-03-16T17:30:05Z","updated_at":"2018-05-14T01:16:57Z","pushed_at":"2018-05-14T01:16:51Z","git_url":"git://github.com/thumbor/thumbor.git","ssh_url":"git@github.com:thumbor/thumbor.git","clone_url":"https://github.com/thumbor/thumbor.git","svn_url":"https://github.com/thumbor/thumbor","homepage":"http://thumbor.org","size":43163,"stargazers_count":5862,"watchers_count":5862,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":551,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":551,"open_issues":92,"watchers":5862,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/1065"},"html":{"href":"https://github.com/thumbor/thumbor/pull/1065"},"issue":{"href":"https://api.github.com/repos/thumbor/thumbor/issues/1065"},"comments":{"href":"https://api.github.com/repos/thumbor/thumbor/issues/1065/comments"},"review_comments":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/1065/comments"},"review_comment":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/1065/commits"},"statuses":{"href":"https://api.github.com/repos/thumbor/thumbor/statuses/05a2a99b013f1d33c165049b11500f7a15d19930"}},"author_association":"NONE"}}
{"actor":{"display_login":"heynemann"}}