{"action":"created","issue":{"url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/1061","repository_url":"https://api.github.com/repos/styleguidist/react-styleguidist","labels_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/1061/labels{/name}","comments_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/1061/comments","events_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/1061/events","html_url":"https://github.com/styleguidist/react-styleguidist/issues/1061","id":343631726,"node_id":"MDU6SXNzdWUzNDM2MzE3MjY=","number":1061,"title":"`react-docgen-displayname-handler` has a peerDependency of `recast`","user":{"login":"everdimension","id":5347023,"node_id":"MDQ6VXNlcjUzNDcwMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5347023?v=4","gravatar_id":"","url":"https://api.github.com/users/everdimension","html_url":"https://github.com/everdimension","followers_url":"https://api.github.com/users/everdimension/followers","following_url":"https://api.github.com/users/everdimension/following{/other_user}","gists_url":"https://api.github.com/users/everdimension/gists{/gist_id}","starred_url":"https://api.github.com/users/everdimension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everdimension/subscriptions","organizations_url":"https://api.github.com/users/everdimension/orgs","repos_url":"https://api.github.com/users/everdimension/repos","events_url":"https://api.github.com/users/everdimension/events{/privacy}","received_events_url":"https://api.github.com/users/everdimension/received_events","type":"User","site_admin":false},"labels":[{"id":257203239,"node_id":"MDU6TGFiZWwyNTcyMDMyMzk=","url":"https://api.github.com/repos/styleguidist/react-styleguidist/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":611120771,"node_id":"MDU6TGFiZWw2MTExMjA3NzE=","url":"https://api.github.com/repos/styleguidist/react-styleguidist/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true},{"id":257203242,"node_id":"MDU6TGFiZWwyNTcyMDMyNDI=","url":"https://api.github.com/repos/styleguidist/react-styleguidist/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-23T13:24:55Z","updated_at":"2018-07-31T19:04:27Z","closed_at":"2018-07-26T15:18:54Z","author_association":"CONTRIBUTOR","body":"**Current behavior**\r\n\r\n<!-- A clear and concise description of what the bug is -->\r\n\r\n`react-styleguidist` depends on `react-docgen-displayname-handler`, which, in turn, has a peerDependency on `recast`. I get an npm warning:\r\n\r\n```\r\nnpm WARN react-docgen-displayname-handler@2.1.0 requires a peer of recast@0.12.6 || 0.13.0 but none is installed. You must install peer dependencies yourself.\r\n```\r\n\r\n**Expected behavior**\r\n\r\n<!-- A clear and concise description of what you expected to happen -->\r\n`react-styleguidist` should list `recast` as a dependency."},"comment":{"url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/comments/409332859","html_url":"https://github.com/styleguidist/react-styleguidist/issues/1061#issuecomment-409332859","issue_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/1061","id":409332859,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTMzMjg1OQ==","user":{"login":"cwmacdon","id":957907,"node_id":"MDQ6VXNlcjk1NzkwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/957907?v=4","gravatar_id":"","url":"https://api.github.com/users/cwmacdon","html_url":"https://github.com/cwmacdon","followers_url":"https://api.github.com/users/cwmacdon/followers","following_url":"https://api.github.com/users/cwmacdon/following{/other_user}","gists_url":"https://api.github.com/users/cwmacdon/gists{/gist_id}","starred_url":"https://api.github.com/users/cwmacdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwmacdon/subscriptions","organizations_url":"https://api.github.com/users/cwmacdon/orgs","repos_url":"https://api.github.com/users/cwmacdon/repos","events_url":"https://api.github.com/users/cwmacdon/events{/privacy}","received_events_url":"https://api.github.com/users/cwmacdon/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T19:04:27Z","updated_at":"2018-07-31T19:04:27Z","author_association":"NONE","body":"Unfortunately this issue should probably be re-opened, as the peerDependency uses exact versions:\r\n\r\n`\"recast\": \"0.12.6 || 0.13.0\"`\r\n\r\nand the commit in this repo uses an inexact version:\r\n\r\n`\"recast\": \"^0.13.0\"`\r\n\r\nThis will install `0.13.2` which does not meet the peerDependency requirement :(\r\n"}}
{"actor":{"display_login":"cwmacdon"}}