{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/manifest/issues/555","repository_url":"https://api.github.com/repos/w3c/manifest","labels_url":"https://api.github.com/repos/w3c/manifest/issues/555/labels{/name}","comments_url":"https://api.github.com/repos/w3c/manifest/issues/555/comments","events_url":"https://api.github.com/repos/w3c/manifest/issues/555/events","html_url":"https://github.com/w3c/manifest/issues/555","id":207948136,"node_id":"MDU6SXNzdWUyMDc5NDgxMzY=","number":555,"title":"Icon shapes and masking","user":{"login":"owencm","id":279720,"node_id":"MDQ6VXNlcjI3OTcyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/279720?v=4","gravatar_id":"","url":"https://api.github.com/users/owencm","html_url":"https://github.com/owencm","followers_url":"https://api.github.com/users/owencm/followers","following_url":"https://api.github.com/users/owencm/following{/other_user}","gists_url":"https://api.github.com/users/owencm/gists{/gist_id}","starred_url":"https://api.github.com/users/owencm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owencm/subscriptions","organizations_url":"https://api.github.com/users/owencm/orgs","repos_url":"https://api.github.com/users/owencm/repos","events_url":"https://api.github.com/users/owencm/events{/privacy}","received_events_url":"https://api.github.com/users/owencm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-02-15T22:26:22Z","updated_at":"2018-07-25T00:43:10Z","closed_at":null,"author_association":"NONE","body":"I've been thinking about how Vanilla Android 7 has largely round icons (or at least some new Google-flavor Android does) and thus icons provided in the manifest, even with the `platform` property will look slightly strange on that OS. \r\n\r\nI heard some developer complain recently that they're not sure how to get the circular shape.\r\n\r\nTaking a broader view on this problem, Samsung has their own icon mask shape, Xiaomi have their own icon shape etc.\r\n\r\nThus I wonder if a better solution is to have sites provide their icon as a large square with sufficient padding around the edges and then have the browser apply a mask appropriate for the OS it's running on.\r\n\r\nNot sure how that could fit into the spec in terms of `platform` etc. Perhaps we could just use `platform: 'android_maskable'` or something, but wanted to raise it as an idea."},"comment":{"url":"https://api.github.com/repos/w3c/manifest/issues/comments/407596320","html_url":"https://github.com/w3c/manifest/issues/555#issuecomment-407596320","issue_url":"https://api.github.com/repos/w3c/manifest/issues/555","id":407596320,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzU5NjMyMA==","user":{"login":"mgiuca","id":228433,"node_id":"MDQ6VXNlcjIyODQzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/228433?v=4","gravatar_id":"","url":"https://api.github.com/users/mgiuca","html_url":"https://github.com/mgiuca","followers_url":"https://api.github.com/users/mgiuca/followers","following_url":"https://api.github.com/users/mgiuca/following{/other_user}","gists_url":"https://api.github.com/users/mgiuca/gists{/gist_id}","starred_url":"https://api.github.com/users/mgiuca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgiuca/subscriptions","organizations_url":"https://api.github.com/users/mgiuca/orgs","repos_url":"https://api.github.com/users/mgiuca/repos","events_url":"https://api.github.com/users/mgiuca/events{/privacy}","received_events_url":"https://api.github.com/users/mgiuca/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T00:43:10Z","updated_at":"2018-07-25T00:43:10Z","author_association":"COLLABORATOR","body":"@dominickng, @kenchris and I had a half-hour VC about this and came to a rough consensus for Option B. Meeting notes follow:\r\n\r\n- Ken/Matt: Worried about small players (e.g., new operating systems in the future) unable to enter the market to convince devs to add their platform-specific icons (under Option C). End up using iOS or Android icons, essentially ending up with apple-touch-icons all over again (or \"vendor prefixing\" used outside of the original vendor).\r\n- Dom: Already have a default icon.\r\n- Ken: Default icon is not good enough as a generic thing. Everybody wants a maskable icon of some kind. In the future we could add iOS specific icon in the future for top-tier polish.\r\n- Dom: Same argument would apply then. If we're going to add platform-specific icons in the future, why not just do it now?\r\n- Dom: Exposing the capability to map your icon to platform-specific form, but requiring transform.\r\n- Dom: If only developers who really care are providing the maskable icon, then this is a fine-tuning/tweaking capability, not for widespread use.\r\n- Matt: This isn't just for top 1% of developers; ideally this is accessible to all developers.\r\n- Ken: Developer tools (or Lighthouse, etc) can show you how your maskable icon will look on various major platforms. [Good idea: we should talk to Chrome devtools and/or Lighthouse.]\r\n- Dom: We should therefore push developers to maskable icons.\r\n- Matt: We should give equal weight to both the traditional and maskable icons (both are equally valid, depends on the brand; e.g. Gmail is a top-tier app that just doesn't make sense to have a maskable icon).\r\n- Dom: Option B takes control away from developers.\r\n- Matt: Giving control also means maintenance burden. If the underlying platform changes, we want developers protected from underlying platform changes in the future, not having to update their site every time Android changes, for example.\r\n- Dom: If we go with Option B, we would want non-normative text explaining the nuances, e.g., the border we would be injecting into the icon.\r\n- Vague resolution: Proceed with Ken's #657 (Option B). Matt and Dom to look over and suggest non-normative text that highlights some of the nuances of this discussion.\r\n\r\nThanks everybody!"}}
{"actor":{"display_login":"mgiuca"}}