{"action":"opened","number":948,"pull_request":{"url":"https://api.github.com/repos/facebook/folly/pulls/948","id":221641662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjQxNjYy","html_url":"https://github.com/facebook/folly/pull/948","diff_url":"https://github.com/facebook/folly/pull/948.diff","patch_url":"https://github.com/facebook/folly/pull/948.patch","issue_url":"https://api.github.com/repos/facebook/folly/issues/948","number":948,"state":"open","locked":false,"title":"Detect `std::launder` in libc++ 6 (and Xcode 10)","user":{"login":"paulrosania","id":1904,"node_id":"MDQ6VXNlcjE5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1904?v=4","gravatar_id":"","url":"https://api.github.com/users/paulrosania","html_url":"https://github.com/paulrosania","followers_url":"https://api.github.com/users/paulrosania/followers","following_url":"https://api.github.com/users/paulrosania/following{/other_user}","gists_url":"https://api.github.com/users/paulrosania/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrosania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrosania/subscriptions","organizations_url":"https://api.github.com/users/paulrosania/orgs","repos_url":"https://api.github.com/users/paulrosania/repos","events_url":"https://api.github.com/users/paulrosania/events{/privacy}","received_events_url":"https://api.github.com/users/paulrosania/received_events","type":"User","site_admin":false},"body":"Fixes #947.\r\n\r\nSummary:\r\n>libc++ 6+ (and Xcode 10's libc++, which seems to be based on it) adds std::launder, but does not define the __cpp_lib_launder feature-test macro. As a result, folly's lang/Launder.h concludes std::launder is missing and defines its own implementation. Since std::launder does actually exist, ADL causes 'ambiguous call' errors whenever a standard library type like std::pair is laundered within the folly namespace. (This breaks compilation of folly's futures, for example, and I believe it will cause compilation issues anywhere else F14Map is used, since it launders std::pair in its F14Policy.)","created_at":"2018-10-10T02:37:17Z","updated_at":"2018-10-10T02:37:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/folly/pulls/948/commits","review_comments_url":"https://api.github.com/repos/facebook/folly/pulls/948/comments","review_comment_url":"https://api.github.com/repos/facebook/folly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/folly/issues/948/comments","statuses_url":"https://api.github.com/repos/facebook/folly/statuses/9a453e9b9498aaff066500e9f49cc32788c35ee6","head":{"label":"paulrosania:libc++-6-launder","ref":"libc++-6-launder","sha":"9a453e9b9498aaff066500e9f49cc32788c35ee6","user":{"login":"paulrosania","id":1904,"node_id":"MDQ6VXNlcjE5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1904?v=4","gravatar_id":"","url":"https://api.github.com/users/paulrosania","html_url":"https://github.com/paulrosania","followers_url":"https://api.github.com/users/paulrosania/followers","following_url":"https://api.github.com/users/paulrosania/following{/other_user}","gists_url":"https://api.github.com/users/paulrosania/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrosania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrosania/subscriptions","organizations_url":"https://api.github.com/users/paulrosania/orgs","repos_url":"https://api.github.com/users/paulrosania/repos","events_url":"https://api.github.com/users/paulrosania/events{/privacy}","received_events_url":"https://api.github.com/users/paulrosania/received_events","type":"User","site_admin":false},"repo":{"id":148212378,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMTIzNzg=","name":"folly","full_name":"paulrosania/folly","private":false,"owner":{"login":"paulrosania","id":1904,"node_id":"MDQ6VXNlcjE5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1904?v=4","gravatar_id":"","url":"https://api.github.com/users/paulrosania","html_url":"https://github.com/paulrosania","followers_url":"https://api.github.com/users/paulrosania/followers","following_url":"https://api.github.com/users/paulrosania/following{/other_user}","gists_url":"https://api.github.com/users/paulrosania/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrosania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrosania/subscriptions","organizations_url":"https://api.github.com/users/paulrosania/orgs","repos_url":"https://api.github.com/users/paulrosania/repos","events_url":"https://api.github.com/users/paulrosania/events{/privacy}","received_events_url":"https://api.github.com/users/paulrosania/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paulrosania/folly","description":"An open-source C++ library developed and used at Facebook.","fork":true,"url":"https://api.github.com/repos/paulrosania/folly","forks_url":"https://api.github.com/repos/paulrosania/folly/forks","keys_url":"https://api.github.com/repos/paulrosania/folly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulrosania/folly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulrosania/folly/teams","hooks_url":"https://api.github.com/repos/paulrosania/folly/hooks","issue_events_url":"https://api.github.com/repos/paulrosania/folly/issues/events{/number}","events_url":"https://api.github.com/repos/paulrosania/folly/events","assignees_url":"https://api.github.com/repos/paulrosania/folly/assignees{/user}","branches_url":"https://api.github.com/repos/paulrosania/folly/branches{/branch}","tags_url":"https://api.github.com/repos/paulrosania/folly/tags","blobs_url":"https://api.github.com/repos/paulrosania/folly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulrosania/folly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulrosania/folly/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulrosania/folly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulrosania/folly/statuses/{sha}","languages_url":"https://api.github.com/repos/paulrosania/folly/languages","stargazers_url":"https://api.github.com/repos/paulrosania/folly/stargazers","contributors_url":"https://api.github.com/repos/paulrosania/folly/contributors","subscribers_url":"https://api.github.com/repos/paulrosania/folly/subscribers","subscription_url":"https://api.github.com/repos/paulrosania/folly/subscription","commits_url":"https://api.github.com/repos/paulrosania/folly/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulrosania/folly/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulrosania/folly/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulrosania/folly/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulrosania/folly/contents/{+path}","compare_url":"https://api.github.com/repos/paulrosania/folly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulrosania/folly/merges","archive_url":"https://api.github.com/repos/paulrosania/folly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulrosania/folly/downloads","issues_url":"https://api.github.com/repos/paulrosania/folly/issues{/number}","pulls_url":"https://api.github.com/repos/paulrosania/folly/pulls{/number}","milestones_url":"https://api.github.com/repos/paulrosania/folly/milestones{/number}","notifications_url":"https://api.github.com/repos/paulrosania/folly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulrosania/folly/labels{/name}","releases_url":"https://api.github.com/repos/paulrosania/folly/releases{/id}","deployments_url":"https://api.github.com/repos/paulrosania/folly/deployments","created_at":"2018-09-10T20:06:19Z","updated_at":"2018-10-10T02:26:30Z","pushed_at":"2018-10-10T02:33:01Z","git_url":"git://github.com/paulrosania/folly.git","ssh_url":"git@github.com:paulrosania/folly.git","clone_url":"https://github.com/paulrosania/folly.git","svn_url":"https://github.com/paulrosania/folly","homepage":"https://groups.google.com/forum/?fromgroups#!forum/facebook-folly","size":19578,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"c3afb202a361a4faa34092d7f9e04c00ce5fcb28","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":4524181,"node_id":"MDEwOlJlcG9zaXRvcnk0NTI0MTgx","name":"folly","full_name":"facebook/folly","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/folly","description":"An open-source C++ library developed and used at Facebook.","fork":false,"url":"https://api.github.com/repos/facebook/folly","forks_url":"https://api.github.com/repos/facebook/folly/forks","keys_url":"https://api.github.com/repos/facebook/folly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/folly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/folly/teams","hooks_url":"https://api.github.com/repos/facebook/folly/hooks","issue_events_url":"https://api.github.com/repos/facebook/folly/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/folly/events","assignees_url":"https://api.github.com/repos/facebook/folly/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/folly/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/folly/tags","blobs_url":"https://api.github.com/repos/facebook/folly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/folly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/folly/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/folly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/folly/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/folly/languages","stargazers_url":"https://api.github.com/repos/facebook/folly/stargazers","contributors_url":"https://api.github.com/repos/facebook/folly/contributors","subscribers_url":"https://api.github.com/repos/facebook/folly/subscribers","subscription_url":"https://api.github.com/repos/facebook/folly/subscription","commits_url":"https://api.github.com/repos/facebook/folly/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/folly/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/folly/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/folly/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/folly/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/folly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/folly/merges","archive_url":"https://api.github.com/repos/facebook/folly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/folly/downloads","issues_url":"https://api.github.com/repos/facebook/folly/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/folly/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/folly/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/folly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/folly/labels{/name}","releases_url":"https://api.github.com/repos/facebook/folly/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/folly/deployments","created_at":"2012-06-01T20:49:04Z","updated_at":"2018-10-10T01:37:24Z","pushed_at":"2018-10-10T01:37:19Z","git_url":"git://github.com/facebook/folly.git","ssh_url":"git@github.com:facebook/folly.git","clone_url":"https://github.com/facebook/folly.git","svn_url":"https://github.com/facebook/folly","homepage":"https://groups.google.com/forum/?fromgroups#!forum/facebook-folly","size":19927,"stargazers_count":11442,"watchers_count":11442,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2799,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2799,"open_issues":125,"watchers":11442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/folly/pulls/948"},"html":{"href":"https://github.com/facebook/folly/pull/948"},"issue":{"href":"https://api.github.com/repos/facebook/folly/issues/948"},"comments":{"href":"https://api.github.com/repos/facebook/folly/issues/948/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/folly/pulls/948/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/folly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/folly/pulls/948/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/folly/statuses/9a453e9b9498aaff066500e9f49cc32788c35ee6"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"paulrosania"}}