{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/raft-rs/pulls/comments/166967847","pull_request_review_id":95113142,"id":166967847,"diff_hunk":"@@ -0,0 +1,89 @@\n+syntax = \"proto3\";\n+package eraftpb;\n+\n+option java_package = \"com.pingcap.tikv.eraftpb\";","path":"proto/eraftpb.proto","position":4,"original_position":4,"commit_id":"94ea0e9e793a794264f688dfc366ed6e2b505672","original_commit_id":"94ea0e9e793a794264f688dfc366ed6e2b505672","user":{"login":"overvenus","id":2150711,"avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"I haven't found any reference to eraftpb in TiSpack.\r\nhttps://github.com/pingcap/tispark/search?utf8=%E2%9C%93&q=eraftpb&type=","created_at":"2018-02-08T15:23:46Z","updated_at":"2018-02-08T15:23:46Z","html_url":"https://github.com/pingcap/raft-rs/pull/28#discussion_r166967847","pull_request_url":"https://api.github.com/repos/pingcap/raft-rs/pulls/28","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/raft-rs/pulls/comments/166967847"},"html":{"href":"https://github.com/pingcap/raft-rs/pull/28#discussion_r166967847"},"pull_request":{"href":"https://api.github.com/repos/pingcap/raft-rs/pulls/28"}},"in_reply_to_id":166962299},"pull_request":{"url":"https://api.github.com/repos/pingcap/raft-rs/pulls/28","id":167612103,"html_url":"https://github.com/pingcap/raft-rs/pull/28","diff_url":"https://github.com/pingcap/raft-rs/pull/28.diff","patch_url":"https://github.com/pingcap/raft-rs/pull/28.patch","issue_url":"https://api.github.com/repos/pingcap/raft-rs/issues/28","number":28,"state":"open","locked":false,"title":"move eraftpb out of kvproto","user":{"login":"BusyJay","id":1701473,"avatar_url":"https://avatars3.githubusercontent.com/u/1701473?v=4","gravatar_id":"","url":"https://api.github.com/users/BusyJay","html_url":"https://github.com/BusyJay","followers_url":"https://api.github.com/users/BusyJay/followers","following_url":"https://api.github.com/users/BusyJay/following{/other_user}","gists_url":"https://api.github.com/users/BusyJay/gists{/gist_id}","starred_url":"https://api.github.com/users/BusyJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BusyJay/subscriptions","organizations_url":"https://api.github.com/users/BusyJay/orgs","repos_url":"https://api.github.com/users/BusyJay/repos","events_url":"https://api.github.com/users/BusyJay/events{/privacy}","received_events_url":"https://api.github.com/users/BusyJay/received_events","type":"User","site_admin":false},"body":"This pr move eraftpb from kvproto into this crate. So that we can drop the dependency of kvproto and grpc.\r\n\r\n/cc #1 ","created_at":"2018-02-07T06:56:48Z","updated_at":"2018-02-08T15:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62b55a97e0483f7d3f894771b8f30695dd2cf41d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Hoverbear","id":130903,"avatar_url":"https://avatars3.githubusercontent.com/u/130903?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoverbear","html_url":"https://github.com/Hoverbear","followers_url":"https://api.github.com/users/Hoverbear/followers","following_url":"https://api.github.com/users/Hoverbear/following{/other_user}","gists_url":"https://api.github.com/users/Hoverbear/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoverbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoverbear/subscriptions","organizations_url":"https://api.github.com/users/Hoverbear/orgs","repos_url":"https://api.github.com/users/Hoverbear/repos","events_url":"https://api.github.com/users/Hoverbear/events{/privacy}","received_events_url":"https://api.github.com/users/Hoverbear/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/raft-rs/pulls/28/commits","review_comments_url":"https://api.github.com/repos/pingcap/raft-rs/pulls/28/comments","review_comment_url":"https://api.github.com/repos/pingcap/raft-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/raft-rs/issues/28/comments","statuses_url":"https://api.github.com/repos/pingcap/raft-rs/statuses/94ea0e9e793a794264f688dfc366ed6e2b505672","head":{"label":"pingcap:busyjay/remove-kvproto","ref":"busyjay/remove-kvproto","sha":"94ea0e9e793a794264f688dfc366ed6e2b505672","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":114735865,"name":"raft-rs","full_name":"pingcap/raft-rs","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/raft-rs","description":"Raft distributed consensus algorithm implemented in Rust.","fork":false,"url":"https://api.github.com/repos/pingcap/raft-rs","forks_url":"https://api.github.com/repos/pingcap/raft-rs/forks","keys_url":"https://api.github.com/repos/pingcap/raft-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/raft-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/raft-rs/teams","hooks_url":"https://api.github.com/repos/pingcap/raft-rs/hooks","issue_events_url":"https://api.github.com/repos/pingcap/raft-rs/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/raft-rs/events","assignees_url":"https://api.github.com/repos/pingcap/raft-rs/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/raft-rs/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/raft-rs/tags","blobs_url":"https://api.github.com/repos/pingcap/raft-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/raft-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/raft-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/raft-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/raft-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/raft-rs/languages","stargazers_url":"https://api.github.com/repos/pingcap/raft-rs/stargazers","contributors_url":"https://api.github.com/repos/pingcap/raft-rs/contributors","subscribers_url":"https://api.github.com/repos/pingcap/raft-rs/subscribers","subscription_url":"https://api.github.com/repos/pingcap/raft-rs/subscription","commits_url":"https://api.github.com/repos/pingcap/raft-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/raft-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/raft-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/raft-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/raft-rs/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/raft-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/raft-rs/merges","archive_url":"https://api.github.com/repos/pingcap/raft-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/raft-rs/downloads","issues_url":"https://api.github.com/repos/pingcap/raft-rs/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/raft-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/raft-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/raft-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/raft-rs/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/raft-rs/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/raft-rs/deployments","created_at":"2017-12-19T07:56:10Z","updated_at":"2018-02-08T13:30:08Z","pushed_at":"2018-02-08T11:17:26Z","git_url":"git://github.com/pingcap/raft-rs.git","ssh_url":"git@github.com:pingcap/raft-rs.git","clone_url":"https://github.com/pingcap/raft-rs.git","svn_url":"https://github.com/pingcap/raft-rs","homepage":"","size":669,"stargazers_count":51,"watchers_count":51,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":9,"open_issues":19,"watchers":51,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"ca8feb3e31737ce6e15e4e3d85439e91dc161411","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":114735865,"name":"raft-rs","full_name":"pingcap/raft-rs","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/raft-rs","description":"Raft distributed consensus algorithm implemented in Rust.","fork":false,"url":"https://api.github.com/repos/pingcap/raft-rs","forks_url":"https://api.github.com/repos/pingcap/raft-rs/forks","keys_url":"https://api.github.com/repos/pingcap/raft-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/raft-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/raft-rs/teams","hooks_url":"https://api.github.com/repos/pingcap/raft-rs/hooks","issue_events_url":"https://api.github.com/repos/pingcap/raft-rs/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/raft-rs/events","assignees_url":"https://api.github.com/repos/pingcap/raft-rs/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/raft-rs/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/raft-rs/tags","blobs_url":"https://api.github.com/repos/pingcap/raft-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/raft-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/raft-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/raft-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/raft-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/raft-rs/languages","stargazers_url":"https://api.github.com/repos/pingcap/raft-rs/stargazers","contributors_url":"https://api.github.com/repos/pingcap/raft-rs/contributors","subscribers_url":"https://api.github.com/repos/pingcap/raft-rs/subscribers","subscription_url":"https://api.github.com/repos/pingcap/raft-rs/subscription","commits_url":"https://api.github.com/repos/pingcap/raft-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/raft-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/raft-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/raft-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/raft-rs/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/raft-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/raft-rs/merges","archive_url":"https://api.github.com/repos/pingcap/raft-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/raft-rs/downloads","issues_url":"https://api.github.com/repos/pingcap/raft-rs/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/raft-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/raft-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/raft-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/raft-rs/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/raft-rs/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/raft-rs/deployments","created_at":"2017-12-19T07:56:10Z","updated_at":"2018-02-08T13:30:08Z","pushed_at":"2018-02-08T11:17:26Z","git_url":"git://github.com/pingcap/raft-rs.git","ssh_url":"git@github.com:pingcap/raft-rs.git","clone_url":"https://github.com/pingcap/raft-rs.git","svn_url":"https://github.com/pingcap/raft-rs","homepage":"","size":669,"stargazers_count":51,"watchers_count":51,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":9,"open_issues":19,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/raft-rs/pulls/28"},"html":{"href":"https://github.com/pingcap/raft-rs/pull/28"},"issue":{"href":"https://api.github.com/repos/pingcap/raft-rs/issues/28"},"comments":{"href":"https://api.github.com/repos/pingcap/raft-rs/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/raft-rs/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/raft-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/raft-rs/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/raft-rs/statuses/94ea0e9e793a794264f688dfc366ed6e2b505672"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"overvenus"}}