{"action":"opened","number":1299,"pull_request":{"url":"https://api.github.com/repos/openwrt/openwrt/pulls/1299","id":209318186,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzE4MTg2","html_url":"https://github.com/openwrt/openwrt/pull/1299","diff_url":"https://github.com/openwrt/openwrt/pull/1299.diff","patch_url":"https://github.com/openwrt/openwrt/pull/1299.patch","issue_url":"https://api.github.com/repos/openwrt/openwrt/issues/1299","number":1299,"state":"open","locked":false,"title":"ath79: fix pci interrupt","user":{"login":"981213","id":3888062,"node_id":"MDQ6VXNlcjM4ODgwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3888062?v=4","gravatar_id":"","url":"https://api.github.com/users/981213","html_url":"https://github.com/981213","followers_url":"https://api.github.com/users/981213/followers","following_url":"https://api.github.com/users/981213/following{/other_user}","gists_url":"https://api.github.com/users/981213/gists{/gist_id}","starred_url":"https://api.github.com/users/981213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/981213/subscriptions","organizations_url":"https://api.github.com/users/981213/orgs","repos_url":"https://api.github.com/users/981213/repos","events_url":"https://api.github.com/users/981213/events{/privacy}","received_events_url":"https://api.github.com/users/981213/received_events","type":"User","site_admin":false},"body":"This PR fixes the \"low throughput\" issue on ar7161 devices.\r\nThere are several mistakes in the original code:\r\n1. interrupt-controller can't share the same node with interrupt-map. If the property interrupt-controller is defined, interrupt-map is ignored and all PCI slave devices got assigned the first IRQ of the registered IRQ chip.\r\n2. The mask/unmask function of the IRQ cascade driver inside PCI driver are wrong. Check commit messages for details about this problem :)\r\n3. the defined interrupt-map is wrong. the last value of interrupt-map-mask should be 0 to map all 4 PCI interrupts to the same IRQ.\r\n4. The \"PCIE\" node in ar7100.dtsi are copied directly from other dts. But we have a PCI controller on ar7100, not a PCIE one. Currently defined interrupt map is wrong.\r\n\r\nThe reason why pci-ar724x works with these mistakes:\r\n1. The incorrect interrupt-controller property defined there caused all the devices bind to the first IRQ on the registered dummy IRQ chip, and this is correct for those pcie controller since there will be only one possible device on each pcie controller.\r\n2. The mask/unmask function called irq_linear_revmap(apc-&gt;domain, d-&gt;irq) with incorrect arguments, and irq_linear_revmap will return 0 when arguments are invalid, and 0 is the correct bit to mask/unmask the interrupt controller.\r\n","created_at":"2018-08-18T16:02:20Z","updated_at":"2018-08-18T16:02:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openwrt/openwrt/pulls/1299/commits","review_comments_url":"https://api.github.com/repos/openwrt/openwrt/pulls/1299/comments","review_comment_url":"https://api.github.com/repos/openwrt/openwrt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openwrt/openwrt/issues/1299/comments","statuses_url":"https://api.github.com/repos/openwrt/openwrt/statuses/c1b2a12bf113fa74c7672ad783fbb82f671dfa5a","head":{"label":"981213:ath79_pci","ref":"ath79_pci","sha":"c1b2a12bf113fa74c7672ad783fbb82f671dfa5a","user":{"login":"981213","id":3888062,"node_id":"MDQ6VXNlcjM4ODgwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3888062?v=4","gravatar_id":"","url":"https://api.github.com/users/981213","html_url":"https://github.com/981213","followers_url":"https://api.github.com/users/981213/followers","following_url":"https://api.github.com/users/981213/following{/other_user}","gists_url":"https://api.github.com/users/981213/gists{/gist_id}","starred_url":"https://api.github.com/users/981213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/981213/subscriptions","organizations_url":"https://api.github.com/users/981213/orgs","repos_url":"https://api.github.com/users/981213/repos","events_url":"https://api.github.com/users/981213/events{/privacy}","received_events_url":"https://api.github.com/users/981213/received_events","type":"User","site_admin":false},"repo":{"id":130391014,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzOTEwMTQ=","name":"openwrt","full_name":"981213/openwrt","owner":{"login":"981213","id":3888062,"node_id":"MDQ6VXNlcjM4ODgwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3888062?v=4","gravatar_id":"","url":"https://api.github.com/users/981213","html_url":"https://github.com/981213","followers_url":"https://api.github.com/users/981213/followers","following_url":"https://api.github.com/users/981213/following{/other_user}","gists_url":"https://api.github.com/users/981213/gists{/gist_id}","starred_url":"https://api.github.com/users/981213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/981213/subscriptions","organizations_url":"https://api.github.com/users/981213/orgs","repos_url":"https://api.github.com/users/981213/repos","events_url":"https://api.github.com/users/981213/events{/privacy}","received_events_url":"https://api.github.com/users/981213/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/981213/openwrt","description":"My openwrt fork here.","fork":true,"url":"https://api.github.com/repos/981213/openwrt","forks_url":"https://api.github.com/repos/981213/openwrt/forks","keys_url":"https://api.github.com/repos/981213/openwrt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/981213/openwrt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/981213/openwrt/teams","hooks_url":"https://api.github.com/repos/981213/openwrt/hooks","issue_events_url":"https://api.github.com/repos/981213/openwrt/issues/events{/number}","events_url":"https://api.github.com/repos/981213/openwrt/events","assignees_url":"https://api.github.com/repos/981213/openwrt/assignees{/user}","branches_url":"https://api.github.com/repos/981213/openwrt/branches{/branch}","tags_url":"https://api.github.com/repos/981213/openwrt/tags","blobs_url":"https://api.github.com/repos/981213/openwrt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/981213/openwrt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/981213/openwrt/git/refs{/sha}","trees_url":"https://api.github.com/repos/981213/openwrt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/981213/openwrt/statuses/{sha}","languages_url":"https://api.github.com/repos/981213/openwrt/languages","stargazers_url":"https://api.github.com/repos/981213/openwrt/stargazers","contributors_url":"https://api.github.com/repos/981213/openwrt/contributors","subscribers_url":"https://api.github.com/repos/981213/openwrt/subscribers","subscription_url":"https://api.github.com/repos/981213/openwrt/subscription","commits_url":"https://api.github.com/repos/981213/openwrt/commits{/sha}","git_commits_url":"https://api.github.com/repos/981213/openwrt/git/commits{/sha}","comments_url":"https://api.github.com/repos/981213/openwrt/comments{/number}","issue_comment_url":"https://api.github.com/repos/981213/openwrt/issues/comments{/number}","contents_url":"https://api.github.com/repos/981213/openwrt/contents/{+path}","compare_url":"https://api.github.com/repos/981213/openwrt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/981213/openwrt/merges","archive_url":"https://api.github.com/repos/981213/openwrt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/981213/openwrt/downloads","issues_url":"https://api.github.com/repos/981213/openwrt/issues{/number}","pulls_url":"https://api.github.com/repos/981213/openwrt/pulls{/number}","milestones_url":"https://api.github.com/repos/981213/openwrt/milestones{/number}","notifications_url":"https://api.github.com/repos/981213/openwrt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/981213/openwrt/labels{/name}","releases_url":"https://api.github.com/repos/981213/openwrt/releases{/id}","deployments_url":"https://api.github.com/repos/981213/openwrt/deployments","created_at":"2018-04-20T16:59:58Z","updated_at":"2018-06-28T09:19:45Z","pushed_at":"2018-08-18T15:30:35Z","git_url":"git://github.com/981213/openwrt.git","ssh_url":"git@github.com:981213/openwrt.git","clone_url":"https://github.com/981213/openwrt.git","svn_url":"https://github.com/981213/openwrt","homepage":"","size":154757,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openwrt:master","ref":"master","sha":"d1ea8ac3b476e1e552f42dbf1042b521c57a0df4","user":{"login":"openwrt","id":2528830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjg4MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/2528830?v=4","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"repo":{"id":45821540,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgyMTU0MA==","name":"openwrt","full_name":"openwrt/openwrt","owner":{"login":"openwrt","id":2528830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjg4MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/2528830?v=4","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openwrt/openwrt","description":"This repository is a mirror of https://git.openwrt.org/openwrt/openwrt.git It is for reference only and is not active for check-ins or for reporting issues.  We will continue to accept Pull Requests here. They will be merged via staging trees then into openwrt.git. All issues should be reported at: https://bugs.openwrt.org","fork":false,"url":"https://api.github.com/repos/openwrt/openwrt","forks_url":"https://api.github.com/repos/openwrt/openwrt/forks","keys_url":"https://api.github.com/repos/openwrt/openwrt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openwrt/openwrt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openwrt/openwrt/teams","hooks_url":"https://api.github.com/repos/openwrt/openwrt/hooks","issue_events_url":"https://api.github.com/repos/openwrt/openwrt/issues/events{/number}","events_url":"https://api.github.com/repos/openwrt/openwrt/events","assignees_url":"https://api.github.com/repos/openwrt/openwrt/assignees{/user}","branches_url":"https://api.github.com/repos/openwrt/openwrt/branches{/branch}","tags_url":"https://api.github.com/repos/openwrt/openwrt/tags","blobs_url":"https://api.github.com/repos/openwrt/openwrt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openwrt/openwrt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openwrt/openwrt/git/refs{/sha}","trees_url":"https://api.github.com/repos/openwrt/openwrt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openwrt/openwrt/statuses/{sha}","languages_url":"https://api.github.com/repos/openwrt/openwrt/languages","stargazers_url":"https://api.github.com/repos/openwrt/openwrt/stargazers","contributors_url":"https://api.github.com/repos/openwrt/openwrt/contributors","subscribers_url":"https://api.github.com/repos/openwrt/openwrt/subscribers","subscription_url":"https://api.github.com/repos/openwrt/openwrt/subscription","commits_url":"https://api.github.com/repos/openwrt/openwrt/commits{/sha}","git_commits_url":"https://api.github.com/repos/openwrt/openwrt/git/commits{/sha}","comments_url":"https://api.github.com/repos/openwrt/openwrt/comments{/number}","issue_comment_url":"https://api.github.com/repos/openwrt/openwrt/issues/comments{/number}","contents_url":"https://api.github.com/repos/openwrt/openwrt/contents/{+path}","compare_url":"https://api.github.com/repos/openwrt/openwrt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openwrt/openwrt/merges","archive_url":"https://api.github.com/repos/openwrt/openwrt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openwrt/openwrt/downloads","issues_url":"https://api.github.com/repos/openwrt/openwrt/issues{/number}","pulls_url":"https://api.github.com/repos/openwrt/openwrt/pulls{/number}","milestones_url":"https://api.github.com/repos/openwrt/openwrt/milestones{/number}","notifications_url":"https://api.github.com/repos/openwrt/openwrt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openwrt/openwrt/labels{/name}","releases_url":"https://api.github.com/repos/openwrt/openwrt/releases{/id}","deployments_url":"https://api.github.com/repos/openwrt/openwrt/deployments","created_at":"2015-11-09T07:13:55Z","updated_at":"2018-08-18T12:13:21Z","pushed_at":"2018-08-18T15:49:13Z","git_url":"git://github.com/openwrt/openwrt.git","ssh_url":"git@github.com:openwrt/openwrt.git","clone_url":"https://github.com/openwrt/openwrt.git","svn_url":"https://github.com/openwrt/openwrt","homepage":"","size":154959,"stargazers_count":2792,"watchers_count":2792,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1679,"mirror_url":null,"archived":false,"open_issues_count":259,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1679,"open_issues":259,"watchers":2792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/1299"},"html":{"href":"https://github.com/openwrt/openwrt/pull/1299"},"issue":{"href":"https://api.github.com/repos/openwrt/openwrt/issues/1299"},"comments":{"href":"https://api.github.com/repos/openwrt/openwrt/issues/1299/comments"},"review_comments":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/1299/comments"},"review_comment":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/1299/commits"},"statuses":{"href":"https://api.github.com/repos/openwrt/openwrt/statuses/c1b2a12bf113fa74c7672ad783fbb82f671dfa5a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":6,"additions":158,"deletions":58,"changed_files":8}}
{"actor":{"display_login":"981213"}}