{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/8668","repository_url":"https://api.github.com/repos/kubernetes/test-infra","labels_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8668/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8668/comments","events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8668/events","html_url":"https://github.com/kubernetes/test-infra/issues/8668","id":340711147,"node_id":"MDU6SXNzdWUzNDA3MTExNDc=","number":8668,"title":"Support sending emails in prow","user":{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"labels":[{"id":412127043,"node_id":"MDU6TGFiZWw0MTIxMjcwNDM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow","name":"area/prow","color":"0052cc","default":false},{"id":718255965,"node_id":"MDU6TGFiZWw3MTgyNTU5NjU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-12T16:29:30Z","updated_at":"2018-07-13T17:50:53Z","closed_at":null,"author_association":"MEMBER","body":"I know that this is supported in testgrid but we should consider supporting it in prow.\r\n\r\n- [x] testgrid is not open-sourced\r\n- [x] even if testgrid was open, we shouldn't force deployments to deploy testgrid just for emails (even though testgrid is likely to be used by everyone who is using prow in the event it's opensourced)\r\n\r\nWe use Jenkins heavily for receiving emails about failed jobs and we can't fully migrate to prow w/o this (otherwise it's going to be a big hit on our flows). \r\n\r\nStrawman implementation that does not require changes in the prowjob api:\r\n* store emails in a prowjob label (`email-notify.prow.io`: `bob@company.com, alice@company.com`)\r\n* write a controller that watches for state transitions to failed prowjobs labeled with `email-notify.prow.io`\r\n* send those emails\r\n\r\n/area prow\r\n/kind feature\r\n\r\n@stevekuznetsov @cjwagner @BenTheElder @krzyzacy @fejta "},"comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments/404905959","html_url":"https://github.com/kubernetes/test-infra/issues/8668#issuecomment-404905959","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8668","id":404905959,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDkwNTk1OQ==","user":{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T17:50:53Z","updated_at":"2018-07-13T17:50:53Z","author_association":"MEMBER","body":"Except for postsubmits, jobs can be rerun again and an individual run can be lost etc.. they're more like a deployment than a pod.\r\n\r\nEmail for postsubmits sounds fine for an MVP but kubernetes at least can't and won't use that if that's all it can do. We mostly favor periodic and Presubmit and for those we really need \"after N failures\" with the alerting decoupled from the specific prowjob instantiation. I'd request if at all possible that we start with that decoupling so we can expand it to support this in the future without rewriting everything but the email code.\r\n\r\nthis has the side benefit of letting you define the email config once for branch sharded jobs"}}
{"actor":{"display_login":"BenTheElder"}}