{"action":"closed","number":2598,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/2598","id":171102007,"html_url":"https://github.com/solidusio/solidus/pull/2598","diff_url":"https://github.com/solidusio/solidus/pull/2598.diff","patch_url":"https://github.com/solidusio/solidus/pull/2598.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/2598","number":2598,"state":"closed","locked":false,"title":"Generate new stores with MySQL timestamp precision 6","user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars3.githubusercontent.com/u/131752?v=4","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"body":"Under MySQL, we end up with caching issues due to timestamps by default only having 1 second precision. In recent versions of MySQL this can be increased to microsecond precision by specifying precision.\r\n\r\nThere's another PR open, #2479, which will `ALTER TABLE` all existing tables to increase the precision. We haven't merged partly out of worry about how long the migration will take for existing users with large tables.\r\n\r\nThis PR instead creates the table with the correct precision to begin with. This won't fix the issue for existing users, but it will for new users (and our spec suite). For existing MySQL users we can recommend they copy in and apply the migration from #2479 at their own time.","created_at":"2018-02-23T19:54:26Z","updated_at":"2018-02-26T18:38:06Z","closed_at":"2018-02-26T18:38:06Z","merged_at":"2018-02-26T18:38:06Z","merge_commit_sha":"b90ec9fb0803e99ffc8a217cb6f9ac7d3659d51d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/2598/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/2598/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/2598/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/b90ec9fb0803e99ffc8a217cb6f9ac7d3659d51d","head":{"label":"jhawthorn:mysql_precision_for_new_stores","ref":"mysql_precision_for_new_stores","sha":"b90ec9fb0803e99ffc8a217cb6f9ac7d3659d51d","user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars3.githubusercontent.com/u/131752?v=4","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"repo":{"id":37868303,"name":"solidus","full_name":"jhawthorn/solidus","owner":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars3.githubusercontent.com/u/131752?v=4","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhawthorn/solidus","description":"solidus ecommerce system","fork":true,"url":"https://api.github.com/repos/jhawthorn/solidus","forks_url":"https://api.github.com/repos/jhawthorn/solidus/forks","keys_url":"https://api.github.com/repos/jhawthorn/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhawthorn/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhawthorn/solidus/teams","hooks_url":"https://api.github.com/repos/jhawthorn/solidus/hooks","issue_events_url":"https://api.github.com/repos/jhawthorn/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/jhawthorn/solidus/events","assignees_url":"https://api.github.com/repos/jhawthorn/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/jhawthorn/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/jhawthorn/solidus/tags","blobs_url":"https://api.github.com/repos/jhawthorn/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhawthorn/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhawthorn/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhawthorn/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhawthorn/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/jhawthorn/solidus/languages","stargazers_url":"https://api.github.com/repos/jhawthorn/solidus/stargazers","contributors_url":"https://api.github.com/repos/jhawthorn/solidus/contributors","subscribers_url":"https://api.github.com/repos/jhawthorn/solidus/subscribers","subscription_url":"https://api.github.com/repos/jhawthorn/solidus/subscription","commits_url":"https://api.github.com/repos/jhawthorn/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhawthorn/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhawthorn/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhawthorn/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhawthorn/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/jhawthorn/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhawthorn/solidus/merges","archive_url":"https://api.github.com/repos/jhawthorn/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhawthorn/solidus/downloads","issues_url":"https://api.github.com/repos/jhawthorn/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/jhawthorn/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/jhawthorn/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/jhawthorn/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhawthorn/solidus/labels{/name}","releases_url":"https://api.github.com/repos/jhawthorn/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/jhawthorn/solidus/deployments","created_at":"2015-06-22T16:58:44Z","updated_at":"2016-01-15T05:22:53Z","pushed_at":"2018-02-23T23:05:45Z","git_url":"git://github.com/jhawthorn/solidus.git","ssh_url":"git@github.com:jhawthorn/solidus.git","clone_url":"https://github.com/jhawthorn/solidus.git","svn_url":"https://github.com/jhawthorn/solidus","homepage":"","size":69672,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"a85e27853acb0f6c0b34de9a909d60eca4882e3d","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2018-02-26T17:19:38Z","pushed_at":"2018-02-26T18:37:54Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":69233,"stargazers_count":1714,"watchers_count":1714,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":550,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":550,"open_issues":162,"watchers":1714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2598"},"html":{"href":"https://github.com/solidusio/solidus/pull/2598"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/2598"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/2598/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2598/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2598/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/b90ec9fb0803e99ffc8a217cb6f9ac7d3659d51d"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars3.githubusercontent.com/u/131752?v=4","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":176,"deletions":176,"changed_files":4}}
{"actor":{"display_login":"jhawthorn"}}