{"action":"created","issue":{"url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2709","repository_url":"https://api.github.com/repos/openmrs/openmrs-core","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2709/labels{/name}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2709/comments","events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2709/events","html_url":"https://github.com/openmrs/openmrs-core/pull/2709","id":359442922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTMxNjM2","number":2709,"title":"Trunk-5430: Form Search Criteria doesn't work as expected","user":{"login":"samuelmale","id":26084581,"node_id":"MDQ6VXNlcjI2MDg0NTgx","avatar_url":"https://avatars0.githubusercontent.com/u/26084581?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelmale","html_url":"https://github.com/samuelmale","followers_url":"https://api.github.com/users/samuelmale/followers","following_url":"https://api.github.com/users/samuelmale/following{/other_user}","gists_url":"https://api.github.com/users/samuelmale/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelmale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelmale/subscriptions","organizations_url":"https://api.github.com/users/samuelmale/orgs","repos_url":"https://api.github.com/users/samuelmale/repos","events_url":"https://api.github.com/users/samuelmale/events{/privacy}","received_events_url":"https://api.github.com/users/samuelmale/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-09-12T11:46:32Z","updated_at":"2018-09-12T22:30:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2709","html_url":"https://github.com/openmrs/openmrs-core/pull/2709","diff_url":"https://github.com/openmrs/openmrs-core/pull/2709.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/2709.patch"},"body":"Work done :  Fixed Form search criteria bug of filtering forms against <code>containingAllFormFields</code> argument. I also added unit test confirming this.\r\n\r\nTicket : https://issues.openmrs.org/browse/TRUNK-5430"},"comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments/420819635","html_url":"https://github.com/openmrs/openmrs-core/pull/2709#issuecomment-420819635","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2709","id":420819635,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDgxOTYzNQ==","user":{"login":"dkayiwa","id":1390773,"node_id":"MDQ6VXNlcjEzOTA3NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1390773?v=4","gravatar_id":"","url":"https://api.github.com/users/dkayiwa","html_url":"https://github.com/dkayiwa","followers_url":"https://api.github.com/users/dkayiwa/followers","following_url":"https://api.github.com/users/dkayiwa/following{/other_user}","gists_url":"https://api.github.com/users/dkayiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dkayiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkayiwa/subscriptions","organizations_url":"https://api.github.com/users/dkayiwa/orgs","repos_url":"https://api.github.com/users/dkayiwa/repos","events_url":"https://api.github.com/users/dkayiwa/events{/privacy}","received_events_url":"https://api.github.com/users/dkayiwa/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T22:30:48Z","updated_at":"2018-09-12T22:30:48Z","author_association":"MEMBER","body":"@samuelmale i have again changed line 466 from crit.add(Subqueries.propertyIn(\"form.formId\", subquery)); to crit.add(Subqueries.propertyIn(\"f.formId\", subquery));\r\n\r\nAnd all tests passed. That means your tests do not cover all your changes."}}
{"actor":{"display_login":"dkayiwa"}}