{"action":"created","issue":{"url":"https://api.github.com/repos/kata-containers/agent/issues/133","repository_url":"https://api.github.com/repos/kata-containers/agent","labels_url":"https://api.github.com/repos/kata-containers/agent/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/kata-containers/agent/issues/133/comments","events_url":"https://api.github.com/repos/kata-containers/agent/issues/133/events","html_url":"https://github.com/kata-containers/agent/pull/133","id":294066317,"number":133,"title":"grpc: Handle hotplugged devices by updating spec info","user":{"login":"sboeuf","id":22890413,"avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-03T00:49:55Z","updated_at":"2018-02-06T14:05:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kata-containers/agent/pulls/133","html_url":"https://github.com/kata-containers/agent/pull/133","diff_url":"https://github.com/kata-containers/agent/pull/133.diff","patch_url":"https://github.com/kata-containers/agent/pull/133.patch"},"body":"When adding a host device to the container by using things like\r\n\"docker run --device /dev/sda1:/dev/blk1\", the runtime will not\r\nbe able to anticipate the major/minor numbers for the device\r\nbeing hotplugged into the VM. This means the agent has to update\r\nthe list of devices provided through the spec, by relying on the\r\nlist of Storages.\r\n\r\nThis commit allows the agent to analyze a list of mounts identified\r\nas devices by using the field Driver of the Storage structure. This\r\nway, it knows when it should try to find major/minor pair related\r\nto the devices listed in the spec. Then, it updates this list in the\r\nspec structure so that proper bind mounts between the VM and the\r\ncontainer are performed.\r\n\r\nFixes #132\r\n\r\nSigned-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>"},"comment":{"url":"https://api.github.com/repos/kata-containers/agent/issues/comments/363431789","html_url":"https://github.com/kata-containers/agent/pull/133#issuecomment-363431789","issue_url":"https://api.github.com/repos/kata-containers/agent/issues/133","id":363431789,"user":{"login":"sboeuf","id":22890413,"avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T14:05:58Z","updated_at":"2018-02-06T14:05:58Z","author_association":"CONTRIBUTOR","body":"@bergwolf I agree for SCSI device, unfortunately this case is not applicable for block devices."}}
{"actor":{"display_login":"sboeuf"}}