{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-react/pulls/comments/184791108","pull_request_review_id":116064114,"id":184791108,"diff_hunk":"@@ -1791,7 +1756,7 @@\n     },\n     \"compression\": {\n       \"version\": \"1.5.2\",\n-      \"resolved\": \"https://registry.npmjs.org/compression/-/compression-1.5.2.tgz\",\n+      \"resolved\": \"http://registry.npmjs.org/compression/-/compression-1.5.2.tgz\",","path":"package-lock.json","position":null,"original_position":253,"commit_id":"f8ae682a262b027381bec761a2c80d505426314e","original_commit_id":"5f20e26b9b79e7cfe489ab9715cb5e800c23e670","user":{"login":"kwingram25","id":879755,"avatar_url":"https://avatars0.githubusercontent.com/u/879755?v=4","gravatar_id":"","url":"https://api.github.com/users/kwingram25","html_url":"https://github.com/kwingram25","followers_url":"https://api.github.com/users/kwingram25/followers","following_url":"https://api.github.com/users/kwingram25/following{/other_user}","gists_url":"https://api.github.com/users/kwingram25/gists{/gist_id}","starred_url":"https://api.github.com/users/kwingram25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwingram25/subscriptions","organizations_url":"https://api.github.com/users/kwingram25/orgs","repos_url":"https://api.github.com/users/kwingram25/repos","events_url":"https://api.github.com/users/kwingram25/events{/privacy}","received_events_url":"https://api.github.com/users/kwingram25/received_events","type":"User","site_admin":false},"body":"Fixed it","created_at":"2018-04-27T19:54:37Z","updated_at":"2018-04-27T19:54:37Z","html_url":"https://github.com/status-im/status-react/pull/3829#discussion_r184791108","pull_request_url":"https://api.github.com/repos/status-im/status-react/pulls/3829","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments/184791108"},"html":{"href":"https://github.com/status-im/status-react/pull/3829#discussion_r184791108"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-react/pulls/3829"}},"in_reply_to_id":184702603},"pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/3829","id":180799972,"html_url":"https://github.com/status-im/status-react/pull/3829","diff_url":"https://github.com/status-im/status-react/pull/3829.diff","patch_url":"https://github.com/status-im/status-react/pull/3829.patch","issue_url":"https://api.github.com/repos/status-im/status-react/issues/3829","number":3829,"state":"open","locked":false,"title":"[FEATURE] Encrypt realms","user":{"login":"kwingram25","id":879755,"avatar_url":"https://avatars0.githubusercontent.com/u/879755?v=4","gravatar_id":"","url":"https://api.github.com/users/kwingram25","html_url":"https://github.com/kwingram25","followers_url":"https://api.github.com/users/kwingram25/followers","following_url":"https://api.github.com/users/kwingram25/following{/other_user}","gists_url":"https://api.github.com/users/kwingram25/gists{/gist_id}","starred_url":"https://api.github.com/users/kwingram25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwingram25/subscriptions","organizations_url":"https://api.github.com/users/kwingram25/orgs","repos_url":"https://api.github.com/users/kwingram25/repos","events_url":"https://api.github.com/users/kwingram25/events{/privacy}","received_events_url":"https://api.github.com/users/kwingram25/received_events","type":"User","site_admin":false},"body":"Fixes #3798 \r\n\r\n### Summary:\r\n- Adds Realm encryption with key stored in device keychain, using [react-native-keychain](https://github.com/oblador/react-native-keychain)\r\n- Refactors app initialize flow to get or create device encryption key, then uses for each realm.open call\r\n\r\n### Review notes:\r\n- Need ability to delete or reset key in certain cases?\r\n- Unclear how migrating from non-encrypted to encrypted will work\r\n\r\n### Steps to test:\r\n- Open Status\r\n- Login, logout, create accounts, restart app, etc. to ensure no breaking changes\r\n\r\nStatus: Ready","created_at":"2018-04-11T06:16:57Z","updated_at":"2018-04-27T19:54:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc126b8a0e1da6206ef527090bf2f6ac4ad35f73","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jeluard","id":359723,"avatar_url":"https://avatars1.githubusercontent.com/u/359723?v=4","gravatar_id":"","url":"https://api.github.com/users/jeluard","html_url":"https://github.com/jeluard","followers_url":"https://api.github.com/users/jeluard/followers","following_url":"https://api.github.com/users/jeluard/following{/other_user}","gists_url":"https://api.github.com/users/jeluard/gists{/gist_id}","starred_url":"https://api.github.com/users/jeluard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeluard/subscriptions","organizations_url":"https://api.github.com/users/jeluard/orgs","repos_url":"https://api.github.com/users/jeluard/repos","events_url":"https://api.github.com/users/jeluard/events{/privacy}","received_events_url":"https://api.github.com/users/jeluard/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":523025415,"url":"https://api.github.com/repos/status-im/status-react/labels/bounty","name":"bounty","color":"FAFAD2","default":false},{"id":903584960,"url":"https://api.github.com/repos/status-im/status-react/labels/security","name":"security","color":"ab08d3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-react/pulls/3829/commits","review_comments_url":"https://api.github.com/repos/status-im/status-react/pulls/3829/comments","review_comment_url":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/3829/comments","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/f8ae682a262b027381bec761a2c80d505426314e","head":{"label":"kwingram25:feature/encrypt-realm","ref":"feature/encrypt-realm","sha":"f8ae682a262b027381bec761a2c80d505426314e","user":{"login":"kwingram25","id":879755,"avatar_url":"https://avatars0.githubusercontent.com/u/879755?v=4","gravatar_id":"","url":"https://api.github.com/users/kwingram25","html_url":"https://github.com/kwingram25","followers_url":"https://api.github.com/users/kwingram25/followers","following_url":"https://api.github.com/users/kwingram25/following{/other_user}","gists_url":"https://api.github.com/users/kwingram25/gists{/gist_id}","starred_url":"https://api.github.com/users/kwingram25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwingram25/subscriptions","organizations_url":"https://api.github.com/users/kwingram25/orgs","repos_url":"https://api.github.com/users/kwingram25/repos","events_url":"https://api.github.com/users/kwingram25/events{/privacy}","received_events_url":"https://api.github.com/users/kwingram25/received_events","type":"User","site_admin":false},"repo":{"id":126228122,"name":"status-react","full_name":"kwingram25/status-react","owner":{"login":"kwingram25","id":879755,"avatar_url":"https://avatars0.githubusercontent.com/u/879755?v=4","gravatar_id":"","url":"https://api.github.com/users/kwingram25","html_url":"https://github.com/kwingram25","followers_url":"https://api.github.com/users/kwingram25/followers","following_url":"https://api.github.com/users/kwingram25/following{/other_user}","gists_url":"https://api.github.com/users/kwingram25/gists{/gist_id}","starred_url":"https://api.github.com/users/kwingram25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwingram25/subscriptions","organizations_url":"https://api.github.com/users/kwingram25/orgs","repos_url":"https://api.github.com/users/kwingram25/repos","events_url":"https://api.github.com/users/kwingram25/events{/privacy}","received_events_url":"https://api.github.com/users/kwingram25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwingram25/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":true,"url":"https://api.github.com/repos/kwingram25/status-react","forks_url":"https://api.github.com/repos/kwingram25/status-react/forks","keys_url":"https://api.github.com/repos/kwingram25/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwingram25/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwingram25/status-react/teams","hooks_url":"https://api.github.com/repos/kwingram25/status-react/hooks","issue_events_url":"https://api.github.com/repos/kwingram25/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/kwingram25/status-react/events","assignees_url":"https://api.github.com/repos/kwingram25/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/kwingram25/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/kwingram25/status-react/tags","blobs_url":"https://api.github.com/repos/kwingram25/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwingram25/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwingram25/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwingram25/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwingram25/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/kwingram25/status-react/languages","stargazers_url":"https://api.github.com/repos/kwingram25/status-react/stargazers","contributors_url":"https://api.github.com/repos/kwingram25/status-react/contributors","subscribers_url":"https://api.github.com/repos/kwingram25/status-react/subscribers","subscription_url":"https://api.github.com/repos/kwingram25/status-react/subscription","commits_url":"https://api.github.com/repos/kwingram25/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwingram25/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwingram25/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwingram25/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwingram25/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/kwingram25/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwingram25/status-react/merges","archive_url":"https://api.github.com/repos/kwingram25/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwingram25/status-react/downloads","issues_url":"https://api.github.com/repos/kwingram25/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/kwingram25/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/kwingram25/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/kwingram25/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwingram25/status-react/labels{/name}","releases_url":"https://api.github.com/repos/kwingram25/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/kwingram25/status-react/deployments","created_at":"2018-03-21T19:09:18Z","updated_at":"2018-04-07T02:09:18Z","pushed_at":"2018-04-27T19:54:21Z","git_url":"git://github.com/kwingram25/status-react.git","ssh_url":"git@github.com:kwingram25/status-react.git","clone_url":"https://github.com/kwingram25/status-react.git","svn_url":"https://github.com/kwingram25/status-react","homepage":"https://status.im","size":53404,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"2558fbcfa152758783036d9bbfa3e016f241667d","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-04-27T16:54:19Z","pushed_at":"2018-04-27T19:54:23Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":53641,"stargazers_count":2157,"watchers_count":2157,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":522,"mirror_url":null,"archived":false,"open_issues_count":591,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":522,"open_issues":591,"watchers":2157,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/3829"},"html":{"href":"https://github.com/status-im/status-react/pull/3829"},"issue":{"href":"https://api.github.com/repos/status-im/status-react/issues/3829"},"comments":{"href":"https://api.github.com/repos/status-im/status-react/issues/3829/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-react/pulls/3829/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-react/pulls/3829/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-react/statuses/f8ae682a262b027381bec761a2c80d505426314e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kwingram25"}}