{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/15381","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/15381/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/15381/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/15381/events","html_url":"https://github.com/ampproject/amphtml/issues/15381","id":323825496,"number":15381,"title":"AMP Ad component needs to send extra params to DFP for amp-consent/GDPR compliance","user":{"login":"clumsyjedi","id":152829,"avatar_url":"https://avatars2.githubusercontent.com/u/152829?v=4","gravatar_id":"","url":"https://api.github.com/users/clumsyjedi","html_url":"https://github.com/clumsyjedi","followers_url":"https://api.github.com/users/clumsyjedi/followers","following_url":"https://api.github.com/users/clumsyjedi/following{/other_user}","gists_url":"https://api.github.com/users/clumsyjedi/gists{/gist_id}","starred_url":"https://api.github.com/users/clumsyjedi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clumsyjedi/subscriptions","organizations_url":"https://api.github.com/users/clumsyjedi/orgs","repos_url":"https://api.github.com/users/clumsyjedi/repos","events_url":"https://api.github.com/users/clumsyjedi/events{/privacy}","received_events_url":"https://api.github.com/users/clumsyjedi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-16T23:47:32Z","updated_at":"2018-05-17T12:41:40Z","closed_at":null,"author_association":"NONE","body":"## What's the issue?\r\n\r\nRegarding GDPR compliance, as provided by the amp-consent and amp-ad components.\r\n\r\nAfter discussion with ade@google.com we have identified that for consistency and reporting purposes, DFP requires the following flags to be passed:\r\n\r\nWhen consent is granted:\r\n\r\nconsent=true\r\n\r\nWhen consent is not granted:\r\n\r\nconsent=false&npa=1\r\n\r\nDoing network capture on ad requests shows that only npa=1 is being set, the consent param is not being set.\r\n\r\n## How do we reproduce the issue?\r\n\r\nIf this is a bug please provide a public URL and ideally a reduced test case (e.g. on jsbin.com) that exhibits only your issue and nothing else.  Then provide step-by-step instructions for reproducing the issue:\r\n\r\n1. Create a document with amp-ad components, pointing to DFP.\r\n1. Add an amp-consent component.\r\n1. Add the data-block-on-consent attribute to the amp-ad elements.\r\n\r\nExpected: Filtering the network tab by 'pubads' should show requests with consent=true|false depending on the consent state\r\nActual: Filtering the network tab by 'pubads' DOES NOT show requests with consent=true|false depending on the consent state\r\n\r\n## What browsers are affected?\r\n\r\nAll browsers\r\n\r\n## Which AMP version is affected?\r\n\r\n1525461683159"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/389852574","html_url":"https://github.com/ampproject/amphtml/issues/15381#issuecomment-389852574","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/15381","id":389852574,"user":{"login":"sebastianbenz","id":380472,"avatar_url":"https://avatars3.githubusercontent.com/u/380472?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastianbenz","html_url":"https://github.com/sebastianbenz","followers_url":"https://api.github.com/users/sebastianbenz/followers","following_url":"https://api.github.com/users/sebastianbenz/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbenz/subscriptions","organizations_url":"https://api.github.com/users/sebastianbenz/orgs","repos_url":"https://api.github.com/users/sebastianbenz/repos","events_url":"https://api.github.com/users/sebastianbenz/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbenz/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T12:41:40Z","updated_at":"2018-05-17T12:41:40Z","author_association":"CONTRIBUTOR","body":"//cc @zhouyx @jasti "}}
{"actor":{"display_login":"sebastianbenz"}}