{"action":"created","issue":{"url":"https://api.github.com/repos/KevinOConnor/klipper/issues/379","repository_url":"https://api.github.com/repos/KevinOConnor/klipper","labels_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/379/labels{/name}","comments_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/379/comments","events_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/379/events","html_url":"https://github.com/KevinOConnor/klipper/issues/379","id":330251330,"node_id":"MDU6SXNzdWUzMzAyNTEzMzA=","number":379,"title":"Delta: Allow setting printable radius to a value different from \"delta_radius\"","user":{"login":"ruevs","id":15338069,"node_id":"MDQ6VXNlcjE1MzM4MDY5","avatar_url":"https://avatars2.githubusercontent.com/u/15338069?v=4","gravatar_id":"","url":"https://api.github.com/users/ruevs","html_url":"https://github.com/ruevs","followers_url":"https://api.github.com/users/ruevs/followers","following_url":"https://api.github.com/users/ruevs/following{/other_user}","gists_url":"https://api.github.com/users/ruevs/gists{/gist_id}","starred_url":"https://api.github.com/users/ruevs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruevs/subscriptions","organizations_url":"https://api.github.com/users/ruevs/orgs","repos_url":"https://api.github.com/users/ruevs/repos","events_url":"https://api.github.com/users/ruevs/events{/privacy}","received_events_url":"https://api.github.com/users/ruevs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-07T12:31:44Z","updated_at":"2018-06-07T17:55:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hi first of all - great job on this firmware! Clean architecture, nice documentation, worked from the first attempt! On a delta the steppers move noticeably smoother than with Repetier and much, much smoother than with Marlin.\r\n\r\nAfter configuring a delta printer (https://github.com/KevinOConnor/klipper/pull/378) I noticed that the `delta_radius` option, which sets the geometry of the printer, is the only \"radius\" that can be configured.\r\n\r\nIn delta.py in the `check_move` function there is rather sensible code that checks whether the end position of the move is in the printable area:\r\n\r\n    self.max_xy2 = min(radius, min_arm_length - radius,\r\n                       ratio_to_dist(4. * SLOW_RATIO) - radius)**2\r\n\r\nWhere `radius = delta_radius`\r\nThis code presumes that the configured geometry is the only thing limiting the printable radius. However this is not always the case. For example for the Anycubic Kossel that I configured `delta_radius: 99.8` but the actual printable radius is only 90mm. In my opinion there should be a `printable_radius` configuration option that should be included in the above `min` statement.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KevinOConnor/klipper/issues/comments/395509601","html_url":"https://github.com/KevinOConnor/klipper/issues/379#issuecomment-395509601","issue_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/379","id":395509601,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTUwOTYwMQ==","user":{"login":"KevinOConnor","id":3004890,"node_id":"MDQ6VXNlcjMwMDQ4OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/3004890?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinOConnor","html_url":"https://github.com/KevinOConnor","followers_url":"https://api.github.com/users/KevinOConnor/followers","following_url":"https://api.github.com/users/KevinOConnor/following{/other_user}","gists_url":"https://api.github.com/users/KevinOConnor/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinOConnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinOConnor/subscriptions","organizations_url":"https://api.github.com/users/KevinOConnor/orgs","repos_url":"https://api.github.com/users/KevinOConnor/repos","events_url":"https://api.github.com/users/KevinOConnor/events{/privacy}","received_events_url":"https://api.github.com/users/KevinOConnor/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T17:55:05Z","updated_at":"2018-06-07T17:55:05Z","author_association":"OWNER","body":"On Thu, Jun 07, 2018 at 06:34:32AM -0700, Harald wrote:\n> note, deltas can also print outside the tower radius!\n\nIndeed.  Klipper currently uses a very simplistic check though - the\nvalid region is modeled as a cylinder with a cone on top.\n\nI haven't seen an indication this is a problem in practice, but if\nsomeone wants to implement a more complete check then that is fine.\n\n-Kevin\n"}}
{"actor":{"display_login":"KevinOConnor"}}