{"action":"closed","issue":{"url":"https://api.github.com/repos/EOSIO/eos/issues/2475","repository_url":"https://api.github.com/repos/EOSIO/eos","labels_url":"https://api.github.com/repos/EOSIO/eos/issues/2475/labels{/name}","comments_url":"https://api.github.com/repos/EOSIO/eos/issues/2475/comments","events_url":"https://api.github.com/repos/EOSIO/eos/issues/2475/events","html_url":"https://github.com/EOSIO/eos/issues/2475","id":315469101,"number":2475,"title":"refactor the delivery of large messages via notify/request pairs","user":{"login":"pmesnier","id":897033,"avatar_url":"https://avatars3.githubusercontent.com/u/897033?v=4","gravatar_id":"","url":"https://api.github.com/users/pmesnier","html_url":"https://github.com/pmesnier","followers_url":"https://api.github.com/users/pmesnier/followers","following_url":"https://api.github.com/users/pmesnier/following{/other_user}","gists_url":"https://api.github.com/users/pmesnier/gists{/gist_id}","starred_url":"https://api.github.com/users/pmesnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmesnier/subscriptions","organizations_url":"https://api.github.com/users/pmesnier/orgs","repos_url":"https://api.github.com/users/pmesnier/repos","events_url":"https://api.github.com/users/pmesnier/events{/privacy}","received_events_url":"https://api.github.com/users/pmesnier/received_events","type":"User","site_admin":false},"labels":[{"id":660342318,"url":"https://api.github.com/repos/EOSIO/eos/labels/in%20progress","name":"in progress","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"pmesnier","id":897033,"avatar_url":"https://avatars3.githubusercontent.com/u/897033?v=4","gravatar_id":"","url":"https://api.github.com/users/pmesnier","html_url":"https://github.com/pmesnier","followers_url":"https://api.github.com/users/pmesnier/followers","following_url":"https://api.github.com/users/pmesnier/following{/other_user}","gists_url":"https://api.github.com/users/pmesnier/gists{/gist_id}","starred_url":"https://api.github.com/users/pmesnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmesnier/subscriptions","organizations_url":"https://api.github.com/users/pmesnier/orgs","repos_url":"https://api.github.com/users/pmesnier/repos","events_url":"https://api.github.com/users/pmesnier/events{/privacy}","received_events_url":"https://api.github.com/users/pmesnier/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmesnier","id":897033,"avatar_url":"https://avatars3.githubusercontent.com/u/897033?v=4","gravatar_id":"","url":"https://api.github.com/users/pmesnier","html_url":"https://github.com/pmesnier","followers_url":"https://api.github.com/users/pmesnier/followers","following_url":"https://api.github.com/users/pmesnier/following{/other_user}","gists_url":"https://api.github.com/users/pmesnier/gists{/gist_id}","starred_url":"https://api.github.com/users/pmesnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmesnier/subscriptions","organizations_url":"https://api.github.com/users/pmesnier/orgs","repos_url":"https://api.github.com/users/pmesnier/repos","events_url":"https://api.github.com/users/pmesnier/events{/privacy}","received_events_url":"https://api.github.com/users/pmesnier/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/EOSIO/eos/milestones/9","html_url":"https://github.com/EOSIO/eos/milestone/9","labels_url":"https://api.github.com/repos/EOSIO/eos/milestones/9/labels","id":3210403,"number":9,"title":"RC2","description":"","creator":{"login":"coreylederer","id":32078160,"avatar_url":"https://avatars0.githubusercontent.com/u/32078160?v=4","gravatar_id":"","url":"https://api.github.com/users/coreylederer","html_url":"https://github.com/coreylederer","followers_url":"https://api.github.com/users/coreylederer/followers","following_url":"https://api.github.com/users/coreylederer/following{/other_user}","gists_url":"https://api.github.com/users/coreylederer/gists{/gist_id}","starred_url":"https://api.github.com/users/coreylederer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreylederer/subscriptions","organizations_url":"https://api.github.com/users/coreylederer/orgs","repos_url":"https://api.github.com/users/coreylederer/repos","events_url":"https://api.github.com/users/coreylederer/events{/privacy}","received_events_url":"https://api.github.com/users/coreylederer/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":93,"state":"open","created_at":"2018-03-22T20:08:42Z","updated_at":"2018-05-09T18:45:15Z","due_on":"2018-05-11T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-04-18T13:00:01Z","updated_at":"2018-05-09T18:45:15Z","closed_at":"2018-05-09T18:45:15Z","author_association":"CONTRIBUTOR","body":"The implementation of this feature is unfinished. To ensure efficient testing, I propose doing he following:\r\n1. add a new maximum \"just sent it\" message size that defaults to \"infinite\" meaning always just send the message, a size of 0 means always send a notice.\r\n2. fix the missing functionality: \r\n  - ensure the peer connection's  block_state.is_known flag is set correctly in all cases. \r\n  - ensure that notice messages are propagated to subordinate peers once the node has received the original large message is retrieved\r\n  - implement the big_msg_manager::retry_fetch function to retry large message retrieval in the case of a timeout or loss of connection while waiting for a requested block/transaction\r\n3. Have the block producing node just aways send the block summary regardless of size since all of tis peers will ask it for he block anyway. Subsequent nodes should still send notices if necessary"}}
{"actor":{"display_login":"bytemaster"}}