{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/4459","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/4459/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/4459/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/4459/events","html_url":"https://github.com/triplea-game/triplea/pull/4459","id":394532078,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMjUzOTI4","number":4459,"title":"Refactor LobbyMenu","user":{"login":"ssoloff","id":4826349,"node_id":"MDQ6VXNlcjQ4MjYzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-28T02:44:03Z","updated_at":"2018-12-28T02:52:30Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/4459","html_url":"https://github.com/triplea-game/triplea/pull/4459","diff_url":"https://github.com/triplea-game/triplea/pull/4459.diff","patch_url":"https://github.com/triplea-game/triplea/pull/4459.patch"},"body":"## Overview\r\n\r\nSaw a few safe refactorings that could be performed in `LobbyMenu` while I was [researching](https://forums.triplea-game.org/post/19419) the feasibility of offline unmute.\r\n\r\n## Functional Changes\r\n\r\nNone.\r\n\r\n## Refactoring Changes\r\n\r\nSee each commit for context.  It's possibly easiest to review this PR commit-by-commit.\r\n\r\n## Manual Testing Performed\r\n\r\nSmoke tested the commands under the **Admin** menu in the lobby client."},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/450277680","html_url":"https://github.com/triplea-game/triplea/pull/4459#issuecomment-450277680","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/4459","id":450277680,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDI3NzY4MA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-12-28T02:52:30Z","updated_at":"2018-12-28T02:52:30Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/4459?src=pr&el=h1) Report\n> Merging [#4459](https://codecov.io/gh/triplea-game/triplea/pull/4459?src=pr&el=desc) into [master](https://codecov.io/gh/triplea-game/triplea/commit/88d3972d52aaba79264703f1b9c771c9966d5165?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/triplea-game/triplea/pull/4459/graphs/tree.svg?width=650&token=QPS14q4xnG&height=150&src=pr)](https://codecov.io/gh/triplea-game/triplea/pull/4459?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #4459      +/-   ##\n============================================\n- Coverage      22.9%   22.89%   -0.01%     \n+ Complexity     6183     6180       -3     \n============================================\n  Files           878      878              \n  Lines         71225    71215      -10     \n  Branches      11339    11339              \n============================================\n- Hits          16312    16308       -4     \n+ Misses        52881    52873       -8     \n- Partials       2032     2034       +2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/triplea-game/triplea/pull/4459?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...a/games/strategy/triplea/ui/menubar/LobbyMenu.java](https://codecov.io/gh/triplea-game/triplea/pull/4459/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS91aS9tZW51YmFyL0xvYmJ5TWVudS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...rategy/triplea/attachments/UnitTypeComparator.java](https://codecov.io/gh/triplea-game/triplea/pull/4459/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9Vbml0VHlwZUNvbXBhcmF0b3IuamF2YQ==) | `46.15% <0%> (-7.7%)` | `12% <0%> (-1%)` | |\n| [.../strategy/triplea/odds/calculator/DummyPlayer.java](https://codecov.io/gh/triplea-game/triplea/pull/4459/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9vZGRzL2NhbGN1bGF0b3IvRHVtbXlQbGF5ZXIuamF2YQ==) | `34.83% <0%> (-1.13%)` | `9% <0%> (-1%)` | |\n| [.../src/main/java/games/strategy/net/nio/Decoder.java](https://codecov.io/gh/triplea-game/triplea/pull/4459/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvbmV0L25pby9EZWNvZGVyLmphdmE=) | `72.82% <0%> (-1.09%)` | `24% <0%> (-1%)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/triplea-game/triplea/pull/4459?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/4459?src=pr&el=footer). Last update [88d3972...7c98b6a](https://codecov.io/gh/triplea-game/triplea/pull/4459?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}