{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/1050","repository_url":"https://api.github.com/repos/hyperledger/iroha","labels_url":"https://api.github.com/repos/hyperledger/iroha/issues/1050/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1050/comments","events_url":"https://api.github.com/repos/hyperledger/iroha/issues/1050/events","html_url":"https://github.com/hyperledger/iroha/pull/1050","id":303063865,"number":1050,"title":"Shared model/new consensus gate","user":{"login":"x3medima17","id":750115,"avatar_url":"https://avatars0.githubusercontent.com/u/750115?v=4","gravatar_id":"","url":"https://api.github.com/users/x3medima17","html_url":"https://github.com/x3medima17","followers_url":"https://api.github.com/users/x3medima17/followers","following_url":"https://api.github.com/users/x3medima17/following{/other_user}","gists_url":"https://api.github.com/users/x3medima17/gists{/gist_id}","starred_url":"https://api.github.com/users/x3medima17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x3medima17/subscriptions","organizations_url":"https://api.github.com/users/x3medima17/orgs","repos_url":"https://api.github.com/users/x3medima17/repos","events_url":"https://api.github.com/users/x3medima17/events{/privacy}","received_events_url":"https://api.github.com/users/x3medima17/received_events","type":"User","site_admin":false},"labels":[{"id":853992875,"url":"https://api.github.com/repos/hyperledger/iroha/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-07T11:34:20Z","updated_at":"2018-03-20T09:57:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1050","html_url":"https://github.com/hyperledger/iroha/pull/1050","diff_url":"https://github.com/hyperledger/iroha/pull/1050.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1050.patch"},"body":"<!-- You will not see HTML commented line in Pull Request body -->\r\n<!-- Optional sections may be omitted. Just remove them or write None -->\r\n\r\n<!-- ### Requirements -->\r\n<!-- * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. -->\r\n<!-- * All new code must have code coverage above 70% (https://docs.codecov.io/docs/about-code-coverage). -->\r\n<!-- * CircleCI builds must be passed. -->\r\n<!-- * Critical and blocker issues reported by Sorabot must be fixed. -->\r\n<!-- * Branch must be rebased onto base branch (https://soramitsu.atlassian.net/wiki/spaces/IS/pages/11173889/Rebase+and+merge+guide). -->\r\n\r\n\r\n### Description of the Change\r\nMigrate consensus gate to the new model\r\n<!-- We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. -->\r\n<!-- Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts. -->\r\n\r\n### Benefits\r\nLess dependency on old model\r\n<!-- What benefits will be realized by the code change? -->\r\n\r\n### Possible Drawbacks \r\nNone\r\n<!-- What are the possible side-effects or negative impacts of the code change? -->\r\n<!-- If no drawbacks, explicitly mention this (write None) -->\r\n"},"comment":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/comments/374538765","html_url":"https://github.com/hyperledger/iroha/pull/1050#issuecomment-374538765","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1050","id":374538765,"user":{"login":"sorabot","id":32125183,"avatar_url":"https://avatars0.githubusercontent.com/u/32125183?v=4","gravatar_id":"","url":"https://api.github.com/users/sorabot","html_url":"https://github.com/sorabot","followers_url":"https://api.github.com/users/sorabot/followers","following_url":"https://api.github.com/users/sorabot/following{/other_user}","gists_url":"https://api.github.com/users/sorabot/gists{/gist_id}","starred_url":"https://api.github.com/users/sorabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorabot/subscriptions","organizations_url":"https://api.github.com/users/sorabot/orgs","repos_url":"https://api.github.com/users/sorabot/repos","events_url":"https://api.github.com/users/sorabot/events{/privacy}","received_events_url":"https://api.github.com/users/sorabot/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T09:57:42Z","updated_at":"2018-03-20T09:57:42Z","author_association":"NONE","body":"SonarQube analysis reported 1 issue\n\n1. ![MINOR][MINOR] [yac_gate_impl.hpp#L61](https://github.com/hyperledger/iroha/blob/0186842461a85841c3b3fda4cfaf432e4260e8ad/irohad/consensus/yac/impl/yac_gate_impl.hpp#L61): Unused private function: 'YacGateImpl::copySignatures' [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cppcheck%3AunusedPrivateFunction)\n\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"sorabot"}}