{"push_id":2594512891,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"59da548b0c4d4239e0ec1855d3f7f77a2bff4b93","before":"26c0e4c1f54759249c2d61b50fb5430bd73793f2","commits":[{"sha":"59da548b0c4d4239e0ec1855d3f7f77a2bff4b93","author":{"name":"Mike Klein","email":"14574f09dfa9b4e14759b88c3426a495a0e627b0@google.com"},"message":"Revert \"find_headers.py to better find headers.\"\n\nThis reverts commit 6c8ad116d460fe892fff77b8f80e284e3487d59d.\n\nReason for revert:\n\nhttps://chromium-swarm.appspot.com/task?id=3db0ac33aa369910&refresh=10\n\n[981/1474] ACTION //:skia.h(//gn/toolchain:gcc_like)\nFAILED: gen/skia.h \npython ../../../gn/find_headers.py /mnt/pd0/s/w/ir/cache/work/skia/bin/gn /mnt/pd0/s/w/ir/cache/work/skia/ gen/skia.h /mnt/pd0/s/w/ir/cache/work/skia/include/android /mnt/pd0/s/w/ir/cache/work/skia/include/c /mnt/pd0/s/w/ir/cache/work/skia/include/codec /mnt/pd0/s/w/ir/cache/work/skia/include/config /mnt/pd0/s/w/ir/cache/work/skia/include/core /mnt/pd0/s/w/ir/cache/work/skia/include/effects /mnt/pd0/s/w/ir/cache/work/skia/include/encode /mnt/pd0/s/w/ir/cache/work/skia/include/gpu /mnt/pd0/s/w/ir/cache/work/skia/include/atlastext /mnt/pd0/s/w/ir/cache/work/skia/include/pathops /mnt/pd0/s/w/ir/cache/work/skia/include/ports /mnt/pd0/s/w/ir/cache/work/skia/include/svg /mnt/pd0/s/w/ir/cache/work/skia/include/utils /mnt/pd0/s/w/ir/cache/work/skia/include/utils/mac /mnt/pd0/s/w/ir/cache/work/skia/include/atlastext\nTraceback (most recent call last):\n  File \"../../../gn/find_headers.py\", line 32, in <module>\n    sources_json = json.loads(subprocess.check_output(gn_sources_cmd))\n  File \"/usr/lib/python2.7/json/__init__.py\", line 339, in loads\n    return _default_decoder.decode(s)\n  File \"/usr/lib/python2.7/json/decoder.py\", line 364, in decode\n    obj, end = self.raw_decode(s, idx=_w(s, 0).end())\n  File \"/usr/lib/python2.7/json/decoder.py\", line 382, in raw_decode\n    raise ValueError(\"No JSON object could be decoded\")\nValueError: No JSON object could be decoded\n\nOriginal change's description:\n> find_headers.py to better find headers.\n> \n> The find_headers.py script claims to \"recursively search each include\n> directory for headers\" but the recursive part has been left out.\n> \n> This changes find_headers to instead find all the sources which are in\n> public include directories and list them with the shortest possible\n> path. This removes the need for a blacklist and also handles includes in\n> subdirectories of public include directories.\n> \n> Change-Id: Ib59256a2059d37d4459686c421923207ac7acf38\n> Reviewed-on: https://skia-review.googlesource.com/129660\n> Reviewed-by: Greg Daniel <egdaniel@google.com>\n> Commit-Queue: Ben Wagner <bungeman@google.com>\n\nTBR=egdaniel@google.com,mtklein@google.com,bungeman@google.com\n\nChange-Id: I5cca85754f1b9fde7771ab0ed1bd8117ee96a970\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://skia-review.googlesource.com/130181\nReviewed-by: Mike Klein <mtklein@google.com>\nCommit-Queue: Mike Klein <mtklein@google.com>","distinct":true,"url":"https://api.github.com/repos/google/skia/commits/59da548b0c4d4239e0ec1855d3f7f77a2bff4b93"}]}
{"actor":{"display_login":"hubot"}}