{"action":"created","issue":{"url":"https://api.github.com/repos/WorldBank-Transport/DRIVER/issues/714","repository_url":"https://api.github.com/repos/WorldBank-Transport/DRIVER","labels_url":"https://api.github.com/repos/WorldBank-Transport/DRIVER/issues/714/labels{/name}","comments_url":"https://api.github.com/repos/WorldBank-Transport/DRIVER/issues/714/comments","events_url":"https://api.github.com/repos/WorldBank-Transport/DRIVER/issues/714/events","html_url":"https://github.com/WorldBank-Transport/DRIVER/pull/714","id":361311938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzEzMTk1","number":714,"title":"Fix docker command in grout playbook","user":{"login":"ddohler","id":447977,"node_id":"MDQ6VXNlcjQ0Nzk3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/447977?v=4","gravatar_id":"","url":"https://api.github.com/users/ddohler","html_url":"https://github.com/ddohler","followers_url":"https://api.github.com/users/ddohler/followers","following_url":"https://api.github.com/users/ddohler/following{/other_user}","gists_url":"https://api.github.com/users/ddohler/gists{/gist_id}","starred_url":"https://api.github.com/users/ddohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddohler/subscriptions","organizations_url":"https://api.github.com/users/ddohler/orgs","repos_url":"https://api.github.com/users/ddohler/repos","events_url":"https://api.github.com/users/ddohler/events{/privacy}","received_events_url":"https://api.github.com/users/ddohler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rmartz","id":1032849,"node_id":"MDQ6VXNlcjEwMzI4NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1032849?v=4","gravatar_id":"","url":"https://api.github.com/users/rmartz","html_url":"https://github.com/rmartz","followers_url":"https://api.github.com/users/rmartz/followers","following_url":"https://api.github.com/users/rmartz/following{/other_user}","gists_url":"https://api.github.com/users/rmartz/gists{/gist_id}","starred_url":"https://api.github.com/users/rmartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmartz/subscriptions","organizations_url":"https://api.github.com/users/rmartz/orgs","repos_url":"https://api.github.com/users/rmartz/repos","events_url":"https://api.github.com/users/rmartz/events{/privacy}","received_events_url":"https://api.github.com/users/rmartz/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmartz","id":1032849,"node_id":"MDQ6VXNlcjEwMzI4NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1032849?v=4","gravatar_id":"","url":"https://api.github.com/users/rmartz","html_url":"https://github.com/rmartz","followers_url":"https://api.github.com/users/rmartz/followers","following_url":"https://api.github.com/users/rmartz/following{/other_user}","gists_url":"https://api.github.com/users/rmartz/gists{/gist_id}","starred_url":"https://api.github.com/users/rmartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmartz/subscriptions","organizations_url":"https://api.github.com/users/rmartz/orgs","repos_url":"https://api.github.com/users/rmartz/repos","events_url":"https://api.github.com/users/rmartz/events{/privacy}","received_events_url":"https://api.github.com/users/rmartz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-09-18T13:44:16Z","updated_at":"2018-09-18T13:58:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/WorldBank-Transport/DRIVER/pulls/714","html_url":"https://github.com/WorldBank-Transport/DRIVER/pull/714","diff_url":"https://github.com/WorldBank-Transport/DRIVER/pull/714.diff","patch_url":"https://github.com/WorldBank-Transport/DRIVER/pull/714.patch"},"body":"## Overview\r\n\r\nThis was a change that @pcaisse and I discovered in the course of testing the Grout PR, but I think we got so excited about it actually working that we forgot to, you know, commit it. This fixes that and should fix any problems with migrating to grout.\r\n\r\n### Checklist\r\n\r\n- [x] PR has a descriptive enough title to be useful in changelogs\r\n\r\n## Testing Instructions\r\n\r\n * Follow the instructions in https://github.com/WorldBank-Transport/DRIVER/pull/713\r\n * It should work, rather than failing.\r\n"},"comment":{"url":"https://api.github.com/repos/WorldBank-Transport/DRIVER/issues/comments/422404058","html_url":"https://github.com/WorldBank-Transport/DRIVER/pull/714#issuecomment-422404058","issue_url":"https://api.github.com/repos/WorldBank-Transport/DRIVER/issues/714","id":422404058,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjQwNDA1OA==","user":{"login":"rmartz","id":1032849,"node_id":"MDQ6VXNlcjEwMzI4NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1032849?v=4","gravatar_id":"","url":"https://api.github.com/users/rmartz","html_url":"https://github.com/rmartz","followers_url":"https://api.github.com/users/rmartz/followers","following_url":"https://api.github.com/users/rmartz/following{/other_user}","gists_url":"https://api.github.com/users/rmartz/gists{/gist_id}","starred_url":"https://api.github.com/users/rmartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmartz/subscriptions","organizations_url":"https://api.github.com/users/rmartz/orgs","repos_url":"https://api.github.com/users/rmartz/repos","events_url":"https://api.github.com/users/rmartz/events{/privacy}","received_events_url":"https://api.github.com/users/rmartz/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T13:58:59Z","updated_at":"2018-09-18T13:58:59Z","author_association":"COLLABORATOR","body":"Unfortunately I already bypassed this problem, though this matches the approach I took of using [`./scripts/manage.sh`](https://github.com/WorldBank-Transport/DRIVER/blob/d5192d6a0466b89800ee9254079d42be51e0c8e0/scripts/manage.sh) to run the commands. The only difference I can see is that `manage.sh` uses `exec -ti`, which shouldn't be needed here since we don't expect the command to require input. That said, I believe for safety we _probably_ [should use `--no-input`](https://docs.djangoproject.com/en/2.1/ref/django-admin/#cmdoption-migrate-noinput), just in case one of the systems we run this on has stale content types or some other situation that could cause `./manage.py migrate` try to be interactive.\r\n\r\nSide note, I'm not super familiar with docker, and from my reading about this last night it seems like `run` should in theory be superior to `exec` since we don't really need to re-use a pre-existing container. I'm not entirely sure why `run` doesn't work - is it not possible to have more than one container from a given image running? What if we passed in a `--name` flag?"}}
{"actor":{"display_login":"rmartz"}}