{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/comments/168390923","pull_request_review_id":96748527,"id":168390923,"diff_hunk":"@@ -2,23 +2,31 @@\n {\n     public class Endpoint\n     {\n-        string host;\n-\n-        public string Name { get; set; }\n+        public string Name\n+        {\n+            get => EndpointDetails.Name;","path":"src/ServiceInsight/Models/Endpoint.cs","position":9,"original_position":9,"commit_id":"dae1b3bbbf9ddaf7f1621df0c7c4b731fa09b23f","original_commit_id":"023f1029fd6be64627948ab848d6eacbd373e6d0","user":{"login":"HEskandari","id":132117,"avatar_url":"https://avatars0.githubusercontent.com/u/132117?v=4","gravatar_id":"","url":"https://api.github.com/users/HEskandari","html_url":"https://github.com/HEskandari","followers_url":"https://api.github.com/users/HEskandari/followers","following_url":"https://api.github.com/users/HEskandari/following{/other_user}","gists_url":"https://api.github.com/users/HEskandari/gists{/gist_id}","starred_url":"https://api.github.com/users/HEskandari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEskandari/subscriptions","organizations_url":"https://api.github.com/users/HEskandari/orgs","repos_url":"https://api.github.com/users/HEskandari/repos","events_url":"https://api.github.com/users/HEskandari/events{/privacy}","received_events_url":"https://api.github.com/users/HEskandari/received_events","type":"User","site_admin":false},"body":"This uses expression assignment instead of old get/set style. Not that I don't like it but for consistency, I think we need to keep using the older/established coding style. Same goes for below.","created_at":"2018-02-15T06:47:32Z","updated_at":"2018-02-15T06:50:10Z","html_url":"https://github.com/Particular/ServiceInsight/pull/778#discussion_r168390923","pull_request_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/778","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/comments/168390923"},"html":{"href":"https://github.com/Particular/ServiceInsight/pull/778#discussion_r168390923"},"pull_request":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/778"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/778","id":166606576,"html_url":"https://github.com/Particular/ServiceInsight/pull/778","diff_url":"https://github.com/Particular/ServiceInsight/pull/778.diff","patch_url":"https://github.com/Particular/ServiceInsight/pull/778.patch","issue_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/778","number":778,"state":"open","locked":false,"title":"[WIP] Use SC /endpoints/known when service is discovered","user":{"login":"boblangley","id":2546913,"avatar_url":"https://avatars3.githubusercontent.com/u/2546913?v=4","gravatar_id":"","url":"https://api.github.com/users/boblangley","html_url":"https://github.com/boblangley","followers_url":"https://api.github.com/users/boblangley/followers","following_url":"https://api.github.com/users/boblangley/following{/other_user}","gists_url":"https://api.github.com/users/boblangley/gists{/gist_id}","starred_url":"https://api.github.com/users/boblangley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boblangley/subscriptions","organizations_url":"https://api.github.com/users/boblangley/orgs","repos_url":"https://api.github.com/users/boblangley/repos","events_url":"https://api.github.com/users/boblangley/events{/privacy}","received_events_url":"https://api.github.com/users/boblangley/received_events","type":"User","site_admin":false},"body":"Connects to https://github.com/Particular/ServiceInsight/issues/774\r\n\r\nWe have introduced a distinct API call to return the known endpoints from ServiceControl which is the, now, more correct call for ServiceInsight to make.\r\n\r\nThe change is intended to be backwards compatible, falling back to the \"endpoints\" const string when no other service is reported by ServiceControl for SI to use.","created_at":"2018-02-01T17:45:51Z","updated_at":"2018-02-15T06:50:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56fb357fe91ebdcee4cc1c3c85579aa337f1c295","assignee":{"login":"adamralph","id":677704,"avatar_url":"https://avatars2.githubusercontent.com/u/677704?v=4","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false},"assignees":[{"login":"adamralph","id":677704,"avatar_url":"https://avatars2.githubusercontent.com/u/677704?v=4","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"adamralph","id":677704,"avatar_url":"https://avatars2.githubusercontent.com/u/677704?v=4","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/778/commits","review_comments_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/778/comments","review_comment_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/778/comments","statuses_url":"https://api.github.com/repos/Particular/ServiceInsight/statuses/dae1b3bbbf9ddaf7f1621df0c7c4b731fa09b23f","head":{"label":"Particular:use-knownendpoints","ref":"use-knownendpoints","sha":"dae1b3bbbf9ddaf7f1621df0c7c4b731fa09b23f","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":8025385,"name":"ServiceInsight","full_name":"Particular/ServiceInsight","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceInsight","description":"Advanced debugging for NServiceBus ","fork":false,"url":"https://api.github.com/repos/Particular/ServiceInsight","forks_url":"https://api.github.com/repos/Particular/ServiceInsight/forks","keys_url":"https://api.github.com/repos/Particular/ServiceInsight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceInsight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceInsight/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceInsight/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceInsight/events","assignees_url":"https://api.github.com/repos/Particular/ServiceInsight/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceInsight/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceInsight/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceInsight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceInsight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceInsight/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceInsight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceInsight/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceInsight/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceInsight/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceInsight/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceInsight/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceInsight/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceInsight/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceInsight/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceInsight/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceInsight/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceInsight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceInsight/merges","archive_url":"https://api.github.com/repos/Particular/ServiceInsight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceInsight/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceInsight/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceInsight/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceInsight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceInsight/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceInsight/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceInsight/deployments","created_at":"2013-02-05T08:37:02Z","updated_at":"2018-01-31T03:39:56Z","pushed_at":"2018-02-14T12:44:14Z","git_url":"git://github.com/Particular/ServiceInsight.git","ssh_url":"git@github.com:Particular/ServiceInsight.git","clone_url":"https://github.com/Particular/ServiceInsight.git","svn_url":"https://github.com/Particular/ServiceInsight","homepage":"http://particular.net/serviceinsight","size":86130,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":25,"open_issues":85,"watchers":12,"default_branch":"master"}},"base":{"label":"Particular:master","ref":"master","sha":"563321a8f479bb475b30bfbfdd4c926a37825b05","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":8025385,"name":"ServiceInsight","full_name":"Particular/ServiceInsight","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceInsight","description":"Advanced debugging for NServiceBus ","fork":false,"url":"https://api.github.com/repos/Particular/ServiceInsight","forks_url":"https://api.github.com/repos/Particular/ServiceInsight/forks","keys_url":"https://api.github.com/repos/Particular/ServiceInsight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceInsight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceInsight/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceInsight/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceInsight/events","assignees_url":"https://api.github.com/repos/Particular/ServiceInsight/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceInsight/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceInsight/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceInsight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceInsight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceInsight/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceInsight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceInsight/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceInsight/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceInsight/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceInsight/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceInsight/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceInsight/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceInsight/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceInsight/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceInsight/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceInsight/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceInsight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceInsight/merges","archive_url":"https://api.github.com/repos/Particular/ServiceInsight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceInsight/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceInsight/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceInsight/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceInsight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceInsight/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceInsight/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceInsight/deployments","created_at":"2013-02-05T08:37:02Z","updated_at":"2018-01-31T03:39:56Z","pushed_at":"2018-02-14T12:44:14Z","git_url":"git://github.com/Particular/ServiceInsight.git","ssh_url":"git@github.com:Particular/ServiceInsight.git","clone_url":"https://github.com/Particular/ServiceInsight.git","svn_url":"https://github.com/Particular/ServiceInsight","homepage":"http://particular.net/serviceinsight","size":86130,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":25,"open_issues":85,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/778"},"html":{"href":"https://github.com/Particular/ServiceInsight/pull/778"},"issue":{"href":"https://api.github.com/repos/Particular/ServiceInsight/issues/778"},"comments":{"href":"https://api.github.com/repos/Particular/ServiceInsight/issues/778/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/778/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/778/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/ServiceInsight/statuses/dae1b3bbbf9ddaf7f1621df0c7c4b731fa09b23f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"HEskandari"}}