{"action":"created","comment":{"url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/comments/166624527","pull_request_review_id":94716460,"id":166624527,"diff_hunk":"@@ -28,6 +28,8 @@ namespace {\n         std::uint32_t numFiles;          /**< Number of files located in this sub .arc */\n         std::uint32_t dataPointer;       /**< Pointer to the beginning of the data section */\n         std::uint32_t unused;            /**< Unused DWORD */\n+\n+        static constexpr std::uint32_t expectedMagic = 0x20030507; /**< Expected value of @ref magic. */","path":"source/SH3/arc/subarc.cpp","position":5,"original_position":5,"commit_id":"7c8bda0311d28f4e662fb5d85682b3c49804f5f0","original_commit_id":"7c8bda0311d28f4e662fb5d85682b3c49804f5f0","user":{"login":"z33ky","id":289819,"avatar_url":"https://avatars2.githubusercontent.com/u/289819?v=4","gravatar_id":"","url":"https://api.github.com/users/z33ky","html_url":"https://github.com/z33ky","followers_url":"https://api.github.com/users/z33ky/followers","following_url":"https://api.github.com/users/z33ky/following{/other_user}","gists_url":"https://api.github.com/users/z33ky/gists{/gist_id}","starred_url":"https://api.github.com/users/z33ky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z33ky/subscriptions","organizations_url":"https://api.github.com/users/z33ky/orgs","repos_url":"https://api.github.com/users/z33ky/repos","events_url":"https://api.github.com/users/z33ky/events{/privacy}","received_events_url":"https://api.github.com/users/z33ky/received_events","type":"User","site_admin":false},"body":"It seems we're a little bit inconsistent. See `arcFileNotFound` or our `sh3_gl::vao_target_array`s for instance. We should perhaps try to define a `.clang-format` and run a pass on our code.","created_at":"2018-02-07T14:00:20Z","updated_at":"2018-02-07T14:00:20Z","html_url":"https://github.com/Palm-Studios/sh3redux/pull/123#discussion_r166624527","pull_request_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/123","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/comments/166624527"},"html":{"href":"https://github.com/Palm-Studios/sh3redux/pull/123#discussion_r166624527"},"pull_request":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/123"}},"in_reply_to_id":166615257},"pull_request":{"url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/123","id":166060458,"html_url":"https://github.com/Palm-Studios/sh3redux/pull/123","diff_url":"https://github.com/Palm-Studios/sh3redux/pull/123.diff","patch_url":"https://github.com/Palm-Studios/sh3redux/pull/123.patch","issue_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/123","number":123,"state":"open","locked":false,"title":"Use error struct for sh3::arc::{mft,subarc}::LoadFile","user":{"login":"z33ky","id":289819,"avatar_url":"https://avatars2.githubusercontent.com/u/289819?v=4","gravatar_id":"","url":"https://api.github.com/users/z33ky","html_url":"https://github.com/z33ky","followers_url":"https://api.github.com/users/z33ky/followers","following_url":"https://api.github.com/users/z33ky/following{/other_user}","gists_url":"https://api.github.com/users/z33ky/gists{/gist_id}","starred_url":"https://api.github.com/users/z33ky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z33ky/subscriptions","organizations_url":"https://api.github.com/users/z33ky/orgs","repos_url":"https://api.github.com/users/z33ky/repos","events_url":"https://api.github.com/users/z33ky/events{/privacy}","received_events_url":"https://api.github.com/users/z33ky/received_events","type":"User","site_admin":false},"body":"We're currently not doing much with the error, but that can be changed easily.\r\nI'm also doing more error checking than before.","created_at":"2018-01-30T18:25:27Z","updated_at":"2018-02-07T14:00:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5749eb88dc606e2a215cb1079c56186395e92899","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/123/commits","review_comments_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/123/comments","review_comment_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/123/comments","statuses_url":"https://api.github.com/repos/Palm-Studios/sh3redux/statuses/7c8bda0311d28f4e662fb5d85682b3c49804f5f0","head":{"label":"z33ky:arc_error","ref":"arc_error","sha":"7c8bda0311d28f4e662fb5d85682b3c49804f5f0","user":{"login":"z33ky","id":289819,"avatar_url":"https://avatars2.githubusercontent.com/u/289819?v=4","gravatar_id":"","url":"https://api.github.com/users/z33ky","html_url":"https://github.com/z33ky","followers_url":"https://api.github.com/users/z33ky/followers","following_url":"https://api.github.com/users/z33ky/following{/other_user}","gists_url":"https://api.github.com/users/z33ky/gists{/gist_id}","starred_url":"https://api.github.com/users/z33ky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z33ky/subscriptions","organizations_url":"https://api.github.com/users/z33ky/orgs","repos_url":"https://api.github.com/users/z33ky/repos","events_url":"https://api.github.com/users/z33ky/events{/privacy}","received_events_url":"https://api.github.com/users/z33ky/received_events","type":"User","site_admin":false},"repo":{"id":77642280,"name":"sh3redux","full_name":"z33ky/sh3redux","owner":{"login":"z33ky","id":289819,"avatar_url":"https://avatars2.githubusercontent.com/u/289819?v=4","gravatar_id":"","url":"https://api.github.com/users/z33ky","html_url":"https://github.com/z33ky","followers_url":"https://api.github.com/users/z33ky/followers","following_url":"https://api.github.com/users/z33ky/following{/other_user}","gists_url":"https://api.github.com/users/z33ky/gists{/gist_id}","starred_url":"https://api.github.com/users/z33ky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z33ky/subscriptions","organizations_url":"https://api.github.com/users/z33ky/orgs","repos_url":"https://api.github.com/users/z33ky/repos","events_url":"https://api.github.com/users/z33ky/events{/privacy}","received_events_url":"https://api.github.com/users/z33ky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/z33ky/sh3redux","description":"SILENT HILL 3 Engine Remake in OpenGL and C++","fork":true,"url":"https://api.github.com/repos/z33ky/sh3redux","forks_url":"https://api.github.com/repos/z33ky/sh3redux/forks","keys_url":"https://api.github.com/repos/z33ky/sh3redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/z33ky/sh3redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/z33ky/sh3redux/teams","hooks_url":"https://api.github.com/repos/z33ky/sh3redux/hooks","issue_events_url":"https://api.github.com/repos/z33ky/sh3redux/issues/events{/number}","events_url":"https://api.github.com/repos/z33ky/sh3redux/events","assignees_url":"https://api.github.com/repos/z33ky/sh3redux/assignees{/user}","branches_url":"https://api.github.com/repos/z33ky/sh3redux/branches{/branch}","tags_url":"https://api.github.com/repos/z33ky/sh3redux/tags","blobs_url":"https://api.github.com/repos/z33ky/sh3redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/z33ky/sh3redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/z33ky/sh3redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/z33ky/sh3redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/z33ky/sh3redux/statuses/{sha}","languages_url":"https://api.github.com/repos/z33ky/sh3redux/languages","stargazers_url":"https://api.github.com/repos/z33ky/sh3redux/stargazers","contributors_url":"https://api.github.com/repos/z33ky/sh3redux/contributors","subscribers_url":"https://api.github.com/repos/z33ky/sh3redux/subscribers","subscription_url":"https://api.github.com/repos/z33ky/sh3redux/subscription","commits_url":"https://api.github.com/repos/z33ky/sh3redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/z33ky/sh3redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/z33ky/sh3redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/z33ky/sh3redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/z33ky/sh3redux/contents/{+path}","compare_url":"https://api.github.com/repos/z33ky/sh3redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/z33ky/sh3redux/merges","archive_url":"https://api.github.com/repos/z33ky/sh3redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/z33ky/sh3redux/downloads","issues_url":"https://api.github.com/repos/z33ky/sh3redux/issues{/number}","pulls_url":"https://api.github.com/repos/z33ky/sh3redux/pulls{/number}","milestones_url":"https://api.github.com/repos/z33ky/sh3redux/milestones{/number}","notifications_url":"https://api.github.com/repos/z33ky/sh3redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/z33ky/sh3redux/labels{/name}","releases_url":"https://api.github.com/repos/z33ky/sh3redux/releases{/id}","deployments_url":"https://api.github.com/repos/z33ky/sh3redux/deployments","created_at":"2016-12-29T21:57:51Z","updated_at":"2016-12-29T23:17:00Z","pushed_at":"2018-02-05T19:56:04Z","git_url":"git://github.com/z33ky/sh3redux.git","ssh_url":"git@github.com:z33ky/sh3redux.git","clone_url":"https://github.com/z33ky/sh3redux.git","svn_url":"https://github.com/z33ky/sh3redux","homepage":null,"size":14950,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Palm-Studios:master","ref":"master","sha":"4dc56545a7fd76ddd1940d510c543bb21dbb3ea1","user":{"login":"Palm-Studios","id":24369067,"avatar_url":"https://avatars2.githubusercontent.com/u/24369067?v=4","gravatar_id":"","url":"https://api.github.com/users/Palm-Studios","html_url":"https://github.com/Palm-Studios","followers_url":"https://api.github.com/users/Palm-Studios/followers","following_url":"https://api.github.com/users/Palm-Studios/following{/other_user}","gists_url":"https://api.github.com/users/Palm-Studios/gists{/gist_id}","starred_url":"https://api.github.com/users/Palm-Studios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Palm-Studios/subscriptions","organizations_url":"https://api.github.com/users/Palm-Studios/orgs","repos_url":"https://api.github.com/users/Palm-Studios/repos","events_url":"https://api.github.com/users/Palm-Studios/events{/privacy}","received_events_url":"https://api.github.com/users/Palm-Studios/received_events","type":"Organization","site_admin":false},"repo":{"id":76116619,"name":"sh3redux","full_name":"Palm-Studios/sh3redux","owner":{"login":"Palm-Studios","id":24369067,"avatar_url":"https://avatars2.githubusercontent.com/u/24369067?v=4","gravatar_id":"","url":"https://api.github.com/users/Palm-Studios","html_url":"https://github.com/Palm-Studios","followers_url":"https://api.github.com/users/Palm-Studios/followers","following_url":"https://api.github.com/users/Palm-Studios/following{/other_user}","gists_url":"https://api.github.com/users/Palm-Studios/gists{/gist_id}","starred_url":"https://api.github.com/users/Palm-Studios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Palm-Studios/subscriptions","organizations_url":"https://api.github.com/users/Palm-Studios/orgs","repos_url":"https://api.github.com/users/Palm-Studios/repos","events_url":"https://api.github.com/users/Palm-Studios/events{/privacy}","received_events_url":"https://api.github.com/users/Palm-Studios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Palm-Studios/sh3redux","description":"SILENT HILL 3 Engine Remake in OpenGL and C++","fork":false,"url":"https://api.github.com/repos/Palm-Studios/sh3redux","forks_url":"https://api.github.com/repos/Palm-Studios/sh3redux/forks","keys_url":"https://api.github.com/repos/Palm-Studios/sh3redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Palm-Studios/sh3redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Palm-Studios/sh3redux/teams","hooks_url":"https://api.github.com/repos/Palm-Studios/sh3redux/hooks","issue_events_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/events{/number}","events_url":"https://api.github.com/repos/Palm-Studios/sh3redux/events","assignees_url":"https://api.github.com/repos/Palm-Studios/sh3redux/assignees{/user}","branches_url":"https://api.github.com/repos/Palm-Studios/sh3redux/branches{/branch}","tags_url":"https://api.github.com/repos/Palm-Studios/sh3redux/tags","blobs_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Palm-Studios/sh3redux/statuses/{sha}","languages_url":"https://api.github.com/repos/Palm-Studios/sh3redux/languages","stargazers_url":"https://api.github.com/repos/Palm-Studios/sh3redux/stargazers","contributors_url":"https://api.github.com/repos/Palm-Studios/sh3redux/contributors","subscribers_url":"https://api.github.com/repos/Palm-Studios/sh3redux/subscribers","subscription_url":"https://api.github.com/repos/Palm-Studios/sh3redux/subscription","commits_url":"https://api.github.com/repos/Palm-Studios/sh3redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Palm-Studios/sh3redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Palm-Studios/sh3redux/contents/{+path}","compare_url":"https://api.github.com/repos/Palm-Studios/sh3redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Palm-Studios/sh3redux/merges","archive_url":"https://api.github.com/repos/Palm-Studios/sh3redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Palm-Studios/sh3redux/downloads","issues_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues{/number}","pulls_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls{/number}","milestones_url":"https://api.github.com/repos/Palm-Studios/sh3redux/milestones{/number}","notifications_url":"https://api.github.com/repos/Palm-Studios/sh3redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Palm-Studios/sh3redux/labels{/name}","releases_url":"https://api.github.com/repos/Palm-Studios/sh3redux/releases{/id}","deployments_url":"https://api.github.com/repos/Palm-Studios/sh3redux/deployments","created_at":"2016-12-10T14:13:46Z","updated_at":"2018-02-01T10:42:26Z","pushed_at":"2018-02-07T13:22:50Z","git_url":"git://github.com/Palm-Studios/sh3redux.git","ssh_url":"git@github.com:Palm-Studios/sh3redux.git","clone_url":"https://github.com/Palm-Studios/sh3redux.git","svn_url":"https://github.com/Palm-Studios/sh3redux","homepage":null,"size":14957,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":5,"open_issues":14,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/123"},"html":{"href":"https://github.com/Palm-Studios/sh3redux/pull/123"},"issue":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/123"},"comments":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/statuses/7c8bda0311d28f4e662fb5d85682b3c49804f5f0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"z33ky"}}