{"action":"created","issue":{"url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2782","repository_url":"https://api.github.com/repos/TerriaJS/terriajs","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2782/labels{/name}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2782/comments","events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2782/events","html_url":"https://github.com/TerriaJS/terriajs/pull/2782","id":286613803,"number":2782,"title":"[#2658] Add ability to get and format the current timeline time in feature info template. / Partial [#2736] Fix feature info updating when clock updates for TableCatalogItems","user":{"login":"a-stacey","id":4453477,"avatar_url":"https://avatars0.githubusercontent.com/u/4453477?v=4","gravatar_id":"","url":"https://api.github.com/users/a-stacey","html_url":"https://github.com/a-stacey","followers_url":"https://api.github.com/users/a-stacey/followers","following_url":"https://api.github.com/users/a-stacey/following{/other_user}","gists_url":"https://api.github.com/users/a-stacey/gists{/gist_id}","starred_url":"https://api.github.com/users/a-stacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-stacey/subscriptions","organizations_url":"https://api.github.com/users/a-stacey/orgs","repos_url":"https://api.github.com/users/a-stacey/repos","events_url":"https://api.github.com/users/a-stacey/events{/privacy}","received_events_url":"https://api.github.com/users/a-stacey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-01-08T00:07:57Z","updated_at":"2018-02-26T02:48:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2782","html_url":"https://github.com/TerriaJS/terriajs/pull/2782","diff_url":"https://github.com/TerriaJS/terriajs/pull/2782.diff","patch_url":"https://github.com/TerriaJS/terriajs/pull/2782.patch"},"body":"I used `dateFormat` since it already seemed to have precedent in the codebase and the formatting seems sane enough compared to what you would implicitly expect.\r\n\r\n\r\n---\r\nFrom #2831:\r\nThis PR is only aimed at fixing part of #2736.\r\n\r\n>    Feature info for TableCatalogItem updates when the time is changed using the timeline (including the date picker on the timeline), but it does not update when using the date picker on the workbench. Fixing this is tricky because there's currently no event that gets raised when the time changes via that mechanism, so the FeatureInfoSection can't subscribe to it.\r\n"},"comment":{"url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments/368375219","html_url":"https://github.com/TerriaJS/terriajs/pull/2782#issuecomment-368375219","issue_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2782","id":368375219,"user":{"login":"a-stacey","id":4453477,"avatar_url":"https://avatars0.githubusercontent.com/u/4453477?v=4","gravatar_id":"","url":"https://api.github.com/users/a-stacey","html_url":"https://github.com/a-stacey","followers_url":"https://api.github.com/users/a-stacey/followers","following_url":"https://api.github.com/users/a-stacey/following{/other_user}","gists_url":"https://api.github.com/users/a-stacey/gists{/gist_id}","starred_url":"https://api.github.com/users/a-stacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-stacey/subscriptions","organizations_url":"https://api.github.com/users/a-stacey/orgs","repos_url":"https://api.github.com/users/a-stacey/repos","events_url":"https://api.github.com/users/a-stacey/events{/privacy}","received_events_url":"https://api.github.com/users/a-stacey/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T02:48:39Z","updated_at":"2018-02-26T02:48:39Z","author_association":"CONTRIBUTOR","body":"So in response to the above question. This was my initial feeling to that I noticed when evaluated merging the code. \r\n\r\nTesting this seems to be fine (to remove) where the template subs in the current time, but not when you aren't explicitly using the time and the time does indirectly effect the values through: `setCurrentFeatureValues` -> `propertyGetTimeValues(feature.properties, clock) / getCurrentDescription(feature, currentTime)`"}}
{"actor":{"display_login":"a-stacey"}}