{"action":"created","issue":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/645","repository_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/645/labels{/name}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/645/comments","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/645/events","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/645","id":296765338,"number":645,"title":"Ticket2893 add ioc ilm200","user":{"login":"AdrianPotter","id":10273443,"avatar_url":"https://avatars1.githubusercontent.com/u/10273443?v=4","gravatar_id":"","url":"https://api.github.com/users/AdrianPotter","html_url":"https://github.com/AdrianPotter","followers_url":"https://api.github.com/users/AdrianPotter/followers","following_url":"https://api.github.com/users/AdrianPotter/following{/other_user}","gists_url":"https://api.github.com/users/AdrianPotter/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianPotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianPotter/subscriptions","organizations_url":"https://api.github.com/users/AdrianPotter/orgs","repos_url":"https://api.github.com/users/AdrianPotter/repos","events_url":"https://api.github.com/users/AdrianPotter/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianPotter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-13T14:54:57Z","updated_at":"2018-02-14T09:54:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/645","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/645","diff_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/645.diff","patch_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/645.patch"},"body":"### Description of work\r\n\r\nAdd IOC for Oxford Instruments ILM 200 series. The current OPI reproduces the functionality available via the VI front panel:\r\n\r\nC:\\LabVIEW Modules\\Oxford Software\\ilmapps.llb\\ILMFrontPanel.vi\r\n\r\nI've emailed the cryo team to see if they need the more detailed panel at:\r\n\r\nC:\\LabVIEW Modules\\Oxford Software\\ILMSUBS.LLB\\ILMReadStatus.vi\r\n\r\nIf they do I'll open it as a separate ticket. They would still be able to access this advanced panel via the VI if needed in the mean time.\r\n\r\n### To test\r\n\r\nhttps://github.com/ISISComputingGroup/IBEX/issues/2893\r\n\r\n### Acceptance criteria\r\n\r\nOPI provides a suitable interface to the GEM ILM 200 series.\r\n\r\n### Unit tests\r\n\r\nOPI only\r\n\r\n### System tests\r\n\r\nOPI only\r\n\r\n### Documentation\r\n\r\nI've added a copy of the manual to the network share\r\n---\r\n\r\n#### Code Review\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Do the changes function as described and is it robust?\r\n- [ ] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev)?\r\n\r\n### Final Steps\r\n- [ ] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments/365551980","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/645#issuecomment-365551980","issue_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/645","id":365551980,"user":{"login":"Tom-Willemsen","id":24375813,"avatar_url":"https://avatars1.githubusercontent.com/u/24375813?v=4","gravatar_id":"","url":"https://api.github.com/users/Tom-Willemsen","html_url":"https://github.com/Tom-Willemsen","followers_url":"https://api.github.com/users/Tom-Willemsen/followers","following_url":"https://api.github.com/users/Tom-Willemsen/following{/other_user}","gists_url":"https://api.github.com/users/Tom-Willemsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom-Willemsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom-Willemsen/subscriptions","organizations_url":"https://api.github.com/users/Tom-Willemsen/orgs","repos_url":"https://api.github.com/users/Tom-Willemsen/repos","events_url":"https://api.github.com/users/Tom-Willemsen/events{/privacy}","received_events_url":"https://api.github.com/users/Tom-Willemsen/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T09:54:33Z","updated_at":"2018-02-14T09:54:33Z","author_association":"CONTRIBUTOR","body":"nit: opi is labelled \"Gas type\", but none of the substances involved are gases."}}
{"actor":{"display_login":"Tom-Willemsen"}}