{"push_id":2766676408,"size":52,"distinct_size":3,"ref":"refs/heads/bg/route-metric-reapply-rh1528071","head":"52b4f3514df4801f8bf5b179e8c277e349b7da26","before":"9472097d8d5d91669775d4f50cf3013ed673bff6","commits":[{"sha":"3f449654f73b58d920f512dc223304bc28f2a4d9","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"contrib/rpm: use whitespace consistently\n\nDouble newline is used to visually separate sections.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/3f449654f73b58d920f512dc223304bc28f2a4d9"},{"sha":"c40dbeb49a3a334b6f41b4d717fdc8e3b76b661a","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"contrib/rpm: add RHEL connectivity checking package\n\nhttps://github.com/NetworkManager/NetworkManager/pull/166","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/c40dbeb49a3a334b6f41b4d717fdc8e3b76b661a"},{"sha":"159ff23268b13aedcaffd1a27c279d8476cf6503","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"dhcp/dhclient-utils: skip over dhclient.conf blocks\n\nExtend the lame-ass dhclient.conf parser to ignore the blocks we can't\ndo anything useful about: alias{}, pseudo{} and even lease{}.\n\nNote that there's still a lot of cases we can't handle without a\nfull-fledged dhclient.conf parser -- notably the files that don't use\nline breaks to separate the statements.\n\nThat is probably okay -- the whole thing is probably mostly useless and\nwe shall ever bother only about cases that actually cause trouble.\n\nhttps://github.com/NetworkManager/NetworkManager/pull/153","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/159ff23268b13aedcaffd1a27c279d8476cf6503"},{"sha":"0d3bb64008271fb2eb8efba90e4c0e06fd743fb1","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared: support zero arguments for NM_NARG() macro\n\nIt relies on the GCC extension ##__VA_ARGS__, but we\ndo that on various places already.\n\nAlso add a test.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/0d3bb64008271fb2eb8efba90e4c0e06fd743fb1"},{"sha":"0ee782d03ecacf31a7d5d74c514ce7157cd04422","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared: add nm_utils_error_set*() helper macros\n\nAdd helper macros to type less.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/0ee782d03ecacf31a7d5d74c514ce7157cd04422"},{"sha":"39f47e2f7e8c0f9dd26aacb822500c6e40cc3b04","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"wwan/trivial: rename NMModemClass.check_connection_compatible() to use unique name\n\nWe also have NMDeviceClass.check_connection_compatible(). It is preferable\nto use unique names, especially for the virtual function table. A reasonable\nthing to do is grep for the function name to find all places that implement\nthis function. But if different classes use the same name, grep just\nturns up annoying false positives.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/39f47e2f7e8c0f9dd26aacb822500c6e40cc3b04"},{"sha":"c3ab0ed60f35ad0a081066eb7eb5da6d3bf71c18","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device/trivial: rename parent-class variable in device class constructor\n\nThe majority of device implementations name their parent-class variable\n\"device_class\". That also makes more sense as it is more consistant.\nE.g. \"parent\" sounds like it's the direct parent, but that is not\nthe crucial point here. The crucial point at this place, is that we\naccess the NMDeviceClass typed pointer. Rename.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/c3ab0ed60f35ad0a081066eb7eb5da6d3bf71c18"},{"sha":"0b8e1fd9711ba1bdb6d84dc7585d1e706882bb31","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core/trival: rename nm_device_match_hwaddr() function to nm_device_match_parent_hwaddr()\n\nThis name is better, because it compares the MAC address of the device's\nparent.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/0b8e1fd9711ba1bdb6d84dc7585d1e706882bb31"},{"sha":"b9ae79c273b069f48ea458855f5a3f1873b99e9c","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device/trivial: rename NMDeviceClass.connection_type to connection_type_supported\n\nThe term \"connection_type\" is overused. Give it a more distinct name.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/b9ae79c273b069f48ea458855f5a3f1873b99e9c"},{"sha":"0cbf2c8c2ae3311bae688449dea4cfa21f4293e6","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device: wrap NM_DEVICE_CLASS_DECLARE_TYPES() macro with do-while block","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/0cbf2c8c2ae3311bae688449dea4cfa21f4293e6"},{"sha":"87a60c4596d097913977f14ceca2c76fda517092","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device: use NM_DEVICE_CLASS_DECLARE_TYPES() to set connection_type_supported of device class\n\nthe macro already does it just fine. Use it.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/87a60c4596d097913977f14ceca2c76fda517092"},{"sha":"c9883b85a246502f1a9cb4704b51707635c4d7b8","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device: also use NM_DEVICE_CLASS_DECLARE_TYPES() for types without link-types\n\nNMDeviceOvsPort and NMDeviceOvsInterface don't have an underlying link-type from platform.\nStill use NM_DEVICE_CLASS_DECLARE_TYPES() macro, for consistancy reasons.\n\nThis requires to extend NM_DEVICE_CLASS_DECLARE_TYPES() macro, to support\na variadic argument list with zero link-types.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/c9883b85a246502f1a9cb4704b51707635c4d7b8"},{"sha":"2ce416796772205e006c0a66188e0379465f0bfa","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device: replace NM_DEVICE_CLASS_DECLARE_TYPES() macro by explicit initialization\n\nIt seems to me the NM_DEVICE_CLASS_DECLARE_TYPES() macro confuses more\nthan helping. Let's explicitly initialize the two fields, albeit with\nanother helper macro NM_DEVICE_DEFINE_LINK_TYPES() to get the list of\nlink-types right.\n\nFor consistency, also leave nop-lines like\n\n  device_class->connection_type_supported = NULL;\n  device_class->link_types = NM_DEVICE_DEFINE_LINK_TYPES ();\n\nbecause all NMDevice class init methods should have this same\nboiler plate code and to make it explicit that this is intended.\nAnd there are only 3 occurences where this actually comes into play.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/2ce416796772205e006c0a66188e0379465f0bfa"},{"sha":"246b74754048e90ab2bd7e6ad9258b6948c47b82","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared: add special error codes to NM_UTILS_ERROR\n\nWill be used next.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/246b74754048e90ab2bd7e6ad9258b6948c47b82"},{"sha":"570e1fa75b3369eb324afceb32d15f2ba2051df7","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: give better error reason why device is unavailable\n\nThe error reason is still unused.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/570e1fa75b3369eb324afceb32d15f2ba2051df7"},{"sha":"33a88ca566e87adce9102c3389568dfa0e200c85","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: give better error reason why device is incompatible with profile\n\nNote the special error codes  NM_UTILS_ERROR_CONNECTION_AVAILABLE_*.\nThis will be used to determine, whether the profile is fundamentally\nincompatible with the device, or whether just some other properties\nmismatch. That information will be importand during a plain `nmcli\nconnection up`, where NetworkManager searches all devices for a device\nto activate. If no device is found (and multiple errors happened),\nwe want to show the error that is most likely relevant for the user.\n\nAlso note, how NMDevice's check_connection_compatible() uses the new\nclass field \"device_class->connection_type_check_compatible\" to simplify\nchecks for compatible profiles.\n\nThe error reason is still unused.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/33a88ca566e87adce9102c3389568dfa0e200c85"},{"sha":"7bad40109ecb8ed9569e24fd64892a3cad916133","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: return error reason from nm_manager_get_best_device_for_connection()\n\nStill unused, but will be used to give a better failure reason when\nno device is found.\n\nThe difficulty here is to select the failure message from the most appropriate\ndevice. This might still need some tweaking by setting the error codes accordingly\nand re-ordering checks so that failure cares that are more accurate are handled\nfirst.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/7bad40109ecb8ed9569e24fd64892a3cad916133"},{"sha":"e9f6bb0bbb5404a1bc4ecdb3b1812970fa2c98c4","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: improve error message when activating profile on device\n\nBefore:\n\n    $ nmcli connection up my-wired ifname eth0\n    Error: Connection activation failed: Connection 'my-wired' is not available on the device eth0 at this time.\n\nAfter:\n\n    $ nmcli connection up my-wired ifname eth0\n    Error: Connection activation failed: Connection 'my-wired' is not available on device eth0 because device has no carrier","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/e9f6bb0bbb5404a1bc4ecdb3b1812970fa2c98c4"},{"sha":"3000ade72af4373f3a53e2b6d02d54fc3ce33513","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: improve error message when activating profile\n\nBefore:\n\n    $ nmcli connection up my-wired\n    Error: Connection activation failed: No suitable device found for this connection.\n\nAfter:\n\n    $ nmcli connection up my-wired\n    Error: Connection activation failed: No suitable device found for this connection (device eth0 not available because device has no carrier).\n\nThis relies on nm_manager_get_best_device_for_connection() giving a\nsuitable error. That is however a bit complicated, because if no\nsuitable device is found, it's not immediately clear what is the\nexact reason. E.g. if you try to activate a Wi-Fi profile, the\nfailure reason\n\n    \"SSID is not visible\"\n\nis better than\n\n    \"Wi-Fi profile cannot activate on ethernet device\".\n\nThis is controlled by carefully setting the failure codes\nNM_UTILS_ERROR_CONNECTION_AVAILABLE_* to indicate an absolute\nrelevance of the failure. And subsequently, by selecting the failure\nwith the highest relevance. This might still need some improvements,\nfor example by reordering checks (so that more relevant failures\nare handled first) and tweaking the error relevance.","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/3000ade72af4373f3a53e2b6d02d54fc3ce33513"},{"sha":"a6f51fffa1b8fbc38f93f86735b18c8539faba1d","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device: merge branch 'th/not-available-reason'\n\nhttps://github.com/NetworkManager/NetworkManager/pull/163","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/a6f51fffa1b8fbc38f93f86735b18c8539faba1d"}]}
{"actor":{"display_login":"fdo-mirror"}}