{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/comments/183134032","pull_request_review_id":114081029,"id":183134032,"diff_hunk":"@@ -219,20 +219,38 @@ impl<R: BlockRngCore> BlockRng<R> {\n     }\n \n     /// Return a reference the wrapped `BlockRngCore`.\n+    #[inline(always)]","path":"rand_core/src/impls.rs","position":4,"original_position":4,"commit_id":"5314b0ac5f95a1cb659dbc343f1099002f18d99a","original_commit_id":"5314b0ac5f95a1cb659dbc343f1099002f18d99a","user":{"login":"pitdicker","id":6255050,"avatar_url":"https://avatars1.githubusercontent.com/u/6255050?v=4","gravatar_id":"","url":"https://api.github.com/users/pitdicker","html_url":"https://github.com/pitdicker","followers_url":"https://api.github.com/users/pitdicker/followers","following_url":"https://api.github.com/users/pitdicker/following{/other_user}","gists_url":"https://api.github.com/users/pitdicker/gists{/gist_id}","starred_url":"https://api.github.com/users/pitdicker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitdicker/subscriptions","organizations_url":"https://api.github.com/users/pitdicker/orgs","repos_url":"https://api.github.com/users/pitdicker/repos","events_url":"https://api.github.com/users/pitdicker/events{/privacy}","received_events_url":"https://api.github.com/users/pitdicker/received_events","type":"User","site_admin":false},"body":"Just curious: did inlining turn out to be necessary, or did you just inline all methods?","created_at":"2018-04-20T18:26:38Z","updated_at":"2018-04-20T18:50:44Z","html_url":"https://github.com/rust-lang-nursery/rand/pull/374#discussion_r183134032","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/374","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/comments/183134032"},"html":{"href":"https://github.com/rust-lang-nursery/rand/pull/374#discussion_r183134032"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/374"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/374","id":179648625,"html_url":"https://github.com/rust-lang-nursery/rand/pull/374","diff_url":"https://github.com/rust-lang-nursery/rand/pull/374.diff","patch_url":"https://github.com/rust-lang-nursery/rand/pull/374.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/rand/issues/374","number":374,"state":"open","locked":false,"title":"ChaCha: support reading counter and setting nonce","user":{"login":"dhardy","id":134893,"avatar_url":"https://avatars1.githubusercontent.com/u/134893?v=4","gravatar_id":"","url":"https://api.github.com/users/dhardy","html_url":"https://github.com/dhardy","followers_url":"https://api.github.com/users/dhardy/followers","following_url":"https://api.github.com/users/dhardy/following{/other_user}","gists_url":"https://api.github.com/users/dhardy/gists{/gist_id}","starred_url":"https://api.github.com/users/dhardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhardy/subscriptions","organizations_url":"https://api.github.com/users/dhardy/orgs","repos_url":"https://api.github.com/users/dhardy/repos","events_url":"https://api.github.com/users/dhardy/events{/privacy}","received_events_url":"https://api.github.com/users/dhardy/received_events","type":"User","site_admin":false},"body":"Part of #349 @burdges @pitdicker \r\n\r\n- Adjust `set_counter` to take only a single 64-bit counter\r\n- Add `get_counter`\r\n- Add 128-bit variants (more for completeness and because there isn't another way to read the nonce, but maybe they shouldn't be there?)\r\n- Add functions to set the nonce\r\n\r\nThis doesn't resolve the issue about setting rounds yet.\r\n\r\nAlso this removes functionality from `ChaChaCore` but I assume that will not be used directly (except within `ReseedingRng` where these functions aren't useful anyway).","created_at":"2018-04-05T11:35:01Z","updated_at":"2018-04-20T18:50:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"958021f387c30ea3274a7b3da8aa0222d94fc110","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":626813540,"url":"https://api.github.com/repos/rust-lang-nursery/rand/labels/B-API","name":"B-API","color":"ff8000","default":false},{"id":173092859,"url":"https://api.github.com/repos/rust-lang-nursery/rand/labels/E-question","name":"E-question","color":"00ffaa","default":false},{"id":864763173,"url":"https://api.github.com/repos/rust-lang-nursery/rand/labels/P-medium","name":"P-medium","color":"d46ad4","default":false},{"id":866963732,"url":"https://api.github.com/repos/rust-lang-nursery/rand/labels/X-discussion","name":"X-discussion","color":"bfbfbf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/374/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/374/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rand/issues/374/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rand/statuses/5314b0ac5f95a1cb659dbc343f1099002f18d99a","head":{"label":"dhardy:chacha","ref":"chacha","sha":"5314b0ac5f95a1cb659dbc343f1099002f18d99a","user":{"login":"dhardy","id":134893,"avatar_url":"https://avatars1.githubusercontent.com/u/134893?v=4","gravatar_id":"","url":"https://api.github.com/users/dhardy","html_url":"https://github.com/dhardy","followers_url":"https://api.github.com/users/dhardy/followers","following_url":"https://api.github.com/users/dhardy/following{/other_user}","gists_url":"https://api.github.com/users/dhardy/gists{/gist_id}","starred_url":"https://api.github.com/users/dhardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhardy/subscriptions","organizations_url":"https://api.github.com/users/dhardy/orgs","repos_url":"https://api.github.com/users/dhardy/repos","events_url":"https://api.github.com/users/dhardy/events{/privacy}","received_events_url":"https://api.github.com/users/dhardy/received_events","type":"User","site_admin":false},"repo":{"id":98670438,"name":"rand","full_name":"dhardy/rand","owner":{"login":"dhardy","id":134893,"avatar_url":"https://avatars1.githubusercontent.com/u/134893?v=4","gravatar_id":"","url":"https://api.github.com/users/dhardy","html_url":"https://github.com/dhardy","followers_url":"https://api.github.com/users/dhardy/followers","following_url":"https://api.github.com/users/dhardy/following{/other_user}","gists_url":"https://api.github.com/users/dhardy/gists{/gist_id}","starred_url":"https://api.github.com/users/dhardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhardy/subscriptions","organizations_url":"https://api.github.com/users/dhardy/orgs","repos_url":"https://api.github.com/users/dhardy/repos","events_url":"https://api.github.com/users/dhardy/events{/privacy}","received_events_url":"https://api.github.com/users/dhardy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhardy/rand","description":null,"fork":true,"url":"https://api.github.com/repos/dhardy/rand","forks_url":"https://api.github.com/repos/dhardy/rand/forks","keys_url":"https://api.github.com/repos/dhardy/rand/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhardy/rand/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhardy/rand/teams","hooks_url":"https://api.github.com/repos/dhardy/rand/hooks","issue_events_url":"https://api.github.com/repos/dhardy/rand/issues/events{/number}","events_url":"https://api.github.com/repos/dhardy/rand/events","assignees_url":"https://api.github.com/repos/dhardy/rand/assignees{/user}","branches_url":"https://api.github.com/repos/dhardy/rand/branches{/branch}","tags_url":"https://api.github.com/repos/dhardy/rand/tags","blobs_url":"https://api.github.com/repos/dhardy/rand/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhardy/rand/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhardy/rand/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhardy/rand/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhardy/rand/statuses/{sha}","languages_url":"https://api.github.com/repos/dhardy/rand/languages","stargazers_url":"https://api.github.com/repos/dhardy/rand/stargazers","contributors_url":"https://api.github.com/repos/dhardy/rand/contributors","subscribers_url":"https://api.github.com/repos/dhardy/rand/subscribers","subscription_url":"https://api.github.com/repos/dhardy/rand/subscription","commits_url":"https://api.github.com/repos/dhardy/rand/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhardy/rand/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhardy/rand/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhardy/rand/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhardy/rand/contents/{+path}","compare_url":"https://api.github.com/repos/dhardy/rand/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhardy/rand/merges","archive_url":"https://api.github.com/repos/dhardy/rand/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhardy/rand/downloads","issues_url":"https://api.github.com/repos/dhardy/rand/issues{/number}","pulls_url":"https://api.github.com/repos/dhardy/rand/pulls{/number}","milestones_url":"https://api.github.com/repos/dhardy/rand/milestones{/number}","notifications_url":"https://api.github.com/repos/dhardy/rand/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhardy/rand/labels{/name}","releases_url":"https://api.github.com/repos/dhardy/rand/releases{/id}","deployments_url":"https://api.github.com/repos/dhardy/rand/deployments","created_at":"2017-07-28T17:04:25Z","updated_at":"2017-12-12T14:37:55Z","pushed_at":"2018-04-20T15:36:27Z","git_url":"git://github.com/dhardy/rand.git","ssh_url":"git@github.com:dhardy/rand.git","clone_url":"https://github.com/dhardy/rand.git","svn_url":"https://github.com/dhardy/rand","homepage":"http://doc.rust-lang.org/rand","size":93955,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":9,"watchers":2,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"8c5b0ac51dd95a7d67dd06b85309cea5d1fb7488","user":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":30227790,"name":"rand","full_name":"rust-lang-nursery/rand","owner":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/rand","description":null,"fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/rand","forks_url":"https://api.github.com/repos/rust-lang-nursery/rand/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/rand/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/rand/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/rand/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/rand/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/rand/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/rand/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/rand/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/rand/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/rand/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/rand/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/rand/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/rand/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/rand/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rand/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/rand/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/rand/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/rand/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/rand/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/rand/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/rand/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/rand/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rand/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/rand/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/rand/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/rand/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/rand/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/rand/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/rand/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/rand/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/rand/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/rand/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/rand/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/rand/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/rand/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/rand/deployments","created_at":"2015-02-03T05:59:32Z","updated_at":"2018-04-20T18:25:12Z","pushed_at":"2018-04-20T18:37:15Z","git_url":"git://github.com/rust-lang-nursery/rand.git","ssh_url":"git@github.com:rust-lang-nursery/rand.git","clone_url":"https://github.com/rust-lang-nursery/rand.git","svn_url":"https://github.com/rust-lang-nursery/rand","homepage":"https://docs.rs/rand","size":85705,"stargazers_count":177,"watchers_count":177,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":125,"open_issues":45,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/374"},"html":{"href":"https://github.com/rust-lang-nursery/rand/pull/374"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/issues/374"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/issues/374/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/374/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/pulls/374/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/rand/statuses/5314b0ac5f95a1cb659dbc343f1099002f18d99a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pitdicker"}}