{"action":"created","comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments/243395637","pull_request_review_id":187155831,"id":243395637,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM5NTYzNw==","diff_hunk":"@@ -125,55 +123,55 @@ TEUCHOS_STATIC_SETUP()\n // gbl_num_columns: Max # of columns in the matrix-representation of the graph.\n //                  This should be >= the highest value of v from all edges (u,v) in edges.\n //                  Note: u and v are 0-indexed, so if the highest v is 11, then this should be 12.\n-template<class LO, class GO, class Node, class comm_t>\n-Teuchos::RCP<Tpetra::CrsGraph<LO, GO, Node>>\n-generate_crsgraph(Teuchos::RCP<comm_t>                      comm,\n-                  const std::vector<std::pair<GO, GO>>&     gbl_edges,\n-                  const std::vector<std::pair<GO, size_t>>& gbl_row_owners,\n-                  const size_t                              gbl_num_columns,\n-                  const bool                                do_fillComplete=true)\n+template<class LO, class GO, class Node>\n+Teuchos::RCP<Tpetra::CrsGraph<LO, GO, Node> >\n+generate_crsgraph(Teuchos::RCP<Teuchos::Comm<int> >&      comm,","path":"packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests_Swap.cpp","position":22,"original_position":22,"commit_id":"039aef01be36c4e485a67843ad5d6c68fcb31d51","original_commit_id":"039aef01be36c4e485a67843ad5d6c68fcb31d51","user":{"login":"william76","id":263654,"node_id":"MDQ6VXNlcjI2MzY1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/263654?v=4","gravatar_id":"","url":"https://api.github.com/users/william76","html_url":"https://github.com/william76","followers_url":"https://api.github.com/users/william76/followers","following_url":"https://api.github.com/users/william76/following{/other_user}","gists_url":"https://api.github.com/users/william76/gists{/gist_id}","starred_url":"https://api.github.com/users/william76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william76/subscriptions","organizations_url":"https://api.github.com/users/william76/orgs","repos_url":"https://api.github.com/users/william76/repos","events_url":"https://api.github.com/users/william76/events{/privacy}","received_events_url":"https://api.github.com/users/william76/received_events","type":"User","site_admin":false},"body":"@mhoemmen just to clarify, the only change here would be to make this a const, right?\r\n\r\nThat's easy enough to do and probably best to just do today before I forget about it over the break.  I can throw that in and shoot off a new PR for it.","created_at":"2018-12-20T19:44:15Z","updated_at":"2018-12-20T19:44:16Z","html_url":"https://github.com/trilinos/Trilinos/pull/4089#discussion_r243395637","pull_request_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/4089","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments/243395637"},"html":{"href":"https://github.com/trilinos/Trilinos/pull/4089#discussion_r243395637"},"pull_request":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/4089"}},"in_reply_to_id":243132529},"pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/4089","id":239908363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTA4MzYz","html_url":"https://github.com/trilinos/Trilinos/pull/4089","diff_url":"https://github.com/trilinos/Trilinos/pull/4089.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/4089.patch","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/4089","number":4089,"state":"closed","locked":false,"title":"Tpetra: Clean up CrsGraph::Swap testing","user":{"login":"william76","id":263654,"node_id":"MDQ6VXNlcjI2MzY1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/263654?v=4","gravatar_id":"","url":"https://api.github.com/users/william76","html_url":"https://github.com/william76","followers_url":"https://api.github.com/users/william76/followers","following_url":"https://api.github.com/users/william76/following{/other_user}","gists_url":"https://api.github.com/users/william76/gists{/gist_id}","starred_url":"https://api.github.com/users/william76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william76/subscriptions","organizations_url":"https://api.github.com/users/william76/orgs","repos_url":"https://api.github.com/users/william76/repos","events_url":"https://api.github.com/users/william76/events{/privacy}","received_events_url":"https://api.github.com/users/william76/received_events","type":"User","site_admin":false},"body":"@trilinos/tpetra\r\n\r\nThere were some `#if 0` blocks in the test which needed to be changed to use `Tpetra::Details::Behavior::verbose()` for consistency.\r\n\r\nThis PR is convenient as well for testing changes to PR jobs on Jenkins for @trilinos/framework for #4065 =) . ","created_at":"2018-12-19T16:59:55Z","updated_at":"2018-12-20T19:44:16Z","closed_at":"2018-12-20T04:37:14Z","merged_at":"2018-12-20T04:37:14Z","merge_commit_sha":"8fb669191d790b69d956be3127dc8b1f81e15417","assignee":{"login":"william76","id":263654,"node_id":"MDQ6VXNlcjI2MzY1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/263654?v=4","gravatar_id":"","url":"https://api.github.com/users/william76","html_url":"https://github.com/william76","followers_url":"https://api.github.com/users/william76/followers","following_url":"https://api.github.com/users/william76/following{/other_user}","gists_url":"https://api.github.com/users/william76/gists{/gist_id}","starred_url":"https://api.github.com/users/william76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william76/subscriptions","organizations_url":"https://api.github.com/users/william76/orgs","repos_url":"https://api.github.com/users/william76/repos","events_url":"https://api.github.com/users/william76/events{/privacy}","received_events_url":"https://api.github.com/users/william76/received_events","type":"User","site_admin":false},"assignees":[{"login":"william76","id":263654,"node_id":"MDQ6VXNlcjI2MzY1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/263654?v=4","gravatar_id":"","url":"https://api.github.com/users/william76","html_url":"https://github.com/william76","followers_url":"https://api.github.com/users/william76/followers","following_url":"https://api.github.com/users/william76/following{/other_user}","gists_url":"https://api.github.com/users/william76/gists{/gist_id}","starred_url":"https://api.github.com/users/william76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william76/subscriptions","organizations_url":"https://api.github.com/users/william76/orgs","repos_url":"https://api.github.com/users/william76/repos","events_url":"https://api.github.com/users/william76/events{/privacy}","received_events_url":"https://api.github.com/users/william76/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"csiefer2","id":8304471,"node_id":"MDQ6VXNlcjgzMDQ0NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/8304471?v=4","gravatar_id":"","url":"https://api.github.com/users/csiefer2","html_url":"https://github.com/csiefer2","followers_url":"https://api.github.com/users/csiefer2/followers","following_url":"https://api.github.com/users/csiefer2/following{/other_user}","gists_url":"https://api.github.com/users/csiefer2/gists{/gist_id}","starred_url":"https://api.github.com/users/csiefer2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csiefer2/subscriptions","organizations_url":"https://api.github.com/users/csiefer2/orgs","repos_url":"https://api.github.com/users/csiefer2/repos","events_url":"https://api.github.com/users/csiefer2/events{/privacy}","received_events_url":"https://api.github.com/users/csiefer2/received_events","type":"User","site_admin":false},{"login":"kddevin","id":9597421,"node_id":"MDQ6VXNlcjk1OTc0MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9597421?v=4","gravatar_id":"","url":"https://api.github.com/users/kddevin","html_url":"https://github.com/kddevin","followers_url":"https://api.github.com/users/kddevin/followers","following_url":"https://api.github.com/users/kddevin/following{/other_user}","gists_url":"https://api.github.com/users/kddevin/gists{/gist_id}","starred_url":"https://api.github.com/users/kddevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kddevin/subscriptions","organizations_url":"https://api.github.com/users/kddevin/orgs","repos_url":"https://api.github.com/users/kddevin/repos","events_url":"https://api.github.com/users/kddevin/events{/privacy}","received_events_url":"https://api.github.com/users/kddevin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":289606028,"node_id":"MDU6TGFiZWwyODk2MDYwMjg=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/pkg:%20Tpetra","name":"pkg: Tpetra","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/4089/commits","review_comments_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/4089/comments","review_comment_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/4089/comments","statuses_url":"https://api.github.com/repos/trilinos/Trilinos/statuses/039aef01be36c4e485a67843ad5d6c68fcb31d51","head":{"label":"william76:Tpetra-CrsGraph-Swap-TestCleanup","ref":"Tpetra-CrsGraph-Swap-TestCleanup","sha":"039aef01be36c4e485a67843ad5d6c68fcb31d51","user":{"login":"william76","id":263654,"node_id":"MDQ6VXNlcjI2MzY1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/263654?v=4","gravatar_id":"","url":"https://api.github.com/users/william76","html_url":"https://github.com/william76","followers_url":"https://api.github.com/users/william76/followers","following_url":"https://api.github.com/users/william76/following{/other_user}","gists_url":"https://api.github.com/users/william76/gists{/gist_id}","starred_url":"https://api.github.com/users/william76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william76/subscriptions","organizations_url":"https://api.github.com/users/william76/orgs","repos_url":"https://api.github.com/users/william76/repos","events_url":"https://api.github.com/users/william76/events{/privacy}","received_events_url":"https://api.github.com/users/william76/received_events","type":"User","site_admin":false},"repo":{"id":84962478,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk2MjQ3OA==","name":"Trilinos","full_name":"william76/Trilinos","private":false,"owner":{"login":"william76","id":263654,"node_id":"MDQ6VXNlcjI2MzY1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/263654?v=4","gravatar_id":"","url":"https://api.github.com/users/william76","html_url":"https://github.com/william76","followers_url":"https://api.github.com/users/william76/followers","following_url":"https://api.github.com/users/william76/following{/other_user}","gists_url":"https://api.github.com/users/william76/gists{/gist_id}","starred_url":"https://api.github.com/users/william76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william76/subscriptions","organizations_url":"https://api.github.com/users/william76/orgs","repos_url":"https://api.github.com/users/william76/repos","events_url":"https://api.github.com/users/william76/events{/privacy}","received_events_url":"https://api.github.com/users/william76/received_events","type":"User","site_admin":false},"html_url":"https://github.com/william76/Trilinos","description":"Primary repository for the Trilinos Project","fork":true,"url":"https://api.github.com/repos/william76/Trilinos","forks_url":"https://api.github.com/repos/william76/Trilinos/forks","keys_url":"https://api.github.com/repos/william76/Trilinos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/william76/Trilinos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/william76/Trilinos/teams","hooks_url":"https://api.github.com/repos/william76/Trilinos/hooks","issue_events_url":"https://api.github.com/repos/william76/Trilinos/issues/events{/number}","events_url":"https://api.github.com/repos/william76/Trilinos/events","assignees_url":"https://api.github.com/repos/william76/Trilinos/assignees{/user}","branches_url":"https://api.github.com/repos/william76/Trilinos/branches{/branch}","tags_url":"https://api.github.com/repos/william76/Trilinos/tags","blobs_url":"https://api.github.com/repos/william76/Trilinos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/william76/Trilinos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/william76/Trilinos/git/refs{/sha}","trees_url":"https://api.github.com/repos/william76/Trilinos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/william76/Trilinos/statuses/{sha}","languages_url":"https://api.github.com/repos/william76/Trilinos/languages","stargazers_url":"https://api.github.com/repos/william76/Trilinos/stargazers","contributors_url":"https://api.github.com/repos/william76/Trilinos/contributors","subscribers_url":"https://api.github.com/repos/william76/Trilinos/subscribers","subscription_url":"https://api.github.com/repos/william76/Trilinos/subscription","commits_url":"https://api.github.com/repos/william76/Trilinos/commits{/sha}","git_commits_url":"https://api.github.com/repos/william76/Trilinos/git/commits{/sha}","comments_url":"https://api.github.com/repos/william76/Trilinos/comments{/number}","issue_comment_url":"https://api.github.com/repos/william76/Trilinos/issues/comments{/number}","contents_url":"https://api.github.com/repos/william76/Trilinos/contents/{+path}","compare_url":"https://api.github.com/repos/william76/Trilinos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/william76/Trilinos/merges","archive_url":"https://api.github.com/repos/william76/Trilinos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/william76/Trilinos/downloads","issues_url":"https://api.github.com/repos/william76/Trilinos/issues{/number}","pulls_url":"https://api.github.com/repos/william76/Trilinos/pulls{/number}","milestones_url":"https://api.github.com/repos/william76/Trilinos/milestones{/number}","notifications_url":"https://api.github.com/repos/william76/Trilinos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/william76/Trilinos/labels{/name}","releases_url":"https://api.github.com/repos/william76/Trilinos/releases{/id}","deployments_url":"https://api.github.com/repos/william76/Trilinos/deployments","created_at":"2017-03-14T15:03:26Z","updated_at":"2017-03-14T15:05:24Z","pushed_at":"2018-12-20T15:58:06Z","git_url":"git://github.com/william76/Trilinos.git","ssh_url":"git@github.com:william76/Trilinos.git","clone_url":"https://github.com/william76/Trilinos.git","svn_url":"https://github.com/william76/Trilinos","homepage":"https://trilinos.org/","size":497277,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"fork-master"}},"base":{"label":"trilinos:develop","ref":"develop","sha":"b0fd3c193575ee97600cdbaafd7a6091ec270e55","user":{"login":"trilinos","id":8566498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NjY0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8566498?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos","html_url":"https://github.com/trilinos","followers_url":"https://api.github.com/users/trilinos/followers","following_url":"https://api.github.com/users/trilinos/following{/other_user}","gists_url":"https://api.github.com/users/trilinos/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos/subscriptions","organizations_url":"https://api.github.com/users/trilinos/orgs","repos_url":"https://api.github.com/users/trilinos/repos","events_url":"https://api.github.com/users/trilinos/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos/received_events","type":"Organization","site_admin":false},"repo":{"id":46297649,"node_id":"MDEwOlJlcG9zaXRvcnk0NjI5NzY0OQ==","name":"Trilinos","full_name":"trilinos/Trilinos","private":false,"owner":{"login":"trilinos","id":8566498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NjY0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8566498?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos","html_url":"https://github.com/trilinos","followers_url":"https://api.github.com/users/trilinos/followers","following_url":"https://api.github.com/users/trilinos/following{/other_user}","gists_url":"https://api.github.com/users/trilinos/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos/subscriptions","organizations_url":"https://api.github.com/users/trilinos/orgs","repos_url":"https://api.github.com/users/trilinos/repos","events_url":"https://api.github.com/users/trilinos/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/trilinos/Trilinos","description":"Primary repository for the Trilinos Project","fork":false,"url":"https://api.github.com/repos/trilinos/Trilinos","forks_url":"https://api.github.com/repos/trilinos/Trilinos/forks","keys_url":"https://api.github.com/repos/trilinos/Trilinos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trilinos/Trilinos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trilinos/Trilinos/teams","hooks_url":"https://api.github.com/repos/trilinos/Trilinos/hooks","issue_events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/events{/number}","events_url":"https://api.github.com/repos/trilinos/Trilinos/events","assignees_url":"https://api.github.com/repos/trilinos/Trilinos/assignees{/user}","branches_url":"https://api.github.com/repos/trilinos/Trilinos/branches{/branch}","tags_url":"https://api.github.com/repos/trilinos/Trilinos/tags","blobs_url":"https://api.github.com/repos/trilinos/Trilinos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trilinos/Trilinos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trilinos/Trilinos/git/refs{/sha}","trees_url":"https://api.github.com/repos/trilinos/Trilinos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trilinos/Trilinos/statuses/{sha}","languages_url":"https://api.github.com/repos/trilinos/Trilinos/languages","stargazers_url":"https://api.github.com/repos/trilinos/Trilinos/stargazers","contributors_url":"https://api.github.com/repos/trilinos/Trilinos/contributors","subscribers_url":"https://api.github.com/repos/trilinos/Trilinos/subscribers","subscription_url":"https://api.github.com/repos/trilinos/Trilinos/subscription","commits_url":"https://api.github.com/repos/trilinos/Trilinos/commits{/sha}","git_commits_url":"https://api.github.com/repos/trilinos/Trilinos/git/commits{/sha}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/comments{/number}","issue_comment_url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments{/number}","contents_url":"https://api.github.com/repos/trilinos/Trilinos/contents/{+path}","compare_url":"https://api.github.com/repos/trilinos/Trilinos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trilinos/Trilinos/merges","archive_url":"https://api.github.com/repos/trilinos/Trilinos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trilinos/Trilinos/downloads","issues_url":"https://api.github.com/repos/trilinos/Trilinos/issues{/number}","pulls_url":"https://api.github.com/repos/trilinos/Trilinos/pulls{/number}","milestones_url":"https://api.github.com/repos/trilinos/Trilinos/milestones{/number}","notifications_url":"https://api.github.com/repos/trilinos/Trilinos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trilinos/Trilinos/labels{/name}","releases_url":"https://api.github.com/repos/trilinos/Trilinos/releases{/id}","deployments_url":"https://api.github.com/repos/trilinos/Trilinos/deployments","created_at":"2015-11-16T19:39:16Z","updated_at":"2018-12-20T16:19:53Z","pushed_at":"2018-12-20T19:07:16Z","git_url":"git://github.com/trilinos/Trilinos.git","ssh_url":"git@github.com:trilinos/Trilinos.git","clone_url":"https://github.com/trilinos/Trilinos.git","svn_url":"https://github.com/trilinos/Trilinos","homepage":"https://trilinos.org/","size":569357,"stargazers_count":325,"watchers_count":325,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"archived":false,"open_issues_count":888,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":227,"open_issues":888,"watchers":325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/4089"},"html":{"href":"https://github.com/trilinos/Trilinos/pull/4089"},"issue":{"href":"https://api.github.com/repos/trilinos/Trilinos/issues/4089"},"comments":{"href":"https://api.github.com/repos/trilinos/Trilinos/issues/4089/comments"},"review_comments":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/4089/comments"},"review_comment":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/4089/commits"},"statuses":{"href":"https://api.github.com/repos/trilinos/Trilinos/statuses/039aef01be36c4e485a67843ad5d6c68fcb31d51"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"william76"}}