{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/169608637","pull_request_review_id":98159169,"id":169608637,"diff_hunk":"@@ -0,0 +1,39 @@\n+const OrganizationModel = require('dashboard/data/organization-model');\n+const UserModel = require('dashboard/data/user-model');\n+const UserGroupsCollection = require('dashboard/data/user-groups-collection');\n+\n+const configModel = require('fixtures/dashboard/config-model.fixture');\n+\n+module.exports = function () {\n+  const userPayload = {\n+    base_url: 'http://team.carto.com/u/pepe',\n+    id: 'uuid',\n+    organization: {\n+      id: 'o1',\n+      admins: []\n+    },\n+    groups: [{\n+      id: 'g1',\n+      display_name: 'my group'\n+    }]\n+  };\n+  user = new UserModel(userPayload, { configModel });\n+  ","path":"lib/assets/test/spec/fixtures/dashboard/user-model.fixture.js","position":21,"original_position":21,"commit_id":"bf3a77e64be82beca03fd0a78a3011c417ec5eef","original_commit_id":"bf3a77e64be82beca03fd0a78a3011c417ec5eef","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing spaces not allowed                    no-trailing-spaces","created_at":"2018-02-21T11:29:53Z","updated_at":"2018-02-21T11:29:54Z","html_url":"https://github.com/CartoDB/cartodb/pull/13469#discussion_r169608637","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13469","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/169608637"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13469#discussion_r169608637"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13469"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13469","id":166462379,"html_url":"https://github.com/CartoDB/cartodb/pull/13469","diff_url":"https://github.com/CartoDB/cartodb/pull/13469.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/13469.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13469","number":13469,"state":"open","locked":false,"title":"Migrate api-keys view to dashboard","user":{"login":"rubenmoya","id":905225,"avatar_url":"https://avatars3.githubusercontent.com/u/905225?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenmoya","html_url":"https://github.com/rubenmoya","followers_url":"https://api.github.com/users/rubenmoya/followers","following_url":"https://api.github.com/users/rubenmoya/following{/other_user}","gists_url":"https://api.github.com/users/rubenmoya/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenmoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenmoya/subscriptions","organizations_url":"https://api.github.com/users/rubenmoya/orgs","repos_url":"https://api.github.com/users/rubenmoya/repos","events_url":"https://api.github.com/users/rubenmoya/events{/privacy}","received_events_url":"https://api.github.com/users/rubenmoya/received_events","type":"User","site_admin":false},"body":"## Related to https://github.com/CartoDB/cartodb/issues/13477\r\n\r\n### Description\r\nThis PR  migrates the API keys view (`/your_apps`) in order to decouple the dashboard from editor. Taking advantage of this change we also implemented the [new API Keys UI](https://projects.invisionapp.com/share/P2DZ1FWUE#/screens/258570869).\r\n\r\n### Files migrated\r\nYou can check the list of migrated files [here](https://docs.google.com/spreadsheets/d/1ylS7hXamWP8dQ9ZgOAIVEvfNb2XAFY9Y2tErhDKtLUg).\r\n\r\n### New files\r\n- [x] `dashboard/components/form-components/editors/multi-checkbox/multi-checkbox.js`\r\n- [ ] `dashboard/components/table-grants/table-grants.js`\r\n- [x] `dashboard/data/api-key-model.js`\r\n- [x] `dashboard/data/api-keys-collection.js`\r\n- [x] `dashboard/data/user-tables-model.js`\r\n- [x] `dashboard/views/api-keys/alert-dialog-view.js`\r\n- [x] `dashboard/views/api-keys/api-keys-form-view.js`\r\n- [x] `dashboard/views/api-keys/api-keys-list-item-view.js`\r\n- [x] `dashboard/views/api-keys/api-keys-list-view.js`\r\n\r\n### Acceptance steps\r\n- [ ] New view is shown only if the user has `builder` active and `new_dashboard` feature flag.\r\n- [ ] When visiting `/your_apps` check you have `master` and `public` keys by default.\r\n- [ ] Regenerate key in `master` works\r\n- [ ] You can create new API keys\r\n- [ ] You can regenerate regular API keys\r\n- [ ] You can delete regular API keys\r\n- [ ] You can search datasets in the new API key form\r\n\r\n### Screenshots\r\n![screen shot 2018-02-19 at 10 50 17](https://user-images.githubusercontent.com/905225/36371571-d20f993c-1562-11e8-8591-d73b1d0d33e0.png)\r\n![screen shot 2018-02-19 at 10 50 25](https://user-images.githubusercontent.com/905225/36371572-d2295d72-1562-11e8-8c4f-cfe33a9faaa3.png)\r\n![screen shot 2018-02-19 at 10 50 33](https://user-images.githubusercontent.com/905225/36371573-d24b491e-1562-11e8-9383-51893fddca27.png)\r\n![screen shot 2018-02-19 at 10 50 39](https://user-images.githubusercontent.com/905225/36371575-d2643b36-1562-11e8-9ee6-98d570af69a0.png)\r\n![screen shot 2018-02-19 at 10 50 53](https://user-images.githubusercontent.com/905225/36371576-d27d8ff0-1562-11e8-9304-53bb78b217af.png)\r\n","created_at":"2018-02-01T07:29:12Z","updated_at":"2018-02-21T11:29:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbf6dc0cfca638d66cbdfc3317281f75eae33b28","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":179080629,"url":"https://api.github.com/repos/CartoDB/cartodb/labels/do%20not%20merge%20yet","name":"do not merge yet","color":"e11d21","default":false},{"id":823665949,"url":"https://api.github.com/repos/CartoDB/cartodb/labels/editor%20migration","name":"editor migration","color":"b3f716","default":false}],"milestone":{"url":"https://api.github.com/repos/CartoDB/cartodb/milestones/157","html_url":"https://github.com/CartoDB/cartodb/milestone/157","labels_url":"https://api.github.com/repos/CartoDB/cartodb/milestones/157/labels","id":3083566,"number":157,"title":"Editor to Builder migration","description":"Project to migrate the pages that are used by Builder users that are placed in old codebase.","creator":{"login":"ivanmalagon","id":1078228,"avatar_url":"https://avatars0.githubusercontent.com/u/1078228?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanmalagon","html_url":"https://github.com/ivanmalagon","followers_url":"https://api.github.com/users/ivanmalagon/followers","following_url":"https://api.github.com/users/ivanmalagon/following{/other_user}","gists_url":"https://api.github.com/users/ivanmalagon/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanmalagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanmalagon/subscriptions","organizations_url":"https://api.github.com/users/ivanmalagon/orgs","repos_url":"https://api.github.com/users/ivanmalagon/repos","events_url":"https://api.github.com/users/ivanmalagon/events{/privacy}","received_events_url":"https://api.github.com/users/ivanmalagon/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":1,"state":"open","created_at":"2018-02-02T11:09:57Z","updated_at":"2018-02-12T10:38:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13469/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13469/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13469/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/bf3a77e64be82beca03fd0a78a3011c417ec5eef","head":{"label":"CartoDB:api-keys-dashboard","ref":"api-keys-dashboard","sha":"bf3a77e64be82beca03fd0a78a3011c417ec5eef","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-02-21T10:09:09Z","pushed_at":"2018-02-21T11:29:16Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":366174,"stargazers_count":1757,"watchers_count":1757,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":485,"mirror_url":null,"archived":false,"open_issues_count":707,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":485,"open_issues":707,"watchers":1757,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"66b7f101a9511717e0e88a4280ad530acef8e70e","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-02-21T10:09:09Z","pushed_at":"2018-02-21T11:29:16Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":366174,"stargazers_count":1757,"watchers_count":1757,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":485,"mirror_url":null,"archived":false,"open_issues_count":707,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":485,"open_issues":707,"watchers":1757,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13469"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13469"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13469"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13469/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13469/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13469/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/bf3a77e64be82beca03fd0a78a3011c417ec5eef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}