{"action":"closed","number":1399,"pull_request":{"url":"https://api.github.com/repos/fossasia/pslab-android/pulls/1399","id":219321084,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MzIxMDg0","html_url":"https://github.com/fossasia/pslab-android/pull/1399","diff_url":"https://github.com/fossasia/pslab-android/pull/1399.diff","patch_url":"https://github.com/fossasia/pslab-android/pull/1399.patch","issue_url":"https://api.github.com/repos/fossasia/pslab-android/issues/1399","number":1399,"state":"closed","locked":false,"title":"Solved issues in Barometer instrument","user":{"login":"harsh-2711","id":32356267,"node_id":"MDQ6VXNlcjMyMzU2MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/32356267?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-2711","html_url":"https://github.com/harsh-2711","followers_url":"https://api.github.com/users/harsh-2711/followers","following_url":"https://api.github.com/users/harsh-2711/following{/other_user}","gists_url":"https://api.github.com/users/harsh-2711/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-2711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-2711/subscriptions","organizations_url":"https://api.github.com/users/harsh-2711/orgs","repos_url":"https://api.github.com/users/harsh-2711/repos","events_url":"https://api.github.com/users/harsh-2711/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-2711/received_events","type":"User","site_admin":false},"body":"Fixes #1364 \r\n\r\n**Changes**: \r\n1. Solved the issue of indicator overlapping in Barometer instrument\r\n2. Changed the indicator in Barometer instrument to make it uniform\r\n3. Made Barometer start working when pressure sensor is present in the mobile\r\n4. Solved the issue of setting max and min in the statistics row\r\n\r\n**Screenshot/s for the changes**: \r\n<img width=\"317\" alt=\"screen shot 2018-10-01 at 12 38 22\" src=\"https://user-images.githubusercontent.com/32356267/46274403-fb6f7a80-c576-11e8-915e-2b28cd1bd4e0.png\">\r\n\r\n<img width=\"316\" alt=\"screen shot 2018-10-01 at 15 27 54\" src=\"https://user-images.githubusercontent.com/32356267/46282312-c707b880-c58e-11e8-8500-c38b2f333308.png\">\r\n\r\n**Checklist**: [Please tick following check boxes with `[x]` if the respective task is completed]\r\n- [x] I have used resources from `strings.xml`, `dimens.xml` and `colors.xml` without hard-coding them\r\n- [x] No modifications done at the end of resource files `strings.xml`, `dimens.xml` or `colors.xml`\r\n- [x] I have reformatted code in every file included in this PR [<kbd>CTRL</kbd>+<kbd>ALT</kbd>+<kbd>L</kbd>]\r\n- [x] My code does not contain any extra lines or extra spaces\r\n- [x] I have requested reviews from other members\r\n\r\n**APK for testing**: \r\n[app-debug.apk.zip](https://github.com/fossasia/pslab-android/files/2433514/app-debug.apk.zip)","created_at":"2018-10-01T10:04:51Z","updated_at":"2018-10-21T06:59:04Z","closed_at":"2018-10-21T06:59:04Z","merged_at":"2018-10-21T06:59:04Z","merge_commit_sha":"a66071f6fdafbb260bb0299f4b4cd756d7d2cec8","assignee":{"login":"harsh-2711","id":32356267,"node_id":"MDQ6VXNlcjMyMzU2MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/32356267?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-2711","html_url":"https://github.com/harsh-2711","followers_url":"https://api.github.com/users/harsh-2711/followers","following_url":"https://api.github.com/users/harsh-2711/following{/other_user}","gists_url":"https://api.github.com/users/harsh-2711/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-2711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-2711/subscriptions","organizations_url":"https://api.github.com/users/harsh-2711/orgs","repos_url":"https://api.github.com/users/harsh-2711/repos","events_url":"https://api.github.com/users/harsh-2711/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-2711/received_events","type":"User","site_admin":false},"assignees":[{"login":"harsh-2711","id":32356267,"node_id":"MDQ6VXNlcjMyMzU2MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/32356267?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-2711","html_url":"https://github.com/harsh-2711","followers_url":"https://api.github.com/users/harsh-2711/followers","following_url":"https://api.github.com/users/harsh-2711/following{/other_user}","gists_url":"https://api.github.com/users/harsh-2711/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-2711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-2711/subscriptions","organizations_url":"https://api.github.com/users/harsh-2711/orgs","repos_url":"https://api.github.com/users/harsh-2711/repos","events_url":"https://api.github.com/users/harsh-2711/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-2711/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Avjeet","id":20573611,"node_id":"MDQ6VXNlcjIwNTczNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/20573611?v=4","gravatar_id":"","url":"https://api.github.com/users/Avjeet","html_url":"https://github.com/Avjeet","followers_url":"https://api.github.com/users/Avjeet/followers","following_url":"https://api.github.com/users/Avjeet/following{/other_user}","gists_url":"https://api.github.com/users/Avjeet/gists{/gist_id}","starred_url":"https://api.github.com/users/Avjeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avjeet/subscriptions","organizations_url":"https://api.github.com/users/Avjeet/orgs","repos_url":"https://api.github.com/users/Avjeet/repos","events_url":"https://api.github.com/users/Avjeet/events{/privacy}","received_events_url":"https://api.github.com/users/Avjeet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":945443198,"node_id":"MDU6TGFiZWw5NDU0NDMxOTg=","url":"https://api.github.com/repos/fossasia/pslab-android/labels/review-required","name":"review-required","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fossasia/pslab-android/pulls/1399/commits","review_comments_url":"https://api.github.com/repos/fossasia/pslab-android/pulls/1399/comments","review_comment_url":"https://api.github.com/repos/fossasia/pslab-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/pslab-android/issues/1399/comments","statuses_url":"https://api.github.com/repos/fossasia/pslab-android/statuses/0a6f67af5e21e1e5108d0ad2fbe91c32818a4ecd","head":{"label":"harsh-2711:barometerBottomSheet","ref":"barometerBottomSheet","sha":"0a6f67af5e21e1e5108d0ad2fbe91c32818a4ecd","user":{"login":"harsh-2711","id":32356267,"node_id":"MDQ6VXNlcjMyMzU2MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/32356267?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-2711","html_url":"https://github.com/harsh-2711","followers_url":"https://api.github.com/users/harsh-2711/followers","following_url":"https://api.github.com/users/harsh-2711/following{/other_user}","gists_url":"https://api.github.com/users/harsh-2711/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-2711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-2711/subscriptions","organizations_url":"https://api.github.com/users/harsh-2711/orgs","repos_url":"https://api.github.com/users/harsh-2711/repos","events_url":"https://api.github.com/users/harsh-2711/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-2711/received_events","type":"User","site_admin":false},"repo":{"id":132598354,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1OTgzNTQ=","name":"pslab-android","full_name":"harsh-2711/pslab-android","private":false,"owner":{"login":"harsh-2711","id":32356267,"node_id":"MDQ6VXNlcjMyMzU2MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/32356267?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-2711","html_url":"https://github.com/harsh-2711","followers_url":"https://api.github.com/users/harsh-2711/followers","following_url":"https://api.github.com/users/harsh-2711/following{/other_user}","gists_url":"https://api.github.com/users/harsh-2711/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-2711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-2711/subscriptions","organizations_url":"https://api.github.com/users/harsh-2711/orgs","repos_url":"https://api.github.com/users/harsh-2711/repos","events_url":"https://api.github.com/users/harsh-2711/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-2711/received_events","type":"User","site_admin":false},"html_url":"https://github.com/harsh-2711/pslab-android","description":"PSLab Android App https://github.com/fossasia/pslab-android/raw/apk/app-debug.apk","fork":true,"url":"https://api.github.com/repos/harsh-2711/pslab-android","forks_url":"https://api.github.com/repos/harsh-2711/pslab-android/forks","keys_url":"https://api.github.com/repos/harsh-2711/pslab-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harsh-2711/pslab-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harsh-2711/pslab-android/teams","hooks_url":"https://api.github.com/repos/harsh-2711/pslab-android/hooks","issue_events_url":"https://api.github.com/repos/harsh-2711/pslab-android/issues/events{/number}","events_url":"https://api.github.com/repos/harsh-2711/pslab-android/events","assignees_url":"https://api.github.com/repos/harsh-2711/pslab-android/assignees{/user}","branches_url":"https://api.github.com/repos/harsh-2711/pslab-android/branches{/branch}","tags_url":"https://api.github.com/repos/harsh-2711/pslab-android/tags","blobs_url":"https://api.github.com/repos/harsh-2711/pslab-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harsh-2711/pslab-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harsh-2711/pslab-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/harsh-2711/pslab-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harsh-2711/pslab-android/statuses/{sha}","languages_url":"https://api.github.com/repos/harsh-2711/pslab-android/languages","stargazers_url":"https://api.github.com/repos/harsh-2711/pslab-android/stargazers","contributors_url":"https://api.github.com/repos/harsh-2711/pslab-android/contributors","subscribers_url":"https://api.github.com/repos/harsh-2711/pslab-android/subscribers","subscription_url":"https://api.github.com/repos/harsh-2711/pslab-android/subscription","commits_url":"https://api.github.com/repos/harsh-2711/pslab-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/harsh-2711/pslab-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/harsh-2711/pslab-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/harsh-2711/pslab-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/harsh-2711/pslab-android/contents/{+path}","compare_url":"https://api.github.com/repos/harsh-2711/pslab-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harsh-2711/pslab-android/merges","archive_url":"https://api.github.com/repos/harsh-2711/pslab-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harsh-2711/pslab-android/downloads","issues_url":"https://api.github.com/repos/harsh-2711/pslab-android/issues{/number}","pulls_url":"https://api.github.com/repos/harsh-2711/pslab-android/pulls{/number}","milestones_url":"https://api.github.com/repos/harsh-2711/pslab-android/milestones{/number}","notifications_url":"https://api.github.com/repos/harsh-2711/pslab-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harsh-2711/pslab-android/labels{/name}","releases_url":"https://api.github.com/repos/harsh-2711/pslab-android/releases{/id}","deployments_url":"https://api.github.com/repos/harsh-2711/pslab-android/deployments","created_at":"2018-05-08T11:21:04Z","updated_at":"2018-10-01T06:38:15Z","pushed_at":"2018-10-01T13:30:19Z","git_url":"git://github.com/harsh-2711/pslab-android.git","ssh_url":"git@github.com:harsh-2711/pslab-android.git","clone_url":"https://github.com/harsh-2711/pslab-android.git","svn_url":"https://github.com/harsh-2711/pslab-android","homepage":"http://pslab.fossasia.org","size":38272,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"c0e9fa7702a31fc8e54f9a5ba66bc9f5caef6077","user":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":86480252,"node_id":"MDEwOlJlcG9zaXRvcnk4NjQ4MDI1Mg==","name":"pslab-android","full_name":"fossasia/pslab-android","private":false,"owner":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fossasia/pslab-android","description":"PSLab Android App https://github.com/fossasia/pslab-android/blob/apk/app-master-release.apk","fork":false,"url":"https://api.github.com/repos/fossasia/pslab-android","forks_url":"https://api.github.com/repos/fossasia/pslab-android/forks","keys_url":"https://api.github.com/repos/fossasia/pslab-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/pslab-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/pslab-android/teams","hooks_url":"https://api.github.com/repos/fossasia/pslab-android/hooks","issue_events_url":"https://api.github.com/repos/fossasia/pslab-android/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/pslab-android/events","assignees_url":"https://api.github.com/repos/fossasia/pslab-android/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/pslab-android/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/pslab-android/tags","blobs_url":"https://api.github.com/repos/fossasia/pslab-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/pslab-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/pslab-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/pslab-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/pslab-android/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/pslab-android/languages","stargazers_url":"https://api.github.com/repos/fossasia/pslab-android/stargazers","contributors_url":"https://api.github.com/repos/fossasia/pslab-android/contributors","subscribers_url":"https://api.github.com/repos/fossasia/pslab-android/subscribers","subscription_url":"https://api.github.com/repos/fossasia/pslab-android/subscription","commits_url":"https://api.github.com/repos/fossasia/pslab-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/pslab-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/pslab-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/pslab-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/pslab-android/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/pslab-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/pslab-android/merges","archive_url":"https://api.github.com/repos/fossasia/pslab-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/pslab-android/downloads","issues_url":"https://api.github.com/repos/fossasia/pslab-android/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/pslab-android/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/pslab-android/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/pslab-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/pslab-android/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/pslab-android/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/pslab-android/deployments","created_at":"2017-03-28T16:03:15Z","updated_at":"2018-10-21T06:48:53Z","pushed_at":"2018-10-21T06:59:04Z","git_url":"git://github.com/fossasia/pslab-android.git","ssh_url":"git@github.com:fossasia/pslab-android.git","clone_url":"https://github.com/fossasia/pslab-android.git","svn_url":"https://github.com/fossasia/pslab-android","homepage":"https://pslab.io","size":389209,"stargazers_count":637,"watchers_count":637,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":238,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":238,"open_issues":40,"watchers":637,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/pslab-android/pulls/1399"},"html":{"href":"https://github.com/fossasia/pslab-android/pull/1399"},"issue":{"href":"https://api.github.com/repos/fossasia/pslab-android/issues/1399"},"comments":{"href":"https://api.github.com/repos/fossasia/pslab-android/issues/1399/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/pslab-android/pulls/1399/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/pslab-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/pslab-android/pulls/1399/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/pslab-android/statuses/0a6f67af5e21e1e5108d0ad2fbe91c32818a4ecd"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"CloudyPadmal","id":14261304,"node_id":"MDQ6VXNlcjE0MjYxMzA0","avatar_url":"https://avatars1.githubusercontent.com/u/14261304?v=4","gravatar_id":"","url":"https://api.github.com/users/CloudyPadmal","html_url":"https://github.com/CloudyPadmal","followers_url":"https://api.github.com/users/CloudyPadmal/followers","following_url":"https://api.github.com/users/CloudyPadmal/following{/other_user}","gists_url":"https://api.github.com/users/CloudyPadmal/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudyPadmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudyPadmal/subscriptions","organizations_url":"https://api.github.com/users/CloudyPadmal/orgs","repos_url":"https://api.github.com/users/CloudyPadmal/repos","events_url":"https://api.github.com/users/CloudyPadmal/events{/privacy}","received_events_url":"https://api.github.com/users/CloudyPadmal/received_events","type":"User","site_admin":false},"comments":5,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":369,"deletions":712,"changed_files":5}}
{"actor":{"display_login":"CloudyPadmal"}}