{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/comments/177944562","pull_request_review_id":107914737,"id":177944562,"diff_hunk":"@@ -78,23 +79,23 @@ This uses a first order approximation of the ODE, and matrix norm upper bounds,\n see Le Guernic, C., & Girard, A., 2010, *Reachability analysis of linear systems\n using support functions. Nonlinear Analysis: Hybrid Systems, 4(2), 250-262.*\n \"\"\"\n-function discr_bloat_firstorder(cont_sys::AbstractContinuousSystem,\n+function discr_bloat_firstorder(cont_sys::InitialValueProblem{<:AbstractContinuousSystem},\n                                 δ::Float64)\n \n     if !(cont_sys.U isa ConstantNonDeterministicInput)\n         error(\"This discretization algorithm is only implemented for constant inputs\")\n     end\n \n     Anorm = norm(full(cont_sys.s.A), Inf)\n-    RX0 = norm(cons_sys.x0, Inf)\n-    inputs = next_set(cont_sys.U)\n+    RX0 = norm(X0, Inf)\n+    inputs = next_set(inputset(cont_sys))","path":"src/ReachSets/discretize.jl","position":null,"original_position":26,"commit_id":"a70001a62c7851869c1d7a39c3a1722ea8dfd4b0","original_commit_id":"a70001a62c7851869c1d7a39c3a1722ea8dfd4b0","user":{"login":"mforets","id":12424594,"avatar_url":"https://avatars3.githubusercontent.com/u/12424594?v=4","gravatar_id":"","url":"https://api.github.com/users/mforets","html_url":"https://github.com/mforets","followers_url":"https://api.github.com/users/mforets/followers","following_url":"https://api.github.com/users/mforets/following{/other_user}","gists_url":"https://api.github.com/users/mforets/gists{/gist_id}","starred_url":"https://api.github.com/users/mforets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mforets/subscriptions","organizations_url":"https://api.github.com/users/mforets/orgs","repos_url":"https://api.github.com/users/mforets/repos","events_url":"https://api.github.com/users/mforets/events{/privacy}","received_events_url":"https://api.github.com/users/mforets/received_events","type":"User","site_admin":false},"body":"in never pushed `systems.jl` :D","created_at":"2018-03-29T03:15:43Z","updated_at":"2018-03-29T03:15:44Z","html_url":"https://github.com/JuliaReach/Reachability.jl/pull/88#discussion_r177944562","pull_request_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/88","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/comments/177944562"},"html":{"href":"https://github.com/JuliaReach/Reachability.jl/pull/88#discussion_r177944562"},"pull_request":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/88"}},"in_reply_to_id":175278929},"pull_request":{"url":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/88","id":173714764,"html_url":"https://github.com/JuliaReach/Reachability.jl/pull/88","diff_url":"https://github.com/JuliaReach/Reachability.jl/pull/88.diff","patch_url":"https://github.com/JuliaReach/Reachability.jl/pull/88.patch","issue_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues/88","number":88,"state":"open","locked":false,"title":"[WIP #41] Replace systems implementation by Systems.jl","user":{"login":"mforets","id":12424594,"avatar_url":"https://avatars3.githubusercontent.com/u/12424594?v=4","gravatar_id":"","url":"https://api.github.com/users/mforets","html_url":"https://github.com/mforets","followers_url":"https://api.github.com/users/mforets/followers","following_url":"https://api.github.com/users/mforets/following{/other_user}","gists_url":"https://api.github.com/users/mforets/gists{/gist_id}","starred_url":"https://api.github.com/users/mforets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mforets/subscriptions","organizations_url":"https://api.github.com/users/mforets/orgs","repos_url":"https://api.github.com/users/mforets/repos","events_url":"https://api.github.com/users/mforets/events{/privacy}","received_events_url":"https://api.github.com/users/mforets/received_events","type":"User","site_admin":false},"body":"Closes #41.\r\nCloses #121.\r\nCloses #122.","created_at":"2018-03-08T11:43:57Z","updated_at":"2018-03-29T03:15:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99bec3361f1d590a09fc66ad938288c1b7b2d88c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/88/commits","review_comments_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/88/comments","review_comment_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues/88/comments","statuses_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/statuses/a70001a62c7851869c1d7a39c3a1722ea8dfd4b0","head":{"label":"JuliaReach:mforets/41","ref":"mforets/41","sha":"a70001a62c7851869c1d7a39c3a1722ea8dfd4b0","user":{"login":"JuliaReach","id":33028082,"avatar_url":"https://avatars3.githubusercontent.com/u/33028082?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaReach","html_url":"https://github.com/JuliaReach","followers_url":"https://api.github.com/users/JuliaReach/followers","following_url":"https://api.github.com/users/JuliaReach/following{/other_user}","gists_url":"https://api.github.com/users/JuliaReach/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaReach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaReach/subscriptions","organizations_url":"https://api.github.com/users/JuliaReach/orgs","repos_url":"https://api.github.com/users/JuliaReach/repos","events_url":"https://api.github.com/users/JuliaReach/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaReach/received_events","type":"Organization","site_admin":false},"repo":{"id":106649339,"name":"Reachability.jl","full_name":"JuliaReach/Reachability.jl","owner":{"login":"JuliaReach","id":33028082,"avatar_url":"https://avatars3.githubusercontent.com/u/33028082?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaReach","html_url":"https://github.com/JuliaReach","followers_url":"https://api.github.com/users/JuliaReach/followers","following_url":"https://api.github.com/users/JuliaReach/following{/other_user}","gists_url":"https://api.github.com/users/JuliaReach/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaReach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaReach/subscriptions","organizations_url":"https://api.github.com/users/JuliaReach/orgs","repos_url":"https://api.github.com/users/JuliaReach/repos","events_url":"https://api.github.com/users/JuliaReach/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaReach/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaReach/Reachability.jl","description":"Reachability and Safety Properties of Affine ODEs with Nondeterministic Inputs","fork":false,"url":"https://api.github.com/repos/JuliaReach/Reachability.jl","forks_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/forks","keys_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/teams","hooks_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/events","assignees_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/tags","blobs_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/subscription","commits_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/merges","archive_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/downloads","issues_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/deployments","created_at":"2017-10-12T05:39:18Z","updated_at":"2018-03-28T15:34:22Z","pushed_at":"2018-03-29T03:00:21Z","git_url":"git://github.com/JuliaReach/Reachability.jl.git","ssh_url":"git@github.com:JuliaReach/Reachability.jl.git","clone_url":"https://github.com/JuliaReach/Reachability.jl.git","svn_url":"https://github.com/JuliaReach/Reachability.jl","homepage":"","size":379,"stargazers_count":5,"watchers_count":5,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":38,"watchers":5,"default_branch":"master"}},"base":{"label":"JuliaReach:master","ref":"master","sha":"ba8952501bfc6bb48ab979d6d88c1cacb4490f63","user":{"login":"JuliaReach","id":33028082,"avatar_url":"https://avatars3.githubusercontent.com/u/33028082?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaReach","html_url":"https://github.com/JuliaReach","followers_url":"https://api.github.com/users/JuliaReach/followers","following_url":"https://api.github.com/users/JuliaReach/following{/other_user}","gists_url":"https://api.github.com/users/JuliaReach/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaReach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaReach/subscriptions","organizations_url":"https://api.github.com/users/JuliaReach/orgs","repos_url":"https://api.github.com/users/JuliaReach/repos","events_url":"https://api.github.com/users/JuliaReach/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaReach/received_events","type":"Organization","site_admin":false},"repo":{"id":106649339,"name":"Reachability.jl","full_name":"JuliaReach/Reachability.jl","owner":{"login":"JuliaReach","id":33028082,"avatar_url":"https://avatars3.githubusercontent.com/u/33028082?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaReach","html_url":"https://github.com/JuliaReach","followers_url":"https://api.github.com/users/JuliaReach/followers","following_url":"https://api.github.com/users/JuliaReach/following{/other_user}","gists_url":"https://api.github.com/users/JuliaReach/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaReach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaReach/subscriptions","organizations_url":"https://api.github.com/users/JuliaReach/orgs","repos_url":"https://api.github.com/users/JuliaReach/repos","events_url":"https://api.github.com/users/JuliaReach/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaReach/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaReach/Reachability.jl","description":"Reachability and Safety Properties of Affine ODEs with Nondeterministic Inputs","fork":false,"url":"https://api.github.com/repos/JuliaReach/Reachability.jl","forks_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/forks","keys_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/teams","hooks_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/events","assignees_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/tags","blobs_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/subscription","commits_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/merges","archive_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/downloads","issues_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaReach/Reachability.jl/deployments","created_at":"2017-10-12T05:39:18Z","updated_at":"2018-03-28T15:34:22Z","pushed_at":"2018-03-29T03:00:21Z","git_url":"git://github.com/JuliaReach/Reachability.jl.git","ssh_url":"git@github.com:JuliaReach/Reachability.jl.git","clone_url":"https://github.com/JuliaReach/Reachability.jl.git","svn_url":"https://github.com/JuliaReach/Reachability.jl","homepage":"","size":379,"stargazers_count":5,"watchers_count":5,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":38,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/88"},"html":{"href":"https://github.com/JuliaReach/Reachability.jl/pull/88"},"issue":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues/88"},"comments":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaReach/Reachability.jl/statuses/a70001a62c7851869c1d7a39c3a1722ea8dfd4b0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"mforets"}}