{"action":"created","issue":{"url":"https://api.github.com/repos/PeerioTechnologies/peerio-desktop/issues/272","repository_url":"https://api.github.com/repos/PeerioTechnologies/peerio-desktop","labels_url":"https://api.github.com/repos/PeerioTechnologies/peerio-desktop/issues/272/labels{/name}","comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-desktop/issues/272/comments","events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-desktop/issues/272/events","html_url":"https://github.com/PeerioTechnologies/peerio-desktop/pull/272","id":314144152,"number":272,"title":"WIP: jump-to-bottom button","user":{"login":"suprko","id":22176050,"avatar_url":"https://avatars1.githubusercontent.com/u/22176050?v=4","gravatar_id":"","url":"https://api.github.com/users/suprko","html_url":"https://github.com/suprko","followers_url":"https://api.github.com/users/suprko/followers","following_url":"https://api.github.com/users/suprko/following{/other_user}","gists_url":"https://api.github.com/users/suprko/gists{/gist_id}","starred_url":"https://api.github.com/users/suprko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suprko/subscriptions","organizations_url":"https://api.github.com/users/suprko/orgs","repos_url":"https://api.github.com/users/suprko/repos","events_url":"https://api.github.com/users/suprko/events{/privacy}","received_events_url":"https://api.github.com/users/suprko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-13T15:06:26Z","updated_at":"2018-04-18T21:25:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PeerioTechnologies/peerio-desktop/pulls/272","html_url":"https://github.com/PeerioTechnologies/peerio-desktop/pull/272","diff_url":"https://github.com/PeerioTechnologies/peerio-desktop/pull/272.diff","patch_url":"https://github.com/PeerioTechnologies/peerio-desktop/pull/272.patch"},"body":"#### Relevant info and issue/PR links \r\n https://app.clubhouse.io/peerio/story/4850/desktop-jump-to-most-recent-message\r\n\r\n#### Testing instructions  \r\nWorks as-is but needs additional icebear support to satisfy the acceptance criteria\r\n\r\n----\r\n### Repository owner\r\n\r\n- [ ] Was tested and can be merged.\r\n- [ ] PR name follows conventional changelog format.\r\n\r\n[PR guideline](https://github.com/PeerioTechnologies/peerio-icebear/blob/dev/docs/CONTRIBUTING.md)\r\n"},"comment":{"url":"https://api.github.com/repos/PeerioTechnologies/peerio-desktop/issues/comments/382534498","html_url":"https://github.com/PeerioTechnologies/peerio-desktop/pull/272#issuecomment-382534498","issue_url":"https://api.github.com/repos/PeerioTechnologies/peerio-desktop/issues/272","id":382534498,"user":{"login":"suprko","id":22176050,"avatar_url":"https://avatars1.githubusercontent.com/u/22176050?v=4","gravatar_id":"","url":"https://api.github.com/users/suprko","html_url":"https://github.com/suprko","followers_url":"https://api.github.com/users/suprko/followers","following_url":"https://api.github.com/users/suprko/following{/other_user}","gists_url":"https://api.github.com/users/suprko/gists{/gist_id}","starred_url":"https://api.github.com/users/suprko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suprko/subscriptions","organizations_url":"https://api.github.com/users/suprko/orgs","repos_url":"https://api.github.com/users/suprko/repos","events_url":"https://api.github.com/users/suprko/events{/privacy}","received_events_url":"https://api.github.com/users/suprko/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T21:25:21Z","updated_at":"2018-04-18T21:25:21Z","author_association":"CONTRIBUTOR","body":"@seavan I've got this working. In your last comment you referenced things in `feat-app-label` branch which I can't view now 😆 \r\n\r\nHere's what has been done:\r\n* desktop MessageList `stickToBottom` has been moved to icebear clientApp `messageStickToBottom`\r\n  * desktop changes the flag the same way as before\r\n  * `messageStickToBottom=true` whenever a new MessageList is mounted (change chat)\r\n* when `!messageStickToBottom`, icebear chat.message-handler does not `markAllAsRead`. unread count (and jump-to-bottom button) are persistent until users scrolls to bottom, either manually or with button\r\n\r\nNothing has changed in chat.js because I wasn't sure what flag is supposed to be reset..."}}
{"actor":{"display_login":"suprko"}}