{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/168574620","pull_request_review_id":96965993,"id":168574620,"diff_hunk":"@@ -318,9 +327,17 @@ public ProjectInfo CreateProjectInfoForCurrentState()\n \n         protected void SetIntellisenseBuildResultAndNotifyWorkspaceHosts(bool succeeded)\n         {\n-            // set intellisense related info\n+            // set IntelliSense related info\n             LastDesignTimeBuildSucceeded = succeeded;\n \n+            Logger.Log(FunctionId.AbstractProject_SetIntelliSenseBuild,\n+                KeyValueLogMessage.Create(LogType.Trace, m =>\n+                {\n+                    m[ProjectGuidPropertyName] = Guid;\n+                    m[nameof(LastDesignTimeBuildSucceeded)] = LastDesignTimeBuildSucceeded;","path":"src/VisualStudio/Core/Def/Implementation/ProjectSystem/AbstractProject.cs","position":42,"original_position":42,"commit_id":"fd6b7d2740bdc6dedff62cd05a3872ff321ec35c","original_commit_id":"fd6b7d2740bdc6dedff62cd05a3872ff321ec35c","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars3.githubusercontent.com/u/1333179?v=4","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"body":"same here. @jonsequitur","created_at":"2018-02-15T18:59:10Z","updated_at":"2018-02-15T18:59:10Z","html_url":"https://github.com/dotnet/roslyn/pull/24870#discussion_r168574620","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24870","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/168574620"},"html":{"href":"https://github.com/dotnet/roslyn/pull/24870#discussion_r168574620"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24870"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/24870","id":169452989,"html_url":"https://github.com/dotnet/roslyn/pull/24870","diff_url":"https://github.com/dotnet/roslyn/pull/24870.diff","patch_url":"https://github.com/dotnet/roslyn/pull/24870.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/24870","number":24870,"state":"open","locked":false,"title":"Add telemetry for when projects are created/pushed/etc","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars3.githubusercontent.com/u/312835?v=4","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"body":"Adds 3 telemetry points to see when projects get created, pushed to the\r\nworkspace, and have their \"LastDesignTimeBuildSucceeded\" flag changed.\r\n\r\nFixes internal bug 568001.\r\n\r\n<details><summary>Ask Mode template not completed</summary>\r\n\r\n<!-- This template is not always required. If you aren't sure about whether it's needed or want help filling out the sections,\r\nsubmit the pull request and then ask us for help. :) -->\r\n\r\n### Customer scenario\r\n\r\nWhat does the customer do to get into this situation, and why do we think this\r\nis common enough to address for this release.  (Granted, sometimes this will be\r\nobvious \"Open project, VS crashes\" but in general, I need to understand how\r\ncommon a scenario is)\r\n\r\n### Bugs this fixes\r\n\r\n(either VSO or GitHub links)\r\n\r\n### Workarounds, if any\r\n\r\nAlso, why we think they are insufficient for RC vs. RC2, RC3, or RTW\r\n\r\n### Risk\r\n\r\nThis is generally a measure our how central the affected code is to adjacent\r\nscenarios and thus how likely your fix is to destabilize a broader area of code\r\n\r\n### Performance impact\r\n\r\n(with a brief justification for that assessment (e.g. \"Low perf impact because no extra allocations/no complexity changes\" vs. \"Low\")\r\n\r\n### Is this a regression from a previous update?\r\n\r\n### Root cause analysis\r\n\r\nHow did we miss it?  What tests are we adding to guard against it in the future?\r\n\r\n### How was the bug found?\r\n\r\n(E.g. customer reported it vs. ad hoc testing)\r\n\r\n### Test documentation updated?\r\n\r\nIf this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.\r\n\r\n</details>\r\n","created_at":"2018-02-15T18:43:14Z","updated_at":"2018-02-15T18:59:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd19fbab77e9ef4b3ea717ae68b5b5188b51debc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jasonmalinowski","id":201340,"avatar_url":"https://avatars3.githubusercontent.com/u/201340?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},{"login":"davkean","id":1103906,"avatar_url":"https://avatars1.githubusercontent.com/u/1103906?v=4","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},{"login":"jinujoseph","id":12449387,"avatar_url":"https://avatars3.githubusercontent.com/u/12449387?v=4","gravatar_id":"","url":"https://api.github.com/users/jinujoseph","html_url":"https://github.com/jinujoseph","followers_url":"https://api.github.com/users/jinujoseph/followers","following_url":"https://api.github.com/users/jinujoseph/following{/other_user}","gists_url":"https://api.github.com/users/jinujoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/jinujoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinujoseph/subscriptions","organizations_url":"https://api.github.com/users/jinujoseph/orgs","repos_url":"https://api.github.com/users/jinujoseph/repos","events_url":"https://api.github.com/users/jinujoseph/events{/privacy}","received_events_url":"https://api.github.com/users/jinujoseph/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"roslyn-ide","id":1781706,"slug":"roslyn-ide","description":"Roslyn IDE Team","privacy":"closed","url":"https://api.github.com/teams/1781706","members_url":"https://api.github.com/teams/1781706/members{/member}","repositories_url":"https://api.github.com/teams/1781706/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24870/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24870/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/24870/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/fd6b7d2740bdc6dedff62cd05a3872ff321ec35c","head":{"label":"Pilchie:Fix568001-IntelliSenseTelemetry","ref":"Fix568001-IntelliSenseTelemetry","sha":"fd6b7d2740bdc6dedff62cd05a3872ff321ec35c","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars3.githubusercontent.com/u/312835?v=4","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"repo":{"id":29272236,"name":"roslyn","full_name":"Pilchie/roslyn","owner":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars3.githubusercontent.com/u/312835?v=4","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pilchie/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/Pilchie/roslyn","forks_url":"https://api.github.com/repos/Pilchie/roslyn/forks","keys_url":"https://api.github.com/repos/Pilchie/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pilchie/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pilchie/roslyn/teams","hooks_url":"https://api.github.com/repos/Pilchie/roslyn/hooks","issue_events_url":"https://api.github.com/repos/Pilchie/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/Pilchie/roslyn/events","assignees_url":"https://api.github.com/repos/Pilchie/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/Pilchie/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/Pilchie/roslyn/tags","blobs_url":"https://api.github.com/repos/Pilchie/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pilchie/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pilchie/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pilchie/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pilchie/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/Pilchie/roslyn/languages","stargazers_url":"https://api.github.com/repos/Pilchie/roslyn/stargazers","contributors_url":"https://api.github.com/repos/Pilchie/roslyn/contributors","subscribers_url":"https://api.github.com/repos/Pilchie/roslyn/subscribers","subscription_url":"https://api.github.com/repos/Pilchie/roslyn/subscription","commits_url":"https://api.github.com/repos/Pilchie/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pilchie/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pilchie/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pilchie/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pilchie/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/Pilchie/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pilchie/roslyn/merges","archive_url":"https://api.github.com/repos/Pilchie/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pilchie/roslyn/downloads","issues_url":"https://api.github.com/repos/Pilchie/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/Pilchie/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/Pilchie/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/Pilchie/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pilchie/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/Pilchie/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/Pilchie/roslyn/deployments","created_at":"2015-01-15T00:05:23Z","updated_at":"2015-01-15T00:06:02Z","pushed_at":"2018-02-15T18:40:10Z","git_url":"git://github.com/Pilchie/roslyn.git","ssh_url":"git@github.com:Pilchie/roslyn.git","clone_url":"https://github.com/Pilchie/roslyn.git","svn_url":"https://github.com/Pilchie/roslyn","homepage":"","size":247513,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev15.6.x","ref":"dev15.6.x","sha":"d379f47d8c558e29d7ebea9686d53ea1f700aff8","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-02-15T14:01:48Z","pushed_at":"2018-02-15T18:56:06Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":286663,"stargazers_count":8851,"watchers_count":8851,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2135,"mirror_url":null,"archived":false,"open_issues_count":4392,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2135,"open_issues":4392,"watchers":8851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24870"},"html":{"href":"https://github.com/dotnet/roslyn/pull/24870"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/24870"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/24870/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24870/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24870/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/fd6b7d2740bdc6dedff62cd05a3872ff321ec35c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"heejaechang"}}