{"comment":{"url":"https://api.github.com/repos/esp8266/Arduino/comments/28256694","html_url":"https://github.com/esp8266/Arduino/commit/f8f205d54af42f34502ad011fd015e104b63d911#commitcomment-28256694","id":28256694,"user":{"login":"devyte","id":16824838,"avatar_url":"https://avatars0.githubusercontent.com/u/16824838?v=4","gravatar_id":"","url":"https://api.github.com/users/devyte","html_url":"https://github.com/devyte","followers_url":"https://api.github.com/users/devyte/followers","following_url":"https://api.github.com/users/devyte/following{/other_user}","gists_url":"https://api.github.com/users/devyte/gists{/gist_id}","starred_url":"https://api.github.com/users/devyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devyte/subscriptions","organizations_url":"https://api.github.com/users/devyte/orgs","repos_url":"https://api.github.com/users/devyte/repos","events_url":"https://api.github.com/users/devyte/events{/privacy}","received_events_url":"https://api.github.com/users/devyte/received_events","type":"User","site_admin":false},"position":1,"line":103,"path":"cores/esp8266/uart.c","commit_id":"f8f205d54af42f34502ad011fd015e104b63d911","created_at":"2018-03-25T09:11:26Z","updated_at":"2018-03-25T09:11:26Z","author_association":"COLLABORATOR","body":"The code in question is like a critical section: it has to be guarded against what happens in the isr to keep it consistent. The line you added makes it less likely that the issue you had will be hit, but it is still possible to happen. This change addresses the underlying cause.\r\nIf you make a pr, I'd appreciate it.\r\nAbout the buffer size change, let's discuss that separately."}}
{"actor":{"display_login":"devyte"}}