{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/comments/181215535","pull_request_review_id":111785520,"id":181215535,"diff_hunk":"@@ -0,0 +1,44 @@\n+#!/bin/bash\n+\n+# Copyright (c) 2017, The Linux Foundation. All rights reserved.\n+# \n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions are\n+# met:\n+#     * Redistributions of source code must retain the above copyright\n+#       notice, this list of conditions and the following disclaimer.\n+#     * Redistributions in binary form must reproduce the above\n+#       copyright notice, this list of conditions and the following\n+#       disclaimer in the documentation and/or other materials provided\n+#       with the distribution.\n+#     * Neither the name of The Linux Foundation nor the names of its\n+#       contributors may be used to endorse or promote products derived\n+#       from this software without specific prior written permission.\n+# \n+# THIS SOFTWARE IS PROVIDED \"AS IS\" AND ANY EXPRESS OR IMPLIED\n+# WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF\n+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT\n+# ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS\n+# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR\n+# BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,\n+# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE\n+# OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN\n+# IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+\n+cores=$(grep -c \"^processor\" /proc/cpuinfo)\n+cores_q1=$(($cores / 4))\n+cores_q2=$(($cores / 2))\n+cores_q3=$(($cores_q1 + $cores_q2))\n+cores_all=\"`seq 24` `seq 8 8 $(($cores))` $cores_q1 $cores_q2 $cores_q3 $cores\"","path":"benchmarks/lockhammer/scripts/sweep.sh","position":34,"original_position":34,"commit_id":"e80bd71842e745efafa263a8a24f6e7daf831247","original_commit_id":"ae672d318d7235ab14fd5434c3095aba1e005b28","user":{"login":"lucasclucasdo","id":37487633,"avatar_url":"https://avatars0.githubusercontent.com/u/37487633?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasclucasdo","html_url":"https://github.com/lucasclucasdo","followers_url":"https://api.github.com/users/lucasclucasdo/followers","following_url":"https://api.github.com/users/lucasclucasdo/following{/other_user}","gists_url":"https://api.github.com/users/lucasclucasdo/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasclucasdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasclucasdo/subscriptions","organizations_url":"https://api.github.com/users/lucasclucasdo/orgs","repos_url":"https://api.github.com/users/lucasclucasdo/repos","events_url":"https://api.github.com/users/lucasclucasdo/events{/privacy}","received_events_url":"https://api.github.com/users/lucasclucasdo/received_events","type":"User","site_admin":false},"body":"This is starting to get a bit complicated.  Would it make more sense to have the acquires-per-thread count adjust based on number of threads?  Since acquires-per-thread is held constant the total number of acquires increases linearly with number of threads.  Since many of these operations saturate at either the critical section time or synchronization overhead time we don't see any scaling at very high core counts.  So the total work increase with the addition of cores but the aggregate SoC performance stays the same causing runtimes to increase linearly with core counts at the higher core.\r\n\r\nBy changing the acquires per thread at higher core counts (say, > 64) to either hold constant the total acquires or increase at a flatter rate we could have more impact on the total runtime than removing some of the datapoints.  It may also improve responsiveness for the very high-core count systems by reducing the maximum time that any one instance can run which might prevent the hangups you've seen.","created_at":"2018-04-12T20:42:28Z","updated_at":"2018-04-12T20:42:29Z","html_url":"https://github.com/ARM-software/synchronization-benchmarks/pull/2#discussion_r181215535","pull_request_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/comments/181215535"},"html":{"href":"https://github.com/ARM-software/synchronization-benchmarks/pull/2#discussion_r181215535"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/2"}},"in_reply_to_id":181194555},"pull_request":{"url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/2","id":179250091,"html_url":"https://github.com/ARM-software/synchronization-benchmarks/pull/2","diff_url":"https://github.com/ARM-software/synchronization-benchmarks/pull/2.diff","patch_url":"https://github.com/ARM-software/synchronization-benchmarks/pull/2.patch","issue_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/issues/2","number":2,"state":"open","locked":false,"title":"Lockhammer: initial commit","user":{"login":"lucasclucasdo","id":37487633,"avatar_url":"https://avatars0.githubusercontent.com/u/37487633?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasclucasdo","html_url":"https://github.com/lucasclucasdo","followers_url":"https://api.github.com/users/lucasclucasdo/followers","following_url":"https://api.github.com/users/lucasclucasdo/following{/other_user}","gists_url":"https://api.github.com/users/lucasclucasdo/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasclucasdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasclucasdo/subscriptions","organizations_url":"https://api.github.com/users/lucasclucasdo/orgs","repos_url":"https://api.github.com/users/lucasclucasdo/repos","events_url":"https://api.github.com/users/lucasclucasdo/events{/privacy}","received_events_url":"https://api.github.com/users/lucasclucasdo/received_events","type":"User","site_admin":false},"body":"Commit base lockhammer benchmark code and tests suite.  Additionally\r\ninclude some third-party algorithms which have been ported to work\r\nwith lockhammer.\r\n\r\nFixes #1\r\n\r\nChange-Id: Idab59148f91e944522eef3e187ec6430c03a69e9\r\nSigned-off-by: Lucas Crowthers <lucasc.qdt@qualcommdatacenter.com>","created_at":"2018-04-03T23:58:37Z","updated_at":"2018-04-12T20:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f315f15bf97bc545d582cc9812be2efacc4316da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/issues/2/comments","statuses_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/statuses/e80bd71842e745efafa263a8a24f6e7daf831247","head":{"label":"codeauroraforum:lockhammer","ref":"lockhammer","sha":"e80bd71842e745efafa263a8a24f6e7daf831247","user":{"login":"codeauroraforum","id":801156,"avatar_url":"https://avatars2.githubusercontent.com/u/801156?v=4","gravatar_id":"","url":"https://api.github.com/users/codeauroraforum","html_url":"https://github.com/codeauroraforum","followers_url":"https://api.github.com/users/codeauroraforum/followers","following_url":"https://api.github.com/users/codeauroraforum/following{/other_user}","gists_url":"https://api.github.com/users/codeauroraforum/gists{/gist_id}","starred_url":"https://api.github.com/users/codeauroraforum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeauroraforum/subscriptions","organizations_url":"https://api.github.com/users/codeauroraforum/orgs","repos_url":"https://api.github.com/users/codeauroraforum/repos","events_url":"https://api.github.com/users/codeauroraforum/events{/privacy}","received_events_url":"https://api.github.com/users/codeauroraforum/received_events","type":"Organization","site_admin":false},"repo":{"id":126507161,"name":"synchronization-benchmarks","full_name":"codeauroraforum/synchronization-benchmarks","owner":{"login":"codeauroraforum","id":801156,"avatar_url":"https://avatars2.githubusercontent.com/u/801156?v=4","gravatar_id":"","url":"https://api.github.com/users/codeauroraforum","html_url":"https://github.com/codeauroraforum","followers_url":"https://api.github.com/users/codeauroraforum/followers","following_url":"https://api.github.com/users/codeauroraforum/following{/other_user}","gists_url":"https://api.github.com/users/codeauroraforum/gists{/gist_id}","starred_url":"https://api.github.com/users/codeauroraforum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeauroraforum/subscriptions","organizations_url":"https://api.github.com/users/codeauroraforum/orgs","repos_url":"https://api.github.com/users/codeauroraforum/repos","events_url":"https://api.github.com/users/codeauroraforum/events{/privacy}","received_events_url":"https://api.github.com/users/codeauroraforum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeauroraforum/synchronization-benchmarks","description":"Collection of synchronization micro-benchmarks and traces from infrastructure applications","fork":true,"url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks","forks_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/forks","keys_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/teams","hooks_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/hooks","issue_events_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/events","assignees_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/tags","blobs_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/languages","stargazers_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/stargazers","contributors_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/contributors","subscribers_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/subscribers","subscription_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/subscription","commits_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/merges","archive_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/downloads","issues_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/labels{/name}","releases_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/codeauroraforum/synchronization-benchmarks/deployments","created_at":"2018-03-23T15:51:37Z","updated_at":"2018-03-23T16:00:37Z","pushed_at":"2018-04-12T20:16:16Z","git_url":"git://github.com/codeauroraforum/synchronization-benchmarks.git","ssh_url":"git@github.com:codeauroraforum/synchronization-benchmarks.git","clone_url":"https://github.com/codeauroraforum/synchronization-benchmarks.git","svn_url":"https://github.com/codeauroraforum/synchronization-benchmarks","homepage":"","size":44,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"db4694c2add3f6b73662eba21d997189f491b155","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":120775910,"name":"synchronization-benchmarks","full_name":"ARM-software/synchronization-benchmarks","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/synchronization-benchmarks","description":"Collection of synchronization micro-benchmarks and traces from infrastructure applications","fork":false,"url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks","forks_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/forks","keys_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/teams","hooks_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/events","assignees_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/tags","blobs_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/languages","stargazers_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/subscription","commits_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/merges","archive_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/downloads","issues_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/deployments","created_at":"2018-02-08T15:00:33Z","updated_at":"2018-04-02T19:03:17Z","pushed_at":"2018-04-12T20:16:17Z","git_url":"git://github.com/ARM-software/synchronization-benchmarks.git","ssh_url":"git@github.com:ARM-software/synchronization-benchmarks.git","clone_url":"https://github.com/ARM-software/synchronization-benchmarks.git","svn_url":"https://github.com/ARM-software/synchronization-benchmarks","homepage":"","size":7,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/2"},"html":{"href":"https://github.com/ARM-software/synchronization-benchmarks/pull/2"},"issue":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/issues/2"},"comments":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/synchronization-benchmarks/statuses/e80bd71842e745efafa263a8a24f6e7daf831247"}},"author_association":"NONE"}}
{"actor":{"display_login":"lucasclucasdo"}}