{"action":"created","issue":{"url":"https://api.github.com/repos/troessner/reek/issues/1341","repository_url":"https://api.github.com/repos/troessner/reek","labels_url":"https://api.github.com/repos/troessner/reek/issues/1341/labels{/name}","comments_url":"https://api.github.com/repos/troessner/reek/issues/1341/comments","events_url":"https://api.github.com/repos/troessner/reek/issues/1341/events","html_url":"https://github.com/troessner/reek/issues/1341","id":333052263,"node_id":"MDU6SXNzdWUzMzMwNTIyNjM=","number":1341,"title":"Detect old-style reek comments","user":{"login":"mvz","id":10898,"node_id":"MDQ6VXNlcjEwODk4","avatar_url":"https://avatars3.githubusercontent.com/u/10898?v=4","gravatar_id":"","url":"https://api.github.com/users/mvz","html_url":"https://github.com/mvz","followers_url":"https://api.github.com/users/mvz/followers","following_url":"https://api.github.com/users/mvz/following{/other_user}","gists_url":"https://api.github.com/users/mvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvz/subscriptions","organizations_url":"https://api.github.com/users/mvz/orgs","repos_url":"https://api.github.com/users/mvz/repos","events_url":"https://api.github.com/users/mvz/events{/privacy}","received_events_url":"https://api.github.com/users/mvz/received_events","type":"User","site_admin":false},"labels":[{"id":212539437,"node_id":"MDU6TGFiZWwyMTI1Mzk0Mzc=","url":"https://api.github.com/repos/troessner/reek/labels/discussion","name":"discussion","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-17T10:29:49Z","updated_at":"2018-06-17T10:59:43Z","closed_at":null,"author_association":"COLLABORATOR","body":"As noticed in #1322, Reek currently still accepts old-style comments with three colons, because the regex used will simply ignore the third colon and everything that follows, essentially blanked-disabling the given smell. This means users will not normally be aware that they need to update their code comments.\r\n\r\nOptions to fix:\r\n\r\n1. Detect this particular usage and complain about it loudly. We probably should have done this already when we deprecated the extra colon.\r\n2. Make the regex less lenient and just ignore the entire code comment if it doesn't use the new style. The reek failures should point out what needs updating, but this could be confusing.\r\n\r\nOption 2 could be implemented by:\r\n* Requiring the comment to come at the end of a line.\r\n* Requiring the comment to be followed by anything but a colon."},"comment":{"url":"https://api.github.com/repos/troessner/reek/issues/comments/397870892","html_url":"https://github.com/troessner/reek/issues/1341#issuecomment-397870892","issue_url":"https://api.github.com/repos/troessner/reek/issues/1341","id":397870892,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzg3MDg5Mg==","user":{"login":"troessner","id":271109,"node_id":"MDQ6VXNlcjI3MTEwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/271109?v=4","gravatar_id":"","url":"https://api.github.com/users/troessner","html_url":"https://github.com/troessner","followers_url":"https://api.github.com/users/troessner/followers","following_url":"https://api.github.com/users/troessner/following{/other_user}","gists_url":"https://api.github.com/users/troessner/gists{/gist_id}","starred_url":"https://api.github.com/users/troessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troessner/subscriptions","organizations_url":"https://api.github.com/users/troessner/orgs","repos_url":"https://api.github.com/users/troessner/repos","events_url":"https://api.github.com/users/troessner/events{/privacy}","received_events_url":"https://api.github.com/users/troessner/received_events","type":"User","site_admin":false},"created_at":"2018-06-17T10:59:43Z","updated_at":"2018-06-17T10:59:43Z","author_association":"OWNER","body":"Good points. I think this\r\n\r\n>> Detect this particular usage and complain about it loudly. We probably should have done this already when we deprecated the extra colon.\r\n\r\nwould be my favourite option :)"}}
{"actor":{"display_login":"troessner"}}