{"action":"created","issue":{"url":"https://api.github.com/repos/builderbook/builderbook/issues/144","repository_url":"https://api.github.com/repos/builderbook/builderbook","labels_url":"https://api.github.com/repos/builderbook/builderbook/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/builderbook/builderbook/issues/144/comments","events_url":"https://api.github.com/repos/builderbook/builderbook/issues/144/events","html_url":"https://github.com/builderbook/builderbook/issues/144","id":370070283,"node_id":"MDU6SXNzdWUzNzAwNzAyODM=","number":144,"title":"WithLayout","user":{"login":"thierryMic","id":21054294,"node_id":"MDQ6VXNlcjIxMDU0Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/21054294?v=4","gravatar_id":"","url":"https://api.github.com/users/thierryMic","html_url":"https://github.com/thierryMic","followers_url":"https://api.github.com/users/thierryMic/followers","following_url":"https://api.github.com/users/thierryMic/following{/other_user}","gists_url":"https://api.github.com/users/thierryMic/gists{/gist_id}","starred_url":"https://api.github.com/users/thierryMic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thierryMic/subscriptions","organizations_url":"https://api.github.com/users/thierryMic/orgs","repos_url":"https://api.github.com/users/thierryMic/repos","events_url":"https://api.github.com/users/thierryMic/events{/privacy}","received_events_url":"https://api.github.com/users/thierryMic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-15T09:17:09Z","updated_at":"2018-10-15T22:29:13Z","closed_at":null,"author_association":"NONE","body":"The examples that are provided by [materialp-ui](https://material-ui.com/getting-started/usage/) almost always make use of the WithLayout HOC. \r\n\r\nThe docs also seem to favour the WithStyles method over inlining [here](https://material-ui.com/getting-started/faq/#when-should-i-use-inline-style-vs-classes-)\r\n\r\nAny reason why builderbook does not use WithLayout? are there any downsides to using WithLayout?"},"comment":{"url":"https://api.github.com/repos/builderbook/builderbook/issues/comments/430036386","html_url":"https://github.com/builderbook/builderbook/issues/144#issuecomment-430036386","issue_url":"https://api.github.com/repos/builderbook/builderbook/issues/144","id":430036386,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDAzNjM4Ng==","user":{"login":"thierryMic","id":21054294,"node_id":"MDQ6VXNlcjIxMDU0Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/21054294?v=4","gravatar_id":"","url":"https://api.github.com/users/thierryMic","html_url":"https://github.com/thierryMic","followers_url":"https://api.github.com/users/thierryMic/followers","following_url":"https://api.github.com/users/thierryMic/following{/other_user}","gists_url":"https://api.github.com/users/thierryMic/gists{/gist_id}","starred_url":"https://api.github.com/users/thierryMic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thierryMic/subscriptions","organizations_url":"https://api.github.com/users/thierryMic/orgs","repos_url":"https://api.github.com/users/thierryMic/repos","events_url":"https://api.github.com/users/thierryMic/events{/privacy}","received_events_url":"https://api.github.com/users/thierryMic/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T22:29:13Z","updated_at":"2018-10-15T22:29:13Z","author_association":"NONE","body":"Yes @tima101 and more specifically, I am referring to Section 1 - Custom styles of Builder Book (the book itself).\r\n\r\nIt recommends 4 ways to add styles (although it does not exclude other methods):\r\n1. Inline style for a single element\r\n2. Reusable style for multiple elements within single page or component\r\n3. Reusable/importable style for multiple pages or components\r\n4. Global style for all pages in application\r\n\r\nNone of the above methods use the WithLayout HOC in the examples provided in the book and i wanted to know whether there is any downside to using the WithLayout HOC?"}}
{"actor":{"display_login":"thierryMic"}}