{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/folio-org/edge-common/pulls/3","id":195942873,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTQyODcz","html_url":"https://github.com/folio-org/edge-common/pull/3","diff_url":"https://github.com/folio-org/edge-common/pull/3.diff","patch_url":"https://github.com/folio-org/edge-common/pull/3.patch","issue_url":"https://api.github.com/repos/folio-org/edge-common/issues/3","number":3,"state":"open","locked":false,"title":"fast fail on missing password","user":{"login":"craigmcnally","id":24814831,"node_id":"MDQ6VXNlcjI0ODE0ODMx","avatar_url":"https://avatars1.githubusercontent.com/u/24814831?v=4","gravatar_id":"","url":"https://api.github.com/users/craigmcnally","html_url":"https://github.com/craigmcnally","followers_url":"https://api.github.com/users/craigmcnally/followers","following_url":"https://api.github.com/users/craigmcnally/following{/other_user}","gists_url":"https://api.github.com/users/craigmcnally/gists{/gist_id}","starred_url":"https://api.github.com/users/craigmcnally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigmcnally/subscriptions","organizations_url":"https://api.github.com/users/craigmcnally/orgs","repos_url":"https://api.github.com/users/craigmcnally/repos","events_url":"https://api.github.com/users/craigmcnally/events{/privacy}","received_events_url":"https://api.github.com/users/craigmcnally/received_events","type":"User","site_admin":false},"body":"The original implementation would log an error and continue w/ an empty string for the password when one could not be obtained from the secure store.  This essentially pushed the responsibility of failing the request out to FOLIO.\r\n\r\nGiven that this will almost never work (empty passwords shouldn't be allowed anyway), we should just fail the request right then and there, before even making a request to FOLIO.","created_at":"2018-06-19T20:07:11Z","updated_at":"2018-06-19T20:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/edge-common/pulls/3/commits","review_comments_url":"https://api.github.com/repos/folio-org/edge-common/pulls/3/comments","review_comment_url":"https://api.github.com/repos/folio-org/edge-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/edge-common/issues/3/comments","statuses_url":"https://api.github.com/repos/folio-org/edge-common/statuses/fa4a5d68191fee45b0561678867d7fb8c2bb855a","head":{"label":"folio-org:fastFailOnMissingPassword","ref":"fastFailOnMissingPassword","sha":"fa4a5d68191fee45b0561678867d7fb8c2bb855a","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":134621285,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2MjEyODU=","name":"edge-common","full_name":"folio-org/edge-common","owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/edge-common","description":"a shared library/framework for edge APIs","fork":false,"url":"https://api.github.com/repos/folio-org/edge-common","forks_url":"https://api.github.com/repos/folio-org/edge-common/forks","keys_url":"https://api.github.com/repos/folio-org/edge-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/edge-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/edge-common/teams","hooks_url":"https://api.github.com/repos/folio-org/edge-common/hooks","issue_events_url":"https://api.github.com/repos/folio-org/edge-common/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/edge-common/events","assignees_url":"https://api.github.com/repos/folio-org/edge-common/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/edge-common/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/edge-common/tags","blobs_url":"https://api.github.com/repos/folio-org/edge-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/edge-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/edge-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/edge-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/edge-common/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/edge-common/languages","stargazers_url":"https://api.github.com/repos/folio-org/edge-common/stargazers","contributors_url":"https://api.github.com/repos/folio-org/edge-common/contributors","subscribers_url":"https://api.github.com/repos/folio-org/edge-common/subscribers","subscription_url":"https://api.github.com/repos/folio-org/edge-common/subscription","commits_url":"https://api.github.com/repos/folio-org/edge-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/edge-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/edge-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/edge-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/edge-common/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/edge-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/edge-common/merges","archive_url":"https://api.github.com/repos/folio-org/edge-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/edge-common/downloads","issues_url":"https://api.github.com/repos/folio-org/edge-common/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/edge-common/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/edge-common/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/edge-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/edge-common/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/edge-common/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/edge-common/deployments","created_at":"2018-05-23T20:20:08Z","updated_at":"2018-06-18T18:34:09Z","pushed_at":"2018-06-19T20:04:50Z","git_url":"git://github.com/folio-org/edge-common.git","ssh_url":"git@github.com:folio-org/edge-common.git","clone_url":"https://github.com/folio-org/edge-common.git","svn_url":"https://github.com/folio-org/edge-common","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"cf85f40e11d5f2bc34c686ff51446970c46847bd","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":134621285,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2MjEyODU=","name":"edge-common","full_name":"folio-org/edge-common","owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/edge-common","description":"a shared library/framework for edge APIs","fork":false,"url":"https://api.github.com/repos/folio-org/edge-common","forks_url":"https://api.github.com/repos/folio-org/edge-common/forks","keys_url":"https://api.github.com/repos/folio-org/edge-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/edge-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/edge-common/teams","hooks_url":"https://api.github.com/repos/folio-org/edge-common/hooks","issue_events_url":"https://api.github.com/repos/folio-org/edge-common/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/edge-common/events","assignees_url":"https://api.github.com/repos/folio-org/edge-common/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/edge-common/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/edge-common/tags","blobs_url":"https://api.github.com/repos/folio-org/edge-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/edge-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/edge-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/edge-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/edge-common/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/edge-common/languages","stargazers_url":"https://api.github.com/repos/folio-org/edge-common/stargazers","contributors_url":"https://api.github.com/repos/folio-org/edge-common/contributors","subscribers_url":"https://api.github.com/repos/folio-org/edge-common/subscribers","subscription_url":"https://api.github.com/repos/folio-org/edge-common/subscription","commits_url":"https://api.github.com/repos/folio-org/edge-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/edge-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/edge-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/edge-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/edge-common/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/edge-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/edge-common/merges","archive_url":"https://api.github.com/repos/folio-org/edge-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/edge-common/downloads","issues_url":"https://api.github.com/repos/folio-org/edge-common/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/edge-common/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/edge-common/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/edge-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/edge-common/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/edge-common/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/edge-common/deployments","created_at":"2018-05-23T20:20:08Z","updated_at":"2018-06-18T18:34:09Z","pushed_at":"2018-06-19T20:04:50Z","git_url":"git://github.com/folio-org/edge-common.git","ssh_url":"git@github.com:folio-org/edge-common.git","clone_url":"https://github.com/folio-org/edge-common.git","svn_url":"https://github.com/folio-org/edge-common","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/edge-common/pulls/3"},"html":{"href":"https://github.com/folio-org/edge-common/pull/3"},"issue":{"href":"https://api.github.com/repos/folio-org/edge-common/issues/3"},"comments":{"href":"https://api.github.com/repos/folio-org/edge-common/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/edge-common/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/edge-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/edge-common/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/edge-common/statuses/fa4a5d68191fee45b0561678867d7fb8c2bb855a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":76,"deletions":57,"changed_files":10}}
{"actor":{"display_login":"craigmcnally"}}