{"action":"created","issue":{"url":"https://api.github.com/repos/intel/libyami/issues/833","repository_url":"https://api.github.com/repos/intel/libyami","labels_url":"https://api.github.com/repos/intel/libyami/issues/833/labels{/name}","comments_url":"https://api.github.com/repos/intel/libyami/issues/833/comments","events_url":"https://api.github.com/repos/intel/libyami/issues/833/events","html_url":"https://github.com/intel/libyami/issues/833","id":303555219,"number":833,"title":"Integer overflow for 32bit build in gtest","user":{"login":"kwizart","id":1677957,"avatar_url":"https://avatars0.githubusercontent.com/u/1677957?v=4","gravatar_id":"","url":"https://api.github.com/users/kwizart","html_url":"https://github.com/kwizart","followers_url":"https://api.github.com/users/kwizart/followers","following_url":"https://api.github.com/users/kwizart/following{/other_user}","gists_url":"https://api.github.com/users/kwizart/gists{/gist_id}","starred_url":"https://api.github.com/users/kwizart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwizart/subscriptions","organizations_url":"https://api.github.com/users/kwizart/orgs","repos_url":"https://api.github.com/users/kwizart/repos","events_url":"https://api.github.com/users/kwizart/events{/privacy}","received_events_url":"https://api.github.com/users/kwizart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"wangzj0601","id":29645985,"avatar_url":"https://avatars3.githubusercontent.com/u/29645985?v=4","gravatar_id":"","url":"https://api.github.com/users/wangzj0601","html_url":"https://github.com/wangzj0601","followers_url":"https://api.github.com/users/wangzj0601/followers","following_url":"https://api.github.com/users/wangzj0601/following{/other_user}","gists_url":"https://api.github.com/users/wangzj0601/gists{/gist_id}","starred_url":"https://api.github.com/users/wangzj0601/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangzj0601/subscriptions","organizations_url":"https://api.github.com/users/wangzj0601/orgs","repos_url":"https://api.github.com/users/wangzj0601/repos","events_url":"https://api.github.com/users/wangzj0601/events{/privacy}","received_events_url":"https://api.github.com/users/wangzj0601/received_events","type":"User","site_admin":false},"assignees":[{"login":"wangzj0601","id":29645985,"avatar_url":"https://avatars3.githubusercontent.com/u/29645985?v=4","gravatar_id":"","url":"https://api.github.com/users/wangzj0601","html_url":"https://github.com/wangzj0601","followers_url":"https://api.github.com/users/wangzj0601/followers","following_url":"https://api.github.com/users/wangzj0601/following{/other_user}","gists_url":"https://api.github.com/users/wangzj0601/gists{/gist_id}","starred_url":"https://api.github.com/users/wangzj0601/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangzj0601/subscriptions","organizations_url":"https://api.github.com/users/wangzj0601/orgs","repos_url":"https://api.github.com/users/wangzj0601/repos","events_url":"https://api.github.com/users/wangzj0601/events{/privacy}","received_events_url":"https://api.github.com/users/wangzj0601/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-03-08T17:00:51Z","updated_at":"2018-03-23T20:27:36Z","closed_at":null,"author_association":"NONE","body":"Building current git on fedora 27 i686 and armv7hl with gtest fails with:\r\n\r\n---\r\ng++ -DHAVE_CONFIG_H -I. -I..    -I../interface -I../gtestsrc/gtest/include   -g -O2 -Wall -Wno-unused-function -Wno-cpp -Wno-missing-braces -Werror  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m32 -march=i686 -mtune=generic -fasynchronous-unwind-tables -c -o unittest-utils_unittest.o `test -f 'utils_unittest.cpp' || echo './'`utils_unittest.cpp\r\nmake[2]: Leaving directory '/builddir/build/BUILD/libyami-40fa32e79f12c3c85c360532be00b7e4f9a35920/common'\r\nutils_unittest.cpp: In member function 'virtual void UtilsTest_guessResolutionOverflow_Test::TestBody()':\r\nutils_unittest.cpp:134:54: error: integer overflow in expression [-Werror=overflow]\r\n     sstream << long(std::numeric_limits<int>::max()) * 2 + 3\r\n                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~\r\nutils_unittest.cpp:136:54: error: integer overflow in expression [-Werror=overflow]\r\n             << long(std::numeric_limits<int>::max()) * 3 + 2;\r\n                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~\r\ncc1plus: all warnings being treated as errors"},"comment":{"url":"https://api.github.com/repos/intel/libyami/issues/comments/375788820","html_url":"https://github.com/intel/libyami/issues/833#issuecomment-375788820","issue_url":"https://api.github.com/repos/intel/libyami/issues/833","id":375788820,"user":{"login":"uartie","id":677859,"avatar_url":"https://avatars1.githubusercontent.com/u/677859?v=4","gravatar_id":"","url":"https://api.github.com/users/uartie","html_url":"https://github.com/uartie","followers_url":"https://api.github.com/users/uartie/followers","following_url":"https://api.github.com/users/uartie/following{/other_user}","gists_url":"https://api.github.com/users/uartie/gists{/gist_id}","starred_url":"https://api.github.com/users/uartie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uartie/subscriptions","organizations_url":"https://api.github.com/users/uartie/orgs","repos_url":"https://api.github.com/users/uartie/repos","events_url":"https://api.github.com/users/uartie/events{/privacy}","received_events_url":"https://api.github.com/users/uartie/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T20:27:36Z","updated_at":"2018-03-23T20:27:36Z","author_association":"CONTRIBUTOR","body":"OK, `long` and `int` are the same size on 32-bit compiler... thus, coercing the type to `long long` to clear the error and get the test to compile is not enough.  The test will still fail when executed... and clearly it exposes another underlying flaw in the `guessResolution` function.\r\n\r\nFYI, there are many more compiler errors on 32-bit builds beyond this (try enabling all encoders, decoders and debug and you'll see).  Clearly, no one had 32-bit support in mind when developing this library."}}
{"actor":{"display_login":"uartie"}}