{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/kazatsuyu/fafnir/pulls/16","id":183557667,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzNTU3NjY3","html_url":"https://github.com/kazatsuyu/fafnir/pull/16","diff_url":"https://github.com/kazatsuyu/fafnir/pull/16.diff","patch_url":"https://github.com/kazatsuyu/fafnir/pull/16.patch","issue_url":"https://api.github.com/repos/kazatsuyu/fafnir/issues/16","number":16,"state":"closed","locked":false,"title":"toolset props change to fix msvs always out of date bug with clang-cl.","user":{"login":"bherrera-reify","id":23617979,"node_id":"MDQ6VXNlcjIzNjE3OTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23617979?v=4","gravatar_id":"","url":"https://api.github.com/users/bherrera-reify","html_url":"https://github.com/bherrera-reify","followers_url":"https://api.github.com/users/bherrera-reify/followers","following_url":"https://api.github.com/users/bherrera-reify/following{/other_user}","gists_url":"https://api.github.com/users/bherrera-reify/gists{/gist_id}","starred_url":"https://api.github.com/users/bherrera-reify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bherrera-reify/subscriptions","organizations_url":"https://api.github.com/users/bherrera-reify/orgs","repos_url":"https://api.github.com/users/bherrera-reify/repos","events_url":"https://api.github.com/users/bherrera-reify/events{/privacy}","received_events_url":"https://api.github.com/users/bherrera-reify/received_events","type":"User","site_admin":false},"body":"When building projects using the clang-cl toolset integration visual studio always thinks the projects are out of date. \r\nThis is due to clang-cl not generating intermediate pdb files. It silently ignores the command line option specifying the name of intermediate pdb files and puts debug data in the .obj files.\r\n\r\nadding a tag to the toolset props compile section to clear that command line argument keeps MSVS from looking for the file and assuming project is out of date.\r\n\r\nadditional change eliminates an annoying ignored command line argument warning.","created_at":"2018-04-23T21:06:32Z","updated_at":"2018-11-09T19:36:49Z","closed_at":"2018-11-09T19:36:49Z","merged_at":null,"merge_commit_sha":"26931f6583775a8f921915ea60250348f3d73a5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kazatsuyu/fafnir/pulls/16/commits","review_comments_url":"https://api.github.com/repos/kazatsuyu/fafnir/pulls/16/comments","review_comment_url":"https://api.github.com/repos/kazatsuyu/fafnir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kazatsuyu/fafnir/issues/16/comments","statuses_url":"https://api.github.com/repos/kazatsuyu/fafnir/statuses/fbfe78366a70d8c5c2cb7b31aee07e2d0e61b4ef","head":{"label":"Reification:fix-clang-cl-msvs-always-out-of-date","ref":"fix-clang-cl-msvs-always-out-of-date","sha":"fbfe78366a70d8c5c2cb7b31aee07e2d0e61b4ef","user":{"login":"Reification","id":26049283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDQ5Mjgz","avatar_url":"https://avatars3.githubusercontent.com/u/26049283?v=4","gravatar_id":"","url":"https://api.github.com/users/Reification","html_url":"https://github.com/Reification","followers_url":"https://api.github.com/users/Reification/followers","following_url":"https://api.github.com/users/Reification/following{/other_user}","gists_url":"https://api.github.com/users/Reification/gists{/gist_id}","starred_url":"https://api.github.com/users/Reification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reification/subscriptions","organizations_url":"https://api.github.com/users/Reification/orgs","repos_url":"https://api.github.com/users/Reification/repos","events_url":"https://api.github.com/users/Reification/events{/privacy}","received_events_url":"https://api.github.com/users/Reification/received_events","type":"Organization","site_admin":false},"repo":{"id":129146140,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxNDYxNDA=","name":"fafnir","full_name":"Reification/fafnir","private":false,"owner":{"login":"Reification","id":26049283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDQ5Mjgz","avatar_url":"https://avatars3.githubusercontent.com/u/26049283?v=4","gravatar_id":"","url":"https://api.github.com/users/Reification","html_url":"https://github.com/Reification","followers_url":"https://api.github.com/users/Reification/followers","following_url":"https://api.github.com/users/Reification/following{/other_user}","gists_url":"https://api.github.com/users/Reification/gists{/gist_id}","starred_url":"https://api.github.com/users/Reification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reification/subscriptions","organizations_url":"https://api.github.com/users/Reification/orgs","repos_url":"https://api.github.com/users/Reification/repos","events_url":"https://api.github.com/users/Reification/events{/privacy}","received_events_url":"https://api.github.com/users/Reification/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Reification/fafnir","description":"Clang MSBuild toolset for Visual Studio 2017","fork":true,"url":"https://api.github.com/repos/Reification/fafnir","forks_url":"https://api.github.com/repos/Reification/fafnir/forks","keys_url":"https://api.github.com/repos/Reification/fafnir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Reification/fafnir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Reification/fafnir/teams","hooks_url":"https://api.github.com/repos/Reification/fafnir/hooks","issue_events_url":"https://api.github.com/repos/Reification/fafnir/issues/events{/number}","events_url":"https://api.github.com/repos/Reification/fafnir/events","assignees_url":"https://api.github.com/repos/Reification/fafnir/assignees{/user}","branches_url":"https://api.github.com/repos/Reification/fafnir/branches{/branch}","tags_url":"https://api.github.com/repos/Reification/fafnir/tags","blobs_url":"https://api.github.com/repos/Reification/fafnir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Reification/fafnir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Reification/fafnir/git/refs{/sha}","trees_url":"https://api.github.com/repos/Reification/fafnir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Reification/fafnir/statuses/{sha}","languages_url":"https://api.github.com/repos/Reification/fafnir/languages","stargazers_url":"https://api.github.com/repos/Reification/fafnir/stargazers","contributors_url":"https://api.github.com/repos/Reification/fafnir/contributors","subscribers_url":"https://api.github.com/repos/Reification/fafnir/subscribers","subscription_url":"https://api.github.com/repos/Reification/fafnir/subscription","commits_url":"https://api.github.com/repos/Reification/fafnir/commits{/sha}","git_commits_url":"https://api.github.com/repos/Reification/fafnir/git/commits{/sha}","comments_url":"https://api.github.com/repos/Reification/fafnir/comments{/number}","issue_comment_url":"https://api.github.com/repos/Reification/fafnir/issues/comments{/number}","contents_url":"https://api.github.com/repos/Reification/fafnir/contents/{+path}","compare_url":"https://api.github.com/repos/Reification/fafnir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Reification/fafnir/merges","archive_url":"https://api.github.com/repos/Reification/fafnir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Reification/fafnir/downloads","issues_url":"https://api.github.com/repos/Reification/fafnir/issues{/number}","pulls_url":"https://api.github.com/repos/Reification/fafnir/pulls{/number}","milestones_url":"https://api.github.com/repos/Reification/fafnir/milestones{/number}","notifications_url":"https://api.github.com/repos/Reification/fafnir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Reification/fafnir/labels{/name}","releases_url":"https://api.github.com/repos/Reification/fafnir/releases{/id}","deployments_url":"https://api.github.com/repos/Reification/fafnir/deployments","created_at":"2018-04-11T19:50:24Z","updated_at":"2018-09-25T19:59:58Z","pushed_at":"2018-11-09T19:36:49Z","git_url":"git://github.com/Reification/fafnir.git","ssh_url":"git@github.com:Reification/fafnir.git","clone_url":"https://github.com/Reification/fafnir.git","svn_url":"https://github.com/Reification/fafnir","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"feature-clang-cl-hooked"}},"base":{"label":"kazatsuyu:master","ref":"master","sha":"829b669f1b6686c5d04017f5a1ba172be4e6d957","user":{"login":"kazatsuyu","id":6465609,"node_id":"MDQ6VXNlcjY0NjU2MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6465609?v=4","gravatar_id":"","url":"https://api.github.com/users/kazatsuyu","html_url":"https://github.com/kazatsuyu","followers_url":"https://api.github.com/users/kazatsuyu/followers","following_url":"https://api.github.com/users/kazatsuyu/following{/other_user}","gists_url":"https://api.github.com/users/kazatsuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/kazatsuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazatsuyu/subscriptions","organizations_url":"https://api.github.com/users/kazatsuyu/orgs","repos_url":"https://api.github.com/users/kazatsuyu/repos","events_url":"https://api.github.com/users/kazatsuyu/events{/privacy}","received_events_url":"https://api.github.com/users/kazatsuyu/received_events","type":"User","site_admin":false},"repo":{"id":122076705,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIwNzY3MDU=","name":"fafnir","full_name":"kazatsuyu/fafnir","private":false,"owner":{"login":"kazatsuyu","id":6465609,"node_id":"MDQ6VXNlcjY0NjU2MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6465609?v=4","gravatar_id":"","url":"https://api.github.com/users/kazatsuyu","html_url":"https://github.com/kazatsuyu","followers_url":"https://api.github.com/users/kazatsuyu/followers","following_url":"https://api.github.com/users/kazatsuyu/following{/other_user}","gists_url":"https://api.github.com/users/kazatsuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/kazatsuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazatsuyu/subscriptions","organizations_url":"https://api.github.com/users/kazatsuyu/orgs","repos_url":"https://api.github.com/users/kazatsuyu/repos","events_url":"https://api.github.com/users/kazatsuyu/events{/privacy}","received_events_url":"https://api.github.com/users/kazatsuyu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kazatsuyu/fafnir","description":"Clang MSBuild toolset for Visual Studio 2017","fork":false,"url":"https://api.github.com/repos/kazatsuyu/fafnir","forks_url":"https://api.github.com/repos/kazatsuyu/fafnir/forks","keys_url":"https://api.github.com/repos/kazatsuyu/fafnir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kazatsuyu/fafnir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kazatsuyu/fafnir/teams","hooks_url":"https://api.github.com/repos/kazatsuyu/fafnir/hooks","issue_events_url":"https://api.github.com/repos/kazatsuyu/fafnir/issues/events{/number}","events_url":"https://api.github.com/repos/kazatsuyu/fafnir/events","assignees_url":"https://api.github.com/repos/kazatsuyu/fafnir/assignees{/user}","branches_url":"https://api.github.com/repos/kazatsuyu/fafnir/branches{/branch}","tags_url":"https://api.github.com/repos/kazatsuyu/fafnir/tags","blobs_url":"https://api.github.com/repos/kazatsuyu/fafnir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kazatsuyu/fafnir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kazatsuyu/fafnir/git/refs{/sha}","trees_url":"https://api.github.com/repos/kazatsuyu/fafnir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kazatsuyu/fafnir/statuses/{sha}","languages_url":"https://api.github.com/repos/kazatsuyu/fafnir/languages","stargazers_url":"https://api.github.com/repos/kazatsuyu/fafnir/stargazers","contributors_url":"https://api.github.com/repos/kazatsuyu/fafnir/contributors","subscribers_url":"https://api.github.com/repos/kazatsuyu/fafnir/subscribers","subscription_url":"https://api.github.com/repos/kazatsuyu/fafnir/subscription","commits_url":"https://api.github.com/repos/kazatsuyu/fafnir/commits{/sha}","git_commits_url":"https://api.github.com/repos/kazatsuyu/fafnir/git/commits{/sha}","comments_url":"https://api.github.com/repos/kazatsuyu/fafnir/comments{/number}","issue_comment_url":"https://api.github.com/repos/kazatsuyu/fafnir/issues/comments{/number}","contents_url":"https://api.github.com/repos/kazatsuyu/fafnir/contents/{+path}","compare_url":"https://api.github.com/repos/kazatsuyu/fafnir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kazatsuyu/fafnir/merges","archive_url":"https://api.github.com/repos/kazatsuyu/fafnir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kazatsuyu/fafnir/downloads","issues_url":"https://api.github.com/repos/kazatsuyu/fafnir/issues{/number}","pulls_url":"https://api.github.com/repos/kazatsuyu/fafnir/pulls{/number}","milestones_url":"https://api.github.com/repos/kazatsuyu/fafnir/milestones{/number}","notifications_url":"https://api.github.com/repos/kazatsuyu/fafnir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kazatsuyu/fafnir/labels{/name}","releases_url":"https://api.github.com/repos/kazatsuyu/fafnir/releases{/id}","deployments_url":"https://api.github.com/repos/kazatsuyu/fafnir/deployments","created_at":"2018-02-19T14:49:09Z","updated_at":"2018-11-02T10:38:46Z","pushed_at":"2018-04-27T13:15:06Z","git_url":"git://github.com/kazatsuyu/fafnir.git","ssh_url":"git@github.com:kazatsuyu/fafnir.git","clone_url":"https://github.com/kazatsuyu/fafnir.git","svn_url":"https://github.com/kazatsuyu/fafnir","homepage":null,"size":30,"stargazers_count":30,"watchers_count":30,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":6,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kazatsuyu/fafnir/pulls/16"},"html":{"href":"https://github.com/kazatsuyu/fafnir/pull/16"},"issue":{"href":"https://api.github.com/repos/kazatsuyu/fafnir/issues/16"},"comments":{"href":"https://api.github.com/repos/kazatsuyu/fafnir/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/kazatsuyu/fafnir/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/kazatsuyu/fafnir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kazatsuyu/fafnir/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/kazatsuyu/fafnir/statuses/fbfe78366a70d8c5c2cb7b31aee07e2d0e61b4ef"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"bherrera-reify"}}