{"action":"closed","number":129,"pull_request":{"url":"https://api.github.com/repos/nipy/heudiconv/pulls/129","id":161432184,"html_url":"https://github.com/nipy/heudiconv/pull/129","diff_url":"https://github.com/nipy/heudiconv/pull/129.diff","patch_url":"https://github.com/nipy/heudiconv/pull/129.patch","issue_url":"https://api.github.com/repos/nipy/heudiconv/issues/129","number":129,"state":"closed","locked":false,"title":"Fixes from DBIC field-test site and code rodeo coding session (AKA reaching convergence)","user":{"login":"yarikoptic","id":39889,"avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"body":"Unfortunately we are still using the codebase which is not yet refactored as in the master (planing to look at switching may be while at code rodeo), some fixes piled up and provided here:\r\n- no git-annex shared access should be configured.  That one is leading to weak data protection so not enabled (files could be then modified in place, ruining assumptions/checksums)\r\n- few extensions/fixes in heuristics (for SE sequences for AP/PA fieldmap correction etc)\r\n- allow to override the subject id\r\n\r\nIf possible, please merge, and not just pick the changes into master since otherwise it makes it a bit more difficult for me to track what was already adopted into master and what not.\r\n\r\n# Further work during rodeo\r\n\r\n- A change in heuristic will trigger a regeneration of the conversion table\r\n- `--overwrite` guards are reincarnated -- if the converted files already exist and no `--overwrite` is provided, the run will error out\r\n\r\n# Doing comparisons against our \"production\" version\r\n\r\nHere I outline critical differences detected/resolved when checked\r\n- [x] session got lost while trying on [///dicoms/dartmouth-phantoms/bids_test4-20161014/phantom-1](http://datasets.datalad.org/?dir=/dicoms/dartmouth-phantoms/bids_test4-20161014/phantom-1) which defined session in the scout sequence\r\n- [x] possible to override the subject\r\n- [x] reincrnate logging -- now it is just a NullLogger without any way to control from env vars like it did before\r\n- [x] fix up for the tests\r\n```\r\ntests/test_heuristics.py:58: in test_dbic_bids_largely_smoke\r\n    runner(args)\r\nE   Failed: DID NOT RAISE <type 'exceptions.RuntimeError'>\r\n```\r\n  ","created_at":"2018-01-05T21:34:44Z","updated_at":"2018-02-02T20:57:06Z","closed_at":"2018-02-02T20:57:06Z","merged_at":"2018-02-02T20:57:06Z","merge_commit_sha":"35e95b611a36540c425504dee6c9ed6675f32e22","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/nipy/heudiconv/pulls/129/commits","review_comments_url":"https://api.github.com/repos/nipy/heudiconv/pulls/129/comments","review_comment_url":"https://api.github.com/repos/nipy/heudiconv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/heudiconv/issues/129/comments","statuses_url":"https://api.github.com/repos/nipy/heudiconv/statuses/f4ac1c8dca905d00b6b77b02ed9752db097e5194","head":{"label":"dartmouth-pbs:merge-enh-dbic2","ref":"merge-enh-dbic2","sha":"f4ac1c8dca905d00b6b77b02ed9752db097e5194","user":{"login":"dartmouth-pbs","id":10568366,"avatar_url":"https://avatars0.githubusercontent.com/u/10568366?v=4","gravatar_id":"","url":"https://api.github.com/users/dartmouth-pbs","html_url":"https://github.com/dartmouth-pbs","followers_url":"https://api.github.com/users/dartmouth-pbs/followers","following_url":"https://api.github.com/users/dartmouth-pbs/following{/other_user}","gists_url":"https://api.github.com/users/dartmouth-pbs/gists{/gist_id}","starred_url":"https://api.github.com/users/dartmouth-pbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dartmouth-pbs/subscriptions","organizations_url":"https://api.github.com/users/dartmouth-pbs/orgs","repos_url":"https://api.github.com/users/dartmouth-pbs/repos","events_url":"https://api.github.com/users/dartmouth-pbs/events{/privacy}","received_events_url":"https://api.github.com/users/dartmouth-pbs/received_events","type":"Organization","site_admin":false},"repo":{"id":68424727,"name":"heudiconv","full_name":"dartmouth-pbs/heudiconv","owner":{"login":"dartmouth-pbs","id":10568366,"avatar_url":"https://avatars0.githubusercontent.com/u/10568366?v=4","gravatar_id":"","url":"https://api.github.com/users/dartmouth-pbs","html_url":"https://github.com/dartmouth-pbs","followers_url":"https://api.github.com/users/dartmouth-pbs/followers","following_url":"https://api.github.com/users/dartmouth-pbs/following{/other_user}","gists_url":"https://api.github.com/users/dartmouth-pbs/gists{/gist_id}","starred_url":"https://api.github.com/users/dartmouth-pbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dartmouth-pbs/subscriptions","organizations_url":"https://api.github.com/users/dartmouth-pbs/orgs","repos_url":"https://api.github.com/users/dartmouth-pbs/repos","events_url":"https://api.github.com/users/dartmouth-pbs/events{/privacy}","received_events_url":"https://api.github.com/users/dartmouth-pbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dartmouth-pbs/heudiconv","description":"little helper to ease DICOM conversion to ready-to-share folder with heuristics","fork":true,"url":"https://api.github.com/repos/dartmouth-pbs/heudiconv","forks_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/forks","keys_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/teams","hooks_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/hooks","issue_events_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/issues/events{/number}","events_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/events","assignees_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/assignees{/user}","branches_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/branches{/branch}","tags_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/tags","blobs_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/git/refs{/sha}","trees_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/statuses/{sha}","languages_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/languages","stargazers_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/stargazers","contributors_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/contributors","subscribers_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/subscribers","subscription_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/subscription","commits_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/commits{/sha}","git_commits_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/git/commits{/sha}","comments_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/comments{/number}","issue_comment_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/issues/comments{/number}","contents_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/contents/{+path}","compare_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/merges","archive_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/downloads","issues_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/issues{/number}","pulls_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/pulls{/number}","milestones_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/milestones{/number}","notifications_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/labels{/name}","releases_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/releases{/id}","deployments_url":"https://api.github.com/repos/dartmouth-pbs/heudiconv/deployments","created_at":"2016-09-17T01:12:50Z","updated_at":"2016-10-31T15:12:37Z","pushed_at":"2018-02-02T02:47:37Z","git_url":"git://github.com/dartmouth-pbs/heudiconv.git","ssh_url":"git@github.com:dartmouth-pbs/heudiconv.git","clone_url":"https://github.com/dartmouth-pbs/heudiconv.git","svn_url":"https://github.com/dartmouth-pbs/heudiconv","homepage":null,"size":582,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":1,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"45502759e3a0bfa957031409dfde0572aaf28270","user":{"login":"nipy","id":233707,"avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":42650211,"name":"heudiconv","full_name":"nipy/heudiconv","owner":{"login":"nipy","id":233707,"avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/heudiconv","description":"little helper to ease DICOM conversion to ready-to-share folder with heuristics","fork":false,"url":"https://api.github.com/repos/nipy/heudiconv","forks_url":"https://api.github.com/repos/nipy/heudiconv/forks","keys_url":"https://api.github.com/repos/nipy/heudiconv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/heudiconv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/heudiconv/teams","hooks_url":"https://api.github.com/repos/nipy/heudiconv/hooks","issue_events_url":"https://api.github.com/repos/nipy/heudiconv/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/heudiconv/events","assignees_url":"https://api.github.com/repos/nipy/heudiconv/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/heudiconv/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/heudiconv/tags","blobs_url":"https://api.github.com/repos/nipy/heudiconv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/heudiconv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/heudiconv/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/heudiconv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/heudiconv/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/heudiconv/languages","stargazers_url":"https://api.github.com/repos/nipy/heudiconv/stargazers","contributors_url":"https://api.github.com/repos/nipy/heudiconv/contributors","subscribers_url":"https://api.github.com/repos/nipy/heudiconv/subscribers","subscription_url":"https://api.github.com/repos/nipy/heudiconv/subscription","commits_url":"https://api.github.com/repos/nipy/heudiconv/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/heudiconv/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/heudiconv/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/heudiconv/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/heudiconv/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/heudiconv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/heudiconv/merges","archive_url":"https://api.github.com/repos/nipy/heudiconv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/heudiconv/downloads","issues_url":"https://api.github.com/repos/nipy/heudiconv/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/heudiconv/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/heudiconv/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/heudiconv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/heudiconv/labels{/name}","releases_url":"https://api.github.com/repos/nipy/heudiconv/releases{/id}","deployments_url":"https://api.github.com/repos/nipy/heudiconv/deployments","created_at":"2015-09-17T10:34:11Z","updated_at":"2018-02-01T14:50:22Z","pushed_at":"2018-02-02T20:57:06Z","git_url":"git://github.com/nipy/heudiconv.git","ssh_url":"git@github.com:nipy/heudiconv.git","clone_url":"https://github.com/nipy/heudiconv.git","svn_url":"https://github.com/nipy/heudiconv","homepage":null,"size":542,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":33,"open_issues":40,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/129"},"html":{"href":"https://github.com/nipy/heudiconv/pull/129"},"issue":{"href":"https://api.github.com/repos/nipy/heudiconv/issues/129"},"comments":{"href":"https://api.github.com/repos/nipy/heudiconv/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/heudiconv/statuses/f4ac1c8dca905d00b6b77b02ed9752db097e5194"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"yarikoptic","id":39889,"avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"maintainer_can_modify":false,"commits":49,"additions":243,"deletions":82,"changed_files":16}}
{"actor":{"display_login":"yarikoptic"}}