{"action":"created","issue":{"url":"https://api.github.com/repos/cbeust/testng/issues/1783","repository_url":"https://api.github.com/repos/cbeust/testng","labels_url":"https://api.github.com/repos/cbeust/testng/issues/1783/labels{/name}","comments_url":"https://api.github.com/repos/cbeust/testng/issues/1783/comments","events_url":"https://api.github.com/repos/cbeust/testng/issues/1783/events","html_url":"https://github.com/cbeust/testng/pull/1783","id":322862741,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3ODYxOTc5","number":1783,"title":"Assure thread affinity","user":{"login":"krmahadevan","id":909773,"node_id":"MDQ6VXNlcjkwOTc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-05-14T15:17:31Z","updated_at":"2018-11-15T05:31:08Z","closed_at":"2018-05-17T16:17:52Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/cbeust/testng/pulls/1783","html_url":"https://github.com/cbeust/testng/pull/1783","diff_url":"https://github.com/cbeust/testng/pull/1783.diff","patch_url":"https://github.com/cbeust/testng/pull/1783.patch"},"body":"Closes #89, #1050, #1066, #1173, #1185\r\n\r\nThis PR aims at assuring that methods that fall\r\nunder the below two use cases, all run on the \r\nsame thread when classes are being run in parallel:\r\n\r\n* @Test methods in a class are ordered by priority\r\n* @Test methods have a single dependency on \r\nanother method using “dependsOnMethods” attribute.\r\n\r\nThe thread affinity feature is supposed to be \r\n“experimental” and it can be turned on via the\r\nJVM argument : `-Dtestng.thread.affinity=true`\r\n\r\nThis feature is turned off by default just to \r\nensure that we don’t have any users experiencing\r\nun-usual behavior.\r\n\r\nFixes #89, #1050, #1066, #1173, #1185\r\n\r\n### Did you remember to?\r\n\r\n- [X] Add test case(s)\r\n- [X] Update `CHANGES.txt`\r\n\r\nWe encourage pull requests that:\r\n\r\n* Add new features to TestNG (or)\r\n* Fix bugs in TestNG\r\n\r\nIf your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the \r\n[TestNG-dev](https://groups.google.com/forum/#!forum/testng-dev) before you spend time working on it."},"comment":{"url":"https://api.github.com/repos/cbeust/testng/issues/comments/438922885","html_url":"https://github.com/cbeust/testng/pull/1783#issuecomment-438922885","issue_url":"https://api.github.com/repos/cbeust/testng/issues/1783","id":438922885,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODkyMjg4NQ==","user":{"login":"krmahadevan","id":909773,"node_id":"MDQ6VXNlcjkwOTc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T05:31:08Z","updated_at":"2018-11-15T05:31:08Z","author_association":"COLLABORATOR","body":"Nope. I dont think its related to \"timeout\". Its mainly to force dependent\nmethods to run on the same thread as their upstream methods.\nBut if you are asking what happens when I add a \"timeout\" attribute to an\n\"@Test\" method that depends on an upstream method, run with parallelism\nenabled and with the JVM argument set as \"-Dtestng.thread.affinity=true\",\nthat I am not sure. I believe the \"timeout\" is always a special case,\nbecause TestNG always runs methods that have \"timeout\" attributes in a\nseparate thread instead of the current one. So this JVM flag may not hold\ntrue for these sort of methods. But no harm in quickly trying out. Can you\nplease help try it out quickly and post back your findings ?\n"}}
{"actor":{"display_login":"krmahadevan"}}