{"action":"created","issue":{"url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/issues/12457","repository_url":"https://api.github.com/repos/MicrosoftDocs/azure-docs","labels_url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/issues/12457/labels{/name}","comments_url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/issues/12457/comments","events_url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/issues/12457/events","html_url":"https://github.com/MicrosoftDocs/azure-docs/issues/12457","id":345026027,"node_id":"MDU6SXNzdWUzNDUwMjYwMjc=","number":12457,"title":"Secrets as octet sequences","user":{"login":"nickwalkmsft","id":13544453,"node_id":"MDQ6VXNlcjEzNTQ0NDUz","avatar_url":"https://avatars0.githubusercontent.com/u/13544453?v=4","gravatar_id":"","url":"https://api.github.com/users/nickwalkmsft","html_url":"https://github.com/nickwalkmsft","followers_url":"https://api.github.com/users/nickwalkmsft/followers","following_url":"https://api.github.com/users/nickwalkmsft/following{/other_user}","gists_url":"https://api.github.com/users/nickwalkmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickwalkmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickwalkmsft/subscriptions","organizations_url":"https://api.github.com/users/nickwalkmsft/orgs","repos_url":"https://api.github.com/users/nickwalkmsft/repos","events_url":"https://api.github.com/users/nickwalkmsft/events{/privacy}","received_events_url":"https://api.github.com/users/nickwalkmsft/received_events","type":"User","site_admin":false},"labels":[{"id":836704823,"node_id":"MDU6TGFiZWw4MzY3MDQ4MjM=","url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/labels/assigned-to-author","name":"assigned-to-author","color":"e01f8f","default":false},{"id":836704994,"node_id":"MDU6TGFiZWw4MzY3MDQ5OTQ=","url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/labels/doc-enhancement","name":"doc-enhancement","color":"50f936","default":false},{"id":646556848,"node_id":"MDU6TGFiZWw2NDY1NTY4NDg=","url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/labels/key-vault/svc","name":"key-vault/svc","color":"0040cc","default":false},{"id":836702742,"node_id":"MDU6TGFiZWw4MzY3MDI3NDI=","url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/labels/triaged","name":"triaged","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"msmbaldwin","id":5092332,"node_id":"MDQ6VXNlcjUwOTIzMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5092332?v=4","gravatar_id":"","url":"https://api.github.com/users/msmbaldwin","html_url":"https://github.com/msmbaldwin","followers_url":"https://api.github.com/users/msmbaldwin/followers","following_url":"https://api.github.com/users/msmbaldwin/following{/other_user}","gists_url":"https://api.github.com/users/msmbaldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/msmbaldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmbaldwin/subscriptions","organizations_url":"https://api.github.com/users/msmbaldwin/orgs","repos_url":"https://api.github.com/users/msmbaldwin/repos","events_url":"https://api.github.com/users/msmbaldwin/events{/privacy}","received_events_url":"https://api.github.com/users/msmbaldwin/received_events","type":"User","site_admin":false},"assignees":[{"login":"msmbaldwin","id":5092332,"node_id":"MDQ6VXNlcjUwOTIzMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5092332?v=4","gravatar_id":"","url":"https://api.github.com/users/msmbaldwin","html_url":"https://github.com/msmbaldwin","followers_url":"https://api.github.com/users/msmbaldwin/followers","following_url":"https://api.github.com/users/msmbaldwin/following{/other_user}","gists_url":"https://api.github.com/users/msmbaldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/msmbaldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmbaldwin/subscriptions","organizations_url":"https://api.github.com/users/msmbaldwin/orgs","repos_url":"https://api.github.com/users/msmbaldwin/repos","events_url":"https://api.github.com/users/msmbaldwin/events{/privacy}","received_events_url":"https://api.github.com/users/msmbaldwin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-07-26T22:22:11Z","updated_at":"2018-10-12T19:16:54Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Why does the \"Working with secrets\" section describe secrets as octet sequences? Secret values in the API are strings. The only client I've seen with direct support for anything else is the CLI, and it supports arbitrary data by using base64 or hex encoding.\r\n\r\nThe first paragraph also describes secrets as \"limited size octet objects\".\r\n\r\n---\r\n#### Document Details\r\n\r\n⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*\r\n\r\n* ID: 962e9ebe-e97f-7a56-03a4-33662454bdfe\r\n* Version Independent ID: 7fda1b8c-67e2-a304-1f17-bfd5a0422766\r\n* Content: [About keys, secrets and certificates](https://docs.microsoft.com/en-us/azure/key-vault/about-keys-secrets-and-certificates#key-vault-general-details)\r\n* Content Source: [articles/key-vault/about-keys-secrets-and-certificates.md](https://github.com/Microsoft/azure-docs/blob/master/articles/key-vault/about-keys-secrets-and-certificates.md)\r\n* Service: **key-vault**\r\n* GitHub Login: @lleonard-msft\r\n* Microsoft Alias: **alleonar**"},"comment":{"url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/issues/comments/429432760","html_url":"https://github.com/MicrosoftDocs/azure-docs/issues/12457#issuecomment-429432760","issue_url":"https://api.github.com/repos/MicrosoftDocs/azure-docs/issues/12457","id":429432760,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQzMjc2MA==","user":{"login":"BryanLa","id":10890027,"node_id":"MDQ6VXNlcjEwODkwMDI3","avatar_url":"https://avatars3.githubusercontent.com/u/10890027?v=4","gravatar_id":"","url":"https://api.github.com/users/BryanLa","html_url":"https://github.com/BryanLa","followers_url":"https://api.github.com/users/BryanLa/followers","following_url":"https://api.github.com/users/BryanLa/following{/other_user}","gists_url":"https://api.github.com/users/BryanLa/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanLa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanLa/subscriptions","organizations_url":"https://api.github.com/users/BryanLa/orgs","repos_url":"https://api.github.com/users/BryanLa/repos","events_url":"https://api.github.com/users/BryanLa/events{/privacy}","received_events_url":"https://api.github.com/users/BryanLa/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T19:16:54Z","updated_at":"2018-10-12T19:16:54Z","author_association":"CONTRIBUTOR","body":"Hi @nickwalkmsft - thanks very much for this feedback, and apologies for the delay in getting back to you.\r\n\r\nI would tend to agree with you, that the \"octet\" term doesn't add a lot of value, and as you said, might even be confusing to some folks. As such, I'm going to propose the following changes:\r\n\r\n- in the [intro paragraph of About keys, secrets, and certificates](https://docs.microsoft.com/azure/key-vault/about-keys-secrets-and-certificates), the 2nd \"Secrets\" bullet:\r\n  - change the first sentence to *Provides secure storage of secrets, such as passwords and database connection strings.*\r\n  - remove the 2nd sentence: *Secrets are limited size octet objects with no specific semantics.*\r\n\r\n- in [the Working with secrets section](https://docs.microsoft.com/en-us/azure/key-vault/about-keys-secrets-and-certificates#working-with-secrets)\r\n   - change the sentence: *Secrets in Key Vault are octet sequences with a maximum size of 25k bytes each.* , to: *From a developer's perspective, Key Vault APIs accept and return secret values as strings. Internally, Key Vault stores and manages secrets as sequences of octets (8-bit bytes), with a maximum size of 25k bytes each.*\r\n\r\nThese changes should be live later today. Thanks again for the feedback on this.\r\n\r\n#please-close"}}
{"actor":{"display_login":"BryanLa"}}