{"action":"closed","number":627,"pull_request":{"url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/627","id":217144524,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTQ0NTI0","html_url":"https://github.com/CityOfZion/neo-python/pull/627","diff_url":"https://github.com/CityOfZion/neo-python/pull/627.diff","patch_url":"https://github.com/CityOfZion/neo-python/pull/627.patch","issue_url":"https://api.github.com/repos/CityOfZion/neo-python/issues/627","number":627,"state":"closed","locked":false,"title":"Fix AccountState","user":{"login":"jseagrave21","id":40873301,"node_id":"MDQ6VXNlcjQwODczMzAx","avatar_url":"https://avatars0.githubusercontent.com/u/40873301?v=4","gravatar_id":"","url":"https://api.github.com/users/jseagrave21","html_url":"https://github.com/jseagrave21","followers_url":"https://api.github.com/users/jseagrave21/followers","following_url":"https://api.github.com/users/jseagrave21/following{/other_user}","gists_url":"https://api.github.com/users/jseagrave21/gists{/gist_id}","starred_url":"https://api.github.com/users/jseagrave21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseagrave21/subscriptions","organizations_url":"https://api.github.com/users/jseagrave21/orgs","repos_url":"https://api.github.com/users/jseagrave21/repos","events_url":"https://api.github.com/users/jseagrave21/events{/privacy}","received_events_url":"https://api.github.com/users/jseagrave21/received_events","type":"User","site_admin":false},"body":"**What current issue(s) does this address, or what feature is it adding?**\r\nThis PR addresses Issue #608 \r\n\r\nPrimarily it fixes 'script_hash' so that output is actually the address string's scripthash\r\n\r\nSecondarily it:\r\n- Adds an 'address' key, so the address is also displayed so `account` and `wallet` are more user-friendly\r\n- Adds a test for `ToJson` in AccountState\r\n- Replaces the variable `script_hash` in `GetAccountState` in LevelDBBlockchain with `address` because the input is an address not a scripthash\r\n- Adds a test for `GetAccountState` in LevelDBBlockchain\r\n\r\n**How did you solve this problem?**\r\n- Trial and Error\r\n- discussion with @ixje concerning the intended functionality of `getaccountstate` and `script_hash`\r\n- @hal0x2328 helped me understand that the privatenet consensus nodes running in docker are running neo-cli, not neo-python.\r\n\r\n**How did you make sure your solution works?**\r\nUnittest\r\n\r\n**Are there any special changes in the code that we should be aware of?**\r\nNo\r\n\r\n**Please check the following, if applicable:**\r\n\r\n- [x] Did you add any tests?\r\n- [x] Did you run `make lint`?\r\n- [x] Did you run `make test`?\r\n- [x] Are you making a PR to a feature branch or development rather than master?\r\n- [x] Did you add an entry to `CHANGELOG.rst`? (if not, please do)\r\n","created_at":"2018-09-21T00:50:36Z","updated_at":"2018-10-06T19:54:53Z","closed_at":"2018-10-06T19:54:53Z","merged_at":"2018-10-06T19:54:52Z","merge_commit_sha":"c78e20442fdfa6d5b9aeac815a05e07883158b5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/627/commits","review_comments_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/627/comments","review_comment_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CityOfZion/neo-python/issues/627/comments","statuses_url":"https://api.github.com/repos/CityOfZion/neo-python/statuses/ae8a91a600731d1d34505405d205e53d6052e807","head":{"label":"jseagrave21:Fix-AccountState","ref":"Fix-AccountState","sha":"ae8a91a600731d1d34505405d205e53d6052e807","user":{"login":"jseagrave21","id":40873301,"node_id":"MDQ6VXNlcjQwODczMzAx","avatar_url":"https://avatars0.githubusercontent.com/u/40873301?v=4","gravatar_id":"","url":"https://api.github.com/users/jseagrave21","html_url":"https://github.com/jseagrave21","followers_url":"https://api.github.com/users/jseagrave21/followers","following_url":"https://api.github.com/users/jseagrave21/following{/other_user}","gists_url":"https://api.github.com/users/jseagrave21/gists{/gist_id}","starred_url":"https://api.github.com/users/jseagrave21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseagrave21/subscriptions","organizations_url":"https://api.github.com/users/jseagrave21/orgs","repos_url":"https://api.github.com/users/jseagrave21/repos","events_url":"https://api.github.com/users/jseagrave21/events{/privacy}","received_events_url":"https://api.github.com/users/jseagrave21/received_events","type":"User","site_admin":false},"repo":{"id":139907465,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5MDc0NjU=","name":"neo-python","full_name":"jseagrave21/neo-python","private":false,"owner":{"login":"jseagrave21","id":40873301,"node_id":"MDQ6VXNlcjQwODczMzAx","avatar_url":"https://avatars0.githubusercontent.com/u/40873301?v=4","gravatar_id":"","url":"https://api.github.com/users/jseagrave21","html_url":"https://github.com/jseagrave21","followers_url":"https://api.github.com/users/jseagrave21/followers","following_url":"https://api.github.com/users/jseagrave21/following{/other_user}","gists_url":"https://api.github.com/users/jseagrave21/gists{/gist_id}","starred_url":"https://api.github.com/users/jseagrave21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseagrave21/subscriptions","organizations_url":"https://api.github.com/users/jseagrave21/orgs","repos_url":"https://api.github.com/users/jseagrave21/repos","events_url":"https://api.github.com/users/jseagrave21/events{/privacy}","received_events_url":"https://api.github.com/users/jseagrave21/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jseagrave21/neo-python","description":"Python Node and SDK for the NEO blockchain","fork":true,"url":"https://api.github.com/repos/jseagrave21/neo-python","forks_url":"https://api.github.com/repos/jseagrave21/neo-python/forks","keys_url":"https://api.github.com/repos/jseagrave21/neo-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jseagrave21/neo-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jseagrave21/neo-python/teams","hooks_url":"https://api.github.com/repos/jseagrave21/neo-python/hooks","issue_events_url":"https://api.github.com/repos/jseagrave21/neo-python/issues/events{/number}","events_url":"https://api.github.com/repos/jseagrave21/neo-python/events","assignees_url":"https://api.github.com/repos/jseagrave21/neo-python/assignees{/user}","branches_url":"https://api.github.com/repos/jseagrave21/neo-python/branches{/branch}","tags_url":"https://api.github.com/repos/jseagrave21/neo-python/tags","blobs_url":"https://api.github.com/repos/jseagrave21/neo-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jseagrave21/neo-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jseagrave21/neo-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/jseagrave21/neo-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jseagrave21/neo-python/statuses/{sha}","languages_url":"https://api.github.com/repos/jseagrave21/neo-python/languages","stargazers_url":"https://api.github.com/repos/jseagrave21/neo-python/stargazers","contributors_url":"https://api.github.com/repos/jseagrave21/neo-python/contributors","subscribers_url":"https://api.github.com/repos/jseagrave21/neo-python/subscribers","subscription_url":"https://api.github.com/repos/jseagrave21/neo-python/subscription","commits_url":"https://api.github.com/repos/jseagrave21/neo-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/jseagrave21/neo-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/jseagrave21/neo-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/jseagrave21/neo-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/jseagrave21/neo-python/contents/{+path}","compare_url":"https://api.github.com/repos/jseagrave21/neo-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jseagrave21/neo-python/merges","archive_url":"https://api.github.com/repos/jseagrave21/neo-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jseagrave21/neo-python/downloads","issues_url":"https://api.github.com/repos/jseagrave21/neo-python/issues{/number}","pulls_url":"https://api.github.com/repos/jseagrave21/neo-python/pulls{/number}","milestones_url":"https://api.github.com/repos/jseagrave21/neo-python/milestones{/number}","notifications_url":"https://api.github.com/repos/jseagrave21/neo-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jseagrave21/neo-python/labels{/name}","releases_url":"https://api.github.com/repos/jseagrave21/neo-python/releases{/id}","deployments_url":"https://api.github.com/repos/jseagrave21/neo-python/deployments","created_at":"2018-07-05T22:40:49Z","updated_at":"2018-09-30T17:48:25Z","pushed_at":"2018-10-05T08:59:38Z","git_url":"git://github.com/jseagrave21/neo-python.git","ssh_url":"git@github.com:jseagrave21/neo-python.git","clone_url":"https://github.com/jseagrave21/neo-python.git","svn_url":"https://github.com/jseagrave21/neo-python","homepage":"https://neo-python.readthedocs.io/en/latest/","size":120424,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"CityOfZion:development","ref":"development","sha":"1990beaf97c01051b75de1867f6a547eee7f5d9e","user":{"login":"CityOfZion","id":29782569,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzgyNTY5","avatar_url":"https://avatars1.githubusercontent.com/u/29782569?v=4","gravatar_id":"","url":"https://api.github.com/users/CityOfZion","html_url":"https://github.com/CityOfZion","followers_url":"https://api.github.com/users/CityOfZion/followers","following_url":"https://api.github.com/users/CityOfZion/following{/other_user}","gists_url":"https://api.github.com/users/CityOfZion/gists{/gist_id}","starred_url":"https://api.github.com/users/CityOfZion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CityOfZion/subscriptions","organizations_url":"https://api.github.com/users/CityOfZion/orgs","repos_url":"https://api.github.com/users/CityOfZion/repos","events_url":"https://api.github.com/users/CityOfZion/events{/privacy}","received_events_url":"https://api.github.com/users/CityOfZion/received_events","type":"Organization","site_admin":false},"repo":{"id":97416422,"node_id":"MDEwOlJlcG9zaXRvcnk5NzQxNjQyMg==","name":"neo-python","full_name":"CityOfZion/neo-python","private":false,"owner":{"login":"CityOfZion","id":29782569,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzgyNTY5","avatar_url":"https://avatars1.githubusercontent.com/u/29782569?v=4","gravatar_id":"","url":"https://api.github.com/users/CityOfZion","html_url":"https://github.com/CityOfZion","followers_url":"https://api.github.com/users/CityOfZion/followers","following_url":"https://api.github.com/users/CityOfZion/following{/other_user}","gists_url":"https://api.github.com/users/CityOfZion/gists{/gist_id}","starred_url":"https://api.github.com/users/CityOfZion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CityOfZion/subscriptions","organizations_url":"https://api.github.com/users/CityOfZion/orgs","repos_url":"https://api.github.com/users/CityOfZion/repos","events_url":"https://api.github.com/users/CityOfZion/events{/privacy}","received_events_url":"https://api.github.com/users/CityOfZion/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CityOfZion/neo-python","description":"Python Node and SDK for the NEO blockchain","fork":false,"url":"https://api.github.com/repos/CityOfZion/neo-python","forks_url":"https://api.github.com/repos/CityOfZion/neo-python/forks","keys_url":"https://api.github.com/repos/CityOfZion/neo-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CityOfZion/neo-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CityOfZion/neo-python/teams","hooks_url":"https://api.github.com/repos/CityOfZion/neo-python/hooks","issue_events_url":"https://api.github.com/repos/CityOfZion/neo-python/issues/events{/number}","events_url":"https://api.github.com/repos/CityOfZion/neo-python/events","assignees_url":"https://api.github.com/repos/CityOfZion/neo-python/assignees{/user}","branches_url":"https://api.github.com/repos/CityOfZion/neo-python/branches{/branch}","tags_url":"https://api.github.com/repos/CityOfZion/neo-python/tags","blobs_url":"https://api.github.com/repos/CityOfZion/neo-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CityOfZion/neo-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CityOfZion/neo-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/CityOfZion/neo-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CityOfZion/neo-python/statuses/{sha}","languages_url":"https://api.github.com/repos/CityOfZion/neo-python/languages","stargazers_url":"https://api.github.com/repos/CityOfZion/neo-python/stargazers","contributors_url":"https://api.github.com/repos/CityOfZion/neo-python/contributors","subscribers_url":"https://api.github.com/repos/CityOfZion/neo-python/subscribers","subscription_url":"https://api.github.com/repos/CityOfZion/neo-python/subscription","commits_url":"https://api.github.com/repos/CityOfZion/neo-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/CityOfZion/neo-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/CityOfZion/neo-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/CityOfZion/neo-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/CityOfZion/neo-python/contents/{+path}","compare_url":"https://api.github.com/repos/CityOfZion/neo-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CityOfZion/neo-python/merges","archive_url":"https://api.github.com/repos/CityOfZion/neo-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CityOfZion/neo-python/downloads","issues_url":"https://api.github.com/repos/CityOfZion/neo-python/issues{/number}","pulls_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls{/number}","milestones_url":"https://api.github.com/repos/CityOfZion/neo-python/milestones{/number}","notifications_url":"https://api.github.com/repos/CityOfZion/neo-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CityOfZion/neo-python/labels{/name}","releases_url":"https://api.github.com/repos/CityOfZion/neo-python/releases{/id}","deployments_url":"https://api.github.com/repos/CityOfZion/neo-python/deployments","created_at":"2017-07-16T23:05:32Z","updated_at":"2018-10-04T17:39:12Z","pushed_at":"2018-10-06T19:54:52Z","git_url":"git://github.com/CityOfZion/neo-python.git","ssh_url":"git@github.com:CityOfZion/neo-python.git","clone_url":"https://github.com/CityOfZion/neo-python.git","svn_url":"https://github.com/CityOfZion/neo-python","homepage":"https://neo-python.readthedocs.io/en/latest/","size":120114,"stargazers_count":270,"watchers_count":270,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":188,"open_issues":41,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/627"},"html":{"href":"https://github.com/CityOfZion/neo-python/pull/627"},"issue":{"href":"https://api.github.com/repos/CityOfZion/neo-python/issues/627"},"comments":{"href":"https://api.github.com/repos/CityOfZion/neo-python/issues/627/comments"},"review_comments":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/627/comments"},"review_comment":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/627/commits"},"statuses":{"href":"https://api.github.com/repos/CityOfZion/neo-python/statuses/ae8a91a600731d1d34505405d205e53d6052e807"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"localhuman","id":192884,"node_id":"MDQ6VXNlcjE5Mjg4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/192884?v=4","gravatar_id":"","url":"https://api.github.com/users/localhuman","html_url":"https://github.com/localhuman","followers_url":"https://api.github.com/users/localhuman/followers","following_url":"https://api.github.com/users/localhuman/following{/other_user}","gists_url":"https://api.github.com/users/localhuman/gists{/gist_id}","starred_url":"https://api.github.com/users/localhuman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localhuman/subscriptions","organizations_url":"https://api.github.com/users/localhuman/orgs","repos_url":"https://api.github.com/users/localhuman/repos","events_url":"https://api.github.com/users/localhuman/events{/privacy}","received_events_url":"https://api.github.com/users/localhuman/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":21,"additions":37,"deletions":10,"changed_files":8}}
{"actor":{"display_login":"localhuman"}}