{"action":"created","comment":{"url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/comments/173553130","pull_request_review_id":102770872,"id":173553130,"diff_hunk":"@@ -234,10 +258,10 @@ var Legend = React.createClass({\n \t},\n \n \trender: function () {\n-\t\tlet { groups, setActiveLabel, activeLabel } = this.props;\n-\t\tlet { colors, curves, labels } = groups;\n+\t\tlet {groups, setActiveLabel, activeLabel} = this.props;\n+\t\tlet {colors, curves, labels} = groups;\n \t\tlet sets = _.zip(colors, curves, labels)\n-\t\t\t\t\t.map(set => makeLegendKey(set, setActiveLabel, activeLabel));\n+\t\t\t.map(set => makeLegendKey(set, setActiveLabel, activeLabel));","path":"js/KmPlot.js","position":204,"original_position":204,"commit_id":"1320bae4b220721550a655734db369ee5faf63bf","original_commit_id":"1320bae4b220721550a655734db369ee5faf63bf","user":{"login":"acthp","id":494506,"avatar_url":"https://avatars3.githubusercontent.com/u/494506?v=4","gravatar_id":"","url":"https://api.github.com/users/acthp","html_url":"https://github.com/acthp","followers_url":"https://api.github.com/users/acthp/followers","following_url":"https://api.github.com/users/acthp/following{/other_user}","gists_url":"https://api.github.com/users/acthp/gists{/gist_id}","starred_url":"https://api.github.com/users/acthp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acthp/subscriptions","organizations_url":"https://api.github.com/users/acthp/orgs","repos_url":"https://api.github.com/users/acthp/repos","events_url":"https://api.github.com/users/acthp/events{/privacy}","received_events_url":"https://api.github.com/users/acthp/received_events","type":"User","site_admin":false},"body":"ws","created_at":"2018-03-09T20:00:16Z","updated_at":"2018-03-09T20:05:18Z","html_url":"https://github.com/ucscXena/ucsc-xena-client/pull/212#discussion_r173553130","pull_request_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/212","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/comments/173553130"},"html":{"href":"https://github.com/ucscXena/ucsc-xena-client/pull/212#discussion_r173553130"},"pull_request":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/212","id":173055496,"html_url":"https://github.com/ucscXena/ucsc-xena-client/pull/212","diff_url":"https://github.com/ucscXena/ucsc-xena-client/pull/212.diff","patch_url":"https://github.com/ucscXena/ucsc-xena-client/pull/212.patch","issue_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/issues/212","number":212,"state":"open","locked":false,"title":"Refactor kmPlot issue #199","user":{"login":"syt123450","id":7977100,"avatar_url":"https://avatars2.githubusercontent.com/u/7977100?v=4","gravatar_id":"","url":"https://api.github.com/users/syt123450","html_url":"https://github.com/syt123450","followers_url":"https://api.github.com/users/syt123450/followers","following_url":"https://api.github.com/users/syt123450/following{/other_user}","gists_url":"https://api.github.com/users/syt123450/gists{/gist_id}","starred_url":"https://api.github.com/users/syt123450/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syt123450/subscriptions","organizations_url":"https://api.github.com/users/syt123450/orgs","repos_url":"https://api.github.com/users/syt123450/repos","events_url":"https://api.github.com/users/syt123450/events{/privacy}","received_events_url":"https://api.github.com/users/syt123450/received_events","type":"User","site_admin":false},"body":"In this PR, I refactor the kmPlot, remove the bootstrap dependencies, and adjust some UI.\r\n\r\nIn remove bootstrap dependencies part:\r\n1. Replace the bootstrap widget with react-toolbox widget\r\n2. Replace the bootstrap classes with our own classes, defined in \"km.css\".\r\n\r\nIn adjust UI part:\r\n1. Align the PDF button\r\n2. Remove the close button(I think there is a close icon in the right top corner, there is no need to have one special close button)\r\n3. Add icon in PDF button and Help button to let them more representative\r\n4. Change the help link with help button, so there is a uniformed UI\r\n5. Change the cursor style (when user hover on the right list, the original cursor style is \"text\", is as if the list is editable, it is a little bit puzzling, I change it with the default cursor)\r\n6. Adjust the basic UI including margin, padding, and so on.\r\n\r\nPS. All function has been tested, they can work well in Chrome, Safari, and Firefox.\r\n\r\nThe original kmPlot UI is as shown below:\r\n<img width=\"750\" alt=\"kmplot\" src=\"https://user-images.githubusercontent.com/7977100/37013914-d491fb82-20b1-11e8-9446-39acd518f1df.png\">\r\n<img width=\"750\" alt=\"pwarning\" src=\"https://user-images.githubusercontent.com/7977100/37013916-d896a2aa-20b1-11e8-9d32-aa49e673fe7e.png\">\r\n\r\nThe kmPlot UI after refactoring is as shown below:\r\n<img width=\"750\" alt=\"kmplotnew\" src=\"https://user-images.githubusercontent.com/7977100/37013925-ea261e92-20b1-11e8-81f0-d32e19736755.png\">\r\n<img width=\"750\" alt=\"pwarningnew\" src=\"https://user-images.githubusercontent.com/7977100/37013934-fb6d245c-20b1-11e8-9bd6-ba4dc2bdb685.png\">\r\n","created_at":"2018-03-06T04:30:10Z","updated_at":"2018-03-09T20:05:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b747d4a18c8a12d5aaccdfc1a7a3fe4f5440711","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/212/commits","review_comments_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/212/comments","review_comment_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/issues/212/comments","statuses_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/statuses/1320bae4b220721550a655734db369ee5faf63bf","head":{"label":"syt123450:master","ref":"master","sha":"1320bae4b220721550a655734db369ee5faf63bf","user":{"login":"syt123450","id":7977100,"avatar_url":"https://avatars2.githubusercontent.com/u/7977100?v=4","gravatar_id":"","url":"https://api.github.com/users/syt123450","html_url":"https://github.com/syt123450","followers_url":"https://api.github.com/users/syt123450/followers","following_url":"https://api.github.com/users/syt123450/following{/other_user}","gists_url":"https://api.github.com/users/syt123450/gists{/gist_id}","starred_url":"https://api.github.com/users/syt123450/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syt123450/subscriptions","organizations_url":"https://api.github.com/users/syt123450/orgs","repos_url":"https://api.github.com/users/syt123450/repos","events_url":"https://api.github.com/users/syt123450/events{/privacy}","received_events_url":"https://api.github.com/users/syt123450/received_events","type":"User","site_admin":false},"repo":{"id":123685600,"name":"ucsc-xena-client","full_name":"syt123450/ucsc-xena-client","owner":{"login":"syt123450","id":7977100,"avatar_url":"https://avatars2.githubusercontent.com/u/7977100?v=4","gravatar_id":"","url":"https://api.github.com/users/syt123450","html_url":"https://github.com/syt123450","followers_url":"https://api.github.com/users/syt123450/followers","following_url":"https://api.github.com/users/syt123450/following{/other_user}","gists_url":"https://api.github.com/users/syt123450/gists{/gist_id}","starred_url":"https://api.github.com/users/syt123450/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syt123450/subscriptions","organizations_url":"https://api.github.com/users/syt123450/orgs","repos_url":"https://api.github.com/users/syt123450/repos","events_url":"https://api.github.com/users/syt123450/events{/privacy}","received_events_url":"https://api.github.com/users/syt123450/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syt123450/ucsc-xena-client","description":"Functional genomics browser","fork":true,"url":"https://api.github.com/repos/syt123450/ucsc-xena-client","forks_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/forks","keys_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/teams","hooks_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/hooks","issue_events_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/issues/events{/number}","events_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/events","assignees_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/assignees{/user}","branches_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/branches{/branch}","tags_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/tags","blobs_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/statuses/{sha}","languages_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/languages","stargazers_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/stargazers","contributors_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/contributors","subscribers_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/subscribers","subscription_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/subscription","commits_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/contents/{+path}","compare_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/merges","archive_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/downloads","issues_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/issues{/number}","pulls_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/pulls{/number}","milestones_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/milestones{/number}","notifications_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/labels{/name}","releases_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/releases{/id}","deployments_url":"https://api.github.com/repos/syt123450/ucsc-xena-client/deployments","created_at":"2018-03-03T11:25:57Z","updated_at":"2018-03-03T11:25:59Z","pushed_at":"2018-03-09T03:52:22Z","git_url":"git://github.com/syt123450/ucsc-xena-client.git","ssh_url":"git@github.com:syt123450/ucsc-xena-client.git","clone_url":"https://github.com/syt123450/ucsc-xena-client.git","svn_url":"https://github.com/syt123450/ucsc-xena-client","homepage":null,"size":4579,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ucscXena:master","ref":"master","sha":"093f84bf174688529ae43dc17b0508add2c00640","user":{"login":"ucscXena","id":17650455,"avatar_url":"https://avatars0.githubusercontent.com/u/17650455?v=4","gravatar_id":"","url":"https://api.github.com/users/ucscXena","html_url":"https://github.com/ucscXena","followers_url":"https://api.github.com/users/ucscXena/followers","following_url":"https://api.github.com/users/ucscXena/following{/other_user}","gists_url":"https://api.github.com/users/ucscXena/gists{/gist_id}","starred_url":"https://api.github.com/users/ucscXena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucscXena/subscriptions","organizations_url":"https://api.github.com/users/ucscXena/orgs","repos_url":"https://api.github.com/users/ucscXena/repos","events_url":"https://api.github.com/users/ucscXena/events{/privacy}","received_events_url":"https://api.github.com/users/ucscXena/received_events","type":"Organization","site_admin":false},"repo":{"id":32299985,"name":"ucsc-xena-client","full_name":"ucscXena/ucsc-xena-client","owner":{"login":"ucscXena","id":17650455,"avatar_url":"https://avatars0.githubusercontent.com/u/17650455?v=4","gravatar_id":"","url":"https://api.github.com/users/ucscXena","html_url":"https://github.com/ucscXena","followers_url":"https://api.github.com/users/ucscXena/followers","following_url":"https://api.github.com/users/ucscXena/following{/other_user}","gists_url":"https://api.github.com/users/ucscXena/gists{/gist_id}","starred_url":"https://api.github.com/users/ucscXena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucscXena/subscriptions","organizations_url":"https://api.github.com/users/ucscXena/orgs","repos_url":"https://api.github.com/users/ucscXena/repos","events_url":"https://api.github.com/users/ucscXena/events{/privacy}","received_events_url":"https://api.github.com/users/ucscXena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucscXena/ucsc-xena-client","description":"Functional genomics browser","fork":false,"url":"https://api.github.com/repos/ucscXena/ucsc-xena-client","forks_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/forks","keys_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/teams","hooks_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/hooks","issue_events_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/issues/events{/number}","events_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/events","assignees_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/assignees{/user}","branches_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/branches{/branch}","tags_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/tags","blobs_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/languages","stargazers_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/stargazers","contributors_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/contributors","subscribers_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/subscribers","subscription_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/subscription","commits_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/contents/{+path}","compare_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/merges","archive_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/downloads","issues_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/issues{/number}","pulls_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/labels{/name}","releases_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/releases{/id}","deployments_url":"https://api.github.com/repos/ucscXena/ucsc-xena-client/deployments","created_at":"2015-03-16T03:50:04Z","updated_at":"2018-03-07T16:25:40Z","pushed_at":"2018-03-09T03:52:24Z","git_url":"git://github.com/ucscXena/ucsc-xena-client.git","ssh_url":"git@github.com:ucscXena/ucsc-xena-client.git","clone_url":"https://github.com/ucscXena/ucsc-xena-client.git","svn_url":"https://github.com/ucscXena/ucsc-xena-client","homepage":null,"size":4575,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":22,"open_issues":47,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/212"},"html":{"href":"https://github.com/ucscXena/ucsc-xena-client/pull/212"},"issue":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/issues/212"},"comments":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/ucscXena/ucsc-xena-client/statuses/1320bae4b220721550a655734db369ee5faf63bf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"acthp"}}