{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webrtc-quic/pulls/comments/241217237","pull_request_review_id":184436007,"id":241217237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTIxNzIzNw==","diff_hunk":"@@ -301,6 +302,55 @@ <h2>Methods</h2>\n                 <em>Return type:</em> <code><a>QuicSendStream</a></code>\n               </div>\n             </dd>\n+            <dt><dfn><code>readyToSendDatagram</code></dfn></dt>\n+            <dd>\n+              <p>Returns a promise that will be <a>fulfilled</a> when the QuicTransport can send\n+              a datagram as defined by [[QUIC-DATAGRAM]].</p>\n+              <p>When <code>readyToSend</code> is called, the user agent\n+              <em class=\"rfc2119\" title=\"MUST\">MUST</em> run the following\n+              steps:</p>\n+              <ol>\n+                <li>\n+                  <p>Let <var>p</var> be a new promise.</p>\n+                </li>\n+                <li>\n+                  <p>Let <var>transport</var> be the\n+                  <code><a>QuicTransportBase</a></code> on which\n+                  <code>readyToSend</code> is invoked.</p>","path":"cs.html","position":null,"original_position":28,"commit_id":"02b20786b6ea97faea7ae231cf60f5897eaa8747","original_commit_id":"a52b0ee2d1f66fc9b1941b27e97b87eccdce3ce0","user":{"login":"shampson","id":6474514,"node_id":"MDQ6VXNlcjY0NzQ1MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6474514?v=4","gravatar_id":"","url":"https://api.github.com/users/shampson","html_url":"https://github.com/shampson","followers_url":"https://api.github.com/users/shampson/followers","following_url":"https://api.github.com/users/shampson/following{/other_user}","gists_url":"https://api.github.com/users/shampson/gists{/gist_id}","starred_url":"https://api.github.com/users/shampson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shampson/subscriptions","organizations_url":"https://api.github.com/users/shampson/orgs","repos_url":"https://api.github.com/users/shampson/repos","events_url":"https://api.github.com/users/shampson/events{/privacy}","received_events_url":"https://api.github.com/users/shampson/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-12-12T23:00:37Z","updated_at":"2018-12-12T23:00:37Z","html_url":"https://github.com/w3c/webrtc-quic/pull/89#discussion_r241217237","pull_request_url":"https://api.github.com/repos/w3c/webrtc-quic/pulls/89","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-quic/pulls/comments/241217237"},"html":{"href":"https://github.com/w3c/webrtc-quic/pull/89#discussion_r241217237"},"pull_request":{"href":"https://api.github.com/repos/w3c/webrtc-quic/pulls/89"}},"in_reply_to_id":241070485},"pull_request":{"url":"https://api.github.com/repos/w3c/webrtc-quic/pulls/89","id":234159094,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTU5MDk0","html_url":"https://github.com/w3c/webrtc-quic/pull/89","diff_url":"https://github.com/w3c/webrtc-quic/pull/89.diff","patch_url":"https://github.com/w3c/webrtc-quic/pull/89.patch","issue_url":"https://api.github.com/repos/w3c/webrtc-quic/issues/89","number":89,"state":"open","locked":false,"title":"Add support for sending and receiving datagrams","user":{"login":"pthatcherg","id":7774202,"node_id":"MDQ6VXNlcjc3NzQyMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/7774202?v=4","gravatar_id":"","url":"https://api.github.com/users/pthatcherg","html_url":"https://github.com/pthatcherg","followers_url":"https://api.github.com/users/pthatcherg/followers","following_url":"https://api.github.com/users/pthatcherg/following{/other_user}","gists_url":"https://api.github.com/users/pthatcherg/gists{/gist_id}","starred_url":"https://api.github.com/users/pthatcherg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pthatcherg/subscriptions","organizations_url":"https://api.github.com/users/pthatcherg/orgs","repos_url":"https://api.github.com/users/pthatcherg/repos","events_url":"https://api.github.com/users/pthatcherg/events{/privacy}","received_events_url":"https://api.github.com/users/pthatcherg/received_events","type":"User","site_admin":false},"body":"This is my first pass at adding support for sending and receiving datagrams.  \r\n\r\nI went with a simple mechanism for backpressure and simple support for knowing when the datagram is acked.\r\n\r\nIt doesn't have WHATWG streams, but we could make a variant using those.  It may make the backpressure easier but would make receiving acks more complicated.","created_at":"2018-11-28T06:10:28Z","updated_at":"2018-12-12T23:00:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd85893f75203cec032df03824882ded6cc47378","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/webrtc-quic/pulls/89/commits","review_comments_url":"https://api.github.com/repos/w3c/webrtc-quic/pulls/89/comments","review_comment_url":"https://api.github.com/repos/w3c/webrtc-quic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webrtc-quic/issues/89/comments","statuses_url":"https://api.github.com/repos/w3c/webrtc-quic/statuses/02b20786b6ea97faea7ae231cf60f5897eaa8747","head":{"label":"w3c:datagram","ref":"datagram","sha":"02b20786b6ea97faea7ae231cf60f5897eaa8747","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":111784745,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3ODQ3NDU=","name":"webrtc-quic","full_name":"w3c/webrtc-quic","private":false,"owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/w3c/webrtc-quic","description":"Interface to create and manage QUIC streams","fork":false,"url":"https://api.github.com/repos/w3c/webrtc-quic","forks_url":"https://api.github.com/repos/w3c/webrtc-quic/forks","keys_url":"https://api.github.com/repos/w3c/webrtc-quic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webrtc-quic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webrtc-quic/teams","hooks_url":"https://api.github.com/repos/w3c/webrtc-quic/hooks","issue_events_url":"https://api.github.com/repos/w3c/webrtc-quic/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webrtc-quic/events","assignees_url":"https://api.github.com/repos/w3c/webrtc-quic/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webrtc-quic/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webrtc-quic/tags","blobs_url":"https://api.github.com/repos/w3c/webrtc-quic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webrtc-quic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webrtc-quic/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webrtc-quic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webrtc-quic/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webrtc-quic/languages","stargazers_url":"https://api.github.com/repos/w3c/webrtc-quic/stargazers","contributors_url":"https://api.github.com/repos/w3c/webrtc-quic/contributors","subscribers_url":"https://api.github.com/repos/w3c/webrtc-quic/subscribers","subscription_url":"https://api.github.com/repos/w3c/webrtc-quic/subscription","commits_url":"https://api.github.com/repos/w3c/webrtc-quic/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webrtc-quic/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webrtc-quic/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webrtc-quic/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webrtc-quic/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webrtc-quic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webrtc-quic/merges","archive_url":"https://api.github.com/repos/w3c/webrtc-quic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webrtc-quic/downloads","issues_url":"https://api.github.com/repos/w3c/webrtc-quic/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webrtc-quic/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webrtc-quic/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webrtc-quic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webrtc-quic/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webrtc-quic/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webrtc-quic/deployments","created_at":"2017-11-23T08:43:13Z","updated_at":"2018-12-12T20:55:34Z","pushed_at":"2018-12-12T23:00:23Z","git_url":"git://github.com/w3c/webrtc-quic.git","ssh_url":"git@github.com:w3c/webrtc-quic.git","clone_url":"https://github.com/w3c/webrtc-quic.git","svn_url":"https://github.com/w3c/webrtc-quic","homepage":"https://w3c.github.io/webrtc-quic/","size":606,"stargazers_count":24,"watchers_count":24,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":21,"watchers":24,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"958338e2a70161c7d361c53302850bc3905d1369","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":111784745,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3ODQ3NDU=","name":"webrtc-quic","full_name":"w3c/webrtc-quic","private":false,"owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/w3c/webrtc-quic","description":"Interface to create and manage QUIC streams","fork":false,"url":"https://api.github.com/repos/w3c/webrtc-quic","forks_url":"https://api.github.com/repos/w3c/webrtc-quic/forks","keys_url":"https://api.github.com/repos/w3c/webrtc-quic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webrtc-quic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webrtc-quic/teams","hooks_url":"https://api.github.com/repos/w3c/webrtc-quic/hooks","issue_events_url":"https://api.github.com/repos/w3c/webrtc-quic/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webrtc-quic/events","assignees_url":"https://api.github.com/repos/w3c/webrtc-quic/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webrtc-quic/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webrtc-quic/tags","blobs_url":"https://api.github.com/repos/w3c/webrtc-quic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webrtc-quic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webrtc-quic/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webrtc-quic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webrtc-quic/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webrtc-quic/languages","stargazers_url":"https://api.github.com/repos/w3c/webrtc-quic/stargazers","contributors_url":"https://api.github.com/repos/w3c/webrtc-quic/contributors","subscribers_url":"https://api.github.com/repos/w3c/webrtc-quic/subscribers","subscription_url":"https://api.github.com/repos/w3c/webrtc-quic/subscription","commits_url":"https://api.github.com/repos/w3c/webrtc-quic/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webrtc-quic/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webrtc-quic/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webrtc-quic/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webrtc-quic/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webrtc-quic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webrtc-quic/merges","archive_url":"https://api.github.com/repos/w3c/webrtc-quic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webrtc-quic/downloads","issues_url":"https://api.github.com/repos/w3c/webrtc-quic/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webrtc-quic/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webrtc-quic/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webrtc-quic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webrtc-quic/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webrtc-quic/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webrtc-quic/deployments","created_at":"2017-11-23T08:43:13Z","updated_at":"2018-12-12T20:55:34Z","pushed_at":"2018-12-12T23:00:23Z","git_url":"git://github.com/w3c/webrtc-quic.git","ssh_url":"git@github.com:w3c/webrtc-quic.git","clone_url":"https://github.com/w3c/webrtc-quic.git","svn_url":"https://github.com/w3c/webrtc-quic","homepage":"https://w3c.github.io/webrtc-quic/","size":606,"stargazers_count":24,"watchers_count":24,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":21,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-quic/pulls/89"},"html":{"href":"https://github.com/w3c/webrtc-quic/pull/89"},"issue":{"href":"https://api.github.com/repos/w3c/webrtc-quic/issues/89"},"comments":{"href":"https://api.github.com/repos/w3c/webrtc-quic/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webrtc-quic/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webrtc-quic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webrtc-quic/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webrtc-quic/statuses/02b20786b6ea97faea7ae231cf60f5897eaa8747"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"shampson"}}