{"action":"created","comment":{"url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/comments/212431192","pull_request_review_id":149064928,"id":212431192,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQzMTE5Mg==","diff_hunk":"@@ -0,0 +1,118 @@\n+from __future__ import print_function\n+import sys\n+\n+import webdriver\n+\n+from tests.support import defaults\n+\n+def ignore_exceptions(f):\n+    def inner(*args, **kwargs):\n+        try:\n+            return f(*args, **kwargs)\n+        except webdriver.error.WebDriverException as e:\n+            print(\"Ignored exception %s\" % e, file=sys.stderr)","path":"webdriver/tests/support/helpers.py","position":14,"original_position":13,"commit_id":"d9a191337f1239711165342bec6198452196cff9","original_commit_id":"ce5fbba5b63ce3386b0f5a866edde676d8963495","user":{"login":"burg","id":70680,"node_id":"MDQ6VXNlcjcwNjgw","avatar_url":"https://avatars0.githubusercontent.com/u/70680?v=4","gravatar_id":"","url":"https://api.github.com/users/burg","html_url":"https://github.com/burg","followers_url":"https://api.github.com/users/burg/followers","following_url":"https://api.github.com/users/burg/following{/other_user}","gists_url":"https://api.github.com/users/burg/gists{/gist_id}","starred_url":"https://api.github.com/users/burg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burg/subscriptions","organizations_url":"https://api.github.com/users/burg/orgs","repos_url":"https://api.github.com/users/burg/repos","events_url":"https://api.github.com/users/burg/events{/privacy}","received_events_url":"https://api.github.com/users/burg/received_events","type":"User","site_admin":false},"body":"This code is not new.","created_at":"2018-08-23T19:34:38Z","updated_at":"2018-08-23T19:34:38Z","html_url":"https://github.com/web-platform-tests/wpt/pull/12654#discussion_r212431192","pull_request_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12654","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/comments/212431192"},"html":{"href":"https://github.com/web-platform-tests/wpt/pull/12654#discussion_r212431192"},"pull_request":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12654"}},"in_reply_to_id":212417961},"pull_request":{"url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12654","id":210499369,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDk5MzY5","html_url":"https://github.com/web-platform-tests/wpt/pull/12654","diff_url":"https://github.com/web-platform-tests/wpt/pull/12654.diff","patch_url":"https://github.com/web-platform-tests/wpt/pull/12654.patch","issue_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12654","number":12654,"state":"open","locked":false,"title":"Convert webdriver pytest fixtures to use pytest.fixture as a decorator.","user":{"login":"burg","id":70680,"node_id":"MDQ6VXNlcjcwNjgw","avatar_url":"https://avatars0.githubusercontent.com/u/70680?v=4","gravatar_id":"","url":"https://api.github.com/users/burg","html_url":"https://github.com/burg","followers_url":"https://api.github.com/users/burg/followers","following_url":"https://api.github.com/users/burg/following{/other_user}","gists_url":"https://api.github.com/users/burg/gists{/gist_id}","starred_url":"https://api.github.com/users/burg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burg/subscriptions","organizations_url":"https://api.github.com/users/burg/orgs","repos_url":"https://api.github.com/users/burg/repos","events_url":"https://api.github.com/users/burg/events{/privacy}","received_events_url":"https://api.github.com/users/burg/received_events","type":"User","site_admin":false},"body":"Starting in pytest 3.7.0, calling the decorator pytest.fixture directly\r\nand passing a function object does not work. Since this is a weird way to\r\nset up fixtures, just migrate fixture implementations from fixtures.py\r\nto the top-level conftest.py and use a decorator to register each fixture.\r\n\r\nMove non-fixture helpers to tests/support/helpers.py. Move constant values\r\nused as defaults to tests/support/defaults.py and adjust imports and uses.\r\nSome default values are used both by fixtures in conftest.py and by helpers\r\nin helpers.py.","created_at":"2018-08-23T16:04:49Z","updated_at":"2018-08-23T19:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c07ff4004c5629d4a27960b04a8806495b5b69e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shs96c","id":28229,"node_id":"MDQ6VXNlcjI4MjI5","avatar_url":"https://avatars2.githubusercontent.com/u/28229?v=4","gravatar_id":"","url":"https://api.github.com/users/shs96c","html_url":"https://github.com/shs96c","followers_url":"https://api.github.com/users/shs96c/followers","following_url":"https://api.github.com/users/shs96c/following{/other_user}","gists_url":"https://api.github.com/users/shs96c/gists{/gist_id}","starred_url":"https://api.github.com/users/shs96c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shs96c/subscriptions","organizations_url":"https://api.github.com/users/shs96c/orgs","repos_url":"https://api.github.com/users/shs96c/repos","events_url":"https://api.github.com/users/shs96c/events{/privacy}","received_events_url":"https://api.github.com/users/shs96c/received_events","type":"User","site_admin":false},{"login":"AutomatedTester","id":128518,"node_id":"MDQ6VXNlcjEyODUxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/128518?v=4","gravatar_id":"","url":"https://api.github.com/users/AutomatedTester","html_url":"https://github.com/AutomatedTester","followers_url":"https://api.github.com/users/AutomatedTester/followers","following_url":"https://api.github.com/users/AutomatedTester/following{/other_user}","gists_url":"https://api.github.com/users/AutomatedTester/gists{/gist_id}","starred_url":"https://api.github.com/users/AutomatedTester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutomatedTester/subscriptions","organizations_url":"https://api.github.com/users/AutomatedTester/orgs","repos_url":"https://api.github.com/users/AutomatedTester/repos","events_url":"https://api.github.com/users/AutomatedTester/events{/privacy}","received_events_url":"https://api.github.com/users/AutomatedTester/received_events","type":"User","site_admin":false},{"login":"andreastt","id":399120,"node_id":"MDQ6VXNlcjM5OTEyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/399120?v=4","gravatar_id":"","url":"https://api.github.com/users/andreastt","html_url":"https://github.com/andreastt","followers_url":"https://api.github.com/users/andreastt/followers","following_url":"https://api.github.com/users/andreastt/following{/other_user}","gists_url":"https://api.github.com/users/andreastt/gists{/gist_id}","starred_url":"https://api.github.com/users/andreastt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreastt/subscriptions","organizations_url":"https://api.github.com/users/andreastt/orgs","repos_url":"https://api.github.com/users/andreastt/repos","events_url":"https://api.github.com/users/andreastt/events{/privacy}","received_events_url":"https://api.github.com/users/andreastt/received_events","type":"User","site_admin":false},{"login":"mjzffr","id":6024326,"node_id":"MDQ6VXNlcjYwMjQzMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/6024326?v=4","gravatar_id":"","url":"https://api.github.com/users/mjzffr","html_url":"https://github.com/mjzffr","followers_url":"https://api.github.com/users/mjzffr/followers","following_url":"https://api.github.com/users/mjzffr/following{/other_user}","gists_url":"https://api.github.com/users/mjzffr/gists{/gist_id}","starred_url":"https://api.github.com/users/mjzffr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjzffr/subscriptions","organizations_url":"https://api.github.com/users/mjzffr/orgs","repos_url":"https://api.github.com/users/mjzffr/repos","events_url":"https://api.github.com/users/mjzffr/events{/privacy}","received_events_url":"https://api.github.com/users/mjzffr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":45231233,"node_id":"MDU6TGFiZWw0NTIzMTIzMw==","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/webdriver","name":"webdriver","color":"ededed","default":false},{"id":80346691,"node_id":"MDU6TGFiZWw4MDM0NjY5MQ==","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/wg-testing_browser","name":"wg-testing_browser","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12654/commits","review_comments_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12654/comments","review_comment_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12654/comments","statuses_url":"https://api.github.com/repos/web-platform-tests/wpt/statuses/d9a191337f1239711165342bec6198452196cff9","head":{"label":"burg:bburg/pytest-fixture-decorators","ref":"bburg/pytest-fixture-decorators","sha":"d9a191337f1239711165342bec6198452196cff9","user":{"login":"burg","id":70680,"node_id":"MDQ6VXNlcjcwNjgw","avatar_url":"https://avatars0.githubusercontent.com/u/70680?v=4","gravatar_id":"","url":"https://api.github.com/users/burg","html_url":"https://github.com/burg","followers_url":"https://api.github.com/users/burg/followers","following_url":"https://api.github.com/users/burg/following{/other_user}","gists_url":"https://api.github.com/users/burg/gists{/gist_id}","starred_url":"https://api.github.com/users/burg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burg/subscriptions","organizations_url":"https://api.github.com/users/burg/orgs","repos_url":"https://api.github.com/users/burg/repos","events_url":"https://api.github.com/users/burg/events{/privacy}","received_events_url":"https://api.github.com/users/burg/received_events","type":"User","site_admin":false},"repo":{"id":117902998,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MDI5OTg=","name":"web-platform-tests","full_name":"burg/web-platform-tests","owner":{"login":"burg","id":70680,"node_id":"MDQ6VXNlcjcwNjgw","avatar_url":"https://avatars0.githubusercontent.com/u/70680?v=4","gravatar_id":"","url":"https://api.github.com/users/burg","html_url":"https://github.com/burg","followers_url":"https://api.github.com/users/burg/followers","following_url":"https://api.github.com/users/burg/following{/other_user}","gists_url":"https://api.github.com/users/burg/gists{/gist_id}","starred_url":"https://api.github.com/users/burg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burg/subscriptions","organizations_url":"https://api.github.com/users/burg/orgs","repos_url":"https://api.github.com/users/burg/repos","events_url":"https://api.github.com/users/burg/events{/privacy}","received_events_url":"https://api.github.com/users/burg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burg/web-platform-tests","description":"Test suites for Web-platform specs — including WHATWG, W3C, and others","fork":true,"url":"https://api.github.com/repos/burg/web-platform-tests","forks_url":"https://api.github.com/repos/burg/web-platform-tests/forks","keys_url":"https://api.github.com/repos/burg/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burg/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burg/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/burg/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/burg/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/burg/web-platform-tests/events","assignees_url":"https://api.github.com/repos/burg/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/burg/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/burg/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/burg/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burg/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burg/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/burg/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burg/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/burg/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/burg/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/burg/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/burg/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/burg/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/burg/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/burg/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/burg/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/burg/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/burg/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/burg/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burg/web-platform-tests/merges","archive_url":"https://api.github.com/repos/burg/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burg/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/burg/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/burg/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/burg/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/burg/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burg/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/burg/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/burg/web-platform-tests/deployments","created_at":"2018-01-17T22:58:55Z","updated_at":"2018-08-23T19:33:25Z","pushed_at":"2018-08-23T19:32:06Z","git_url":"git://github.com/burg/web-platform-tests.git","ssh_url":"git@github.com:burg/web-platform-tests.git","clone_url":"https://github.com/burg/web-platform-tests.git","svn_url":"https://github.com/burg/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":284280,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"web-platform-tests:master","ref":"master","sha":"e570d8f2040c24dd9ba77f1c7887a282a04eb529","user":{"login":"web-platform-tests","id":37226233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/37226233?v=4","gravatar_id":"","url":"https://api.github.com/users/web-platform-tests","html_url":"https://github.com/web-platform-tests","followers_url":"https://api.github.com/users/web-platform-tests/followers","following_url":"https://api.github.com/users/web-platform-tests/following{/other_user}","gists_url":"https://api.github.com/users/web-platform-tests/gists{/gist_id}","starred_url":"https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-platform-tests/subscriptions","organizations_url":"https://api.github.com/users/web-platform-tests/orgs","repos_url":"https://api.github.com/users/web-platform-tests/repos","events_url":"https://api.github.com/users/web-platform-tests/events{/privacy}","received_events_url":"https://api.github.com/users/web-platform-tests/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"node_id":"MDEwOlJlcG9zaXRvcnkzNjE4MTMz","name":"wpt","full_name":"web-platform-tests/wpt","owner":{"login":"web-platform-tests","id":37226233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/37226233?v=4","gravatar_id":"","url":"https://api.github.com/users/web-platform-tests","html_url":"https://github.com/web-platform-tests","followers_url":"https://api.github.com/users/web-platform-tests/followers","following_url":"https://api.github.com/users/web-platform-tests/following{/other_user}","gists_url":"https://api.github.com/users/web-platform-tests/gists{/gist_id}","starred_url":"https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-platform-tests/subscriptions","organizations_url":"https://api.github.com/users/web-platform-tests/orgs","repos_url":"https://api.github.com/users/web-platform-tests/repos","events_url":"https://api.github.com/users/web-platform-tests/events{/privacy}","received_events_url":"https://api.github.com/users/web-platform-tests/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/web-platform-tests/wpt","description":"Test suites for Web platform specs — including WHATWG, W3C, and others","fork":false,"url":"https://api.github.com/repos/web-platform-tests/wpt","forks_url":"https://api.github.com/repos/web-platform-tests/wpt/forks","keys_url":"https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/web-platform-tests/wpt/teams","hooks_url":"https://api.github.com/repos/web-platform-tests/wpt/hooks","issue_events_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}","events_url":"https://api.github.com/repos/web-platform-tests/wpt/events","assignees_url":"https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}","branches_url":"https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}","tags_url":"https://api.github.com/repos/web-platform-tests/wpt/tags","blobs_url":"https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}","trees_url":"https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}","languages_url":"https://api.github.com/repos/web-platform-tests/wpt/languages","stargazers_url":"https://api.github.com/repos/web-platform-tests/wpt/stargazers","contributors_url":"https://api.github.com/repos/web-platform-tests/wpt/contributors","subscribers_url":"https://api.github.com/repos/web-platform-tests/wpt/subscribers","subscription_url":"https://api.github.com/repos/web-platform-tests/wpt/subscription","commits_url":"https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}","git_commits_url":"https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}","comments_url":"https://api.github.com/repos/web-platform-tests/wpt/comments{/number}","issue_comment_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}","contents_url":"https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}","compare_url":"https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/web-platform-tests/wpt/merges","archive_url":"https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/web-platform-tests/wpt/downloads","issues_url":"https://api.github.com/repos/web-platform-tests/wpt/issues{/number}","pulls_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}","milestones_url":"https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}","notifications_url":"https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/web-platform-tests/wpt/labels{/name}","releases_url":"https://api.github.com/repos/web-platform-tests/wpt/releases{/id}","deployments_url":"https://api.github.com/repos/web-platform-tests/wpt/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2018-08-23T18:29:16Z","pushed_at":"2018-08-23T19:32:53Z","git_url":"git://github.com/web-platform-tests/wpt.git","ssh_url":"git@github.com:web-platform-tests/wpt.git","clone_url":"https://github.com/web-platform-tests/wpt.git","svn_url":"https://github.com/web-platform-tests/wpt","homepage":"http://irc.w3.org/?channels=testing","size":302259,"stargazers_count":1750,"watchers_count":1750,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1475,"mirror_url":null,"archived":false,"open_issues_count":1252,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1475,"open_issues":1252,"watchers":1750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12654"},"html":{"href":"https://github.com/web-platform-tests/wpt/pull/12654"},"issue":{"href":"https://api.github.com/repos/web-platform-tests/wpt/issues/12654"},"comments":{"href":"https://api.github.com/repos/web-platform-tests/wpt/issues/12654/comments"},"review_comments":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12654/comments"},"review_comment":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12654/commits"},"statuses":{"href":"https://api.github.com/repos/web-platform-tests/wpt/statuses/d9a191337f1239711165342bec6198452196cff9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"burg"}}