{"action":"created","comment":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/180479863","pull_request_review_id":110907265,"id":180479863,"diff_hunk":"@@ -0,0 +1,192 @@\n+#include \"cartographer/mapping/internal/2d/overlapping_submaps_trimmer.h\"\n+\n+#include <algorithm>\n+\n+#include \"cartographer/mapping/2d/submap_2d.h\"\n+\n+namespace cartographer {\n+namespace mapping {\n+namespace {\n+\n+class GlobalGrid {\n+ public:\n+  // Aliases for documentation only (no type-safety).\n+  using CellId = std::pair<int64 /* x cells */, int64 /* y cells */>;\n+  using StoredType = std::vector<std::pair<SubmapId, common::Time>>;\n+\n+  explicit GlobalGrid(const Eigen::Vector2d& offset) : offset_(offset) {}\n+\n+  // Adds data to the StoredType in a cell that corresponds to the given point.","path":"cartographer/mapping/internal/2d/overlapping_submaps_trimmer.cc","position":19,"original_position":19,"commit_id":"a985d6bb6c1b6317c6531d172c623b4dfe0354e1","original_commit_id":"a985d6bb6c1b6317c6531d172c623b4dfe0354e1","user":{"login":"pifon2a","id":32522095,"avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-04-10T16:10:46Z","updated_at":"2018-04-10T16:10:47Z","html_url":"https://github.com/googlecartographer/cartographer/pull/1027#discussion_r180479863","pull_request_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1027","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/180479863"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/1027#discussion_r180479863"},"pull_request":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1027"}},"in_reply_to_id":180439869},"pull_request":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1027","id":178602113,"html_url":"https://github.com/googlecartographer/cartographer/pull/1027","diff_url":"https://github.com/googlecartographer/cartographer/pull/1027.diff","patch_url":"https://github.com/googlecartographer/cartographer/pull/1027.patch","issue_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/1027","number":1027,"state":"open","locked":false,"title":"WIP: Add overlapping submaps trimmer.","user":{"login":"pifon2a","id":32522095,"avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-30T17:37:24Z","updated_at":"2018-04-10T16:10:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6faccd67b52c361c27b1f808d97b3b0ecf01e824","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":418020229,"url":"https://api.github.com/repos/googlecartographer/cartographer/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1027/commits","review_comments_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1027/comments","review_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/1027/comments","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/a985d6bb6c1b6317c6531d172c623b4dfe0354e1","head":{"label":"pifon2a:trimmer","ref":"trimmer","sha":"a985d6bb6c1b6317c6531d172c623b4dfe0354e1","user":{"login":"pifon2a","id":32522095,"avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"repo":{"id":108394000,"name":"cartographer","full_name":"pifon2a/cartographer","owner":{"login":"pifon2a","id":32522095,"avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pifon2a/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":true,"url":"https://api.github.com/repos/pifon2a/cartographer","forks_url":"https://api.github.com/repos/pifon2a/cartographer/forks","keys_url":"https://api.github.com/repos/pifon2a/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pifon2a/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pifon2a/cartographer/teams","hooks_url":"https://api.github.com/repos/pifon2a/cartographer/hooks","issue_events_url":"https://api.github.com/repos/pifon2a/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/pifon2a/cartographer/events","assignees_url":"https://api.github.com/repos/pifon2a/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/pifon2a/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/pifon2a/cartographer/tags","blobs_url":"https://api.github.com/repos/pifon2a/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pifon2a/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pifon2a/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/pifon2a/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pifon2a/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/pifon2a/cartographer/languages","stargazers_url":"https://api.github.com/repos/pifon2a/cartographer/stargazers","contributors_url":"https://api.github.com/repos/pifon2a/cartographer/contributors","subscribers_url":"https://api.github.com/repos/pifon2a/cartographer/subscribers","subscription_url":"https://api.github.com/repos/pifon2a/cartographer/subscription","commits_url":"https://api.github.com/repos/pifon2a/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/pifon2a/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/pifon2a/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/pifon2a/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/pifon2a/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/pifon2a/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pifon2a/cartographer/merges","archive_url":"https://api.github.com/repos/pifon2a/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pifon2a/cartographer/downloads","issues_url":"https://api.github.com/repos/pifon2a/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/pifon2a/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/pifon2a/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/pifon2a/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pifon2a/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/pifon2a/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/pifon2a/cartographer/deployments","created_at":"2017-10-26T09:59:05Z","updated_at":"2018-03-26T10:09:31Z","pushed_at":"2018-04-10T14:40:47Z","git_url":"git://github.com/pifon2a/cartographer.git","ssh_url":"git@github.com:pifon2a/cartographer.git","clone_url":"https://github.com/pifon2a/cartographer.git","svn_url":"https://github.com/pifon2a/cartographer","homepage":"","size":4234,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlecartographer:master","ref":"master","sha":"895f1d61b485c52bc41a5fb62fac541e8e2aaf7c","user":{"login":"googlecartographer","id":20636162,"avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":64732358,"name":"cartographer","full_name":"googlecartographer/cartographer","owner":{"login":"googlecartographer","id":20636162,"avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlecartographer/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":false,"url":"https://api.github.com/repos/googlecartographer/cartographer","forks_url":"https://api.github.com/repos/googlecartographer/cartographer/forks","keys_url":"https://api.github.com/repos/googlecartographer/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/cartographer/teams","hooks_url":"https://api.github.com/repos/googlecartographer/cartographer/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/cartographer/events","assignees_url":"https://api.github.com/repos/googlecartographer/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/cartographer/tags","blobs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/cartographer/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/cartographer/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/cartographer/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/cartographer/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/cartographer/subscription","commits_url":"https://api.github.com/repos/googlecartographer/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/cartographer/merges","archive_url":"https://api.github.com/repos/googlecartographer/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/cartographer/downloads","issues_url":"https://api.github.com/repos/googlecartographer/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/cartographer/deployments","created_at":"2016-08-02T06:55:43Z","updated_at":"2018-04-10T16:05:06Z","pushed_at":"2018-04-10T16:05:04Z","git_url":"git://github.com/googlecartographer/cartographer.git","ssh_url":"git@github.com:googlecartographer/cartographer.git","clone_url":"https://github.com/googlecartographer/cartographer.git","svn_url":"https://github.com/googlecartographer/cartographer","homepage":"","size":4163,"stargazers_count":3296,"watchers_count":3296,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1045,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1045,"open_issues":31,"watchers":3296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1027"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/1027"},"issue":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/1027"},"comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/1027/comments"},"review_comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1027/comments"},"review_comment":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1027/commits"},"statuses":{"href":"https://api.github.com/repos/googlecartographer/cartographer/statuses/a985d6bb6c1b6317c6531d172c623b4dfe0354e1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pifon2a"}}