{"action":"created","comment":{"url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/comments/187938681","pull_request_review_id":119815970,"id":187938681,"diff_hunk":"@@ -169,7 +169,7 @@ def as_json(self,\n             # they are NOT model fields or properties!\n             'distance': self.distance,\n         }\n-        if rome_codes is not None and len(rome_codes) > 1:  # only makes sense for multi rome searches\n+        if rome_codes is not None:","path":"labonneboite/common/models/office.py","position":5,"original_position":5,"commit_id":"02ac6c5240f98d568eeb92434f1db92278de7084","original_commit_id":"02ac6c5240f98d568eeb92434f1db92278de7084","user":{"login":"regisb","id":44319,"avatar_url":"https://avatars1.githubusercontent.com/u/44319?v=4","gravatar_id":"","url":"https://api.github.com/users/regisb","html_url":"https://github.com/regisb","followers_url":"https://api.github.com/users/regisb/followers","following_url":"https://api.github.com/users/regisb/following{/other_user}","gists_url":"https://api.github.com/users/regisb/gists{/gist_id}","starred_url":"https://api.github.com/users/regisb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regisb/subscriptions","organizations_url":"https://api.github.com/users/regisb/orgs","repos_url":"https://api.github.com/users/regisb/repos","events_url":"https://api.github.com/users/regisb/events{/privacy}","received_events_url":"https://api.github.com/users/regisb/received_events","type":"User","site_admin":false},"body":"Du coup, je ne comprends pas la condition : est-ce qu'il ne faudrait pas écrire plutôt `if rome_code` ?","created_at":"2018-05-14T12:43:53Z","updated_at":"2018-05-14T12:43:53Z","html_url":"https://github.com/StartupsPoleEmploi/labonneboite/pull/175#discussion_r187938681","pull_request_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/175","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/comments/187938681"},"html":{"href":"https://github.com/StartupsPoleEmploi/labonneboite/pull/175#discussion_r187938681"},"pull_request":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/175","id":187476496,"html_url":"https://github.com/StartupsPoleEmploi/labonneboite/pull/175","diff_url":"https://github.com/StartupsPoleEmploi/labonneboite/pull/175.diff","patch_url":"https://github.com/StartupsPoleEmploi/labonneboite/pull/175.patch","issue_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues/175","number":175,"state":"open","locked":false,"title":"vgrange/hotfix_matched_rome_even_if_single_rome","user":{"login":"vgrange","id":10533583,"avatar_url":"https://avatars3.githubusercontent.com/u/10533583?v=4","gravatar_id":"","url":"https://api.github.com/users/vgrange","html_url":"https://github.com/vgrange","followers_url":"https://api.github.com/users/vgrange/followers","following_url":"https://api.github.com/users/vgrange/following{/other_user}","gists_url":"https://api.github.com/users/vgrange/gists{/gist_id}","starred_url":"https://api.github.com/users/vgrange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgrange/subscriptions","organizations_url":"https://api.github.com/users/vgrange/orgs","repos_url":"https://api.github.com/users/vgrange/repos","events_url":"https://api.github.com/users/vgrange/events{/privacy}","received_events_url":"https://api.github.com/users/vgrange/received_events","type":"User","site_admin":false},"body":"actuellement en production pour sauver LBA\r\n\r\n`make deploy-code-without-migrations-to-production BRANCH=vgrange/hotfix_matched_rome_even_if_single_rome`\r\n\r\nà discuter lundi: c'est un besoin légitime, pour un user de l'API multi rome qui compte sur les champs `matched_rome` que ces champs continuent d'exister dans le cas d'un single rome... sinon c'est confusant et l'oblige à rajouter une logique dans le cas du single rome\r\n\r\nj'ai pas de solution élégante du coup on en reparle lundi @regisb ","created_at":"2018-05-11T14:15:12Z","updated_at":"2018-05-14T12:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de43a62e49fa8bf949344ee9257134fa087ddb55","assignee":{"login":"regisb","id":44319,"avatar_url":"https://avatars1.githubusercontent.com/u/44319?v=4","gravatar_id":"","url":"https://api.github.com/users/regisb","html_url":"https://github.com/regisb","followers_url":"https://api.github.com/users/regisb/followers","following_url":"https://api.github.com/users/regisb/following{/other_user}","gists_url":"https://api.github.com/users/regisb/gists{/gist_id}","starred_url":"https://api.github.com/users/regisb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regisb/subscriptions","organizations_url":"https://api.github.com/users/regisb/orgs","repos_url":"https://api.github.com/users/regisb/repos","events_url":"https://api.github.com/users/regisb/events{/privacy}","received_events_url":"https://api.github.com/users/regisb/received_events","type":"User","site_admin":false},"assignees":[{"login":"regisb","id":44319,"avatar_url":"https://avatars1.githubusercontent.com/u/44319?v=4","gravatar_id":"","url":"https://api.github.com/users/regisb","html_url":"https://github.com/regisb","followers_url":"https://api.github.com/users/regisb/followers","following_url":"https://api.github.com/users/regisb/following{/other_user}","gists_url":"https://api.github.com/users/regisb/gists{/gist_id}","starred_url":"https://api.github.com/users/regisb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regisb/subscriptions","organizations_url":"https://api.github.com/users/regisb/orgs","repos_url":"https://api.github.com/users/regisb/repos","events_url":"https://api.github.com/users/regisb/events{/privacy}","received_events_url":"https://api.github.com/users/regisb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/175/commits","review_comments_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/175/comments","review_comment_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues/175/comments","statuses_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/statuses/02ac6c5240f98d568eeb92434f1db92278de7084","head":{"label":"StartupsPoleEmploi:vgrange/hotfix_matched_rome_even_if_single_rome","ref":"vgrange/hotfix_matched_rome_even_if_single_rome","sha":"02ac6c5240f98d568eeb92434f1db92278de7084","user":{"login":"StartupsPoleEmploi","id":24388500,"avatar_url":"https://avatars0.githubusercontent.com/u/24388500?v=4","gravatar_id":"","url":"https://api.github.com/users/StartupsPoleEmploi","html_url":"https://github.com/StartupsPoleEmploi","followers_url":"https://api.github.com/users/StartupsPoleEmploi/followers","following_url":"https://api.github.com/users/StartupsPoleEmploi/following{/other_user}","gists_url":"https://api.github.com/users/StartupsPoleEmploi/gists{/gist_id}","starred_url":"https://api.github.com/users/StartupsPoleEmploi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StartupsPoleEmploi/subscriptions","organizations_url":"https://api.github.com/users/StartupsPoleEmploi/orgs","repos_url":"https://api.github.com/users/StartupsPoleEmploi/repos","events_url":"https://api.github.com/users/StartupsPoleEmploi/events{/privacy}","received_events_url":"https://api.github.com/users/StartupsPoleEmploi/received_events","type":"Organization","site_admin":false},"repo":{"id":101279781,"name":"labonneboite","full_name":"StartupsPoleEmploi/labonneboite","owner":{"login":"StartupsPoleEmploi","id":24388500,"avatar_url":"https://avatars0.githubusercontent.com/u/24388500?v=4","gravatar_id":"","url":"https://api.github.com/users/StartupsPoleEmploi","html_url":"https://github.com/StartupsPoleEmploi","followers_url":"https://api.github.com/users/StartupsPoleEmploi/followers","following_url":"https://api.github.com/users/StartupsPoleEmploi/following{/other_user}","gists_url":"https://api.github.com/users/StartupsPoleEmploi/gists{/gist_id}","starred_url":"https://api.github.com/users/StartupsPoleEmploi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StartupsPoleEmploi/subscriptions","organizations_url":"https://api.github.com/users/StartupsPoleEmploi/orgs","repos_url":"https://api.github.com/users/StartupsPoleEmploi/repos","events_url":"https://api.github.com/users/StartupsPoleEmploi/events{/privacy}","received_events_url":"https://api.github.com/users/StartupsPoleEmploi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StartupsPoleEmploi/labonneboite","description":"La Bonne Boite - https://labonneboite.pole-emploi.fr/","fork":false,"url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite","forks_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/forks","keys_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/teams","hooks_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/hooks","issue_events_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues/events{/number}","events_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/events","assignees_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/assignees{/user}","branches_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/branches{/branch}","tags_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/tags","blobs_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/refs{/sha}","trees_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/statuses/{sha}","languages_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/languages","stargazers_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/stargazers","contributors_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/contributors","subscribers_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/subscribers","subscription_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/subscription","commits_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/commits{/sha}","git_commits_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/commits{/sha}","comments_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/comments{/number}","issue_comment_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues/comments{/number}","contents_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/contents/{+path}","compare_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/merges","archive_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/downloads","issues_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues{/number}","pulls_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls{/number}","milestones_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/milestones{/number}","notifications_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/labels{/name}","releases_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/releases{/id}","deployments_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/deployments","created_at":"2017-08-24T09:49:19Z","updated_at":"2018-05-14T12:41:53Z","pushed_at":"2018-05-14T12:41:54Z","git_url":"git://github.com/StartupsPoleEmploi/labonneboite.git","ssh_url":"git@github.com:StartupsPoleEmploi/labonneboite.git","clone_url":"https://github.com/StartupsPoleEmploi/labonneboite.git","svn_url":"https://github.com/StartupsPoleEmploi/labonneboite","homepage":null,"size":31322,"stargazers_count":19,"watchers_count":19,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":2,"open_issues":10,"watchers":19,"default_branch":"master"}},"base":{"label":"StartupsPoleEmploi:master","ref":"master","sha":"97c5efe72d597c960322a7bd01d9e7a388587f27","user":{"login":"StartupsPoleEmploi","id":24388500,"avatar_url":"https://avatars0.githubusercontent.com/u/24388500?v=4","gravatar_id":"","url":"https://api.github.com/users/StartupsPoleEmploi","html_url":"https://github.com/StartupsPoleEmploi","followers_url":"https://api.github.com/users/StartupsPoleEmploi/followers","following_url":"https://api.github.com/users/StartupsPoleEmploi/following{/other_user}","gists_url":"https://api.github.com/users/StartupsPoleEmploi/gists{/gist_id}","starred_url":"https://api.github.com/users/StartupsPoleEmploi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StartupsPoleEmploi/subscriptions","organizations_url":"https://api.github.com/users/StartupsPoleEmploi/orgs","repos_url":"https://api.github.com/users/StartupsPoleEmploi/repos","events_url":"https://api.github.com/users/StartupsPoleEmploi/events{/privacy}","received_events_url":"https://api.github.com/users/StartupsPoleEmploi/received_events","type":"Organization","site_admin":false},"repo":{"id":101279781,"name":"labonneboite","full_name":"StartupsPoleEmploi/labonneboite","owner":{"login":"StartupsPoleEmploi","id":24388500,"avatar_url":"https://avatars0.githubusercontent.com/u/24388500?v=4","gravatar_id":"","url":"https://api.github.com/users/StartupsPoleEmploi","html_url":"https://github.com/StartupsPoleEmploi","followers_url":"https://api.github.com/users/StartupsPoleEmploi/followers","following_url":"https://api.github.com/users/StartupsPoleEmploi/following{/other_user}","gists_url":"https://api.github.com/users/StartupsPoleEmploi/gists{/gist_id}","starred_url":"https://api.github.com/users/StartupsPoleEmploi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StartupsPoleEmploi/subscriptions","organizations_url":"https://api.github.com/users/StartupsPoleEmploi/orgs","repos_url":"https://api.github.com/users/StartupsPoleEmploi/repos","events_url":"https://api.github.com/users/StartupsPoleEmploi/events{/privacy}","received_events_url":"https://api.github.com/users/StartupsPoleEmploi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StartupsPoleEmploi/labonneboite","description":"La Bonne Boite - https://labonneboite.pole-emploi.fr/","fork":false,"url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite","forks_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/forks","keys_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/teams","hooks_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/hooks","issue_events_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues/events{/number}","events_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/events","assignees_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/assignees{/user}","branches_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/branches{/branch}","tags_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/tags","blobs_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/refs{/sha}","trees_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/statuses/{sha}","languages_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/languages","stargazers_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/stargazers","contributors_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/contributors","subscribers_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/subscribers","subscription_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/subscription","commits_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/commits{/sha}","git_commits_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/git/commits{/sha}","comments_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/comments{/number}","issue_comment_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues/comments{/number}","contents_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/contents/{+path}","compare_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/merges","archive_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/downloads","issues_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues{/number}","pulls_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls{/number}","milestones_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/milestones{/number}","notifications_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/labels{/name}","releases_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/releases{/id}","deployments_url":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/deployments","created_at":"2017-08-24T09:49:19Z","updated_at":"2018-05-14T12:41:53Z","pushed_at":"2018-05-14T12:41:54Z","git_url":"git://github.com/StartupsPoleEmploi/labonneboite.git","ssh_url":"git@github.com:StartupsPoleEmploi/labonneboite.git","clone_url":"https://github.com/StartupsPoleEmploi/labonneboite.git","svn_url":"https://github.com/StartupsPoleEmploi/labonneboite","homepage":null,"size":31322,"stargazers_count":19,"watchers_count":19,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":2,"open_issues":10,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/175"},"html":{"href":"https://github.com/StartupsPoleEmploi/labonneboite/pull/175"},"issue":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues/175"},"comments":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/StartupsPoleEmploi/labonneboite/statuses/02ac6c5240f98d568eeb92434f1db92278de7084"}},"author_association":"OWNER"}}
{"actor":{"display_login":"regisb"}}