{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/234706253","pull_request_review_id":176405164,"id":234706253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDcwNjI1Mw==","diff_hunk":"@@ -40,53 +24,48 @@ private static bool Compat(AlignedArray a)\n             float* linearWeights, float* latentWeights, float* linearAccumulatedSquaredGrads, float* latentAccumulatedSquaredGrads);\n \n         public static void CalculateIntermediateVariables(int fieldCount, int latentDim, int count, int[] fieldIndices, int[] featureIndices, float[] featureValues,\n-            float[] linearWeights, AlignedArray latentWeights, AlignedArray latentSum, ref float response)\n+            float[] linearWeights, float[] latentWeights, float[] latentSum, ref float response)\n         {\n             Contracts.AssertNonEmpty(fieldIndices);\n             Contracts.AssertNonEmpty(featureValues);\n             Contracts.AssertNonEmpty(featureIndices);\n             Contracts.AssertNonEmpty(linearWeights);\n-            Contracts.Assert(Compat(latentWeights));\n-            Contracts.Assert(Compat(latentSum));\n \n             unsafe\n             {\n                 fixed (int* pf = &fieldIndices[0])\n                 fixed (int* pi = &featureIndices[0])\n                 fixed (float* px = &featureValues[0])\n                 fixed (float* pw = &linearWeights[0])\n-                fixed (float* pv = &latentWeights.Items[0])\n-                fixed (float* pq = &latentSum.Items[0])\n+                fixed (float* pv = &latentWeights[0])","path":"src/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs","position":45,"original_position":45,"commit_id":"0e16431ec07ac8f0f93073879a51d8ef97c35816","original_commit_id":"0e16431ec07ac8f0f93073879a51d8ef97c35816","user":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"You should still be asserting above that these arrays are non-empty.","created_at":"2018-11-19T17:13:02Z","updated_at":"2018-11-19T17:13:03Z","html_url":"https://github.com/dotnet/machinelearning/pull/1657#discussion_r234706253","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1657","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/234706253"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1657#discussion_r234706253"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1657"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1657","id":231676458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjc2NDU4","html_url":"https://github.com/dotnet/machinelearning/pull/1657","diff_url":"https://github.com/dotnet/machinelearning/pull/1657.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/1657.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1657","number":1657,"state":"open","locked":false,"title":"Removed AlignedArray ","user":{"login":"Anipik","id":10516582,"node_id":"MDQ6VXNlcjEwNTE2NTgy","avatar_url":"https://avatars1.githubusercontent.com/u/10516582?v=4","gravatar_id":"","url":"https://api.github.com/users/Anipik","html_url":"https://github.com/Anipik","followers_url":"https://api.github.com/users/Anipik/followers","following_url":"https://api.github.com/users/Anipik/following{/other_user}","gists_url":"https://api.github.com/users/Anipik/gists{/gist_id}","starred_url":"https://api.github.com/users/Anipik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anipik/subscriptions","organizations_url":"https://api.github.com/users/Anipik/orgs","repos_url":"https://api.github.com/users/Anipik/repos","events_url":"https://api.github.com/users/Anipik/events{/privacy}","received_events_url":"https://api.github.com/users/Anipik/received_events","type":"User","site_admin":false},"body":"- Removed Aligned Array\r\n- Matmul and MatmulTran modified for any dimension of row and col\r\n- added some more tests for new dimension changes\r\n- corrected the base implementation of MatMulTrans\r\n- added tolerance for some tests for netcoreapp3.0\r\n\r\n\r\nFixes https://github.com/dotnet/machinelearning/issues/1018\r\nRelated to https://github.com/dotnet/machinelearning/issues/1096\r\n","created_at":"2018-11-16T22:46:26Z","updated_at":"2018-11-19T17:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15b4401a9007d8b932dca6add3de529e78a6e795","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danmosemsft","id":6385855,"node_id":"MDQ6VXNlcjYzODU4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6385855?v=4","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},{"login":"yaeldekel","id":9617320,"node_id":"MDQ6VXNlcjk2MTczMjA=","avatar_url":"https://avatars1.githubusercontent.com/u/9617320?v=4","gravatar_id":"","url":"https://api.github.com/users/yaeldekel","html_url":"https://github.com/yaeldekel","followers_url":"https://api.github.com/users/yaeldekel/followers","following_url":"https://api.github.com/users/yaeldekel/following{/other_user}","gists_url":"https://api.github.com/users/yaeldekel/gists{/gist_id}","starred_url":"https://api.github.com/users/yaeldekel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaeldekel/subscriptions","organizations_url":"https://api.github.com/users/yaeldekel/orgs","repos_url":"https://api.github.com/users/yaeldekel/repos","events_url":"https://api.github.com/users/yaeldekel/events{/privacy}","received_events_url":"https://api.github.com/users/yaeldekel/received_events","type":"User","site_admin":false},{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1657/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1657/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1657/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/0e16431ec07ac8f0f93073879a51d8ef97c35816","head":{"label":"Anipik:temp2","ref":"temp2","sha":"0e16431ec07ac8f0f93073879a51d8ef97c35816","user":{"login":"Anipik","id":10516582,"node_id":"MDQ6VXNlcjEwNTE2NTgy","avatar_url":"https://avatars1.githubusercontent.com/u/10516582?v=4","gravatar_id":"","url":"https://api.github.com/users/Anipik","html_url":"https://github.com/Anipik","followers_url":"https://api.github.com/users/Anipik/followers","following_url":"https://api.github.com/users/Anipik/following{/other_user}","gists_url":"https://api.github.com/users/Anipik/gists{/gist_id}","starred_url":"https://api.github.com/users/Anipik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anipik/subscriptions","organizations_url":"https://api.github.com/users/Anipik/orgs","repos_url":"https://api.github.com/users/Anipik/repos","events_url":"https://api.github.com/users/Anipik/events{/privacy}","received_events_url":"https://api.github.com/users/Anipik/received_events","type":"User","site_admin":false},"repo":{"id":132616023,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2MTYwMjM=","name":"machinelearning","full_name":"Anipik/machinelearning","private":false,"owner":{"login":"Anipik","id":10516582,"node_id":"MDQ6VXNlcjEwNTE2NTgy","avatar_url":"https://avatars1.githubusercontent.com/u/10516582?v=4","gravatar_id":"","url":"https://api.github.com/users/Anipik","html_url":"https://github.com/Anipik","followers_url":"https://api.github.com/users/Anipik/followers","following_url":"https://api.github.com/users/Anipik/following{/other_user}","gists_url":"https://api.github.com/users/Anipik/gists{/gist_id}","starred_url":"https://api.github.com/users/Anipik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anipik/subscriptions","organizations_url":"https://api.github.com/users/Anipik/orgs","repos_url":"https://api.github.com/users/Anipik/repos","events_url":"https://api.github.com/users/Anipik/events{/privacy}","received_events_url":"https://api.github.com/users/Anipik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Anipik/machinelearning","description":"ML.NET is the core library of machine learning in .net.","fork":true,"url":"https://api.github.com/repos/Anipik/machinelearning","forks_url":"https://api.github.com/repos/Anipik/machinelearning/forks","keys_url":"https://api.github.com/repos/Anipik/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Anipik/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Anipik/machinelearning/teams","hooks_url":"https://api.github.com/repos/Anipik/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/Anipik/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/Anipik/machinelearning/events","assignees_url":"https://api.github.com/repos/Anipik/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/Anipik/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/Anipik/machinelearning/tags","blobs_url":"https://api.github.com/repos/Anipik/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Anipik/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Anipik/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/Anipik/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Anipik/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/Anipik/machinelearning/languages","stargazers_url":"https://api.github.com/repos/Anipik/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/Anipik/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/Anipik/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/Anipik/machinelearning/subscription","commits_url":"https://api.github.com/repos/Anipik/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/Anipik/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/Anipik/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/Anipik/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/Anipik/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/Anipik/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Anipik/machinelearning/merges","archive_url":"https://api.github.com/repos/Anipik/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Anipik/machinelearning/downloads","issues_url":"https://api.github.com/repos/Anipik/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/Anipik/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/Anipik/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/Anipik/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Anipik/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/Anipik/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/Anipik/machinelearning/deployments","created_at":"2018-05-08T13:51:12Z","updated_at":"2018-11-16T21:45:54Z","pushed_at":"2018-11-17T00:54:46Z","git_url":"git://github.com/Anipik/machinelearning.git","ssh_url":"git@github.com:Anipik/machinelearning.git","clone_url":"https://github.com/Anipik/machinelearning.git","svn_url":"https://github.com/Anipik/machinelearning","homepage":"","size":28903,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"31102c27ff705d533463a10229213dff90b0cac2","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-11-19T15:36:04Z","pushed_at":"2018-11-19T17:06:21Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":28818,"stargazers_count":4163,"watchers_count":4163,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":787,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":787,"open_issues":383,"watchers":4163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1657"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1657"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1657"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1657/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1657/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1657/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/0e16431ec07ac8f0f93073879a51d8ef97c35816"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eerhardt"}}