{"action":"created","comment":{"url":"https://api.github.com/repos/libMesh/libmesh/pulls/comments/183441229","pull_request_review_id":114440009,"id":183441229,"diff_hunk":"@@ -1730,18 +1731,21 @@ void ExodusII_IO_Helper::initialize_element_variables(std::vector<std::string> n\n \n   this->write_var_names(ELEMENTAL, names);\n \n-  // Form the element variable truth table and send to Exodus.\n-  // This tells which variables are written to which blocks,\n-  // and can dramatically speed up writing element variables\n-  //\n-  // We really should initialize all entries in the truth table to 0\n-  // and then loop over all subdomains, setting their entries to 1\n-  // if a given variable exists on that subdomain.  However,\n-  // we don't have that information, and the element variables\n-  // passed to us are padded with zeroes for the blocks where\n-  // they aren't defined.  To be consistent with that, fill\n-  // the truth table with ones.\n-  std::vector<int> truth_tab(num_elem_blk*num_elem_vars, 1);\n+  // Use the truth table to indicate which subdomain/variable pairs are\n+  // active according to vars_active_subdomains.\n+  std::vector<int> truth_tab(num_elem_blk*num_elem_vars, 0);\n+  for(unsigned int var_num=0; var_num<vars_active_subdomains.size(); var_num++)\n+    {\n+      for(auto block_id : vars_active_subdomains[var_num])\n+        {\n+          unsigned int block_index =\n+            std::distance(block_ids.begin(), std::find(block_ids.begin(), block_ids.end(), block_id));\n+\n+          unsigned int truth_tab_index = block_index*num_elem_vars + var_num;\n+          truth_tab[truth_tab_index] = 1;\n+        }\n+    }\n+","path":"src/mesh/exodusII_io_helper.C","position":40,"original_position":40,"commit_id":"a2e7ee6d869720437ad09d3dfd3fcc143a7cbcfc","original_commit_id":"a2e7ee6d869720437ad09d3dfd3fcc143a7cbcfc","user":{"login":"jwpeterson","id":1775907,"avatar_url":"https://avatars0.githubusercontent.com/u/1775907?v=4","gravatar_id":"","url":"https://api.github.com/users/jwpeterson","html_url":"https://github.com/jwpeterson","followers_url":"https://api.github.com/users/jwpeterson/followers","following_url":"https://api.github.com/users/jwpeterson/following{/other_user}","gists_url":"https://api.github.com/users/jwpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jwpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwpeterson/subscriptions","organizations_url":"https://api.github.com/users/jwpeterson/orgs","repos_url":"https://api.github.com/users/jwpeterson/repos","events_url":"https://api.github.com/users/jwpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jwpeterson/received_events","type":"User","site_admin":false},"body":"Both tests which are failing are attempting to read in Exodus files written out by other tests. Both tests have CONSTANT, MONOMIAL auxiliary variables in them, but they aren't subdomain restricted as far as I can tell. Also the first parts of each test still pass, so presumably the outputs from those are identical to before? ","created_at":"2018-04-23T15:39:08Z","updated_at":"2018-04-23T15:39:08Z","html_url":"https://github.com/libMesh/libmesh/pull/1669#discussion_r183441229","pull_request_url":"https://api.github.com/repos/libMesh/libmesh/pulls/1669","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/comments/183441229"},"html":{"href":"https://github.com/libMesh/libmesh/pull/1669#discussion_r183441229"},"pull_request":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/1669"}},"in_reply_to_id":183432435},"pull_request":{"url":"https://api.github.com/repos/libMesh/libmesh/pulls/1669","id":183203043,"html_url":"https://github.com/libMesh/libmesh/pull/1669","diff_url":"https://github.com/libMesh/libmesh/pull/1669.diff","patch_url":"https://github.com/libMesh/libmesh/pull/1669.patch","issue_url":"https://api.github.com/repos/libMesh/libmesh/issues/1669","number":1669,"state":"open","locked":false,"title":"Updated ExodusII_IO to skip element variable writing on blocks that are inactive","user":{"login":"dknez","id":3017801,"avatar_url":"https://avatars3.githubusercontent.com/u/3017801?v=4","gravatar_id":"","url":"https://api.github.com/users/dknez","html_url":"https://github.com/dknez","followers_url":"https://api.github.com/users/dknez/followers","following_url":"https://api.github.com/users/dknez/following{/other_user}","gists_url":"https://api.github.com/users/dknez/gists{/gist_id}","starred_url":"https://api.github.com/users/dknez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dknez/subscriptions","organizations_url":"https://api.github.com/users/dknez/orgs","repos_url":"https://api.github.com/users/dknez/repos","events_url":"https://api.github.com/users/dknez/events{/privacy}","received_events_url":"https://api.github.com/users/dknez/received_events","type":"User","site_admin":false},"body":"We use the \"truth table\" feature of the ExodusII API to skip writing element variables on inactive blocks.","created_at":"2018-04-21T03:19:26Z","updated_at":"2018-04-23T15:39:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94b943d1f803bf539cca4a3620b85f7b59c94b88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libMesh/libmesh/pulls/1669/commits","review_comments_url":"https://api.github.com/repos/libMesh/libmesh/pulls/1669/comments","review_comment_url":"https://api.github.com/repos/libMesh/libmesh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libMesh/libmesh/issues/1669/comments","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/a2e7ee6d869720437ad09d3dfd3fcc143a7cbcfc","head":{"label":"dknez:exodusII_inactive_blocks","ref":"exodusII_inactive_blocks","sha":"a2e7ee6d869720437ad09d3dfd3fcc143a7cbcfc","user":{"login":"dknez","id":3017801,"avatar_url":"https://avatars3.githubusercontent.com/u/3017801?v=4","gravatar_id":"","url":"https://api.github.com/users/dknez","html_url":"https://github.com/dknez","followers_url":"https://api.github.com/users/dknez/followers","following_url":"https://api.github.com/users/dknez/following{/other_user}","gists_url":"https://api.github.com/users/dknez/gists{/gist_id}","starred_url":"https://api.github.com/users/dknez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dknez/subscriptions","organizations_url":"https://api.github.com/users/dknez/orgs","repos_url":"https://api.github.com/users/dknez/repos","events_url":"https://api.github.com/users/dknez/events{/privacy}","received_events_url":"https://api.github.com/users/dknez/received_events","type":"User","site_admin":false},"repo":{"id":10469663,"name":"libmesh","full_name":"dknez/libmesh","owner":{"login":"dknez","id":3017801,"avatar_url":"https://avatars3.githubusercontent.com/u/3017801?v=4","gravatar_id":"","url":"https://api.github.com/users/dknez","html_url":"https://github.com/dknez","followers_url":"https://api.github.com/users/dknez/followers","following_url":"https://api.github.com/users/dknez/following{/other_user}","gists_url":"https://api.github.com/users/dknez/gists{/gist_id}","starred_url":"https://api.github.com/users/dknez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dknez/subscriptions","organizations_url":"https://api.github.com/users/dknez/orgs","repos_url":"https://api.github.com/users/dknez/repos","events_url":"https://api.github.com/users/dknez/events{/privacy}","received_events_url":"https://api.github.com/users/dknez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dknez/libmesh","description":"libMesh github repository","fork":true,"url":"https://api.github.com/repos/dknez/libmesh","forks_url":"https://api.github.com/repos/dknez/libmesh/forks","keys_url":"https://api.github.com/repos/dknez/libmesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dknez/libmesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dknez/libmesh/teams","hooks_url":"https://api.github.com/repos/dknez/libmesh/hooks","issue_events_url":"https://api.github.com/repos/dknez/libmesh/issues/events{/number}","events_url":"https://api.github.com/repos/dknez/libmesh/events","assignees_url":"https://api.github.com/repos/dknez/libmesh/assignees{/user}","branches_url":"https://api.github.com/repos/dknez/libmesh/branches{/branch}","tags_url":"https://api.github.com/repos/dknez/libmesh/tags","blobs_url":"https://api.github.com/repos/dknez/libmesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dknez/libmesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dknez/libmesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/dknez/libmesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dknez/libmesh/statuses/{sha}","languages_url":"https://api.github.com/repos/dknez/libmesh/languages","stargazers_url":"https://api.github.com/repos/dknez/libmesh/stargazers","contributors_url":"https://api.github.com/repos/dknez/libmesh/contributors","subscribers_url":"https://api.github.com/repos/dknez/libmesh/subscribers","subscription_url":"https://api.github.com/repos/dknez/libmesh/subscription","commits_url":"https://api.github.com/repos/dknez/libmesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/dknez/libmesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/dknez/libmesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/dknez/libmesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/dknez/libmesh/contents/{+path}","compare_url":"https://api.github.com/repos/dknez/libmesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dknez/libmesh/merges","archive_url":"https://api.github.com/repos/dknez/libmesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dknez/libmesh/downloads","issues_url":"https://api.github.com/repos/dknez/libmesh/issues{/number}","pulls_url":"https://api.github.com/repos/dknez/libmesh/pulls{/number}","milestones_url":"https://api.github.com/repos/dknez/libmesh/milestones{/number}","notifications_url":"https://api.github.com/repos/dknez/libmesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dknez/libmesh/labels{/name}","releases_url":"https://api.github.com/repos/dknez/libmesh/releases{/id}","deployments_url":"https://api.github.com/repos/dknez/libmesh/deployments","created_at":"2013-06-04T02:48:40Z","updated_at":"2014-12-11T02:14:09Z","pushed_at":"2018-04-23T01:39:47Z","git_url":"git://github.com/dknez/libmesh.git","ssh_url":"git@github.com:dknez/libmesh.git","clone_url":"https://github.com/dknez/libmesh.git","svn_url":"https://github.com/dknez/libmesh","homepage":"http://libmesh.sourceforge.net","size":115113,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libMesh:master","ref":"master","sha":"739c62489ebc75de803b73b4dc0b6f33b5101db3","user":{"login":"libMesh","id":2366757,"avatar_url":"https://avatars1.githubusercontent.com/u/2366757?v=4","gravatar_id":"","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"repo":{"id":5850234,"name":"libmesh","full_name":"libMesh/libmesh","owner":{"login":"libMesh","id":2366757,"avatar_url":"https://avatars1.githubusercontent.com/u/2366757?v=4","gravatar_id":"","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libMesh/libmesh","description":"libMesh github repository","fork":false,"url":"https://api.github.com/repos/libMesh/libmesh","forks_url":"https://api.github.com/repos/libMesh/libmesh/forks","keys_url":"https://api.github.com/repos/libMesh/libmesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libMesh/libmesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libMesh/libmesh/teams","hooks_url":"https://api.github.com/repos/libMesh/libmesh/hooks","issue_events_url":"https://api.github.com/repos/libMesh/libmesh/issues/events{/number}","events_url":"https://api.github.com/repos/libMesh/libmesh/events","assignees_url":"https://api.github.com/repos/libMesh/libmesh/assignees{/user}","branches_url":"https://api.github.com/repos/libMesh/libmesh/branches{/branch}","tags_url":"https://api.github.com/repos/libMesh/libmesh/tags","blobs_url":"https://api.github.com/repos/libMesh/libmesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libMesh/libmesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libMesh/libmesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/libMesh/libmesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/{sha}","languages_url":"https://api.github.com/repos/libMesh/libmesh/languages","stargazers_url":"https://api.github.com/repos/libMesh/libmesh/stargazers","contributors_url":"https://api.github.com/repos/libMesh/libmesh/contributors","subscribers_url":"https://api.github.com/repos/libMesh/libmesh/subscribers","subscription_url":"https://api.github.com/repos/libMesh/libmesh/subscription","commits_url":"https://api.github.com/repos/libMesh/libmesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/libMesh/libmesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/libMesh/libmesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/libMesh/libmesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/libMesh/libmesh/contents/{+path}","compare_url":"https://api.github.com/repos/libMesh/libmesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libMesh/libmesh/merges","archive_url":"https://api.github.com/repos/libMesh/libmesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libMesh/libmesh/downloads","issues_url":"https://api.github.com/repos/libMesh/libmesh/issues{/number}","pulls_url":"https://api.github.com/repos/libMesh/libmesh/pulls{/number}","milestones_url":"https://api.github.com/repos/libMesh/libmesh/milestones{/number}","notifications_url":"https://api.github.com/repos/libMesh/libmesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libMesh/libmesh/labels{/name}","releases_url":"https://api.github.com/repos/libMesh/libmesh/releases{/id}","deployments_url":"https://api.github.com/repos/libMesh/libmesh/deployments","created_at":"2012-09-18T02:12:18Z","updated_at":"2018-04-23T14:46:33Z","pushed_at":"2018-04-23T14:46:31Z","git_url":"git://github.com/libMesh/libmesh.git","ssh_url":"git@github.com:libMesh/libmesh.git","clone_url":"https://github.com/libMesh/libmesh.git","svn_url":"https://github.com/libMesh/libmesh","homepage":"http://libmesh.github.io","size":116834,"stargazers_count":217,"watchers_count":217,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":153,"open_issues":114,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/1669"},"html":{"href":"https://github.com/libMesh/libmesh/pull/1669"},"issue":{"href":"https://api.github.com/repos/libMesh/libmesh/issues/1669"},"comments":{"href":"https://api.github.com/repos/libMesh/libmesh/issues/1669/comments"},"review_comments":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/1669/comments"},"review_comment":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/1669/commits"},"statuses":{"href":"https://api.github.com/repos/libMesh/libmesh/statuses/a2e7ee6d869720437ad09d3dfd3fcc143a7cbcfc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jwpeterson"}}