{"action":"created","comment":{"url":"https://api.github.com/repos/libdfp/libdfp/pulls/comments/172513475","pull_request_review_id":101536172,"id":172513475,"diff_hunk":"@@ -65,15 +65,25 @@ CONVERT_WRAPPER(\n \t          return SIGNBIT(a) ? -INFINITY : INFINITY;\n \t      }\n \t  }\n-\telse if (exp < -BINPOWOF10_LIMIT)\t\t/* Obvious underflow.  */\n+\telse if (exp <= -BINPOWOF10_DENORM_DBL)\t\t/*Obvious underflow.  */\n \t  {\n \t    if (DFP_EXCEPTIONS_ENABLED)\n \t      DFP_HANDLE_EXCEPTIONS (FE_UNDERFLOW|FE_INEXACT);\n \n \t    switch (fegetround())\n \t      {\n \t        case FE_TONEAREST:\n-              return SIGNBIT(a) ? -__DBL_DENORM_MIN__ : __DBL_DENORM_MIN__;\n+\t          mant = llabs (a_norm);\n+\t          if (exp < -BINPOWOF10_DENORM_DBL ||\n+\t                    ((exp == -BINPOWOF10_DENORM_DBL) &&\n+\t                     (mant >= 24703282292062300)))\n+\t           {\n+\t              return SIGNBIT(a) ? -0.0 : 0.0;\n+\t           }\n+\t          else\n+\t           {\n+\t              return SIGNBIT(a) ? -__DBL_DENORM_MIN__ : __DBL_DENORM_MIN__;\n+\t           }","path":"base-math/trunctddf.c","position":33,"original_position":33,"commit_id":"75b60cf1537de9ee75487600ae98a78cd3e23052","original_commit_id":"75b60cf1537de9ee75487600ae98a78cd3e23052","user":{"login":"tuliom","id":85220,"avatar_url":"https://avatars0.githubusercontent.com/u/85220?v=4","gravatar_id":"","url":"https://api.github.com/users/tuliom","html_url":"https://github.com/tuliom","followers_url":"https://api.github.com/users/tuliom/followers","following_url":"https://api.github.com/users/tuliom/following{/other_user}","gists_url":"https://api.github.com/users/tuliom/gists{/gist_id}","starred_url":"https://api.github.com/users/tuliom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuliom/subscriptions","organizations_url":"https://api.github.com/users/tuliom/orgs","repos_url":"https://api.github.com/users/tuliom/repos","events_url":"https://api.github.com/users/tuliom/events{/privacy}","received_events_url":"https://api.github.com/users/tuliom/received_events","type":"User","site_admin":false},"body":"Both `if` and `else` don't need `{}`.  Be careful with long lines.","created_at":"2018-03-06T13:25:56Z","updated_at":"2018-03-06T13:48:19Z","html_url":"https://github.com/libdfp/libdfp/pull/65#discussion_r172513475","pull_request_url":"https://api.github.com/repos/libdfp/libdfp/pulls/65","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/comments/172513475"},"html":{"href":"https://github.com/libdfp/libdfp/pull/65#discussion_r172513475"},"pull_request":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/libdfp/libdfp/pulls/65","id":172246671,"html_url":"https://github.com/libdfp/libdfp/pull/65","diff_url":"https://github.com/libdfp/libdfp/pull/65.diff","patch_url":"https://github.com/libdfp/libdfp/pull/65.patch","issue_url":"https://api.github.com/repos/libdfp/libdfp/issues/65","number":65,"state":"open","locked":false,"title":"Fix subnormals","user":{"login":"racardoso","id":13421176,"avatar_url":"https://avatars0.githubusercontent.com/u/13421176?v=4","gravatar_id":"","url":"https://api.github.com/users/racardoso","html_url":"https://github.com/racardoso","followers_url":"https://api.github.com/users/racardoso/followers","following_url":"https://api.github.com/users/racardoso/following{/other_user}","gists_url":"https://api.github.com/users/racardoso/gists{/gist_id}","starred_url":"https://api.github.com/users/racardoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racardoso/subscriptions","organizations_url":"https://api.github.com/users/racardoso/orgs","repos_url":"https://api.github.com/users/racardoso/repos","events_url":"https://api.github.com/users/racardoso/events{/privacy}","received_events_url":"https://api.github.com/users/racardoso/received_events","type":"User","site_admin":false},"body":"This commit fixes a wrongly produced zero instead subnormal. The underflow\r\ncase was been check by the minumum normal exponent -308 for double and -39 for\r\nsingle when should checked by by the minimum subnormal exponent (-324 and -45\r\nrespectively. (task #30)\r\n\r\nSigned-off-by: Rogerio Alves <rcardoso@linux.vnet.ibm.com>","created_at":"2018-03-01T14:10:16Z","updated_at":"2018-03-06T13:48:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"836b2209ae5d9c16a26d80f78a97b7707a61e2df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libdfp/libdfp/pulls/65/commits","review_comments_url":"https://api.github.com/repos/libdfp/libdfp/pulls/65/comments","review_comment_url":"https://api.github.com/repos/libdfp/libdfp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libdfp/libdfp/issues/65/comments","statuses_url":"https://api.github.com/repos/libdfp/libdfp/statuses/75b60cf1537de9ee75487600ae98a78cd3e23052","head":{"label":"racardoso:fix-subnormals","ref":"fix-subnormals","sha":"75b60cf1537de9ee75487600ae98a78cd3e23052","user":{"login":"racardoso","id":13421176,"avatar_url":"https://avatars0.githubusercontent.com/u/13421176?v=4","gravatar_id":"","url":"https://api.github.com/users/racardoso","html_url":"https://github.com/racardoso","followers_url":"https://api.github.com/users/racardoso/followers","following_url":"https://api.github.com/users/racardoso/following{/other_user}","gists_url":"https://api.github.com/users/racardoso/gists{/gist_id}","starred_url":"https://api.github.com/users/racardoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racardoso/subscriptions","organizations_url":"https://api.github.com/users/racardoso/orgs","repos_url":"https://api.github.com/users/racardoso/repos","events_url":"https://api.github.com/users/racardoso/events{/privacy}","received_events_url":"https://api.github.com/users/racardoso/received_events","type":"User","site_admin":false},"repo":{"id":101081769,"name":"libdfp","full_name":"racardoso/libdfp","owner":{"login":"racardoso","id":13421176,"avatar_url":"https://avatars0.githubusercontent.com/u/13421176?v=4","gravatar_id":"","url":"https://api.github.com/users/racardoso","html_url":"https://github.com/racardoso","followers_url":"https://api.github.com/users/racardoso/followers","following_url":"https://api.github.com/users/racardoso/following{/other_user}","gists_url":"https://api.github.com/users/racardoso/gists{/gist_id}","starred_url":"https://api.github.com/users/racardoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racardoso/subscriptions","organizations_url":"https://api.github.com/users/racardoso/orgs","repos_url":"https://api.github.com/users/racardoso/repos","events_url":"https://api.github.com/users/racardoso/events{/privacy}","received_events_url":"https://api.github.com/users/racardoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/racardoso/libdfp","description":"Decimal Floating Point C Library","fork":true,"url":"https://api.github.com/repos/racardoso/libdfp","forks_url":"https://api.github.com/repos/racardoso/libdfp/forks","keys_url":"https://api.github.com/repos/racardoso/libdfp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/racardoso/libdfp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/racardoso/libdfp/teams","hooks_url":"https://api.github.com/repos/racardoso/libdfp/hooks","issue_events_url":"https://api.github.com/repos/racardoso/libdfp/issues/events{/number}","events_url":"https://api.github.com/repos/racardoso/libdfp/events","assignees_url":"https://api.github.com/repos/racardoso/libdfp/assignees{/user}","branches_url":"https://api.github.com/repos/racardoso/libdfp/branches{/branch}","tags_url":"https://api.github.com/repos/racardoso/libdfp/tags","blobs_url":"https://api.github.com/repos/racardoso/libdfp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/racardoso/libdfp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/racardoso/libdfp/git/refs{/sha}","trees_url":"https://api.github.com/repos/racardoso/libdfp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/racardoso/libdfp/statuses/{sha}","languages_url":"https://api.github.com/repos/racardoso/libdfp/languages","stargazers_url":"https://api.github.com/repos/racardoso/libdfp/stargazers","contributors_url":"https://api.github.com/repos/racardoso/libdfp/contributors","subscribers_url":"https://api.github.com/repos/racardoso/libdfp/subscribers","subscription_url":"https://api.github.com/repos/racardoso/libdfp/subscription","commits_url":"https://api.github.com/repos/racardoso/libdfp/commits{/sha}","git_commits_url":"https://api.github.com/repos/racardoso/libdfp/git/commits{/sha}","comments_url":"https://api.github.com/repos/racardoso/libdfp/comments{/number}","issue_comment_url":"https://api.github.com/repos/racardoso/libdfp/issues/comments{/number}","contents_url":"https://api.github.com/repos/racardoso/libdfp/contents/{+path}","compare_url":"https://api.github.com/repos/racardoso/libdfp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/racardoso/libdfp/merges","archive_url":"https://api.github.com/repos/racardoso/libdfp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/racardoso/libdfp/downloads","issues_url":"https://api.github.com/repos/racardoso/libdfp/issues{/number}","pulls_url":"https://api.github.com/repos/racardoso/libdfp/pulls{/number}","milestones_url":"https://api.github.com/repos/racardoso/libdfp/milestones{/number}","notifications_url":"https://api.github.com/repos/racardoso/libdfp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/racardoso/libdfp/labels{/name}","releases_url":"https://api.github.com/repos/racardoso/libdfp/releases{/id}","deployments_url":"https://api.github.com/repos/racardoso/libdfp/deployments","created_at":"2017-08-22T16:02:07Z","updated_at":"2017-08-22T16:02:10Z","pushed_at":"2018-03-01T14:08:47Z","git_url":"git://github.com/racardoso/libdfp.git","ssh_url":"git@github.com:racardoso/libdfp.git","clone_url":"https://github.com/racardoso/libdfp.git","svn_url":"https://github.com/racardoso/libdfp","homepage":null,"size":2221,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libdfp:master","ref":"master","sha":"c5f353ed6cef0571b8056a8bee3d4db742722faf","user":{"login":"libdfp","id":6402467,"avatar_url":"https://avatars1.githubusercontent.com/u/6402467?v=4","gravatar_id":"","url":"https://api.github.com/users/libdfp","html_url":"https://github.com/libdfp","followers_url":"https://api.github.com/users/libdfp/followers","following_url":"https://api.github.com/users/libdfp/following{/other_user}","gists_url":"https://api.github.com/users/libdfp/gists{/gist_id}","starred_url":"https://api.github.com/users/libdfp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libdfp/subscriptions","organizations_url":"https://api.github.com/users/libdfp/orgs","repos_url":"https://api.github.com/users/libdfp/repos","events_url":"https://api.github.com/users/libdfp/events{/privacy}","received_events_url":"https://api.github.com/users/libdfp/received_events","type":"Organization","site_admin":false},"repo":{"id":15912252,"name":"libdfp","full_name":"libdfp/libdfp","owner":{"login":"libdfp","id":6402467,"avatar_url":"https://avatars1.githubusercontent.com/u/6402467?v=4","gravatar_id":"","url":"https://api.github.com/users/libdfp","html_url":"https://github.com/libdfp","followers_url":"https://api.github.com/users/libdfp/followers","following_url":"https://api.github.com/users/libdfp/following{/other_user}","gists_url":"https://api.github.com/users/libdfp/gists{/gist_id}","starred_url":"https://api.github.com/users/libdfp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libdfp/subscriptions","organizations_url":"https://api.github.com/users/libdfp/orgs","repos_url":"https://api.github.com/users/libdfp/repos","events_url":"https://api.github.com/users/libdfp/events{/privacy}","received_events_url":"https://api.github.com/users/libdfp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libdfp/libdfp","description":"Decimal Floating Point C Library","fork":false,"url":"https://api.github.com/repos/libdfp/libdfp","forks_url":"https://api.github.com/repos/libdfp/libdfp/forks","keys_url":"https://api.github.com/repos/libdfp/libdfp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libdfp/libdfp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libdfp/libdfp/teams","hooks_url":"https://api.github.com/repos/libdfp/libdfp/hooks","issue_events_url":"https://api.github.com/repos/libdfp/libdfp/issues/events{/number}","events_url":"https://api.github.com/repos/libdfp/libdfp/events","assignees_url":"https://api.github.com/repos/libdfp/libdfp/assignees{/user}","branches_url":"https://api.github.com/repos/libdfp/libdfp/branches{/branch}","tags_url":"https://api.github.com/repos/libdfp/libdfp/tags","blobs_url":"https://api.github.com/repos/libdfp/libdfp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libdfp/libdfp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libdfp/libdfp/git/refs{/sha}","trees_url":"https://api.github.com/repos/libdfp/libdfp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libdfp/libdfp/statuses/{sha}","languages_url":"https://api.github.com/repos/libdfp/libdfp/languages","stargazers_url":"https://api.github.com/repos/libdfp/libdfp/stargazers","contributors_url":"https://api.github.com/repos/libdfp/libdfp/contributors","subscribers_url":"https://api.github.com/repos/libdfp/libdfp/subscribers","subscription_url":"https://api.github.com/repos/libdfp/libdfp/subscription","commits_url":"https://api.github.com/repos/libdfp/libdfp/commits{/sha}","git_commits_url":"https://api.github.com/repos/libdfp/libdfp/git/commits{/sha}","comments_url":"https://api.github.com/repos/libdfp/libdfp/comments{/number}","issue_comment_url":"https://api.github.com/repos/libdfp/libdfp/issues/comments{/number}","contents_url":"https://api.github.com/repos/libdfp/libdfp/contents/{+path}","compare_url":"https://api.github.com/repos/libdfp/libdfp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libdfp/libdfp/merges","archive_url":"https://api.github.com/repos/libdfp/libdfp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libdfp/libdfp/downloads","issues_url":"https://api.github.com/repos/libdfp/libdfp/issues{/number}","pulls_url":"https://api.github.com/repos/libdfp/libdfp/pulls{/number}","milestones_url":"https://api.github.com/repos/libdfp/libdfp/milestones{/number}","notifications_url":"https://api.github.com/repos/libdfp/libdfp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libdfp/libdfp/labels{/name}","releases_url":"https://api.github.com/repos/libdfp/libdfp/releases{/id}","deployments_url":"https://api.github.com/repos/libdfp/libdfp/deployments","created_at":"2014-01-14T19:08:58Z","updated_at":"2018-03-04T19:28:34Z","pushed_at":"2018-03-01T14:10:16Z","git_url":"git://github.com/libdfp/libdfp.git","ssh_url":"git@github.com:libdfp/libdfp.git","clone_url":"https://github.com/libdfp/libdfp.git","svn_url":"https://github.com/libdfp/libdfp","homepage":null,"size":2216,"stargazers_count":24,"watchers_count":24,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":14,"open_issues":17,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/65"},"html":{"href":"https://github.com/libdfp/libdfp/pull/65"},"issue":{"href":"https://api.github.com/repos/libdfp/libdfp/issues/65"},"comments":{"href":"https://api.github.com/repos/libdfp/libdfp/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/libdfp/libdfp/statuses/75b60cf1537de9ee75487600ae98a78cd3e23052"}},"author_association":"NONE"}}
{"actor":{"display_login":"tuliom"}}