{"action":"created","issue":{"url":"https://api.github.com/repos/oliver006/redis_exporter/issues/199","repository_url":"https://api.github.com/repos/oliver006/redis_exporter","labels_url":"https://api.github.com/repos/oliver006/redis_exporter/issues/199/labels{/name}","comments_url":"https://api.github.com/repos/oliver006/redis_exporter/issues/199/comments","events_url":"https://api.github.com/repos/oliver006/redis_exporter/issues/199/events","html_url":"https://github.com/oliver006/redis_exporter/pull/199","id":381340282,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzM0OTc4","number":199,"title":"feat: add aof metrics","user":{"login":"tomplus","id":1572228,"node_id":"MDQ6VXNlcjE1NzIyMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1572228?v=4","gravatar_id":"","url":"https://api.github.com/users/tomplus","html_url":"https://github.com/tomplus","followers_url":"https://api.github.com/users/tomplus/followers","following_url":"https://api.github.com/users/tomplus/following{/other_user}","gists_url":"https://api.github.com/users/tomplus/gists{/gist_id}","starred_url":"https://api.github.com/users/tomplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomplus/subscriptions","organizations_url":"https://api.github.com/users/tomplus/orgs","repos_url":"https://api.github.com/users/tomplus/repos","events_url":"https://api.github.com/users/tomplus/events{/privacy}","received_events_url":"https://api.github.com/users/tomplus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-15T21:09:55Z","updated_at":"2018-11-15T21:11:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/oliver006/redis_exporter/pulls/199","html_url":"https://github.com/oliver006/redis_exporter/pull/199","diff_url":"https://github.com/oliver006/redis_exporter/pull/199.diff","patch_url":"https://github.com/oliver006/redis_exporter/pull/199.patch"},"body":"I'd like to extend list of AOF releated metrics. A server return few metrics if aof is disabled:\r\n\r\n```\r\naof_enabled:0\r\naof_rewrite_in_progress:0\r\naof_rewrite_scheduled:0\r\naof_last_rewrite_time_sec:-1\r\naof_current_rewrite_time_sec:-1\r\naof_last_bgrewrite_status:ok\r\naof_last_write_status:ok\r\naof_last_cow_size:0\r\n```\r\nbut if AOF is enabled we get additional interesting metrics:\r\n\r\n```\r\n127.0.0.1:6379> CONFIG set appendonly yes\r\nOK\r\n\r\n--\r\naof_enabled:1\r\naof_rewrite_in_progress:0\r\naof_rewrite_scheduled:0\r\naof_last_rewrite_time_sec:0\r\naof_current_rewrite_time_sec:-1\r\naof_last_bgrewrite_status:ok\r\naof_last_write_status:ok\r\naof_last_cow_size:200704\r\naof_current_size:92\r\naof_base_size:92\r\naof_pending_rewrite:0\r\naof_buffer_length:0\r\naof_rewrite_buffer_length:0\r\naof_pending_bio_fsync:0\r\naof_delayed_fsync:0\r\n```\r\n\r\nIn this PR I added the metrics from the list above.\r\n\r\nThanks.\r\n"},"comment":{"url":"https://api.github.com/repos/oliver006/redis_exporter/issues/comments/439191433","html_url":"https://github.com/oliver006/redis_exporter/pull/199#issuecomment-439191433","issue_url":"https://api.github.com/repos/oliver006/redis_exporter/issues/199","id":439191433,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTE5MTQzMw==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T21:11:05Z","updated_at":"2018-11-15T21:11:05Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/20132081/badge)](https://coveralls.io/builds/20132081)\n\nCoverage remained the same at 88.22% when pulling **f99d3e9dc089e897187ea9a1826f80b8ceac2761 on tomplus:feat/aof-metrics** into **d870a53c5e9c8a2b798d29e670ca6b43468edddc on oliver006:master**.\n"}}
{"actor":{"display_login":"coveralls"}}