{"action":"created","issue":{"url":"https://api.github.com/repos/johot/TinyOAuth1/issues/2","repository_url":"https://api.github.com/repos/johot/TinyOAuth1","labels_url":"https://api.github.com/repos/johot/TinyOAuth1/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/johot/TinyOAuth1/issues/2/comments","events_url":"https://api.github.com/repos/johot/TinyOAuth1/issues/2/events","html_url":"https://github.com/johot/TinyOAuth1/pull/2","id":337356274,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTYzMzk3","number":2,"title":"Add ability to change signature method and provide RSA signing key.","user":{"login":"jekstrom","id":2407180,"node_id":"MDQ6VXNlcjI0MDcxODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2407180?v=4","gravatar_id":"","url":"https://api.github.com/users/jekstrom","html_url":"https://github.com/jekstrom","followers_url":"https://api.github.com/users/jekstrom/followers","following_url":"https://api.github.com/users/jekstrom/following{/other_user}","gists_url":"https://api.github.com/users/jekstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jekstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekstrom/subscriptions","organizations_url":"https://api.github.com/users/jekstrom/orgs","repos_url":"https://api.github.com/users/jekstrom/repos","events_url":"https://api.github.com/users/jekstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jekstrom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-02T03:15:24Z","updated_at":"2018-10-11T15:39:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/johot/TinyOAuth1/pulls/2","html_url":"https://github.com/johot/TinyOAuth1/pull/2","diff_url":"https://github.com/johot/TinyOAuth1/pull/2.diff","patch_url":"https://github.com/johot/TinyOAuth1/pull/2.patch"},"body":"I needed the ability to sign with RSA-SHA1 for interacting with Jira, so I modified this to handle that signing method."},"comment":{"url":"https://api.github.com/repos/johot/TinyOAuth1/issues/comments/429003956","html_url":"https://github.com/johot/TinyOAuth1/pull/2#issuecomment-429003956","issue_url":"https://api.github.com/repos/johot/TinyOAuth1/issues/2","id":429003956,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTAwMzk1Ng==","user":{"login":"nitzel","id":8362046,"node_id":"MDQ6VXNlcjgzNjIwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/8362046?v=4","gravatar_id":"","url":"https://api.github.com/users/nitzel","html_url":"https://github.com/nitzel","followers_url":"https://api.github.com/users/nitzel/followers","following_url":"https://api.github.com/users/nitzel/following{/other_user}","gists_url":"https://api.github.com/users/nitzel/gists{/gist_id}","starred_url":"https://api.github.com/users/nitzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitzel/subscriptions","organizations_url":"https://api.github.com/users/nitzel/orgs","repos_url":"https://api.github.com/users/nitzel/repos","events_url":"https://api.github.com/users/nitzel/events{/privacy}","received_events_url":"https://api.github.com/users/nitzel/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T15:39:27Z","updated_at":"2018-10-11T15:39:27Z","author_association":"NONE","body":"@jekstrom Thanks for taking the ownership here! The nuget package works mostly fine for me.\r\nWhat bugs me is that the code in the nuget package is not the same as in your master branch (`NotImplementedException`s).\r\n\r\nFor the oauth_callback to work with JIRA, you have to completely omit(sic!) it in `GetRequestTokenAsync` and then append it to the url as you did in `GetAuthorizationUrl`.\r\n\r\nAs strings are a code smell I'd convert them to `Uri`s where possible and use an enum for the signature method. I've used a slightly incorrect string way too many times:\r\n```\r\n    public enum SignatureMethod\r\n    {\r\n        HMAC_SHA1,\r\n        RSA_SHA1,\r\n        PLAINTEXT\r\n    }\r\n\r\n    public static class ExtensionMethods\r\n    {\r\n        public static string MapToString(this SignatureMethod signatureMethod)\r\n        {\r\n            switch (signatureMethod)\r\n            {\r\n                case SignatureMethod.HMAC_SHA1:\r\n                    return \"HMAC-SHA1\";\r\n                case SignatureMethod.RSA_SHA1:\r\n                    return \"RSA-SHA1\";\r\n                case SignatureMethod.PLAINTEXT:\r\n                    return \"PLAINTEXT\";\r\n                default:\r\n                    throw new ArgumentException(nameof(signatureMethod));\r\n            }\r\n        }\r\n    }\r\n```"}}
{"actor":{"display_login":"nitzel"}}