{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20398","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20398/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20398/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20398/events","html_url":"https://github.com/joomla/joomla-cms/pull/20398","id":322935359,"number":20398,"title":"[4.0] Fix frontend module editing","user":{"login":"dgrammatiko","id":3889375,"avatar_url":"https://avatars0.githubusercontent.com/u/3889375?v=4","gravatar_id":"","url":"https://api.github.com/users/dgrammatiko","html_url":"https://github.com/dgrammatiko","followers_url":"https://api.github.com/users/dgrammatiko/followers","following_url":"https://api.github.com/users/dgrammatiko/following{/other_user}","gists_url":"https://api.github.com/users/dgrammatiko/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrammatiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrammatiko/subscriptions","organizations_url":"https://api.github.com/users/dgrammatiko/orgs","repos_url":"https://api.github.com/users/dgrammatiko/repos","events_url":"https://api.github.com/users/dgrammatiko/events{/privacy}","received_events_url":"https://api.github.com/users/dgrammatiko/received_events","type":"User","site_admin":false},"labels":[{"id":444033883,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-14T18:44:50Z","updated_at":"2018-05-15T08:48:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20398","html_url":"https://github.com/joomla/joomla-cms/pull/20398","diff_url":"https://github.com/joomla/joomla-cms/pull/20398.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20398.patch"},"body":"Issue: https://github.com/joomla/joomla-cms/issues/20389\r\n\r\n### Summary of Changes\r\nStandard forms dont require inline js for validation, they only require a class `form-validate`!\r\n\r\n\r\n### Testing Instructions\r\n\r\nApply patch and try to edit a module in the frontend. Save, Save and close and Close buttons should behave normally. Also check that editing the article also works\r\n\r\nBTW, I've applied the same code to the rest views of com_config and also com_content\r\n\r\n### Expected result\r\n\r\n<img width=\"578\" alt=\"screen shot 2018-05-14 at 20 37 53\" src=\"https://user-images.githubusercontent.com/3889375/40016653-45bbfbdc-57b7-11e8-8030-b9db26c0a919.png\">\r\n\r\n\r\n### Actual result\r\n\r\n\r\n### Documentation Changes Required\r\nAt some point we really need to document this submitbutton...\r\n\r\n\r\n@wilsonge "},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/389092066","html_url":"https://github.com/joomla/joomla-cms/pull/20398#issuecomment-389092066","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20398","id":389092066,"user":{"login":"laoneo","id":251072,"avatar_url":"https://avatars3.githubusercontent.com/u/251072?v=4","gravatar_id":"","url":"https://api.github.com/users/laoneo","html_url":"https://github.com/laoneo","followers_url":"https://api.github.com/users/laoneo/followers","following_url":"https://api.github.com/users/laoneo/following{/other_user}","gists_url":"https://api.github.com/users/laoneo/gists{/gist_id}","starred_url":"https://api.github.com/users/laoneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laoneo/subscriptions","organizations_url":"https://api.github.com/users/laoneo/orgs","repos_url":"https://api.github.com/users/laoneo/repos","events_url":"https://api.github.com/users/laoneo/events{/privacy}","received_events_url":"https://api.github.com/users/laoneo/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T08:48:14Z","updated_at":"2018-05-15T08:48:14Z","author_association":"MEMBER","body":"The drone tests are because of some other issues."}}
{"actor":{"display_login":"laoneo"}}