{"action":"created","comment":{"url":"https://api.github.com/repos/ElementsProject/elements/pulls/comments/221042826","pull_request_review_id":159597397,"id":221042826,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTA0MjgyNg==","diff_hunk":"@@ -49,12 +49,15 @@ def setup_network(self, split=False):\n                 rpc_u, rpc_p = rpc_auth_pair(n)\n                 self.extra_args.append([\n                     \"-printtoconsole=0\",\n+                    \"-addresstype=legacy\", # To make sure bitcoind gives back p2pkh no matter version\n+                    \"-deprecatedrpc=validateaddress\",\n+                    # Parent chain is looking for its own conf(e.g., bitcoin.conf)\n+                    # These are not generated or cached during batch functional testing\n+                    # so we enter the required lines here","path":"qa/rpc-tests/feature_fedpeg.py","position":null,"original_position":8,"commit_id":"b2c2ee4cafab57f7f7ed2518d12ae4a0dc48e4b3","original_commit_id":"396dc19af8329aa8925056b41365e72fc2504858","user":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"body":"i didnt feel like fixing up this comment if we end up adding more chain support in the future :)","created_at":"2018-09-27T19:07:33Z","updated_at":"2018-09-27T19:07:33Z","html_url":"https://github.com/ElementsProject/elements/pull/422#discussion_r221042826","pull_request_url":"https://api.github.com/repos/ElementsProject/elements/pulls/422","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/elements/pulls/comments/221042826"},"html":{"href":"https://github.com/ElementsProject/elements/pull/422#discussion_r221042826"},"pull_request":{"href":"https://api.github.com/repos/ElementsProject/elements/pulls/422"}},"in_reply_to_id":221020620},"pull_request":{"url":"https://api.github.com/repos/ElementsProject/elements/pulls/422","id":218737870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NzM3ODcw","html_url":"https://github.com/ElementsProject/elements/pull/422","diff_url":"https://github.com/ElementsProject/elements/pull/422.diff","patch_url":"https://github.com/ElementsProject/elements/pull/422.patch","issue_url":"https://api.github.com/repos/ElementsProject/elements/issues/422","number":422,"state":"open","locked":false,"title":"feature_fedpeg.py bitcoind parent2 uses rpc cookie auth","user":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"body":"Resolves https://github.com/ElementsProject/elements/issues/420","created_at":"2018-09-27T17:54:23Z","updated_at":"2018-09-27T19:07:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58c59bff3fd03adca05a7a8ea7408f4e02f2dfd5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ElementsProject/elements/pulls/422/commits","review_comments_url":"https://api.github.com/repos/ElementsProject/elements/pulls/422/comments","review_comment_url":"https://api.github.com/repos/ElementsProject/elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElementsProject/elements/issues/422/comments","statuses_url":"https://api.github.com/repos/ElementsProject/elements/statuses/b2c2ee4cafab57f7f7ed2518d12ae4a0dc48e4b3","head":{"label":"instagibbs:explain_port_dupe","ref":"explain_port_dupe","sha":"b2c2ee4cafab57f7f7ed2518d12ae4a0dc48e4b3","user":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"repo":{"id":45544816,"node_id":"MDEwOlJlcG9zaXRvcnk0NTU0NDgxNg==","name":"elements","full_name":"instagibbs/elements","private":false,"owner":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/instagibbs/elements","description":"Feature experiments to advance the art of Bitcoin","fork":true,"url":"https://api.github.com/repos/instagibbs/elements","forks_url":"https://api.github.com/repos/instagibbs/elements/forks","keys_url":"https://api.github.com/repos/instagibbs/elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/instagibbs/elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/instagibbs/elements/teams","hooks_url":"https://api.github.com/repos/instagibbs/elements/hooks","issue_events_url":"https://api.github.com/repos/instagibbs/elements/issues/events{/number}","events_url":"https://api.github.com/repos/instagibbs/elements/events","assignees_url":"https://api.github.com/repos/instagibbs/elements/assignees{/user}","branches_url":"https://api.github.com/repos/instagibbs/elements/branches{/branch}","tags_url":"https://api.github.com/repos/instagibbs/elements/tags","blobs_url":"https://api.github.com/repos/instagibbs/elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/instagibbs/elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/instagibbs/elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/instagibbs/elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/instagibbs/elements/statuses/{sha}","languages_url":"https://api.github.com/repos/instagibbs/elements/languages","stargazers_url":"https://api.github.com/repos/instagibbs/elements/stargazers","contributors_url":"https://api.github.com/repos/instagibbs/elements/contributors","subscribers_url":"https://api.github.com/repos/instagibbs/elements/subscribers","subscription_url":"https://api.github.com/repos/instagibbs/elements/subscription","commits_url":"https://api.github.com/repos/instagibbs/elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/instagibbs/elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/instagibbs/elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/instagibbs/elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/instagibbs/elements/contents/{+path}","compare_url":"https://api.github.com/repos/instagibbs/elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/instagibbs/elements/merges","archive_url":"https://api.github.com/repos/instagibbs/elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/instagibbs/elements/downloads","issues_url":"https://api.github.com/repos/instagibbs/elements/issues{/number}","pulls_url":"https://api.github.com/repos/instagibbs/elements/pulls{/number}","milestones_url":"https://api.github.com/repos/instagibbs/elements/milestones{/number}","notifications_url":"https://api.github.com/repos/instagibbs/elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/instagibbs/elements/labels{/name}","releases_url":"https://api.github.com/repos/instagibbs/elements/releases{/id}","deployments_url":"https://api.github.com/repos/instagibbs/elements/deployments","created_at":"2015-11-04T14:39:00Z","updated_at":"2016-02-15T19:58:12Z","pushed_at":"2018-09-27T19:02:43Z","git_url":"git://github.com/instagibbs/elements.git","ssh_url":"git@github.com:instagibbs/elements.git","clone_url":"https://github.com/instagibbs/elements.git","svn_url":"https://github.com/instagibbs/elements","homepage":"","size":53264,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"alpha"}},"base":{"label":"ElementsProject:elements-0.14.1","ref":"elements-0.14.1","sha":"5fe9c2cbebfe8444f5599d92966bb4a840daa982","user":{"login":"ElementsProject","id":12729539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzI5NTM5","avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":37064937,"node_id":"MDEwOlJlcG9zaXRvcnkzNzA2NDkzNw==","name":"elements","full_name":"ElementsProject/elements","private":false,"owner":{"login":"ElementsProject","id":12729539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzI5NTM5","avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ElementsProject/elements","description":"Open Source implementation of advanced blockchain features extending the Bitcoin protocol","fork":false,"url":"https://api.github.com/repos/ElementsProject/elements","forks_url":"https://api.github.com/repos/ElementsProject/elements/forks","keys_url":"https://api.github.com/repos/ElementsProject/elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElementsProject/elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElementsProject/elements/teams","hooks_url":"https://api.github.com/repos/ElementsProject/elements/hooks","issue_events_url":"https://api.github.com/repos/ElementsProject/elements/issues/events{/number}","events_url":"https://api.github.com/repos/ElementsProject/elements/events","assignees_url":"https://api.github.com/repos/ElementsProject/elements/assignees{/user}","branches_url":"https://api.github.com/repos/ElementsProject/elements/branches{/branch}","tags_url":"https://api.github.com/repos/ElementsProject/elements/tags","blobs_url":"https://api.github.com/repos/ElementsProject/elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElementsProject/elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElementsProject/elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElementsProject/elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElementsProject/elements/statuses/{sha}","languages_url":"https://api.github.com/repos/ElementsProject/elements/languages","stargazers_url":"https://api.github.com/repos/ElementsProject/elements/stargazers","contributors_url":"https://api.github.com/repos/ElementsProject/elements/contributors","subscribers_url":"https://api.github.com/repos/ElementsProject/elements/subscribers","subscription_url":"https://api.github.com/repos/ElementsProject/elements/subscription","commits_url":"https://api.github.com/repos/ElementsProject/elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElementsProject/elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElementsProject/elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElementsProject/elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElementsProject/elements/contents/{+path}","compare_url":"https://api.github.com/repos/ElementsProject/elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElementsProject/elements/merges","archive_url":"https://api.github.com/repos/ElementsProject/elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElementsProject/elements/downloads","issues_url":"https://api.github.com/repos/ElementsProject/elements/issues{/number}","pulls_url":"https://api.github.com/repos/ElementsProject/elements/pulls{/number}","milestones_url":"https://api.github.com/repos/ElementsProject/elements/milestones{/number}","notifications_url":"https://api.github.com/repos/ElementsProject/elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElementsProject/elements/labels{/name}","releases_url":"https://api.github.com/repos/ElementsProject/elements/releases{/id}","deployments_url":"https://api.github.com/repos/ElementsProject/elements/deployments","created_at":"2015-06-08T12:17:33Z","updated_at":"2018-09-27T16:12:13Z","pushed_at":"2018-09-27T19:04:43Z","git_url":"git://github.com/ElementsProject/elements.git","ssh_url":"git@github.com:ElementsProject/elements.git","clone_url":"https://github.com/ElementsProject/elements.git","svn_url":"https://github.com/ElementsProject/elements","homepage":"","size":66398,"stargazers_count":573,"watchers_count":573,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":213,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":213,"open_issues":91,"watchers":573,"default_branch":"elements-0.14.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/elements/pulls/422"},"html":{"href":"https://github.com/ElementsProject/elements/pull/422"},"issue":{"href":"https://api.github.com/repos/ElementsProject/elements/issues/422"},"comments":{"href":"https://api.github.com/repos/ElementsProject/elements/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/ElementsProject/elements/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/ElementsProject/elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElementsProject/elements/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/ElementsProject/elements/statuses/b2c2ee4cafab57f7f7ed2518d12ae4a0dc48e4b3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"instagibbs"}}