{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/189799030","pull_request_review_id":122045328,"id":189799030,"diff_hunk":"@@ -5,3 +5,16 @@ Security\n --------\n \n  * Using the `has_role()` function in security expressions is deprecated, use the `is_granted()` function instead.\n+ * Passing custom class names to the\n+   `Symfony\\Component\\Security\\Core\\Authentication\\AuthenticationTrustResolver` to define\n+   custom anonymous and remember me token classes, is deprecated as of 4.2. To\n+   use custom tokens, extend the existing `Symfony\\Component\\Security\\Core\\Authentication\\Token\\AnonymousToken`\n+   and `Symfony\\Component\\Security\\Core\\Authentication\\Token\\RememberMeToken`.\n+\n+SecurityBundle\n+--------------\n+\n+ * Using the `security.authentication.trust_resolver.anonymous_class` and \n+   `security.authentication.trust_resolver.rememberme_class` parameters to define\n+   the token classes, is deprecated as of 4.2. To use","path":"UPGRADE-4.2.md","position":15,"original_position":15,"commit_id":"e82f1faf6743bcc181a78c40405fada1b28ea33d","original_commit_id":"e82f1faf6743bcc181a78c40405fada1b28ea33d","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars3.githubusercontent.com/u/47313?v=4","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2018-05-22T07:23:48Z","updated_at":"2018-05-22T07:26:10Z","html_url":"https://github.com/symfony/symfony/pull/26981#discussion_r189799030","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/26981","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/189799030"},"html":{"href":"https://github.com/symfony/symfony/pull/26981#discussion_r189799030"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26981"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/26981","id":182739763,"html_url":"https://github.com/symfony/symfony/pull/26981","diff_url":"https://github.com/symfony/symfony/pull/26981.diff","patch_url":"https://github.com/symfony/symfony/pull/26981.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/26981","number":26981,"state":"open","locked":false,"title":"No more support for custom anon/remember tokens based on FQCN","user":{"login":"iltar","id":1754678,"avatar_url":"https://avatars0.githubusercontent.com/u/1754678?v=4","gravatar_id":"","url":"https://api.github.com/users/iltar","html_url":"https://github.com/iltar","followers_url":"https://api.github.com/users/iltar/followers","following_url":"https://api.github.com/users/iltar/following{/other_user}","gists_url":"https://api.github.com/users/iltar/gists{/gist_id}","starred_url":"https://api.github.com/users/iltar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iltar/subscriptions","organizations_url":"https://api.github.com/users/iltar/orgs","repos_url":"https://api.github.com/users/iltar/repos","events_url":"https://api.github.com/users/iltar/events{/privacy}","received_events_url":"https://api.github.com/users/iltar/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | #26940\r\n| License       | MIT\r\n| Doc PR        | ~\r\n\r\nThis PR deprecates the ability to configure a custom anonymous and remember me token class, via the AuthenticationTrustResolver. The only change required _if_ you have changed the token classes like this, is to extend the Anonymous/RememberMe token classes.","created_at":"2018-04-19T10:59:58Z","updated_at":"2018-05-22T07:26:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e7581ad5029d5b10ef098b5a2a4dd56121acc8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":337186922,"url":"https://api.github.com/repos/symfony/symfony/labels/Deprecation","name":"Deprecation","color":"f1c40f","default":false},{"id":99600,"url":"https://api.github.com/repos/symfony/symfony/labels/Security","name":"Security","color":"DDDDDD","default":false},{"id":238909857,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Work","name":"Status: Needs Work","color":"fad8c7","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":131,"closed_issues":18,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-05-21T18:18:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/26981/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/26981/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/26981/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/e82f1faf6743bcc181a78c40405fada1b28ea33d","head":{"label":"iltar:feature/trust-resolver-tokens","ref":"feature/trust-resolver-tokens","sha":"e82f1faf6743bcc181a78c40405fada1b28ea33d","user":{"login":"iltar","id":1754678,"avatar_url":"https://avatars0.githubusercontent.com/u/1754678?v=4","gravatar_id":"","url":"https://api.github.com/users/iltar","html_url":"https://github.com/iltar","followers_url":"https://api.github.com/users/iltar/followers","following_url":"https://api.github.com/users/iltar/following{/other_user}","gists_url":"https://api.github.com/users/iltar/gists{/gist_id}","starred_url":"https://api.github.com/users/iltar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iltar/subscriptions","organizations_url":"https://api.github.com/users/iltar/orgs","repos_url":"https://api.github.com/users/iltar/repos","events_url":"https://api.github.com/users/iltar/events{/privacy}","received_events_url":"https://api.github.com/users/iltar/received_events","type":"User","site_admin":false},"repo":{"id":7439250,"name":"symfony","full_name":"iltar/symfony","owner":{"login":"iltar","id":1754678,"avatar_url":"https://avatars0.githubusercontent.com/u/1754678?v=4","gravatar_id":"","url":"https://api.github.com/users/iltar","html_url":"https://github.com/iltar","followers_url":"https://api.github.com/users/iltar/followers","following_url":"https://api.github.com/users/iltar/following{/other_user}","gists_url":"https://api.github.com/users/iltar/gists{/gist_id}","starred_url":"https://api.github.com/users/iltar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iltar/subscriptions","organizations_url":"https://api.github.com/users/iltar/orgs","repos_url":"https://api.github.com/users/iltar/repos","events_url":"https://api.github.com/users/iltar/events{/privacy}","received_events_url":"https://api.github.com/users/iltar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iltar/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/iltar/symfony","forks_url":"https://api.github.com/repos/iltar/symfony/forks","keys_url":"https://api.github.com/repos/iltar/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iltar/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iltar/symfony/teams","hooks_url":"https://api.github.com/repos/iltar/symfony/hooks","issue_events_url":"https://api.github.com/repos/iltar/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/iltar/symfony/events","assignees_url":"https://api.github.com/repos/iltar/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/iltar/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/iltar/symfony/tags","blobs_url":"https://api.github.com/repos/iltar/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iltar/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iltar/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/iltar/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iltar/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/iltar/symfony/languages","stargazers_url":"https://api.github.com/repos/iltar/symfony/stargazers","contributors_url":"https://api.github.com/repos/iltar/symfony/contributors","subscribers_url":"https://api.github.com/repos/iltar/symfony/subscribers","subscription_url":"https://api.github.com/repos/iltar/symfony/subscription","commits_url":"https://api.github.com/repos/iltar/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/iltar/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/iltar/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/iltar/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/iltar/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/iltar/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iltar/symfony/merges","archive_url":"https://api.github.com/repos/iltar/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iltar/symfony/downloads","issues_url":"https://api.github.com/repos/iltar/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/iltar/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/iltar/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/iltar/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iltar/symfony/labels{/name}","releases_url":"https://api.github.com/repos/iltar/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/iltar/symfony/deployments","created_at":"2013-01-04T11:22:34Z","updated_at":"2018-05-18T11:18:47Z","pushed_at":"2018-05-22T07:22:11Z","git_url":"git://github.com/iltar/symfony.git","ssh_url":"git@github.com:iltar/symfony.git","clone_url":"https://github.com/iltar/symfony.git","svn_url":"https://github.com/iltar/symfony","homepage":"symfony.com","size":112886,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"57a1dd1c57170f610c8396001c24f18c03f45f81","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-05-22T07:13:35Z","pushed_at":"2018-05-22T07:22:15Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":117718,"stargazers_count":17610,"watchers_count":17610,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6215,"mirror_url":null,"archived":false,"open_issues_count":829,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6215,"open_issues":829,"watchers":17610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26981"},"html":{"href":"https://github.com/symfony/symfony/pull/26981"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/26981"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/26981/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26981/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26981/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/e82f1faf6743bcc181a78c40405fada1b28ea33d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fabpot"}}