{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11970","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11970/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11970/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11970/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11970","id":365228599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjA3MzIz","number":11970,"title":"Eliminate extra tool-change park moves","user":{"login":"InsanityAutomation","id":38436470,"node_id":"MDQ6VXNlcjM4NDM2NDcw","avatar_url":"https://avatars2.githubusercontent.com/u/38436470?v=4","gravatar_id":"","url":"https://api.github.com/users/InsanityAutomation","html_url":"https://github.com/InsanityAutomation","followers_url":"https://api.github.com/users/InsanityAutomation/followers","following_url":"https://api.github.com/users/InsanityAutomation/following{/other_user}","gists_url":"https://api.github.com/users/InsanityAutomation/gists{/gist_id}","starred_url":"https://api.github.com/users/InsanityAutomation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InsanityAutomation/subscriptions","organizations_url":"https://api.github.com/users/InsanityAutomation/orgs","repos_url":"https://api.github.com/users/InsanityAutomation/repos","events_url":"https://api.github.com/users/InsanityAutomation/events{/privacy}","received_events_url":"https://api.github.com/users/InsanityAutomation/received_events","type":"User","site_admin":false},"labels":[{"id":92233140,"node_id":"MDU6TGFiZWw5MjIzMzE0MA==","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Needs:%20Testing","name":"Needs: Testing","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-09-30T14:22:50Z","updated_at":"2018-10-01T21:18:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11970","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11970","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/11970.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/11970.patch"},"body":"### Requirements\r\n\r\nDual X Carriage enabled\r\n\r\n### Description\r\n\r\nEliminate Unpark z raise variable\r\nEliminate duplicated moves\r\nEnsure dual x carriage tool change function honors no move variable\r\nRemove redundant logic\r\n\r\nIf this looks good, please let me know before merging and I will update all of the default / example configs today."},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/426066436","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11970#issuecomment-426066436","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11970","id":426066436,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjA2NjQzNg==","user":{"login":"Roxy-3D","id":8404322,"node_id":"MDQ6VXNlcjg0MDQzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/8404322?v=4","gravatar_id":"","url":"https://api.github.com/users/Roxy-3D","html_url":"https://github.com/Roxy-3D","followers_url":"https://api.github.com/users/Roxy-3D/followers","following_url":"https://api.github.com/users/Roxy-3D/following{/other_user}","gists_url":"https://api.github.com/users/Roxy-3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Roxy-3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roxy-3D/subscriptions","organizations_url":"https://api.github.com/users/Roxy-3D/orgs","repos_url":"https://api.github.com/users/Roxy-3D/repos","events_url":"https://api.github.com/users/Roxy-3D/events{/privacy}","received_events_url":"https://api.github.com/users/Roxy-3D/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T21:18:29Z","updated_at":"2018-10-01T21:18:29Z","author_association":"MEMBER","body":"OK!   Understood!\r\n\r\n> One thing in the code that has me dubious is the removal of fixing the position based on the hotend_offset for Y and Z. If the nozzle is offset compared to the other one, then it won't have the correct position without this.\r\n\r\nUnless this is compensated for some where else...  I agree.   In theory the IDEX extruders re-position exactly where the other one was when there is a tool change.   But I know this isn't the case.   \r\n\r\nIn fact...  I think I would almost argue for IDEX, we should put the HOTEND_OFFSET's together so everybody knows they can specify a Z offset:\r\n```\r\n  #define HOTEND_OFFSET_X {0.0,  0.00}  // (in mm) for each extruder, offset of the hotend on the X axis\r\n  #define HOTEND_OFFSET_Y {0.0,  0.00}  // (in mm) for each extruder, offset of the hotend on the Y axis\r\n  #define HOTEND_OFFSET_Z {0.0, -0.00}  // Z-offsets of the two hotends. The first must be 0.\r\n```"}}
{"actor":{"display_login":"Roxy-3D"}}