{"action":"created","issue":{"url":"https://api.github.com/repos/amplitude/redux-query/issues/96","repository_url":"https://api.github.com/repos/amplitude/redux-query","labels_url":"https://api.github.com/repos/amplitude/redux-query/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/amplitude/redux-query/issues/96/comments","events_url":"https://api.github.com/repos/amplitude/redux-query/issues/96/events","html_url":"https://github.com/amplitude/redux-query/issues/96","id":309849796,"node_id":"MDU6SXNzdWUzMDk4NDk3OTY=","number":96,"title":"Serializing url and body could cause passwords to be stored in plain text","user":{"login":"jth0024","id":5278555,"node_id":"MDQ6VXNlcjUyNzg1NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5278555?v=4","gravatar_id":"","url":"https://api.github.com/users/jth0024","html_url":"https://github.com/jth0024","followers_url":"https://api.github.com/users/jth0024/followers","following_url":"https://api.github.com/users/jth0024/following{/other_user}","gists_url":"https://api.github.com/users/jth0024/gists{/gist_id}","starred_url":"https://api.github.com/users/jth0024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jth0024/subscriptions","organizations_url":"https://api.github.com/users/jth0024/orgs","repos_url":"https://api.github.com/users/jth0024/repos","events_url":"https://api.github.com/users/jth0024/events{/privacy}","received_events_url":"https://api.github.com/users/jth0024/received_events","type":"User","site_admin":false},"labels":[{"id":536225976,"node_id":"MDU6TGFiZWw1MzYyMjU5NzY=","url":"https://api.github.com/repos/amplitude/redux-query/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-29T18:02:46Z","updated_at":"2018-09-27T04:13:34Z","closed_at":null,"author_association":"NONE","body":"Hello,\r\n\r\nCorrect me if I'm wrong, but I think your current approach could result in passwords being stored in plain text. Your documentation states that the default queryKey is computed by serializing the url and body. If that's the case, then a mutation that includes a new password in the body could cause that password to get serialized and stored in plain text, right? "},"comment":{"url":"https://api.github.com/repos/amplitude/redux-query/issues/comments/424953335","html_url":"https://github.com/amplitude/redux-query/issues/96#issuecomment-424953335","issue_url":"https://api.github.com/repos/amplitude/redux-query/issues/96","id":424953335,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDk1MzMzNQ==","user":{"login":"karevn","id":7992040,"node_id":"MDQ6VXNlcjc5OTIwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7992040?v=4","gravatar_id":"","url":"https://api.github.com/users/karevn","html_url":"https://github.com/karevn","followers_url":"https://api.github.com/users/karevn/followers","following_url":"https://api.github.com/users/karevn/following{/other_user}","gists_url":"https://api.github.com/users/karevn/gists{/gist_id}","starred_url":"https://api.github.com/users/karevn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karevn/subscriptions","organizations_url":"https://api.github.com/users/karevn/orgs","repos_url":"https://api.github.com/users/karevn/repos","events_url":"https://api.github.com/users/karevn/events{/privacy}","received_events_url":"https://api.github.com/users/karevn/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T04:13:34Z","updated_at":"2018-09-27T04:13:34Z","author_association":"CONTRIBUTOR","body":"#110 resolves this issue by using md5 for query keys.\r\n@jth0024 You can also generate keys by your custom code if you want."}}
{"actor":{"display_login":"karevn"}}