{"action":"opened","number":75,"pull_request":{"url":"https://api.github.com/repos/NBISweden/MrBayes/pulls/75","id":219947562,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTQ3NTYy","html_url":"https://github.com/NBISweden/MrBayes/pull/75","diff_url":"https://github.com/NBISweden/MrBayes/pull/75.diff","patch_url":"https://github.com/NBISweden/MrBayes/pull/75.patch","issue_url":"https://api.github.com/repos/NBISweden/MrBayes/issues/75","number":75,"state":"open","locked":false,"title":"Possible fix for segmentation fault in FMA code path","user":{"login":"kusalananda","id":6161362,"node_id":"MDQ6VXNlcjYxNjEzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6161362?v=4","gravatar_id":"","url":"https://api.github.com/users/kusalananda","html_url":"https://github.com/kusalananda","followers_url":"https://api.github.com/users/kusalananda/followers","following_url":"https://api.github.com/users/kusalananda/following{/other_user}","gists_url":"https://api.github.com/users/kusalananda/gists{/gist_id}","starred_url":"https://api.github.com/users/kusalananda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kusalananda/subscriptions","organizations_url":"https://api.github.com/users/kusalananda/orgs","repos_url":"https://api.github.com/users/kusalananda/repos","events_url":"https://api.github.com/users/kusalananda/events{/privacy}","received_events_url":"https://api.github.com/users/kusalananda/received_events","type":"User","site_admin":false},"body":"The FMA code caused a segmentation fault when calling _mm256_mul_ps() in\r\nCondLikeDown_NUC4_FMA().  This was likely caused by using FMA SIMD\r\ninstructions on misaligned data.\r\n\r\nUpon debugging this, I noticed that AlignedMalloc() was being called\r\nwith an alignment of 16 rather than 32 for some of the data.  This was\r\ndue to two if-statements only testing for AVX and not also for FMA.\r\n\r\nThe patch fixes the two if-statements and the resulting binary no longer\r\nexhibit the segmentation fault.\r\n\r\nI noted that another if-statement already had this extra test for FMA\r\nincluded.\r\n\r\nThis is primarily relating to issue #74 and possibly also to issue #65.\r\n\r\n(the commit message said \"PR\" rather than \"issue\" on the line above this, this was a mistyping)","created_at":"2018-10-03T08:05:29Z","updated_at":"2018-10-03T08:05:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NBISweden/MrBayes/pulls/75/commits","review_comments_url":"https://api.github.com/repos/NBISweden/MrBayes/pulls/75/comments","review_comment_url":"https://api.github.com/repos/NBISweden/MrBayes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NBISweden/MrBayes/issues/75/comments","statuses_url":"https://api.github.com/repos/NBISweden/MrBayes/statuses/58af4d008fc1ed9abe7ea58c81ac15283f578528","head":{"label":"NBISweden:feature/FMA_segfault_fix","ref":"feature/FMA_segfault_fix","sha":"58af4d008fc1ed9abe7ea58c81ac15283f578528","user":{"login":"NBISweden","id":1224807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQ4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1224807?v=4","gravatar_id":"","url":"https://api.github.com/users/NBISweden","html_url":"https://github.com/NBISweden","followers_url":"https://api.github.com/users/NBISweden/followers","following_url":"https://api.github.com/users/NBISweden/following{/other_user}","gists_url":"https://api.github.com/users/NBISweden/gists{/gist_id}","starred_url":"https://api.github.com/users/NBISweden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBISweden/subscriptions","organizations_url":"https://api.github.com/users/NBISweden/orgs","repos_url":"https://api.github.com/users/NBISweden/repos","events_url":"https://api.github.com/users/NBISweden/events{/privacy}","received_events_url":"https://api.github.com/users/NBISweden/received_events","type":"Organization","site_admin":false},"repo":{"id":55602076,"node_id":"MDEwOlJlcG9zaXRvcnk1NTYwMjA3Ng==","name":"MrBayes","full_name":"NBISweden/MrBayes","private":false,"owner":{"login":"NBISweden","id":1224807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQ4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1224807?v=4","gravatar_id":"","url":"https://api.github.com/users/NBISweden","html_url":"https://github.com/NBISweden","followers_url":"https://api.github.com/users/NBISweden/followers","following_url":"https://api.github.com/users/NBISweden/following{/other_user}","gists_url":"https://api.github.com/users/NBISweden/gists{/gist_id}","starred_url":"https://api.github.com/users/NBISweden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBISweden/subscriptions","organizations_url":"https://api.github.com/users/NBISweden/orgs","repos_url":"https://api.github.com/users/NBISweden/repos","events_url":"https://api.github.com/users/NBISweden/events{/privacy}","received_events_url":"https://api.github.com/users/NBISweden/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NBISweden/MrBayes","description":"MrBayes is a program for Bayesian inference and model choice across a wide range of phylogenetic and evolutionary models. For documentation and downloading the program, please see the home page:","fork":false,"url":"https://api.github.com/repos/NBISweden/MrBayes","forks_url":"https://api.github.com/repos/NBISweden/MrBayes/forks","keys_url":"https://api.github.com/repos/NBISweden/MrBayes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NBISweden/MrBayes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NBISweden/MrBayes/teams","hooks_url":"https://api.github.com/repos/NBISweden/MrBayes/hooks","issue_events_url":"https://api.github.com/repos/NBISweden/MrBayes/issues/events{/number}","events_url":"https://api.github.com/repos/NBISweden/MrBayes/events","assignees_url":"https://api.github.com/repos/NBISweden/MrBayes/assignees{/user}","branches_url":"https://api.github.com/repos/NBISweden/MrBayes/branches{/branch}","tags_url":"https://api.github.com/repos/NBISweden/MrBayes/tags","blobs_url":"https://api.github.com/repos/NBISweden/MrBayes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NBISweden/MrBayes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NBISweden/MrBayes/git/refs{/sha}","trees_url":"https://api.github.com/repos/NBISweden/MrBayes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NBISweden/MrBayes/statuses/{sha}","languages_url":"https://api.github.com/repos/NBISweden/MrBayes/languages","stargazers_url":"https://api.github.com/repos/NBISweden/MrBayes/stargazers","contributors_url":"https://api.github.com/repos/NBISweden/MrBayes/contributors","subscribers_url":"https://api.github.com/repos/NBISweden/MrBayes/subscribers","subscription_url":"https://api.github.com/repos/NBISweden/MrBayes/subscription","commits_url":"https://api.github.com/repos/NBISweden/MrBayes/commits{/sha}","git_commits_url":"https://api.github.com/repos/NBISweden/MrBayes/git/commits{/sha}","comments_url":"https://api.github.com/repos/NBISweden/MrBayes/comments{/number}","issue_comment_url":"https://api.github.com/repos/NBISweden/MrBayes/issues/comments{/number}","contents_url":"https://api.github.com/repos/NBISweden/MrBayes/contents/{+path}","compare_url":"https://api.github.com/repos/NBISweden/MrBayes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NBISweden/MrBayes/merges","archive_url":"https://api.github.com/repos/NBISweden/MrBayes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NBISweden/MrBayes/downloads","issues_url":"https://api.github.com/repos/NBISweden/MrBayes/issues{/number}","pulls_url":"https://api.github.com/repos/NBISweden/MrBayes/pulls{/number}","milestones_url":"https://api.github.com/repos/NBISweden/MrBayes/milestones{/number}","notifications_url":"https://api.github.com/repos/NBISweden/MrBayes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NBISweden/MrBayes/labels{/name}","releases_url":"https://api.github.com/repos/NBISweden/MrBayes/releases{/id}","deployments_url":"https://api.github.com/repos/NBISweden/MrBayes/deployments","created_at":"2016-04-06T11:59:34Z","updated_at":"2018-09-27T14:59:06Z","pushed_at":"2018-10-03T08:03:11Z","git_url":"git://github.com/NBISweden/MrBayes.git","ssh_url":"git@github.com:NBISweden/MrBayes.git","clone_url":"https://github.com/NBISweden/MrBayes.git","svn_url":"https://github.com/NBISweden/MrBayes","homepage":"http://NBISweden.github.io/MrBayes/","size":192696,"stargazers_count":37,"watchers_count":37,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":38,"watchers":37,"default_branch":"develop"}},"base":{"label":"NBISweden:develop","ref":"develop","sha":"4575990ba308aae99bb133730b2e634f7c25b238","user":{"login":"NBISweden","id":1224807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQ4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1224807?v=4","gravatar_id":"","url":"https://api.github.com/users/NBISweden","html_url":"https://github.com/NBISweden","followers_url":"https://api.github.com/users/NBISweden/followers","following_url":"https://api.github.com/users/NBISweden/following{/other_user}","gists_url":"https://api.github.com/users/NBISweden/gists{/gist_id}","starred_url":"https://api.github.com/users/NBISweden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBISweden/subscriptions","organizations_url":"https://api.github.com/users/NBISweden/orgs","repos_url":"https://api.github.com/users/NBISweden/repos","events_url":"https://api.github.com/users/NBISweden/events{/privacy}","received_events_url":"https://api.github.com/users/NBISweden/received_events","type":"Organization","site_admin":false},"repo":{"id":55602076,"node_id":"MDEwOlJlcG9zaXRvcnk1NTYwMjA3Ng==","name":"MrBayes","full_name":"NBISweden/MrBayes","private":false,"owner":{"login":"NBISweden","id":1224807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQ4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1224807?v=4","gravatar_id":"","url":"https://api.github.com/users/NBISweden","html_url":"https://github.com/NBISweden","followers_url":"https://api.github.com/users/NBISweden/followers","following_url":"https://api.github.com/users/NBISweden/following{/other_user}","gists_url":"https://api.github.com/users/NBISweden/gists{/gist_id}","starred_url":"https://api.github.com/users/NBISweden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBISweden/subscriptions","organizations_url":"https://api.github.com/users/NBISweden/orgs","repos_url":"https://api.github.com/users/NBISweden/repos","events_url":"https://api.github.com/users/NBISweden/events{/privacy}","received_events_url":"https://api.github.com/users/NBISweden/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NBISweden/MrBayes","description":"MrBayes is a program for Bayesian inference and model choice across a wide range of phylogenetic and evolutionary models. For documentation and downloading the program, please see the home page:","fork":false,"url":"https://api.github.com/repos/NBISweden/MrBayes","forks_url":"https://api.github.com/repos/NBISweden/MrBayes/forks","keys_url":"https://api.github.com/repos/NBISweden/MrBayes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NBISweden/MrBayes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NBISweden/MrBayes/teams","hooks_url":"https://api.github.com/repos/NBISweden/MrBayes/hooks","issue_events_url":"https://api.github.com/repos/NBISweden/MrBayes/issues/events{/number}","events_url":"https://api.github.com/repos/NBISweden/MrBayes/events","assignees_url":"https://api.github.com/repos/NBISweden/MrBayes/assignees{/user}","branches_url":"https://api.github.com/repos/NBISweden/MrBayes/branches{/branch}","tags_url":"https://api.github.com/repos/NBISweden/MrBayes/tags","blobs_url":"https://api.github.com/repos/NBISweden/MrBayes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NBISweden/MrBayes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NBISweden/MrBayes/git/refs{/sha}","trees_url":"https://api.github.com/repos/NBISweden/MrBayes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NBISweden/MrBayes/statuses/{sha}","languages_url":"https://api.github.com/repos/NBISweden/MrBayes/languages","stargazers_url":"https://api.github.com/repos/NBISweden/MrBayes/stargazers","contributors_url":"https://api.github.com/repos/NBISweden/MrBayes/contributors","subscribers_url":"https://api.github.com/repos/NBISweden/MrBayes/subscribers","subscription_url":"https://api.github.com/repos/NBISweden/MrBayes/subscription","commits_url":"https://api.github.com/repos/NBISweden/MrBayes/commits{/sha}","git_commits_url":"https://api.github.com/repos/NBISweden/MrBayes/git/commits{/sha}","comments_url":"https://api.github.com/repos/NBISweden/MrBayes/comments{/number}","issue_comment_url":"https://api.github.com/repos/NBISweden/MrBayes/issues/comments{/number}","contents_url":"https://api.github.com/repos/NBISweden/MrBayes/contents/{+path}","compare_url":"https://api.github.com/repos/NBISweden/MrBayes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NBISweden/MrBayes/merges","archive_url":"https://api.github.com/repos/NBISweden/MrBayes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NBISweden/MrBayes/downloads","issues_url":"https://api.github.com/repos/NBISweden/MrBayes/issues{/number}","pulls_url":"https://api.github.com/repos/NBISweden/MrBayes/pulls{/number}","milestones_url":"https://api.github.com/repos/NBISweden/MrBayes/milestones{/number}","notifications_url":"https://api.github.com/repos/NBISweden/MrBayes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NBISweden/MrBayes/labels{/name}","releases_url":"https://api.github.com/repos/NBISweden/MrBayes/releases{/id}","deployments_url":"https://api.github.com/repos/NBISweden/MrBayes/deployments","created_at":"2016-04-06T11:59:34Z","updated_at":"2018-09-27T14:59:06Z","pushed_at":"2018-10-03T08:03:11Z","git_url":"git://github.com/NBISweden/MrBayes.git","ssh_url":"git@github.com:NBISweden/MrBayes.git","clone_url":"https://github.com/NBISweden/MrBayes.git","svn_url":"https://github.com/NBISweden/MrBayes","homepage":"http://NBISweden.github.io/MrBayes/","size":192696,"stargazers_count":37,"watchers_count":37,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":38,"watchers":37,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NBISweden/MrBayes/pulls/75"},"html":{"href":"https://github.com/NBISweden/MrBayes/pull/75"},"issue":{"href":"https://api.github.com/repos/NBISweden/MrBayes/issues/75"},"comments":{"href":"https://api.github.com/repos/NBISweden/MrBayes/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/NBISweden/MrBayes/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/NBISweden/MrBayes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NBISweden/MrBayes/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/NBISweden/MrBayes/statuses/58af4d008fc1ed9abe7ea58c81ac15283f578528"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"kusalananda"}}