{"action":"created","issue":{"url":"https://api.github.com/repos/cerner/terra-core/issues/1214","repository_url":"https://api.github.com/repos/cerner/terra-core","labels_url":"https://api.github.com/repos/cerner/terra-core/issues/1214/labels{/name}","comments_url":"https://api.github.com/repos/cerner/terra-core/issues/1214/comments","events_url":"https://api.github.com/repos/cerner/terra-core/issues/1214/events","html_url":"https://github.com/cerner/terra-core/pull/1214","id":294868055,"number":1214,"title":"Add theming styles and wdio tests to Popup.","user":{"login":"msaikaushik1992","id":8599881,"avatar_url":"https://avatars0.githubusercontent.com/u/8599881?v=4","gravatar_id":"","url":"https://api.github.com/users/msaikaushik1992","html_url":"https://github.com/msaikaushik1992","followers_url":"https://api.github.com/users/msaikaushik1992/followers","following_url":"https://api.github.com/users/msaikaushik1992/following{/other_user}","gists_url":"https://api.github.com/users/msaikaushik1992/gists{/gist_id}","starred_url":"https://api.github.com/users/msaikaushik1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msaikaushik1992/subscriptions","organizations_url":"https://api.github.com/users/msaikaushik1992/orgs","repos_url":"https://api.github.com/users/msaikaushik1992/repos","events_url":"https://api.github.com/users/msaikaushik1992/events{/privacy}","received_events_url":"https://api.github.com/users/msaikaushik1992/received_events","type":"User","site_admin":false},"labels":[{"id":608219660,"url":"https://api.github.com/repos/cerner/terra-core/labels/Needs%20UX%20review","name":"Needs UX review","color":"d93f0b","default":false},{"id":608219780,"url":"https://api.github.com/repos/cerner/terra-core/labels/Needs%20functional%20review","name":"Needs functional review","color":"d93f0b","default":false},{"id":547258202,"url":"https://api.github.com/repos/cerner/terra-core/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":681010787,"url":"https://api.github.com/repos/cerner/terra-core/labels/testing","name":"testing","color":"bfdadc","default":false},{"id":595531418,"url":"https://api.github.com/repos/cerner/terra-core/labels/theming","name":"theming","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"msaikaushik1992","id":8599881,"avatar_url":"https://avatars0.githubusercontent.com/u/8599881?v=4","gravatar_id":"","url":"https://api.github.com/users/msaikaushik1992","html_url":"https://github.com/msaikaushik1992","followers_url":"https://api.github.com/users/msaikaushik1992/followers","following_url":"https://api.github.com/users/msaikaushik1992/following{/other_user}","gists_url":"https://api.github.com/users/msaikaushik1992/gists{/gist_id}","starred_url":"https://api.github.com/users/msaikaushik1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msaikaushik1992/subscriptions","organizations_url":"https://api.github.com/users/msaikaushik1992/orgs","repos_url":"https://api.github.com/users/msaikaushik1992/repos","events_url":"https://api.github.com/users/msaikaushik1992/events{/privacy}","received_events_url":"https://api.github.com/users/msaikaushik1992/received_events","type":"User","site_admin":false},"assignees":[{"login":"msaikaushik1992","id":8599881,"avatar_url":"https://avatars0.githubusercontent.com/u/8599881?v=4","gravatar_id":"","url":"https://api.github.com/users/msaikaushik1992","html_url":"https://github.com/msaikaushik1992","followers_url":"https://api.github.com/users/msaikaushik1992/followers","following_url":"https://api.github.com/users/msaikaushik1992/following{/other_user}","gists_url":"https://api.github.com/users/msaikaushik1992/gists{/gist_id}","starred_url":"https://api.github.com/users/msaikaushik1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msaikaushik1992/subscriptions","organizations_url":"https://api.github.com/users/msaikaushik1992/orgs","repos_url":"https://api.github.com/users/msaikaushik1992/repos","events_url":"https://api.github.com/users/msaikaushik1992/events{/privacy}","received_events_url":"https://api.github.com/users/msaikaushik1992/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-06T18:37:27Z","updated_at":"2018-02-08T17:53:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/1214","html_url":"https://github.com/cerner/terra-core/pull/1214","diff_url":"https://github.com/cerner/terra-core/pull/1214.diff","patch_url":"https://github.com/cerner/terra-core/pull/1214.patch"},"body":"### Summary\r\nResolves #1213 \r\n\r\n### Additional Details\r\nThis adds theming styles and web driver IO tests to Popup component."},"comment":{"url":"https://api.github.com/repos/cerner/terra-core/issues/comments/364194206","html_url":"https://github.com/cerner/terra-core/pull/1214#issuecomment-364194206","issue_url":"https://api.github.com/repos/cerner/terra-core/issues/1214","id":364194206,"user":{"login":"neilpfeiffer","id":1355485,"avatar_url":"https://avatars1.githubusercontent.com/u/1355485?v=4","gravatar_id":"","url":"https://api.github.com/users/neilpfeiffer","html_url":"https://github.com/neilpfeiffer","followers_url":"https://api.github.com/users/neilpfeiffer/followers","following_url":"https://api.github.com/users/neilpfeiffer/following{/other_user}","gists_url":"https://api.github.com/users/neilpfeiffer/gists{/gist_id}","starred_url":"https://api.github.com/users/neilpfeiffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilpfeiffer/subscriptions","organizations_url":"https://api.github.com/users/neilpfeiffer/orgs","repos_url":"https://api.github.com/users/neilpfeiffer/repos","events_url":"https://api.github.com/users/neilpfeiffer/events{/privacy}","received_events_url":"https://api.github.com/users/neilpfeiffer/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T17:53:35Z","updated_at":"2018-02-08T17:53:35Z","author_association":"CONTRIBUTOR","body":"Changes to update for consumer theme:\r\nLets remove these themeable variables and css lines as they are not needed:\r\n```\r\nfont-size: var(--terra-popup-content-close-font-size, 1.45rem);\r\nfont-weight: var(--terra-popup-content-close-font-weight, bold);\r\nline-height: var(--terra-popup-content-close-line-height, 0);\r\n```\r\nline number is here:\r\nhttps://github.com/cerner/terra-core/blob/24efe4a0995d6f04ab38a7c16e9b6478a94e02fc/packages/terra-popup/src/PopupContent.scss#L25\r\n\r\n\\\r\n\\\r\nThis we'll want to keep as non-themeable (remove variable and revert to original) and update value to 3px.\r\nhttps://github.com/cerner/terra-core/blob/24efe4a0995d6f04ab38a7c16e9b6478a94e02fc/packages/terra-popup/src/PopupContent.scss#L10\r\n\r\n\\\r\n\\\r\nAnd here we are going to need to swap out the icon being added via import and the icon component, to making theme a themeable variable where we inline the SVG as the CSS value:\r\nhttps://github.com/cerner/terra-core/blob/24efe4a0995d6f04ab38a7c16e9b6478a94e02fc/packages/terra-popup/src/_PopupContent.jsx#L124\r\n\r\n"}}
{"actor":{"display_login":"neilpfeiffer"}}