{"action":"created","issue":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1282","repository_url":"https://api.github.com/repos/broadinstitute/firecloud-ui","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1282/labels{/name}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1282/comments","events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1282/events","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/1282","id":317291739,"number":1282,"title":"Refactor MethodConfigSpec","user":{"login":"aweng98","id":35533885,"avatar_url":"https://avatars2.githubusercontent.com/u/35533885?v=4","gravatar_id":"","url":"https://api.github.com/users/aweng98","html_url":"https://github.com/aweng98","followers_url":"https://api.github.com/users/aweng98/followers","following_url":"https://api.github.com/users/aweng98/following{/other_user}","gists_url":"https://api.github.com/users/aweng98/gists{/gist_id}","starred_url":"https://api.github.com/users/aweng98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweng98/subscriptions","organizations_url":"https://api.github.com/users/aweng98/orgs","repos_url":"https://api.github.com/users/aweng98/repos","events_url":"https://api.github.com/users/aweng98/events{/privacy}","received_events_url":"https://api.github.com/users/aweng98/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-24T15:58:16Z","updated_at":"2018-04-24T16:14:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1282","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/1282","diff_url":"https://github.com/broadinstitute/firecloud-ui/pull/1282.diff","patch_url":"https://github.com/broadinstitute/firecloud-ui/pull/1282.patch"},"body":"- [ ] **Submitter**: Include the JIRA issue number in the PR description\r\n- [ ] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [ ] **Submitter**: If you changed a URL that is used elsewhere (e.g. in an email), comment about where it is used and ensure the dependent code is updated.\r\n- [ ] **Submitter**: JIRA ticket checks:\r\n  * Acceptance criteria exists and is met\r\n  * Note any changes to implementation from the description\r\n  * To Demo flag is set\r\n  * Release Summary is filled out, if applicable\r\n  * Add notes on how to QA\r\n- [ ] **Submitter**: Update RC_XXX release ticket with any config or environment changes necessary\r\n- [ ] **Submitter**: Update FISMA documentation if changes to:\r\n  * Authentication\r\n  * Authorization\r\n  * Encryption\r\n  * Audit trails\r\n- [ ] **Submitter**: If you're adding new libraries, sign us up to security updates for them\r\n- [ ] **Submitter**: If you're adding new automated UI tests, review the test plan with QA\r\n* Review cycle:\r\n  * LR reviews\r\n  * Rest of team may comment on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH\r\n  * Submitter updates documentation as needed\r\n  * Submitter **reassigns to LR** for further feedback\r\n- [ ] **TL** sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Product Owner** sign off\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests and automated UI tests.\r\n- [ ] **Submitter**: Squash commits and merge to develop. If adding test code, merge application code and test code at the same time.\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n"},"comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/comments/383991558","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/1282#issuecomment-383991558","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1282","id":383991558,"user":{"login":"aweng98","id":35533885,"avatar_url":"https://avatars2.githubusercontent.com/u/35533885?v=4","gravatar_id":"","url":"https://api.github.com/users/aweng98","html_url":"https://github.com/aweng98","followers_url":"https://api.github.com/users/aweng98/followers","following_url":"https://api.github.com/users/aweng98/following{/other_user}","gists_url":"https://api.github.com/users/aweng98/gists{/gist_id}","starred_url":"https://api.github.com/users/aweng98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweng98/subscriptions","organizations_url":"https://api.github.com/users/aweng98/orgs","repos_url":"https://api.github.com/users/aweng98/repos","events_url":"https://api.github.com/users/aweng98/events{/privacy}","received_events_url":"https://api.github.com/users/aweng98/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T16:14:40Z","updated_at":"2018-04-24T16:14:40Z","author_association":"CONTRIBUTOR","body":"To have two smaller test files:\r\n1) Per QA OKRs, no single test file should be running longer than 10 minutes alone. A single large test file should be refactored into smaller test files, per test feature.\r\n2) Use `withMethod` to create new method so tests cross contamination don't happen.\r\n3) Run more tests in parallel that leverage multiple chrome nodes"}}
{"actor":{"display_login":"aweng98"}}