{"action":"created","issue":{"url":"https://api.github.com/repos/storybooks/storybook/issues/3531","repository_url":"https://api.github.com/repos/storybooks/storybook","labels_url":"https://api.github.com/repos/storybooks/storybook/issues/3531/labels{/name}","comments_url":"https://api.github.com/repos/storybooks/storybook/issues/3531/comments","events_url":"https://api.github.com/repos/storybooks/storybook/issues/3531/events","html_url":"https://github.com/storybooks/storybook/pull/3531","id":320430419,"number":3531,"title":"Ignore home package.json no license field","user":{"login":"Keraito","id":5955441,"avatar_url":"https://avatars1.githubusercontent.com/u/5955441?v=4","gravatar_id":"","url":"https://api.github.com/users/Keraito","html_url":"https://github.com/Keraito","followers_url":"https://api.github.com/users/Keraito/followers","following_url":"https://api.github.com/users/Keraito/following{/other_user}","gists_url":"https://api.github.com/users/Keraito/gists{/gist_id}","starred_url":"https://api.github.com/users/Keraito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keraito/subscriptions","organizations_url":"https://api.github.com/users/Keraito/orgs","repos_url":"https://api.github.com/users/Keraito/repos","events_url":"https://api.github.com/users/Keraito/events{/privacy}","received_events_url":"https://api.github.com/users/Keraito/received_events","type":"User","site_admin":false},"labels":[{"id":343576454,"url":"https://api.github.com/repos/storybooks/storybook/labels/bug","name":"bug","color":"EB484F","default":true},{"id":603520516,"url":"https://api.github.com/repos/storybooks/storybook/labels/cli","name":"cli","color":"fbca04","default":false},{"id":786624925,"url":"https://api.github.com/repos/storybooks/storybook/labels/patch","name":"patch","color":"09e55d","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-05-04T21:06:47Z","updated_at":"2018-05-05T14:28:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/storybooks/storybook/pulls/3531","html_url":"https://github.com/storybooks/storybook/pull/3531","diff_url":"https://github.com/storybooks/storybook/pull/3531.diff","patch_url":"https://github.com/storybooks/storybook/pull/3531.patch"},"body":"Issue: Fixes #3446 \r\n\r\nIf the `/home/user` folder contained a `package.json` without a `license` field, the installation of `getstorybook` is cancelled. This warning is thrown regardless of anything in the current folder that you're running `getstorybook` in. \r\n\r\nReproduction would be to [create a package.json without a license field in your home directory](https://github.com/storybooks/storybook/issues/3446#issuecomment-382553884), initialize a project that would normally work with `getstorybook`, like through `create-react-app`, and then run `getstorybook`.\r\n\r\nThis is caused by the [checking of the version of the generator dependencies](https://github.com/storybooks/storybook/blob/master/lib/cli/lib/latest_version.js#L8) which resulted in the warning being thrown and thus existing the installation at https://github.com/storybooks/storybook/blob/3539625d7f801a0fee1fb8c58f1ff57016c9513f/lib/cli/lib/latest_version.js#L34\r\n(Thanks to @sunilhari for pointing this out).  \r\nIn fact, if you for whatever reason have a `package.json` at your home directory without a `license` field (or anywhere along the path towards the current directory), the warning will be thrown at any `yarn` command. The result of actually running the command, however, is then outputted after the warning:\r\n![image](https://user-images.githubusercontent.com/5955441/39652736-d4804b14-4fee-11e8-9132-9e07ac858c8c.png)\r\n\r\n## What I did\r\nUsing the knowledge from the screenshot above, I basically added an array of warning texts that will not stop the entire installation process.\r\n\r\nThis fix is entirely based on `yarn` and I did not check yet how this works with `npm` and if there are any differences. But I wanted to open this PR in order to see whether this solution is desired before spending more time on it."},"comment":{"url":"https://api.github.com/repos/storybooks/storybook/issues/comments/386809487","html_url":"https://github.com/storybooks/storybook/pull/3531#issuecomment-386809487","issue_url":"https://api.github.com/repos/storybooks/storybook/issues/3531","id":386809487,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-05-05T14:28:33Z","updated_at":"2018-05-05T14:28:33Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/storybooks/storybook/pull/3531?src=pr&el=h1) Report\n> Merging [#3531](https://codecov.io/gh/storybooks/storybook/pull/3531?src=pr&el=desc) into [master](https://codecov.io/gh/storybooks/storybook/commit/3539625d7f801a0fee1fb8c58f1ff57016c9513f?src=pr&el=desc) will **decrease** coverage by `0.01%`.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/storybooks/storybook/pull/3531/graphs/tree.svg?src=pr&token=cVp0HBIrZl&width=650&height=150)](https://codecov.io/gh/storybooks/storybook/pull/3531?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master   #3531      +/-   ##\n=========================================\n- Coverage   37.61%   37.6%   -0.02%     \n=========================================\n  Files         459     460       +1     \n  Lines       10377   10380       +3     \n  Branches      928     930       +2     \n=========================================\n  Hits         3903    3903              \n+ Misses       5932    5927       -5     \n- Partials      542     550       +8\n```\n\n\n| [Impacted Files](https://codecov.io/gh/storybooks/storybook/pull/3531?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [lib/cli/lib/latest\\_version.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-bGliL2NsaS9saWIvbGF0ZXN0X3ZlcnNpb24uanM=) | `0% <0%> (ø)` | :arrow_up: |\n| [lib/cli/lib/whitelisted\\_warnings.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-bGliL2NsaS9saWIvd2hpdGVsaXN0ZWRfd2FybmluZ3MuanM=) | `0% <0%> (ø)` | |\n| [...-native/src/preview/components/OnDeviceUI/index.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-YXBwL3JlYWN0LW5hdGl2ZS9zcmMvcHJldmlldy9jb21wb25lbnRzL09uRGV2aWNlVUkvaW5kZXguanM=) | `0% <0%> (ø)` | :arrow_up: |\n| [addons/jest/src/components/Result.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-YWRkb25zL2plc3Qvc3JjL2NvbXBvbmVudHMvUmVzdWx0Lmpz) | `0% <0%> (ø)` | :arrow_up: |\n| [lib/core/src/server/config/env.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-bGliL2NvcmUvc3JjL3NlcnZlci9jb25maWcvZW52Lmpz) | `80% <0%> (ø)` | :arrow_up: |\n| [app/react-native/src/server/addons.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-YXBwL3JlYWN0LW5hdGl2ZS9zcmMvc2VydmVyL2FkZG9ucy5qcw==) | `0% <0%> (ø)` | :arrow_up: |\n| [lib/ui/src/modules/ui/libs/filters.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-bGliL3VpL3NyYy9tb2R1bGVzL3VpL2xpYnMvZmlsdGVycy5qcw==) | `48.64% <0%> (ø)` | :arrow_up: |\n| [addons/info/src/components/makeTableComponent.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-YWRkb25zL2luZm8vc3JjL2NvbXBvbmVudHMvbWFrZVRhYmxlQ29tcG9uZW50Lmpz) | `67.46% <0%> (ø)` | :arrow_up: |\n| [addons/events/src/components/Event.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-YWRkb25zL2V2ZW50cy9zcmMvY29tcG9uZW50cy9FdmVudC5qcw==) | `0% <0%> (ø)` | :arrow_up: |\n| [addons/storyshots/src/rn/loader.js](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree#diff-YWRkb25zL3N0b3J5c2hvdHMvc3JjL3JuL2xvYWRlci5qcw==) | `53.33% <0%> (ø)` | :arrow_up: |\n| ... and [64 more](https://codecov.io/gh/storybooks/storybook/pull/3531/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/storybooks/storybook/pull/3531?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/storybooks/storybook/pull/3531?src=pr&el=footer). Last update [3539625...56244b2](https://codecov.io/gh/storybooks/storybook/pull/3531?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}