{"action":"created","issue":{"url":"https://api.github.com/repos/dataforgoodfr/batch_5_transplant/issues/30","repository_url":"https://api.github.com/repos/dataforgoodfr/batch_5_transplant","labels_url":"https://api.github.com/repos/dataforgoodfr/batch_5_transplant/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/dataforgoodfr/batch_5_transplant/issues/30/comments","events_url":"https://api.github.com/repos/dataforgoodfr/batch_5_transplant/issues/30/events","html_url":"https://github.com/dataforgoodfr/batch_5_transplant/pull/30","id":388225152,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTM4Nzg5","number":30,"title":"Armand dataviz tools","user":{"login":"armgilles","id":8374843,"node_id":"MDQ6VXNlcjgzNzQ4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8374843?v=4","gravatar_id":"","url":"https://api.github.com/users/armgilles","html_url":"https://github.com/armgilles","followers_url":"https://api.github.com/users/armgilles/followers","following_url":"https://api.github.com/users/armgilles/following{/other_user}","gists_url":"https://api.github.com/users/armgilles/gists{/gist_id}","starred_url":"https://api.github.com/users/armgilles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armgilles/subscriptions","organizations_url":"https://api.github.com/users/armgilles/orgs","repos_url":"https://api.github.com/users/armgilles/repos","events_url":"https://api.github.com/users/armgilles/events{/privacy}","received_events_url":"https://api.github.com/users/armgilles/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-06T13:57:22Z","updated_at":"2018-12-06T14:20:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dataforgoodfr/batch_5_transplant/pulls/30","html_url":"https://github.com/dataforgoodfr/batch_5_transplant/pull/30","diff_url":"https://github.com/dataforgoodfr/batch_5_transplant/pull/30.diff","patch_url":"https://github.com/dataforgoodfr/batch_5_transplant/pull/30.patch"},"body":"Cf issue #27 \r\n\r\nCréation d'un tool pour l'analyse de données via graphiques.\r\n\r\n## Utilisation : \r\n\r\n```\r\nfrom transplant.tools.dataset import Dataset\r\nfrom transplant.tools.graph import plot_dynmatic_features\r\nfrom transplant.config import *\r\n\r\n# Get dynamic data from classe Dataset\r\ntrain, test = dataset.get_dynamic()\r\n\r\n# Concat train & test\r\ndf = pd.concat([train, test])\r\n\r\n# Have fun \r\nplot_dynamic_features(df, 225, DYNAMIC_CATEGORIES['neurology'])\r\n```\r\n![image](https://user-images.githubusercontent.com/8374843/49588045-01fae380-f966-11e8-9947-ee586e1dffdb.png)\r\n\r\n## Scripts : \r\n\r\n- graph.py dans `transplant⁩/tools⁩`\r\n- Pour l'instant il n'y a qu'une fonction.\r\n\r\n## Contraintes : \r\n\r\n- Le graphique ne prend  en compte que les variables numériques.\r\n- Le DataFrame  doit avoir les variables `id_patient` et `time` en colonnes.\r\n- Trop de variables numérique en entrées conduise à un graphique trop plein, utilisé le paramètre `features_list` pour restreindre le nombre de variable à afficher.\r\n\r\n## Environnement de developpement\r\n\r\n- Ajout de plotly dans l'env conda\r\n- Ajout de plotly dans `requirement.txt`\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dataforgoodfr/batch_5_transplant/issues/comments/444886096","html_url":"https://github.com/dataforgoodfr/batch_5_transplant/pull/30#issuecomment-444886096","issue_url":"https://api.github.com/repos/dataforgoodfr/batch_5_transplant/issues/30","id":444886096,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDg4NjA5Ng==","user":{"login":"martindaniel4","id":695006,"node_id":"MDQ6VXNlcjY5NTAwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/695006?v=4","gravatar_id":"","url":"https://api.github.com/users/martindaniel4","html_url":"https://github.com/martindaniel4","followers_url":"https://api.github.com/users/martindaniel4/followers","following_url":"https://api.github.com/users/martindaniel4/following{/other_user}","gists_url":"https://api.github.com/users/martindaniel4/gists{/gist_id}","starred_url":"https://api.github.com/users/martindaniel4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martindaniel4/subscriptions","organizations_url":"https://api.github.com/users/martindaniel4/orgs","repos_url":"https://api.github.com/users/martindaniel4/repos","events_url":"https://api.github.com/users/martindaniel4/events{/privacy}","received_events_url":"https://api.github.com/users/martindaniel4/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T14:20:58Z","updated_at":"2018-12-06T14:20:58Z","author_association":"CONTRIBUTOR","body":"Yep je suis d'accord avec @julamb. On pourrait simplifier en `plot_dynamic()` du coup. \r\n\r\nQue pensez vous de l'idée d'avoir un objet `Patient` du coup? Ou alors d'ajouter un `id_patient` comme variable de `Dataset`?  Genre: \r\n\r\n```\r\nfrom transplant.tools.patient import Patient\r\n\r\np = Patient(id=401)\r\np.plot_dynamic()\r\n\r\n```"}}
{"actor":{"display_login":"martindaniel4"}}