{"action":"closed","number":470,"pull_request":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls/470","id":212123850,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTIzODUw","html_url":"https://github.com/Esri/arcgis-runtime-samples-ios/pull/470","diff_url":"https://github.com/Esri/arcgis-runtime-samples-ios/pull/470.diff","patch_url":"https://github.com/Esri/arcgis-runtime-samples-ios/pull/470.patch","issue_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/issues/470","number":470,"state":"closed","locked":false,"title":"Changes class-only protocols to inherit from AnyObject rather than class","user":{"login":"qsmmorgan","id":42748837,"node_id":"MDQ6VXNlcjQyNzQ4ODM3","avatar_url":"https://avatars3.githubusercontent.com/u/42748837?v=4","gravatar_id":"","url":"https://api.github.com/users/qsmmorgan","html_url":"https://github.com/qsmmorgan","followers_url":"https://api.github.com/users/qsmmorgan/followers","following_url":"https://api.github.com/users/qsmmorgan/following{/other_user}","gists_url":"https://api.github.com/users/qsmmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/qsmmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsmmorgan/subscriptions","organizations_url":"https://api.github.com/users/qsmmorgan/orgs","repos_url":"https://api.github.com/users/qsmmorgan/repos","events_url":"https://api.github.com/users/qsmmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/qsmmorgan/received_events","type":"User","site_admin":false},"body":"As per [best practices](https://docs.swift.org/swift-book/LanguageGuide/Protocols.html#ID281), I changed protocols limited to classes to inherit from AnyObject, as in `protocol MyObjectDelegate: AnyObject { … }` rather than from class, as in `protocol MyObjectDelegate: class { … }`.","created_at":"2018-08-30T15:39:00Z","updated_at":"2018-08-30T17:12:11Z","closed_at":"2018-08-30T17:12:11Z","merged_at":"2018-08-30T17:12:11Z","merge_commit_sha":"9f069fe307a0ccc2d892102398684ef0e5912cf9","assignee":{"login":"qsmmorgan","id":42748837,"node_id":"MDQ6VXNlcjQyNzQ4ODM3","avatar_url":"https://avatars3.githubusercontent.com/u/42748837?v=4","gravatar_id":"","url":"https://api.github.com/users/qsmmorgan","html_url":"https://github.com/qsmmorgan","followers_url":"https://api.github.com/users/qsmmorgan/followers","following_url":"https://api.github.com/users/qsmmorgan/following{/other_user}","gists_url":"https://api.github.com/users/qsmmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/qsmmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsmmorgan/subscriptions","organizations_url":"https://api.github.com/users/qsmmorgan/orgs","repos_url":"https://api.github.com/users/qsmmorgan/repos","events_url":"https://api.github.com/users/qsmmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/qsmmorgan/received_events","type":"User","site_admin":false},"assignees":[{"login":"qsmmorgan","id":42748837,"node_id":"MDQ6VXNlcjQyNzQ4ODM3","avatar_url":"https://avatars3.githubusercontent.com/u/42748837?v=4","gravatar_id":"","url":"https://api.github.com/users/qsmmorgan","html_url":"https://github.com/qsmmorgan","followers_url":"https://api.github.com/users/qsmmorgan/followers","following_url":"https://api.github.com/users/qsmmorgan/following{/other_user}","gists_url":"https://api.github.com/users/qsmmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/qsmmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsmmorgan/subscriptions","organizations_url":"https://api.github.com/users/qsmmorgan/orgs","repos_url":"https://api.github.com/users/qsmmorgan/repos","events_url":"https://api.github.com/users/qsmmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/qsmmorgan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls/470/commits","review_comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls/470/comments","review_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/issues/470/comments","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/statuses/b61d3323f4066a0948c6a4b8e1050b59bb25da53","head":{"label":"qsmmorgan:qsmmorgan/class-protocol-anyobject-inheritance","ref":"qsmmorgan/class-protocol-anyobject-inheritance","sha":"b61d3323f4066a0948c6a4b8e1050b59bb25da53","user":{"login":"qsmmorgan","id":42748837,"node_id":"MDQ6VXNlcjQyNzQ4ODM3","avatar_url":"https://avatars3.githubusercontent.com/u/42748837?v=4","gravatar_id":"","url":"https://api.github.com/users/qsmmorgan","html_url":"https://github.com/qsmmorgan","followers_url":"https://api.github.com/users/qsmmorgan/followers","following_url":"https://api.github.com/users/qsmmorgan/following{/other_user}","gists_url":"https://api.github.com/users/qsmmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/qsmmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsmmorgan/subscriptions","organizations_url":"https://api.github.com/users/qsmmorgan/orgs","repos_url":"https://api.github.com/users/qsmmorgan/repos","events_url":"https://api.github.com/users/qsmmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/qsmmorgan/received_events","type":"User","site_admin":false},"repo":{"id":146651145,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NTExNDU=","name":"arcgis-runtime-samples-ios","full_name":"qsmmorgan/arcgis-runtime-samples-ios","owner":{"login":"qsmmorgan","id":42748837,"node_id":"MDQ6VXNlcjQyNzQ4ODM3","avatar_url":"https://avatars3.githubusercontent.com/u/42748837?v=4","gravatar_id":"","url":"https://api.github.com/users/qsmmorgan","html_url":"https://github.com/qsmmorgan","followers_url":"https://api.github.com/users/qsmmorgan/followers","following_url":"https://api.github.com/users/qsmmorgan/following{/other_user}","gists_url":"https://api.github.com/users/qsmmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/qsmmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsmmorgan/subscriptions","organizations_url":"https://api.github.com/users/qsmmorgan/orgs","repos_url":"https://api.github.com/users/qsmmorgan/repos","events_url":"https://api.github.com/users/qsmmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/qsmmorgan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qsmmorgan/arcgis-runtime-samples-ios","description":"Swift samples demonstrating various capabilities of ArcGIS Runtime SDK for iOS","fork":true,"url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios","forks_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/forks","keys_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/teams","hooks_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/hooks","issue_events_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/issues/events{/number}","events_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/events","assignees_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/assignees{/user}","branches_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/branches{/branch}","tags_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/tags","blobs_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/languages","stargazers_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/stargazers","contributors_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/contributors","subscribers_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/subscribers","subscription_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/subscription","commits_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/contents/{+path}","compare_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/merges","archive_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/downloads","issues_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/issues{/number}","pulls_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/labels{/name}","releases_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/releases{/id}","deployments_url":"https://api.github.com/repos/qsmmorgan/arcgis-runtime-samples-ios/deployments","created_at":"2018-08-29T19:56:15Z","updated_at":"2018-08-29T19:56:21Z","pushed_at":"2018-08-30T15:34:12Z","git_url":"git://github.com/qsmmorgan/arcgis-runtime-samples-ios.git","ssh_url":"git@github.com:qsmmorgan/arcgis-runtime-samples-ios.git","clone_url":"https://github.com/qsmmorgan/arcgis-runtime-samples-ios.git","svn_url":"https://github.com/qsmmorgan/arcgis-runtime-samples-ios","homepage":"http://developers.arcgis.com/en/ios/","size":396179,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Esri:v.next","ref":"v.next","sha":"b2cd9bfe76f1f7fa90a53ffffc000f6a74cd9b68","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":7922900,"node_id":"MDEwOlJlcG9zaXRvcnk3OTIyOTAw","name":"arcgis-runtime-samples-ios","full_name":"Esri/arcgis-runtime-samples-ios","owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/arcgis-runtime-samples-ios","description":"Swift samples demonstrating various capabilities of ArcGIS Runtime SDK for iOS","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/deployments","created_at":"2013-01-30T20:18:40Z","updated_at":"2018-08-29T19:16:52Z","pushed_at":"2018-08-30T17:12:11Z","git_url":"git://github.com/Esri/arcgis-runtime-samples-ios.git","ssh_url":"git@github.com:Esri/arcgis-runtime-samples-ios.git","clone_url":"https://github.com/Esri/arcgis-runtime-samples-ios.git","svn_url":"https://github.com/Esri/arcgis-runtime-samples-ios","homepage":"http://developers.arcgis.com/en/ios/","size":396206,"stargazers_count":221,"watchers_count":221,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":347,"open_issues":31,"watchers":221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls/470"},"html":{"href":"https://github.com/Esri/arcgis-runtime-samples-ios/pull/470"},"issue":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/issues/470"},"comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/issues/470/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls/470/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/pulls/470/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-ios/statuses/b61d3323f4066a0948c6a4b8e1050b59bb25da53"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"qsmmorgan","id":42748837,"node_id":"MDQ6VXNlcjQyNzQ4ODM3","avatar_url":"https://avatars3.githubusercontent.com/u/42748837?v=4","gravatar_id":"","url":"https://api.github.com/users/qsmmorgan","html_url":"https://github.com/qsmmorgan","followers_url":"https://api.github.com/users/qsmmorgan/followers","following_url":"https://api.github.com/users/qsmmorgan/following{/other_user}","gists_url":"https://api.github.com/users/qsmmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/qsmmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsmmorgan/subscriptions","organizations_url":"https://api.github.com/users/qsmmorgan/orgs","repos_url":"https://api.github.com/users/qsmmorgan/repos","events_url":"https://api.github.com/users/qsmmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/qsmmorgan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":33,"deletions":33,"changed_files":33}}
{"actor":{"display_login":"qsmmorgan"}}