{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/comments/242033355","pull_request_review_id":185448232,"id":242033355,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjAzMzM1NQ==","diff_hunk":"@@ -69,10 +69,25 @@ export default class TopAppBar extends React.Component {\n     this.foundation_.destroy();\n   }\n \n+  componentDidUpdate(prevProps) {\n+    const foundationChanged = ['short', 'shortCollapsed', 'fixed']\n+      .some((variant) => this.props[variant] !== prevProps[variant] );","path":"packages/top-app-bar/index.js","position":6,"original_position":6,"commit_id":"1cebcef77a9c61a339b56e7be24765e45d42b324","original_commit_id":"1cebcef77a9c61a339b56e7be24765e45d42b324","user":{"login":"moog16","id":579873,"node_id":"MDQ6VXNlcjU3OTg3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/579873?v=4","gravatar_id":"","url":"https://api.github.com/users/moog16","html_url":"https://github.com/moog16","followers_url":"https://api.github.com/users/moog16/followers","following_url":"https://api.github.com/users/moog16/following{/other_user}","gists_url":"https://api.github.com/users/moog16/gists{/gist_id}","starred_url":"https://api.github.com/users/moog16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moog16/subscriptions","organizations_url":"https://api.github.com/users/moog16/orgs","repos_url":"https://api.github.com/users/moog16/repos","events_url":"https://api.github.com/users/moog16/events{/privacy}","received_events_url":"https://api.github.com/users/moog16/received_events","type":"User","site_admin":false},"body":"formatting issue, but for the sake of time I'm going to ignore this one and fix in a following pr","created_at":"2018-12-17T06:05:05Z","updated_at":"2018-12-17T06:05:05Z","html_url":"https://github.com/material-components/material-components-web-react/pull/519#discussion_r242033355","pull_request_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/519","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/comments/242033355"},"html":{"href":"https://github.com/material-components/material-components-web-react/pull/519#discussion_r242033355"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/519"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/519","id":238548271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTQ4Mjcx","html_url":"https://github.com/material-components/material-components-web-react/pull/519","diff_url":"https://github.com/material-components/material-components-web-react/pull/519.diff","patch_url":"https://github.com/material-components/material-components-web-react/pull/519.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/519","number":519,"state":"open","locked":false,"title":"fix(top-app-bar): foundation should be destroyed and reinitialized on variant change","user":{"login":"mgr34","id":9339171,"node_id":"MDQ6VXNlcjkzMzkxNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9339171?v=4","gravatar_id":"","url":"https://api.github.com/users/mgr34","html_url":"https://github.com/mgr34","followers_url":"https://api.github.com/users/mgr34/followers","following_url":"https://api.github.com/users/mgr34/following{/other_user}","gists_url":"https://api.github.com/users/mgr34/gists{/gist_id}","starred_url":"https://api.github.com/users/mgr34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgr34/subscriptions","organizations_url":"https://api.github.com/users/mgr34/orgs","repos_url":"https://api.github.com/users/mgr34/repos","events_url":"https://api.github.com/users/mgr34/events{/privacy}","received_events_url":"https://api.github.com/users/mgr34/received_events","type":"User","site_admin":false},"body":"this should close issue #517. hope I didn't go overboard on the unit tests.  As noted in discord I am having trouble getting screenshot tests to run. I have added a new one.\r\n\r\n---\r\n\r\nI signed it","created_at":"2018-12-13T22:08:22Z","updated_at":"2018-12-17T06:05:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30b3c0c80696be907dbacf24cff41aa4733364f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/519/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/519/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/519/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web-react/statuses/1cebcef77a9c61a339b56e7be24765e45d42b324","head":{"label":"mgr34:fix/top-app-bar/variant-change","ref":"fix/top-app-bar/variant-change","sha":"1cebcef77a9c61a339b56e7be24765e45d42b324","user":{"login":"mgr34","id":9339171,"node_id":"MDQ6VXNlcjkzMzkxNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9339171?v=4","gravatar_id":"","url":"https://api.github.com/users/mgr34","html_url":"https://github.com/mgr34","followers_url":"https://api.github.com/users/mgr34/followers","following_url":"https://api.github.com/users/mgr34/following{/other_user}","gists_url":"https://api.github.com/users/mgr34/gists{/gist_id}","starred_url":"https://api.github.com/users/mgr34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgr34/subscriptions","organizations_url":"https://api.github.com/users/mgr34/orgs","repos_url":"https://api.github.com/users/mgr34/repos","events_url":"https://api.github.com/users/mgr34/events{/privacy}","received_events_url":"https://api.github.com/users/mgr34/received_events","type":"User","site_admin":false},"repo":{"id":161538359,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE1MzgzNTk=","name":"material-components-web-react","full_name":"mgr34/material-components-web-react","private":false,"owner":{"login":"mgr34","id":9339171,"node_id":"MDQ6VXNlcjkzMzkxNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9339171?v=4","gravatar_id":"","url":"https://api.github.com/users/mgr34","html_url":"https://github.com/mgr34","followers_url":"https://api.github.com/users/mgr34/followers","following_url":"https://api.github.com/users/mgr34/following{/other_user}","gists_url":"https://api.github.com/users/mgr34/gists{/gist_id}","starred_url":"https://api.github.com/users/mgr34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgr34/subscriptions","organizations_url":"https://api.github.com/users/mgr34/orgs","repos_url":"https://api.github.com/users/mgr34/repos","events_url":"https://api.github.com/users/mgr34/events{/privacy}","received_events_url":"https://api.github.com/users/mgr34/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mgr34/material-components-web-react","description":"Material Components for React (MDC React)","fork":true,"url":"https://api.github.com/repos/mgr34/material-components-web-react","forks_url":"https://api.github.com/repos/mgr34/material-components-web-react/forks","keys_url":"https://api.github.com/repos/mgr34/material-components-web-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgr34/material-components-web-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgr34/material-components-web-react/teams","hooks_url":"https://api.github.com/repos/mgr34/material-components-web-react/hooks","issue_events_url":"https://api.github.com/repos/mgr34/material-components-web-react/issues/events{/number}","events_url":"https://api.github.com/repos/mgr34/material-components-web-react/events","assignees_url":"https://api.github.com/repos/mgr34/material-components-web-react/assignees{/user}","branches_url":"https://api.github.com/repos/mgr34/material-components-web-react/branches{/branch}","tags_url":"https://api.github.com/repos/mgr34/material-components-web-react/tags","blobs_url":"https://api.github.com/repos/mgr34/material-components-web-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgr34/material-components-web-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgr34/material-components-web-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgr34/material-components-web-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgr34/material-components-web-react/statuses/{sha}","languages_url":"https://api.github.com/repos/mgr34/material-components-web-react/languages","stargazers_url":"https://api.github.com/repos/mgr34/material-components-web-react/stargazers","contributors_url":"https://api.github.com/repos/mgr34/material-components-web-react/contributors","subscribers_url":"https://api.github.com/repos/mgr34/material-components-web-react/subscribers","subscription_url":"https://api.github.com/repos/mgr34/material-components-web-react/subscription","commits_url":"https://api.github.com/repos/mgr34/material-components-web-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgr34/material-components-web-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgr34/material-components-web-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgr34/material-components-web-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgr34/material-components-web-react/contents/{+path}","compare_url":"https://api.github.com/repos/mgr34/material-components-web-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgr34/material-components-web-react/merges","archive_url":"https://api.github.com/repos/mgr34/material-components-web-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgr34/material-components-web-react/downloads","issues_url":"https://api.github.com/repos/mgr34/material-components-web-react/issues{/number}","pulls_url":"https://api.github.com/repos/mgr34/material-components-web-react/pulls{/number}","milestones_url":"https://api.github.com/repos/mgr34/material-components-web-react/milestones{/number}","notifications_url":"https://api.github.com/repos/mgr34/material-components-web-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgr34/material-components-web-react/labels{/name}","releases_url":"https://api.github.com/repos/mgr34/material-components-web-react/releases{/id}","deployments_url":"https://api.github.com/repos/mgr34/material-components-web-react/deployments","created_at":"2018-12-12T19:58:52Z","updated_at":"2018-12-12T19:58:55Z","pushed_at":"2018-12-16T22:14:22Z","git_url":"git://github.com/mgr34/material-components-web-react.git","ssh_url":"git@github.com:mgr34/material-components-web-react.git","clone_url":"https://github.com/mgr34/material-components-web-react.git","svn_url":"https://github.com/mgr34/material-components-web-react","homepage":"","size":3572,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"material-components:rc0.8.0","ref":"rc0.8.0","sha":"33fb5004515e6c6e5e3fd65ac678a6f1267a6a1e","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":124129430,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxMjk0MzA=","name":"material-components-web-react","full_name":"material-components/material-components-web-react","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web-react","description":"Material Components for React (MDC React)","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web-react","forks_url":"https://api.github.com/repos/material-components/material-components-web-react/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web-react/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web-react/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web-react/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web-react/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web-react/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web-react/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web-react/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web-react/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web-react/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web-react/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web-react/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web-react/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web-react/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web-react/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web-react/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web-react/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web-react/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web-react/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web-react/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web-react/deployments","created_at":"2018-03-06T19:42:24Z","updated_at":"2018-12-16T21:24:32Z","pushed_at":"2018-12-17T05:59:29Z","git_url":"git://github.com/material-components/material-components-web-react.git","ssh_url":"git@github.com:material-components/material-components-web-react.git","clone_url":"https://github.com/material-components/material-components-web-react.git","svn_url":"https://github.com/material-components/material-components-web-react","homepage":"","size":3690,"stargazers_count":920,"watchers_count":920,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":105,"open_issues":87,"watchers":920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/519"},"html":{"href":"https://github.com/material-components/material-components-web-react/pull/519"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web-react/issues/519"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web-react/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web-react/statuses/1cebcef77a9c61a339b56e7be24765e45d42b324"}},"author_association":"NONE"}}
{"actor":{"display_login":"moog16"}}