{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/216329502","pull_request_review_id":153783845,"id":216329502,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjMyOTUwMg==","diff_hunk":"@@ -163,7 +164,10 @@ dist: writeversion staticdeps staticdeps-cext buildconfig assets translation-dja\n pex: writeversion\n \tls dist/*.whl | while read whlfile; do pex $$whlfile --disable-cache -o dist/kolibri-`cat kolibri/VERSION | sed 's/+/_/g'`.pex -m kolibri --python-shebang=/usr/bin/python; done\n \n-translation-extract: assets\n+translation-extract: clean-build\n+\t@echo \"\"\n+\t@echo \"!! This assumes that you are running with latest assets. Run 'make assets' if in doubt !!\"\n+\t@echo \"\"","path":"Makefile","position":15,"original_position":15,"commit_id":"7819742da350e40a338f4745a30344185008bda4","original_commit_id":"7819742da350e40a338f4745a30344185008bda4","user":{"login":"benjaoming","id":374612,"node_id":"MDQ6VXNlcjM3NDYxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/374612?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"body":"Oh, it is a pre-requisite for messages to display in English (the source language) ?","created_at":"2018-09-10T13:52:55Z","updated_at":"2018-09-10T13:52:56Z","html_url":"https://github.com/learningequality/kolibri/pull/4121#discussion_r216329502","pull_request_url":"https://api.github.com/repos/learningequality/kolibri/pulls/4121","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/216329502"},"html":{"href":"https://github.com/learningequality/kolibri/pull/4121#discussion_r216329502"},"pull_request":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/4121"}},"in_reply_to_id":216178172},"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/4121","id":206849479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODQ5NDc5","html_url":"https://github.com/learningequality/kolibri/pull/4121","diff_url":"https://github.com/learningequality/kolibri/pull/4121.diff","patch_url":"https://github.com/learningequality/kolibri/pull/4121.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/4121","number":4121,"state":"closed","locked":false,"title":"Maintain source translation files in git + update languages for 0.10.x","user":{"login":"benjaoming","id":374612,"node_id":"MDQ6VXNlcjM3NDYxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/374612?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nVery few translations have been missing in 0.10 - guaranteed missing from builds from a clean environments.\r\n\r\nShipped translations originate from 0.10, so there are just very few translations missing.\r\n\r\nCause of issue: We did not have any source translation files in the repo, and they didn't get generated when downloading from CrowdIn. So a clean checkout would lack the source language, and the CrowdIn CLI would not be able to pattern match the contents of the empty `kolibri/local/en`\r\n\r\n- [x] update Make target `translation-crowdin-download`\r\n- [x] add new translations\r\n\r\n### Reviewer guidance\r\n\r\nn/a - anything I don't get here?\r\n\r\nIn my experience, it's totally conventional practice to maintain source languages in a repo :)\r\n\r\n### References\r\n\r\nDon't think we opened issues, but @radinamatic flagged this many times :)\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [ ] Contributor has fully tested the PR manually\r\n- [ ] PR has the correct target branch and milestone\r\n- [ ] PR has 'needs review' or 'work-in-progress' label\r\n- [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [ ] If there are any front-end changes, before/after screenshots are included\r\n- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n","created_at":"2018-08-07T22:59:44Z","updated_at":"2018-09-10T13:52:56Z","closed_at":"2018-08-15T16:55:20Z","merged_at":"2018-08-15T16:55:20Z","merge_commit_sha":"5216fc32f6328d7bab2d56361a76dd8503351f05","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":493378585,"node_id":"MDU6TGFiZWw0OTMzNzg1ODU=","url":"https://api.github.com/repos/learningequality/kolibri/labels/DEV:%20devops","name":"DEV: devops","color":"DFDFDF","default":false},{"id":732327197,"node_id":"MDU6TGFiZWw3MzIzMjcxOTc=","url":"https://api.github.com/repos/learningequality/kolibri/labels/DEV:%20distributions","name":"DEV: distributions","color":"dfdfdf","default":false},{"id":667034570,"node_id":"MDU6TGFiZWw2NjcwMzQ1NzA=","url":"https://api.github.com/repos/learningequality/kolibri/labels/P0%20-%20critical","name":"P0 - critical","color":"ff6600","default":false},{"id":410338552,"node_id":"MDU6TGFiZWw0MTAzMzg1NTI=","url":"https://api.github.com/repos/learningequality/kolibri/labels/PR:%20needs%20review","name":"PR: needs review","color":"1f6ad6","default":false}],"milestone":{"url":"https://api.github.com/repos/learningequality/kolibri/milestones/28","html_url":"https://github.com/learningequality/kolibri/milestone/28","labels_url":"https://api.github.com/repos/learningequality/kolibri/milestones/28/labels","id":3548522,"node_id":"MDk6TWlsZXN0b25lMzU0ODUyMg==","number":28,"title":"0.10.2","description":null,"creator":{"login":"rtibbles","id":1680573,"node_id":"MDQ6VXNlcjE2ODA1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1680573?v=4","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":13,"state":"closed","created_at":"2018-08-06T09:37:21Z","updated_at":"2018-08-27T13:45:11Z","due_on":null,"closed_at":"2018-08-27T13:45:11Z"},"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/4121/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/4121/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/4121/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/7819742da350e40a338f4745a30344185008bda4","head":{"label":"benjaoming:bug/crowdinconfig","ref":"bug/crowdinconfig","sha":"7819742da350e40a338f4745a30344185008bda4","user":{"login":"benjaoming","id":374612,"node_id":"MDQ6VXNlcjM3NDYxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/374612?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"repo":{"id":50074781,"node_id":"MDEwOlJlcG9zaXRvcnk1MDA3NDc4MQ==","name":"kolibri","full_name":"benjaoming/kolibri","owner":{"login":"benjaoming","id":374612,"node_id":"MDQ6VXNlcjM3NDYxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/374612?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaoming/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":true,"url":"https://api.github.com/repos/benjaoming/kolibri","forks_url":"https://api.github.com/repos/benjaoming/kolibri/forks","keys_url":"https://api.github.com/repos/benjaoming/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaoming/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaoming/kolibri/teams","hooks_url":"https://api.github.com/repos/benjaoming/kolibri/hooks","issue_events_url":"https://api.github.com/repos/benjaoming/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/benjaoming/kolibri/events","assignees_url":"https://api.github.com/repos/benjaoming/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/benjaoming/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/benjaoming/kolibri/tags","blobs_url":"https://api.github.com/repos/benjaoming/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaoming/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaoming/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaoming/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaoming/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaoming/kolibri/languages","stargazers_url":"https://api.github.com/repos/benjaoming/kolibri/stargazers","contributors_url":"https://api.github.com/repos/benjaoming/kolibri/contributors","subscribers_url":"https://api.github.com/repos/benjaoming/kolibri/subscribers","subscription_url":"https://api.github.com/repos/benjaoming/kolibri/subscription","commits_url":"https://api.github.com/repos/benjaoming/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaoming/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaoming/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaoming/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaoming/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/benjaoming/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaoming/kolibri/merges","archive_url":"https://api.github.com/repos/benjaoming/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaoming/kolibri/downloads","issues_url":"https://api.github.com/repos/benjaoming/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/benjaoming/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaoming/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaoming/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaoming/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/benjaoming/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/benjaoming/kolibri/deployments","created_at":"2016-01-21T02:03:13Z","updated_at":"2016-01-21T14:31:46Z","pushed_at":"2018-09-05T12:53:38Z","git_url":"git://github.com/benjaoming/kolibri.git","ssh_url":"git@github.com:benjaoming/kolibri.git","clone_url":"https://github.com/benjaoming/kolibri.git","svn_url":"https://github.com/benjaoming/kolibri","homepage":"http://learningequality.org/kolibri/","size":42985,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"learningequality:release-v0.10.x","ref":"release-v0.10.x","sha":"8d36c187e42db7a226e450b751fca3728a9ccdee","user":{"login":"learningequality","id":3926525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3NjkzOQ==","name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"Kolibri: the offline app for universal education","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2018-09-06T18:59:20Z","pushed_at":"2018-09-10T08:45:02Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":44277,"stargazers_count":196,"watchers_count":196,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":300,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":144,"open_issues":300,"watchers":196,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/4121"},"html":{"href":"https://github.com/learningequality/kolibri/pull/4121"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/4121"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/4121/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/4121/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/4121/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/7819742da350e40a338f4745a30344185008bda4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"benjaoming"}}