{"action":"created","comment":{"url":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/comments/187813577","pull_request_review_id":119666963,"id":187813577,"diff_hunk":"@@ -27,102 +32,98 @@ class ManSea001 : public EventScript\n \n    void Scene00000( Entity::Player& player )\n    {\n-      auto callback = [this]( Entity::Player& player, const Event::SceneResult& result )\n+      player.playScene( m_id, 0, 8192,\n+         [&]( Entity::Player& player, const Event::SceneResult& result )\n       {\n-         if( result.param2 == 1 )\n+         if ( result.param2 == 1 )\n          {\n             player.setOpeningSequence( 2 );\n             Scene00001( player );\n          }\n-      };\n-\n-      player.playScene( getId(), 0, HIDE_HOTBAR, 0, 0, callback );\n+      } );\n    }\n \n    void Scene00001( Entity::Player& player )\n    {\n-      player.playSceneChain( getId(), 1, DISABLE_SKIP | HIDE_HOTBAR | SET_BASE, bindScene( &ManSea001::Scene00002 ) );\n+      player.playSceneChain( m_id, 1, DISABLE_SKIP | HIDE_HOTBAR | SET_BASE, bindScene( &ManSea001::Scene00002 ) );\n    }\n \n    void Scene00002( Entity::Player& player )\n    {\n-      player.playSceneChain( getId(), 2, NONE, bindScene( &ManSea001::Scene00003 ) );\n+      player.updateQuest( m_id, 1 );\n+      player.playSceneChain( m_id, 2, NONE, bindScene( &ManSea001::Scene00003 ) );\n    }\n \n    void Scene00003( Entity::Player& player )\n    {\n-      auto callback = [this]( Entity::Player& player, const Event::SceneResult& result )\n-      {\n-         player.playScene( OPENING_EVENT_HANDLER, 0x1E, HIDE_HOTBAR | NO_DEFAULT_CAMERA, 1, 0 );\n-      };\n-\n-      player.playScene( getId(), 3, NONE, 0, 0, callback );\n+      player.playScene( OPENING_EVENT_HANDLER, 0x1E, HIDE_HOTBAR | NO_DEFAULT_CAMERA, 1, 0 );","path":"src/servers/Scripts/quest/ManSea001.cpp","position":63,"original_position":63,"commit_id":"d2d96581e635a4194b9ab81f2e68183f7c95633b","original_commit_id":"d2d96581e635a4194b9ab81f2e68183f7c95633b","user":{"login":"SapphireMordred","id":30826167,"avatar_url":"https://avatars0.githubusercontent.com/u/30826167?v=4","gravatar_id":"","url":"https://api.github.com/users/SapphireMordred","html_url":"https://github.com/SapphireMordred","followers_url":"https://api.github.com/users/SapphireMordred/followers","following_url":"https://api.github.com/users/SapphireMordred/following{/other_user}","gists_url":"https://api.github.com/users/SapphireMordred/gists{/gist_id}","starred_url":"https://api.github.com/users/SapphireMordred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SapphireMordred/subscriptions","organizations_url":"https://api.github.com/users/SapphireMordred/orgs","repos_url":"https://api.github.com/users/SapphireMordred/repos","events_url":"https://api.github.com/users/SapphireMordred/events{/privacy}","received_events_url":"https://api.github.com/users/SapphireMordred/received_events","type":"User","site_admin":false},"body":"Fact is still that the call Scene0003 make no sense if it is not actually playing scene 3. It logically is flawed. If all it does is call to the opening handler, then sure ( should be named accordingly ) although i bet retail still uses scene3 as dummy to call to the openinghandler just as in gridania opening.","created_at":"2018-05-13T21:18:05Z","updated_at":"2018-05-13T21:18:05Z","html_url":"https://github.com/SapphireMordred/Sapphire/pull/291#discussion_r187813577","pull_request_url":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/291","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/comments/187813577"},"html":{"href":"https://github.com/SapphireMordred/Sapphire/pull/291#discussion_r187813577"},"pull_request":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/291"}},"in_reply_to_id":187794469},"pull_request":{"url":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/291","id":187649411,"html_url":"https://github.com/SapphireMordred/Sapphire/pull/291","diff_url":"https://github.com/SapphireMordred/Sapphire/pull/291.diff","patch_url":"https://github.com/SapphireMordred/Sapphire/pull/291.patch","issue_url":"https://api.github.com/repos/SapphireMordred/Sapphire/issues/291","number":291,"state":"open","locked":false,"title":"ManSea001 now work properly","user":{"login":"DantestyleXD","id":7908668,"avatar_url":"https://avatars1.githubusercontent.com/u/7908668?v=4","gravatar_id":"","url":"https://api.github.com/users/DantestyleXD","html_url":"https://github.com/DantestyleXD","followers_url":"https://api.github.com/users/DantestyleXD/followers","following_url":"https://api.github.com/users/DantestyleXD/following{/other_user}","gists_url":"https://api.github.com/users/DantestyleXD/gists{/gist_id}","starred_url":"https://api.github.com/users/DantestyleXD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DantestyleXD/subscriptions","organizations_url":"https://api.github.com/users/DantestyleXD/orgs","repos_url":"https://api.github.com/users/DantestyleXD/repos","events_url":"https://api.github.com/users/DantestyleXD/events{/privacy}","received_events_url":"https://api.github.com/users/DantestyleXD/received_events","type":"User","site_admin":false},"body":"Quest Script: ManSea001_00107\r\nQuest Name: Coming to Limsa Lominsa\r\n\r\nOld script:\r\n- Events locked at Scene00003 (no QuestUpdate)\r\n\r\nActually:\r\n- QuestUpdate set on Scene00003\r\n- Add \"If param2\" on Scene00006 (because Actor1 ask if we want change position)\r\n\r\nPS: I modified the entire script for a better understanding (imho)","created_at":"2018-05-13T02:38:40Z","updated_at":"2018-05-13T21:18:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b99eeb3c576e34c0c53b70aa2844352c38c3724","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/291/commits","review_comments_url":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/291/comments","review_comment_url":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SapphireMordred/Sapphire/issues/291/comments","statuses_url":"https://api.github.com/repos/SapphireMordred/Sapphire/statuses/d2d96581e635a4194b9ab81f2e68183f7c95633b","head":{"label":"DantestyleXD:master","ref":"master","sha":"d2d96581e635a4194b9ab81f2e68183f7c95633b","user":{"login":"DantestyleXD","id":7908668,"avatar_url":"https://avatars1.githubusercontent.com/u/7908668?v=4","gravatar_id":"","url":"https://api.github.com/users/DantestyleXD","html_url":"https://github.com/DantestyleXD","followers_url":"https://api.github.com/users/DantestyleXD/followers","following_url":"https://api.github.com/users/DantestyleXD/following{/other_user}","gists_url":"https://api.github.com/users/DantestyleXD/gists{/gist_id}","starred_url":"https://api.github.com/users/DantestyleXD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DantestyleXD/subscriptions","organizations_url":"https://api.github.com/users/DantestyleXD/orgs","repos_url":"https://api.github.com/users/DantestyleXD/repos","events_url":"https://api.github.com/users/DantestyleXD/events{/privacy}","received_events_url":"https://api.github.com/users/DantestyleXD/received_events","type":"User","site_admin":false},"repo":{"id":131459087,"name":"Sapphire","full_name":"DantestyleXD/Sapphire","owner":{"login":"DantestyleXD","id":7908668,"avatar_url":"https://avatars1.githubusercontent.com/u/7908668?v=4","gravatar_id":"","url":"https://api.github.com/users/DantestyleXD","html_url":"https://github.com/DantestyleXD","followers_url":"https://api.github.com/users/DantestyleXD/followers","following_url":"https://api.github.com/users/DantestyleXD/following{/other_user}","gists_url":"https://api.github.com/users/DantestyleXD/gists{/gist_id}","starred_url":"https://api.github.com/users/DantestyleXD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DantestyleXD/subscriptions","organizations_url":"https://api.github.com/users/DantestyleXD/orgs","repos_url":"https://api.github.com/users/DantestyleXD/repos","events_url":"https://api.github.com/users/DantestyleXD/events{/privacy}","received_events_url":"https://api.github.com/users/DantestyleXD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DantestyleXD/Sapphire","description":"A Final Fantasy XIV 4.0+ Server Emulator written in C++","fork":true,"url":"https://api.github.com/repos/DantestyleXD/Sapphire","forks_url":"https://api.github.com/repos/DantestyleXD/Sapphire/forks","keys_url":"https://api.github.com/repos/DantestyleXD/Sapphire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DantestyleXD/Sapphire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DantestyleXD/Sapphire/teams","hooks_url":"https://api.github.com/repos/DantestyleXD/Sapphire/hooks","issue_events_url":"https://api.github.com/repos/DantestyleXD/Sapphire/issues/events{/number}","events_url":"https://api.github.com/repos/DantestyleXD/Sapphire/events","assignees_url":"https://api.github.com/repos/DantestyleXD/Sapphire/assignees{/user}","branches_url":"https://api.github.com/repos/DantestyleXD/Sapphire/branches{/branch}","tags_url":"https://api.github.com/repos/DantestyleXD/Sapphire/tags","blobs_url":"https://api.github.com/repos/DantestyleXD/Sapphire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DantestyleXD/Sapphire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DantestyleXD/Sapphire/git/refs{/sha}","trees_url":"https://api.github.com/repos/DantestyleXD/Sapphire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DantestyleXD/Sapphire/statuses/{sha}","languages_url":"https://api.github.com/repos/DantestyleXD/Sapphire/languages","stargazers_url":"https://api.github.com/repos/DantestyleXD/Sapphire/stargazers","contributors_url":"https://api.github.com/repos/DantestyleXD/Sapphire/contributors","subscribers_url":"https://api.github.com/repos/DantestyleXD/Sapphire/subscribers","subscription_url":"https://api.github.com/repos/DantestyleXD/Sapphire/subscription","commits_url":"https://api.github.com/repos/DantestyleXD/Sapphire/commits{/sha}","git_commits_url":"https://api.github.com/repos/DantestyleXD/Sapphire/git/commits{/sha}","comments_url":"https://api.github.com/repos/DantestyleXD/Sapphire/comments{/number}","issue_comment_url":"https://api.github.com/repos/DantestyleXD/Sapphire/issues/comments{/number}","contents_url":"https://api.github.com/repos/DantestyleXD/Sapphire/contents/{+path}","compare_url":"https://api.github.com/repos/DantestyleXD/Sapphire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DantestyleXD/Sapphire/merges","archive_url":"https://api.github.com/repos/DantestyleXD/Sapphire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DantestyleXD/Sapphire/downloads","issues_url":"https://api.github.com/repos/DantestyleXD/Sapphire/issues{/number}","pulls_url":"https://api.github.com/repos/DantestyleXD/Sapphire/pulls{/number}","milestones_url":"https://api.github.com/repos/DantestyleXD/Sapphire/milestones{/number}","notifications_url":"https://api.github.com/repos/DantestyleXD/Sapphire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DantestyleXD/Sapphire/labels{/name}","releases_url":"https://api.github.com/repos/DantestyleXD/Sapphire/releases{/id}","deployments_url":"https://api.github.com/repos/DantestyleXD/Sapphire/deployments","created_at":"2018-04-29T02:11:37Z","updated_at":"2018-05-13T02:40:17Z","pushed_at":"2018-05-13T02:40:15Z","git_url":"git://github.com/DantestyleXD/Sapphire.git","ssh_url":"git@github.com:DantestyleXD/Sapphire.git","clone_url":"https://github.com/DantestyleXD/Sapphire.git","svn_url":"https://github.com/DantestyleXD/Sapphire","homepage":"","size":6074,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SapphireMordred:develop","ref":"develop","sha":"cc1726184891910d335b77234800ea262a2190a6","user":{"login":"SapphireMordred","id":30826167,"avatar_url":"https://avatars0.githubusercontent.com/u/30826167?v=4","gravatar_id":"","url":"https://api.github.com/users/SapphireMordred","html_url":"https://github.com/SapphireMordred","followers_url":"https://api.github.com/users/SapphireMordred/followers","following_url":"https://api.github.com/users/SapphireMordred/following{/other_user}","gists_url":"https://api.github.com/users/SapphireMordred/gists{/gist_id}","starred_url":"https://api.github.com/users/SapphireMordred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SapphireMordred/subscriptions","organizations_url":"https://api.github.com/users/SapphireMordred/orgs","repos_url":"https://api.github.com/users/SapphireMordred/repos","events_url":"https://api.github.com/users/SapphireMordred/events{/privacy}","received_events_url":"https://api.github.com/users/SapphireMordred/received_events","type":"User","site_admin":false},"repo":{"id":99668166,"name":"Sapphire","full_name":"SapphireMordred/Sapphire","owner":{"login":"SapphireMordred","id":30826167,"avatar_url":"https://avatars0.githubusercontent.com/u/30826167?v=4","gravatar_id":"","url":"https://api.github.com/users/SapphireMordred","html_url":"https://github.com/SapphireMordred","followers_url":"https://api.github.com/users/SapphireMordred/followers","following_url":"https://api.github.com/users/SapphireMordred/following{/other_user}","gists_url":"https://api.github.com/users/SapphireMordred/gists{/gist_id}","starred_url":"https://api.github.com/users/SapphireMordred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SapphireMordred/subscriptions","organizations_url":"https://api.github.com/users/SapphireMordred/orgs","repos_url":"https://api.github.com/users/SapphireMordred/repos","events_url":"https://api.github.com/users/SapphireMordred/events{/privacy}","received_events_url":"https://api.github.com/users/SapphireMordred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SapphireMordred/Sapphire","description":"A Final Fantasy XIV 4.0+ Server Emulator written in C++","fork":false,"url":"https://api.github.com/repos/SapphireMordred/Sapphire","forks_url":"https://api.github.com/repos/SapphireMordred/Sapphire/forks","keys_url":"https://api.github.com/repos/SapphireMordred/Sapphire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SapphireMordred/Sapphire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SapphireMordred/Sapphire/teams","hooks_url":"https://api.github.com/repos/SapphireMordred/Sapphire/hooks","issue_events_url":"https://api.github.com/repos/SapphireMordred/Sapphire/issues/events{/number}","events_url":"https://api.github.com/repos/SapphireMordred/Sapphire/events","assignees_url":"https://api.github.com/repos/SapphireMordred/Sapphire/assignees{/user}","branches_url":"https://api.github.com/repos/SapphireMordred/Sapphire/branches{/branch}","tags_url":"https://api.github.com/repos/SapphireMordred/Sapphire/tags","blobs_url":"https://api.github.com/repos/SapphireMordred/Sapphire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SapphireMordred/Sapphire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SapphireMordred/Sapphire/git/refs{/sha}","trees_url":"https://api.github.com/repos/SapphireMordred/Sapphire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SapphireMordred/Sapphire/statuses/{sha}","languages_url":"https://api.github.com/repos/SapphireMordred/Sapphire/languages","stargazers_url":"https://api.github.com/repos/SapphireMordred/Sapphire/stargazers","contributors_url":"https://api.github.com/repos/SapphireMordred/Sapphire/contributors","subscribers_url":"https://api.github.com/repos/SapphireMordred/Sapphire/subscribers","subscription_url":"https://api.github.com/repos/SapphireMordred/Sapphire/subscription","commits_url":"https://api.github.com/repos/SapphireMordred/Sapphire/commits{/sha}","git_commits_url":"https://api.github.com/repos/SapphireMordred/Sapphire/git/commits{/sha}","comments_url":"https://api.github.com/repos/SapphireMordred/Sapphire/comments{/number}","issue_comment_url":"https://api.github.com/repos/SapphireMordred/Sapphire/issues/comments{/number}","contents_url":"https://api.github.com/repos/SapphireMordred/Sapphire/contents/{+path}","compare_url":"https://api.github.com/repos/SapphireMordred/Sapphire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SapphireMordred/Sapphire/merges","archive_url":"https://api.github.com/repos/SapphireMordred/Sapphire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SapphireMordred/Sapphire/downloads","issues_url":"https://api.github.com/repos/SapphireMordred/Sapphire/issues{/number}","pulls_url":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls{/number}","milestones_url":"https://api.github.com/repos/SapphireMordred/Sapphire/milestones{/number}","notifications_url":"https://api.github.com/repos/SapphireMordred/Sapphire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SapphireMordred/Sapphire/labels{/name}","releases_url":"https://api.github.com/repos/SapphireMordred/Sapphire/releases{/id}","deployments_url":"https://api.github.com/repos/SapphireMordred/Sapphire/deployments","created_at":"2017-08-08T08:14:54Z","updated_at":"2018-04-24T19:09:39Z","pushed_at":"2018-05-13T02:40:16Z","git_url":"git://github.com/SapphireMordred/Sapphire.git","ssh_url":"git@github.com:SapphireMordred/Sapphire.git","clone_url":"https://github.com/SapphireMordred/Sapphire.git","svn_url":"https://github.com/SapphireMordred/Sapphire","homepage":"","size":6045,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":35,"open_issues":26,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/291"},"html":{"href":"https://github.com/SapphireMordred/Sapphire/pull/291"},"issue":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/issues/291"},"comments":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/SapphireMordred/Sapphire/statuses/d2d96581e635a4194b9ab81f2e68183f7c95633b"}},"author_association":"NONE"}}
{"actor":{"display_login":"SapphireMordred"}}