{"action":"created","comment":{"url":"https://api.github.com/repos/0xProject/0x.js/pulls/comments/169467211","pull_request_review_id":97997949,"id":169467211,"diff_hunk":"@@ -116,67 +150,51 @@ export class Compiler {\n     public async compileAllAsync(): Promise<void> {\n         await this._createArtifactsDirIfDoesNotExistAsync();\n         this._contractSourcesIfExists = await Compiler._getContractSourcesAsync(this._contractsDir);\n-        const contractBaseNames = _.keys(this._contractSourcesIfExists);\n-        const compiledContractPromises = _.map(contractBaseNames, async (contractBaseName: string): Promise<void> => {\n-            return this._compileContractAsync(contractBaseName);\n+        _.forIn(this._contractSourcesIfExists, (source, fileName) => {\n+            this._contractSourceData[fileName] = Compiler._getContractSpecificSourceData(source);\n         });\n-        await Promise.all(compiledContractPromises);\n-\n+        const fileNames = this._specifiedContracts.has(ALL_CONTRACTS_IDENTIFIER)\n+            ? _.keys(this._contractSourcesIfExists)\n+            : Array.from(this._specifiedContracts.values());\n+        _.forEach(fileNames, fileName => {\n+            this._setSourceTreeHash(fileName);\n+        });\n+        await Promise.all(_.map(fileNames, async fileName => this._compileContractAsync(fileName)));","path":"packages/deployer/src/compiler.ts","position":151,"original_position":151,"commit_id":"df1e657c9dcab14d0a313351127dd72070f0ad12","original_commit_id":"3502507b01fcbd68de1fb8e7e079adda51cf3605","user":{"login":"abandeali1","id":18060168,"avatar_url":"https://avatars0.githubusercontent.com/u/18060168?v=4","gravatar_id":"","url":"https://api.github.com/users/abandeali1","html_url":"https://github.com/abandeali1","followers_url":"https://api.github.com/users/abandeali1/followers","following_url":"https://api.github.com/users/abandeali1/following{/other_user}","gists_url":"https://api.github.com/users/abandeali1/gists{/gist_id}","starred_url":"https://api.github.com/users/abandeali1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abandeali1/subscriptions","organizations_url":"https://api.github.com/users/abandeali1/orgs","repos_url":"https://api.github.com/users/abandeali1/repos","events_url":"https://api.github.com/users/abandeali1/events{/privacy}","received_events_url":"https://api.github.com/users/abandeali1/received_events","type":"User","site_admin":false},"body":"Hmm, the way this is currently written seems pretty understandable/standard to me. Are we explicitly binding `this` in every single case where we need to throughout our codebase (rather than using arrow functions)?","created_at":"2018-02-20T21:35:18Z","updated_at":"2018-02-20T21:35:19Z","html_url":"https://github.com/0xProject/0x.js/pull/408#discussion_r169467211","pull_request_url":"https://api.github.com/repos/0xProject/0x.js/pulls/408","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/comments/169467211"},"html":{"href":"https://github.com/0xProject/0x.js/pull/408#discussion_r169467211"},"pull_request":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/408"}},"in_reply_to_id":169438274},"pull_request":{"url":"https://api.github.com/repos/0xProject/0x.js/pulls/408","id":169806878,"html_url":"https://github.com/0xProject/0x.js/pull/408","diff_url":"https://github.com/0xProject/0x.js/pull/408.diff","patch_url":"https://github.com/0xProject/0x.js/pull/408.patch","issue_url":"https://api.github.com/repos/0xProject/0x.js/issues/408","number":408,"state":"open","locked":false,"title":"Check dependencies when compiling contracts","user":{"login":"abandeali1","id":18060168,"avatar_url":"https://avatars0.githubusercontent.com/u/18060168?v=4","gravatar_id":"","url":"https://api.github.com/users/abandeali1","html_url":"https://github.com/abandeali1","followers_url":"https://api.github.com/users/abandeali1/followers","following_url":"https://api.github.com/users/abandeali1/following{/other_user}","gists_url":"https://api.github.com/users/abandeali1/gists{/gist_id}","starred_url":"https://api.github.com/users/abandeali1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abandeali1/subscriptions","organizations_url":"https://api.github.com/users/abandeali1/orgs","repos_url":"https://api.github.com/users/abandeali1/repos","events_url":"https://api.github.com/users/abandeali1/events{/privacy}","received_events_url":"https://api.github.com/users/abandeali1/received_events","type":"User","site_admin":false},"body":"<!--- Thank you for taking the time to submit a Pull Request -->\r\n\r\n<!--- Provide a general summary of the issue in the Title above -->\r\n\r\n## Description\r\nPreviously, contracts where not recompiled if the hash of the source matched the hash stored in the contract artifacts. This PR checks the hash of the contract's entire dependency tree when determining if the contract should be recompiled. \r\n\r\nThis PR also adds the contract artifacts back to `.gitignore`. These artifacts are not being used externally, so there is no need to commit them. Commiting them also leads to annoying merge conflicts and prettier errors.\r\n\r\n## Motivation and Context\r\nContracts are not correctly recompiling on the `v2-prototype` branch.\r\n\r\n## How Has This Been Tested?\r\nTested manually for now.\r\n## Types of changes\r\n\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n\r\n* [x] Bug fix (non-breaking change which fixes an issue)\r\n* [x] New feature (non-breaking change which adds functionality)\r\n* [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n* [ ] Change requires a change to the documentation.\r\n* [ ] Added tests to cover my changes.\r\n* [x] Added new entries to the relevant CHANGELOGs.\r\n* [x] Updated the new versions of the changed packages in the relevant CHANGELOGs.\r\n* [x] Labeled this PR with the 'WIP' label if it is a work in progress.\r\n* [x] Labeled this PR with the labels corresponding to the changed package.\r\n","created_at":"2018-02-17T23:31:36Z","updated_at":"2018-02-20T21:35:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94738a168279bc430b0266f89796ce60a21ad2c4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dekz","id":27389,"avatar_url":"https://avatars0.githubusercontent.com/u/27389?v=4","gravatar_id":"","url":"https://api.github.com/users/dekz","html_url":"https://github.com/dekz","followers_url":"https://api.github.com/users/dekz/followers","following_url":"https://api.github.com/users/dekz/following{/other_user}","gists_url":"https://api.github.com/users/dekz/gists{/gist_id}","starred_url":"https://api.github.com/users/dekz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dekz/subscriptions","organizations_url":"https://api.github.com/users/dekz/orgs","repos_url":"https://api.github.com/users/dekz/repos","events_url":"https://api.github.com/users/dekz/events{/privacy}","received_events_url":"https://api.github.com/users/dekz/received_events","type":"User","site_admin":false},{"login":"Recmo","id":4532328,"avatar_url":"https://avatars2.githubusercontent.com/u/4532328?v=4","gravatar_id":"","url":"https://api.github.com/users/Recmo","html_url":"https://github.com/Recmo","followers_url":"https://api.github.com/users/Recmo/followers","following_url":"https://api.github.com/users/Recmo/following{/other_user}","gists_url":"https://api.github.com/users/Recmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Recmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Recmo/subscriptions","organizations_url":"https://api.github.com/users/Recmo/orgs","repos_url":"https://api.github.com/users/Recmo/repos","events_url":"https://api.github.com/users/Recmo/events{/privacy}","received_events_url":"https://api.github.com/users/Recmo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":840339691,"url":"https://api.github.com/repos/0xProject/0x.js/labels/deployer","name":"deployer","color":"e8b392","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/0xProject/0x.js/pulls/408/commits","review_comments_url":"https://api.github.com/repos/0xProject/0x.js/pulls/408/comments","review_comment_url":"https://api.github.com/repos/0xProject/0x.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xProject/0x.js/issues/408/comments","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/df1e657c9dcab14d0a313351127dd72070f0ad12","head":{"label":"0xProject:fix/deployer/checkDependencies","ref":"fix/deployer/checkDependencies","sha":"df1e657c9dcab14d0a313351127dd72070f0ad12","user":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"name":"0x.js","full_name":"0xProject/0x.js","owner":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/0x.js","description":"0x protocol TypeScript monorepo","fork":false,"url":"https://api.github.com/repos/0xProject/0x.js","forks_url":"https://api.github.com/repos/0xProject/0x.js/forks","keys_url":"https://api.github.com/repos/0xProject/0x.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x.js/teams","hooks_url":"https://api.github.com/repos/0xProject/0x.js/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x.js/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x.js/events","assignees_url":"https://api.github.com/repos/0xProject/0x.js/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x.js/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x.js/tags","blobs_url":"https://api.github.com/repos/0xProject/0x.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x.js/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x.js/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x.js/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x.js/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x.js/subscription","commits_url":"https://api.github.com/repos/0xProject/0x.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x.js/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x.js/merges","archive_url":"https://api.github.com/repos/0xProject/0x.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x.js/downloads","issues_url":"https://api.github.com/repos/0xProject/0x.js/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x.js/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x.js/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x.js/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x.js/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x.js/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-02-20T15:57:55Z","pushed_at":"2018-02-20T21:27:24Z","git_url":"git://github.com/0xProject/0x.js.git","ssh_url":"git@github.com:0xProject/0x.js.git","clone_url":"https://github.com/0xProject/0x.js.git","svn_url":"https://github.com/0xProject/0x.js","homepage":"","size":25226,"stargazers_count":398,"watchers_count":398,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":87,"open_issues":23,"watchers":398,"default_branch":"development"}},"base":{"label":"0xProject:development","ref":"development","sha":"097fc477a2e06b8004d98e77dc17d98ab26ab3f1","user":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"name":"0x.js","full_name":"0xProject/0x.js","owner":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/0x.js","description":"0x protocol TypeScript monorepo","fork":false,"url":"https://api.github.com/repos/0xProject/0x.js","forks_url":"https://api.github.com/repos/0xProject/0x.js/forks","keys_url":"https://api.github.com/repos/0xProject/0x.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x.js/teams","hooks_url":"https://api.github.com/repos/0xProject/0x.js/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x.js/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x.js/events","assignees_url":"https://api.github.com/repos/0xProject/0x.js/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x.js/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x.js/tags","blobs_url":"https://api.github.com/repos/0xProject/0x.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x.js/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x.js/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x.js/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x.js/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x.js/subscription","commits_url":"https://api.github.com/repos/0xProject/0x.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x.js/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x.js/merges","archive_url":"https://api.github.com/repos/0xProject/0x.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x.js/downloads","issues_url":"https://api.github.com/repos/0xProject/0x.js/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x.js/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x.js/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x.js/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x.js/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x.js/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-02-20T15:57:55Z","pushed_at":"2018-02-20T21:27:24Z","git_url":"git://github.com/0xProject/0x.js.git","ssh_url":"git@github.com:0xProject/0x.js.git","clone_url":"https://github.com/0xProject/0x.js.git","svn_url":"https://github.com/0xProject/0x.js","homepage":"","size":25226,"stargazers_count":398,"watchers_count":398,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":87,"open_issues":23,"watchers":398,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/408"},"html":{"href":"https://github.com/0xProject/0x.js/pull/408"},"issue":{"href":"https://api.github.com/repos/0xProject/0x.js/issues/408"},"comments":{"href":"https://api.github.com/repos/0xProject/0x.js/issues/408/comments"},"review_comments":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/408/comments"},"review_comment":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/408/commits"},"statuses":{"href":"https://api.github.com/repos/0xProject/0x.js/statuses/df1e657c9dcab14d0a313351127dd72070f0ad12"}},"author_association":"OWNER"}}
{"actor":{"display_login":"abandeali1"}}