{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/173246103","pull_request_review_id":102404597,"id":173246103,"diff_hunk":"@@ -35,6 +35,13 @@\n       <Link>System\\MathF.netstandard.cs</Link>\n     </Compile>\n   </ItemGroup>\n+  <ItemGroup Condition=\"'$(TargetGroup)' == 'netcoreapp'\">","path":"src/System.Numerics.Vectors/tests/System.Numerics.Vectors.Tests.csproj","position":4,"original_position":4,"commit_id":"eac445c85a6059b783e9c4aa067ba133af47bb95","original_commit_id":"eac445c85a6059b783e9c4aa067ba133af47bb95","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Right. TargetGroup can only have values listed in Configurations.props.","created_at":"2018-03-08T18:22:39Z","updated_at":"2018-03-08T18:22:39Z","html_url":"https://github.com/dotnet/corefx/pull/26499#discussion_r173246103","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/26499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/173246103"},"html":{"href":"https://github.com/dotnet/corefx/pull/26499#discussion_r173246103"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26499"}},"in_reply_to_id":173238312},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/26499","id":164186450,"html_url":"https://github.com/dotnet/corefx/pull/26499","diff_url":"https://github.com/dotnet/corefx/pull/26499.diff","patch_url":"https://github.com/dotnet/corefx/pull/26499.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/26499","number":26499,"state":"open","locked":false,"title":"Issue #24343 Vector Ctor using Span","user":{"login":"WinCPP","id":8945458,"avatar_url":"https://avatars1.githubusercontent.com/u/8945458?v=4","gravatar_id":"","url":"https://api.github.com/users/WinCPP","html_url":"https://github.com/WinCPP","followers_url":"https://api.github.com/users/WinCPP/followers","following_url":"https://api.github.com/users/WinCPP/following{/other_user}","gists_url":"https://api.github.com/users/WinCPP/gists{/gist_id}","starred_url":"https://api.github.com/users/WinCPP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WinCPP/subscriptions","organizations_url":"https://api.github.com/users/WinCPP/orgs","repos_url":"https://api.github.com/users/WinCPP/repos","events_url":"https://api.github.com/users/WinCPP/events{/privacy}","received_events_url":"https://api.github.com/users/WinCPP/received_events","type":"User","site_admin":false},"body":"Fixes #24343.\r\n\r\nDepends on dotnet/coreclr#16733 for successful compilation.\r\n\r\nKindly see my comments in the issue #24343. Raising this PR based on my understanding...\r\n\r\n@KrzysztofCwalina  @terrajobst @karelz @jkotas @mellinoe @ahsonkhan @benaadams @stephentoub Appreciate reviews and feedback.\r\n\r\nThanks,\r\nMandar\r\n\r\n","created_at":"2018-01-21T17:52:50Z","updated_at":"2018-03-08T18:22:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61d8afeff9b03c3fd312b2356a7a25fc775205fd","assignee":{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"assignees":[{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},{"login":"WinCPP","id":8945458,"avatar_url":"https://avatars1.githubusercontent.com/u/8945458?v=4","gravatar_id":"","url":"https://api.github.com/users/WinCPP","html_url":"https://github.com/WinCPP","followers_url":"https://api.github.com/users/WinCPP/followers","following_url":"https://api.github.com/users/WinCPP/following{/other_user}","gists_url":"https://api.github.com/users/WinCPP/gists{/gist_id}","starred_url":"https://api.github.com/users/WinCPP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WinCPP/subscriptions","organizations_url":"https://api.github.com/users/WinCPP/orgs","repos_url":"https://api.github.com/users/WinCPP/repos","events_url":"https://api.github.com/users/WinCPP/events{/privacy}","received_events_url":"https://api.github.com/users/WinCPP/received_events","type":"User","site_admin":false},{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars0.githubusercontent.com/u/9724236?v=4","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":147576314,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Numerics","name":"area-System.Numerics","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/26499/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/26499/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/26499/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/eac445c85a6059b783e9c4aa067ba133af47bb95","head":{"label":"WinCPP:issue_24343","ref":"issue_24343","sha":"eac445c85a6059b783e9c4aa067ba133af47bb95","user":{"login":"WinCPP","id":8945458,"avatar_url":"https://avatars1.githubusercontent.com/u/8945458?v=4","gravatar_id":"","url":"https://api.github.com/users/WinCPP","html_url":"https://github.com/WinCPP","followers_url":"https://api.github.com/users/WinCPP/followers","following_url":"https://api.github.com/users/WinCPP/following{/other_user}","gists_url":"https://api.github.com/users/WinCPP/gists{/gist_id}","starred_url":"https://api.github.com/users/WinCPP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WinCPP/subscriptions","organizations_url":"https://api.github.com/users/WinCPP/orgs","repos_url":"https://api.github.com/users/WinCPP/repos","events_url":"https://api.github.com/users/WinCPP/events{/privacy}","received_events_url":"https://api.github.com/users/WinCPP/received_events","type":"User","site_admin":false},"repo":{"id":77516940,"name":"corefx","full_name":"WinCPP/corefx","owner":{"login":"WinCPP","id":8945458,"avatar_url":"https://avatars1.githubusercontent.com/u/8945458?v=4","gravatar_id":"","url":"https://api.github.com/users/WinCPP","html_url":"https://github.com/WinCPP","followers_url":"https://api.github.com/users/WinCPP/followers","following_url":"https://api.github.com/users/WinCPP/following{/other_user}","gists_url":"https://api.github.com/users/WinCPP/gists{/gist_id}","starred_url":"https://api.github.com/users/WinCPP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WinCPP/subscriptions","organizations_url":"https://api.github.com/users/WinCPP/orgs","repos_url":"https://api.github.com/users/WinCPP/repos","events_url":"https://api.github.com/users/WinCPP/events{/privacy}","received_events_url":"https://api.github.com/users/WinCPP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WinCPP/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/WinCPP/corefx","forks_url":"https://api.github.com/repos/WinCPP/corefx/forks","keys_url":"https://api.github.com/repos/WinCPP/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WinCPP/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WinCPP/corefx/teams","hooks_url":"https://api.github.com/repos/WinCPP/corefx/hooks","issue_events_url":"https://api.github.com/repos/WinCPP/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/WinCPP/corefx/events","assignees_url":"https://api.github.com/repos/WinCPP/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/WinCPP/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/WinCPP/corefx/tags","blobs_url":"https://api.github.com/repos/WinCPP/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WinCPP/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WinCPP/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/WinCPP/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WinCPP/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/WinCPP/corefx/languages","stargazers_url":"https://api.github.com/repos/WinCPP/corefx/stargazers","contributors_url":"https://api.github.com/repos/WinCPP/corefx/contributors","subscribers_url":"https://api.github.com/repos/WinCPP/corefx/subscribers","subscription_url":"https://api.github.com/repos/WinCPP/corefx/subscription","commits_url":"https://api.github.com/repos/WinCPP/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/WinCPP/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/WinCPP/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/WinCPP/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/WinCPP/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/WinCPP/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WinCPP/corefx/merges","archive_url":"https://api.github.com/repos/WinCPP/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WinCPP/corefx/downloads","issues_url":"https://api.github.com/repos/WinCPP/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/WinCPP/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/WinCPP/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/WinCPP/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WinCPP/corefx/labels{/name}","releases_url":"https://api.github.com/repos/WinCPP/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/WinCPP/corefx/deployments","created_at":"2016-12-28T08:35:49Z","updated_at":"2017-02-05T04:41:05Z","pushed_at":"2018-03-08T17:34:17Z","git_url":"git://github.com/WinCPP/corefx.git","ssh_url":"git@github.com:WinCPP/corefx.git","clone_url":"https://github.com/WinCPP/corefx.git","svn_url":"https://github.com/WinCPP/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":171143,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b43797298b7cad224e5ab181f5506ee903845624","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-03-08T15:31:52Z","pushed_at":"2018-03-08T18:21:27Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":173135,"stargazers_count":13507,"watchers_count":13507,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3847,"mirror_url":null,"archived":false,"open_issues_count":2217,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3847,"open_issues":2217,"watchers":13507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26499"},"html":{"href":"https://github.com/dotnet/corefx/pull/26499"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/26499"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/26499/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26499/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26499/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/eac445c85a6059b783e9c4aa067ba133af47bb95"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jkotas"}}