{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/223505572","pull_request_review_id":162650160,"id":223505572,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzUwNTU3Mg==","diff_hunk":"@@ -82,11 +82,16 @@ exports.getFlags = function(config) {\n     language_in: 'ES6',\n     language_out: config.language_out || 'ES5',\n     module_output_path_prefix: config.writeTo || 'out/',\n+    module_resolution: 'NODE',\n     externs: config.externs,\n     define: config.define,\n     // Turn off warning for \"Unknown @define\" since we use define to pass\n     // args such as FORTESTING to our runner.\n     jscomp_off: ['unknownDefines'],\n+    // checkVars: Demote \"variable foo is undeclared\" errors.\n+    // moduleLoad: Demote \"module not found\" errors to ignore missing files\n+    //     in type declarations in the swg.js bundle.\n+    jscomp_warning: ['checkVars', 'moduleLoad'],","path":"build-system/get-dep-graph.js","position":13,"original_position":13,"commit_id":"7684408c0d3d217cf029dfacd20f9b26d584db2e","original_commit_id":"f3c2bdef1e5b20c06b3395f8efa6f2ae01a2ee31","user":{"login":"erwinmombay","id":354746,"node_id":"MDQ6VXNlcjM1NDc0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/354746?v=4","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"body":"@choumx ideally. i just remembered the scenario you ran into originally with multi-pass, where the compilation worked but check-types failed. was that more an inconsistency with another option?","created_at":"2018-10-08T21:44:07Z","updated_at":"2018-10-08T21:44:07Z","html_url":"https://github.com/ampproject/amphtml/pull/18609#discussion_r223505572","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/18609","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/223505572"},"html":{"href":"https://github.com/ampproject/amphtml/pull/18609#discussion_r223505572"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/18609"}},"in_reply_to_id":223487568},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/18609","id":221232857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjMyODU3","html_url":"https://github.com/ampproject/amphtml/pull/18609","diff_url":"https://github.com/ampproject/amphtml/pull/18609.diff","patch_url":"https://github.com/ampproject/amphtml/pull/18609.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/18609","number":18609,"state":"open","locked":false,"title":"Roll forward CC upgrade with fixes (#18552)","user":{"login":"choumx","id":20525523,"node_id":"MDQ6VXNlcjIwNTI1NTIz","avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"body":"See #18552.\r\n\r\nNew changes:\r\n- Remove `node_modules/` path from `js_module_root` option.\r\n- Document method for removing missing type paths in `swg.js`.","created_at":"2018-10-08T20:23:28Z","updated_at":"2018-10-08T21:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5b05ae4b16961cfb8fbcaa9ce8ecead5ff42ef7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/18609/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/18609/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/18609/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/7684408c0d3d217cf029dfacd20f9b26d584db2e","head":{"label":"choumx:cc-upgrade-remix","ref":"cc-upgrade-remix","sha":"7684408c0d3d217cf029dfacd20f9b26d584db2e","user":{"login":"choumx","id":20525523,"node_id":"MDQ6VXNlcjIwNTI1NTIz","avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"repo":{"id":63805137,"node_id":"MDEwOlJlcG9zaXRvcnk2MzgwNTEzNw==","name":"amphtml","full_name":"choumx/amphtml","private":false,"owner":{"login":"choumx","id":20525523,"node_id":"MDQ6VXNlcjIwNTI1NTIz","avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/choumx/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/choumx/amphtml","forks_url":"https://api.github.com/repos/choumx/amphtml/forks","keys_url":"https://api.github.com/repos/choumx/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/choumx/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/choumx/amphtml/teams","hooks_url":"https://api.github.com/repos/choumx/amphtml/hooks","issue_events_url":"https://api.github.com/repos/choumx/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/choumx/amphtml/events","assignees_url":"https://api.github.com/repos/choumx/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/choumx/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/choumx/amphtml/tags","blobs_url":"https://api.github.com/repos/choumx/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/choumx/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/choumx/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/choumx/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/choumx/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/choumx/amphtml/languages","stargazers_url":"https://api.github.com/repos/choumx/amphtml/stargazers","contributors_url":"https://api.github.com/repos/choumx/amphtml/contributors","subscribers_url":"https://api.github.com/repos/choumx/amphtml/subscribers","subscription_url":"https://api.github.com/repos/choumx/amphtml/subscription","commits_url":"https://api.github.com/repos/choumx/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/choumx/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/choumx/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/choumx/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/choumx/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/choumx/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/choumx/amphtml/merges","archive_url":"https://api.github.com/repos/choumx/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/choumx/amphtml/downloads","issues_url":"https://api.github.com/repos/choumx/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/choumx/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/choumx/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/choumx/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/choumx/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/choumx/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/choumx/amphtml/deployments","created_at":"2016-07-20T18:33:46Z","updated_at":"2018-10-07T17:43:27Z","pushed_at":"2018-10-08T20:54:11Z","git_url":"git://github.com/choumx/amphtml.git","ssh_url":"git@github.com:choumx/amphtml.git","clone_url":"https://github.com/choumx/amphtml.git","svn_url":"https://github.com/choumx/amphtml","homepage":"https://ampproject.org","size":530620,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"e952a6b3a22f3ad4d5b596f4f59b38bad3451f79","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-10-08T21:40:05Z","pushed_at":"2018-10-08T21:43:57Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":530727,"stargazers_count":12052,"watchers_count":12052,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2630,"mirror_url":null,"archived":false,"open_issues_count":1473,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2630,"open_issues":1473,"watchers":12052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/18609"},"html":{"href":"https://github.com/ampproject/amphtml/pull/18609"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/18609"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/18609/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/18609/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/18609/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/7684408c0d3d217cf029dfacd20f9b26d584db2e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"erwinmombay"}}