{"action":"created","comment":{"url":"https://api.github.com/repos/mu-editor/mu/pulls/comments/181217020","pull_request_review_id":111787562,"id":181217020,"diff_hunk":"@@ -10,6 +11,25 @@\n with open('CHANGES.rst') as f:\n     changes = f.read()\n \n+install_requires = ['pycodestyle==2.3.1', 'pyflakes==1.6.0',\n+                    'pyserial==3.4', 'pyqt5==5.10.1', 'qscintilla>=2.10',\n+                    'qtconsole==4.3.1', 'matplotlib==2.1.2',\n+                    'pgzero==1.2', 'PyQtChart>=5.10', 'appdirs>=1.4.3',\n+                    'gpiozero>=1.4.1', 'guizero>=0.4.5',\n+                    'pigpio>=1.40.post1', 'Pillow>=5.0.0',\n+                    'requests>=2.18.4']\n+\n+# Exclude packages not available for ARM in PyPI/piwheels (Raspberry Pi)\n+try:\n+    machine = platform.machine()\n+    if machine.lower().startswith('arm'):\n+        exclude = ('pyqt5', 'qscintilla', 'qtconsole', 'PyQtChart')\n+        install_requires = [requirement for requirement in install_requires\n+                            if not requirement.startswith(exclude)]\n+except Exception as e:\n+    # Something unexpected happened, so simply keep all requires\n+    pass\n+","path":"setup.py","position":27,"original_position":27,"commit_id":"f30f8dade1de00ba18a0682fe2b409094710a071","original_commit_id":"f30f8dade1de00ba18a0682fe2b409094710a071","user":{"login":"carlosperate","id":4189262,"avatar_url":"https://avatars0.githubusercontent.com/u/4189262?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosperate","html_url":"https://github.com/carlosperate","followers_url":"https://api.github.com/users/carlosperate/followers","following_url":"https://api.github.com/users/carlosperate/following{/other_user}","gists_url":"https://api.github.com/users/carlosperate/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosperate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosperate/subscriptions","organizations_url":"https://api.github.com/users/carlosperate/orgs","repos_url":"https://api.github.com/users/carlosperate/repos","events_url":"https://api.github.com/users/carlosperate/events{/privacy}","received_events_url":"https://api.github.com/users/carlosperate/received_events","type":"User","site_admin":false},"body":"This is a bit ugly to have in the setup.py, but I found it to be the best solution to dynamically chose what to include in the `install_requires`. Otherwise mu-debug doesn't work.\r\nUsing something like extra_requires is a lot messier during installation.","created_at":"2018-04-12T20:47:53Z","updated_at":"2018-04-12T20:47:53Z","html_url":"https://github.com/mu-editor/mu/pull/438#discussion_r181217020","pull_request_url":"https://api.github.com/repos/mu-editor/mu/pulls/438","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/comments/181217020"},"html":{"href":"https://github.com/mu-editor/mu/pull/438#discussion_r181217020"},"pull_request":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/mu-editor/mu/pulls/438","id":181320958,"html_url":"https://github.com/mu-editor/mu/pull/438","diff_url":"https://github.com/mu-editor/mu/pull/438.diff","patch_url":"https://github.com/mu-editor/mu/pull/438.patch","issue_url":"https://api.github.com/repos/mu-editor/mu/issues/438","number":438,"state":"open","locked":false,"title":"Update setup.py to be able to install from source on Raspberry Pi","user":{"login":"carlosperate","id":4189262,"avatar_url":"https://avatars0.githubusercontent.com/u/4189262?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosperate","html_url":"https://github.com/carlosperate","followers_url":"https://api.github.com/users/carlosperate/followers","following_url":"https://api.github.com/users/carlosperate/following{/other_user}","gists_url":"https://api.github.com/users/carlosperate/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosperate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosperate/subscriptions","organizations_url":"https://api.github.com/users/carlosperate/orgs","repos_url":"https://api.github.com/users/carlosperate/repos","events_url":"https://api.github.com/users/carlosperate/events{/privacy}","received_events_url":"https://api.github.com/users/carlosperate/received_events","type":"User","site_admin":false},"body":"Also updates the docs as well with the simplified instructions.\r\nNo more messing around editing the setup.py, just:\r\n```\r\nsudo apt-get install ...\r\npip install -r requirements_pi.txt\r\npip install .\r\n```\r\n\r\nThe requirements_pi.txt has also been updated to follow the changes in requirements.txt from https://github.com/mu-editor/mu/pull/421.","created_at":"2018-04-12T20:46:00Z","updated_at":"2018-04-12T20:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12c8d73c5589da4f1d5ececc561dfb242b4b61ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mu-editor/mu/pulls/438/commits","review_comments_url":"https://api.github.com/repos/mu-editor/mu/pulls/438/comments","review_comment_url":"https://api.github.com/repos/mu-editor/mu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mu-editor/mu/issues/438/comments","statuses_url":"https://api.github.com/repos/mu-editor/mu/statuses/f30f8dade1de00ba18a0682fe2b409094710a071","head":{"label":"mu-editor:install_pi","ref":"install_pi","sha":"f30f8dade1de00ba18a0682fe2b409094710a071","user":{"login":"mu-editor","id":17850097,"avatar_url":"https://avatars3.githubusercontent.com/u/17850097?v=4","gravatar_id":"","url":"https://api.github.com/users/mu-editor","html_url":"https://github.com/mu-editor","followers_url":"https://api.github.com/users/mu-editor/followers","following_url":"https://api.github.com/users/mu-editor/following{/other_user}","gists_url":"https://api.github.com/users/mu-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/mu-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mu-editor/subscriptions","organizations_url":"https://api.github.com/users/mu-editor/orgs","repos_url":"https://api.github.com/users/mu-editor/repos","events_url":"https://api.github.com/users/mu-editor/events{/privacy}","received_events_url":"https://api.github.com/users/mu-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":47607357,"name":"mu","full_name":"mu-editor/mu","owner":{"login":"mu-editor","id":17850097,"avatar_url":"https://avatars3.githubusercontent.com/u/17850097?v=4","gravatar_id":"","url":"https://api.github.com/users/mu-editor","html_url":"https://github.com/mu-editor","followers_url":"https://api.github.com/users/mu-editor/followers","following_url":"https://api.github.com/users/mu-editor/following{/other_user}","gists_url":"https://api.github.com/users/mu-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/mu-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mu-editor/subscriptions","organizations_url":"https://api.github.com/users/mu-editor/orgs","repos_url":"https://api.github.com/users/mu-editor/repos","events_url":"https://api.github.com/users/mu-editor/events{/privacy}","received_events_url":"https://api.github.com/users/mu-editor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mu-editor/mu","description":"A small, simple editor for beginner Python programmers. Written in Python and Qt5.","fork":false,"url":"https://api.github.com/repos/mu-editor/mu","forks_url":"https://api.github.com/repos/mu-editor/mu/forks","keys_url":"https://api.github.com/repos/mu-editor/mu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mu-editor/mu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mu-editor/mu/teams","hooks_url":"https://api.github.com/repos/mu-editor/mu/hooks","issue_events_url":"https://api.github.com/repos/mu-editor/mu/issues/events{/number}","events_url":"https://api.github.com/repos/mu-editor/mu/events","assignees_url":"https://api.github.com/repos/mu-editor/mu/assignees{/user}","branches_url":"https://api.github.com/repos/mu-editor/mu/branches{/branch}","tags_url":"https://api.github.com/repos/mu-editor/mu/tags","blobs_url":"https://api.github.com/repos/mu-editor/mu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mu-editor/mu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mu-editor/mu/git/refs{/sha}","trees_url":"https://api.github.com/repos/mu-editor/mu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mu-editor/mu/statuses/{sha}","languages_url":"https://api.github.com/repos/mu-editor/mu/languages","stargazers_url":"https://api.github.com/repos/mu-editor/mu/stargazers","contributors_url":"https://api.github.com/repos/mu-editor/mu/contributors","subscribers_url":"https://api.github.com/repos/mu-editor/mu/subscribers","subscription_url":"https://api.github.com/repos/mu-editor/mu/subscription","commits_url":"https://api.github.com/repos/mu-editor/mu/commits{/sha}","git_commits_url":"https://api.github.com/repos/mu-editor/mu/git/commits{/sha}","comments_url":"https://api.github.com/repos/mu-editor/mu/comments{/number}","issue_comment_url":"https://api.github.com/repos/mu-editor/mu/issues/comments{/number}","contents_url":"https://api.github.com/repos/mu-editor/mu/contents/{+path}","compare_url":"https://api.github.com/repos/mu-editor/mu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mu-editor/mu/merges","archive_url":"https://api.github.com/repos/mu-editor/mu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mu-editor/mu/downloads","issues_url":"https://api.github.com/repos/mu-editor/mu/issues{/number}","pulls_url":"https://api.github.com/repos/mu-editor/mu/pulls{/number}","milestones_url":"https://api.github.com/repos/mu-editor/mu/milestones{/number}","notifications_url":"https://api.github.com/repos/mu-editor/mu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mu-editor/mu/labels{/name}","releases_url":"https://api.github.com/repos/mu-editor/mu/releases{/id}","deployments_url":"https://api.github.com/repos/mu-editor/mu/deployments","created_at":"2015-12-08T07:56:02Z","updated_at":"2018-04-12T16:51:30Z","pushed_at":"2018-04-12T20:46:01Z","git_url":"git://github.com/mu-editor/mu.git","ssh_url":"git@github.com:mu-editor/mu.git","clone_url":"https://github.com/mu-editor/mu.git","svn_url":"https://github.com/mu-editor/mu","homepage":"http://codewith.mu","size":11453,"stargazers_count":214,"watchers_count":214,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":113,"open_issues":110,"watchers":214,"default_branch":"master"}},"base":{"label":"mu-editor:master","ref":"master","sha":"1e7c5f9891f9c262e7f10976ca88e74713ca9baf","user":{"login":"mu-editor","id":17850097,"avatar_url":"https://avatars3.githubusercontent.com/u/17850097?v=4","gravatar_id":"","url":"https://api.github.com/users/mu-editor","html_url":"https://github.com/mu-editor","followers_url":"https://api.github.com/users/mu-editor/followers","following_url":"https://api.github.com/users/mu-editor/following{/other_user}","gists_url":"https://api.github.com/users/mu-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/mu-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mu-editor/subscriptions","organizations_url":"https://api.github.com/users/mu-editor/orgs","repos_url":"https://api.github.com/users/mu-editor/repos","events_url":"https://api.github.com/users/mu-editor/events{/privacy}","received_events_url":"https://api.github.com/users/mu-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":47607357,"name":"mu","full_name":"mu-editor/mu","owner":{"login":"mu-editor","id":17850097,"avatar_url":"https://avatars3.githubusercontent.com/u/17850097?v=4","gravatar_id":"","url":"https://api.github.com/users/mu-editor","html_url":"https://github.com/mu-editor","followers_url":"https://api.github.com/users/mu-editor/followers","following_url":"https://api.github.com/users/mu-editor/following{/other_user}","gists_url":"https://api.github.com/users/mu-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/mu-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mu-editor/subscriptions","organizations_url":"https://api.github.com/users/mu-editor/orgs","repos_url":"https://api.github.com/users/mu-editor/repos","events_url":"https://api.github.com/users/mu-editor/events{/privacy}","received_events_url":"https://api.github.com/users/mu-editor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mu-editor/mu","description":"A small, simple editor for beginner Python programmers. Written in Python and Qt5.","fork":false,"url":"https://api.github.com/repos/mu-editor/mu","forks_url":"https://api.github.com/repos/mu-editor/mu/forks","keys_url":"https://api.github.com/repos/mu-editor/mu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mu-editor/mu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mu-editor/mu/teams","hooks_url":"https://api.github.com/repos/mu-editor/mu/hooks","issue_events_url":"https://api.github.com/repos/mu-editor/mu/issues/events{/number}","events_url":"https://api.github.com/repos/mu-editor/mu/events","assignees_url":"https://api.github.com/repos/mu-editor/mu/assignees{/user}","branches_url":"https://api.github.com/repos/mu-editor/mu/branches{/branch}","tags_url":"https://api.github.com/repos/mu-editor/mu/tags","blobs_url":"https://api.github.com/repos/mu-editor/mu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mu-editor/mu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mu-editor/mu/git/refs{/sha}","trees_url":"https://api.github.com/repos/mu-editor/mu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mu-editor/mu/statuses/{sha}","languages_url":"https://api.github.com/repos/mu-editor/mu/languages","stargazers_url":"https://api.github.com/repos/mu-editor/mu/stargazers","contributors_url":"https://api.github.com/repos/mu-editor/mu/contributors","subscribers_url":"https://api.github.com/repos/mu-editor/mu/subscribers","subscription_url":"https://api.github.com/repos/mu-editor/mu/subscription","commits_url":"https://api.github.com/repos/mu-editor/mu/commits{/sha}","git_commits_url":"https://api.github.com/repos/mu-editor/mu/git/commits{/sha}","comments_url":"https://api.github.com/repos/mu-editor/mu/comments{/number}","issue_comment_url":"https://api.github.com/repos/mu-editor/mu/issues/comments{/number}","contents_url":"https://api.github.com/repos/mu-editor/mu/contents/{+path}","compare_url":"https://api.github.com/repos/mu-editor/mu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mu-editor/mu/merges","archive_url":"https://api.github.com/repos/mu-editor/mu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mu-editor/mu/downloads","issues_url":"https://api.github.com/repos/mu-editor/mu/issues{/number}","pulls_url":"https://api.github.com/repos/mu-editor/mu/pulls{/number}","milestones_url":"https://api.github.com/repos/mu-editor/mu/milestones{/number}","notifications_url":"https://api.github.com/repos/mu-editor/mu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mu-editor/mu/labels{/name}","releases_url":"https://api.github.com/repos/mu-editor/mu/releases{/id}","deployments_url":"https://api.github.com/repos/mu-editor/mu/deployments","created_at":"2015-12-08T07:56:02Z","updated_at":"2018-04-12T16:51:30Z","pushed_at":"2018-04-12T20:46:01Z","git_url":"git://github.com/mu-editor/mu.git","ssh_url":"git@github.com:mu-editor/mu.git","clone_url":"https://github.com/mu-editor/mu.git","svn_url":"https://github.com/mu-editor/mu","homepage":"http://codewith.mu","size":11453,"stargazers_count":214,"watchers_count":214,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":113,"open_issues":110,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/438"},"html":{"href":"https://github.com/mu-editor/mu/pull/438"},"issue":{"href":"https://api.github.com/repos/mu-editor/mu/issues/438"},"comments":{"href":"https://api.github.com/repos/mu-editor/mu/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/mu-editor/mu/statuses/f30f8dade1de00ba18a0682fe2b409094710a071"}},"author_association":"OWNER"}}
{"actor":{"display_login":"carlosperate"}}