{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8734","repository_url":"https://api.github.com/repos/DynamoDS/Dynamo","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8734/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8734/comments","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8734/events","html_url":"https://github.com/DynamoDS/Dynamo/pull/8734","id":312108899,"number":8734,"title":"Fix nested dictionary preview","user":{"login":"aparajit-pratap","id":5710686,"avatar_url":"https://avatars0.githubusercontent.com/u/5710686?v=4","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-06T20:33:45Z","updated_at":"2018-04-06T21:00:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/8734","html_url":"https://github.com/DynamoDS/Dynamo/pull/8734","diff_url":"https://github.com/DynamoDS/Dynamo/pull/8734.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/8734.patch"},"body":"### Purpose\r\n\r\nThis fixes QNTM-3947. Nested dictionaries will not have any information about preferred dictionary ordering. Therefore when the same ordering from the outer dictionary is passed into the nested dictionary preview, the ordering of the outer dictionary does not apply to the nested one resulting in an `key not found exception`. In this case, we therefore pass null to the nested dictionary all the time. And we add a null check for `preferredDictinoaryordering` argument so that we check it only if a non-null argument for it is passed.\r\n\r\nRelated Github issue: https://github.com/DynamoDS/Dynamo/issues/8665\r\n![image](https://user-images.githubusercontent.com/5710686/38443148-a606cd72-39b8-11e8-802e-54d9667d52d9.png)\r\n\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [X] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [X] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] All tests pass using the self-service CI.\r\n- [ ] Snapshot of UI changes, if any.\r\n- [ ] Changes to the API follow [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the [API Changes](https://github.com/DynamoDS/Dynamo/wiki/API-Changes) document.\r\n\r\n### Reviewers\r\n@mjkkirschner \r\n\r\n### FYIs\r\n@jnealb \r\n"},"comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/379377108","html_url":"https://github.com/DynamoDS/Dynamo/pull/8734#issuecomment-379377108","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8734","id":379377108,"user":{"login":"QilongTang","id":3942418,"avatar_url":"https://avatars2.githubusercontent.com/u/3942418?v=4","gravatar_id":"","url":"https://api.github.com/users/QilongTang","html_url":"https://github.com/QilongTang","followers_url":"https://api.github.com/users/QilongTang/followers","following_url":"https://api.github.com/users/QilongTang/following{/other_user}","gists_url":"https://api.github.com/users/QilongTang/gists{/gist_id}","starred_url":"https://api.github.com/users/QilongTang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QilongTang/subscriptions","organizations_url":"https://api.github.com/users/QilongTang/orgs","repos_url":"https://api.github.com/users/QilongTang/repos","events_url":"https://api.github.com/users/QilongTang/events{/privacy}","received_events_url":"https://api.github.com/users/QilongTang/received_events","type":"User","site_admin":false},"created_at":"2018-04-06T21:00:47Z","updated_at":"2018-04-06T21:00:47Z","author_association":"CONTRIBUTOR","body":"@ramramps This is unfortunate. Dynamo Nugets 2.0.0 are all out this morning since we need an official RC to test. Two options here in my mind:\r\n1. We do not include this in 2.0 ( I am not sure if we have decided to include it yet @Racel ?)\r\n2. We release nuget 2.0.0.xxxx to accomadate this change which is pretty easy and just update https://github.com/DynamoDS/Dynamo/pull/8723/ We have never done that but according to sementic versioning, it is valid because what is out there currently is treated as 2.0.0.0000"}}
{"actor":{"display_login":"QilongTang"}}