{"action":"created","comment":{"url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/comments/207275045","pull_request_review_id":142853881,"id":207275045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzI3NTA0NQ==","diff_hunk":"@@ -75,21 +75,23 @@ case class DepositDir private(baseDir: File, user: String, id: UUID) extends Deb\n    */\n   def setStateInfo(stateInfo: StateInfo): Try[Unit] = {\n     for {\n-      props <- getDepositProps\n-      currentState = State.withName(props.getString(\"state.label\"))\n-      _ <- checkStateTransition(currentState, stateInfo.state)\n+      props <- checkStateTransition(stateInfo.state) // read again as submit might have added a DOI","path":"src/main/scala/nl.knaw.dans.easy.deposit/DepositDir.scala","position":7,"original_position":7,"commit_id":"0b6e5fbe95007be5c7ec3f693a308886b129fdbe","original_commit_id":"0b6e5fbe95007be5c7ec3f693a308886b129fdbe","user":{"login":"lindareijnhoudt","id":2812779,"node_id":"MDQ6VXNlcjI4MTI3Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2812779?v=4","gravatar_id":"","url":"https://api.github.com/users/lindareijnhoudt","html_url":"https://github.com/lindareijnhoudt","followers_url":"https://api.github.com/users/lindareijnhoudt/followers","following_url":"https://api.github.com/users/lindareijnhoudt/following{/other_user}","gists_url":"https://api.github.com/users/lindareijnhoudt/gists{/gist_id}","starred_url":"https://api.github.com/users/lindareijnhoudt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindareijnhoudt/subscriptions","organizations_url":"https://api.github.com/users/lindareijnhoudt/orgs","repos_url":"https://api.github.com/users/lindareijnhoudt/repos","events_url":"https://api.github.com/users/lindareijnhoudt/events{/privacy}","received_events_url":"https://api.github.com/users/lindareijnhoudt/received_events","type":"User","site_admin":false},"body":"isn't it a bit weird to get the props returned for this check? I liked the previous def better, where there were two state-parameters","created_at":"2018-08-02T15:38:03Z","updated_at":"2018-08-02T15:44:33Z","html_url":"https://github.com/DANS-KNAW/easy-deposit-api/pull/59#discussion_r207275045","pull_request_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/59","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/comments/207275045"},"html":{"href":"https://github.com/DANS-KNAW/easy-deposit-api/pull/59#discussion_r207275045"},"pull_request":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/59","id":205105271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTA1Mjcx","html_url":"https://github.com/DANS-KNAW/easy-deposit-api/pull/59","diff_url":"https://github.com/DANS-KNAW/easy-deposit-api/pull/59.diff","patch_url":"https://github.com/DANS-KNAW/easy-deposit-api/pull/59.patch","issue_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/issues/59","number":59,"state":"open","locked":false,"title":"EASY-1564 deposit properties + EASY-1464 submit: doi and state","user":{"login":"jo-pol","id":10553630,"node_id":"MDQ6VXNlcjEwNTUzNjMw","avatar_url":"https://avatars3.githubusercontent.com/u/10553630?v=4","gravatar_id":"","url":"https://api.github.com/users/jo-pol","html_url":"https://github.com/jo-pol","followers_url":"https://api.github.com/users/jo-pol/followers","following_url":"https://api.github.com/users/jo-pol/following{/other_user}","gists_url":"https://api.github.com/users/jo-pol/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-pol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-pol/subscriptions","organizations_url":"https://api.github.com/users/jo-pol/orgs","repos_url":"https://api.github.com/users/jo-pol/repos","events_url":"https://api.github.com/users/jo-pol/events{/privacy}","received_events_url":"https://api.github.com/users/jo-pol/received_events","type":"User","site_admin":false},"body":"Fixes EASY-1464 + some more steps of EASY-1464\r\n\r\n#### When applied it will\r\n* add the fields that wre still missing from the deposit.properties\r\n* add a DOI if not yet available\r\n* check state transition before submit actions\r\n* change the state\r\n\r\n#### Where should the reviewer @DANS-KNAW/easy start?\r\n\r\nSubmitterSpec and a new test in IntegrationSpec illustrate the implemented changes.\r\n\r\n#### How should this be manually tested?\r\n\r\nSubmit will fail with a not implemented exception but metadata files should be created/changed.\r\n\r\n#### Related pull requests on github\r\nrepo                       | PR                | note\r\n-------------------------- | ----------------- | ----\r\neasy-                      | [PR#](PRlink)     | ..\r\n","created_at":"2018-07-31T13:03:45Z","updated_at":"2018-08-02T15:44:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a599c97b657c69539bb2efb917877ad095ba9e7d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/59/commits","review_comments_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/59/comments","review_comment_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/issues/59/comments","statuses_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/statuses/0b6e5fbe95007be5c7ec3f693a308886b129fdbe","head":{"label":"DANS-KNAW-jp:1464-doi-and-state","ref":"1464-doi-and-state","sha":"0b6e5fbe95007be5c7ec3f693a308886b129fdbe","user":{"login":"DANS-KNAW-jp","id":21305289,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzA1Mjg5","avatar_url":"https://avatars1.githubusercontent.com/u/21305289?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW-jp","html_url":"https://github.com/DANS-KNAW-jp","followers_url":"https://api.github.com/users/DANS-KNAW-jp/followers","following_url":"https://api.github.com/users/DANS-KNAW-jp/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW-jp/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW-jp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW-jp/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW-jp/orgs","repos_url":"https://api.github.com/users/DANS-KNAW-jp/repos","events_url":"https://api.github.com/users/DANS-KNAW-jp/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW-jp/received_events","type":"Organization","site_admin":false},"repo":{"id":136455923,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0NTU5MjM=","name":"easy-deposit-api","full_name":"DANS-KNAW-jp/easy-deposit-api","owner":{"login":"DANS-KNAW-jp","id":21305289,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzA1Mjg5","avatar_url":"https://avatars1.githubusercontent.com/u/21305289?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW-jp","html_url":"https://github.com/DANS-KNAW-jp","followers_url":"https://api.github.com/users/DANS-KNAW-jp/followers","following_url":"https://api.github.com/users/DANS-KNAW-jp/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW-jp/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW-jp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW-jp/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW-jp/orgs","repos_url":"https://api.github.com/users/DANS-KNAW-jp/repos","events_url":"https://api.github.com/users/DANS-KNAW-jp/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW-jp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DANS-KNAW-jp/easy-deposit-api","description":"JSON-based depositing service","fork":true,"url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api","forks_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/forks","keys_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/teams","hooks_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/hooks","issue_events_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/issues/events{/number}","events_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/events","assignees_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/assignees{/user}","branches_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/branches{/branch}","tags_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/tags","blobs_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/statuses/{sha}","languages_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/languages","stargazers_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/stargazers","contributors_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/contributors","subscribers_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/subscribers","subscription_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/subscription","commits_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/contents/{+path}","compare_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/merges","archive_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/downloads","issues_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/issues{/number}","pulls_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/pulls{/number}","milestones_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/milestones{/number}","notifications_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/labels{/name}","releases_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/releases{/id}","deployments_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-deposit-api/deployments","created_at":"2018-06-07T09:43:00Z","updated_at":"2018-07-31T11:17:13Z","pushed_at":"2018-08-02T09:28:50Z","git_url":"git://github.com/DANS-KNAW-jp/easy-deposit-api.git","ssh_url":"git@github.com:DANS-KNAW-jp/easy-deposit-api.git","clone_url":"https://github.com/DANS-KNAW-jp/easy-deposit-api.git","svn_url":"https://github.com/DANS-KNAW-jp/easy-deposit-api","homepage":"https://dans-knaw.github.io/easy-deposit-api/01_manual.html","size":5006,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DANS-KNAW:master","ref":"master","sha":"fb3ba7db33526f7869fd8fe07b9dfef308bbdae0","user":{"login":"DANS-KNAW","id":7858446,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTg0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7858446?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW","html_url":"https://github.com/DANS-KNAW","followers_url":"https://api.github.com/users/DANS-KNAW/followers","following_url":"https://api.github.com/users/DANS-KNAW/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW/orgs","repos_url":"https://api.github.com/users/DANS-KNAW/repos","events_url":"https://api.github.com/users/DANS-KNAW/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW/received_events","type":"Organization","site_admin":false},"repo":{"id":120271175,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyNzExNzU=","name":"easy-deposit-api","full_name":"DANS-KNAW/easy-deposit-api","owner":{"login":"DANS-KNAW","id":7858446,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTg0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7858446?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW","html_url":"https://github.com/DANS-KNAW","followers_url":"https://api.github.com/users/DANS-KNAW/followers","following_url":"https://api.github.com/users/DANS-KNAW/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW/orgs","repos_url":"https://api.github.com/users/DANS-KNAW/repos","events_url":"https://api.github.com/users/DANS-KNAW/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DANS-KNAW/easy-deposit-api","description":"JSON-based depositing service","fork":false,"url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api","forks_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/forks","keys_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/teams","hooks_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/hooks","issue_events_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/issues/events{/number}","events_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/events","assignees_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/assignees{/user}","branches_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/branches{/branch}","tags_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/tags","blobs_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/statuses/{sha}","languages_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/languages","stargazers_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/stargazers","contributors_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/contributors","subscribers_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/subscribers","subscription_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/subscription","commits_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/contents/{+path}","compare_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/merges","archive_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/downloads","issues_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/issues{/number}","pulls_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls{/number}","milestones_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/milestones{/number}","notifications_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/labels{/name}","releases_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/releases{/id}","deployments_url":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/deployments","created_at":"2018-02-05T07:41:05Z","updated_at":"2018-07-30T08:56:46Z","pushed_at":"2018-08-02T09:28:51Z","git_url":"git://github.com/DANS-KNAW/easy-deposit-api.git","ssh_url":"git@github.com:DANS-KNAW/easy-deposit-api.git","clone_url":"https://github.com/DANS-KNAW/easy-deposit-api.git","svn_url":"https://github.com/DANS-KNAW/easy-deposit-api","homepage":"https://dans-knaw.github.io/easy-deposit-api","size":5003,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/59"},"html":{"href":"https://github.com/DANS-KNAW/easy-deposit-api/pull/59"},"issue":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/issues/59"},"comments":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/DANS-KNAW/easy-deposit-api/statuses/0b6e5fbe95007be5c7ec3f693a308886b129fdbe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lindareijnhoudt"}}