{"action":"created","issue":{"url":"https://api.github.com/repos/HHogg/remarkable-react/issues/14","repository_url":"https://api.github.com/repos/HHogg/remarkable-react","labels_url":"https://api.github.com/repos/HHogg/remarkable-react/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/HHogg/remarkable-react/issues/14/comments","events_url":"https://api.github.com/repos/HHogg/remarkable-react/issues/14/events","html_url":"https://github.com/HHogg/remarkable-react/pull/14","id":294192648,"number":14,"title":"fix: enable returning boolean false from props mapping function","user":{"login":"DxCx","id":1080411,"avatar_url":"https://avatars1.githubusercontent.com/u/1080411?v=4","gravatar_id":"","url":"https://api.github.com/users/DxCx","html_url":"https://github.com/DxCx","followers_url":"https://api.github.com/users/DxCx/followers","following_url":"https://api.github.com/users/DxCx/following{/other_user}","gists_url":"https://api.github.com/users/DxCx/gists{/gist_id}","starred_url":"https://api.github.com/users/DxCx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DxCx/subscriptions","organizations_url":"https://api.github.com/users/DxCx/orgs","repos_url":"https://api.github.com/users/DxCx/repos","events_url":"https://api.github.com/users/DxCx/events{/privacy}","received_events_url":"https://api.github.com/users/DxCx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-04T12:15:21Z","updated_at":"2018-02-06T10:46:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/HHogg/remarkable-react/pulls/14","html_url":"https://github.com/HHogg/remarkable-react/pull/14","diff_url":"https://github.com/HHogg/remarkable-react/pull/14.diff","patch_url":"https://github.com/HHogg/remarkable-react/pull/14.patch"},"body":"With current code if mapper function return { value: false } it will take original propValue.\r\nthis patch will take value key as is if exists.\r\n\r\nP.S\r\nwould be great to get a new npm release after this is merged ^_^"},"comment":{"url":"https://api.github.com/repos/HHogg/remarkable-react/issues/comments/363384131","html_url":"https://github.com/HHogg/remarkable-react/pull/14#issuecomment-363384131","issue_url":"https://api.github.com/repos/HHogg/remarkable-react/issues/14","id":363384131,"user":{"login":"HHogg","id":7130591,"avatar_url":"https://avatars0.githubusercontent.com/u/7130591?v=4","gravatar_id":"","url":"https://api.github.com/users/HHogg","html_url":"https://github.com/HHogg","followers_url":"https://api.github.com/users/HHogg/followers","following_url":"https://api.github.com/users/HHogg/following{/other_user}","gists_url":"https://api.github.com/users/HHogg/gists{/gist_id}","starred_url":"https://api.github.com/users/HHogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HHogg/subscriptions","organizations_url":"https://api.github.com/users/HHogg/orgs","repos_url":"https://api.github.com/users/HHogg/repos","events_url":"https://api.github.com/users/HHogg/events{/privacy}","received_events_url":"https://api.github.com/users/HHogg/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T10:46:36Z","updated_at":"2018-02-06T10:46:36Z","author_association":"OWNER","body":"Thanks for fixing this @DxCx. Just two things before it can be merged. \r\n\r\n1) This repo uses semantic-release so an npm release will happen automagically when it's merged. Just need to amend your commit message slightly to ... \r\n\r\n```\r\nfix(Renderer): enable returning boolean false from props mapping function\r\n```\r\n\r\n2) Would you mind adding a test to check boolean props? "}}
{"actor":{"display_login":"HHogg"}}