{"action":"created","comment":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments/220286470","pull_request_review_id":158656041,"id":220286470,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDI4NjQ3MA==","diff_hunk":"@@ -0,0 +1,24 @@\n+# -*- coding: UTF-8 -*-\r\n+# A part of NonVisual Desktop Access (NVDA)\r\n+# Copyright (C) 2018 NV Access Limited, Łukasz Golonka\r\n+# This file may be used under the terms of the GNU General Public License, version 2 or later.\r\n+# For more details see: https://www.gnu.org/licenses/gpl-2.0.html\r\n+\r\n+\"\"\" Under older builds of Windows 10 (from RTM release to  Creators Update) dllhost is used to display a properties window. \r\n+Read-Only edit boxes in it can contain dates that include unwanted left-to-right and right-to-left indicator characters.\r\n+This simply imports a proper class from explorer app module, and maps it to a edit control.\r\n+\"\"\"\r\n+\r\n+import appModuleHandler\r\n+from .explorer import ReadOnlyEditBox\r\n+\r\n+class AppModule(appModuleHandler.AppModule):\r\n+\r\n+\tdef chooseNVDAObjectOverlayClasses(self, obj, clsList):\r\n+\t\twindowClass = obj.windowClassName\r\n+\r\n+\t\tif windowClass == \"Edit\":\r\n+\t\t\tclsList.insert(0, ReadOnlyEditBox)\r\n+\t\t\treturn\r","path":"source/appModules/dllhost.py","position":22,"original_position":22,"commit_id":"97c01b53a91cffc09bc2b5297c83363f8fa8d354","original_commit_id":"97c01b53a91cffc09bc2b5297c83363f8fa8d354","user":{"login":"dkager","id":3109617,"node_id":"MDQ6VXNlcjMxMDk2MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3109617?v=4","gravatar_id":"","url":"https://api.github.com/users/dkager","html_url":"https://github.com/dkager","followers_url":"https://api.github.com/users/dkager/followers","following_url":"https://api.github.com/users/dkager/following{/other_user}","gists_url":"https://api.github.com/users/dkager/gists{/gist_id}","starred_url":"https://api.github.com/users/dkager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkager/subscriptions","organizations_url":"https://api.github.com/users/dkager/orgs","repos_url":"https://api.github.com/users/dkager/repos","events_url":"https://api.github.com/users/dkager/events{/privacy}","received_events_url":"https://api.github.com/users/dkager/received_events","type":"User","site_admin":false},"body":"This return statement is redundant because the function ends here anyway.","created_at":"2018-09-25T17:35:24Z","updated_at":"2018-09-25T17:39:08Z","html_url":"https://github.com/nvaccess/nvda/pull/8643#discussion_r220286470","pull_request_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8643","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments/220286470"},"html":{"href":"https://github.com/nvaccess/nvda/pull/8643#discussion_r220286470"},"pull_request":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8643"}}},"pull_request":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/8643","id":209211854,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjExODU0","html_url":"https://github.com/nvaccess/nvda/pull/8643","diff_url":"https://github.com/nvaccess/nvda/pull/8643.diff","patch_url":"https://github.com/nvaccess/nvda/pull/8643.patch","issue_url":"https://api.github.com/repos/nvaccess/nvda/issues/8643","number":8643,"state":"open","locked":false,"title":"Remove RTL and LTR marks from taskbar clock text and from edit boxes in a properties window","user":{"login":"lukaszgo1","id":11059719,"node_id":"MDQ6VXNlcjExMDU5NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/11059719?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszgo1","html_url":"https://github.com/lukaszgo1","followers_url":"https://api.github.com/users/lukaszgo1/followers","following_url":"https://api.github.com/users/lukaszgo1/following{/other_user}","gists_url":"https://api.github.com/users/lukaszgo1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszgo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszgo1/subscriptions","organizations_url":"https://api.github.com/users/lukaszgo1/orgs","repos_url":"https://api.github.com/users/lukaszgo1/repos","events_url":"https://api.github.com/users/lukaszgo1/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszgo1/received_events","type":"User","site_admin":false},"body":"### Link to issue number:\r\nFixes #8361\r\n### Summary of the issue:\r\nRight-to-left and left-to-right characters In the taskbar clock and in the read-only edit boxes in a properties  window was annoying when reading character by character, or when displayed on a braille display.\r\n### Description of how this pull request fixes the issue:\r\nThe characters are removed from clock name and value, from read-only edit boxes in Windows Explorer,, and from read-only edit boxes in dllhost, which is responsible for displaying properties window under older builds of Windows 10.\r\n### Testing performed:\r\nTested, that the characters are gone in speech and in braille under all supported versions of Windows. The test build was also tested by @DrSooom, and he also confirms, that the issue is fixed.\r\n### Known issues with pull request:\r\n1. I’ve removed Right-to-left character from the clock, however I haven’t seen it there. Removing it doesn’t hurt, and for right-to-left languages it might be present.\r\n2. The RTL and LTR marks are defined three times in the code. It will be nice to clean this up, but I have no idea where to place them to avoid this duplication.\r\n### Change log entry:\r\nThe removal from the clock icon was covered by #5729 so only remaining thing is\r\n\r\nSection:  Bug fixes\r\n\r\nNVDA no longer reports (LTR and RTL marks) in Braille or per-character speech when accessing the properties window.","created_at":"2018-08-17T17:32:46Z","updated_at":"2018-09-25T17:39:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb700c4924d537586283f7fab184c081f052697a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8643/commits","review_comments_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8643/comments","review_comment_url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nvaccess/nvda/issues/8643/comments","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/97c01b53a91cffc09bc2b5297c83363f8fa8d354","head":{"label":"lukaszgo1:I8361","ref":"I8361","sha":"97c01b53a91cffc09bc2b5297c83363f8fa8d354","user":{"login":"lukaszgo1","id":11059719,"node_id":"MDQ6VXNlcjExMDU5NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/11059719?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszgo1","html_url":"https://github.com/lukaszgo1","followers_url":"https://api.github.com/users/lukaszgo1/followers","following_url":"https://api.github.com/users/lukaszgo1/following{/other_user}","gists_url":"https://api.github.com/users/lukaszgo1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszgo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszgo1/subscriptions","organizations_url":"https://api.github.com/users/lukaszgo1/orgs","repos_url":"https://api.github.com/users/lukaszgo1/repos","events_url":"https://api.github.com/users/lukaszgo1/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszgo1/received_events","type":"User","site_admin":false},"repo":{"id":134272622,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyNzI2MjI=","name":"nvda","full_name":"lukaszgo1/nvda","private":false,"owner":{"login":"lukaszgo1","id":11059719,"node_id":"MDQ6VXNlcjExMDU5NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/11059719?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszgo1","html_url":"https://github.com/lukaszgo1","followers_url":"https://api.github.com/users/lukaszgo1/followers","following_url":"https://api.github.com/users/lukaszgo1/following{/other_user}","gists_url":"https://api.github.com/users/lukaszgo1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszgo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszgo1/subscriptions","organizations_url":"https://api.github.com/users/lukaszgo1/orgs","repos_url":"https://api.github.com/users/lukaszgo1/repos","events_url":"https://api.github.com/users/lukaszgo1/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszgo1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lukaszgo1/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":true,"url":"https://api.github.com/repos/lukaszgo1/nvda","forks_url":"https://api.github.com/repos/lukaszgo1/nvda/forks","keys_url":"https://api.github.com/repos/lukaszgo1/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukaszgo1/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukaszgo1/nvda/teams","hooks_url":"https://api.github.com/repos/lukaszgo1/nvda/hooks","issue_events_url":"https://api.github.com/repos/lukaszgo1/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/lukaszgo1/nvda/events","assignees_url":"https://api.github.com/repos/lukaszgo1/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/lukaszgo1/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/lukaszgo1/nvda/tags","blobs_url":"https://api.github.com/repos/lukaszgo1/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukaszgo1/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukaszgo1/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukaszgo1/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukaszgo1/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/lukaszgo1/nvda/languages","stargazers_url":"https://api.github.com/repos/lukaszgo1/nvda/stargazers","contributors_url":"https://api.github.com/repos/lukaszgo1/nvda/contributors","subscribers_url":"https://api.github.com/repos/lukaszgo1/nvda/subscribers","subscription_url":"https://api.github.com/repos/lukaszgo1/nvda/subscription","commits_url":"https://api.github.com/repos/lukaszgo1/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukaszgo1/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukaszgo1/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukaszgo1/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukaszgo1/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/lukaszgo1/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukaszgo1/nvda/merges","archive_url":"https://api.github.com/repos/lukaszgo1/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukaszgo1/nvda/downloads","issues_url":"https://api.github.com/repos/lukaszgo1/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/lukaszgo1/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/lukaszgo1/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/lukaszgo1/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukaszgo1/nvda/labels{/name}","releases_url":"https://api.github.com/repos/lukaszgo1/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/lukaszgo1/nvda/deployments","created_at":"2018-05-21T13:25:42Z","updated_at":"2018-09-19T17:50:23Z","pushed_at":"2018-09-19T17:50:05Z","git_url":"git://github.com/lukaszgo1/nvda.git","ssh_url":"git@github.com:lukaszgo1/nvda.git","clone_url":"https://github.com/lukaszgo1/nvda.git","svn_url":"https://github.com/lukaszgo1/nvda","homepage":null,"size":153040,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nvaccess:master","ref":"master","sha":"8e2df9fdec6a5a3d9f47ee9290d9584dacf7bcc9","user":{"login":"nvaccess","id":4166525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjY1MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"repo":{"id":45885732,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg4NTczMg==","name":"nvda","full_name":"nvaccess/nvda","private":false,"owner":{"login":"nvaccess","id":4166525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjY1MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nvaccess/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":false,"url":"https://api.github.com/repos/nvaccess/nvda","forks_url":"https://api.github.com/repos/nvaccess/nvda/forks","keys_url":"https://api.github.com/repos/nvaccess/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvaccess/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvaccess/nvda/teams","hooks_url":"https://api.github.com/repos/nvaccess/nvda/hooks","issue_events_url":"https://api.github.com/repos/nvaccess/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/nvaccess/nvda/events","assignees_url":"https://api.github.com/repos/nvaccess/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/nvaccess/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/nvaccess/nvda/tags","blobs_url":"https://api.github.com/repos/nvaccess/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvaccess/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvaccess/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvaccess/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/nvaccess/nvda/languages","stargazers_url":"https://api.github.com/repos/nvaccess/nvda/stargazers","contributors_url":"https://api.github.com/repos/nvaccess/nvda/contributors","subscribers_url":"https://api.github.com/repos/nvaccess/nvda/subscribers","subscription_url":"https://api.github.com/repos/nvaccess/nvda/subscription","commits_url":"https://api.github.com/repos/nvaccess/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvaccess/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvaccess/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvaccess/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvaccess/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/nvaccess/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvaccess/nvda/merges","archive_url":"https://api.github.com/repos/nvaccess/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvaccess/nvda/downloads","issues_url":"https://api.github.com/repos/nvaccess/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/nvaccess/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/nvaccess/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/nvaccess/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvaccess/nvda/labels{/name}","releases_url":"https://api.github.com/repos/nvaccess/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/nvaccess/nvda/deployments","created_at":"2015-11-10T03:47:11Z","updated_at":"2018-09-25T02:27:57Z","pushed_at":"2018-09-25T12:37:21Z","git_url":"git://github.com/nvaccess/nvda.git","ssh_url":"git@github.com:nvaccess/nvda.git","clone_url":"https://github.com/nvaccess/nvda.git","svn_url":"https://github.com/nvaccess/nvda","homepage":null,"size":154739,"stargazers_count":549,"watchers_count":549,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":226,"mirror_url":null,"archived":false,"open_issues_count":2357,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":226,"open_issues":2357,"watchers":549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8643"},"html":{"href":"https://github.com/nvaccess/nvda/pull/8643"},"issue":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/8643"},"comments":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/8643/comments"},"review_comments":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8643/comments"},"review_comment":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8643/commits"},"statuses":{"href":"https://api.github.com/repos/nvaccess/nvda/statuses/97c01b53a91cffc09bc2b5297c83363f8fa8d354"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dkager"}}