{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/224921629","pull_request_review_id":164417302,"id":224921629,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDkyMTYyOQ==","diff_hunk":"@@ -245,6 +254,19 @@ def ensure(self):\n             change_needed = True\n             boot_firmware_required = True\n \n+        if self.vm.config.bootOptions.efiSecureBootEnabled != self.params.get('secure_boot_enabled'):\n+            if self.params.get('secure_boot_enabled') is True and self.params.get('boot_firmware') == \"bios\":\n+                self.module.fail_json(msg=\"EFI secure boot cannot be enabled when boot_firmware = bios, but both are specified\")\n+\n+            # If the user is not specifying boot_firmware, make sure they aren't trying to enable it on a\n+            # system with boot_firmware already set to 'bios'\n+            if self.params.get('secure_boot_enabled') is True and self.params.get('boot_firmware') is None:\n+                if self.vm.config.firmware == 'bios':","path":"lib/ansible/modules/cloud/vmware/vmware_guest_boot_manager.py","position":46,"original_position":46,"commit_id":"8c76caf15c05f6ca8a0d56f2acac0400348d14c7","original_commit_id":"8c76caf15c05f6ca8a0d56f2acac0400348d14c7","user":{"login":"healem","id":10199452,"node_id":"MDQ6VXNlcjEwMTk5NDUy","avatar_url":"https://avatars1.githubusercontent.com/u/10199452?v=4","gravatar_id":"","url":"https://api.github.com/users/healem","html_url":"https://github.com/healem","followers_url":"https://api.github.com/users/healem/followers","following_url":"https://api.github.com/users/healem/following{/other_user}","gists_url":"https://api.github.com/users/healem/gists{/gist_id}","starred_url":"https://api.github.com/users/healem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/healem/subscriptions","organizations_url":"https://api.github.com/users/healem/orgs","repos_url":"https://api.github.com/users/healem/repos","events_url":"https://api.github.com/users/healem/events{/privacy}","received_events_url":"https://api.github.com/users/healem/received_events","type":"User","site_admin":false},"body":"Will do","created_at":"2018-10-12T21:37:32Z","updated_at":"2018-10-12T21:37:32Z","html_url":"https://github.com/ansible/ansible/pull/46717#discussion_r224921629","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/46717","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/224921629"},"html":{"href":"https://github.com/ansible/ansible/pull/46717#discussion_r224921629"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/46717"}},"in_reply_to_id":224913710},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/46717","id":221586535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTg2NTM1","html_url":"https://github.com/ansible/ansible/pull/46717","diff_url":"https://github.com/ansible/ansible/pull/46717.diff","patch_url":"https://github.com/ansible/ansible/pull/46717.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/46717","number":46717,"state":"open","locked":false,"title":"VMware: Added secure boot enable/disable to vmware_guest_boot_manager.","user":{"login":"healem","id":10199452,"node_id":"MDQ6VXNlcjEwMTk5NDUy","avatar_url":"https://avatars1.githubusercontent.com/u/10199452?v=4","gravatar_id":"","url":"https://api.github.com/users/healem","html_url":"https://github.com/healem","followers_url":"https://api.github.com/users/healem/followers","following_url":"https://api.github.com/users/healem/following{/other_user}","gists_url":"https://api.github.com/users/healem/gists{/gist_id}","starred_url":"https://api.github.com/users/healem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/healem/subscriptions","organizations_url":"https://api.github.com/users/healem/orgs","repos_url":"https://api.github.com/users/healem/repos","events_url":"https://api.github.com/users/healem/events{/privacy}","received_events_url":"https://api.github.com/users/healem/received_events","type":"User","site_admin":false},"body":"\r\n##### SUMMARY\r\n<!--- Describe the change below, including rationale and design decisions -->\r\nModifying the boot order has no effect on VMs with secure_boot enabled.  This pull request adds the state of secure_boot to facts and the ability to enable/disable secure_boot for the VM.\r\n\r\n<!--- HINT: Include \"Fixes #nnn\" if you are fixing an existing issue -->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n- Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Write the short name of the module, plugin, task or feature below -->\r\nvmware_guest_boot_manager module\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes -->\r\n```paste below\r\nansible 2.8.0.dev0 (vsphereCopy 1cfa4c1228) last updated 2018/10/09 17:46:32 (GMT +000)\r\n  config file = None\r\n  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /ansible/lib/ansible\r\n  executable location = /ansible/bin/ansible\r\n  python version = 2.7.15 (default, Sep 12 2018, 02:38:23) [GCC 6.4.0]\r\n```\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!--- Include additional information to help people understand the change here -->\r\n<!--- A step-by-step reproduction of the problem is helpful if there is no related issue -->\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```paste below\r\n\r\n```\r\n","created_at":"2018-10-09T21:09:18Z","updated_at":"2018-10-12T21:37:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f17ca6e74e43b7d9d159013869c8691ac9d677bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":61528803,"node_id":"MDU6TGFiZWw2MTUyODgwMw==","url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":501518759,"node_id":"MDU6TGFiZWw1MDE1MTg3NTk=","url":"https://api.github.com/repos/ansible/ansible/labels/community_review","name":"community_review","color":"f9d0c4","default":false},{"id":852590921,"node_id":"MDU6TGFiZWw4NTI1OTA5MjE=","url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":723150340,"node_id":"MDU6TGFiZWw3MjMxNTAzNDA=","url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"c2e0c6","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":427121291,"node_id":"MDU6TGFiZWw0MjcxMjEyOTE=","url":"https://api.github.com/repos/ansible/ansible/labels/vmware","name":"vmware","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/46717/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/46717/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/46717/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/8c76caf15c05f6ca8a0d56f2acac0400348d14c7","head":{"label":"healem:secureBoot","ref":"secureBoot","sha":"8c76caf15c05f6ca8a0d56f2acac0400348d14c7","user":{"login":"healem","id":10199452,"node_id":"MDQ6VXNlcjEwMTk5NDUy","avatar_url":"https://avatars1.githubusercontent.com/u/10199452?v=4","gravatar_id":"","url":"https://api.github.com/users/healem","html_url":"https://github.com/healem","followers_url":"https://api.github.com/users/healem/followers","following_url":"https://api.github.com/users/healem/following{/other_user}","gists_url":"https://api.github.com/users/healem/gists{/gist_id}","starred_url":"https://api.github.com/users/healem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/healem/subscriptions","organizations_url":"https://api.github.com/users/healem/orgs","repos_url":"https://api.github.com/users/healem/repos","events_url":"https://api.github.com/users/healem/events{/privacy}","received_events_url":"https://api.github.com/users/healem/received_events","type":"User","site_admin":false},"repo":{"id":149670011,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NzAwMTE=","name":"ansible","full_name":"healem/ansible","private":false,"owner":{"login":"healem","id":10199452,"node_id":"MDQ6VXNlcjEwMTk5NDUy","avatar_url":"https://avatars1.githubusercontent.com/u/10199452?v=4","gravatar_id":"","url":"https://api.github.com/users/healem","html_url":"https://github.com/healem","followers_url":"https://api.github.com/users/healem/followers","following_url":"https://api.github.com/users/healem/following{/other_user}","gists_url":"https://api.github.com/users/healem/gists{/gist_id}","starred_url":"https://api.github.com/users/healem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/healem/subscriptions","organizations_url":"https://api.github.com/users/healem/orgs","repos_url":"https://api.github.com/users/healem/repos","events_url":"https://api.github.com/users/healem/events{/privacy}","received_events_url":"https://api.github.com/users/healem/received_events","type":"User","site_admin":false},"html_url":"https://github.com/healem/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/healem/ansible","forks_url":"https://api.github.com/repos/healem/ansible/forks","keys_url":"https://api.github.com/repos/healem/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/healem/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/healem/ansible/teams","hooks_url":"https://api.github.com/repos/healem/ansible/hooks","issue_events_url":"https://api.github.com/repos/healem/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/healem/ansible/events","assignees_url":"https://api.github.com/repos/healem/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/healem/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/healem/ansible/tags","blobs_url":"https://api.github.com/repos/healem/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/healem/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/healem/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/healem/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/healem/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/healem/ansible/languages","stargazers_url":"https://api.github.com/repos/healem/ansible/stargazers","contributors_url":"https://api.github.com/repos/healem/ansible/contributors","subscribers_url":"https://api.github.com/repos/healem/ansible/subscribers","subscription_url":"https://api.github.com/repos/healem/ansible/subscription","commits_url":"https://api.github.com/repos/healem/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/healem/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/healem/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/healem/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/healem/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/healem/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/healem/ansible/merges","archive_url":"https://api.github.com/repos/healem/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/healem/ansible/downloads","issues_url":"https://api.github.com/repos/healem/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/healem/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/healem/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/healem/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/healem/ansible/labels{/name}","releases_url":"https://api.github.com/repos/healem/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/healem/ansible/deployments","created_at":"2018-09-20T20:59:28Z","updated_at":"2018-10-08T17:22:28Z","pushed_at":"2018-10-12T16:47:14Z","git_url":"git://github.com/healem/ansible.git","ssh_url":"git@github.com:healem/ansible.git","clone_url":"https://github.com/healem/ansible.git","svn_url":"https://github.com/healem/ansible","homepage":"https://www.ansible.com/","size":134814,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"40c9301b2738108e0b68ccf47da48153de257c96","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-10-12T21:08:21Z","pushed_at":"2018-10-12T21:37:19Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":143226,"stargazers_count":33088,"watchers_count":33088,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13094,"mirror_url":null,"archived":false,"open_issues_count":5599,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13094,"open_issues":5599,"watchers":33088,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/46717"},"html":{"href":"https://github.com/ansible/ansible/pull/46717"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/46717"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/46717/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/46717/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/46717/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/8c76caf15c05f6ca8a0d56f2acac0400348d14c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"healem"}}