{"action":"created","issue":{"url":"https://api.github.com/repos/grayma/plm18-groupg/issues/2","repository_url":"https://api.github.com/repos/grayma/plm18-groupg","labels_url":"https://api.github.com/repos/grayma/plm18-groupg/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/grayma/plm18-groupg/issues/2/comments","events_url":"https://api.github.com/repos/grayma/plm18-groupg/issues/2/events","html_url":"https://github.com/grayma/plm18-groupg/issues/2","id":298444307,"number":2,"title":"Implement Rules","user":{"login":"grayma","id":1779593,"avatar_url":"https://avatars3.githubusercontent.com/u/1779593?v=4","gravatar_id":"","url":"https://api.github.com/users/grayma","html_url":"https://github.com/grayma","followers_url":"https://api.github.com/users/grayma/followers","following_url":"https://api.github.com/users/grayma/following{/other_user}","gists_url":"https://api.github.com/users/grayma/gists{/gist_id}","starred_url":"https://api.github.com/users/grayma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayma/subscriptions","organizations_url":"https://api.github.com/users/grayma/orgs","repos_url":"https://api.github.com/users/grayma/repos","events_url":"https://api.github.com/users/grayma/events{/privacy}","received_events_url":"https://api.github.com/users/grayma/received_events","type":"User","site_admin":false},"labels":[{"id":802129254,"url":"https://api.github.com/repos/grayma/plm18-groupg/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-20T01:18:46Z","updated_at":"2018-02-20T20:26:30Z","closed_at":null,"author_association":"OWNER","body":"We need Rule to do act as a validation for a single thing in the game. Every rule will be ran through on the validation of a move. Moves are a collection of old and new game state and old and new player state.\r\n\r\nSo a Rule will essentially compare old and new game and player state, look for a difference that it doesn't like (each Rule will be one particular thing), and then return false (?) if it doesn't like a state change? The thing I'm not sure about is if Rule will access the state in the Game object, or what.\r\n\r\nBecause this is Python and a lot of stuff is loosey-goosey, I don't want to either over-couple certain components, make abstraction/implementation a PITA, or just do it badly in general, so I would love to hear thoughts on this. I think what I have above is good, but I would love someone to shoot it down."},"comment":{"url":"https://api.github.com/repos/grayma/plm18-groupg/issues/comments/367107854","html_url":"https://github.com/grayma/plm18-groupg/issues/2#issuecomment-367107854","issue_url":"https://api.github.com/repos/grayma/plm18-groupg/issues/2","id":367107854,"user":{"login":"willglas","id":35304767,"avatar_url":"https://avatars0.githubusercontent.com/u/35304767?v=4","gravatar_id":"","url":"https://api.github.com/users/willglas","html_url":"https://github.com/willglas","followers_url":"https://api.github.com/users/willglas/followers","following_url":"https://api.github.com/users/willglas/following{/other_user}","gists_url":"https://api.github.com/users/willglas/gists{/gist_id}","starred_url":"https://api.github.com/users/willglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willglas/subscriptions","organizations_url":"https://api.github.com/users/willglas/orgs","repos_url":"https://api.github.com/users/willglas/repos","events_url":"https://api.github.com/users/willglas/events{/privacy}","received_events_url":"https://api.github.com/users/willglas/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T20:26:29Z","updated_at":"2018-02-20T20:26:29Z","author_association":"COLLABORATOR","body":"So just to clarify... What you're proposing here is a Rule class which will have many instances, and each instance will validate a different, unique rule for the game? So then each time a move is made by a player, each Rule will be passed the game state, player state, and the move, and then validate that move against the game/player state?"}}
{"actor":{"display_login":"willglas"}}