{"action":"created","comment":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments/180084834","pull_request_review_id":110442578,"id":180084834,"diff_hunk":"@@ -77,6 +79,9 @@ public boolean equals(Person person) {\n         return getName().equals(person.getName().fullName)\n                 && getAddress().equals(person.getAddress().value)\n                 && getPhone().equals(person.getPhone().value)\n-                && getEmail().equals(person.getEmail().value);\n+                && getEmail().equals(person.getEmail().value)\n+                && CollectionUtils.isEqualCollection(getTags(), person.getTags().stream()\n+                                                                                .map(tag -> tag.tagName)\n+                                                                                .collect(Collectors.toList()));","path":"src/test/java/guitests/guihandles/PersonCardHandle.java","position":17,"original_position":17,"commit_id":"5219a377b1cec19cb35fd3fc5f21c97db54ffe84","original_commit_id":"5219a377b1cec19cb35fd3fc5f21c97db54ffe84","user":{"login":"vivekscl","id":17037188,"avatar_url":"https://avatars0.githubusercontent.com/u/17037188?v=4","gravatar_id":"","url":"https://api.github.com/users/vivekscl","html_url":"https://github.com/vivekscl","followers_url":"https://api.github.com/users/vivekscl/followers","following_url":"https://api.github.com/users/vivekscl/following{/other_user}","gists_url":"https://api.github.com/users/vivekscl/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekscl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekscl/subscriptions","organizations_url":"https://api.github.com/users/vivekscl/orgs","repos_url":"https://api.github.com/users/vivekscl/repos","events_url":"https://api.github.com/users/vivekscl/events{/privacy}","received_events_url":"https://api.github.com/users/vivekscl/received_events","type":"User","site_admin":false},"body":">after ensuring the cardinality is the same between the List and the Set\r\n\r\nHmm, by cardinality do you mean the length of the `List` and `Set`? So only if the length is the same we should convert the `List` into a `Set`? But wouldn't that mean it's better just to convert the `person.getTags()` to a `List` and then use the library that was imported? ","created_at":"2018-04-09T12:57:34Z","updated_at":"2018-04-09T12:57:34Z","html_url":"https://github.com/se-edu/addressbook-level4/pull/844#discussion_r180084834","pull_request_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/844","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments/180084834"},"html":{"href":"https://github.com/se-edu/addressbook-level4/pull/844#discussion_r180084834"},"pull_request":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/844"}},"in_reply_to_id":179920605},"pull_request":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/844","id":173975814,"html_url":"https://github.com/se-edu/addressbook-level4/pull/844","diff_url":"https://github.com/se-edu/addressbook-level4/pull/844.diff","patch_url":"https://github.com/se-edu/addressbook-level4/pull/844.patch","issue_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/844","number":844,"state":"open","locked":false,"title":"Add different levels of comparison to equality methods of Person class #742","user":{"login":"vivekscl","id":17037188,"avatar_url":"https://avatars0.githubusercontent.com/u/17037188?v=4","gravatar_id":"","url":"https://api.github.com/users/vivekscl","html_url":"https://github.com/vivekscl","followers_url":"https://api.github.com/users/vivekscl/followers","following_url":"https://api.github.com/users/vivekscl/following{/other_user}","gists_url":"https://api.github.com/users/vivekscl/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekscl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekscl/subscriptions","organizations_url":"https://api.github.com/users/vivekscl/orgs","repos_url":"https://api.github.com/users/vivekscl/repos","events_url":"https://api.github.com/users/vivekscl/events{/privacy}","received_events_url":"https://api.github.com/users/vivekscl/received_events","type":"User","site_admin":false},"body":"Fixes #742 \r\n\r\nSome changes to note:\r\nIn `AddCommandSystemTest`, line 120 was changed from `assertCommandSuccess(CARL)` to `assertCommandSuccess(AMY)`  to test for duplicate persons in the next few lines as the duplicate person tests require the default person to be used, which is either AMY or BOB.\r\n\r\nWhile porting from [se-edu/addressbook-level2#122](https://github.com/se-edu/addressbook-level2/issues/122), I realized only name and phone were checked. Since email is a unique identifier for a person as well, I added that to the equality method.","created_at":"2018-03-09T10:55:58Z","updated_at":"2018-04-09T12:57:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d17a11927a7a76e01fbf2b07af41d61ec3c40e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":456150209,"url":"https://api.github.com/repos/se-edu/addressbook-level4/labels/s.Ongoing","name":"s.Ongoing","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/844/commits","review_comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/844/comments","review_comment_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/844/comments","statuses_url":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/5219a377b1cec19cb35fd3fc5f21c97db54ffe84","head":{"label":"vivekscl:742-person-equality-different-levels","ref":"742-person-equality-different-levels","sha":"5219a377b1cec19cb35fd3fc5f21c97db54ffe84","user":{"login":"vivekscl","id":17037188,"avatar_url":"https://avatars0.githubusercontent.com/u/17037188?v=4","gravatar_id":"","url":"https://api.github.com/users/vivekscl","html_url":"https://github.com/vivekscl","followers_url":"https://api.github.com/users/vivekscl/followers","following_url":"https://api.github.com/users/vivekscl/following{/other_user}","gists_url":"https://api.github.com/users/vivekscl/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekscl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekscl/subscriptions","organizations_url":"https://api.github.com/users/vivekscl/orgs","repos_url":"https://api.github.com/users/vivekscl/repos","events_url":"https://api.github.com/users/vivekscl/events{/privacy}","received_events_url":"https://api.github.com/users/vivekscl/received_events","type":"User","site_admin":false},"repo":{"id":114201636,"name":"addressbook-level4","full_name":"vivekscl/addressbook-level4","owner":{"login":"vivekscl","id":17037188,"avatar_url":"https://avatars0.githubusercontent.com/u/17037188?v=4","gravatar_id":"","url":"https://api.github.com/users/vivekscl","html_url":"https://github.com/vivekscl","followers_url":"https://api.github.com/users/vivekscl/followers","following_url":"https://api.github.com/users/vivekscl/following{/other_user}","gists_url":"https://api.github.com/users/vivekscl/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekscl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekscl/subscriptions","organizations_url":"https://api.github.com/users/vivekscl/orgs","repos_url":"https://api.github.com/users/vivekscl/repos","events_url":"https://api.github.com/users/vivekscl/events{/privacy}","received_events_url":"https://api.github.com/users/vivekscl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vivekscl/addressbook-level4","description":"Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/vivekscl/addressbook-level4","forks_url":"https://api.github.com/repos/vivekscl/addressbook-level4/forks","keys_url":"https://api.github.com/repos/vivekscl/addressbook-level4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vivekscl/addressbook-level4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vivekscl/addressbook-level4/teams","hooks_url":"https://api.github.com/repos/vivekscl/addressbook-level4/hooks","issue_events_url":"https://api.github.com/repos/vivekscl/addressbook-level4/issues/events{/number}","events_url":"https://api.github.com/repos/vivekscl/addressbook-level4/events","assignees_url":"https://api.github.com/repos/vivekscl/addressbook-level4/assignees{/user}","branches_url":"https://api.github.com/repos/vivekscl/addressbook-level4/branches{/branch}","tags_url":"https://api.github.com/repos/vivekscl/addressbook-level4/tags","blobs_url":"https://api.github.com/repos/vivekscl/addressbook-level4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vivekscl/addressbook-level4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vivekscl/addressbook-level4/git/refs{/sha}","trees_url":"https://api.github.com/repos/vivekscl/addressbook-level4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vivekscl/addressbook-level4/statuses/{sha}","languages_url":"https://api.github.com/repos/vivekscl/addressbook-level4/languages","stargazers_url":"https://api.github.com/repos/vivekscl/addressbook-level4/stargazers","contributors_url":"https://api.github.com/repos/vivekscl/addressbook-level4/contributors","subscribers_url":"https://api.github.com/repos/vivekscl/addressbook-level4/subscribers","subscription_url":"https://api.github.com/repos/vivekscl/addressbook-level4/subscription","commits_url":"https://api.github.com/repos/vivekscl/addressbook-level4/commits{/sha}","git_commits_url":"https://api.github.com/repos/vivekscl/addressbook-level4/git/commits{/sha}","comments_url":"https://api.github.com/repos/vivekscl/addressbook-level4/comments{/number}","issue_comment_url":"https://api.github.com/repos/vivekscl/addressbook-level4/issues/comments{/number}","contents_url":"https://api.github.com/repos/vivekscl/addressbook-level4/contents/{+path}","compare_url":"https://api.github.com/repos/vivekscl/addressbook-level4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vivekscl/addressbook-level4/merges","archive_url":"https://api.github.com/repos/vivekscl/addressbook-level4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vivekscl/addressbook-level4/downloads","issues_url":"https://api.github.com/repos/vivekscl/addressbook-level4/issues{/number}","pulls_url":"https://api.github.com/repos/vivekscl/addressbook-level4/pulls{/number}","milestones_url":"https://api.github.com/repos/vivekscl/addressbook-level4/milestones{/number}","notifications_url":"https://api.github.com/repos/vivekscl/addressbook-level4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vivekscl/addressbook-level4/labels{/name}","releases_url":"https://api.github.com/repos/vivekscl/addressbook-level4/releases{/id}","deployments_url":"https://api.github.com/repos/vivekscl/addressbook-level4/deployments","created_at":"2017-12-14T04:15:21Z","updated_at":"2018-04-05T05:34:27Z","pushed_at":"2018-04-07T17:25:22Z","git_url":"git://github.com/vivekscl/addressbook-level4.git","ssh_url":"git@github.com:vivekscl/addressbook-level4.git","clone_url":"https://github.com/vivekscl/addressbook-level4.git","svn_url":"https://github.com/vivekscl/addressbook-level4","homepage":"https://se-edu.github.io/addressbook-level4","size":7813,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"se-edu:master","ref":"master","sha":"285f0a1bf97537dffbcdcd2ec604edfa84ba4c5f","user":{"login":"se-edu","id":20763652,"avatar_url":"https://avatars2.githubusercontent.com/u/20763652?v=4","gravatar_id":"","url":"https://api.github.com/users/se-edu","html_url":"https://github.com/se-edu","followers_url":"https://api.github.com/users/se-edu/followers","following_url":"https://api.github.com/users/se-edu/following{/other_user}","gists_url":"https://api.github.com/users/se-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/se-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/se-edu/subscriptions","organizations_url":"https://api.github.com/users/se-edu/orgs","repos_url":"https://api.github.com/users/se-edu/repos","events_url":"https://api.github.com/users/se-edu/events{/privacy}","received_events_url":"https://api.github.com/users/se-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":65120941,"name":"addressbook-level4","full_name":"se-edu/addressbook-level4","owner":{"login":"se-edu","id":20763652,"avatar_url":"https://avatars2.githubusercontent.com/u/20763652?v=4","gravatar_id":"","url":"https://api.github.com/users/se-edu","html_url":"https://github.com/se-edu","followers_url":"https://api.github.com/users/se-edu/followers","following_url":"https://api.github.com/users/se-edu/following{/other_user}","gists_url":"https://api.github.com/users/se-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/se-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/se-edu/subscriptions","organizations_url":"https://api.github.com/users/se-edu/orgs","repos_url":"https://api.github.com/users/se-edu/repos","events_url":"https://api.github.com/users/se-edu/events{/privacy}","received_events_url":"https://api.github.com/users/se-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/se-edu/addressbook-level4","description":"Address Book sample application (Level 4)","fork":false,"url":"https://api.github.com/repos/se-edu/addressbook-level4","forks_url":"https://api.github.com/repos/se-edu/addressbook-level4/forks","keys_url":"https://api.github.com/repos/se-edu/addressbook-level4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/se-edu/addressbook-level4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/se-edu/addressbook-level4/teams","hooks_url":"https://api.github.com/repos/se-edu/addressbook-level4/hooks","issue_events_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/events{/number}","events_url":"https://api.github.com/repos/se-edu/addressbook-level4/events","assignees_url":"https://api.github.com/repos/se-edu/addressbook-level4/assignees{/user}","branches_url":"https://api.github.com/repos/se-edu/addressbook-level4/branches{/branch}","tags_url":"https://api.github.com/repos/se-edu/addressbook-level4/tags","blobs_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/refs{/sha}","trees_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/{sha}","languages_url":"https://api.github.com/repos/se-edu/addressbook-level4/languages","stargazers_url":"https://api.github.com/repos/se-edu/addressbook-level4/stargazers","contributors_url":"https://api.github.com/repos/se-edu/addressbook-level4/contributors","subscribers_url":"https://api.github.com/repos/se-edu/addressbook-level4/subscribers","subscription_url":"https://api.github.com/repos/se-edu/addressbook-level4/subscription","commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/commits{/sha}","git_commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/commits{/sha}","comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/comments{/number}","issue_comment_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/comments{/number}","contents_url":"https://api.github.com/repos/se-edu/addressbook-level4/contents/{+path}","compare_url":"https://api.github.com/repos/se-edu/addressbook-level4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/se-edu/addressbook-level4/merges","archive_url":"https://api.github.com/repos/se-edu/addressbook-level4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/se-edu/addressbook-level4/downloads","issues_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues{/number}","pulls_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls{/number}","milestones_url":"https://api.github.com/repos/se-edu/addressbook-level4/milestones{/number}","notifications_url":"https://api.github.com/repos/se-edu/addressbook-level4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/se-edu/addressbook-level4/labels{/name}","releases_url":"https://api.github.com/repos/se-edu/addressbook-level4/releases{/id}","deployments_url":"https://api.github.com/repos/se-edu/addressbook-level4/deployments","created_at":"2016-08-07T07:17:26Z","updated_at":"2018-04-08T22:47:33Z","pushed_at":"2018-04-09T03:29:37Z","git_url":"git://github.com/se-edu/addressbook-level4.git","ssh_url":"git@github.com:se-edu/addressbook-level4.git","clone_url":"https://github.com/se-edu/addressbook-level4.git","svn_url":"https://github.com/se-edu/addressbook-level4","homepage":"https://se-edu.github.io/addressbook-level4","size":18989,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":989,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":989,"open_issues":112,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/844"},"html":{"href":"https://github.com/se-edu/addressbook-level4/pull/844"},"issue":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/issues/844"},"comments":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/issues/844/comments"},"review_comments":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/844/comments"},"review_comment":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/844/commits"},"statuses":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/5219a377b1cec19cb35fd3fc5f21c97db54ffe84"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vivekscl"}}