{"action":"created","comment":{"url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/comments/231332780","pull_request_review_id":172279640,"id":231332780,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTMzMjc4MA==","diff_hunk":"@@ -1,27 +1,32 @@\n-from sklearn.decomposition import PCA, DictionaryLearning\n+from sklearn.decomposition import (\n+    PCA,\n+    DictionaryLearning,\n+    MiniBatchDictionaryLearning,\n+)\n \n from .common import Benchmark\n-from .datasets import _mnist_dataset\n+from .datasets import _mnist_dataset, _decomposition_dataset\n \n \n class PCA_bench(Benchmark):\n     \"\"\"\n     Benchmarks for PCA.\n     \"\"\"\n+\n     # params = (svd_solver)\n     param_names = ['params']\n-    params = ([('full',),\n-               ('arpack',),\n-               ('randomized',)],)\n+    params = ([('full', ), ('arpack', ), ('randomized', )], )","path":"benchmarks/decomposition.py","position":23,"original_position":23,"commit_id":"9700eb5626b524b44acb34cd0055be6a8f3fe43a","original_commit_id":"9700eb5626b524b44acb34cd0055be6a8f3fe43a","user":{"login":"anton-malakhov","id":7475946,"node_id":"MDQ6VXNlcjc0NzU5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/7475946?v=4","gravatar_id":"","url":"https://api.github.com/users/anton-malakhov","html_url":"https://github.com/anton-malakhov","followers_url":"https://api.github.com/users/anton-malakhov/followers","following_url":"https://api.github.com/users/anton-malakhov/following{/other_user}","gists_url":"https://api.github.com/users/anton-malakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-malakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-malakhov/subscriptions","organizations_url":"https://api.github.com/users/anton-malakhov/orgs","repos_url":"https://api.github.com/users/anton-malakhov/repos","events_url":"https://api.github.com/users/anton-malakhov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-malakhov/received_events","type":"User","site_admin":false},"body":"doesn't it overwrite the n_jobs params? This (and other) benches need to take n_jobs into account","created_at":"2018-11-06T23:28:53Z","updated_at":"2018-11-06T23:31:17Z","html_url":"https://github.com/IntelPython/scikit-learn-bench-contrib/pull/1#discussion_r231332780","pull_request_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/comments/231332780"},"html":{"href":"https://github.com/IntelPython/scikit-learn-bench-contrib/pull/1#discussion_r231332780"},"pull_request":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/1","id":227091032,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDkxMDMy","html_url":"https://github.com/IntelPython/scikit-learn-bench-contrib/pull/1","diff_url":"https://github.com/IntelPython/scikit-learn-bench-contrib/pull/1.diff","patch_url":"https://github.com/IntelPython/scikit-learn-bench-contrib/pull/1.patch","issue_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues/1","number":1,"state":"open","locked":false,"title":"Benchmarks for up-streaming, part 2","user":{"login":"anton-malakhov","id":7475946,"node_id":"MDQ6VXNlcjc0NzU5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/7475946?v=4","gravatar_id":"","url":"https://api.github.com/users/anton-malakhov","html_url":"https://github.com/anton-malakhov","followers_url":"https://api.github.com/users/anton-malakhov/followers","following_url":"https://api.github.com/users/anton-malakhov/following{/other_user}","gists_url":"https://api.github.com/users/anton-malakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-malakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-malakhov/subscriptions","organizations_url":"https://api.github.com/users/anton-malakhov/orgs","repos_url":"https://api.github.com/users/anton-malakhov/repos","events_url":"https://api.github.com/users/anton-malakhov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-malakhov/received_events","type":"User","site_admin":false},"body":"Please review. @oleksandr-pavlyk @0just0 ","created_at":"2018-10-30T21:40:42Z","updated_at":"2018-11-06T23:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90215b8febc43ca9454929f5dc1da013c426cd6b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"oleksandr-pavlyk","id":21087696,"node_id":"MDQ6VXNlcjIxMDg3Njk2","avatar_url":"https://avatars0.githubusercontent.com/u/21087696?v=4","gravatar_id":"","url":"https://api.github.com/users/oleksandr-pavlyk","html_url":"https://github.com/oleksandr-pavlyk","followers_url":"https://api.github.com/users/oleksandr-pavlyk/followers","following_url":"https://api.github.com/users/oleksandr-pavlyk/following{/other_user}","gists_url":"https://api.github.com/users/oleksandr-pavlyk/gists{/gist_id}","starred_url":"https://api.github.com/users/oleksandr-pavlyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleksandr-pavlyk/subscriptions","organizations_url":"https://api.github.com/users/oleksandr-pavlyk/orgs","repos_url":"https://api.github.com/users/oleksandr-pavlyk/repos","events_url":"https://api.github.com/users/oleksandr-pavlyk/events{/privacy}","received_events_url":"https://api.github.com/users/oleksandr-pavlyk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/1/commits","review_comments_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/1/comments","review_comment_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues/1/comments","statuses_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/statuses/9700eb5626b524b44acb34cd0055be6a8f3fe43a","head":{"label":"IntelPython:dt/intel-benchmarks","ref":"dt/intel-benchmarks","sha":"9700eb5626b524b44acb34cd0055be6a8f3fe43a","user":{"login":"IntelPython","id":20491374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDkxMzc0","avatar_url":"https://avatars1.githubusercontent.com/u/20491374?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelPython","html_url":"https://github.com/IntelPython","followers_url":"https://api.github.com/users/IntelPython/followers","following_url":"https://api.github.com/users/IntelPython/following{/other_user}","gists_url":"https://api.github.com/users/IntelPython/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelPython/subscriptions","organizations_url":"https://api.github.com/users/IntelPython/orgs","repos_url":"https://api.github.com/users/IntelPython/repos","events_url":"https://api.github.com/users/IntelPython/events{/privacy}","received_events_url":"https://api.github.com/users/IntelPython/received_events","type":"Organization","site_admin":false},"repo":{"id":153806439,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM4MDY0Mzk=","name":"scikit-learn-bench-contrib","full_name":"IntelPython/scikit-learn-bench-contrib","private":false,"owner":{"login":"IntelPython","id":20491374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDkxMzc0","avatar_url":"https://avatars1.githubusercontent.com/u/20491374?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelPython","html_url":"https://github.com/IntelPython","followers_url":"https://api.github.com/users/IntelPython/followers","following_url":"https://api.github.com/users/IntelPython/following{/other_user}","gists_url":"https://api.github.com/users/IntelPython/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelPython/subscriptions","organizations_url":"https://api.github.com/users/IntelPython/orgs","repos_url":"https://api.github.com/users/IntelPython/repos","events_url":"https://api.github.com/users/IntelPython/events{/privacy}","received_events_url":"https://api.github.com/users/IntelPython/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IntelPython/scikit-learn-bench-contrib","description":"Benchmark suite for scikit-learn performances","fork":true,"url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib","forks_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/forks","keys_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/teams","hooks_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/hooks","issue_events_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/events","assignees_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/tags","blobs_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/languages","stargazers_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/stargazers","contributors_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/contributors","subscribers_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/subscribers","subscription_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/subscription","commits_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/merges","archive_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/downloads","issues_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/labels{/name}","releases_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/deployments","created_at":"2018-10-19T15:44:35Z","updated_at":"2018-10-30T21:30:26Z","pushed_at":"2018-11-01T11:51:24Z","git_url":"git://github.com/IntelPython/scikit-learn-bench-contrib.git","ssh_url":"git@github.com:IntelPython/scikit-learn-bench-contrib.git","clone_url":"https://github.com/IntelPython/scikit-learn-bench-contrib.git","svn_url":"https://github.com/IntelPython/scikit-learn-bench-contrib","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"IntelPython:master","ref":"master","sha":"11b5a86b91e81d9d20770acef72bc88ed15de0f3","user":{"login":"IntelPython","id":20491374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDkxMzc0","avatar_url":"https://avatars1.githubusercontent.com/u/20491374?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelPython","html_url":"https://github.com/IntelPython","followers_url":"https://api.github.com/users/IntelPython/followers","following_url":"https://api.github.com/users/IntelPython/following{/other_user}","gists_url":"https://api.github.com/users/IntelPython/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelPython/subscriptions","organizations_url":"https://api.github.com/users/IntelPython/orgs","repos_url":"https://api.github.com/users/IntelPython/repos","events_url":"https://api.github.com/users/IntelPython/events{/privacy}","received_events_url":"https://api.github.com/users/IntelPython/received_events","type":"Organization","site_admin":false},"repo":{"id":153806439,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM4MDY0Mzk=","name":"scikit-learn-bench-contrib","full_name":"IntelPython/scikit-learn-bench-contrib","private":false,"owner":{"login":"IntelPython","id":20491374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDkxMzc0","avatar_url":"https://avatars1.githubusercontent.com/u/20491374?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelPython","html_url":"https://github.com/IntelPython","followers_url":"https://api.github.com/users/IntelPython/followers","following_url":"https://api.github.com/users/IntelPython/following{/other_user}","gists_url":"https://api.github.com/users/IntelPython/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelPython/subscriptions","organizations_url":"https://api.github.com/users/IntelPython/orgs","repos_url":"https://api.github.com/users/IntelPython/repos","events_url":"https://api.github.com/users/IntelPython/events{/privacy}","received_events_url":"https://api.github.com/users/IntelPython/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IntelPython/scikit-learn-bench-contrib","description":"Benchmark suite for scikit-learn performances","fork":true,"url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib","forks_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/forks","keys_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/teams","hooks_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/hooks","issue_events_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/events","assignees_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/tags","blobs_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/languages","stargazers_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/stargazers","contributors_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/contributors","subscribers_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/subscribers","subscription_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/subscription","commits_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/merges","archive_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/downloads","issues_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/labels{/name}","releases_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/deployments","created_at":"2018-10-19T15:44:35Z","updated_at":"2018-10-30T21:30:26Z","pushed_at":"2018-11-01T11:51:24Z","git_url":"git://github.com/IntelPython/scikit-learn-bench-contrib.git","ssh_url":"git@github.com:IntelPython/scikit-learn-bench-contrib.git","clone_url":"https://github.com/IntelPython/scikit-learn-bench-contrib.git","svn_url":"https://github.com/IntelPython/scikit-learn-bench-contrib","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/1"},"html":{"href":"https://github.com/IntelPython/scikit-learn-bench-contrib/pull/1"},"issue":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues/1"},"comments":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/IntelPython/scikit-learn-bench-contrib/statuses/9700eb5626b524b44acb34cd0055be6a8f3fe43a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"anton-malakhov"}}