{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/215011758","pull_request_review_id":152179064,"id":215011758,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTAxMTc1OA==","diff_hunk":"@@ -429,23 +425,29 @@ func (k8sh *K8sHelper) IsPodWithLabelPresent(label string, namespace string) boo\n \treturn count > 0\n }\n \n-//WaitForLabeledPodToRun returns true if a Pod is running status or goes to Running status within 90s else returns false\n-func (k8sh *K8sHelper) WaitForLabeledPodToRun(label string, namespace string) error {\n+//WaitForLabeledPodsToRun returns true if a Pod is running status or goes to Running status within 90s else returns false","path":"tests/framework/utils/k8s_helper.go","position":17,"original_position":17,"commit_id":"f840e3574ea3ba985495d53c284a2c6b2334b868","original_commit_id":"f840e3574ea3ba985495d53c284a2c6b2334b868","user":{"login":"galexrt","id":3718398,"node_id":"MDQ6VXNlcjM3MTgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3718398?v=4","gravatar_id":"","url":"https://api.github.com/users/galexrt","html_url":"https://github.com/galexrt","followers_url":"https://api.github.com/users/galexrt/followers","following_url":"https://api.github.com/users/galexrt/following{/other_user}","gists_url":"https://api.github.com/users/galexrt/gists{/gist_id}","starred_url":"https://api.github.com/users/galexrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galexrt/subscriptions","organizations_url":"https://api.github.com/users/galexrt/orgs","repos_url":"https://api.github.com/users/galexrt/repos","events_url":"https://api.github.com/users/galexrt/events{/privacy}","received_events_url":"https://api.github.com/users/galexrt/received_events","type":"User","site_admin":false},"body":"Could you add a space here at the comment begin `// WaitForLa...`","created_at":"2018-09-04T18:01:14Z","updated_at":"2018-09-04T18:05:10Z","html_url":"https://github.com/rook/rook/pull/2018#discussion_r215011758","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/2018","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/215011758"},"html":{"href":"https://github.com/rook/rook/pull/2018#discussion_r215011758"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/2018"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/2018","id":207757001,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzU3MDAx","html_url":"https://github.com/rook/rook/pull/2018","diff_url":"https://github.com/rook/rook/pull/2018.diff","patch_url":"https://github.com/rook/rook/pull/2018.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/2018","number":2018,"state":"open","locked":false,"title":"Start mons with deployments instead of replicasets and rename the mons","user":{"login":"travisn","id":1048514,"node_id":"MDQ6VXNlcjEwNDg1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"body":"<!-- Please take a look at our [Contributing](https://rook.io/docs/rook/master/development-flow.html)\r\ndocumentation before submitting a Pull Request!\r\nThank you for contributing to Rook! -->\r\n\r\n**Description of your changes:**\r\nThe mon pods have two updates:\r\n- The mons are started with a Deployment instead of a ReplicaSet to simplify the upgrade implementation in the future. During upgrade, the old replicasets will be deleted and the new deployments will be created essentially with the same pod specs. \r\n- The mon names are now based on a letter instead of a number to be more consistent with other daemons. The mon names will increase alphabetically as mons are added or failover happens. If more than 26 mon names are needed due to failure, more than one letter will be used (the 27th mon will be `aa`). During upgrade, the legacy mon names with the numbers will be preserved. Afterwards, new mons will be created based on letters.\r\n\r\nTo implement the mon names, the internal `Name` property on mons is now two properties: `ResourceName` wherever a k8s resource name is needed (with the `rook-ceph-mon` prefix) and `DaemonName` to be used everywhere else.\r\n\r\nI am working on an integration test to verify the upgrade of the mons, but it is turning into a big change so I'll submit it as a separate PR.\r\n\r\n**Which issue is resolved by this Pull Request:**\r\nResolves #1751 \r\n\r\nThis gives us pods and deployments that look like the following. OSDs are the only pods with numerical IDs.\r\n```\r\n$ kubectl -n rook-ceph get pod\r\nNAME                                     READY     STATUS      RESTARTS   AGE\r\nrook-ceph-mds-myfs-858dd667bb-6z294      1/1       Running     0          17s\r\nrook-ceph-mds-myfs-858dd667bb-r7zsp      1/1       Running     0          17s\r\nrook-ceph-mgr-a-9c44495df-8cbmv          1/1       Running     0          4m\r\nrook-ceph-mon-a-5cbdd9bff5-rl8hf         1/1       Running     0          5m\r\nrook-ceph-mon-b-5cff7458f6-58szd         1/1       Running     0          4m\r\nrook-ceph-mon-c-6fdc4f8465-c756f         1/1       Running     0          4m\r\nrook-ceph-osd-id-0-f688bd659-ftt57       1/1       Running     0          4m\r\nrook-ceph-osd-prepare-minikube-ln9sq     0/1       Completed   0          4m\r\nrook-ceph-rgw-my-store-ddc6c4d9c-gp4wk   1/1       Running     0          2s\r\n\r\n$ kubectl -n rook-ceph get deploy\r\nNAME                     DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE\r\nrook-ceph-mds-myfs       2         2         2            2           31s\r\nrook-ceph-mgr-a          1         1         1            1           4m\r\nrook-ceph-mon-a          1         1         1            1           5m\r\nrook-ceph-mon-b          1         1         1            1           5m\r\nrook-ceph-mon-c          1         1         1            1           4m\r\nrook-ceph-osd-id-0       1         1         1            1           4m\r\nrook-ceph-rgw-my-store   1         1         1            1           16s\r\n```\r\n\r\n**Checklist:**\r\n- [x] Documentation has been updated, if necessary.\r\n- [x] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n- [x] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.\r\n- [x] Code generation (`make codegen`) has been run to update object specifications, if necessary.\r\n- [x] `make vendor` does not cause changes.\r\n","created_at":"2018-08-11T04:23:22Z","updated_at":"2018-09-04T18:05:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d0ce43085da271da2926a3d0eab48ff70a499f6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},{"login":"jbw976","id":4313439,"node_id":"MDQ6VXNlcjQzMTM0Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/4313439?v=4","gravatar_id":"","url":"https://api.github.com/users/jbw976","html_url":"https://github.com/jbw976","followers_url":"https://api.github.com/users/jbw976/followers","following_url":"https://api.github.com/users/jbw976/following{/other_user}","gists_url":"https://api.github.com/users/jbw976/gists{/gist_id}","starred_url":"https://api.github.com/users/jbw976/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbw976/subscriptions","organizations_url":"https://api.github.com/users/jbw976/orgs","repos_url":"https://api.github.com/users/jbw976/repos","events_url":"https://api.github.com/users/jbw976/events{/privacy}","received_events_url":"https://api.github.com/users/jbw976/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":479456042,"node_id":"MDU6TGFiZWw0Nzk0NTYwNDI=","url":"https://api.github.com/repos/rook/rook/labels/ceph","name":"ceph","color":"d93f0b","default":false},{"id":479820581,"node_id":"MDU6TGFiZWw0Nzk4MjA1ODE=","url":"https://api.github.com/repos/rook/rook/labels/operator","name":"operator","color":"00aaaa","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/2018/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/2018/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/2018/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/f840e3574ea3ba985495d53c284a2c6b2334b868","head":{"label":"travisn:rename-ceph-mon","ref":"rename-ceph-mon","sha":"f840e3574ea3ba985495d53c284a2c6b2334b868","user":{"login":"travisn","id":1048514,"node_id":"MDQ6VXNlcjEwNDg1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"repo":{"id":73165238,"node_id":"MDEwOlJlcG9zaXRvcnk3MzE2NTIzOA==","name":"rook","full_name":"travisn/rook","owner":{"login":"travisn","id":1048514,"node_id":"MDQ6VXNlcjEwNDg1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/travisn/rook","description":"Open, Universal, Cloud Native, Distributed Storage","fork":true,"url":"https://api.github.com/repos/travisn/rook","forks_url":"https://api.github.com/repos/travisn/rook/forks","keys_url":"https://api.github.com/repos/travisn/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travisn/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travisn/rook/teams","hooks_url":"https://api.github.com/repos/travisn/rook/hooks","issue_events_url":"https://api.github.com/repos/travisn/rook/issues/events{/number}","events_url":"https://api.github.com/repos/travisn/rook/events","assignees_url":"https://api.github.com/repos/travisn/rook/assignees{/user}","branches_url":"https://api.github.com/repos/travisn/rook/branches{/branch}","tags_url":"https://api.github.com/repos/travisn/rook/tags","blobs_url":"https://api.github.com/repos/travisn/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travisn/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travisn/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/travisn/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travisn/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/travisn/rook/languages","stargazers_url":"https://api.github.com/repos/travisn/rook/stargazers","contributors_url":"https://api.github.com/repos/travisn/rook/contributors","subscribers_url":"https://api.github.com/repos/travisn/rook/subscribers","subscription_url":"https://api.github.com/repos/travisn/rook/subscription","commits_url":"https://api.github.com/repos/travisn/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/travisn/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/travisn/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/travisn/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/travisn/rook/contents/{+path}","compare_url":"https://api.github.com/repos/travisn/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travisn/rook/merges","archive_url":"https://api.github.com/repos/travisn/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travisn/rook/downloads","issues_url":"https://api.github.com/repos/travisn/rook/issues{/number}","pulls_url":"https://api.github.com/repos/travisn/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/travisn/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/travisn/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travisn/rook/labels{/name}","releases_url":"https://api.github.com/repos/travisn/rook/releases{/id}","deployments_url":"https://api.github.com/repos/travisn/rook/deployments","created_at":"2016-11-08T08:30:24Z","updated_at":"2018-08-24T20:59:19Z","pushed_at":"2018-09-04T17:15:56Z","git_url":"git://github.com/travisn/rook.git","ssh_url":"git@github.com:travisn/rook.git","clone_url":"https://github.com/travisn/rook.git","svn_url":"https://github.com/travisn/rook","homepage":"http://rook.io","size":6155,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"7121418cef1fc36923f991e6a4949acd819dcf50","user":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"node_id":"MDEwOlJlcG9zaXRvcnk2MjkyMTU1Mw==","name":"rook","full_name":"rook/rook","owner":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rook/rook","description":"Storage Orchestration for Kubernetes","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2018-09-04T12:20:12Z","pushed_at":"2018-09-04T17:19:14Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":6122,"stargazers_count":3358,"watchers_count":3358,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":233,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":405,"open_issues":233,"watchers":3358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/2018"},"html":{"href":"https://github.com/rook/rook/pull/2018"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/2018"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/2018/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/2018/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/2018/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/f840e3574ea3ba985495d53c284a2c6b2334b868"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"galexrt"}}