{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments/174471632","pull_request_review_id":103832888,"id":174471632,"diff_hunk":"@@ -15,15 +15,13 @@ RUN usermod -u $CONTAINER_USERID frontend\n # docker would use it's cache for this and the following stages.\n ADD Gemfile /obs/src/api/Gemfile\n ADD Gemfile.lock /obs/src/api/Gemfile.lock\n+ADD .bundle /obs/src/api/\n RUN chown -R frontend /obs/src/api\n \n # Now do the rest as the user with the same ID as the user who\n # builds this container\n USER frontend\n WORKDIR /obs/src/api\n \n-# Refresh our bundle\n-RUN export NOKOGIRI_USE_SYSTEM_LIBRARIES=1; bundle install --jobs=3 --retry=3 || bundle install --jobs=3 --retry=3\n-\n-# Run our command\n-CMD [\"foreman\", \"start\", \"-f\", \"Procfile\"]\n+# Install/Refresh our gems and start OBS\n+CMD bundle install --clean && foreman start -f Procfile","path":"src/api/docker-files/Dockerfile","position":18,"original_position":18,"commit_id":"3ba919fb6923f32239cb08a0006342c5b6e6bcc5","original_commit_id":"3ba919fb6923f32239cb08a0006342c5b6e6bcc5","user":{"login":"hennevogel","id":514785,"avatar_url":"https://avatars1.githubusercontent.com/u/514785?v=4","gravatar_id":"","url":"https://api.github.com/users/hennevogel","html_url":"https://github.com/hennevogel","followers_url":"https://api.github.com/users/hennevogel/followers","following_url":"https://api.github.com/users/hennevogel/following{/other_user}","gists_url":"https://api.github.com/users/hennevogel/gists{/gist_id}","starred_url":"https://api.github.com/users/hennevogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hennevogel/subscriptions","organizations_url":"https://api.github.com/users/hennevogel/orgs","repos_url":"https://api.github.com/users/hennevogel/repos","events_url":"https://api.github.com/users/hennevogel/events{/privacy}","received_events_url":"https://api.github.com/users/hennevogel/received_events","type":"User","site_admin":false},"body":">> You can do this, of course. But controlling multiple processes is the whole point of foreman :-) So again, why would you do that?\r\n\r\n> And the whole point of docker / containerizing is to run multiple processes / services in separate containers. :-)\r\n\r\nWell it's certainly okay to have more processes in the container as long as you have one controlling every other process. That is the point, not the amount of processes. \r\n\r\nAnd of course you could also build many `frontend` like containers now, all having to deal with the bundle of dependencies that need to be refreshed all the time, but why would you do that?\r\n\r\nThere is no speed gain. There is not gain in simplicity. There is no need to split processes. There is a new  dependency on the network for running this...","created_at":"2018-03-14T14:11:01Z","updated_at":"2018-03-14T14:11:01Z","html_url":"https://github.com/openSUSE/open-build-service/pull/4642#discussion_r174471632","pull_request_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4642","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments/174471632"},"html":{"href":"https://github.com/openSUSE/open-build-service/pull/4642#discussion_r174471632"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4642"}},"in_reply_to_id":174084083},"pull_request":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4642","id":174512155,"html_url":"https://github.com/openSUSE/open-build-service/pull/4642","diff_url":"https://github.com/openSUSE/open-build-service/pull/4642.diff","patch_url":"https://github.com/openSUSE/open-build-service/pull/4642.patch","issue_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/4642","number":4642,"state":"open","locked":false,"title":"Update gem bundling of dev container","user":{"login":"bgeuken","id":968949,"avatar_url":"https://avatars2.githubusercontent.com/u/968949?v=4","gravatar_id":"","url":"https://api.github.com/users/bgeuken","html_url":"https://github.com/bgeuken","followers_url":"https://api.github.com/users/bgeuken/followers","following_url":"https://api.github.com/users/bgeuken/following{/other_user}","gists_url":"https://api.github.com/users/bgeuken/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeuken/subscriptions","organizations_url":"https://api.github.com/users/bgeuken/orgs","repos_url":"https://api.github.com/users/bgeuken/repos","events_url":"https://api.github.com/users/bgeuken/events{/privacy}","received_events_url":"https://api.github.com/users/bgeuken/received_events","type":"User","site_admin":false},"body":"* Allow custom bundle configuration in our dev container (via api/.bundle)\r\n* Allow to bundle / use gems in / from a custom directory (in api/gems)\r\n* Rebundle gems when starting the container. That way changes in the gem file doesn't make it impossible to start the dev container again.","created_at":"2018-03-12T22:27:57Z","updated_at":"2018-03-14T14:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef71b256634faf7546d19d187bc7067b2b142bb2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":21922370,"url":"https://api.github.com/repos/openSUSE/open-build-service/labels/Frontend%20%F0%9F%91%BB","name":"Frontend 👻","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4642/commits","review_comments_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4642/comments","review_comment_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/4642/comments","statuses_url":"https://api.github.com/repos/openSUSE/open-build-service/statuses/3ba919fb6923f32239cb08a0006342c5b6e6bcc5","head":{"label":"bgeuken:bundling_in_docker_dev_container","ref":"bundling_in_docker_dev_container","sha":"3ba919fb6923f32239cb08a0006342c5b6e6bcc5","user":{"login":"bgeuken","id":968949,"avatar_url":"https://avatars2.githubusercontent.com/u/968949?v=4","gravatar_id":"","url":"https://api.github.com/users/bgeuken","html_url":"https://github.com/bgeuken","followers_url":"https://api.github.com/users/bgeuken/followers","following_url":"https://api.github.com/users/bgeuken/following{/other_user}","gists_url":"https://api.github.com/users/bgeuken/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeuken/subscriptions","organizations_url":"https://api.github.com/users/bgeuken/orgs","repos_url":"https://api.github.com/users/bgeuken/repos","events_url":"https://api.github.com/users/bgeuken/events{/privacy}","received_events_url":"https://api.github.com/users/bgeuken/received_events","type":"User","site_admin":false},"repo":{"id":10003040,"name":"open-build-service","full_name":"bgeuken/open-build-service","owner":{"login":"bgeuken","id":968949,"avatar_url":"https://avatars2.githubusercontent.com/u/968949?v=4","gravatar_id":"","url":"https://api.github.com/users/bgeuken","html_url":"https://github.com/bgeuken","followers_url":"https://api.github.com/users/bgeuken/followers","following_url":"https://api.github.com/users/bgeuken/following{/other_user}","gists_url":"https://api.github.com/users/bgeuken/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeuken/subscriptions","organizations_url":"https://api.github.com/users/bgeuken/orgs","repos_url":"https://api.github.com/users/bgeuken/repos","events_url":"https://api.github.com/users/bgeuken/events{/privacy}","received_events_url":"https://api.github.com/users/bgeuken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgeuken/open-build-service","description":"A generic system to build and distribute packages from sources in an automatic, consistent and reproducible way. Release your software for a wide range of operating systems and hardware architectures.","fork":true,"url":"https://api.github.com/repos/bgeuken/open-build-service","forks_url":"https://api.github.com/repos/bgeuken/open-build-service/forks","keys_url":"https://api.github.com/repos/bgeuken/open-build-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgeuken/open-build-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgeuken/open-build-service/teams","hooks_url":"https://api.github.com/repos/bgeuken/open-build-service/hooks","issue_events_url":"https://api.github.com/repos/bgeuken/open-build-service/issues/events{/number}","events_url":"https://api.github.com/repos/bgeuken/open-build-service/events","assignees_url":"https://api.github.com/repos/bgeuken/open-build-service/assignees{/user}","branches_url":"https://api.github.com/repos/bgeuken/open-build-service/branches{/branch}","tags_url":"https://api.github.com/repos/bgeuken/open-build-service/tags","blobs_url":"https://api.github.com/repos/bgeuken/open-build-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgeuken/open-build-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgeuken/open-build-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgeuken/open-build-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgeuken/open-build-service/statuses/{sha}","languages_url":"https://api.github.com/repos/bgeuken/open-build-service/languages","stargazers_url":"https://api.github.com/repos/bgeuken/open-build-service/stargazers","contributors_url":"https://api.github.com/repos/bgeuken/open-build-service/contributors","subscribers_url":"https://api.github.com/repos/bgeuken/open-build-service/subscribers","subscription_url":"https://api.github.com/repos/bgeuken/open-build-service/subscription","commits_url":"https://api.github.com/repos/bgeuken/open-build-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgeuken/open-build-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgeuken/open-build-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgeuken/open-build-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgeuken/open-build-service/contents/{+path}","compare_url":"https://api.github.com/repos/bgeuken/open-build-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgeuken/open-build-service/merges","archive_url":"https://api.github.com/repos/bgeuken/open-build-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgeuken/open-build-service/downloads","issues_url":"https://api.github.com/repos/bgeuken/open-build-service/issues{/number}","pulls_url":"https://api.github.com/repos/bgeuken/open-build-service/pulls{/number}","milestones_url":"https://api.github.com/repos/bgeuken/open-build-service/milestones{/number}","notifications_url":"https://api.github.com/repos/bgeuken/open-build-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgeuken/open-build-service/labels{/name}","releases_url":"https://api.github.com/repos/bgeuken/open-build-service/releases{/id}","deployments_url":"https://api.github.com/repos/bgeuken/open-build-service/deployments","created_at":"2013-05-11T17:48:20Z","updated_at":"2017-11-14T11:23:28Z","pushed_at":"2018-03-14T12:59:06Z","git_url":"git://github.com/bgeuken/open-build-service.git","ssh_url":"git@github.com:bgeuken/open-build-service.git","clone_url":"https://github.com/bgeuken/open-build-service.git","svn_url":"https://github.com/bgeuken/open-build-service","homepage":"http://openbuildservice.org/","size":57707,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"0dbe0189c30e6c33ecfab67518273870e672512f","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":2046192,"name":"open-build-service","full_name":"openSUSE/open-build-service","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/open-build-service","description":"A generic system to build and distribute packages from sources in an automatic, consistent and reproducible way. Release your software for a wide range of operating systems and hardware architectures.","fork":false,"url":"https://api.github.com/repos/openSUSE/open-build-service","forks_url":"https://api.github.com/repos/openSUSE/open-build-service/forks","keys_url":"https://api.github.com/repos/openSUSE/open-build-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/open-build-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/open-build-service/teams","hooks_url":"https://api.github.com/repos/openSUSE/open-build-service/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/open-build-service/events","assignees_url":"https://api.github.com/repos/openSUSE/open-build-service/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/open-build-service/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/open-build-service/tags","blobs_url":"https://api.github.com/repos/openSUSE/open-build-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/open-build-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/open-build-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/open-build-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/open-build-service/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/open-build-service/languages","stargazers_url":"https://api.github.com/repos/openSUSE/open-build-service/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/open-build-service/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/open-build-service/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/open-build-service/subscription","commits_url":"https://api.github.com/repos/openSUSE/open-build-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/open-build-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/open-build-service/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/open-build-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/open-build-service/merges","archive_url":"https://api.github.com/repos/openSUSE/open-build-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/open-build-service/downloads","issues_url":"https://api.github.com/repos/openSUSE/open-build-service/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/open-build-service/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/open-build-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/open-build-service/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/open-build-service/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/open-build-service/deployments","created_at":"2011-07-14T06:52:57Z","updated_at":"2018-03-14T14:02:04Z","pushed_at":"2018-03-14T14:09:20Z","git_url":"git://github.com/openSUSE/open-build-service.git","ssh_url":"git@github.com:openSUSE/open-build-service.git","clone_url":"https://github.com/openSUSE/open-build-service.git","svn_url":"https://github.com/openSUSE/open-build-service","homepage":"http://openbuildservice.org/","size":57750,"stargazers_count":330,"watchers_count":330,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"archived":false,"open_issues_count":477,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":222,"open_issues":477,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4642"},"html":{"href":"https://github.com/openSUSE/open-build-service/pull/4642"},"issue":{"href":"https://api.github.com/repos/openSUSE/open-build-service/issues/4642"},"comments":{"href":"https://api.github.com/repos/openSUSE/open-build-service/issues/4642/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4642/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4642/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/open-build-service/statuses/3ba919fb6923f32239cb08a0006342c5b6e6bcc5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hennevogel"}}