{"action":"created","issue":{"url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1986","repository_url":"https://api.github.com/repos/bigdatagenomics/adam","labels_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1986/labels{/name}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1986/comments","events_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1986/events","html_url":"https://github.com/bigdatagenomics/adam/issues/1986","id":316532329,"node_id":"MDU6SXNzdWUzMTY1MzIzMjk=","number":1986,"title":"Use consistent (Scala-specific) (Java-specific) qualifiers in method scaladoc","user":{"login":"heuermh","id":35293,"node_id":"MDQ6VXNlcjM1Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/35293?v=4","gravatar_id":"","url":"https://api.github.com/users/heuermh","html_url":"https://github.com/heuermh","followers_url":"https://api.github.com/users/heuermh/followers","following_url":"https://api.github.com/users/heuermh/following{/other_user}","gists_url":"https://api.github.com/users/heuermh/gists{/gist_id}","starred_url":"https://api.github.com/users/heuermh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuermh/subscriptions","organizations_url":"https://api.github.com/users/heuermh/orgs","repos_url":"https://api.github.com/users/heuermh/repos","events_url":"https://api.github.com/users/heuermh/events{/privacy}","received_events_url":"https://api.github.com/users/heuermh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"heuermh","id":35293,"node_id":"MDQ6VXNlcjM1Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/35293?v=4","gravatar_id":"","url":"https://api.github.com/users/heuermh","html_url":"https://github.com/heuermh","followers_url":"https://api.github.com/users/heuermh/followers","following_url":"https://api.github.com/users/heuermh/following{/other_user}","gists_url":"https://api.github.com/users/heuermh/gists{/gist_id}","starred_url":"https://api.github.com/users/heuermh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuermh/subscriptions","organizations_url":"https://api.github.com/users/heuermh/orgs","repos_url":"https://api.github.com/users/heuermh/repos","events_url":"https://api.github.com/users/heuermh/events{/privacy}","received_events_url":"https://api.github.com/users/heuermh/received_events","type":"User","site_admin":false},"assignees":[{"login":"heuermh","id":35293,"node_id":"MDQ6VXNlcjM1Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/35293?v=4","gravatar_id":"","url":"https://api.github.com/users/heuermh","html_url":"https://github.com/heuermh","followers_url":"https://api.github.com/users/heuermh/followers","following_url":"https://api.github.com/users/heuermh/following{/other_user}","gists_url":"https://api.github.com/users/heuermh/gists{/gist_id}","starred_url":"https://api.github.com/users/heuermh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuermh/subscriptions","organizations_url":"https://api.github.com/users/heuermh/orgs","repos_url":"https://api.github.com/users/heuermh/repos","events_url":"https://api.github.com/users/heuermh/events{/privacy}","received_events_url":"https://api.github.com/users/heuermh/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-04-21T22:56:01Z","updated_at":"2018-12-06T16:51:16Z","closed_at":null,"author_association":"MEMBER","body":"[Apache Spark scaladoc](https://spark.apache.org/docs/2.1.0/api/java/org/apache/spark/sql/Dataset.html#filter(java.lang.String)) uses (Scala-specific) (Java-specific) qualifiers on methods, e.g.\r\n(Scala-specific) Returns a new Dataset that contains the result of applying func to each element.\r\n(Java-specific) Returns a new Dataset that contains the result of applying func to each element.\r\n\r\nThis is preferable to a mention in second or third sentences as we often do, since those don't show up in the scaladoc method overview."},"comment":{"url":"https://api.github.com/repos/bigdatagenomics/adam/issues/comments/444943950","html_url":"https://github.com/bigdatagenomics/adam/issues/1986#issuecomment-444943950","issue_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1986","id":444943950,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDk0Mzk1MA==","user":{"login":"heuermh","id":35293,"node_id":"MDQ6VXNlcjM1Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/35293?v=4","gravatar_id":"","url":"https://api.github.com/users/heuermh","html_url":"https://github.com/heuermh","followers_url":"https://api.github.com/users/heuermh/followers","following_url":"https://api.github.com/users/heuermh/following{/other_user}","gists_url":"https://api.github.com/users/heuermh/gists{/gist_id}","starred_url":"https://api.github.com/users/heuermh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuermh/subscriptions","organizations_url":"https://api.github.com/users/heuermh/orgs","repos_url":"https://api.github.com/users/heuermh/repos","events_url":"https://api.github.com/users/heuermh/events{/privacy}","received_events_url":"https://api.github.com/users/heuermh/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T16:51:16Z","updated_at":"2018-12-06T16:51:16Z","author_association":"MEMBER","body":"@devin-petersohn @fnothaft While going through this, I noticed that we have `flankSize` as `java.lang.Integer`, `java.lang.Double`, and `Long` in separate region join methods.\r\n\r\nIs there any reason not to have just (Java-specific) `java.lang.Long` and (Scala-specific) `Long` methods?  E.g.\r\n```scala\r\n  // (Java-specific)\r\n  def broadcastRegionJoin[X, Y <: Product, Z <: GenomicDataset[X, Y, Z]](\r\n    genomicDataset: GenomicDataset[X, Y, Z],\r\n    flankSize: java.lang.Long): GenericGenomicDataset[(T, X), (U, Y)] = {\r\n\r\n    implicit val tTag = ClassTag.AnyRef.asInstanceOf[ClassTag[T]]\r\n    implicit val xTag = ClassTag.AnyRef.asInstanceOf[ClassTag[X]]\r\n    implicit val txTag = ClassTag.AnyRef.asInstanceOf[ClassTag[(T, X)]]\r\n    implicit val u1Tag: TypeTag[U] = uTag\r\n    implicit val u2Tag: TypeTag[Y] = genomicDataset.uTag\r\n    implicit val uyTag = typeTag[(U, Y)]\r\n\r\n    broadcastRegionJoin(genomicDataset, flankSize)\r\n  }\r\n\r\n  // (Scala-specific)\r\n  def broadcastRegionJoin[X, Y <: Product, Z <: GenomicDataset[X, Y, Z]](\r\n    genomicDataset: GenomicDataset[X, Y, Z],\r\n    flankSize: Long)(\r\n      implicit tTag: ClassTag[T],\r\n      xTag: ClassTag[X],\r\n      txTag: ClassTag[(T, X)],\r\n      uyTag: TypeTag[(U, Y)]): GenericGenomicDataset[(T, X), (U, Y)] = InnerBroadcastJoin.time {\r\n    // ...\r\n  }\r\n```"}}
{"actor":{"display_login":"heuermh"}}