{"action":"closed","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/98","repository_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds","labels_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/98/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/98/events","html_url":"https://github.com/ipfs/go-ipfs-cmds/issues/98","id":314331082,"node_id":"MDU6SXNzdWUzMTQzMzEwODI=","number":98,"title":"Rename SetError to CloseWithError","user":{"login":"keks","id":146678,"node_id":"MDQ6VXNlcjE0NjY3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/146678?v=4","gravatar_id":"","url":"https://api.github.com/users/keks","html_url":"https://github.com/keks","followers_url":"https://api.github.com/users/keks/followers","following_url":"https://api.github.com/users/keks/following{/other_user}","gists_url":"https://api.github.com/users/keks/gists{/gist_id}","starred_url":"https://api.github.com/users/keks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keks/subscriptions","organizations_url":"https://api.github.com/users/keks/orgs","repos_url":"https://api.github.com/users/keks/repos","events_url":"https://api.github.com/users/keks/events{/privacy}","received_events_url":"https://api.github.com/users/keks/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-14T13:58:08Z","updated_at":"2018-10-25T20:12:40Z","closed_at":"2018-10-25T20:12:40Z","author_association":"COLLABORATOR","body":"At the moment, we basically only use SetError right before we close the connection, and using it for anything else has turned out to make things much more complicated than I thought.\r\n\r\nThe method `CloseWithError(error) error` is pretty common in Go, and returns the passed error to the caller of `Read` (or in our case `Next`) on the other side of the stream. Type information can be preserved for runtime-analysis, until we send the error through the http api, where it becomes a cmdkit.Error, if it isn't already.\r\n\r\n@Stebalien do you have opinions on this?"}}
{"actor":{"display_login":"Stebalien"}}