{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/168245860","pull_request_review_id":96582321,"id":168245860,"diff_hunk":"@@ -43,15 +43,21 @@ def install\n     args_static = args.dup << \"-DBUILD_SHARED_LIBS=OFF\"\n     args_static << \"-DBUILD_BULLET2_DEMOS=OFF\" if build.without? \"demo\"\n \n-    system \"cmake\", \".\", *args_shared\n-    system \"make\", \"install\"\n+    mkdir \"build\" do\n+      system \"cmake\", \"..\", *args_shared\n+      system \"make\", \"install\"\n \n-    system \"make\", \"clean\"","path":"Formula/bullet.rb","position":26,"original_position":10,"commit_id":"bc23626bb062144d7058be7550eb01be23eaf70e","original_commit_id":"b75f7634b357b8b4292fa5e2fa94ae5af91ed954","user":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars2.githubusercontent.com/u/2618447?v=4","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"body":"Amended.","created_at":"2018-02-14T17:12:18Z","updated_at":"2018-02-14T17:12:18Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/24100#discussion_r168245860","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/168245860"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/24100#discussion_r168245860"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24100"}},"in_reply_to_id":168224535},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24100","id":169023057,"html_url":"https://github.com/Homebrew/homebrew-core/pull/24100","diff_url":"https://github.com/Homebrew/homebrew-core/pull/24100.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/24100.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/24100","number":24100,"state":"open","locked":false,"title":"bullet: fix examples installation","user":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars2.githubusercontent.com/u/2618447?v=4","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"body":"- [X] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [X] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [X] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [X] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nFixes #24051.\r\n\r\nFixes the `bullet` demo-installation code.\r\n\r\nSwitches to using a `build` subdirectory to make it easier to clean build artifacts and scrub down the `examples` directory to avoid picking up source files and build scripts.\r\n\r\nAlso includes the `data` directory in the `examples` installation, which is needed for some of the examples. (If missing, you'll get segfaults when trying to launch certain demos, like those using URDF.)","created_at":"2018-02-14T05:09:11Z","updated_at":"2018-02-14T17:12:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a41da104684a20fb2927a9808c6fa2f35dcd1b94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24100/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24100/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/24100/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/bc23626bb062144d7058be7550eb01be23eaf70e","head":{"label":"apjanke:bullet-with-demos","ref":"bullet-with-demos","sha":"bc23626bb062144d7058be7550eb01be23eaf70e","user":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars2.githubusercontent.com/u/2618447?v=4","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"repo":{"id":55312079,"name":"homebrew-core","full_name":"apjanke/homebrew-core","owner":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars2.githubusercontent.com/u/2618447?v=4","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apjanke/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/apjanke/homebrew-core","forks_url":"https://api.github.com/repos/apjanke/homebrew-core/forks","keys_url":"https://api.github.com/repos/apjanke/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apjanke/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apjanke/homebrew-core/teams","hooks_url":"https://api.github.com/repos/apjanke/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/apjanke/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/apjanke/homebrew-core/events","assignees_url":"https://api.github.com/repos/apjanke/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/apjanke/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/apjanke/homebrew-core/tags","blobs_url":"https://api.github.com/repos/apjanke/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apjanke/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apjanke/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apjanke/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apjanke/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apjanke/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/apjanke/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/apjanke/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/apjanke/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/apjanke/homebrew-core/subscription","commits_url":"https://api.github.com/repos/apjanke/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apjanke/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apjanke/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apjanke/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apjanke/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/apjanke/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apjanke/homebrew-core/merges","archive_url":"https://api.github.com/repos/apjanke/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apjanke/homebrew-core/downloads","issues_url":"https://api.github.com/repos/apjanke/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/apjanke/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apjanke/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apjanke/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apjanke/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/apjanke/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/apjanke/homebrew-core/deployments","created_at":"2016-04-02T19:20:27Z","updated_at":"2016-04-02T19:20:40Z","pushed_at":"2018-02-14T17:11:47Z","git_url":"git://github.com/apjanke/homebrew-core.git","ssh_url":"git@github.com:apjanke/homebrew-core.git","clone_url":"https://github.com/apjanke/homebrew-core.git","svn_url":"https://github.com/apjanke/homebrew-core","homepage":"","size":168842,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"e095194cedc650b9e8f876ac4f0787338ce1abc8","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2018-02-14T15:16:24Z","pushed_at":"2018-02-14T17:11:50Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":169125,"stargazers_count":3050,"watchers_count":3050,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3906,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":3906,"open_issues":56,"watchers":3050,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24100"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/24100"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/24100"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/24100/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24100/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24100/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/bc23626bb062144d7058be7550eb01be23eaf70e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apjanke"}}