{"action":"created","comment":{"url":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/comments/239836991","pull_request_review_id":182731191,"id":239836991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTgzNjk5MQ==","diff_hunk":"@@ -153,15 +153,6 @@\n     },\n ]\n \n-# Workaround for template loading of titanium theme\n-if not os.path.exists('/opt/branding/applied'):\n-    TEMPLATES[0]['DIRS'] = ['/usr/share/openstack-dashboard/'\n-                            'openstack_dashboard/themes/titanium/templates',\n-                            os.path.join(ROOT_PATH, 'templates'), ]\n-elif os.path.exists('/opt/branding/applied/templates'):\n-    TEMPLATES[0]['DIRS'] = ['/opt/branding/applied/templates',\n-                            os.path.join(ROOT_PATH, 'templates'), ]","path":"openstack_dashboard/settings.py","position":11,"original_position":11,"commit_id":"cb1091f186b7b48b0b9684f55c04a1d2a0865e47","original_commit_id":"cb1091f186b7b48b0b9684f55c04a1d2a0865e47","user":{"login":"tylersmith22","id":40066067,"node_id":"MDQ6VXNlcjQwMDY2MDY3","avatar_url":"https://avatars3.githubusercontent.com/u/40066067?v=4","gravatar_id":"","url":"https://api.github.com/users/tylersmith22","html_url":"https://github.com/tylersmith22","followers_url":"https://api.github.com/users/tylersmith22/followers","following_url":"https://api.github.com/users/tylersmith22/following{/other_user}","gists_url":"https://api.github.com/users/tylersmith22/gists{/gist_id}","starred_url":"https://api.github.com/users/tylersmith22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylersmith22/subscriptions","organizations_url":"https://api.github.com/users/tylersmith22/orgs","repos_url":"https://api.github.com/users/tylersmith22/repos","events_url":"https://api.github.com/users/tylersmith22/events{/privacy}","received_events_url":"https://api.github.com/users/tylersmith22/received_events","type":"User","site_admin":false},"body":"I believe we still need the elif part of the above code, it is used for our custom branding feature to get around horizon disallowing template dirs outside of horizon","created_at":"2018-12-07T15:03:40Z","updated_at":"2018-12-07T15:03:40Z","html_url":"https://github.com/starlingx-staging/stx-horizon/pull/18#discussion_r239836991","pull_request_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/18","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/comments/239836991"},"html":{"href":"https://github.com/starlingx-staging/stx-horizon/pull/18#discussion_r239836991"},"pull_request":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/18","id":236595625,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTk1NjI1","html_url":"https://github.com/starlingx-staging/stx-horizon/pull/18","diff_url":"https://github.com/starlingx-staging/stx-horizon/pull/18.diff","patch_url":"https://github.com/starlingx-staging/stx-horizon/pull/18.patch","issue_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/18","number":18,"state":"open","locked":false,"title":"Remove Starlingx branding from stx-horizon","user":{"login":"kbujold","id":26882112,"node_id":"MDQ6VXNlcjI2ODgyMTEy","avatar_url":"https://avatars0.githubusercontent.com/u/26882112?v=4","gravatar_id":"","url":"https://api.github.com/users/kbujold","html_url":"https://github.com/kbujold","followers_url":"https://api.github.com/users/kbujold/followers","following_url":"https://api.github.com/users/kbujold/following{/other_user}","gists_url":"https://api.github.com/users/kbujold/gists{/gist_id}","starred_url":"https://api.github.com/users/kbujold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbujold/subscriptions","organizations_url":"https://api.github.com/users/kbujold/orgs","repos_url":"https://api.github.com/users/kbujold/repos","events_url":"https://api.github.com/users/kbujold/events{/privacy}","received_events_url":"https://api.github.com/users/kbujold/received_events","type":"User","site_admin":false},"body":"Removed themes/titanium/ and themes/starlingx/ folder from\r\nstx-horizon.\r\n\r\nStory: 2004552\r\nTask: 28310\r\n\r\nSigned-off-by: Kristine Bujold <kristine.bujold@windriver.com>","created_at":"2018-12-06T16:39:36Z","updated_at":"2018-12-07T15:03:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3ebb65fe33cb21899e5e9bf6c94a36a0c51f141","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/18/commits","review_comments_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/18/comments","review_comment_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/18/comments","statuses_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/statuses/cb1091f186b7b48b0b9684f55c04a1d2a0865e47","head":{"label":"kbujold:remove_stx_branding","ref":"remove_stx_branding","sha":"cb1091f186b7b48b0b9684f55c04a1d2a0865e47","user":{"login":"kbujold","id":26882112,"node_id":"MDQ6VXNlcjI2ODgyMTEy","avatar_url":"https://avatars0.githubusercontent.com/u/26882112?v=4","gravatar_id":"","url":"https://api.github.com/users/kbujold","html_url":"https://github.com/kbujold","followers_url":"https://api.github.com/users/kbujold/followers","following_url":"https://api.github.com/users/kbujold/following{/other_user}","gists_url":"https://api.github.com/users/kbujold/gists{/gist_id}","starred_url":"https://api.github.com/users/kbujold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbujold/subscriptions","organizations_url":"https://api.github.com/users/kbujold/orgs","repos_url":"https://api.github.com/users/kbujold/repos","events_url":"https://api.github.com/users/kbujold/events{/privacy}","received_events_url":"https://api.github.com/users/kbujold/received_events","type":"User","site_admin":false},"repo":{"id":146335336,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzMzUzMzY=","name":"stx-horizon","full_name":"kbujold/stx-horizon","private":false,"owner":{"login":"kbujold","id":26882112,"node_id":"MDQ6VXNlcjI2ODgyMTEy","avatar_url":"https://avatars0.githubusercontent.com/u/26882112?v=4","gravatar_id":"","url":"https://api.github.com/users/kbujold","html_url":"https://github.com/kbujold","followers_url":"https://api.github.com/users/kbujold/followers","following_url":"https://api.github.com/users/kbujold/following{/other_user}","gists_url":"https://api.github.com/users/kbujold/gists{/gist_id}","starred_url":"https://api.github.com/users/kbujold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbujold/subscriptions","organizations_url":"https://api.github.com/users/kbujold/orgs","repos_url":"https://api.github.com/users/kbujold/repos","events_url":"https://api.github.com/users/kbujold/events{/privacy}","received_events_url":"https://api.github.com/users/kbujold/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kbujold/stx-horizon","description":"StarlingX Staging stx-horizon","fork":true,"url":"https://api.github.com/repos/kbujold/stx-horizon","forks_url":"https://api.github.com/repos/kbujold/stx-horizon/forks","keys_url":"https://api.github.com/repos/kbujold/stx-horizon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbujold/stx-horizon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbujold/stx-horizon/teams","hooks_url":"https://api.github.com/repos/kbujold/stx-horizon/hooks","issue_events_url":"https://api.github.com/repos/kbujold/stx-horizon/issues/events{/number}","events_url":"https://api.github.com/repos/kbujold/stx-horizon/events","assignees_url":"https://api.github.com/repos/kbujold/stx-horizon/assignees{/user}","branches_url":"https://api.github.com/repos/kbujold/stx-horizon/branches{/branch}","tags_url":"https://api.github.com/repos/kbujold/stx-horizon/tags","blobs_url":"https://api.github.com/repos/kbujold/stx-horizon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbujold/stx-horizon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbujold/stx-horizon/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbujold/stx-horizon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbujold/stx-horizon/statuses/{sha}","languages_url":"https://api.github.com/repos/kbujold/stx-horizon/languages","stargazers_url":"https://api.github.com/repos/kbujold/stx-horizon/stargazers","contributors_url":"https://api.github.com/repos/kbujold/stx-horizon/contributors","subscribers_url":"https://api.github.com/repos/kbujold/stx-horizon/subscribers","subscription_url":"https://api.github.com/repos/kbujold/stx-horizon/subscription","commits_url":"https://api.github.com/repos/kbujold/stx-horizon/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbujold/stx-horizon/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbujold/stx-horizon/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbujold/stx-horizon/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbujold/stx-horizon/contents/{+path}","compare_url":"https://api.github.com/repos/kbujold/stx-horizon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbujold/stx-horizon/merges","archive_url":"https://api.github.com/repos/kbujold/stx-horizon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbujold/stx-horizon/downloads","issues_url":"https://api.github.com/repos/kbujold/stx-horizon/issues{/number}","pulls_url":"https://api.github.com/repos/kbujold/stx-horizon/pulls{/number}","milestones_url":"https://api.github.com/repos/kbujold/stx-horizon/milestones{/number}","notifications_url":"https://api.github.com/repos/kbujold/stx-horizon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbujold/stx-horizon/labels{/name}","releases_url":"https://api.github.com/repos/kbujold/stx-horizon/releases{/id}","deployments_url":"https://api.github.com/repos/kbujold/stx-horizon/deployments","created_at":"2018-08-27T18:06:10Z","updated_at":"2018-09-17T14:25:19Z","pushed_at":"2018-12-06T15:59:21Z","git_url":"git://github.com/kbujold/stx-horizon.git","ssh_url":"git@github.com:kbujold/stx-horizon.git","clone_url":"https://github.com/kbujold/stx-horizon.git","svn_url":"https://github.com/kbujold/stx-horizon","homepage":null,"size":180505,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"starlingx-staging:master","ref":"master","sha":"13f7720c100de0200ce382b85451bfc08f76216f","user":{"login":"starlingx-staging","id":39442395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDQyMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/39442395?v=4","gravatar_id":"","url":"https://api.github.com/users/starlingx-staging","html_url":"https://github.com/starlingx-staging","followers_url":"https://api.github.com/users/starlingx-staging/followers","following_url":"https://api.github.com/users/starlingx-staging/following{/other_user}","gists_url":"https://api.github.com/users/starlingx-staging/gists{/gist_id}","starred_url":"https://api.github.com/users/starlingx-staging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starlingx-staging/subscriptions","organizations_url":"https://api.github.com/users/starlingx-staging/orgs","repos_url":"https://api.github.com/users/starlingx-staging/repos","events_url":"https://api.github.com/users/starlingx-staging/events{/privacy}","received_events_url":"https://api.github.com/users/starlingx-staging/received_events","type":"Organization","site_admin":false},"repo":{"id":134119844,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQxMTk4NDQ=","name":"stx-horizon","full_name":"starlingx-staging/stx-horizon","private":false,"owner":{"login":"starlingx-staging","id":39442395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDQyMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/39442395?v=4","gravatar_id":"","url":"https://api.github.com/users/starlingx-staging","html_url":"https://github.com/starlingx-staging","followers_url":"https://api.github.com/users/starlingx-staging/followers","following_url":"https://api.github.com/users/starlingx-staging/following{/other_user}","gists_url":"https://api.github.com/users/starlingx-staging/gists{/gist_id}","starred_url":"https://api.github.com/users/starlingx-staging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starlingx-staging/subscriptions","organizations_url":"https://api.github.com/users/starlingx-staging/orgs","repos_url":"https://api.github.com/users/starlingx-staging/repos","events_url":"https://api.github.com/users/starlingx-staging/events{/privacy}","received_events_url":"https://api.github.com/users/starlingx-staging/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/starlingx-staging/stx-horizon","description":"StarlingX Staging stx-horizon","fork":false,"url":"https://api.github.com/repos/starlingx-staging/stx-horizon","forks_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/forks","keys_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/teams","hooks_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/hooks","issue_events_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/events{/number}","events_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/events","assignees_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/assignees{/user}","branches_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/branches{/branch}","tags_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/tags","blobs_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/git/refs{/sha}","trees_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/statuses/{sha}","languages_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/languages","stargazers_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/stargazers","contributors_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/contributors","subscribers_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/subscribers","subscription_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/subscription","commits_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/commits{/sha}","git_commits_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/git/commits{/sha}","comments_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/comments{/number}","issue_comment_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/comments{/number}","contents_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/contents/{+path}","compare_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/merges","archive_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/downloads","issues_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues{/number}","pulls_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls{/number}","milestones_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/milestones{/number}","notifications_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/labels{/name}","releases_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/releases{/id}","deployments_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/deployments","created_at":"2018-05-20T04:32:07Z","updated_at":"2018-11-02T21:13:19Z","pushed_at":"2018-12-06T16:39:37Z","git_url":"git://github.com/starlingx-staging/stx-horizon.git","ssh_url":"git@github.com:starlingx-staging/stx-horizon.git","clone_url":"https://github.com/starlingx-staging/stx-horizon.git","svn_url":"https://github.com/starlingx-staging/stx-horizon","homepage":null,"size":180512,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/18"},"html":{"href":"https://github.com/starlingx-staging/stx-horizon/pull/18"},"issue":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/18"},"comments":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/starlingx-staging/stx-horizon/statuses/cb1091f186b7b48b0b9684f55c04a1d2a0865e47"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tylersmith22"}}