{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/comments/214772744","pull_request_review_id":151893737,"id":214772744,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDc3Mjc0NA==","diff_hunk":"@@ -240,7 +240,7 @@ function fakesolve(instance::MockLinQuadOptimizer)\n     instance.inner.quadratic_primal_solution = unload(instance.quadratic_primal_solution_stored, instance.inner.quadratic_primal_solution)\n     instance.inner.quadratic_dual_solution = unload(instance.quadratic_dual_solution_stored, instance.inner.quadratic_dual_solution)\n \n-    nothing\n+    return nothing","path":"src/mockoptimizer.jl","position":null,"original_position":5,"commit_id":"2dfc1d29c3a8fff0ccf0019ddba5e62c2d407909","original_commit_id":"2dfc1d29c3a8fff0ccf0019ddba5e62c2d407909","user":{"login":"odow","id":8177701,"node_id":"MDQ6VXNlcjgxNzc3MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/8177701?v=4","gravatar_id":"","url":"https://api.github.com/users/odow","html_url":"https://github.com/odow","followers_url":"https://api.github.com/users/odow/followers","following_url":"https://api.github.com/users/odow/following{/other_user}","gists_url":"https://api.github.com/users/odow/gists{/gist_id}","starred_url":"https://api.github.com/users/odow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odow/subscriptions","organizations_url":"https://api.github.com/users/odow/orgs","repos_url":"https://api.github.com/users/odow/repos","events_url":"https://api.github.com/users/odow/events{/privacy}","received_events_url":"https://api.github.com/users/odow/received_events","type":"User","site_admin":false},"body":"Style nit: just `return` instead of `return nothing`","created_at":"2018-09-04T02:13:47Z","updated_at":"2018-09-04T02:15:28Z","html_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl/pull/57#discussion_r214772744","pull_request_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/57","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/comments/214772744"},"html":{"href":"https://github.com/JuliaOpt/LinQuadOptInterface.jl/pull/57#discussion_r214772744"},"pull_request":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/57","id":211940712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTQwNzEy","html_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl/pull/57","diff_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl/pull/57.diff","patch_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl/pull/57.patch","issue_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues/57","number":57,"state":"open","locked":false,"title":"[WIP] Add solutions for tests","user":{"login":"joaquimg","id":13870065,"node_id":"MDQ6VXNlcjEzODcwMDY1","avatar_url":"https://avatars2.githubusercontent.com/u/13870065?v=4","gravatar_id":"","url":"https://api.github.com/users/joaquimg","html_url":"https://github.com/joaquimg","followers_url":"https://api.github.com/users/joaquimg/followers","following_url":"https://api.github.com/users/joaquimg/following{/other_user}","gists_url":"https://api.github.com/users/joaquimg/gists{/gist_id}","starred_url":"https://api.github.com/users/joaquimg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaquimg/subscriptions","organizations_url":"https://api.github.com/users/joaquimg/orgs","repos_url":"https://api.github.com/users/joaquimg/repos","events_url":"https://api.github.com/users/joaquimg/events{/privacy}","received_events_url":"https://api.github.com/users/joaquimg/received_events","type":"User","site_admin":false},"body":"Fixes mocksolver to support querying solutions after solves.\r\nStarts adding tests for solutions.","created_at":"2018-08-30T02:51:10Z","updated_at":"2018-09-04T02:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d07ca437580f9e5e79d77430c5df47b41c7cd421","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/57/commits","review_comments_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/57/comments","review_comment_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues/57/comments","statuses_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/statuses/2dfc1d29c3a8fff0ccf0019ddba5e62c2d407909","head":{"label":"JuliaOpt:testsolve","ref":"testsolve","sha":"2dfc1d29c3a8fff0ccf0019ddba5e62c2d407909","user":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":102805818,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI4MDU4MTg=","name":"LinQuadOptInterface.jl","full_name":"JuliaOpt/LinQuadOptInterface.jl","owner":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl","description":"Intermediate wrapper of MOI for some linear quadratic solvers","fork":false,"url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl","forks_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/deployments","created_at":"2017-09-08T02:06:51Z","updated_at":"2018-09-01T19:53:20Z","pushed_at":"2018-09-04T01:41:46Z","git_url":"git://github.com/JuliaOpt/LinQuadOptInterface.jl.git","ssh_url":"git@github.com:JuliaOpt/LinQuadOptInterface.jl.git","clone_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl.git","svn_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl","homepage":"","size":229,"stargazers_count":7,"watchers_count":7,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":11,"watchers":7,"default_branch":"master"}},"base":{"label":"JuliaOpt:master","ref":"master","sha":"f303b02d128577ca176af6b7be099a7e09fc1ce3","user":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":102805818,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI4MDU4MTg=","name":"LinQuadOptInterface.jl","full_name":"JuliaOpt/LinQuadOptInterface.jl","owner":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl","description":"Intermediate wrapper of MOI for some linear quadratic solvers","fork":false,"url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl","forks_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/deployments","created_at":"2017-09-08T02:06:51Z","updated_at":"2018-09-01T19:53:20Z","pushed_at":"2018-09-04T01:41:46Z","git_url":"git://github.com/JuliaOpt/LinQuadOptInterface.jl.git","ssh_url":"git@github.com:JuliaOpt/LinQuadOptInterface.jl.git","clone_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl.git","svn_url":"https://github.com/JuliaOpt/LinQuadOptInterface.jl","homepage":"","size":229,"stargazers_count":7,"watchers_count":7,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/57"},"html":{"href":"https://github.com/JuliaOpt/LinQuadOptInterface.jl/pull/57"},"issue":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues/57"},"comments":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaOpt/LinQuadOptInterface.jl/statuses/2dfc1d29c3a8fff0ccf0019ddba5e62c2d407909"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"odow"}}