{"action":"created","issue":{"url":"https://api.github.com/repos/coredns/coredns/issues/1689","repository_url":"https://api.github.com/repos/coredns/coredns","labels_url":"https://api.github.com/repos/coredns/coredns/issues/1689/labels{/name}","comments_url":"https://api.github.com/repos/coredns/coredns/issues/1689/comments","events_url":"https://api.github.com/repos/coredns/coredns/issues/1689/events","html_url":"https://github.com/coredns/coredns/pull/1689","id":315447280,"number":1689,"title":"pkg/log: ability for debug logs","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-18T11:52:28Z","updated_at":"2018-04-18T12:26:09Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/coredns/coredns/pulls/1689","html_url":"https://github.com/coredns/coredns/pull/1689","diff_url":"https://github.com/coredns/coredns/pull/1689.diff","patch_url":"https://github.com/coredns/coredns/pull/1689.patch"},"body":"When the debug plugin is enabled all log.Debug calls will print to\r\nstandard; if not there are a noop (almost).\r\n\r\nThe log package wraps some standard log functions as well, so just\r\nreplacing \"log\" with \"plugin/pkg/log\" should be enough to use this\r\npackage.\r\n\r\nFixes #1626 "},"comment":{"url":"https://api.github.com/repos/coredns/coredns/issues/comments/382368628","html_url":"https://github.com/coredns/coredns/pull/1689#issuecomment-382368628","issue_url":"https://api.github.com/repos/coredns/coredns/issues/1689","id":382368628,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T12:26:09Z","updated_at":"2018-04-18T12:26:09Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/coredns/coredns/pull/1689?src=pr&el=h1) Report\n> Merging [#1689](https://codecov.io/gh/coredns/coredns/pull/1689?src=pr&el=desc) into [master](https://codecov.io/gh/coredns/coredns/commit/08443a9f009fa0529a6d5cbb4708790165c16a0c?src=pr&el=desc) will **decrease** coverage by `0.13%`.\n> The diff coverage is `26.31%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/coredns/coredns/pull/1689/graphs/tree.svg?height=150&token=Ji3zZaIzpC&width=650&src=pr)](https://codecov.io/gh/coredns/coredns/pull/1689?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master   #1689      +/-   ##\n=========================================\n- Coverage   54.23%   54.1%   -0.14%     \n=========================================\n  Files         189     190       +1     \n  Lines        9413    9432      +19     \n=========================================\n- Hits         5105    5103       -2     \n- Misses       3924    3944      +20     \n- Partials      384     385       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/coredns/coredns/pull/1689?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [core/dnsserver/server.go](https://codecov.io/gh/coredns/coredns/pull/1689/diff?src=pr&el=tree#diff-Y29yZS9kbnNzZXJ2ZXIvc2VydmVyLmdv) | `15% <0%> (-0.1%)` | :arrow_down: |\n| [plugin/pkg/log/log.go](https://codecov.io/gh/coredns/coredns/pull/1689/diff?src=pr&el=tree#diff-cGx1Z2luL3BrZy9sb2cvbG9nLmdv) | `27.77% <27.77%> (ø)` | |\n| [plugin/pkg/up/up.go](https://codecov.io/gh/coredns/coredns/pull/1689/diff?src=pr&el=tree#diff-cGx1Z2luL3BrZy91cC91cC5nbw==) | `66.66% <0%> (-15.16%)` | :arrow_down: |\n| [plugin/file/reload.go](https://codecov.io/gh/coredns/coredns/pull/1689/diff?src=pr&el=tree#diff-cGx1Z2luL2ZpbGUvcmVsb2FkLmdv) | `67.64% <0%> (-5.89%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/coredns/coredns/pull/1689?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/coredns/coredns/pull/1689?src=pr&el=footer). Last update [08443a9...849db3c](https://codecov.io/gh/coredns/coredns/pull/1689?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}