{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments/174105128","pull_request_review_id":103400241,"id":174105128,"diff_hunk":"@@ -64,32 +66,33 @@ public GraphDatabaseService create() {\n \t\tAtomicBoolean isNew = new AtomicBoolean( false );\n \t\tFactoryHolder factoryHolder = GRAPH_DATABASE_SERVICE_MAP.computeIfAbsent( dbLocationAbsolutePath, ( String dbPath ) -> {\n \t\t\tLOG.infof( \" Create new service instance for dbPath  %s\", dbLocationAbsolutePath );\n-\t\t\tGraphDatabaseService service = buildGraphDatabaseService();\n+\t\t\tGraphDatabaseFacade service = buildGraphDatabaseService();\n \t\t\tFactoryHolder holder = new FactoryHolder();\n \t\t\tholder.setCounter( 1 );\n-\t\t\tholder.setGraphDatabaseService( service );\n+\t\t\tholder.setGraphDatabaseFacade( service );\n \t\t\tisNew.set( true );\n \t\t\treturn holder;\n \t\t} );\n \t\tif ( !isNew.get() ) {\n \t\t\tsynchronized (GRAPH_DATABASE_SERVICE_MAP) {\n-\t\t\t\tboolean isAvailable = factoryHolder.getGraphDatabaseService().isAvailable( 100 );\n+\t\t\t\tfactoryHolder.getGraphDatabaseFacade();\n+\t\t\t\tboolean isAvailable = factoryHolder.getGraphDatabaseFacade().isAvailable( 100 );\n \t\t\t\tif ( isAvailable ) {","path":"neo4j/src/main/java/org/hibernate/ogm/datastore/neo4j/embedded/impl/EmbeddedNeo4jGraphDatabaseFactory.java","position":null,"original_position":34,"commit_id":"785e7c491a6f7fc5569840596ee427c5e8f43716","original_commit_id":"989a4ee2eee7481f8e84345c189cb1ddb0fbcbd9","user":{"login":"DavideD","id":559221,"avatar_url":"https://avatars1.githubusercontent.com/u/559221?v=4","gravatar_id":"","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User","site_admin":false},"body":"It's better not to have Magic numbers like this in the codebase. This should be a constant called something like WAITING_TIME_MS","created_at":"2018-03-13T12:08:03Z","updated_at":"2018-03-13T12:08:03Z","html_url":"https://github.com/hibernate/hibernate-ogm/pull/987#discussion_r174105128","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/987","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments/174105128"},"html":{"href":"https://github.com/hibernate/hibernate-ogm/pull/987#discussion_r174105128"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/987"}},"in_reply_to_id":174084221},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/987","id":174562585,"html_url":"https://github.com/hibernate/hibernate-ogm/pull/987","diff_url":"https://github.com/hibernate/hibernate-ogm/pull/987.diff","patch_url":"https://github.com/hibernate/hibernate-ogm/pull/987.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/987","number":987,"state":"open","locked":false,"title":"[PREVIEW] OGM-1047 using database pool","user":{"login":"schernolyas","id":9314123,"avatar_url":"https://avatars3.githubusercontent.com/u/9314123?v=4","gravatar_id":"","url":"https://api.github.com/users/schernolyas","html_url":"https://github.com/schernolyas","followers_url":"https://api.github.com/users/schernolyas/followers","following_url":"https://api.github.com/users/schernolyas/following{/other_user}","gists_url":"https://api.github.com/users/schernolyas/gists{/gist_id}","starred_url":"https://api.github.com/users/schernolyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schernolyas/subscriptions","organizations_url":"https://api.github.com/users/schernolyas/orgs","repos_url":"https://api.github.com/users/schernolyas/repos","events_url":"https://api.github.com/users/schernolyas/events{/privacy}","received_events_url":"https://api.github.com/users/schernolyas/received_events","type":"User","site_admin":false},"body":"https://hibernate.atlassian.net/browse/OGM-1047\r\n","created_at":"2018-03-13T05:36:28Z","updated_at":"2018-03-13T12:08:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d29105e4efe6be91008317159d7cb5a4fee96549","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/987/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/987/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/987/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/785e7c491a6f7fc5569840596ee427c5e8f43716","head":{"label":"schernolyas:OGM-1047_using-database-pool","ref":"OGM-1047_using-database-pool","sha":"785e7c491a6f7fc5569840596ee427c5e8f43716","user":{"login":"schernolyas","id":9314123,"avatar_url":"https://avatars3.githubusercontent.com/u/9314123?v=4","gravatar_id":"","url":"https://api.github.com/users/schernolyas","html_url":"https://github.com/schernolyas","followers_url":"https://api.github.com/users/schernolyas/followers","following_url":"https://api.github.com/users/schernolyas/following{/other_user}","gists_url":"https://api.github.com/users/schernolyas/gists{/gist_id}","starred_url":"https://api.github.com/users/schernolyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schernolyas/subscriptions","organizations_url":"https://api.github.com/users/schernolyas/orgs","repos_url":"https://api.github.com/users/schernolyas/repos","events_url":"https://api.github.com/users/schernolyas/events{/privacy}","received_events_url":"https://api.github.com/users/schernolyas/received_events","type":"User","site_admin":false},"repo":{"id":48686618,"name":"hibernate-ogm","full_name":"schernolyas/hibernate-ogm","owner":{"login":"schernolyas","id":9314123,"avatar_url":"https://avatars3.githubusercontent.com/u/9314123?v=4","gravatar_id":"","url":"https://api.github.com/users/schernolyas","html_url":"https://github.com/schernolyas","followers_url":"https://api.github.com/users/schernolyas/followers","following_url":"https://api.github.com/users/schernolyas/following{/other_user}","gists_url":"https://api.github.com/users/schernolyas/gists{/gist_id}","starred_url":"https://api.github.com/users/schernolyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schernolyas/subscriptions","organizations_url":"https://api.github.com/users/schernolyas/orgs","repos_url":"https://api.github.com/users/schernolyas/repos","events_url":"https://api.github.com/users/schernolyas/events{/privacy}","received_events_url":"https://api.github.com/users/schernolyas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schernolyas/hibernate-ogm","description":"Hibernate Object/Grid Mapper","fork":true,"url":"https://api.github.com/repos/schernolyas/hibernate-ogm","forks_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/forks","keys_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/teams","hooks_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/hooks","issue_events_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/issues/events{/number}","events_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/events","assignees_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/assignees{/user}","branches_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/branches{/branch}","tags_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/tags","blobs_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/git/refs{/sha}","trees_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/statuses/{sha}","languages_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/languages","stargazers_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/stargazers","contributors_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/contributors","subscribers_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/subscribers","subscription_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/subscription","commits_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/commits{/sha}","git_commits_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/git/commits{/sha}","comments_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/comments{/number}","issue_comment_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/issues/comments{/number}","contents_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/contents/{+path}","compare_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/merges","archive_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/downloads","issues_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/issues{/number}","pulls_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/pulls{/number}","milestones_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/milestones{/number}","notifications_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/labels{/name}","releases_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/releases{/id}","deployments_url":"https://api.github.com/repos/schernolyas/hibernate-ogm/deployments","created_at":"2015-12-28T10:10:36Z","updated_at":"2017-03-03T11:37:15Z","pushed_at":"2018-03-13T08:21:47Z","git_url":"git://github.com/schernolyas/hibernate-ogm.git","ssh_url":"git@github.com:schernolyas/hibernate-ogm.git","clone_url":"https://github.com/schernolyas/hibernate-ogm.git","svn_url":"https://github.com/schernolyas/hibernate-ogm","homepage":"http://hibernate.org/ogm/","size":18054,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"a4bae8353bbfbe185e6769e8dbf185915315b70c","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":1608936,"name":"hibernate-ogm","full_name":"hibernate/hibernate-ogm","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-ogm","description":"Hibernate OGM - Domain model persistence for NoSQL datastores","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-ogm","forks_url":"https://api.github.com/repos/hibernate/hibernate-ogm/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-ogm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-ogm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-ogm/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-ogm/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-ogm/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-ogm/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-ogm/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-ogm/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-ogm/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-ogm/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-ogm/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-ogm/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-ogm/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-ogm/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-ogm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-ogm/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-ogm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-ogm/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-ogm/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-ogm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-ogm/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-ogm/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/deployments","created_at":"2011-04-13T11:40:56Z","updated_at":"2018-03-12T19:42:15Z","pushed_at":"2018-03-13T08:21:49Z","git_url":"git://github.com/hibernate/hibernate-ogm.git","ssh_url":"git@github.com:hibernate/hibernate-ogm.git","clone_url":"https://github.com/hibernate/hibernate-ogm.git","svn_url":"https://github.com/hibernate/hibernate-ogm","homepage":"http://hibernate.org/ogm/","size":15626,"stargazers_count":251,"watchers_count":251,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":178,"open_issues":5,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/987"},"html":{"href":"https://github.com/hibernate/hibernate-ogm/pull/987"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/987"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/987/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/987/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/987/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/785e7c491a6f7fc5569840596ee427c5e8f43716"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DavideD"}}