{"action":"closed","number":506,"pull_request":{"url":"https://api.github.com/repos/lobsters/lobsters/pulls/506","id":194660517,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjYwNTE3","html_url":"https://github.com/lobsters/lobsters/pull/506","diff_url":"https://github.com/lobsters/lobsters/pull/506.diff","patch_url":"https://github.com/lobsters/lobsters/pull/506.patch","issue_url":"https://api.github.com/repos/lobsters/lobsters/issues/506","number":506,"state":"closed","locked":false,"title":"Factorybot fixtures","user":{"login":"david-wolgemuth","id":11606807,"node_id":"MDQ6VXNlcjExNjA2ODA3","avatar_url":"https://avatars0.githubusercontent.com/u/11606807?v=4","gravatar_id":"","url":"https://api.github.com/users/david-wolgemuth","html_url":"https://github.com/david-wolgemuth","followers_url":"https://api.github.com/users/david-wolgemuth/followers","following_url":"https://api.github.com/users/david-wolgemuth/following{/other_user}","gists_url":"https://api.github.com/users/david-wolgemuth/gists{/gist_id}","starred_url":"https://api.github.com/users/david-wolgemuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-wolgemuth/subscriptions","organizations_url":"https://api.github.com/users/david-wolgemuth/orgs","repos_url":"https://api.github.com/users/david-wolgemuth/repos","events_url":"https://api.github.com/users/david-wolgemuth/events{/privacy}","received_events_url":"https://api.github.com/users/david-wolgemuth/received_events","type":"User","site_admin":false},"body":"Responding to issue #503.\r\n\r\nSwapped `machinist` gem with `factory_bot_rails` gem.\r\n\r\nIn summary, replaced all `Model.make!` with `create(:model)`, and `Model.make` with `build(:model)`. Also, made use of traits with the user factory.\r\n\r\n(closed and resubmitted PR because it failed tests on an empty test db)\r\n<!--\r\nIssues and PRs are typically reviewed Wednesday and some Thursday mornings.\r\n-->\r\n","created_at":"2018-06-13T17:29:25Z","updated_at":"2018-06-13T17:36:41Z","closed_at":"2018-06-13T17:36:41Z","merged_at":null,"merge_commit_sha":"62767b6c273b7eb65f64ce090c6c41e2d7577141","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lobsters/lobsters/pulls/506/commits","review_comments_url":"https://api.github.com/repos/lobsters/lobsters/pulls/506/comments","review_comment_url":"https://api.github.com/repos/lobsters/lobsters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lobsters/lobsters/issues/506/comments","statuses_url":"https://api.github.com/repos/lobsters/lobsters/statuses/d16bbbcec9be7006ab05b749c5b19bff31094932","head":{"label":"david-wolgemuth:factorybot_fixtures","ref":"factorybot_fixtures","sha":"d16bbbcec9be7006ab05b749c5b19bff31094932","user":{"login":"david-wolgemuth","id":11606807,"node_id":"MDQ6VXNlcjExNjA2ODA3","avatar_url":"https://avatars0.githubusercontent.com/u/11606807?v=4","gravatar_id":"","url":"https://api.github.com/users/david-wolgemuth","html_url":"https://github.com/david-wolgemuth","followers_url":"https://api.github.com/users/david-wolgemuth/followers","following_url":"https://api.github.com/users/david-wolgemuth/following{/other_user}","gists_url":"https://api.github.com/users/david-wolgemuth/gists{/gist_id}","starred_url":"https://api.github.com/users/david-wolgemuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-wolgemuth/subscriptions","organizations_url":"https://api.github.com/users/david-wolgemuth/orgs","repos_url":"https://api.github.com/users/david-wolgemuth/repos","events_url":"https://api.github.com/users/david-wolgemuth/events{/privacy}","received_events_url":"https://api.github.com/users/david-wolgemuth/received_events","type":"User","site_admin":false},"repo":{"id":131173092,"node_id":"MDEwOlJlcG9zaXRvcnkxMzExNzMwOTI=","name":"lobsters","full_name":"david-wolgemuth/lobsters","owner":{"login":"david-wolgemuth","id":11606807,"node_id":"MDQ6VXNlcjExNjA2ODA3","avatar_url":"https://avatars0.githubusercontent.com/u/11606807?v=4","gravatar_id":"","url":"https://api.github.com/users/david-wolgemuth","html_url":"https://github.com/david-wolgemuth","followers_url":"https://api.github.com/users/david-wolgemuth/followers","following_url":"https://api.github.com/users/david-wolgemuth/following{/other_user}","gists_url":"https://api.github.com/users/david-wolgemuth/gists{/gist_id}","starred_url":"https://api.github.com/users/david-wolgemuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-wolgemuth/subscriptions","organizations_url":"https://api.github.com/users/david-wolgemuth/orgs","repos_url":"https://api.github.com/users/david-wolgemuth/repos","events_url":"https://api.github.com/users/david-wolgemuth/events{/privacy}","received_events_url":"https://api.github.com/users/david-wolgemuth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-wolgemuth/lobsters","description":"Rails code running the Lobsters link aggregation site","fork":true,"url":"https://api.github.com/repos/david-wolgemuth/lobsters","forks_url":"https://api.github.com/repos/david-wolgemuth/lobsters/forks","keys_url":"https://api.github.com/repos/david-wolgemuth/lobsters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-wolgemuth/lobsters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-wolgemuth/lobsters/teams","hooks_url":"https://api.github.com/repos/david-wolgemuth/lobsters/hooks","issue_events_url":"https://api.github.com/repos/david-wolgemuth/lobsters/issues/events{/number}","events_url":"https://api.github.com/repos/david-wolgemuth/lobsters/events","assignees_url":"https://api.github.com/repos/david-wolgemuth/lobsters/assignees{/user}","branches_url":"https://api.github.com/repos/david-wolgemuth/lobsters/branches{/branch}","tags_url":"https://api.github.com/repos/david-wolgemuth/lobsters/tags","blobs_url":"https://api.github.com/repos/david-wolgemuth/lobsters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-wolgemuth/lobsters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-wolgemuth/lobsters/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-wolgemuth/lobsters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-wolgemuth/lobsters/statuses/{sha}","languages_url":"https://api.github.com/repos/david-wolgemuth/lobsters/languages","stargazers_url":"https://api.github.com/repos/david-wolgemuth/lobsters/stargazers","contributors_url":"https://api.github.com/repos/david-wolgemuth/lobsters/contributors","subscribers_url":"https://api.github.com/repos/david-wolgemuth/lobsters/subscribers","subscription_url":"https://api.github.com/repos/david-wolgemuth/lobsters/subscription","commits_url":"https://api.github.com/repos/david-wolgemuth/lobsters/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-wolgemuth/lobsters/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-wolgemuth/lobsters/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-wolgemuth/lobsters/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-wolgemuth/lobsters/contents/{+path}","compare_url":"https://api.github.com/repos/david-wolgemuth/lobsters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-wolgemuth/lobsters/merges","archive_url":"https://api.github.com/repos/david-wolgemuth/lobsters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-wolgemuth/lobsters/downloads","issues_url":"https://api.github.com/repos/david-wolgemuth/lobsters/issues{/number}","pulls_url":"https://api.github.com/repos/david-wolgemuth/lobsters/pulls{/number}","milestones_url":"https://api.github.com/repos/david-wolgemuth/lobsters/milestones{/number}","notifications_url":"https://api.github.com/repos/david-wolgemuth/lobsters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-wolgemuth/lobsters/labels{/name}","releases_url":"https://api.github.com/repos/david-wolgemuth/lobsters/releases{/id}","deployments_url":"https://api.github.com/repos/david-wolgemuth/lobsters/deployments","created_at":"2018-04-26T15:07:23Z","updated_at":"2018-06-11T19:45:22Z","pushed_at":"2018-06-13T17:26:35Z","git_url":"git://github.com/david-wolgemuth/lobsters.git","ssh_url":"git@github.com:david-wolgemuth/lobsters.git","clone_url":"https://github.com/david-wolgemuth/lobsters.git","svn_url":"https://github.com/david-wolgemuth/lobsters","homepage":"https://lobste.rs","size":2086,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lobsters:master","ref":"master","sha":"440c932d6338aec7dd280507af97ebce80d5a13f","user":{"login":"lobsters","id":32438445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDM4NDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/32438445?v=4","gravatar_id":"","url":"https://api.github.com/users/lobsters","html_url":"https://github.com/lobsters","followers_url":"https://api.github.com/users/lobsters/followers","following_url":"https://api.github.com/users/lobsters/following{/other_user}","gists_url":"https://api.github.com/users/lobsters/gists{/gist_id}","starred_url":"https://api.github.com/users/lobsters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lobsters/subscriptions","organizations_url":"https://api.github.com/users/lobsters/orgs","repos_url":"https://api.github.com/users/lobsters/repos","events_url":"https://api.github.com/users/lobsters/events{/privacy}","received_events_url":"https://api.github.com/users/lobsters/received_events","type":"Organization","site_admin":false},"repo":{"id":5543112,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQzMTEy","name":"lobsters","full_name":"lobsters/lobsters","owner":{"login":"lobsters","id":32438445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDM4NDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/32438445?v=4","gravatar_id":"","url":"https://api.github.com/users/lobsters","html_url":"https://github.com/lobsters","followers_url":"https://api.github.com/users/lobsters/followers","following_url":"https://api.github.com/users/lobsters/following{/other_user}","gists_url":"https://api.github.com/users/lobsters/gists{/gist_id}","starred_url":"https://api.github.com/users/lobsters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lobsters/subscriptions","organizations_url":"https://api.github.com/users/lobsters/orgs","repos_url":"https://api.github.com/users/lobsters/repos","events_url":"https://api.github.com/users/lobsters/events{/privacy}","received_events_url":"https://api.github.com/users/lobsters/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lobsters/lobsters","description":"Rails code running the Lobsters link aggregation site","fork":false,"url":"https://api.github.com/repos/lobsters/lobsters","forks_url":"https://api.github.com/repos/lobsters/lobsters/forks","keys_url":"https://api.github.com/repos/lobsters/lobsters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lobsters/lobsters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lobsters/lobsters/teams","hooks_url":"https://api.github.com/repos/lobsters/lobsters/hooks","issue_events_url":"https://api.github.com/repos/lobsters/lobsters/issues/events{/number}","events_url":"https://api.github.com/repos/lobsters/lobsters/events","assignees_url":"https://api.github.com/repos/lobsters/lobsters/assignees{/user}","branches_url":"https://api.github.com/repos/lobsters/lobsters/branches{/branch}","tags_url":"https://api.github.com/repos/lobsters/lobsters/tags","blobs_url":"https://api.github.com/repos/lobsters/lobsters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lobsters/lobsters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lobsters/lobsters/git/refs{/sha}","trees_url":"https://api.github.com/repos/lobsters/lobsters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lobsters/lobsters/statuses/{sha}","languages_url":"https://api.github.com/repos/lobsters/lobsters/languages","stargazers_url":"https://api.github.com/repos/lobsters/lobsters/stargazers","contributors_url":"https://api.github.com/repos/lobsters/lobsters/contributors","subscribers_url":"https://api.github.com/repos/lobsters/lobsters/subscribers","subscription_url":"https://api.github.com/repos/lobsters/lobsters/subscription","commits_url":"https://api.github.com/repos/lobsters/lobsters/commits{/sha}","git_commits_url":"https://api.github.com/repos/lobsters/lobsters/git/commits{/sha}","comments_url":"https://api.github.com/repos/lobsters/lobsters/comments{/number}","issue_comment_url":"https://api.github.com/repos/lobsters/lobsters/issues/comments{/number}","contents_url":"https://api.github.com/repos/lobsters/lobsters/contents/{+path}","compare_url":"https://api.github.com/repos/lobsters/lobsters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lobsters/lobsters/merges","archive_url":"https://api.github.com/repos/lobsters/lobsters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lobsters/lobsters/downloads","issues_url":"https://api.github.com/repos/lobsters/lobsters/issues{/number}","pulls_url":"https://api.github.com/repos/lobsters/lobsters/pulls{/number}","milestones_url":"https://api.github.com/repos/lobsters/lobsters/milestones{/number}","notifications_url":"https://api.github.com/repos/lobsters/lobsters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lobsters/lobsters/labels{/name}","releases_url":"https://api.github.com/repos/lobsters/lobsters/releases{/id}","deployments_url":"https://api.github.com/repos/lobsters/lobsters/deployments","created_at":"2012-08-24T16:48:03Z","updated_at":"2018-06-13T14:57:49Z","pushed_at":"2018-06-13T17:29:26Z","git_url":"git://github.com/lobsters/lobsters.git","ssh_url":"git@github.com:lobsters/lobsters.git","clone_url":"https://github.com/lobsters/lobsters.git","svn_url":"https://github.com/lobsters/lobsters","homepage":"https://lobste.rs","size":2084,"stargazers_count":1685,"watchers_count":1685,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":434,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":434,"open_issues":28,"watchers":1685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lobsters/lobsters/pulls/506"},"html":{"href":"https://github.com/lobsters/lobsters/pull/506"},"issue":{"href":"https://api.github.com/repos/lobsters/lobsters/issues/506"},"comments":{"href":"https://api.github.com/repos/lobsters/lobsters/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/lobsters/lobsters/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/lobsters/lobsters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lobsters/lobsters/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/lobsters/lobsters/statuses/d16bbbcec9be7006ab05b749c5b19bff31094932"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":215,"deletions":195,"changed_files":26}}
{"actor":{"display_login":"david-wolgemuth"}}