{"action":"created","comment":{"url":"https://api.github.com/repos/hypothesis/h/pulls/comments/174854769","pull_request_review_id":104289077,"id":174854769,"diff_hunk":"@@ -1,15 +1,25 @@\n {% if not field.widget.hidden %}\n <li class=\"list-input__item\" title=\"{{ field.description }}\">\n \n-  {{ field.serialize(cstruct=cstruct) | safe }}\n+  <div class=\"list-input__item-inner\">\n+    {{ field.serialize(cstruct=cstruct) | safe }}\n \n-  <button class=\"btn btn--danger list-input__remove-btn\" type=\"button\"\n-          data-ref=\"removeItemButton\">Remove</button>\n+    <button class=\"list-input__remove-btn\"\n+            title=\"{% trans %}Remove item{% endtrans %}\"\n+            type=\"button\"\n+            data-ref=\"removeItemButton\">\n+    {{ svg_icon('lozenge-close') }}\n+    </button>\n+  </div>\n \n-  {% if field.error %}\n-  {% for msg in field.error.messages() %}\n-  <p class=\"{{ field.widget.error_class }}\">{{ msg }}</p>\n-  {% endfor %}\n-  {% endif %}\n+  {%- if field.error and not field.widget.hidden -%}\n+  <ul class=\"list-input__error-list\">\n+    {% for msg in field.error.messages() -%}\n+      {%- set errstr = 'error-%s' % field.oid -%}\n+      {%- set pid = (loop.index0==0 and errstr) or ('%s-%s' % (errstr, loop.index0)) -%}\n+      <li class=\"list-input__error-item\" id=\"{{ pid }}\">{{ _(msg) }}</li>\n+    {% endfor -%}\n+  </ul>\n+  {% endif -%}","path":"h/templates/deform/sequence_item.jinja2","position":31,"original_position":31,"commit_id":"5d3133c978a843c796b88d13a554b1456782d1a2","original_commit_id":"5d3133c978a843c796b88d13a554b1456782d1a2","user":{"login":"seanh","id":22498,"avatar_url":"https://avatars3.githubusercontent.com/u/22498?v=4","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"body":"Yeah. Probably good to move away from that design generally","created_at":"2018-03-15T16:53:06Z","updated_at":"2018-03-15T16:53:06Z","html_url":"https://github.com/hypothesis/h/pull/4884#discussion_r174854769","pull_request_url":"https://api.github.com/repos/hypothesis/h/pulls/4884","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments/174854769"},"html":{"href":"https://github.com/hypothesis/h/pull/4884#discussion_r174854769"},"pull_request":{"href":"https://api.github.com/repos/hypothesis/h/pulls/4884"}},"in_reply_to_id":174852731},"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/4884","id":175259096,"html_url":"https://github.com/hypothesis/h/pull/4884","diff_url":"https://github.com/hypothesis/h/pull/4884.diff","patch_url":"https://github.com/hypothesis/h/pull/4884.patch","issue_url":"https://api.github.com/repos/hypothesis/h/issues/4884","number":4884,"state":"open","locked":false,"title":"Improve design of form list inputs (Part 1)","user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"body":"~~**Depends on https://github.com/hypothesis/h/pull/4879**~~\r\n\r\nThese are the initial batch of improvements to the design of form list input. The changes in this PR are to:\r\n\r\n- Reduce the height of input fields without labels\r\n- Make the \"Remove item\" button more subtle\r\n- Display validation error messages closer to the input field and in red\r\n\r\nNotably missing from this first batch of changes is to make the outline of list items with validation errors bold + red as they are for other input fields. That will come in follow-up work.\r\n\r\n**Master:**\r\n\r\n<img width=\"435\" alt=\"screenshot 2018-03-15 13 53 04\" src=\"https://user-images.githubusercontent.com/2458/37467609-a194f9c4-2858-11e8-8110-9381eb615a43.png\">\r\n\r\n<img width=\"432\" alt=\"screenshot 2018-03-15 13 52 45\" src=\"https://user-images.githubusercontent.com/2458/37467615-a9f425e0-2858-11e8-9a02-5b95a2c6c251.png\">\r\n\r\n**This branch:**\r\n\r\n<img width=\"426\" alt=\"screenshot 2018-03-15 13 52 01\" src=\"https://user-images.githubusercontent.com/2458/37467641-bc37f68c-2858-11e8-883f-c32bec0a33f8.png\">\r\n\r\n<img width=\"426\" alt=\"screenshot 2018-03-15 13 52 17\" src=\"https://user-images.githubusercontent.com/2458/37467630-b62bd52e-2858-11e8-84be-05fe808a817c.png\">\r\n\r\n\r\n","created_at":"2018-03-15T14:00:08Z","updated_at":"2018-03-15T16:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06bae55d1c66515748dc2fe77e65974af434eb2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hypothesis/h/pulls/4884/commits","review_comments_url":"https://api.github.com/repos/hypothesis/h/pulls/4884/comments","review_comment_url":"https://api.github.com/repos/hypothesis/h/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/4884/comments","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/5d3133c978a843c796b88d13a554b1456782d1a2","head":{"label":"hypothesis:improve-form-list-design-pt1","ref":"improve-form-list-design-pt1","sha":"5d3133c978a843c796b88d13a554b1456782d1a2","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"name":"h","full_name":"hypothesis/h","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/h","description":"Annotate with anyone, anywhere.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/h/deployments","created_at":"2012-04-02T19:56:59Z","updated_at":"2018-03-15T16:41:45Z","pushed_at":"2018-03-15T16:42:19Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":28916,"stargazers_count":1053,"watchers_count":1053,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":244,"open_issues":68,"watchers":1053,"default_branch":"master"}},"base":{"label":"hypothesis:master","ref":"master","sha":"9be06bf63ffd930133f6eae35cc1a7e162fa1870","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"name":"h","full_name":"hypothesis/h","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/h","description":"Annotate with anyone, anywhere.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/h/deployments","created_at":"2012-04-02T19:56:59Z","updated_at":"2018-03-15T16:41:45Z","pushed_at":"2018-03-15T16:42:19Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":28916,"stargazers_count":1053,"watchers_count":1053,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":244,"open_issues":68,"watchers":1053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/4884"},"html":{"href":"https://github.com/hypothesis/h/pull/4884"},"issue":{"href":"https://api.github.com/repos/hypothesis/h/issues/4884"},"comments":{"href":"https://api.github.com/repos/hypothesis/h/issues/4884/comments"},"review_comments":{"href":"https://api.github.com/repos/hypothesis/h/pulls/4884/comments"},"review_comment":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hypothesis/h/pulls/4884/commits"},"statuses":{"href":"https://api.github.com/repos/hypothesis/h/statuses/5d3133c978a843c796b88d13a554b1456782d1a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"seanh"}}