{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/comments/201791899","pull_request_review_id":136362707,"id":201791899,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc5MTg5OQ==","diff_hunk":"@@ -0,0 +1,69 @@\n+@testset \"Cycle Basis\" begin\n+\n+    function evaluate(x,y)\n+        @test length(x) == length(y)\n+        for i=1:length(x)\n+            @test isempty(setdiff(x[i],y[i]))\n+            @test isempty(setdiff(x[i],y[i]))\n+        end\n+    end\n+\n+    # No Edges\n+    ex = Graph(1)\n+    expected_cyclebasis = Array{Int64,1}[]\n+    for g in testgraphs(ex)\n+        ex_cyclebasis = cycle_basis(g)","path":"test/cycles/basis.jl","position":15,"original_position":15,"commit_id":"b1c7a8fb8a476061c3b329c7b2cd78f8eebd3d11","original_commit_id":"b1c7a8fb8a476061c3b329c7b2cd78f8eebd3d11","user":{"login":"fneum","id":29101152,"node_id":"MDQ6VXNlcjI5MTAxMTUy","avatar_url":"https://avatars1.githubusercontent.com/u/29101152?v=4","gravatar_id":"","url":"https://api.github.com/users/fneum","html_url":"https://github.com/fneum","followers_url":"https://api.github.com/users/fneum/followers","following_url":"https://api.github.com/users/fneum/following{/other_user}","gists_url":"https://api.github.com/users/fneum/gists{/gist_id}","starred_url":"https://api.github.com/users/fneum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fneum/subscriptions","organizations_url":"https://api.github.com/users/fneum/orgs","repos_url":"https://api.github.com/users/fneum/repos","events_url":"https://api.github.com/users/fneum/events{/privacy}","received_events_url":"https://api.github.com/users/fneum/received_events","type":"User","site_admin":false},"body":"Alright, is this also necessary for the other test cases?","created_at":"2018-07-11T18:15:09Z","updated_at":"2018-07-11T18:15:10Z","html_url":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/929#discussion_r201791899","pull_request_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/929","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/comments/201791899"},"html":{"href":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/929#discussion_r201791899"},"pull_request":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/929"}},"in_reply_to_id":201730192},"pull_request":{"url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/929","id":200663673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjYzNjcz","html_url":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/929","diff_url":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/929.diff","patch_url":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/929.patch","issue_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/929","number":929,"state":"open","locked":false,"title":"Function to return cycle basis for undirected graph","user":{"login":"fneum","id":29101152,"node_id":"MDQ6VXNlcjI5MTAxMTUy","avatar_url":"https://avatars1.githubusercontent.com/u/29101152?v=4","gravatar_id":"","url":"https://api.github.com/users/fneum","html_url":"https://github.com/fneum","followers_url":"https://api.github.com/users/fneum/followers","following_url":"https://api.github.com/users/fneum/following{/other_user}","gists_url":"https://api.github.com/users/fneum/gists{/gist_id}","starred_url":"https://api.github.com/users/fneum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fneum/subscriptions","organizations_url":"https://api.github.com/users/fneum/orgs","repos_url":"https://api.github.com/users/fneum/repos","events_url":"https://api.github.com/users/fneum/events{/privacy}","received_events_url":"https://api.github.com/users/fneum/received_events","type":"User","site_admin":false},"body":"This is the PR to the discussion in issue #927.\r\n\r\n1. Added a function that returns a list of cycles which form a basis for cycles of an _undirected_ graph. It translates an algorithm included in the Python library [networkx.algorithms.cycles.cycle_basis](https://networkx.github.io/documentation/latest/reference/algorithms/generated/networkx.algorithms.cycles.cycle_basis.html). A basis for cycles of a network is a minimal collection of cycles such that any cycle in the network can be written as a sum of cycles in the basis. Also includes tests.\r\n\r\n2. So far the circuit function for oriented graphs is placed in `digraph/cycles`. Made a re-organization of the files such that the `digraph/cycles` folder goes up one level to include both circuits and cycles.\r\n\r\nI'd be happy about feedback if something does not fit! Not entirely sure if everything is in right place and style.","created_at":"2018-07-11T11:05:51Z","updated_at":"2018-07-11T18:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38ef1f9e07baccfeb1e6a8327c342cb547ea7648","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/929/commits","review_comments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/929/comments","review_comment_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/929/comments","statuses_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/statuses/b1c7a8fb8a476061c3b329c7b2cd78f8eebd3d11","head":{"label":"fneum:master","ref":"master","sha":"b1c7a8fb8a476061c3b329c7b2cd78f8eebd3d11","user":{"login":"fneum","id":29101152,"node_id":"MDQ6VXNlcjI5MTAxMTUy","avatar_url":"https://avatars1.githubusercontent.com/u/29101152?v=4","gravatar_id":"","url":"https://api.github.com/users/fneum","html_url":"https://github.com/fneum","followers_url":"https://api.github.com/users/fneum/followers","following_url":"https://api.github.com/users/fneum/following{/other_user}","gists_url":"https://api.github.com/users/fneum/gists{/gist_id}","starred_url":"https://api.github.com/users/fneum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fneum/subscriptions","organizations_url":"https://api.github.com/users/fneum/orgs","repos_url":"https://api.github.com/users/fneum/repos","events_url":"https://api.github.com/users/fneum/events{/privacy}","received_events_url":"https://api.github.com/users/fneum/received_events","type":"User","site_admin":false},"repo":{"id":140550963,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1NTA5NjM=","name":"LightGraphs.jl","full_name":"fneum/LightGraphs.jl","owner":{"login":"fneum","id":29101152,"node_id":"MDQ6VXNlcjI5MTAxMTUy","avatar_url":"https://avatars1.githubusercontent.com/u/29101152?v=4","gravatar_id":"","url":"https://api.github.com/users/fneum","html_url":"https://github.com/fneum","followers_url":"https://api.github.com/users/fneum/followers","following_url":"https://api.github.com/users/fneum/following{/other_user}","gists_url":"https://api.github.com/users/fneum/gists{/gist_id}","starred_url":"https://api.github.com/users/fneum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fneum/subscriptions","organizations_url":"https://api.github.com/users/fneum/orgs","repos_url":"https://api.github.com/users/fneum/repos","events_url":"https://api.github.com/users/fneum/events{/privacy}","received_events_url":"https://api.github.com/users/fneum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fneum/LightGraphs.jl","description":"An optimized graphs package for Julia","fork":true,"url":"https://api.github.com/repos/fneum/LightGraphs.jl","forks_url":"https://api.github.com/repos/fneum/LightGraphs.jl/forks","keys_url":"https://api.github.com/repos/fneum/LightGraphs.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fneum/LightGraphs.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fneum/LightGraphs.jl/teams","hooks_url":"https://api.github.com/repos/fneum/LightGraphs.jl/hooks","issue_events_url":"https://api.github.com/repos/fneum/LightGraphs.jl/issues/events{/number}","events_url":"https://api.github.com/repos/fneum/LightGraphs.jl/events","assignees_url":"https://api.github.com/repos/fneum/LightGraphs.jl/assignees{/user}","branches_url":"https://api.github.com/repos/fneum/LightGraphs.jl/branches{/branch}","tags_url":"https://api.github.com/repos/fneum/LightGraphs.jl/tags","blobs_url":"https://api.github.com/repos/fneum/LightGraphs.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fneum/LightGraphs.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fneum/LightGraphs.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/fneum/LightGraphs.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fneum/LightGraphs.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/fneum/LightGraphs.jl/languages","stargazers_url":"https://api.github.com/repos/fneum/LightGraphs.jl/stargazers","contributors_url":"https://api.github.com/repos/fneum/LightGraphs.jl/contributors","subscribers_url":"https://api.github.com/repos/fneum/LightGraphs.jl/subscribers","subscription_url":"https://api.github.com/repos/fneum/LightGraphs.jl/subscription","commits_url":"https://api.github.com/repos/fneum/LightGraphs.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/fneum/LightGraphs.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/fneum/LightGraphs.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/fneum/LightGraphs.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/fneum/LightGraphs.jl/contents/{+path}","compare_url":"https://api.github.com/repos/fneum/LightGraphs.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fneum/LightGraphs.jl/merges","archive_url":"https://api.github.com/repos/fneum/LightGraphs.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fneum/LightGraphs.jl/downloads","issues_url":"https://api.github.com/repos/fneum/LightGraphs.jl/issues{/number}","pulls_url":"https://api.github.com/repos/fneum/LightGraphs.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/fneum/LightGraphs.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/fneum/LightGraphs.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fneum/LightGraphs.jl/labels{/name}","releases_url":"https://api.github.com/repos/fneum/LightGraphs.jl/releases{/id}","deployments_url":"https://api.github.com/repos/fneum/LightGraphs.jl/deployments","created_at":"2018-07-11T09:14:57Z","updated_at":"2018-07-11T13:44:00Z","pushed_at":"2018-07-11T13:43:58Z","git_url":"git://github.com/fneum/LightGraphs.jl.git","ssh_url":"git@github.com:fneum/LightGraphs.jl.git","clone_url":"https://github.com/fneum/LightGraphs.jl.git","svn_url":"https://github.com/fneum/LightGraphs.jl","homepage":"","size":5474,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaGraphs:master","ref":"master","sha":"80aa43f49d966ffadf7bd0ca5e798b46333dba51","user":{"login":"JuliaGraphs","id":10791402,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzkxNDAy","avatar_url":"https://avatars0.githubusercontent.com/u/10791402?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"repo":{"id":29314835,"node_id":"MDEwOlJlcG9zaXRvcnkyOTMxNDgzNQ==","name":"LightGraphs.jl","full_name":"JuliaGraphs/LightGraphs.jl","owner":{"login":"JuliaGraphs","id":10791402,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzkxNDAy","avatar_url":"https://avatars0.githubusercontent.com/u/10791402?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaGraphs/LightGraphs.jl","description":"An optimized graphs package for Julia","fork":false,"url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl","forks_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/forks","keys_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/teams","hooks_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/events","assignees_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/tags","blobs_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/subscription","commits_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/merges","archive_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/downloads","issues_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/deployments","created_at":"2015-01-15T19:44:43Z","updated_at":"2018-07-09T10:08:13Z","pushed_at":"2018-07-11T17:21:58Z","git_url":"git://github.com/JuliaGraphs/LightGraphs.jl.git","ssh_url":"git@github.com:JuliaGraphs/LightGraphs.jl.git","clone_url":"https://github.com/JuliaGraphs/LightGraphs.jl.git","svn_url":"https://github.com/JuliaGraphs/LightGraphs.jl","homepage":"","size":5468,"stargazers_count":213,"watchers_count":213,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":82,"open_issues":14,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/929"},"html":{"href":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/929"},"issue":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/929"},"comments":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/929/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/929/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/929/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/statuses/b1c7a8fb8a476061c3b329c7b2cd78f8eebd3d11"}},"author_association":"NONE"}}
{"actor":{"display_login":"fneum"}}