{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/244147985","pull_request_review_id":188083152,"id":244147985,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDE0Nzk4NQ==","diff_hunk":"@@ -593,29 +594,80 @@ duplicate in between calls).\n void largestPartialIntersection\n (alias less = \"a < b\", RangeOfRanges, Range)\n (RangeOfRanges ror, Range tgt, SortOutput sorted = No.sortOutput)\n+if (isSortedRange!(ElementType!(RangeOfRanges)))\n {\n-    struct UnitWeights\n-    {\n-        static int opIndex(ElementType!(ElementType!RangeOfRanges)) { return 1; }\n-    }\n-    return largestPartialIntersectionWeighted!less(ror, tgt, UnitWeights(),\n-            sorted);\n+    largestPartialIntersectionImpl(ror, tgt, sorted);\n+}\n+\n+/// ditto\n+void largestPartialIntersection","path":"std/algorithm/setops.d","position":45,"original_position":44,"commit_id":"42928fd64bbe1bcb2d63e31dd8d2c3255f5dd2d3","original_commit_id":"5eb52e5bf56a41354d38c1ec2205d6718f2e655f","user":{"login":"burner","id":13327,"node_id":"MDQ6VXNlcjEzMzI3","avatar_url":"https://avatars0.githubusercontent.com/u/13327?v=4","gravatar_id":"","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"body":"yes, the one that is not requiring a SortedRange should be removed eventually. ","created_at":"2018-12-27T12:58:01Z","updated_at":"2018-12-27T12:58:01Z","html_url":"https://github.com/dlang/phobos/pull/6795#discussion_r244147985","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/6795","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/244147985"},"html":{"href":"https://github.com/dlang/phobos/pull/6795#discussion_r244147985"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6795"}},"in_reply_to_id":241464847},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/6795","id":236511442,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTExNDQy","html_url":"https://github.com/dlang/phobos/pull/6795","diff_url":"https://github.com/dlang/phobos/pull/6795.diff","patch_url":"https://github.com/dlang/phobos/pull/6795.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/6795","number":6795,"state":"open","locked":false,"title":"Fix Issue 10706 setops functions need to require SortedRanges","user":{"login":"burner","id":13327,"node_id":"MDQ6VXNlcjEzMzI3","avatar_url":"https://avatars0.githubusercontent.com/u/13327?v=4","gravatar_id":"","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"body":"https://issues.dlang.org/show_bug.cgi?id=10706\r\n\r\n* largestPartialIntersection\r\n* largestPartialIntersectionWeighted\r\n* multiwayMerge\r\n* multiwayUnion\r\n* setDifference\r\n* setIntersection\r\n* setSymmetricDifference\r\n\r\nNow all require SortedRanges to be passed, as that is what they expect\r\nimplicitly anyway.\r\n\r\nA new public symbol `isSortedRange` was added to std.range.","created_at":"2018-12-06T12:23:28Z","updated_at":"2018-12-27T12:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9c5ced1018a5db3506d7056bd90b875abc12332","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JackStouffer","id":680068,"node_id":"MDQ6VXNlcjY4MDA2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/680068?v=4","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false},{"login":"ZombineDev","id":3475150,"node_id":"MDQ6VXNlcjM0NzUxNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3475150?v=4","gravatar_id":"","url":"https://api.github.com/users/ZombineDev","html_url":"https://github.com/ZombineDev","followers_url":"https://api.github.com/users/ZombineDev/followers","following_url":"https://api.github.com/users/ZombineDev/following{/other_user}","gists_url":"https://api.github.com/users/ZombineDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ZombineDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZombineDev/subscriptions","organizations_url":"https://api.github.com/users/ZombineDev/orgs","repos_url":"https://api.github.com/users/ZombineDev/repos","events_url":"https://api.github.com/users/ZombineDev/events{/privacy}","received_events_url":"https://api.github.com/users/ZombineDev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":416188102,"node_id":"MDU6TGFiZWw0MTYxODgxMDI=","url":"https://api.github.com/repos/dlang/phobos/labels/Bug%20Fix","name":"Bug Fix","color":"0052cc","default":false},{"id":416188433,"node_id":"MDU6TGFiZWw0MTYxODg0MzM=","url":"https://api.github.com/repos/dlang/phobos/labels/Enhancement","name":"Enhancement","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/6795/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/6795/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/6795/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/42928fd64bbe1bcb2d63e31dd8d2c3255f5dd2d3","head":{"label":"burner:issue10706","ref":"issue10706","sha":"42928fd64bbe1bcb2d63e31dd8d2c3255f5dd2d3","user":{"login":"burner","id":13327,"node_id":"MDQ6VXNlcjEzMzI3","avatar_url":"https://avatars0.githubusercontent.com/u/13327?v=4","gravatar_id":"","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"repo":{"id":7882025,"node_id":"MDEwOlJlcG9zaXRvcnk3ODgyMDI1","name":"phobos","full_name":"burner/phobos","private":false,"owner":{"login":"burner","id":13327,"node_id":"MDQ6VXNlcjEzMzI3","avatar_url":"https://avatars0.githubusercontent.com/u/13327?v=4","gravatar_id":"","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/burner/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/burner/phobos","forks_url":"https://api.github.com/repos/burner/phobos/forks","keys_url":"https://api.github.com/repos/burner/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burner/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burner/phobos/teams","hooks_url":"https://api.github.com/repos/burner/phobos/hooks","issue_events_url":"https://api.github.com/repos/burner/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/burner/phobos/events","assignees_url":"https://api.github.com/repos/burner/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/burner/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/burner/phobos/tags","blobs_url":"https://api.github.com/repos/burner/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burner/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burner/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/burner/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burner/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/burner/phobos/languages","stargazers_url":"https://api.github.com/repos/burner/phobos/stargazers","contributors_url":"https://api.github.com/repos/burner/phobos/contributors","subscribers_url":"https://api.github.com/repos/burner/phobos/subscribers","subscription_url":"https://api.github.com/repos/burner/phobos/subscription","commits_url":"https://api.github.com/repos/burner/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/burner/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/burner/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/burner/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/burner/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/burner/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burner/phobos/merges","archive_url":"https://api.github.com/repos/burner/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burner/phobos/downloads","issues_url":"https://api.github.com/repos/burner/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/burner/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/burner/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/burner/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burner/phobos/labels{/name}","releases_url":"https://api.github.com/repos/burner/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/burner/phobos/deployments","created_at":"2013-01-29T00:26:08Z","updated_at":"2015-03-18T19:53:04Z","pushed_at":"2018-12-18T12:29:14Z","git_url":"git://github.com/burner/phobos.git","ssh_url":"git@github.com:burner/phobos.git","clone_url":"https://github.com/burner/phobos.git","svn_url":"https://github.com/burner/phobos","homepage":"dlang.org/phobos","size":51079,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"21afd40c422efdb8483d15aa31a867b0cd69fa8b","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDg0","name":"phobos","full_name":"dlang/phobos","private":false,"owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2018-12-27T01:02:54Z","pushed_at":"2018-12-27T01:02:37Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":51432,"stargazers_count":901,"watchers_count":901,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":625,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":625,"open_issues":112,"watchers":901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6795"},"html":{"href":"https://github.com/dlang/phobos/pull/6795"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/6795"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/6795/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6795/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6795/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/42928fd64bbe1bcb2d63e31dd8d2c3255f5dd2d3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"burner"}}