{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/184869006","pull_request_review_id":116152567,"id":184869006,"diff_hunk":"@@ -140,17 +135,7 @@ class MClientCaps : public Message {\n \t      int dirty,\n \t      int mseq,\n               epoch_t oeb)\n-    : Message(CEPH_MSG_CLIENT_CAPS, HEAD_VERSION, COMPAT_VERSION),\n-      size(0),\n-      max_size(0),\n-      truncate_size(0),\n-      change_attr(0),\n-      truncate_seq(0),\n-      time_warp_seq(0),\n-      osd_epoch_barrier(oeb),","path":"src/messages/MClientCaps.h","position":92,"original_position":92,"commit_id":"02f878f5446b510dd5d767369d52ac9c6f9b3c98","original_commit_id":"02f878f5446b510dd5d767369d52ac9c6f9b3c98","user":{"login":"batrick","id":548304,"avatar_url":"https://avatars3.githubusercontent.com/u/548304?v=4","gravatar_id":"","url":"https://api.github.com/users/batrick","html_url":"https://github.com/batrick","followers_url":"https://api.github.com/users/batrick/followers","following_url":"https://api.github.com/users/batrick/following{/other_user}","gists_url":"https://api.github.com/users/batrick/gists{/gist_id}","starred_url":"https://api.github.com/users/batrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batrick/subscriptions","organizations_url":"https://api.github.com/users/batrick/orgs","repos_url":"https://api.github.com/users/batrick/repos","events_url":"https://api.github.com/users/batrick/events{/privacy}","received_events_url":"https://api.github.com/users/batrick/received_events","type":"User","site_admin":false},"body":"This was accidentally removed. It's initializing `osd_epoch_barrier(0)` (the default). Causes: http://tracker.ceph.com/issues/23927","created_at":"2018-04-29T01:15:20Z","updated_at":"2018-04-29T01:15:25Z","html_url":"https://github.com/ceph/ceph/pull/21668#discussion_r184869006","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/21668","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/184869006"},"html":{"href":"https://github.com/ceph/ceph/pull/21668#discussion_r184869006"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21668"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/21668","id":184296200,"html_url":"https://github.com/ceph/ceph/pull/21668","diff_url":"https://github.com/ceph/ceph/pull/21668.diff","patch_url":"https://github.com/ceph/ceph/pull/21668.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/21668","number":21668,"state":"open","locked":false,"title":"mds: include nfiles/nsubdirs of directory inode in MClientCaps","user":{"login":"ukernel","id":2775471,"avatar_url":"https://avatars1.githubusercontent.com/u/2775471?v=4","gravatar_id":"","url":"https://api.github.com/users/ukernel","html_url":"https://github.com/ukernel","followers_url":"https://api.github.com/users/ukernel/followers","following_url":"https://api.github.com/users/ukernel/following{/other_user}","gists_url":"https://api.github.com/users/ukernel/gists{/gist_id}","starred_url":"https://api.github.com/users/ukernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukernel/subscriptions","organizations_url":"https://api.github.com/users/ukernel/orgs","repos_url":"https://api.github.com/users/ukernel/repos","events_url":"https://api.github.com/users/ukernel/events{/privacy}","received_events_url":"https://api.github.com/users/ukernel/received_events","type":"User","site_admin":false},"body":"Directory inode's dirstat gets updated by request reply, but not by\r\ncap message. This causes problem for following case.\r\n\r\n1. MDS modifies a directory\r\n2. MDS issues CEPH_CAP_ANY_SHARED to client\r\n3. The client satifies stat(2) by its cached metadata.\r\n\r\nSigned-off-by: \"Yan, Zheng\" <zyan@redhat.com>\r\nFixes: http://tracker.ceph.com/issues/23855","created_at":"2018-04-26T10:34:40Z","updated_at":"2018-04-29T01:15:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e8239e0ebe30cd1409d1e9afff03f26fe9b0b1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":134774049,"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329802,"url":"https://api.github.com/repos/ceph/ceph/labels/cephfs","name":"cephfs","color":"b192ff","default":false},{"id":635439348,"url":"https://api.github.com/repos/ceph/ceph/labels/wip-pdonnell-testing","name":"wip-pdonnell-testing","color":"12346b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/21668/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/21668/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/21668/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/02f878f5446b510dd5d767369d52ac9c6f9b3c98","head":{"label":"ukernel:wip-23855","ref":"wip-23855","sha":"02f878f5446b510dd5d767369d52ac9c6f9b3c98","user":{"login":"ukernel","id":2775471,"avatar_url":"https://avatars1.githubusercontent.com/u/2775471?v=4","gravatar_id":"","url":"https://api.github.com/users/ukernel","html_url":"https://github.com/ukernel","followers_url":"https://api.github.com/users/ukernel/followers","following_url":"https://api.github.com/users/ukernel/following{/other_user}","gists_url":"https://api.github.com/users/ukernel/gists{/gist_id}","starred_url":"https://api.github.com/users/ukernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukernel/subscriptions","organizations_url":"https://api.github.com/users/ukernel/orgs","repos_url":"https://api.github.com/users/ukernel/repos","events_url":"https://api.github.com/users/ukernel/events{/privacy}","received_events_url":"https://api.github.com/users/ukernel/received_events","type":"User","site_admin":false},"repo":{"id":13721085,"name":"ceph","full_name":"ukernel/ceph","owner":{"login":"ukernel","id":2775471,"avatar_url":"https://avatars1.githubusercontent.com/u/2775471?v=4","gravatar_id":"","url":"https://api.github.com/users/ukernel","html_url":"https://github.com/ukernel","followers_url":"https://api.github.com/users/ukernel/followers","following_url":"https://api.github.com/users/ukernel/following{/other_user}","gists_url":"https://api.github.com/users/ukernel/gists{/gist_id}","starred_url":"https://api.github.com/users/ukernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukernel/subscriptions","organizations_url":"https://api.github.com/users/ukernel/orgs","repos_url":"https://api.github.com/users/ukernel/repos","events_url":"https://api.github.com/users/ukernel/events{/privacy}","received_events_url":"https://api.github.com/users/ukernel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ukernel/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/ukernel/ceph","forks_url":"https://api.github.com/repos/ukernel/ceph/forks","keys_url":"https://api.github.com/repos/ukernel/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ukernel/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ukernel/ceph/teams","hooks_url":"https://api.github.com/repos/ukernel/ceph/hooks","issue_events_url":"https://api.github.com/repos/ukernel/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ukernel/ceph/events","assignees_url":"https://api.github.com/repos/ukernel/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ukernel/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ukernel/ceph/tags","blobs_url":"https://api.github.com/repos/ukernel/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ukernel/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ukernel/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ukernel/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ukernel/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ukernel/ceph/languages","stargazers_url":"https://api.github.com/repos/ukernel/ceph/stargazers","contributors_url":"https://api.github.com/repos/ukernel/ceph/contributors","subscribers_url":"https://api.github.com/repos/ukernel/ceph/subscribers","subscription_url":"https://api.github.com/repos/ukernel/ceph/subscription","commits_url":"https://api.github.com/repos/ukernel/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ukernel/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ukernel/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ukernel/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ukernel/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ukernel/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ukernel/ceph/merges","archive_url":"https://api.github.com/repos/ukernel/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ukernel/ceph/downloads","issues_url":"https://api.github.com/repos/ukernel/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ukernel/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ukernel/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ukernel/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ukernel/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ukernel/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ukernel/ceph/deployments","created_at":"2013-10-20T15:10:44Z","updated_at":"2018-04-20T07:51:58Z","pushed_at":"2018-04-28T10:33:22Z","git_url":"git://github.com/ukernel/ceph.git","ssh_url":"git@github.com:ukernel/ceph.git","clone_url":"https://github.com/ukernel/ceph.git","svn_url":"https://github.com/ukernel/ceph","homepage":"http://ceph.com","size":254159,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"ff98185a2621dee7c2d7ac3e3c44f519a803615c","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-04-29T00:58:56Z","pushed_at":"2018-04-29T00:36:15Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":280941,"stargazers_count":4424,"watchers_count":4424,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2422,"mirror_url":null,"archived":false,"open_issues_count":664,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2422,"open_issues":664,"watchers":4424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21668"},"html":{"href":"https://github.com/ceph/ceph/pull/21668"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/21668"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/21668/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21668/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21668/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/02f878f5446b510dd5d767369d52ac9c6f9b3c98"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"batrick"}}