{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/209675014","pull_request_review_id":145734061,"id":209675014,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTY3NTAxNA==","diff_hunk":"@@ -246,6 +296,25 @@ def apply_gradients(self, grads_and_vars, global_step=None, name=None):\n       local_update = state_ops.assign_add(\n           self._local_step, 1, name='local_step_update').op\n \n+    # this is for place the variables created by optimizer to local collection\n+    # e.g., AdamOptimizer will create beta as global variables\n+    def _adjust_optimizer_variable_collection():","path":"tensorflow/contrib/opt/python/training/elastic_average_optimizer.py","position":170,"original_position":170,"commit_id":"167487ebf7e50e13779fb344038b2002056e9b81","original_commit_id":"167487ebf7e50e13779fb344038b2002056e9b81","user":{"login":"alextp","id":5061,"node_id":"MDQ6VXNlcjUwNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5061?v=4","gravatar_id":"","url":"https://api.github.com/users/alextp","html_url":"https://github.com/alextp","followers_url":"https://api.github.com/users/alextp/followers","following_url":"https://api.github.com/users/alextp/following{/other_user}","gists_url":"https://api.github.com/users/alextp/gists{/gist_id}","starred_url":"https://api.github.com/users/alextp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alextp/subscriptions","organizations_url":"https://api.github.com/users/alextp/orgs","repos_url":"https://api.github.com/users/alextp/repos","events_url":"https://api.github.com/users/alextp/events{/privacy}","received_events_url":"https://api.github.com/users/alextp/received_events","type":"User","site_admin":false},"body":"Why is this necessary?","created_at":"2018-08-13T16:29:04Z","updated_at":"2018-08-13T16:35:48Z","html_url":"https://github.com/tensorflow/tensorflow/pull/21486#discussion_r209675014","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21486","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/209675014"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/21486#discussion_r209675014"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21486"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21486","id":207111539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTExNTM5","html_url":"https://github.com/tensorflow/tensorflow/pull/21486","diff_url":"https://github.com/tensorflow/tensorflow/pull/21486.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/21486.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21486","number":21486,"state":"open","locked":false,"title":"elastic averaging SGD update: support partitioner & more optimizers","user":{"login":"weidankong","id":42156564,"node_id":"MDQ6VXNlcjQyMTU2NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/42156564?v=4","gravatar_id":"","url":"https://api.github.com/users/weidankong","html_url":"https://github.com/weidankong","followers_url":"https://api.github.com/users/weidankong/followers","following_url":"https://api.github.com/users/weidankong/following{/other_user}","gists_url":"https://api.github.com/users/weidankong/gists{/gist_id}","starred_url":"https://api.github.com/users/weidankong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weidankong/subscriptions","organizations_url":"https://api.github.com/users/weidankong/orgs","repos_url":"https://api.github.com/users/weidankong/repos","events_url":"https://api.github.com/users/weidankong/events{/privacy}","received_events_url":"https://api.github.com/users/weidankong/received_events","type":"User","site_admin":false},"body":"The old implementation of elastic average optimizer does not partitioned variables, support optimizer like AdamOptimizer which will create global variables like beta_1, beta2.\r\n\r\nMain changes:\r\n1. supports partitioned variables\r\n2. support more optimizers, e.g., Adam/RMSProp\r\n3. add a saver to save the values in the global_center_variable\r\n    As it turns out the global model is better than the local worker. To allow chief worker save the global values, a mapping logic is added.\r\n\r\nVerifications I have done:  Cifar10 on AlexNet/MobileNetV2 and other internal models.\r\nAll Results shows better performance and precision.\r\n\r\nRelated Item\r\n#12472: Feature request: EASGD\r\n@ali01, @jinxin0924, @tmulc18 Could you kindly help on review the changes?\r\n","created_at":"2018-08-08T19:23:13Z","updated_at":"2018-08-13T16:35:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"832d1856b1bc353b00f94d99c63a911bfa0df58b","assignee":{"login":"drpngx","id":20959853,"node_id":"MDQ6VXNlcjIwOTU5ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20959853?v=4","gravatar_id":"","url":"https://api.github.com/users/drpngx","html_url":"https://github.com/drpngx","followers_url":"https://api.github.com/users/drpngx/followers","following_url":"https://api.github.com/users/drpngx/following{/other_user}","gists_url":"https://api.github.com/users/drpngx/gists{/gist_id}","starred_url":"https://api.github.com/users/drpngx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpngx/subscriptions","organizations_url":"https://api.github.com/users/drpngx/orgs","repos_url":"https://api.github.com/users/drpngx/repos","events_url":"https://api.github.com/users/drpngx/events{/privacy}","received_events_url":"https://api.github.com/users/drpngx/received_events","type":"User","site_admin":false},"assignees":[{"login":"drpngx","id":20959853,"node_id":"MDQ6VXNlcjIwOTU5ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20959853?v=4","gravatar_id":"","url":"https://api.github.com/users/drpngx","html_url":"https://github.com/drpngx","followers_url":"https://api.github.com/users/drpngx/followers","following_url":"https://api.github.com/users/drpngx/following{/other_user}","gists_url":"https://api.github.com/users/drpngx/gists{/gist_id}","starred_url":"https://api.github.com/users/drpngx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpngx/subscriptions","organizations_url":"https://api.github.com/users/drpngx/orgs","repos_url":"https://api.github.com/users/drpngx/repos","events_url":"https://api.github.com/users/drpngx/events{/privacy}","received_events_url":"https://api.github.com/users/drpngx/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":390482148,"node_id":"MDU6TGFiZWwzOTA0ODIxNDg=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review","name":"awaiting review","color":"fef2c0","default":false},{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21486/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21486/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21486/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/167487ebf7e50e13779fb344038b2002056e9b81","head":{"label":"weidankong:elastic_average","ref":"elastic_average","sha":"167487ebf7e50e13779fb344038b2002056e9b81","user":{"login":"weidankong","id":42156564,"node_id":"MDQ6VXNlcjQyMTU2NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/42156564?v=4","gravatar_id":"","url":"https://api.github.com/users/weidankong","html_url":"https://github.com/weidankong","followers_url":"https://api.github.com/users/weidankong/followers","following_url":"https://api.github.com/users/weidankong/following{/other_user}","gists_url":"https://api.github.com/users/weidankong/gists{/gist_id}","starred_url":"https://api.github.com/users/weidankong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weidankong/subscriptions","organizations_url":"https://api.github.com/users/weidankong/orgs","repos_url":"https://api.github.com/users/weidankong/repos","events_url":"https://api.github.com/users/weidankong/events{/privacy}","received_events_url":"https://api.github.com/users/weidankong/received_events","type":"User","site_admin":false},"repo":{"id":143921733,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MjE3MzM=","name":"tensorflow","full_name":"weidankong/tensorflow","owner":{"login":"weidankong","id":42156564,"node_id":"MDQ6VXNlcjQyMTU2NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/42156564?v=4","gravatar_id":"","url":"https://api.github.com/users/weidankong","html_url":"https://github.com/weidankong","followers_url":"https://api.github.com/users/weidankong/followers","following_url":"https://api.github.com/users/weidankong/following{/other_user}","gists_url":"https://api.github.com/users/weidankong/gists{/gist_id}","starred_url":"https://api.github.com/users/weidankong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weidankong/subscriptions","organizations_url":"https://api.github.com/users/weidankong/orgs","repos_url":"https://api.github.com/users/weidankong/repos","events_url":"https://api.github.com/users/weidankong/events{/privacy}","received_events_url":"https://api.github.com/users/weidankong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weidankong/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/weidankong/tensorflow","forks_url":"https://api.github.com/repos/weidankong/tensorflow/forks","keys_url":"https://api.github.com/repos/weidankong/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weidankong/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weidankong/tensorflow/teams","hooks_url":"https://api.github.com/repos/weidankong/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/weidankong/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/weidankong/tensorflow/events","assignees_url":"https://api.github.com/repos/weidankong/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/weidankong/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/weidankong/tensorflow/tags","blobs_url":"https://api.github.com/repos/weidankong/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weidankong/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weidankong/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/weidankong/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weidankong/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/weidankong/tensorflow/languages","stargazers_url":"https://api.github.com/repos/weidankong/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/weidankong/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/weidankong/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/weidankong/tensorflow/subscription","commits_url":"https://api.github.com/repos/weidankong/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/weidankong/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/weidankong/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/weidankong/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/weidankong/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/weidankong/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weidankong/tensorflow/merges","archive_url":"https://api.github.com/repos/weidankong/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weidankong/tensorflow/downloads","issues_url":"https://api.github.com/repos/weidankong/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/weidankong/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/weidankong/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/weidankong/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weidankong/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/weidankong/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/weidankong/tensorflow/deployments","created_at":"2018-08-07T20:07:54Z","updated_at":"2018-08-07T20:08:37Z","pushed_at":"2018-08-08T18:56:48Z","git_url":"git://github.com/weidankong/tensorflow.git","ssh_url":"git@github.com:weidankong/tensorflow.git","clone_url":"https://github.com/weidankong/tensorflow.git","svn_url":"https://github.com/weidankong/tensorflow","homepage":"https://tensorflow.org","size":187653,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"85fb2bf56873638bb65d9cad75d59a0a16087fe3","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcxNzI1MA==","name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2018-08-13T16:32:04Z","pushed_at":"2018-08-13T16:29:50Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":189914,"stargazers_count":107315,"watchers_count":107315,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66413,"mirror_url":null,"archived":false,"open_issues_count":1797,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":66413,"open_issues":1797,"watchers":107315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21486"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/21486"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/21486"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/21486/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21486/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21486/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/167487ebf7e50e13779fb344038b2002056e9b81"}},"author_association":"NONE"}}
{"actor":{"display_login":"alextp"}}