{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/ditto/issues/84","repository_url":"https://api.github.com/repos/NREL/ditto","labels_url":"https://api.github.com/repos/NREL/ditto/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/NREL/ditto/issues/84/comments","events_url":"https://api.github.com/repos/NREL/ditto/issues/84/events","html_url":"https://github.com/NREL/ditto/issues/84","id":323370087,"node_id":"MDU6SXNzdWUzMjMzNzAwODc=","number":84,"title":"Units in models and parsers","user":{"login":"NicolasGensollen","id":2639645,"node_id":"MDQ6VXNlcjI2Mzk2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2639645?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasGensollen","html_url":"https://github.com/NicolasGensollen","followers_url":"https://api.github.com/users/NicolasGensollen/followers","following_url":"https://api.github.com/users/NicolasGensollen/following{/other_user}","gists_url":"https://api.github.com/users/NicolasGensollen/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasGensollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasGensollen/subscriptions","organizations_url":"https://api.github.com/users/NicolasGensollen/orgs","repos_url":"https://api.github.com/users/NicolasGensollen/repos","events_url":"https://api.github.com/users/NicolasGensollen/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasGensollen/received_events","type":"User","site_admin":false},"labels":[{"id":957871791,"node_id":"MDU6TGFiZWw5NTc4NzE3OTE=","url":"https://api.github.com/repos/NREL/ditto/labels/Beta","name":"Beta","color":"c11330","default":false},{"id":966856733,"node_id":"MDU6TGFiZWw5NjY4NTY3MzM=","url":"https://api.github.com/repos/NREL/ditto/labels/Medium%20Priority","name":"Medium Priority","color":"c5d655","default":false},{"id":919409374,"node_id":"MDU6TGFiZWw5MTk0MDkzNzQ=","url":"https://api.github.com/repos/NREL/ditto/labels/discussion","name":"discussion","color":"babaf4","default":false},{"id":836449884,"node_id":"MDU6TGFiZWw4MzY0NDk4ODQ=","url":"https://api.github.com/repos/NREL/ditto/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/ditto/milestones/1","html_url":"https://github.com/NREL/ditto/milestone/1","labels_url":"https://api.github.com/repos/NREL/ditto/milestones/1/labels","id":3408358,"node_id":"MDk6TWlsZXN0b25lMzQwODM1OA==","number":1,"title":"Beta release","description":"Beta release for DiTTo. \r\nTentative date is end of the SMART-DS project.","creator":{"login":"NicolasGensollen","id":2639645,"node_id":"MDQ6VXNlcjI2Mzk2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2639645?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasGensollen","html_url":"https://github.com/NicolasGensollen","followers_url":"https://api.github.com/users/NicolasGensollen/followers","following_url":"https://api.github.com/users/NicolasGensollen/following{/other_user}","gists_url":"https://api.github.com/users/NicolasGensollen/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasGensollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasGensollen/subscriptions","organizations_url":"https://api.github.com/users/NicolasGensollen/orgs","repos_url":"https://api.github.com/users/NicolasGensollen/repos","events_url":"https://api.github.com/users/NicolasGensollen/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasGensollen/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":4,"state":"open","created_at":"2018-06-07T16:21:06Z","updated_at":"2018-07-24T15:22:40Z","due_on":"2018-08-31T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-05-15T20:25:46Z","updated_at":"2018-08-07T16:42:19Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"A few unit related problems I noticed:\r\n\r\n- Unit conversions are currently managed in the parsers (most of the time hardcoded when setting the attribute value), which is hard to maintain.\r\n\r\nEx:\r\n```python\r\n#From cyme reader\r\napi_winding.nominal_voltage=float(settings['primarybasevoltage'])*10**3 #DiTTo in volt\r\n```\r\n\r\n- Attribute units are not clear when looking at the DiTTo model. Sometimes there is some indication in the help but not always. In addition some names are misleading in terms of the unit assumed by DiTTo. \r\n\r\nEx:\r\n```python\r\n#In KVA or VA???\r\nnormhkva = Float(help='Normal maximum kVA rating for H winding', default_value=None)\r\n```\r\nThese are already introducing some bugs in the conversions and it will probably get worse as we add more parsers...\r\n\r\nHaving a more robust framework to handle units (like [Pint](https://pint.readthedocs.io/en/latest/) maybe??) would be a nice addition in my opinion. Thoughts?\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/ditto/issues/comments/411122929","html_url":"https://github.com/NREL/ditto/issues/84#issuecomment-411122929","issue_url":"https://api.github.com/repos/NREL/ditto/issues/84","id":411122929,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTEyMjkyOQ==","user":{"login":"kdheepak","id":1813121,"node_id":"MDQ6VXNlcjE4MTMxMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1813121?v=4","gravatar_id":"","url":"https://api.github.com/users/kdheepak","html_url":"https://github.com/kdheepak","followers_url":"https://api.github.com/users/kdheepak/followers","following_url":"https://api.github.com/users/kdheepak/following{/other_user}","gists_url":"https://api.github.com/users/kdheepak/gists{/gist_id}","starred_url":"https://api.github.com/users/kdheepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdheepak/subscriptions","organizations_url":"https://api.github.com/users/kdheepak/orgs","repos_url":"https://api.github.com/users/kdheepak/repos","events_url":"https://api.github.com/users/kdheepak/events{/privacy}","received_events_url":"https://api.github.com/users/kdheepak/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T16:42:19Z","updated_at":"2018-08-07T16:42:19Z","author_association":"MEMBER","body":"It might work well. Why do we need `unit_type`?"}}
{"actor":{"display_login":"kdheepak"}}