{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/199984047","pull_request_review_id":134209226,"id":199984047,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk4NDA0Nw==","diff_hunk":"@@ -247,8 +247,8 @@ def pull(self, key, out=None, priority=0):\n \n         The returned values are guaranteed to be the latest values in the store.\n \n-        For `RowSparseNDArray` values, this call is ignored,\n-        please use ``row_sparse_pull`` instead.\n+        pull with `RowSparseNDArray` is not supported for dist kvstore.\n+        Please use ``row_sparse_pull`` instead.","path":"python/mxnet/kvstore.py","position":16,"original_position":16,"commit_id":"a2b1cc9d431d90966c324dce427cdea9dc018a4e","original_commit_id":"a2b1cc9d431d90966c324dce427cdea9dc018a4e","user":{"login":"eric-haibin-lin","id":5545640,"node_id":"MDQ6VXNlcjU1NDU2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5545640?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-haibin-lin","html_url":"https://github.com/eric-haibin-lin","followers_url":"https://api.github.com/users/eric-haibin-lin/followers","following_url":"https://api.github.com/users/eric-haibin-lin/following{/other_user}","gists_url":"https://api.github.com/users/eric-haibin-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-haibin-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-haibin-lin/subscriptions","organizations_url":"https://api.github.com/users/eric-haibin-lin/orgs","repos_url":"https://api.github.com/users/eric-haibin-lin/repos","events_url":"https://api.github.com/users/eric-haibin-lin/events{/privacy}","received_events_url":"https://api.github.com/users/eric-haibin-lin/received_events","type":"User","site_admin":false},"body":"Previous behavior is to always ignore sparse. So it's consistent","created_at":"2018-07-04T00:41:50Z","updated_at":"2018-07-04T00:41:51Z","html_url":"https://github.com/apache/incubator-mxnet/pull/11429#discussion_r199984047","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11429","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/199984047"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/11429#discussion_r199984047"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11429"}},"in_reply_to_id":199961435},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11429","id":197849131,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODQ5MTMx","html_url":"https://github.com/apache/incubator-mxnet/pull/11429","diff_url":"https://github.com/apache/incubator-mxnet/pull/11429.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/11429.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11429","number":11429,"state":"open","locked":false,"title":"Improve sparse pull performance for gluon trainer","user":{"login":"eric-haibin-lin","id":5545640,"node_id":"MDQ6VXNlcjU1NDU2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5545640?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-haibin-lin","html_url":"https://github.com/eric-haibin-lin","followers_url":"https://api.github.com/users/eric-haibin-lin/followers","following_url":"https://api.github.com/users/eric-haibin-lin/following{/other_user}","gists_url":"https://api.github.com/users/eric-haibin-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-haibin-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-haibin-lin/subscriptions","organizations_url":"https://api.github.com/users/eric-haibin-lin/orgs","repos_url":"https://api.github.com/users/eric-haibin-lin/repos","events_url":"https://api.github.com/users/eric-haibin-lin/events{/privacy}","received_events_url":"https://api.github.com/users/eric-haibin-lin/received_events","type":"User","site_admin":false},"body":"## Description ##\r\n- introduce gpu priority queue for row sparse pull operations\r\n- add ignore_sparse option to kv.pull, which improves hybrid blocks with dense weight and sparse gradient\r\n\r\n@leezu @rahul003 \r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)\r\n- [ ] Changes are complete (i.e. I finished coding on this PR)\r\n- [ ] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [ ] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [ ] Feature1, tests, (and when applicable, API doc)\r\n- [ ] Feature2, tests, (and when applicable, API doc)\r\n\r\n## Comments ##\r\n- If this change is a backward incompatible change, why must this change be made.\r\n- Interesting edge cases to note here\r\n","created_at":"2018-06-27T20:48:07Z","updated_at":"2018-07-04T00:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d3ef0584ee14d1940d56d5cb81d43bef8bbc1af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11429/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11429/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11429/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/a2b1cc9d431d90966c324dce427cdea9dc018a4e","head":{"label":"eric-haibin-lin:sparse-fix","ref":"sparse-fix","sha":"a2b1cc9d431d90966c324dce427cdea9dc018a4e","user":{"login":"eric-haibin-lin","id":5545640,"node_id":"MDQ6VXNlcjU1NDU2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5545640?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-haibin-lin","html_url":"https://github.com/eric-haibin-lin","followers_url":"https://api.github.com/users/eric-haibin-lin/followers","following_url":"https://api.github.com/users/eric-haibin-lin/following{/other_user}","gists_url":"https://api.github.com/users/eric-haibin-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-haibin-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-haibin-lin/subscriptions","organizations_url":"https://api.github.com/users/eric-haibin-lin/orgs","repos_url":"https://api.github.com/users/eric-haibin-lin/repos","events_url":"https://api.github.com/users/eric-haibin-lin/events{/privacy}","received_events_url":"https://api.github.com/users/eric-haibin-lin/received_events","type":"User","site_admin":false},"repo":{"id":54802325,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgwMjMyNQ==","name":"mxnet","full_name":"eric-haibin-lin/mxnet","owner":{"login":"eric-haibin-lin","id":5545640,"node_id":"MDQ6VXNlcjU1NDU2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5545640?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-haibin-lin","html_url":"https://github.com/eric-haibin-lin","followers_url":"https://api.github.com/users/eric-haibin-lin/followers","following_url":"https://api.github.com/users/eric-haibin-lin/following{/other_user}","gists_url":"https://api.github.com/users/eric-haibin-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-haibin-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-haibin-lin/subscriptions","organizations_url":"https://api.github.com/users/eric-haibin-lin/orgs","repos_url":"https://api.github.com/users/eric-haibin-lin/repos","events_url":"https://api.github.com/users/eric-haibin-lin/events{/privacy}","received_events_url":"https://api.github.com/users/eric-haibin-lin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eric-haibin-lin/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/eric-haibin-lin/mxnet","forks_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/forks","keys_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/teams","hooks_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/hooks","issue_events_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/events","assignees_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/tags","blobs_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/languages","stargazers_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/stargazers","contributors_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/contributors","subscribers_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/subscribers","subscription_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/subscription","commits_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/merges","archive_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/downloads","issues_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/eric-haibin-lin/mxnet/deployments","created_at":"2016-03-26T22:27:07Z","updated_at":"2018-02-28T12:42:24Z","pushed_at":"2018-07-02T21:04:07Z","git_url":"git://github.com/eric-haibin-lin/mxnet.git","ssh_url":"git@github.com:eric-haibin-lin/mxnet.git","clone_url":"https://github.com/eric-haibin-lin/mxnet.git","svn_url":"https://github.com/eric-haibin-lin/mxnet","homepage":"http://mxnet.rtfd.org","size":74234,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a7d858db95dbb6f595d22a2cab87644bb81f5f12","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2NDQwMg==","name":"incubator-mxnet","full_name":"apache/incubator-mxnet","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-07-03T21:54:43Z","pushed_at":"2018-07-04T00:36:21Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"https://mxnet.apache.org","size":38654,"stargazers_count":14327,"watchers_count":14327,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5295,"mirror_url":null,"archived":false,"open_issues_count":966,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5295,"open_issues":966,"watchers":14327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11429"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/11429"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/11429"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/11429/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11429/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11429/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/a2b1cc9d431d90966c324dce427cdea9dc018a4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eric-haibin-lin"}}