{"action":"created","issue":{"url":"https://api.github.com/repos/wix/yoshi/issues/487","repository_url":"https://api.github.com/repos/wix/yoshi","labels_url":"https://api.github.com/repos/wix/yoshi/issues/487/labels{/name}","comments_url":"https://api.github.com/repos/wix/yoshi/issues/487/comments","events_url":"https://api.github.com/repos/wix/yoshi/issues/487/events","html_url":"https://github.com/wix/yoshi/issues/487","id":349063835,"node_id":"MDU6SXNzdWUzNDkwNjM4MzU=","number":487,"title":"JSON imports break wallaby, but builds ok","user":{"login":"yurynix","id":326402,"node_id":"MDQ6VXNlcjMyNjQwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/326402?v=4","gravatar_id":"","url":"https://api.github.com/users/yurynix","html_url":"https://github.com/yurynix","followers_url":"https://api.github.com/users/yurynix/followers","following_url":"https://api.github.com/users/yurynix/following{/other_user}","gists_url":"https://api.github.com/users/yurynix/gists{/gist_id}","starred_url":"https://api.github.com/users/yurynix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurynix/subscriptions","organizations_url":"https://api.github.com/users/yurynix/orgs","repos_url":"https://api.github.com/users/yurynix/repos","events_url":"https://api.github.com/users/yurynix/events{/privacy}","received_events_url":"https://api.github.com/users/yurynix/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-09T10:11:31Z","updated_at":"2018-08-13T07:48:00Z","closed_at":"2018-08-12T07:51:18Z","author_association":"CONTRIBUTOR","body":"# 🐛 Bug Report\r\n\r\n### 😯 Current Behavior\r\n\r\nWallaby breaks when `.json` file is imported:\r\n\r\n```es6\r\nimport mocks from '../../../test/mocks.json';\r\n```\r\n\r\n<img width=\"633\" alt=\"screen shot 2018-08-09 at 13 02 07\" src=\"https://user-images.githubusercontent.com/326402/43892763-8d246894-9bd5-11e8-99b5-d99c2405ad0a.png\">\r\n\r\n### 🤔 Expected Behavior\r\n\r\nI expected wallaby to keep working, especially since the normal build runs ok\r\n\r\n### 💁 Possible Solution <!-- optional -->\r\n\r\nto fix, in wallaby_common.js, we need to add proper loader for babel:\r\n<img width=\"650\" alt=\"screen shot 2018-08-09 at 13 10 31\" src=\"https://user-images.githubusercontent.com/326402/43892803-a3c9d14c-9bd5-11e8-967d-8d619ac86a7e.png\">\r\n\r\n\r\n### 👣 Steps to Reproduce <!-- optional -->\r\n\r\n1. Create a spec file where wallaby runs fine\r\n2. Import some `.json` file\r\n3. Wally will no longer run and display in it's output:\r\n<img width=\"633\" alt=\"screen shot 2018-08-09 at 13 02 07\" src=\"https://user-images.githubusercontent.com/326402/43892763-8d246894-9bd5-11e8-99b5-d99c2405ad0a.png\">\r\n\r\n### 🌍 Your Environment\r\n```\r\n  System:\r\n    OS: macOS High Sierra 10.13.6\r\n    CPU: x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz\r\n  Binaries:\r\n    Node: 10.7.0 - ~/.nvm/versions/node/v10.7.0/bin/node\r\n    Yarn: 1.9.4 - ~/.nvm/versions/node/v10.7.0/bin/yarn\r\n    npm: 6.1.0 - ~/.nvm/versions/node/v10.7.0/bin/npm\r\n  Browsers:\r\n    Chrome: 68.0.3440.106\r\n    Firefox: 61.0.1\r\n    Safari: 11.1.2\r\n  npmPackages:\r\n    yoshi: ^3.0.0 => 3.4.3 \r\n\r\n Yoshi config\r\n{\r\n  \"externals\": {\r\n    \"react\": \"React\",\r\n    \"react-dom\": \"ReactDOM\"\r\n  },\r\n  \"hmr\": \"auto\"\r\n}\r\n\r\n```\r\n\r\n```\r\n  \"yoshi\": {\r\n    \"externals\": {\r\n      \"react\": \"React\",\r\n      \"react-dom\": \"ReactDOM\"\r\n    },\r\n    \"hmr\": \"auto\"\r\n  },\r\n```"},"comment":{"url":"https://api.github.com/repos/wix/yoshi/issues/comments/412435511","html_url":"https://github.com/wix/yoshi/issues/487#issuecomment-412435511","issue_url":"https://api.github.com/repos/wix/yoshi/issues/487","id":412435511,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQzNTUxMQ==","user":{"login":"ranyitz","id":11733036,"node_id":"MDQ6VXNlcjExNzMzMDM2","avatar_url":"https://avatars2.githubusercontent.com/u/11733036?v=4","gravatar_id":"","url":"https://api.github.com/users/ranyitz","html_url":"https://github.com/ranyitz","followers_url":"https://api.github.com/users/ranyitz/followers","following_url":"https://api.github.com/users/ranyitz/following{/other_user}","gists_url":"https://api.github.com/users/ranyitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ranyitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranyitz/subscriptions","organizations_url":"https://api.github.com/users/ranyitz/orgs","repos_url":"https://api.github.com/users/ranyitz/repos","events_url":"https://api.github.com/users/ranyitz/events{/privacy}","received_events_url":"https://api.github.com/users/ranyitz/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T07:48:00Z","updated_at":"2018-08-13T07:48:00Z","author_association":"COLLABORATOR","body":"@yurynix yes, and that's probably because it's not in these glob patterns:\r\n\r\nhttps://github.com/wix/yoshi/blob/e0ffc5ac873435966f60c6fee71e10e7ab5880a7/packages/yoshi/config/wallaby-common.js#L43-L60\r\n\r\nYou can move this file to be inside of `src` directory.\r\n\r\nWe can also add `json` files inside of `test` directory, but no one requested it until now.\r\n\r\nIs it something you think everybody uses?"}}
{"actor":{"display_login":"ranyitz"}}