{"action":"created","comment":{"url":"https://api.github.com/repos/containous/traefik/pulls/comments/206693604","pull_request_review_id":142158111,"id":206693604,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjY5MzYwNA==","diff_hunk":"@@ -40,3 +38,20 @@ func (e *entryPointMiddleware) ServeHTTP(w http.ResponseWriter, r *http.Request,\n \tLogResponseCode(span, recorder.Status())\n \tspan.Finish()\n }\n+\n+// generateEntryPointSpanName will return a Span name of an appropriate lenth based on the 'spanLimit' argument.  If needed, it will be truncated, but will not be less than 24 characters","path":"middlewares/tracing/entrypoint.go","position":20,"original_position":20,"commit_id":"195dc7218a1702f75e705f2cc4767022ec52d8a2","original_commit_id":"ed7a12b0ed25a8b2d3a55109dda9f752a8d38f4f","user":{"login":"timoreimann","id":694826,"node_id":"MDQ6VXNlcjY5NDgyNg==","avatar_url":"https://avatars1.githubusercontent.com/u/694826?v=4","gravatar_id":"","url":"https://api.github.com/users/timoreimann","html_url":"https://github.com/timoreimann","followers_url":"https://api.github.com/users/timoreimann/followers","following_url":"https://api.github.com/users/timoreimann/following{/other_user}","gists_url":"https://api.github.com/users/timoreimann/gists{/gist_id}","starred_url":"https://api.github.com/users/timoreimann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoreimann/subscriptions","organizations_url":"https://api.github.com/users/timoreimann/orgs","repos_url":"https://api.github.com/users/timoreimann/repos","events_url":"https://api.github.com/users/timoreimann/events{/privacy}","received_events_url":"https://api.github.com/users/timoreimann/received_events","type":"User","site_admin":false},"body":"Trailing punctuation missing.","created_at":"2018-07-31T21:44:13Z","updated_at":"2018-07-31T21:47:28Z","html_url":"https://github.com/containous/traefik/pull/3689#discussion_r206693604","pull_request_url":"https://api.github.com/repos/containous/traefik/pulls/3689","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/containous/traefik/pulls/comments/206693604"},"html":{"href":"https://github.com/containous/traefik/pull/3689#discussion_r206693604"},"pull_request":{"href":"https://api.github.com/repos/containous/traefik/pulls/3689"}}},"pull_request":{"url":"https://api.github.com/repos/containous/traefik/pulls/3689","id":204505767,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTA1NzY3","html_url":"https://github.com/containous/traefik/pull/3689","diff_url":"https://github.com/containous/traefik/pull/3689.diff","patch_url":"https://github.com/containous/traefik/pull/3689.patch","issue_url":"https://api.github.com/repos/containous/traefik/issues/3689","number":3689,"state":"open","locked":false,"title":"Added support for Trace name truncation for traces","user":{"login":"aantono","id":22290,"node_id":"MDQ6VXNlcjIyMjkw","avatar_url":"https://avatars0.githubusercontent.com/u/22290?v=4","gravatar_id":"","url":"https://api.github.com/users/aantono","html_url":"https://github.com/aantono","followers_url":"https://api.github.com/users/aantono/followers","following_url":"https://api.github.com/users/aantono/following{/other_user}","gists_url":"https://api.github.com/users/aantono/gists{/gist_id}","starred_url":"https://api.github.com/users/aantono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aantono/subscriptions","organizations_url":"https://api.github.com/users/aantono/orgs","repos_url":"https://api.github.com/users/aantono/repos","events_url":"https://api.github.com/users/aantono/events{/privacy}","received_events_url":"https://api.github.com/users/aantono/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nIn many situations the trace name gets pretty large (over 100 chars, especially when using k8s provider).  This provides an option to truncate the name to a configurable length to avoid dropped traces.\r\n\r\n### More\r\n\r\n- [x] Added/updated tests\r\n- [x] Added/updated documentation\r\n","created_at":"2018-07-27T18:23:53Z","updated_at":"2018-07-31T21:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27587eb854915f176b6faea622a1c6d847a72cd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":806886349,"node_id":"MDU6TGFiZWw4MDY4ODYzNDk=","url":"https://api.github.com/repos/containous/traefik/labels/area/middleware/tracing","name":"area/middleware/tracing","color":"bfdadc","default":false},{"id":265969105,"node_id":"MDU6TGFiZWwyNjU5NjkxMDU=","url":"https://api.github.com/repos/containous/traefik/labels/contributor/waiting-for-corrections","name":"contributor/waiting-for-corrections","color":"0052cc","default":false},{"id":591452819,"node_id":"MDU6TGFiZWw1OTE0NTI4MTk=","url":"https://api.github.com/repos/containous/traefik/labels/kind/bug/fix","name":"kind/bug/fix","color":"ee0701","default":false},{"id":602267810,"node_id":"MDU6TGFiZWw2MDIyNjc4MTA=","url":"https://api.github.com/repos/containous/traefik/labels/size/L","name":"size/L","color":"d93f0b","default":false},{"id":265100665,"node_id":"MDU6TGFiZWwyNjUxMDA2NjU=","url":"https://api.github.com/repos/containous/traefik/labels/status/2-needs-review","name":"status/2-needs-review","color":"FADECF","default":false}],"milestone":{"url":"https://api.github.com/repos/containous/traefik/milestones/9","html_url":"https://github.com/containous/traefik/milestone/9","labels_url":"https://api.github.com/repos/containous/traefik/milestones/9/labels","id":3212132,"node_id":"MDk6TWlsZXN0b25lMzIxMjEzMg==","number":9,"title":"1.7","description":"","creator":{"login":"ldez","id":5674651,"node_id":"MDQ6VXNlcjU2NzQ2NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5674651?v=4","gravatar_id":"","url":"https://api.github.com/users/ldez","html_url":"https://github.com/ldez","followers_url":"https://api.github.com/users/ldez/followers","following_url":"https://api.github.com/users/ldez/following{/other_user}","gists_url":"https://api.github.com/users/ldez/gists{/gist_id}","starred_url":"https://api.github.com/users/ldez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldez/subscriptions","organizations_url":"https://api.github.com/users/ldez/orgs","repos_url":"https://api.github.com/users/ldez/repos","events_url":"https://api.github.com/users/ldez/events{/privacy}","received_events_url":"https://api.github.com/users/ldez/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":172,"state":"open","created_at":"2018-03-23T12:54:13Z","updated_at":"2018-07-31T16:56:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/containous/traefik/pulls/3689/commits","review_comments_url":"https://api.github.com/repos/containous/traefik/pulls/3689/comments","review_comment_url":"https://api.github.com/repos/containous/traefik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containous/traefik/issues/3689/comments","statuses_url":"https://api.github.com/repos/containous/traefik/statuses/195dc7218a1702f75e705f2cc4767022ec52d8a2","head":{"label":"aantono:dd-apm","ref":"dd-apm","sha":"195dc7218a1702f75e705f2cc4767022ec52d8a2","user":{"login":"aantono","id":22290,"node_id":"MDQ6VXNlcjIyMjkw","avatar_url":"https://avatars0.githubusercontent.com/u/22290?v=4","gravatar_id":"","url":"https://api.github.com/users/aantono","html_url":"https://github.com/aantono","followers_url":"https://api.github.com/users/aantono/followers","following_url":"https://api.github.com/users/aantono/following{/other_user}","gists_url":"https://api.github.com/users/aantono/gists{/gist_id}","starred_url":"https://api.github.com/users/aantono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aantono/subscriptions","organizations_url":"https://api.github.com/users/aantono/orgs","repos_url":"https://api.github.com/users/aantono/repos","events_url":"https://api.github.com/users/aantono/events{/privacy}","received_events_url":"https://api.github.com/users/aantono/received_events","type":"User","site_admin":false},"repo":{"id":89506319,"node_id":"MDEwOlJlcG9zaXRvcnk4OTUwNjMxOQ==","name":"traefik","full_name":"aantono/traefik","owner":{"login":"aantono","id":22290,"node_id":"MDQ6VXNlcjIyMjkw","avatar_url":"https://avatars0.githubusercontent.com/u/22290?v=4","gravatar_id":"","url":"https://api.github.com/users/aantono","html_url":"https://github.com/aantono","followers_url":"https://api.github.com/users/aantono/followers","following_url":"https://api.github.com/users/aantono/following{/other_user}","gists_url":"https://api.github.com/users/aantono/gists{/gist_id}","starred_url":"https://api.github.com/users/aantono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aantono/subscriptions","organizations_url":"https://api.github.com/users/aantono/orgs","repos_url":"https://api.github.com/users/aantono/repos","events_url":"https://api.github.com/users/aantono/events{/privacy}","received_events_url":"https://api.github.com/users/aantono/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aantono/traefik","description":"Træfik, a modern reverse proxy","fork":true,"url":"https://api.github.com/repos/aantono/traefik","forks_url":"https://api.github.com/repos/aantono/traefik/forks","keys_url":"https://api.github.com/repos/aantono/traefik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aantono/traefik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aantono/traefik/teams","hooks_url":"https://api.github.com/repos/aantono/traefik/hooks","issue_events_url":"https://api.github.com/repos/aantono/traefik/issues/events{/number}","events_url":"https://api.github.com/repos/aantono/traefik/events","assignees_url":"https://api.github.com/repos/aantono/traefik/assignees{/user}","branches_url":"https://api.github.com/repos/aantono/traefik/branches{/branch}","tags_url":"https://api.github.com/repos/aantono/traefik/tags","blobs_url":"https://api.github.com/repos/aantono/traefik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aantono/traefik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aantono/traefik/git/refs{/sha}","trees_url":"https://api.github.com/repos/aantono/traefik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aantono/traefik/statuses/{sha}","languages_url":"https://api.github.com/repos/aantono/traefik/languages","stargazers_url":"https://api.github.com/repos/aantono/traefik/stargazers","contributors_url":"https://api.github.com/repos/aantono/traefik/contributors","subscribers_url":"https://api.github.com/repos/aantono/traefik/subscribers","subscription_url":"https://api.github.com/repos/aantono/traefik/subscription","commits_url":"https://api.github.com/repos/aantono/traefik/commits{/sha}","git_commits_url":"https://api.github.com/repos/aantono/traefik/git/commits{/sha}","comments_url":"https://api.github.com/repos/aantono/traefik/comments{/number}","issue_comment_url":"https://api.github.com/repos/aantono/traefik/issues/comments{/number}","contents_url":"https://api.github.com/repos/aantono/traefik/contents/{+path}","compare_url":"https://api.github.com/repos/aantono/traefik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aantono/traefik/merges","archive_url":"https://api.github.com/repos/aantono/traefik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aantono/traefik/downloads","issues_url":"https://api.github.com/repos/aantono/traefik/issues{/number}","pulls_url":"https://api.github.com/repos/aantono/traefik/pulls{/number}","milestones_url":"https://api.github.com/repos/aantono/traefik/milestones{/number}","notifications_url":"https://api.github.com/repos/aantono/traefik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aantono/traefik/labels{/name}","releases_url":"https://api.github.com/repos/aantono/traefik/releases{/id}","deployments_url":"https://api.github.com/repos/aantono/traefik/deployments","created_at":"2017-04-26T17:01:49Z","updated_at":"2018-07-20T17:11:12Z","pushed_at":"2018-07-31T21:44:18Z","git_url":"git://github.com/aantono/traefik.git","ssh_url":"git@github.com:aantono/traefik.git","clone_url":"https://github.com/aantono/traefik.git","svn_url":"https://github.com/aantono/traefik","homepage":"https://traefik.io/","size":30176,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containous:v1.7","ref":"v1.7","sha":"ed0c7d9c49604619e43edcbfa76957262694e949","user":{"login":"containous","id":16349663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzQ5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/16349663?v=4","gravatar_id":"","url":"https://api.github.com/users/containous","html_url":"https://github.com/containous","followers_url":"https://api.github.com/users/containous/followers","following_url":"https://api.github.com/users/containous/following{/other_user}","gists_url":"https://api.github.com/users/containous/gists{/gist_id}","starred_url":"https://api.github.com/users/containous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containous/subscriptions","organizations_url":"https://api.github.com/users/containous/orgs","repos_url":"https://api.github.com/users/containous/repos","events_url":"https://api.github.com/users/containous/events{/privacy}","received_events_url":"https://api.github.com/users/containous/received_events","type":"Organization","site_admin":false},"repo":{"id":42408804,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQwODgwNA==","name":"traefik","full_name":"containous/traefik","owner":{"login":"containous","id":16349663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzQ5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/16349663?v=4","gravatar_id":"","url":"https://api.github.com/users/containous","html_url":"https://github.com/containous","followers_url":"https://api.github.com/users/containous/followers","following_url":"https://api.github.com/users/containous/following{/other_user}","gists_url":"https://api.github.com/users/containous/gists{/gist_id}","starred_url":"https://api.github.com/users/containous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containous/subscriptions","organizations_url":"https://api.github.com/users/containous/orgs","repos_url":"https://api.github.com/users/containous/repos","events_url":"https://api.github.com/users/containous/events{/privacy}","received_events_url":"https://api.github.com/users/containous/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containous/traefik","description":"The Cloud Native Edge Router","fork":false,"url":"https://api.github.com/repos/containous/traefik","forks_url":"https://api.github.com/repos/containous/traefik/forks","keys_url":"https://api.github.com/repos/containous/traefik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containous/traefik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containous/traefik/teams","hooks_url":"https://api.github.com/repos/containous/traefik/hooks","issue_events_url":"https://api.github.com/repos/containous/traefik/issues/events{/number}","events_url":"https://api.github.com/repos/containous/traefik/events","assignees_url":"https://api.github.com/repos/containous/traefik/assignees{/user}","branches_url":"https://api.github.com/repos/containous/traefik/branches{/branch}","tags_url":"https://api.github.com/repos/containous/traefik/tags","blobs_url":"https://api.github.com/repos/containous/traefik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containous/traefik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containous/traefik/git/refs{/sha}","trees_url":"https://api.github.com/repos/containous/traefik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containous/traefik/statuses/{sha}","languages_url":"https://api.github.com/repos/containous/traefik/languages","stargazers_url":"https://api.github.com/repos/containous/traefik/stargazers","contributors_url":"https://api.github.com/repos/containous/traefik/contributors","subscribers_url":"https://api.github.com/repos/containous/traefik/subscribers","subscription_url":"https://api.github.com/repos/containous/traefik/subscription","commits_url":"https://api.github.com/repos/containous/traefik/commits{/sha}","git_commits_url":"https://api.github.com/repos/containous/traefik/git/commits{/sha}","comments_url":"https://api.github.com/repos/containous/traefik/comments{/number}","issue_comment_url":"https://api.github.com/repos/containous/traefik/issues/comments{/number}","contents_url":"https://api.github.com/repos/containous/traefik/contents/{+path}","compare_url":"https://api.github.com/repos/containous/traefik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containous/traefik/merges","archive_url":"https://api.github.com/repos/containous/traefik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containous/traefik/downloads","issues_url":"https://api.github.com/repos/containous/traefik/issues{/number}","pulls_url":"https://api.github.com/repos/containous/traefik/pulls{/number}","milestones_url":"https://api.github.com/repos/containous/traefik/milestones{/number}","notifications_url":"https://api.github.com/repos/containous/traefik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containous/traefik/labels{/name}","releases_url":"https://api.github.com/repos/containous/traefik/releases{/id}","deployments_url":"https://api.github.com/repos/containous/traefik/deployments","created_at":"2015-09-13T19:04:02Z","updated_at":"2018-07-31T21:44:30Z","pushed_at":"2018-07-31T21:44:20Z","git_url":"git://github.com/containous/traefik.git","ssh_url":"git@github.com:containous/traefik.git","clone_url":"https://github.com/containous/traefik.git","svn_url":"https://github.com/containous/traefik","homepage":"https://traefik.io","size":30593,"stargazers_count":16681,"watchers_count":16681,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1665,"mirror_url":null,"archived":false,"open_issues_count":273,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1665,"open_issues":273,"watchers":16681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containous/traefik/pulls/3689"},"html":{"href":"https://github.com/containous/traefik/pull/3689"},"issue":{"href":"https://api.github.com/repos/containous/traefik/issues/3689"},"comments":{"href":"https://api.github.com/repos/containous/traefik/issues/3689/comments"},"review_comments":{"href":"https://api.github.com/repos/containous/traefik/pulls/3689/comments"},"review_comment":{"href":"https://api.github.com/repos/containous/traefik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containous/traefik/pulls/3689/commits"},"statuses":{"href":"https://api.github.com/repos/containous/traefik/statuses/195dc7218a1702f75e705f2cc4767022ec52d8a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timoreimann"}}