{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/179850942","pull_request_review_id":110177753,"id":179850942,"diff_hunk":"@@ -40,36 +44,35 @@ define([\n      *\n      * @param {Object} [options] Object with the following properties:\n      * @param {Boolean} [options.show=true] Whether to display the particle system.\n-     * @param {ParticleSystem~applyForce[]} [options.forces] An array of force callbacks.","path":"Source/Scene/ParticleSystem.js","position":29,"original_position":29,"commit_id":"fc2c0e521d6921b8b405f7274b34db3947f14bd3","original_commit_id":"fc2c0e521d6921b8b405f7274b34db3947f14bd3","user":{"login":"ggetz","id":4439461,"avatar_url":"https://avatars3.githubusercontent.com/u/4439461?v=4","gravatar_id":"","url":"https://api.github.com/users/ggetz","html_url":"https://github.com/ggetz","followers_url":"https://api.github.com/users/ggetz/followers","following_url":"https://api.github.com/users/ggetz/following{/other_user}","gists_url":"https://api.github.com/users/ggetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ggetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggetz/subscriptions","organizations_url":"https://api.github.com/users/ggetz/orgs","repos_url":"https://api.github.com/users/ggetz/repos","events_url":"https://api.github.com/users/ggetz/events{/privacy}","received_events_url":"https://api.github.com/users/ggetz/received_events","type":"User","site_admin":false},"body":"Yes. When deprecating a function or property, we add the `@deprecated` tag, but I don't believe you can do that with a parameter, so state it explicitly. ","created_at":"2018-04-06T19:12:01Z","updated_at":"2018-04-06T19:12:01Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6429#discussion_r179850942","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6429","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/179850942"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6429#discussion_r179850942"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6429"}},"in_reply_to_id":179610983},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6429","id":179788754,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6429","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6429.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6429.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/6429","number":6429,"state":"open","locked":false,"title":"Particle system updates and name changes","user":{"login":"hanbollar","id":19377312,"avatar_url":"https://avatars1.githubusercontent.com/u/19377312?v=4","gravatar_id":"","url":"https://api.github.com/users/hanbollar","html_url":"https://github.com/hanbollar","followers_url":"https://api.github.com/users/hanbollar/followers","following_url":"https://api.github.com/users/hanbollar/following{/other_user}","gists_url":"https://api.github.com/users/hanbollar/gists{/gist_id}","starred_url":"https://api.github.com/users/hanbollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanbollar/subscriptions","organizations_url":"https://api.github.com/users/hanbollar/orgs","repos_url":"https://api.github.com/users/hanbollar/repos","events_url":"https://api.github.com/users/hanbollar/events{/privacy}","received_events_url":"https://api.github.com/users/hanbollar/received_events","type":"User","site_admin":false},"body":"includes renaming and adding in deprecations for specific variables and reconfigured methods such as forces is no longer an array, it's just one function callback, and was renamed to updateParticle (etc). \r\n\r\nCleaning up readability of ParticleSystem and Particle classes","created_at":"2018-04-05T20:33:23Z","updated_at":"2018-04-06T19:12:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa631359b31bbc069720ac800ae6814cc79c2014","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6429/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6429/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/6429/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/fc2c0e521d6921b8b405f7274b34db3947f14bd3","head":{"label":"hanbollar:particle-system-updates-and-deprecations","ref":"particle-system-updates-and-deprecations","sha":"fc2c0e521d6921b8b405f7274b34db3947f14bd3","user":{"login":"hanbollar","id":19377312,"avatar_url":"https://avatars1.githubusercontent.com/u/19377312?v=4","gravatar_id":"","url":"https://api.github.com/users/hanbollar","html_url":"https://github.com/hanbollar","followers_url":"https://api.github.com/users/hanbollar/followers","following_url":"https://api.github.com/users/hanbollar/following{/other_user}","gists_url":"https://api.github.com/users/hanbollar/gists{/gist_id}","starred_url":"https://api.github.com/users/hanbollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanbollar/subscriptions","organizations_url":"https://api.github.com/users/hanbollar/orgs","repos_url":"https://api.github.com/users/hanbollar/repos","events_url":"https://api.github.com/users/hanbollar/events{/privacy}","received_events_url":"https://api.github.com/users/hanbollar/received_events","type":"User","site_admin":false},"repo":{"id":116838218,"name":"cesium","full_name":"hanbollar/cesium","owner":{"login":"hanbollar","id":19377312,"avatar_url":"https://avatars1.githubusercontent.com/u/19377312?v=4","gravatar_id":"","url":"https://api.github.com/users/hanbollar","html_url":"https://github.com/hanbollar","followers_url":"https://api.github.com/users/hanbollar/followers","following_url":"https://api.github.com/users/hanbollar/following{/other_user}","gists_url":"https://api.github.com/users/hanbollar/gists{/gist_id}","starred_url":"https://api.github.com/users/hanbollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanbollar/subscriptions","organizations_url":"https://api.github.com/users/hanbollar/orgs","repos_url":"https://api.github.com/users/hanbollar/repos","events_url":"https://api.github.com/users/hanbollar/events{/privacy}","received_events_url":"https://api.github.com/users/hanbollar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hanbollar/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":true,"url":"https://api.github.com/repos/hanbollar/cesium","forks_url":"https://api.github.com/repos/hanbollar/cesium/forks","keys_url":"https://api.github.com/repos/hanbollar/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hanbollar/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hanbollar/cesium/teams","hooks_url":"https://api.github.com/repos/hanbollar/cesium/hooks","issue_events_url":"https://api.github.com/repos/hanbollar/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/hanbollar/cesium/events","assignees_url":"https://api.github.com/repos/hanbollar/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/hanbollar/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/hanbollar/cesium/tags","blobs_url":"https://api.github.com/repos/hanbollar/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hanbollar/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hanbollar/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/hanbollar/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hanbollar/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/hanbollar/cesium/languages","stargazers_url":"https://api.github.com/repos/hanbollar/cesium/stargazers","contributors_url":"https://api.github.com/repos/hanbollar/cesium/contributors","subscribers_url":"https://api.github.com/repos/hanbollar/cesium/subscribers","subscription_url":"https://api.github.com/repos/hanbollar/cesium/subscription","commits_url":"https://api.github.com/repos/hanbollar/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/hanbollar/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/hanbollar/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/hanbollar/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/hanbollar/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/hanbollar/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hanbollar/cesium/merges","archive_url":"https://api.github.com/repos/hanbollar/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hanbollar/cesium/downloads","issues_url":"https://api.github.com/repos/hanbollar/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/hanbollar/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/hanbollar/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/hanbollar/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hanbollar/cesium/labels{/name}","releases_url":"https://api.github.com/repos/hanbollar/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/hanbollar/cesium/deployments","created_at":"2018-01-09T16:04:28Z","updated_at":"2018-04-05T14:51:20Z","pushed_at":"2018-04-05T21:11:29Z","git_url":"git://github.com/hanbollar/cesium.git","ssh_url":"git@github.com:hanbollar/cesium.git","clone_url":"https://github.com/hanbollar/cesium.git","svn_url":"https://github.com/hanbollar/cesium","homepage":"http://cesiumjs.org/","size":284338,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"92596933d73a56def0ce690ac26f772562574df9","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars0.githubusercontent.com/u/1490220?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars0.githubusercontent.com/u/1490220?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2018-04-06T18:23:20Z","pushed_at":"2018-04-06T17:39:27Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"http://cesiumjs.org/","size":292527,"stargazers_count":2991,"watchers_count":2991,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1332,"mirror_url":null,"archived":false,"open_issues_count":720,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1332,"open_issues":720,"watchers":2991,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6429"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/6429"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/6429"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/6429/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6429/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/6429/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/fc2c0e521d6921b8b405f7274b34db3947f14bd3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ggetz"}}