{"action":"opened","number":24355,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24355","id":230705270,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzA1Mjcw","html_url":"https://github.com/nodejs/node/pull/24355","diff_url":"https://github.com/nodejs/node/pull/24355.diff","patch_url":"https://github.com/nodejs/node/pull/24355.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/24355","number":24355,"state":"open","locked":false,"title":"src: remove unused variables","user":{"login":"danbev","id":432351,"node_id":"MDQ6VXNlcjQzMjM1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"body":"Currently the following compiler warnings are generated:\r\n```console\r\n../src/node_process.cc:799:16:\r\nwarning: unused variable 'ary' [-Wunused-variable]\r\n  Local<Array> ary = Array::New(args.GetIsolate());\r\n               ^\r\n1 warning generated.\r\n```\r\n```console\r\n../src/node_http2.cc:1294:16:\r\nwarning: unused variable 'holder' [-Wunused-variable]\r\n  Local<Array> holder = Array::New(isolate);\r\n               ^\r\n1 warning generated.\r\n```\r\nThis commit removes these unused variables.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-11-14T04:18:45Z","updated_at":"2018-11-14T04:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/24355/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/24355/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24355/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/84a7ae21be5dbf363b4a0d7b41262fb4ab136293","head":{"label":"danbev:unused_vars","ref":"unused_vars","sha":"84a7ae21be5dbf363b4a0d7b41262fb4ab136293","user":{"login":"danbev","id":432351,"node_id":"MDQ6VXNlcjQzMjM1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"repo":{"id":60841866,"node_id":"MDEwOlJlcG9zaXRvcnk2MDg0MTg2Ng==","name":"node","full_name":"danbev/node","private":false,"owner":{"login":"danbev","id":432351,"node_id":"MDQ6VXNlcjQzMjM1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danbev/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/danbev/node","forks_url":"https://api.github.com/repos/danbev/node/forks","keys_url":"https://api.github.com/repos/danbev/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danbev/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danbev/node/teams","hooks_url":"https://api.github.com/repos/danbev/node/hooks","issue_events_url":"https://api.github.com/repos/danbev/node/issues/events{/number}","events_url":"https://api.github.com/repos/danbev/node/events","assignees_url":"https://api.github.com/repos/danbev/node/assignees{/user}","branches_url":"https://api.github.com/repos/danbev/node/branches{/branch}","tags_url":"https://api.github.com/repos/danbev/node/tags","blobs_url":"https://api.github.com/repos/danbev/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danbev/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danbev/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/danbev/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danbev/node/statuses/{sha}","languages_url":"https://api.github.com/repos/danbev/node/languages","stargazers_url":"https://api.github.com/repos/danbev/node/stargazers","contributors_url":"https://api.github.com/repos/danbev/node/contributors","subscribers_url":"https://api.github.com/repos/danbev/node/subscribers","subscription_url":"https://api.github.com/repos/danbev/node/subscription","commits_url":"https://api.github.com/repos/danbev/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/danbev/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/danbev/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/danbev/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/danbev/node/contents/{+path}","compare_url":"https://api.github.com/repos/danbev/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danbev/node/merges","archive_url":"https://api.github.com/repos/danbev/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danbev/node/downloads","issues_url":"https://api.github.com/repos/danbev/node/issues{/number}","pulls_url":"https://api.github.com/repos/danbev/node/pulls{/number}","milestones_url":"https://api.github.com/repos/danbev/node/milestones{/number}","notifications_url":"https://api.github.com/repos/danbev/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danbev/node/labels{/name}","releases_url":"https://api.github.com/repos/danbev/node/releases{/id}","deployments_url":"https://api.github.com/repos/danbev/node/deployments","created_at":"2016-06-10T11:03:24Z","updated_at":"2018-05-14T03:58:52Z","pushed_at":"2018-11-14T04:18:07Z","git_url":"git://github.com/danbev/node.git","ssh_url":"git@github.com:danbev/node.git","clone_url":"https://github.com/danbev/node.git","svn_url":"https://github.com/danbev/node","homepage":"https://nodejs.org","size":398364,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"98278584ee2c322655849e6d673ac1739e720b53","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-11-14T03:27:56Z","pushed_at":"2018-11-14T03:28:10Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":432171,"stargazers_count":55347,"watchers_count":55347,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12122,"mirror_url":null,"archived":false,"open_issues_count":853,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12122,"open_issues":853,"watchers":55347,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/24355"},"html":{"href":"https://github.com/nodejs/node/pull/24355"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/24355"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/24355/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/24355/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/24355/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/84a7ae21be5dbf363b4a0d7b41262fb4ab136293"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":0,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"danbev"}}