{"action":"closed","number":4598,"pull_request":{"url":"https://api.github.com/repos/swagger-api/swagger-ui/pulls/4598","id":190920781,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwOTIwNzgx","html_url":"https://github.com/swagger-api/swagger-ui/pull/4598","diff_url":"https://github.com/swagger-api/swagger-ui/pull/4598.diff","patch_url":"https://github.com/swagger-api/swagger-ui/pull/4598.patch","issue_url":"https://api.github.com/repos/swagger-api/swagger-ui/issues/4598","number":4598,"state":"closed","locked":false,"title":"Prevent loading resources from third party CDN","user":{"login":"markuspoerschke","id":1222377,"node_id":"MDQ6VXNlcjEyMjIzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1222377?v=4","gravatar_id":"","url":"https://api.github.com/users/markuspoerschke","html_url":"https://github.com/markuspoerschke","followers_url":"https://api.github.com/users/markuspoerschke/followers","following_url":"https://api.github.com/users/markuspoerschke/following{/other_user}","gists_url":"https://api.github.com/users/markuspoerschke/gists{/gist_id}","starred_url":"https://api.github.com/users/markuspoerschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuspoerschke/subscriptions","organizations_url":"https://api.github.com/users/markuspoerschke/orgs","repos_url":"https://api.github.com/users/markuspoerschke/repos","events_url":"https://api.github.com/users/markuspoerschke/events{/privacy}","received_events_url":"https://api.github.com/users/markuspoerschke/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n- Usage of Google Fonts was removed.\r\n- System fonts are used instead.\r\n\r\n### Motivation and Context\r\n\r\n- Remove usage of Google Fonts to avoid any data protection issue. \r\n- Using a CDN will leak data to a third party that can be simply avoided by using system fonts instead.\r\n- Usage of CDNs can cause legal issues in EU countries.\r\n\r\n## Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n### My PR contains... \r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] No code changes (`src/` is unmodified: changes to documentation, CI, metadata, etc.)\r\n- [ ] Dependency changes (any modification to dependencies in `package.json`)\r\n- [ ] Bug fixes (non-breaking change which fixes an issue)\r\n- [x] Improvements (misc. changes to existing features)\r\n- [ ] Features (non-breaking change which adds functionality)\r\n\r\n### My changes...\r\n- [ ] are breaking changes to a public API (config options, System API, major UI change, etc).\r\n- [ ] are breaking changes to a private API (Redux, component props, utility functions, etc.).\r\n- [ ] are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).\r\n- [x] are not breaking changes.\r\n\r\n### Documentation\r\n- [x] My changes do not require a change to the project documentation.\r\n- [ ] My changes require a change to the project documentation.\r\n- [ ] If yes to above: I have updated the documentation accordingly.\r\n\r\n### Automated tests\r\n- [x] My changes can not or do not need to be tested.\r\n- [ ] My changes can and should be tested by unit and/or integration tests.\r\n- [ ] If yes to above: I have added tests to cover my changes.\r\n- [ ] If yes to above: I have taken care to cover edge cases in my tests.\r\n- [ ] All new and existing tests passed.\r\n","created_at":"2018-05-28T12:40:56Z","updated_at":"2018-07-06T02:55:26Z","closed_at":"2018-07-06T02:55:26Z","merged_at":"2018-07-06T02:55:26Z","merge_commit_sha":"875caab173b1700bdd5c9e909df533019c3eca9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swagger-api/swagger-ui/pulls/4598/commits","review_comments_url":"https://api.github.com/repos/swagger-api/swagger-ui/pulls/4598/comments","review_comment_url":"https://api.github.com/repos/swagger-api/swagger-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swagger-api/swagger-ui/issues/4598/comments","statuses_url":"https://api.github.com/repos/swagger-api/swagger-ui/statuses/2473d4fd8f6195732b31eba99693c48081fcedef","head":{"label":"markuspoerschke:ft/prevent-cdn-usage","ref":"ft/prevent-cdn-usage","sha":"2473d4fd8f6195732b31eba99693c48081fcedef","user":{"login":"markuspoerschke","id":1222377,"node_id":"MDQ6VXNlcjEyMjIzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1222377?v=4","gravatar_id":"","url":"https://api.github.com/users/markuspoerschke","html_url":"https://github.com/markuspoerschke","followers_url":"https://api.github.com/users/markuspoerschke/followers","following_url":"https://api.github.com/users/markuspoerschke/following{/other_user}","gists_url":"https://api.github.com/users/markuspoerschke/gists{/gist_id}","starred_url":"https://api.github.com/users/markuspoerschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuspoerschke/subscriptions","organizations_url":"https://api.github.com/users/markuspoerschke/orgs","repos_url":"https://api.github.com/users/markuspoerschke/repos","events_url":"https://api.github.com/users/markuspoerschke/events{/privacy}","received_events_url":"https://api.github.com/users/markuspoerschke/received_events","type":"User","site_admin":false},"repo":{"id":135158842,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxNTg4NDI=","name":"swagger-ui","full_name":"markuspoerschke/swagger-ui","owner":{"login":"markuspoerschke","id":1222377,"node_id":"MDQ6VXNlcjEyMjIzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1222377?v=4","gravatar_id":"","url":"https://api.github.com/users/markuspoerschke","html_url":"https://github.com/markuspoerschke","followers_url":"https://api.github.com/users/markuspoerschke/followers","following_url":"https://api.github.com/users/markuspoerschke/following{/other_user}","gists_url":"https://api.github.com/users/markuspoerschke/gists{/gist_id}","starred_url":"https://api.github.com/users/markuspoerschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuspoerschke/subscriptions","organizations_url":"https://api.github.com/users/markuspoerschke/orgs","repos_url":"https://api.github.com/users/markuspoerschke/repos","events_url":"https://api.github.com/users/markuspoerschke/events{/privacy}","received_events_url":"https://api.github.com/users/markuspoerschke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markuspoerschke/swagger-ui","description":"Swagger UI is a collection of HTML, Javascript, and CSS assets that dynamically generate beautiful documentation from a Swagger-compliant API.","fork":true,"url":"https://api.github.com/repos/markuspoerschke/swagger-ui","forks_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/forks","keys_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/teams","hooks_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/hooks","issue_events_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/issues/events{/number}","events_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/events","assignees_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/assignees{/user}","branches_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/branches{/branch}","tags_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/tags","blobs_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/languages","stargazers_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/stargazers","contributors_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/contributors","subscribers_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/subscribers","subscription_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/subscription","commits_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/contents/{+path}","compare_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/merges","archive_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/downloads","issues_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/issues{/number}","pulls_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/labels{/name}","releases_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/releases{/id}","deployments_url":"https://api.github.com/repos/markuspoerschke/swagger-ui/deployments","created_at":"2018-05-28T12:36:07Z","updated_at":"2018-05-28T12:36:10Z","pushed_at":"2018-07-06T02:51:11Z","git_url":"git://github.com/markuspoerschke/swagger-ui.git","ssh_url":"git@github.com:markuspoerschke/swagger-ui.git","clone_url":"https://github.com/markuspoerschke/swagger-ui.git","svn_url":"https://github.com/markuspoerschke/swagger-ui","homepage":"http://swagger.io","size":218717,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swagger-api:master","ref":"master","sha":"ef95d6e00c8d070f613ab270b95756907e7387f0","user":{"login":"swagger-api","id":7658037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTgwMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/7658037?v=4","gravatar_id":"","url":"https://api.github.com/users/swagger-api","html_url":"https://github.com/swagger-api","followers_url":"https://api.github.com/users/swagger-api/followers","following_url":"https://api.github.com/users/swagger-api/following{/other_user}","gists_url":"https://api.github.com/users/swagger-api/gists{/gist_id}","starred_url":"https://api.github.com/users/swagger-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swagger-api/subscriptions","organizations_url":"https://api.github.com/users/swagger-api/orgs","repos_url":"https://api.github.com/users/swagger-api/repos","events_url":"https://api.github.com/users/swagger-api/events{/privacy}","received_events_url":"https://api.github.com/users/swagger-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2055965,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU1OTY1","name":"swagger-ui","full_name":"swagger-api/swagger-ui","owner":{"login":"swagger-api","id":7658037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTgwMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/7658037?v=4","gravatar_id":"","url":"https://api.github.com/users/swagger-api","html_url":"https://github.com/swagger-api","followers_url":"https://api.github.com/users/swagger-api/followers","following_url":"https://api.github.com/users/swagger-api/following{/other_user}","gists_url":"https://api.github.com/users/swagger-api/gists{/gist_id}","starred_url":"https://api.github.com/users/swagger-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swagger-api/subscriptions","organizations_url":"https://api.github.com/users/swagger-api/orgs","repos_url":"https://api.github.com/users/swagger-api/repos","events_url":"https://api.github.com/users/swagger-api/events{/privacy}","received_events_url":"https://api.github.com/users/swagger-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swagger-api/swagger-ui","description":"Swagger UI is a collection of HTML, Javascript, and CSS assets that dynamically generate beautiful documentation from a Swagger-compliant API.","fork":false,"url":"https://api.github.com/repos/swagger-api/swagger-ui","forks_url":"https://api.github.com/repos/swagger-api/swagger-ui/forks","keys_url":"https://api.github.com/repos/swagger-api/swagger-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swagger-api/swagger-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swagger-api/swagger-ui/teams","hooks_url":"https://api.github.com/repos/swagger-api/swagger-ui/hooks","issue_events_url":"https://api.github.com/repos/swagger-api/swagger-ui/issues/events{/number}","events_url":"https://api.github.com/repos/swagger-api/swagger-ui/events","assignees_url":"https://api.github.com/repos/swagger-api/swagger-ui/assignees{/user}","branches_url":"https://api.github.com/repos/swagger-api/swagger-ui/branches{/branch}","tags_url":"https://api.github.com/repos/swagger-api/swagger-ui/tags","blobs_url":"https://api.github.com/repos/swagger-api/swagger-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swagger-api/swagger-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swagger-api/swagger-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/swagger-api/swagger-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swagger-api/swagger-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/swagger-api/swagger-ui/languages","stargazers_url":"https://api.github.com/repos/swagger-api/swagger-ui/stargazers","contributors_url":"https://api.github.com/repos/swagger-api/swagger-ui/contributors","subscribers_url":"https://api.github.com/repos/swagger-api/swagger-ui/subscribers","subscription_url":"https://api.github.com/repos/swagger-api/swagger-ui/subscription","commits_url":"https://api.github.com/repos/swagger-api/swagger-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/swagger-api/swagger-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/swagger-api/swagger-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/swagger-api/swagger-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/swagger-api/swagger-ui/contents/{+path}","compare_url":"https://api.github.com/repos/swagger-api/swagger-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swagger-api/swagger-ui/merges","archive_url":"https://api.github.com/repos/swagger-api/swagger-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swagger-api/swagger-ui/downloads","issues_url":"https://api.github.com/repos/swagger-api/swagger-ui/issues{/number}","pulls_url":"https://api.github.com/repos/swagger-api/swagger-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/swagger-api/swagger-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/swagger-api/swagger-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swagger-api/swagger-ui/labels{/name}","releases_url":"https://api.github.com/repos/swagger-api/swagger-ui/releases{/id}","deployments_url":"https://api.github.com/repos/swagger-api/swagger-ui/deployments","created_at":"2011-07-15T22:56:39Z","updated_at":"2018-07-06T02:24:04Z","pushed_at":"2018-07-06T02:55:26Z","git_url":"git://github.com/swagger-api/swagger-ui.git","ssh_url":"git@github.com:swagger-api/swagger-ui.git","clone_url":"https://github.com/swagger-api/swagger-ui.git","svn_url":"https://github.com/swagger-api/swagger-ui","homepage":"http://swagger.io","size":228240,"stargazers_count":12075,"watchers_count":12075,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5693,"mirror_url":null,"archived":false,"open_issues_count":252,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5693,"open_issues":252,"watchers":12075,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swagger-api/swagger-ui/pulls/4598"},"html":{"href":"https://github.com/swagger-api/swagger-ui/pull/4598"},"issue":{"href":"https://api.github.com/repos/swagger-api/swagger-ui/issues/4598"},"comments":{"href":"https://api.github.com/repos/swagger-api/swagger-ui/issues/4598/comments"},"review_comments":{"href":"https://api.github.com/repos/swagger-api/swagger-ui/pulls/4598/comments"},"review_comment":{"href":"https://api.github.com/repos/swagger-api/swagger-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swagger-api/swagger-ui/pulls/4598/commits"},"statuses":{"href":"https://api.github.com/repos/swagger-api/swagger-ui/statuses/2473d4fd8f6195732b31eba99693c48081fcedef"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shockey","id":680248,"node_id":"MDQ6VXNlcjY4MDI0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/680248?v=4","gravatar_id":"","url":"https://api.github.com/users/shockey","html_url":"https://github.com/shockey","followers_url":"https://api.github.com/users/shockey/followers","following_url":"https://api.github.com/users/shockey/following{/other_user}","gists_url":"https://api.github.com/users/shockey/gists{/gist_id}","starred_url":"https://api.github.com/users/shockey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shockey/subscriptions","organizations_url":"https://api.github.com/users/shockey/orgs","repos_url":"https://api.github.com/users/shockey/repos","events_url":"https://api.github.com/users/shockey/events{/privacy}","received_events_url":"https://api.github.com/users/shockey/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"shockey"}}