{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/86","repository_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby","labels_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/86/comments","events_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/86/events","html_url":"https://github.com/DataDog/dogstatsd-ruby/pull/86","id":326318636,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNDM3Mzg5","number":86,"title":"Set buffer size in bytes","user":{"login":"grosser","id":11367,"node_id":"MDQ6VXNlcjExMzY3","avatar_url":"https://avatars3.githubusercontent.com/u/11367?v=4","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/milestones/12","html_url":"https://github.com/DataDog/dogstatsd-ruby/milestone/12","labels_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/milestones/12/labels","id":2974521,"node_id":"MDk6TWlsZXN0b25lMjk3NDUyMQ==","number":12,"title":"4.0.0","description":"","creator":{"login":"masci","id":7241,"node_id":"MDQ6VXNlcjcyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7241?v=4","gravatar_id":"","url":"https://api.github.com/users/masci","html_url":"https://github.com/masci","followers_url":"https://api.github.com/users/masci/followers","following_url":"https://api.github.com/users/masci/following{/other_user}","gists_url":"https://api.github.com/users/masci/gists{/gist_id}","starred_url":"https://api.github.com/users/masci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masci/subscriptions","organizations_url":"https://api.github.com/users/masci/orgs","repos_url":"https://api.github.com/users/masci/repos","events_url":"https://api.github.com/users/masci/events{/privacy}","received_events_url":"https://api.github.com/users/masci/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2017-12-12T14:27:33Z","updated_at":"2018-06-05T11:57:12Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-05-24T22:28:30Z","updated_at":"2018-06-05T19:35:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/86","html_url":"https://github.com/DataDog/dogstatsd-ruby/pull/86","diff_url":"https://github.com/DataDog/dogstatsd-ruby/pull/86.diff","patch_url":"https://github.com/DataDog/dogstatsd-ruby/pull/86.patch"},"body":"Default buffer size matches dd-agent read buffer\r\n\r\n@Antti @jonmoter \r\n\r\nas replacement for https://github.com/DataDog/dogstatsd-ruby/pull/82 and https://github.com/DataDog/dogstatsd-ruby/pull/65"},"comment":{"url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/comments/394833494","html_url":"https://github.com/DataDog/dogstatsd-ruby/pull/86#issuecomment-394833494","issue_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/86","id":394833494,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDgzMzQ5NA==","user":{"login":"grosser","id":11367,"node_id":"MDQ6VXNlcjExMzY3","avatar_url":"https://avatars3.githubusercontent.com/u/11367?v=4","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T19:35:33Z","updated_at":"2018-06-05T19:35:33Z","author_association":"NONE","body":"I think the agent can be configured to accept higher values, so that should\nbe fine.\nA warning for something that might be a valid usecase also means we must\nallow users to opt-out of the warning,\nif someone sets this option I'd trust them to know what they are doing.\n\nOn Tue, Jun 5, 2018 at 12:22 PM Syed Humza Shah <notifications@github.com>\nwrote:\n\n> *@humzashah* commented on this pull request.\n> ------------------------------\n>\n> In lib/datadog/statsd.rb\n> <https://github.com/DataDog/dogstatsd-ruby/pull/86#discussion_r193191194>:\n>\n> > @@ -108,8 +108,10 @@ def initialize(host = DEFAULT_HOST, port = DEFAULT_PORT, opts = EMPTY_OPTIONS)\n>        raise ArgumentError, 'tags must be a Array<String>' unless tags.nil? or tags.is_a? Array\n>        @tags = (tags || []).compact.map! {|tag| escape_tag_content(tag)}\n>\n> -      @buffer = Array.new\n> -      @max_buffer_size = opts[:max_buffer_size] || 50\n> +      # batching\n> +      @max_buffer_bytes = opts[:max_buffer_bytes] || 8192\n>\n> What are your thoughts on warning somebody when they set max_buffer_bytes\n> greater than this default?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/DataDog/dogstatsd-ruby/pull/86#pullrequestreview-126115459>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAAsZ1vK9okU_F7Sm3motAgSx2GyqL-cks5t5tpdgaJpZM4UNGAi>\n> .\n>\n"}}
{"actor":{"display_login":"grosser"}}