{"action":"created","issue":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2769","repository_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2769/labels{/name}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2769/comments","events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2769/events","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/issues/2769","id":363277284,"node_id":"MDU6SXNzdWUzNjMyNzcyODQ=","number":2769,"title":"Saving failed notification when saving product changes in spree - UK ","user":{"login":"sineadfenton","id":28807449,"node_id":"MDQ6VXNlcjI4ODA3NDQ5","avatar_url":"https://avatars3.githubusercontent.com/u/28807449?v=4","gravatar_id":"","url":"https://api.github.com/users/sineadfenton","html_url":"https://github.com/sineadfenton","followers_url":"https://api.github.com/users/sineadfenton/followers","following_url":"https://api.github.com/users/sineadfenton/following{/other_user}","gists_url":"https://api.github.com/users/sineadfenton/gists{/gist_id}","starred_url":"https://api.github.com/users/sineadfenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sineadfenton/subscriptions","organizations_url":"https://api.github.com/users/sineadfenton/orgs","repos_url":"https://api.github.com/users/sineadfenton/repos","events_url":"https://api.github.com/users/sineadfenton/events{/privacy}","received_events_url":"https://api.github.com/users/sineadfenton/received_events","type":"User","site_admin":false},"labels":[{"id":782472172,"node_id":"MDU6TGFiZWw3ODI0NzIxNzI=","url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/labels/bug-s2","name":"bug-s2","color":"ff6400","default":false}],"state":"open","locked":false,"assignee":{"login":"kristinalim","id":2243,"node_id":"MDQ6VXNlcjIyNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2243?v=4","gravatar_id":"","url":"https://api.github.com/users/kristinalim","html_url":"https://github.com/kristinalim","followers_url":"https://api.github.com/users/kristinalim/followers","following_url":"https://api.github.com/users/kristinalim/following{/other_user}","gists_url":"https://api.github.com/users/kristinalim/gists{/gist_id}","starred_url":"https://api.github.com/users/kristinalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristinalim/subscriptions","organizations_url":"https://api.github.com/users/kristinalim/orgs","repos_url":"https://api.github.com/users/kristinalim/repos","events_url":"https://api.github.com/users/kristinalim/events{/privacy}","received_events_url":"https://api.github.com/users/kristinalim/received_events","type":"User","site_admin":false},"assignees":[{"login":"kristinalim","id":2243,"node_id":"MDQ6VXNlcjIyNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2243?v=4","gravatar_id":"","url":"https://api.github.com/users/kristinalim","html_url":"https://github.com/kristinalim","followers_url":"https://api.github.com/users/kristinalim/followers","following_url":"https://api.github.com/users/kristinalim/following{/other_user}","gists_url":"https://api.github.com/users/kristinalim/gists{/gist_id}","starred_url":"https://api.github.com/users/kristinalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristinalim/subscriptions","organizations_url":"https://api.github.com/users/kristinalim/orgs","repos_url":"https://api.github.com/users/kristinalim/repos","events_url":"https://api.github.com/users/kristinalim/events{/privacy}","received_events_url":"https://api.github.com/users/kristinalim/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-09-24T18:56:50Z","updated_at":"2018-10-05T15:01:42Z","closed_at":null,"author_association":"NONE","body":"<!-- Provide a general summary of the issue in the Title above.\r\nWhen making changes to products on the product page in spree, when you click save you recieve an error stating \"Saving failed.Save failed due to invalid data:422\".\r\n\r\nWhen refreshing the page however it does appear that the changes have actually made it through, so the error notification seems to happen 'in error', and not actually an indication of there being a true error. \r\n\r\n-->\r\n## Description\r\n<!-- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->\r\n\r\nIn UK production site, in spree. Click save on the product page and you see an error message when infact the request has been processed. This is not the intended flow, instead you should see a saved/complete notification.\r\n\r\n## Expected Behavior\r\n<!-- Tell us what should happen -->\r\nYou should seed a \"saved\" notification when you click save and not 'Saving failed.Save failed due to invalid data:422'. This should only show when there is an error.\r\n\r\n## Actual Behavior\r\n<!-- Tell us what happens instead -->\r\nYou click save and Saving failed.Save failed due to invalid data:422 comes up\r\n\r\n## Steps to Reproduce\r\n<!-- Provide an unambiguous set of steps to reproduce this bug -->\r\n<!-- Include code to reproduce if relevant -->\r\n\r\n1. Go to product page\r\n2. Make a change - I changed the weight of an item.\r\n3. Click save\r\n4. Saving processes and then you get Saving failed with \"Save failed due to invalid data:422\" at the bottom of the screen\r\n5. Refresh the page. You'll see your changes have actually gone through\r\n\r\n## Animated Gif/Screenshot\r\n<!-- Provide a screenshot or brief animated gif reproducing the bug. Linux users can use\r\n[Peek](https://github.com/phw/peek#ubuntu) while Mac users can use [Recordit](http://recordit.co/) -->\r\n\r\n![image](https://user-images.githubusercontent.com/28807449/45972367-7397e680-c033-11e8-9fd9-9f0c89b5c9b7.png)\r\n\r\n\r\n## Context\r\n<!-- How has this bug affected you? What were you trying to accomplish? -->\r\n\r\nUsers will be confused and this there is an error when there is not. this will result in more support requests\r\n\r\n## Severity\r\n<!-- Assign a label and explain the impact.\r\n\r\nbug-s1: a critical feature is broken: checkout, payments, signup, login\r\nbug-s2: a non-critical feature is broken, no workaround\r\nbug-s3: a feature is broken but there is a workaround\r\nbug-s4: it's annoying, but you can use it\r\nbug-s5: we can live with it, only a few users impacted\r\n\r\nhttps://github.com/openfoodfoundation/openfoodnetwork/wiki/Bug-severity\r\n-->\r\n\r\n## Your Environment\r\n<!-- Include relevant details about the environment you experienced the bug in -->\r\n\r\n* Version used:\r\n* Browser name and version: Chrome\r\n* Operating System and version (desktop or mobile): Desktop, windows\r\nUK production was upgraded to 1.20.0 today (24/09) and this issue is new as of today.\r\n\r\n## Possible Fix\r\n<!-- Not obligatory, but suggest a fix or reason for the bug -->\r\nHave the correct message when a task is successfully completed, and error show up only when there is an error.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/comments/427396131","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/issues/2769#issuecomment-427396131","issue_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2769","id":427396131,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzM5NjEzMQ==","user":{"login":"myriamboure","id":8135376,"node_id":"MDQ6VXNlcjgxMzUzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/8135376?v=4","gravatar_id":"","url":"https://api.github.com/users/myriamboure","html_url":"https://github.com/myriamboure","followers_url":"https://api.github.com/users/myriamboure/followers","following_url":"https://api.github.com/users/myriamboure/following{/other_user}","gists_url":"https://api.github.com/users/myriamboure/gists{/gist_id}","starred_url":"https://api.github.com/users/myriamboure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myriamboure/subscriptions","organizations_url":"https://api.github.com/users/myriamboure/orgs","repos_url":"https://api.github.com/users/myriamboure/repos","events_url":"https://api.github.com/users/myriamboure/events{/privacy}","received_events_url":"https://api.github.com/users/myriamboure/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T15:01:42Z","updated_at":"2018-10-05T15:01:42Z","author_association":"CONTRIBUTOR","body":"@OliverUK is it only for sacred lotus that you have an issue? Or all products you have access to?"}}
{"actor":{"display_login":"myriamboure"}}