{"action":"created","issue":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1046","repository_url":"https://api.github.com/repos/AliceO2Group/AliceO2","labels_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1046/labels{/name}","comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1046/comments","events_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1046/events","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1046","id":319503507,"number":1046,"title":"[WIP] Introducing background/signal merging","user":{"login":"sawenzel","id":3536753,"avatar_url":"https://avatars1.githubusercontent.com/u/3536753?v=4","gravatar_id":"","url":"https://api.github.com/users/sawenzel","html_url":"https://github.com/sawenzel","followers_url":"https://api.github.com/users/sawenzel/followers","following_url":"https://api.github.com/users/sawenzel/following{/other_user}","gists_url":"https://api.github.com/users/sawenzel/gists{/gist_id}","starred_url":"https://api.github.com/users/sawenzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sawenzel/subscriptions","organizations_url":"https://api.github.com/users/sawenzel/orgs","repos_url":"https://api.github.com/users/sawenzel/repos","events_url":"https://api.github.com/users/sawenzel/events{/privacy}","received_events_url":"https://api.github.com/users/sawenzel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-02T10:49:16Z","updated_at":"2018-05-02T12:02:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1046","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1046","diff_url":"https://github.com/AliceO2Group/AliceO2/pull/1046.diff","patch_url":"https://github.com/AliceO2Group/AliceO2/pull/1046.patch"},"body":"This commit provides a major new feature for the hit processing\r\nstage. We are now able to overlay hits from different chains/files (in digitization).\r\n\r\nThis is mainly achieved through\r\n\r\n* Extension of the HitProcessingManager/RunContext, with the new ability\r\n  to take background/signal filenames and to sample composite collisions starting\r\n  from elementary events\r\n\r\nThe new feature is demonstrated in the digitizer workflow example for the TPC\r\n\r\n* digitizer-workflow -b --simFile background.root [--simFileS signal.root]\r\n\r\nIn order to make this work, some functions/structures in the TPC needed to be generalized:\r\n\r\n* passing down labels is now done using directly the MCCompLabel class in order\r\n  to correctly propagate the sourceID (previously not done)\r\n\r\n* more generic TPCHitGroupID\r\n\r\n* adapted version of the getHits() function to filter hits for any drifttime\r\n\r\nThis commit is part of [AOCSF-111]"},"comment":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/comments/385954513","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1046#issuecomment-385954513","issue_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1046","id":385954513,"user":{"login":"alibuild","id":13233178,"avatar_url":"https://avatars0.githubusercontent.com/u/13233178?v=4","gravatar_id":"","url":"https://api.github.com/users/alibuild","html_url":"https://github.com/alibuild","followers_url":"https://api.github.com/users/alibuild/followers","following_url":"https://api.github.com/users/alibuild/following{/other_user}","gists_url":"https://api.github.com/users/alibuild/gists{/gist_id}","starred_url":"https://api.github.com/users/alibuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibuild/subscriptions","organizations_url":"https://api.github.com/users/alibuild/orgs","repos_url":"https://api.github.com/users/alibuild/repos","events_url":"https://api.github.com/users/alibuild/events{/privacy}","received_events_url":"https://api.github.com/users/alibuild/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T12:02:55Z","updated_at":"2018-05-02T12:02:55Z","author_association":"COLLABORATOR","body":"Error while checking build/o2checkcode/o2 for e8782cde1b28ea7585abba90c278f772cdbee75d:\n```\nsw/BUILD/O2-latest/log\nDPLUtils_bucket\nDPLUtils_bucket\n-- Generate test test_ArrowTests_test_Arrow01\n-- Generate test test_Algorithm_o2formatparser\n-- Generate test test_Algorithm_headerstack\n-- Generate test test_Algorithm_parser\n-- Generate test test_Algorithm_tableview\n-- Generate test test_Algorithm_pageparser\n-- Generate test test_Algorithm_test_mpl_tools\n-- Generate test test_aliceHLTwrapper_testMessageFormat\n-- Generate test test_O2MessageMonitor_O2MessageMonitorTest\nDDS is found, QC Packages will be build\n-- Generate test test_DataFlow_test_TimeframeParser\n-- Generate test test_DataFlow_test_SubframeUtils01\n-- Generate test test_DataFlow_test_PayloadMerger01\n-- Generate test test_DataCompression_test_dc_primitives\n-- Generate test test_DataCompression_test_Fifo\n-- Generate test test_DataCompression_test_DataGenerator\n-- Generate test test_DataCompression_test_HuffmanCodec\n-- Generate test test_DataCompression_test_DataDeflater\n-- Generate test test_Steer_testInteractionSampler\n-- Generate test test_Steer_testHitProcessingManager\n-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) \nCMake Warning at doc/CMakeLists.txt:8 (message):\n  Graphviz doesn't seem to be installed.  Doxygen will not be able to\n  generate graphs.  Consider installing this package.\n\n\n-- Configuring done\nCMake Error at cmake/O2Utils.cmake:340 (ADD_EXECUTABLE):\n  Cannot find source file:\n\n    test/testHitProcessingManager.cxx\n\n  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm\n  .hpp .hxx .in .txx\nCall Stack (most recent call first):\n  cmake/O2Utils.cmake:422 (O2_GENERATE_EXECUTABLE)\n  Steer/CMakeLists.txt:28 (O2_GENERATE_TESTS)\n\n\nCMake Error at cmake/O2Utils.cmake:340 (ADD_EXECUTABLE):\n  No SOURCES given to target: test_Steer_testHitProcessingManager\nCall Stack (most recent call first):\n  cmake/O2Utils.cmake:422 (O2_GENERATE_EXECUTABLE)\n  Steer/CMakeLists.txt:28 (O2_GENERATE_TESTS)\n\n\n-- Build files have been written to: /mnt/mesos/sandbox/sandbox/sw/BUILD/016d343013916de10341028f6efff40215003c2c/O2\n```\nFull log [here](https://ali-ci.cern.ch/repo/logs/AliceO2Group/AliceO2/1046/e8782cde1b28ea7585abba90c278f772cdbee75d/build_o2checkcode_o2/fullLog.txt).\n"}}
{"actor":{"display_login":"alibuild"}}