{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/170335371","pull_request_review_id":99014466,"id":170335371,"diff_hunk":"@@ -471,6 +471,12 @@ void Server::process_PlayerPos(RemotePlayer *player, PlayerSAO *playersao,\n \tv3f position((f32)ps.X / 100.0f, (f32)ps.Y / 100.0f, (f32)ps.Z / 100.0f);\n \tv3f speed((f32)ss.X / 100.0f, (f32)ss.Y / 100.0f, (f32)ss.Z / 100.0f);\n \n+\tconst v3s16 old_node_position = floatToInt(playersao->getBasePosition(), BS);\n+\tconst v3s16 new_node_position = floatToInt(position, BS);\n+\n+\tif(old_node_position != new_node_position)\n+\t\tm_script->on_moveplayer(playersao, new_node_position, old_node_position);","path":"src/network/serverpackethandler.cpp","position":8,"original_position":8,"commit_id":"6e9a8b007086c3dbd5f4259ca7bc1bc9d88ca6b9","original_commit_id":"6e9a8b007086c3dbd5f4259ca7bc1bc9d88ca6b9","user":{"login":"lisacvuk","id":7235221,"avatar_url":"https://avatars2.githubusercontent.com/u/7235221?v=4","gravatar_id":"","url":"https://api.github.com/users/lisacvuk","html_url":"https://github.com/lisacvuk","followers_url":"https://api.github.com/users/lisacvuk/followers","following_url":"https://api.github.com/users/lisacvuk/following{/other_user}","gists_url":"https://api.github.com/users/lisacvuk/gists{/gist_id}","starred_url":"https://api.github.com/users/lisacvuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisacvuk/subscriptions","organizations_url":"https://api.github.com/users/lisacvuk/orgs","repos_url":"https://api.github.com/users/lisacvuk/repos","events_url":"https://api.github.com/users/lisacvuk/events{/privacy}","received_events_url":"https://api.github.com/users/lisacvuk/received_events","type":"User","site_admin":false},"body":"the number of calls to on_moveplayer, that is.","created_at":"2018-02-23T18:54:25Z","updated_at":"2018-02-23T18:54:25Z","html_url":"https://github.com/minetest/minetest/pull/7069#discussion_r170335371","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/7069","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/170335371"},"html":{"href":"https://github.com/minetest/minetest/pull/7069#discussion_r170335371"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7069"}},"in_reply_to_id":170325678},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7069","id":170907422,"html_url":"https://github.com/minetest/minetest/pull/7069","diff_url":"https://github.com/minetest/minetest/pull/7069.diff","patch_url":"https://github.com/minetest/minetest/pull/7069.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7069","number":7069,"state":"open","locked":false,"title":"[WIP] Add minetest.register_on_moveplayer","user":{"login":"lisacvuk","id":7235221,"avatar_url":"https://avatars2.githubusercontent.com/u/7235221?v=4","gravatar_id":"","url":"https://api.github.com/users/lisacvuk","html_url":"https://github.com/lisacvuk","followers_url":"https://api.github.com/users/lisacvuk/followers","following_url":"https://api.github.com/users/lisacvuk/following{/other_user}","gists_url":"https://api.github.com/users/lisacvuk/gists{/gist_id}","starred_url":"https://api.github.com/users/lisacvuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisacvuk/subscriptions","organizations_url":"https://api.github.com/users/lisacvuk/orgs","repos_url":"https://api.github.com/users/lisacvuk/repos","events_url":"https://api.github.com/users/lisacvuk/events{/privacy}","received_events_url":"https://api.github.com/users/lisacvuk/received_events","type":"User","site_admin":false},"body":"A function that's called every time player moves.  \r\nIs there a function for converting engine coords to node coords?  \r\n\r\nProvides the old position, and the new position.\r\n\r\nExample mod:\r\n```\r\nminetest.register_on_moveplayer(function(player, newpos, oldpos)\r\n\tprint(\"Player \" .. player:get_player_name() .. \" has moved to \" .. dump(newpos) .. \" from \" .. dump(oldpos))\r\nend)\r\n```\r\nSeems to close #247\r\n\r\nPlease review.","created_at":"2018-02-23T00:53:48Z","updated_at":"2018-02-23T18:54:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b53ce8c9449c12fd8ff8d3ce6b69364db6d4674e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":471238548,"url":"https://api.github.com/repos/minetest/minetest/labels/Feature","name":"Feature","color":"f9d0c4","default":false},{"id":110411003,"url":"https://api.github.com/repos/minetest/minetest/labels/WIP","name":"WIP","color":"aa3000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/7069/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/7069/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7069/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/6e9a8b007086c3dbd5f4259ca7bc1bc9d88ca6b9","head":{"label":"lisacvuk:add-on-moveplayer","ref":"add-on-moveplayer","sha":"6e9a8b007086c3dbd5f4259ca7bc1bc9d88ca6b9","user":{"login":"lisacvuk","id":7235221,"avatar_url":"https://avatars2.githubusercontent.com/u/7235221?v=4","gravatar_id":"","url":"https://api.github.com/users/lisacvuk","html_url":"https://github.com/lisacvuk","followers_url":"https://api.github.com/users/lisacvuk/followers","following_url":"https://api.github.com/users/lisacvuk/following{/other_user}","gists_url":"https://api.github.com/users/lisacvuk/gists{/gist_id}","starred_url":"https://api.github.com/users/lisacvuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisacvuk/subscriptions","organizations_url":"https://api.github.com/users/lisacvuk/orgs","repos_url":"https://api.github.com/users/lisacvuk/repos","events_url":"https://api.github.com/users/lisacvuk/events{/privacy}","received_events_url":"https://api.github.com/users/lisacvuk/received_events","type":"User","site_admin":false},"repo":{"id":93155319,"name":"minetest","full_name":"lisacvuk/minetest","owner":{"login":"lisacvuk","id":7235221,"avatar_url":"https://avatars2.githubusercontent.com/u/7235221?v=4","gravatar_id":"","url":"https://api.github.com/users/lisacvuk","html_url":"https://github.com/lisacvuk","followers_url":"https://api.github.com/users/lisacvuk/followers","following_url":"https://api.github.com/users/lisacvuk/following{/other_user}","gists_url":"https://api.github.com/users/lisacvuk/gists{/gist_id}","starred_url":"https://api.github.com/users/lisacvuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisacvuk/subscriptions","organizations_url":"https://api.github.com/users/lisacvuk/orgs","repos_url":"https://api.github.com/users/lisacvuk/repos","events_url":"https://api.github.com/users/lisacvuk/events{/privacy}","received_events_url":"https://api.github.com/users/lisacvuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lisacvuk/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/lisacvuk/minetest","forks_url":"https://api.github.com/repos/lisacvuk/minetest/forks","keys_url":"https://api.github.com/repos/lisacvuk/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lisacvuk/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lisacvuk/minetest/teams","hooks_url":"https://api.github.com/repos/lisacvuk/minetest/hooks","issue_events_url":"https://api.github.com/repos/lisacvuk/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/lisacvuk/minetest/events","assignees_url":"https://api.github.com/repos/lisacvuk/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/lisacvuk/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/lisacvuk/minetest/tags","blobs_url":"https://api.github.com/repos/lisacvuk/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lisacvuk/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lisacvuk/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/lisacvuk/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lisacvuk/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/lisacvuk/minetest/languages","stargazers_url":"https://api.github.com/repos/lisacvuk/minetest/stargazers","contributors_url":"https://api.github.com/repos/lisacvuk/minetest/contributors","subscribers_url":"https://api.github.com/repos/lisacvuk/minetest/subscribers","subscription_url":"https://api.github.com/repos/lisacvuk/minetest/subscription","commits_url":"https://api.github.com/repos/lisacvuk/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/lisacvuk/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/lisacvuk/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/lisacvuk/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/lisacvuk/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/lisacvuk/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lisacvuk/minetest/merges","archive_url":"https://api.github.com/repos/lisacvuk/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lisacvuk/minetest/downloads","issues_url":"https://api.github.com/repos/lisacvuk/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/lisacvuk/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/lisacvuk/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/lisacvuk/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lisacvuk/minetest/labels{/name}","releases_url":"https://api.github.com/repos/lisacvuk/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/lisacvuk/minetest/deployments","created_at":"2017-06-02T10:32:18Z","updated_at":"2017-06-02T10:32:23Z","pushed_at":"2018-02-23T16:05:26Z","git_url":"git://github.com/lisacvuk/minetest.git","ssh_url":"git@github.com:lisacvuk/minetest.git","clone_url":"https://github.com/lisacvuk/minetest.git","svn_url":"https://github.com/lisacvuk/minetest","homepage":"http://minetest.net/","size":54996,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"673f7196a2200a8f77d04a0470f642f729a4f94b","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game engine and game with survival and crafting. Also see https://github.com/minetest/minetest_game","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2018-02-23T18:05:07Z","pushed_at":"2018-02-23T16:05:28Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":55618,"stargazers_count":3163,"watchers_count":3163,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":885,"mirror_url":null,"archived":false,"open_issues_count":917,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":885,"open_issues":917,"watchers":3163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7069"},"html":{"href":"https://github.com/minetest/minetest/pull/7069"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/7069"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/7069/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7069/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7069/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/6e9a8b007086c3dbd5f4259ca7bc1bc9d88ca6b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lisacvuk"}}