{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/53340","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/53340/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/53340/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/53340/events","html_url":"https://github.com/Microsoft/vscode/issues/53340","id":337034065,"node_id":"MDU6SXNzdWUzMzcwMzQwNjU=","number":53340,"title":"TS rename causes many type definitions files to open for NPM packages","user":{"login":"kyle-mccarthy","id":7758522,"node_id":"MDQ6VXNlcjc3NTg1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7758522?v=4","gravatar_id":"","url":"https://api.github.com/users/kyle-mccarthy","html_url":"https://github.com/kyle-mccarthy","followers_url":"https://api.github.com/users/kyle-mccarthy/followers","following_url":"https://api.github.com/users/kyle-mccarthy/following{/other_user}","gists_url":"https://api.github.com/users/kyle-mccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-mccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-mccarthy/subscriptions","organizations_url":"https://api.github.com/users/kyle-mccarthy/orgs","repos_url":"https://api.github.com/users/kyle-mccarthy/repos","events_url":"https://api.github.com/users/kyle-mccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-mccarthy/received_events","type":"User","site_admin":false},"labels":[{"id":272689423,"node_id":"MDU6TGFiZWwyNzI2ODk0MjM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/needs%20more%20info","name":"needs more info","color":"E2A1C2","default":false},{"id":291055694,"node_id":"MDU6TGFiZWwyOTEwNTU2OTQ=","url":"https://api.github.com/repos/Microsoft/vscode/labels/typescript","name":"typescript","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"assignees":[{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-06-29T15:04:58Z","updated_at":"2018-06-29T19:03:22Z","closed_at":null,"author_association":"NONE","body":"With `\"typescript.updateImportsOnFileMove.enabled\"` setting set to `\"always\"`, after renaming a TS file, many TS definitions files from NPM packages will open.  When going to close the `.d.ts` files, VS code will think a change was made and prompt to save the package file.\r\n\r\n- VSCode Version: Version 1.24.1 (1.24.1)\r\n- OS Version: MacOS High Sierra 10.13.5 (17F77)\r\n\r\nSteps to Reproduce:\r\n\r\n1. Open TS file in project\r\n2. Rename open file\r\n3. Many definitions files from NPM packages open after change\r\n\r\nDoes this issue occur when all extensions are disabled?: Yes\r\n\r\n![bu0toawr8z](https://user-images.githubusercontent.com/7758522/42099598-7a4a5f48-7b83-11e8-920e-35a6144e9b31.gif)\r\n\r\nIt seemed similar to #53186 but the trigger and result are different. "},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/401445730","html_url":"https://github.com/Microsoft/vscode/issues/53340#issuecomment-401445730","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/53340","id":401445730,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTQ0NTczMA==","user":{"login":"kyle-mccarthy","id":7758522,"node_id":"MDQ6VXNlcjc3NTg1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7758522?v=4","gravatar_id":"","url":"https://api.github.com/users/kyle-mccarthy","html_url":"https://github.com/kyle-mccarthy","followers_url":"https://api.github.com/users/kyle-mccarthy/followers","following_url":"https://api.github.com/users/kyle-mccarthy/following{/other_user}","gists_url":"https://api.github.com/users/kyle-mccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-mccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-mccarthy/subscriptions","organizations_url":"https://api.github.com/users/kyle-mccarthy/orgs","repos_url":"https://api.github.com/users/kyle-mccarthy/repos","events_url":"https://api.github.com/users/kyle-mccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-mccarthy/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T19:03:22Z","updated_at":"2018-06-29T19:03:22Z","author_association":"NONE","body":"@mjbvz I just tried it out and while it didn't open any type def files, it opened several unrelated project files.\r\n\r\n![b96cdnp6c5](https://user-images.githubusercontent.com/7758522/42109968-20595cec-7ba5-11e8-9ca6-74e1d739efe8.gif)\r\n"}}
{"actor":{"display_login":"kyle-mccarthy"}}