{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/1639","repository_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/1639/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/1639/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/1639/events","html_url":"https://github.com/kubernetes-incubator/service-catalog/issues/1639","id":284070975,"number":1639,"title":"Duplicate OSB create/delete requests","user":{"login":"nilebox","id":6176360,"avatar_url":"https://avatars0.githubusercontent.com/u/6176360?v=4","gravatar_id":"","url":"https://api.github.com/users/nilebox","html_url":"https://github.com/nilebox","followers_url":"https://api.github.com/users/nilebox/followers","following_url":"https://api.github.com/users/nilebox/following{/other_user}","gists_url":"https://api.github.com/users/nilebox/gists{/gist_id}","starred_url":"https://api.github.com/users/nilebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilebox/subscriptions","organizations_url":"https://api.github.com/users/nilebox/orgs","repos_url":"https://api.github.com/users/nilebox/repos","events_url":"https://api.github.com/users/nilebox/events{/privacy}","received_events_url":"https://api.github.com/users/nilebox/received_events","type":"User","site_admin":false},"labels":[{"id":441215738,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-12-22T04:43:01Z","updated_at":"2018-03-07T05:55:50Z","closed_at":"2018-03-07T05:55:50Z","author_association":"CONTRIBUTOR","body":"I've noticed duplicate OSB requests for a single change in `ServiceInstance` in different scenarios:\r\n- 5 deprovisioning requests reported [there](https://github.com/kubernetes-incubator/service-catalog/issues/1574#issuecomment-353273293)\r\n- 2 create requests (logs from `ups-broker`):\r\n```\r\nI1221 23:46:09.728136       1 server.go:111] Get Service Broker Catalog...\r\nI1221 23:46:09.728152       1 controller.go:57] Catalog()\r\nI1221 23:54:58.838849       1 server.go:137] CreateServiceInstance 434423cf-8a6e-482a-937e-ddf95f992486...\r\nI1221 23:54:58.839113       1 controller.go:87] CreateServiceInstance()\r\nI1221 23:54:58.839195       1 controller.go:118] Created User Provided Service Instance:\r\n&{434423cf-8a6e-482a-937e-ddf95f992486 0xc4200fd1c0}\r\nI1221 23:54:58.937091       1 server.go:137] CreateServiceInstance 434423cf-8a6e-482a-937e-ddf95f992486...\r\nI1221 23:54:58.937207       1 controller.go:87] CreateServiceInstance()\r\nI1221 23:54:58.937225       1 controller.go:118] Created User Provided Service Instance:\r\n&{434423cf-8a6e-482a-937e-ddf95f992486 0xc4200fd1c8}\r\n```\r\n\r\nBy looking at the Service Catalog logs, it seems that there is an issue with picking up a stale object from the queue (before it is synchronized with the latest version from etcd) which leads to duplicate processing:\r\n```\r\nI1221 23:54:58.942144       1 round_trippers.go:436] PUT https://10.96.0.1:443/apis/servicecatalog.k8s.io/v1beta1/namespaces/test-ns/serviceinstances/ups-instance123/status 409 Conflict in 4 milliseconds\r\nI1221 23:54:58.942444       1 request.go:836] Response Body: {\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Failure\",\"message\":\"Operation cannot be fulfilled on serviceinstances.servicecatalog.k8s.io \\\"ups-instance123\\\": the object has been modified; please apply your changes to the latest version and try again\",\"reason\":\"Conflict\",\"details\":{\"name\":\"ups-instance123\",\"group\":\"servicecatalog.k8s.io\",\"kind\":\"serviceinstances\"},\"code\":409}\r\nE1221 23:54:58.942585       1 controller_instance.go:1844] ServiceInstance \"test-ns/ups-instance123\": Failed to update status: Operation cannot be fulfilled on serviceinstances.servicecatalog.k8s.io \"ups-instance123\": the object has been modified; please apply your changes to the latest version and try again\r\nI1221 23:54:58.942617       1 controller.go:237] Error syncing ServiceInstance test-ns/ups-instance123: Operation cannot be fulfilled on serviceinstances.servicecatalog.k8s.io \"ups-instance123\": the object has been modified; please apply your changes to the latest version and try again\r\n\r\n```"}}
{"actor":{"display_login":"nilebox"}}