{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/202494310","pull_request_review_id":137215831,"id":202494310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ5NDMxMA==","diff_hunk":"@@ -0,0 +1,4 @@\n+// RUN: %swiftc_driver -driver-print-jobs -target x86_64-unknown-linux-gnu -v %s 2>&1 | %FileCheck %s -check-prefix=VERBOSE_CLANG\n+// RUN: %swiftc_driver -driver-print-jobs -target x86_64-unknown-windows-misc -v %s 2>&1 | %FileCheck %s -check-prefix=VERBOSE_CLANG","path":"test/Driver/verbose.swift","position":2,"original_position":2,"commit_id":"3be298a3fac10adb3f5fc64b75965c4a425ecd59","original_commit_id":"3be298a3fac10adb3f5fc64b75965c4a425ecd59","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"\"msvc\", I think. I would expect the Cygnus build to use the GenericUnix toolchain. (Actually, there's a Cygnus toolchain that extends GenericUnix, but in this case it'll be the same.)","created_at":"2018-07-13T23:29:11Z","updated_at":"2018-07-13T23:29:12Z","html_url":"https://github.com/apple/swift/pull/16458#discussion_r202494310","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/16458","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/202494310"},"html":{"href":"https://github.com/apple/swift/pull/16458#discussion_r202494310"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/16458"}},"in_reply_to_id":202490807},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/16458","id":186767088,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2NzY3MDg4","html_url":"https://github.com/apple/swift/pull/16458","diff_url":"https://github.com/apple/swift/pull/16458.diff","patch_url":"https://github.com/apple/swift/pull/16458.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/16458","number":16458,"state":"open","locked":false,"title":"Run clang++ in verbose mode during linking if swiftc is called with \"-v\"","user":{"login":"dabelknap","id":1830592,"node_id":"MDQ6VXNlcjE4MzA1OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1830592?v=4","gravatar_id":"","url":"https://api.github.com/users/dabelknap","html_url":"https://github.com/dabelknap","followers_url":"https://api.github.com/users/dabelknap/followers","following_url":"https://api.github.com/users/dabelknap/following{/other_user}","gists_url":"https://api.github.com/users/dabelknap/gists{/gist_id}","starred_url":"https://api.github.com/users/dabelknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabelknap/subscriptions","organizations_url":"https://api.github.com/users/dabelknap/orgs","repos_url":"https://api.github.com/users/dabelknap/repos","events_url":"https://api.github.com/users/dabelknap/events{/privacy}","received_events_url":"https://api.github.com/users/dabelknap/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nThis PR is specific to `GenericUnix` and `Windows` platforms. If the `-v` option is supplied to the Swift compiler, also run `clang++` with the `-v` option during linking. Darwin calls the linker directly, so this change is only needed for Generic Unix and Windows.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nResolves [SR-656](https://bugs.swift.org/browse/SR-656).\r\n\r\nPreviously, this fix was attempted in [PR 4439](https://github.com/apple/swift/pull/4439), which was closed before any changes were made.\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n","created_at":"2018-05-08T21:57:15Z","updated_at":"2018-07-13T23:29:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f3db8b3432f11cb2aaa7d35a3ea6e8c484a8672","assignee":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/16458/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/16458/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/16458/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/3be298a3fac10adb3f5fc64b75965c4a425ecd59","head":{"label":"dabelknap:verbose_linker","ref":"verbose_linker","sha":"3be298a3fac10adb3f5fc64b75965c4a425ecd59","user":{"login":"dabelknap","id":1830592,"node_id":"MDQ6VXNlcjE4MzA1OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1830592?v=4","gravatar_id":"","url":"https://api.github.com/users/dabelknap","html_url":"https://github.com/dabelknap","followers_url":"https://api.github.com/users/dabelknap/followers","following_url":"https://api.github.com/users/dabelknap/following{/other_user}","gists_url":"https://api.github.com/users/dabelknap/gists{/gist_id}","starred_url":"https://api.github.com/users/dabelknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabelknap/subscriptions","organizations_url":"https://api.github.com/users/dabelknap/orgs","repos_url":"https://api.github.com/users/dabelknap/repos","events_url":"https://api.github.com/users/dabelknap/events{/privacy}","received_events_url":"https://api.github.com/users/dabelknap/received_events","type":"User","site_admin":false},"repo":{"id":127975258,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5NzUyNTg=","name":"swift","full_name":"dabelknap/swift","owner":{"login":"dabelknap","id":1830592,"node_id":"MDQ6VXNlcjE4MzA1OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1830592?v=4","gravatar_id":"","url":"https://api.github.com/users/dabelknap","html_url":"https://github.com/dabelknap","followers_url":"https://api.github.com/users/dabelknap/followers","following_url":"https://api.github.com/users/dabelknap/following{/other_user}","gists_url":"https://api.github.com/users/dabelknap/gists{/gist_id}","starred_url":"https://api.github.com/users/dabelknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabelknap/subscriptions","organizations_url":"https://api.github.com/users/dabelknap/orgs","repos_url":"https://api.github.com/users/dabelknap/repos","events_url":"https://api.github.com/users/dabelknap/events{/privacy}","received_events_url":"https://api.github.com/users/dabelknap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dabelknap/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/dabelknap/swift","forks_url":"https://api.github.com/repos/dabelknap/swift/forks","keys_url":"https://api.github.com/repos/dabelknap/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dabelknap/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dabelknap/swift/teams","hooks_url":"https://api.github.com/repos/dabelknap/swift/hooks","issue_events_url":"https://api.github.com/repos/dabelknap/swift/issues/events{/number}","events_url":"https://api.github.com/repos/dabelknap/swift/events","assignees_url":"https://api.github.com/repos/dabelknap/swift/assignees{/user}","branches_url":"https://api.github.com/repos/dabelknap/swift/branches{/branch}","tags_url":"https://api.github.com/repos/dabelknap/swift/tags","blobs_url":"https://api.github.com/repos/dabelknap/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dabelknap/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dabelknap/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/dabelknap/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dabelknap/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/dabelknap/swift/languages","stargazers_url":"https://api.github.com/repos/dabelknap/swift/stargazers","contributors_url":"https://api.github.com/repos/dabelknap/swift/contributors","subscribers_url":"https://api.github.com/repos/dabelknap/swift/subscribers","subscription_url":"https://api.github.com/repos/dabelknap/swift/subscription","commits_url":"https://api.github.com/repos/dabelknap/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/dabelknap/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/dabelknap/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/dabelknap/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/dabelknap/swift/contents/{+path}","compare_url":"https://api.github.com/repos/dabelknap/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dabelknap/swift/merges","archive_url":"https://api.github.com/repos/dabelknap/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dabelknap/swift/downloads","issues_url":"https://api.github.com/repos/dabelknap/swift/issues{/number}","pulls_url":"https://api.github.com/repos/dabelknap/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/dabelknap/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/dabelknap/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dabelknap/swift/labels{/name}","releases_url":"https://api.github.com/repos/dabelknap/swift/releases{/id}","deployments_url":"https://api.github.com/repos/dabelknap/swift/deployments","created_at":"2018-04-03T22:21:29Z","updated_at":"2018-07-10T22:38:31Z","pushed_at":"2018-07-13T22:42:22Z","git_url":"git://github.com/dabelknap/swift.git","ssh_url":"git@github.com:dabelknap/swift.git","clone_url":"https://github.com/dabelknap/swift.git","svn_url":"https://github.com/dabelknap/swift","homepage":"https://swift.org/","size":299041,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"88fb1246431c6e8e5e23555b597d673205f81863","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-07-13T22:52:15Z","pushed_at":"2018-07-13T23:28:00Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":309711,"stargazers_count":44523,"watchers_count":44523,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7030,"mirror_url":null,"archived":false,"open_issues_count":377,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7030,"open_issues":377,"watchers":44523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/16458"},"html":{"href":"https://github.com/apple/swift/pull/16458"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/16458"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/16458/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/16458/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/16458/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/3be298a3fac10adb3f5fc64b75965c4a425ecd59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jrose-apple"}}