{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/7340","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/7340/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/7340/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/7340/events","html_url":"https://github.com/Microsoft/vscode/issues/7340","id":158972554,"number":7340,"title":"Rename provider should support to 'resolve' rename location (to expand, invalidate, etc)","user":{"login":"daschult","id":7052303,"avatar_url":"https://avatars3.githubusercontent.com/u/7052303?v=4","gravatar_id":"","url":"https://api.github.com/users/daschult","html_url":"https://github.com/daschult","followers_url":"https://api.github.com/users/daschult/followers","following_url":"https://api.github.com/users/daschult/following{/other_user}","gists_url":"https://api.github.com/users/daschult/gists{/gist_id}","starred_url":"https://api.github.com/users/daschult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschult/subscriptions","organizations_url":"https://api.github.com/users/daschult/orgs","repos_url":"https://api.github.com/users/daschult/repos","events_url":"https://api.github.com/users/daschult/events{/privacy}","received_events_url":"https://api.github.com/users/daschult/received_events","type":"User","site_admin":false},"labels":[{"id":290465400,"url":"https://api.github.com/repos/Microsoft/vscode/labels/api","name":"api","color":"1d76db","default":false},{"id":869332220,"url":"https://api.github.com/repos/Microsoft/vscode/labels/api-proposal","name":"api-proposal","color":"83defc","default":false},{"id":272689392,"url":"https://api.github.com/repos/Microsoft/vscode/labels/feature-request","name":"feature-request","color":"dcdcdc","default":false}],"state":"open","locked":false,"assignee":{"login":"jrieken","id":1794099,"avatar_url":"https://avatars2.githubusercontent.com/u/1794099?v=4","gravatar_id":"","url":"https://api.github.com/users/jrieken","html_url":"https://github.com/jrieken","followers_url":"https://api.github.com/users/jrieken/followers","following_url":"https://api.github.com/users/jrieken/following{/other_user}","gists_url":"https://api.github.com/users/jrieken/gists{/gist_id}","starred_url":"https://api.github.com/users/jrieken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrieken/subscriptions","organizations_url":"https://api.github.com/users/jrieken/orgs","repos_url":"https://api.github.com/users/jrieken/repos","events_url":"https://api.github.com/users/jrieken/events{/privacy}","received_events_url":"https://api.github.com/users/jrieken/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrieken","id":1794099,"avatar_url":"https://avatars2.githubusercontent.com/u/1794099?v=4","gravatar_id":"","url":"https://api.github.com/users/jrieken","html_url":"https://github.com/jrieken","followers_url":"https://api.github.com/users/jrieken/followers","following_url":"https://api.github.com/users/jrieken/following{/other_user}","gists_url":"https://api.github.com/users/jrieken/gists{/gist_id}","starred_url":"https://api.github.com/users/jrieken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrieken/subscriptions","organizations_url":"https://api.github.com/users/jrieken/orgs","repos_url":"https://api.github.com/users/jrieken/repos","events_url":"https://api.github.com/users/jrieken/events{/privacy}","received_events_url":"https://api.github.com/users/jrieken/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/66","html_url":"https://github.com/Microsoft/vscode/milestone/66","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/66/labels","id":3186784,"number":66,"title":"April 2018","description":"","creator":{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars3.githubusercontent.com/u/22350?v=4","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"open_issues":83,"closed_issues":0,"state":"open","created_at":"2018-03-14T10:30:19Z","updated_at":"2018-03-28T08:05:17Z","due_on":null,"closed_at":null},"comments":52,"created_at":"2016-06-07T16:52:50Z","updated_at":"2018-03-28T08:17:51Z","closed_at":null,"author_association":"NONE","body":"- VSCode Version: 1.2.0\n- OS Version: Windows 10\n\nI’m having trouble with getting VS Code to do a rename operation correctly. When I put the caret on the word I want to rename and I hit F2, I see this:\n\n![badrename](https://cloud.githubusercontent.com/assets/7052303/15866856/50c279ec-2c95-11e6-994a-1e059dfe2a43.png)\n\nHowever, if I do the same operation (F2) on a simple string, I get just the contents I expect:\n\n![goodrename](https://cloud.githubusercontent.com/assets/7052303/15866859/57f6efcc-2c95-11e6-9891-c39dc2498e2c.png)\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/376801654","html_url":"https://github.com/Microsoft/vscode/issues/7340#issuecomment-376801654","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/7340","id":376801654,"user":{"login":"DanTup","id":1078012,"avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T08:17:51Z","updated_at":"2018-03-28T08:17:51Z","author_association":"NONE","body":"Ok, apparently the behaviour I'm seeing with my language server is a bug. In most cases it does actually return the range for the symbol.\r\n\r\nSo, I'm going to take the range provided by my server and read that part of the document and see if it matches the `oldName` variable they provided me. If they do, then all is good and I will pass that range to Code and if it does not then I will reject the rename. This will allow all cases where I have reliable info to work (which should be everything once the bugs are fixed) and no cases where the user will get the wrong thing in the box."}}
{"actor":{"display_login":"DanTup"}}