{"action":"created","comment":{"url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/comments/230122331","pull_request_review_id":170787533,"id":230122331,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDEyMjMzMQ==","diff_hunk":"@@ -1,18 +1,10 @@\n {","path":"packages/lisk-cryptography/test/tsconfig.json","position":1,"original_position":1,"commit_id":"37a2c4547bcdec43ff64634db60fa3bd1576e540","original_commit_id":"7901f66f6fac749f678bc181e92175256c69aef0","user":{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"body":"`\"typeRoots\": [\"../src/types\", \"../../../types\", \"../node_modules/@types\"]`\r\nthis part was bit different in this package","created_at":"2018-11-01T17:14:51Z","updated_at":"2018-11-01T17:14:52Z","html_url":"https://github.com/LiskHQ/lisk-elements/pull/835#discussion_r230122331","pull_request_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/835","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/comments/230122331"},"html":{"href":"https://github.com/LiskHQ/lisk-elements/pull/835#discussion_r230122331"},"pull_request":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/835"}},"in_reply_to_id":230121846},"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/835","id":227593357,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTkzMzU3","html_url":"https://github.com/LiskHQ/lisk-elements/pull/835","diff_url":"https://github.com/LiskHQ/lisk-elements/pull/835.diff","patch_url":"https://github.com/LiskHQ/lisk-elements/pull/835.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/835","number":835,"state":"open","locked":false,"title":"Fix sinon global for typescript - Closes #825","user":{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"body":"### What was the problem?\r\nReading the global definition of the sinon was unstable in the test.\r\n\r\n### How did I fix it?\r\nRestructuring the root type folder in the standard way, and using the `typeRoots` for referencing it.\r\n\r\n### How to test it?\r\n```\r\nnpm test\r\n```\r\n\r\n### Review checklist\r\n\r\n* The PR resolves #825\r\n* All new code is covered with unit tests\r\n* All new code was formatted with Prettier\r\n* Linting passes\r\n* Tests pass\r\n* Commit messages follow the [commit guidelines](CONTRIBUTING.md#git-commit-messages)\r\n* Documentation has been added/updated\r\n","created_at":"2018-11-01T11:46:13Z","updated_at":"2018-11-01T17:14:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41f000c54318c72b673695d74d8e980b46f625f1","assignee":{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"assignees":[{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},{"login":"mitsujutsu","id":36514357,"node_id":"MDQ6VXNlcjM2NTE0MzU3","avatar_url":"https://avatars0.githubusercontent.com/u/36514357?v=4","gravatar_id":"","url":"https://api.github.com/users/mitsujutsu","html_url":"https://github.com/mitsujutsu","followers_url":"https://api.github.com/users/mitsujutsu/followers","following_url":"https://api.github.com/users/mitsujutsu/following{/other_user}","gists_url":"https://api.github.com/users/mitsujutsu/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsujutsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsujutsu/subscriptions","organizations_url":"https://api.github.com/users/mitsujutsu/orgs","repos_url":"https://api.github.com/users/mitsujutsu/repos","events_url":"https://api.github.com/users/mitsujutsu/events{/privacy}","received_events_url":"https://api.github.com/users/mitsujutsu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":655490233,"node_id":"MDU6TGFiZWw2NTU0OTAyMzM=","url":"https://api.github.com/repos/LiskHQ/lisk-elements/labels/:eye:%20pending%20review","name":":eye: pending review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/835/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/835/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/835/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-elements/statuses/37a2c4547bcdec43ff64634db60fa3bd1576e540","head":{"label":"LiskHQ:825-global_types","ref":"825-global_types","sha":"37a2c4547bcdec43ff64634db60fa3bd1576e540","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":49426311,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQyNjMxMQ==","name":"lisk-elements","full_name":"LiskHQ/lisk-elements","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk-elements","description":"⚙️ Library for sending Lisk transactions from the client or server","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-elements","forks_url":"https://api.github.com/repos/LiskHQ/lisk-elements/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-elements/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-elements/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-elements/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-elements/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-elements/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-elements/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-elements/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-elements/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-elements/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-elements/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-elements/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-elements/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-elements/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-elements/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-elements/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-elements/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/deployments","created_at":"2016-01-11T12:54:02Z","updated_at":"2018-11-01T16:36:38Z","pushed_at":"2018-11-01T17:04:00Z","git_url":"git://github.com/LiskHQ/lisk-elements.git","ssh_url":"git@github.com:LiskHQ/lisk-elements.git","clone_url":"https://github.com/LiskHQ/lisk-elements.git","svn_url":"https://github.com/LiskHQ/lisk-elements","homepage":"https://lisk.io/","size":13893,"stargazers_count":263,"watchers_count":263,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":75,"open_issues":14,"watchers":263,"default_branch":"development"}},"base":{"label":"LiskHQ:development","ref":"development","sha":"af0d20c11a66f04dfe7f4b1a1e73759d1b7d264f","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":49426311,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQyNjMxMQ==","name":"lisk-elements","full_name":"LiskHQ/lisk-elements","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk-elements","description":"⚙️ Library for sending Lisk transactions from the client or server","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-elements","forks_url":"https://api.github.com/repos/LiskHQ/lisk-elements/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-elements/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-elements/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-elements/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-elements/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-elements/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-elements/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-elements/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-elements/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-elements/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-elements/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-elements/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-elements/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-elements/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-elements/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-elements/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-elements/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/deployments","created_at":"2016-01-11T12:54:02Z","updated_at":"2018-11-01T16:36:38Z","pushed_at":"2018-11-01T17:04:00Z","git_url":"git://github.com/LiskHQ/lisk-elements.git","ssh_url":"git@github.com:LiskHQ/lisk-elements.git","clone_url":"https://github.com/LiskHQ/lisk-elements.git","svn_url":"https://github.com/LiskHQ/lisk-elements","homepage":"https://lisk.io/","size":13893,"stargazers_count":263,"watchers_count":263,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":75,"open_issues":14,"watchers":263,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/835"},"html":{"href":"https://github.com/LiskHQ/lisk-elements/pull/835"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/835"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/835/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/835/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/835/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/statuses/37a2c4547bcdec43ff64634db60fa3bd1576e540"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shuse2"}}