{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/eui/pulls/comments/216774699","pull_request_review_id":154337383,"id":216774699,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc3NDY5OQ==","diff_hunk":"@@ -590,9 +597,9 @@ export class EuiBasicTable extends Component {\n       <Fragment key={`row_${itemId}`}>\n         <EuiTableRow\n           aria-owns={expandedRowId}\n-          isSelectable={isSelectable}\n+          isSelectable={typeof isSelectable === 'boolean' ? isSelectable : calculatedHasSelection}","path":"src/components/basic_table/basic_table.js","position":null,"original_position":49,"commit_id":"995593202d344a363c01eb94996813e6e6d49613","original_commit_id":"5df355c6f858fe13df5c44812121582c7c6af349","user":{"login":"cchaos","id":549577,"node_id":"MDQ6VXNlcjU0OTU3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"body":"Makes sense, done","created_at":"2018-09-11T18:31:55Z","updated_at":"2018-09-11T18:31:55Z","html_url":"https://github.com/elastic/eui/pull/1103#discussion_r216774699","pull_request_url":"https://api.github.com/repos/elastic/eui/pulls/1103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/eui/pulls/comments/216774699"},"html":{"href":"https://github.com/elastic/eui/pull/1103#discussion_r216774699"},"pull_request":{"href":"https://api.github.com/repos/elastic/eui/pulls/1103"}},"in_reply_to_id":216765630},"pull_request":{"url":"https://api.github.com/repos/elastic/eui/pulls/1103","id":207137499,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTM3NDk5","html_url":"https://github.com/elastic/eui/pull/1103","diff_url":"https://github.com/elastic/eui/pull/1103.diff","patch_url":"https://github.com/elastic/eui/pull/1103.patch","issue_url":"https://api.github.com/repos/elastic/eui/issues/1103","number":1103,"state":"open","locked":false,"title":"Table actions visibility","user":{"login":"cchaos","id":549577,"node_id":"MDQ6VXNlcjU0OTU3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"body":"Piggy-backing off of the discussion from #1080, here is a POC for altering the `EuiBasicTable` to utilize the concept agreed upon.\r\n\r\nI've commented out all but the Actions example in the docs to help zero in on the relevant example. I tried not to create any breaking changes.\r\n\r\nEssentially, instead of completely hiding the icons until hover, their opacity is just reduced a bit and the actions object now doesn't collapse until there are more than 2 (not more than 1) options. If any are deemed `isPrimary`, those will be shown on hover alongside the \"more\" dropdown, though only the first 2 \"primary\" actions will be shown in case more were declared.\r\n\r\nThe `isPrimary` prop added to the actions options, is my favorite prop name because it conflicts with our color scheme naming, but I'm having trouble coming up with a better one. \r\n\r\n<img src=\"https://d.pr/free/i/e7kleA+\" />\r\n\r\n\r\n## Decisions:\r\n\r\n- [ ] **Icon color**: Do we allow for supplied colors, restrict to a smaller palette, or not allow custom colors at all and they're always black or blue?","created_at":"2018-08-08T21:05:44Z","updated_at":"2018-09-11T18:31:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"125fcd388c2fffb39f99314335a09e11771a4c0b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"snide","id":324519,"node_id":"MDQ6VXNlcjMyNDUxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/324519?v=4","gravatar_id":"","url":"https://api.github.com/users/snide","html_url":"https://github.com/snide","followers_url":"https://api.github.com/users/snide/followers","following_url":"https://api.github.com/users/snide/following{/other_user}","gists_url":"https://api.github.com/users/snide/gists{/gist_id}","starred_url":"https://api.github.com/users/snide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snide/subscriptions","organizations_url":"https://api.github.com/users/snide/orgs","repos_url":"https://api.github.com/users/snide/repos","events_url":"https://api.github.com/users/snide/events{/privacy}","received_events_url":"https://api.github.com/users/snide/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/eui/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/elastic/eui/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/elastic/eui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/eui/issues/1103/comments","statuses_url":"https://api.github.com/repos/elastic/eui/statuses/995593202d344a363c01eb94996813e6e6d49613","head":{"label":"cchaos:poc/table-actions","ref":"poc/table-actions","sha":"995593202d344a363c01eb94996813e6e6d49613","user":{"login":"cchaos","id":549577,"node_id":"MDQ6VXNlcjU0OTU3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"repo":{"id":113351911,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzNTE5MTE=","name":"eui","full_name":"cchaos/eui","owner":{"login":"cchaos","id":549577,"node_id":"MDQ6VXNlcjU0OTU3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cchaos/eui","description":"Elastic UI Framework 🙌","fork":true,"url":"https://api.github.com/repos/cchaos/eui","forks_url":"https://api.github.com/repos/cchaos/eui/forks","keys_url":"https://api.github.com/repos/cchaos/eui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cchaos/eui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cchaos/eui/teams","hooks_url":"https://api.github.com/repos/cchaos/eui/hooks","issue_events_url":"https://api.github.com/repos/cchaos/eui/issues/events{/number}","events_url":"https://api.github.com/repos/cchaos/eui/events","assignees_url":"https://api.github.com/repos/cchaos/eui/assignees{/user}","branches_url":"https://api.github.com/repos/cchaos/eui/branches{/branch}","tags_url":"https://api.github.com/repos/cchaos/eui/tags","blobs_url":"https://api.github.com/repos/cchaos/eui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cchaos/eui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cchaos/eui/git/refs{/sha}","trees_url":"https://api.github.com/repos/cchaos/eui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cchaos/eui/statuses/{sha}","languages_url":"https://api.github.com/repos/cchaos/eui/languages","stargazers_url":"https://api.github.com/repos/cchaos/eui/stargazers","contributors_url":"https://api.github.com/repos/cchaos/eui/contributors","subscribers_url":"https://api.github.com/repos/cchaos/eui/subscribers","subscription_url":"https://api.github.com/repos/cchaos/eui/subscription","commits_url":"https://api.github.com/repos/cchaos/eui/commits{/sha}","git_commits_url":"https://api.github.com/repos/cchaos/eui/git/commits{/sha}","comments_url":"https://api.github.com/repos/cchaos/eui/comments{/number}","issue_comment_url":"https://api.github.com/repos/cchaos/eui/issues/comments{/number}","contents_url":"https://api.github.com/repos/cchaos/eui/contents/{+path}","compare_url":"https://api.github.com/repos/cchaos/eui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cchaos/eui/merges","archive_url":"https://api.github.com/repos/cchaos/eui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cchaos/eui/downloads","issues_url":"https://api.github.com/repos/cchaos/eui/issues{/number}","pulls_url":"https://api.github.com/repos/cchaos/eui/pulls{/number}","milestones_url":"https://api.github.com/repos/cchaos/eui/milestones{/number}","notifications_url":"https://api.github.com/repos/cchaos/eui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cchaos/eui/labels{/name}","releases_url":"https://api.github.com/repos/cchaos/eui/releases{/id}","deployments_url":"https://api.github.com/repos/cchaos/eui/deployments","created_at":"2017-12-06T18:19:26Z","updated_at":"2018-09-11T16:46:18Z","pushed_at":"2018-09-11T18:31:42Z","git_url":"git://github.com/cchaos/eui.git","ssh_url":"git@github.com:cchaos/eui.git","clone_url":"https://github.com/cchaos/eui.git","svn_url":"https://github.com/cchaos/eui","homepage":"https://elastic.github.io/eui/","size":121847,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"6558b71e0c2964be170fe8c5f84573ba810189cf","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":107422373,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc0MjIzNzM=","name":"eui","full_name":"elastic/eui","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/eui","description":"Elastic UI Framework 🙌","fork":false,"url":"https://api.github.com/repos/elastic/eui","forks_url":"https://api.github.com/repos/elastic/eui/forks","keys_url":"https://api.github.com/repos/elastic/eui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/eui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/eui/teams","hooks_url":"https://api.github.com/repos/elastic/eui/hooks","issue_events_url":"https://api.github.com/repos/elastic/eui/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/eui/events","assignees_url":"https://api.github.com/repos/elastic/eui/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/eui/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/eui/tags","blobs_url":"https://api.github.com/repos/elastic/eui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/eui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/eui/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/eui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/eui/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/eui/languages","stargazers_url":"https://api.github.com/repos/elastic/eui/stargazers","contributors_url":"https://api.github.com/repos/elastic/eui/contributors","subscribers_url":"https://api.github.com/repos/elastic/eui/subscribers","subscription_url":"https://api.github.com/repos/elastic/eui/subscription","commits_url":"https://api.github.com/repos/elastic/eui/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/eui/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/eui/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/eui/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/eui/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/eui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/eui/merges","archive_url":"https://api.github.com/repos/elastic/eui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/eui/downloads","issues_url":"https://api.github.com/repos/elastic/eui/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/eui/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/eui/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/eui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/eui/labels{/name}","releases_url":"https://api.github.com/repos/elastic/eui/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/eui/deployments","created_at":"2017-10-18T14:49:20Z","updated_at":"2018-09-11T18:14:43Z","pushed_at":"2018-09-11T18:31:43Z","git_url":"git://github.com/elastic/eui.git","ssh_url":"git@github.com:elastic/eui.git","clone_url":"https://github.com/elastic/eui.git","svn_url":"https://github.com/elastic/eui","homepage":"https://elastic.github.io/eui/","size":124575,"stargazers_count":331,"watchers_count":331,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":75,"open_issues":171,"watchers":331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/eui/pulls/1103"},"html":{"href":"https://github.com/elastic/eui/pull/1103"},"issue":{"href":"https://api.github.com/repos/elastic/eui/issues/1103"},"comments":{"href":"https://api.github.com/repos/elastic/eui/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/eui/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/eui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/eui/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/eui/statuses/995593202d344a363c01eb94996813e6e6d49613"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cchaos"}}