{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/11986","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/11986/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/11986/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/11986/events","html_url":"https://github.com/home-assistant/home-assistant/pull/11986","id":292180048,"number":11986,"title":"counter: allow custom increment/decrement amounts","user":{"login":"jackwilsdon","id":1843197,"avatar_url":"https://avatars0.githubusercontent.com/u/1843197?v=4","gravatar_id":"","url":"https://api.github.com/users/jackwilsdon","html_url":"https://github.com/jackwilsdon","followers_url":"https://api.github.com/users/jackwilsdon/followers","following_url":"https://api.github.com/users/jackwilsdon/following{/other_user}","gists_url":"https://api.github.com/users/jackwilsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/jackwilsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackwilsdon/subscriptions","organizations_url":"https://api.github.com/users/jackwilsdon/orgs","repos_url":"https://api.github.com/users/jackwilsdon/repos","events_url":"https://api.github.com/users/jackwilsdon/events{/privacy}","received_events_url":"https://api.github.com/users/jackwilsdon/received_events","type":"User","site_admin":false},"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":677113793,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20counter","name":"component: counter","color":"ededed","default":false},{"id":451931292,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-01-28T06:03:48Z","updated_at":"2018-02-28T20:39:19Z","closed_at":"2018-02-28T20:39:19Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11986","html_url":"https://github.com/home-assistant/home-assistant/pull/11986","diff_url":"https://github.com/home-assistant/home-assistant/pull/11986.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/11986.patch"},"body":"## Description: Allow custom increment/decrement amounts for counters.\r\n\r\nOne question I have regarding this is that whether `amount` should be an exact value (like it is in this PR as of writing), or a multiplier for steps (i.e. the real amount changed would be `step * amount`). I haven't created a PR for documentation yet as I'm unsure if it currently has the desired functionality.\r\n\r\n**Related issue (if applicable):** N/A\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nscript:\r\n  increment_default:\r\n    alias: Increment (default)\r\n    sequence:\r\n      - service: counter.increment\r\n        data:\r\n          entity_id: counter.counter\r\n  increment_5:\r\n    alias: Increment (5)\r\n    sequence:\r\n      - service: counter.increment\r\n        data:\r\n          entity_id: counter.counter\r\n          amount: 5\r\n  decrement_default:\r\n    alias: Decrement (default)\r\n    sequence:\r\n      - service: counter.decrement\r\n        data:\r\n          entity_id: counter.counter\r\n  decrement_5:\r\n    alias: Decrement (5)\r\n    sequence:\r\n      - service: counter.decrement\r\n        data:\r\n          entity_id: counter.counter\r\n          amount: 5\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/369374963","html_url":"https://github.com/home-assistant/home-assistant/pull/11986#issuecomment-369374963","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/11986","id":369374963,"user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T20:39:19Z","updated_at":"2018-02-28T20:39:19Z","author_association":"OWNER","body":"This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it."}}
{"actor":{"display_login":"balloob"}}