{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/205791103","pull_request_review_id":141134049,"id":205791103,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTc5MTEwMw==","diff_hunk":"@@ -0,0 +1,306 @@\n+// SASSTODO: we don't have a suitable var\n+.dscSidebar__ListHeader {\n+  margin-top: 5px;\n+}\n+\n+// SASSTODO: we don't have a suitable var\n+.dscPopularFields {\n+  padding-top: 10px;\n+}\n+\n+// SASSTODO: we don't have a z-index variable with the value of 1\n+.dscWrapper {\n+  padding-right: 0;\n+  padding-left: 21px;\n+  z-index: 1\n+}\n+\n+.dscWrapper__content {\n+  padding-right: $euiSize;\n+  clear: both;\n+}\n+\n+.dscTimechart {\n+  display: block;\n+  position: relative;\n+\n+  // SASSTODO: the visualizing component should have an option or a modifier\n+  .series > rect {\n+    fill-opacity: 0.5;\n+    stroke-width: 1;\n+  }\n+\n+  // SASSTODO: Seems that this selector is not used anywhere\n+  visualize {\n+    height: 200px; /* 1 */\n+\n+    .loading {\n+      opacity: 1 !important;\n+    }\n+\n+    &.only-spy {\n+      height: auto;\n+\n+      .visualize-table {\n+        height: auto;\n+      }\n+    }\n+  }\n+\n+  // SASSTODO: Seems that this class is not used anywhere\n+  .chartwrapper {\n+    position: absolute;\n+    top: 0;\n+    left: 0;\n+    width: 100%;\n+    height: 100%;\n+  }\n+\n+  // SASSTODO: Seems that this class is not used anywhere\n+  .vis-overlay {\n+    display: flex;\n+    align-items: center;\n+  }\n+}\n+\n+.dscTimechart__header {\n+  display: flex;\n+  justify-content: center;\n+  min-height: $euiSizeXXL;\n+  padding: $euiSizeXS 0;\n+}\n+\n+.dscOverlay {\n+  position: absolute;\n+  top: 0;\n+  right: 0;\n+  bottom: 0;\n+  left: 0;\n+  z-index: 20;\n+  padding-top: $euiSizeM;\n+\n+  opacity: 0.75;\n+  text-align: center;\n+  background-color: transparent;\n+}\n+\n+// SASSTODO: seems like this class is not used anywhere\n+.discover-info {\n+  line-height: 30px;\n+  padding: 0 10px;\n+  border-bottom-left-radius: $euiBorderRadius;\n+}\n+\n+// SASSTODO: seems like this class is not used anywhere\n+.discover-info-title {\n+  font-weight: bold;\n+  margin-right: 10px;\n+}\n+\n+.dscTable {\n+  overflow: auto;\n+\n+  // SASSTODO: add a monospace modifier to the doc-table component\n+  tbody {\n+    font-family: 'Lucida Console', Monaco, monospace;\n+  }\n+}\n+\n+// SASSTODO: replace the padding value with a variable\n+.dscTable__footer {\n+  background-color: $euiColorLightShade;\n+  padding: 5px 10px;\n+  text-align: center;\n+}\n+\n+// SASSTODO: seems like this class is not used anywhere\n+.discover-table-details-toggle {\n+  margin-bottom: 3px;\n+}\n+\n+.dscTable__timefield {\n+  white-space: nowrap;\n+}\n+\n+/**\n+ * 1. When switching between open and closed, the toggle changes size\n+ *    slightly which is a problem because it forces the entire table to\n+ *    re-render which is SLOW.\n+ */\n+.dscTable__openButton {\n+  appearance: none;\n+  background-color: transparent;\n+  padding: 0;\n+  border: none;\n+  width: 14px; /* 1 */\n+  height: 14px;\n+}\n+\n+// SASSTODO: seems like this class is not used anywhere\n+.discover-field-filter {\n+  background-color: $euiColorLightShade;\n+  margin-right: 10px;\n+\n+  .form-group {\n+    margin-bottom: 0;\n+  }\n+}\n+\n+/**\n+ * 1. Override sidebar-item-title styles.\n+ */\n+.dscSidebarItem {\n+  position: relative;\n+  display: flex;\n+  align-items: center;\n+  justify-content: space-between;\n+  padding-top: 0 !important; /* 1 */\n+  padding-bottom: 0 !important; /* 1 */\n+  height: $euiSizeXL;\n+\n+  &--active {","path":"src/core_plugins/kibana/public/discover/_discover.scss","position":null,"original_position":161,"commit_id":"23f203119b454bb146be19cf2bdc40a0875163f2","original_commit_id":"e584171bdfaf1ed8d5186c3279c1f0b7c34c7075","user":{"login":"going-confetti","id":3773351,"node_id":"MDQ6VXNlcjM3NzMzNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3773351?v=4","gravatar_id":"","url":"https://api.github.com/users/going-confetti","html_url":"https://github.com/going-confetti","followers_url":"https://api.github.com/users/going-confetti/followers","following_url":"https://api.github.com/users/going-confetti/following{/other_user}","gists_url":"https://api.github.com/users/going-confetti/gists{/gist_id}","starred_url":"https://api.github.com/users/going-confetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/going-confetti/subscriptions","organizations_url":"https://api.github.com/users/going-confetti/orgs","repos_url":"https://api.github.com/users/going-confetti/repos","events_url":"https://api.github.com/users/going-confetti/events{/privacy}","received_events_url":"https://api.github.com/users/going-confetti/received_events","type":"User","site_admin":false},"body":"You're right, besides we use full selector names everywhere. Fixed this one","created_at":"2018-07-27T14:23:36Z","updated_at":"2018-07-27T14:23:37Z","html_url":"https://github.com/elastic/kibana/pull/21290#discussion_r205791103","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/21290","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/205791103"},"html":{"href":"https://github.com/elastic/kibana/pull/21290#discussion_r205791103"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/21290"}},"in_reply_to_id":205684835},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/21290","id":204223745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjIzNzQ1","html_url":"https://github.com/elastic/kibana/pull/21290","diff_url":"https://github.com/elastic/kibana/pull/21290.diff","patch_url":"https://github.com/elastic/kibana/pull/21290.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/21290","number":21290,"state":"open","locked":false,"title":"Convert all Less files to Sass in discover, use EUI variable scope","user":{"login":"going-confetti","id":3773351,"node_id":"MDQ6VXNlcjM3NzMzNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3773351?v=4","gravatar_id":"","url":"https://api.github.com/users/going-confetti","html_url":"https://github.com/going-confetti","followers_url":"https://api.github.com/users/going-confetti/followers","following_url":"https://api.github.com/users/going-confetti/following{/other_user}","gists_url":"https://api.github.com/users/going-confetti/gists{/gist_id}","starred_url":"https://api.github.com/users/going-confetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/going-confetti/subscriptions","organizations_url":"https://api.github.com/users/going-confetti/orgs","repos_url":"https://api.github.com/users/going-confetti/repos","events_url":"https://api.github.com/users/going-confetti/events{/privacy}","received_events_url":"https://api.github.com/users/going-confetti/received_events","type":"User","site_admin":false},"body":"This PR removes the LESS files for the discover plugin and replaces them with Sass. It follows the same process takein in https://github.com/elastic/kibana/pull/20995","created_at":"2018-07-26T18:10:24Z","updated_at":"2018-07-27T14:23:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87e37b061a6c6742ac358816ffd24177ff115d8c","assignee":{"login":"going-confetti","id":3773351,"node_id":"MDQ6VXNlcjM3NzMzNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3773351?v=4","gravatar_id":"","url":"https://api.github.com/users/going-confetti","html_url":"https://github.com/going-confetti","followers_url":"https://api.github.com/users/going-confetti/followers","following_url":"https://api.github.com/users/going-confetti/following{/other_user}","gists_url":"https://api.github.com/users/going-confetti/gists{/gist_id}","starred_url":"https://api.github.com/users/going-confetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/going-confetti/subscriptions","organizations_url":"https://api.github.com/users/going-confetti/orgs","repos_url":"https://api.github.com/users/going-confetti/repos","events_url":"https://api.github.com/users/going-confetti/events{/privacy}","received_events_url":"https://api.github.com/users/going-confetti/received_events","type":"User","site_admin":false},"assignees":[{"login":"going-confetti","id":3773351,"node_id":"MDQ6VXNlcjM3NzMzNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3773351?v=4","gravatar_id":"","url":"https://api.github.com/users/going-confetti","html_url":"https://github.com/going-confetti","followers_url":"https://api.github.com/users/going-confetti/followers","following_url":"https://api.github.com/users/going-confetti/following{/other_user}","gists_url":"https://api.github.com/users/going-confetti/gists{/gist_id}","starred_url":"https://api.github.com/users/going-confetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/going-confetti/subscriptions","organizations_url":"https://api.github.com/users/going-confetti/orgs","repos_url":"https://api.github.com/users/going-confetti/repos","events_url":"https://api.github.com/users/going-confetti/events{/privacy}","received_events_url":"https://api.github.com/users/going-confetti/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/21290/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/21290/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/21290/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/23f203119b454bb146be19cf2bdc40a0875163f2","head":{"label":"going-confetti:sass/discover","ref":"sass/discover","sha":"23f203119b454bb146be19cf2bdc40a0875163f2","user":{"login":"going-confetti","id":3773351,"node_id":"MDQ6VXNlcjM3NzMzNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3773351?v=4","gravatar_id":"","url":"https://api.github.com/users/going-confetti","html_url":"https://github.com/going-confetti","followers_url":"https://api.github.com/users/going-confetti/followers","following_url":"https://api.github.com/users/going-confetti/following{/other_user}","gists_url":"https://api.github.com/users/going-confetti/gists{/gist_id}","starred_url":"https://api.github.com/users/going-confetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/going-confetti/subscriptions","organizations_url":"https://api.github.com/users/going-confetti/orgs","repos_url":"https://api.github.com/users/going-confetti/repos","events_url":"https://api.github.com/users/going-confetti/events{/privacy}","received_events_url":"https://api.github.com/users/going-confetti/received_events","type":"User","site_admin":false},"repo":{"id":141570323,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NzAzMjM=","name":"kibana","full_name":"going-confetti/kibana","owner":{"login":"going-confetti","id":3773351,"node_id":"MDQ6VXNlcjM3NzMzNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3773351?v=4","gravatar_id":"","url":"https://api.github.com/users/going-confetti","html_url":"https://github.com/going-confetti","followers_url":"https://api.github.com/users/going-confetti/followers","following_url":"https://api.github.com/users/going-confetti/following{/other_user}","gists_url":"https://api.github.com/users/going-confetti/gists{/gist_id}","starred_url":"https://api.github.com/users/going-confetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/going-confetti/subscriptions","organizations_url":"https://api.github.com/users/going-confetti/orgs","repos_url":"https://api.github.com/users/going-confetti/repos","events_url":"https://api.github.com/users/going-confetti/events{/privacy}","received_events_url":"https://api.github.com/users/going-confetti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/going-confetti/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/going-confetti/kibana","forks_url":"https://api.github.com/repos/going-confetti/kibana/forks","keys_url":"https://api.github.com/repos/going-confetti/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/going-confetti/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/going-confetti/kibana/teams","hooks_url":"https://api.github.com/repos/going-confetti/kibana/hooks","issue_events_url":"https://api.github.com/repos/going-confetti/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/going-confetti/kibana/events","assignees_url":"https://api.github.com/repos/going-confetti/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/going-confetti/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/going-confetti/kibana/tags","blobs_url":"https://api.github.com/repos/going-confetti/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/going-confetti/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/going-confetti/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/going-confetti/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/going-confetti/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/going-confetti/kibana/languages","stargazers_url":"https://api.github.com/repos/going-confetti/kibana/stargazers","contributors_url":"https://api.github.com/repos/going-confetti/kibana/contributors","subscribers_url":"https://api.github.com/repos/going-confetti/kibana/subscribers","subscription_url":"https://api.github.com/repos/going-confetti/kibana/subscription","commits_url":"https://api.github.com/repos/going-confetti/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/going-confetti/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/going-confetti/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/going-confetti/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/going-confetti/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/going-confetti/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/going-confetti/kibana/merges","archive_url":"https://api.github.com/repos/going-confetti/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/going-confetti/kibana/downloads","issues_url":"https://api.github.com/repos/going-confetti/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/going-confetti/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/going-confetti/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/going-confetti/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/going-confetti/kibana/labels{/name}","releases_url":"https://api.github.com/repos/going-confetti/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/going-confetti/kibana/deployments","created_at":"2018-07-19T11:31:34Z","updated_at":"2018-07-23T18:16:11Z","pushed_at":"2018-07-27T14:20:54Z","git_url":"git://github.com/going-confetti/kibana.git","ssh_url":"git@github.com:going-confetti/kibana.git","clone_url":"https://github.com/going-confetti/kibana.git","svn_url":"https://github.com/going-confetti/kibana","homepage":"https://www.elastic.co/products/kibana","size":432449,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"7a0c61fc2c436bb908fc65f17a5f5e2732375abe","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-07-27T14:14:33Z","pushed_at":"2018-07-27T14:20:57Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":433904,"stargazers_count":9758,"watchers_count":9758,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3813,"mirror_url":null,"archived":false,"open_issues_count":3347,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3813,"open_issues":3347,"watchers":9758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/21290"},"html":{"href":"https://github.com/elastic/kibana/pull/21290"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/21290"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/21290/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/21290/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/21290/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/23f203119b454bb146be19cf2bdc40a0875163f2"}},"author_association":"NONE"}}
{"actor":{"display_login":"going-confetti"}}