{"action":"created","comment":{"url":"https://api.github.com/repos/mltframework/mlt/pulls/comments/165814968","pull_request_review_id":93817072,"id":165814968,"diff_hunk":"@@ -712,8 +712,9 @@ mlt_frame mlt_consumer_get_frame( mlt_consumer self )\n \t\tif ( test_card != NULL )\n \t\t\tmlt_properties_set_data( frame_properties, \"test_card_producer\", test_card, 0, NULL, NULL );\n \n-\t\t// Pass along the interpolation and deinterlace options\n+\t\t// Pass along the channel convert, interpolation and deinterlace options\n \t\t// TODO: get rid of consumer_deinterlace and use profile.progressive\n+\t\tmlt_properties_set( frame_properties, \"audiochannel.convert\", mlt_properties_get( properties, \"channelconvert\" ) );","path":"src/framework/mlt_consumer.c","position":7,"original_position":7,"commit_id":"c4d11402c5b7e5b3875fa9374dea8ee7368bca5d","original_commit_id":"c4d11402c5b7e5b3875fa9374dea8ee7368bca5d","user":{"login":"bmatherly","id":821968,"avatar_url":"https://avatars0.githubusercontent.com/u/821968?v=4","gravatar_id":"","url":"https://api.github.com/users/bmatherly","html_url":"https://github.com/bmatherly","followers_url":"https://api.github.com/users/bmatherly/followers","following_url":"https://api.github.com/users/bmatherly/following{/other_user}","gists_url":"https://api.github.com/users/bmatherly/gists{/gist_id}","starred_url":"https://api.github.com/users/bmatherly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmatherly/subscriptions","organizations_url":"https://api.github.com/users/bmatherly/orgs","repos_url":"https://api.github.com/users/bmatherly/repos","events_url":"https://api.github.com/users/bmatherly/events{/privacy}","received_events_url":"https://api.github.com/users/bmatherly/received_events","type":"User","site_admin":false},"body":"I had in mind that any filter could intercept this property and use/apply it. So I don't think it has to specifically target the audiochannels filter. Or example, we could create a new filter that uses avresample and that filter should also use this property. I will change it to \"consumer_channels_convert\"","created_at":"2018-02-03T13:45:23Z","updated_at":"2018-02-03T13:45:23Z","html_url":"https://github.com/mltframework/mlt/pull/295#discussion_r165814968","pull_request_url":"https://api.github.com/repos/mltframework/mlt/pulls/295","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mltframework/mlt/pulls/comments/165814968"},"html":{"href":"https://github.com/mltframework/mlt/pull/295#discussion_r165814968"},"pull_request":{"href":"https://api.github.com/repos/mltframework/mlt/pulls/295"}},"in_reply_to_id":164329250},"pull_request":{"url":"https://api.github.com/repos/mltframework/mlt/pulls/295","id":165608010,"html_url":"https://github.com/mltframework/mlt/pull/295","diff_url":"https://github.com/mltframework/mlt/pull/295.diff","patch_url":"https://github.com/mltframework/mlt/pull/295.patch","issue_url":"https://api.github.com/repos/mltframework/mlt/issues/295","number":295,"state":"open","locked":false,"title":"Extend audio channel conversion.","user":{"login":"bmatherly","id":821968,"avatar_url":"https://avatars0.githubusercontent.com/u/821968?v=4","gravatar_id":"","url":"https://api.github.com/users/bmatherly","html_url":"https://github.com/bmatherly","followers_url":"https://api.github.com/users/bmatherly/followers","following_url":"https://api.github.com/users/bmatherly/following{/other_user}","gists_url":"https://api.github.com/users/bmatherly/gists{/gist_id}","starred_url":"https://api.github.com/users/bmatherly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmatherly/subscriptions","organizations_url":"https://api.github.com/users/bmatherly/orgs","repos_url":"https://api.github.com/users/bmatherly/repos","events_url":"https://api.github.com/users/bmatherly/events{/privacy}","received_events_url":"https://api.github.com/users/bmatherly/received_events","type":"User","site_admin":false},"body":"* Add more comprehensive surround mixing combinations.\r\n* Properly handle conversions to/from mono and stereo.\r\n* Provide two conversion modes:\r\n  - mix: for stereo/surround audio channels\r\n  - dupdrop: for discrete (unrelated) audio channels\r\n* Allow the consumer to specify the conversion mode to use.\r\n* The default mode is \"mix\"","created_at":"2018-01-29T03:12:48Z","updated_at":"2018-02-03T13:45:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95898eda051df07cfb45d987761a113e75add3ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mltframework/mlt/pulls/295/commits","review_comments_url":"https://api.github.com/repos/mltframework/mlt/pulls/295/comments","review_comment_url":"https://api.github.com/repos/mltframework/mlt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mltframework/mlt/issues/295/comments","statuses_url":"https://api.github.com/repos/mltframework/mlt/statuses/c4d11402c5b7e5b3875fa9374dea8ee7368bca5d","head":{"label":"bmatherly:surround_convert","ref":"surround_convert","sha":"c4d11402c5b7e5b3875fa9374dea8ee7368bca5d","user":{"login":"bmatherly","id":821968,"avatar_url":"https://avatars0.githubusercontent.com/u/821968?v=4","gravatar_id":"","url":"https://api.github.com/users/bmatherly","html_url":"https://github.com/bmatherly","followers_url":"https://api.github.com/users/bmatherly/followers","following_url":"https://api.github.com/users/bmatherly/following{/other_user}","gists_url":"https://api.github.com/users/bmatherly/gists{/gist_id}","starred_url":"https://api.github.com/users/bmatherly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmatherly/subscriptions","organizations_url":"https://api.github.com/users/bmatherly/orgs","repos_url":"https://api.github.com/users/bmatherly/repos","events_url":"https://api.github.com/users/bmatherly/events{/privacy}","received_events_url":"https://api.github.com/users/bmatherly/received_events","type":"User","site_admin":false},"repo":{"id":8225935,"name":"mlt","full_name":"bmatherly/mlt","owner":{"login":"bmatherly","id":821968,"avatar_url":"https://avatars0.githubusercontent.com/u/821968?v=4","gravatar_id":"","url":"https://api.github.com/users/bmatherly","html_url":"https://github.com/bmatherly","followers_url":"https://api.github.com/users/bmatherly/followers","following_url":"https://api.github.com/users/bmatherly/following{/other_user}","gists_url":"https://api.github.com/users/bmatherly/gists{/gist_id}","starred_url":"https://api.github.com/users/bmatherly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmatherly/subscriptions","organizations_url":"https://api.github.com/users/bmatherly/orgs","repos_url":"https://api.github.com/users/bmatherly/repos","events_url":"https://api.github.com/users/bmatherly/events{/privacy}","received_events_url":"https://api.github.com/users/bmatherly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmatherly/mlt","description":"Media Lovin' Toolkit","fork":true,"url":"https://api.github.com/repos/bmatherly/mlt","forks_url":"https://api.github.com/repos/bmatherly/mlt/forks","keys_url":"https://api.github.com/repos/bmatherly/mlt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmatherly/mlt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmatherly/mlt/teams","hooks_url":"https://api.github.com/repos/bmatherly/mlt/hooks","issue_events_url":"https://api.github.com/repos/bmatherly/mlt/issues/events{/number}","events_url":"https://api.github.com/repos/bmatherly/mlt/events","assignees_url":"https://api.github.com/repos/bmatherly/mlt/assignees{/user}","branches_url":"https://api.github.com/repos/bmatherly/mlt/branches{/branch}","tags_url":"https://api.github.com/repos/bmatherly/mlt/tags","blobs_url":"https://api.github.com/repos/bmatherly/mlt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmatherly/mlt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmatherly/mlt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmatherly/mlt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmatherly/mlt/statuses/{sha}","languages_url":"https://api.github.com/repos/bmatherly/mlt/languages","stargazers_url":"https://api.github.com/repos/bmatherly/mlt/stargazers","contributors_url":"https://api.github.com/repos/bmatherly/mlt/contributors","subscribers_url":"https://api.github.com/repos/bmatherly/mlt/subscribers","subscription_url":"https://api.github.com/repos/bmatherly/mlt/subscription","commits_url":"https://api.github.com/repos/bmatherly/mlt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmatherly/mlt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmatherly/mlt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmatherly/mlt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmatherly/mlt/contents/{+path}","compare_url":"https://api.github.com/repos/bmatherly/mlt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmatherly/mlt/merges","archive_url":"https://api.github.com/repos/bmatherly/mlt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmatherly/mlt/downloads","issues_url":"https://api.github.com/repos/bmatherly/mlt/issues{/number}","pulls_url":"https://api.github.com/repos/bmatherly/mlt/pulls{/number}","milestones_url":"https://api.github.com/repos/bmatherly/mlt/milestones{/number}","notifications_url":"https://api.github.com/repos/bmatherly/mlt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmatherly/mlt/labels{/name}","releases_url":"https://api.github.com/repos/bmatherly/mlt/releases{/id}","deployments_url":"https://api.github.com/repos/bmatherly/mlt/deployments","created_at":"2013-02-15T20:49:34Z","updated_at":"2015-05-06T03:47:46Z","pushed_at":"2018-01-29T03:02:55Z","git_url":"git://github.com/bmatherly/mlt.git","ssh_url":"git@github.com:bmatherly/mlt.git","clone_url":"https://github.com/bmatherly/mlt.git","svn_url":"https://github.com/bmatherly/mlt","homepage":"http://www.mltframework.org","size":18523,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mltframework:master","ref":"master","sha":"aea7f984b85ac61a4052d6ae17ce981d0530548e","user":{"login":"mltframework","id":1558770,"avatar_url":"https://avatars3.githubusercontent.com/u/1558770?v=4","gravatar_id":"","url":"https://api.github.com/users/mltframework","html_url":"https://github.com/mltframework","followers_url":"https://api.github.com/users/mltframework/followers","following_url":"https://api.github.com/users/mltframework/following{/other_user}","gists_url":"https://api.github.com/users/mltframework/gists{/gist_id}","starred_url":"https://api.github.com/users/mltframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mltframework/subscriptions","organizations_url":"https://api.github.com/users/mltframework/orgs","repos_url":"https://api.github.com/users/mltframework/repos","events_url":"https://api.github.com/users/mltframework/events{/privacy}","received_events_url":"https://api.github.com/users/mltframework/received_events","type":"Organization","site_admin":false},"repo":{"id":4019052,"name":"mlt","full_name":"mltframework/mlt","owner":{"login":"mltframework","id":1558770,"avatar_url":"https://avatars3.githubusercontent.com/u/1558770?v=4","gravatar_id":"","url":"https://api.github.com/users/mltframework","html_url":"https://github.com/mltframework","followers_url":"https://api.github.com/users/mltframework/followers","following_url":"https://api.github.com/users/mltframework/following{/other_user}","gists_url":"https://api.github.com/users/mltframework/gists{/gist_id}","starred_url":"https://api.github.com/users/mltframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mltframework/subscriptions","organizations_url":"https://api.github.com/users/mltframework/orgs","repos_url":"https://api.github.com/users/mltframework/repos","events_url":"https://api.github.com/users/mltframework/events{/privacy}","received_events_url":"https://api.github.com/users/mltframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mltframework/mlt","description":"MLT Multimedia Framework","fork":false,"url":"https://api.github.com/repos/mltframework/mlt","forks_url":"https://api.github.com/repos/mltframework/mlt/forks","keys_url":"https://api.github.com/repos/mltframework/mlt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mltframework/mlt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mltframework/mlt/teams","hooks_url":"https://api.github.com/repos/mltframework/mlt/hooks","issue_events_url":"https://api.github.com/repos/mltframework/mlt/issues/events{/number}","events_url":"https://api.github.com/repos/mltframework/mlt/events","assignees_url":"https://api.github.com/repos/mltframework/mlt/assignees{/user}","branches_url":"https://api.github.com/repos/mltframework/mlt/branches{/branch}","tags_url":"https://api.github.com/repos/mltframework/mlt/tags","blobs_url":"https://api.github.com/repos/mltframework/mlt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mltframework/mlt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mltframework/mlt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mltframework/mlt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mltframework/mlt/statuses/{sha}","languages_url":"https://api.github.com/repos/mltframework/mlt/languages","stargazers_url":"https://api.github.com/repos/mltframework/mlt/stargazers","contributors_url":"https://api.github.com/repos/mltframework/mlt/contributors","subscribers_url":"https://api.github.com/repos/mltframework/mlt/subscribers","subscription_url":"https://api.github.com/repos/mltframework/mlt/subscription","commits_url":"https://api.github.com/repos/mltframework/mlt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mltframework/mlt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mltframework/mlt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mltframework/mlt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mltframework/mlt/contents/{+path}","compare_url":"https://api.github.com/repos/mltframework/mlt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mltframework/mlt/merges","archive_url":"https://api.github.com/repos/mltframework/mlt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mltframework/mlt/downloads","issues_url":"https://api.github.com/repos/mltframework/mlt/issues{/number}","pulls_url":"https://api.github.com/repos/mltframework/mlt/pulls{/number}","milestones_url":"https://api.github.com/repos/mltframework/mlt/milestones{/number}","notifications_url":"https://api.github.com/repos/mltframework/mlt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mltframework/mlt/labels{/name}","releases_url":"https://api.github.com/repos/mltframework/mlt/releases{/id}","deployments_url":"https://api.github.com/repos/mltframework/mlt/deployments","created_at":"2012-04-13T18:30:28Z","updated_at":"2018-02-01T16:02:07Z","pushed_at":"2018-02-02T01:12:59Z","git_url":"git://github.com/mltframework/mlt.git","ssh_url":"git@github.com:mltframework/mlt.git","clone_url":"https://github.com/mltframework/mlt.git","svn_url":"https://github.com/mltframework/mlt","homepage":"https://www.mltframework.org","size":18560,"stargazers_count":304,"watchers_count":304,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":97,"open_issues":33,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mltframework/mlt/pulls/295"},"html":{"href":"https://github.com/mltframework/mlt/pull/295"},"issue":{"href":"https://api.github.com/repos/mltframework/mlt/issues/295"},"comments":{"href":"https://api.github.com/repos/mltframework/mlt/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/mltframework/mlt/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/mltframework/mlt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mltframework/mlt/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/mltframework/mlt/statuses/c4d11402c5b7e5b3875fa9374dea8ee7368bca5d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"bmatherly"}}