{"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/180976980","pull_request_review_id":111491945,"id":180976980,"diff_hunk":"@@ -4,16 +4,18 @@ exports.config = {\n   allScriptsTimeout: 20000,\n \n   specs: [\n-    './e2e/modules/account/**/*.spec.ts',\n-    './e2e/modules/admin/**/*.spec.ts',\n-    './e2e/entities/**/*.spec.ts',\n+    './e2e/modules/account/*.spec.ts',\n+    './e2e/modules/administration/*.spec.ts',\n+    './e2e/modules/page-objects/*.spec.ts',","path":"generators/client/templates/react/src/test/javascript/protractor.conf.js.ejs","position":9,"original_position":9,"commit_id":"c68ae3ab6d4a7848a8bfcb2168d932ab4b48e962","original_commit_id":"c68ae3ab6d4a7848a8bfcb2168d932ab4b48e962","user":{"login":"deepu105","id":1107223,"avatar_url":"https://avatars2.githubusercontent.com/u/1107223?v=4","gravatar_id":"","url":"https://api.github.com/users/deepu105","html_url":"https://github.com/deepu105","followers_url":"https://api.github.com/users/deepu105/followers","following_url":"https://api.github.com/users/deepu105/following{/other_user}","gists_url":"https://api.github.com/users/deepu105/gists{/gist_id}","starred_url":"https://api.github.com/users/deepu105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepu105/subscriptions","organizations_url":"https://api.github.com/users/deepu105/orgs","repos_url":"https://api.github.com/users/deepu105/repos","events_url":"https://api.github.com/users/deepu105/events{/privacy}","received_events_url":"https://api.github.com/users/deepu105/received_events","type":"User","site_admin":false},"body":"Therebis nonspecs under page objects, only tests should be here","created_at":"2018-04-12T06:35:21Z","updated_at":"2018-04-12T06:41:11Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/7469#discussion_r180976980","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7469","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/180976980"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/7469#discussion_r180976980"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7469"}}},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7469","id":180952378,"html_url":"https://github.com/jhipster/generator-jhipster/pull/7469","diff_url":"https://github.com/jhipster/generator-jhipster/pull/7469.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/7469.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7469","number":7469,"state":"open","locked":false,"title":"Add React end-to-end tests","user":{"login":"chrisdns","id":17642361,"avatar_url":"https://avatars2.githubusercontent.com/u/17642361?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdns","html_url":"https://github.com/chrisdns","followers_url":"https://api.github.com/users/chrisdns/followers","following_url":"https://api.github.com/users/chrisdns/following{/other_user}","gists_url":"https://api.github.com/users/chrisdns/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdns/subscriptions","organizations_url":"https://api.github.com/users/chrisdns/orgs","repos_url":"https://api.github.com/users/chrisdns/repos","events_url":"https://api.github.com/users/chrisdns/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdns/received_events","type":"User","site_admin":false},"body":"- Please make sure the below checklist is followed for Pull Requests.\r\n\r\n- [ ] [Travis tests](https://travis-ci.org/jhipster/generator-jhipster/pull_requests) are green\r\n- [x] Tests are added where necessary\r\n- [x] Documentation is added/updated where necessary\r\n- [x] Coding Rules & Commit Guidelines as per our [CONTRIBUTING.md document](https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md) are followed\r\n- [ ] Fix i18n troubles\r\n- [ ] Standardize React notification system (set toasts everywhere) in order to e2e test properly\r\n- [ ] Add more tests\r\n\r\nThere is also some troubles with tslint rule saying\r\n> unused expression, expected an assignment or function call\r\n\r\nwhich appear with these kind of code : `expect(foo).to.be.true`\r\nThis rule should be disabled when using chai.\r\n\r\n \r\n","created_at":"2018-04-11T15:59:43Z","updated_at":"2018-04-12T06:41:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fac3f6a3e8329e441eccdd37f01f09d5076f6f30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7469/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7469/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7469/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/c68ae3ab6d4a7848a8bfcb2168d932ab4b48e962","head":{"label":"chrisdns:react-e2e-tests","ref":"react-e2e-tests","sha":"c68ae3ab6d4a7848a8bfcb2168d932ab4b48e962","user":{"login":"chrisdns","id":17642361,"avatar_url":"https://avatars2.githubusercontent.com/u/17642361?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdns","html_url":"https://github.com/chrisdns","followers_url":"https://api.github.com/users/chrisdns/followers","following_url":"https://api.github.com/users/chrisdns/following{/other_user}","gists_url":"https://api.github.com/users/chrisdns/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdns/subscriptions","organizations_url":"https://api.github.com/users/chrisdns/orgs","repos_url":"https://api.github.com/users/chrisdns/repos","events_url":"https://api.github.com/users/chrisdns/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdns/received_events","type":"User","site_admin":false},"repo":{"id":121487798,"name":"generator-jhipster","full_name":"chrisdns/generator-jhipster","owner":{"login":"chrisdns","id":17642361,"avatar_url":"https://avatars2.githubusercontent.com/u/17642361?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdns","html_url":"https://github.com/chrisdns","followers_url":"https://api.github.com/users/chrisdns/followers","following_url":"https://api.github.com/users/chrisdns/following{/other_user}","gists_url":"https://api.github.com/users/chrisdns/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdns/subscriptions","organizations_url":"https://api.github.com/users/chrisdns/orgs","repos_url":"https://api.github.com/users/chrisdns/repos","events_url":"https://api.github.com/users/chrisdns/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisdns/generator-jhipster","description":"Open Source application generator for creating Spring Boot + Angular projects in seconds!","fork":true,"url":"https://api.github.com/repos/chrisdns/generator-jhipster","forks_url":"https://api.github.com/repos/chrisdns/generator-jhipster/forks","keys_url":"https://api.github.com/repos/chrisdns/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisdns/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisdns/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/chrisdns/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/chrisdns/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/chrisdns/generator-jhipster/events","assignees_url":"https://api.github.com/repos/chrisdns/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/chrisdns/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/chrisdns/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/chrisdns/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisdns/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisdns/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisdns/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisdns/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisdns/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/chrisdns/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/chrisdns/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/chrisdns/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/chrisdns/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/chrisdns/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisdns/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisdns/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisdns/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisdns/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/chrisdns/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisdns/generator-jhipster/merges","archive_url":"https://api.github.com/repos/chrisdns/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisdns/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/chrisdns/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/chrisdns/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisdns/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisdns/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisdns/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/chrisdns/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/chrisdns/generator-jhipster/deployments","created_at":"2018-02-14T08:31:30Z","updated_at":"2018-04-11T08:57:26Z","pushed_at":"2018-04-11T15:35:54Z","git_url":"git://github.com/chrisdns/generator-jhipster.git","ssh_url":"git@github.com:chrisdns/generator-jhipster.git","clone_url":"https://github.com/chrisdns/generator-jhipster.git","svn_url":"https://github.com/chrisdns/generator-jhipster","homepage":"http://www.jhipster.tech","size":30311,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"3ac4037833b4b2e6b4d811c50f4587b2798565a4","user":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars3.githubusercontent.com/u/6059488?v=4","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars3.githubusercontent.com/u/6059488?v=4","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Open Source application generator for creating Spring Boot + Angular/React projects in seconds!","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2018-04-12T06:32:19Z","pushed_at":"2018-04-11T15:59:44Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"https://www.jhipster.tech","size":30287,"stargazers_count":10078,"watchers_count":10078,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2208,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2208,"open_issues":53,"watchers":10078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7469"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/7469"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7469"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7469/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7469/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7469/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/c68ae3ab6d4a7848a8bfcb2168d932ab4b48e962"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deepu105"}}