{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/200001697","pull_request_review_id":134229789,"id":200001697,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDAwMTY5Nw==","diff_hunk":"@@ -77,6 +77,42 @@ func TestGateway_HTTPIngress(t *testing.T) {\n \t})\n }\n \n+func TestGateway_HTTPSIngress(t *testing.T) {\n+\tif !tc.V1alpha3 {\n+\t\tt.Skipf(\"Skipping %s: v1alpha3=false\", t.Name())\n+\t}\n+\n+\tistioNamespace := tc.Kube.IstioSystemNamespace()\n+\tingressGatewayServiceName := tc.Kube.IstioIngressGatewayService()\n+\n+\t// Configure a route from us.bookinfo.com to \"c-v2\" only\n+\tcfgs := &deployableConfig{\n+\t\tNamespace: tc.Kube.Namespace,\n+\t\tYamlFiles: []string{\n+\t\t\t\"testdata/v1alpha3/ingressgateway.yaml\",\n+\t\t\t\"testdata/v1alpha3/destination-rule-c.yaml\",\n+\t\t\t\"testdata/v1alpha3/rule-ingressgateway.yaml\"},\n+\t}\n+\tif err := cfgs.Setup(); err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\tdefer cfgs.Teardown()\n+\n+\trunRetriableTest(t, \"VersionRouting\", defaultRetryBudget, func() error {\n+\t\treqURL := fmt.Sprintf(\"https://%s.%s:443/c\", ingressGatewayServiceName, istioNamespace)","path":"tests/e2e/tests/pilot/ingressgateway_test.go","position":26,"original_position":26,"commit_id":"d8b9bb14b8d50a06976ede0e6122773f021dd121","original_commit_id":"d8b9bb14b8d50a06976ede0e6122773f021dd121","user":{"login":"vadimeisenbergibm","id":16784982,"node_id":"MDQ6VXNlcjE2Nzg0OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/16784982?v=4","gravatar_id":"","url":"https://api.github.com/users/vadimeisenbergibm","html_url":"https://github.com/vadimeisenbergibm","followers_url":"https://api.github.com/users/vadimeisenbergibm/followers","following_url":"https://api.github.com/users/vadimeisenbergibm/following{/other_user}","gists_url":"https://api.github.com/users/vadimeisenbergibm/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimeisenbergibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimeisenbergibm/subscriptions","organizations_url":"https://api.github.com/users/vadimeisenbergibm/orgs","repos_url":"https://api.github.com/users/vadimeisenbergibm/repos","events_url":"https://api.github.com/users/vadimeisenbergibm/events{/privacy}","received_events_url":"https://api.github.com/users/vadimeisenbergibm/received_events","type":"User","site_admin":false},"body":"@cmluciano Sorry, I missed your question. In the real life, the users will have the _httbin.example.com_ hostname allocated to their cluster. The users will not have to use `--resolve` option. Since in our case, in the test environment, _httpbin.example.com_ is a fake domain name, we have to use `--resolve` option. So it is \"a usability issue\" in tests environments only, which is OK in my opinion.","created_at":"2018-07-04T03:45:27Z","updated_at":"2018-07-04T03:45:27Z","html_url":"https://github.com/istio/istio/pull/5547#discussion_r200001697","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/5547","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/200001697"},"html":{"href":"https://github.com/istio/istio/pull/5547#discussion_r200001697"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/5547"}},"in_reply_to_id":192478267},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5547","id":187303800,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3MzAzODAw","html_url":"https://github.com/istio/istio/pull/5547","diff_url":"https://github.com/istio/istio/pull/5547.diff","patch_url":"https://github.com/istio/istio/pull/5547.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/5547","number":5547,"state":"closed","locked":false,"title":"WIP: test GatewayHTTPS","user":{"login":"cmluciano","id":4790487,"node_id":"MDQ6VXNlcjQ3OTA0ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/4790487?v=4","gravatar_id":"","url":"https://api.github.com/users/cmluciano","html_url":"https://github.com/cmluciano","followers_url":"https://api.github.com/users/cmluciano/followers","following_url":"https://api.github.com/users/cmluciano/following{/other_user}","gists_url":"https://api.github.com/users/cmluciano/gists{/gist_id}","starred_url":"https://api.github.com/users/cmluciano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmluciano/subscriptions","organizations_url":"https://api.github.com/users/cmluciano/orgs","repos_url":"https://api.github.com/users/cmluciano/repos","events_url":"https://api.github.com/users/cmluciano/events{/privacy}","received_events_url":"https://api.github.com/users/cmluciano/received_events","type":"User","site_admin":false},"body":"fixes #5642 ","created_at":"2018-05-10T20:50:57Z","updated_at":"2018-07-04T03:45:27Z","closed_at":"2018-07-04T00:43:24Z","merged_at":null,"merge_commit_sha":"e8d2a022109faaedad9df9e2b1b60b738b63376f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"frankbu","id":2752495,"node_id":"MDQ6VXNlcjI3NTI0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752495?v=4","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":971613641,"node_id":"MDU6TGFiZWw5NzE2MTM2NDE=","url":"https://api.github.com/repos/istio/istio/labels/stale","name":"stale","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/5547/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/5547/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/5547/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/d8b9bb14b8d50a06976ede0e6122773f021dd121","head":{"label":"cmluciano:cml/gatewayhttps","ref":"cml/gatewayhttps","sha":"d8b9bb14b8d50a06976ede0e6122773f021dd121","user":{"login":"cmluciano","id":4790487,"node_id":"MDQ6VXNlcjQ3OTA0ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/4790487?v=4","gravatar_id":"","url":"https://api.github.com/users/cmluciano","html_url":"https://github.com/cmluciano","followers_url":"https://api.github.com/users/cmluciano/followers","following_url":"https://api.github.com/users/cmluciano/following{/other_user}","gists_url":"https://api.github.com/users/cmluciano/gists{/gist_id}","starred_url":"https://api.github.com/users/cmluciano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmluciano/subscriptions","organizations_url":"https://api.github.com/users/cmluciano/orgs","repos_url":"https://api.github.com/users/cmluciano/repos","events_url":"https://api.github.com/users/cmluciano/events{/privacy}","received_events_url":"https://api.github.com/users/cmluciano/received_events","type":"User","site_admin":false},"repo":{"id":99718766,"node_id":"MDEwOlJlcG9zaXRvcnk5OTcxODc2Ng==","name":"istio","full_name":"cmluciano/istio","owner":{"login":"cmluciano","id":4790487,"node_id":"MDQ6VXNlcjQ3OTA0ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/4790487?v=4","gravatar_id":"","url":"https://api.github.com/users/cmluciano","html_url":"https://github.com/cmluciano","followers_url":"https://api.github.com/users/cmluciano/followers","following_url":"https://api.github.com/users/cmluciano/following{/other_user}","gists_url":"https://api.github.com/users/cmluciano/gists{/gist_id}","starred_url":"https://api.github.com/users/cmluciano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmluciano/subscriptions","organizations_url":"https://api.github.com/users/cmluciano/orgs","repos_url":"https://api.github.com/users/cmluciano/repos","events_url":"https://api.github.com/users/cmluciano/events{/privacy}","received_events_url":"https://api.github.com/users/cmluciano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmluciano/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":true,"url":"https://api.github.com/repos/cmluciano/istio","forks_url":"https://api.github.com/repos/cmluciano/istio/forks","keys_url":"https://api.github.com/repos/cmluciano/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmluciano/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmluciano/istio/teams","hooks_url":"https://api.github.com/repos/cmluciano/istio/hooks","issue_events_url":"https://api.github.com/repos/cmluciano/istio/issues/events{/number}","events_url":"https://api.github.com/repos/cmluciano/istio/events","assignees_url":"https://api.github.com/repos/cmluciano/istio/assignees{/user}","branches_url":"https://api.github.com/repos/cmluciano/istio/branches{/branch}","tags_url":"https://api.github.com/repos/cmluciano/istio/tags","blobs_url":"https://api.github.com/repos/cmluciano/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmluciano/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmluciano/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmluciano/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmluciano/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/cmluciano/istio/languages","stargazers_url":"https://api.github.com/repos/cmluciano/istio/stargazers","contributors_url":"https://api.github.com/repos/cmluciano/istio/contributors","subscribers_url":"https://api.github.com/repos/cmluciano/istio/subscribers","subscription_url":"https://api.github.com/repos/cmluciano/istio/subscription","commits_url":"https://api.github.com/repos/cmluciano/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmluciano/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmluciano/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmluciano/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmluciano/istio/contents/{+path}","compare_url":"https://api.github.com/repos/cmluciano/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmluciano/istio/merges","archive_url":"https://api.github.com/repos/cmluciano/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmluciano/istio/downloads","issues_url":"https://api.github.com/repos/cmluciano/istio/issues{/number}","pulls_url":"https://api.github.com/repos/cmluciano/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/cmluciano/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/cmluciano/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmluciano/istio/labels{/name}","releases_url":"https://api.github.com/repos/cmluciano/istio/releases{/id}","deployments_url":"https://api.github.com/repos/cmluciano/istio/deployments","created_at":"2017-08-08T17:26:10Z","updated_at":"2018-06-05T15:17:27Z","pushed_at":"2018-06-21T19:27:35Z","git_url":"git://github.com/cmluciano/istio.git","ssh_url":"git@github.com:cmluciano/istio.git","clone_url":"https://github.com/cmluciano/istio.git","svn_url":"https://github.com/cmluciano/istio","homepage":"https://istio.io","size":120635,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-0.8","ref":"release-0.8","sha":"6f9f420f0c7119ff4fa6a1966a6f6d89b1b4db84","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-07-04T03:30:02Z","pushed_at":"2018-07-04T01:28:50Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":40898,"stargazers_count":9063,"watchers_count":9063,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1248,"mirror_url":null,"archived":false,"open_issues_count":814,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1248,"open_issues":814,"watchers":9063,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/5547"},"html":{"href":"https://github.com/istio/istio/pull/5547"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/5547"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/5547/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/5547/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/5547/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/d8b9bb14b8d50a06976ede0e6122773f021dd121"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vadimeisenbergibm"}}