{"action":"created","comment":{"url":"https://api.github.com/repos/cmu-db/terrier/pulls/comments/211580343","pull_request_review_id":147872434,"id":211580343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU4MDM0Mw==","diff_hunk":"@@ -0,0 +1,273 @@\n+#pragma once\n+#include <vector>\n+#include \"common/macros.h\"\n+#include \"storage/storage_defs.h\"\n+\n+namespace terrier::storage {\n+// TODO(Tianyu): Align the values\n+/**\n+ * A projected row is a partial row image of a tuple. It also encodes\n+ * a projection list that allows for reordering of the columns. Its in-memory\n+ * layout:\n+ * -------------------------------------------------------------------------------\n+ * | size | num_cols | col_id1 | col_id2 | ... | val1_offset | val2_offset | ... |\n+ * -------------------------------------------------------------------------------\n+ * | null-bitmap (pad up to byte) | val1 | val2 | ...                            |\n+ * -------------------------------------------------------------------------------\n+ * Warning, 0 means null in the null-bitmap\n+ *\n+ * The projection list is encoded as position of col_id -> col_id. For example:\n+ *\n+ * --------------------------------------------------------\n+ * | 36 | 3 | 1 | 0 | 2 | 0 | 4 | 8 | 0xC0 | 721 | 15 | x |\n+ * --------------------------------------------------------\n+ * Would be the row: { 0 -> 15, 1 -> 721, 2 -> nul}\n+ */\n+// TODO(Tianyu): The PACKED directive here is not necessary, but C++ does some weird thing where\n+// it will pad sizeof(ProjectedRow) to 8 but the varlen content still points at 6. This should not\n+// break any code, but the padding no will be immediately before the values instead of after num_cols,","path":"src/include/storage/delta_record.h","position":28,"original_position":28,"commit_id":"96050c22bdbd9de652e755a3569d05c80392272f","original_commit_id":"96050c22bdbd9de652e755a3569d05c80392272f","user":{"login":"mbutrovich","id":6855576,"node_id":"MDQ6VXNlcjY4NTU1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6855576?v=4","gravatar_id":"","url":"https://api.github.com/users/mbutrovich","html_url":"https://github.com/mbutrovich","followers_url":"https://api.github.com/users/mbutrovich/followers","following_url":"https://api.github.com/users/mbutrovich/following{/other_user}","gists_url":"https://api.github.com/users/mbutrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mbutrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbutrovich/subscriptions","organizations_url":"https://api.github.com/users/mbutrovich/orgs","repos_url":"https://api.github.com/users/mbutrovich/repos","events_url":"https://api.github.com/users/mbutrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mbutrovich/received_events","type":"User","site_admin":false},"body":"typo on \"no\" instead of \"now\"?","created_at":"2018-08-21T12:09:51Z","updated_at":"2018-08-21T13:00:04Z","html_url":"https://github.com/cmu-db/terrier/pull/123#discussion_r211580343","pull_request_url":"https://api.github.com/repos/cmu-db/terrier/pulls/123","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/comments/211580343"},"html":{"href":"https://github.com/cmu-db/terrier/pull/123#discussion_r211580343"},"pull_request":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/cmu-db/terrier/pulls/123","id":209661009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjYxMDA5","html_url":"https://github.com/cmu-db/terrier/pull/123","diff_url":"https://github.com/cmu-db/terrier/pull/123.diff","patch_url":"https://github.com/cmu-db/terrier/pull/123.patch","issue_url":"https://api.github.com/repos/cmu-db/terrier/issues/123","number":123,"state":"open","locked":false,"title":"Break StorageDef, move some implementation to .cpp, and documentation for testing framework","user":{"login":"tli2","id":12805799,"node_id":"MDQ6VXNlcjEyODA1Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/12805799?v=4","gravatar_id":"","url":"https://api.github.com/users/tli2","html_url":"https://github.com/tli2","followers_url":"https://api.github.com/users/tli2/followers","following_url":"https://api.github.com/users/tli2/following{/other_user}","gists_url":"https://api.github.com/users/tli2/gists{/gist_id}","starred_url":"https://api.github.com/users/tli2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tli2/subscriptions","organizations_url":"https://api.github.com/users/tli2/orgs","repos_url":"https://api.github.com/users/tli2/repos","events_url":"https://api.github.com/users/tli2/events{/privacy}","received_events_url":"https://api.github.com/users/tli2/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-20T22:28:41Z","updated_at":"2018-08-21T13:00:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23bbbd6436ff28a70ce549be815013518edf488a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1010453444,"node_id":"MDU6TGFiZWwxMDEwNDUzNDQ0","url":"https://api.github.com/repos/cmu-db/terrier/labels/best-practice","name":"best-practice","color":"c2e0c6","default":false},{"id":1010451271,"node_id":"MDU6TGFiZWwxMDEwNDUxMjcx","url":"https://api.github.com/repos/cmu-db/terrier/labels/ready-for-review","name":"ready-for-review","color":"76b726","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cmu-db/terrier/pulls/123/commits","review_comments_url":"https://api.github.com/repos/cmu-db/terrier/pulls/123/comments","review_comment_url":"https://api.github.com/repos/cmu-db/terrier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmu-db/terrier/issues/123/comments","statuses_url":"https://api.github.com/repos/cmu-db/terrier/statuses/96050c22bdbd9de652e755a3569d05c80392272f","head":{"label":"cmu-db:tianyu-cleanup","ref":"tianyu-cleanup","sha":"96050c22bdbd9de652e755a3569d05c80392272f","user":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":140325970,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMjU5NzA=","name":"terrier","full_name":"cmu-db/terrier","owner":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/terrier","description":"You know what this is...","fork":false,"url":"https://api.github.com/repos/cmu-db/terrier","forks_url":"https://api.github.com/repos/cmu-db/terrier/forks","keys_url":"https://api.github.com/repos/cmu-db/terrier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/terrier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/terrier/teams","hooks_url":"https://api.github.com/repos/cmu-db/terrier/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/terrier/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/terrier/events","assignees_url":"https://api.github.com/repos/cmu-db/terrier/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/terrier/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/terrier/tags","blobs_url":"https://api.github.com/repos/cmu-db/terrier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/terrier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/terrier/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/terrier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/terrier/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/terrier/languages","stargazers_url":"https://api.github.com/repos/cmu-db/terrier/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/terrier/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/terrier/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/terrier/subscription","commits_url":"https://api.github.com/repos/cmu-db/terrier/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/terrier/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/terrier/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/terrier/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/terrier/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/terrier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/terrier/merges","archive_url":"https://api.github.com/repos/cmu-db/terrier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/terrier/downloads","issues_url":"https://api.github.com/repos/cmu-db/terrier/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/terrier/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/terrier/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/terrier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/terrier/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/terrier/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/terrier/deployments","created_at":"2018-07-09T18:22:34Z","updated_at":"2018-08-21T00:32:29Z","pushed_at":"2018-08-21T02:49:47Z","git_url":"git://github.com/cmu-db/terrier.git","ssh_url":"git@github.com:cmu-db/terrier.git","clone_url":"https://github.com/cmu-db/terrier.git","svn_url":"https://github.com/cmu-db/terrier","homepage":null,"size":1068,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":18,"watchers":2,"default_branch":"master"}},"base":{"label":"cmu-db:master","ref":"master","sha":"25e1ed6951932f1413ed4ea08f8c8ef953cbdbc1","user":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":140325970,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMjU5NzA=","name":"terrier","full_name":"cmu-db/terrier","owner":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/terrier","description":"You know what this is...","fork":false,"url":"https://api.github.com/repos/cmu-db/terrier","forks_url":"https://api.github.com/repos/cmu-db/terrier/forks","keys_url":"https://api.github.com/repos/cmu-db/terrier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/terrier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/terrier/teams","hooks_url":"https://api.github.com/repos/cmu-db/terrier/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/terrier/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/terrier/events","assignees_url":"https://api.github.com/repos/cmu-db/terrier/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/terrier/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/terrier/tags","blobs_url":"https://api.github.com/repos/cmu-db/terrier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/terrier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/terrier/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/terrier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/terrier/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/terrier/languages","stargazers_url":"https://api.github.com/repos/cmu-db/terrier/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/terrier/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/terrier/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/terrier/subscription","commits_url":"https://api.github.com/repos/cmu-db/terrier/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/terrier/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/terrier/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/terrier/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/terrier/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/terrier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/terrier/merges","archive_url":"https://api.github.com/repos/cmu-db/terrier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/terrier/downloads","issues_url":"https://api.github.com/repos/cmu-db/terrier/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/terrier/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/terrier/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/terrier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/terrier/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/terrier/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/terrier/deployments","created_at":"2018-07-09T18:22:34Z","updated_at":"2018-08-21T00:32:29Z","pushed_at":"2018-08-21T02:49:47Z","git_url":"git://github.com/cmu-db/terrier.git","ssh_url":"git@github.com:cmu-db/terrier.git","clone_url":"https://github.com/cmu-db/terrier.git","svn_url":"https://github.com/cmu-db/terrier","homepage":null,"size":1068,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":18,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/123"},"html":{"href":"https://github.com/cmu-db/terrier/pull/123"},"issue":{"href":"https://api.github.com/repos/cmu-db/terrier/issues/123"},"comments":{"href":"https://api.github.com/repos/cmu-db/terrier/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/cmu-db/terrier/statuses/96050c22bdbd9de652e755a3569d05c80392272f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mbutrovich"}}