{"action":"closed","number":588,"pull_request":{"url":"https://api.github.com/repos/jknack/handlebars.java/pulls/588","id":125355245,"html_url":"https://github.com/jknack/handlebars.java/pull/588","diff_url":"https://github.com/jknack/handlebars.java/pull/588.diff","patch_url":"https://github.com/jknack/handlebars.java/pull/588.patch","issue_url":"https://api.github.com/repos/jknack/handlebars.java/issues/588","number":588,"state":"closed","locked":false,"title":"Massive performance improvement","user":{"login":"DannyReinhold","id":29073540,"avatar_url":"https://avatars1.githubusercontent.com/u/29073540?v=4","gravatar_id":"","url":"https://api.github.com/users/DannyReinhold","html_url":"https://github.com/DannyReinhold","followers_url":"https://api.github.com/users/DannyReinhold/followers","following_url":"https://api.github.com/users/DannyReinhold/following{/other_user}","gists_url":"https://api.github.com/users/DannyReinhold/gists{/gist_id}","starred_url":"https://api.github.com/users/DannyReinhold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DannyReinhold/subscriptions","organizations_url":"https://api.github.com/users/DannyReinhold/orgs","repos_url":"https://api.github.com/users/DannyReinhold/repos","events_url":"https://api.github.com/users/DannyReinhold/events{/privacy}","received_events_url":"https://api.github.com/users/DannyReinhold/received_events","type":"User","site_admin":false},"body":"Handlebars.java evaluates partial blocks before the actual partials are evaluated and rendered. This is a feature to allow context modifications like so:\r\n\r\n\"{{#> myPartial}}{{#*inline 'myInline'}}Wow!!!{{/inline}}{{/myPartial}}\"\r\nAnd with a template myPartial.hbs like so\r\n\"{{> myInline}}\"\r\nyou actually see the \"Wow!!!\" text.\r\n\r\nThis pre evaluation slows down the performance of handlebars.java significantly if deeply nested partial blocks are used. And I also think this is more or less unexpected behaviour (although it is compatible with handlebars.js).\r\n\r\nWith this commit you can control if this pre evaluation takes place or not. Without the pre evaluation the rendering process gets *much* faster!\r\n\r\nYou can still call \"myPartial\" as in the example above.\r\nBut myPartial.hbs now has to evaluate the partial block explicitly like so:\r\n\"{{> @partial-block}}{{> myInline}}\"\r\n\r\nA tiny change that makes a huge performance difference.\r\n\r\nOf course there is a flag to control the behavior. If Handlebars::preEvaluatePartialBlocks is true (default) everythig is as you know it. If preEvaluatePartialBlocks is set to false, partial blocks are only evaluated (and rendered) when there is a {{> @partial-block}} and the rendering process is *much* faster.","created_at":"2017-06-13T12:50:07Z","updated_at":"2018-05-24T16:14:34Z","closed_at":"2018-05-24T16:14:34Z","merged_at":null,"merge_commit_sha":"28f4cd05194d2b9e0f750b7b77c73c23e0b66677","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":5812434,"url":"https://api.github.com/repos/jknack/handlebars.java/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/jknack/handlebars.java/milestones/48","html_url":"https://github.com/jknack/handlebars.java/milestone/48","labels_url":"https://api.github.com/repos/jknack/handlebars.java/milestones/48/labels","id":1984035,"number":48,"title":"4.0.7","description":"","creator":{"login":"jknack","id":1301129,"avatar_url":"https://avatars0.githubusercontent.com/u/1301129?v=4","gravatar_id":"","url":"https://api.github.com/users/jknack","html_url":"https://github.com/jknack","followers_url":"https://api.github.com/users/jknack/followers","following_url":"https://api.github.com/users/jknack/following{/other_user}","gists_url":"https://api.github.com/users/jknack/gists{/gist_id}","starred_url":"https://api.github.com/users/jknack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknack/subscriptions","organizations_url":"https://api.github.com/users/jknack/orgs","repos_url":"https://api.github.com/users/jknack/repos","events_url":"https://api.github.com/users/jknack/events{/privacy}","received_events_url":"https://api.github.com/users/jknack/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":12,"state":"open","created_at":"2016-09-05T12:01:30Z","updated_at":"2018-05-24T16:14:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jknack/handlebars.java/pulls/588/commits","review_comments_url":"https://api.github.com/repos/jknack/handlebars.java/pulls/588/comments","review_comment_url":"https://api.github.com/repos/jknack/handlebars.java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jknack/handlebars.java/issues/588/comments","statuses_url":"https://api.github.com/repos/jknack/handlebars.java/statuses/b711a96b6b979d7fac0cdb9b9f92fc664ced6215","head":{"label":"DannyReinhold:master","ref":"master","sha":"b711a96b6b979d7fac0cdb9b9f92fc664ced6215","user":{"login":"DannyReinhold","id":29073540,"avatar_url":"https://avatars1.githubusercontent.com/u/29073540?v=4","gravatar_id":"","url":"https://api.github.com/users/DannyReinhold","html_url":"https://github.com/DannyReinhold","followers_url":"https://api.github.com/users/DannyReinhold/followers","following_url":"https://api.github.com/users/DannyReinhold/following{/other_user}","gists_url":"https://api.github.com/users/DannyReinhold/gists{/gist_id}","starred_url":"https://api.github.com/users/DannyReinhold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DannyReinhold/subscriptions","organizations_url":"https://api.github.com/users/DannyReinhold/orgs","repos_url":"https://api.github.com/users/DannyReinhold/repos","events_url":"https://api.github.com/users/DannyReinhold/events{/privacy}","received_events_url":"https://api.github.com/users/DannyReinhold/received_events","type":"User","site_admin":false},"repo":{"id":92924073,"name":"handlebars.java","full_name":"DannyReinhold/handlebars.java","owner":{"login":"DannyReinhold","id":29073540,"avatar_url":"https://avatars1.githubusercontent.com/u/29073540?v=4","gravatar_id":"","url":"https://api.github.com/users/DannyReinhold","html_url":"https://github.com/DannyReinhold","followers_url":"https://api.github.com/users/DannyReinhold/followers","following_url":"https://api.github.com/users/DannyReinhold/following{/other_user}","gists_url":"https://api.github.com/users/DannyReinhold/gists{/gist_id}","starred_url":"https://api.github.com/users/DannyReinhold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DannyReinhold/subscriptions","organizations_url":"https://api.github.com/users/DannyReinhold/orgs","repos_url":"https://api.github.com/users/DannyReinhold/repos","events_url":"https://api.github.com/users/DannyReinhold/events{/privacy}","received_events_url":"https://api.github.com/users/DannyReinhold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DannyReinhold/handlebars.java","description":"Logic-less and semantic Mustache templates with Java","fork":true,"url":"https://api.github.com/repos/DannyReinhold/handlebars.java","forks_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/forks","keys_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/teams","hooks_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/hooks","issue_events_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/issues/events{/number}","events_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/events","assignees_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/assignees{/user}","branches_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/branches{/branch}","tags_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/tags","blobs_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/statuses/{sha}","languages_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/languages","stargazers_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/stargazers","contributors_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/contributors","subscribers_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/subscribers","subscription_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/subscription","commits_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/issues/comments{/number}","contents_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/contents/{+path}","compare_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/merges","archive_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/downloads","issues_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/issues{/number}","pulls_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/pulls{/number}","milestones_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/milestones{/number}","notifications_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/labels{/name}","releases_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/releases{/id}","deployments_url":"https://api.github.com/repos/DannyReinhold/handlebars.java/deployments","created_at":"2017-05-31T08:36:42Z","updated_at":"2017-05-31T08:36:44Z","pushed_at":"2018-01-23T16:03:09Z","git_url":"git://github.com/DannyReinhold/handlebars.java.git","ssh_url":"git@github.com:DannyReinhold/handlebars.java.git","clone_url":"https://github.com/DannyReinhold/handlebars.java.git","svn_url":"https://github.com/DannyReinhold/handlebars.java","homepage":"http://jknack.github.io/handlebars.java","size":3301,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jknack:master","ref":"master","sha":"1f6c48e606dc1303d1e92a0a0eaa94120eba64fd","user":{"login":"jknack","id":1301129,"avatar_url":"https://avatars0.githubusercontent.com/u/1301129?v=4","gravatar_id":"","url":"https://api.github.com/users/jknack","html_url":"https://github.com/jknack","followers_url":"https://api.github.com/users/jknack/followers","following_url":"https://api.github.com/users/jknack/following{/other_user}","gists_url":"https://api.github.com/users/jknack/gists{/gist_id}","starred_url":"https://api.github.com/users/jknack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknack/subscriptions","organizations_url":"https://api.github.com/users/jknack/orgs","repos_url":"https://api.github.com/users/jknack/repos","events_url":"https://api.github.com/users/jknack/events{/privacy}","received_events_url":"https://api.github.com/users/jknack/received_events","type":"User","site_admin":false},"repo":{"id":4459604,"name":"handlebars.java","full_name":"jknack/handlebars.java","owner":{"login":"jknack","id":1301129,"avatar_url":"https://avatars0.githubusercontent.com/u/1301129?v=4","gravatar_id":"","url":"https://api.github.com/users/jknack","html_url":"https://github.com/jknack","followers_url":"https://api.github.com/users/jknack/followers","following_url":"https://api.github.com/users/jknack/following{/other_user}","gists_url":"https://api.github.com/users/jknack/gists{/gist_id}","starred_url":"https://api.github.com/users/jknack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknack/subscriptions","organizations_url":"https://api.github.com/users/jknack/orgs","repos_url":"https://api.github.com/users/jknack/repos","events_url":"https://api.github.com/users/jknack/events{/privacy}","received_events_url":"https://api.github.com/users/jknack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jknack/handlebars.java","description":"Logic-less and semantic Mustache templates with Java","fork":false,"url":"https://api.github.com/repos/jknack/handlebars.java","forks_url":"https://api.github.com/repos/jknack/handlebars.java/forks","keys_url":"https://api.github.com/repos/jknack/handlebars.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jknack/handlebars.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jknack/handlebars.java/teams","hooks_url":"https://api.github.com/repos/jknack/handlebars.java/hooks","issue_events_url":"https://api.github.com/repos/jknack/handlebars.java/issues/events{/number}","events_url":"https://api.github.com/repos/jknack/handlebars.java/events","assignees_url":"https://api.github.com/repos/jknack/handlebars.java/assignees{/user}","branches_url":"https://api.github.com/repos/jknack/handlebars.java/branches{/branch}","tags_url":"https://api.github.com/repos/jknack/handlebars.java/tags","blobs_url":"https://api.github.com/repos/jknack/handlebars.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jknack/handlebars.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jknack/handlebars.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/jknack/handlebars.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jknack/handlebars.java/statuses/{sha}","languages_url":"https://api.github.com/repos/jknack/handlebars.java/languages","stargazers_url":"https://api.github.com/repos/jknack/handlebars.java/stargazers","contributors_url":"https://api.github.com/repos/jknack/handlebars.java/contributors","subscribers_url":"https://api.github.com/repos/jknack/handlebars.java/subscribers","subscription_url":"https://api.github.com/repos/jknack/handlebars.java/subscription","commits_url":"https://api.github.com/repos/jknack/handlebars.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/jknack/handlebars.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/jknack/handlebars.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/jknack/handlebars.java/issues/comments{/number}","contents_url":"https://api.github.com/repos/jknack/handlebars.java/contents/{+path}","compare_url":"https://api.github.com/repos/jknack/handlebars.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jknack/handlebars.java/merges","archive_url":"https://api.github.com/repos/jknack/handlebars.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jknack/handlebars.java/downloads","issues_url":"https://api.github.com/repos/jknack/handlebars.java/issues{/number}","pulls_url":"https://api.github.com/repos/jknack/handlebars.java/pulls{/number}","milestones_url":"https://api.github.com/repos/jknack/handlebars.java/milestones{/number}","notifications_url":"https://api.github.com/repos/jknack/handlebars.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jknack/handlebars.java/labels{/name}","releases_url":"https://api.github.com/repos/jknack/handlebars.java/releases{/id}","deployments_url":"https://api.github.com/repos/jknack/handlebars.java/deployments","created_at":"2012-05-27T03:22:22Z","updated_at":"2018-05-24T16:10:12Z","pushed_at":"2018-05-24T15:25:24Z","git_url":"git://github.com/jknack/handlebars.java.git","ssh_url":"git@github.com:jknack/handlebars.java.git","clone_url":"https://github.com/jknack/handlebars.java.git","svn_url":"https://github.com/jknack/handlebars.java","homepage":"http://jknack.github.io/handlebars.java","size":3778,"stargazers_count":911,"watchers_count":911,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":270,"open_issues":90,"watchers":911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jknack/handlebars.java/pulls/588"},"html":{"href":"https://github.com/jknack/handlebars.java/pull/588"},"issue":{"href":"https://api.github.com/repos/jknack/handlebars.java/issues/588"},"comments":{"href":"https://api.github.com/repos/jknack/handlebars.java/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/jknack/handlebars.java/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/jknack/handlebars.java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jknack/handlebars.java/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/jknack/handlebars.java/statuses/b711a96b6b979d7fac0cdb9b9f92fc664ced6215"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":540,"deletions":449,"changed_files":15}}
{"actor":{"display_login":"jknack"}}