{"action":"created","issue":{"url":"https://api.github.com/repos/ohmybrew/laravel-shopify/issues/63","repository_url":"https://api.github.com/repos/ohmybrew/laravel-shopify","labels_url":"https://api.github.com/repos/ohmybrew/laravel-shopify/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/ohmybrew/laravel-shopify/issues/63/comments","events_url":"https://api.github.com/repos/ohmybrew/laravel-shopify/issues/63/events","html_url":"https://github.com/ohmybrew/laravel-shopify/issues/63","id":348214245,"node_id":"MDU6SXNzdWUzNDgyMTQyNDU=","number":63,"title":"Free access for partners and Shopify employees","user":{"login":"tobiasdalhof","id":10046578,"node_id":"MDQ6VXNlcjEwMDQ2NTc4","avatar_url":"https://avatars2.githubusercontent.com/u/10046578?v=4","gravatar_id":"","url":"https://api.github.com/users/tobiasdalhof","html_url":"https://github.com/tobiasdalhof","followers_url":"https://api.github.com/users/tobiasdalhof/followers","following_url":"https://api.github.com/users/tobiasdalhof/following{/other_user}","gists_url":"https://api.github.com/users/tobiasdalhof/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasdalhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasdalhof/subscriptions","organizations_url":"https://api.github.com/users/tobiasdalhof/orgs","repos_url":"https://api.github.com/users/tobiasdalhof/repos","events_url":"https://api.github.com/users/tobiasdalhof/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasdalhof/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-07T08:14:25Z","updated_at":"2018-08-08T12:38:07Z","closed_at":null,"author_association":"NONE","body":"What is the best way to enable free access for partners and Shopify employees?\r\n\r\nMy first idea:\r\n```\r\nGET /admin/shop.json\r\n```\r\n\r\nPartners\r\n```php\r\nif ($shop->plan_name === 'affiliate') {\r\n    return $next($request);\r\n}\r\n```\r\n\r\n\r\nShopify employees\r\n```php\r\n// @see https://help.shopify.com/en/api/app-store/being-successful-in-the-app-store/offering-employee-discounts\r\nif ($shop->plan_name === 'staff_business') {\r\n   return $next($request);\r\n}\r\n```\r\n\r\nSo i would need a way to skip or extend the billable middleware and call the shop.json endpoint (and store the plan_name in session?) before the billable middleware.\r\n\r\nShould i add my own billable middleware to `App/Http/Kernel.php`?\r\n\r\n\r\nAny ideas?"},"comment":{"url":"https://api.github.com/repos/ohmybrew/laravel-shopify/issues/comments/411390247","html_url":"https://github.com/ohmybrew/laravel-shopify/issues/63#issuecomment-411390247","issue_url":"https://api.github.com/repos/ohmybrew/laravel-shopify/issues/63","id":411390247,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTM5MDI0Nw==","user":{"login":"ohmybrew","id":2420282,"node_id":"MDQ6VXNlcjI0MjAyODI=","avatar_url":"https://avatars2.githubusercontent.com/u/2420282?v=4","gravatar_id":"","url":"https://api.github.com/users/ohmybrew","html_url":"https://github.com/ohmybrew","followers_url":"https://api.github.com/users/ohmybrew/followers","following_url":"https://api.github.com/users/ohmybrew/following{/other_user}","gists_url":"https://api.github.com/users/ohmybrew/gists{/gist_id}","starred_url":"https://api.github.com/users/ohmybrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohmybrew/subscriptions","organizations_url":"https://api.github.com/users/ohmybrew/orgs","repos_url":"https://api.github.com/users/ohmybrew/repos","events_url":"https://api.github.com/users/ohmybrew/events{/privacy}","received_events_url":"https://api.github.com/users/ohmybrew/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T12:38:07Z","updated_at":"2018-08-08T12:38:07Z","author_association":"OWNER","body":"I like the idea of the events, yes it would keep things not so bloated then\nand give full freedom to the developer. Any recommendations on a simple\nevent system for Laravel? Would rather not roll my own if one exists..\n\nOn Wed., Aug. 8, 2018, 7:31 a.m. Tobias Dalhof, <notifications@github.com>\nwrote:\n\n> Ah, that makes sense...\n>\n> Hmm.. How about adding events to the installation process? Something like\n> BeforeInstallation and AfterInstallation?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/ohmybrew/laravel-shopify/issues/63#issuecomment-411354053>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ACTuOunaeDyQ-x_Wu4Od_5h1gECyJnzsks5uOrb8gaJpZM4VxsT3>\n> .\n>\n"}}
{"actor":{"display_login":"ohmybrew"}}