{"action":"created","issue":{"url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6166","repository_url":"https://api.github.com/repos/galaxyproject/galaxy","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6166/labels{/name}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6166/comments","events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6166/events","html_url":"https://github.com/galaxyproject/galaxy/pull/6166","id":324152464,"number":6166,"title":"[18.05] Pin handsontable to the requested peer dependency","user":{"login":"dannon","id":155398,"avatar_url":"https://avatars2.githubusercontent.com/u/155398?v=4","gravatar_id":"","url":"https://api.github.com/users/dannon","html_url":"https://github.com/dannon","followers_url":"https://api.github.com/users/dannon/followers","following_url":"https://api.github.com/users/dannon/following{/other_user}","gists_url":"https://api.github.com/users/dannon/gists{/gist_id}","starred_url":"https://api.github.com/users/dannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannon/subscriptions","organizations_url":"https://api.github.com/users/dannon/orgs","repos_url":"https://api.github.com/users/dannon/repos","events_url":"https://api.github.com/users/dannon/events{/privacy}","received_events_url":"https://api.github.com/users/dannon/received_events","type":"User","site_admin":false},"labels":[{"id":180024669,"url":"https://api.github.com/repos/galaxyproject/galaxy/labels/kind/bug","name":"kind/bug","color":"84b6eb","default":false},{"id":276566862,"url":"https://api.github.com/repos/galaxyproject/galaxy/labels/status/review","name":"status/review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/10","html_url":"https://github.com/galaxyproject/galaxy/milestone/10","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/10/labels","id":2883981,"number":10,"title":"18.05","description":"","creator":{"login":"martenson","id":1814954,"avatar_url":"https://avatars2.githubusercontent.com/u/1814954?v=4","gravatar_id":"","url":"https://api.github.com/users/martenson","html_url":"https://github.com/martenson","followers_url":"https://api.github.com/users/martenson/followers","following_url":"https://api.github.com/users/martenson/following{/other_user}","gists_url":"https://api.github.com/users/martenson/gists{/gist_id}","starred_url":"https://api.github.com/users/martenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martenson/subscriptions","organizations_url":"https://api.github.com/users/martenson/orgs","repos_url":"https://api.github.com/users/martenson/repos","events_url":"https://api.github.com/users/martenson/events{/privacy}","received_events_url":"https://api.github.com/users/martenson/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":334,"state":"open","created_at":"2017-11-02T15:59:46Z","updated_at":"2018-05-17T19:21:36Z","due_on":"2018-05-01T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-05-17T19:20:40Z","updated_at":"2018-05-17T19:52:16Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6166","html_url":"https://github.com/galaxyproject/galaxy/pull/6166","diff_url":"https://github.com/galaxyproject/galaxy/pull/6166.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/6166.patch"},"body":"Fixes #5978.  Peer dependencies are a little annoying, but we should keep them pinned to the requested versions for compatibility."},"comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments/389988489","html_url":"https://github.com/galaxyproject/galaxy/pull/6166#issuecomment-389988489","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6166","id":389988489,"user":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars0.githubusercontent.com/u/216771?v=4","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T19:52:16Z","updated_at":"2018-05-17T19:52:16Z","author_association":"MEMBER","body":"This downgrades the version of handsontable we are using to an older one right? In the absence of an actual user facing bug I'd prefer to go with the newest version if possible - the warning message is annoying for sure but are we aware of any actual incompatibility that would lead us to believe the older version is better suited? Reviewing https://github.com/handsontable/handsontable/releases/tag/2.0.0 it looks like there are some fine bug fixes in the newer branch and none of the breaking changes are related to features we use.\r\n\r\nIf I published a fork of \"@handsontable/vue\" with a newer peer dependency that made the error message go away would that be any better than just ignoring the message - if yes, that is another route I'd prefer to this so let me know I can do that.\r\n\r\nWe've already done a lot of hands on testing of the current version in the release branch, if you want to downgrade this I feel like dev would be the better place to do it at this point.\r\n\r\n"}}
{"actor":{"display_login":"jmchilton"}}