{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/166440896","pull_request_review_id":94503157,"id":166440896,"diff_hunk":"@@ -25,6 +25,14 @@ rocksdb_compiler_flags = [\n     \"-DTBB\",\n     # Needed to compile in fbcode\n     \"-Wno-expansion-to-defined\",\n+    # Added missing flags from output of build_detect_platform","path":"TARGETS","position":4,"original_position":4,"commit_id":"fa85cfab935b889df47ca5a0dde0c3f1869a70ab","original_commit_id":"3551e5c68a58aeea47eb2d08d97002dc737c420c","user":{"login":"gfosco","id":406732,"avatar_url":"https://avatars2.githubusercontent.com/u/406732?v=4","gravatar_id":"","url":"https://api.github.com/users/gfosco","html_url":"https://github.com/gfosco","followers_url":"https://api.github.com/users/gfosco/followers","following_url":"https://api.github.com/users/gfosco/following{/other_user}","gists_url":"https://api.github.com/users/gfosco/gists{/gist_id}","starred_url":"https://api.github.com/users/gfosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfosco/subscriptions","organizations_url":"https://api.github.com/users/gfosco/orgs","repos_url":"https://api.github.com/users/gfosco/repos","events_url":"https://api.github.com/users/gfosco/events{/privacy}","received_events_url":"https://api.github.com/users/gfosco/received_events","type":"User","site_admin":false},"body":"updated, can I get an approval?","created_at":"2018-02-06T21:03:58Z","updated_at":"2018-02-06T21:03:58Z","html_url":"https://github.com/facebook/rocksdb/pull/3452#discussion_r166440896","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/3452","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/166440896"},"html":{"href":"https://github.com/facebook/rocksdb/pull/3452#discussion_r166440896"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3452"}},"in_reply_to_id":165233719},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/3452","id":166417225,"html_url":"https://github.com/facebook/rocksdb/pull/3452","diff_url":"https://github.com/facebook/rocksdb/pull/3452.diff","patch_url":"https://github.com/facebook/rocksdb/pull/3452.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/3452","number":3452,"state":"open","locked":false,"title":"[fb] Update buckifier and TARGETS","user":{"login":"gfosco","id":406732,"avatar_url":"https://avatars2.githubusercontent.com/u/406732?v=4","gravatar_id":"","url":"https://api.github.com/users/gfosco","html_url":"https://github.com/gfosco","followers_url":"https://api.github.com/users/gfosco/followers","following_url":"https://api.github.com/users/gfosco/following{/other_user}","gists_url":"https://api.github.com/users/gfosco/gists{/gist_id}","starred_url":"https://api.github.com/users/gfosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfosco/subscriptions","organizations_url":"https://api.github.com/users/gfosco/orgs","repos_url":"https://api.github.com/users/gfosco/repos","events_url":"https://api.github.com/users/gfosco/events{/privacy}","received_events_url":"https://api.github.com/users/gfosco/received_events","type":"User","site_admin":false},"body":"Some flags used via make were not applied in the buckifier/targets file, causing some failures to be missed by testing infra ( ie the one fixed by #3434 )","created_at":"2018-02-01T00:53:01Z","updated_at":"2018-02-06T21:03:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45c7f3a05e7ee64905ded26960a1ad0e86aad4c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/3452/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/3452/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/3452/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/fa85cfab935b889df47ca5a0dde0c3f1869a70ab","head":{"label":"gfosco:bucktarg","ref":"bucktarg","sha":"fa85cfab935b889df47ca5a0dde0c3f1869a70ab","user":{"login":"gfosco","id":406732,"avatar_url":"https://avatars2.githubusercontent.com/u/406732?v=4","gravatar_id":"","url":"https://api.github.com/users/gfosco","html_url":"https://github.com/gfosco","followers_url":"https://api.github.com/users/gfosco/followers","following_url":"https://api.github.com/users/gfosco/following{/other_user}","gists_url":"https://api.github.com/users/gfosco/gists{/gist_id}","starred_url":"https://api.github.com/users/gfosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfosco/subscriptions","organizations_url":"https://api.github.com/users/gfosco/orgs","repos_url":"https://api.github.com/users/gfosco/repos","events_url":"https://api.github.com/users/gfosco/events{/privacy}","received_events_url":"https://api.github.com/users/gfosco/received_events","type":"User","site_admin":false},"repo":{"id":117278970,"name":"rocksdb","full_name":"gfosco/rocksdb","owner":{"login":"gfosco","id":406732,"avatar_url":"https://avatars2.githubusercontent.com/u/406732?v=4","gravatar_id":"","url":"https://api.github.com/users/gfosco","html_url":"https://github.com/gfosco","followers_url":"https://api.github.com/users/gfosco/followers","following_url":"https://api.github.com/users/gfosco/following{/other_user}","gists_url":"https://api.github.com/users/gfosco/gists{/gist_id}","starred_url":"https://api.github.com/users/gfosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfosco/subscriptions","organizations_url":"https://api.github.com/users/gfosco/orgs","repos_url":"https://api.github.com/users/gfosco/repos","events_url":"https://api.github.com/users/gfosco/events{/privacy}","received_events_url":"https://api.github.com/users/gfosco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfosco/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/gfosco/rocksdb","forks_url":"https://api.github.com/repos/gfosco/rocksdb/forks","keys_url":"https://api.github.com/repos/gfosco/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfosco/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfosco/rocksdb/teams","hooks_url":"https://api.github.com/repos/gfosco/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/gfosco/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/gfosco/rocksdb/events","assignees_url":"https://api.github.com/repos/gfosco/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/gfosco/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/gfosco/rocksdb/tags","blobs_url":"https://api.github.com/repos/gfosco/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfosco/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfosco/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfosco/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfosco/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/gfosco/rocksdb/languages","stargazers_url":"https://api.github.com/repos/gfosco/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/gfosco/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/gfosco/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/gfosco/rocksdb/subscription","commits_url":"https://api.github.com/repos/gfosco/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfosco/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfosco/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfosco/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfosco/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/gfosco/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfosco/rocksdb/merges","archive_url":"https://api.github.com/repos/gfosco/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfosco/rocksdb/downloads","issues_url":"https://api.github.com/repos/gfosco/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/gfosco/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/gfosco/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/gfosco/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfosco/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/gfosco/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/gfosco/rocksdb/deployments","created_at":"2018-01-12T19:16:05Z","updated_at":"2018-01-12T19:16:11Z","pushed_at":"2018-02-06T00:00:35Z","git_url":"git://github.com/gfosco/rocksdb.git","ssh_url":"git@github.com:gfosco/rocksdb.git","clone_url":"https://github.com/gfosco/rocksdb.git","svn_url":"https://github.com/gfosco/rocksdb","homepage":"http://rocksdb.org","size":111285,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"b78ed0460b7f16013e62f72a0253eb98220a0965","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2018-02-06T20:12:49Z","pushed_at":"2018-02-06T20:52:50Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":111321,"stargazers_count":9701,"watchers_count":9701,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2144,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":2144,"open_issues":140,"watchers":9701,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3452"},"html":{"href":"https://github.com/facebook/rocksdb/pull/3452"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/3452"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/3452/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3452/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3452/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/fa85cfab935b889df47ca5a0dde0c3f1869a70ab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gfosco"}}