{"action":"created","comment":{"url":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/comments/179862682","pull_request_review_id":110192762,"id":179862682,"diff_hunk":"@@ -1,2 +1,3 @@\n custom_toolchain=\"//build/toolchain/linux/unbundle:default\"\n host_toolchain=\"//build/toolchain/linux/unbundle:default\"\n+is_official_build=true","path":"resources/config_bundles/archlinux/gn_flags.map","position":3,"original_position":3,"commit_id":"357341fe8fa763546df689703944cc9e6e9cfbb7","original_commit_id":"357341fe8fa763546df689703944cc9e6e9cfbb7","user":{"login":"xsmile","id":920840,"avatar_url":"https://avatars2.githubusercontent.com/u/920840?v=4","gravatar_id":"","url":"https://api.github.com/users/xsmile","html_url":"https://github.com/xsmile","followers_url":"https://api.github.com/users/xsmile/followers","following_url":"https://api.github.com/users/xsmile/following{/other_user}","gists_url":"https://api.github.com/users/xsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/xsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsmile/subscriptions","organizations_url":"https://api.github.com/users/xsmile/orgs","repos_url":"https://api.github.com/users/xsmile/repos","events_url":"https://api.github.com/users/xsmile/events{/privacy}","received_events_url":"https://api.github.com/users/xsmile/received_events","type":"User","site_admin":false},"body":"`is_official_build` is responsible for a set of optimization flags. E.g. for 64-bit Linux it enables ThinLTO and control-flow integrity. It slows down the build process but should have advantages during runtime. I experimented with these flags a while back if you remember and \r\n recently `is_official_build` made it into the official Arch Linux build script.\r\nI can't comment on the effects for other operating systems though and it will need to be tested.\r\n\r\nAdditional changes to make it work are listed at [1] and [2]. Specifically the patch for ICU is needed and I believe that the rest is optional.\r\n\r\n1: https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/chromium&id=067cef8b936524e5ff1801a57042b2d121ef1363\r\n2: https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/chromium&id=8f15906c7fab24107b34f42f05a4be8e337969e3","created_at":"2018-04-06T20:05:51Z","updated_at":"2018-04-06T20:05:51Z","html_url":"https://github.com/Eloston/ungoogled-chromium/pull/388#discussion_r179862682","pull_request_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/388","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/comments/179862682"},"html":{"href":"https://github.com/Eloston/ungoogled-chromium/pull/388#discussion_r179862682"},"pull_request":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/388"}},"in_reply_to_id":179817331},"pull_request":{"url":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/388","id":179745415,"html_url":"https://github.com/Eloston/ungoogled-chromium/pull/388","diff_url":"https://github.com/Eloston/ungoogled-chromium/pull/388.diff","patch_url":"https://github.com/Eloston/ungoogled-chromium/pull/388.patch","issue_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/388","number":388,"state":"open","locked":false,"title":"Update Linux patches to 66","user":{"login":"xsmile","id":920840,"avatar_url":"https://avatars2.githubusercontent.com/u/920840?v=4","gravatar_id":"","url":"https://api.github.com/users/xsmile","html_url":"https://github.com/xsmile","followers_url":"https://api.github.com/users/xsmile/followers","following_url":"https://api.github.com/users/xsmile/following{/other_user}","gists_url":"https://api.github.com/users/xsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/xsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsmile/subscriptions","organizations_url":"https://api.github.com/users/xsmile/orgs","repos_url":"https://api.github.com/users/xsmile/repos","events_url":"https://api.github.com/users/xsmile/events{/privacy}","received_events_url":"https://api.github.com/users/xsmile/received_events","type":"User","site_admin":false},"body":"At the moment the PR is for Chromium 66.0.3359.66 but it will be updated for further beta releases of 66 and it will be completed when a stable version of 66 is released.","created_at":"2018-04-05T17:30:39Z","updated_at":"2018-04-06T20:05:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc614894c72863f80bae905f622d49ca639f516e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":223840428,"url":"https://api.github.com/repos/Eloston/ungoogled-chromium/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/Eloston/ungoogled-chromium/milestones/9","html_url":"https://github.com/Eloston/ungoogled-chromium/milestone/9","labels_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/milestones/9/labels","id":3248267,"number":9,"title":"66.x.x.x","description":"","creator":{"login":"Eloston","id":1305560,"avatar_url":"https://avatars2.githubusercontent.com/u/1305560?v=4","gravatar_id":"","url":"https://api.github.com/users/Eloston","html_url":"https://github.com/Eloston","followers_url":"https://api.github.com/users/Eloston/followers","following_url":"https://api.github.com/users/Eloston/following{/other_user}","gists_url":"https://api.github.com/users/Eloston/gists{/gist_id}","starred_url":"https://api.github.com/users/Eloston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eloston/subscriptions","organizations_url":"https://api.github.com/users/Eloston/orgs","repos_url":"https://api.github.com/users/Eloston/repos","events_url":"https://api.github.com/users/Eloston/events{/privacy}","received_events_url":"https://api.github.com/users/Eloston/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-04-06T16:30:28Z","updated_at":"2018-04-06T16:30:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/388/commits","review_comments_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/388/comments","review_comment_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/388/comments","statuses_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/statuses/357341fe8fa763546df689703944cc9e6e9cfbb7","head":{"label":"xsmile:66","ref":"66","sha":"357341fe8fa763546df689703944cc9e6e9cfbb7","user":{"login":"xsmile","id":920840,"avatar_url":"https://avatars2.githubusercontent.com/u/920840?v=4","gravatar_id":"","url":"https://api.github.com/users/xsmile","html_url":"https://github.com/xsmile","followers_url":"https://api.github.com/users/xsmile/followers","following_url":"https://api.github.com/users/xsmile/following{/other_user}","gists_url":"https://api.github.com/users/xsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/xsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsmile/subscriptions","organizations_url":"https://api.github.com/users/xsmile/orgs","repos_url":"https://api.github.com/users/xsmile/repos","events_url":"https://api.github.com/users/xsmile/events{/privacy}","received_events_url":"https://api.github.com/users/xsmile/received_events","type":"User","site_admin":false},"repo":{"id":124567094,"name":"ungoogled-chromium","full_name":"xsmile/ungoogled-chromium","owner":{"login":"xsmile","id":920840,"avatar_url":"https://avatars2.githubusercontent.com/u/920840?v=4","gravatar_id":"","url":"https://api.github.com/users/xsmile","html_url":"https://github.com/xsmile","followers_url":"https://api.github.com/users/xsmile/followers","following_url":"https://api.github.com/users/xsmile/following{/other_user}","gists_url":"https://api.github.com/users/xsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/xsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsmile/subscriptions","organizations_url":"https://api.github.com/users/xsmile/orgs","repos_url":"https://api.github.com/users/xsmile/repos","events_url":"https://api.github.com/users/xsmile/events{/privacy}","received_events_url":"https://api.github.com/users/xsmile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xsmile/ungoogled-chromium","description":"Modifications to Google Chromium for removing Google integration and enhancing privacy, control, and transparency","fork":true,"url":"https://api.github.com/repos/xsmile/ungoogled-chromium","forks_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/forks","keys_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/teams","hooks_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/hooks","issue_events_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/issues/events{/number}","events_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/events","assignees_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/assignees{/user}","branches_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/branches{/branch}","tags_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/tags","blobs_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/git/refs{/sha}","trees_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/statuses/{sha}","languages_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/languages","stargazers_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/stargazers","contributors_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/contributors","subscribers_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/subscribers","subscription_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/subscription","commits_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/commits{/sha}","git_commits_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/git/commits{/sha}","comments_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/comments{/number}","issue_comment_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/issues/comments{/number}","contents_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/contents/{+path}","compare_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/merges","archive_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/downloads","issues_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/issues{/number}","pulls_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/pulls{/number}","milestones_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/milestones{/number}","notifications_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/labels{/name}","releases_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/releases{/id}","deployments_url":"https://api.github.com/repos/xsmile/ungoogled-chromium/deployments","created_at":"2018-03-09T16:41:25Z","updated_at":"2018-03-09T16:41:28Z","pushed_at":"2018-04-06T09:50:55Z","git_url":"git://github.com/xsmile/ungoogled-chromium.git","ssh_url":"git@github.com:xsmile/ungoogled-chromium.git","clone_url":"https://github.com/xsmile/ungoogled-chromium.git","svn_url":"https://github.com/xsmile/ungoogled-chromium","homepage":"","size":3514,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Eloston:develop","ref":"develop","sha":"769bfc546966ba1f4e97ba6ecb64632e3432fae7","user":{"login":"Eloston","id":1305560,"avatar_url":"https://avatars2.githubusercontent.com/u/1305560?v=4","gravatar_id":"","url":"https://api.github.com/users/Eloston","html_url":"https://github.com/Eloston","followers_url":"https://api.github.com/users/Eloston/followers","following_url":"https://api.github.com/users/Eloston/following{/other_user}","gists_url":"https://api.github.com/users/Eloston/gists{/gist_id}","starred_url":"https://api.github.com/users/Eloston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eloston/subscriptions","organizations_url":"https://api.github.com/users/Eloston/orgs","repos_url":"https://api.github.com/users/Eloston/repos","events_url":"https://api.github.com/users/Eloston/events{/privacy}","received_events_url":"https://api.github.com/users/Eloston/received_events","type":"User","site_admin":false},"repo":{"id":37347459,"name":"ungoogled-chromium","full_name":"Eloston/ungoogled-chromium","owner":{"login":"Eloston","id":1305560,"avatar_url":"https://avatars2.githubusercontent.com/u/1305560?v=4","gravatar_id":"","url":"https://api.github.com/users/Eloston","html_url":"https://github.com/Eloston","followers_url":"https://api.github.com/users/Eloston/followers","following_url":"https://api.github.com/users/Eloston/following{/other_user}","gists_url":"https://api.github.com/users/Eloston/gists{/gist_id}","starred_url":"https://api.github.com/users/Eloston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eloston/subscriptions","organizations_url":"https://api.github.com/users/Eloston/orgs","repos_url":"https://api.github.com/users/Eloston/repos","events_url":"https://api.github.com/users/Eloston/events{/privacy}","received_events_url":"https://api.github.com/users/Eloston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eloston/ungoogled-chromium","description":"Modifications to Google Chromium for removing Google integration and enhancing privacy, control, and transparency","fork":false,"url":"https://api.github.com/repos/Eloston/ungoogled-chromium","forks_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/forks","keys_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/teams","hooks_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/hooks","issue_events_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/events{/number}","events_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/events","assignees_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/assignees{/user}","branches_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/branches{/branch}","tags_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/tags","blobs_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/statuses/{sha}","languages_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/languages","stargazers_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/stargazers","contributors_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/contributors","subscribers_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/subscribers","subscription_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/subscription","commits_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/contents/{+path}","compare_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/merges","archive_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/downloads","issues_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues{/number}","pulls_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls{/number}","milestones_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/milestones{/number}","notifications_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/labels{/name}","releases_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/releases{/id}","deployments_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/deployments","created_at":"2015-06-12T22:24:24Z","updated_at":"2018-04-06T16:29:38Z","pushed_at":"2018-04-06T16:29:31Z","git_url":"git://github.com/Eloston/ungoogled-chromium.git","ssh_url":"git@github.com:Eloston/ungoogled-chromium.git","clone_url":"https://github.com/Eloston/ungoogled-chromium.git","svn_url":"https://github.com/Eloston/ungoogled-chromium","homepage":"","size":3613,"stargazers_count":3481,"watchers_count":3481,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":140,"open_issues":33,"watchers":3481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/388"},"html":{"href":"https://github.com/Eloston/ungoogled-chromium/pull/388"},"issue":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/388"},"comments":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/Eloston/ungoogled-chromium/statuses/357341fe8fa763546df689703944cc9e6e9cfbb7"}},"author_association":"NONE"}}
{"actor":{"display_login":"xsmile"}}