{"action":"created","comment":{"url":"https://api.github.com/repos/allthings/elements/pulls/comments/169915788","pull_request_review_id":98517282,"id":169915788,"diff_hunk":"@@ -15,18 +15,31 @@ const buttonStyle = css({\n   border: 0,\n })\n \n+const availableSizes = {\n+  xs: 30,\n+  s: 40,\n+  m: 50,\n+  l: 60,\n+  xl: 70,\n+}\n+\n class FloatingButton extends React.Component {\n   static propTypes = {\n     color: PropTypes.string.isRequired,\n     disabled: PropTypes.bool,\n     disabledColor: PropTypes.string.isRequired,\n+    size: PropTypes.oneOf(['xs', 's', 'm', 'l', 'xl']),\n+  }\n+\n+  static defaultProps = {\n+    size: 'l',","path":"src/molecules/FloatingButton.jsx","position":39,"original_position":21,"commit_id":"5c41d0ceb453cac66606c22f56558580c74be29d","original_commit_id":"2e37f9b37375a70f4e4ad437df4eb7ae3e8693ed","user":{"login":"fivenp","id":132332,"avatar_url":"https://avatars2.githubusercontent.com/u/132332?v=4","gravatar_id":"","url":"https://api.github.com/users/fivenp","html_url":"https://github.com/fivenp","followers_url":"https://api.github.com/users/fivenp/followers","following_url":"https://api.github.com/users/fivenp/following{/other_user}","gists_url":"https://api.github.com/users/fivenp/gists{/gist_id}","starred_url":"https://api.github.com/users/fivenp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivenp/subscriptions","organizations_url":"https://api.github.com/users/fivenp/orgs","repos_url":"https://api.github.com/users/fivenp/repos","events_url":"https://api.github.com/users/fivenp/events{/privacy}","received_events_url":"https://api.github.com/users/fivenp/received_events","type":"User","site_admin":false},"body":"I did some research aaaand:\r\n\r\n#### current usage of the `<FloatingButton>` seems to be like\r\n\r\n```jsx\r\n<FloatingButton>\r\n  <Text strong size=\"s\">text</Text>\r\n<FloatingButton>\r\n```\r\n* FloatingButton is **fixed** to 50px height\r\n* Text is 12px (set by size=\"s\")\r\n\r\n#### which would translate after this PR into\r\n```jsx\r\n<FloatingButton size=\"m\">\r\n  <Text strong size=\"s\">text</Text>\r\n<FloatingButton>\r\n```\r\n* FloatingButton is 50px heigh (set by size=\"m\")\r\n* Text is 12px (set by size=\"s\")\r\n\r\n#### perfect final usage would be\r\n```jsx\r\n<FloatingButton>\r\n  <Text strong>text</Text>\r\n<FloatingButton>\r\n```\r\n* FloatingButton **defaults** to 60px height\r\n* Text **defaults** to 13px\r\n\r\n#### proposal for a smooth transition:\r\n* Implement this PR and default to size \"l\" for the FloatingButton\r\n* Do a console.warn telling people to make sure to update their `<Text>` child within the `FloatingButton` to remove the `size` prop if it's set at all....","created_at":"2018-02-22T10:38:56Z","updated_at":"2018-02-22T10:38:56Z","html_url":"https://github.com/allthings/elements/pull/131#discussion_r169915788","pull_request_url":"https://api.github.com/repos/allthings/elements/pulls/131","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/allthings/elements/pulls/comments/169915788"},"html":{"href":"https://github.com/allthings/elements/pull/131#discussion_r169915788"},"pull_request":{"href":"https://api.github.com/repos/allthings/elements/pulls/131"}},"in_reply_to_id":169643990},"pull_request":{"url":"https://api.github.com/repos/allthings/elements/pulls/131","id":170476909,"html_url":"https://github.com/allthings/elements/pull/131","diff_url":"https://github.com/allthings/elements/pull/131.diff","patch_url":"https://github.com/allthings/elements/pull/131.patch","issue_url":"https://api.github.com/repos/allthings/elements/issues/131","number":131,"state":"open","locked":false,"title":"adding buttons sizes and cursor:pointer to floatingbutton","user":{"login":"fivenp","id":132332,"avatar_url":"https://avatars2.githubusercontent.com/u/132332?v=4","gravatar_id":"","url":"https://api.github.com/users/fivenp","html_url":"https://github.com/fivenp","followers_url":"https://api.github.com/users/fivenp/followers","following_url":"https://api.github.com/users/fivenp/following{/other_user}","gists_url":"https://api.github.com/users/fivenp/gists{/gist_id}","starred_url":"https://api.github.com/users/fivenp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivenp/subscriptions","organizations_url":"https://api.github.com/users/fivenp/orgs","repos_url":"https://api.github.com/users/fivenp/repos","events_url":"https://api.github.com/users/fivenp/events{/privacy}","received_events_url":"https://api.github.com/users/fivenp/received_events","type":"User","site_admin":false},"body":"Adding the possibility to pass different button sizes to this component.\r\n\r\nThe only culprint - the `<Text>` component which is usually used in combination with this button doesn't scale automatically the font-size (aka. you need to add `<Text size=\"xl\">` if you want a `<FloatingButton size=\"xl\">`)\r\n\r\nChecklist:\r\n\r\n- [x] Test added / Snapshots updated\r\n- [x] Documentation added / updated\r\n\r\n\r\n","created_at":"2018-02-21T13:57:43Z","updated_at":"2018-02-22T10:38:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ae184d0c034ee061a061050bc85c7d049287313","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mosch","id":224866,"avatar_url":"https://avatars0.githubusercontent.com/u/224866?v=4","gravatar_id":"","url":"https://api.github.com/users/mosch","html_url":"https://github.com/mosch","followers_url":"https://api.github.com/users/mosch/followers","following_url":"https://api.github.com/users/mosch/following{/other_user}","gists_url":"https://api.github.com/users/mosch/gists{/gist_id}","starred_url":"https://api.github.com/users/mosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosch/subscriptions","organizations_url":"https://api.github.com/users/mosch/orgs","repos_url":"https://api.github.com/users/mosch/repos","events_url":"https://api.github.com/users/mosch/events{/privacy}","received_events_url":"https://api.github.com/users/mosch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/allthings/elements/pulls/131/commits","review_comments_url":"https://api.github.com/repos/allthings/elements/pulls/131/comments","review_comment_url":"https://api.github.com/repos/allthings/elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allthings/elements/issues/131/comments","statuses_url":"https://api.github.com/repos/allthings/elements/statuses/5c41d0ceb453cac66606c22f56558580c74be29d","head":{"label":"allthings:add-button-sizes","ref":"add-button-sizes","sha":"5c41d0ceb453cac66606c22f56558580c74be29d","user":{"login":"allthings","id":11928936,"avatar_url":"https://avatars3.githubusercontent.com/u/11928936?v=4","gravatar_id":"","url":"https://api.github.com/users/allthings","html_url":"https://github.com/allthings","followers_url":"https://api.github.com/users/allthings/followers","following_url":"https://api.github.com/users/allthings/following{/other_user}","gists_url":"https://api.github.com/users/allthings/gists{/gist_id}","starred_url":"https://api.github.com/users/allthings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allthings/subscriptions","organizations_url":"https://api.github.com/users/allthings/orgs","repos_url":"https://api.github.com/users/allthings/repos","events_url":"https://api.github.com/users/allthings/events{/privacy}","received_events_url":"https://api.github.com/users/allthings/received_events","type":"Organization","site_admin":false},"repo":{"id":104872302,"name":"elements","full_name":"allthings/elements","owner":{"login":"allthings","id":11928936,"avatar_url":"https://avatars3.githubusercontent.com/u/11928936?v=4","gravatar_id":"","url":"https://api.github.com/users/allthings","html_url":"https://github.com/allthings","followers_url":"https://api.github.com/users/allthings/followers","following_url":"https://api.github.com/users/allthings/following{/other_user}","gists_url":"https://api.github.com/users/allthings/gists{/gist_id}","starred_url":"https://api.github.com/users/allthings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allthings/subscriptions","organizations_url":"https://api.github.com/users/allthings/orgs","repos_url":"https://api.github.com/users/allthings/repos","events_url":"https://api.github.com/users/allthings/events{/privacy}","received_events_url":"https://api.github.com/users/allthings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allthings/elements","description":"Elements is a set of carefully crafted, high quality React UI components, designed for the Allthings Platform.","fork":false,"url":"https://api.github.com/repos/allthings/elements","forks_url":"https://api.github.com/repos/allthings/elements/forks","keys_url":"https://api.github.com/repos/allthings/elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allthings/elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allthings/elements/teams","hooks_url":"https://api.github.com/repos/allthings/elements/hooks","issue_events_url":"https://api.github.com/repos/allthings/elements/issues/events{/number}","events_url":"https://api.github.com/repos/allthings/elements/events","assignees_url":"https://api.github.com/repos/allthings/elements/assignees{/user}","branches_url":"https://api.github.com/repos/allthings/elements/branches{/branch}","tags_url":"https://api.github.com/repos/allthings/elements/tags","blobs_url":"https://api.github.com/repos/allthings/elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allthings/elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allthings/elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/allthings/elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allthings/elements/statuses/{sha}","languages_url":"https://api.github.com/repos/allthings/elements/languages","stargazers_url":"https://api.github.com/repos/allthings/elements/stargazers","contributors_url":"https://api.github.com/repos/allthings/elements/contributors","subscribers_url":"https://api.github.com/repos/allthings/elements/subscribers","subscription_url":"https://api.github.com/repos/allthings/elements/subscription","commits_url":"https://api.github.com/repos/allthings/elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/allthings/elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/allthings/elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/allthings/elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/allthings/elements/contents/{+path}","compare_url":"https://api.github.com/repos/allthings/elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allthings/elements/merges","archive_url":"https://api.github.com/repos/allthings/elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allthings/elements/downloads","issues_url":"https://api.github.com/repos/allthings/elements/issues{/number}","pulls_url":"https://api.github.com/repos/allthings/elements/pulls{/number}","milestones_url":"https://api.github.com/repos/allthings/elements/milestones{/number}","notifications_url":"https://api.github.com/repos/allthings/elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allthings/elements/labels{/name}","releases_url":"https://api.github.com/repos/allthings/elements/releases{/id}","deployments_url":"https://api.github.com/repos/allthings/elements/deployments","created_at":"2017-09-26T10:43:51Z","updated_at":"2018-02-02T11:29:16Z","pushed_at":"2018-02-22T10:33:08Z","git_url":"git://github.com/allthings/elements.git","ssh_url":"git@github.com:allthings/elements.git","clone_url":"https://github.com/allthings/elements.git","svn_url":"https://github.com/allthings/elements","homepage":"https://developers.allthings.me/elements/index.html","size":12424,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":15,"watchers":6,"default_branch":"master"}},"base":{"label":"allthings:master","ref":"master","sha":"6736c543f7218752d14f49286f2360bb610144ce","user":{"login":"allthings","id":11928936,"avatar_url":"https://avatars3.githubusercontent.com/u/11928936?v=4","gravatar_id":"","url":"https://api.github.com/users/allthings","html_url":"https://github.com/allthings","followers_url":"https://api.github.com/users/allthings/followers","following_url":"https://api.github.com/users/allthings/following{/other_user}","gists_url":"https://api.github.com/users/allthings/gists{/gist_id}","starred_url":"https://api.github.com/users/allthings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allthings/subscriptions","organizations_url":"https://api.github.com/users/allthings/orgs","repos_url":"https://api.github.com/users/allthings/repos","events_url":"https://api.github.com/users/allthings/events{/privacy}","received_events_url":"https://api.github.com/users/allthings/received_events","type":"Organization","site_admin":false},"repo":{"id":104872302,"name":"elements","full_name":"allthings/elements","owner":{"login":"allthings","id":11928936,"avatar_url":"https://avatars3.githubusercontent.com/u/11928936?v=4","gravatar_id":"","url":"https://api.github.com/users/allthings","html_url":"https://github.com/allthings","followers_url":"https://api.github.com/users/allthings/followers","following_url":"https://api.github.com/users/allthings/following{/other_user}","gists_url":"https://api.github.com/users/allthings/gists{/gist_id}","starred_url":"https://api.github.com/users/allthings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allthings/subscriptions","organizations_url":"https://api.github.com/users/allthings/orgs","repos_url":"https://api.github.com/users/allthings/repos","events_url":"https://api.github.com/users/allthings/events{/privacy}","received_events_url":"https://api.github.com/users/allthings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allthings/elements","description":"Elements is a set of carefully crafted, high quality React UI components, designed for the Allthings Platform.","fork":false,"url":"https://api.github.com/repos/allthings/elements","forks_url":"https://api.github.com/repos/allthings/elements/forks","keys_url":"https://api.github.com/repos/allthings/elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allthings/elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allthings/elements/teams","hooks_url":"https://api.github.com/repos/allthings/elements/hooks","issue_events_url":"https://api.github.com/repos/allthings/elements/issues/events{/number}","events_url":"https://api.github.com/repos/allthings/elements/events","assignees_url":"https://api.github.com/repos/allthings/elements/assignees{/user}","branches_url":"https://api.github.com/repos/allthings/elements/branches{/branch}","tags_url":"https://api.github.com/repos/allthings/elements/tags","blobs_url":"https://api.github.com/repos/allthings/elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allthings/elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allthings/elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/allthings/elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allthings/elements/statuses/{sha}","languages_url":"https://api.github.com/repos/allthings/elements/languages","stargazers_url":"https://api.github.com/repos/allthings/elements/stargazers","contributors_url":"https://api.github.com/repos/allthings/elements/contributors","subscribers_url":"https://api.github.com/repos/allthings/elements/subscribers","subscription_url":"https://api.github.com/repos/allthings/elements/subscription","commits_url":"https://api.github.com/repos/allthings/elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/allthings/elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/allthings/elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/allthings/elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/allthings/elements/contents/{+path}","compare_url":"https://api.github.com/repos/allthings/elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allthings/elements/merges","archive_url":"https://api.github.com/repos/allthings/elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allthings/elements/downloads","issues_url":"https://api.github.com/repos/allthings/elements/issues{/number}","pulls_url":"https://api.github.com/repos/allthings/elements/pulls{/number}","milestones_url":"https://api.github.com/repos/allthings/elements/milestones{/number}","notifications_url":"https://api.github.com/repos/allthings/elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allthings/elements/labels{/name}","releases_url":"https://api.github.com/repos/allthings/elements/releases{/id}","deployments_url":"https://api.github.com/repos/allthings/elements/deployments","created_at":"2017-09-26T10:43:51Z","updated_at":"2018-02-02T11:29:16Z","pushed_at":"2018-02-22T10:33:08Z","git_url":"git://github.com/allthings/elements.git","ssh_url":"git@github.com:allthings/elements.git","clone_url":"https://github.com/allthings/elements.git","svn_url":"https://github.com/allthings/elements","homepage":"https://developers.allthings.me/elements/index.html","size":12424,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":15,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allthings/elements/pulls/131"},"html":{"href":"https://github.com/allthings/elements/pull/131"},"issue":{"href":"https://api.github.com/repos/allthings/elements/issues/131"},"comments":{"href":"https://api.github.com/repos/allthings/elements/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/allthings/elements/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/allthings/elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allthings/elements/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/allthings/elements/statuses/5c41d0ceb453cac66606c22f56558580c74be29d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fivenp"}}