{"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/225878928","pull_request_review_id":165572040,"id":225878928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTg3ODkyOA==","diff_hunk":"@@ -0,0 +1,175 @@\n+/*\n+Copyright 2018 The Knative Authors\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    https://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package resources","path":"pkg/reconciler/v1alpha1/route/resources/cluster_ingress.go","position":17,"original_position":17,"commit_id":"efb9ea898b67ada7c369221928b9c6aa83a32684","original_commit_id":"efb9ea898b67ada7c369221928b9c6aa83a32684","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"body":"Golint comments: should have a package comment, unless it's in another file for this package. [More info](https://golang.org/wiki/CodeReviewComments#package-comments). <!-- golint -->","created_at":"2018-10-17T11:06:23Z","updated_at":"2018-10-17T11:06:24Z","html_url":"https://github.com/knative/serving/pull/2243#discussion_r225878928","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/2243","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/225878928"},"html":{"href":"https://github.com/knative/serving/pull/2243#discussion_r225878928"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/2243"}}},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2243","id":223559968,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTU5OTY4","html_url":"https://github.com/knative/serving/pull/2243","diff_url":"https://github.com/knative/serving/pull/2243.diff","patch_url":"https://github.com/knative/serving/pull/2243.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/2243","number":2243,"state":"open","locked":false,"title":"WIP: Update route reconciler to create ClusterIngress instead of VirtualService","user":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"body":"<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->\r\n\r\nPart of #1963\r\nFollow-up #2189\r\n\r\n## Proposed Changes\r\n\r\n  * helper funcs to construct clusteringress\r\n  * create placeholder service according to ingress status\r\n  * update route reconciler to create ClusterIngress instead of VirtualService\r\n\r\n**Release Note**\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n```\r\nupdate route reconciler to create ClusterIngress instead of VirtualService\r\n```\r\n\r\nIt is developed on top of https://github.com/knative/serving/pull/2189, I'll have it rebased after https://github.com/knative/serving/pull/2189 merged\r\n\r\n/area networking\r\n","created_at":"2018-10-17T11:06:11Z","updated_at":"2018-10-17T11:06:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65e9ae9dcf3c6b37a1e29a9f3eac890755c3ff95","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":868660931,"node_id":"MDU6TGFiZWw4Njg2NjA5MzE=","url":"https://api.github.com/repos/knative/serving/labels/area/networking","name":"area/networking","color":"e59cc2","default":false},{"id":862161916,"node_id":"MDU6TGFiZWw4NjIxNjE5MTY=","url":"https://api.github.com/repos/knative/serving/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"b60205","default":false},{"id":860875203,"node_id":"MDU6TGFiZWw4NjA4NzUyMDM=","url":"https://api.github.com/repos/knative/serving/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/2243/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/2243/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/2243/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/efb9ea898b67ada7c369221928b9c6aa83a32684","head":{"label":"lichuqiang:route_reconciler","ref":"route_reconciler","sha":"efb9ea898b67ada7c369221928b9c6aa83a32684","user":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"repo":{"id":149099865,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwOTk4NjU=","name":"serving","full_name":"lichuqiang/serving","private":false,"owner":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lichuqiang/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/lichuqiang/serving","forks_url":"https://api.github.com/repos/lichuqiang/serving/forks","keys_url":"https://api.github.com/repos/lichuqiang/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lichuqiang/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lichuqiang/serving/teams","hooks_url":"https://api.github.com/repos/lichuqiang/serving/hooks","issue_events_url":"https://api.github.com/repos/lichuqiang/serving/issues/events{/number}","events_url":"https://api.github.com/repos/lichuqiang/serving/events","assignees_url":"https://api.github.com/repos/lichuqiang/serving/assignees{/user}","branches_url":"https://api.github.com/repos/lichuqiang/serving/branches{/branch}","tags_url":"https://api.github.com/repos/lichuqiang/serving/tags","blobs_url":"https://api.github.com/repos/lichuqiang/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lichuqiang/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lichuqiang/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/lichuqiang/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lichuqiang/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/lichuqiang/serving/languages","stargazers_url":"https://api.github.com/repos/lichuqiang/serving/stargazers","contributors_url":"https://api.github.com/repos/lichuqiang/serving/contributors","subscribers_url":"https://api.github.com/repos/lichuqiang/serving/subscribers","subscription_url":"https://api.github.com/repos/lichuqiang/serving/subscription","commits_url":"https://api.github.com/repos/lichuqiang/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/lichuqiang/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/lichuqiang/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/lichuqiang/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/lichuqiang/serving/contents/{+path}","compare_url":"https://api.github.com/repos/lichuqiang/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lichuqiang/serving/merges","archive_url":"https://api.github.com/repos/lichuqiang/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lichuqiang/serving/downloads","issues_url":"https://api.github.com/repos/lichuqiang/serving/issues{/number}","pulls_url":"https://api.github.com/repos/lichuqiang/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/lichuqiang/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/lichuqiang/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lichuqiang/serving/labels{/name}","releases_url":"https://api.github.com/repos/lichuqiang/serving/releases{/id}","deployments_url":"https://api.github.com/repos/lichuqiang/serving/deployments","created_at":"2018-09-17T09:18:42Z","updated_at":"2018-09-17T09:18:45Z","pushed_at":"2018-10-17T11:03:54Z","git_url":"git://github.com/lichuqiang/serving.git","ssh_url":"git@github.com:lichuqiang/serving.git","clone_url":"https://github.com/lichuqiang/serving.git","svn_url":"https://github.com/lichuqiang/serving","homepage":"","size":23209,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"81ef6ec36ffc86c43aaf877d1db7be5c9e4b8b39","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-10-16T20:48:35Z","pushed_at":"2018-10-17T11:06:12Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":23151,"stargazers_count":771,"watchers_count":771,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":346,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":141,"open_issues":346,"watchers":771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/2243"},"html":{"href":"https://github.com/knative/serving/pull/2243"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/2243"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/2243/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/2243/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/2243/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/efb9ea898b67ada7c369221928b9c6aa83a32684"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"knative-prow-robot"}}