{"action":"created","comment":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/234295523","pull_request_review_id":175914308,"id":234295523,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDI5NTUyMw==","diff_hunk":"@@ -390,24 +391,21 @@ def find_config(self, versions=None):\n         if not isinstance(versions, list) and versions is not None:\n             versions = listify(versions)\n \n-        if self.env.is_cross_build() and not self.native:\n-            cross_file = self.env.cross_info.config['binaries']\n-            try:\n-                tools = [cross_file[self.tool_name]]\n-            except KeyError:\n+        for_machine = MachineChoice.BUILD if self.native else MachineChoice.HOST\n+        tool = self.env.binaries[for_machine].lookup_entry(self.tool_name)","path":"mesonbuild/dependencies/base.py","position":20,"original_position":20,"commit_id":"a31728cdd3bcc9bd0023796a0a90b6336c8d023b","original_commit_id":"a31728cdd3bcc9bd0023796a0a90b6336c8d023b","user":{"login":"Ericson2314","id":1055245,"node_id":"MDQ6VXNlcjEwNTUyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1055245?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"body":"This is always a list","created_at":"2018-11-16T17:56:31Z","updated_at":"2018-11-16T17:56:31Z","html_url":"https://github.com/mesonbuild/meson/pull/4445#discussion_r234295523","pull_request_url":"https://api.github.com/repos/mesonbuild/meson/pulls/4445","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/234295523"},"html":{"href":"https://github.com/mesonbuild/meson/pull/4445#discussion_r234295523"},"pull_request":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/4445"}}},"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/4445","id":226620423,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjIwNDIz","html_url":"https://github.com/mesonbuild/meson/pull/4445","diff_url":"https://github.com/mesonbuild/meson/pull/4445.diff","patch_url":"https://github.com/mesonbuild/meson/pull/4445.patch","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/4445","number":4445,"state":"open","locked":false,"title":"WIP Parsing of cross file upfront, and store in cross-agnostic data structures","user":{"login":"Ericson2314","id":1055245,"node_id":"MDQ6VXNlcjEwNTUyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1055245?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"body":"Continuing what #4338 started. So ignore this until that is merged.\r\n\r\nSimply put, this gets rid of `environment.cross_info`. Information is instead stored in `environment.binaries` (the `BinaryTable` class has instances now), `environment.machines` as was already done, and `environment.properties`. All of these are `PerMachine` containers, paving the way for a rebased #4010 completely merging cross and native code paths.\r\n\r\nIn particular the binary lookup code has begun to be consolidated with this, using the same function to assist with looking up in either the cross file or environment variables. There's a lot more consolidation to be done however, that this enables. More net-negative commits on the way!\r\n\r\nN.B: `self.environment.is_cross_build() and self.environment.cross_info.need_cross_compiler()` becomes just `self.environment.is_cross_build()`.There's no point distinguishing target =?= build like this, because meson doesn't do anything with the target platform in it's own logic. It's purely there for user logic.\r\n\r\nFinally, now that https://github.com/mesonbuild/meson/pull/4216 is merged, this can fold in that code too, and also almost gets rid of `environment.config_info`\r\n\r\nCloses #4332\r\n\r\n","created_at":"2018-10-29T16:07:29Z","updated_at":"2018-11-16T17:56:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16f085b4e28983449714fdb741006ec127c870f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesonbuild/meson/pulls/4445/commits","review_comments_url":"https://api.github.com/repos/mesonbuild/meson/pulls/4445/comments","review_comment_url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/4445/comments","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/a31728cdd3bcc9bd0023796a0a90b6336c8d023b","head":{"label":"Ericson2314:no-cross_info","ref":"no-cross_info","sha":"a31728cdd3bcc9bd0023796a0a90b6336c8d023b","user":{"login":"Ericson2314","id":1055245,"node_id":"MDQ6VXNlcjEwNTUyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1055245?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"repo":{"id":126203542,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyMDM1NDI=","name":"meson","full_name":"Ericson2314/meson","private":false,"owner":{"login":"Ericson2314","id":1055245,"node_id":"MDQ6VXNlcjEwNTUyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1055245?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Ericson2314/meson","description":"The Meson Build System","fork":true,"url":"https://api.github.com/repos/Ericson2314/meson","forks_url":"https://api.github.com/repos/Ericson2314/meson/forks","keys_url":"https://api.github.com/repos/Ericson2314/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ericson2314/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ericson2314/meson/teams","hooks_url":"https://api.github.com/repos/Ericson2314/meson/hooks","issue_events_url":"https://api.github.com/repos/Ericson2314/meson/issues/events{/number}","events_url":"https://api.github.com/repos/Ericson2314/meson/events","assignees_url":"https://api.github.com/repos/Ericson2314/meson/assignees{/user}","branches_url":"https://api.github.com/repos/Ericson2314/meson/branches{/branch}","tags_url":"https://api.github.com/repos/Ericson2314/meson/tags","blobs_url":"https://api.github.com/repos/Ericson2314/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ericson2314/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ericson2314/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ericson2314/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ericson2314/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/Ericson2314/meson/languages","stargazers_url":"https://api.github.com/repos/Ericson2314/meson/stargazers","contributors_url":"https://api.github.com/repos/Ericson2314/meson/contributors","subscribers_url":"https://api.github.com/repos/Ericson2314/meson/subscribers","subscription_url":"https://api.github.com/repos/Ericson2314/meson/subscription","commits_url":"https://api.github.com/repos/Ericson2314/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ericson2314/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ericson2314/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ericson2314/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ericson2314/meson/contents/{+path}","compare_url":"https://api.github.com/repos/Ericson2314/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ericson2314/meson/merges","archive_url":"https://api.github.com/repos/Ericson2314/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ericson2314/meson/downloads","issues_url":"https://api.github.com/repos/Ericson2314/meson/issues{/number}","pulls_url":"https://api.github.com/repos/Ericson2314/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/Ericson2314/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/Ericson2314/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ericson2314/meson/labels{/name}","releases_url":"https://api.github.com/repos/Ericson2314/meson/releases{/id}","deployments_url":"https://api.github.com/repos/Ericson2314/meson/deployments","created_at":"2018-03-21T15:51:35Z","updated_at":"2018-11-16T17:46:43Z","pushed_at":"2018-11-16T17:46:33Z","git_url":"git://github.com/Ericson2314/meson.git","ssh_url":"git@github.com:Ericson2314/meson.git","clone_url":"https://github.com/Ericson2314/meson.git","svn_url":"https://github.com/Ericson2314/meson","homepage":"http://mesonbuild.com","size":19315,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesonbuild:master","ref":"master","sha":"c7a3e81098b8879522a2bbbf733c037d1345d05c","user":{"login":"mesonbuild","id":12551236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":19784232,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc4NDIzMg==","name":"meson","full_name":"mesonbuild/meson","private":false,"owner":{"login":"mesonbuild","id":12551236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesonbuild/meson","description":"The Meson Build System","fork":false,"url":"https://api.github.com/repos/mesonbuild/meson","forks_url":"https://api.github.com/repos/mesonbuild/meson/forks","keys_url":"https://api.github.com/repos/mesonbuild/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/meson/teams","hooks_url":"https://api.github.com/repos/mesonbuild/meson/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/meson/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/meson/events","assignees_url":"https://api.github.com/repos/mesonbuild/meson/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/meson/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/meson/tags","blobs_url":"https://api.github.com/repos/mesonbuild/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/meson/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/meson/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/meson/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/meson/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/meson/subscription","commits_url":"https://api.github.com/repos/mesonbuild/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/meson/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/meson/merges","archive_url":"https://api.github.com/repos/mesonbuild/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/meson/downloads","issues_url":"https://api.github.com/repos/mesonbuild/meson/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/meson/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/meson/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/meson/deployments","created_at":"2014-05-14T15:08:16Z","updated_at":"2018-11-16T16:22:24Z","pushed_at":"2018-11-16T17:46:35Z","git_url":"git://github.com/mesonbuild/meson.git","ssh_url":"git@github.com:mesonbuild/meson.git","clone_url":"https://github.com/mesonbuild/meson.git","svn_url":"https://github.com/mesonbuild/meson","homepage":"http://mesonbuild.com","size":19586,"stargazers_count":1748,"watchers_count":1748,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":468,"mirror_url":null,"archived":false,"open_issues_count":873,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":468,"open_issues":873,"watchers":1748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/4445"},"html":{"href":"https://github.com/mesonbuild/meson/pull/4445"},"issue":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/4445"},"comments":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/4445/comments"},"review_comments":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/4445/comments"},"review_comment":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/4445/commits"},"statuses":{"href":"https://api.github.com/repos/mesonbuild/meson/statuses/a31728cdd3bcc9bd0023796a0a90b6336c8d023b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Ericson2314"}}