{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/19668","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/19668/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/19668/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/19668/events","html_url":"https://github.com/guardian/frontend/pull/19668","id":323717132,"number":19668,"title":"Native Epic vs DFP Epic","user":{"login":"Mullefa","id":4085817,"avatar_url":"https://avatars3.githubusercontent.com/u/4085817?v=4","gravatar_id":"","url":"https://api.github.com/users/Mullefa","html_url":"https://github.com/Mullefa","followers_url":"https://api.github.com/users/Mullefa/followers","following_url":"https://api.github.com/users/Mullefa/following{/other_user}","gists_url":"https://api.github.com/users/Mullefa/gists{/gist_id}","starred_url":"https://api.github.com/users/Mullefa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mullefa/subscriptions","organizations_url":"https://api.github.com/users/Mullefa/orgs","repos_url":"https://api.github.com/users/Mullefa/repos","events_url":"https://api.github.com/users/Mullefa/events{/privacy}","received_events_url":"https://api.github.com/users/Mullefa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-16T17:31:17Z","updated_at":"2018-05-21T16:33:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/19668","html_url":"https://github.com/guardian/frontend/pull/19668","diff_url":"https://github.com/guardian/frontend/pull/19668.diff","patch_url":"https://github.com/guardian/frontend/pull/19668.patch"},"body":"## What does this change?\r\n\r\nAdds an AB test to test the null hypothesis that there is no difference in the annualised value per impression of like-for-like Native and DFP Epics for readers who don't use AdBlock.\r\n\r\n## What is the value of this and can you measure success?\r\n\r\nIf the null hypothesis is true, then we take a big step towards using DFP to serve Epics. This has lots of potential advantages, some of which include: templating, AB test functionality, real-time optimisation of which Epic to show.\r\n\r\n## Screenshots\r\n\r\n|             | Native                                                                                                                 | DFP                                                                                                                 |\r\n|-------------|------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------|\r\n| __Desktop__ | ![native_desktop](https://user-images.githubusercontent.com/4085817/40071700-73906fd6-5869-11e8-9dbc-c7b8b261e9ed.png) | ![dfp_desktop](https://user-images.githubusercontent.com/4085817/40071693-6dda84d2-5869-11e8-9b38-c883e31f1f25.png) |\r\n| __Mobile__  | ![native_mobile](https://user-images.githubusercontent.com/4085817/40071703-754174e2-5869-11e8-99af-61419a7c5638.png)  | ![dfp_mobile](https://user-images.githubusercontent.com/4085817/40071696-6ff7211c-5869-11e8-922d-473e26764a14.png)  |\r\n\r\n## Tested in CODE?\r\n\r\nNo. Tested locally.\r\n\r\n## Notes\r\n\r\n- the DFP Line Item used to target the `epic` slot is called `AB Test - Native Epic vs DFP Epic`\r\n- this Line Item has one associated Creative - `Epic V1.1`\r\n- this Creative has been created from the Native Template `Epic V1` with parameters such that the fields which are in both the acquisition event and Epic component event have matching values e.g. `componentId` is equal to `gdnwb_copts_memco_epic_native_vs_dfp_dfp`\r\n\r\n## TODOs\r\n\r\nI need to liaise with Devina and Jesse to resolve the `TODO`s before this pull request is merged.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/390708566","html_url":"https://github.com/guardian/frontend/pull/19668#issuecomment-390708566","issue_url":"https://api.github.com/repos/guardian/frontend/issues/19668","id":390708566,"user":{"login":"Jester232","id":37469174,"avatar_url":"https://avatars0.githubusercontent.com/u/37469174?v=4","gravatar_id":"","url":"https://api.github.com/users/Jester232","html_url":"https://github.com/Jester232","followers_url":"https://api.github.com/users/Jester232/followers","following_url":"https://api.github.com/users/Jester232/following{/other_user}","gists_url":"https://api.github.com/users/Jester232/gists{/gist_id}","starred_url":"https://api.github.com/users/Jester232/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jester232/subscriptions","organizations_url":"https://api.github.com/users/Jester232/orgs","repos_url":"https://api.github.com/users/Jester232/repos","events_url":"https://api.github.com/users/Jester232/events{/privacy}","received_events_url":"https://api.github.com/users/Jester232/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T16:33:31Z","updated_at":"2018-05-21T16:33:31Z","author_association":"NONE","body":"False\n\nOn Mon, May 21, 2018, 11:29 AM Guy Dawson <notifications@github.com> wrote:\n\n> *@Mullefa* commented on this pull request.\n> ------------------------------\n>\n> In\n> static/src/javascripts/projects/common/modules/experiments/tests/acquisitions-epic-native-vs-dfp.js\n> <https://github.com/guardian/frontend/pull/19668#discussion_r189642524>:\n>\n> > @@ -0,0 +1,58 @@\n> +// @flow\n> +import { makeABTest } from 'common/modules/commercial/contributions-utilities';\n> +import type { AdBlockEpicTemplate } from 'common/modules/commercial/contributions-utilities';\n> +import { createSlots } from 'commercial/modules/dfp/create-slots';\n> +\n> +// The adblockInUse boolean in detect.js is (necessarily) a promise.\n> +// This does not interact well with the synchronous canRun() function expected by the AB testing framework.\n> +// To mitigate against this, create a function which returns false <=>\n> +// ad blocker is active or it is unresolved whether it is active.\n> +// Since the test running is predicated on this function returning true,\n> +// readers in the test will have ad blocker off,\n> +// but we might not include all readers who have ad blocker off.\n>\n> random\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/guardian/frontend/pull/19668#discussion_r189642524>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/Aju79kdEwsvqwbTkHJff_PxwM2wE43qaks5t0uuHgaJpZM4UBuyx>\n> .\n>\n"}}
{"actor":{"display_login":"Jester232"}}