{"action":"opened","number":2737,"pull_request":{"url":"https://api.github.com/repos/ansible/awx/pulls/2737","id":231981208,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTgxMjA4","html_url":"https://github.com/ansible/awx/pull/2737","diff_url":"https://github.com/ansible/awx/pull/2737.diff","patch_url":"https://github.com/ansible/awx/pull/2737.patch","issue_url":"https://api.github.com/repos/ansible/awx/issues/2737","number":2737,"state":"open","locked":false,"title":"Implement deprecation of groups_with_active_failures","user":{"login":"AlanCoding","id":1385596,"node_id":"MDQ6VXNlcjEzODU1OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1385596?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanCoding","html_url":"https://github.com/AlanCoding","followers_url":"https://api.github.com/users/AlanCoding/followers","following_url":"https://api.github.com/users/AlanCoding/following{/other_user}","gists_url":"https://api.github.com/users/AlanCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanCoding/subscriptions","organizations_url":"https://api.github.com/users/AlanCoding/orgs","repos_url":"https://api.github.com/users/AlanCoding/repos","events_url":"https://api.github.com/users/AlanCoding/events{/privacy}","received_events_url":"https://api.github.com/users/AlanCoding/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nSearching for this field in code base:\r\n\r\nhttps://github.com/ansible/awx/search?q=groups_with_active_failures&unscoped_q=groups_with_active_failures\r\n\r\nNo javascript results. The UI is not using this field at all.\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n - Bugfix Pull Request\r\n - Docs Pull Request\r\n\r\n##### COMPONENT NAME\r\n - API\r\n\r\n##### AWX VERSION\r\n```\r\n2.1.0\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nFollows same pattern as: https://github.com/ansible/awx/pull/2591\r\n\r\nPrior attempts to deal with computed fields issues:\r\n\r\nApplying a lock for de-duplication, iffy https://github.com/ansible/awx/pull/2715\r\n\r\nAvoid recursion in logic to reduce combinatorial runtimes, https://github.com/ansible/awx/pull/1642, needs significant algorithmic testing\r\n\r\non-the-fly calculations https://github.com/ansible/awx/pull/1628, generally favored, but actually not viable\r\n\r\nWhenever I ever dug into an algorithmic option, it was clear that this exact field _kills_ our options. To clarify \"Groups with active failures\" means groups that have either hosts with failures _or_ any sub-groups that have hosts with active failures, which could be of any depth. You could have `group1`->`group2`->`group3`->`host1`, and if host1 had a failed job last job, then group1 has active failures.\r\n\r\nThis is a complex concept, and apparently no one uses it.\r\n\r\nBy opening up the option of removing this field, we dramatically increase our available options for replacement or abatement of computed fields.\r\n\r\nOPTIONS before:\r\n\r\n```json\r\n\"groups_with_active_failures\": {\r\n    \"type\": \"integer\",\r\n    \"label\": \"Groups with active failures\",\r\n    \"help_text\": \"Number of groups in this inventory with active failures.\",\r\n    \"min_value\": 0,\r\n    \"filterable\": true\r\n},\r\n```\r\n\r\nOPTIONS after:\r\n\r\n```json\r\n\"groups_with_active_failures\": {\r\n    \"type\": \"integer\",\r\n    \"label\": \"Groups with active failures\",\r\n    \"help_text\": \"This field has been deprecated and will be removed in a future release\",\r\n    \"min_value\": 0,\r\n    \"filterable\": true\r\n},\r\n```","created_at":"2018-11-19T13:54:53Z","updated_at":"2018-11-19T13:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/awx/pulls/2737/commits","review_comments_url":"https://api.github.com/repos/ansible/awx/pulls/2737/comments","review_comment_url":"https://api.github.com/repos/ansible/awx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/awx/issues/2737/comments","statuses_url":"https://api.github.com/repos/ansible/awx/statuses/0ed50b380a175d6010deb9f67749aa4416322764","head":{"label":"AlanCoding:death_to_groups","ref":"death_to_groups","sha":"0ed50b380a175d6010deb9f67749aa4416322764","user":{"login":"AlanCoding","id":1385596,"node_id":"MDQ6VXNlcjEzODU1OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1385596?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanCoding","html_url":"https://github.com/AlanCoding","followers_url":"https://api.github.com/users/AlanCoding/followers","following_url":"https://api.github.com/users/AlanCoding/following{/other_user}","gists_url":"https://api.github.com/users/AlanCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanCoding/subscriptions","organizations_url":"https://api.github.com/users/AlanCoding/orgs","repos_url":"https://api.github.com/users/AlanCoding/repos","events_url":"https://api.github.com/users/AlanCoding/events{/privacy}","received_events_url":"https://api.github.com/users/AlanCoding/received_events","type":"User","site_admin":false},"repo":{"id":102798838,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3OTg4Mzg=","name":"awx","full_name":"AlanCoding/awx","private":false,"owner":{"login":"AlanCoding","id":1385596,"node_id":"MDQ6VXNlcjEzODU1OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1385596?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanCoding","html_url":"https://github.com/AlanCoding","followers_url":"https://api.github.com/users/AlanCoding/followers","following_url":"https://api.github.com/users/AlanCoding/following{/other_user}","gists_url":"https://api.github.com/users/AlanCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanCoding/subscriptions","organizations_url":"https://api.github.com/users/AlanCoding/orgs","repos_url":"https://api.github.com/users/AlanCoding/repos","events_url":"https://api.github.com/users/AlanCoding/events{/privacy}","received_events_url":"https://api.github.com/users/AlanCoding/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AlanCoding/awx","description":"AWX Project","fork":true,"url":"https://api.github.com/repos/AlanCoding/awx","forks_url":"https://api.github.com/repos/AlanCoding/awx/forks","keys_url":"https://api.github.com/repos/AlanCoding/awx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlanCoding/awx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlanCoding/awx/teams","hooks_url":"https://api.github.com/repos/AlanCoding/awx/hooks","issue_events_url":"https://api.github.com/repos/AlanCoding/awx/issues/events{/number}","events_url":"https://api.github.com/repos/AlanCoding/awx/events","assignees_url":"https://api.github.com/repos/AlanCoding/awx/assignees{/user}","branches_url":"https://api.github.com/repos/AlanCoding/awx/branches{/branch}","tags_url":"https://api.github.com/repos/AlanCoding/awx/tags","blobs_url":"https://api.github.com/repos/AlanCoding/awx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlanCoding/awx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlanCoding/awx/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlanCoding/awx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlanCoding/awx/statuses/{sha}","languages_url":"https://api.github.com/repos/AlanCoding/awx/languages","stargazers_url":"https://api.github.com/repos/AlanCoding/awx/stargazers","contributors_url":"https://api.github.com/repos/AlanCoding/awx/contributors","subscribers_url":"https://api.github.com/repos/AlanCoding/awx/subscribers","subscription_url":"https://api.github.com/repos/AlanCoding/awx/subscription","commits_url":"https://api.github.com/repos/AlanCoding/awx/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlanCoding/awx/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlanCoding/awx/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlanCoding/awx/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlanCoding/awx/contents/{+path}","compare_url":"https://api.github.com/repos/AlanCoding/awx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlanCoding/awx/merges","archive_url":"https://api.github.com/repos/AlanCoding/awx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlanCoding/awx/downloads","issues_url":"https://api.github.com/repos/AlanCoding/awx/issues{/number}","pulls_url":"https://api.github.com/repos/AlanCoding/awx/pulls{/number}","milestones_url":"https://api.github.com/repos/AlanCoding/awx/milestones{/number}","notifications_url":"https://api.github.com/repos/AlanCoding/awx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlanCoding/awx/labels{/name}","releases_url":"https://api.github.com/repos/AlanCoding/awx/releases{/id}","deployments_url":"https://api.github.com/repos/AlanCoding/awx/deployments","created_at":"2017-09-08T00:27:27Z","updated_at":"2018-10-18T12:47:59Z","pushed_at":"2018-11-19T13:29:59Z","git_url":"git://github.com/AlanCoding/awx.git","ssh_url":"git@github.com:AlanCoding/awx.git","clone_url":"https://github.com/AlanCoding/awx.git","svn_url":"https://github.com/AlanCoding/awx","homepage":"","size":207787,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"b923efad37d944ca2d195bc6be5d93057bec75f1","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":91594105,"node_id":"MDEwOlJlcG9zaXRvcnk5MTU5NDEwNQ==","name":"awx","full_name":"ansible/awx","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/awx","description":"AWX Project","fork":false,"url":"https://api.github.com/repos/ansible/awx","forks_url":"https://api.github.com/repos/ansible/awx/forks","keys_url":"https://api.github.com/repos/ansible/awx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/awx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/awx/teams","hooks_url":"https://api.github.com/repos/ansible/awx/hooks","issue_events_url":"https://api.github.com/repos/ansible/awx/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/awx/events","assignees_url":"https://api.github.com/repos/ansible/awx/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/awx/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/awx/tags","blobs_url":"https://api.github.com/repos/ansible/awx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/awx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/awx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/awx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/awx/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/awx/languages","stargazers_url":"https://api.github.com/repos/ansible/awx/stargazers","contributors_url":"https://api.github.com/repos/ansible/awx/contributors","subscribers_url":"https://api.github.com/repos/ansible/awx/subscribers","subscription_url":"https://api.github.com/repos/ansible/awx/subscription","commits_url":"https://api.github.com/repos/ansible/awx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/awx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/awx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/awx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/awx/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/awx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/awx/merges","archive_url":"https://api.github.com/repos/ansible/awx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/awx/downloads","issues_url":"https://api.github.com/repos/ansible/awx/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/awx/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/awx/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/awx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/awx/labels{/name}","releases_url":"https://api.github.com/repos/ansible/awx/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/awx/deployments","created_at":"2017-05-17T15:50:14Z","updated_at":"2018-11-19T13:23:48Z","pushed_at":"2018-11-19T13:08:10Z","git_url":"git://github.com/ansible/awx.git","ssh_url":"git@github.com:ansible/awx.git","clone_url":"https://github.com/ansible/awx.git","svn_url":"https://github.com/ansible/awx","homepage":"","size":207444,"stargazers_count":4794,"watchers_count":4794,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":990,"mirror_url":null,"archived":false,"open_issues_count":531,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":990,"open_issues":531,"watchers":4794,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/awx/pulls/2737"},"html":{"href":"https://github.com/ansible/awx/pull/2737"},"issue":{"href":"https://api.github.com/repos/ansible/awx/issues/2737"},"comments":{"href":"https://api.github.com/repos/ansible/awx/issues/2737/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/awx/pulls/2737/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/awx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/awx/pulls/2737/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/awx/statuses/0ed50b380a175d6010deb9f67749aa4416322764"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":11,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"AlanCoding"}}