{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/166606721","pull_request_review_id":94694979,"id":166606721,"diff_hunk":"@@ -1,4 +1,4 @@\n-// Type definitions for stripe 5.0\n+// Type definitions for stripe 6.0","path":"types/stripe/index.d.ts","position":2,"original_position":2,"commit_id":"499d248746c7a3875d7322f78000ad00c8e51af4","original_commit_id":"499d248746c7a3875d7322f78000ad00c8e51af4","user":{"login":"CodeAnimal","id":4548677,"avatar_url":"https://avatars2.githubusercontent.com/u/4548677?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeAnimal","html_url":"https://github.com/CodeAnimal","followers_url":"https://api.github.com/users/CodeAnimal/followers","following_url":"https://api.github.com/users/CodeAnimal/following{/other_user}","gists_url":"https://api.github.com/users/CodeAnimal/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeAnimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeAnimal/subscriptions","organizations_url":"https://api.github.com/users/CodeAnimal/orgs","repos_url":"https://api.github.com/users/CodeAnimal/repos","events_url":"https://api.github.com/users/CodeAnimal/events{/privacy}","received_events_url":"https://api.github.com/users/CodeAnimal/received_events","type":"User","site_admin":false},"body":"I totally agree.","created_at":"2018-02-07T12:48:35Z","updated_at":"2018-02-07T12:48:35Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23471#discussion_r166606721","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23471","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/166606721"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23471#discussion_r166606721"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23471"}},"in_reply_to_id":166559634},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23471","id":167595822,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23471","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23471.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23471.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23471","number":23471,"state":"open","locked":false,"title":"Stripe card numbers are strings:","user":{"login":"garthk","id":15906,"avatar_url":"https://avatars2.githubusercontent.com/u/15906?v=4","gravatar_id":"","url":"https://api.github.com/users/garthk","html_url":"https://github.com/garthk","followers_url":"https://api.github.com/users/garthk/followers","following_url":"https://api.github.com/users/garthk/following{/other_user}","gists_url":"https://api.github.com/users/garthk/gists{/gist_id}","starred_url":"https://api.github.com/users/garthk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthk/subscriptions","organizations_url":"https://api.github.com/users/garthk/orgs","repos_url":"https://api.github.com/users/garthk/repos","events_url":"https://api.github.com/users/garthk/events{/privacy}","received_events_url":"https://api.github.com/users/garthk/received_events","type":"User","site_admin":false},"body":"The Stripe API for Node documentation of [Create a card token][cct]\r\ngives the example code:\r\n\r\n```\r\nvar stripe = require(\"stripe\")(\r\n  \"sk_test_BQokikJOvBiI2HlWgH4olfQ2\"\r\n);\r\n\r\nstripe.tokens.create({\r\n  card: {\r\n    \"number\": '4242424242424242',\r\n    \"exp_month\": 12,\r\n    \"exp_year\": 2019,\r\n    \"cvc\": '123'\r\n  }\r\n}, function(err, token) {\r\n  // asynchronously called\r\n});\r\n```\r\n\r\n[cct]: https://stripe.com/docs/api/node#create_card_token\r\n\r\nRelevant typings history:\r\n\r\n* @borisyankov first added `StripeTokenData.number: number` in 2013-09\r\n\r\n* @codeanimal substantially reworked the typings in 2016-04 with\r\n`ISourceCreationOptions.number: string` but giving it the comment:\r\n\r\n  > The card number, as a string without any separators.\r\n\r\n----\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>\r\n- [x] Increase the version number in the header if appropriate.\r\n\r\nNote I've bumped the major version in the typings' header because this is a breaking change, but not made a copy of the old one for ongoing maintenance because the upgrade effort is low.\r\n","created_at":"2018-02-07T04:29:00Z","updated_at":"2018-02-07T12:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c92dbea7ee7b44118bf14262cc3e8ff0cd778326","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23471/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23471/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23471/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/499d248746c7a3875d7322f78000ad00c8e51af4","head":{"label":"garthk:fix-stripe-card-numbers","ref":"fix-stripe-card-numbers","sha":"499d248746c7a3875d7322f78000ad00c8e51af4","user":{"login":"garthk","id":15906,"avatar_url":"https://avatars2.githubusercontent.com/u/15906?v=4","gravatar_id":"","url":"https://api.github.com/users/garthk","html_url":"https://github.com/garthk","followers_url":"https://api.github.com/users/garthk/followers","following_url":"https://api.github.com/users/garthk/following{/other_user}","gists_url":"https://api.github.com/users/garthk/gists{/gist_id}","starred_url":"https://api.github.com/users/garthk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthk/subscriptions","organizations_url":"https://api.github.com/users/garthk/orgs","repos_url":"https://api.github.com/users/garthk/repos","events_url":"https://api.github.com/users/garthk/events{/privacy}","received_events_url":"https://api.github.com/users/garthk/received_events","type":"User","site_admin":false},"repo":{"id":63115452,"name":"DefinitelyTyped","full_name":"garthk/DefinitelyTyped","owner":{"login":"garthk","id":15906,"avatar_url":"https://avatars2.githubusercontent.com/u/15906?v=4","gravatar_id":"","url":"https://api.github.com/users/garthk","html_url":"https://github.com/garthk","followers_url":"https://api.github.com/users/garthk/followers","following_url":"https://api.github.com/users/garthk/following{/other_user}","gists_url":"https://api.github.com/users/garthk/gists{/gist_id}","starred_url":"https://api.github.com/users/garthk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthk/subscriptions","organizations_url":"https://api.github.com/users/garthk/orgs","repos_url":"https://api.github.com/users/garthk/repos","events_url":"https://api.github.com/users/garthk/events{/privacy}","received_events_url":"https://api.github.com/users/garthk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garthk/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/garthk/DefinitelyTyped","forks_url":"https://api.github.com/repos/garthk/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/garthk/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garthk/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garthk/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/garthk/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/garthk/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/garthk/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/garthk/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/garthk/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/garthk/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/garthk/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garthk/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garthk/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/garthk/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garthk/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/garthk/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/garthk/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/garthk/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/garthk/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/garthk/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/garthk/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/garthk/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/garthk/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/garthk/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/garthk/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/garthk/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garthk/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/garthk/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garthk/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/garthk/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/garthk/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/garthk/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/garthk/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garthk/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/garthk/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/garthk/DefinitelyTyped/deployments","created_at":"2016-07-12T01:37:35Z","updated_at":"2016-07-12T01:37:43Z","pushed_at":"2018-02-07T04:26:59Z","git_url":"git://github.com/garthk/DefinitelyTyped.git","ssh_url":"git@github.com:garthk/DefinitelyTyped.git","clone_url":"https://github.com/garthk/DefinitelyTyped.git","svn_url":"https://github.com/garthk/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":273550,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"a593fd2d6018474681bdb0e9e85bd85c8a04fed5","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-02-07T11:29:10Z","pushed_at":"2018-02-07T12:39:36Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":280777,"stargazers_count":14183,"watchers_count":14183,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11798,"mirror_url":null,"archived":false,"open_issues_count":2013,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11798,"open_issues":2013,"watchers":14183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23471"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23471"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23471"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23471/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23471/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23471/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/499d248746c7a3875d7322f78000ad00c8e51af4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CodeAnimal"}}