{"action":"created","issue":{"url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/594","repository_url":"https://api.github.com/repos/SixLabors/ImageSharp","labels_url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/594/labels{/name}","comments_url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/594/comments","events_url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/594/events","html_url":"https://github.com/SixLabors/ImageSharp/issues/594","id":325914760,"number":594,"title":"Investigate skipped tests in PackedPixelTests","user":{"login":"antonfirsov","id":6835152,"avatar_url":"https://avatars2.githubusercontent.com/u/6835152?v=4","gravatar_id":"","url":"https://api.github.com/users/antonfirsov","html_url":"https://github.com/antonfirsov","followers_url":"https://api.github.com/users/antonfirsov/followers","following_url":"https://api.github.com/users/antonfirsov/following{/other_user}","gists_url":"https://api.github.com/users/antonfirsov/gists{/gist_id}","starred_url":"https://api.github.com/users/antonfirsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonfirsov/subscriptions","organizations_url":"https://api.github.com/users/antonfirsov/orgs","repos_url":"https://api.github.com/users/antonfirsov/repos","events_url":"https://api.github.com/users/antonfirsov/events{/privacy}","received_events_url":"https://api.github.com/users/antonfirsov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-23T23:46:42Z","updated_at":"2018-05-24T18:15:29Z","closed_at":null,"author_association":"MEMBER","body":"### Prerequisites\r\n\r\n- [x] I have written a descriptive issue title\r\n- [x] I have verified that I am running the latest version of ImageSharp\r\n- [x] I have verified if the problem exist in both `DEBUG` and `RELEASE` mode\r\n- [x] I have searched [open](https://github.com/SixLabors/ImageSharp/issues) and [closed](https://github.com/SixLabors/ImageSharp/issues?q=is%3Aissue+is%3Aclosed) issues to ensure it has not already been reported\r\n\r\n### Description\r\nIssue opened for a reason similar to #576:\r\nHad to skip some (less valuable) tests on travis/linux to finish the work on #585:  `NormalizedShort4`, `Short4`, `NormalizedByte4` all in  `PackedPixelTests`. Previously had to skip `PackedPixelTests.Rgba64` for a similar reason.\r\n\r\nI have a feeling that this time it's not the CLR, these tests seem to depend on implementation specific details for me. They are also poorly isolated (not AAA), that makes them harder to troubleshoot.\r\n\r\n### Steps to Reproduce\r\nUnskip tests & run travis build. (It might be enough to do a local execution on Linux).\r\n\r\nSee: [failing build log](https://gist.github.com/antonfirsov/2606a188a023feab07ce8c946e70f8a4)"},"comment":{"url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/comments/391810574","html_url":"https://github.com/SixLabors/ImageSharp/issues/594#issuecomment-391810574","issue_url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/594","id":391810574,"user":{"login":"brianpopow","id":38701097,"avatar_url":"https://avatars2.githubusercontent.com/u/38701097?v=4","gravatar_id":"","url":"https://api.github.com/users/brianpopow","html_url":"https://github.com/brianpopow","followers_url":"https://api.github.com/users/brianpopow/followers","following_url":"https://api.github.com/users/brianpopow/following{/other_user}","gists_url":"https://api.github.com/users/brianpopow/gists{/gist_id}","starred_url":"https://api.github.com/users/brianpopow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianpopow/subscriptions","organizations_url":"https://api.github.com/users/brianpopow/orgs","repos_url":"https://api.github.com/users/brianpopow/repos","events_url":"https://api.github.com/users/brianpopow/events{/privacy}","received_events_url":"https://api.github.com/users/brianpopow/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T18:15:29Z","updated_at":"2018-05-24T18:15:29Z","author_association":"CONTRIBUTOR","body":"Hi Anton and James,  \r\n\r\ni have tried to figure out this issue and it seems similar to #576, because it fails also only in Release build not on debug. \r\n\r\nOne differnce between Debug and Release is AggressiveInlining, so i thought i might give it a try and disable it and indeed disabling it in NormalizedShort4, Short4, NormalizedByte4  on the method ToByteScaledVector4 seems to fix this issue. \r\n\r\nI can not completely explain yet why this AggressiveInlining at that specific method is causing it. I found some similar issue: https://github.com/dotnet/roslyn/issues/21323\r\nbut this is windows and not linux (on windows this does not happen again)\r\n\r\nI could provide an PR, if you think disabling AggressiveInlining on this specific method is a viable workaround for this,"}}
{"actor":{"display_login":"brianpopow"}}