{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/lsp4j/issues/227","repository_url":"https://api.github.com/repos/eclipse/lsp4j","labels_url":"https://api.github.com/repos/eclipse/lsp4j/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/lsp4j/issues/227/comments","events_url":"https://api.github.com/repos/eclipse/lsp4j/issues/227/events","html_url":"https://github.com/eclipse/lsp4j/issues/227","id":351193352,"node_id":"MDU6SXNzdWUzNTExOTMzNTI=","number":227,"title":"Debug Adapter Protocol: Response messages do not contain required success key","user":{"login":"fwcd","id":30873659,"node_id":"MDQ6VXNlcjMwODczNjU5","avatar_url":"https://avatars2.githubusercontent.com/u/30873659?v=4","gravatar_id":"","url":"https://api.github.com/users/fwcd","html_url":"https://github.com/fwcd","followers_url":"https://api.github.com/users/fwcd/followers","following_url":"https://api.github.com/users/fwcd/following{/other_user}","gists_url":"https://api.github.com/users/fwcd/gists{/gist_id}","starred_url":"https://api.github.com/users/fwcd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwcd/subscriptions","organizations_url":"https://api.github.com/users/fwcd/orgs","repos_url":"https://api.github.com/users/fwcd/repos","events_url":"https://api.github.com/users/fwcd/events{/privacy}","received_events_url":"https://api.github.com/users/fwcd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jonahgraham","id":679236,"node_id":"MDQ6VXNlcjY3OTIzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/679236?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahgraham","html_url":"https://github.com/jonahgraham","followers_url":"https://api.github.com/users/jonahgraham/followers","following_url":"https://api.github.com/users/jonahgraham/following{/other_user}","gists_url":"https://api.github.com/users/jonahgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahgraham/subscriptions","organizations_url":"https://api.github.com/users/jonahgraham/orgs","repos_url":"https://api.github.com/users/jonahgraham/repos","events_url":"https://api.github.com/users/jonahgraham/events{/privacy}","received_events_url":"https://api.github.com/users/jonahgraham/received_events","type":"User","site_admin":false},"assignees":[{"login":"jonahgraham","id":679236,"node_id":"MDQ6VXNlcjY3OTIzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/679236?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahgraham","html_url":"https://github.com/jonahgraham","followers_url":"https://api.github.com/users/jonahgraham/followers","following_url":"https://api.github.com/users/jonahgraham/following{/other_user}","gists_url":"https://api.github.com/users/jonahgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahgraham/subscriptions","organizations_url":"https://api.github.com/users/jonahgraham/orgs","repos_url":"https://api.github.com/users/jonahgraham/repos","events_url":"https://api.github.com/users/jonahgraham/events{/privacy}","received_events_url":"https://api.github.com/users/jonahgraham/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-08-16T12:55:47Z","updated_at":"2018-08-16T14:17:27Z","closed_at":null,"author_association":"NONE","body":"This is a sample JSON response from my debug adapter:\r\n\r\n![image](https://user-images.githubusercontent.com/30873659/44209568-30a94000-a164-11e8-8b19-a843e3b39219.png)\r\n\r\nThe specification - however - requires a `success` keyword:\r\n\r\n```typescript\r\ninterface Response extends ProtocolMessage {\r\n  type: 'response';\r\n\r\n  /**\r\n   * Sequence number of the corresponding request.\r\n   */\r\n  request_seq: number;\r\n\r\n  /**\r\n   * Outcome of the request.\r\n   */\r\n  success: boolean;\r\n\r\n  /**\r\n   * The command requested.\r\n   */\r\n  command: string;\r\n\r\n  /**\r\n   * Contains error message if success == false.\r\n   */\r\n  message?: string;\r\n\r\n  /**\r\n   * Contains request result if success is true and optional error details if success is false.\r\n   */\r\n  body?: any;\r\n}\r\n```\r\n\r\nSee https://microsoft.github.io/debug-adapter-protocol/specification#Base_Protocol_Response"},"comment":{"url":"https://api.github.com/repos/eclipse/lsp4j/issues/comments/413561391","html_url":"https://github.com/eclipse/lsp4j/issues/227#issuecomment-413561391","issue_url":"https://api.github.com/repos/eclipse/lsp4j/issues/227","id":413561391,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzU2MTM5MQ==","user":{"login":"jonahgraham","id":679236,"node_id":"MDQ6VXNlcjY3OTIzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/679236?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahgraham","html_url":"https://github.com/jonahgraham","followers_url":"https://api.github.com/users/jonahgraham/followers","following_url":"https://api.github.com/users/jonahgraham/following{/other_user}","gists_url":"https://api.github.com/users/jonahgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahgraham/subscriptions","organizations_url":"https://api.github.com/users/jonahgraham/orgs","repos_url":"https://api.github.com/users/jonahgraham/repos","events_url":"https://api.github.com/users/jonahgraham/events{/privacy}","received_events_url":"https://api.github.com/users/jonahgraham/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T14:17:27Z","updated_at":"2018-08-16T14:17:27Z","author_association":"CONTRIBUTOR","body":"Thanks, your suggestion looks right. I think there is also a related issue that a missing success field in the response parsing means the message is assume to be successful, when it should be treated as unsuccessful. "}}
{"actor":{"display_login":"jonahgraham"}}