{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/vmware/cascade/pulls/39","id":234718209,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzE4MjA5","html_url":"https://github.com/vmware/cascade/pull/39","diff_url":"https://github.com/vmware/cascade/pull/39.diff","patch_url":"https://github.com/vmware/cascade/pull/39.patch","issue_url":"https://api.github.com/repos/vmware/cascade/issues/39","number":39,"state":"closed","locked":false,"title":"Support bison 3.1.2","user":{"login":"no2chem","id":6496984,"node_id":"MDQ6VXNlcjY0OTY5ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6496984?v=4","gravatar_id":"","url":"https://api.github.com/users/no2chem","html_url":"https://github.com/no2chem","followers_url":"https://api.github.com/users/no2chem/followers","following_url":"https://api.github.com/users/no2chem/following{/other_user}","gists_url":"https://api.github.com/users/no2chem/gists{/gist_id}","starred_url":"https://api.github.com/users/no2chem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no2chem/subscriptions","organizations_url":"https://api.github.com/users/no2chem/orgs","repos_url":"https://api.github.com/users/no2chem/repos","events_url":"https://api.github.com/users/no2chem/events{/privacy}","received_events_url":"https://api.github.com/users/no2chem/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nDescription: This PR fixes an issues with bison 3.1.2, where the build fails due to\r\n```\r\nfatal error: too many arguments provided to function-like macro invocation\r\n```\r\n\r\nAs documented in issue #33, this is because Bison 3.1.2 uses a new `YY_RVREF` macro, which passes the arguments to the preprocessor. Unfortunately, the preprocessor doesn't know about types and thinks the comma in the std::pair is the second argument, resulting in the too many arguments error.\r\n\r\nThis PR adds typedefs to replace the usage of std::pair, fixing the issue. \r\n\r\nRelated issue(s) (if applicable): Fixes #33\r\n\r\n## Checklist (Definition of Done):\r\n\r\n- [x] There are no TODOs left in the code\r\n- [x] Change is covered by automated tests\r\n","created_at":"2018-11-29T17:11:13Z","updated_at":"2018-11-30T19:33:41Z","closed_at":"2018-11-30T19:33:41Z","merged_at":"2018-11-30T19:33:41Z","merge_commit_sha":"6ad0023ad249933bd9d35acbfa6c57229d69f670","assignee":{"login":"no2chem","id":6496984,"node_id":"MDQ6VXNlcjY0OTY5ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6496984?v=4","gravatar_id":"","url":"https://api.github.com/users/no2chem","html_url":"https://github.com/no2chem","followers_url":"https://api.github.com/users/no2chem/followers","following_url":"https://api.github.com/users/no2chem/following{/other_user}","gists_url":"https://api.github.com/users/no2chem/gists{/gist_id}","starred_url":"https://api.github.com/users/no2chem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no2chem/subscriptions","organizations_url":"https://api.github.com/users/no2chem/orgs","repos_url":"https://api.github.com/users/no2chem/repos","events_url":"https://api.github.com/users/no2chem/events{/privacy}","received_events_url":"https://api.github.com/users/no2chem/received_events","type":"User","site_admin":false},"assignees":[{"login":"no2chem","id":6496984,"node_id":"MDQ6VXNlcjY0OTY5ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6496984?v=4","gravatar_id":"","url":"https://api.github.com/users/no2chem","html_url":"https://github.com/no2chem","followers_url":"https://api.github.com/users/no2chem/followers","following_url":"https://api.github.com/users/no2chem/following{/other_user}","gists_url":"https://api.github.com/users/no2chem/gists{/gist_id}","starred_url":"https://api.github.com/users/no2chem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no2chem/subscriptions","organizations_url":"https://api.github.com/users/no2chem/orgs","repos_url":"https://api.github.com/users/no2chem/repos","events_url":"https://api.github.com/users/no2chem/events{/privacy}","received_events_url":"https://api.github.com/users/no2chem/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/cascade/pulls/39/commits","review_comments_url":"https://api.github.com/repos/vmware/cascade/pulls/39/comments","review_comment_url":"https://api.github.com/repos/vmware/cascade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/cascade/issues/39/comments","statuses_url":"https://api.github.com/repos/vmware/cascade/statuses/363d32b878da075a7a31139e4302e1a69d2fd96a","head":{"label":"vmware:bison312","ref":"bison312","sha":"363d32b878da075a7a31139e4302e1a69d2fd96a","user":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":147731281,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3MzEyODE=","name":"cascade","full_name":"vmware/cascade","private":false,"owner":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vmware/cascade","description":"A Just-In-Time Compiler for Verilog","fork":false,"url":"https://api.github.com/repos/vmware/cascade","forks_url":"https://api.github.com/repos/vmware/cascade/forks","keys_url":"https://api.github.com/repos/vmware/cascade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/cascade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/cascade/teams","hooks_url":"https://api.github.com/repos/vmware/cascade/hooks","issue_events_url":"https://api.github.com/repos/vmware/cascade/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/cascade/events","assignees_url":"https://api.github.com/repos/vmware/cascade/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/cascade/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/cascade/tags","blobs_url":"https://api.github.com/repos/vmware/cascade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/cascade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/cascade/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/cascade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/cascade/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/cascade/languages","stargazers_url":"https://api.github.com/repos/vmware/cascade/stargazers","contributors_url":"https://api.github.com/repos/vmware/cascade/contributors","subscribers_url":"https://api.github.com/repos/vmware/cascade/subscribers","subscription_url":"https://api.github.com/repos/vmware/cascade/subscription","commits_url":"https://api.github.com/repos/vmware/cascade/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/cascade/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/cascade/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/cascade/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/cascade/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/cascade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/cascade/merges","archive_url":"https://api.github.com/repos/vmware/cascade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/cascade/downloads","issues_url":"https://api.github.com/repos/vmware/cascade/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/cascade/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/cascade/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/cascade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/cascade/labels{/name}","releases_url":"https://api.github.com/repos/vmware/cascade/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/cascade/deployments","created_at":"2018-09-06T20:43:23Z","updated_at":"2018-11-29T22:51:40Z","pushed_at":"2018-11-30T19:33:41Z","git_url":"git://github.com/vmware/cascade.git","ssh_url":"git@github.com:vmware/cascade.git","clone_url":"https://github.com/vmware/cascade.git","svn_url":"https://github.com/vmware/cascade","homepage":null,"size":11175,"stargazers_count":194,"watchers_count":194,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":10,"watchers":194,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"f8b51297cdc6bc19a8e2a06a5426f7b1f7b20a01","user":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":147731281,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3MzEyODE=","name":"cascade","full_name":"vmware/cascade","private":false,"owner":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vmware/cascade","description":"A Just-In-Time Compiler for Verilog","fork":false,"url":"https://api.github.com/repos/vmware/cascade","forks_url":"https://api.github.com/repos/vmware/cascade/forks","keys_url":"https://api.github.com/repos/vmware/cascade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/cascade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/cascade/teams","hooks_url":"https://api.github.com/repos/vmware/cascade/hooks","issue_events_url":"https://api.github.com/repos/vmware/cascade/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/cascade/events","assignees_url":"https://api.github.com/repos/vmware/cascade/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/cascade/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/cascade/tags","blobs_url":"https://api.github.com/repos/vmware/cascade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/cascade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/cascade/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/cascade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/cascade/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/cascade/languages","stargazers_url":"https://api.github.com/repos/vmware/cascade/stargazers","contributors_url":"https://api.github.com/repos/vmware/cascade/contributors","subscribers_url":"https://api.github.com/repos/vmware/cascade/subscribers","subscription_url":"https://api.github.com/repos/vmware/cascade/subscription","commits_url":"https://api.github.com/repos/vmware/cascade/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/cascade/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/cascade/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/cascade/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/cascade/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/cascade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/cascade/merges","archive_url":"https://api.github.com/repos/vmware/cascade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/cascade/downloads","issues_url":"https://api.github.com/repos/vmware/cascade/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/cascade/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/cascade/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/cascade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/cascade/labels{/name}","releases_url":"https://api.github.com/repos/vmware/cascade/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/cascade/deployments","created_at":"2018-09-06T20:43:23Z","updated_at":"2018-11-29T22:51:40Z","pushed_at":"2018-11-30T19:33:41Z","git_url":"git://github.com/vmware/cascade.git","ssh_url":"git@github.com:vmware/cascade.git","clone_url":"https://github.com/vmware/cascade.git","svn_url":"https://github.com/vmware/cascade","homepage":null,"size":11175,"stargazers_count":194,"watchers_count":194,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":10,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/cascade/pulls/39"},"html":{"href":"https://github.com/vmware/cascade/pull/39"},"issue":{"href":"https://api.github.com/repos/vmware/cascade/issues/39"},"comments":{"href":"https://api.github.com/repos/vmware/cascade/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/cascade/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/cascade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/cascade/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/cascade/statuses/363d32b878da075a7a31139e4302e1a69d2fd96a"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"eschkufz","id":637102,"node_id":"MDQ6VXNlcjYzNzEwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/637102?v=4","gravatar_id":"","url":"https://api.github.com/users/eschkufz","html_url":"https://github.com/eschkufz","followers_url":"https://api.github.com/users/eschkufz/followers","following_url":"https://api.github.com/users/eschkufz/following{/other_user}","gists_url":"https://api.github.com/users/eschkufz/gists{/gist_id}","starred_url":"https://api.github.com/users/eschkufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschkufz/subscriptions","organizations_url":"https://api.github.com/users/eschkufz/orgs","repos_url":"https://api.github.com/users/eschkufz/repos","events_url":"https://api.github.com/users/eschkufz/events{/privacy}","received_events_url":"https://api.github.com/users/eschkufz/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"eschkufz"}}