{"action":"created","comment":{"url":"https://api.github.com/repos/knative/build-pipeline/pulls/comments/216103266","pull_request_review_id":153522884,"id":216103266,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjEwMzI2Ng==","diff_hunk":"@@ -0,0 +1,118 @@\n+/*\n+Copyright 2018 The Knative Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package v1beta1\n+\n+import (\n+\tcorev1 \"k8s.io/api/core/v1\"\n+\tmetav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+)\n+\n+// EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!\n+// NOTE: json tags are required.  Any new fields you add must have json tags for the fields to be serialized.\n+\n+// PipelineRunSpec defines the desired state of PipelineRun\n+type PipelineRunSpec struct {\n+\t// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster\n+\t// Important: Run \"make\" to regenerate code after modifying this file\n+}\n+\n+// PipelineRunStatus defines the observed state of PipelineRun\n+type PipelineRunStatus struct {\n+\tTaskRuns   []PipelineTaskRun      `json:\"taskRuns,omitempty\"`\n+\tConditions []PipelineRunCondition `json:\"conditions\"`\n+}\n+\n+// +genclient\n+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n+\n+// PipelineRun is the Schema for the pipelineruns API\n+// +k8s:openapi-gen=true\n+type PipelineRun struct {\n+\tmetav1.TypeMeta   `json:\",inline\"`\n+\tmetav1.ObjectMeta `json:\"metadata,omitempty\"`\n+\n+\tSpec   PipelineRunSpec   `json:\"spec,omitempty\"`\n+\tStatus PipelineRunStatus `json:\"status,omitempty\"`\n+}\n+\n+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n+\n+// PipelineRunList contains a list of PipelineRun\n+type PipelineRunList struct {\n+\tmetav1.TypeMeta `json:\",inline\"`\n+\tmetav1.ListMeta `json:\"metadata,omitempty\"`\n+\tItems           []PipelineRun `json:\"items\"`\n+}\n+\n+// PipelineTaskRun reports the results of running a step in the Task. Each\n+// task has the potential to succeed or fail (based on the exit code)\n+// and produces logs.\n+type PipelineTaskRun struct {\n+\tName string `json:\"name\"`\n+}\n+\n+// PipelineTaskRunRef refers to a TaskRun and also indicates which TaskRuns\n+// executed before and after it.\n+type PipelineTaskRunRef struct {\n+\tTaskRunRef\n+\tNextTasks []TaskRunRef `json:\"nextTasks\"`\n+\tPrevTasks []TaskRunRef `json:\"prevTasks\"`\n+}\n+\n+// TaskRunRef can be used to refer to a specific instance of a TaskRun.\n+// Copied from CrossVersionObjectReference: https://github.com/kubernetes/kubernetes/blob/169df7434155cbbc22f1532cba8e0a9588e29ad8/pkg/apis/autoscaling/types.go#L64\n+type TaskRunRef struct {\n+\t// Name of the referent; More info: http://kubernetes.io/docs/user-guide/identifiers#names\n+\tName string `json:\"name\"`\n+\t// API version of the referent\n+\tAPIVersion string `json:\"apiVersion,omitempty\"`\n+}\n+\n+// PipelineRunConditionType indicates the status of the execution of the PipelineRun.\n+type PipelineRunConditionType string\n+\n+const (\n+\t// PipelineRunConditionTypeStarted indicates whether or not the PipelineRun\n+\t// has started actually executing.\n+\tPipelineRunConditionTypeStarted PipelineRunConditionType = \"Started\"\n+\n+\t//PipelineRunConditionTypeCompleted indicates whether or not the PipelineRun\n+\t// has finished executing.\n+\tPipelineRunConditionTypeCompleted PipelineRunConditionType = \"Completed\"\n+\n+\t// PipelineRunConditionTypeSucceeded indicates whether or not the PipelineRun\n+\t// was successful.\n+\tPipelineRunConditionTypeSucceeded PipelineRunConditionType = \"Successful\"\n+)\n+\n+// PipelineRunCondition holds a Condition that the PipelineRun has entered into while being executed.\n+type PipelineRunCondition struct {\n+\tType PipelineRunConditionType `json:\"type\"`\n+\n+\tStatus corev1.ConditionStatus `json:\"status\"`\n+\n+\t// TODO(bobcatfish): when I use `metav1.Time` here I can't figure out\n+\t// how to serialize :(\n+\tLastTransitionTime string `json:\"lastTransitionTime\"`\n+","path":"pkg/apis/pipeline/v1beta1/pipelinerun_types.go","position":null,"original_position":111,"commit_id":"519d718ceb38420ccabcc53793c998aa16ab4a4a","original_commit_id":"362223b2230204ce272120ca738161b2f233c9a0","user":{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"body":"not sure what the issue was prior, changing to metav1.Time appears to be working now.  made this change in the PR","created_at":"2018-09-07T22:37:03Z","updated_at":"2018-09-07T22:37:03Z","html_url":"https://github.com/knative/build-pipeline/pull/2#discussion_r216103266","pull_request_url":"https://api.github.com/repos/knative/build-pipeline/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/comments/216103266"},"html":{"href":"https://github.com/knative/build-pipeline/pull/2#discussion_r216103266"},"pull_request":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/2"}},"in_reply_to_id":215756945},"pull_request":{"url":"https://api.github.com/repos/knative/build-pipeline/pulls/2","id":213701194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzAxMTk0","html_url":"https://github.com/knative/build-pipeline/pull/2","diff_url":"https://github.com/knative/build-pipeline/pull/2.diff","patch_url":"https://github.com/knative/build-pipeline/pull/2.patch","issue_url":"https://api.github.com/repos/knative/build-pipeline/issues/2","number":2,"state":"open","locked":false,"title":"Add types","user":{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"body":"This PR adds the basic Pipeline CRD types from the strawman examples.  The types were created from a kubebuilder scaffold.  These CRDs include:\r\nPipeline\r\nPipelineRun\r\nPipelineParams\r\nTask\r\nTaskRun\r\n\r\nTo install the types into a cluster you can use:\r\n`make install`\r\n\r\nTo run the test suite:\r\n`make test`\r\n\r\nFor more info on kubebuilder see:\r\nhttps://book.kubebuilder.io/quick_start.html\r\n","created_at":"2018-09-06T17:57:16Z","updated_at":"2018-09-07T22:37:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cae233ae21084d0f4e99bbb9057bfa08eaa13b05","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/knative/build-pipeline/pulls/2/commits","review_comments_url":"https://api.github.com/repos/knative/build-pipeline/pulls/2/comments","review_comment_url":"https://api.github.com/repos/knative/build-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/build-pipeline/issues/2/comments","statuses_url":"https://api.github.com/repos/knative/build-pipeline/statuses/519d718ceb38420ccabcc53793c998aa16ab4a4a","head":{"label":"aaron-prindle:add-types","ref":"add-types","sha":"519d718ceb38420ccabcc53793c998aa16ab4a4a","user":{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"repo":{"id":147589047,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1ODkwNDc=","name":"build-pipeline","full_name":"aaron-prindle/build-pipeline","owner":{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaron-prindle/build-pipeline","description":"A K8s-native Pipeline resource.","fork":true,"url":"https://api.github.com/repos/aaron-prindle/build-pipeline","forks_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/forks","keys_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/teams","hooks_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/hooks","issue_events_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/events","assignees_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/tags","blobs_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/languages","stargazers_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/stargazers","contributors_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/contributors","subscribers_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/subscribers","subscription_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/subscription","commits_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/merges","archive_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/downloads","issues_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/aaron-prindle/build-pipeline/deployments","created_at":"2018-09-05T23:01:12Z","updated_at":"2018-09-06T18:20:56Z","pushed_at":"2018-09-07T22:36:12Z","git_url":"git://github.com/aaron-prindle/build-pipeline.git","ssh_url":"git@github.com:aaron-prindle/build-pipeline.git","clone_url":"https://github.com/aaron-prindle/build-pipeline.git","svn_url":"https://github.com/aaron-prindle/build-pipeline","homepage":"","size":29666,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"e4e1a48328e06787f9ed0e7b087326e44ab8e7ab","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":146641150,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NDExNTA=","name":"build-pipeline","full_name":"knative/build-pipeline","owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/knative/build-pipeline","description":"A K8s-native Pipeline resource.","fork":false,"url":"https://api.github.com/repos/knative/build-pipeline","forks_url":"https://api.github.com/repos/knative/build-pipeline/forks","keys_url":"https://api.github.com/repos/knative/build-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/build-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/build-pipeline/teams","hooks_url":"https://api.github.com/repos/knative/build-pipeline/hooks","issue_events_url":"https://api.github.com/repos/knative/build-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/knative/build-pipeline/events","assignees_url":"https://api.github.com/repos/knative/build-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/knative/build-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/knative/build-pipeline/tags","blobs_url":"https://api.github.com/repos/knative/build-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/build-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/build-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/build-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/build-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/build-pipeline/languages","stargazers_url":"https://api.github.com/repos/knative/build-pipeline/stargazers","contributors_url":"https://api.github.com/repos/knative/build-pipeline/contributors","subscribers_url":"https://api.github.com/repos/knative/build-pipeline/subscribers","subscription_url":"https://api.github.com/repos/knative/build-pipeline/subscription","commits_url":"https://api.github.com/repos/knative/build-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/build-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/build-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/build-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/build-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/knative/build-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/build-pipeline/merges","archive_url":"https://api.github.com/repos/knative/build-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/build-pipeline/downloads","issues_url":"https://api.github.com/repos/knative/build-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/knative/build-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/build-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/build-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/build-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/knative/build-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/knative/build-pipeline/deployments","created_at":"2018-08-29T18:21:55Z","updated_at":"2018-09-07T21:05:22Z","pushed_at":"2018-09-07T22:36:14Z","git_url":"git://github.com/knative/build-pipeline.git","ssh_url":"git@github.com:knative/build-pipeline.git","clone_url":"https://github.com/knative/build-pipeline.git","svn_url":"https://github.com/knative/build-pipeline","homepage":"","size":109,"stargazers_count":8,"watchers_count":8,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/2"},"html":{"href":"https://github.com/knative/build-pipeline/pull/2"},"issue":{"href":"https://api.github.com/repos/knative/build-pipeline/issues/2"},"comments":{"href":"https://api.github.com/repos/knative/build-pipeline/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/knative/build-pipeline/statuses/519d718ceb38420ccabcc53793c998aa16ab4a4a"}},"author_association":"NONE"}}
{"actor":{"display_login":"aaron-prindle"}}