{"action":"created","comment":{"url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/comments/179517578","pull_request_review_id":109777015,"id":179517578,"diff_hunk":"@@ -0,0 +1,56 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<!--\n+  ~ \tCopyright (c) 2018. Toshi Inc\n+  ~\n+  ~ \tThis program is free software: you can redistribute it and/or modify\n+  ~     it under the terms of the GNU General Public License as published by\n+  ~     the Free Software Foundation, either version 3 of the License, or\n+  ~     (at your option) any later version.\n+  ~\n+  ~     This program is distributed in the hope that it will be useful,\n+  ~     but WITHOUT ANY WARRANTY; without even the implied warranty of\n+  ~     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+  ~     GNU General Public License for more details.\n+  ~\n+  ~     You should have received a copy of the GNU General Public License\n+  ~     along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+  -->\n+<LinearLayout xmlns:android=\"http://schemas.android.com/apk/res/android\"\n+    xmlns:tools=\"http://schemas.android.com/tools\"\n+    xmlns:app=\"http://schemas.android.com/apk/res-auto\"\n+    android:layout_height=\"wrap_content\"\n+    android:layout_width=\"match_parent\"\n+    android:orientation=\"vertical\">\n+\n+    <LinearLayout\n+        android:layout_width=\"match_parent\"\n+        android:layout_height=\"@dimen/list_item_height_default\"\n+        android:paddingLeft=\"@dimen/margin_primary\"\n+        android:paddingStart=\"@dimen/margin_primary\"\n+        android:paddingRight=\"@dimen/margin_primary\"\n+        android:paddingEnd=\"@dimen/margin_primary\"\n+        android:background=\"@color/windowBackground\"\n+        android:orientation=\"horizontal\">\n+\n+        <ImageView\n+            style=\"@style/CircleWithInsetIcon\"\n+            android:layout_marginRight=\"@dimen/margin_primary\"\n+            android:layout_marginEnd=\"@dimen/margin_primary\"\n+            android:layout_gravity=\"center_vertical\"\n+            app:srcCompat=\"@drawable/ic_search\"\n+            tools:ignore=\"ContentDescription\" />\n+\n+        <TextView\n+            android:layout_width=\"match_parent\"\n+            android:layout_height=\"wrap_content\"\n+            android:textColor=\"@color/colorPrimary\"\n+            android:layout_gravity=\"center_vertical\"\n+            android:textSize=\"@dimen/text_size_default\"\n+            android:text = \"@string/start_user_search\" />\n+\n+    </LinearLayout>\n+\n+    <android.support.v4.widget.Space","path":"app/src/main/res/layout/list_item__search_header.xml","position":53,"original_position":53,"commit_id":"f40c80f8373c983c84a604efe22fdbac0533bde7","original_commit_id":"f40c80f8373c983c84a604efe22fdbac0533bde7","user":{"login":"designatednerd","id":1976498,"avatar_url":"https://avatars1.githubusercontent.com/u/1976498?v=4","gravatar_id":"","url":"https://api.github.com/users/designatednerd","html_url":"https://github.com/designatednerd","followers_url":"https://api.github.com/users/designatednerd/followers","following_url":"https://api.github.com/users/designatednerd/following{/other_user}","gists_url":"https://api.github.com/users/designatednerd/gists{/gist_id}","starred_url":"https://api.github.com/users/designatednerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designatednerd/subscriptions","organizations_url":"https://api.github.com/users/designatednerd/orgs","repos_url":"https://api.github.com/users/designatednerd/repos","events_url":"https://api.github.com/users/designatednerd/events{/privacy}","received_events_url":"https://api.github.com/users/designatednerd/received_events","type":"User","site_admin":false},"body":"quick question for @martintoften or @csdodd: Why are we using the support library version of `Space` instead of the regular library version of it now that our min API > 14? ","created_at":"2018-04-05T16:09:27Z","updated_at":"2018-04-05T16:09:27Z","html_url":"https://github.com/toshiapp/toshi-android-client/pull/971#discussion_r179517578","pull_request_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/971","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/comments/179517578"},"html":{"href":"https://github.com/toshiapp/toshi-android-client/pull/971#discussion_r179517578"},"pull_request":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/971"}}},"pull_request":{"url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/971","id":179525943,"html_url":"https://github.com/toshiapp/toshi-android-client/pull/971","diff_url":"https://github.com/toshiapp/toshi-android-client/pull/971.diff","patch_url":"https://github.com/toshiapp/toshi-android-client/pull/971.patch","issue_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/971","number":971,"state":"open","locked":false,"title":"Chat Refactor 2: Moar Designier","user":{"login":"designatednerd","id":1976498,"avatar_url":"https://avatars1.githubusercontent.com/u/1976498?v=4","gravatar_id":"","url":"https://api.github.com/users/designatednerd","html_url":"https://github.com/designatednerd","followers_url":"https://api.github.com/users/designatednerd/followers","following_url":"https://api.github.com/users/designatednerd/following{/other_user}","gists_url":"https://api.github.com/users/designatednerd/gists{/gist_id}","starred_url":"https://api.github.com/users/designatednerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designatednerd/subscriptions","organizations_url":"https://api.github.com/users/designatednerd/orgs","repos_url":"https://api.github.com/users/designatednerd/repos","events_url":"https://api.github.com/users/designatednerd/events{/privacy}","received_events_url":"https://api.github.com/users/designatednerd/received_events","type":"User","site_admin":false},"body":"No conversations or requests: \r\n![screenshot_1522877101](https://user-images.githubusercontent.com/1976498/38337385-100b7b28-3833-11e8-8f05-34b7d2bd2d69.png)\r\n\r\nRequests but no conversations: \r\n![screenshot_1522877312](https://user-images.githubusercontent.com/1976498/38337411-1eee1e5c-3833-11e8-8e2e-f834800f76f8.png)\r\n\r\nRequests and conversations: \r\n![screenshot_1522879204](https://user-images.githubusercontent.com/1976498/38337418-26d256c4-3833-11e8-8280-56c09f25653b.png)\r\n\r\nConversations but no requests: \r\n![screenshot_1522879265](https://user-images.githubusercontent.com/1976498/38337369-03814234-3833-11e8-9b8e-c5e9a020ae70.png)\r\n\r\n\r\nStill to do, most likely in another view:\r\n- Figure out how to get the `selectableItemBackground` back on the rows, even with the background of the view itself being white\r\n- Either use `RecyclerView.ItemDecoration` to add dividers as shown in the designs, or refactor `list_item__recent.xml` to use a `ConstraintLayout` so I can just shove the dividers in there and have them line up where I want them to. a) is probably the right way, b) is probably the better way for the way we have this set up. \r\n- Anal-retentively update hard-coded dimens throughout the app because i love that boring shit","created_at":"2018-04-04T22:09:56Z","updated_at":"2018-04-05T16:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68840731ec60e98831e15f4a053d9b8c6cad4390","assignee":null,"assignees":[],"requested_reviewers":[{"login":"csdodd","id":4302925,"avatar_url":"https://avatars3.githubusercontent.com/u/4302925?v=4","gravatar_id":"","url":"https://api.github.com/users/csdodd","html_url":"https://github.com/csdodd","followers_url":"https://api.github.com/users/csdodd/followers","following_url":"https://api.github.com/users/csdodd/following{/other_user}","gists_url":"https://api.github.com/users/csdodd/gists{/gist_id}","starred_url":"https://api.github.com/users/csdodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csdodd/subscriptions","organizations_url":"https://api.github.com/users/csdodd/orgs","repos_url":"https://api.github.com/users/csdodd/repos","events_url":"https://api.github.com/users/csdodd/events{/privacy}","received_events_url":"https://api.github.com/users/csdodd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/971/commits","review_comments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/971/comments","review_comment_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/971/comments","statuses_url":"https://api.github.com/repos/toshiapp/toshi-android-client/statuses/f40c80f8373c983c84a604efe22fdbac0533bde7","head":{"label":"toshiapp:enhance/chat_new_ui","ref":"enhance/chat_new_ui","sha":"f40c80f8373c983c84a604efe22fdbac0533bde7","user":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"repo":{"id":75301435,"name":"toshi-android-client","full_name":"toshiapp/toshi-android-client","owner":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toshiapp/toshi-android-client","description":"Android client for Toshi","fork":false,"url":"https://api.github.com/repos/toshiapp/toshi-android-client","forks_url":"https://api.github.com/repos/toshiapp/toshi-android-client/forks","keys_url":"https://api.github.com/repos/toshiapp/toshi-android-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toshiapp/toshi-android-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toshiapp/toshi-android-client/teams","hooks_url":"https://api.github.com/repos/toshiapp/toshi-android-client/hooks","issue_events_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/events{/number}","events_url":"https://api.github.com/repos/toshiapp/toshi-android-client/events","assignees_url":"https://api.github.com/repos/toshiapp/toshi-android-client/assignees{/user}","branches_url":"https://api.github.com/repos/toshiapp/toshi-android-client/branches{/branch}","tags_url":"https://api.github.com/repos/toshiapp/toshi-android-client/tags","blobs_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toshiapp/toshi-android-client/statuses/{sha}","languages_url":"https://api.github.com/repos/toshiapp/toshi-android-client/languages","stargazers_url":"https://api.github.com/repos/toshiapp/toshi-android-client/stargazers","contributors_url":"https://api.github.com/repos/toshiapp/toshi-android-client/contributors","subscribers_url":"https://api.github.com/repos/toshiapp/toshi-android-client/subscribers","subscription_url":"https://api.github.com/repos/toshiapp/toshi-android-client/subscription","commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/toshiapp/toshi-android-client/contents/{+path}","compare_url":"https://api.github.com/repos/toshiapp/toshi-android-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toshiapp/toshi-android-client/merges","archive_url":"https://api.github.com/repos/toshiapp/toshi-android-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toshiapp/toshi-android-client/downloads","issues_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues{/number}","pulls_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls{/number}","milestones_url":"https://api.github.com/repos/toshiapp/toshi-android-client/milestones{/number}","notifications_url":"https://api.github.com/repos/toshiapp/toshi-android-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toshiapp/toshi-android-client/labels{/name}","releases_url":"https://api.github.com/repos/toshiapp/toshi-android-client/releases{/id}","deployments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/deployments","created_at":"2016-12-01T14:41:46Z","updated_at":"2018-04-05T15:36:36Z","pushed_at":"2018-04-05T16:06:57Z","git_url":"git://github.com/toshiapp/toshi-android-client.git","ssh_url":"git@github.com:toshiapp/toshi-android-client.git","clone_url":"https://github.com/toshiapp/toshi-android-client.git","svn_url":"https://github.com/toshiapp/toshi-android-client","homepage":"","size":9656,"stargazers_count":96,"watchers_count":96,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":42,"open_issues":7,"watchers":96,"default_branch":"master"}},"base":{"label":"toshiapp:master","ref":"master","sha":"74bac37fb20e5cb412cca2c6b91540e4522b2fde","user":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"repo":{"id":75301435,"name":"toshi-android-client","full_name":"toshiapp/toshi-android-client","owner":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toshiapp/toshi-android-client","description":"Android client for Toshi","fork":false,"url":"https://api.github.com/repos/toshiapp/toshi-android-client","forks_url":"https://api.github.com/repos/toshiapp/toshi-android-client/forks","keys_url":"https://api.github.com/repos/toshiapp/toshi-android-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toshiapp/toshi-android-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toshiapp/toshi-android-client/teams","hooks_url":"https://api.github.com/repos/toshiapp/toshi-android-client/hooks","issue_events_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/events{/number}","events_url":"https://api.github.com/repos/toshiapp/toshi-android-client/events","assignees_url":"https://api.github.com/repos/toshiapp/toshi-android-client/assignees{/user}","branches_url":"https://api.github.com/repos/toshiapp/toshi-android-client/branches{/branch}","tags_url":"https://api.github.com/repos/toshiapp/toshi-android-client/tags","blobs_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toshiapp/toshi-android-client/statuses/{sha}","languages_url":"https://api.github.com/repos/toshiapp/toshi-android-client/languages","stargazers_url":"https://api.github.com/repos/toshiapp/toshi-android-client/stargazers","contributors_url":"https://api.github.com/repos/toshiapp/toshi-android-client/contributors","subscribers_url":"https://api.github.com/repos/toshiapp/toshi-android-client/subscribers","subscription_url":"https://api.github.com/repos/toshiapp/toshi-android-client/subscription","commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/toshiapp/toshi-android-client/contents/{+path}","compare_url":"https://api.github.com/repos/toshiapp/toshi-android-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toshiapp/toshi-android-client/merges","archive_url":"https://api.github.com/repos/toshiapp/toshi-android-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toshiapp/toshi-android-client/downloads","issues_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues{/number}","pulls_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls{/number}","milestones_url":"https://api.github.com/repos/toshiapp/toshi-android-client/milestones{/number}","notifications_url":"https://api.github.com/repos/toshiapp/toshi-android-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toshiapp/toshi-android-client/labels{/name}","releases_url":"https://api.github.com/repos/toshiapp/toshi-android-client/releases{/id}","deployments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/deployments","created_at":"2016-12-01T14:41:46Z","updated_at":"2018-04-05T15:36:36Z","pushed_at":"2018-04-05T16:06:57Z","git_url":"git://github.com/toshiapp/toshi-android-client.git","ssh_url":"git@github.com:toshiapp/toshi-android-client.git","clone_url":"https://github.com/toshiapp/toshi-android-client.git","svn_url":"https://github.com/toshiapp/toshi-android-client","homepage":"","size":9656,"stargazers_count":96,"watchers_count":96,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":42,"open_issues":7,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/971"},"html":{"href":"https://github.com/toshiapp/toshi-android-client/pull/971"},"issue":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/971"},"comments":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/971/comments"},"review_comments":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/971/comments"},"review_comment":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/971/commits"},"statuses":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/statuses/f40c80f8373c983c84a604efe22fdbac0533bde7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"designatednerd"}}