{"action":"created","issue":{"url":"https://api.github.com/repos/api-platform/core/issues/1692","repository_url":"https://api.github.com/repos/api-platform/core","labels_url":"https://api.github.com/repos/api-platform/core/issues/1692/labels{/name}","comments_url":"https://api.github.com/repos/api-platform/core/issues/1692/comments","events_url":"https://api.github.com/repos/api-platform/core/issues/1692/events","html_url":"https://github.com/api-platform/core/pull/1692","id":295554092,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY4MDAzMzEw","number":1692,"title":"throw an exception if required filter is not set","user":{"login":"jdeniau","id":1398469,"node_id":"MDQ6VXNlcjEzOTg0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1398469?v=4","gravatar_id":"","url":"https://api.github.com/users/jdeniau","html_url":"https://github.com/jdeniau","followers_url":"https://api.github.com/users/jdeniau/followers","following_url":"https://api.github.com/users/jdeniau/following{/other_user}","gists_url":"https://api.github.com/users/jdeniau/gists{/gist_id}","starred_url":"https://api.github.com/users/jdeniau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdeniau/subscriptions","organizations_url":"https://api.github.com/users/jdeniau/orgs","repos_url":"https://api.github.com/users/jdeniau/repos","events_url":"https://api.github.com/users/jdeniau/events{/privacy}","received_events_url":"https://api.github.com/users/jdeniau/received_events","type":"User","site_admin":false},"labels":[{"id":453639309,"node_id":"MDU6TGFiZWw0NTM2MzkzMDk=","url":"https://api.github.com/repos/api-platform/core/labels/[RFR]%20Ready%20for%20Review","name":"[RFR] Ready for Review","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-02-08T15:27:21Z","updated_at":"2018-06-04T08:09:03Z","closed_at":"2018-06-04T08:08:56Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/api-platform/core/pulls/1692","html_url":"https://github.com/api-platform/core/pull/1692","diff_url":"https://github.com/api-platform/core/pull/1692.diff","patch_url":"https://github.com/api-platform/core/pull/1692.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | kind of\r\n| New feature?  | yes\r\n| BC breaks?    | if filter config was wrongly set to `required=true`\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #1627\r\n| License       | MIT\r\n| Doc PR        | Doc PR will follow if PR is approved\r\n\r\nThis PR is a start of query parameter validation.\r\n\r\nIt does only check `required=true` filter for now but I will open other PR to include [the rest of OpenAPI specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#parameter-object) on field validation.\r\n\r\nThere are some points that I am not really sure of:\r\n\r\n  * namespace of the new `QueryParameterValidateLister`: I put it in `Core\\Validator\\EventListener` but maybe in `Symfony\\Bridge` ?\r\n  * I set the priority of the event listener to 16, this way, it is the first event in the queue (according to [the documentation](https://api-platform.com/docs/core/events))\r\n\r\nOtherwise, the code is quite simple and leverage Symfony validation system.\r\n\r\nThanks !"},"comment":{"url":"https://api.github.com/repos/api-platform/core/issues/comments/394269666","html_url":"https://github.com/api-platform/core/pull/1692#issuecomment-394269666","issue_url":"https://api.github.com/repos/api-platform/core/issues/1692","id":394269666,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDI2OTY2Ng==","user":{"login":"soyuka","id":1321971,"node_id":"MDQ6VXNlcjEzMjE5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1321971?v=4","gravatar_id":"","url":"https://api.github.com/users/soyuka","html_url":"https://github.com/soyuka","followers_url":"https://api.github.com/users/soyuka/followers","following_url":"https://api.github.com/users/soyuka/following{/other_user}","gists_url":"https://api.github.com/users/soyuka/gists{/gist_id}","starred_url":"https://api.github.com/users/soyuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soyuka/subscriptions","organizations_url":"https://api.github.com/users/soyuka/orgs","repos_url":"https://api.github.com/users/soyuka/repos","events_url":"https://api.github.com/users/soyuka/events{/privacy}","received_events_url":"https://api.github.com/users/soyuka/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T08:09:03Z","updated_at":"2018-06-04T08:09:03Z","author_association":"MEMBER","body":"Thanks @jdeniau !"}}
{"actor":{"display_login":"soyuka"}}