{"push_id":2733369574,"size":147,"distinct_size":147,"ref":"refs/heads/prepare-upstream","head":"da94a548eb55cd4d081675445ddafff6c06daae4","before":"e06f58575f345ebea33a4ade9f00f66d53273c04","commits":[{"sha":"4b0c8b0136ee54e779b9eddf7ba00f6ecfeb9f6f","author":{"name":"Joe Tsai","email":"ad9e03fbec35106ba742f446a098eef3d5e31d20@digital-static.net"},"message":"archive/zip: fix regression when writing directories\n\nSeveral adjustments:\n\n1) When encoding the FileHeader for a directory, explicitly set all of the sizes\nto zero regardless of their prior values. These values are currently populated\nby FileInfoHeader as it calls os.FileInfo.Size regardless of whether the file is\na directory or not. We avoid fixing FileInfoHeader now as it is too late in the\nrelease cycle (see #24082).\n\nWe silently adjust slightly wrong FileHeader fields as opposed to returning\nan error because the CreateHeader method already does such mutations\n(e.g., for UTF-8 detection, data descriptor, etc).\n\n2) Have dirWriter.Write only return an error if some number of bytes are written.\nSome code still call Write for both normal files and directories, but just pass\nan empty []byte to Write for directories.\n\nChange-Id: I85492a31356107fcf76dc89ceb00a28853754289\nReviewed-on: https://go-review.googlesource.com/124155\nRun-TryBot: Joe Tsai <thebrokentoaster@gmail.com>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/4b0c8b0136ee54e779b9eddf7ba00f6ecfeb9f6f"},{"sha":"274fde9a36bf62f62f9ffda4b178df437649e8bf","author":{"name":"Ian Lance Taylor","email":"87e9c6d529889242b7e184afb632328636553ab4@golang.org"},"message":"cmd/internal/buildid: close ELF file after reading note\n\nUpdates #26400\n\nChange-Id: I1747d1f1018521cdfa4b3ed13412a944829967cf\nReviewed-on: https://go-review.googlesource.com/124235\nRun-TryBot: Ian Lance Taylor <iant@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/274fde9a36bf62f62f9ffda4b178df437649e8bf"},{"sha":"c2ba0ca80454d0d9fdf801619279bbbbe8f50748","author":{"name":"Russ Cox","email":"5ad239cb8a44f659eaaee0aa1ea5b94947abe557@golang.org"},"message":"cmd/go: handle relative temp dir\n\nMost programs seem to accept a relative temp dir, as weird as that might be.\n\nAlso, the meaning of relative is a little more fluid on Windows:\nTMP=\\temp is relative (to the current drive) but will work well enough.\n\nAlso, Windows GetTempPath automatically converts a relative\n%TMP% into an absolute path, so we'd be imposing different\nbehavior for GOTMPDIR vs TMP.\n\nIt seems easier and more consistent to just impose the obvious\nmeaning than to add an error we can only implement some of\nthe time.\n\nOriginally got here because \"cmd/go:\" should be\"go:\" in error message,\nbut the error message is gone now.\n\nFixes #23264.\n\nChange-Id: I3c3fb801cbd5e652364f1f62bb3881e9317e3581\nReviewed-on: https://go-review.googlesource.com/123876\nRun-TryBot: Russ Cox <rsc@golang.org>\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/c2ba0ca80454d0d9fdf801619279bbbbe8f50748"},{"sha":"6e4e29408aba3adbc1bfc3f474ab120f1c983ec2","author":{"name":"Eric Daniels","email":"96f164ad4d9b2b0dacf8ebee2bb1eeb3aa69adf1@erdaniels.com"},"message":"http/internal: document final CRLF behavior on chunkedWriter\n\nChange-Id: I0f76b40dbfda2d382c88aec377db1851c4ac7441\n\nChange-Id: I0f76b40dbfda2d382c88aec377db1851c4ac7441\nGitHub-Last-Rev: ab42559278d8cba9e025b431a459d117500a73da\nGitHub-Pull-Request: golang/go#26410\nReviewed-on: https://go-review.googlesource.com/124255\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/6e4e29408aba3adbc1bfc3f474ab120f1c983ec2"},{"sha":"0c319ee4fe655e3c8e7bf72bce572c989f565a53","author":{"name":"Zev Goldstein","email":"39fd15e55f0ebc779e52537755ba4ad0d17a1499@gmail.com"},"message":"cmd/go/internal/cache: squelch cache init warnings when $HOME is /\n\nDocker sets $HOME to / when running with a UID that doesn't exist within\nthe container.  This not  uncommon on CI servers.\n\nFixes #26280\n\nChange-Id: Ic7ff62b41403fe6e7c0cef12814667ef73f6c954\nReviewed-on: https://go-review.googlesource.com/122487\nRun-TryBot: Ian Lance Taylor <iant@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/0c319ee4fe655e3c8e7bf72bce572c989f565a53"},{"sha":"f17220c20818f93efa22287e6f0fa8bbd7b4e5c4","author":{"name":"Ian Lance Taylor","email":"87e9c6d529889242b7e184afb632328636553ab4@golang.org"},"message":"cmd/go: fix handling of vet.cfg with buggyInstall\n\nThe vet action assumes that a.Deps[0] is the compilation action for\nwhich vet information should be generated. However, when using\n-linkshared, the action graph is built with a ModeBuggyInstall action\nto install the shared library built from the compilation action.\nAdjust the set up of the vet action accordingly. Also don't clean up\nthe working directory after completing the buggy install.\n\nUpdates #26400\n\nChange-Id: Ia51f9f6b8cde5614a6f2e41b6207478951547770\nReviewed-on: https://go-review.googlesource.com/124275\nRun-TryBot: Ian Lance Taylor <iant@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Bryan C. Mills <bcmills@google.com>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/f17220c20818f93efa22287e6f0fa8bbd7b4e5c4"},{"sha":"c4f30481b3ee94746f6ae0fcb19cbe9adb3a937b","author":{"name":"Rob Pike","email":"4dc7c9ec434ed06502767136789763ec11d2c4b7@golang.org"},"message":"doc: rewrite run-on sentence in garbage collection discussion\n\nChange-Id: I60cb7010448757ca4c7a2973bee2277b3d5fc439\nReviewed-on: https://go-review.googlesource.com/124175\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/c4f30481b3ee94746f6ae0fcb19cbe9adb3a937b"},{"sha":"b59b42cee8c1ca209dafd952da872fd493b77405","author":{"name":"Rob Pike","email":"4dc7c9ec434ed06502767136789763ec11d2c4b7@golang.org"},"message":"doc: update Usage section of the FAQ\n\nThis is close to a complete rewrite, as the content was pretty old.\n\nThe CL includes links to the Wiki for information about companies\nusing Go, a new section about IDEs and editors¹, and a restatement\nof the foreign function interface story. It also modernizes and\nexpands a little on the use of Go inside Google.\n\n¹ Ed is the standard editor.\n\nChange-Id: I5e54aafa53d00d86297b2691960a376b40f6225b\nReviewed-on: https://go-review.googlesource.com/123922\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/b59b42cee8c1ca209dafd952da872fd493b77405"},{"sha":"5890e25b7ccb2d2249b2f8a02ef5dbc36047868b","author":{"name":"Russ Cox","email":"5ad239cb8a44f659eaaee0aa1ea5b94947abe557@golang.org"},"message":"cmd/go: add new test script facility\n\nThe original cmd/go tests were tiny shell scripts\nwritten against a library of shell functions.\nThey were okay to write but difficult to run:\nyou couldn't select individual tests (with -run)\nthey didn't run on Windows, they were slow, and so on.\n\nCL 10464 introduced go_test.go's testgo framework\nand later CLs translated the test shell script over to\nindividual go tests. This let us run tests selectively,\nrun tests on Windows, run tests in parallel, isolate\ndifferent tests, and so on. It was a big advance.\n\nThe tests had always been awkward to write.\nHere was the first test in test.bash:\n\n\tTEST 'file:line in error messages'\n\t# Test that error messages have file:line information at beginning of\n\t# the line. Also test issue 4917: that the error is on stderr.\n\td=$(TMPDIR=/var/tmp mktemp -d -t testgoXXX)\n\tfn=$d/err.go\n\techo \"package main\" > $fn\n\techo 'import \"bar\"' >> $fn\n\t./testgo run $fn 2>$d/err.out || true\n\tif ! grep -q \"^$fn:\" $d/err.out; then\n\t\techo \"missing file:line in error message\"\n\t\tcat $d/err.out\n\t\tok=false\n\tfi\n\trm -r $d\n\nThe final Go version of this test was:\n\n\tfunc TestFileLineInErrorMessages(t *testing.T) {\n\t\ttg := testgo(t)\n\t\tdefer tg.cleanup()\n\t\ttg.parallel()\n\t\ttg.tempFile(\"err.go\", `package main; import \"bar\"`)\n\t\tpath := tg.path(\"err.go\")\n\t\ttg.runFail(\"run\", path)\n\t\tshortPath := path\n\t\tif rel, err := filepath.Rel(tg.pwd(), path); err == nil && len(rel) < len(path) {\n\t\t\tshortPath = rel\n\t\t}\n\t\ttg.grepStderr(\"^\"+regexp.QuoteMeta(shortPath)+\":\", \"missing file:line in error message\")\n\t}\n\nIt's better but still quite difficult to skim.\n\nThis CL introduces a new facility meant as a successor to the testgo\napproach that brings back the style of writing tests as little scripts,\nbut they are now scripts in a built-for-purpose shell-like language,\nnot bash itself. In this new form, the test above is a single file,\ntestdata/script/fileline.txt:\n\n\t# look for short, relative file:line in error message\n\t! go run ../../gopath/x/y/z/err.go\n\tstderr ^..[\\\\/]x[\\\\/]y[\\\\/]z[\\\\/]err.go:\n\n\t-- ../x/y/z/err.go --\n\tpackage main; import \"bar\"\n\nThe file is a txtar text archive (see CL 123359) in which the leading comment\nis the test script and the files are the initial state of the temporary file\nsystem where the script runs.\n\nEach script runs as a subtest, so that they can still be selected individually.\n\nThe scripts are kept isolated from each other by default,\nso all script subtests are treated as parallel tests, for the\ntesting package to run in parallel. Even for the 15 tests in\nthis CL, that cuts the time for TestScript from 5.5s to 2.5s.\n\nThe scripts do not have access to the cmd/go source directory,\nnor to cmd/go/testdata, so they are prevented from creating temporary\nfiles in those places or modifying existing ones. (Many existing tests\nscribble in testdata, unfortunately, especially testdata/pkg when\nthey run builds with GOPATH=testdata.)\n\nThis CL introduces the script facility and converts 15 tests.\nThe txtar archive form will allow us to delete the large trees of trivial\nfiles in testdata; a few are deleted in this CL.\n\nSee testdata/script/README for details and a larger conversion example.\n\nAs part of converting testdata/script/test_badtest.txt,\nI discovered that 'go test' was incorrectly printing a FAIL line\nto stderr (not stdout) in one corner case. This CL fixes that\nto keep the test passing.\n\nFuture CLs will convert more tests.\n\nChange-Id: I11aa9e18dd2d4c7dcd8e310dbdc6a1ea5f7e54c1\nReviewed-on: https://go-review.googlesource.com/123577\nRun-TryBot: Russ Cox <rsc@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/5890e25b7ccb2d2249b2f8a02ef5dbc36047868b"},{"sha":"1546ab5a3925b07c86f05ccfa4c8b4c2b818790e","author":{"name":"Michael Munday","email":"19411bdeea90f848b8e02e9a1c63a7ce7cc699ea@ibm.com"},"message":"cmd/compile: keep autos if their address reaches a control value\n\nAutos must be kept if their address reaches the control value of a\nblock. We didn't see this before because it is rare for an auto's\naddress to reach a control value without also reaching a phi or\nbeing written to memory. We can probably optimize away the\ncomparisons that lead to this scenario since autos cannot alias\nwith pointers from elsewhere, however for now we take the\nconservative approach and just ensure the auto is properly\ninitialised if its address reaches a control value.\n\nFixes #26407.\n\nChange-Id: I02265793f010a9e001c3e1a5397c290c6769d4de\nReviewed-on: https://go-review.googlesource.com/124335\nReviewed-by: David Chase <drchase@google.com>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/1546ab5a3925b07c86f05ccfa4c8b4c2b818790e"},{"sha":"ff5b54d24a7fda589d3fc4516aa153a3f2e1a224","author":{"name":"Austin Clements","email":"7ea35d812706d9213868749011af1ed4fa2f6aa0@google.com"},"message":"runtime: disable compressed DWARF for lldb test\n\nlldb doesn't support compressed DWARF, so right now we're just always\nskipping the lldb test. This CL makes the test run again by disabling\ncompressed DWARF just for this test.\n\nUpdates #25925.\n\nChange-Id: Ib9ddc442305fe6d37060d48f36bc4458b6fd8c86\nReviewed-on: https://go-review.googlesource.com/124385\nRun-TryBot: Austin Clements <austin@google.com>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/ff5b54d24a7fda589d3fc4516aa153a3f2e1a224"},{"sha":"57b5a71d7c897a2f3a21ba8b875bb9264faed326","author":{"name":"Austin Clements","email":"7ea35d812706d9213868749011af1ed4fa2f6aa0@google.com"},"message":"Revert \"runtime: fix lldb test after DWARF compression\"\n\nThis reverts commit c99300229de4e69220790c71da14785dc52c3d68.\n\nThe original CL skipped the lldb test if it couldn't read compressed\nDWARF, but lldb can never read compressed DWARF, so this effectively\ndisabled this test unconditionally.\n\nThe previous commit disabled DWARF compression for this test, so the\ntest now works on its own merits again. This CL reverts the change to\nskip the test so we don't simply mask lldb failures.\n\nUpdates #25925.\n\nChange-Id: I3e1c787b658257b542c3c70807065dde9cfe05ee\nReviewed-on: https://go-review.googlesource.com/124386\nRun-TryBot: Austin Clements <austin@google.com>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/57b5a71d7c897a2f3a21ba8b875bb9264faed326"},{"sha":"bccbf59046b9d1289f3cbf0240d02b8ae550e0ac","author":{"name":"Alberto Donizetti","email":"90b16103a35511ced020676f3544f17117fb4c92@gmail.com"},"message":"doc/go1.11: explain new vet typechecking behaviour in release notes\n\nSince Go1.10, go test runs vet on the tests before executing them.\n\nMoreover, the vet tool typechecks the package under analysis with\ngo/types before running. In Go1.10, a typechecking failure just caused\na warning to be printed. In Go1.11, a typechecking failure will cause\nvet to exit with a fatal error (see Issue #21287).\n\nThis means that starting with Go1.11, tests that don't typecheck will\nfail immediately. This would not normally be an issue, since a test\nthat doesn't typecheck shouldn't even compile, and it should already\nbe broken.\n\nUnfortunately, there's a bug in gc that makes it accept programs with\nunused variables inside a closure (Issue #3059). This means that a\ntest with an unused variable inside a closure, that compiled and\npassed in Go1.10, will fail in the typechecking step of vet starting\nwith Go1.11.\n\nExplain this in the 1.11 release notes.\n\nFixes #26109\n\nChange-Id: I970c1033ab6bc985d8c64bd24f56e854af155f96\nReviewed-on: https://go-review.googlesource.com/121455\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/bccbf59046b9d1289f3cbf0240d02b8ae550e0ac"},{"sha":"5419e7a09d3ad91aa462621fc86752b092bf2718","author":{"name":"Steeve Morin","email":"7f3ba7bbc079b62d3fe54555c2b0ce0ddda2bb7c@gmail.com"},"message":"cmd/cgo: update JNI's jobject to uintptr check for newer Android NDKs\n\nIn Android's NDK16, jobject is now declared as:\n    #ifdef __cplusplus\n    class _jobject {};\n    typedef _jobject*       jobject;\n    #else /* not __cplusplus */\n    typedef void*           jobject;\n    #endif\n\nThis makes the jobject to uintptr check fail because it expects the\nfollowing definition:\n    struct _jobject;\n    typedef struct _jobject *jobject;\n\nUpdate the type check to handle that new type definition in both C and\nC++ modes.\n\nFixes #26213\n\nChange-Id: Ic36d4a5176526998d2d5e4e404f8943961141f7a\nGitHub-Last-Rev: 42037c3c584579c2b3281c25372b830e864e7aec\nGitHub-Pull-Request: golang/go#26221\nReviewed-on: https://go-review.googlesource.com/122217\nRun-TryBot: Ian Lance Taylor <iant@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Keith Randall <khr@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/5419e7a09d3ad91aa462621fc86752b092bf2718"},{"sha":"b9a764ffdfa0fd41be6b0cfcd889f2349b14e2b5","author":{"name":"Frank Schroeder","email":"b13e26791f2eb0e8cc598702fdfa3db887f5a8ed@gmail.com"},"message":"cmd/go: run git log with --no-show-signature\n\nGit timestamp parsing is broken when fetching modules if the\nlocal git configuration has 'log.showsignature=true'.\n\nFixes #26388\n\nChange-Id: I47f92381784072335a2a465de56092106c616108\nGitHub-Last-Rev: 96f988c0a2dd39a5747ec4a7bad05e7e8ee0d384\nGitHub-Pull-Request: golang/go#26389\nReviewed-on: https://go-review.googlesource.com/123958\nReviewed-by: Daniel Martí <mvdan@mvdan.cc>\nReviewed-by: Russ Cox <rsc@golang.org>\nRun-TryBot: Daniel Martí <mvdan@mvdan.cc>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/b9a764ffdfa0fd41be6b0cfcd889f2349b14e2b5"},{"sha":"a80a7f0e77fab42cebe61c43b98e0959b740def2","author":{"name":"Filippo Valsorda","email":"4f40cda291c5f9634e1affd3db44947af61f705c@golang.org"},"message":"doc: minor go1.11 changes\n\nCL 124135 follow-ups.\n\nChange-Id: Ib7e2066bd2d18851561e03386709a1b42b50fcef\nReviewed-on: https://go-review.googlesource.com/124136\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nReviewed-by: Andrew Bonventre <andybons@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/a80a7f0e77fab42cebe61c43b98e0959b740def2"},{"sha":"940811922fb528fabda91a2b2dbb401a06aeb1b3","author":{"name":"Mostyn Bramley-Moore","email":"e7b3521f6c488773b80d643b5f5ff7357eaedb70@antipode.se"},"message":"path/filepath: make Walk example runnable in the playground\n\nRelates to #9679\n\nChange-Id: I68951f664d2a03812dae309c580c181869d8af21\nReviewed-on: https://go-review.googlesource.com/122237\nRun-TryBot: Ian Lance Taylor <iant@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/940811922fb528fabda91a2b2dbb401a06aeb1b3"},{"sha":"61a04474e265151500148172f0bee1e5381e6fbf","author":{"name":"Austin Clements","email":"7ea35d812706d9213868749011af1ed4fa2f6aa0@google.com"},"message":"doc/go1.11: fix some typos\n\nChange-Id: I3c0cb9b56776d8cc78a96ef012385c31f9f0e146\nReviewed-on: https://go-review.googlesource.com/124516\nReviewed-by: Austin Clements <austin@google.com>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/61a04474e265151500148172f0bee1e5381e6fbf"},{"sha":"92e03bbaa8731a5857cf0a914f1483af36b781ea","author":{"name":"Austin Clements","email":"7ea35d812706d9213868749011af1ed4fa2f6aa0@google.com"},"message":"doc/go1.11: compiler and runtime release notes\n\nChange-Id: I487bdf0c828d28b2122bd93934dc5a9a5dbc6a00\nReviewed-on: https://go-review.googlesource.com/124517\nReviewed-by: Austin Clements <austin@google.com>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/92e03bbaa8731a5857cf0a914f1483af36b781ea"},{"sha":"3a28a711db15efd97c7675fccf0d2d0f2245a99b","author":{"name":"Rob Pike","email":"4dc7c9ec434ed06502767136789763ec11d2c4b7@golang.org"},"message":"doc: improve the garbage collection discussion\n\nBring it up to date with recent terminology, mention new approaches\nsuch as in Rust, and link to the new blog post.\n\nChange-Id: I1d0b121e6f8347c3cf2c8ca0d8adc8285ce59ef1\nReviewed-on: https://go-review.googlesource.com/124475\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/jordanrh1/go/commits/3a28a711db15efd97c7675fccf0d2d0f2245a99b"}]}
{"actor":{"display_login":"jordanrh1"}}