{"action":"created","comment":{"url":"https://api.github.com/repos/diablomedia/zf1/pulls/comments/173387222","pull_request_review_id":102558193,"id":173387222,"diff_hunk":"@@ -174,7 +164,7 @@ public function __isset($name)\n     public function __unset($name)\n     {\n         unset($this->_dynamicAttributes[$name]);\n-        return;\n+        return null;","path":"library/Zend/Tool/Framework/Metadata/Dynamic.php","position":22,"original_position":22,"commit_id":"7ef78e087850680b896d1679145dd20904644c84","original_commit_id":"7ef78e087850680b896d1679145dd20904644c84","user":{"login":"jaydiablo","id":136907,"avatar_url":"https://avatars0.githubusercontent.com/u/136907?v=4","gravatar_id":"","url":"https://api.github.com/users/jaydiablo","html_url":"https://github.com/jaydiablo","followers_url":"https://api.github.com/users/jaydiablo/followers","following_url":"https://api.github.com/users/jaydiablo/following{/other_user}","gists_url":"https://api.github.com/users/jaydiablo/gists{/gist_id}","starred_url":"https://api.github.com/users/jaydiablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaydiablo/subscriptions","organizations_url":"https://api.github.com/users/jaydiablo/orgs","repos_url":"https://api.github.com/users/jaydiablo/repos","events_url":"https://api.github.com/users/jaydiablo/events{/privacy}","received_events_url":"https://api.github.com/users/jaydiablo/received_events","type":"User","site_admin":false},"body":"null return","created_at":"2018-03-09T08:15:22Z","updated_at":"2018-03-09T08:22:04Z","html_url":"https://github.com/diablomedia/zf1/pull/17#discussion_r173387222","pull_request_url":"https://api.github.com/repos/diablomedia/zf1/pulls/17","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/diablomedia/zf1/pulls/comments/173387222"},"html":{"href":"https://github.com/diablomedia/zf1/pull/17#discussion_r173387222"},"pull_request":{"href":"https://api.github.com/repos/diablomedia/zf1/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/diablomedia/zf1/pulls/17","id":173871709,"html_url":"https://github.com/diablomedia/zf1/pull/17","diff_url":"https://github.com/diablomedia/zf1/pull/17.diff","patch_url":"https://github.com/diablomedia/zf1/pull/17.patch","issue_url":"https://api.github.com/repos/diablomedia/zf1/issues/17","number":17,"state":"open","locked":false,"title":"Changes to address phpstan issues","user":{"login":"jaydiablo","id":136907,"avatar_url":"https://avatars0.githubusercontent.com/u/136907?v=4","gravatar_id":"","url":"https://api.github.com/users/jaydiablo","html_url":"https://github.com/jaydiablo","followers_url":"https://api.github.com/users/jaydiablo/followers","following_url":"https://api.github.com/users/jaydiablo/following{/other_user}","gists_url":"https://api.github.com/users/jaydiablo/gists{/gist_id}","starred_url":"https://api.github.com/users/jaydiablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaydiablo/subscriptions","organizations_url":"https://api.github.com/users/jaydiablo/orgs","repos_url":"https://api.github.com/users/jaydiablo/repos","events_url":"https://api.github.com/users/jaydiablo/events{/privacy}","received_events_url":"https://api.github.com/users/jaydiablo/received_events","type":"User","site_admin":false},"body":"There are a series of commits here that each address a different level of phpstan.  I was able to get through level 4 with very little code changes (but a lot of phpstan ignores in phpstan.neon).\r\n\r\nI removed all `require_once` calls in the library code (except in a few cases, like autoloader and a few other places), so this now depends on composer autoloading to load properly (phpstan would double-load some classes when the `require_once` calls were in place, and it's generally recommended to remove the `require_once` calls for performance https://web.archive.org/web/20120905092618/http://framework.zend.com:80/manual/en/performance.classloading.html).  phpstan is good at catching when classnames don't match their filename, so pretty confident that no files will be missed due to the composer autoloader not seeing them.\r\n\r\nMost of the changes here are docblock changes to get the param and return type definitions in line with what the code is actually doing.  There are a few code changes here and there, but it's mostly just incorrect case usage for function/method calls (I think I modified a couple of return types from `return;` to `return null;` where the method already was returning something else in body (so return type `void` wouldn't be possible in php 7.1 anyhow).\r\n\r\nI'll look over the changes in this PR and comment on any code changes that aren't one of those cases.\r\n\r\nBecause of the require_once change I think it's probably wise to bump the major version of this, though I did test in some of our own projects and no autoloader changes were necessary (but we use composer autoloading, others may not).\r\n\r\nAll of the tests passed (on my local machine) with these changes, but I haven't tested against travis yet.","created_at":"2018-03-08T22:41:46Z","updated_at":"2018-03-09T08:22:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73722ac17ae5903ef9e64a2388286e327aa0e518","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diablomedia/zf1/pulls/17/commits","review_comments_url":"https://api.github.com/repos/diablomedia/zf1/pulls/17/comments","review_comment_url":"https://api.github.com/repos/diablomedia/zf1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diablomedia/zf1/issues/17/comments","statuses_url":"https://api.github.com/repos/diablomedia/zf1/statuses/7ef78e087850680b896d1679145dd20904644c84","head":{"label":"diablomedia:phpstan","ref":"phpstan","sha":"7ef78e087850680b896d1679145dd20904644c84","user":{"login":"diablomedia","id":2982598,"avatar_url":"https://avatars3.githubusercontent.com/u/2982598?v=4","gravatar_id":"","url":"https://api.github.com/users/diablomedia","html_url":"https://github.com/diablomedia","followers_url":"https://api.github.com/users/diablomedia/followers","following_url":"https://api.github.com/users/diablomedia/following{/other_user}","gists_url":"https://api.github.com/users/diablomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/diablomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diablomedia/subscriptions","organizations_url":"https://api.github.com/users/diablomedia/orgs","repos_url":"https://api.github.com/users/diablomedia/repos","events_url":"https://api.github.com/users/diablomedia/events{/privacy}","received_events_url":"https://api.github.com/users/diablomedia/received_events","type":"Organization","site_admin":false},"repo":{"id":79167261,"name":"zf1","full_name":"diablomedia/zf1","owner":{"login":"diablomedia","id":2982598,"avatar_url":"https://avatars3.githubusercontent.com/u/2982598?v=4","gravatar_id":"","url":"https://api.github.com/users/diablomedia","html_url":"https://github.com/diablomedia","followers_url":"https://api.github.com/users/diablomedia/followers","following_url":"https://api.github.com/users/diablomedia/following{/other_user}","gists_url":"https://api.github.com/users/diablomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/diablomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diablomedia/subscriptions","organizations_url":"https://api.github.com/users/diablomedia/orgs","repos_url":"https://api.github.com/users/diablomedia/repos","events_url":"https://api.github.com/users/diablomedia/events{/privacy}","received_events_url":"https://api.github.com/users/diablomedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diablomedia/zf1","description":"A fork of Zend Framework 1.12 updated to be compatible with newer versions of PHP.","fork":true,"url":"https://api.github.com/repos/diablomedia/zf1","forks_url":"https://api.github.com/repos/diablomedia/zf1/forks","keys_url":"https://api.github.com/repos/diablomedia/zf1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diablomedia/zf1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diablomedia/zf1/teams","hooks_url":"https://api.github.com/repos/diablomedia/zf1/hooks","issue_events_url":"https://api.github.com/repos/diablomedia/zf1/issues/events{/number}","events_url":"https://api.github.com/repos/diablomedia/zf1/events","assignees_url":"https://api.github.com/repos/diablomedia/zf1/assignees{/user}","branches_url":"https://api.github.com/repos/diablomedia/zf1/branches{/branch}","tags_url":"https://api.github.com/repos/diablomedia/zf1/tags","blobs_url":"https://api.github.com/repos/diablomedia/zf1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diablomedia/zf1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diablomedia/zf1/git/refs{/sha}","trees_url":"https://api.github.com/repos/diablomedia/zf1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diablomedia/zf1/statuses/{sha}","languages_url":"https://api.github.com/repos/diablomedia/zf1/languages","stargazers_url":"https://api.github.com/repos/diablomedia/zf1/stargazers","contributors_url":"https://api.github.com/repos/diablomedia/zf1/contributors","subscribers_url":"https://api.github.com/repos/diablomedia/zf1/subscribers","subscription_url":"https://api.github.com/repos/diablomedia/zf1/subscription","commits_url":"https://api.github.com/repos/diablomedia/zf1/commits{/sha}","git_commits_url":"https://api.github.com/repos/diablomedia/zf1/git/commits{/sha}","comments_url":"https://api.github.com/repos/diablomedia/zf1/comments{/number}","issue_comment_url":"https://api.github.com/repos/diablomedia/zf1/issues/comments{/number}","contents_url":"https://api.github.com/repos/diablomedia/zf1/contents/{+path}","compare_url":"https://api.github.com/repos/diablomedia/zf1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diablomedia/zf1/merges","archive_url":"https://api.github.com/repos/diablomedia/zf1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diablomedia/zf1/downloads","issues_url":"https://api.github.com/repos/diablomedia/zf1/issues{/number}","pulls_url":"https://api.github.com/repos/diablomedia/zf1/pulls{/number}","milestones_url":"https://api.github.com/repos/diablomedia/zf1/milestones{/number}","notifications_url":"https://api.github.com/repos/diablomedia/zf1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diablomedia/zf1/labels{/name}","releases_url":"https://api.github.com/repos/diablomedia/zf1/releases{/id}","deployments_url":"https://api.github.com/repos/diablomedia/zf1/deployments","created_at":"2017-01-16T22:59:12Z","updated_at":"2018-02-14T20:34:17Z","pushed_at":"2018-03-09T06:54:00Z","git_url":"git://github.com/diablomedia/zf1.git","ssh_url":"git@github.com:diablomedia/zf1.git","clone_url":"https://github.com/diablomedia/zf1.git","svn_url":"https://github.com/diablomedia/zf1","homepage":"","size":81199,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"diablomedia:master","ref":"master","sha":"5619c52d46ccb16c9acdad84e6d7ae634c2425ff","user":{"login":"diablomedia","id":2982598,"avatar_url":"https://avatars3.githubusercontent.com/u/2982598?v=4","gravatar_id":"","url":"https://api.github.com/users/diablomedia","html_url":"https://github.com/diablomedia","followers_url":"https://api.github.com/users/diablomedia/followers","following_url":"https://api.github.com/users/diablomedia/following{/other_user}","gists_url":"https://api.github.com/users/diablomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/diablomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diablomedia/subscriptions","organizations_url":"https://api.github.com/users/diablomedia/orgs","repos_url":"https://api.github.com/users/diablomedia/repos","events_url":"https://api.github.com/users/diablomedia/events{/privacy}","received_events_url":"https://api.github.com/users/diablomedia/received_events","type":"Organization","site_admin":false},"repo":{"id":79167261,"name":"zf1","full_name":"diablomedia/zf1","owner":{"login":"diablomedia","id":2982598,"avatar_url":"https://avatars3.githubusercontent.com/u/2982598?v=4","gravatar_id":"","url":"https://api.github.com/users/diablomedia","html_url":"https://github.com/diablomedia","followers_url":"https://api.github.com/users/diablomedia/followers","following_url":"https://api.github.com/users/diablomedia/following{/other_user}","gists_url":"https://api.github.com/users/diablomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/diablomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diablomedia/subscriptions","organizations_url":"https://api.github.com/users/diablomedia/orgs","repos_url":"https://api.github.com/users/diablomedia/repos","events_url":"https://api.github.com/users/diablomedia/events{/privacy}","received_events_url":"https://api.github.com/users/diablomedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diablomedia/zf1","description":"A fork of Zend Framework 1.12 updated to be compatible with newer versions of PHP.","fork":true,"url":"https://api.github.com/repos/diablomedia/zf1","forks_url":"https://api.github.com/repos/diablomedia/zf1/forks","keys_url":"https://api.github.com/repos/diablomedia/zf1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diablomedia/zf1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diablomedia/zf1/teams","hooks_url":"https://api.github.com/repos/diablomedia/zf1/hooks","issue_events_url":"https://api.github.com/repos/diablomedia/zf1/issues/events{/number}","events_url":"https://api.github.com/repos/diablomedia/zf1/events","assignees_url":"https://api.github.com/repos/diablomedia/zf1/assignees{/user}","branches_url":"https://api.github.com/repos/diablomedia/zf1/branches{/branch}","tags_url":"https://api.github.com/repos/diablomedia/zf1/tags","blobs_url":"https://api.github.com/repos/diablomedia/zf1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diablomedia/zf1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diablomedia/zf1/git/refs{/sha}","trees_url":"https://api.github.com/repos/diablomedia/zf1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diablomedia/zf1/statuses/{sha}","languages_url":"https://api.github.com/repos/diablomedia/zf1/languages","stargazers_url":"https://api.github.com/repos/diablomedia/zf1/stargazers","contributors_url":"https://api.github.com/repos/diablomedia/zf1/contributors","subscribers_url":"https://api.github.com/repos/diablomedia/zf1/subscribers","subscription_url":"https://api.github.com/repos/diablomedia/zf1/subscription","commits_url":"https://api.github.com/repos/diablomedia/zf1/commits{/sha}","git_commits_url":"https://api.github.com/repos/diablomedia/zf1/git/commits{/sha}","comments_url":"https://api.github.com/repos/diablomedia/zf1/comments{/number}","issue_comment_url":"https://api.github.com/repos/diablomedia/zf1/issues/comments{/number}","contents_url":"https://api.github.com/repos/diablomedia/zf1/contents/{+path}","compare_url":"https://api.github.com/repos/diablomedia/zf1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diablomedia/zf1/merges","archive_url":"https://api.github.com/repos/diablomedia/zf1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diablomedia/zf1/downloads","issues_url":"https://api.github.com/repos/diablomedia/zf1/issues{/number}","pulls_url":"https://api.github.com/repos/diablomedia/zf1/pulls{/number}","milestones_url":"https://api.github.com/repos/diablomedia/zf1/milestones{/number}","notifications_url":"https://api.github.com/repos/diablomedia/zf1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diablomedia/zf1/labels{/name}","releases_url":"https://api.github.com/repos/diablomedia/zf1/releases{/id}","deployments_url":"https://api.github.com/repos/diablomedia/zf1/deployments","created_at":"2017-01-16T22:59:12Z","updated_at":"2018-02-14T20:34:17Z","pushed_at":"2018-03-09T06:54:00Z","git_url":"git://github.com/diablomedia/zf1.git","ssh_url":"git@github.com:diablomedia/zf1.git","clone_url":"https://github.com/diablomedia/zf1.git","svn_url":"https://github.com/diablomedia/zf1","homepage":"","size":81199,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diablomedia/zf1/pulls/17"},"html":{"href":"https://github.com/diablomedia/zf1/pull/17"},"issue":{"href":"https://api.github.com/repos/diablomedia/zf1/issues/17"},"comments":{"href":"https://api.github.com/repos/diablomedia/zf1/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/diablomedia/zf1/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/diablomedia/zf1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diablomedia/zf1/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/diablomedia/zf1/statuses/7ef78e087850680b896d1679145dd20904644c84"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jaydiablo"}}