{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments/173737091","pull_request_review_id":102971649,"id":173737091,"diff_hunk":"@@ -147,4 +149,85 @@\n       end\n     end\n   end\n+\n+  describe \".ParseInstallationKernelCmdline\" do\n+    before do\n+      allow(Yast::SCR).to receive(:Read).with(path(\".etc.install_inf.Cmdline\")).and_return(cmdline)\n+      allow(Yast::Stage).to receive(:initial).and_return(true)\n+      allow(Yast::Arch).to receive(:architecture).and_return(\"x86_64\")\n+    end\n+\n+    context \"for common options\" do\n+      let(:cmdline) { \"splash=verbose silent\" }\n+\n+      it \"adds options to CmdLine\" do\n+        subject.ParseInstallationKernelCmdline\n+        expect(subject.GetCmdLine).to eq \" splash=verbose silent\"\n+      end\n+    end\n+\n+    context \"when command line contain newline\" do\n+      let(:cmdline) { \"splash=verbose silent\\n\" }\n+\n+      it \"deletes this newline from CmdLine\" do\n+        subject.ParseInstallationKernelCmdline\n+        expect(subject.GetCmdLine).to eq \" splash=verbose silent\"\n+      end\n+    end\n+\n+    context \"when command line contain vga= key\" do\n+      let(:cmdline) { \"vga=ask splash=verbose silent\\n\" }\n+\n+      it \"deletes vga parameter from CmdLine\" do\n+        subject.ParseInstallationKernelCmdline\n+        expect(subject.GetCmdLine).to eq \" splash=verbose silent\"\n+      end\n+\n+      it \"sets vgaType\" do\n+        subject.ParseInstallationKernelCmdline\n+        expect(subject.GetVgaType).to eq \"ask\"\n+      end\n+    end\n+\n+    context \"when command line value including quotes\" do\n+      let(:cmdline) { \" splash=\\\"verbose, silent\\\" text=abc\\n\" }\n+\n+      it \"it adds it to CmdLine correctly\" do\n+        subject.ParseInstallationKernelCmdline\n+        expect(subject.GetCmdLine).to eq \" splash=\\\"verbose, silent\\\" text=abc\"\n+      end\n+    end\n+\n+    # FIXME: keep old functionality, but probably kernel does not allow it.","path":"library/system/test/kernel_test.rb","position":68,"original_position":68,"commit_id":"337babcfcef211fe385c7fa6d818592cf8797c83","original_commit_id":"337babcfcef211fe385c7fa6d818592cf8797c83","user":{"login":"mvidner","id":102056,"avatar_url":"https://avatars3.githubusercontent.com/u/102056?v=4","gravatar_id":"","url":"https://api.github.com/users/mvidner","html_url":"https://github.com/mvidner","followers_url":"https://api.github.com/users/mvidner/followers","following_url":"https://api.github.com/users/mvidner/following{/other_user}","gists_url":"https://api.github.com/users/mvidner/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidner/subscriptions","organizations_url":"https://api.github.com/users/mvidner/orgs","repos_url":"https://api.github.com/users/mvidner/repos","events_url":"https://api.github.com/users/mvidner/events{/privacy}","received_events_url":"https://api.github.com/users/mvidner/received_events","type":"User","site_admin":false},"body":"```rb\r\n# FIXME: we do backslash escapes but in fact\r\n# the kernel does not care about any backslashes, only about double quotes\r\n```","created_at":"2018-03-12T09:44:25Z","updated_at":"2018-03-12T09:46:23Z","html_url":"https://github.com/yast/yast-yast2/pull/710#discussion_r173737091","pull_request_url":"https://api.github.com/repos/yast/yast-yast2/pulls/710","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments/173737091"},"html":{"href":"https://github.com/yast/yast-yast2/pull/710#discussion_r173737091"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/710"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/710","id":173987572,"html_url":"https://github.com/yast/yast-yast2/pull/710","diff_url":"https://github.com/yast/yast-yast2/pull/710.diff","patch_url":"https://github.com/yast/yast-yast2/pull/710.patch","issue_url":"https://api.github.com/repos/yast/yast-yast2/issues/710","number":710,"state":"open","locked":false,"title":"Fix cmdline parsing master","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars2.githubusercontent.com/u/478871?v=4","gravatar_id":"","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-09T11:56:38Z","updated_at":"2018-03-12T09:46:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"832fb5d3e499300c36939b5dc9e19aa4428c7bd1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-yast2/pulls/710/commits","review_comments_url":"https://api.github.com/repos/yast/yast-yast2/pulls/710/comments","review_comment_url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-yast2/issues/710/comments","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/337babcfcef211fe385c7fa6d818592cf8797c83","head":{"label":"yast:fix_cmdline_parsing_master","ref":"fix_cmdline_parsing_master","sha":"337babcfcef211fe385c7fa6d818592cf8797c83","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368244,"name":"yast-yast2","full_name":"yast/yast-yast2","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-yast2","description":"YaST module yast2","fork":false,"url":"https://api.github.com/repos/yast/yast-yast2","forks_url":"https://api.github.com/repos/yast/yast-yast2/forks","keys_url":"https://api.github.com/repos/yast/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-yast2/teams","hooks_url":"https://api.github.com/repos/yast/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-yast2/events","assignees_url":"https://api.github.com/repos/yast/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-yast2/tags","blobs_url":"https://api.github.com/repos/yast/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/yast/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-yast2/subscription","commits_url":"https://api.github.com/repos/yast/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-yast2/merges","archive_url":"https://api.github.com/repos/yast/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-yast2/downloads","issues_url":"https://api.github.com/repos/yast/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-yast2/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-yast2/deployments","created_at":"2012-05-18T10:27:22Z","updated_at":"2017-11-16T00:48:28Z","pushed_at":"2018-03-12T09:18:12Z","git_url":"git://github.com/yast/yast-yast2.git","ssh_url":"git@github.com:yast/yast-yast2.git","clone_url":"https://github.com/yast/yast-yast2.git","svn_url":"https://github.com/yast/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":25665,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":31,"open_issues":14,"watchers":27,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"957753e377c37bf77e4709944392955cd53576f7","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368244,"name":"yast-yast2","full_name":"yast/yast-yast2","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-yast2","description":"YaST module yast2","fork":false,"url":"https://api.github.com/repos/yast/yast-yast2","forks_url":"https://api.github.com/repos/yast/yast-yast2/forks","keys_url":"https://api.github.com/repos/yast/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-yast2/teams","hooks_url":"https://api.github.com/repos/yast/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-yast2/events","assignees_url":"https://api.github.com/repos/yast/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-yast2/tags","blobs_url":"https://api.github.com/repos/yast/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/yast/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-yast2/subscription","commits_url":"https://api.github.com/repos/yast/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-yast2/merges","archive_url":"https://api.github.com/repos/yast/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-yast2/downloads","issues_url":"https://api.github.com/repos/yast/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-yast2/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-yast2/deployments","created_at":"2012-05-18T10:27:22Z","updated_at":"2017-11-16T00:48:28Z","pushed_at":"2018-03-12T09:18:12Z","git_url":"git://github.com/yast/yast-yast2.git","ssh_url":"git@github.com:yast/yast-yast2.git","clone_url":"https://github.com/yast/yast-yast2.git","svn_url":"https://github.com/yast/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":25665,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":31,"open_issues":14,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/710"},"html":{"href":"https://github.com/yast/yast-yast2/pull/710"},"issue":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/710"},"comments":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/710/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/710/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/710/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-yast2/statuses/337babcfcef211fe385c7fa6d818592cf8797c83"}},"author_association":"OWNER"}}
{"actor":{"display_login":"mvidner"}}