{"action":"opened","number":1037,"pull_request":{"url":"https://api.github.com/repos/spinnaker/halyard/pulls/1037","id":215579739,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTc5NzM5","html_url":"https://github.com/spinnaker/halyard/pull/1037","diff_url":"https://github.com/spinnaker/halyard/pull/1037.diff","patch_url":"https://github.com/spinnaker/halyard/pull/1037.patch","issue_url":"https://api.github.com/repos/spinnaker/halyard/issues/1037","number":1037,"state":"open","locked":false,"title":"fix(deploy): fix regex for illegal char replace","user":{"login":"ethanfrogers","id":3324110,"node_id":"MDQ6VXNlcjMzMjQxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3324110?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrogers","html_url":"https://github.com/ethanfrogers","followers_url":"https://api.github.com/users/ethanfrogers/followers","following_url":"https://api.github.com/users/ethanfrogers/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrogers/subscriptions","organizations_url":"https://api.github.com/users/ethanfrogers/orgs","repos_url":"https://api.github.com/users/ethanfrogers/repos","events_url":"https://api.github.com/users/ethanfrogers/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrogers/received_events","type":"User","site_admin":false},"body":"the regex used in `replaceAll` in `makeValidLabel` was incorrect not\r\nreplacing chararacters. the intent was to remove all characters that are\r\nnot `A-Za-z0-9-_.` but using a leading and trailing `/` broke it. by\r\nremoving the `/`, we get the desired effect.\r\n\r\n@lwander PTAL :)","created_at":"2018-09-14T12:34:00Z","updated_at":"2018-09-14T12:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/halyard/pulls/1037/commits","review_comments_url":"https://api.github.com/repos/spinnaker/halyard/pulls/1037/comments","review_comment_url":"https://api.github.com/repos/spinnaker/halyard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/halyard/issues/1037/comments","statuses_url":"https://api.github.com/repos/spinnaker/halyard/statuses/af11a5580cc24727b69a95aa927a7809741b6237","head":{"label":"ethanfrogers:fix-regex-for-label","ref":"fix-regex-for-label","sha":"af11a5580cc24727b69a95aa927a7809741b6237","user":{"login":"ethanfrogers","id":3324110,"node_id":"MDQ6VXNlcjMzMjQxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3324110?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrogers","html_url":"https://github.com/ethanfrogers","followers_url":"https://api.github.com/users/ethanfrogers/followers","following_url":"https://api.github.com/users/ethanfrogers/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrogers/subscriptions","organizations_url":"https://api.github.com/users/ethanfrogers/orgs","repos_url":"https://api.github.com/users/ethanfrogers/repos","events_url":"https://api.github.com/users/ethanfrogers/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrogers/received_events","type":"User","site_admin":false},"repo":{"id":105721408,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3MjE0MDg=","name":"halyard","full_name":"ethanfrogers/halyard","owner":{"login":"ethanfrogers","id":3324110,"node_id":"MDQ6VXNlcjMzMjQxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3324110?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrogers","html_url":"https://github.com/ethanfrogers","followers_url":"https://api.github.com/users/ethanfrogers/followers","following_url":"https://api.github.com/users/ethanfrogers/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrogers/subscriptions","organizations_url":"https://api.github.com/users/ethanfrogers/orgs","repos_url":"https://api.github.com/users/ethanfrogers/repos","events_url":"https://api.github.com/users/ethanfrogers/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrogers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ethanfrogers/halyard","description":"A tool for configuring, installing, and updating Spinnaker","fork":true,"url":"https://api.github.com/repos/ethanfrogers/halyard","forks_url":"https://api.github.com/repos/ethanfrogers/halyard/forks","keys_url":"https://api.github.com/repos/ethanfrogers/halyard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethanfrogers/halyard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethanfrogers/halyard/teams","hooks_url":"https://api.github.com/repos/ethanfrogers/halyard/hooks","issue_events_url":"https://api.github.com/repos/ethanfrogers/halyard/issues/events{/number}","events_url":"https://api.github.com/repos/ethanfrogers/halyard/events","assignees_url":"https://api.github.com/repos/ethanfrogers/halyard/assignees{/user}","branches_url":"https://api.github.com/repos/ethanfrogers/halyard/branches{/branch}","tags_url":"https://api.github.com/repos/ethanfrogers/halyard/tags","blobs_url":"https://api.github.com/repos/ethanfrogers/halyard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethanfrogers/halyard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethanfrogers/halyard/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethanfrogers/halyard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethanfrogers/halyard/statuses/{sha}","languages_url":"https://api.github.com/repos/ethanfrogers/halyard/languages","stargazers_url":"https://api.github.com/repos/ethanfrogers/halyard/stargazers","contributors_url":"https://api.github.com/repos/ethanfrogers/halyard/contributors","subscribers_url":"https://api.github.com/repos/ethanfrogers/halyard/subscribers","subscription_url":"https://api.github.com/repos/ethanfrogers/halyard/subscription","commits_url":"https://api.github.com/repos/ethanfrogers/halyard/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethanfrogers/halyard/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethanfrogers/halyard/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethanfrogers/halyard/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethanfrogers/halyard/contents/{+path}","compare_url":"https://api.github.com/repos/ethanfrogers/halyard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethanfrogers/halyard/merges","archive_url":"https://api.github.com/repos/ethanfrogers/halyard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethanfrogers/halyard/downloads","issues_url":"https://api.github.com/repos/ethanfrogers/halyard/issues{/number}","pulls_url":"https://api.github.com/repos/ethanfrogers/halyard/pulls{/number}","milestones_url":"https://api.github.com/repos/ethanfrogers/halyard/milestones{/number}","notifications_url":"https://api.github.com/repos/ethanfrogers/halyard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethanfrogers/halyard/labels{/name}","releases_url":"https://api.github.com/repos/ethanfrogers/halyard/releases{/id}","deployments_url":"https://api.github.com/repos/ethanfrogers/halyard/deployments","created_at":"2017-10-04T01:34:47Z","updated_at":"2017-10-04T01:34:51Z","pushed_at":"2018-09-14T12:33:17Z","git_url":"git://github.com/ethanfrogers/halyard.git","ssh_url":"git@github.com:ethanfrogers/halyard.git","clone_url":"https://github.com/ethanfrogers/halyard.git","svn_url":"https://github.com/ethanfrogers/halyard","homepage":"","size":3310,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"776599c18ea48932625670ee5580266d6781b4c0","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":69277020,"node_id":"MDEwOlJlcG9zaXRvcnk2OTI3NzAyMA==","name":"halyard","full_name":"spinnaker/halyard","owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/halyard","description":"A tool for configuring, installing, and updating Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/halyard","forks_url":"https://api.github.com/repos/spinnaker/halyard/forks","keys_url":"https://api.github.com/repos/spinnaker/halyard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/halyard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/halyard/teams","hooks_url":"https://api.github.com/repos/spinnaker/halyard/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/halyard/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/halyard/events","assignees_url":"https://api.github.com/repos/spinnaker/halyard/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/halyard/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/halyard/tags","blobs_url":"https://api.github.com/repos/spinnaker/halyard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/halyard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/halyard/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/halyard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/halyard/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/halyard/languages","stargazers_url":"https://api.github.com/repos/spinnaker/halyard/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/halyard/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/halyard/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/halyard/subscription","commits_url":"https://api.github.com/repos/spinnaker/halyard/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/halyard/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/halyard/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/halyard/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/halyard/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/halyard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/halyard/merges","archive_url":"https://api.github.com/repos/spinnaker/halyard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/halyard/downloads","issues_url":"https://api.github.com/repos/spinnaker/halyard/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/halyard/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/halyard/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/halyard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/halyard/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/halyard/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/halyard/deployments","created_at":"2016-09-26T17:55:37Z","updated_at":"2018-09-12T17:13:45Z","pushed_at":"2018-09-12T17:44:38Z","git_url":"git://github.com/spinnaker/halyard.git","ssh_url":"git@github.com:spinnaker/halyard.git","clone_url":"https://github.com/spinnaker/halyard.git","svn_url":"https://github.com/spinnaker/halyard","homepage":"","size":4594,"stargazers_count":142,"watchers_count":142,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":263,"open_issues":6,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/halyard/pulls/1037"},"html":{"href":"https://github.com/spinnaker/halyard/pull/1037"},"issue":{"href":"https://api.github.com/repos/spinnaker/halyard/issues/1037"},"comments":{"href":"https://api.github.com/repos/spinnaker/halyard/issues/1037/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/halyard/pulls/1037/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/halyard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/halyard/pulls/1037/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/halyard/statuses/af11a5580cc24727b69a95aa927a7809741b6237"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ethanfrogers"}}