{"action":"closed","number":4404,"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/4404","id":198723033,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzIzMDMz","html_url":"https://github.com/ethereum/solidity/pull/4404","diff_url":"https://github.com/ethereum/solidity/pull/4404.diff","patch_url":"https://github.com/ethereum/solidity/pull/4404.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/4404","number":4404,"state":"closed","locked":false,"title":"[WIP] v0.5.0 var keyword type suggestion","user":{"login":"christianparpart","id":56763,"node_id":"MDQ6VXNlcjU2NzYz","avatar_url":"https://avatars1.githubusercontent.com/u/56763?v=4","gravatar_id":"","url":"https://api.github.com/users/christianparpart","html_url":"https://github.com/christianparpart","followers_url":"https://api.github.com/users/christianparpart/followers","following_url":"https://api.github.com/users/christianparpart/following{/other_user}","gists_url":"https://api.github.com/users/christianparpart/gists{/gist_id}","starred_url":"https://api.github.com/users/christianparpart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianparpart/subscriptions","organizations_url":"https://api.github.com/users/christianparpart/orgs","repos_url":"https://api.github.com/users/christianparpart/repos","events_url":"https://api.github.com/users/christianparpart/events{/privacy}","received_events_url":"https://api.github.com/users/christianparpart/received_events","type":"User","site_admin":false},"body":"_((NOTE: This PR is rebased on top of #4274 in order to work. This PR (currently) exists only of one single commit containing the necessary changes))_\r\n\r\nThis PR enhances #4274 by also suggestion what type to use instead of just reporting that `var` keyword is disallowed, which should greatly help bigger projects in adapting their software (as it helped me adapting the tests).\r\n\r\nAs some types cannot be expressed without the `var`-keyword, we must inform the user about that.\r\n\r\n### Tuple-Assignments Wording\r\n```\r\n    Use of \"var\" keyword is disallowed. Use explicit `(type1 var1, ..., typeN varN)` instead.\r\n```","created_at":"2018-07-02T15:58:45Z","updated_at":"2018-07-11T14:33:10Z","closed_at":"2018-07-11T14:33:10Z","merged_at":"2018-07-11T14:33:10Z","merge_commit_sha":"08345209e6f68c509ec5af820596a2172b886568","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/4404/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/4404/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/4404/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/458a4c8aa5dc88aed46ad1ab1494fa035af09e31","head":{"label":"ethereum:v050-var-keyword-suggest","ref":"v050-var-keyword-suggest","sha":"458a4c8aa5dc88aed46ad1ab1494fa035af09e31","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-07-11T13:38:46Z","pushed_at":"2018-07-11T14:33:10Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":20704,"stargazers_count":5441,"watchers_count":5441,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1421,"mirror_url":null,"archived":false,"open_issues_count":615,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1421,"open_issues":615,"watchers":5441,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"d84976dc871a1fdfab233650b989af69e325bf2b","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-07-11T13:38:46Z","pushed_at":"2018-07-11T14:33:10Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":20704,"stargazers_count":5441,"watchers_count":5441,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1421,"mirror_url":null,"archived":false,"open_issues_count":615,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1421,"open_issues":615,"watchers":5441,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4404"},"html":{"href":"https://github.com/ethereum/solidity/pull/4404"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4404"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4404/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4404/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4404/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/458a4c8aa5dc88aed46ad1ab1494fa035af09e31"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"christianparpart","id":56763,"node_id":"MDQ6VXNlcjU2NzYz","avatar_url":"https://avatars1.githubusercontent.com/u/56763?v=4","gravatar_id":"","url":"https://api.github.com/users/christianparpart","html_url":"https://github.com/christianparpart","followers_url":"https://api.github.com/users/christianparpart/followers","following_url":"https://api.github.com/users/christianparpart/following{/other_user}","gists_url":"https://api.github.com/users/christianparpart/gists{/gist_id}","starred_url":"https://api.github.com/users/christianparpart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianparpart/subscriptions","organizations_url":"https://api.github.com/users/christianparpart/orgs","repos_url":"https://api.github.com/users/christianparpart/repos","events_url":"https://api.github.com/users/christianparpart/events{/privacy}","received_events_url":"https://api.github.com/users/christianparpart/received_events","type":"User","site_admin":false},"comments":4,"review_comments":9,"maintainer_can_modify":false,"commits":2,"additions":86,"deletions":19,"changed_files":4}}
{"actor":{"display_login":"christianparpart"}}