{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/197375512","pull_request_review_id":131107880,"id":197375512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzM3NTUxMg==","diff_hunk":"@@ -23,7 +23,7 @@ def __init__(self):\n         pass\n \n     def _get_params(self, attr, deep=True):\n-        out = super(_BaseComposition, self).get_params(deep=False)\n+        out = super(_BaseComposition, self).get_params(deep=deep)","path":"sklearn/utils/metaestimators.py","position":5,"original_position":5,"commit_id":"6f0c2ddba27b63139615fe64bd832230f758d7de","original_commit_id":"f9352229f667a9ce3e95d3af9ba19c8d2d689446","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"OK!","created_at":"2018-06-22T08:29:53Z","updated_at":"2018-06-22T08:29:54Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11315#discussion_r197375512","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11315","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/197375512"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11315#discussion_r197375512"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11315"}},"in_reply_to_id":197185705},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11315","id":195630985,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjMwOTg1","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11315","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/11315.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/11315.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11315","number":11315,"state":"open","locked":false,"title":"API: Adds transformer support in ColumnTransformer.remainder","user":{"login":"thomasjpfan","id":5402633,"node_id":"MDQ6VXNlcjU0MDI2MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5402633?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasjpfan","html_url":"https://github.com/thomasjpfan","followers_url":"https://api.github.com/users/thomasjpfan/followers","following_url":"https://api.github.com/users/thomasjpfan/following{/other_user}","gists_url":"https://api.github.com/users/thomasjpfan/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasjpfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasjpfan/subscriptions","organizations_url":"https://api.github.com/users/thomasjpfan/orgs","repos_url":"https://api.github.com/users/thomasjpfan/repos","events_url":"https://api.github.com/users/thomasjpfan/events{/privacy}","received_events_url":"https://api.github.com/users/thomasjpfan/received_events","type":"User","site_admin":false},"body":"#### Reference Issues/PRs\r\nFixes #11210.\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nAdds transformer support in the `ColumnTransformer.remainder` parameter.","created_at":"2018-06-18T19:56:04Z","updated_at":"2018-06-22T08:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7e57f2a3162d63a868cb26e5509ea0db6cac435","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11315/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11315/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11315/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/6f0c2ddba27b63139615fe64bd832230f758d7de","head":{"label":"thomasjpfan:issue-11210","ref":"issue-11210","sha":"6f0c2ddba27b63139615fe64bd832230f758d7de","user":{"login":"thomasjpfan","id":5402633,"node_id":"MDQ6VXNlcjU0MDI2MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5402633?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasjpfan","html_url":"https://github.com/thomasjpfan","followers_url":"https://api.github.com/users/thomasjpfan/followers","following_url":"https://api.github.com/users/thomasjpfan/following{/other_user}","gists_url":"https://api.github.com/users/thomasjpfan/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasjpfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasjpfan/subscriptions","organizations_url":"https://api.github.com/users/thomasjpfan/orgs","repos_url":"https://api.github.com/users/thomasjpfan/repos","events_url":"https://api.github.com/users/thomasjpfan/events{/privacy}","received_events_url":"https://api.github.com/users/thomasjpfan/received_events","type":"User","site_admin":false},"repo":{"id":135866406,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU4NjY0MDY=","name":"scikit-learn","full_name":"thomasjpfan/scikit-learn","owner":{"login":"thomasjpfan","id":5402633,"node_id":"MDQ6VXNlcjU0MDI2MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5402633?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasjpfan","html_url":"https://github.com/thomasjpfan","followers_url":"https://api.github.com/users/thomasjpfan/followers","following_url":"https://api.github.com/users/thomasjpfan/following{/other_user}","gists_url":"https://api.github.com/users/thomasjpfan/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasjpfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasjpfan/subscriptions","organizations_url":"https://api.github.com/users/thomasjpfan/orgs","repos_url":"https://api.github.com/users/thomasjpfan/repos","events_url":"https://api.github.com/users/thomasjpfan/events{/privacy}","received_events_url":"https://api.github.com/users/thomasjpfan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasjpfan/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/thomasjpfan/scikit-learn","forks_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/forks","keys_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/teams","hooks_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/events","assignees_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/tags","blobs_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/subscription","commits_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/merges","archive_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/downloads","issues_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/thomasjpfan/scikit-learn/deployments","created_at":"2018-06-03T02:13:41Z","updated_at":"2018-06-21T03:02:52Z","pushed_at":"2018-06-21T16:57:38Z","git_url":"git://github.com/thomasjpfan/scikit-learn.git","ssh_url":"git@github.com:thomasjpfan/scikit-learn.git","clone_url":"https://github.com/thomasjpfan/scikit-learn.git","svn_url":"https://github.com/thomasjpfan/scikit-learn","homepage":"http://scikit-learn.org","size":90364,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"bb5110b8e0b70d98eae2f7f8b6d4deaa5d2de038","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-06-22T08:03:47Z","pushed_at":"2018-06-22T08:24:36Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":91110,"stargazers_count":28917,"watchers_count":28917,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14351,"mirror_url":null,"archived":false,"open_issues_count":1637,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14351,"open_issues":1637,"watchers":28917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11315"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11315"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11315"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11315/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11315/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11315/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/6f0c2ddba27b63139615fe64bd832230f758d7de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jorisvandenbossche"}}