{"action":"created","issue":{"url":"https://api.github.com/repos/Modorganizer2/modorganizer/issues/470","repository_url":"https://api.github.com/repos/Modorganizer2/modorganizer","labels_url":"https://api.github.com/repos/Modorganizer2/modorganizer/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/Modorganizer2/modorganizer/issues/470/comments","events_url":"https://api.github.com/repos/Modorganizer2/modorganizer/issues/470/events","html_url":"https://github.com/Modorganizer2/modorganizer/issues/470","id":348112325,"node_id":"MDU6SXNzdWUzNDgxMTIzMjU=","number":470,"title":"Disk full marks downloads as successfully completed.","user":{"login":"AnyOldName3","id":8485112,"node_id":"MDQ6VXNlcjg0ODUxMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/8485112?v=4","gravatar_id":"","url":"https://api.github.com/users/AnyOldName3","html_url":"https://github.com/AnyOldName3","followers_url":"https://api.github.com/users/AnyOldName3/followers","following_url":"https://api.github.com/users/AnyOldName3/following{/other_user}","gists_url":"https://api.github.com/users/AnyOldName3/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyOldName3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyOldName3/subscriptions","organizations_url":"https://api.github.com/users/AnyOldName3/orgs","repos_url":"https://api.github.com/users/AnyOldName3/repos","events_url":"https://api.github.com/users/AnyOldName3/events{/privacy}","received_events_url":"https://api.github.com/users/AnyOldName3/received_events","type":"User","site_admin":false},"labels":[{"id":480723861,"node_id":"MDU6TGFiZWw0ODA3MjM4NjE=","url":"https://api.github.com/repos/Modorganizer2/modorganizer/labels/bug","name":"bug","color":"ee0701","default":true},{"id":480723863,"node_id":"MDU6TGFiZWw0ODA3MjM4NjM=","url":"https://api.github.com/repos/Modorganizer2/modorganizer/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-06T23:14:24Z","updated_at":"2018-08-19T21:31:54Z","closed_at":"2018-08-19T21:31:54Z","author_association":"MEMBER","body":"# The problem\r\n\r\nIf a MO download fills up a disk drive, instead of giving an error message to say that there's no space to finish the download, it's marked as completed.\r\n\r\n# Environment\r\n\r\n* Mod Organizer Version that exhibits the issue: 2.1.4 release\r\n* Last Mod Organizer Verison that did not exhibit the issue (if applicable): Not tested\r\n* Desktop OS/version used to run Mod Organizer: Windows 10 \r\n\r\n# Details\r\n\r\nN/A\r\n\r\n# Link to Mod Organizer logs\r\n\r\n## USVFS\r\nN/A\r\n\r\n## MO Interface\r\nI accidentally overwrote the log by opening MO to double check if it was up to date. I've since cleared up some disk space, so can't easily regenerate it. Hopefully, the issue is simple enough that this is completely irrelevant.\r\n"},"comment":{"url":"https://api.github.com/repos/Modorganizer2/modorganizer/issues/comments/414157425","html_url":"https://github.com/Modorganizer2/modorganizer/issues/470#issuecomment-414157425","issue_url":"https://api.github.com/repos/Modorganizer2/modorganizer/issues/470","id":414157425,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDE1NzQyNQ==","user":{"login":"LostDragonist","id":7862539,"node_id":"MDQ6VXNlcjc4NjI1Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7862539?v=4","gravatar_id":"","url":"https://api.github.com/users/LostDragonist","html_url":"https://github.com/LostDragonist","followers_url":"https://api.github.com/users/LostDragonist/followers","following_url":"https://api.github.com/users/LostDragonist/following{/other_user}","gists_url":"https://api.github.com/users/LostDragonist/gists{/gist_id}","starred_url":"https://api.github.com/users/LostDragonist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LostDragonist/subscriptions","organizations_url":"https://api.github.com/users/LostDragonist/orgs","repos_url":"https://api.github.com/users/LostDragonist/repos","events_url":"https://api.github.com/users/LostDragonist/events{/privacy}","received_events_url":"https://api.github.com/users/LostDragonist/received_events","type":"User","site_admin":false},"created_at":"2018-08-19T21:31:54Z","updated_at":"2018-08-19T21:31:54Z","author_association":"MEMBER","body":"Commit 67287048dd7ae276b916861d948701c649d88a5e looks for error when writing downloads to the storage drive.  It will inform the user of the error, suggest looking at the available space, and cancel the download.  \r\n\r\nI spent a good amount of time trying to leave the download in a state where the user could resume it without (1) corrupting the download and (2) deadlocking MO2.  The deadlocks appeared to be due to MO2 trying to open the download's metafile multiple times.\r\n\r\nThe main issue of leaving a corrupt download in a ready state is fixed so I'm closing this issue."}}
{"actor":{"display_login":"LostDragonist"}}