{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChromeLabs/sw-precache/issues/364","repository_url":"https://api.github.com/repos/GoogleChromeLabs/sw-precache","labels_url":"https://api.github.com/repos/GoogleChromeLabs/sw-precache/issues/364/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChromeLabs/sw-precache/issues/364/comments","events_url":"https://api.github.com/repos/GoogleChromeLabs/sw-precache/issues/364/events","html_url":"https://github.com/GoogleChromeLabs/sw-precache/issues/364","id":344018171,"node_id":"MDU6SXNzdWUzNDQwMTgxNzE=","number":364,"title":"skipWaiting false and a refresh button","user":{"login":"jliebrand","id":23407884,"node_id":"MDQ6VXNlcjIzNDA3ODg0","avatar_url":"https://avatars3.githubusercontent.com/u/23407884?v=4","gravatar_id":"","url":"https://api.github.com/users/jliebrand","html_url":"https://github.com/jliebrand","followers_url":"https://api.github.com/users/jliebrand/followers","following_url":"https://api.github.com/users/jliebrand/following{/other_user}","gists_url":"https://api.github.com/users/jliebrand/gists{/gist_id}","starred_url":"https://api.github.com/users/jliebrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jliebrand/subscriptions","organizations_url":"https://api.github.com/users/jliebrand/orgs","repos_url":"https://api.github.com/users/jliebrand/repos","events_url":"https://api.github.com/users/jliebrand/events{/privacy}","received_events_url":"https://api.github.com/users/jliebrand/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-24T12:36:59Z","updated_at":"2018-07-26T16:58:59Z","closed_at":"2018-07-26T16:58:59Z","author_association":"NONE","body":"Hi there,\r\n\r\nI have a SPA with dynamic bundles, so long story short: I need to use skipWaiting=false to ensure caches aren't removed from underneath the current app. This works fine, as long as the user closes the tab every now and then.\r\n\r\nI'd like to add a common \"The app has updated, please reload\" button, but I can't seem to find what message to post to the generated sw for it to call self.skipWaiting ?  In fact, looking at the code, it doesn't appear that's in there?\r\n\r\nDoes that mean that we won't be able to have the user refresh with skipWaiting=false in the config?"},"comment":{"url":"https://api.github.com/repos/GoogleChromeLabs/sw-precache/issues/comments/408164775","html_url":"https://github.com/GoogleChromeLabs/sw-precache/issues/364#issuecomment-408164775","issue_url":"https://api.github.com/repos/GoogleChromeLabs/sw-precache/issues/364","id":408164775,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODE2NDc3NQ==","user":{"login":"jeffposnick","id":1749548,"node_id":"MDQ6VXNlcjE3NDk1NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1749548?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffposnick","html_url":"https://github.com/jeffposnick","followers_url":"https://api.github.com/users/jeffposnick/followers","following_url":"https://api.github.com/users/jeffposnick/following{/other_user}","gists_url":"https://api.github.com/users/jeffposnick/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffposnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffposnick/subscriptions","organizations_url":"https://api.github.com/users/jeffposnick/orgs","repos_url":"https://api.github.com/users/jeffposnick/repos","events_url":"https://api.github.com/users/jeffposnick/events{/privacy}","received_events_url":"https://api.github.com/users/jeffposnick/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T16:58:59Z","updated_at":"2018-07-26T16:58:59Z","author_association":"COLLABORATOR","body":"So, it's not likely that anything like that will be added to `sw-precache`. The team's [focus](https://github.com/GoogleChromeLabs/sw-precache#support) has been on enhancing the successor, [Workbox](https://developers.google.com/web/tools/workbox/), for a while now.\r\n\r\nWe have a [guide in the Workbox](https://developers.google.com/web/tools/workbox/guides/advanced-recipes#offer_a_page_reload_for_users) docs for handling what you describe, and some of it would also apply to `sw-precache`."}}
{"actor":{"display_login":"jeffposnick"}}