{"action":"closed","number":4207,"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/4207","id":212487049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDg3MDQ5","html_url":"https://github.com/learningequality/kolibri/pull/4207","diff_url":"https://github.com/learningequality/kolibri/pull/4207.diff","patch_url":"https://github.com/learningequality/kolibri/pull/4207.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/4207","number":4207,"state":"closed","locked":false,"title":"Fix cancellation of metadata download DBs","user":{"login":"jonboiser","id":10248067,"node_id":"MDQ6VXNlcjEwMjQ4MDY3","avatar_url":"https://avatars2.githubusercontent.com/u/10248067?v=4","gravatar_id":"","url":"https://api.github.com/users/jonboiser","html_url":"https://github.com/jonboiser","followers_url":"https://api.github.com/users/jonboiser/followers","following_url":"https://api.github.com/users/jonboiser/following{/other_user}","gists_url":"https://api.github.com/users/jonboiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboiser/subscriptions","organizations_url":"https://api.github.com/users/jonboiser/orgs","repos_url":"https://api.github.com/users/jonboiser/repos","events_url":"https://api.github.com/users/jonboiser/events{/privacy}","received_events_url":"https://api.github.com/users/jonboiser/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nThis fixes an issue #4206 where a Task Status bar would appear on the Manage  Content Page after cancelling a Channel Metadata Download task on the Select Content Page for the channel.\r\n\r\nThis happened because of a race condition between the router and component lifecycle (a state-resetting router beforeEach hook for the next page happened before the SelectContentPage's beforeDestroy  hook).\r\n\r\nThis fixes it by storing the data needed to cancel the Task within the SelectContentPage instance.\r\n\r\nThis also fixes some behavior during channel update cancellation where the main area of the Select Content Page and other elements would appear when a cancellation and full-page refresh were impending. Now, this flash should not appear.\r\n\r\n![cancelling](https://user-images.githubusercontent.com/10248067/44934424-97f8ef80-ad21-11e8-8fcf-fb2752f21b1a.gif)\r\n\r\n### Reviewer guidance\r\n\r\n1. Try to import from a channel not yet installed on the server\r\n1. Cancel the import before the metadata can be completely downloaded\r\n1. You should be taken back to the Manage Content Page and not see any Task Status element.\r\n\r\nTry the same with updating a channel (although you're at risk of running into Database locked issues, depending on the channel).\r\n\r\n### References\r\n\r\n#4206 \r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [x] Contributor has fully tested the PR manually\r\n- [x] PR has the correct target branch and milestone\r\n- [x] PR has 'needs review' or 'work-in-progress' label\r\n- [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [ ] If there are any front-end changes, before/after screenshots are included\r\n- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n","created_at":"2018-08-31T20:28:15Z","updated_at":"2018-09-17T16:30:29Z","closed_at":"2018-09-17T16:30:29Z","merged_at":"2018-09-17T16:30:29Z","merge_commit_sha":"3678f0380631c2d2aa2aa92ea88aadf7340df883","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":410338552,"node_id":"MDU6TGFiZWw0MTAzMzg1NTI=","url":"https://api.github.com/repos/learningequality/kolibri/labels/PR:%20needs%20review","name":"PR: needs review","color":"1f6ad6","default":false}],"milestone":{"url":"https://api.github.com/repos/learningequality/kolibri/milestones/22","html_url":"https://github.com/learningequality/kolibri/milestone/22","labels_url":"https://api.github.com/repos/learningequality/kolibri/milestones/22/labels","id":3254318,"node_id":"MDk6TWlsZXN0b25lMzI1NDMxOA==","number":22,"title":"0.11.0","description":"","creator":{"login":"indirectlylit","id":2367265,"node_id":"MDQ6VXNlcjIzNjcyNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":82,"state":"open","created_at":"2018-04-09T23:34:55Z","updated_at":"2018-09-17T16:30:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/4207/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/4207/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/4207/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/6a807f22d6687797eb4effb680ded647f395e8b2","head":{"label":"jonboiser:fix-task-cancel","ref":"fix-task-cancel","sha":"6a807f22d6687797eb4effb680ded647f395e8b2","user":{"login":"jonboiser","id":10248067,"node_id":"MDQ6VXNlcjEwMjQ4MDY3","avatar_url":"https://avatars2.githubusercontent.com/u/10248067?v=4","gravatar_id":"","url":"https://api.github.com/users/jonboiser","html_url":"https://github.com/jonboiser","followers_url":"https://api.github.com/users/jonboiser/followers","following_url":"https://api.github.com/users/jonboiser/following{/other_user}","gists_url":"https://api.github.com/users/jonboiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboiser/subscriptions","organizations_url":"https://api.github.com/users/jonboiser/orgs","repos_url":"https://api.github.com/users/jonboiser/repos","events_url":"https://api.github.com/users/jonboiser/events{/privacy}","received_events_url":"https://api.github.com/users/jonboiser/received_events","type":"User","site_admin":false},"repo":{"id":86381998,"node_id":"MDEwOlJlcG9zaXRvcnk4NjM4MTk5OA==","name":"kolibri","full_name":"jonboiser/kolibri","private":false,"owner":{"login":"jonboiser","id":10248067,"node_id":"MDQ6VXNlcjEwMjQ4MDY3","avatar_url":"https://avatars2.githubusercontent.com/u/10248067?v=4","gravatar_id":"","url":"https://api.github.com/users/jonboiser","html_url":"https://github.com/jonboiser","followers_url":"https://api.github.com/users/jonboiser/followers","following_url":"https://api.github.com/users/jonboiser/following{/other_user}","gists_url":"https://api.github.com/users/jonboiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboiser/subscriptions","organizations_url":"https://api.github.com/users/jonboiser/orgs","repos_url":"https://api.github.com/users/jonboiser/repos","events_url":"https://api.github.com/users/jonboiser/events{/privacy}","received_events_url":"https://api.github.com/users/jonboiser/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jonboiser/kolibri","description":"Kolibri: the offline app for universal education","fork":true,"url":"https://api.github.com/repos/jonboiser/kolibri","forks_url":"https://api.github.com/repos/jonboiser/kolibri/forks","keys_url":"https://api.github.com/repos/jonboiser/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonboiser/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonboiser/kolibri/teams","hooks_url":"https://api.github.com/repos/jonboiser/kolibri/hooks","issue_events_url":"https://api.github.com/repos/jonboiser/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/jonboiser/kolibri/events","assignees_url":"https://api.github.com/repos/jonboiser/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/jonboiser/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/jonboiser/kolibri/tags","blobs_url":"https://api.github.com/repos/jonboiser/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonboiser/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonboiser/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonboiser/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonboiser/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/jonboiser/kolibri/languages","stargazers_url":"https://api.github.com/repos/jonboiser/kolibri/stargazers","contributors_url":"https://api.github.com/repos/jonboiser/kolibri/contributors","subscribers_url":"https://api.github.com/repos/jonboiser/kolibri/subscribers","subscription_url":"https://api.github.com/repos/jonboiser/kolibri/subscription","commits_url":"https://api.github.com/repos/jonboiser/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonboiser/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonboiser/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonboiser/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonboiser/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/jonboiser/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonboiser/kolibri/merges","archive_url":"https://api.github.com/repos/jonboiser/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonboiser/kolibri/downloads","issues_url":"https://api.github.com/repos/jonboiser/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/jonboiser/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/jonboiser/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/jonboiser/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonboiser/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/jonboiser/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/jonboiser/kolibri/deployments","created_at":"2017-03-27T20:40:59Z","updated_at":"2018-06-28T22:38:39Z","pushed_at":"2018-09-14T21:27:48Z","git_url":"git://github.com/jonboiser/kolibri.git","ssh_url":"git@github.com:jonboiser/kolibri.git","clone_url":"https://github.com/jonboiser/kolibri.git","svn_url":"https://github.com/jonboiser/kolibri","homepage":"http://learningequality.org/kolibri/","size":43923,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"learningequality:develop","ref":"develop","sha":"fc86e8976118f6aa917b110a73374bf3f14c3b8d","user":{"login":"learningequality","id":3926525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3NjkzOQ==","name":"kolibri","full_name":"learningequality/kolibri","private":false,"owner":{"login":"learningequality","id":3926525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/learningequality/kolibri","description":"Kolibri: the offline app for universal education","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2018-09-17T16:26:18Z","pushed_at":"2018-09-17T16:30:28Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"https://learningequality.org/kolibri/","size":44337,"stargazers_count":202,"watchers_count":202,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"open_issues_count":311,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":143,"open_issues":311,"watchers":202,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/4207"},"html":{"href":"https://github.com/learningequality/kolibri/pull/4207"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/4207"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/4207/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/4207/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/4207/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/6a807f22d6687797eb4effb680ded647f395e8b2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rtibbles","id":1680573,"node_id":"MDQ6VXNlcjE2ODA1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1680573?v=4","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"rtibbles"}}