{"action":"created","comment":{"url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments/195912616","pull_request_review_id":129373449,"id":195912616,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTkxMjYxNg==","diff_hunk":"@@ -426,6 +427,13 @@ exports.Rewriter = class Rewriter\n       tokens[method] generate 'TERMINATOR', '\\n', tokens[j] unless tokens[j][0] is 'TERMINATOR'\n       tokens[method] generate 'JS', '', tokens[j], token\n \n+    dontShiftForward = (i, tokens) ->","path":"src/rewriter.coffee","position":12,"original_position":12,"commit_id":"2a8bfd72cfe875a76c77cb225dad91d516d52084","original_commit_id":"1893b5cf3a0effeeaa0cdd2cc732a42b6fe9f190","user":{"login":"GeoffreyBooth","id":456802,"node_id":"MDQ6VXNlcjQ1NjgwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/456802?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"body":"The rewriting function that keeps comments inside interpolation (`}`) blocks should be keeping this one from shifting onto the other side of the `}`. If it doesn’t, that’s a bug in its own right that should be fixed; and it should probably be fixed in `rescueStowawayComments`, not by adding another rewriter function.","created_at":"2018-06-16T21:40:03Z","updated_at":"2018-06-16T21:40:03Z","html_url":"https://github.com/jashkenas/coffeescript/pull/5079#discussion_r195912616","pull_request_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/5079","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments/195912616"},"html":{"href":"https://github.com/jashkenas/coffeescript/pull/5079#discussion_r195912616"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/5079"}},"in_reply_to_id":194605456},"pull_request":{"url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/5079","id":190755600,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzU1NjAw","html_url":"https://github.com/jashkenas/coffeescript/pull/5079","diff_url":"https://github.com/jashkenas/coffeescript/pull/5079.diff","patch_url":"https://github.com/jashkenas/coffeescript/pull/5079.patch","issue_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/5079","number":5079,"state":"open","locked":false,"title":"Preserve empty interpolations","user":{"login":"helixbass","id":440230,"node_id":"MDQ6VXNlcjQ0MDIzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/440230?v=4","gravatar_id":"","url":"https://api.github.com/users/helixbass","html_url":"https://github.com/helixbass","followers_url":"https://api.github.com/users/helixbass/followers","following_url":"https://api.github.com/users/helixbass/following{/other_user}","gists_url":"https://api.github.com/users/helixbass/gists{/gist_id}","starred_url":"https://api.github.com/users/helixbass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helixbass/subscriptions","organizations_url":"https://api.github.com/users/helixbass/orgs","repos_url":"https://api.github.com/users/helixbass/repos","events_url":"https://api.github.com/users/helixbass/events{/privacy}","received_events_url":"https://api.github.com/users/helixbass/received_events","type":"User","site_admin":false},"body":"@GeoffreyBooth I ran into the need to preserve empty interpolations (`#{}`) for Prettier, so figured it was a good excuse to do the refactoring of interpolated strings that you [suggested](https://github.com/jashkenas/coffeescript/pull/5057#issuecomment-388678970)\r\n\r\nThis is currently based on my `preserve-string-literal` branch (#5057), see [here](https://github.com/helixbass/copheescript/compare/preserve-string-literal...preserve-empty-interpolations) for now for the diff of just this branch, or once that gets merged I can rebase/retarget to `master`","created_at":"2018-05-26T19:15:35Z","updated_at":"2018-06-16T21:40:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28177f3894967d66e69304678c0eb831b5231b7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/5079/commits","review_comments_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/5079/comments","review_comment_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/5079/comments","statuses_url":"https://api.github.com/repos/jashkenas/coffeescript/statuses/2a8bfd72cfe875a76c77cb225dad91d516d52084","head":{"label":"helixbass:preserve-empty-interpolations","ref":"preserve-empty-interpolations","sha":"2a8bfd72cfe875a76c77cb225dad91d516d52084","user":{"login":"helixbass","id":440230,"node_id":"MDQ6VXNlcjQ0MDIzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/440230?v=4","gravatar_id":"","url":"https://api.github.com/users/helixbass","html_url":"https://github.com/helixbass","followers_url":"https://api.github.com/users/helixbass/followers","following_url":"https://api.github.com/users/helixbass/following{/other_user}","gists_url":"https://api.github.com/users/helixbass/gists{/gist_id}","starred_url":"https://api.github.com/users/helixbass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helixbass/subscriptions","organizations_url":"https://api.github.com/users/helixbass/orgs","repos_url":"https://api.github.com/users/helixbass/repos","events_url":"https://api.github.com/users/helixbass/events{/privacy}","received_events_url":"https://api.github.com/users/helixbass/received_events","type":"User","site_admin":false},"repo":{"id":33657555,"node_id":"MDEwOlJlcG9zaXRvcnkzMzY1NzU1NQ==","name":"copheescript","full_name":"helixbass/copheescript","owner":{"login":"helixbass","id":440230,"node_id":"MDQ6VXNlcjQ0MDIzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/440230?v=4","gravatar_id":"","url":"https://api.github.com/users/helixbass","html_url":"https://github.com/helixbass","followers_url":"https://api.github.com/users/helixbass/followers","following_url":"https://api.github.com/users/helixbass/following{/other_user}","gists_url":"https://api.github.com/users/helixbass/gists{/gist_id}","starred_url":"https://api.github.com/users/helixbass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helixbass/subscriptions","organizations_url":"https://api.github.com/users/helixbass/orgs","repos_url":"https://api.github.com/users/helixbass/repos","events_url":"https://api.github.com/users/helixbass/events{/privacy}","received_events_url":"https://api.github.com/users/helixbass/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helixbass/copheescript","description":"Unfancy JavaScript","fork":true,"url":"https://api.github.com/repos/helixbass/copheescript","forks_url":"https://api.github.com/repos/helixbass/copheescript/forks","keys_url":"https://api.github.com/repos/helixbass/copheescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helixbass/copheescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helixbass/copheescript/teams","hooks_url":"https://api.github.com/repos/helixbass/copheescript/hooks","issue_events_url":"https://api.github.com/repos/helixbass/copheescript/issues/events{/number}","events_url":"https://api.github.com/repos/helixbass/copheescript/events","assignees_url":"https://api.github.com/repos/helixbass/copheescript/assignees{/user}","branches_url":"https://api.github.com/repos/helixbass/copheescript/branches{/branch}","tags_url":"https://api.github.com/repos/helixbass/copheescript/tags","blobs_url":"https://api.github.com/repos/helixbass/copheescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helixbass/copheescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helixbass/copheescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/helixbass/copheescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helixbass/copheescript/statuses/{sha}","languages_url":"https://api.github.com/repos/helixbass/copheescript/languages","stargazers_url":"https://api.github.com/repos/helixbass/copheescript/stargazers","contributors_url":"https://api.github.com/repos/helixbass/copheescript/contributors","subscribers_url":"https://api.github.com/repos/helixbass/copheescript/subscribers","subscription_url":"https://api.github.com/repos/helixbass/copheescript/subscription","commits_url":"https://api.github.com/repos/helixbass/copheescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/helixbass/copheescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/helixbass/copheescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/helixbass/copheescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/helixbass/copheescript/contents/{+path}","compare_url":"https://api.github.com/repos/helixbass/copheescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helixbass/copheescript/merges","archive_url":"https://api.github.com/repos/helixbass/copheescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helixbass/copheescript/downloads","issues_url":"https://api.github.com/repos/helixbass/copheescript/issues{/number}","pulls_url":"https://api.github.com/repos/helixbass/copheescript/pulls{/number}","milestones_url":"https://api.github.com/repos/helixbass/copheescript/milestones{/number}","notifications_url":"https://api.github.com/repos/helixbass/copheescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helixbass/copheescript/labels{/name}","releases_url":"https://api.github.com/repos/helixbass/copheescript/releases{/id}","deployments_url":"https://api.github.com/repos/helixbass/copheescript/deployments","created_at":"2015-04-09T08:28:47Z","updated_at":"2016-08-10T16:03:24Z","pushed_at":"2018-06-16T15:59:38Z","git_url":"git://github.com/helixbass/copheescript.git","ssh_url":"git@github.com:helixbass/copheescript.git","clone_url":"https://github.com/helixbass/copheescript.git","svn_url":"https://github.com/helixbass/copheescript","homepage":"http://coffeescript.org/","size":29416,"stargazers_count":2,"watchers_count":2,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"jashkenas:ast","ref":"ast","sha":"8a2519544269153c99c295b0729a6be07acf1939","user":{"login":"jashkenas","id":4732,"node_id":"MDQ6VXNlcjQ3MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4732?v=4","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"repo":{"id":441269,"node_id":"MDEwOlJlcG9zaXRvcnk0NDEyNjk=","name":"coffeescript","full_name":"jashkenas/coffeescript","owner":{"login":"jashkenas","id":4732,"node_id":"MDQ6VXNlcjQ3MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4732?v=4","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jashkenas/coffeescript","description":"Unfancy JavaScript","fork":false,"url":"https://api.github.com/repos/jashkenas/coffeescript","forks_url":"https://api.github.com/repos/jashkenas/coffeescript/forks","keys_url":"https://api.github.com/repos/jashkenas/coffeescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jashkenas/coffeescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jashkenas/coffeescript/teams","hooks_url":"https://api.github.com/repos/jashkenas/coffeescript/hooks","issue_events_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/events{/number}","events_url":"https://api.github.com/repos/jashkenas/coffeescript/events","assignees_url":"https://api.github.com/repos/jashkenas/coffeescript/assignees{/user}","branches_url":"https://api.github.com/repos/jashkenas/coffeescript/branches{/branch}","tags_url":"https://api.github.com/repos/jashkenas/coffeescript/tags","blobs_url":"https://api.github.com/repos/jashkenas/coffeescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jashkenas/coffeescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jashkenas/coffeescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jashkenas/coffeescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jashkenas/coffeescript/statuses/{sha}","languages_url":"https://api.github.com/repos/jashkenas/coffeescript/languages","stargazers_url":"https://api.github.com/repos/jashkenas/coffeescript/stargazers","contributors_url":"https://api.github.com/repos/jashkenas/coffeescript/contributors","subscribers_url":"https://api.github.com/repos/jashkenas/coffeescript/subscribers","subscription_url":"https://api.github.com/repos/jashkenas/coffeescript/subscription","commits_url":"https://api.github.com/repos/jashkenas/coffeescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jashkenas/coffeescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jashkenas/coffeescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jashkenas/coffeescript/contents/{+path}","compare_url":"https://api.github.com/repos/jashkenas/coffeescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jashkenas/coffeescript/merges","archive_url":"https://api.github.com/repos/jashkenas/coffeescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jashkenas/coffeescript/downloads","issues_url":"https://api.github.com/repos/jashkenas/coffeescript/issues{/number}","pulls_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls{/number}","milestones_url":"https://api.github.com/repos/jashkenas/coffeescript/milestones{/number}","notifications_url":"https://api.github.com/repos/jashkenas/coffeescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jashkenas/coffeescript/labels{/name}","releases_url":"https://api.github.com/repos/jashkenas/coffeescript/releases{/id}","deployments_url":"https://api.github.com/repos/jashkenas/coffeescript/deployments","created_at":"2009-12-18T01:39:53Z","updated_at":"2018-06-16T18:57:43Z","pushed_at":"2018-06-16T15:59:39Z","git_url":"git://github.com/jashkenas/coffeescript.git","ssh_url":"git@github.com:jashkenas/coffeescript.git","clone_url":"https://github.com/jashkenas/coffeescript.git","svn_url":"https://github.com/jashkenas/coffeescript","homepage":"http://coffeescript.org/","size":25469,"stargazers_count":14750,"watchers_count":14750,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1973,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1973,"open_issues":28,"watchers":14750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/5079"},"html":{"href":"https://github.com/jashkenas/coffeescript/pull/5079"},"issue":{"href":"https://api.github.com/repos/jashkenas/coffeescript/issues/5079"},"comments":{"href":"https://api.github.com/repos/jashkenas/coffeescript/issues/5079/comments"},"review_comments":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/5079/comments"},"review_comment":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/5079/commits"},"statuses":{"href":"https://api.github.com/repos/jashkenas/coffeescript/statuses/2a8bfd72cfe875a76c77cb225dad91d516d52084"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GeoffreyBooth"}}