{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/167468919","pull_request_review_id":95690359,"id":167468919,"diff_hunk":"@@ -143,17 +145,25 @@ def async_update(self):\n         if req.status != 200:\n             _LOGGER.error(\"Request failed with status: %u\", req.status)\n             return False\n-        data = yield from req.json()\n-        for (api, ha_name) in API_HA_MAP:\n-            self.data[ha_name] = float(data[\"value\"][0][api])\n-        on_peak_download = self.data[\"onpeak_download\"]\n-        on_peak_upload = self.data[\"onpeak_upload\"]\n-        off_peak_download = self.data[\"offpeak_download\"]\n-        off_peak_upload = self.data[\"offpeak_upload\"]\n-        limit = self.data[\"limit\"]\n-        self.data[\"usage\"] = 100*on_peak_download/self.bandwidth_cap\n-        self.data[\"usage_gb\"] = on_peak_download\n-        self.data[\"onpeak_total\"] = on_peak_download + on_peak_upload\n-        self.data[\"offpeak_total\"] = off_peak_download + off_peak_upload\n-        self.data[\"onpeak_remaining\"] = limit - on_peak_download\n-        return True\n+        else:\n+            try:\n+                data = yield from req.json()\n+                for (api, ha_name) in API_HA_MAP:\n+                    self.data[ha_name] = float(data[\"value\"][0][api])\n+                on_peak_download = self.data[\"onpeak_download\"]\n+                on_peak_upload = self.data[\"onpeak_upload\"]\n+                off_peak_download = self.data[\"offpeak_download\"]\n+                off_peak_upload = self.data[\"offpeak_upload\"]\n+                limit = self.data[\"limit\"]\n+                # Support \"unlimited\" users\n+                self.data[\"usage\"] = 100*on_peak_download/self.bandwidth_cap\\\n+                    if self.bandwidth_cap > 0 else 0\n+                self.data[\"usage_gb\"] = on_peak_download\n+                self.data[\"onpeak_total\"] = on_peak_download + on_peak_upload\n+                self.data[\"offpeak_total\"] = off_peak_download +\\\n+                    off_peak_upload\n+                self.data[\"onpeak_remaining\"] = limit - on_peak_download\n+                return True\n+            except ValueError:","path":"homeassistant/components/sensor/teksavvy.py","position":62,"original_position":62,"commit_id":"f5fbca3bc77daf081ebc71b37590c04715892aea","original_commit_id":"f5fbca3bc77daf081ebc71b37590c04715892aea","user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"What can cause a JSON decode error?","created_at":"2018-02-12T04:53:18Z","updated_at":"2018-02-12T04:53:18Z","html_url":"https://github.com/home-assistant/home-assistant/pull/12325#discussion_r167468919","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12325","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/167468919"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12325#discussion_r167468919"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12325"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12325","id":168481936,"html_url":"https://github.com/home-assistant/home-assistant/pull/12325","diff_url":"https://github.com/home-assistant/home-assistant/pull/12325.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/12325.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12325","number":12325,"state":"open","locked":false,"title":"TekSavvy Sensor unlimited bandwidth support","user":{"login":"mikeodr","id":61757,"avatar_url":"https://avatars3.githubusercontent.com/u/61757?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeodr","html_url":"https://github.com/mikeodr","followers_url":"https://api.github.com/users/mikeodr/followers","following_url":"https://api.github.com/users/mikeodr/following{/other_user}","gists_url":"https://api.github.com/users/mikeodr/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeodr/subscriptions","organizations_url":"https://api.github.com/users/mikeodr/orgs","repos_url":"https://api.github.com/users/mikeodr/repos","events_url":"https://api.github.com/users/mikeodr/events{/privacy}","received_events_url":"https://api.github.com/users/mikeodr/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nAdd support for ISP TekSavvy sensor on uncapped plans.\r\nUnit tests added for TekSavvy component, none were present previously.\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#4645\r\n\r\n## Breaking Change:\r\n\r\nThe sensor entity id for peak upload usage used to be `sensor.teksavvy_on_peak_upload_` this has been changed to `sensor.teksavvy_on_peak_upload`\r\n\r\nThe `usage` title was shared between and therefore indeterminate between GB and % usage. Therefore % usage entity ID has been changed to `sensor.teksavvy_usage_ratio`\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nsensor:\r\n  - platform: teksavvy\r\n    api_key:  API_KEY_HERE\r\n    total_bandwidth: 0\r\n    monitored_variables:\r\n      - usage\r\n      - usage_gb\r\n      - limit\r\n      - onpeak_download\r\n      - onpeak_upload\r\n      - onpeak_total\r\n      - offpeak_download\r\n      - offpeak_upload\r\n      - offpeak_total\r\n      - onpeak_remaining\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [x] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [x] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-02-11T23:44:49Z","updated_at":"2018-02-12T04:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d5dde2dbc26fccd9cec8250a5394674be9ee220","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":457646398,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/breaking%20change","name":"breaking change","color":"d93f0b","default":false},{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":781228068,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.teksavvy","name":"platform: sensor.teksavvy","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12325/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12325/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12325/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/f5fbca3bc77daf081ebc71b37590c04715892aea","head":{"label":"mikeodr:teksavvy-unlimited-bw-support","ref":"teksavvy-unlimited-bw-support","sha":"f5fbca3bc77daf081ebc71b37590c04715892aea","user":{"login":"mikeodr","id":61757,"avatar_url":"https://avatars3.githubusercontent.com/u/61757?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeodr","html_url":"https://github.com/mikeodr","followers_url":"https://api.github.com/users/mikeodr/followers","following_url":"https://api.github.com/users/mikeodr/following{/other_user}","gists_url":"https://api.github.com/users/mikeodr/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeodr/subscriptions","organizations_url":"https://api.github.com/users/mikeodr/orgs","repos_url":"https://api.github.com/users/mikeodr/repos","events_url":"https://api.github.com/users/mikeodr/events{/privacy}","received_events_url":"https://api.github.com/users/mikeodr/received_events","type":"User","site_admin":false},"repo":{"id":120976673,"name":"home-assistant","full_name":"mikeodr/home-assistant","owner":{"login":"mikeodr","id":61757,"avatar_url":"https://avatars3.githubusercontent.com/u/61757?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeodr","html_url":"https://github.com/mikeodr","followers_url":"https://api.github.com/users/mikeodr/followers","following_url":"https://api.github.com/users/mikeodr/following{/other_user}","gists_url":"https://api.github.com/users/mikeodr/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeodr/subscriptions","organizations_url":"https://api.github.com/users/mikeodr/orgs","repos_url":"https://api.github.com/users/mikeodr/repos","events_url":"https://api.github.com/users/mikeodr/events{/privacy}","received_events_url":"https://api.github.com/users/mikeodr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikeodr/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/mikeodr/home-assistant","forks_url":"https://api.github.com/repos/mikeodr/home-assistant/forks","keys_url":"https://api.github.com/repos/mikeodr/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikeodr/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikeodr/home-assistant/teams","hooks_url":"https://api.github.com/repos/mikeodr/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/mikeodr/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/mikeodr/home-assistant/events","assignees_url":"https://api.github.com/repos/mikeodr/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/mikeodr/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/mikeodr/home-assistant/tags","blobs_url":"https://api.github.com/repos/mikeodr/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikeodr/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikeodr/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikeodr/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikeodr/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/mikeodr/home-assistant/languages","stargazers_url":"https://api.github.com/repos/mikeodr/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/mikeodr/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/mikeodr/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/mikeodr/home-assistant/subscription","commits_url":"https://api.github.com/repos/mikeodr/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikeodr/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikeodr/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikeodr/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikeodr/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/mikeodr/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikeodr/home-assistant/merges","archive_url":"https://api.github.com/repos/mikeodr/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikeodr/home-assistant/downloads","issues_url":"https://api.github.com/repos/mikeodr/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/mikeodr/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/mikeodr/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/mikeodr/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikeodr/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/mikeodr/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/mikeodr/home-assistant/deployments","created_at":"2018-02-10T02:21:36Z","updated_at":"2018-02-10T02:21:44Z","pushed_at":"2018-02-12T04:33:58Z","git_url":"git://github.com/mikeodr/home-assistant.git","ssh_url":"git@github.com:mikeodr/home-assistant.git","clone_url":"https://github.com/mikeodr/home-assistant.git","svn_url":"https://github.com/mikeodr/home-assistant","homepage":"https://home-assistant.io","size":78723,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"7e9dcfa4c95bb80db859be9114c066bb926e066c","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-12T04:37:56Z","pushed_at":"2018-02-12T04:44:59Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78708,"stargazers_count":12483,"watchers_count":12483,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3596,"mirror_url":null,"archived":false,"open_issues_count":824,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3596,"open_issues":824,"watchers":12483,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12325"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12325"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12325"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12325/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12325/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12325/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/f5fbca3bc77daf081ebc71b37590c04715892aea"}},"author_association":"NONE"}}
{"actor":{"display_login":"balloob"}}