{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/188005723","pull_request_review_id":119897857,"id":188005723,"diff_hunk":"@@ -1005,26 +1008,32 @@ public TextLoader(IHostEnvironment env, Arguments args, IMultiStreamSource files\n                 _inputSize = SrcLim - 1;\n \n             _host.CheckNonEmpty(args.Separator, nameof(args.Separator), \"Must specify a separator\");\n-            string sep = args.Separator.ToLowerInvariant();\n+            _host.CheckNonEmpty(args.Delimiter.ToString(), nameof(args.Delimiter), \"Must specify a delimeter\");\n \n-            if (sep == \",\")\n-                _separators = new char[] { ',' };\n+            if (args.Delimiter != '\\t')\n+                _separators = new char[] { args.Delimiter };","path":"src/Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs","position":24,"original_position":24,"commit_id":"a61d244d885c8d7e756c0e0650e7016e0c126cf3","original_commit_id":"a61d244d885c8d7e756c0e0650e7016e0c126cf3","user":{"login":"TomFinley","id":8295757,"avatar_url":"https://avatars1.githubusercontent.com/u/8295757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomFinley","html_url":"https://github.com/TomFinley","followers_url":"https://api.github.com/users/TomFinley/followers","following_url":"https://api.github.com/users/TomFinley/following{/other_user}","gists_url":"https://api.github.com/users/TomFinley/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFinley/subscriptions","organizations_url":"https://api.github.com/users/TomFinley/orgs","repos_url":"https://api.github.com/users/TomFinley/repos","events_url":"https://api.github.com/users/TomFinley/events{/privacy}","received_events_url":"https://api.github.com/users/TomFinley/received_events","type":"User","site_admin":false},"body":"Maybe comment on the code how this relies on the fact that the default `arg.Separator` is `\"tab\"`, since to a reader this will look odd.","created_at":"2018-05-14T15:52:58Z","updated_at":"2018-05-14T15:52:58Z","html_url":"https://github.com/dotnet/machinelearning/pull/142#discussion_r188005723","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/142","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/188005723"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/142#discussion_r188005723"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/142","id":187756043,"html_url":"https://github.com/dotnet/machinelearning/pull/142","diff_url":"https://github.com/dotnet/machinelearning/pull/142.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/142.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/142","number":142,"state":"open","locked":false,"title":"Code generate TextLoader API and make it backward compatible with existing TextLoader API.","user":{"login":"codemzs","id":1211949,"avatar_url":"https://avatars3.githubusercontent.com/u/1211949?v=4","gravatar_id":"","url":"https://api.github.com/users/codemzs","html_url":"https://github.com/codemzs","followers_url":"https://api.github.com/users/codemzs/followers","following_url":"https://api.github.com/users/codemzs/following{/other_user}","gists_url":"https://api.github.com/users/codemzs/gists{/gist_id}","starred_url":"https://api.github.com/users/codemzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemzs/subscriptions","organizations_url":"https://api.github.com/users/codemzs/orgs","repos_url":"https://api.github.com/users/codemzs/repos","events_url":"https://api.github.com/users/codemzs/events{/privacy}","received_events_url":"https://api.github.com/users/codemzs/received_events","type":"User","site_admin":false},"body":"*Code generate support for IDataLoader\r\n*Make TextLoader API code generated so that it's at functional parity with the text loader in the ML.Net infrastructure.\r\n*Move TextLoader API under Microsoft.ML.Data namespace\r\n*Make TextLoader API backward compatible.\r\n*Add error checking for invalid loader arguments such as ordinal, column names.\r\n*Update baselines.\r\n*Update samples with new loader API and backward compatibility with old loader API.\r\n\r\n[*ADDRESS COMMENTS FROM PR# 38*](https://github.com/dotnet/machinelearning/pull/38)\r\n","created_at":"2018-05-14T08:42:57Z","updated_at":"2018-05-14T15:52:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"725558e9454b24e313d9a87cf6491d6875bf1032","assignee":null,"assignees":[],"requested_reviewers":[{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/142/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/142/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/142/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/a61d244d885c8d7e756c0e0650e7016e0c126cf3","head":{"label":"codemzs:loader","ref":"loader","sha":"a61d244d885c8d7e756c0e0650e7016e0c126cf3","user":{"login":"codemzs","id":1211949,"avatar_url":"https://avatars3.githubusercontent.com/u/1211949?v=4","gravatar_id":"","url":"https://api.github.com/users/codemzs","html_url":"https://github.com/codemzs","followers_url":"https://api.github.com/users/codemzs/followers","following_url":"https://api.github.com/users/codemzs/following{/other_user}","gists_url":"https://api.github.com/users/codemzs/gists{/gist_id}","starred_url":"https://api.github.com/users/codemzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemzs/subscriptions","organizations_url":"https://api.github.com/users/codemzs/orgs","repos_url":"https://api.github.com/users/codemzs/repos","events_url":"https://api.github.com/users/codemzs/events{/privacy}","received_events_url":"https://api.github.com/users/codemzs/received_events","type":"User","site_admin":false},"repo":{"id":132967177,"name":"machinelearning","full_name":"codemzs/machinelearning","owner":{"login":"codemzs","id":1211949,"avatar_url":"https://avatars3.githubusercontent.com/u/1211949?v=4","gravatar_id":"","url":"https://api.github.com/users/codemzs","html_url":"https://github.com/codemzs","followers_url":"https://api.github.com/users/codemzs/followers","following_url":"https://api.github.com/users/codemzs/following{/other_user}","gists_url":"https://api.github.com/users/codemzs/gists{/gist_id}","starred_url":"https://api.github.com/users/codemzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemzs/subscriptions","organizations_url":"https://api.github.com/users/codemzs/orgs","repos_url":"https://api.github.com/users/codemzs/repos","events_url":"https://api.github.com/users/codemzs/events{/privacy}","received_events_url":"https://api.github.com/users/codemzs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codemzs/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/codemzs/machinelearning","forks_url":"https://api.github.com/repos/codemzs/machinelearning/forks","keys_url":"https://api.github.com/repos/codemzs/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codemzs/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codemzs/machinelearning/teams","hooks_url":"https://api.github.com/repos/codemzs/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/codemzs/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/codemzs/machinelearning/events","assignees_url":"https://api.github.com/repos/codemzs/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/codemzs/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/codemzs/machinelearning/tags","blobs_url":"https://api.github.com/repos/codemzs/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codemzs/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codemzs/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/codemzs/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codemzs/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/codemzs/machinelearning/languages","stargazers_url":"https://api.github.com/repos/codemzs/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/codemzs/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/codemzs/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/codemzs/machinelearning/subscription","commits_url":"https://api.github.com/repos/codemzs/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/codemzs/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/codemzs/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/codemzs/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/codemzs/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/codemzs/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codemzs/machinelearning/merges","archive_url":"https://api.github.com/repos/codemzs/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codemzs/machinelearning/downloads","issues_url":"https://api.github.com/repos/codemzs/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/codemzs/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/codemzs/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/codemzs/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codemzs/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/codemzs/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/codemzs/machinelearning/deployments","created_at":"2018-05-11T00:07:14Z","updated_at":"2018-05-11T00:14:39Z","pushed_at":"2018-05-14T08:40:10Z","git_url":"git://github.com/codemzs/machinelearning.git","ssh_url":"git@github.com:codemzs/machinelearning.git","clone_url":"https://github.com/codemzs/machinelearning.git","svn_url":"https://github.com/codemzs/machinelearning","homepage":"http://dot.net/ml","size":16872,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"54a0b420262001c4db68e8f7d0524bd30328411c","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"name":"machinelearning","full_name":"dotnet/machinelearning","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-05-14T15:36:56Z","pushed_at":"2018-05-14T14:39:33Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"http://dot.net/ml","size":16963,"stargazers_count":1750,"watchers_count":1750,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":168,"open_issues":81,"watchers":1750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/142"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/142"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/142"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/a61d244d885c8d7e756c0e0650e7016e0c126cf3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TomFinley"}}