{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/186608087","pull_request_review_id":118217851,"id":186608087,"diff_hunk":"@@ -28,7 +28,7 @@ const (\n \n var configFields = environschema.Fields{\n \tJujuManagedUnits: {\n-\t\tDescription: \"whether Juju manages unit lifecycle or the CAAS substrate\",\n+\t\tDescription: \"DEPRECATED - whether Juju manages unit lifecycle or the CAAS substrate(it is always set to false now)\",","path":"caas/config.go","position":5,"original_position":5,"commit_id":"105b8d3f452a4015353f2372a4e4133d71571752","original_commit_id":"f0ff02262e2a0d130a8491210ade4daebd88845e","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"body":"Niiice :D ","created_at":"2018-05-08T03:24:04Z","updated_at":"2018-05-08T03:27:07Z","html_url":"https://github.com/juju/juju/pull/8675#discussion_r186608087","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/8675","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/186608087"},"html":{"href":"https://github.com/juju/juju/pull/8675#discussion_r186608087"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/8675"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/8675","id":186509390,"html_url":"https://github.com/juju/juju/pull/8675","diff_url":"https://github.com/juju/juju/pull/8675.diff","patch_url":"https://github.com/juju/juju/pull/8675.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/8675","number":8675,"state":"open","locked":false,"title":"Feature/hide juju managed units","user":{"login":"ycliuhw","id":6562925,"avatar_url":"https://avatars3.githubusercontent.com/u/6562925?v=4","gravatar_id":"","url":"https://api.github.com/users/ycliuhw","html_url":"https://github.com/ycliuhw","followers_url":"https://api.github.com/users/ycliuhw/followers","following_url":"https://api.github.com/users/ycliuhw/following{/other_user}","gists_url":"https://api.github.com/users/ycliuhw/gists{/gist_id}","starred_url":"https://api.github.com/users/ycliuhw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycliuhw/subscriptions","organizations_url":"https://api.github.com/users/ycliuhw/orgs","repos_url":"https://api.github.com/users/ycliuhw/repos","events_url":"https://api.github.com/users/ycliuhw/events{/privacy}","received_events_url":"https://api.github.com/users/ycliuhw/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n\r\nHide `juju-managed-units` from user(immutable for users, always equals to `false`)\r\n\r\n## QA steps\r\n1. unit tests ensure.\r\n2. deploy any caas charm to caas model with `juju-managed-units=true` configed by `juju deploy <charm-build-dir> --config juju-managed-units=true`, then run `kubectl get deploy -n <caas-model-name>`, the `deployment` resource of the app should be created.\r\n\r\n##### deploy with this branch and develop branch build with `juju-managed-units=true`\r\n```bash\r\njuju deploy ./builds/mysql  --config juju-managed-units=true \r\n```\r\n```bash\r\nkubectl get all -n testcaas1   # k8s managed created svc and deployment resources <this PR>\r\n```\r\n```\r\nNAME                DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE\r\ndeploy/juju-mysql   1         1         1            0           42s\r\n\r\nNAME                       DESIRED   CURRENT   READY     AGE\r\nrs/juju-mysql-6fc5f55fbf   1         1         0         42s\r\n\r\nNAME                DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE\r\ndeploy/juju-mysql   1         1         1            0           42s\r\n\r\nNAME                       DESIRED   CURRENT   READY     AGE\r\nrs/juju-mysql-6fc5f55fbf   1         1         0         42s\r\n\r\nNAME                             READY     STATUS              RESTARTS   AGE\r\npo/juju-mysql-6fc5f55fbf-n2gbz   0/1       ContainerCreating   0          42s\r\npo/juju-operator-mysql           1/1       Running             0          2m\r\n\r\nNAME             TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE\r\nsvc/juju-mysql   ClusterIP   10.152.183.23   <none>        3306/TCP   42s\r\n```\r\n\r\n```bash\r\nkubectl get all -n testcaas2   # juju managed only created svc but no deployment resources <`current develop branch`>\r\n```\r\n```\r\nNAME                     READY     STATUS    RESTARTS   AGE\r\npo/juju-operator-mysql   1/1       Running   0          28s\r\npo/juju-unit-mysql-0     1/1       Running   0          18s\r\n\r\nNAME             TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE\r\nsvc/juju-mysql   ClusterIP   10.152.183.245   <none>        3306/TCP   18s\r\n```\r\n\r\n\r\n## Documentation changes\r\n\r\nConfig var description of `juju-managed-units` has been updated \r\n\r\n## Bug reference\r\nit's a feature change but not a bug\r\n","created_at":"2018-05-08T02:10:42Z","updated_at":"2018-05-08T03:27:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a040366b52baadd4c48fce1c451262ea50ee087","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/8675/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/8675/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/8675/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/105b8d3f452a4015353f2372a4e4133d71571752","head":{"label":"ycliuhw:feature/hide-juju-managed-units","ref":"feature/hide-juju-managed-units","sha":"105b8d3f452a4015353f2372a4e4133d71571752","user":{"login":"ycliuhw","id":6562925,"avatar_url":"https://avatars3.githubusercontent.com/u/6562925?v=4","gravatar_id":"","url":"https://api.github.com/users/ycliuhw","html_url":"https://github.com/ycliuhw","followers_url":"https://api.github.com/users/ycliuhw/followers","following_url":"https://api.github.com/users/ycliuhw/following{/other_user}","gists_url":"https://api.github.com/users/ycliuhw/gists{/gist_id}","starred_url":"https://api.github.com/users/ycliuhw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycliuhw/subscriptions","organizations_url":"https://api.github.com/users/ycliuhw/orgs","repos_url":"https://api.github.com/users/ycliuhw/repos","events_url":"https://api.github.com/users/ycliuhw/events{/privacy}","received_events_url":"https://api.github.com/users/ycliuhw/received_events","type":"User","site_admin":false},"repo":{"id":129208625,"name":"juju","full_name":"ycliuhw/juju","owner":{"login":"ycliuhw","id":6562925,"avatar_url":"https://avatars3.githubusercontent.com/u/6562925?v=4","gravatar_id":"","url":"https://api.github.com/users/ycliuhw","html_url":"https://github.com/ycliuhw","followers_url":"https://api.github.com/users/ycliuhw/followers","following_url":"https://api.github.com/users/ycliuhw/following{/other_user}","gists_url":"https://api.github.com/users/ycliuhw/gists{/gist_id}","starred_url":"https://api.github.com/users/ycliuhw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycliuhw/subscriptions","organizations_url":"https://api.github.com/users/ycliuhw/orgs","repos_url":"https://api.github.com/users/ycliuhw/repos","events_url":"https://api.github.com/users/ycliuhw/events{/privacy}","received_events_url":"https://api.github.com/users/ycliuhw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ycliuhw/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/ycliuhw/juju","forks_url":"https://api.github.com/repos/ycliuhw/juju/forks","keys_url":"https://api.github.com/repos/ycliuhw/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ycliuhw/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ycliuhw/juju/teams","hooks_url":"https://api.github.com/repos/ycliuhw/juju/hooks","issue_events_url":"https://api.github.com/repos/ycliuhw/juju/issues/events{/number}","events_url":"https://api.github.com/repos/ycliuhw/juju/events","assignees_url":"https://api.github.com/repos/ycliuhw/juju/assignees{/user}","branches_url":"https://api.github.com/repos/ycliuhw/juju/branches{/branch}","tags_url":"https://api.github.com/repos/ycliuhw/juju/tags","blobs_url":"https://api.github.com/repos/ycliuhw/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ycliuhw/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ycliuhw/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/ycliuhw/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ycliuhw/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/ycliuhw/juju/languages","stargazers_url":"https://api.github.com/repos/ycliuhw/juju/stargazers","contributors_url":"https://api.github.com/repos/ycliuhw/juju/contributors","subscribers_url":"https://api.github.com/repos/ycliuhw/juju/subscribers","subscription_url":"https://api.github.com/repos/ycliuhw/juju/subscription","commits_url":"https://api.github.com/repos/ycliuhw/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/ycliuhw/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/ycliuhw/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/ycliuhw/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/ycliuhw/juju/contents/{+path}","compare_url":"https://api.github.com/repos/ycliuhw/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ycliuhw/juju/merges","archive_url":"https://api.github.com/repos/ycliuhw/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ycliuhw/juju/downloads","issues_url":"https://api.github.com/repos/ycliuhw/juju/issues{/number}","pulls_url":"https://api.github.com/repos/ycliuhw/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/ycliuhw/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/ycliuhw/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ycliuhw/juju/labels{/name}","releases_url":"https://api.github.com/repos/ycliuhw/juju/releases{/id}","deployments_url":"https://api.github.com/repos/ycliuhw/juju/deployments","created_at":"2018-04-12T07:09:20Z","updated_at":"2018-05-04T01:20:46Z","pushed_at":"2018-05-08T03:26:29Z","git_url":"git://github.com/ycliuhw/juju.git","ssh_url":"git@github.com:ycliuhw/juju.git","clone_url":"https://github.com/ycliuhw/juju.git","svn_url":"https://github.com/ycliuhw/juju","homepage":"juju.ubuntu.com","size":209435,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:develop","ref":"develop","sha":"236050a25f5c851413cff7550185442d5171ef2f","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-05-07T10:14:15Z","pushed_at":"2018-05-08T03:26:29Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":209464,"stargazers_count":1154,"watchers_count":1154,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":270,"open_issues":19,"watchers":1154,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/8675"},"html":{"href":"https://github.com/juju/juju/pull/8675"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/8675"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/8675/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/8675/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/8675/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/105b8d3f452a4015353f2372a4e4133d71571752"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"anastasiamac"}}