{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/republicprotocol/republic-go/pulls/35","id":185615523,"html_url":"https://github.com/republicprotocol/republic-go/pull/35","diff_url":"https://github.com/republicprotocol/republic-go/pull/35.diff","patch_url":"https://github.com/republicprotocol/republic-go/pull/35.patch","issue_url":"https://api.github.com/repos/republicprotocol/republic-go/issues/35","number":35,"state":"closed","locked":false,"title":"Status rpc","user":{"login":"tok-kkk","id":27789539,"avatar_url":"https://avatars2.githubusercontent.com/u/27789539?v=4","gravatar_id":"","url":"https://api.github.com/users/tok-kkk","html_url":"https://github.com/tok-kkk","followers_url":"https://api.github.com/users/tok-kkk/followers","following_url":"https://api.github.com/users/tok-kkk/following{/other_user}","gists_url":"https://api.github.com/users/tok-kkk/gists{/gist_id}","starred_url":"https://api.github.com/users/tok-kkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tok-kkk/subscriptions","organizations_url":"https://api.github.com/users/tok-kkk/orgs","repos_url":"https://api.github.com/users/tok-kkk/repos","events_url":"https://api.github.com/users/tok-kkk/events{/privacy}","received_events_url":"https://api.github.com/users/tok-kkk/received_events","type":"User","site_admin":false},"body":"**Description**\r\n\r\n- New endpoint for getting status of the node \r\n- Rpc command-line tool for making rpc calls\r\n- Improve the registrar command-line tool \r\n- Add configurable tags for logger\r\n\r\n**Motivation**\r\n\r\nThe [falconry devOp tool](https://github.com/republicprotocol/falconry/pull/1) needs to display status of each nodes.\r\n\r\n> E.g. Is the node registered? Is the node bootstrapped? Number of nodes connected? ...\r\n\r\nIt needs to get these status either from the dark itself or through the darknode registry contract.\r\n\r\n**Design**\r\n\r\n- New endpoint for getting status of the node\r\n\r\nThere will be new grpc service `status` for getting status data from the node in the rpc package.\r\nIt will only has one simple rpc call which returns all the data needed in a single rpc message.\r\n\r\n- Rpc command-line tool for making rpc calls\r\n\r\nFor now, we only need the cmd to support `status` service. And we can add other rpc services \r\nin the future if needed. No package should be affected by this change.\r\n```bash\r\n$ rpc status 192.168.0.1:8080\r\n8MGfbzAMS59Gb4cSjpm34soGNYsM2ft true 32\r\n```\r\n\r\n- Improve the registrar command-line tool \r\nWe need two extra subcommand for the `registrar` cmd for getting the pool index and checking registration. We need have some help functions from the `darkocean` package.\r\n\r\n```bash\r\n$ registrar pool 8MGfbzAMS59Gb4cSjpm34soGNYsM2ft\r\n1      # index of the pool the node is in\r\n\r\n$ registrar pool 8MGfbzAMS59Gb4cSjpm34soGNYsM3as\r\n-1    # return  -1 if the node is not in any pool\r\n```\r\n\r\n```bash\r\n$ registrar checkreg 0x009FbB7Aafee69081EF24c14A55A19c3cDd25eF4\r\ntrue  # check if the node with given address has been registered\r\n```\r\n\r\n- Add configurable tags for logger\r\nLogger will have an extra field storing all the tags as key-value pair.These tags will be read from the config file. Each log message will have these tags appended for filtering .\r\n\r\n**Unresolved Issues**\r\n\r\nFor now, we only need  know if the node is bootstrapped and how many nodes it connects . We might need more status from the node as new features added in the darknode.\r\nWe might also need to support other rpc services in the cmd if needed.\r\n","created_at":"2018-05-03T04:35:42Z","updated_at":"2018-05-07T06:25:06Z","closed_at":"2018-05-07T06:25:06Z","merged_at":"2018-05-07T06:25:06Z","merge_commit_sha":"1dee6448722ae26e3dcccb30e9f78236c4acaf1f","assignee":{"login":"tok-kkk","id":27789539,"avatar_url":"https://avatars2.githubusercontent.com/u/27789539?v=4","gravatar_id":"","url":"https://api.github.com/users/tok-kkk","html_url":"https://github.com/tok-kkk","followers_url":"https://api.github.com/users/tok-kkk/followers","following_url":"https://api.github.com/users/tok-kkk/following{/other_user}","gists_url":"https://api.github.com/users/tok-kkk/gists{/gist_id}","starred_url":"https://api.github.com/users/tok-kkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tok-kkk/subscriptions","organizations_url":"https://api.github.com/users/tok-kkk/orgs","repos_url":"https://api.github.com/users/tok-kkk/repos","events_url":"https://api.github.com/users/tok-kkk/events{/privacy}","received_events_url":"https://api.github.com/users/tok-kkk/received_events","type":"User","site_admin":false},"assignees":[{"login":"tok-kkk","id":27789539,"avatar_url":"https://avatars2.githubusercontent.com/u/27789539?v=4","gravatar_id":"","url":"https://api.github.com/users/tok-kkk","html_url":"https://github.com/tok-kkk","followers_url":"https://api.github.com/users/tok-kkk/followers","following_url":"https://api.github.com/users/tok-kkk/following{/other_user}","gists_url":"https://api.github.com/users/tok-kkk/gists{/gist_id}","starred_url":"https://api.github.com/users/tok-kkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tok-kkk/subscriptions","organizations_url":"https://api.github.com/users/tok-kkk/orgs","repos_url":"https://api.github.com/users/tok-kkk/repos","events_url":"https://api.github.com/users/tok-kkk/events{/privacy}","received_events_url":"https://api.github.com/users/tok-kkk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/republicprotocol/republic-go/pulls/35/commits","review_comments_url":"https://api.github.com/repos/republicprotocol/republic-go/pulls/35/comments","review_comment_url":"https://api.github.com/repos/republicprotocol/republic-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/republicprotocol/republic-go/issues/35/comments","statuses_url":"https://api.github.com/repos/republicprotocol/republic-go/statuses/5310c10e702d2a9a779ded5e38db1f55328125a6","head":{"label":"republicprotocol:status-rpc","ref":"status-rpc","sha":"5310c10e702d2a9a779ded5e38db1f55328125a6","user":{"login":"republicprotocol","id":30725666,"avatar_url":"https://avatars0.githubusercontent.com/u/30725666?v=4","gravatar_id":"","url":"https://api.github.com/users/republicprotocol","html_url":"https://github.com/republicprotocol","followers_url":"https://api.github.com/users/republicprotocol/followers","following_url":"https://api.github.com/users/republicprotocol/following{/other_user}","gists_url":"https://api.github.com/users/republicprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/republicprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/republicprotocol/subscriptions","organizations_url":"https://api.github.com/users/republicprotocol/orgs","repos_url":"https://api.github.com/users/republicprotocol/repos","events_url":"https://api.github.com/users/republicprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/republicprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":123352488,"name":"republic-go","full_name":"republicprotocol/republic-go","owner":{"login":"republicprotocol","id":30725666,"avatar_url":"https://avatars0.githubusercontent.com/u/30725666?v=4","gravatar_id":"","url":"https://api.github.com/users/republicprotocol","html_url":"https://github.com/republicprotocol","followers_url":"https://api.github.com/users/republicprotocol/followers","following_url":"https://api.github.com/users/republicprotocol/following{/other_user}","gists_url":"https://api.github.com/users/republicprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/republicprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/republicprotocol/subscriptions","organizations_url":"https://api.github.com/users/republicprotocol/orgs","repos_url":"https://api.github.com/users/republicprotocol/repos","events_url":"https://api.github.com/users/republicprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/republicprotocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/republicprotocol/republic-go","description":"An official reference implementation of Republic Protocol, written in Go","fork":false,"url":"https://api.github.com/repos/republicprotocol/republic-go","forks_url":"https://api.github.com/repos/republicprotocol/republic-go/forks","keys_url":"https://api.github.com/repos/republicprotocol/republic-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/republicprotocol/republic-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/republicprotocol/republic-go/teams","hooks_url":"https://api.github.com/repos/republicprotocol/republic-go/hooks","issue_events_url":"https://api.github.com/repos/republicprotocol/republic-go/issues/events{/number}","events_url":"https://api.github.com/repos/republicprotocol/republic-go/events","assignees_url":"https://api.github.com/repos/republicprotocol/republic-go/assignees{/user}","branches_url":"https://api.github.com/repos/republicprotocol/republic-go/branches{/branch}","tags_url":"https://api.github.com/repos/republicprotocol/republic-go/tags","blobs_url":"https://api.github.com/repos/republicprotocol/republic-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/republicprotocol/republic-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/republicprotocol/republic-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/republicprotocol/republic-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/republicprotocol/republic-go/statuses/{sha}","languages_url":"https://api.github.com/repos/republicprotocol/republic-go/languages","stargazers_url":"https://api.github.com/repos/republicprotocol/republic-go/stargazers","contributors_url":"https://api.github.com/repos/republicprotocol/republic-go/contributors","subscribers_url":"https://api.github.com/repos/republicprotocol/republic-go/subscribers","subscription_url":"https://api.github.com/repos/republicprotocol/republic-go/subscription","commits_url":"https://api.github.com/repos/republicprotocol/republic-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/republicprotocol/republic-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/republicprotocol/republic-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/republicprotocol/republic-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/republicprotocol/republic-go/contents/{+path}","compare_url":"https://api.github.com/repos/republicprotocol/republic-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/republicprotocol/republic-go/merges","archive_url":"https://api.github.com/repos/republicprotocol/republic-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/republicprotocol/republic-go/downloads","issues_url":"https://api.github.com/repos/republicprotocol/republic-go/issues{/number}","pulls_url":"https://api.github.com/repos/republicprotocol/republic-go/pulls{/number}","milestones_url":"https://api.github.com/repos/republicprotocol/republic-go/milestones{/number}","notifications_url":"https://api.github.com/repos/republicprotocol/republic-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/republicprotocol/republic-go/labels{/name}","releases_url":"https://api.github.com/repos/republicprotocol/republic-go/releases{/id}","deployments_url":"https://api.github.com/repos/republicprotocol/republic-go/deployments","created_at":"2018-02-28T22:56:31Z","updated_at":"2018-05-07T02:52:05Z","pushed_at":"2018-05-07T06:25:06Z","git_url":"git://github.com/republicprotocol/republic-go.git","ssh_url":"git@github.com:republicprotocol/republic-go.git","clone_url":"https://github.com/republicprotocol/republic-go.git","svn_url":"https://github.com/republicprotocol/republic-go","homepage":"https://republicprotocol.com","size":82449,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":0,"watchers":22,"default_branch":"master"}},"base":{"label":"republicprotocol:develop","ref":"develop","sha":"dec3bfe548970b5b4647b03b0c003811023eb73e","user":{"login":"republicprotocol","id":30725666,"avatar_url":"https://avatars0.githubusercontent.com/u/30725666?v=4","gravatar_id":"","url":"https://api.github.com/users/republicprotocol","html_url":"https://github.com/republicprotocol","followers_url":"https://api.github.com/users/republicprotocol/followers","following_url":"https://api.github.com/users/republicprotocol/following{/other_user}","gists_url":"https://api.github.com/users/republicprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/republicprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/republicprotocol/subscriptions","organizations_url":"https://api.github.com/users/republicprotocol/orgs","repos_url":"https://api.github.com/users/republicprotocol/repos","events_url":"https://api.github.com/users/republicprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/republicprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":123352488,"name":"republic-go","full_name":"republicprotocol/republic-go","owner":{"login":"republicprotocol","id":30725666,"avatar_url":"https://avatars0.githubusercontent.com/u/30725666?v=4","gravatar_id":"","url":"https://api.github.com/users/republicprotocol","html_url":"https://github.com/republicprotocol","followers_url":"https://api.github.com/users/republicprotocol/followers","following_url":"https://api.github.com/users/republicprotocol/following{/other_user}","gists_url":"https://api.github.com/users/republicprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/republicprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/republicprotocol/subscriptions","organizations_url":"https://api.github.com/users/republicprotocol/orgs","repos_url":"https://api.github.com/users/republicprotocol/repos","events_url":"https://api.github.com/users/republicprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/republicprotocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/republicprotocol/republic-go","description":"An official reference implementation of Republic Protocol, written in Go","fork":false,"url":"https://api.github.com/repos/republicprotocol/republic-go","forks_url":"https://api.github.com/repos/republicprotocol/republic-go/forks","keys_url":"https://api.github.com/repos/republicprotocol/republic-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/republicprotocol/republic-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/republicprotocol/republic-go/teams","hooks_url":"https://api.github.com/repos/republicprotocol/republic-go/hooks","issue_events_url":"https://api.github.com/repos/republicprotocol/republic-go/issues/events{/number}","events_url":"https://api.github.com/repos/republicprotocol/republic-go/events","assignees_url":"https://api.github.com/repos/republicprotocol/republic-go/assignees{/user}","branches_url":"https://api.github.com/repos/republicprotocol/republic-go/branches{/branch}","tags_url":"https://api.github.com/repos/republicprotocol/republic-go/tags","blobs_url":"https://api.github.com/repos/republicprotocol/republic-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/republicprotocol/republic-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/republicprotocol/republic-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/republicprotocol/republic-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/republicprotocol/republic-go/statuses/{sha}","languages_url":"https://api.github.com/repos/republicprotocol/republic-go/languages","stargazers_url":"https://api.github.com/repos/republicprotocol/republic-go/stargazers","contributors_url":"https://api.github.com/repos/republicprotocol/republic-go/contributors","subscribers_url":"https://api.github.com/repos/republicprotocol/republic-go/subscribers","subscription_url":"https://api.github.com/repos/republicprotocol/republic-go/subscription","commits_url":"https://api.github.com/repos/republicprotocol/republic-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/republicprotocol/republic-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/republicprotocol/republic-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/republicprotocol/republic-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/republicprotocol/republic-go/contents/{+path}","compare_url":"https://api.github.com/repos/republicprotocol/republic-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/republicprotocol/republic-go/merges","archive_url":"https://api.github.com/repos/republicprotocol/republic-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/republicprotocol/republic-go/downloads","issues_url":"https://api.github.com/repos/republicprotocol/republic-go/issues{/number}","pulls_url":"https://api.github.com/repos/republicprotocol/republic-go/pulls{/number}","milestones_url":"https://api.github.com/repos/republicprotocol/republic-go/milestones{/number}","notifications_url":"https://api.github.com/repos/republicprotocol/republic-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/republicprotocol/republic-go/labels{/name}","releases_url":"https://api.github.com/repos/republicprotocol/republic-go/releases{/id}","deployments_url":"https://api.github.com/repos/republicprotocol/republic-go/deployments","created_at":"2018-02-28T22:56:31Z","updated_at":"2018-05-07T02:52:05Z","pushed_at":"2018-05-07T06:25:06Z","git_url":"git://github.com/republicprotocol/republic-go.git","ssh_url":"git@github.com:republicprotocol/republic-go.git","clone_url":"https://github.com/republicprotocol/republic-go.git","svn_url":"https://github.com/republicprotocol/republic-go","homepage":"https://republicprotocol.com","size":82449,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":0,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/republicprotocol/republic-go/pulls/35"},"html":{"href":"https://github.com/republicprotocol/republic-go/pull/35"},"issue":{"href":"https://api.github.com/repos/republicprotocol/republic-go/issues/35"},"comments":{"href":"https://api.github.com/repos/republicprotocol/republic-go/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/republicprotocol/republic-go/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/republicprotocol/republic-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/republicprotocol/republic-go/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/republicprotocol/republic-go/statuses/5310c10e702d2a9a779ded5e38db1f55328125a6"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"loongy","id":6580801,"avatar_url":"https://avatars3.githubusercontent.com/u/6580801?v=4","gravatar_id":"","url":"https://api.github.com/users/loongy","html_url":"https://github.com/loongy","followers_url":"https://api.github.com/users/loongy/followers","following_url":"https://api.github.com/users/loongy/following{/other_user}","gists_url":"https://api.github.com/users/loongy/gists{/gist_id}","starred_url":"https://api.github.com/users/loongy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loongy/subscriptions","organizations_url":"https://api.github.com/users/loongy/orgs","repos_url":"https://api.github.com/users/loongy/repos","events_url":"https://api.github.com/users/loongy/events{/privacy}","received_events_url":"https://api.github.com/users/loongy/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"maintainer_can_modify":false,"commits":27,"additions":752,"deletions":19,"changed_files":16}}
{"actor":{"display_login":"loongy"}}