{"action":"created","issue":{"url":"https://api.github.com/repos/RubyMoney/money/issues/774","repository_url":"https://api.github.com/repos/RubyMoney/money","labels_url":"https://api.github.com/repos/RubyMoney/money/issues/774/labels{/name}","comments_url":"https://api.github.com/repos/RubyMoney/money/issues/774/comments","events_url":"https://api.github.com/repos/RubyMoney/money/issues/774/events","html_url":"https://github.com/RubyMoney/money/pull/774","id":325653046,"number":774,"title":"Respect symbol_first i18n setting when formatting amount","user":{"login":"xijo","id":104711,"avatar_url":"https://avatars0.githubusercontent.com/u/104711?v=4","gravatar_id":"","url":"https://api.github.com/users/xijo","html_url":"https://github.com/xijo","followers_url":"https://api.github.com/users/xijo/followers","following_url":"https://api.github.com/users/xijo/following{/other_user}","gists_url":"https://api.github.com/users/xijo/gists{/gist_id}","starred_url":"https://api.github.com/users/xijo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xijo/subscriptions","organizations_url":"https://api.github.com/users/xijo/orgs","repos_url":"https://api.github.com/users/xijo/repos","events_url":"https://api.github.com/users/xijo/events{/privacy}","received_events_url":"https://api.github.com/users/xijo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-23T10:55:21Z","updated_at":"2018-05-24T07:50:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/RubyMoney/money/pulls/774","html_url":"https://github.com/RubyMoney/money/pull/774","diff_url":"https://github.com/RubyMoney/money/pull/774.diff","patch_url":"https://github.com/RubyMoney/money/pull/774.patch"},"body":"Previously only the separators were localized, but the symbol position\r\nremained unchanged and based on the currency.\r\nIn most cases, when you localize an amount, the currency setting is less\r\nimportant than the user preference (i.e. through locale).\r\n\r\nAlthough this is not a rails default currency i18n setting, it would be\r\nvery helpful if it was respected correctly.\r\n\r\nThe fallback remains to the currency setting, so this change is\r\nbackwards compatible unless the \"number.format.currency.symbol_first\"\r\nkey is set.\r\n\r\nspec is included, tests are green."},"comment":{"url":"https://api.github.com/repos/RubyMoney/money/issues/comments/391622544","html_url":"https://github.com/RubyMoney/money/pull/774#issuecomment-391622544","issue_url":"https://api.github.com/repos/RubyMoney/money/issues/774","id":391622544,"user":{"login":"antstorm","id":118353,"avatar_url":"https://avatars1.githubusercontent.com/u/118353?v=4","gravatar_id":"","url":"https://api.github.com/users/antstorm","html_url":"https://github.com/antstorm","followers_url":"https://api.github.com/users/antstorm/followers","following_url":"https://api.github.com/users/antstorm/following{/other_user}","gists_url":"https://api.github.com/users/antstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/antstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antstorm/subscriptions","organizations_url":"https://api.github.com/users/antstorm/orgs","repos_url":"https://api.github.com/users/antstorm/repos","events_url":"https://api.github.com/users/antstorm/events{/privacy}","received_events_url":"https://api.github.com/users/antstorm/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T07:50:54Z","updated_at":"2018-05-24T07:50:54Z","author_association":"CONTRIBUTOR","body":"@xijo I really like this change, however it seems that i18n doesn't use `symbol_first` by default. Instead it uses `format` to specify a couple of things — symbol/number order, spacing and any potential extra text surrounding it (like html tags, for example).\r\n\r\nSince the intention is to move to all localisation to i18n (since localising per currency doesn't make much sense), it might be worth jumping straight to supporting `format` and avoiding this intermediary step. What do you think?"}}
{"actor":{"display_login":"antstorm"}}