{"action":"created","issue":{"url":"https://api.github.com/repos/shuup/shuup/issues/1193","repository_url":"https://api.github.com/repos/shuup/shuup","labels_url":"https://api.github.com/repos/shuup/shuup/issues/1193/labels{/name}","comments_url":"https://api.github.com/repos/shuup/shuup/issues/1193/comments","events_url":"https://api.github.com/repos/shuup/shuup/issues/1193/events","html_url":"https://github.com/shuup/shuup/pull/1193","id":296030717,"number":1193,"title":"DefaultTax: filter tax rules correctly","user":{"login":"chessbr","id":8770370,"avatar_url":"https://avatars3.githubusercontent.com/u/8770370?v=4","gravatar_id":"","url":"https://api.github.com/users/chessbr","html_url":"https://github.com/chessbr","followers_url":"https://api.github.com/users/chessbr/followers","following_url":"https://api.github.com/users/chessbr/following{/other_user}","gists_url":"https://api.github.com/users/chessbr/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbr/subscriptions","organizations_url":"https://api.github.com/users/chessbr/orgs","repos_url":"https://api.github.com/users/chessbr/repos","events_url":"https://api.github.com/users/chessbr/events{/privacy}","received_events_url":"https://api.github.com/users/chessbr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-09T22:22:46Z","updated_at":"2018-02-09T22:53:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/shuup/shuup/pulls/1193","html_url":"https://github.com/shuup/shuup/pull/1193","diff_url":"https://github.com/shuup/shuup/pull/1193.diff","patch_url":"https://github.com/shuup/shuup/pull/1193.patch"},"body":"When tax rule has a specific customer tax group, do not allow contexts with no customer tax groups to match.\r\n\r\nIn some situations where a tax is only applied to a specific customer group, it is more than necessary to avoid taxing customers that do not belong to that group or which don't even have a group configured.\r\n\r\nSo, in cases where we have taxes for companies like B2B and also sell to a regular customer with different prices and also allow anonymous ordering, we don't want to tax the anonymous user the same way we tax companies.\r\n\r\nTo create a tax rule that applies to any customer group, creating a simple rule with no customer tax group will work as expected.\r\n\r\nNo refs"},"comment":{"url":"https://api.github.com/repos/shuup/shuup/issues/comments/364592747","html_url":"https://github.com/shuup/shuup/pull/1193#issuecomment-364592747","issue_url":"https://api.github.com/repos/shuup/shuup/issues/1193","id":364592747,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T22:53:07Z","updated_at":"2018-02-09T22:53:07Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/shuup/shuup/pull/1193?src=pr&el=h1) Report\n> Merging [#1193](https://codecov.io/gh/shuup/shuup/pull/1193?src=pr&el=desc) into [master](https://codecov.io/gh/shuup/shuup/commit/aff08c874d75953125ee2b1dea070cd5e21f0e71?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/shuup/shuup/pull/1193/graphs/tree.svg?width=650&height=150&src=pr&token=gtV7dI0HlB)](https://codecov.io/gh/shuup/shuup/pull/1193?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1193      +/-   ##\n==========================================\n+ Coverage   84.84%   84.84%   +<.01%     \n==========================================\n  Files         733      733              \n  Lines       32768    32769       +1     \n  Branches     4168     4168              \n==========================================\n+ Hits        27802    27804       +2     \n+ Misses       4000     3999       -1     \n  Partials      966      966\n```\n\n\n| [Impacted Files](https://codecov.io/gh/shuup/shuup/pull/1193?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [shuup/default\\_tax/module.py](https://codecov.io/gh/shuup/shuup/pull/1193/diff?src=pr&el=tree#diff-c2h1dXAvZGVmYXVsdF90YXgvbW9kdWxlLnB5) | `100% <100%> (ø)` | :arrow_up: |\n| [shuup/default\\_tax/models.py](https://codecov.io/gh/shuup/shuup/pull/1193/diff?src=pr&el=tree#diff-c2h1dXAvZGVmYXVsdF90YXgvbW9kZWxzLnB5) | `94.11% <0%> (+1.96%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/shuup/shuup/pull/1193?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/shuup/shuup/pull/1193?src=pr&el=footer). Last update [aff08c8...0cc8075](https://codecov.io/gh/shuup/shuup/pull/1193?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}