{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments/211990663","pull_request_review_id":148527224,"id":211990663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTk5MDY2Mw==","diff_hunk":"@@ -741,3 +742,58 @@ type CombinedCluster struct {\n \tClusterStatus         *capiv1.ClusterStatus\n \tClusterProviderStatus *ClusterProviderStatus\n }\n+\n+// +genclient\n+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n+\n+// DNSZone represents a Domain Name Service Zone to manage\n+type DNSZone struct {\n+\t// +optional\n+\tmetav1.TypeMeta `json:\",inline\"`\n+\t// +optional\n+\tmetav1.ObjectMeta `json:\"metadata,omitempty\"`\n+\n+\t// +optional\n+\tSpec DNSZoneSpec `json:\"spec,omitempty\"`\n+\t// +optional\n+\tStatus DNSZoneStatus `json:\"status,omitempty\"`\n+}\n+\n+// DNSZoneSpec is a specification of a Domain Name Service Zone. The specification will\n+// be specific to each cloud provider.\n+type DNSZoneSpec struct {\n+\t// Zone is the DNS zone to host\n+\tDNSZone string `json:\"dnszone\"`","path":"pkg/apis/clusteroperator/v1alpha1/types.go","position":33,"original_position":33,"commit_id":"ce5a4a70963f191a7031891772e34412539d2493","original_commit_id":"0c660eaa06f436c5997c6f393340e90371d134f0","user":{"login":"twiest","id":732867,"node_id":"MDQ6VXNlcjczMjg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/732867?v=4","gravatar_id":"","url":"https://api.github.com/users/twiest","html_url":"https://github.com/twiest","followers_url":"https://api.github.com/users/twiest/followers","following_url":"https://api.github.com/users/twiest/following{/other_user}","gists_url":"https://api.github.com/users/twiest/gists{/gist_id}","starred_url":"https://api.github.com/users/twiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twiest/subscriptions","organizations_url":"https://api.github.com/users/twiest/orgs","repos_url":"https://api.github.com/users/twiest/repos","events_url":"https://api.github.com/users/twiest/events{/privacy}","received_events_url":"https://api.github.com/users/twiest/received_events","type":"User","site_admin":false},"body":"That is very funny, I hadn't thought of the inception there.\r\n\r\nIt's a string, so the code isn't in an object reference cycle or anything, but conceptually I can see how this would be confusing.\r\n\r\nThis field needs to exist here as it's the actual \"something.example.com\" zone that needs to be created. Some places have called it \"Name\" but I think that's a little confusing since the object metadata also has \"Name\".\r\n\r\nI could rename it to just \"zone\". Would that suffice do you think?","created_at":"2018-08-22T15:04:22Z","updated_at":"2018-08-22T15:04:23Z","html_url":"https://github.com/openshift/cluster-operator/pull/325#discussion_r211990663","pull_request_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/325","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments/211990663"},"html":{"href":"https://github.com/openshift/cluster-operator/pull/325#discussion_r211990663"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/325"}},"in_reply_to_id":211581760},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-operator/pulls/325","id":209613402,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjEzNDAy","html_url":"https://github.com/openshift/cluster-operator/pull/325","diff_url":"https://github.com/openshift/cluster-operator/pull/325.diff","patch_url":"https://github.com/openshift/cluster-operator/pull/325.patch","issue_url":"https://api.github.com/repos/openshift/cluster-operator/issues/325","number":325,"state":"open","locked":false,"title":"Add route53 hosted zone controller.","user":{"login":"twiest","id":732867,"node_id":"MDQ6VXNlcjczMjg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/732867?v=4","gravatar_id":"","url":"https://api.github.com/users/twiest","html_url":"https://github.com/twiest","followers_url":"https://api.github.com/users/twiest/followers","following_url":"https://api.github.com/users/twiest/following{/other_user}","gists_url":"https://api.github.com/users/twiest/gists{/gist_id}","starred_url":"https://api.github.com/users/twiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twiest/subscriptions","organizations_url":"https://api.github.com/users/twiest/orgs","repos_url":"https://api.github.com/users/twiest/repos","events_url":"https://api.github.com/users/twiest/events{/privacy}","received_events_url":"https://api.github.com/users/twiest/received_events","type":"User","site_admin":false},"body":"- [x] Add route53 hosted zone controller.\r\n- [x] Add unit tests for route53 hosted zone controller\r\n- [x] Add aggregated API for DNSZone object\r\n- [x] Verify that controller correctly creates route53 hosted zones given a DNSZone object","created_at":"2018-08-20T19:02:38Z","updated_at":"2018-08-22T15:04:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c80b7ade121b7a13bcbdac80add6b89cd9be417f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":770478179,"node_id":"MDU6TGFiZWw3NzA0NzgxNzk=","url":"https://api.github.com/repos/openshift/cluster-operator/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/325/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/325/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-operator/issues/325/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-operator/statuses/ce5a4a70963f191a7031891772e34412539d2493","head":{"label":"twiest:hostedzone-controller","ref":"hostedzone-controller","sha":"ce5a4a70963f191a7031891772e34412539d2493","user":{"login":"twiest","id":732867,"node_id":"MDQ6VXNlcjczMjg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/732867?v=4","gravatar_id":"","url":"https://api.github.com/users/twiest","html_url":"https://github.com/twiest","followers_url":"https://api.github.com/users/twiest/followers","following_url":"https://api.github.com/users/twiest/following{/other_user}","gists_url":"https://api.github.com/users/twiest/gists{/gist_id}","starred_url":"https://api.github.com/users/twiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twiest/subscriptions","organizations_url":"https://api.github.com/users/twiest/orgs","repos_url":"https://api.github.com/users/twiest/repos","events_url":"https://api.github.com/users/twiest/events{/privacy}","received_events_url":"https://api.github.com/users/twiest/received_events","type":"User","site_admin":false},"repo":{"id":113199255,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxOTkyNTU=","name":"cluster-operator","full_name":"twiest/cluster-operator","owner":{"login":"twiest","id":732867,"node_id":"MDQ6VXNlcjczMjg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/732867?v=4","gravatar_id":"","url":"https://api.github.com/users/twiest","html_url":"https://github.com/twiest","followers_url":"https://api.github.com/users/twiest/followers","following_url":"https://api.github.com/users/twiest/following{/other_user}","gists_url":"https://api.github.com/users/twiest/gists{/gist_id}","starred_url":"https://api.github.com/users/twiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twiest/subscriptions","organizations_url":"https://api.github.com/users/twiest/orgs","repos_url":"https://api.github.com/users/twiest/repos","events_url":"https://api.github.com/users/twiest/events{/privacy}","received_events_url":"https://api.github.com/users/twiest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twiest/cluster-operator","description":null,"fork":true,"url":"https://api.github.com/repos/twiest/cluster-operator","forks_url":"https://api.github.com/repos/twiest/cluster-operator/forks","keys_url":"https://api.github.com/repos/twiest/cluster-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twiest/cluster-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twiest/cluster-operator/teams","hooks_url":"https://api.github.com/repos/twiest/cluster-operator/hooks","issue_events_url":"https://api.github.com/repos/twiest/cluster-operator/issues/events{/number}","events_url":"https://api.github.com/repos/twiest/cluster-operator/events","assignees_url":"https://api.github.com/repos/twiest/cluster-operator/assignees{/user}","branches_url":"https://api.github.com/repos/twiest/cluster-operator/branches{/branch}","tags_url":"https://api.github.com/repos/twiest/cluster-operator/tags","blobs_url":"https://api.github.com/repos/twiest/cluster-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twiest/cluster-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twiest/cluster-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/twiest/cluster-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twiest/cluster-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/twiest/cluster-operator/languages","stargazers_url":"https://api.github.com/repos/twiest/cluster-operator/stargazers","contributors_url":"https://api.github.com/repos/twiest/cluster-operator/contributors","subscribers_url":"https://api.github.com/repos/twiest/cluster-operator/subscribers","subscription_url":"https://api.github.com/repos/twiest/cluster-operator/subscription","commits_url":"https://api.github.com/repos/twiest/cluster-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/twiest/cluster-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/twiest/cluster-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/twiest/cluster-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/twiest/cluster-operator/contents/{+path}","compare_url":"https://api.github.com/repos/twiest/cluster-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twiest/cluster-operator/merges","archive_url":"https://api.github.com/repos/twiest/cluster-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twiest/cluster-operator/downloads","issues_url":"https://api.github.com/repos/twiest/cluster-operator/issues{/number}","pulls_url":"https://api.github.com/repos/twiest/cluster-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/twiest/cluster-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/twiest/cluster-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twiest/cluster-operator/labels{/name}","releases_url":"https://api.github.com/repos/twiest/cluster-operator/releases{/id}","deployments_url":"https://api.github.com/repos/twiest/cluster-operator/deployments","created_at":"2017-12-05T15:27:43Z","updated_at":"2018-08-22T14:40:21Z","pushed_at":"2018-08-22T14:48:11Z","git_url":"git://github.com/twiest/cluster-operator.git","ssh_url":"git@github.com:twiest/cluster-operator.git","clone_url":"https://github.com/twiest/cluster-operator.git","svn_url":"https://github.com/twiest/cluster-operator","homepage":null,"size":91820,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"eeafb42675a2899c8907f95a2721527e307db1c1","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":113197161,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxOTcxNjE=","name":"cluster-operator","full_name":"openshift/cluster-operator","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/cluster-operator","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/cluster-operator","forks_url":"https://api.github.com/repos/openshift/cluster-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-operator/deployments","created_at":"2017-12-05T15:09:17Z","updated_at":"2018-08-21T19:46:00Z","pushed_at":"2018-08-22T14:48:13Z","git_url":"git://github.com/openshift/cluster-operator.git","ssh_url":"git@github.com:openshift/cluster-operator.git","clone_url":"https://github.com/openshift/cluster-operator.git","svn_url":"https://github.com/openshift/cluster-operator","homepage":null,"size":91794,"stargazers_count":32,"watchers_count":32,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":24,"open_issues":18,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/325"},"html":{"href":"https://github.com/openshift/cluster-operator/pull/325"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-operator/issues/325"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-operator/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-operator/statuses/ce5a4a70963f191a7031891772e34412539d2493"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"twiest"}}