{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/167356454","pull_request_review_id":95575331,"id":167356454,"diff_hunk":"@@ -65,3 +66,35 @@ String.prototype.fileToCommandArgument = function (this: string): string {\n     }\n     return this.toCommandArgument().replace(/\\\\/g, '/');\n };\n+\n+// tslint:disable-next-line:interface-name\n+declare interface Promise<T> {\n+    /**\n+     * Explicitly states that promise will run asynchronously.\n+     */\n+    doNotWait(onComplete?: () => void, onError?: (reason?: {}) => void): void;\n+}\n+\n+/**\n+ * Explicitly tells that promise should be run asynchonously.\n+ */\n+Promise.prototype.doNotWait = function <T>(this: Promise<T>, onComplete?: () => void, onError?: (reason?: {}) => void) {\n+    this\n+        .catch(reason => {\n+            if (onError) {\n+                //vscode.window.createOutputChannel(STANDARD_OUTPUT_CHANNEL).appendLine(`Promise exception: ${reason.ToString()}`);\n+                onError(reason);\n+            }\n+        })\n+        .then(() => {\n+            if (onComplete) {\n+                onComplete();\n+            }\n+        })\n+        .catch(() => {\n+            if (onError) {\n+                //vscode.window.createOutputChannel(STANDARD_OUTPUT_CHANNEL).appendLine(`Promise exception: ${reason.ToString()}`);\n+                onError();","path":"src/client/common/extensions.ts","position":null,"original_position":50,"commit_id":"db905888ed54d4d2c7e208990c155d60d7cc61f0","original_commit_id":"812276e6cc4dd8698b197120f6c76c9f6a06fcad","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"Let's make this one into `ignoreErrors`. We can discuss rethrowing separately","created_at":"2018-02-09T21:56:26Z","updated_at":"2018-02-09T21:56:26Z","html_url":"https://github.com/Microsoft/vscode-python/pull/744#discussion_r167356454","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/744","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/167356454"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/744#discussion_r167356454"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/744"}},"in_reply_to_id":167305836},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/744","id":168307052,"html_url":"https://github.com/Microsoft/vscode-python/pull/744","diff_url":"https://github.com/Microsoft/vscode-python/pull/744.diff","patch_url":"https://github.com/Microsoft/vscode-python/pull/744.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/744","number":744,"state":"open","locked":false,"title":"Limit Jedi RAM consumption","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"Fixes #263\r\n\r\nIntroduces setting for the Jedi RAM limit. Default (0) means 1024 MB. Max 8GB.\r\nRAM consumption is checked every 2 seconds and completion.py process is killed if threshold is exceeded. Process is then auto-restarted.","created_at":"2018-02-09T18:10:11Z","updated_at":"2018-02-09T21:56:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd14a12f7a5e1279be03a3a4788193819dd8028c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/744/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/744/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/744/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/db905888ed54d4d2c7e208990c155d60d7cc61f0","head":{"label":"MikhailArkhipov:ram","ref":"ram","sha":"db905888ed54d4d2c7e208990c155d60d7cc61f0","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"repo":{"id":112513491,"name":"vscode-python","full_name":"MikhailArkhipov/vscode-python","owner":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikhailArkhipov/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/MikhailArkhipov/vscode-python","forks_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/forks","keys_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/teams","hooks_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/events","assignees_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/tags","blobs_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/languages","stargazers_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/subscription","commits_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/merges","archive_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/downloads","issues_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/MikhailArkhipov/vscode-python/deployments","created_at":"2017-11-29T18:40:10Z","updated_at":"2017-11-29T18:40:13Z","pushed_at":"2018-02-09T21:55:59Z","git_url":"git://github.com/MikhailArkhipov/vscode-python.git","ssh_url":"git@github.com:MikhailArkhipov/vscode-python.git","clone_url":"https://github.com/MikhailArkhipov/vscode-python.git","svn_url":"https://github.com/MikhailArkhipov/vscode-python","homepage":"","size":55934,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"012985cd8c5a278432e9c859031d3103b1b8f439","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"name":"vscode-python","full_name":"Microsoft/vscode-python","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/Microsoft/vscode-python","forks_url":"https://api.github.com/repos/Microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2018-02-09T20:25:10Z","pushed_at":"2018-02-09T21:56:00Z","git_url":"git://github.com/Microsoft/vscode-python.git","ssh_url":"git@github.com:Microsoft/vscode-python.git","clone_url":"https://github.com/Microsoft/vscode-python.git","svn_url":"https://github.com/Microsoft/vscode-python","homepage":"https://github.com/Microsoft/vscode-python","size":55745,"stargazers_count":353,"watchers_count":353,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":249,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":55,"open_issues":249,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/744"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/744"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/744"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/744/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/744/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/744/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-python/statuses/db905888ed54d4d2c7e208990c155d60d7cc61f0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MikhailArkhipov"}}