{"action":"closed","number":118,"pull_request":{"url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls/118","id":194775283,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Nzc1Mjgz","html_url":"https://github.com/amilajack/eslint-plugin-compat/pull/118","diff_url":"https://github.com/amilajack/eslint-plugin-compat/pull/118.diff","patch_url":"https://github.com/amilajack/eslint-plugin-compat/pull/118.patch","issue_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/issues/118","number":118,"state":"closed","locked":false,"title":"Refactor CanIUseProvider#getUnsupportedTargets()","user":{"login":"kenju","id":4186381,"node_id":"MDQ6VXNlcjQxODYzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4186381?v=4","gravatar_id":"","url":"https://api.github.com/users/kenju","html_url":"https://github.com/kenju","followers_url":"https://api.github.com/users/kenju/followers","following_url":"https://api.github.com/users/kenju/following{/other_user}","gists_url":"https://api.github.com/users/kenju/gists{/gist_id}","starred_url":"https://api.github.com/users/kenju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenju/subscriptions","organizations_url":"https://api.github.com/users/kenju/orgs","repos_url":"https://api.github.com/users/kenju/repos","events_url":"https://api.github.com/users/kenju/events{/privacy}","received_events_url":"https://api.github.com/users/kenju/received_events","type":"User","site_admin":false},"body":"Here is a nits refactor.\r\n\r\nSeparating `CanIUseProvider#getUnsupportedTargets()` because it looks a little bit complicated.\r\nThis method has there 2 logics, so split into different methods as follows:\r\n\r\n- `canIUseSupported()` ... check if canIUse supported\r\n- `getUnsupportedTargets()` (original) ... get stats & map browser identifiers\r\n\r\nplease revieiw 🙏 ","created_at":"2018-06-14T04:23:15Z","updated_at":"2018-06-25T02:56:14Z","closed_at":"2018-06-25T02:56:14Z","merged_at":"2018-06-25T02:56:14Z","merge_commit_sha":"d7f3f4cae8ba82f436533c28d050c4802bf59683","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls/118/commits","review_comments_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls/118/comments","review_comment_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/issues/118/comments","statuses_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/statuses/97dd16c673258b73ef4c1b6f1df8b04502ca3b56","head":{"label":"kenju:refactor-getUnsupportedTargets","ref":"refactor-getUnsupportedTargets","sha":"97dd16c673258b73ef4c1b6f1df8b04502ca3b56","user":{"login":"kenju","id":4186381,"node_id":"MDQ6VXNlcjQxODYzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4186381?v=4","gravatar_id":"","url":"https://api.github.com/users/kenju","html_url":"https://github.com/kenju","followers_url":"https://api.github.com/users/kenju/followers","following_url":"https://api.github.com/users/kenju/following{/other_user}","gists_url":"https://api.github.com/users/kenju/gists{/gist_id}","starred_url":"https://api.github.com/users/kenju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenju/subscriptions","organizations_url":"https://api.github.com/users/kenju/orgs","repos_url":"https://api.github.com/users/kenju/repos","events_url":"https://api.github.com/users/kenju/events{/privacy}","received_events_url":"https://api.github.com/users/kenju/received_events","type":"User","site_admin":false},"repo":{"id":137021763,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwMjE3NjM=","name":"eslint-plugin-compat","full_name":"kenju/eslint-plugin-compat","owner":{"login":"kenju","id":4186381,"node_id":"MDQ6VXNlcjQxODYzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4186381?v=4","gravatar_id":"","url":"https://api.github.com/users/kenju","html_url":"https://github.com/kenju","followers_url":"https://api.github.com/users/kenju/followers","following_url":"https://api.github.com/users/kenju/following{/other_user}","gists_url":"https://api.github.com/users/kenju/gists{/gist_id}","starred_url":"https://api.github.com/users/kenju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenju/subscriptions","organizations_url":"https://api.github.com/users/kenju/orgs","repos_url":"https://api.github.com/users/kenju/repos","events_url":"https://api.github.com/users/kenju/events{/privacy}","received_events_url":"https://api.github.com/users/kenju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenju/eslint-plugin-compat","description":"Lint the browser compatibility of your code","fork":true,"url":"https://api.github.com/repos/kenju/eslint-plugin-compat","forks_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/forks","keys_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/teams","hooks_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/hooks","issue_events_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/issues/events{/number}","events_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/events","assignees_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/assignees{/user}","branches_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/branches{/branch}","tags_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/tags","blobs_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/statuses/{sha}","languages_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/languages","stargazers_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/stargazers","contributors_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/contributors","subscribers_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/subscribers","subscription_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/subscription","commits_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/contents/{+path}","compare_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/merges","archive_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/downloads","issues_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/issues{/number}","pulls_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/pulls{/number}","milestones_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/milestones{/number}","notifications_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/labels{/name}","releases_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/releases{/id}","deployments_url":"https://api.github.com/repos/kenju/eslint-plugin-compat/deployments","created_at":"2018-06-12T05:32:57Z","updated_at":"2018-06-13T13:04:52Z","pushed_at":"2018-06-14T04:21:14Z","git_url":"git://github.com/kenju/eslint-plugin-compat.git","ssh_url":"git@github.com:kenju/eslint-plugin-compat.git","clone_url":"https://github.com/kenju/eslint-plugin-compat.git","svn_url":"https://github.com/kenju/eslint-plugin-compat","homepage":"","size":5122,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amilajack:master","ref":"master","sha":"07d426e40221afd4ffc20e5879669c077a725fa3","user":{"login":"amilajack","id":6374832,"node_id":"MDQ6VXNlcjYzNzQ4MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6374832?v=4","gravatar_id":"","url":"https://api.github.com/users/amilajack","html_url":"https://github.com/amilajack","followers_url":"https://api.github.com/users/amilajack/followers","following_url":"https://api.github.com/users/amilajack/following{/other_user}","gists_url":"https://api.github.com/users/amilajack/gists{/gist_id}","starred_url":"https://api.github.com/users/amilajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amilajack/subscriptions","organizations_url":"https://api.github.com/users/amilajack/orgs","repos_url":"https://api.github.com/users/amilajack/repos","events_url":"https://api.github.com/users/amilajack/events{/privacy}","received_events_url":"https://api.github.com/users/amilajack/received_events","type":"User","site_admin":false},"repo":{"id":69679985,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY3OTk4NQ==","name":"eslint-plugin-compat","full_name":"amilajack/eslint-plugin-compat","owner":{"login":"amilajack","id":6374832,"node_id":"MDQ6VXNlcjYzNzQ4MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6374832?v=4","gravatar_id":"","url":"https://api.github.com/users/amilajack","html_url":"https://github.com/amilajack","followers_url":"https://api.github.com/users/amilajack/followers","following_url":"https://api.github.com/users/amilajack/following{/other_user}","gists_url":"https://api.github.com/users/amilajack/gists{/gist_id}","starred_url":"https://api.github.com/users/amilajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amilajack/subscriptions","organizations_url":"https://api.github.com/users/amilajack/orgs","repos_url":"https://api.github.com/users/amilajack/repos","events_url":"https://api.github.com/users/amilajack/events{/privacy}","received_events_url":"https://api.github.com/users/amilajack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amilajack/eslint-plugin-compat","description":"Lint the browser compatibility of your code","fork":false,"url":"https://api.github.com/repos/amilajack/eslint-plugin-compat","forks_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/forks","keys_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/teams","hooks_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/hooks","issue_events_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/issues/events{/number}","events_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/events","assignees_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/assignees{/user}","branches_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/branches{/branch}","tags_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/tags","blobs_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/git/refs{/sha}","trees_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/statuses/{sha}","languages_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/languages","stargazers_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/stargazers","contributors_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/contributors","subscribers_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/subscribers","subscription_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/subscription","commits_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/commits{/sha}","git_commits_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/git/commits{/sha}","comments_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/comments{/number}","issue_comment_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/issues/comments{/number}","contents_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/contents/{+path}","compare_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/merges","archive_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/downloads","issues_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/issues{/number}","pulls_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls{/number}","milestones_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/milestones{/number}","notifications_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/labels{/name}","releases_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/releases{/id}","deployments_url":"https://api.github.com/repos/amilajack/eslint-plugin-compat/deployments","created_at":"2016-09-30T15:47:58Z","updated_at":"2018-06-24T21:53:27Z","pushed_at":"2018-06-25T02:56:14Z","git_url":"git://github.com/amilajack/eslint-plugin-compat.git","ssh_url":"git@github.com:amilajack/eslint-plugin-compat.git","clone_url":"https://github.com/amilajack/eslint-plugin-compat.git","svn_url":"https://github.com/amilajack/eslint-plugin-compat","homepage":"","size":5116,"stargazers_count":1920,"watchers_count":1920,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":63,"open_issues":21,"watchers":1920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls/118"},"html":{"href":"https://github.com/amilajack/eslint-plugin-compat/pull/118"},"issue":{"href":"https://api.github.com/repos/amilajack/eslint-plugin-compat/issues/118"},"comments":{"href":"https://api.github.com/repos/amilajack/eslint-plugin-compat/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amilajack/eslint-plugin-compat/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/amilajack/eslint-plugin-compat/statuses/97dd16c673258b73ef4c1b6f1df8b04502ca3b56"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"amilajack","id":6374832,"node_id":"MDQ6VXNlcjYzNzQ4MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6374832?v=4","gravatar_id":"","url":"https://api.github.com/users/amilajack","html_url":"https://github.com/amilajack","followers_url":"https://api.github.com/users/amilajack/followers","following_url":"https://api.github.com/users/amilajack/following{/other_user}","gists_url":"https://api.github.com/users/amilajack/gists{/gist_id}","starred_url":"https://api.github.com/users/amilajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amilajack/subscriptions","organizations_url":"https://api.github.com/users/amilajack/orgs","repos_url":"https://api.github.com/users/amilajack/repos","events_url":"https://api.github.com/users/amilajack/events{/privacy}","received_events_url":"https://api.github.com/users/amilajack/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":27,"changed_files":1}}
{"actor":{"display_login":"amilajack"}}