{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-xray-sdk-node/issues/48","repository_url":"https://api.github.com/repos/aws/aws-xray-sdk-node","labels_url":"https://api.github.com/repos/aws/aws-xray-sdk-node/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-xray-sdk-node/issues/48/comments","events_url":"https://api.github.com/repos/aws/aws-xray-sdk-node/issues/48/events","html_url":"https://github.com/aws/aws-xray-sdk-node/issues/48","id":343929240,"node_id":"MDU6SXNzdWUzNDM5MjkyNDA=","number":48,"title":"Incompatible with Winston v3.0","user":{"login":"IllegalCactus","id":2632211,"node_id":"MDQ6VXNlcjI2MzIyMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2632211?v=4","gravatar_id":"","url":"https://api.github.com/users/IllegalCactus","html_url":"https://github.com/IllegalCactus","followers_url":"https://api.github.com/users/IllegalCactus/followers","following_url":"https://api.github.com/users/IllegalCactus/following{/other_user}","gists_url":"https://api.github.com/users/IllegalCactus/gists{/gist_id}","starred_url":"https://api.github.com/users/IllegalCactus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IllegalCactus/subscriptions","organizations_url":"https://api.github.com/users/IllegalCactus/orgs","repos_url":"https://api.github.com/users/IllegalCactus/repos","events_url":"https://api.github.com/users/IllegalCactus/events{/privacy}","received_events_url":"https://api.github.com/users/IllegalCactus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-24T08:09:44Z","updated_at":"2018-07-25T07:41:56Z","closed_at":"2018-07-25T07:41:56Z","author_association":"NONE","body":"Using the SDK with Winston v.3.0.0 produces the following error:\r\n\r\n```\r\nnode_modules/aws-xray-sdk-core/lib/logger.js:17\r\n    logger = new (winston.Logger)({});\r\n\r\nTypeError: winston.Logger is not a constructor\r\n```\r\n\r\nWinston had a breaking change in 3.0 which changes how the logger should be constructed:\r\n\r\nhttps://github.com/winstonjs/winston#creating-your-own-logger\r\n\r\nhttps://github.com/winstonjs/winston/commit/eff6f00588ea6e7fcfc0a33bcf049ad85c76b6d9#diff-fc1a687308b45c41cf7efa7aff4253dd\r\n\r\nNot sure if updating the Winston version in this project is an option?"},"comment":{"url":"https://api.github.com/repos/aws/aws-xray-sdk-node/issues/comments/407664241","html_url":"https://github.com/aws/aws-xray-sdk-node/issues/48#issuecomment-407664241","issue_url":"https://api.github.com/repos/aws/aws-xray-sdk-node/issues/48","id":407664241,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzY2NDI0MQ==","user":{"login":"IllegalCactus","id":2632211,"node_id":"MDQ6VXNlcjI2MzIyMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2632211?v=4","gravatar_id":"","url":"https://api.github.com/users/IllegalCactus","html_url":"https://github.com/IllegalCactus","followers_url":"https://api.github.com/users/IllegalCactus/followers","following_url":"https://api.github.com/users/IllegalCactus/following{/other_user}","gists_url":"https://api.github.com/users/IllegalCactus/gists{/gist_id}","starred_url":"https://api.github.com/users/IllegalCactus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IllegalCactus/subscriptions","organizations_url":"https://api.github.com/users/IllegalCactus/orgs","repos_url":"https://api.github.com/users/IllegalCactus/repos","events_url":"https://api.github.com/users/IllegalCactus/events{/privacy}","received_events_url":"https://api.github.com/users/IllegalCactus/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T07:41:56Z","updated_at":"2018-07-25T07:41:56Z","author_association":"NONE","body":"Ah I didn't see that issue, thanks. In that case, I'm happy to close this as I don't have an urgent need to use 3.0 in the meantime. I just spotted this error while upgrading some dependencies in a project but in my case I can stick with 2.x too.\r\n\r\n\r\n"}}
{"actor":{"display_login":"IllegalCactus"}}