{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/170418788","pull_request_review_id":99110048,"id":170418788,"diff_hunk":"@@ -0,0 +1,46 @@\n+# Ark-server\n+\n+This helm chart install ark-server version v0.7.1\n+\n+## Premise\n+Helm cannot handle properly CRD becauses it has a validation mechanism that checks the installation before the CRD are actually created,\n+hence each resource that uses a CRD cannot be validated because the CRD doesn't exist yet!\n+\n+The trick here is to create CRD via helm chart, and only after (using a `post-install`) to install the resources with a container.\n+The container has the only job to execute a `kubectl create -f filename` and create the resources.\n+\n+At the same time the resources created with the hook are completely transparent to Helm, that is, when you delete the\n+chart those resources remain there. Hence we need a sencond hook for deleting them (see delete.yaml)\n+\n+## Content\n+- `templates/prerequisites.yaml` this file contains the CRD and SA needed by Ark Server\n+- `hook.yaml` This is the container that will deploy or delete ark-server and its configuration\n+   it creates also the necessary SA and RBAC\n+- `configmap.yaml` Configmap will be mounted to the hook container as a file and subsequently used as k8s manifest for deploy or deletion\n+\n+## ConfigMap customization\n+Since we want to have a customizable chart it's important that the configmap is a template and not a static file.","path":"incubator/ark-server/README.md","position":22,"original_position":22,"commit_id":"8c74bc3967f735faba8242651598f8f1ad789a8d","original_commit_id":"8c74bc3967f735faba8242651598f8f1ad789a8d","user":{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"body":"Then why don't you put it into the templates folder directly?","created_at":"2018-02-24T11:12:17Z","updated_at":"2018-02-24T11:26:07Z","html_url":"https://github.com/kubernetes/charts/pull/3795#discussion_r170418788","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/3795","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/170418788"},"html":{"href":"https://github.com/kubernetes/charts/pull/3795#discussion_r170418788"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/3795"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/3795","id":170438926,"html_url":"https://github.com/kubernetes/charts/pull/3795","diff_url":"https://github.com/kubernetes/charts/pull/3795.diff","patch_url":"https://github.com/kubernetes/charts/pull/3795.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/3795","number":3795,"state":"open","locked":false,"title":"Adds helm chart for heptio/ark","user":{"login":"domcar","id":19223900,"avatar_url":"https://avatars1.githubusercontent.com/u/19223900?v=4","gravatar_id":"","url":"https://api.github.com/users/domcar","html_url":"https://github.com/domcar","followers_url":"https://api.github.com/users/domcar/followers","following_url":"https://api.github.com/users/domcar/following{/other_user}","gists_url":"https://api.github.com/users/domcar/gists{/gist_id}","starred_url":"https://api.github.com/users/domcar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcar/subscriptions","organizations_url":"https://api.github.com/users/domcar/orgs","repos_url":"https://api.github.com/users/domcar/repos","events_url":"https://api.github.com/users/domcar/events{/privacy}","received_events_url":"https://api.github.com/users/domcar/received_events","type":"User","site_admin":false},"body":"## Premise\r\nHelm cannot handle properly CRD becauses it has a validation mechanism that checks the installation before the CRD are actually created,\r\nhence each resource that uses a CRD cannot be validated because the CRD doesn't exist yet!\r\n\r\n## Solution\r\nThe solution here is to create CRD via helm chart, and only after (using a `post-install`) to install the resources with a container.\r\nThe container has the only job to execute a `kubectl create -f filename` and create the resources.\r\n\r\nAt the same time the resources created with the hook are completely transparent to Helm, that is, when you delete the\r\nchart those resources remain there. Hence we need a second hook for deleting them\r\n\r\n","created_at":"2018-02-21T11:10:22Z","updated_at":"2018-02-24T11:26:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35da3c091d50ce8d8abe1b2eb3e99b5a81a16f73","assignee":{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"assignees":[{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":582594847,"url":"https://api.github.com/repos/kubernetes/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":678010043,"url":"https://api.github.com/repos/kubernetes/charts/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/3795/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/3795/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/3795/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/8c74bc3967f735faba8242651598f8f1ad789a8d","head":{"label":"domcar:master","ref":"master","sha":"8c74bc3967f735faba8242651598f8f1ad789a8d","user":{"login":"domcar","id":19223900,"avatar_url":"https://avatars1.githubusercontent.com/u/19223900?v=4","gravatar_id":"","url":"https://api.github.com/users/domcar","html_url":"https://github.com/domcar","followers_url":"https://api.github.com/users/domcar/followers","following_url":"https://api.github.com/users/domcar/following{/other_user}","gists_url":"https://api.github.com/users/domcar/gists{/gist_id}","starred_url":"https://api.github.com/users/domcar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcar/subscriptions","organizations_url":"https://api.github.com/users/domcar/orgs","repos_url":"https://api.github.com/users/domcar/repos","events_url":"https://api.github.com/users/domcar/events{/privacy}","received_events_url":"https://api.github.com/users/domcar/received_events","type":"User","site_admin":false},"repo":{"id":122311622,"name":"charts","full_name":"domcar/charts","owner":{"login":"domcar","id":19223900,"avatar_url":"https://avatars1.githubusercontent.com/u/19223900?v=4","gravatar_id":"","url":"https://api.github.com/users/domcar","html_url":"https://github.com/domcar","followers_url":"https://api.github.com/users/domcar/followers","following_url":"https://api.github.com/users/domcar/following{/other_user}","gists_url":"https://api.github.com/users/domcar/gists{/gist_id}","starred_url":"https://api.github.com/users/domcar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcar/subscriptions","organizations_url":"https://api.github.com/users/domcar/orgs","repos_url":"https://api.github.com/users/domcar/repos","events_url":"https://api.github.com/users/domcar/events{/privacy}","received_events_url":"https://api.github.com/users/domcar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domcar/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/domcar/charts","forks_url":"https://api.github.com/repos/domcar/charts/forks","keys_url":"https://api.github.com/repos/domcar/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domcar/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domcar/charts/teams","hooks_url":"https://api.github.com/repos/domcar/charts/hooks","issue_events_url":"https://api.github.com/repos/domcar/charts/issues/events{/number}","events_url":"https://api.github.com/repos/domcar/charts/events","assignees_url":"https://api.github.com/repos/domcar/charts/assignees{/user}","branches_url":"https://api.github.com/repos/domcar/charts/branches{/branch}","tags_url":"https://api.github.com/repos/domcar/charts/tags","blobs_url":"https://api.github.com/repos/domcar/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domcar/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domcar/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/domcar/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domcar/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/domcar/charts/languages","stargazers_url":"https://api.github.com/repos/domcar/charts/stargazers","contributors_url":"https://api.github.com/repos/domcar/charts/contributors","subscribers_url":"https://api.github.com/repos/domcar/charts/subscribers","subscription_url":"https://api.github.com/repos/domcar/charts/subscription","commits_url":"https://api.github.com/repos/domcar/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/domcar/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/domcar/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/domcar/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/domcar/charts/contents/{+path}","compare_url":"https://api.github.com/repos/domcar/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domcar/charts/merges","archive_url":"https://api.github.com/repos/domcar/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domcar/charts/downloads","issues_url":"https://api.github.com/repos/domcar/charts/issues{/number}","pulls_url":"https://api.github.com/repos/domcar/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/domcar/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/domcar/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domcar/charts/labels{/name}","releases_url":"https://api.github.com/repos/domcar/charts/releases{/id}","deployments_url":"https://api.github.com/repos/domcar/charts/deployments","created_at":"2018-02-21T08:45:13Z","updated_at":"2018-02-21T08:45:17Z","pushed_at":"2018-02-23T13:28:16Z","git_url":"git://github.com/domcar/charts.git","ssh_url":"git@github.com:domcar/charts.git","clone_url":"https://github.com/domcar/charts.git","svn_url":"https://github.com/domcar/charts","homepage":"","size":4155,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ee28a003e6e98161c0fc9e41fdf2f82b746629bb","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-02-24T05:48:21Z","pushed_at":"2018-02-24T10:57:46Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":4222,"stargazers_count":2265,"watchers_count":2265,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1888,"mirror_url":null,"archived":false,"open_issues_count":541,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1888,"open_issues":541,"watchers":2265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/3795"},"html":{"href":"https://github.com/kubernetes/charts/pull/3795"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/3795"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/3795/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/3795/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/3795/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/8c74bc3967f735faba8242651598f8f1ad789a8d"}},"author_association":"NONE"}}
{"actor":{"display_login":"unguiculus"}}