{"action":"created","issue":{"url":"https://api.github.com/repos/Aeval/AncientBot/issues/1","repository_url":"https://api.github.com/repos/Aeval/AncientBot","labels_url":"https://api.github.com/repos/Aeval/AncientBot/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Aeval/AncientBot/issues/1/comments","events_url":"https://api.github.com/repos/Aeval/AncientBot/issues/1/events","html_url":"https://github.com/Aeval/AncientBot/pull/1","id":334197970,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjMzMDI5","number":1,"title":"Adding node_modules to gitignore && Start of Code Review!","user":{"login":"adilanchian","id":13204620,"node_id":"MDQ6VXNlcjEzMjA0NjIw","avatar_url":"https://avatars0.githubusercontent.com/u/13204620?v=4","gravatar_id":"","url":"https://api.github.com/users/adilanchian","html_url":"https://github.com/adilanchian","followers_url":"https://api.github.com/users/adilanchian/followers","following_url":"https://api.github.com/users/adilanchian/following{/other_user}","gists_url":"https://api.github.com/users/adilanchian/gists{/gist_id}","starred_url":"https://api.github.com/users/adilanchian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adilanchian/subscriptions","organizations_url":"https://api.github.com/users/adilanchian/orgs","repos_url":"https://api.github.com/users/adilanchian/repos","events_url":"https://api.github.com/users/adilanchian/events{/privacy}","received_events_url":"https://api.github.com/users/adilanchian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Aeval","id":34603833,"node_id":"MDQ6VXNlcjM0NjAzODMz","avatar_url":"https://avatars3.githubusercontent.com/u/34603833?v=4","gravatar_id":"","url":"https://api.github.com/users/Aeval","html_url":"https://github.com/Aeval","followers_url":"https://api.github.com/users/Aeval/followers","following_url":"https://api.github.com/users/Aeval/following{/other_user}","gists_url":"https://api.github.com/users/Aeval/gists{/gist_id}","starred_url":"https://api.github.com/users/Aeval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aeval/subscriptions","organizations_url":"https://api.github.com/users/Aeval/orgs","repos_url":"https://api.github.com/users/Aeval/repos","events_url":"https://api.github.com/users/Aeval/events{/privacy}","received_events_url":"https://api.github.com/users/Aeval/received_events","type":"User","site_admin":false},"assignees":[{"login":"Aeval","id":34603833,"node_id":"MDQ6VXNlcjM0NjAzODMz","avatar_url":"https://avatars3.githubusercontent.com/u/34603833?v=4","gravatar_id":"","url":"https://api.github.com/users/Aeval","html_url":"https://github.com/Aeval","followers_url":"https://api.github.com/users/Aeval/followers","following_url":"https://api.github.com/users/Aeval/following{/other_user}","gists_url":"https://api.github.com/users/Aeval/gists{/gist_id}","starred_url":"https://api.github.com/users/Aeval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aeval/subscriptions","organizations_url":"https://api.github.com/users/Aeval/orgs","repos_url":"https://api.github.com/users/Aeval/repos","events_url":"https://api.github.com/users/Aeval/events{/privacy}","received_events_url":"https://api.github.com/users/Aeval/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-06-20T18:26:19Z","updated_at":"2018-06-20T21:47:02Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Aeval/AncientBot/pulls/1","html_url":"https://github.com/Aeval/AncientBot/pull/1","diff_url":"https://github.com/Aeval/AncientBot/pull/1.diff","patch_url":"https://github.com/Aeval/AncientBot/pull/1.patch"},"body":"Hi!\r\n\r\nI have made one change and have kicked off the review process :). I will add comments through out your code for things I would suggest to change! Once it is done, it can be approved and merged directly into master!\r\n\r\nLet me know if you have any questions!"},"comment":{"url":"https://api.github.com/repos/Aeval/AncientBot/issues/comments/398908226","html_url":"https://github.com/Aeval/AncientBot/pull/1#issuecomment-398908226","issue_url":"https://api.github.com/repos/Aeval/AncientBot/issues/1","id":398908226,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODkwODIyNg==","user":{"login":"adilanchian","id":13204620,"node_id":"MDQ6VXNlcjEzMjA0NjIw","avatar_url":"https://avatars0.githubusercontent.com/u/13204620?v=4","gravatar_id":"","url":"https://api.github.com/users/adilanchian","html_url":"https://github.com/adilanchian","followers_url":"https://api.github.com/users/adilanchian/followers","following_url":"https://api.github.com/users/adilanchian/following{/other_user}","gists_url":"https://api.github.com/users/adilanchian/gists{/gist_id}","starred_url":"https://api.github.com/users/adilanchian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adilanchian/subscriptions","organizations_url":"https://api.github.com/users/adilanchian/orgs","repos_url":"https://api.github.com/users/adilanchian/repos","events_url":"https://api.github.com/users/adilanchian/events{/privacy}","received_events_url":"https://api.github.com/users/adilanchian/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T21:47:02Z","updated_at":"2018-06-20T21:47:02Z","author_association":"COLLABORATOR","body":"Sweet :) I am glad you feel like you are on the right track.\r\n\r\nSo what I mean about creating a helper method is extracting the logic at a certain point in your code and moving it to a method that could be called with one line. So in the examples I gave you, the simplest form of this is pulling the logic out and creating a method and just call it in the spot where you pulled the logic (all within the same file).\r\n\r\nIf you want to take it even further, you can create a new file that you can require at the top of your index.js file and reference your helper methods throughout! That file can hold any similar logic, but it modularizes it so you can easily figure out where certain pieces of logic are happening. \r\n\r\nIt is better to start on this early on because as your code base gets bigger, the harder it is to refactor haha. I hope this helps! Let me know if you have anymore questions :)"}}
{"actor":{"display_login":"adilanchian"}}