{"action":"created","issue":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/724","repository_url":"https://api.github.com/repos/cosmos/cosmos-sdk","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/724/labels{/name}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/724/comments","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/724/events","html_url":"https://github.com/cosmos/cosmos-sdk/issues/724","id":309182728,"number":724,"title":"Staking keeper defaultParams shouldn't exist","user":{"login":"rigelrozanski","id":20132176,"avatar_url":"https://avatars1.githubusercontent.com/u/20132176?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelrozanski","html_url":"https://github.com/rigelrozanski","followers_url":"https://api.github.com/users/rigelrozanski/followers","following_url":"https://api.github.com/users/rigelrozanski/following{/other_user}","gists_url":"https://api.github.com/users/rigelrozanski/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelrozanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelrozanski/subscriptions","organizations_url":"https://api.github.com/users/rigelrozanski/orgs","repos_url":"https://api.github.com/users/rigelrozanski/repos","events_url":"https://api.github.com/users/rigelrozanski/events{/privacy}","received_events_url":"https://api.github.com/users/rigelrozanski/received_events","type":"User","site_admin":false},"labels":[{"id":851620486,"url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/staking","name":"staking","color":"fce0ab","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-28T00:46:38Z","updated_at":"2018-04-02T22:06:11Z","closed_at":null,"author_association":"MEMBER","body":"We should still define default params for within the tests but the `GetParams` function shouldn't create default params, they should always be loaded from genesis and panic if not provided :)\r\n\r\nSimilarly for the `GetPool` function"},"comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments/378061357","html_url":"https://github.com/cosmos/cosmos-sdk/issues/724#issuecomment-378061357","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/724","id":378061357,"user":{"login":"rigelrozanski","id":20132176,"avatar_url":"https://avatars1.githubusercontent.com/u/20132176?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelrozanski","html_url":"https://github.com/rigelrozanski","followers_url":"https://api.github.com/users/rigelrozanski/followers","following_url":"https://api.github.com/users/rigelrozanski/following{/other_user}","gists_url":"https://api.github.com/users/rigelrozanski/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelrozanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelrozanski/subscriptions","organizations_url":"https://api.github.com/users/rigelrozanski/orgs","repos_url":"https://api.github.com/users/rigelrozanski/repos","events_url":"https://api.github.com/users/rigelrozanski/events{/privacy}","received_events_url":"https://api.github.com/users/rigelrozanski/received_events","type":"User","site_admin":false},"created_at":"2018-04-02T22:06:11Z","updated_at":"2018-04-02T22:06:11Z","author_association":"MEMBER","body":"related but not duplicate - we want an init genesis function for staking AND we want to remove the use of default params within keeper.go GetParams - when we remove the default params we also want to reimplement them in testing"}}
{"actor":{"display_login":"rigelrozanski"}}