{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/zoltar/pulls/comments/245038882","pull_request_review_id":189060129,"id":245038882,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTAzODg4Mg==","diff_hunk":"@@ -52,35 +54,27 @@ public void close() throws Exception {\n   }\n \n   @Test\n-  public void preload() {\n+  public void preload() throws InterruptedException, ExecutionException, TimeoutException {\n     final ModelLoader<DummyModel> loader = ModelLoader\n-        .lift(DummyModel::new)\n-        .with(Preloader.preload());\n-\n-    assertThat(loader.get().toCompletableFuture().isDone(), is(true));\n-  }\n-\n-  @Test\n-  public void preloadTimeout() {\n-    final ModelLoader<DummyModel> loader = ModelLoader\n-        .lift(() -> {\n-          Thread.sleep(Duration.ofSeconds(10).toMillis());\n+        .load(() -> {\n+          Thread.sleep(Duration.ofMillis(500).toMillis());","path":"zoltar-tests/src/test/java/com/spotify/zoltar/ModelLoaderTest.java","position":43,"original_position":43,"commit_id":"9cc5077e7a3923875c33246cf5602755f85ac9fa","original_commit_id":"9cc5077e7a3923875c33246cf5602755f85ac9fa","user":{"login":"brianmartin","id":130559,"node_id":"MDQ6VXNlcjEzMDU1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/130559?v=4","gravatar_id":"","url":"https://api.github.com/users/brianmartin","html_url":"https://github.com/brianmartin","followers_url":"https://api.github.com/users/brianmartin/followers","following_url":"https://api.github.com/users/brianmartin/following{/other_user}","gists_url":"https://api.github.com/users/brianmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmartin/subscriptions","organizations_url":"https://api.github.com/users/brianmartin/orgs","repos_url":"https://api.github.com/users/brianmartin/repos","events_url":"https://api.github.com/users/brianmartin/events{/privacy}","received_events_url":"https://api.github.com/users/brianmartin/received_events","type":"User","site_admin":false},"body":"Any reason this shouldn't be something much smaller? Like `5ms`?","created_at":"2019-01-03T15:40:44Z","updated_at":"2019-01-03T15:47:11Z","html_url":"https://github.com/spotify/zoltar/pull/168#discussion_r245038882","pull_request_url":"https://api.github.com/repos/spotify/zoltar/pulls/168","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spotify/zoltar/pulls/comments/245038882"},"html":{"href":"https://github.com/spotify/zoltar/pull/168#discussion_r245038882"},"pull_request":{"href":"https://api.github.com/repos/spotify/zoltar/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/zoltar/pulls/168","id":241979493,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTc5NDkz","html_url":"https://github.com/spotify/zoltar/pull/168","diff_url":"https://github.com/spotify/zoltar/pull/168.diff","patch_url":"https://github.com/spotify/zoltar/pull/168.patch","issue_url":"https://api.github.com/repos/spotify/zoltar/issues/168","number":168,"state":"open","locked":false,"title":"Refactor ModelLoader to move away from the common pool executor.","user":{"login":"regadas","id":163899,"node_id":"MDQ6VXNlcjE2Mzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/163899?v=4","gravatar_id":"","url":"https://api.github.com/users/regadas","html_url":"https://github.com/regadas","followers_url":"https://api.github.com/users/regadas/followers","following_url":"https://api.github.com/users/regadas/following{/other_user}","gists_url":"https://api.github.com/users/regadas/gists{/gist_id}","starred_url":"https://api.github.com/users/regadas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regadas/subscriptions","organizations_url":"https://api.github.com/users/regadas/orgs","repos_url":"https://api.github.com/users/regadas/repos","events_url":"https://api.github.com/users/regadas/events{/privacy}","received_events_url":"https://api.github.com/users/regadas/received_events","type":"User","site_admin":false},"body":null,"created_at":"2019-01-03T12:18:01Z","updated_at":"2019-01-03T15:47:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42dcd80762bc9e4b9e0177f90b9e0b098e2ff08b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/zoltar/pulls/168/commits","review_comments_url":"https://api.github.com/repos/spotify/zoltar/pulls/168/comments","review_comment_url":"https://api.github.com/repos/spotify/zoltar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/zoltar/issues/168/comments","statuses_url":"https://api.github.com/repos/spotify/zoltar/statuses/9cc5077e7a3923875c33246cf5602755f85ac9fa","head":{"label":"regadas:feature/model-loader-es","ref":"feature/model-loader-es","sha":"9cc5077e7a3923875c33246cf5602755f85ac9fa","user":{"login":"regadas","id":163899,"node_id":"MDQ6VXNlcjE2Mzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/163899?v=4","gravatar_id":"","url":"https://api.github.com/users/regadas","html_url":"https://github.com/regadas","followers_url":"https://api.github.com/users/regadas/followers","following_url":"https://api.github.com/users/regadas/following{/other_user}","gists_url":"https://api.github.com/users/regadas/gists{/gist_id}","starred_url":"https://api.github.com/users/regadas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regadas/subscriptions","organizations_url":"https://api.github.com/users/regadas/orgs","repos_url":"https://api.github.com/users/regadas/repos","events_url":"https://api.github.com/users/regadas/events{/privacy}","received_events_url":"https://api.github.com/users/regadas/received_events","type":"User","site_admin":false},"repo":{"id":125404775,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU0MDQ3NzU=","name":"zoltar","full_name":"regadas/zoltar","private":false,"owner":{"login":"regadas","id":163899,"node_id":"MDQ6VXNlcjE2Mzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/163899?v=4","gravatar_id":"","url":"https://api.github.com/users/regadas","html_url":"https://github.com/regadas","followers_url":"https://api.github.com/users/regadas/followers","following_url":"https://api.github.com/users/regadas/following{/other_user}","gists_url":"https://api.github.com/users/regadas/gists{/gist_id}","starred_url":"https://api.github.com/users/regadas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regadas/subscriptions","organizations_url":"https://api.github.com/users/regadas/orgs","repos_url":"https://api.github.com/users/regadas/repos","events_url":"https://api.github.com/users/regadas/events{/privacy}","received_events_url":"https://api.github.com/users/regadas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/regadas/zoltar","description":"Common library for serving TensorFlow and XGBoost models in production.","fork":true,"url":"https://api.github.com/repos/regadas/zoltar","forks_url":"https://api.github.com/repos/regadas/zoltar/forks","keys_url":"https://api.github.com/repos/regadas/zoltar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/regadas/zoltar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/regadas/zoltar/teams","hooks_url":"https://api.github.com/repos/regadas/zoltar/hooks","issue_events_url":"https://api.github.com/repos/regadas/zoltar/issues/events{/number}","events_url":"https://api.github.com/repos/regadas/zoltar/events","assignees_url":"https://api.github.com/repos/regadas/zoltar/assignees{/user}","branches_url":"https://api.github.com/repos/regadas/zoltar/branches{/branch}","tags_url":"https://api.github.com/repos/regadas/zoltar/tags","blobs_url":"https://api.github.com/repos/regadas/zoltar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/regadas/zoltar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/regadas/zoltar/git/refs{/sha}","trees_url":"https://api.github.com/repos/regadas/zoltar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/regadas/zoltar/statuses/{sha}","languages_url":"https://api.github.com/repos/regadas/zoltar/languages","stargazers_url":"https://api.github.com/repos/regadas/zoltar/stargazers","contributors_url":"https://api.github.com/repos/regadas/zoltar/contributors","subscribers_url":"https://api.github.com/repos/regadas/zoltar/subscribers","subscription_url":"https://api.github.com/repos/regadas/zoltar/subscription","commits_url":"https://api.github.com/repos/regadas/zoltar/commits{/sha}","git_commits_url":"https://api.github.com/repos/regadas/zoltar/git/commits{/sha}","comments_url":"https://api.github.com/repos/regadas/zoltar/comments{/number}","issue_comment_url":"https://api.github.com/repos/regadas/zoltar/issues/comments{/number}","contents_url":"https://api.github.com/repos/regadas/zoltar/contents/{+path}","compare_url":"https://api.github.com/repos/regadas/zoltar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/regadas/zoltar/merges","archive_url":"https://api.github.com/repos/regadas/zoltar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/regadas/zoltar/downloads","issues_url":"https://api.github.com/repos/regadas/zoltar/issues{/number}","pulls_url":"https://api.github.com/repos/regadas/zoltar/pulls{/number}","milestones_url":"https://api.github.com/repos/regadas/zoltar/milestones{/number}","notifications_url":"https://api.github.com/repos/regadas/zoltar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/regadas/zoltar/labels{/name}","releases_url":"https://api.github.com/repos/regadas/zoltar/releases{/id}","deployments_url":"https://api.github.com/repos/regadas/zoltar/deployments","created_at":"2018-03-15T17:41:35Z","updated_at":"2018-03-29T14:43:14Z","pushed_at":"2019-01-03T12:15:35Z","git_url":"git://github.com/regadas/zoltar.git","ssh_url":"git@github.com:regadas/zoltar.git","clone_url":"https://github.com/regadas/zoltar.git","svn_url":"https://github.com/regadas/zoltar","homepage":"","size":896,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"38c895b3a0c6cfde790b5bd9d0697d5c9105474a","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":124923731,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5MjM3MzE=","name":"zoltar","full_name":"spotify/zoltar","private":false,"owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spotify/zoltar","description":"Common library for serving TensorFlow, XGBoost and scikit-learn models in production.","fork":false,"url":"https://api.github.com/repos/spotify/zoltar","forks_url":"https://api.github.com/repos/spotify/zoltar/forks","keys_url":"https://api.github.com/repos/spotify/zoltar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/zoltar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/zoltar/teams","hooks_url":"https://api.github.com/repos/spotify/zoltar/hooks","issue_events_url":"https://api.github.com/repos/spotify/zoltar/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/zoltar/events","assignees_url":"https://api.github.com/repos/spotify/zoltar/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/zoltar/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/zoltar/tags","blobs_url":"https://api.github.com/repos/spotify/zoltar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/zoltar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/zoltar/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/zoltar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/zoltar/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/zoltar/languages","stargazers_url":"https://api.github.com/repos/spotify/zoltar/stargazers","contributors_url":"https://api.github.com/repos/spotify/zoltar/contributors","subscribers_url":"https://api.github.com/repos/spotify/zoltar/subscribers","subscription_url":"https://api.github.com/repos/spotify/zoltar/subscription","commits_url":"https://api.github.com/repos/spotify/zoltar/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/zoltar/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/zoltar/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/zoltar/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/zoltar/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/zoltar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/zoltar/merges","archive_url":"https://api.github.com/repos/spotify/zoltar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/zoltar/downloads","issues_url":"https://api.github.com/repos/spotify/zoltar/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/zoltar/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/zoltar/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/zoltar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/zoltar/labels{/name}","releases_url":"https://api.github.com/repos/spotify/zoltar/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/zoltar/deployments","created_at":"2018-03-12T17:09:52Z","updated_at":"2019-01-02T19:17:27Z","pushed_at":"2019-01-03T12:18:02Z","git_url":"git://github.com/spotify/zoltar.git","ssh_url":"git@github.com:spotify/zoltar.git","clone_url":"https://github.com/spotify/zoltar.git","svn_url":"https://github.com/spotify/zoltar","homepage":"https://spotify.github.io/zoltar/","size":1520,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":18,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/zoltar/pulls/168"},"html":{"href":"https://github.com/spotify/zoltar/pull/168"},"issue":{"href":"https://api.github.com/repos/spotify/zoltar/issues/168"},"comments":{"href":"https://api.github.com/repos/spotify/zoltar/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/zoltar/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/zoltar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/zoltar/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/zoltar/statuses/9cc5077e7a3923875c33246cf5602755f85ac9fa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brianmartin"}}