{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/168917254","pull_request_review_id":97369784,"id":168917254,"diff_hunk":"@@ -1,7 +1,8 @@\n import FWCore.ParameterSet.Config as cms\n \n-umnioTask = cms.EDAnalyzer(\n-\t\"UMNioTask\",\n+from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer\n+umnioTask = DQMEDAnalyzer(\n+\t'UMNioTask',","path":"DQM/HcalTasks/python/UMNioTask.py","position":7,"original_position":7,"commit_id":"dfbdc38dc4967fbc185aed1b432833fdec15e193","original_commit_id":"dfbdc38dc4967fbc185aed1b432833fdec15e193","user":{"login":"fwyzard","id":4069793,"avatar_url":"https://avatars2.githubusercontent.com/u/4069793?v=4","gravatar_id":"","url":"https://api.github.com/users/fwyzard","html_url":"https://github.com/fwyzard","followers_url":"https://api.github.com/users/fwyzard/followers","following_url":"https://api.github.com/users/fwyzard/following{/other_user}","gists_url":"https://api.github.com/users/fwyzard/gists{/gist_id}","starred_url":"https://api.github.com/users/fwyzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwyzard/subscriptions","organizations_url":"https://api.github.com/users/fwyzard/orgs","repos_url":"https://api.github.com/users/fwyzard/repos","events_url":"https://api.github.com/users/fwyzard/events{/privacy}","received_events_url":"https://api.github.com/users/fwyzard/received_events","type":"User","site_admin":false},"body":"can you avoid changing the `\"` into `'` ?","created_at":"2018-02-17T09:22:06Z","updated_at":"2018-02-17T09:29:43Z","html_url":"https://github.com/cms-sw/cmssw/pull/22243#discussion_r168917254","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22243","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/168917254"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22243#discussion_r168917254"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22243"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22243","id":169431922,"html_url":"https://github.com/cms-sw/cmssw/pull/22243","diff_url":"https://github.com/cms-sw/cmssw/pull/22243.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22243.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22243","number":22243,"state":"open","locked":false,"title":"More config changes for DQMEDAnalyzer","user":{"login":"schneiml","id":17005446,"avatar_url":"https://avatars1.githubusercontent.com/u/17005446?v=4","gravatar_id":"","url":"https://api.github.com/users/schneiml","html_url":"https://github.com/schneiml","followers_url":"https://api.github.com/users/schneiml/followers","following_url":"https://api.github.com/users/schneiml/following{/other_user}","gists_url":"https://api.github.com/users/schneiml/gists{/gist_id}","starred_url":"https://api.github.com/users/schneiml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneiml/subscriptions","organizations_url":"https://api.github.com/users/schneiml/orgs","repos_url":"https://api.github.com/users/schneiml/repos","events_url":"https://api.github.com/users/schneiml/events{/privacy}","received_events_url":"https://api.github.com/users/schneiml/received_events","type":"User","site_admin":false},"body":"This PR is a followup to #21871, and does the same thing, to more files.\r\n\r\nIt is split out of #22157, and supersedes it partially.\r\n\r\nAdditionally, there are some includes added that were previously pulled in via `DQMEDAnalyzer.h`. This is not strictly necessary, since this file is not changed here, but simplifies moving forward.\r\n\r\nThere is a conflict with #21794: The two might not conflict formally, and will also not cause problem if both get merged (for now), but the later of the two should be corrected to not touch the freshly converted `DQMGlobalEDAnalyzer` modules (Edit: resolved here, but not dramatic until we switch to EDProducer anyways).","created_at":"2018-02-15T17:12:42Z","updated_at":"2018-02-17T09:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4165e9f228642b12de05a2d4415418eed8abec41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":52881463,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":52881179,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"009800","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800","default":false},{"id":52882241,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-approved","name":"dqm-approved","color":"009800","default":false},{"id":52881628,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-pending","name":"fastsim-pending","color":"fbca04","default":false},{"id":52882379,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-approved","name":"l1-approved","color":"009800","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73","html_url":"https://github.com/cms-sw/cmssw/milestone/73","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73/labels","id":3060828,"number":73,"title":"CMSSW_10_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":66,"closed_issues":232,"state":"open","created_at":"2018-01-24T11:24:59Z","updated_at":"2018-02-16T21:03:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22243/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22243/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22243/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/dfbdc38dc4967fbc185aed1b432833fdec15e193","head":{"label":"schneiml:dqm-migrate-to-accumulator-configchanges","ref":"dqm-migrate-to-accumulator-configchanges","sha":"dfbdc38dc4967fbc185aed1b432833fdec15e193","user":{"login":"schneiml","id":17005446,"avatar_url":"https://avatars1.githubusercontent.com/u/17005446?v=4","gravatar_id":"","url":"https://api.github.com/users/schneiml","html_url":"https://github.com/schneiml","followers_url":"https://api.github.com/users/schneiml/followers","following_url":"https://api.github.com/users/schneiml/following{/other_user}","gists_url":"https://api.github.com/users/schneiml/gists{/gist_id}","starred_url":"https://api.github.com/users/schneiml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneiml/subscriptions","organizations_url":"https://api.github.com/users/schneiml/orgs","repos_url":"https://api.github.com/users/schneiml/repos","events_url":"https://api.github.com/users/schneiml/events{/privacy}","received_events_url":"https://api.github.com/users/schneiml/received_events","type":"User","site_admin":false},"repo":{"id":50838446,"name":"cmssw","full_name":"schneiml/cmssw","owner":{"login":"schneiml","id":17005446,"avatar_url":"https://avatars1.githubusercontent.com/u/17005446?v=4","gravatar_id":"","url":"https://api.github.com/users/schneiml","html_url":"https://github.com/schneiml","followers_url":"https://api.github.com/users/schneiml/followers","following_url":"https://api.github.com/users/schneiml/following{/other_user}","gists_url":"https://api.github.com/users/schneiml/gists{/gist_id}","starred_url":"https://api.github.com/users/schneiml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneiml/subscriptions","organizations_url":"https://api.github.com/users/schneiml/orgs","repos_url":"https://api.github.com/users/schneiml/repos","events_url":"https://api.github.com/users/schneiml/events{/privacy}","received_events_url":"https://api.github.com/users/schneiml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schneiml/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/schneiml/cmssw","forks_url":"https://api.github.com/repos/schneiml/cmssw/forks","keys_url":"https://api.github.com/repos/schneiml/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schneiml/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schneiml/cmssw/teams","hooks_url":"https://api.github.com/repos/schneiml/cmssw/hooks","issue_events_url":"https://api.github.com/repos/schneiml/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/schneiml/cmssw/events","assignees_url":"https://api.github.com/repos/schneiml/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/schneiml/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/schneiml/cmssw/tags","blobs_url":"https://api.github.com/repos/schneiml/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schneiml/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schneiml/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/schneiml/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schneiml/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/schneiml/cmssw/languages","stargazers_url":"https://api.github.com/repos/schneiml/cmssw/stargazers","contributors_url":"https://api.github.com/repos/schneiml/cmssw/contributors","subscribers_url":"https://api.github.com/repos/schneiml/cmssw/subscribers","subscription_url":"https://api.github.com/repos/schneiml/cmssw/subscription","commits_url":"https://api.github.com/repos/schneiml/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/schneiml/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/schneiml/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/schneiml/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/schneiml/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/schneiml/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schneiml/cmssw/merges","archive_url":"https://api.github.com/repos/schneiml/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schneiml/cmssw/downloads","issues_url":"https://api.github.com/repos/schneiml/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/schneiml/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/schneiml/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/schneiml/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schneiml/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/schneiml/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/schneiml/cmssw/deployments","created_at":"2016-02-01T12:39:02Z","updated_at":"2016-02-01T12:42:01Z","pushed_at":"2018-02-16T16:17:47Z","git_url":"git://github.com/schneiml/cmssw.git","ssh_url":"git@github.com:schneiml/cmssw.git","clone_url":"https://github.com/schneiml/cmssw.git","svn_url":"https://github.com/schneiml/cmssw","homepage":"http://cms-sw.github.io/","size":986629,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_8_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"0ef6a286b4b97552fb17e188750c4d2430276e67","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-02-15T23:46:56Z","pushed_at":"2018-02-17T00:38:46Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":993793,"stargazers_count":514,"watchers_count":514,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2459,"mirror_url":null,"archived":false,"open_issues_count":446,"license":null,"forks":2459,"open_issues":446,"watchers":514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22243"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22243"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22243"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22243/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22243/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22243/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/dfbdc38dc4967fbc185aed1b432833fdec15e193"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fwyzard"}}