{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/222086290","pull_request_review_id":160891087,"id":222086290,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjA4NjI5MA==","diff_hunk":"@@ -83,18 +86,17 @@ func eventMapping(r mb.ReporterV2, content []byte) error {\n \tvar data map[string]interface{}\n \terr := json.Unmarshal(content, &data)\n \tif err != nil {\n-\t\tr.Error(err)\n-\t\treturn err\n+\t\treturn errors.Wrap(err, \"failure parsing Kibana Stats API response\")\n \t}\n \n \tdataFields, err := schema.Apply(data)\n \tif err != nil {\n-\t\tr.Error(err)\n+\t\treturn errors.Wrap(err, \"failure to apply stats schema\")","path":"metricbeat/module/kibana/stats/data.go","position":27,"original_position":27,"commit_id":"8362a1f9bdebb719d3f6b54042d824b175e34d49","original_commit_id":"8362a1f9bdebb719d3f6b54042d824b175e34d49","user":{"login":"ycombinator","id":51061,"node_id":"MDQ6VXNlcjUxMDYx","avatar_url":"https://avatars2.githubusercontent.com/u/51061?v=4","gravatar_id":"","url":"https://api.github.com/users/ycombinator","html_url":"https://github.com/ycombinator","followers_url":"https://api.github.com/users/ycombinator/followers","following_url":"https://api.github.com/users/ycombinator/following{/other_user}","gists_url":"https://api.github.com/users/ycombinator/gists{/gist_id}","starred_url":"https://api.github.com/users/ycombinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycombinator/subscriptions","organizations_url":"https://api.github.com/users/ycombinator/orgs","repos_url":"https://api.github.com/users/ycombinator/repos","events_url":"https://api.github.com/users/ycombinator/events{/privacy}","received_events_url":"https://api.github.com/users/ycombinator/received_events","type":"User","site_admin":false},"body":"Yep, same as https://github.com/elastic/beats/pull/8308/files#r222085637. For non-xpack code paths (like this one here) I will update the PR to report one error per event.","created_at":"2018-10-02T19:42:26Z","updated_at":"2018-10-02T19:42:27Z","html_url":"https://github.com/elastic/beats/pull/8308#discussion_r222086290","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/8308","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/222086290"},"html":{"href":"https://github.com/elastic/beats/pull/8308#discussion_r222086290"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/8308"}},"in_reply_to_id":222073569},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/8308","id":215382538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzgyNTM4","html_url":"https://github.com/elastic/beats/pull/8308","diff_url":"https://github.com/elastic/beats/pull/8308.diff","patch_url":"https://github.com/elastic/beats/pull/8308.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/8308","number":8308,"state":"open","locked":false,"title":"Consistency in Elastic stack metricsets' code","user":{"login":"ycombinator","id":51061,"node_id":"MDQ6VXNlcjUxMDYx","avatar_url":"https://avatars2.githubusercontent.com/u/51061?v=4","gravatar_id":"","url":"https://api.github.com/users/ycombinator","html_url":"https://github.com/ycombinator","followers_url":"https://api.github.com/users/ycombinator/followers","following_url":"https://api.github.com/users/ycombinator/following{/other_user}","gists_url":"https://api.github.com/users/ycombinator/gists{/gist_id}","starred_url":"https://api.github.com/users/ycombinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycombinator/subscriptions","organizations_url":"https://api.github.com/users/ycombinator/orgs","repos_url":"https://api.github.com/users/ycombinator/repos","events_url":"https://api.github.com/users/ycombinator/events{/privacy}","received_events_url":"https://api.github.com/users/ycombinator/received_events","type":"User","site_admin":false},"body":"This PR makes error messages, reporting, and logging consistent across all metricsets for Elastic stack products, including the xpack monitoring code paths:\r\n\r\n* [x] `elasticsearch/ccr`\r\n* [x] `elasticsearch/cluster_stats`\r\n* [x] `elasticsearch/index`\r\n* [x] `elasticsearch/index_recovery`\r\n* [x] `elasticsearch/index_summary`\r\n* [x] `elasticsearch/ml_job`\r\n* [x] `elasticsearch/node`\r\n* [x] `elasticsearch/node_stats`\r\n* [x] `elasticsearch/pending_tasks`\r\n* [x] `elasticsearch/shard`\r\n* [x] `kibana/status`\r\n* [x] `kibana/stats`\r\n* [x] `logstash/node`\r\n* [x] `logstash/node_stats`","created_at":"2018-09-13T18:59:42Z","updated_at":"2018-10-02T19:42:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c84ab225bd2ec69d9e8e6ccd64a34cfe3885dae1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":331378892,"node_id":"MDU6TGFiZWwzMzEzNzg4OTI=","url":"https://api.github.com/repos/elastic/beats/labels/Metricbeat","name":"Metricbeat","color":"008000","default":false},{"id":360592718,"node_id":"MDU6TGFiZWwzNjA1OTI3MTg=","url":"https://api.github.com/repos/elastic/beats/labels/needs_backport","name":"needs_backport","color":"1d76db","default":false},{"id":228068770,"node_id":"MDU6TGFiZWwyMjgwNjg3NzA=","url":"https://api.github.com/repos/elastic/beats/labels/review","name":"review","color":"207de5","default":false},{"id":1004497282,"node_id":"MDU6TGFiZWwxMDA0NDk3Mjgy","url":"https://api.github.com/repos/elastic/beats/labels/v6.5.0","name":"v6.5.0","color":"ededed","default":false},{"id":884168819,"node_id":"MDU6TGFiZWw4ODQxNjg4MTk=","url":"https://api.github.com/repos/elastic/beats/labels/v7.0.0-alpha1","name":"v7.0.0-alpha1","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/8308/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/8308/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/8308/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/8362a1f9bdebb719d3f6b54042d824b175e34d49","head":{"label":"ycombinator:metricbeat-xpack-log-errors","ref":"metricbeat-xpack-log-errors","sha":"8362a1f9bdebb719d3f6b54042d824b175e34d49","user":{"login":"ycombinator","id":51061,"node_id":"MDQ6VXNlcjUxMDYx","avatar_url":"https://avatars2.githubusercontent.com/u/51061?v=4","gravatar_id":"","url":"https://api.github.com/users/ycombinator","html_url":"https://github.com/ycombinator","followers_url":"https://api.github.com/users/ycombinator/followers","following_url":"https://api.github.com/users/ycombinator/following{/other_user}","gists_url":"https://api.github.com/users/ycombinator/gists{/gist_id}","starred_url":"https://api.github.com/users/ycombinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycombinator/subscriptions","organizations_url":"https://api.github.com/users/ycombinator/orgs","repos_url":"https://api.github.com/users/ycombinator/repos","events_url":"https://api.github.com/users/ycombinator/events{/privacy}","received_events_url":"https://api.github.com/users/ycombinator/received_events","type":"User","site_admin":false},"repo":{"id":135076276,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwNzYyNzY=","name":"beats","full_name":"ycombinator/beats","private":false,"owner":{"login":"ycombinator","id":51061,"node_id":"MDQ6VXNlcjUxMDYx","avatar_url":"https://avatars2.githubusercontent.com/u/51061?v=4","gravatar_id":"","url":"https://api.github.com/users/ycombinator","html_url":"https://github.com/ycombinator","followers_url":"https://api.github.com/users/ycombinator/followers","following_url":"https://api.github.com/users/ycombinator/following{/other_user}","gists_url":"https://api.github.com/users/ycombinator/gists{/gist_id}","starred_url":"https://api.github.com/users/ycombinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycombinator/subscriptions","organizations_url":"https://api.github.com/users/ycombinator/orgs","repos_url":"https://api.github.com/users/ycombinator/repos","events_url":"https://api.github.com/users/ycombinator/events{/privacy}","received_events_url":"https://api.github.com/users/ycombinator/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ycombinator/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":true,"url":"https://api.github.com/repos/ycombinator/beats","forks_url":"https://api.github.com/repos/ycombinator/beats/forks","keys_url":"https://api.github.com/repos/ycombinator/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ycombinator/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ycombinator/beats/teams","hooks_url":"https://api.github.com/repos/ycombinator/beats/hooks","issue_events_url":"https://api.github.com/repos/ycombinator/beats/issues/events{/number}","events_url":"https://api.github.com/repos/ycombinator/beats/events","assignees_url":"https://api.github.com/repos/ycombinator/beats/assignees{/user}","branches_url":"https://api.github.com/repos/ycombinator/beats/branches{/branch}","tags_url":"https://api.github.com/repos/ycombinator/beats/tags","blobs_url":"https://api.github.com/repos/ycombinator/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ycombinator/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ycombinator/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/ycombinator/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ycombinator/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/ycombinator/beats/languages","stargazers_url":"https://api.github.com/repos/ycombinator/beats/stargazers","contributors_url":"https://api.github.com/repos/ycombinator/beats/contributors","subscribers_url":"https://api.github.com/repos/ycombinator/beats/subscribers","subscription_url":"https://api.github.com/repos/ycombinator/beats/subscription","commits_url":"https://api.github.com/repos/ycombinator/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/ycombinator/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/ycombinator/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/ycombinator/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/ycombinator/beats/contents/{+path}","compare_url":"https://api.github.com/repos/ycombinator/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ycombinator/beats/merges","archive_url":"https://api.github.com/repos/ycombinator/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ycombinator/beats/downloads","issues_url":"https://api.github.com/repos/ycombinator/beats/issues{/number}","pulls_url":"https://api.github.com/repos/ycombinator/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/ycombinator/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/ycombinator/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ycombinator/beats/labels{/name}","releases_url":"https://api.github.com/repos/ycombinator/beats/releases{/id}","deployments_url":"https://api.github.com/repos/ycombinator/beats/deployments","created_at":"2018-05-27T19:41:46Z","updated_at":"2018-09-26T14:15:09Z","pushed_at":"2018-10-02T18:02:28Z","git_url":"git://github.com/ycombinator/beats.git","ssh_url":"git@github.com:ycombinator/beats.git","clone_url":"https://github.com/ycombinator/beats.git","svn_url":"https://github.com/ycombinator/beats","homepage":"https://www.elastic.co/products/beats","size":91187,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"a8def47eb1e2de47eeedb11c11b3197d6f7feb47","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU1NDczOQ==","name":"beats","full_name":"elastic/beats","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2018-10-02T19:03:05Z","pushed_at":"2018-10-02T19:37:25Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":99556,"stargazers_count":6199,"watchers_count":6199,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1933,"mirror_url":null,"archived":false,"open_issues_count":942,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1933,"open_issues":942,"watchers":6199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/8308"},"html":{"href":"https://github.com/elastic/beats/pull/8308"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/8308"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/8308/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/8308/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/8308/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/8362a1f9bdebb719d3f6b54042d824b175e34d49"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ycombinator"}}