{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments/240828081","pull_request_review_id":183949719,"id":240828081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDgyODA4MQ==","diff_hunk":"@@ -140,6 +140,29 @@ fi\n echo \"[PASSED] backup_data with no data\"\n echo \"[PASSED] restore_data with no data\"\n \n+# ----------------------------------------------\n+# Delete backup directory function\n+# ----------------------------------------------\n+\n+echo \"[RUNNING] delete_dir\"\n+echo $data | $plugin backup_data $plugin_config $testdata\n+\n+# ensures the dir exists prior to deletion\n+$plugin restore_data $plugin_config $testdata > /dev/null\n+\n+$plugin delete_dir $plugin_config 20180101010101\n+\n+set +e\n+# output=`$plugin restore_data $plugin_config $testdata 2>&1`","path":"plugins/plugin_test_bench.sh","position":17,"original_position":17,"commit_id":"e21da19a108b85dac2a33725f687de785afb1f26","original_commit_id":"e21da19a108b85dac2a33725f687de785afb1f26","user":{"login":"tyacovone","id":38438025,"node_id":"MDQ6VXNlcjM4NDM4MDI1","avatar_url":"https://avatars0.githubusercontent.com/u/38438025?v=4","gravatar_id":"","url":"https://api.github.com/users/tyacovone","html_url":"https://github.com/tyacovone","followers_url":"https://api.github.com/users/tyacovone/followers","following_url":"https://api.github.com/users/tyacovone/following{/other_user}","gists_url":"https://api.github.com/users/tyacovone/gists{/gist_id}","starred_url":"https://api.github.com/users/tyacovone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyacovone/subscriptions","organizations_url":"https://api.github.com/users/tyacovone/orgs","repos_url":"https://api.github.com/users/tyacovone/repos","events_url":"https://api.github.com/users/tyacovone/events{/privacy}","received_events_url":"https://api.github.com/users/tyacovone/received_events","type":"User","site_admin":false},"body":"yep, good catch","created_at":"2018-12-11T23:14:53Z","updated_at":"2018-12-11T23:14:53Z","html_url":"https://github.com/greenplum-db/gpbackup/pull/200#discussion_r240828081","pull_request_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/200","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments/240828081"},"html":{"href":"https://github.com/greenplum-db/gpbackup/pull/200#discussion_r240828081"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/200"}},"in_reply_to_id":240808624},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/200","id":237801175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODAxMTc1","html_url":"https://github.com/greenplum-db/gpbackup/pull/200","diff_url":"https://github.com/greenplum-db/gpbackup/pull/200.diff","patch_url":"https://github.com/greenplum-db/gpbackup/pull/200.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/200","number":200,"state":"open","locked":false,"title":" Add delete_dir test to plugin_test_bench","user":{"login":"tyacovone","id":38438025,"node_id":"MDQ6VXNlcjM4NDM4MDI1","avatar_url":"https://avatars0.githubusercontent.com/u/38438025?v=4","gravatar_id":"","url":"https://api.github.com/users/tyacovone","html_url":"https://github.com/tyacovone","followers_url":"https://api.github.com/users/tyacovone/followers","following_url":"https://api.github.com/users/tyacovone/following{/other_user}","gists_url":"https://api.github.com/users/tyacovone/gists{/gist_id}","starred_url":"https://api.github.com/users/tyacovone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyacovone/subscriptions","organizations_url":"https://api.github.com/users/tyacovone/orgs","repos_url":"https://api.github.com/users/tyacovone/repos","events_url":"https://api.github.com/users/tyacovone/events{/privacy}","received_events_url":"https://api.github.com/users/tyacovone/received_events","type":"User","site_admin":false},"body":"We also updated the plugin api version to 0.4.0","created_at":"2018-12-11T19:32:59Z","updated_at":"2018-12-11T23:14:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90489fc0a73417b2f1c701999b10e68224a70798","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/200/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/200/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/200/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/e21da19a108b85dac2a33725f687de785afb1f26","head":{"label":"greenplum-db:detect-delete","ref":"detect-delete","sha":"e21da19a108b85dac2a33725f687de785afb1f26","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":91118401,"node_id":"MDEwOlJlcG9zaXRvcnk5MTExODQwMQ==","name":"gpbackup","full_name":"greenplum-db/gpbackup","private":false,"owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/greenplum-db/gpbackup","description":"GPDB Backup Utility","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpbackup","forks_url":"https://api.github.com/repos/greenplum-db/gpbackup/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpbackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpbackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpbackup/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpbackup/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpbackup/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpbackup/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpbackup/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpbackup/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpbackup/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpbackup/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpbackup/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpbackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpbackup/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpbackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpbackup/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpbackup/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpbackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpbackup/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpbackup/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpbackup/deployments","created_at":"2017-05-12T18:18:13Z","updated_at":"2018-12-11T22:00:34Z","pushed_at":"2018-12-11T22:00:35Z","git_url":"git://github.com/greenplum-db/gpbackup.git","ssh_url":"git@github.com:greenplum-db/gpbackup.git","clone_url":"https://github.com/greenplum-db/gpbackup.git","svn_url":"https://github.com/greenplum-db/gpbackup","homepage":null,"size":2865,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":2,"watchers":10,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"59a9d867e7222f3acc5650773810f6f0c92f91fb","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":91118401,"node_id":"MDEwOlJlcG9zaXRvcnk5MTExODQwMQ==","name":"gpbackup","full_name":"greenplum-db/gpbackup","private":false,"owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/greenplum-db/gpbackup","description":"GPDB Backup Utility","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpbackup","forks_url":"https://api.github.com/repos/greenplum-db/gpbackup/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpbackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpbackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpbackup/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpbackup/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpbackup/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpbackup/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpbackup/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpbackup/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpbackup/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpbackup/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpbackup/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpbackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpbackup/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpbackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpbackup/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpbackup/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpbackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpbackup/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpbackup/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpbackup/deployments","created_at":"2017-05-12T18:18:13Z","updated_at":"2018-12-11T22:00:34Z","pushed_at":"2018-12-11T22:00:35Z","git_url":"git://github.com/greenplum-db/gpbackup.git","ssh_url":"git@github.com:greenplum-db/gpbackup.git","clone_url":"https://github.com/greenplum-db/gpbackup.git","svn_url":"https://github.com/greenplum-db/gpbackup","homepage":null,"size":2865,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/200"},"html":{"href":"https://github.com/greenplum-db/gpbackup/pull/200"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/issues/200"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/e21da19a108b85dac2a33725f687de785afb1f26"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tyacovone"}}