{"action":"created","comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/217259801","pull_request_review_id":154928150,"id":217259801,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzI1OTgwMQ==","diff_hunk":"@@ -172,10 +172,11 @@ private HdfsFile getHdfsFile(String resolvedFileName) {\n     }\n \n     private HdfsFile createHdfsFile(String resolvedFileName) {\n-        HdfsFile hdfsFile = new HdfsFile();\n         Path filePath = getFilePath(resolvedFileName);\n-        hdfsFile.setPath(filePath);\n-        hdfsFile.setFsDataOutputStream(createFsDataOutputStream(hdfs, filePath));\n+        FSDataOutputStream fsDataOutputStream = createFsDataOutputStream(hdfs, filePath);\n+\n+        HdfsFile hdfsFile = new HdfsFile(filePath, fsDataOutputStream);","path":"modules/java-modules/hdfs/src/main/java/org/syslog_ng/hdfs/HdfsDestination.java","position":207,"original_position":10,"commit_id":"b5b6efeec5387f402ac0e6aa3055d43c23cc6406","original_commit_id":"900e78c6795e2af878c3e9976f66f1326e8ce870","user":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"body":"Actually for me the issue is not the `filePath` but the `FSDataOutputStream`. Because for a file to me it is natural to provide the path, not some magical stream (That should be the `HdfsFile` internal business.)\r\nBut for that I have to deal with append and archive (maybe just append). The actual purpose of this PR was not to refactor, and I made a cut here as for me it was acceptable (compared to the original.)","created_at":"2018-09-13T04:53:56Z","updated_at":"2018-09-13T04:53:56Z","html_url":"https://github.com/balabit/syslog-ng/pull/2257#discussion_r217259801","pull_request_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2257","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/217259801"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/2257#discussion_r217259801"},"pull_request":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2257"}},"in_reply_to_id":216685755},"pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2257","id":212376508,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzc2NTA4","html_url":"https://github.com/balabit/syslog-ng/pull/2257","diff_url":"https://github.com/balabit/syslog-ng/pull/2257.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/2257.patch","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2257","number":2257,"state":"open","locked":false,"title":"Hdfs time-reap","user":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"body":"This patchset introduces the `time_reap` option for the `hdfs` destination. The user could simply set this option in seconds after that every file that has not been written since `time_reap` seconds is going to be closed.\r\n(Note: In case of archive is configured it also triggers the archiving mechanism for that file only.)\r\n```\r\n  hdfs( ... time_reap(60));\r\n```\r\n\r\nThe option default value is `0`, which means disable the timeout.\r\n\r\nThe `java: option set/get key leaked` commit fixes a general java based option leak, every get/set option leaked per call.\r\nFixes #917","created_at":"2018-08-31T13:03:16Z","updated_at":"2018-09-13T04:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"297475438bb103420702267f39170da988f3b96e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gaborznagy","id":25612261,"node_id":"MDQ6VXNlcjI1NjEyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/25612261?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborznagy","html_url":"https://github.com/gaborznagy","followers_url":"https://api.github.com/users/gaborznagy/followers","following_url":"https://api.github.com/users/gaborznagy/following{/other_user}","gists_url":"https://api.github.com/users/gaborznagy/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborznagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborznagy/subscriptions","organizations_url":"https://api.github.com/users/gaborznagy/orgs","repos_url":"https://api.github.com/users/gaborznagy/repos","events_url":"https://api.github.com/users/gaborznagy/events{/privacy}","received_events_url":"https://api.github.com/users/gaborznagy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":988239098,"node_id":"MDU6TGFiZWw5ODgyMzkwOTg=","url":"https://api.github.com/repos/balabit/syslog-ng/labels/user-visible-feature","name":"user-visible-feature","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/balabit/syslog-ng/milestones/16","html_url":"https://github.com/balabit/syslog-ng/milestone/16","labels_url":"https://api.github.com/repos/balabit/syslog-ng/milestones/16/labels","id":3555169,"node_id":"MDk6TWlsZXN0b25lMzU1NTE2OQ==","number":16,"title":"OSE 3.18","description":"","creator":{"login":"lbudai","id":5908786,"node_id":"MDQ6VXNlcjU5MDg3ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/5908786?v=4","gravatar_id":"","url":"https://api.github.com/users/lbudai","html_url":"https://github.com/lbudai","followers_url":"https://api.github.com/users/lbudai/followers","following_url":"https://api.github.com/users/lbudai/following{/other_user}","gists_url":"https://api.github.com/users/lbudai/gists{/gist_id}","starred_url":"https://api.github.com/users/lbudai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbudai/subscriptions","organizations_url":"https://api.github.com/users/lbudai/orgs","repos_url":"https://api.github.com/users/lbudai/repos","events_url":"https://api.github.com/users/lbudai/events{/privacy}","received_events_url":"https://api.github.com/users/lbudai/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":20,"state":"open","created_at":"2018-08-08T10:01:49Z","updated_at":"2018-09-12T10:30:02Z","due_on":"2018-10-07T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2257/commits","review_comments_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2257/comments","review_comment_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2257/comments","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/b5b6efeec5387f402ac0e6aa3055d43c23cc6406","head":{"label":"Kokan:hdfs_timereap","ref":"hdfs_timereap","sha":"b5b6efeec5387f402ac0e6aa3055d43c23cc6406","user":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"repo":{"id":100604377,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2MDQzNzc=","name":"syslog-ng","full_name":"Kokan/syslog-ng","owner":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kokan/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":true,"url":"https://api.github.com/repos/Kokan/syslog-ng","forks_url":"https://api.github.com/repos/Kokan/syslog-ng/forks","keys_url":"https://api.github.com/repos/Kokan/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kokan/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kokan/syslog-ng/teams","hooks_url":"https://api.github.com/repos/Kokan/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/Kokan/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/Kokan/syslog-ng/events","assignees_url":"https://api.github.com/repos/Kokan/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/Kokan/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/Kokan/syslog-ng/tags","blobs_url":"https://api.github.com/repos/Kokan/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kokan/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kokan/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kokan/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kokan/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/Kokan/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/Kokan/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/Kokan/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/Kokan/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/Kokan/syslog-ng/subscription","commits_url":"https://api.github.com/repos/Kokan/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kokan/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kokan/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kokan/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kokan/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/Kokan/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kokan/syslog-ng/merges","archive_url":"https://api.github.com/repos/Kokan/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kokan/syslog-ng/downloads","issues_url":"https://api.github.com/repos/Kokan/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/Kokan/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/Kokan/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/Kokan/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kokan/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/Kokan/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/Kokan/syslog-ng/deployments","created_at":"2017-08-17T13:05:54Z","updated_at":"2018-09-12T07:38:21Z","pushed_at":"2018-09-12T10:26:14Z","git_url":"git://github.com/Kokan/syslog-ng.git","ssh_url":"git@github.com:Kokan/syslog-ng.git","clone_url":"https://github.com/Kokan/syslog-ng.git","svn_url":"https://github.com/Kokan/syslog-ng","homepage":"http://www.syslog-ng.org/","size":23572,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"balabit:master","ref":"master","sha":"0675461ba259414023acad1d12acc8d41b761d17","user":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0Njc1Nw==","name":"syslog-ng","full_name":"balabit/syslog-ng","owner":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/balabit/syslog-ng/deployments","created_at":"2013-11-05T16:22:02Z","updated_at":"2018-09-12T21:34:56Z","pushed_at":"2018-09-12T16:54:59Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"http://www.syslog-ng.org/","size":24560,"stargazers_count":865,"watchers_count":865,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":241,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":241,"open_issues":167,"watchers":865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2257"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/2257"},"issue":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/2257"},"comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/2257/comments"},"review_comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2257/comments"},"review_comment":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2257/commits"},"statuses":{"href":"https://api.github.com/repos/balabit/syslog-ng/statuses/b5b6efeec5387f402ac0e6aa3055d43c23cc6406"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Kokan"}}