{"action":"closed","number":12656,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/12656","id":182896209,"html_url":"https://github.com/facebook/react/pull/12656","diff_url":"https://github.com/facebook/react/pull/12656.diff","patch_url":"https://github.com/facebook/react/pull/12656.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/12656","number":12656,"state":"closed","locked":false,"title":"Perform null check on sourceFiber","user":{"login":"JeffUberman","id":7062515,"avatar_url":"https://avatars1.githubusercontent.com/u/7062515?v=4","gravatar_id":"","url":"https://api.github.com/users/JeffUberman","html_url":"https://github.com/JeffUberman","followers_url":"https://api.github.com/users/JeffUberman/followers","following_url":"https://api.github.com/users/JeffUberman/following{/other_user}","gists_url":"https://api.github.com/users/JeffUberman/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffUberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffUberman/subscriptions","organizations_url":"https://api.github.com/users/JeffUberman/orgs","repos_url":"https://api.github.com/users/JeffUberman/repos","events_url":"https://api.github.com/users/JeffUberman/events{/privacy}","received_events_url":"https://api.github.com/users/JeffUberman/received_events","type":"User","site_admin":false},"body":"Similar to issue presented in https://github.com/facebook/react/issues/12449, the \"Cannot read property 'return' of null\" of error can still be thrown due to a possible null value. This PR adds a nullcheck.\r\n\r\nError: \r\n![](https://user-images.githubusercontent.com/7062515/39015394-e4bdce6a-43e2-11e8-909a-1120d36d8a30.png)\r\n","created_at":"2018-04-19T20:55:59Z","updated_at":"2018-05-04T20:33:53Z","closed_at":"2018-05-04T20:33:53Z","merged_at":null,"merge_commit_sha":"4963b518ec5bf5fb72385cc94e0a8d00069f8624","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196858374,"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/12656/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/12656/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/12656/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/601c03e160a64c6ae600d34de68b067d6860c213","head":{"label":"JeffUberman:JeffUberman-patch-1","ref":"JeffUberman-patch-1","sha":"601c03e160a64c6ae600d34de68b067d6860c213","user":{"login":"JeffUberman","id":7062515,"avatar_url":"https://avatars1.githubusercontent.com/u/7062515?v=4","gravatar_id":"","url":"https://api.github.com/users/JeffUberman","html_url":"https://github.com/JeffUberman","followers_url":"https://api.github.com/users/JeffUberman/followers","following_url":"https://api.github.com/users/JeffUberman/following{/other_user}","gists_url":"https://api.github.com/users/JeffUberman/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffUberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffUberman/subscriptions","organizations_url":"https://api.github.com/users/JeffUberman/orgs","repos_url":"https://api.github.com/users/JeffUberman/repos","events_url":"https://api.github.com/users/JeffUberman/events{/privacy}","received_events_url":"https://api.github.com/users/JeffUberman/received_events","type":"User","site_admin":false},"repo":{"id":130267817,"name":"react","full_name":"JeffUberman/react","owner":{"login":"JeffUberman","id":7062515,"avatar_url":"https://avatars1.githubusercontent.com/u/7062515?v=4","gravatar_id":"","url":"https://api.github.com/users/JeffUberman","html_url":"https://github.com/JeffUberman","followers_url":"https://api.github.com/users/JeffUberman/followers","following_url":"https://api.github.com/users/JeffUberman/following{/other_user}","gists_url":"https://api.github.com/users/JeffUberman/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffUberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffUberman/subscriptions","organizations_url":"https://api.github.com/users/JeffUberman/orgs","repos_url":"https://api.github.com/users/JeffUberman/repos","events_url":"https://api.github.com/users/JeffUberman/events{/privacy}","received_events_url":"https://api.github.com/users/JeffUberman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JeffUberman/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/JeffUberman/react","forks_url":"https://api.github.com/repos/JeffUberman/react/forks","keys_url":"https://api.github.com/repos/JeffUberman/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JeffUberman/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JeffUberman/react/teams","hooks_url":"https://api.github.com/repos/JeffUberman/react/hooks","issue_events_url":"https://api.github.com/repos/JeffUberman/react/issues/events{/number}","events_url":"https://api.github.com/repos/JeffUberman/react/events","assignees_url":"https://api.github.com/repos/JeffUberman/react/assignees{/user}","branches_url":"https://api.github.com/repos/JeffUberman/react/branches{/branch}","tags_url":"https://api.github.com/repos/JeffUberman/react/tags","blobs_url":"https://api.github.com/repos/JeffUberman/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JeffUberman/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JeffUberman/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/JeffUberman/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JeffUberman/react/statuses/{sha}","languages_url":"https://api.github.com/repos/JeffUberman/react/languages","stargazers_url":"https://api.github.com/repos/JeffUberman/react/stargazers","contributors_url":"https://api.github.com/repos/JeffUberman/react/contributors","subscribers_url":"https://api.github.com/repos/JeffUberman/react/subscribers","subscription_url":"https://api.github.com/repos/JeffUberman/react/subscription","commits_url":"https://api.github.com/repos/JeffUberman/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/JeffUberman/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/JeffUberman/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/JeffUberman/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/JeffUberman/react/contents/{+path}","compare_url":"https://api.github.com/repos/JeffUberman/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JeffUberman/react/merges","archive_url":"https://api.github.com/repos/JeffUberman/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JeffUberman/react/downloads","issues_url":"https://api.github.com/repos/JeffUberman/react/issues{/number}","pulls_url":"https://api.github.com/repos/JeffUberman/react/pulls{/number}","milestones_url":"https://api.github.com/repos/JeffUberman/react/milestones{/number}","notifications_url":"https://api.github.com/repos/JeffUberman/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JeffUberman/react/labels{/name}","releases_url":"https://api.github.com/repos/JeffUberman/react/releases{/id}","deployments_url":"https://api.github.com/repos/JeffUberman/react/deployments","created_at":"2018-04-19T20:15:06Z","updated_at":"2018-04-19T20:41:37Z","pushed_at":"2018-04-19T20:41:10Z","git_url":"git://github.com/JeffUberman/react.git","ssh_url":"git@github.com:JeffUberman/react.git","clone_url":"https://github.com/JeffUberman/react.git","svn_url":"https://github.com/JeffUberman/react","homepage":"https://reactjs.org","size":135539,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"999b656ed1c94b00fcfd043f54e18ade7553dee0","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2018-05-04T20:29:38Z","pushed_at":"2018-05-04T20:24:36Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://reactjs.org","size":135619,"stargazers_count":95027,"watchers_count":95027,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17892,"mirror_url":null,"archived":false,"open_issues_count":448,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17892,"open_issues":448,"watchers":95027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/12656"},"html":{"href":"https://github.com/facebook/react/pull/12656"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/12656"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/12656/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/12656/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/12656/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/601c03e160a64c6ae600d34de68b067d6860c213"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"gaearon"}}