{"action":"created","issue":{"url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2819","repository_url":"https://api.github.com/repos/ag-grid/ag-grid","labels_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2819/labels{/name}","comments_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2819/comments","events_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2819/events","html_url":"https://github.com/ag-grid/ag-grid/issues/2819","id":388469468,"node_id":"MDU6SXNzdWUzODg0Njk0Njg=","number":2819,"title":"Bootstrap theme is terrible","user":{"login":"dflock","id":47756,"node_id":"MDQ6VXNlcjQ3NzU2","avatar_url":"https://avatars2.githubusercontent.com/u/47756?v=4","gravatar_id":"","url":"https://api.github.com/users/dflock","html_url":"https://github.com/dflock","followers_url":"https://api.github.com/users/dflock/followers","following_url":"https://api.github.com/users/dflock/following{/other_user}","gists_url":"https://api.github.com/users/dflock/gists{/gist_id}","starred_url":"https://api.github.com/users/dflock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dflock/subscriptions","organizations_url":"https://api.github.com/users/dflock/orgs","repos_url":"https://api.github.com/users/dflock/repos","events_url":"https://api.github.com/users/dflock/events{/privacy}","received_events_url":"https://api.github.com/users/dflock/received_events","type":"User","site_admin":false},"labels":[{"id":1070071522,"node_id":"MDU6TGFiZWwxMDcwMDcxNTIy","url":"https://api.github.com/repos/ag-grid/ag-grid/labels/in_zendesk","name":"in_zendesk","color":"f7e8aa","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-07T01:34:56Z","updated_at":"2018-12-07T11:23:24Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => see 'Providing a Reproducible Scenario'\r\n[] feature request => do not use Github for feature requests, see 'Customers of ag-Grid'\r\n[] support request => see 'Requesting Community Support'\r\n```\r\n\r\nThe current bootstrap theme doesn't do a very good job - and doesn't integrate with bootstrap very well at all. See comments on #34.\r\n\r\nThis is an attempt at improving the styles a bit. This is aimed at matching bootstrap tables that use the `.table-striped` class, but not `.table-bordered`. It's a scss file and assumes that you have the relevant bootstrap scss files in your project, allowing you to use the bootstrap scss variables etc...\r\n\r\n```scss\r\n//\r\n// Improve agGrid bootstrap theme\r\n//\r\n$ag-icons-path: '../node_modules/ag-grid-community/src/styles/icons/';\r\n\r\n$font-family: var(--font-family-sans-serif);\r\n$font-weight: 400;\r\n\r\n$secondary-font-family: var(--font-family-sans-serif);\r\n$secondary-font-weight: 700;\r\n\r\n$grid-size: 4px;\r\n$row-height: $grid-size * 6 + 4;\r\n$header-height: $row-height;\r\n\r\n@import '~ag-grid-community/src/styles/ag-grid';\r\n@import '~ag-grid-community/src/styles/ag-theme-bootstrap';\r\n\r\n.ag-theme-bootstrap {\r\n  margin-bottom: 1rem;\r\n\r\n  // TODO: make this contingent on boostrap .table-bordered\r\n  .ag-root {\r\n    border: 0;\r\n  }\r\n\r\n  .ag-header {\r\n    border-bottom: 1px solid $table-border-color;\r\n\r\n    .ag-header-row,\r\n    .ag-header-cell {\r\n      border: 0;\r\n      cursor: pointer;\r\n    }\r\n    .ag-header-cell {\r\n      border-top: 1px solid $table-border-color;\r\n    }\r\n  }\r\n\r\n  // By default the agGrid row stripes are the opposite way round from the boostrap ones. You can customize this in Bootstrap to match agGrid by setting a variable, or we can fix it here.\r\n  .ag-row-even {\r\n    // background-color: $table-accent-bg;\r\n    // Should be this ^^, but that gets you #EAEAEA,\r\n    // which isn't what bootstrap seems to use???\r\n    background-color: #f2f2f2;\r\n  }\r\n  .ag-row-odd {\r\n    background-color: $white;\r\n  }\r\n\r\n  .ag-cell {\r\n    border-top: 1px solid $table-border-color;\r\n  }\r\n\r\n  .ag-ltr .ag-cell-focus {\r\n    border: 1px dotted $table-border-color;\r\n  }\r\n}\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ag-grid/ag-grid/issues/comments/445203729","html_url":"https://github.com/ag-grid/ag-grid/issues/2819#issuecomment-445203729","issue_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2819","id":445203729,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTIwMzcyOQ==","user":{"login":"makinggoodsoftware","id":505400,"node_id":"MDQ6VXNlcjUwNTQwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/505400?v=4","gravatar_id":"","url":"https://api.github.com/users/makinggoodsoftware","html_url":"https://github.com/makinggoodsoftware","followers_url":"https://api.github.com/users/makinggoodsoftware/followers","following_url":"https://api.github.com/users/makinggoodsoftware/following{/other_user}","gists_url":"https://api.github.com/users/makinggoodsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/makinggoodsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makinggoodsoftware/subscriptions","organizations_url":"https://api.github.com/users/makinggoodsoftware/orgs","repos_url":"https://api.github.com/users/makinggoodsoftware/repos","events_url":"https://api.github.com/users/makinggoodsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/makinggoodsoftware/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T11:23:24Z","updated_at":"2018-12-07T11:23:24Z","author_association":"CONTRIBUTOR","body":"Hi,\r\n\r\nYour ticket has been flagged as in_zendesk, it means that we recognize this as an issue worth investigating so we have moved it to our official support channel for customers (zendesk)\r\n\r\nWe will carry on there with the investigation and we will update you as soon as possible.\r\n\r\nThanks"}}
{"actor":{"display_login":"makinggoodsoftware"}}