{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/229885583","pull_request_review_id":170493320,"id":229885583,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg4NTU4Mw==","diff_hunk":"@@ -982,6 +984,34 @@ class GridSearchCV(BaseSearchCV):\n      'split2_test_score', ...\n      'std_fit_time', 'std_score_time', 'std_test_score']\n \n+    >>> from sklearn import svm, datasets","path":"sklearn/model_selection/_search.py","position":17,"original_position":17,"commit_id":"e2d787fafcbc602ee65f64161453d53a82485df2","original_commit_id":"e2d787fafcbc602ee65f64161453d53a82485df2","user":{"login":"jnothman","id":78827,"node_id":"MDQ6VXNlcjc4ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"This rather belongs in doc/modules/grid_search.rst or \r\n../cross_validation.rst or doc/glossary.rst if not covered in those already\r\n","created_at":"2018-10-31T22:12:53Z","updated_at":"2018-10-31T22:13:25Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12495#discussion_r229885583","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12495","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/229885583"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12495#discussion_r229885583"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12495"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12495","id":227129175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTI5MTc1","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12495","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/12495.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/12495.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12495","number":12495,"state":"open","locked":false,"title":"DOC: Clarify `cv` parameter description in `GridSearchCV`","user":{"login":"QBatista","id":24798947,"node_id":"MDQ6VXNlcjI0Nzk4OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/24798947?v=4","gravatar_id":"","url":"https://api.github.com/users/QBatista","html_url":"https://github.com/QBatista","followers_url":"https://api.github.com/users/QBatista/followers","following_url":"https://api.github.com/users/QBatista/following{/other_user}","gists_url":"https://api.github.com/users/QBatista/gists{/gist_id}","starred_url":"https://api.github.com/users/QBatista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QBatista/subscriptions","organizations_url":"https://api.github.com/users/QBatista/orgs","repos_url":"https://api.github.com/users/QBatista/repos","events_url":"https://api.github.com/users/QBatista/events{/privacy}","received_events_url":"https://api.github.com/users/QBatista/received_events","type":"User","site_admin":false},"body":"#### Reference Issues/PRs\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\n\r\nThis PR addresses issue #12466.\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nThis PR does the 3 following things:\r\n- Rewrite the `cv` parameter description in `GridSearchCV`\r\n- Link the new `CV splitter` description to an existing example\r\n- Add an example with a custom iterable\r\n\r\nThanks for reviewing this!\r\n\r\nClose #12466 \r\n","created_at":"2018-10-31T01:11:30Z","updated_at":"2018-10-31T22:13:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e875890c092b09fccaae54382231f812dfc466fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12495/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12495/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12495/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/e2d787fafcbc602ee65f64161453d53a82485df2","head":{"label":"QBatista:fix_doc_cv","ref":"fix_doc_cv","sha":"e2d787fafcbc602ee65f64161453d53a82485df2","user":{"login":"QBatista","id":24798947,"node_id":"MDQ6VXNlcjI0Nzk4OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/24798947?v=4","gravatar_id":"","url":"https://api.github.com/users/QBatista","html_url":"https://github.com/QBatista","followers_url":"https://api.github.com/users/QBatista/followers","following_url":"https://api.github.com/users/QBatista/following{/other_user}","gists_url":"https://api.github.com/users/QBatista/gists{/gist_id}","starred_url":"https://api.github.com/users/QBatista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QBatista/subscriptions","organizations_url":"https://api.github.com/users/QBatista/orgs","repos_url":"https://api.github.com/users/QBatista/repos","events_url":"https://api.github.com/users/QBatista/events{/privacy}","received_events_url":"https://api.github.com/users/QBatista/received_events","type":"User","site_admin":false},"repo":{"id":155332731,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUzMzI3MzE=","name":"scikit-learn","full_name":"QBatista/scikit-learn","private":false,"owner":{"login":"QBatista","id":24798947,"node_id":"MDQ6VXNlcjI0Nzk4OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/24798947?v=4","gravatar_id":"","url":"https://api.github.com/users/QBatista","html_url":"https://github.com/QBatista","followers_url":"https://api.github.com/users/QBatista/followers","following_url":"https://api.github.com/users/QBatista/following{/other_user}","gists_url":"https://api.github.com/users/QBatista/gists{/gist_id}","starred_url":"https://api.github.com/users/QBatista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QBatista/subscriptions","organizations_url":"https://api.github.com/users/QBatista/orgs","repos_url":"https://api.github.com/users/QBatista/repos","events_url":"https://api.github.com/users/QBatista/events{/privacy}","received_events_url":"https://api.github.com/users/QBatista/received_events","type":"User","site_admin":false},"html_url":"https://github.com/QBatista/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/QBatista/scikit-learn","forks_url":"https://api.github.com/repos/QBatista/scikit-learn/forks","keys_url":"https://api.github.com/repos/QBatista/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QBatista/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QBatista/scikit-learn/teams","hooks_url":"https://api.github.com/repos/QBatista/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/QBatista/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/QBatista/scikit-learn/events","assignees_url":"https://api.github.com/repos/QBatista/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/QBatista/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/QBatista/scikit-learn/tags","blobs_url":"https://api.github.com/repos/QBatista/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QBatista/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QBatista/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/QBatista/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QBatista/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/QBatista/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/QBatista/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/QBatista/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/QBatista/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/QBatista/scikit-learn/subscription","commits_url":"https://api.github.com/repos/QBatista/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/QBatista/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/QBatista/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/QBatista/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/QBatista/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/QBatista/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QBatista/scikit-learn/merges","archive_url":"https://api.github.com/repos/QBatista/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QBatista/scikit-learn/downloads","issues_url":"https://api.github.com/repos/QBatista/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/QBatista/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/QBatista/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/QBatista/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QBatista/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/QBatista/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/QBatista/scikit-learn/deployments","created_at":"2018-10-30T06:03:12Z","updated_at":"2018-10-30T06:03:19Z","pushed_at":"2018-10-31T01:34:41Z","git_url":"git://github.com/QBatista/scikit-learn.git","ssh_url":"git@github.com:QBatista/scikit-learn.git","clone_url":"https://github.com/QBatista/scikit-learn.git","svn_url":"https://github.com/QBatista/scikit-learn","homepage":"http://scikit-learn.org","size":95781,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"c2f17d0fc0e57a9ed00b895b5f419d956adfc5cf","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","private":false,"owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-10-31T21:39:36Z","pushed_at":"2018-10-31T20:34:35Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":96464,"stargazers_count":31442,"watchers_count":31442,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15509,"mirror_url":null,"archived":false,"open_issues_count":1801,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15509,"open_issues":1801,"watchers":31442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12495"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12495"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12495"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12495/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12495/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12495/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/e2d787fafcbc602ee65f64161453d53a82485df2"}},"author_association":"NONE"}}
{"actor":{"display_login":"jnothman"}}