{"action":"created","comment":{"url":"https://api.github.com/repos/mjambon/atd/pulls/comments/200820131","pull_request_review_id":135212492,"id":200820131,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgyMDEzMQ==","diff_hunk":"@@ -546,38 +546,79 @@ example is:\n \n   type t = string <ocaml valid=\"fun s -> String.length s >= 8\"> option\n \n-``atdgen -v`` will produce something equivalent to the following\n-implementation:\n+As we can seefrom this example, the validation function is specified using the\n+annotation ``<ocaml valid=p>``, where ``p`` is a predicate ``p : t -> bool``,\n+returning ``true`` when the value of type ``t`` is valid and ``false``\n+otherwise.","path":"doc/tutorial.rst","position":9,"original_position":9,"commit_id":"567fc0da20d9ac909e9017d127595cc3422ca7a2","original_commit_id":"567fc0da20d9ac909e9017d127595cc3422ca7a2","user":{"login":"mjambon","id":343265,"node_id":"MDQ6VXNlcjM0MzI2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/343265?v=4","gravatar_id":"","url":"https://api.github.com/users/mjambon","html_url":"https://github.com/mjambon","followers_url":"https://api.github.com/users/mjambon/followers","following_url":"https://api.github.com/users/mjambon/following{/other_user}","gists_url":"https://api.github.com/users/mjambon/gists{/gist_id}","starred_url":"https://api.github.com/users/mjambon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjambon/subscriptions","organizations_url":"https://api.github.com/users/mjambon/orgs","repos_url":"https://api.github.com/users/mjambon/repos","events_url":"https://api.github.com/users/mjambon/events{/privacy}","received_events_url":"https://api.github.com/users/mjambon/received_events","type":"User","site_admin":false},"body":"2 things here:\r\n* seefrom -> see from\r\n* `<ocaml valid=p>` would be clearer as `<ocaml valid=\"p\">` I think.","created_at":"2018-07-07T19:20:09Z","updated_at":"2018-07-07T19:20:09Z","html_url":"https://github.com/mjambon/atd/pull/141#discussion_r200820131","pull_request_url":"https://api.github.com/repos/mjambon/atd/pulls/141","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mjambon/atd/pulls/comments/200820131"},"html":{"href":"https://github.com/mjambon/atd/pull/141#discussion_r200820131"},"pull_request":{"href":"https://api.github.com/repos/mjambon/atd/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/mjambon/atd/pulls/141","id":198841104,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODQxMTA0","html_url":"https://github.com/mjambon/atd/pull/141","diff_url":"https://github.com/mjambon/atd/pull/141.diff","patch_url":"https://github.com/mjambon/atd/pull/141.patch","issue_url":"https://api.github.com/repos/mjambon/atd/issues/141","number":141,"state":"open","locked":false,"title":"Update data validation tutorial section and example code","user":{"login":"shonfeder","id":19820422,"node_id":"MDQ6VXNlcjE5ODIwNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/19820422?v=4","gravatar_id":"","url":"https://api.github.com/users/shonfeder","html_url":"https://github.com/shonfeder","followers_url":"https://api.github.com/users/shonfeder/followers","following_url":"https://api.github.com/users/shonfeder/following{/other_user}","gists_url":"https://api.github.com/users/shonfeder/gists{/gist_id}","starred_url":"https://api.github.com/users/shonfeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shonfeder/subscriptions","organizations_url":"https://api.github.com/users/shonfeder/orgs","repos_url":"https://api.github.com/users/shonfeder/repos","events_url":"https://api.github.com/users/shonfeder/events{/privacy}","received_events_url":"https://api.github.com/users/shonfeder/received_events","type":"User","site_admin":false},"body":"Closes  #134 \r\n\r\nThe whitespace changes to doc/tutorial-data/validate/resume_util.ml are just from bringing the example code up to date with the code in the tutorial text.","created_at":"2018-07-03T03:34:31Z","updated_at":"2018-07-07T19:20:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a2d79ab06402ea7e8dce7fd646259c0c330e9d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mjambon/atd/pulls/141/commits","review_comments_url":"https://api.github.com/repos/mjambon/atd/pulls/141/comments","review_comment_url":"https://api.github.com/repos/mjambon/atd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mjambon/atd/issues/141/comments","statuses_url":"https://api.github.com/repos/mjambon/atd/statuses/567fc0da20d9ac909e9017d127595cc3422ca7a2","head":{"label":"shonfeder:update-data-validation-tutorial","ref":"update-data-validation-tutorial","sha":"567fc0da20d9ac909e9017d127595cc3422ca7a2","user":{"login":"shonfeder","id":19820422,"node_id":"MDQ6VXNlcjE5ODIwNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/19820422?v=4","gravatar_id":"","url":"https://api.github.com/users/shonfeder","html_url":"https://github.com/shonfeder","followers_url":"https://api.github.com/users/shonfeder/followers","following_url":"https://api.github.com/users/shonfeder/following{/other_user}","gists_url":"https://api.github.com/users/shonfeder/gists{/gist_id}","starred_url":"https://api.github.com/users/shonfeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shonfeder/subscriptions","organizations_url":"https://api.github.com/users/shonfeder/orgs","repos_url":"https://api.github.com/users/shonfeder/repos","events_url":"https://api.github.com/users/shonfeder/events{/privacy}","received_events_url":"https://api.github.com/users/shonfeder/received_events","type":"User","site_admin":false},"repo":{"id":135846838,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU4NDY4Mzg=","name":"atd","full_name":"shonfeder/atd","owner":{"login":"shonfeder","id":19820422,"node_id":"MDQ6VXNlcjE5ODIwNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/19820422?v=4","gravatar_id":"","url":"https://api.github.com/users/shonfeder","html_url":"https://github.com/shonfeder","followers_url":"https://api.github.com/users/shonfeder/followers","following_url":"https://api.github.com/users/shonfeder/following{/other_user}","gists_url":"https://api.github.com/users/shonfeder/gists{/gist_id}","starred_url":"https://api.github.com/users/shonfeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shonfeder/subscriptions","organizations_url":"https://api.github.com/users/shonfeder/orgs","repos_url":"https://api.github.com/users/shonfeder/repos","events_url":"https://api.github.com/users/shonfeder/events{/privacy}","received_events_url":"https://api.github.com/users/shonfeder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shonfeder/atd","description":"Static types for JSON APIs","fork":true,"url":"https://api.github.com/repos/shonfeder/atd","forks_url":"https://api.github.com/repos/shonfeder/atd/forks","keys_url":"https://api.github.com/repos/shonfeder/atd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shonfeder/atd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shonfeder/atd/teams","hooks_url":"https://api.github.com/repos/shonfeder/atd/hooks","issue_events_url":"https://api.github.com/repos/shonfeder/atd/issues/events{/number}","events_url":"https://api.github.com/repos/shonfeder/atd/events","assignees_url":"https://api.github.com/repos/shonfeder/atd/assignees{/user}","branches_url":"https://api.github.com/repos/shonfeder/atd/branches{/branch}","tags_url":"https://api.github.com/repos/shonfeder/atd/tags","blobs_url":"https://api.github.com/repos/shonfeder/atd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shonfeder/atd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shonfeder/atd/git/refs{/sha}","trees_url":"https://api.github.com/repos/shonfeder/atd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shonfeder/atd/statuses/{sha}","languages_url":"https://api.github.com/repos/shonfeder/atd/languages","stargazers_url":"https://api.github.com/repos/shonfeder/atd/stargazers","contributors_url":"https://api.github.com/repos/shonfeder/atd/contributors","subscribers_url":"https://api.github.com/repos/shonfeder/atd/subscribers","subscription_url":"https://api.github.com/repos/shonfeder/atd/subscription","commits_url":"https://api.github.com/repos/shonfeder/atd/commits{/sha}","git_commits_url":"https://api.github.com/repos/shonfeder/atd/git/commits{/sha}","comments_url":"https://api.github.com/repos/shonfeder/atd/comments{/number}","issue_comment_url":"https://api.github.com/repos/shonfeder/atd/issues/comments{/number}","contents_url":"https://api.github.com/repos/shonfeder/atd/contents/{+path}","compare_url":"https://api.github.com/repos/shonfeder/atd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shonfeder/atd/merges","archive_url":"https://api.github.com/repos/shonfeder/atd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shonfeder/atd/downloads","issues_url":"https://api.github.com/repos/shonfeder/atd/issues{/number}","pulls_url":"https://api.github.com/repos/shonfeder/atd/pulls{/number}","milestones_url":"https://api.github.com/repos/shonfeder/atd/milestones{/number}","notifications_url":"https://api.github.com/repos/shonfeder/atd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shonfeder/atd/labels{/name}","releases_url":"https://api.github.com/repos/shonfeder/atd/releases{/id}","deployments_url":"https://api.github.com/repos/shonfeder/atd/deployments","created_at":"2018-06-02T19:37:06Z","updated_at":"2018-06-02T19:37:08Z","pushed_at":"2018-07-03T03:33:32Z","git_url":"git://github.com/shonfeder/atd.git","ssh_url":"git@github.com:shonfeder/atd.git","clone_url":"https://github.com/shonfeder/atd.git","svn_url":"https://github.com/shonfeder/atd","homepage":"https://mjambon.github.io/atdgen-doc","size":1604,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mjambon:master","ref":"master","sha":"dab693e700b1123b837e41dd6d6729c8eb65e071","user":{"login":"mjambon","id":343265,"node_id":"MDQ6VXNlcjM0MzI2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/343265?v=4","gravatar_id":"","url":"https://api.github.com/users/mjambon","html_url":"https://github.com/mjambon","followers_url":"https://api.github.com/users/mjambon/followers","following_url":"https://api.github.com/users/mjambon/following{/other_user}","gists_url":"https://api.github.com/users/mjambon/gists{/gist_id}","starred_url":"https://api.github.com/users/mjambon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjambon/subscriptions","organizations_url":"https://api.github.com/users/mjambon/orgs","repos_url":"https://api.github.com/users/mjambon/repos","events_url":"https://api.github.com/users/mjambon/events{/privacy}","received_events_url":"https://api.github.com/users/mjambon/received_events","type":"User","site_admin":false},"repo":{"id":8681682,"node_id":"MDEwOlJlcG9zaXRvcnk4NjgxNjgy","name":"atd","full_name":"mjambon/atd","owner":{"login":"mjambon","id":343265,"node_id":"MDQ6VXNlcjM0MzI2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/343265?v=4","gravatar_id":"","url":"https://api.github.com/users/mjambon","html_url":"https://github.com/mjambon","followers_url":"https://api.github.com/users/mjambon/followers","following_url":"https://api.github.com/users/mjambon/following{/other_user}","gists_url":"https://api.github.com/users/mjambon/gists{/gist_id}","starred_url":"https://api.github.com/users/mjambon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjambon/subscriptions","organizations_url":"https://api.github.com/users/mjambon/orgs","repos_url":"https://api.github.com/users/mjambon/repos","events_url":"https://api.github.com/users/mjambon/events{/privacy}","received_events_url":"https://api.github.com/users/mjambon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjambon/atd","description":"Static types for JSON APIs","fork":false,"url":"https://api.github.com/repos/mjambon/atd","forks_url":"https://api.github.com/repos/mjambon/atd/forks","keys_url":"https://api.github.com/repos/mjambon/atd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjambon/atd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjambon/atd/teams","hooks_url":"https://api.github.com/repos/mjambon/atd/hooks","issue_events_url":"https://api.github.com/repos/mjambon/atd/issues/events{/number}","events_url":"https://api.github.com/repos/mjambon/atd/events","assignees_url":"https://api.github.com/repos/mjambon/atd/assignees{/user}","branches_url":"https://api.github.com/repos/mjambon/atd/branches{/branch}","tags_url":"https://api.github.com/repos/mjambon/atd/tags","blobs_url":"https://api.github.com/repos/mjambon/atd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjambon/atd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjambon/atd/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjambon/atd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjambon/atd/statuses/{sha}","languages_url":"https://api.github.com/repos/mjambon/atd/languages","stargazers_url":"https://api.github.com/repos/mjambon/atd/stargazers","contributors_url":"https://api.github.com/repos/mjambon/atd/contributors","subscribers_url":"https://api.github.com/repos/mjambon/atd/subscribers","subscription_url":"https://api.github.com/repos/mjambon/atd/subscription","commits_url":"https://api.github.com/repos/mjambon/atd/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjambon/atd/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjambon/atd/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjambon/atd/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjambon/atd/contents/{+path}","compare_url":"https://api.github.com/repos/mjambon/atd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjambon/atd/merges","archive_url":"https://api.github.com/repos/mjambon/atd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjambon/atd/downloads","issues_url":"https://api.github.com/repos/mjambon/atd/issues{/number}","pulls_url":"https://api.github.com/repos/mjambon/atd/pulls{/number}","milestones_url":"https://api.github.com/repos/mjambon/atd/milestones{/number}","notifications_url":"https://api.github.com/repos/mjambon/atd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjambon/atd/labels{/name}","releases_url":"https://api.github.com/repos/mjambon/atd/releases{/id}","deployments_url":"https://api.github.com/repos/mjambon/atd/deployments","created_at":"2013-03-10T06:43:15Z","updated_at":"2018-07-07T13:08:05Z","pushed_at":"2018-07-03T03:34:32Z","git_url":"git://github.com/mjambon/atd.git","ssh_url":"git@github.com:mjambon/atd.git","clone_url":"https://github.com/mjambon/atd.git","svn_url":"https://github.com/mjambon/atd","homepage":"","size":1610,"stargazers_count":52,"watchers_count":52,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":36,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjambon/atd/pulls/141"},"html":{"href":"https://github.com/mjambon/atd/pull/141"},"issue":{"href":"https://api.github.com/repos/mjambon/atd/issues/141"},"comments":{"href":"https://api.github.com/repos/mjambon/atd/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/mjambon/atd/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/mjambon/atd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mjambon/atd/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/mjambon/atd/statuses/567fc0da20d9ac909e9017d127595cc3422ca7a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mjambon"}}