{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/223552635","pull_request_review_id":162706914,"id":223552635,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzU1MjYzNQ==","diff_hunk":"@@ -4,12 +4,18 @@ project(libtorrent\n \tDESCRIPTION \"Bittorrent library\"\n \tVERSION 1.2.0\n )\n+set(CPACK_SOURCE_PACKAGE_FILE_NAME \"${CMAKE_PROJECT_NAME}-${VERSION}\")\n set (SOVERSION \"10\")\n \n list(APPEND CMAKE_MODULE_PATH ${libtorrent_SOURCE_DIR}/cmake/Modules)\n include(FeatureSummary)\n include(GNUInstallDirs)\n include(GeneratePkgConfig)\n+include(CPack)\n+\n+add_custom_target(dist COMMAND ${CMAKE_MAKE_PROGRAM} package_source)\n+\n+set(CMAKE_CXX_EXTENSIONS OFF)","path":"CMakeLists.txt","position":15,"original_position":15,"commit_id":"0481affc13264cb1b620b32435dab6cd9f876ded","original_commit_id":"a442176d7468f6e08def43d69bcb37e529b7ca32","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"on second thought I think this should be controlled from top-level as well","created_at":"2018-10-09T03:39:31Z","updated_at":"2018-10-09T03:39:31Z","html_url":"https://github.com/arvidn/libtorrent/pull/3339#discussion_r223552635","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/223552635"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/3339#discussion_r223552635"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339"}},"in_reply_to_id":223371873},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339","id":221126078,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTI2MDc4","html_url":"https://github.com/arvidn/libtorrent/pull/3339","diff_url":"https://github.com/arvidn/libtorrent/pull/3339.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/3339.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/3339","number":3339,"state":"open","locked":false,"title":"fix missing cmake-related files in tarball","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"a bunch of cmake fixes. specifically to enable building with cmake out of a tarball generated with automake.\r\n\r\n@zeule would you mind taking a look?","created_at":"2018-10-08T13:54:05Z","updated_at":"2018-10-09T03:39:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b48da87757d8ac4d1c54ba7d3c18b53e31d78bc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/3339/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/0481affc13264cb1b620b32435dab6cd9f876ded","head":{"label":"arvidn:fix-tarball-cmake","ref":"fix-tarball-cmake","sha":"0481affc13264cb1b620b32435dab6cd9f876ded","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc4MTc2OQ==","name":"libtorrent","full_name":"arvidn/libtorrent","private":false,"owner":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2018-10-08T14:22:04Z","pushed_at":"2018-10-08T14:30:24Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":77875,"stargazers_count":1484,"watchers_count":1484,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":411,"mirror_url":null,"archived":false,"open_issues_count":236,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":411,"open_issues":236,"watchers":1484,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"8e8489c6dc5159c6014a6f3ce405102c311a3eb4","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc4MTc2OQ==","name":"libtorrent","full_name":"arvidn/libtorrent","private":false,"owner":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2018-10-08T14:22:04Z","pushed_at":"2018-10-08T14:30:24Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":77875,"stargazers_count":1484,"watchers_count":1484,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":411,"mirror_url":null,"archived":false,"open_issues_count":236,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":411,"open_issues":236,"watchers":1484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/3339"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/3339"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/3339/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/0481affc13264cb1b620b32435dab6cd9f876ded"}},"author_association":"OWNER"}}
{"actor":{"display_login":"arvidn"}}