{"action":"created","comment":{"url":"https://api.github.com/repos/klee/klee/pulls/comments/242523242","pull_request_review_id":186048380,"id":242523242,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjUyMzI0Mg==","diff_hunk":"@@ -276,38 +250,115 @@ namespace {\n \t\t    clEnumValN(Executor::User, \"User\", \"Wrong klee_* functions invocation\"),\n \t\t    clEnumValN(Executor::Unhandled, \"Unhandled\", \"Unhandled instruction hit\")\n \t\t    KLEE_LLVM_CL_VAL_END),\n-\t\t  cl::ZeroOrMore);\n+\t\t  cl::ZeroOrMore,\n+                  cl::cat(TerminationCat));\n \n   cl::opt<unsigned long long>\n   StopAfterNInstructions(\"stop-after-n-instructions\",\n                          cl::desc(\"Stop execution after specified number of instructions (default=0 (off))\"),\n-                         cl::init(0));\n+                         cl::init(0),\n+                         cl::cat(TerminationCat));\n   \n   cl::opt<unsigned>\n   MaxForks(\"max-forks\",\n            cl::desc(\"Only fork this many times (default=-1 (off))\"),\n-           cl::init(~0u));\n+           cl::init(~0u),\n+           cl::cat(TerminationCat));\n   \n   cl::opt<unsigned>\n   MaxDepth(\"max-depth\",\n            cl::desc(\"Only allow this many symbolic branches (default=0 (off))\"),\n-           cl::init(0));\n+           cl::init(0),\n+           cl::cat(TerminationCat));\n   \n   cl::opt<unsigned>\n   MaxMemory(\"max-memory\",\n             cl::desc(\"Refuse to fork when above this amount of memory (in MB, default=2000)\"),\n-            cl::init(2000));\n+            cl::init(2000),\n+            cl::cat(TerminationCat));\n \n   cl::opt<bool>\n   MaxMemoryInhibit(\"max-memory-inhibit\",\n-            cl::desc(\"Inhibit forking at memory cap (vs. random terminate) (default=on)\"),\n-            cl::init(true));\n-\n-  cl::opt<unsigned> RuntimeMaxStackFrames(\n-      \"max-stack-frames\",\n-      cl::desc(\"Terminates a state after the limit of stack frames is reached \"\n-               \"(default=8192). Disable check with 0.\"),\n-      cl::init(8192));\n+                   cl::desc(\"Inhibit forking at memory cap (vs. random terminate) (default=on)\"),\n+                   cl::init(true),\n+                   cl::cat(TerminationCat));\n+\n+  cl::opt<unsigned> RuntimeMaxStackFrames(\"max-stack-frames\",\n+                                          cl::desc(\"Terminate a state after this many stack frames (default=8192).  Disable check with 0.\"),\n+                                          cl::init(8192),\n+                                          cl::cat(TerminationCat));\n+\n+  cl::opt<std::string>\n+  MaxInstructionTime(\"max-instruction-time\",\n+                     cl::desc(\"Allow a single instruction to take only this much time (default=0s (off)). Enables --use-forked-solver\"),\n+                     cl::cat(TerminationCat));\n+\n+  \n+\n+  /*** Debugging options ***/\n+\n+  /// The different query logging solvers that can switched on/off\n+  enum PrintDebugInstructionsType {\n+    STDERR_ALL, ///\n+    STDERR_SRC,\n+    STDERR_COMPACT,\n+    FILE_ALL,    ///\n+    FILE_SRC,    ///\n+    FILE_COMPACT ///\n+  };\n+\n+  llvm::cl::bits<PrintDebugInstructionsType> DebugPrintInstructions(\n+      \"debug-print-instructions\",\n+      llvm::cl::desc(\"Log instructions during execution.\"),\n+      llvm::cl::values(\n+          clEnumValN(STDERR_ALL, \"all:stderr\", \"Log all instructions to stderr \"\n+                                               \"in format [src, inst_id, \"\n+                                               \"llvm_inst]\"),\n+          clEnumValN(STDERR_SRC, \"src:stderr\",\n+                     \"Log all instructions to stderr in format [src, inst_id]\"),\n+          clEnumValN(STDERR_COMPACT, \"compact:stderr\",\n+                     \"Log all instructions to stderr in format [inst_id]\"),\n+          clEnumValN(FILE_ALL, \"all:file\", \"Log all instructions to file \"\n+                                           \"instructions.txt in format [src, \"\n+                                           \"inst_id, llvm_inst]\"),\n+          clEnumValN(FILE_SRC, \"src:file\", \"Log all instructions to file \"\n+                                           \"instructions.txt in format [src, \"\n+                                           \"inst_id]\"),\n+          clEnumValN(FILE_COMPACT, \"compact:file\",\n+                     \"Log all instructions to file instructions.txt in format \"\n+                     \"[inst_id]\")\n+          KLEE_LLVM_CL_VAL_END),\n+      llvm::cl::CommaSeparated);\n+#ifdef HAVE_ZLIB_H\n+  cl::opt<bool> DebugCompressInstructions(\n+      \"debug-compress-instructions\", cl::init(false),\n+      cl::desc(\"Compress the logged instructions in gzip format.\"));\n+#endif\n+\n+  cl::opt<bool>\n+  DebugCheckForImpliedValues(\"debug-check-for-implied-values\");\n+\n+\n+  cl::opt<double>\n+  MaxStaticForkPct(\"max-static-fork-pct\", \n+\t\t   cl::init(1.),\n+\t\t   cl::desc(\"(default=1.0)\"));\n+\n+  cl::opt<double>\n+  MaxStaticSolvePct(\"max-static-solve-pct\",\n+\t\t    cl::init(1.),\n+\t\t    cl::desc(\"(default=1.0)\"));\n+\n+  cl::opt<double>\n+  MaxStaticCPForkPct(\"max-static-cpfork-pct\", \n+\t\t     cl::init(1.),\n+\t\t     cl::desc(\"(default=1.0)\"));","path":"lib/Core/Executor.cpp","position":346,"original_position":346,"commit_id":"714840c938f466a78bc872a1b3b7df57ade3ab36","original_commit_id":"714840c938f466a78bc872a1b3b7df57ade3ab36","user":{"login":"MartinNowack","id":2443641,"node_id":"MDQ6VXNlcjI0NDM2NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2443641?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinNowack","html_url":"https://github.com/MartinNowack","followers_url":"https://api.github.com/users/MartinNowack/followers","following_url":"https://api.github.com/users/MartinNowack/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowack/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowack/subscriptions","organizations_url":"https://api.github.com/users/MartinNowack/orgs","repos_url":"https://api.github.com/users/MartinNowack/repos","events_url":"https://api.github.com/users/MartinNowack/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowack/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n      cl::desc(\"Set the maximum threshold for which at an instruction as part \"\r\n               \"of a call path can be forked over the forks of all \"\r\n               \"instructions. (default=1.0 (always)). Otherwise concretize.\"));\r\n```","created_at":"2018-12-18T12:48:38Z","updated_at":"2018-12-18T12:57:26Z","html_url":"https://github.com/klee/klee/pull/1024#discussion_r242523242","pull_request_url":"https://api.github.com/repos/klee/klee/pulls/1024","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/klee/klee/pulls/comments/242523242"},"html":{"href":"https://github.com/klee/klee/pull/1024#discussion_r242523242"},"pull_request":{"href":"https://api.github.com/repos/klee/klee/pulls/1024"}}},"pull_request":{"url":"https://api.github.com/repos/klee/klee/pulls/1024","id":239193975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTkzOTc1","html_url":"https://github.com/klee/klee/pull/1024","diff_url":"https://github.com/klee/klee/pull/1024.diff","patch_url":"https://github.com/klee/klee/pull/1024.patch","issue_url":"https://api.github.com/repos/klee/klee/issues/1024","number":1024,"state":"open","locked":false,"title":"Added categories for most options in Executor.cpp","user":{"login":"ccadar","id":5022313,"node_id":"MDQ6VXNlcjUwMjIzMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5022313?v=4","gravatar_id":"","url":"https://api.github.com/users/ccadar","html_url":"https://github.com/ccadar","followers_url":"https://api.github.com/users/ccadar/followers","following_url":"https://api.github.com/users/ccadar/following{/other_user}","gists_url":"https://api.github.com/users/ccadar/gists{/gist_id}","starred_url":"https://api.github.com/users/ccadar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccadar/subscriptions","organizations_url":"https://api.github.com/users/ccadar/orgs","repos_url":"https://api.github.com/users/ccadar/repos","events_url":"https://api.github.com/users/ccadar/events{/privacy}","received_events_url":"https://api.github.com/users/ccadar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-17T15:55:14Z","updated_at":"2018-12-18T12:57:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"400d1680a8ad7014403db226fc99b086e1f64b56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/klee/klee/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/klee/klee/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/klee/klee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/klee/klee/issues/1024/comments","statuses_url":"https://api.github.com/repos/klee/klee/statuses/714840c938f466a78bc872a1b3b7df57ade3ab36","head":{"label":"ccadar:categories","ref":"categories","sha":"714840c938f466a78bc872a1b3b7df57ade3ab36","user":{"login":"ccadar","id":5022313,"node_id":"MDQ6VXNlcjUwMjIzMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5022313?v=4","gravatar_id":"","url":"https://api.github.com/users/ccadar","html_url":"https://github.com/ccadar","followers_url":"https://api.github.com/users/ccadar/followers","following_url":"https://api.github.com/users/ccadar/following{/other_user}","gists_url":"https://api.github.com/users/ccadar/gists{/gist_id}","starred_url":"https://api.github.com/users/ccadar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccadar/subscriptions","organizations_url":"https://api.github.com/users/ccadar/orgs","repos_url":"https://api.github.com/users/ccadar/repos","events_url":"https://api.github.com/users/ccadar/events{/privacy}","received_events_url":"https://api.github.com/users/ccadar/received_events","type":"User","site_admin":false},"repo":{"id":72950657,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjk1MDY1Nw==","name":"klee","full_name":"ccadar/klee","private":false,"owner":{"login":"ccadar","id":5022313,"node_id":"MDQ6VXNlcjUwMjIzMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5022313?v=4","gravatar_id":"","url":"https://api.github.com/users/ccadar","html_url":"https://github.com/ccadar","followers_url":"https://api.github.com/users/ccadar/followers","following_url":"https://api.github.com/users/ccadar/following{/other_user}","gists_url":"https://api.github.com/users/ccadar/gists{/gist_id}","starred_url":"https://api.github.com/users/ccadar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccadar/subscriptions","organizations_url":"https://api.github.com/users/ccadar/orgs","repos_url":"https://api.github.com/users/ccadar/repos","events_url":"https://api.github.com/users/ccadar/events{/privacy}","received_events_url":"https://api.github.com/users/ccadar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ccadar/klee","description":"KLEE Symbolic Virtual Machine","fork":true,"url":"https://api.github.com/repos/ccadar/klee","forks_url":"https://api.github.com/repos/ccadar/klee/forks","keys_url":"https://api.github.com/repos/ccadar/klee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccadar/klee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccadar/klee/teams","hooks_url":"https://api.github.com/repos/ccadar/klee/hooks","issue_events_url":"https://api.github.com/repos/ccadar/klee/issues/events{/number}","events_url":"https://api.github.com/repos/ccadar/klee/events","assignees_url":"https://api.github.com/repos/ccadar/klee/assignees{/user}","branches_url":"https://api.github.com/repos/ccadar/klee/branches{/branch}","tags_url":"https://api.github.com/repos/ccadar/klee/tags","blobs_url":"https://api.github.com/repos/ccadar/klee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccadar/klee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccadar/klee/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccadar/klee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccadar/klee/statuses/{sha}","languages_url":"https://api.github.com/repos/ccadar/klee/languages","stargazers_url":"https://api.github.com/repos/ccadar/klee/stargazers","contributors_url":"https://api.github.com/repos/ccadar/klee/contributors","subscribers_url":"https://api.github.com/repos/ccadar/klee/subscribers","subscription_url":"https://api.github.com/repos/ccadar/klee/subscription","commits_url":"https://api.github.com/repos/ccadar/klee/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccadar/klee/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccadar/klee/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccadar/klee/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccadar/klee/contents/{+path}","compare_url":"https://api.github.com/repos/ccadar/klee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccadar/klee/merges","archive_url":"https://api.github.com/repos/ccadar/klee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccadar/klee/downloads","issues_url":"https://api.github.com/repos/ccadar/klee/issues{/number}","pulls_url":"https://api.github.com/repos/ccadar/klee/pulls{/number}","milestones_url":"https://api.github.com/repos/ccadar/klee/milestones{/number}","notifications_url":"https://api.github.com/repos/ccadar/klee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccadar/klee/labels{/name}","releases_url":"https://api.github.com/repos/ccadar/klee/releases{/id}","deployments_url":"https://api.github.com/repos/ccadar/klee/deployments","created_at":"2016-11-05T20:11:32Z","updated_at":"2018-12-17T14:46:33Z","pushed_at":"2018-12-17T15:52:33Z","git_url":"git://github.com/ccadar/klee.git","ssh_url":"git@github.com:ccadar/klee.git","clone_url":"https://github.com/ccadar/klee.git","svn_url":"https://github.com/ccadar/klee","homepage":"http://klee.llvm.org","size":5917,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"klee:master","ref":"master","sha":"124f8f688cfaa0c8ef8321d86064af216bb0e406","user":{"login":"klee","id":6224192,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjQxOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/6224192?v=4","gravatar_id":"","url":"https://api.github.com/users/klee","html_url":"https://github.com/klee","followers_url":"https://api.github.com/users/klee/followers","following_url":"https://api.github.com/users/klee/following{/other_user}","gists_url":"https://api.github.com/users/klee/gists{/gist_id}","starred_url":"https://api.github.com/users/klee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klee/subscriptions","organizations_url":"https://api.github.com/users/klee/orgs","repos_url":"https://api.github.com/users/klee/repos","events_url":"https://api.github.com/users/klee/events{/privacy}","received_events_url":"https://api.github.com/users/klee/received_events","type":"Organization","site_admin":false},"repo":{"id":11568417,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU2ODQxNw==","name":"klee","full_name":"klee/klee","private":false,"owner":{"login":"klee","id":6224192,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjQxOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/6224192?v=4","gravatar_id":"","url":"https://api.github.com/users/klee","html_url":"https://github.com/klee","followers_url":"https://api.github.com/users/klee/followers","following_url":"https://api.github.com/users/klee/following{/other_user}","gists_url":"https://api.github.com/users/klee/gists{/gist_id}","starred_url":"https://api.github.com/users/klee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klee/subscriptions","organizations_url":"https://api.github.com/users/klee/orgs","repos_url":"https://api.github.com/users/klee/repos","events_url":"https://api.github.com/users/klee/events{/privacy}","received_events_url":"https://api.github.com/users/klee/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/klee/klee","description":"KLEE Symbolic Execution Engine","fork":false,"url":"https://api.github.com/repos/klee/klee","forks_url":"https://api.github.com/repos/klee/klee/forks","keys_url":"https://api.github.com/repos/klee/klee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klee/klee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klee/klee/teams","hooks_url":"https://api.github.com/repos/klee/klee/hooks","issue_events_url":"https://api.github.com/repos/klee/klee/issues/events{/number}","events_url":"https://api.github.com/repos/klee/klee/events","assignees_url":"https://api.github.com/repos/klee/klee/assignees{/user}","branches_url":"https://api.github.com/repos/klee/klee/branches{/branch}","tags_url":"https://api.github.com/repos/klee/klee/tags","blobs_url":"https://api.github.com/repos/klee/klee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klee/klee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klee/klee/git/refs{/sha}","trees_url":"https://api.github.com/repos/klee/klee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klee/klee/statuses/{sha}","languages_url":"https://api.github.com/repos/klee/klee/languages","stargazers_url":"https://api.github.com/repos/klee/klee/stargazers","contributors_url":"https://api.github.com/repos/klee/klee/contributors","subscribers_url":"https://api.github.com/repos/klee/klee/subscribers","subscription_url":"https://api.github.com/repos/klee/klee/subscription","commits_url":"https://api.github.com/repos/klee/klee/commits{/sha}","git_commits_url":"https://api.github.com/repos/klee/klee/git/commits{/sha}","comments_url":"https://api.github.com/repos/klee/klee/comments{/number}","issue_comment_url":"https://api.github.com/repos/klee/klee/issues/comments{/number}","contents_url":"https://api.github.com/repos/klee/klee/contents/{+path}","compare_url":"https://api.github.com/repos/klee/klee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klee/klee/merges","archive_url":"https://api.github.com/repos/klee/klee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klee/klee/downloads","issues_url":"https://api.github.com/repos/klee/klee/issues{/number}","pulls_url":"https://api.github.com/repos/klee/klee/pulls{/number}","milestones_url":"https://api.github.com/repos/klee/klee/milestones{/number}","notifications_url":"https://api.github.com/repos/klee/klee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klee/klee/labels{/name}","releases_url":"https://api.github.com/repos/klee/klee/releases{/id}","deployments_url":"https://api.github.com/repos/klee/klee/deployments","created_at":"2013-07-21T22:03:03Z","updated_at":"2018-12-17T09:18:50Z","pushed_at":"2018-12-17T22:43:37Z","git_url":"git://github.com/klee/klee.git","ssh_url":"git@github.com:klee/klee.git","clone_url":"https://github.com/klee/klee.git","svn_url":"https://github.com/klee/klee","homepage":"http://klee.github.io/","size":5913,"stargazers_count":993,"watchers_count":993,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":327,"open_issues":131,"watchers":993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/klee/klee/pulls/1024"},"html":{"href":"https://github.com/klee/klee/pull/1024"},"issue":{"href":"https://api.github.com/repos/klee/klee/issues/1024"},"comments":{"href":"https://api.github.com/repos/klee/klee/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/klee/klee/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/klee/klee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/klee/klee/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/klee/klee/statuses/714840c938f466a78bc872a1b3b7df57ade3ab36"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MartinNowack"}}