{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/vsc-install/pulls/comments/187561205","pull_request_review_id":119364773,"id":187561205,"diff_hunk":"@@ -170,7 +176,12 @@ def test_prepare_rpm(self):\n         setup = vsc_setup()\n         setup.REPO_LIB_DIR = libdir\n         setup.prepare_rpm(package)\n-        self.assertEqual(setup.SHARED_TARGET['packages'], ['vsc', 'vsc.test'])\n+\n+        # Generate list of packages, sorted\n+        package_list = list(setup.SHARED_TARGET['packages'])\n+        package_list.sort()\n+\n+        self.assertEqual(package_list, ['vsc', 'vsc.test'])","path":"test/shared_setup.py","position":55,"original_position":69,"commit_id":"a5b3a5ee0e6d9b67972c1b629f7254b764926d67","original_commit_id":"a5b3a5ee0e6d9b67972c1b629f7254b764926d67","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"Same here, more straightforward (imho) change:\r\n\r\n```python\r\nself.assertEqual(sorted(setup.SHARED_TARGET['packages']), ['vsc', 'vsc.test'])\r\n```","created_at":"2018-05-11T09:11:28Z","updated_at":"2018-05-11T09:25:32Z","html_url":"https://github.com/hpcugent/vsc-install/pull/83#discussion_r187561205","pull_request_url":"https://api.github.com/repos/hpcugent/vsc-install/pulls/83","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-install/pulls/comments/187561205"},"html":{"href":"https://github.com/hpcugent/vsc-install/pull/83#discussion_r187561205"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/vsc-install/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/vsc-install/pulls/83","id":187006870,"html_url":"https://github.com/hpcugent/vsc-install/pull/83","diff_url":"https://github.com/hpcugent/vsc-install/pull/83.diff","patch_url":"https://github.com/hpcugent/vsc-install/pull/83.patch","issue_url":"https://api.github.com/repos/hpcugent/vsc-install/issues/83","number":83,"state":"open","locked":false,"title":"minimal tweaks to update for python3","user":{"login":"vsoch","id":814322,"avatar_url":"https://avatars0.githubusercontent.com/u/814322?v=4","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"body":"This PR includes minimal changes to update to Python three. In summary, this largely includes:\r\n\r\n - adjusting print statements to use two parenthesis\r\n - choosing to try --> import --> except --> fallback in favor of using larger libraries like six. This included:\r\n   - import of cStringio from io\r\n   - using str instead of basestring\r\n   - __bulletin__ is bulletins in python 3\r\n\r\nThere were also a couple of instances of popping items from dictionaries while they were being iterated over, and I changed this to create a copy and then simply not add entries that would be removed. I also changed some of the file reading patterns to go from:\r\n\r\n```\r\ncontent = open(filename).read()\r\n```\r\n\r\nto more of:\r\n\r\n```\r\nwith open(filename) as filey:\r\n     content = filey.read()\r\n```\r\n\r\nI'm not sure how everything is working together, but to test I did:\r\n\r\n```\r\npython setup.py test\r\n```\r\nand there were many issues with pylint not closing a file, but I believe that's out of our control here? The tests, as run above, pass with these tiny changes. I'm going to move over to the other repo vsc-base and see what kind of issues I run into now that I have vsc installed! I'll update here if necessary.","created_at":"2018-05-09T18:45:17Z","updated_at":"2018-05-11T09:25:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0455fe14b128b836ad939011c932f6472f21f9a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/vsc-install/pulls/83/commits","review_comments_url":"https://api.github.com/repos/hpcugent/vsc-install/pulls/83/comments","review_comment_url":"https://api.github.com/repos/hpcugent/vsc-install/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/vsc-install/issues/83/comments","statuses_url":"https://api.github.com/repos/hpcugent/vsc-install/statuses/a5b3a5ee0e6d9b67972c1b629f7254b764926d67","head":{"label":"vsoch:update/python3","ref":"update/python3","sha":"a5b3a5ee0e6d9b67972c1b629f7254b764926d67","user":{"login":"vsoch","id":814322,"avatar_url":"https://avatars0.githubusercontent.com/u/814322?v=4","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"repo":{"id":132787005,"name":"vsc-install","full_name":"vsoch/vsc-install","owner":{"login":"vsoch","id":814322,"avatar_url":"https://avatars0.githubusercontent.com/u/814322?v=4","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vsoch/vsc-install","description":"Shared setuptools functions and classes for python libraries developed by UGent's HPC group","fork":true,"url":"https://api.github.com/repos/vsoch/vsc-install","forks_url":"https://api.github.com/repos/vsoch/vsc-install/forks","keys_url":"https://api.github.com/repos/vsoch/vsc-install/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vsoch/vsc-install/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vsoch/vsc-install/teams","hooks_url":"https://api.github.com/repos/vsoch/vsc-install/hooks","issue_events_url":"https://api.github.com/repos/vsoch/vsc-install/issues/events{/number}","events_url":"https://api.github.com/repos/vsoch/vsc-install/events","assignees_url":"https://api.github.com/repos/vsoch/vsc-install/assignees{/user}","branches_url":"https://api.github.com/repos/vsoch/vsc-install/branches{/branch}","tags_url":"https://api.github.com/repos/vsoch/vsc-install/tags","blobs_url":"https://api.github.com/repos/vsoch/vsc-install/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vsoch/vsc-install/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vsoch/vsc-install/git/refs{/sha}","trees_url":"https://api.github.com/repos/vsoch/vsc-install/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vsoch/vsc-install/statuses/{sha}","languages_url":"https://api.github.com/repos/vsoch/vsc-install/languages","stargazers_url":"https://api.github.com/repos/vsoch/vsc-install/stargazers","contributors_url":"https://api.github.com/repos/vsoch/vsc-install/contributors","subscribers_url":"https://api.github.com/repos/vsoch/vsc-install/subscribers","subscription_url":"https://api.github.com/repos/vsoch/vsc-install/subscription","commits_url":"https://api.github.com/repos/vsoch/vsc-install/commits{/sha}","git_commits_url":"https://api.github.com/repos/vsoch/vsc-install/git/commits{/sha}","comments_url":"https://api.github.com/repos/vsoch/vsc-install/comments{/number}","issue_comment_url":"https://api.github.com/repos/vsoch/vsc-install/issues/comments{/number}","contents_url":"https://api.github.com/repos/vsoch/vsc-install/contents/{+path}","compare_url":"https://api.github.com/repos/vsoch/vsc-install/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vsoch/vsc-install/merges","archive_url":"https://api.github.com/repos/vsoch/vsc-install/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vsoch/vsc-install/downloads","issues_url":"https://api.github.com/repos/vsoch/vsc-install/issues{/number}","pulls_url":"https://api.github.com/repos/vsoch/vsc-install/pulls{/number}","milestones_url":"https://api.github.com/repos/vsoch/vsc-install/milestones{/number}","notifications_url":"https://api.github.com/repos/vsoch/vsc-install/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vsoch/vsc-install/labels{/name}","releases_url":"https://api.github.com/repos/vsoch/vsc-install/releases{/id}","deployments_url":"https://api.github.com/repos/vsoch/vsc-install/deployments","created_at":"2018-05-09T16:51:07Z","updated_at":"2018-05-09T16:51:10Z","pushed_at":"2018-05-10T07:55:19Z","git_url":"git://github.com/vsoch/vsc-install.git","ssh_url":"git@github.com:vsoch/vsc-install.git","clone_url":"https://github.com/vsoch/vsc-install.git","svn_url":"https://github.com/vsoch/vsc-install","homepage":null,"size":360,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:master","ref":"master","sha":"2ed32939c986a9316e780e65af6e5d7e1d8743d0","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars0.githubusercontent.com/u/1515263?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":44304014,"name":"vsc-install","full_name":"hpcugent/vsc-install","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars0.githubusercontent.com/u/1515263?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/vsc-install","description":"Shared setuptools functions and classes for python libraries developed by UGent's HPC group","fork":false,"url":"https://api.github.com/repos/hpcugent/vsc-install","forks_url":"https://api.github.com/repos/hpcugent/vsc-install/forks","keys_url":"https://api.github.com/repos/hpcugent/vsc-install/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/vsc-install/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/vsc-install/teams","hooks_url":"https://api.github.com/repos/hpcugent/vsc-install/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/vsc-install/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/vsc-install/events","assignees_url":"https://api.github.com/repos/hpcugent/vsc-install/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/vsc-install/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/vsc-install/tags","blobs_url":"https://api.github.com/repos/hpcugent/vsc-install/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/vsc-install/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/vsc-install/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/vsc-install/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/vsc-install/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/vsc-install/languages","stargazers_url":"https://api.github.com/repos/hpcugent/vsc-install/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/vsc-install/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/vsc-install/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/vsc-install/subscription","commits_url":"https://api.github.com/repos/hpcugent/vsc-install/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/vsc-install/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/vsc-install/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/vsc-install/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/vsc-install/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/vsc-install/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/vsc-install/merges","archive_url":"https://api.github.com/repos/hpcugent/vsc-install/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/vsc-install/downloads","issues_url":"https://api.github.com/repos/hpcugent/vsc-install/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/vsc-install/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/vsc-install/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/vsc-install/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/vsc-install/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/vsc-install/releases{/id}","deployments_url":"https://api.github.com/repos/hpcugent/vsc-install/deployments","created_at":"2015-10-15T08:30:59Z","updated_at":"2017-07-12T14:37:29Z","pushed_at":"2018-05-10T07:55:21Z","git_url":"git://github.com/hpcugent/vsc-install.git","ssh_url":"git@github.com:hpcugent/vsc-install.git","clone_url":"https://github.com/hpcugent/vsc-install.git","svn_url":"https://github.com/hpcugent/vsc-install","homepage":null,"size":349,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-install/pulls/83"},"html":{"href":"https://github.com/hpcugent/vsc-install/pull/83"},"issue":{"href":"https://api.github.com/repos/hpcugent/vsc-install/issues/83"},"comments":{"href":"https://api.github.com/repos/hpcugent/vsc-install/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/vsc-install/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/vsc-install/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/vsc-install/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/vsc-install/statuses/a5b3a5ee0e6d9b67972c1b629f7254b764926d67"}},"author_association":"NONE"}}
{"actor":{"display_login":"boegel"}}