{"action":"created","issue":{"url":"https://api.github.com/repos/qTox/qTox/issues/5160","repository_url":"https://api.github.com/repos/qTox/qTox","labels_url":"https://api.github.com/repos/qTox/qTox/issues/5160/labels{/name}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/5160/comments","events_url":"https://api.github.com/repos/qTox/qTox/issues/5160/events","html_url":"https://github.com/qTox/qTox/pull/5160","id":327521694,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjk1OTA4","number":5160,"title":"refactor(themes): load css and images from themes folder","user":{"login":"tox-user","id":32248732,"node_id":"MDQ6VXNlcjMyMjQ4NzMy","avatar_url":"https://avatars1.githubusercontent.com/u/32248732?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-user","html_url":"https://github.com/tox-user","followers_url":"https://api.github.com/users/tox-user/followers","following_url":"https://api.github.com/users/tox-user/following{/other_user}","gists_url":"https://api.github.com/users/tox-user/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-user/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-user/subscriptions","organizations_url":"https://api.github.com/users/tox-user/orgs","repos_url":"https://api.github.com/users/tox-user/repos","events_url":"https://api.github.com/users/tox-user/events{/privacy}","received_events_url":"https://api.github.com/users/tox-user/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2018-05-29T23:28:25Z","updated_at":"2018-06-20T15:47:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/qTox/qTox/pulls/5160","html_url":"https://github.com/qTox/qTox/pull/5160","diff_url":"https://github.com/qTox/qTox/pull/5160.diff","patch_url":"https://github.com/qTox/qTox/pull/5160.patch"},"body":"The default theme is now placed in 'themes' folder in addition to being included\r\nas a resource. That means:\r\n- modifying css files doesn't require recompiling the program anymore\r\n- users can now easily modify the existing theme\r\n- whenever there is a style sheet or image file missing (for example deleted by user),\r\nit will be loaded from the default theme that is included as a resource\r\n\r\nThis is a first of many future changes to make it possible to create themes.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/qtox/qtox/5160)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/qTox/qTox/issues/comments/398799428","html_url":"https://github.com/qTox/qTox/pull/5160#issuecomment-398799428","issue_url":"https://api.github.com/repos/qTox/qTox/issues/5160","id":398799428,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODc5OTQyOA==","user":{"login":"sudden6","id":5585762,"node_id":"MDQ6VXNlcjU1ODU3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5585762?v=4","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T15:47:47Z","updated_at":"2018-06-20T15:47:47Z","author_association":"MEMBER","body":">  it does matter because I hardcoded those paths in cmake\r\n\r\nGood that you bring that up again, I missed it the first time reviewing...\r\n\r\nThis: `C:\\\\users\\\\%username%\\\\AppData\\\\roaming\\\\qtox)` is really bad. There's no guarantee the path to the \"home\" directory is `users\\<username>\\`, it could even not be on `C:\\` and then this breaks a lot of stuff. We have to use environment variables for this too. Like `%appdata%`, that's what they are for.\r\n\r\nAlso I just now noticed, that for shipped themes to work, you have to update the windows installer scripts too."}}
{"actor":{"display_login":"sudden6"}}