{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/19447","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/19447/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19447/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/19447/events","html_url":"https://github.com/nodejs/node/pull/19447","id":306519161,"number":19447,"title":"[6.x] n-api: backport to v6.x","user":{"login":"gabrielschulhof","id":976081,"avatar_url":"https://avatars2.githubusercontent.com/u/976081?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":574036893,"url":"https://api.github.com/repos/nodejs/node/labels/n-api","name":"n-api","color":"d93f0b","default":false},{"id":169485478,"url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false},{"id":364835500,"url":"https://api.github.com/repos/nodejs/node/labels/v6.x","name":"v6.x","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-19T15:46:43Z","updated_at":"2018-03-20T02:00:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19447","html_url":"https://github.com/nodejs/node/pull/19447","diff_url":"https://github.com/nodejs/node/pull/19447.diff","patch_url":"https://github.com/nodejs/node/pull/19447.patch"},"body":"* src/node_api_backport.cc and src/node_api_backport.h are added\r\ncontaining stubs for internal APIs used by N-API.\r\n\r\n* expectsError() is brought in from master and added to\r\ntests/common/index.js.\r\n\r\n* N-API tests involving the JS async_hooks module are removed.\r\n\r\n* The following commits are partially or completely applied:\r\n\r\nf24d0ec201 6a5a9ad62d d20f1f004c 5fb6f7f22f cd7d7b15c1 a03c90b661\r\n33e63fe64f 48b5c11b16 35c7238bb7 d83f8303fd 449d1c8ea4 c698017a2f\r\na29089d7c8 9cb96ac828 945eb1bb69 6e1c25c456 463d1a490f caee112e52\r\n755e07cb73 a1bab826c4 2bead4ba9e 1729af2ce9 fe442f6b5f d3569b623c\r\n5ecd2e15b8 6101bd209e d379db31fd a555397185 c2b9048ac8 629a4476f0\r\n47f664ee88 1286923cc0 0c16b18043 6e312c5cc7 6c1906ab3e c1234673bb\r\nf054855bbf f7c709fdd0 c90185c15e 316b5efd6b f75bc2c1a5 3e062762e4\r\n8938c4c22d 91c1ccd84f 8a86d9c1cf 93acfe55db 094d92bb57 94e29510d9\r\n246aeaca1e a893e79a69 ef49f55e93 d4cd8c2a77 50afd901ea 2475676995\r\nff9a6bc1f3 12c8b4d154 dc389bf7cc 493340f56e 8f2c366bb2 a4a9a3de6e\r\n9cf3525535 97ba69f915 959c425a19 9b4ab1452d 51f92b6fff e0b1394cb0\r\n3ee524b14c f2cb78c4e7 e04d23c1fd 2336df1b50 0736ad4743 201ecef767\r\ne07e708102 7be4a84c66 b3f9b38174 6bc82daef0 a1c080410c f88178906b\r\n3594223c2e 17b818bae4 49577269e2 b33b3e1838 84579b1d7d e6e58fde8b\r\ncec6e21668 05e4c1d6bc 8b902500cd a406a32ee9 3070d53e31 a8c0a43a22\r\n19766547fa 973c12f631 0c258bdc40 92e5f5cc09 1a0727d85e 8c8c90b714\r\n290315ace7 cb94905774 a10856a7d3 61e9ba1271 78286984da 1cdb41f287\r\nc77e6d3f8c 7efb8f7619 6c382dea6b 82bad0b4d8 70664bf5a1 e96b94970a\r\n1fe0741e50 85d7d97d81 e6eb5c00da 835c383969 b72e702247 af70c3b478\r\nad664eae7d f3afe29e19 6968eadc3f aa6fac68da 77ca3cb474 9926dfebc8\r\n7849b52810 e59987c39e 57a4cebbd5 4d1e0862ce bb29405904 65eefa0105\r\ne3f7a54d0a 73078d6072 ac41db4af0 598a128ff4 f52c707853 d5b397c9b6\r\n8f3dab4b63 9c6804c1df 29df1a87fa 34cf8ad73d e36917bdc1 c9b6d95161\r\nea927b3711 732ae419b4 f803e77b1e 0f1888f313 a71d20518a ef28d85611\r\n3e18c49657 d2913384aa ecf6a46d98 62e940dfa6 ca8a29c360 2529119680\r\n01f4d9af5e c28418a9e5 df46fcb61a 7d9dfdaea3 ddba969321 bd4b79051a\r\n062071a9c3 7a7ac1c6db 8ab8c33985 fd54b10500 bb91879f31 43e4efdf21\r\neffeff1843 d9ee297afb 196190015d 2af49b6c89 260cd411d4 47919b3b6f\r\nf3ef9719b5 bfade5aacd 4a7b7e8097 a63b245b0a 0dd8b9a965 008301167e\r\n47c3c58704 1b28022de0 9516aa19c1 abfd4bf9df 654afa2c19 147048a0d3\r\n2e3fef7628 2bbabb1f85 0a734fec88 73d9c0f903 94a120cf65 8aca66a1f3\r\ncd32b77567 a180259e42 0142276977 deb9622b11 972bfe1514 427125491f\r\n1d968030d4 4241577112 b7a341d7e5 ba7bac5c37 468275ac79 6c606916db\r\n70b51c8cc3 9d522225e7 46f202690b ad5f987558 8bd26d3aea 9de2e159c4\r\n0ec0272e10 affe0f2d2a 9decfb1521 ca786c3734 afd5966fa9 8fbace163a\r\n84602845c6 0a5bf4aee3 491d59da84 4a21e398d6 56e881d0b0\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/374446733","html_url":"https://github.com/nodejs/node/pull/19447#issuecomment-374446733","issue_url":"https://api.github.com/repos/nodejs/node/issues/19447","id":374446733,"user":{"login":"gabrielschulhof","id":976081,"avatar_url":"https://avatars2.githubusercontent.com/u/976081?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T02:00:47Z","updated_at":"2018-03-20T02:00:47Z","author_association":"CONTRIBUTOR","body":"To that end I've actually tested the following sequence:\n\n```\ngit checkout v6.x-backport-n-api\ngit clean -x -d -f -f\n./configure\nmake -j4\nmake -j4 test-addons-napi\ngit checkout v8.x-backport-n-api-updated-squashed\n./configure\nmake -j4\n/usr/bin/python2.7 tools/test.py --mode=release addons-napi\ngit checkout master\n./configure\nmake -j4\n/usr/bin/python2.7 tools/test.py --mode=release addons-napi\n```\n\n... and I've found it to work. That is, test/addons-napi can be run without\nrebuilding.\n\nOn Mon, Mar 19, 2018 at 9:57 PM, Schulhof, Gabriel <\ngabriel.schulhof@intel.com> wrote:\n\n> ... and binary compatible in all three, of course!\n>\n> On Mon, Mar 19, 2018 at 9:56 PM, Schulhof, Gabriel <\n> gabriel.schulhof@intel.com> wrote:\n>\n>> Our hope is to be able to claim, when 10.0.0 arrives, that N-API is now\n>> stable in the latest of each of 6.x, 8.x, and 10.x.\n>>\n>> On Mon, Mar 19, 2018 at 9:54 PM, Schulhof, Gabriel <\n>> gabriel.schulhof@intel.com> wrote:\n>>\n>>> The experimental flag is not in place in this patch. It captures the\n>>> full circle of having it in, and then having it removed.\n>>>\n>>> On Mon, Mar 19, 2018 at 9:30 PM, Myles Borins <notifications@github.com>\n>>> wrote:\n>>>\n>>>> @gabrielschulhof <https://github.com/gabrielschulhof> great work. Is\n>>>> this landed with the experimental flag in place? We may want to consider\n>>>> doing a semver minor for this... not 100%. We were not planning another\n>>>> minor for 6.x before it went into maintenance mode though\n>>>>\n>>>> /cc @nodejs/lts <https://github.com/orgs/nodejs/teams/lts>, thoughts?\n>>>>\n>>>> —\n>>>> You are receiving this because you were mentioned.\n>>>> Reply to this email directly, view it on GitHub\n>>>> <https://github.com/nodejs/node/pull/19447#issuecomment-374441301>, or mute\n>>>> the thread\n>>>> <https://github.com/notifications/unsubscribe-auth/AA7k0TXggTNRk5Bk0u7kKq6HSKoLYgNbks5tgFufgaJpZM4SwaB6>\n>>>> .\n>>>>\n>>>\n>>>\n>>\n>\n"}}
{"actor":{"display_login":"gabrielschulhof"}}