{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/status-im/react-native-keychain/pulls/6","id":239174358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTc0MzU4","html_url":"https://github.com/status-im/react-native-keychain/pull/6","diff_url":"https://github.com/status-im/react-native-keychain/pull/6.diff","patch_url":"https://github.com/status-im/react-native-keychain/pull/6.patch","issue_url":"https://api.github.com/repos/status-im/react-native-keychain/issues/6","number":6,"state":"closed","locked":false,"title":"Minimal security guarantees for react-native-keychain","user":{"login":"mandrigin","id":466427,"node_id":"MDQ6VXNlcjQ2NjQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},"body":"Supported security levels:\r\n- ANY\r\n- SECURE_SOFTWARE\r\n- SECURE_HARDWARE (TEE or SE guarantees).\r\n\r\n(1) Add `getSecurityLevel()` API that returns which security level is\r\nsupported on this Android version and the specific device.\r\n\r\n(2) For APIs that store credentials, an additional optional parameter was added\r\nthat fails storing the credentials if the security level is not what is\r\nexpected.\r\n\r\n```\r\n// Store the credentials.\r\n// Will fail if Keychain can't guarantee at least SECURE_HARDWARE level of encryption key.\r\nawait Keychain.setGenericPassword(username, password, Keychain.SECURITY_LEVEL.SECURE_HARDWARE);\r\n```\r\n\r\n(3) StongBox support on Android 9+ (and supported devices [Pixel 3]).","created_at":"2018-12-17T15:00:38Z","updated_at":"2018-12-19T08:11:11Z","closed_at":"2018-12-19T08:11:10Z","merged_at":"2018-12-19T08:11:10Z","merge_commit_sha":"43e5512cabb8ee064fd9e503be943dcf2c7d7669","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/react-native-keychain/pulls/6/commits","review_comments_url":"https://api.github.com/repos/status-im/react-native-keychain/pulls/6/comments","review_comment_url":"https://api.github.com/repos/status-im/react-native-keychain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/react-native-keychain/issues/6/comments","statuses_url":"https://api.github.com/repos/status-im/react-native-keychain/statuses/1af7a0ff8304717899892c18344d11c16b3b8b71","head":{"label":"status-im:feature/minimum-security-guarantee","ref":"feature/minimum-security-guarantee","sha":"1af7a0ff8304717899892c18344d11c16b3b8b71","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":138318574,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMTg1NzQ=","name":"react-native-keychain","full_name":"status-im/react-native-keychain","private":false,"owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/status-im/react-native-keychain","description":":key: Keychain Access for React Native","fork":true,"url":"https://api.github.com/repos/status-im/react-native-keychain","forks_url":"https://api.github.com/repos/status-im/react-native-keychain/forks","keys_url":"https://api.github.com/repos/status-im/react-native-keychain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/react-native-keychain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/react-native-keychain/teams","hooks_url":"https://api.github.com/repos/status-im/react-native-keychain/hooks","issue_events_url":"https://api.github.com/repos/status-im/react-native-keychain/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/react-native-keychain/events","assignees_url":"https://api.github.com/repos/status-im/react-native-keychain/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/react-native-keychain/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/react-native-keychain/tags","blobs_url":"https://api.github.com/repos/status-im/react-native-keychain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/react-native-keychain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/react-native-keychain/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/react-native-keychain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/react-native-keychain/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/react-native-keychain/languages","stargazers_url":"https://api.github.com/repos/status-im/react-native-keychain/stargazers","contributors_url":"https://api.github.com/repos/status-im/react-native-keychain/contributors","subscribers_url":"https://api.github.com/repos/status-im/react-native-keychain/subscribers","subscription_url":"https://api.github.com/repos/status-im/react-native-keychain/subscription","commits_url":"https://api.github.com/repos/status-im/react-native-keychain/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/react-native-keychain/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/react-native-keychain/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/react-native-keychain/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/react-native-keychain/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/react-native-keychain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/react-native-keychain/merges","archive_url":"https://api.github.com/repos/status-im/react-native-keychain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/react-native-keychain/downloads","issues_url":"https://api.github.com/repos/status-im/react-native-keychain/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/react-native-keychain/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/react-native-keychain/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/react-native-keychain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/react-native-keychain/labels{/name}","releases_url":"https://api.github.com/repos/status-im/react-native-keychain/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/react-native-keychain/deployments","created_at":"2018-06-22T15:26:00Z","updated_at":"2018-10-25T18:35:56Z","pushed_at":"2018-12-19T08:11:10Z","git_url":"git://github.com/status-im/react-native-keychain.git","ssh_url":"git@github.com:status-im/react-native-keychain.git","clone_url":"https://github.com/status-im/react-native-keychain.git","svn_url":"https://github.com/status-im/react-native-keychain","homepage":"","size":581,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"status-im:master","ref":"master","sha":"ea1bfe6b803ab712d6009a40267db820ce2ec2cd","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":138318574,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMTg1NzQ=","name":"react-native-keychain","full_name":"status-im/react-native-keychain","private":false,"owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/status-im/react-native-keychain","description":":key: Keychain Access for React Native","fork":true,"url":"https://api.github.com/repos/status-im/react-native-keychain","forks_url":"https://api.github.com/repos/status-im/react-native-keychain/forks","keys_url":"https://api.github.com/repos/status-im/react-native-keychain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/react-native-keychain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/react-native-keychain/teams","hooks_url":"https://api.github.com/repos/status-im/react-native-keychain/hooks","issue_events_url":"https://api.github.com/repos/status-im/react-native-keychain/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/react-native-keychain/events","assignees_url":"https://api.github.com/repos/status-im/react-native-keychain/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/react-native-keychain/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/react-native-keychain/tags","blobs_url":"https://api.github.com/repos/status-im/react-native-keychain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/react-native-keychain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/react-native-keychain/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/react-native-keychain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/react-native-keychain/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/react-native-keychain/languages","stargazers_url":"https://api.github.com/repos/status-im/react-native-keychain/stargazers","contributors_url":"https://api.github.com/repos/status-im/react-native-keychain/contributors","subscribers_url":"https://api.github.com/repos/status-im/react-native-keychain/subscribers","subscription_url":"https://api.github.com/repos/status-im/react-native-keychain/subscription","commits_url":"https://api.github.com/repos/status-im/react-native-keychain/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/react-native-keychain/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/react-native-keychain/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/react-native-keychain/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/react-native-keychain/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/react-native-keychain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/react-native-keychain/merges","archive_url":"https://api.github.com/repos/status-im/react-native-keychain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/react-native-keychain/downloads","issues_url":"https://api.github.com/repos/status-im/react-native-keychain/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/react-native-keychain/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/react-native-keychain/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/react-native-keychain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/react-native-keychain/labels{/name}","releases_url":"https://api.github.com/repos/status-im/react-native-keychain/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/react-native-keychain/deployments","created_at":"2018-06-22T15:26:00Z","updated_at":"2018-10-25T18:35:56Z","pushed_at":"2018-12-19T08:11:10Z","git_url":"git://github.com/status-im/react-native-keychain.git","ssh_url":"git@github.com:status-im/react-native-keychain.git","clone_url":"https://github.com/status-im/react-native-keychain.git","svn_url":"https://github.com/status-im/react-native-keychain","homepage":"","size":581,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/react-native-keychain/pulls/6"},"html":{"href":"https://github.com/status-im/react-native-keychain/pull/6"},"issue":{"href":"https://api.github.com/repos/status-im/react-native-keychain/issues/6"},"comments":{"href":"https://api.github.com/repos/status-im/react-native-keychain/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/react-native-keychain/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/react-native-keychain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/react-native-keychain/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/react-native-keychain/statuses/1af7a0ff8304717899892c18344d11c16b3b8b71"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mandrigin","id":466427,"node_id":"MDQ6VXNlcjQ2NjQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":7,"additions":286,"deletions":55,"changed_files":9}}
{"actor":{"display_login":"mandrigin"}}