{"action":"closed","number":5006,"pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/5006","id":198448524,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDQ4NTI0","html_url":"https://github.com/status-im/status-react/pull/5006","diff_url":"https://github.com/status-im/status-react/pull/5006.diff","patch_url":"https://github.com/status-im/status-react/pull/5006.patch","issue_url":"https://api.github.com/repos/status-im/status-react/issues/5006","number":5006,"state":"closed","locked":false,"title":"Preset keychain username on desktop","user":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"body":"### Summary:\r\n\r\nOn Linux underlying keychain records access requires username (on macOS it works fine without passing of username). PR unifies access to keychain both for macOS and linux systems.\r\n\r\n### Overview and steps to test:\r\n\r\nBoth macOS and linux builds affected. username key is used additionally to access keychain to get db encryption keys.\r\n\r\nTesting on mac:\r\nAt least creation of new database and further logins into the app should work fine. (Compatibility with older db openning might be broken, because new path to new encryption key probably is used)\r\n\r\nTesting on linux:\r\nSince used underlying qtkeychain library supports gnome-keyring or kwallet keychains it requires to have installed components of supported keychains.\r\n\r\ngnome-keyring usage has priority under kwallet if both are installed.\r\n\r\ngnome-keyring requires additionally package `libgnome-keyring0` installed on linux system.\r\nkwallet setup instructions can be found there https://askubuntu.com/a/913594\r\n\r\n### Status: ready\r\n\r\n\r\n","created_at":"2018-06-30T00:07:30Z","updated_at":"2018-07-05T20:44:17Z","closed_at":"2018-07-05T20:44:17Z","merged_at":"2018-07-05T20:44:17Z","merge_commit_sha":"a190e7db99809c5b3510fe69609a75b58fa4fc8b","assignee":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"assignees":[{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":782926578,"node_id":"MDU6TGFiZWw3ODI5MjY1Nzg=","url":"https://api.github.com/repos/status-im/status-react/labels/desktop","name":"desktop","color":"fcb099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-react/pulls/5006/commits","review_comments_url":"https://api.github.com/repos/status-im/status-react/pulls/5006/comments","review_comment_url":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/5006/comments","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/a190e7db99809c5b3510fe69609a75b58fa4fc8b","head":{"label":"MaxRis:bug/linux-startup-error","ref":"bug/linux-startup-error","sha":"a190e7db99809c5b3510fe69609a75b58fa4fc8b","user":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"repo":{"id":105751349,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3NTEzNDk=","name":"status-react","full_name":"MaxRis/status-react","owner":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaxRis/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":true,"url":"https://api.github.com/repos/MaxRis/status-react","forks_url":"https://api.github.com/repos/MaxRis/status-react/forks","keys_url":"https://api.github.com/repos/MaxRis/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaxRis/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaxRis/status-react/teams","hooks_url":"https://api.github.com/repos/MaxRis/status-react/hooks","issue_events_url":"https://api.github.com/repos/MaxRis/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/MaxRis/status-react/events","assignees_url":"https://api.github.com/repos/MaxRis/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/MaxRis/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/MaxRis/status-react/tags","blobs_url":"https://api.github.com/repos/MaxRis/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaxRis/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaxRis/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaxRis/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaxRis/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/MaxRis/status-react/languages","stargazers_url":"https://api.github.com/repos/MaxRis/status-react/stargazers","contributors_url":"https://api.github.com/repos/MaxRis/status-react/contributors","subscribers_url":"https://api.github.com/repos/MaxRis/status-react/subscribers","subscription_url":"https://api.github.com/repos/MaxRis/status-react/subscription","commits_url":"https://api.github.com/repos/MaxRis/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaxRis/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaxRis/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaxRis/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaxRis/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/MaxRis/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaxRis/status-react/merges","archive_url":"https://api.github.com/repos/MaxRis/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaxRis/status-react/downloads","issues_url":"https://api.github.com/repos/MaxRis/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/MaxRis/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/MaxRis/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/MaxRis/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaxRis/status-react/labels{/name}","releases_url":"https://api.github.com/repos/MaxRis/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/MaxRis/status-react/deployments","created_at":"2017-10-04T09:27:40Z","updated_at":"2017-10-04T09:27:44Z","pushed_at":"2018-07-05T20:12:44Z","git_url":"git://github.com/MaxRis/status-react.git","ssh_url":"git@github.com:MaxRis/status-react.git","clone_url":"https://github.com/MaxRis/status-react.git","svn_url":"https://github.com/MaxRis/status-react","homepage":"https://status.im","size":95681,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"status-im:desktop","ref":"desktop","sha":"47cfb764c83cf68f3fab2b1215f8ffface8d09d0","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==","name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-07-05T13:32:42Z","pushed_at":"2018-07-05T20:44:16Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":58979,"stargazers_count":2309,"watchers_count":2309,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":567,"mirror_url":null,"archived":false,"open_issues_count":701,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":567,"open_issues":701,"watchers":2309,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/5006"},"html":{"href":"https://github.com/status-im/status-react/pull/5006"},"issue":{"href":"https://api.github.com/repos/status-im/status-react/issues/5006"},"comments":{"href":"https://api.github.com/repos/status-im/status-react/issues/5006/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-react/pulls/5006/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-react/pulls/5006/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-react/statuses/a190e7db99809c5b3510fe69609a75b58fa4fc8b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"comments":14,"review_comments":5,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"MaxRis"}}