{"action":"created","comment":{"url":"https://api.github.com/repos/shapeblue/cloudstack/pulls/comments/194419757","pull_request_review_id":127587478,"id":194419757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQxOTc1Nw==","diff_hunk":"@@ -0,0 +1,49 @@\n+//\n+// Licensed to the Apache Software Foundation (ASF) under one\n+// or more contributor license agreements.  See the NOTICE file\n+// distributed with this work for additional information\n+// regarding copyright ownership.  The ASF licenses this file\n+// to you under the Apache License, Version 2.0 (the\n+// \"License\"); you may not use this file except in compliance\n+// with the License.  You may obtain a copy of the License at\n+//\n+//   http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing,\n+// software distributed under the License is distributed on an\n+// \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+// KIND, either express or implied.  See the License for the\n+// specific language governing permissions and limitations\n+// under the License.\n+//\n+\n+package org.apache.cloudstack.diangosis;\n+\n+import com.cloud.exception.AgentUnavailableException;\n+import com.cloud.exception.InvalidParameterValueException;\n+import org.apache.cloudstack.api.command.admin.diagnostics.RemoteDiagnosticsCmd;\n+import org.apache.cloudstack.api.response.RemoteDiagnosticsResponse;\n+import org.apache.cloudstack.framework.config.ConfigKey;\n+\n+public interface RemoteDiagnosticsService {\n+    static final ConfigKey<String> PingUtility = new ConfigKey<String>(\"Advanced\", String.class, \"ping\", \"ping\", \"I am description\", true);\n+    static final ConfigKey<String> TracerouteUtility = new ConfigKey<String>(\"Advanced\", String.class, \"traceroute\", \"ping\", \"I am description\", true);\n+    static final ConfigKey<String> ArpingUtility = new ConfigKey<String>(\"Advanced\", String.class, \"arping\", \"ping\", \"I am description\", true);\n+\n+\n+    RemoteDiagnosticsResponse executeDiagnosticsToolInSystemVm(RemoteDiagnosticsCmd cmd) throws AgentUnavailableException, InvalidParameterValueException;\n+\n+    enum DiagnosisType {\n+        ping, traceroute, arping;\n+\n+        public static boolean contains(String cmd){\n+            try{\n+                valueOf(cmd);\n+                return true;\n+            }catch (Exception e){\n+                return false;\n+            }\n+","path":"api/src/main/java/org/apache/cloudstack/diangosis/RemoteDiagnosticsService.java","position":46,"original_position":46,"commit_id":"05483de0bcd7fafe26f947fc880c5a38682d1c26","original_commit_id":"72f70239906035f34b45ebac898297ce8f10fdb2","user":{"login":"dhlaluku","id":19572501,"node_id":"MDQ6VXNlcjE5NTcyNTAx","avatar_url":"https://avatars1.githubusercontent.com/u/19572501?v=4","gravatar_id":"","url":"https://api.github.com/users/dhlaluku","html_url":"https://github.com/dhlaluku","followers_url":"https://api.github.com/users/dhlaluku/followers","following_url":"https://api.github.com/users/dhlaluku/following{/other_user}","gists_url":"https://api.github.com/users/dhlaluku/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlaluku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlaluku/subscriptions","organizations_url":"https://api.github.com/users/dhlaluku/orgs","repos_url":"https://api.github.com/users/dhlaluku/repos","events_url":"https://api.github.com/users/dhlaluku/events{/privacy}","received_events_url":"https://api.github.com/users/dhlaluku/received_events","type":"User","site_admin":false},"body":"resolved","created_at":"2018-06-11T14:16:52Z","updated_at":"2018-06-11T14:16:52Z","html_url":"https://github.com/shapeblue/cloudstack/pull/13#discussion_r194419757","pull_request_url":"https://api.github.com/repos/shapeblue/cloudstack/pulls/13","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/shapeblue/cloudstack/pulls/comments/194419757"},"html":{"href":"https://github.com/shapeblue/cloudstack/pull/13#discussion_r194419757"},"pull_request":{"href":"https://api.github.com/repos/shapeblue/cloudstack/pulls/13"}},"in_reply_to_id":193317714},"pull_request":{"url":"https://api.github.com/repos/shapeblue/cloudstack/pulls/13","id":190260841,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMjYwODQx","html_url":"https://github.com/shapeblue/cloudstack/pull/13","diff_url":"https://github.com/shapeblue/cloudstack/pull/13.diff","patch_url":"https://github.com/shapeblue/cloudstack/pull/13.patch","issue_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/13","number":13,"state":"open","locked":false,"title":"Remote diganosis api","user":{"login":"dhlaluku","id":19572501,"node_id":"MDQ6VXNlcjE5NTcyNTAx","avatar_url":"https://avatars1.githubusercontent.com/u/19572501?v=4","gravatar_id":"","url":"https://api.github.com/users/dhlaluku","html_url":"https://github.com/dhlaluku","followers_url":"https://api.github.com/users/dhlaluku/followers","following_url":"https://api.github.com/users/dhlaluku/following{/other_user}","gists_url":"https://api.github.com/users/dhlaluku/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlaluku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlaluku/subscriptions","organizations_url":"https://api.github.com/users/dhlaluku/orgs","repos_url":"https://api.github.com/users/dhlaluku/repos","events_url":"https://api.github.com/users/dhlaluku/events{/privacy}","received_events_url":"https://api.github.com/users/dhlaluku/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!--- Describe your changes in detail -->\r\nThis a new feature for CloudStack to provide functionality for the admin user to execute network utitlity commands (ping, tracert, arping) directly from the SSVMs.\r\n\r\n<!-- For new features, provide link to FS, dev ML discussion etc. -->\r\n<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\nTesting\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All relevant new and existing integration tests have passed.\r\n- [ ] A full integration testsuite with all test that can run on my environment has passed.\r\n\r\n","created_at":"2018-05-24T11:46:41Z","updated_at":"2018-06-11T14:16:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77d3980b3a74f4bd89ebdbe24c4dbafca0d02487","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shapeblue/cloudstack/pulls/13/commits","review_comments_url":"https://api.github.com/repos/shapeblue/cloudstack/pulls/13/comments","review_comment_url":"https://api.github.com/repos/shapeblue/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/13/comments","statuses_url":"https://api.github.com/repos/shapeblue/cloudstack/statuses/05483de0bcd7fafe26f947fc880c5a38682d1c26","head":{"label":"shapeblue:remoteDiganosisAPI","ref":"remoteDiganosisAPI","sha":"05483de0bcd7fafe26f947fc880c5a38682d1c26","user":{"login":"shapeblue","id":6001764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDE3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6001764?v=4","gravatar_id":"","url":"https://api.github.com/users/shapeblue","html_url":"https://github.com/shapeblue","followers_url":"https://api.github.com/users/shapeblue/followers","following_url":"https://api.github.com/users/shapeblue/following{/other_user}","gists_url":"https://api.github.com/users/shapeblue/gists{/gist_id}","starred_url":"https://api.github.com/users/shapeblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapeblue/subscriptions","organizations_url":"https://api.github.com/users/shapeblue/orgs","repos_url":"https://api.github.com/users/shapeblue/repos","events_url":"https://api.github.com/users/shapeblue/events{/privacy}","received_events_url":"https://api.github.com/users/shapeblue/received_events","type":"Organization","site_admin":false},"repo":{"id":35481491,"node_id":"MDEwOlJlcG9zaXRvcnkzNTQ4MTQ5MQ==","name":"cloudstack","full_name":"shapeblue/cloudstack","owner":{"login":"shapeblue","id":6001764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDE3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6001764?v=4","gravatar_id":"","url":"https://api.github.com/users/shapeblue","html_url":"https://github.com/shapeblue","followers_url":"https://api.github.com/users/shapeblue/followers","following_url":"https://api.github.com/users/shapeblue/following{/other_user}","gists_url":"https://api.github.com/users/shapeblue/gists{/gist_id}","starred_url":"https://api.github.com/users/shapeblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapeblue/subscriptions","organizations_url":"https://api.github.com/users/shapeblue/orgs","repos_url":"https://api.github.com/users/shapeblue/repos","events_url":"https://api.github.com/users/shapeblue/events{/privacy}","received_events_url":"https://api.github.com/users/shapeblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shapeblue/cloudstack","description":"The upstream repository is at http://github.com/apache/cloudstack. This is ShapeBlue's support/patch branches and Apache CloudStack™ backup","fork":true,"url":"https://api.github.com/repos/shapeblue/cloudstack","forks_url":"https://api.github.com/repos/shapeblue/cloudstack/forks","keys_url":"https://api.github.com/repos/shapeblue/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shapeblue/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shapeblue/cloudstack/teams","hooks_url":"https://api.github.com/repos/shapeblue/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/shapeblue/cloudstack/events","assignees_url":"https://api.github.com/repos/shapeblue/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/shapeblue/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/shapeblue/cloudstack/tags","blobs_url":"https://api.github.com/repos/shapeblue/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shapeblue/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shapeblue/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/shapeblue/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shapeblue/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/shapeblue/cloudstack/languages","stargazers_url":"https://api.github.com/repos/shapeblue/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/shapeblue/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/shapeblue/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/shapeblue/cloudstack/subscription","commits_url":"https://api.github.com/repos/shapeblue/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/shapeblue/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/shapeblue/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/shapeblue/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/shapeblue/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shapeblue/cloudstack/merges","archive_url":"https://api.github.com/repos/shapeblue/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shapeblue/cloudstack/downloads","issues_url":"https://api.github.com/repos/shapeblue/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/shapeblue/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/shapeblue/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/shapeblue/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shapeblue/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/shapeblue/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/shapeblue/cloudstack/deployments","created_at":"2015-05-12T10:22:21Z","updated_at":"2018-06-08T08:18:06Z","pushed_at":"2018-06-11T09:21:23Z","git_url":"git://github.com/shapeblue/cloudstack.git","ssh_url":"git@github.com:shapeblue/cloudstack.git","clone_url":"https://github.com/shapeblue/cloudstack.git","svn_url":"https://github.com/shapeblue/cloudstack","homepage":"http://shapeblue.com/packages","size":538721,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"shapeblue:master","ref":"master","sha":"ca17b6a126d8842adb750146a3f843e6acbadd04","user":{"login":"shapeblue","id":6001764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDE3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6001764?v=4","gravatar_id":"","url":"https://api.github.com/users/shapeblue","html_url":"https://github.com/shapeblue","followers_url":"https://api.github.com/users/shapeblue/followers","following_url":"https://api.github.com/users/shapeblue/following{/other_user}","gists_url":"https://api.github.com/users/shapeblue/gists{/gist_id}","starred_url":"https://api.github.com/users/shapeblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapeblue/subscriptions","organizations_url":"https://api.github.com/users/shapeblue/orgs","repos_url":"https://api.github.com/users/shapeblue/repos","events_url":"https://api.github.com/users/shapeblue/events{/privacy}","received_events_url":"https://api.github.com/users/shapeblue/received_events","type":"Organization","site_admin":false},"repo":{"id":35481491,"node_id":"MDEwOlJlcG9zaXRvcnkzNTQ4MTQ5MQ==","name":"cloudstack","full_name":"shapeblue/cloudstack","owner":{"login":"shapeblue","id":6001764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDE3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6001764?v=4","gravatar_id":"","url":"https://api.github.com/users/shapeblue","html_url":"https://github.com/shapeblue","followers_url":"https://api.github.com/users/shapeblue/followers","following_url":"https://api.github.com/users/shapeblue/following{/other_user}","gists_url":"https://api.github.com/users/shapeblue/gists{/gist_id}","starred_url":"https://api.github.com/users/shapeblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapeblue/subscriptions","organizations_url":"https://api.github.com/users/shapeblue/orgs","repos_url":"https://api.github.com/users/shapeblue/repos","events_url":"https://api.github.com/users/shapeblue/events{/privacy}","received_events_url":"https://api.github.com/users/shapeblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shapeblue/cloudstack","description":"The upstream repository is at http://github.com/apache/cloudstack. This is ShapeBlue's support/patch branches and Apache CloudStack™ backup","fork":true,"url":"https://api.github.com/repos/shapeblue/cloudstack","forks_url":"https://api.github.com/repos/shapeblue/cloudstack/forks","keys_url":"https://api.github.com/repos/shapeblue/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shapeblue/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shapeblue/cloudstack/teams","hooks_url":"https://api.github.com/repos/shapeblue/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/shapeblue/cloudstack/events","assignees_url":"https://api.github.com/repos/shapeblue/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/shapeblue/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/shapeblue/cloudstack/tags","blobs_url":"https://api.github.com/repos/shapeblue/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shapeblue/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shapeblue/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/shapeblue/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shapeblue/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/shapeblue/cloudstack/languages","stargazers_url":"https://api.github.com/repos/shapeblue/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/shapeblue/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/shapeblue/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/shapeblue/cloudstack/subscription","commits_url":"https://api.github.com/repos/shapeblue/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/shapeblue/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/shapeblue/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/shapeblue/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/shapeblue/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shapeblue/cloudstack/merges","archive_url":"https://api.github.com/repos/shapeblue/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shapeblue/cloudstack/downloads","issues_url":"https://api.github.com/repos/shapeblue/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/shapeblue/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/shapeblue/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/shapeblue/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shapeblue/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/shapeblue/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/shapeblue/cloudstack/deployments","created_at":"2015-05-12T10:22:21Z","updated_at":"2018-06-08T08:18:06Z","pushed_at":"2018-06-11T09:21:23Z","git_url":"git://github.com/shapeblue/cloudstack.git","ssh_url":"git@github.com:shapeblue/cloudstack.git","clone_url":"https://github.com/shapeblue/cloudstack.git","svn_url":"https://github.com/shapeblue/cloudstack","homepage":"http://shapeblue.com/packages","size":538721,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shapeblue/cloudstack/pulls/13"},"html":{"href":"https://github.com/shapeblue/cloudstack/pull/13"},"issue":{"href":"https://api.github.com/repos/shapeblue/cloudstack/issues/13"},"comments":{"href":"https://api.github.com/repos/shapeblue/cloudstack/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/shapeblue/cloudstack/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/shapeblue/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shapeblue/cloudstack/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/shapeblue/cloudstack/statuses/05483de0bcd7fafe26f947fc880c5a38682d1c26"}},"author_association":"NONE"}}
{"actor":{"display_login":"dhlaluku"}}