{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/21863","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21863/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21863/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21863/events","html_url":"https://github.com/pandas-dev/pandas/pull/21863","id":340342847,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzc3OTU2","number":21863,"title":"Replaced PANDAS_DATETIMEUNIT with NPY_DATETIMEUNIT","user":{"login":"WillAyd","id":609873,"node_id":"MDQ6VXNlcjYwOTg3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/609873?v=4","gravatar_id":"","url":"https://api.github.com/users/WillAyd","html_url":"https://github.com/WillAyd","followers_url":"https://api.github.com/users/WillAyd/followers","following_url":"https://api.github.com/users/WillAyd/following{/other_user}","gists_url":"https://api.github.com/users/WillAyd/gists{/gist_id}","starred_url":"https://api.github.com/users/WillAyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillAyd/subscriptions","organizations_url":"https://api.github.com/users/WillAyd/orgs","repos_url":"https://api.github.com/users/WillAyd/repos","events_url":"https://api.github.com/users/WillAyd/events{/privacy}","received_events_url":"https://api.github.com/users/WillAyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-11T17:47:47Z","updated_at":"2018-07-11T19:05:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21863","html_url":"https://github.com/pandas-dev/pandas/pull/21863","diff_url":"https://github.com/pandas-dev/pandas/pull/21863.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/21863.patch"},"body":"progress towards #21852\r\n\r\n- [X] tests added / passed\r\n- [ ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n\r\nWorking on my C-fu as well. There may be a better way to do this (ex: even adding NPY_DATETIMEUNIT to Cython/includes) but figured I'd offer this up for review\r\n\r\n@jbrockmendel "},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/404277445","html_url":"https://github.com/pandas-dev/pandas/pull/21863#issuecomment-404277445","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21863","id":404277445,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDI3NzQ0NQ==","user":{"login":"WillAyd","id":609873,"node_id":"MDQ6VXNlcjYwOTg3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/609873?v=4","gravatar_id":"","url":"https://api.github.com/users/WillAyd","html_url":"https://github.com/WillAyd","followers_url":"https://api.github.com/users/WillAyd/followers","following_url":"https://api.github.com/users/WillAyd/following{/other_user}","gists_url":"https://api.github.com/users/WillAyd/gists{/gist_id}","starred_url":"https://api.github.com/users/WillAyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillAyd/subscriptions","organizations_url":"https://api.github.com/users/WillAyd/orgs","repos_url":"https://api.github.com/users/WillAyd/repos","events_url":"https://api.github.com/users/WillAyd/events{/privacy}","received_events_url":"https://api.github.com/users/WillAyd/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T19:05:06Z","updated_at":"2018-07-11T19:05:06Z","author_association":"MEMBER","body":"@jbrockmendel not sure what you are looking for out of that but it doesn't appear that header is included in numpy's `core/include` directory along with the rest of the headers. You might have to mess around with `setup.py` if you are trying to include header files outside of that location:\r\n\r\nhttps://github.com/pandas-dev/pandas/blob/5d0daa0522730a6f999ceaf328f63f03dd62d0b4/setup.py#L128\r\n\r\nThough that most likely violates a lot of best practices"}}
{"actor":{"display_login":"WillAyd"}}