{"action":"created","comment":{"url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/comments/190594213","pull_request_review_id":123002361,"id":190594213,"diff_hunk":"@@ -0,0 +1,96 @@\n+package com.sequenceiq.cloudbreak.converter.util;\n+\n+import java.security.KeyPair;\n+import java.security.cert.X509Certificate;\n+import java.util.Collection;\n+import java.util.Collections;\n+import java.util.List;\n+import java.util.Set;\n+import java.util.stream.Collectors;\n+\n+import javax.inject.Inject;\n+\n+import org.apache.commons.lang3.StringUtils;\n+import org.springframework.core.convert.ConversionService;\n+import org.springframework.stereotype.Component;\n+import org.springframework.util.CollectionUtils;\n+\n+import com.sequenceiq.cloudbreak.api.model.stack.cluster.gateway.GatewayJson;\n+import com.sequenceiq.cloudbreak.api.model.stack.cluster.gateway.GatewayTopologyJson;\n+import com.sequenceiq.cloudbreak.api.model.stack.cluster.gateway.SSOType;\n+import com.sequenceiq.cloudbreak.client.PkiUtil;\n+import com.sequenceiq.cloudbreak.domain.stack.cluster.gateway.Gateway;\n+import com.sequenceiq.cloudbreak.domain.stack.cluster.gateway.GatewayTopology;\n+\n+@Component\n+public class GatewayConvertUtil {\n+\n+    @Inject\n+    private ConversionService conversionService;\n+\n+    public void setTopologies(GatewayJson source, Gateway gateway) {","path":"core/src/main/java/com/sequenceiq/cloudbreak/converter/util/GatewayConvertUtil.java","position":31,"original_position":31,"commit_id":"4215ca2b69254e0a260f1945328d177f41ce499f","original_commit_id":"4215ca2b69254e0a260f1945328d177f41ce499f","user":{"login":"attilapalfi92","id":9819500,"avatar_url":"https://avatars1.githubusercontent.com/u/9819500?v=4","gravatar_id":"","url":"https://api.github.com/users/attilapalfi92","html_url":"https://github.com/attilapalfi92","followers_url":"https://api.github.com/users/attilapalfi92/followers","following_url":"https://api.github.com/users/attilapalfi92/following{/other_user}","gists_url":"https://api.github.com/users/attilapalfi92/gists{/gist_id}","starred_url":"https://api.github.com/users/attilapalfi92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attilapalfi92/subscriptions","organizations_url":"https://api.github.com/users/attilapalfi92/orgs","repos_url":"https://api.github.com/users/attilapalfi92/repos","events_url":"https://api.github.com/users/attilapalfi92/events{/privacy}","received_events_url":"https://api.github.com/users/attilapalfi92/received_events","type":"User","site_admin":false},"body":"Also this method does not provide the backward compatibility","created_at":"2018-05-24T13:53:38Z","updated_at":"2018-05-24T13:53:39Z","html_url":"https://github.com/hortonworks/cloudbreak/pull/3470#discussion_r190594213","pull_request_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/3470","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/comments/190594213"},"html":{"href":"https://github.com/hortonworks/cloudbreak/pull/3470#discussion_r190594213"},"pull_request":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/3470"}},"in_reply_to_id":190589953},"pull_request":{"url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/3470","id":190280063,"html_url":"https://github.com/hortonworks/cloudbreak/pull/3470","diff_url":"https://github.com/hortonworks/cloudbreak/pull/3470.diff","patch_url":"https://github.com/hortonworks/cloudbreak/pull/3470.patch","issue_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/3470","number":3470,"state":"open","locked":false,"title":"WIP -BUG-102975 Created converter service for StackV2 request to Gateway, …","user":{"login":"lnardai","id":3493960,"avatar_url":"https://avatars2.githubusercontent.com/u/3493960?v=4","gravatar_id":"","url":"https://api.github.com/users/lnardai","html_url":"https://github.com/lnardai","followers_url":"https://api.github.com/users/lnardai/followers","following_url":"https://api.github.com/users/lnardai/following{/other_user}","gists_url":"https://api.github.com/users/lnardai/gists{/gist_id}","starred_url":"https://api.github.com/users/lnardai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnardai/subscriptions","organizations_url":"https://api.github.com/users/lnardai/orgs","repos_url":"https://api.github.com/users/lnardai/repos","events_url":"https://api.github.com/users/lnardai/events{/privacy}","received_events_url":"https://api.github.com/users/lnardai/received_events","type":"User","site_admin":false},"body":"Initially Gateway transformation logic was present in ClusterRequestToClusterConverter.\r\n- Extracted logic into GatewayConverterUtil for generating Gateway object from different ClusterRequests.\r\n- For StackV2Request know SSO related parameters are populated in Gateway object.","created_at":"2018-05-24T12:56:31Z","updated_at":"2018-05-24T13:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"499d94ce1adda1f726658294c72a1a3966f0c71b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/3470/commits","review_comments_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/3470/comments","review_comment_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/3470/comments","statuses_url":"https://api.github.com/repos/hortonworks/cloudbreak/statuses/4215ca2b69254e0a260f1945328d177f41ce499f","head":{"label":"hortonworks:ranger-sso-config-for-blueprint","ref":"ranger-sso-config-for-blueprint","sha":"4215ca2b69254e0a260f1945328d177f41ce499f","user":{"login":"hortonworks","id":898785,"avatar_url":"https://avatars2.githubusercontent.com/u/898785?v=4","gravatar_id":"","url":"https://api.github.com/users/hortonworks","html_url":"https://github.com/hortonworks","followers_url":"https://api.github.com/users/hortonworks/followers","following_url":"https://api.github.com/users/hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortonworks/subscriptions","organizations_url":"https://api.github.com/users/hortonworks/orgs","repos_url":"https://api.github.com/users/hortonworks/repos","events_url":"https://api.github.com/users/hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/hortonworks/received_events","type":"Organization","site_admin":false},"repo":{"id":19638422,"name":"cloudbreak","full_name":"hortonworks/cloudbreak","owner":{"login":"hortonworks","id":898785,"avatar_url":"https://avatars2.githubusercontent.com/u/898785?v=4","gravatar_id":"","url":"https://api.github.com/users/hortonworks","html_url":"https://github.com/hortonworks","followers_url":"https://api.github.com/users/hortonworks/followers","following_url":"https://api.github.com/users/hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortonworks/subscriptions","organizations_url":"https://api.github.com/users/hortonworks/orgs","repos_url":"https://api.github.com/users/hortonworks/repos","events_url":"https://api.github.com/users/hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/hortonworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hortonworks/cloudbreak","description":"A tool for provisioning and managing Apache Hadoop clusters in the cloud. Cloudbreak, as part of the Hortonworks Data Platform, makes it easy to provision, configure and elastically grow HDP clusters on cloud infrastructure. Cloudbreak can be used to provision Hadoop across cloud infrastructure providers including AWS, Azure, GCP and OpenStack.","fork":false,"url":"https://api.github.com/repos/hortonworks/cloudbreak","forks_url":"https://api.github.com/repos/hortonworks/cloudbreak/forks","keys_url":"https://api.github.com/repos/hortonworks/cloudbreak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hortonworks/cloudbreak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hortonworks/cloudbreak/teams","hooks_url":"https://api.github.com/repos/hortonworks/cloudbreak/hooks","issue_events_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/events{/number}","events_url":"https://api.github.com/repos/hortonworks/cloudbreak/events","assignees_url":"https://api.github.com/repos/hortonworks/cloudbreak/assignees{/user}","branches_url":"https://api.github.com/repos/hortonworks/cloudbreak/branches{/branch}","tags_url":"https://api.github.com/repos/hortonworks/cloudbreak/tags","blobs_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/refs{/sha}","trees_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hortonworks/cloudbreak/statuses/{sha}","languages_url":"https://api.github.com/repos/hortonworks/cloudbreak/languages","stargazers_url":"https://api.github.com/repos/hortonworks/cloudbreak/stargazers","contributors_url":"https://api.github.com/repos/hortonworks/cloudbreak/contributors","subscribers_url":"https://api.github.com/repos/hortonworks/cloudbreak/subscribers","subscription_url":"https://api.github.com/repos/hortonworks/cloudbreak/subscription","commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/commits{/sha}","git_commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/commits{/sha}","comments_url":"https://api.github.com/repos/hortonworks/cloudbreak/comments{/number}","issue_comment_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/comments{/number}","contents_url":"https://api.github.com/repos/hortonworks/cloudbreak/contents/{+path}","compare_url":"https://api.github.com/repos/hortonworks/cloudbreak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hortonworks/cloudbreak/merges","archive_url":"https://api.github.com/repos/hortonworks/cloudbreak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hortonworks/cloudbreak/downloads","issues_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues{/number}","pulls_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls{/number}","milestones_url":"https://api.github.com/repos/hortonworks/cloudbreak/milestones{/number}","notifications_url":"https://api.github.com/repos/hortonworks/cloudbreak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hortonworks/cloudbreak/labels{/name}","releases_url":"https://api.github.com/repos/hortonworks/cloudbreak/releases{/id}","deployments_url":"https://api.github.com/repos/hortonworks/cloudbreak/deployments","created_at":"2014-05-10T10:03:07Z","updated_at":"2018-05-24T11:00:06Z","pushed_at":"2018-05-24T13:25:27Z","git_url":"git://github.com/hortonworks/cloudbreak.git","ssh_url":"git@github.com:hortonworks/cloudbreak.git","clone_url":"https://github.com/hortonworks/cloudbreak.git","svn_url":"https://github.com/hortonworks/cloudbreak","homepage":"http://hortonworks.github.io/cloudbreak-docs","size":40460,"stargazers_count":201,"watchers_count":201,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":88,"open_issues":17,"watchers":201,"default_branch":"master"}},"base":{"label":"hortonworks:master","ref":"master","sha":"6646b9c0184247fb2deafe301fe0e9404b4389f5","user":{"login":"hortonworks","id":898785,"avatar_url":"https://avatars2.githubusercontent.com/u/898785?v=4","gravatar_id":"","url":"https://api.github.com/users/hortonworks","html_url":"https://github.com/hortonworks","followers_url":"https://api.github.com/users/hortonworks/followers","following_url":"https://api.github.com/users/hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortonworks/subscriptions","organizations_url":"https://api.github.com/users/hortonworks/orgs","repos_url":"https://api.github.com/users/hortonworks/repos","events_url":"https://api.github.com/users/hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/hortonworks/received_events","type":"Organization","site_admin":false},"repo":{"id":19638422,"name":"cloudbreak","full_name":"hortonworks/cloudbreak","owner":{"login":"hortonworks","id":898785,"avatar_url":"https://avatars2.githubusercontent.com/u/898785?v=4","gravatar_id":"","url":"https://api.github.com/users/hortonworks","html_url":"https://github.com/hortonworks","followers_url":"https://api.github.com/users/hortonworks/followers","following_url":"https://api.github.com/users/hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortonworks/subscriptions","organizations_url":"https://api.github.com/users/hortonworks/orgs","repos_url":"https://api.github.com/users/hortonworks/repos","events_url":"https://api.github.com/users/hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/hortonworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hortonworks/cloudbreak","description":"A tool for provisioning and managing Apache Hadoop clusters in the cloud. Cloudbreak, as part of the Hortonworks Data Platform, makes it easy to provision, configure and elastically grow HDP clusters on cloud infrastructure. Cloudbreak can be used to provision Hadoop across cloud infrastructure providers including AWS, Azure, GCP and OpenStack.","fork":false,"url":"https://api.github.com/repos/hortonworks/cloudbreak","forks_url":"https://api.github.com/repos/hortonworks/cloudbreak/forks","keys_url":"https://api.github.com/repos/hortonworks/cloudbreak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hortonworks/cloudbreak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hortonworks/cloudbreak/teams","hooks_url":"https://api.github.com/repos/hortonworks/cloudbreak/hooks","issue_events_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/events{/number}","events_url":"https://api.github.com/repos/hortonworks/cloudbreak/events","assignees_url":"https://api.github.com/repos/hortonworks/cloudbreak/assignees{/user}","branches_url":"https://api.github.com/repos/hortonworks/cloudbreak/branches{/branch}","tags_url":"https://api.github.com/repos/hortonworks/cloudbreak/tags","blobs_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/refs{/sha}","trees_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hortonworks/cloudbreak/statuses/{sha}","languages_url":"https://api.github.com/repos/hortonworks/cloudbreak/languages","stargazers_url":"https://api.github.com/repos/hortonworks/cloudbreak/stargazers","contributors_url":"https://api.github.com/repos/hortonworks/cloudbreak/contributors","subscribers_url":"https://api.github.com/repos/hortonworks/cloudbreak/subscribers","subscription_url":"https://api.github.com/repos/hortonworks/cloudbreak/subscription","commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/commits{/sha}","git_commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/commits{/sha}","comments_url":"https://api.github.com/repos/hortonworks/cloudbreak/comments{/number}","issue_comment_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/comments{/number}","contents_url":"https://api.github.com/repos/hortonworks/cloudbreak/contents/{+path}","compare_url":"https://api.github.com/repos/hortonworks/cloudbreak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hortonworks/cloudbreak/merges","archive_url":"https://api.github.com/repos/hortonworks/cloudbreak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hortonworks/cloudbreak/downloads","issues_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues{/number}","pulls_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls{/number}","milestones_url":"https://api.github.com/repos/hortonworks/cloudbreak/milestones{/number}","notifications_url":"https://api.github.com/repos/hortonworks/cloudbreak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hortonworks/cloudbreak/labels{/name}","releases_url":"https://api.github.com/repos/hortonworks/cloudbreak/releases{/id}","deployments_url":"https://api.github.com/repos/hortonworks/cloudbreak/deployments","created_at":"2014-05-10T10:03:07Z","updated_at":"2018-05-24T11:00:06Z","pushed_at":"2018-05-24T13:25:27Z","git_url":"git://github.com/hortonworks/cloudbreak.git","ssh_url":"git@github.com:hortonworks/cloudbreak.git","clone_url":"https://github.com/hortonworks/cloudbreak.git","svn_url":"https://github.com/hortonworks/cloudbreak","homepage":"http://hortonworks.github.io/cloudbreak-docs","size":40460,"stargazers_count":201,"watchers_count":201,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":88,"open_issues":17,"watchers":201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/3470"},"html":{"href":"https://github.com/hortonworks/cloudbreak/pull/3470"},"issue":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/issues/3470"},"comments":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/issues/3470/comments"},"review_comments":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/3470/comments"},"review_comment":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/3470/commits"},"statuses":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/statuses/4215ca2b69254e0a260f1945328d177f41ce499f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"attilapalfi92"}}