{"action":"created","comment":{"url":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/comments/191072805","pull_request_review_id":123579997,"id":191072805,"diff_hunk":"@@ -31,49 +20,32 @@ object GraphQLSchema {\n       MessageType)\n \n \n-\n   val RoomType = ObjectType[Context, Room](\n     \"Room\",\n     fields[Context, Room](\n       Field(\"id\", IDType, resolve = _.value.id),\n       Field(\"title\", StringType, resolve = _.value.title),\n       Field(\"messages\", OptionType(messageConnection),\n         arguments = Connection.Args.All,\n-        resolve = c => c.ctx.dao.messageConnection(c.value.id, ConnectionArgs(c)))\n+        resolve = c => c.ctx.dao.messageConnectionByRoom(c.value.id, ConnectionArgs(c)))\n     )\n   )\n \n   val ConnectionDefinition(_, roomConnection) =\n-    Connection.definition[Context, Connection, Room](name= \"Rooms\", RoomType)\n+    Connection.definition[Context, Connection, Room](name = \"Rooms\", RoomType)\n \n-  // 2\n   val QueryType = ObjectType(\n     \"Query\",\n     fields[Context, Unit](\n-      Field(\"allLinks\", ListType(LinkType), resolve = c => c.ctx.dao.allLinks),\n-      Field(\"allRooms\", ListType(RoomType), resolve = c => c.ctx.dao.allRooms),\n-      Field(\"link\",\n-        OptionType(LinkType),\n-        arguments = List(Argument(\"id\", StringType)),\n-        resolve = c => c.ctx.dao.getLink(c.arg[String](\"id\"))\n-      ),\n-      Field(\"links\",\n-        ListType(LinkType),\n-        arguments = List(Argument(\"ids\", ListInputType(StringType))),\n-        resolve = c => c.ctx.dao.getLinks(c.arg[Seq[String]](\"ids\"))\n-      ),\n       Field(\"messagesByRoom\",\n-        ListType(MessageType),\n-        arguments = List(Argument(\"roomId\", StringType)),\n-        resolve = c => c.ctx.dao.getMessagesByRoomId(c.arg[String](name=\"roomId\"))\n+        OptionType(messageConnection),\n+        arguments = List(Argument(\"roomId\", StringType)) ::: Connection.Args.All,","path":"chat-graphql-backend/src/main/scala/edu/greatchat/scala/sangria/GraphQLSchema.scala","position":null,"original_position":66,"commit_id":"a0f92a7e87f4c33e970aa993834d8ab92beea7ee","original_commit_id":"a0f92a7e87f4c33e970aa993834d8ab92beea7ee","user":{"login":"mgargas","id":32864654,"avatar_url":"https://avatars0.githubusercontent.com/u/32864654?v=4","gravatar_id":"","url":"https://api.github.com/users/mgargas","html_url":"https://github.com/mgargas","followers_url":"https://api.github.com/users/mgargas/followers","following_url":"https://api.github.com/users/mgargas/following{/other_user}","gists_url":"https://api.github.com/users/mgargas/gists{/gist_id}","starred_url":"https://api.github.com/users/mgargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgargas/subscriptions","organizations_url":"https://api.github.com/users/mgargas/orgs","repos_url":"https://api.github.com/users/mgargas/repos","events_url":"https://api.github.com/users/mgargas/events{/privacy}","received_events_url":"https://api.github.com/users/mgargas/received_events","type":"User","site_admin":false},"body":"What is \"::: Conection.Args.All\" resposible for?","created_at":"2018-05-27T11:01:02Z","updated_at":"2018-05-27T11:01:02Z","html_url":"https://github.com/osdnk/chat-graphql-scala/pull/6#discussion_r191072805","pull_request_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/comments/191072805"},"html":{"href":"https://github.com/osdnk/chat-graphql-scala/pull/6#discussion_r191072805"},"pull_request":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/6","id":190766795,"html_url":"https://github.com/osdnk/chat-graphql-scala/pull/6","diff_url":"https://github.com/osdnk/chat-graphql-scala/pull/6.diff","patch_url":"https://github.com/osdnk/chat-graphql-scala/pull/6.patch","issue_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues/6","number":6,"state":"open","locked":false,"title":"Pagination","user":{"login":"mgargas","id":32864654,"avatar_url":"https://avatars0.githubusercontent.com/u/32864654?v=4","gravatar_id":"","url":"https://api.github.com/users/mgargas","html_url":"https://github.com/mgargas","followers_url":"https://api.github.com/users/mgargas/followers","following_url":"https://api.github.com/users/mgargas/following{/other_user}","gists_url":"https://api.github.com/users/mgargas/gists{/gist_id}","starred_url":"https://api.github.com/users/mgargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgargas/subscriptions","organizations_url":"https://api.github.com/users/mgargas/orgs","repos_url":"https://api.github.com/users/mgargas/repos","events_url":"https://api.github.com/users/mgargas/events{/privacy}","received_events_url":"https://api.github.com/users/mgargas/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-27T01:56:41Z","updated_at":"2018-05-27T11:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5384a5d3e66e3618fbe762663dd3ecaba89dfe05","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":945832555,"url":"https://api.github.com/repos/osdnk/chat-graphql-scala/labels/WIP","name":"WIP","color":"2bb5b5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/6/commits","review_comments_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/6/comments","review_comment_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues/6/comments","statuses_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/statuses/a0f92a7e87f4c33e970aa993834d8ab92beea7ee","head":{"label":"osdnk:pagination","ref":"pagination","sha":"a0f92a7e87f4c33e970aa993834d8ab92beea7ee","user":{"login":"osdnk","id":25709300,"avatar_url":"https://avatars2.githubusercontent.com/u/25709300?v=4","gravatar_id":"","url":"https://api.github.com/users/osdnk","html_url":"https://github.com/osdnk","followers_url":"https://api.github.com/users/osdnk/followers","following_url":"https://api.github.com/users/osdnk/following{/other_user}","gists_url":"https://api.github.com/users/osdnk/gists{/gist_id}","starred_url":"https://api.github.com/users/osdnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osdnk/subscriptions","organizations_url":"https://api.github.com/users/osdnk/orgs","repos_url":"https://api.github.com/users/osdnk/repos","events_url":"https://api.github.com/users/osdnk/events{/privacy}","received_events_url":"https://api.github.com/users/osdnk/received_events","type":"User","site_admin":false},"repo":{"id":133134687,"name":"chat-graphql-scala","full_name":"osdnk/chat-graphql-scala","owner":{"login":"osdnk","id":25709300,"avatar_url":"https://avatars2.githubusercontent.com/u/25709300?v=4","gravatar_id":"","url":"https://api.github.com/users/osdnk","html_url":"https://github.com/osdnk","followers_url":"https://api.github.com/users/osdnk/followers","following_url":"https://api.github.com/users/osdnk/following{/other_user}","gists_url":"https://api.github.com/users/osdnk/gists{/gist_id}","starred_url":"https://api.github.com/users/osdnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osdnk/subscriptions","organizations_url":"https://api.github.com/users/osdnk/orgs","repos_url":"https://api.github.com/users/osdnk/repos","events_url":"https://api.github.com/users/osdnk/events{/privacy}","received_events_url":"https://api.github.com/users/osdnk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osdnk/chat-graphql-scala","description":"Project for scala classes","fork":false,"url":"https://api.github.com/repos/osdnk/chat-graphql-scala","forks_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/forks","keys_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/teams","hooks_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/hooks","issue_events_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues/events{/number}","events_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/events","assignees_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/assignees{/user}","branches_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/branches{/branch}","tags_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/tags","blobs_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/languages","stargazers_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/stargazers","contributors_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/contributors","subscribers_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/subscribers","subscription_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/subscription","commits_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/contents/{+path}","compare_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/merges","archive_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/downloads","issues_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues{/number}","pulls_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/labels{/name}","releases_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/releases{/id}","deployments_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/deployments","created_at":"2018-05-12T10:08:23Z","updated_at":"2018-05-26T19:18:56Z","pushed_at":"2018-05-27T10:50:16Z","git_url":"git://github.com/osdnk/chat-graphql-scala.git","ssh_url":"git@github.com:osdnk/chat-graphql-scala.git","clone_url":"https://github.com/osdnk/chat-graphql-scala.git","svn_url":"https://github.com/osdnk/chat-graphql-scala","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"osdnk:master","ref":"master","sha":"3eb207ab4396577a6966d2c4d8a1d6df1b91cb0c","user":{"login":"osdnk","id":25709300,"avatar_url":"https://avatars2.githubusercontent.com/u/25709300?v=4","gravatar_id":"","url":"https://api.github.com/users/osdnk","html_url":"https://github.com/osdnk","followers_url":"https://api.github.com/users/osdnk/followers","following_url":"https://api.github.com/users/osdnk/following{/other_user}","gists_url":"https://api.github.com/users/osdnk/gists{/gist_id}","starred_url":"https://api.github.com/users/osdnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osdnk/subscriptions","organizations_url":"https://api.github.com/users/osdnk/orgs","repos_url":"https://api.github.com/users/osdnk/repos","events_url":"https://api.github.com/users/osdnk/events{/privacy}","received_events_url":"https://api.github.com/users/osdnk/received_events","type":"User","site_admin":false},"repo":{"id":133134687,"name":"chat-graphql-scala","full_name":"osdnk/chat-graphql-scala","owner":{"login":"osdnk","id":25709300,"avatar_url":"https://avatars2.githubusercontent.com/u/25709300?v=4","gravatar_id":"","url":"https://api.github.com/users/osdnk","html_url":"https://github.com/osdnk","followers_url":"https://api.github.com/users/osdnk/followers","following_url":"https://api.github.com/users/osdnk/following{/other_user}","gists_url":"https://api.github.com/users/osdnk/gists{/gist_id}","starred_url":"https://api.github.com/users/osdnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osdnk/subscriptions","organizations_url":"https://api.github.com/users/osdnk/orgs","repos_url":"https://api.github.com/users/osdnk/repos","events_url":"https://api.github.com/users/osdnk/events{/privacy}","received_events_url":"https://api.github.com/users/osdnk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osdnk/chat-graphql-scala","description":"Project for scala classes","fork":false,"url":"https://api.github.com/repos/osdnk/chat-graphql-scala","forks_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/forks","keys_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/teams","hooks_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/hooks","issue_events_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues/events{/number}","events_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/events","assignees_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/assignees{/user}","branches_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/branches{/branch}","tags_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/tags","blobs_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/languages","stargazers_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/stargazers","contributors_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/contributors","subscribers_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/subscribers","subscription_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/subscription","commits_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/contents/{+path}","compare_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/merges","archive_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/downloads","issues_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues{/number}","pulls_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/labels{/name}","releases_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/releases{/id}","deployments_url":"https://api.github.com/repos/osdnk/chat-graphql-scala/deployments","created_at":"2018-05-12T10:08:23Z","updated_at":"2018-05-26T19:18:56Z","pushed_at":"2018-05-27T10:50:16Z","git_url":"git://github.com/osdnk/chat-graphql-scala.git","ssh_url":"git@github.com:osdnk/chat-graphql-scala.git","clone_url":"https://github.com/osdnk/chat-graphql-scala.git","svn_url":"https://github.com/osdnk/chat-graphql-scala","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/6"},"html":{"href":"https://github.com/osdnk/chat-graphql-scala/pull/6"},"issue":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues/6"},"comments":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/osdnk/chat-graphql-scala/statuses/a0f92a7e87f4c33e970aa993834d8ab92beea7ee"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mgargas"}}