{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/2328","repository_url":"https://api.github.com/repos/openzipkin/zipkin","labels_url":"https://api.github.com/repos/openzipkin/zipkin/issues/2328/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/2328/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/2328/events","html_url":"https://github.com/openzipkin/zipkin/pull/2328","id":391431172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTQ0MTk5","number":2328,"title":"experimental grpc server for span collection","user":{"login":"ewhauser","id":131389,"node_id":"MDQ6VXNlcjEzMTM4OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/131389?v=4","gravatar_id":"","url":"https://api.github.com/users/ewhauser","html_url":"https://github.com/ewhauser","followers_url":"https://api.github.com/users/ewhauser/followers","following_url":"https://api.github.com/users/ewhauser/following{/other_user}","gists_url":"https://api.github.com/users/ewhauser/gists{/gist_id}","starred_url":"https://api.github.com/users/ewhauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewhauser/subscriptions","organizations_url":"https://api.github.com/users/ewhauser/orgs","repos_url":"https://api.github.com/users/ewhauser/repos","events_url":"https://api.github.com/users/ewhauser/events{/privacy}","received_events_url":"https://api.github.com/users/ewhauser/received_events","type":"User","site_admin":false},"labels":[{"id":237089117,"node_id":"MDU6TGFiZWwyMzcwODkxMTc=","url":"https://api.github.com/repos/openzipkin/zipkin/labels/collector","name":"collector","color":"eb6420","default":false},{"id":237089161,"node_id":"MDU6TGFiZWwyMzcwODkxNjE=","url":"https://api.github.com/repos/openzipkin/zipkin/labels/server","name":"server","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2018-12-16T03:17:07Z","updated_at":"2018-12-31T05:45:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/2328","html_url":"https://github.com/openzipkin/zipkin/pull/2328","diff_url":"https://github.com/openzipkin/zipkin/pull/2328.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/2328.patch"},"body":"This PR is an offshoot of a discussion in openzipkin/zipkin-api#57 . There are a number of issues that need to be addressed before consideration of merge:\r\n\r\n- [ ] Finalize the API and merge it into `zipkin-api`\r\n- [ ] Find a zero-duplication and zero-copy approach for the deserialization of spans on the server side\r\n- [ ] Add additional configuration options for configuring the server (i.e. SSL)\r\n- [ ] Integration test with GCP\r\n- [ ] Performance testing\r\n\r\nAlso, there is still some discussion about whether the project as a whole wants to support a gRPC endpoint in `zipkin-server` due to potential bloat. See the discussion in zipkin-api#57 for background."},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments/450610527","html_url":"https://github.com/openzipkin/zipkin/pull/2328#issuecomment-450610527","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/2328","id":450610527,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDYxMDUyNw==","user":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2018-12-31T05:45:15Z","updated_at":"2018-12-31T05:45:15Z","author_association":"CONTRIBUTOR","body":"@anuraaga PS I like the idea of re-using http/2 flow-control (and also ping for that matter) in theory, and will also help with whatever infra is needed when we experiment with streaming."}}
{"actor":{"display_login":"adriancole"}}