{"action":"created","comment":{"url":"https://api.github.com/repos/gnunn1/tilix/pulls/comments/213454953","pull_request_review_id":150295533,"id":213454953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzQ1NDk1Mw==","diff_hunk":"@@ -0,0 +1,107 @@\n+\n+icon_sizes = ['16x16', '22x22', '24x24', '32x32', '48x48', '256x256', '512x512']\n+\n+# install bitmap icons\n+foreach size : icon_sizes\n+    install_data(\n+        'icons/hicolor/' + size + '/apps/' + meson.project_name() + '.png',\n+        install_dir: 'share/icons/hicolor/' + size + '/apps/'\n+    )\n+endforeach\n+\n+# install scalable symbolic icon\n+install_data(\n+    'icons/hicolor/scalable/apps/com.gexperts.Tilix-symbolic.svg',\n+    install_dir: 'share/icons/hicolor/scalable/apps/'\n+)\n+\n+\n+# Validate desktop file\n+desktop_file_validate = find_program('desktop-file-validate', required:false)\n+\n+if desktop_file_validate.found()\n+  test (\n+    'Validate desktop file',\n+    desktop_file_validate,\n+    args: join_paths(meson.current_build_dir (), meson.project_name() + '.desktop')\n+  )\n+endif\n+\n+# Install the desktop file\n+i18n.merge_file(\n+    output:  meson.project_name() + '.desktop',\n+    input: 'pkg/desktop/' + meson.project_name() + '.desktop.in',\n+    po_dir: join_paths(meson.source_root(), 'po'),\n+    type: 'desktop',\n+    install: true,\n+    install_dir: 'share/applications'\n+)\n+\n+# Validate AppData file\n+appstreamcli = find_program('appstream-util', required:false)","path":"data/meson.build","position":null,"original_position":41,"commit_id":"6cba881159ffba4bf4bdbdf911850a130d4b73be","original_commit_id":"24fce983dfb15dc990ffb3cc9b5109cd0a2f9a12","user":{"login":"ximion","id":417468,"node_id":"MDQ6VXNlcjQxNzQ2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/417468?v=4","gravatar_id":"","url":"https://api.github.com/users/ximion","html_url":"https://github.com/ximion","followers_url":"https://api.github.com/users/ximion/followers","following_url":"https://api.github.com/users/ximion/following{/other_user}","gists_url":"https://api.github.com/users/ximion/gists{/gist_id}","starred_url":"https://api.github.com/users/ximion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximion/subscriptions","organizations_url":"https://api.github.com/users/ximion/orgs","repos_url":"https://api.github.com/users/ximion/repos","events_url":"https://api.github.com/users/ximion/events{/privacy}","received_events_url":"https://api.github.com/users/ximion/received_events","type":"User","site_admin":false},"body":"Can you point me at the issue? The only thing I'm aware of that was recently changed was empty content_attribute tags being allowed instead of setting every attribute to none explicitly.","created_at":"2018-08-28T20:09:13Z","updated_at":"2018-08-28T20:09:13Z","html_url":"https://github.com/gnunn1/tilix/pull/1507#discussion_r213454953","pull_request_url":"https://api.github.com/repos/gnunn1/tilix/pulls/1507","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gnunn1/tilix/pulls/comments/213454953"},"html":{"href":"https://github.com/gnunn1/tilix/pull/1507#discussion_r213454953"},"pull_request":{"href":"https://api.github.com/repos/gnunn1/tilix/pulls/1507"}},"in_reply_to_id":213374447},"pull_request":{"url":"https://api.github.com/repos/gnunn1/tilix/pulls/1507","id":211424204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDI0MjA0","html_url":"https://github.com/gnunn1/tilix/pull/1507","diff_url":"https://github.com/gnunn1/tilix/pull/1507.diff","patch_url":"https://github.com/gnunn1/tilix/pull/1507.patch","issue_url":"https://api.github.com/repos/gnunn1/tilix/issues/1507","number":1507,"state":"open","locked":false,"title":"Port to meson","user":{"login":"bilelmoussaoui","id":7660997,"node_id":"MDQ6VXNlcjc2NjA5OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7660997?v=4","gravatar_id":"","url":"https://api.github.com/users/bilelmoussaoui","html_url":"https://github.com/bilelmoussaoui","followers_url":"https://api.github.com/users/bilelmoussaoui/followers","following_url":"https://api.github.com/users/bilelmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bilelmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bilelmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilelmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bilelmoussaoui/orgs","repos_url":"https://api.github.com/users/bilelmoussaoui/repos","events_url":"https://api.github.com/users/bilelmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bilelmoussaoui/received_events","type":"User","site_admin":false},"body":"This a work in progress in order to allow other to play around with #1502 \r\n\r\nWhat doesn't work:\r\n- Still doesn't build correctly, see #1502 \r\n- The translations still need some work\r\n- The man page needs to be installed (need some work in order to translate the man file too). Gettext doesn't support man page yet :/\r\n\r\nBefore merging:\r\n- Update the manual installation instructions on the website and the README file.\r\n- Remove the install.sh & uninstall.sh, which should be handled now by meson. \r\n\r\n","created_at":"2018-08-28T13:33:09Z","updated_at":"2018-08-28T20:09:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc71994bc67bcac97a2cd9afdfd47e9df868ffa3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnunn1/tilix/pulls/1507/commits","review_comments_url":"https://api.github.com/repos/gnunn1/tilix/pulls/1507/comments","review_comment_url":"https://api.github.com/repos/gnunn1/tilix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnunn1/tilix/issues/1507/comments","statuses_url":"https://api.github.com/repos/gnunn1/tilix/statuses/6cba881159ffba4bf4bdbdf911850a130d4b73be","head":{"label":"bilelmoussaoui:meson","ref":"meson","sha":"6cba881159ffba4bf4bdbdf911850a130d4b73be","user":{"login":"bilelmoussaoui","id":7660997,"node_id":"MDQ6VXNlcjc2NjA5OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7660997?v=4","gravatar_id":"","url":"https://api.github.com/users/bilelmoussaoui","html_url":"https://github.com/bilelmoussaoui","followers_url":"https://api.github.com/users/bilelmoussaoui/followers","following_url":"https://api.github.com/users/bilelmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bilelmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bilelmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilelmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bilelmoussaoui/orgs","repos_url":"https://api.github.com/users/bilelmoussaoui/repos","events_url":"https://api.github.com/users/bilelmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bilelmoussaoui/received_events","type":"User","site_admin":false},"repo":{"id":146446988,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0NDY5ODg=","name":"tilix","full_name":"bilelmoussaoui/tilix","owner":{"login":"bilelmoussaoui","id":7660997,"node_id":"MDQ6VXNlcjc2NjA5OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7660997?v=4","gravatar_id":"","url":"https://api.github.com/users/bilelmoussaoui","html_url":"https://github.com/bilelmoussaoui","followers_url":"https://api.github.com/users/bilelmoussaoui/followers","following_url":"https://api.github.com/users/bilelmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bilelmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bilelmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilelmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bilelmoussaoui/orgs","repos_url":"https://api.github.com/users/bilelmoussaoui/repos","events_url":"https://api.github.com/users/bilelmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bilelmoussaoui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bilelmoussaoui/tilix","description":"A tiling terminal emulator for Linux using GTK+ 3","fork":true,"url":"https://api.github.com/repos/bilelmoussaoui/tilix","forks_url":"https://api.github.com/repos/bilelmoussaoui/tilix/forks","keys_url":"https://api.github.com/repos/bilelmoussaoui/tilix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bilelmoussaoui/tilix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bilelmoussaoui/tilix/teams","hooks_url":"https://api.github.com/repos/bilelmoussaoui/tilix/hooks","issue_events_url":"https://api.github.com/repos/bilelmoussaoui/tilix/issues/events{/number}","events_url":"https://api.github.com/repos/bilelmoussaoui/tilix/events","assignees_url":"https://api.github.com/repos/bilelmoussaoui/tilix/assignees{/user}","branches_url":"https://api.github.com/repos/bilelmoussaoui/tilix/branches{/branch}","tags_url":"https://api.github.com/repos/bilelmoussaoui/tilix/tags","blobs_url":"https://api.github.com/repos/bilelmoussaoui/tilix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bilelmoussaoui/tilix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bilelmoussaoui/tilix/git/refs{/sha}","trees_url":"https://api.github.com/repos/bilelmoussaoui/tilix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bilelmoussaoui/tilix/statuses/{sha}","languages_url":"https://api.github.com/repos/bilelmoussaoui/tilix/languages","stargazers_url":"https://api.github.com/repos/bilelmoussaoui/tilix/stargazers","contributors_url":"https://api.github.com/repos/bilelmoussaoui/tilix/contributors","subscribers_url":"https://api.github.com/repos/bilelmoussaoui/tilix/subscribers","subscription_url":"https://api.github.com/repos/bilelmoussaoui/tilix/subscription","commits_url":"https://api.github.com/repos/bilelmoussaoui/tilix/commits{/sha}","git_commits_url":"https://api.github.com/repos/bilelmoussaoui/tilix/git/commits{/sha}","comments_url":"https://api.github.com/repos/bilelmoussaoui/tilix/comments{/number}","issue_comment_url":"https://api.github.com/repos/bilelmoussaoui/tilix/issues/comments{/number}","contents_url":"https://api.github.com/repos/bilelmoussaoui/tilix/contents/{+path}","compare_url":"https://api.github.com/repos/bilelmoussaoui/tilix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bilelmoussaoui/tilix/merges","archive_url":"https://api.github.com/repos/bilelmoussaoui/tilix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bilelmoussaoui/tilix/downloads","issues_url":"https://api.github.com/repos/bilelmoussaoui/tilix/issues{/number}","pulls_url":"https://api.github.com/repos/bilelmoussaoui/tilix/pulls{/number}","milestones_url":"https://api.github.com/repos/bilelmoussaoui/tilix/milestones{/number}","notifications_url":"https://api.github.com/repos/bilelmoussaoui/tilix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bilelmoussaoui/tilix/labels{/name}","releases_url":"https://api.github.com/repos/bilelmoussaoui/tilix/releases{/id}","deployments_url":"https://api.github.com/repos/bilelmoussaoui/tilix/deployments","created_at":"2018-08-28T12:51:48Z","updated_at":"2018-08-28T12:51:51Z","pushed_at":"2018-08-28T19:24:48Z","git_url":"git://github.com/bilelmoussaoui/tilix.git","ssh_url":"git@github.com:bilelmoussaoui/tilix.git","clone_url":"https://github.com/bilelmoussaoui/tilix.git","svn_url":"https://github.com/bilelmoussaoui/tilix","homepage":"https://gnunn1.github.io/tilix-web","size":14987,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gnunn1:master","ref":"master","sha":"f5289d3aa6f0995986fd36d825b6fd0db4ad5cc2","user":{"login":"gnunn1","id":9358238,"node_id":"MDQ6VXNlcjkzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9358238?v=4","gravatar_id":"","url":"https://api.github.com/users/gnunn1","html_url":"https://github.com/gnunn1","followers_url":"https://api.github.com/users/gnunn1/followers","following_url":"https://api.github.com/users/gnunn1/following{/other_user}","gists_url":"https://api.github.com/users/gnunn1/gists{/gist_id}","starred_url":"https://api.github.com/users/gnunn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnunn1/subscriptions","organizations_url":"https://api.github.com/users/gnunn1/orgs","repos_url":"https://api.github.com/users/gnunn1/repos","events_url":"https://api.github.com/users/gnunn1/events{/privacy}","received_events_url":"https://api.github.com/users/gnunn1/received_events","type":"User","site_admin":false},"repo":{"id":48780523,"node_id":"MDEwOlJlcG9zaXRvcnk0ODc4MDUyMw==","name":"tilix","full_name":"gnunn1/tilix","owner":{"login":"gnunn1","id":9358238,"node_id":"MDQ6VXNlcjkzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9358238?v=4","gravatar_id":"","url":"https://api.github.com/users/gnunn1","html_url":"https://github.com/gnunn1","followers_url":"https://api.github.com/users/gnunn1/followers","following_url":"https://api.github.com/users/gnunn1/following{/other_user}","gists_url":"https://api.github.com/users/gnunn1/gists{/gist_id}","starred_url":"https://api.github.com/users/gnunn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnunn1/subscriptions","organizations_url":"https://api.github.com/users/gnunn1/orgs","repos_url":"https://api.github.com/users/gnunn1/repos","events_url":"https://api.github.com/users/gnunn1/events{/privacy}","received_events_url":"https://api.github.com/users/gnunn1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gnunn1/tilix","description":"A tiling terminal emulator for Linux using GTK+ 3","fork":false,"url":"https://api.github.com/repos/gnunn1/tilix","forks_url":"https://api.github.com/repos/gnunn1/tilix/forks","keys_url":"https://api.github.com/repos/gnunn1/tilix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnunn1/tilix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnunn1/tilix/teams","hooks_url":"https://api.github.com/repos/gnunn1/tilix/hooks","issue_events_url":"https://api.github.com/repos/gnunn1/tilix/issues/events{/number}","events_url":"https://api.github.com/repos/gnunn1/tilix/events","assignees_url":"https://api.github.com/repos/gnunn1/tilix/assignees{/user}","branches_url":"https://api.github.com/repos/gnunn1/tilix/branches{/branch}","tags_url":"https://api.github.com/repos/gnunn1/tilix/tags","blobs_url":"https://api.github.com/repos/gnunn1/tilix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnunn1/tilix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnunn1/tilix/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnunn1/tilix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnunn1/tilix/statuses/{sha}","languages_url":"https://api.github.com/repos/gnunn1/tilix/languages","stargazers_url":"https://api.github.com/repos/gnunn1/tilix/stargazers","contributors_url":"https://api.github.com/repos/gnunn1/tilix/contributors","subscribers_url":"https://api.github.com/repos/gnunn1/tilix/subscribers","subscription_url":"https://api.github.com/repos/gnunn1/tilix/subscription","commits_url":"https://api.github.com/repos/gnunn1/tilix/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnunn1/tilix/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnunn1/tilix/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnunn1/tilix/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnunn1/tilix/contents/{+path}","compare_url":"https://api.github.com/repos/gnunn1/tilix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnunn1/tilix/merges","archive_url":"https://api.github.com/repos/gnunn1/tilix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnunn1/tilix/downloads","issues_url":"https://api.github.com/repos/gnunn1/tilix/issues{/number}","pulls_url":"https://api.github.com/repos/gnunn1/tilix/pulls{/number}","milestones_url":"https://api.github.com/repos/gnunn1/tilix/milestones{/number}","notifications_url":"https://api.github.com/repos/gnunn1/tilix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnunn1/tilix/labels{/name}","releases_url":"https://api.github.com/repos/gnunn1/tilix/releases{/id}","deployments_url":"https://api.github.com/repos/gnunn1/tilix/deployments","created_at":"2015-12-30T03:48:32Z","updated_at":"2018-08-28T15:24:47Z","pushed_at":"2018-08-28T19:24:49Z","git_url":"git://github.com/gnunn1/tilix.git","ssh_url":"git@github.com:gnunn1/tilix.git","clone_url":"https://github.com/gnunn1/tilix.git","svn_url":"https://github.com/gnunn1/tilix","homepage":"https://gnunn1.github.io/tilix-web","size":14742,"stargazers_count":2595,"watchers_count":2595,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":136,"open_issues":43,"watchers":2595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnunn1/tilix/pulls/1507"},"html":{"href":"https://github.com/gnunn1/tilix/pull/1507"},"issue":{"href":"https://api.github.com/repos/gnunn1/tilix/issues/1507"},"comments":{"href":"https://api.github.com/repos/gnunn1/tilix/issues/1507/comments"},"review_comments":{"href":"https://api.github.com/repos/gnunn1/tilix/pulls/1507/comments"},"review_comment":{"href":"https://api.github.com/repos/gnunn1/tilix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnunn1/tilix/pulls/1507/commits"},"statuses":{"href":"https://api.github.com/repos/gnunn1/tilix/statuses/6cba881159ffba4bf4bdbdf911850a130d4b73be"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ximion"}}