{"action":"opened","number":1178,"pull_request":{"url":"https://api.github.com/repos/swaponline/swap.react/pulls/1178","id":240589315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTg5MzE1","html_url":"https://github.com/swaponline/swap.react/pull/1178","diff_url":"https://github.com/swaponline/swap.react/pull/1178.diff","patch_url":"https://github.com/swaponline/swap.react/pull/1178.patch","issue_url":"https://api.github.com/repos/swaponline/swap.react/issues/1178","number":1178,"state":"open","locked":false,"title":"Widget","user":{"login":"shendel","id":1880211,"node_id":"MDQ6VXNlcjE4ODAyMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1880211?v=4","gravatar_id":"","url":"https://api.github.com/users/shendel","html_url":"https://github.com/shendel","followers_url":"https://api.github.com/users/shendel/followers","following_url":"https://api.github.com/users/shendel/following{/other_user}","gists_url":"https://api.github.com/users/shendel/gists{/gist_id}","starred_url":"https://api.github.com/users/shendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shendel/subscriptions","organizations_url":"https://api.github.com/users/shendel/orgs","repos_url":"https://api.github.com/users/shendel/repos","events_url":"https://api.github.com/users/shendel/events{/privacy}","received_events_url":"https://api.github.com/users/shendel/received_events","type":"User","site_admin":false},"body":"# Pull request template\r\n\r\n## Checklist\r\n\r\nНе мержить. Предложения и конструктивная критика.\r\nИшью-таск https://github.com/swaponline/swap.react/issues/967\r\n\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/swaponline/swap.react/wiki/CONTRIBUTING) guide\r\n- [ ] branch rebased on `develop`\r\n- [ ] styleguide check `npm run validate`\r\n- [ ] good naming\r\n- [ ] keep simple\r\n- [ ] video or screenshot attached\r\n- [ ] testing instruction attached\r\n- [ ] check your PR once again\r\n\r\n\r\n### Description\r\nДобавил три команды сборки\r\nОтладка на localhost:9001\r\nnpm run dev:testnet-widget do 0x49feeF410293261c04F1d14600Ba427F8eED8723 syc2 2 Synexcoin2\r\n- do просто \"do\"\r\n- адрес контракта\r\n- код в коре\r\n- кол-во символов\r\n- понятное название \"_\" заменяются пробелами - Super_Coin будет \"Super Coin\"\r\n\r\nБилд в тестнете\r\nnpm run build:testnet-widget 0x49feeF410293261c04F1d14600Ba427F8eED8723 syc2 2 Synexcoin2\r\n- адрес контракта\r\n- код в коре\r\n- кол-во символов\r\n- понятное название\r\n\r\nБилд в маиннете\r\nnpm run build:mainnet-widget 0x49feeF410293261c04F1d14600Ba427F8eED8723 syc2 2 Synexcoin2\r\n- адрес контракта\r\n- код в коре\r\n- кол-во символов\r\n- понятное название\r\n\r\nВид сборки, доступность функций определяет по конфигурации (config.isWidget) https://github.com/shendel/swap.react/blob/714460e4c187b8fe30c7f73721dcb44529d80cc2/config/testnet.widget.dev.js#L23\r\n\r\nСделал \"заглушкой\" проход ошибки загрузки токенов (реакт не грузиться если нет токена \"Swap\" https://github.com/swaponline/swap.react/blob/0787b17220ff307f0f76ae11f37d6ab928633058/shared/containers/App/App.js#L38 -> https://github.com/swaponline/swap.react/blob/0787b17220ff307f0f76ae11f37d6ab928633058/shared/containers/App/App.js#L99) \r\n\r\nУбрал шапку с футером (https://github.com/swaponline/swap.react/blob/714460e4c187b8fe30c7f73721dcb44529d80cc2/shared/components/Footer/Footer.js#L19)\r\n\r\nВ процессе....\r\n- стандартный роутинг на /exchange\r\n- валюты свопа (сейчас доступны комбинации eos, ltc итд https://github.com/swaponline/swap.react/blob/714460e4c187b8fe30c7f73721dcb44529d80cc2/shared/redux/reducers/currencies.js#L43)\r\n\r\n### Video or screenshot\r\n\r\n\r\n### What and how to test\r\n\r\nПри обычном заходе по собранный ПР должно работать как на testnet\r\nПри ручной сборке\r\nnpm run dev:testnet-widget **DO** АдресКонтракта КодВКоре КолВоСимволов Название_Для_Людей\r\nпо адресу localhost:9001 должно открывать страницу кошелька без шапки и футера, из валют должны быть доступны btc/eth/eos/ltc + указанный токен\r\nПри ручном переходе на localhost:9001/exchange должно открывать старницу partial с возможностью свапа по указанным выше валютам, свап должен проходить\r\n\r\nПри ручной сборке\r\nnpm run build:testnet-widget АдресКонтракта КодВКоре КолВоСимволов Название_Для_Людей\r\nдолжен пройти успешный билд\r\nВ корневой папке \"build-testnet\" должен появиться билд\r\nПри запуске билда на сервере (на прямую в браузере еще не работает по причине HistoryApi.Push) должен открыться кошелек с балансами без шапки и футера - далее как и с тестнет. Список валют должен быть btc/eth/eos/ltc + указанный токен, при ручном переходе на /echange должен работать свап\r\n\r\nПри ручной сборке \r\nnpm run build:mainnet-widget АдресКонракта КодВКоре КолвоСимволов Название_Для_Людей\r\nДолжен появиться билд в папке \"build-mainnet\". Дальше по пунктам выше + USDT\r\n","created_at":"2018-12-21T22:19:20Z","updated_at":"2018-12-21T22:19:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swaponline/swap.react/pulls/1178/commits","review_comments_url":"https://api.github.com/repos/swaponline/swap.react/pulls/1178/comments","review_comment_url":"https://api.github.com/repos/swaponline/swap.react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swaponline/swap.react/issues/1178/comments","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/714460e4c187b8fe30c7f73721dcb44529d80cc2","head":{"label":"shendel:Widget","ref":"Widget","sha":"714460e4c187b8fe30c7f73721dcb44529d80cc2","user":{"login":"shendel","id":1880211,"node_id":"MDQ6VXNlcjE4ODAyMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1880211?v=4","gravatar_id":"","url":"https://api.github.com/users/shendel","html_url":"https://github.com/shendel","followers_url":"https://api.github.com/users/shendel/followers","following_url":"https://api.github.com/users/shendel/following{/other_user}","gists_url":"https://api.github.com/users/shendel/gists{/gist_id}","starred_url":"https://api.github.com/users/shendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shendel/subscriptions","organizations_url":"https://api.github.com/users/shendel/orgs","repos_url":"https://api.github.com/users/shendel/repos","events_url":"https://api.github.com/users/shendel/events{/privacy}","received_events_url":"https://api.github.com/users/shendel/received_events","type":"User","site_admin":false},"repo":{"id":157577031,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1NzcwMzE=","name":"swap.react","full_name":"shendel/swap.react","private":false,"owner":{"login":"shendel","id":1880211,"node_id":"MDQ6VXNlcjE4ODAyMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1880211?v=4","gravatar_id":"","url":"https://api.github.com/users/shendel","html_url":"https://github.com/shendel","followers_url":"https://api.github.com/users/shendel/followers","following_url":"https://api.github.com/users/shendel/following{/other_user}","gists_url":"https://api.github.com/users/shendel/gists{/gist_id}","starred_url":"https://api.github.com/users/shendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shendel/subscriptions","organizations_url":"https://api.github.com/users/shendel/orgs","repos_url":"https://api.github.com/users/shendel/repos","events_url":"https://api.github.com/users/shendel/events{/privacy}","received_events_url":"https://api.github.com/users/shendel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shendel/swap.react","description":"develop branch --> https://testnet.swap.online :) In-browser atomic swap exchange based on swap.core library. It is an implementation of Swap DEP crosschain protocol. Hosted at https://swap.online","fork":true,"url":"https://api.github.com/repos/shendel/swap.react","forks_url":"https://api.github.com/repos/shendel/swap.react/forks","keys_url":"https://api.github.com/repos/shendel/swap.react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shendel/swap.react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shendel/swap.react/teams","hooks_url":"https://api.github.com/repos/shendel/swap.react/hooks","issue_events_url":"https://api.github.com/repos/shendel/swap.react/issues/events{/number}","events_url":"https://api.github.com/repos/shendel/swap.react/events","assignees_url":"https://api.github.com/repos/shendel/swap.react/assignees{/user}","branches_url":"https://api.github.com/repos/shendel/swap.react/branches{/branch}","tags_url":"https://api.github.com/repos/shendel/swap.react/tags","blobs_url":"https://api.github.com/repos/shendel/swap.react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shendel/swap.react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shendel/swap.react/git/refs{/sha}","trees_url":"https://api.github.com/repos/shendel/swap.react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shendel/swap.react/statuses/{sha}","languages_url":"https://api.github.com/repos/shendel/swap.react/languages","stargazers_url":"https://api.github.com/repos/shendel/swap.react/stargazers","contributors_url":"https://api.github.com/repos/shendel/swap.react/contributors","subscribers_url":"https://api.github.com/repos/shendel/swap.react/subscribers","subscription_url":"https://api.github.com/repos/shendel/swap.react/subscription","commits_url":"https://api.github.com/repos/shendel/swap.react/commits{/sha}","git_commits_url":"https://api.github.com/repos/shendel/swap.react/git/commits{/sha}","comments_url":"https://api.github.com/repos/shendel/swap.react/comments{/number}","issue_comment_url":"https://api.github.com/repos/shendel/swap.react/issues/comments{/number}","contents_url":"https://api.github.com/repos/shendel/swap.react/contents/{+path}","compare_url":"https://api.github.com/repos/shendel/swap.react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shendel/swap.react/merges","archive_url":"https://api.github.com/repos/shendel/swap.react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shendel/swap.react/downloads","issues_url":"https://api.github.com/repos/shendel/swap.react/issues{/number}","pulls_url":"https://api.github.com/repos/shendel/swap.react/pulls{/number}","milestones_url":"https://api.github.com/repos/shendel/swap.react/milestones{/number}","notifications_url":"https://api.github.com/repos/shendel/swap.react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shendel/swap.react/labels{/name}","releases_url":"https://api.github.com/repos/shendel/swap.react/releases{/id}","deployments_url":"https://api.github.com/repos/shendel/swap.react/deployments","created_at":"2018-11-14T16:22:24Z","updated_at":"2018-12-21T14:01:18Z","pushed_at":"2018-12-21T17:12:40Z","git_url":"git://github.com/shendel/swap.react.git","ssh_url":"git@github.com:shendel/swap.react.git","clone_url":"https://github.com/shendel/swap.react.git","svn_url":"https://github.com/shendel/swap.react","homepage":"https://swap.online","size":14704,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swaponline:develop","ref":"develop","sha":"e2fcd38286028b1d4194289c3316775ff091635a","user":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"repo":{"id":130675402,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2NzU0MDI=","name":"swap.react","full_name":"swaponline/swap.react","private":false,"owner":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/swaponline/swap.react","description":"develop branch --> https://testnet.swap.online :) In-browser atomic swap exchange based on swap.core library. It is an implementation of Swap DEP crosschain protocol. Hosted at https://swap.online","fork":false,"url":"https://api.github.com/repos/swaponline/swap.react","forks_url":"https://api.github.com/repos/swaponline/swap.react/forks","keys_url":"https://api.github.com/repos/swaponline/swap.react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaponline/swap.react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaponline/swap.react/teams","hooks_url":"https://api.github.com/repos/swaponline/swap.react/hooks","issue_events_url":"https://api.github.com/repos/swaponline/swap.react/issues/events{/number}","events_url":"https://api.github.com/repos/swaponline/swap.react/events","assignees_url":"https://api.github.com/repos/swaponline/swap.react/assignees{/user}","branches_url":"https://api.github.com/repos/swaponline/swap.react/branches{/branch}","tags_url":"https://api.github.com/repos/swaponline/swap.react/tags","blobs_url":"https://api.github.com/repos/swaponline/swap.react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaponline/swap.react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaponline/swap.react/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaponline/swap.react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/{sha}","languages_url":"https://api.github.com/repos/swaponline/swap.react/languages","stargazers_url":"https://api.github.com/repos/swaponline/swap.react/stargazers","contributors_url":"https://api.github.com/repos/swaponline/swap.react/contributors","subscribers_url":"https://api.github.com/repos/swaponline/swap.react/subscribers","subscription_url":"https://api.github.com/repos/swaponline/swap.react/subscription","commits_url":"https://api.github.com/repos/swaponline/swap.react/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaponline/swap.react/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaponline/swap.react/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaponline/swap.react/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaponline/swap.react/contents/{+path}","compare_url":"https://api.github.com/repos/swaponline/swap.react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaponline/swap.react/merges","archive_url":"https://api.github.com/repos/swaponline/swap.react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaponline/swap.react/downloads","issues_url":"https://api.github.com/repos/swaponline/swap.react/issues{/number}","pulls_url":"https://api.github.com/repos/swaponline/swap.react/pulls{/number}","milestones_url":"https://api.github.com/repos/swaponline/swap.react/milestones{/number}","notifications_url":"https://api.github.com/repos/swaponline/swap.react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaponline/swap.react/labels{/name}","releases_url":"https://api.github.com/repos/swaponline/swap.react/releases{/id}","deployments_url":"https://api.github.com/repos/swaponline/swap.react/deployments","created_at":"2018-04-23T09:48:44Z","updated_at":"2018-12-18T06:07:23Z","pushed_at":"2018-12-21T13:49:22Z","git_url":"git://github.com/swaponline/swap.react.git","ssh_url":"git@github.com:swaponline/swap.react.git","clone_url":"https://github.com/swaponline/swap.react.git","svn_url":"https://github.com/swaponline/swap.react","homepage":"https://swap.online","size":14988,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":34,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/1178"},"html":{"href":"https://github.com/swaponline/swap.react/pull/1178"},"issue":{"href":"https://api.github.com/repos/swaponline/swap.react/issues/1178"},"comments":{"href":"https://api.github.com/repos/swaponline/swap.react/issues/1178/comments"},"review_comments":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/1178/comments"},"review_comment":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/1178/commits"},"statuses":{"href":"https://api.github.com/repos/swaponline/swap.react/statuses/714460e4c187b8fe30c7f73721dcb44529d80cc2"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":87,"deletions":3,"changed_files":7}}
{"actor":{"display_login":"shendel"}}