{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/239234108","pull_request_review_id":181968984,"id":239234108,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTIzNDEwOA==","diff_hunk":"@@ -36,24 +40,76 @@ func (t *TerraformVariables) Dependencies() []asset.Asset {\n \t\t&installconfig.InstallConfig{},\n \t\t&bootstrap.Bootstrap{},\n \t\t&machine.Master{},\n+\t\t&machines.Master{},\n \t}\n }\n \n // Generate generates the terraform.tfvars file.\n func (t *TerraformVariables) Generate(parents asset.Parents) error {\n \tinstallConfig := &installconfig.InstallConfig{}\n-\tbootstrap := &bootstrap.Bootstrap{}\n-\tmaster := &machine.Master{}\n-\tparents.Get(installConfig, bootstrap, master)\n+\tbootstrapIgnAsset := &bootstrap.Bootstrap{}\n+\tmasterIgnAsset := &machine.Master{}\n+\tmastersAsset := &machines.Master{}\n+\tparents.Get(installConfig, bootstrapIgnAsset, masterIgnAsset, mastersAsset)\n \n-\tbootstrapIgn := string(bootstrap.Files()[0].Data)\n+\tbootstrapIgn := string(bootstrapIgnAsset.Files()[0].Data)\n \n-\tmasterIgn := string(master.Files()[0].Data)\n+\tmasterIgn := string(masterIgnAsset.Files()[0].Data)\n \n-\tdata, err := tfvars.TFVars(installConfig.Config, bootstrapIgn, masterIgn)\n+\tvar mastersList metav1.List\n+\terr := yaml.Unmarshal(mastersAsset.MachinesRaw, &mastersList)","path":"pkg/asset/cluster/tfvars.go","position":44,"original_position":44,"commit_id":"270da620fa02a38895ea3ca54f0dcfaaacbf0e83","original_commit_id":"270da620fa02a38895ea3ca54f0dcfaaacbf0e83","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":"can we change the master asset to be typed.. no need for this unamrshal? There were no consumers for that before, might be good time to add it...","created_at":"2018-12-05T20:56:34Z","updated_at":"2018-12-05T20:56:35Z","html_url":"https://github.com/openshift/installer/pull/792#discussion_r239234108","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/792","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/239234108"},"html":{"href":"https://github.com/openshift/installer/pull/792#discussion_r239234108"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/792"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/792","id":236283773,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjgzNzcz","html_url":"https://github.com/openshift/installer/pull/792","diff_url":"https://github.com/openshift/installer/pull/792.diff","patch_url":"https://github.com/openshift/installer/pull/792.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/792","number":792,"state":"open","locked":false,"title":"WIP: pkg/tfvars: Pull from []Machine instead of InstallConfig","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"The previous implementation pulled from the install-config, but that missed downstream changes like AWS instance type defaults being applied in `pkg/asset/machines`.  With this commit, we pull that information from the cluster-API types, since they're the last touch point for that data.  The remaining information still comes from the `InstallConfig`, but I've split it into explicit arguments to avoid confusion about where data is coming from when `InstallConfig`'s machine pools, etc. overlap with `clusterapi.Machine` fields.\n\nThis is a WIP because there are some FIXMEs around cluster-API support for some of the settings we're currently configuring in `InstallConfig` machine pools.","created_at":"2018-12-05T18:50:08Z","updated_at":"2018-12-05T20:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5daf669f5ee71242cf72c5138af3878f4c864176","assignee":null,"assignees":[],"requested_reviewers":[{"login":"flaper87","id":13816,"node_id":"MDQ6VXNlcjEzODE2","avatar_url":"https://avatars0.githubusercontent.com/u/13816?v=4","gravatar_id":"","url":"https://api.github.com/users/flaper87","html_url":"https://github.com/flaper87","followers_url":"https://api.github.com/users/flaper87/followers","following_url":"https://api.github.com/users/flaper87/following{/other_user}","gists_url":"https://api.github.com/users/flaper87/gists{/gist_id}","starred_url":"https://api.github.com/users/flaper87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaper87/subscriptions","organizations_url":"https://api.github.com/users/flaper87/orgs","repos_url":"https://api.github.com/users/flaper87/repos","events_url":"https://api.github.com/users/flaper87/events{/privacy}","received_events_url":"https://api.github.com/users/flaper87/received_events","type":"User","site_admin":false},{"login":"hardys","id":1325867,"node_id":"MDQ6VXNlcjEzMjU4Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1325867?v=4","gravatar_id":"","url":"https://api.github.com/users/hardys","html_url":"https://github.com/hardys","followers_url":"https://api.github.com/users/hardys/followers","following_url":"https://api.github.com/users/hardys/following{/other_user}","gists_url":"https://api.github.com/users/hardys/gists{/gist_id}","starred_url":"https://api.github.com/users/hardys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardys/subscriptions","organizations_url":"https://api.github.com/users/hardys/orgs","repos_url":"https://api.github.com/users/hardys/repos","events_url":"https://api.github.com/users/hardys/events{/privacy}","received_events_url":"https://api.github.com/users/hardys/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959731323,"node_id":"MDU6TGFiZWw5NTk3MzEzMjM=","url":"https://api.github.com/repos/openshift/installer/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":959732835,"node_id":"MDU6TGFiZWw5NTk3MzI4MzU=","url":"https://api.github.com/repos/openshift/installer/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/792/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/792/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/792/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/270da620fa02a38895ea3ca54f0dcfaaacbf0e83","head":{"label":"wking:tfvars-from-machines","ref":"tfvars-from-machines","sha":"270da620fa02a38895ea3ca54f0dcfaaacbf0e83","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"repo":{"id":140026813,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMjY4MTM=","name":"openshift-installer","full_name":"wking/openshift-installer","private":false,"owner":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wking/openshift-installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/wking/openshift-installer","forks_url":"https://api.github.com/repos/wking/openshift-installer/forks","keys_url":"https://api.github.com/repos/wking/openshift-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wking/openshift-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wking/openshift-installer/teams","hooks_url":"https://api.github.com/repos/wking/openshift-installer/hooks","issue_events_url":"https://api.github.com/repos/wking/openshift-installer/issues/events{/number}","events_url":"https://api.github.com/repos/wking/openshift-installer/events","assignees_url":"https://api.github.com/repos/wking/openshift-installer/assignees{/user}","branches_url":"https://api.github.com/repos/wking/openshift-installer/branches{/branch}","tags_url":"https://api.github.com/repos/wking/openshift-installer/tags","blobs_url":"https://api.github.com/repos/wking/openshift-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wking/openshift-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wking/openshift-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/wking/openshift-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wking/openshift-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/wking/openshift-installer/languages","stargazers_url":"https://api.github.com/repos/wking/openshift-installer/stargazers","contributors_url":"https://api.github.com/repos/wking/openshift-installer/contributors","subscribers_url":"https://api.github.com/repos/wking/openshift-installer/subscribers","subscription_url":"https://api.github.com/repos/wking/openshift-installer/subscription","commits_url":"https://api.github.com/repos/wking/openshift-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/wking/openshift-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/wking/openshift-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/wking/openshift-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/wking/openshift-installer/contents/{+path}","compare_url":"https://api.github.com/repos/wking/openshift-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wking/openshift-installer/merges","archive_url":"https://api.github.com/repos/wking/openshift-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wking/openshift-installer/downloads","issues_url":"https://api.github.com/repos/wking/openshift-installer/issues{/number}","pulls_url":"https://api.github.com/repos/wking/openshift-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/wking/openshift-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/wking/openshift-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wking/openshift-installer/labels{/name}","releases_url":"https://api.github.com/repos/wking/openshift-installer/releases{/id}","deployments_url":"https://api.github.com/repos/wking/openshift-installer/deployments","created_at":"2018-07-06T20:26:48Z","updated_at":"2018-12-05T18:33:36Z","pushed_at":"2018-12-05T20:55:35Z","git_url":"git://github.com/wking/openshift-installer.git","ssh_url":"git@github.com:wking/openshift-installer.git","clone_url":"https://github.com/wking/openshift-installer.git","svn_url":"https://github.com/wking/openshift-installer","homepage":"","size":45561,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"57d91803fad0b92a5d742b0203478d4e92b10849","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-12-05T19:31:50Z","pushed_at":"2018-12-05T20:55:36Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":44167,"stargazers_count":123,"watchers_count":123,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":119,"open_issues":93,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/792"},"html":{"href":"https://github.com/openshift/installer/pull/792"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/792"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/792/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/792/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/792/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/270da620fa02a38895ea3ca54f0dcfaaacbf0e83"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abhinavdahiya"}}