{"action":"created","issue":{"url":"https://api.github.com/repos/Brightspace/d2l-opt-in-flyout-webcomponent/issues/8","repository_url":"https://api.github.com/repos/Brightspace/d2l-opt-in-flyout-webcomponent","labels_url":"https://api.github.com/repos/Brightspace/d2l-opt-in-flyout-webcomponent/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/Brightspace/d2l-opt-in-flyout-webcomponent/issues/8/comments","events_url":"https://api.github.com/repos/Brightspace/d2l-opt-in-flyout-webcomponent/issues/8/events","html_url":"https://github.com/Brightspace/d2l-opt-in-flyout-webcomponent/pull/8","id":393483716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNDkzMzUy","number":8,"title":"Pre polymer3","user":{"login":"margaree","id":6804600,"node_id":"MDQ6VXNlcjY4MDQ2MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6804600?v=4","gravatar_id":"","url":"https://api.github.com/users/margaree","html_url":"https://github.com/margaree","followers_url":"https://api.github.com/users/margaree/followers","following_url":"https://api.github.com/users/margaree/following{/other_user}","gists_url":"https://api.github.com/users/margaree/gists{/gist_id}","starred_url":"https://api.github.com/users/margaree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margaree/subscriptions","organizations_url":"https://api.github.com/users/margaree/orgs","repos_url":"https://api.github.com/users/margaree/repos","events_url":"https://api.github.com/users/margaree/events{/privacy}","received_events_url":"https://api.github.com/users/margaree/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-21T14:47:27Z","updated_at":"2018-12-21T16:44:30Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-opt-in-flyout-webcomponent/pulls/8","html_url":"https://github.com/Brightspace/d2l-opt-in-flyout-webcomponent/pull/8","diff_url":"https://github.com/Brightspace/d2l-opt-in-flyout-webcomponent/pull/8.diff","patch_url":"https://github.com/Brightspace/d2l-opt-in-flyout-webcomponent/pull/8.patch"},"body":"Changes:\r\n- updated structure/regularly used files to be a bit more similar to other repos, and added travis\r\n- index.html was moved to demo/index.html, since polymer 3 converter deletes index.html. The demos can now be navigated to by adding /demo to the end of the url.\r\n- pre-fixed some lint problems that are noticed post-conversion\r\n- added some tests in order to somewhat have confidence that things don't break during conversion, and so that all files actually convert\r\n- 2 code logic changes were made due to test results\r\n    - a test failed in polymer 1 because `d2l-opt-out-flyout` always used opt-in wording (“The new experience is turned off.”)\r\n    - if only tutorialLink was specified and not helpDocLink (and probably vice versa? I can’t remember), there would still be 2 links in the text, one just wouldn’t be visible, but it could still be tabbed to and if I pressed enter then it would navigate to the link that was specified for tutorialLink. I updated the `dom-if` for this just to have a case for 1 link and a case for both links, but I didn’t touch the wording functionality.\r\n"},"comment":{"url":"https://api.github.com/repos/Brightspace/d2l-opt-in-flyout-webcomponent/issues/comments/449438017","html_url":"https://github.com/Brightspace/d2l-opt-in-flyout-webcomponent/pull/8#issuecomment-449438017","issue_url":"https://api.github.com/repos/Brightspace/d2l-opt-in-flyout-webcomponent/issues/8","id":449438017,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQzODAxNw==","user":{"login":"mpharoah-d2l","id":12971370,"node_id":"MDQ6VXNlcjEyOTcxMzcw","avatar_url":"https://avatars2.githubusercontent.com/u/12971370?v=4","gravatar_id":"","url":"https://api.github.com/users/mpharoah-d2l","html_url":"https://github.com/mpharoah-d2l","followers_url":"https://api.github.com/users/mpharoah-d2l/followers","following_url":"https://api.github.com/users/mpharoah-d2l/following{/other_user}","gists_url":"https://api.github.com/users/mpharoah-d2l/gists{/gist_id}","starred_url":"https://api.github.com/users/mpharoah-d2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpharoah-d2l/subscriptions","organizations_url":"https://api.github.com/users/mpharoah-d2l/orgs","repos_url":"https://api.github.com/users/mpharoah-d2l/repos","events_url":"https://api.github.com/users/mpharoah-d2l/events{/privacy}","received_events_url":"https://api.github.com/users/mpharoah-d2l/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T16:44:30Z","updated_at":"2018-12-21T16:44:30Z","author_association":"COLLABORATOR","body":"Is that because `index.html` was moved to demo? Could you maybe make a symlink to it for now so that it still works?"}}
{"actor":{"display_login":"mpharoah-d2l"}}