{"action":"closed","number":6217,"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/6217","id":196079508,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDc5NTA4","html_url":"https://github.com/helm/charts/pull/6217","diff_url":"https://github.com/helm/charts/pull/6217.diff","patch_url":"https://github.com/helm/charts/pull/6217.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/6217","number":6217,"state":"closed","locked":false,"title":"fluent-bit: allow use of hostNetwork","user":{"login":"eviln1","id":12036591,"node_id":"MDQ6VXNlcjEyMDM2NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/12036591?v=4","gravatar_id":"","url":"https://api.github.com/users/eviln1","html_url":"https://github.com/eviln1","followers_url":"https://api.github.com/users/eviln1/followers","following_url":"https://api.github.com/users/eviln1/following{/other_user}","gists_url":"https://api.github.com/users/eviln1/gists{/gist_id}","starred_url":"https://api.github.com/users/eviln1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviln1/subscriptions","organizations_url":"https://api.github.com/users/eviln1/orgs","repos_url":"https://api.github.com/users/eviln1/repos","events_url":"https://api.github.com/users/eviln1/events{/privacy}","received_events_url":"https://api.github.com/users/eviln1/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis PR enables the `DaemonSet` to bind on `hostNetwork`. In our use case, we wish to ship logs to a server which is not reachable (by design) from the Pod network.\r\nAlso, this allows to set `dnsPolicy` which might be required when `hostNetwork` is used.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-06-20T09:43:51Z","updated_at":"2018-12-14T13:44:24Z","closed_at":"2018-12-14T13:44:24Z","merged_at":"2018-12-14T13:44:24Z","merge_commit_sha":"5db16060cee2d792fee5187b021f4a75570b648a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sameersbn","id":410147,"node_id":"MDQ6VXNlcjQxMDE0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/410147?v=4","gravatar_id":"","url":"https://api.github.com/users/sameersbn","html_url":"https://github.com/sameersbn","followers_url":"https://api.github.com/users/sameersbn/followers","following_url":"https://api.github.com/users/sameersbn/following{/other_user}","gists_url":"https://api.github.com/users/sameersbn/gists{/gist_id}","starred_url":"https://api.github.com/users/sameersbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameersbn/subscriptions","organizations_url":"https://api.github.com/users/sameersbn/orgs","repos_url":"https://api.github.com/users/sameersbn/repos","events_url":"https://api.github.com/users/sameersbn/events{/privacy}","received_events_url":"https://api.github.com/users/sameersbn/received_events","type":"User","site_admin":false},{"login":"seanknox","id":1231630,"node_id":"MDQ6VXNlcjEyMzE2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1231630?v=4","gravatar_id":"","url":"https://api.github.com/users/seanknox","html_url":"https://github.com/seanknox","followers_url":"https://api.github.com/users/seanknox/followers","following_url":"https://api.github.com/users/seanknox/following{/other_user}","gists_url":"https://api.github.com/users/seanknox/gists{/gist_id}","starred_url":"https://api.github.com/users/seanknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanknox/subscriptions","organizations_url":"https://api.github.com/users/seanknox/orgs","repos_url":"https://api.github.com/users/seanknox/repos","events_url":"https://api.github.com/users/seanknox/events{/privacy}","received_events_url":"https://api.github.com/users/seanknox/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":764227863,"node_id":"MDU6TGFiZWw3NjQyMjc4NjM=","url":"https://api.github.com/repos/helm/charts/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":352669720,"node_id":"MDU6TGFiZWwzNTI2Njk3MjA=","url":"https://api.github.com/repos/helm/charts/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":676009699,"node_id":"MDU6TGFiZWw2NzYwMDk2OTk=","url":"https://api.github.com/repos/helm/charts/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/6217/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/6217/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/6217/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/e305c76004481b2526c2068ff38b1170bb002241","head":{"label":"Polyconseil:fluent-bit/hostnetwork","ref":"fluent-bit/hostnetwork","sha":"e305c76004481b2526c2068ff38b1170bb002241","user":{"login":"Polyconseil","id":818669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxODY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/818669?v=4","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"repo":{"id":127303485,"node_id":"MDEwOlJlcG9zaXRvcnkxMjczMDM0ODU=","name":"charts","full_name":"Polyconseil/charts","private":false,"owner":{"login":"Polyconseil","id":818669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxODY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/818669?v=4","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Polyconseil/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/Polyconseil/charts","forks_url":"https://api.github.com/repos/Polyconseil/charts/forks","keys_url":"https://api.github.com/repos/Polyconseil/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polyconseil/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polyconseil/charts/teams","hooks_url":"https://api.github.com/repos/Polyconseil/charts/hooks","issue_events_url":"https://api.github.com/repos/Polyconseil/charts/issues/events{/number}","events_url":"https://api.github.com/repos/Polyconseil/charts/events","assignees_url":"https://api.github.com/repos/Polyconseil/charts/assignees{/user}","branches_url":"https://api.github.com/repos/Polyconseil/charts/branches{/branch}","tags_url":"https://api.github.com/repos/Polyconseil/charts/tags","blobs_url":"https://api.github.com/repos/Polyconseil/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polyconseil/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polyconseil/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polyconseil/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polyconseil/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Polyconseil/charts/languages","stargazers_url":"https://api.github.com/repos/Polyconseil/charts/stargazers","contributors_url":"https://api.github.com/repos/Polyconseil/charts/contributors","subscribers_url":"https://api.github.com/repos/Polyconseil/charts/subscribers","subscription_url":"https://api.github.com/repos/Polyconseil/charts/subscription","commits_url":"https://api.github.com/repos/Polyconseil/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polyconseil/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polyconseil/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polyconseil/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polyconseil/charts/contents/{+path}","compare_url":"https://api.github.com/repos/Polyconseil/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polyconseil/charts/merges","archive_url":"https://api.github.com/repos/Polyconseil/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polyconseil/charts/downloads","issues_url":"https://api.github.com/repos/Polyconseil/charts/issues{/number}","pulls_url":"https://api.github.com/repos/Polyconseil/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Polyconseil/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Polyconseil/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polyconseil/charts/labels{/name}","releases_url":"https://api.github.com/repos/Polyconseil/charts/releases{/id}","deployments_url":"https://api.github.com/repos/Polyconseil/charts/deployments","created_at":"2018-03-29T14:29:31Z","updated_at":"2018-09-11T12:24:11Z","pushed_at":"2018-12-14T11:06:35Z","git_url":"git://github.com/Polyconseil/charts.git","ssh_url":"git@github.com:Polyconseil/charts.git","clone_url":"https://github.com/Polyconseil/charts.git","svn_url":"https://github.com/Polyconseil/charts","homepage":"","size":14600,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"cc362ad771914a4a7e1295d6cd3b832278e67c5a","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-12-14T13:01:24Z","pushed_at":"2018-12-14T13:44:24Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":14623,"stargazers_count":6009,"watchers_count":6009,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5507,"mirror_url":null,"archived":false,"open_issues_count":692,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5507,"open_issues":692,"watchers":6009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/6217"},"html":{"href":"https://github.com/helm/charts/pull/6217"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/6217"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/6217/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/6217/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/6217/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/e305c76004481b2526c2068ff38b1170bb002241"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":20,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":12,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"k8s-ci-robot"}}