{"action":"closed","number":23920,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/23920","id":221483895,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDgzODk1","html_url":"https://github.com/elastic/kibana/pull/23920","diff_url":"https://github.com/elastic/kibana/pull/23920.diff","patch_url":"https://github.com/elastic/kibana/pull/23920.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/23920","number":23920,"state":"closed","locked":false,"title":"fix building Canvas plugin on Windows","user":{"login":"LeeDr","id":13542669,"node_id":"MDQ6VXNlcjEzNTQyNjY5","avatar_url":"https://avatars1.githubusercontent.com/u/13542669?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeDr","html_url":"https://github.com/LeeDr","followers_url":"https://api.github.com/users/LeeDr/followers","following_url":"https://api.github.com/users/LeeDr/following{/other_user}","gists_url":"https://api.github.com/users/LeeDr/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeDr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeDr/subscriptions","organizations_url":"https://api.github.com/users/LeeDr/orgs","repos_url":"https://api.github.com/users/LeeDr/repos","events_url":"https://api.github.com/users/LeeDr/events{/privacy}","received_events_url":"https://api.github.com/users/LeeDr/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nCanvas plugin wouldn't build on Windows 10 because of the difference in the slash path separator.  The error was;\r\n```\r\n$ node scripts/kbn run build:plugins --include canvas\r\nRunning [run] command from [C:\\Users\\LeeDr\\git\\kibana]:\r\n\r\nFound [1] projects:\r\n\r\n\r\n└── x-pack\\plugins\\canvas\r\n\r\nRunning script [build:plugins] in batched topological order\r\n\r\n× canvas: warning package.json: No license field\r\ncanvas: $ ../../node_modules/.bin/gulp canvas:plugins:build\r\ncanvas: [09:18:47] Working directory changed to ~\\git\\kibana\\x-pack\r\ncanvas: [09:18:55] C:\\Users\\LeeDr\\git\\kibana\\x-pack\\plugins\\canvas\\canvas_plugin\r\ncanvas: [09:18:55] Using gulpfile ~\\git\\kibana\\x-pack\\gulpfile.js\r\ncanvas: [09:18:55] Starting 'canvas:plugins:build'...\r\n× canvas: C:\\Users\\LeeDr\\git\\kibana\\node_modules\\webpack\\lib\\NormalModule.js:303\\n                              const error = new ModuleParseError(this, source, e);\r\n\\n                  ^\r\n× canvas: ModuleParseError: Module parse failed: C:\\Users\\LeeDr\\git\\kibana\\x-pack\\node_modules\\@elastic\\eui\\src\\components\\accessibility\\keyboard_accessible.js Unex\r\npected token (31:12)\r\n× canvas: You may need an appropriate loader to handle this file type.\r\n× canvas: |\r\n× canvas: | export class EuiKeyboardAccessible extends Component {\r\n× canvas: |   onKeyDown = e => {\r\n× canvas: |     // Prevent a scroll from occurring if the user has hit space.\r\n× canvas: |     if (e.keyCode === keyCodes.SPACE) {\\n    at doBuild (C:\\Users\\LeeDr\\git\\kibana\\node_modules\\webpack\\lib\\NormalModule.js:303:19)\\n    at runLoaders (\r\nC:\\Users\\LeeDr\\git\\kibana\\node_modules\\webpack\\lib\\NormalModule.js:209:11)\\n    at C:\\Users\\LeeDr\\git\\kibana\\node_modules\\loader-runner\\lib\\LoaderRunner.js:370:3\\n\r\n   at iterateNormalLoaders (C:\\Users\\LeeDr\\git\\kibana\\node_modules\\loader-runner\\lib\\LoaderRunner.js:211:10)\\n    at Array.<anonymous> (C:\\Users\\LeeDr\\git\\kibana\\no\r\nde_modules\\loader-runner\\lib\\LoaderRunner.js:202:4)\\n    at Storage.finished (C:\\Users\\LeeDr\\git\\kibana\\node_modules\\enhanced-resolve\\lib\\CachedInputFileSystem.js:4\r\n0:15)\\n    at C:\\Users\\LeeDr\\git\\kibana\\node_modules\\enhanced-resolve\\lib\\CachedInputFileSystem.js:77:9\\n    at C:\\Users\\LeeDr\\git\\kibana\\node_modules\\graceful-fs\\g\r\nraceful-fs.js:78:16\\n    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)\r\ncanvas: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.\r\n× canvas: error Command failed with exit code 1.\r\n```\r\n\r\nThis solution (thanks @spalger) using the regular expression to match both `/` and `\\` path seperators is consistent with other places in Kibana.\r\n\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n~- [ ] This was checked for cross-browser compatability, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~\r\n~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~\r\n~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~\r\n~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~\r\n~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~\r\n- [x] We don't have Windows build machines in our Jenkins workers yet, but this would have failed there but will pass with this change.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n- [ ] This includes a feature additition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n\r\n","created_at":"2018-10-09T15:24:36Z","updated_at":"2018-10-11T10:14:42Z","closed_at":"2018-10-11T10:14:42Z","merged_at":"2018-10-11T10:14:42Z","merge_commit_sha":"527178771ab784b1c76178e552adcdc592c9abbf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cqliu1","id":1697105,"node_id":"MDQ6VXNlcjE2OTcxMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1697105?v=4","gravatar_id":"","url":"https://api.github.com/users/cqliu1","html_url":"https://github.com/cqliu1","followers_url":"https://api.github.com/users/cqliu1/followers","following_url":"https://api.github.com/users/cqliu1/following{/other_user}","gists_url":"https://api.github.com/users/cqliu1/gists{/gist_id}","starred_url":"https://api.github.com/users/cqliu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cqliu1/subscriptions","organizations_url":"https://api.github.com/users/cqliu1/orgs","repos_url":"https://api.github.com/users/cqliu1/repos","events_url":"https://api.github.com/users/cqliu1/events{/privacy}","received_events_url":"https://api.github.com/users/cqliu1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":912981985,"node_id":"MDU6TGFiZWw5MTI5ODE5ODU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Canvas","name":":Canvas","color":"fef2c0","default":false},{"id":912973198,"node_id":"MDU6TGFiZWw5MTI5NzMxOTg=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.5.0","name":"v6.5.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/23920/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/23920/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/23920/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/6bcfedd5e28d10c5b8807054dc418971862128f4","head":{"label":"LeeDr:fixCanvasWebpackWindows","ref":"fixCanvasWebpackWindows","sha":"6bcfedd5e28d10c5b8807054dc418971862128f4","user":{"login":"LeeDr","id":13542669,"node_id":"MDQ6VXNlcjEzNTQyNjY5","avatar_url":"https://avatars1.githubusercontent.com/u/13542669?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeDr","html_url":"https://github.com/LeeDr","followers_url":"https://api.github.com/users/LeeDr/followers","following_url":"https://api.github.com/users/LeeDr/following{/other_user}","gists_url":"https://api.github.com/users/LeeDr/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeDr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeDr/subscriptions","organizations_url":"https://api.github.com/users/LeeDr/orgs","repos_url":"https://api.github.com/users/LeeDr/repos","events_url":"https://api.github.com/users/LeeDr/events{/privacy}","received_events_url":"https://api.github.com/users/LeeDr/received_events","type":"User","site_admin":false},"repo":{"id":39850757,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg1MDc1Nw==","name":"kibana","full_name":"LeeDr/kibana","private":false,"owner":{"login":"LeeDr","id":13542669,"node_id":"MDQ6VXNlcjEzNTQyNjY5","avatar_url":"https://avatars1.githubusercontent.com/u/13542669?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeDr","html_url":"https://github.com/LeeDr","followers_url":"https://api.github.com/users/LeeDr/followers","following_url":"https://api.github.com/users/LeeDr/following{/other_user}","gists_url":"https://api.github.com/users/LeeDr/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeDr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeDr/subscriptions","organizations_url":"https://api.github.com/users/LeeDr/orgs","repos_url":"https://api.github.com/users/LeeDr/repos","events_url":"https://api.github.com/users/LeeDr/events{/privacy}","received_events_url":"https://api.github.com/users/LeeDr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LeeDr/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/LeeDr/kibana","forks_url":"https://api.github.com/repos/LeeDr/kibana/forks","keys_url":"https://api.github.com/repos/LeeDr/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeeDr/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeeDr/kibana/teams","hooks_url":"https://api.github.com/repos/LeeDr/kibana/hooks","issue_events_url":"https://api.github.com/repos/LeeDr/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/LeeDr/kibana/events","assignees_url":"https://api.github.com/repos/LeeDr/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/LeeDr/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/LeeDr/kibana/tags","blobs_url":"https://api.github.com/repos/LeeDr/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeeDr/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeeDr/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeeDr/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeeDr/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/LeeDr/kibana/languages","stargazers_url":"https://api.github.com/repos/LeeDr/kibana/stargazers","contributors_url":"https://api.github.com/repos/LeeDr/kibana/contributors","subscribers_url":"https://api.github.com/repos/LeeDr/kibana/subscribers","subscription_url":"https://api.github.com/repos/LeeDr/kibana/subscription","commits_url":"https://api.github.com/repos/LeeDr/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeeDr/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeeDr/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeeDr/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeeDr/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/LeeDr/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeeDr/kibana/merges","archive_url":"https://api.github.com/repos/LeeDr/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeeDr/kibana/downloads","issues_url":"https://api.github.com/repos/LeeDr/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/LeeDr/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/LeeDr/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/LeeDr/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeeDr/kibana/labels{/name}","releases_url":"https://api.github.com/repos/LeeDr/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/LeeDr/kibana/deployments","created_at":"2015-07-28T18:24:24Z","updated_at":"2018-08-31T23:58:04Z","pushed_at":"2018-10-09T15:16:00Z","git_url":"git://github.com/LeeDr/kibana.git","ssh_url":"git@github.com:LeeDr/kibana.git","clone_url":"https://github.com/LeeDr/kibana.git","svn_url":"https://github.com/LeeDr/kibana","homepage":"https://www.elastic.co/products/kibana","size":464847,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"c6911d43d9444dcf9d56f6e6e2fdf8300d9cf308","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-10-11T09:23:18Z","pushed_at":"2018-10-11T10:14:42Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":536520,"stargazers_count":10233,"watchers_count":10233,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3977,"mirror_url":null,"archived":false,"open_issues_count":3572,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3977,"open_issues":3572,"watchers":10233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23920"},"html":{"href":"https://github.com/elastic/kibana/pull/23920"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/23920"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/23920/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23920/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23920/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/6bcfedd5e28d10c5b8807054dc418971862128f4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"LeeDr","id":13542669,"node_id":"MDQ6VXNlcjEzNTQyNjY5","avatar_url":"https://avatars1.githubusercontent.com/u/13542669?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeDr","html_url":"https://github.com/LeeDr","followers_url":"https://api.github.com/users/LeeDr/followers","following_url":"https://api.github.com/users/LeeDr/following{/other_user}","gists_url":"https://api.github.com/users/LeeDr/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeDr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeDr/subscriptions","organizations_url":"https://api.github.com/users/LeeDr/orgs","repos_url":"https://api.github.com/users/LeeDr/repos","events_url":"https://api.github.com/users/LeeDr/events{/privacy}","received_events_url":"https://api.github.com/users/LeeDr/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"LeeDr"}}