{"action":"created","issue":{"url":"https://api.github.com/repos/getsentry/responses/issues/230","repository_url":"https://api.github.com/repos/getsentry/responses","labels_url":"https://api.github.com/repos/getsentry/responses/issues/230/labels{/name}","comments_url":"https://api.github.com/repos/getsentry/responses/issues/230/comments","events_url":"https://api.github.com/repos/getsentry/responses/issues/230/events","html_url":"https://github.com/getsentry/responses/issues/230","id":379948981,"node_id":"MDU6SXNzdWUzNzk5NDg5ODE=","number":230,"title":"Regression in 0.10.3: SyntaxError during","user":{"login":"pjdelport","id":630271,"node_id":"MDQ6VXNlcjYzMDI3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/630271?v=4","gravatar_id":"","url":"https://api.github.com/users/pjdelport","html_url":"https://github.com/pjdelport","followers_url":"https://api.github.com/users/pjdelport/followers","following_url":"https://api.github.com/users/pjdelport/following{/other_user}","gists_url":"https://api.github.com/users/pjdelport/gists{/gist_id}","starred_url":"https://api.github.com/users/pjdelport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjdelport/subscriptions","organizations_url":"https://api.github.com/users/pjdelport/orgs","repos_url":"https://api.github.com/users/pjdelport/repos","events_url":"https://api.github.com/users/pjdelport/events{/privacy}","received_events_url":"https://api.github.com/users/pjdelport/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-12T20:56:31Z","updated_at":"2018-11-12T21:01:33Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Upgrading responses from 0.10.2 to 0.10.3 causes pytest's test discovery to fail with the following error:\r\n\r\n```\r\n==================================== ERRORS ====================================\r\n_____________________ ERROR collecting tests/test_foo.py ______________________\r\n…/python3.6/site-packages/_pytest/python.py:450: in _importtestmodule\r\n    mod = self.fspath.pyimport(ensuresyspath=importmode)\r\n…/python3.6/site-packages/py/_path/local.py:668: in pyimport\r\n    __import__(modname)\r\n<frozen importlib._bootstrap>:971: in _find_and_load\r\n    ???\r\n<frozen importlib._bootstrap>:955: in _find_and_load_unlocked\r\n    ???\r\n<frozen importlib._bootstrap>:656: in _load_unlocked\r\n    ???\r\n<frozen importlib._bootstrap>:626: in _load_backward_compatible\r\n    ???\r\n…/python3.6/site-packages/_pytest/assertion/rewrite.py:294: in load_module\r\n    six.exec_(co, mod.__dict__)\r\ntests/test_foo.py:1234: in <module>\r\n    class TestFoo(TestCase):\r\ntests/test_foo.py:1345: in TestFoo\r\n    def test_foo(self) -> None:\r\n…/python3.6/site-packages/responses.py:553: in activate\r\n    return get_wrapped(func, self)\r\n…/python3.6/site-packages/responses.py:158: in get_wrapped\r\n    evaldict,\r\nE     File \"<string>\", line 3\r\nE       return func(self) -> None\r\nE                          ^\r\nE   SyntaxError: invalid syntax\r\n!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!\r\n=========================== 1 error in 6.21 seconds ============================\r\n```\r\n\r\nReverting back to 0.10.2 avoids the error."},"comment":{"url":"https://api.github.com/repos/getsentry/responses/issues/comments/438027205","html_url":"https://github.com/getsentry/responses/issues/230#issuecomment-438027205","issue_url":"https://api.github.com/repos/getsentry/responses/issues/230","id":438027205,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODAyNzIwNQ==","user":{"login":"pjdelport","id":630271,"node_id":"MDQ6VXNlcjYzMDI3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/630271?v=4","gravatar_id":"","url":"https://api.github.com/users/pjdelport","html_url":"https://github.com/pjdelport","followers_url":"https://api.github.com/users/pjdelport/followers","following_url":"https://api.github.com/users/pjdelport/following{/other_user}","gists_url":"https://api.github.com/users/pjdelport/gists{/gist_id}","starred_url":"https://api.github.com/users/pjdelport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjdelport/subscriptions","organizations_url":"https://api.github.com/users/pjdelport/orgs","repos_url":"https://api.github.com/users/pjdelport/repos","events_url":"https://api.github.com/users/pjdelport/events{/privacy}","received_events_url":"https://api.github.com/users/pjdelport/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T21:01:33Z","updated_at":"2018-11-12T21:01:33Z","author_association":"CONTRIBUTOR","body":"I haven't really looked at this in detail, but from the changelog and error message, it looks like the fix for #216 in #222 may not be dealing with type annotations correctly anymore?\r\n\r\n(It looks like the ` -> None` is getting inserted into the wrapper template where it shouldn't be?)"}}
{"actor":{"display_login":"pjdelport"}}