{"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/comments/209249074","pull_request_review_id":145228175,"id":209249074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTI0OTA3NA==","diff_hunk":"@@ -53,10 +54,18 @@ extension MongoCollection {\n         let reply = Document()\n         var error = bson_error_t()\n         if !mongoc_collection_insert_many(\n+             // TODO SWIFT-139: include writeErrors and writeConcernErrors from reply in the error\n             self._collection, &docPointers, documents.count, opts?.data, reply.data, &error) {\n             throw MongoError.commandError(message: toErrorString(error))\n         }\n-        return InsertManyResult(insertedIds: documents.map { $0[\"_id\"] })\n+\n+        // if we succeeded, then we should store + return every `_id`","path":"Sources/MongoSwift/MongoCollection+Write.swift","position":null,"original_position":18,"commit_id":"9b5bacfd5ad041ca120993bdbc13affb02cb8252","original_commit_id":"9b5bacfd5ad041ca120993bdbc13affb02cb8252","user":{"login":"jmikola","id":244663,"node_id":"MDQ6VXNlcjI0NDY2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/244663?v=4","gravatar_id":"","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"body":"Interesting. Since [`mongoc_collection_insert_many()`](http://mongoc.org/libmongoc/current/mongoc_collection_insert_many.html) doesn't report `insertedIds`, we might actually have to interpret the errors to determine how to (a) construct the map or (b) redact failed inserts from the map (assuming we construct it before executing the insert).\r\n\r\nI know that PHPLIB reports inserted IDs in its InsertManyResult class. Looking at [the source](https://github.com/mongodb/mongo-php-library/blob/1.4.2/src/Operation/InsertMany.php#L142), it appears we don't report the map if an exception is thrown. In that case, we let the exception from [`executeBulkWrite()`](http://php.net/manual/en/mongodb-driver-manager.executebulkwrite.php) propagate. That exception will include a PHPC [WriteResult](http://php.net/manual/en/class.mongodb-driver-writeresult.php), which is derived from libmongoc's reply document and does not include a map of inserted IDs.\r\n\r\nGiven the complexity of building this map after encountering an error (mentioned in the first paragraph of this comment), I'm not sure it's worth the trouble. I might suggest poking around other drivers to see how they handle this before expending the effort to implement the TODO item above.","created_at":"2018-08-10T12:55:26Z","updated_at":"2018-08-10T12:55:26Z","html_url":"https://github.com/mongodb/mongo-swift-driver/pull/104#discussion_r209249074","pull_request_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/104","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/comments/209249074"},"html":{"href":"https://github.com/mongodb/mongo-swift-driver/pull/104#discussion_r209249074"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/104","id":205873018,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODczMDE4","html_url":"https://github.com/mongodb/mongo-swift-driver/pull/104","diff_url":"https://github.com/mongodb/mongo-swift-driver/pull/104.diff","patch_url":"https://github.com/mongodb/mongo-swift-driver/pull/104.patch","issue_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues/104","number":104,"state":"open","locked":false,"title":"SWIFT-162 Allow for null document IDs in inserted and upserted documents","user":{"login":"kmahar","id":5976377,"node_id":"MDQ6VXNlcjU5NzYzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5976377?v=4","gravatar_id":"","url":"https://api.github.com/users/kmahar","html_url":"https://github.com/kmahar","followers_url":"https://api.github.com/users/kmahar/followers","following_url":"https://api.github.com/users/kmahar/following{/other_user}","gists_url":"https://api.github.com/users/kmahar/gists{/gist_id}","starred_url":"https://api.github.com/users/kmahar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmahar/subscriptions","organizations_url":"https://api.github.com/users/kmahar/orgs","repos_url":"https://api.github.com/users/kmahar/repos","events_url":"https://api.github.com/users/kmahar/events{/privacy}","received_events_url":"https://api.github.com/users/kmahar/received_events","type":"User","site_admin":false},"body":"https://jira.mongodb.org/browse/SWIFT-162","created_at":"2018-08-02T21:57:52Z","updated_at":"2018-08-10T12:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c86db11cf3d882c62bc24eef8c9437911e47a69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/104/commits","review_comments_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/104/comments","review_comment_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues/104/comments","statuses_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/statuses/9b5bacfd5ad041ca120993bdbc13affb02cb8252","head":{"label":"mongodb:SWIFT-162","ref":"SWIFT-162","sha":"9b5bacfd5ad041ca120993bdbc13affb02cb8252","user":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":118030974,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwMzA5NzQ=","name":"mongo-swift-driver","full_name":"mongodb/mongo-swift-driver","owner":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/mongo-swift-driver","description":"The Swift driver for MongoDB","fork":false,"url":"https://api.github.com/repos/mongodb/mongo-swift-driver","forks_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/forks","keys_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/teams","hooks_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/hooks","issue_events_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/events","assignees_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/tags","blobs_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/languages","stargazers_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/stargazers","contributors_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/contributors","subscribers_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/subscribers","subscription_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/subscription","commits_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/merges","archive_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/downloads","issues_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/deployments","created_at":"2018-01-18T19:55:11Z","updated_at":"2018-08-10T12:14:37Z","pushed_at":"2018-08-09T20:25:17Z","git_url":"git://github.com/mongodb/mongo-swift-driver.git","ssh_url":"git@github.com:mongodb/mongo-swift-driver.git","clone_url":"https://github.com/mongodb/mongo-swift-driver.git","svn_url":"https://github.com/mongodb/mongo-swift-driver","homepage":"","size":6494,"stargazers_count":37,"watchers_count":37,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":8,"watchers":37,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"6e3adbdf80ce6bc26d1783d041b1cd0cbbda4c02","user":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":118030974,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwMzA5NzQ=","name":"mongo-swift-driver","full_name":"mongodb/mongo-swift-driver","owner":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/mongo-swift-driver","description":"The Swift driver for MongoDB","fork":false,"url":"https://api.github.com/repos/mongodb/mongo-swift-driver","forks_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/forks","keys_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/teams","hooks_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/hooks","issue_events_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/events","assignees_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/tags","blobs_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/languages","stargazers_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/stargazers","contributors_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/contributors","subscribers_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/subscribers","subscription_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/subscription","commits_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/merges","archive_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/downloads","issues_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/mongo-swift-driver/deployments","created_at":"2018-01-18T19:55:11Z","updated_at":"2018-08-10T12:14:37Z","pushed_at":"2018-08-09T20:25:17Z","git_url":"git://github.com/mongodb/mongo-swift-driver.git","ssh_url":"git@github.com:mongodb/mongo-swift-driver.git","clone_url":"https://github.com/mongodb/mongo-swift-driver.git","svn_url":"https://github.com/mongodb/mongo-swift-driver","homepage":"","size":6494,"stargazers_count":37,"watchers_count":37,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":8,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/104"},"html":{"href":"https://github.com/mongodb/mongo-swift-driver/pull/104"},"issue":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues/104"},"comments":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/mongo-swift-driver/statuses/9b5bacfd5ad041ca120993bdbc13affb02cb8252"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jmikola"}}