{"action":"created","comment":{"url":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments/241794526","pull_request_review_id":185090625,"id":241794526,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTc5NDUyNg==","diff_hunk":"@@ -47,55 +49,44 @@ defmodule OMG.Eth.RootChain do\n     )\n   end\n \n-  def start_deposit_exit(deposit_positon, token, value, from, contract \\\\ nil, opts \\\\ []) do\n-    defaults = @tx_defaults |> Keyword.put(:gas, 1_000_000)\n-    opts = defaults |> Keyword.merge(opts)\n-\n-    contract = contract || from_hex(Application.fetch_env!(:omg_eth, :contract_addr))\n-\n-    Eth.contract_transact(\n-      from,\n-      contract,\n-      \"startDepositExit(uint256,address,uint256)\",\n-      [deposit_positon, token, value],\n-      opts\n-    )\n-  end\n+  def start_exit(outputId, txbytes, proof, from, contract \\\\ nil, opts \\\\ []) do\n+    defaults =\n+      @tx_defaults\n+      |> Keyword.put(:gas, 1_000_000)\n+      # standardExitBond = 31415926535 wei\n+      |> Keyword.put(:value, 31_415_926_535)\n \n-  def start_exit(utxo_position, txbytes, proof, sigs, from, contract \\\\ nil, opts \\\\ []) do\n-    defaults = @tx_defaults |> Keyword.put(:gas, 1_000_000)\n     opts = defaults |> Keyword.merge(opts)\n \n     contract = contract || from_hex(Application.fetch_env!(:omg_eth, :contract_addr))\n \n     Eth.contract_transact(\n       from,\n       contract,\n-      \"startExit(uint256,bytes,bytes,bytes)\",\n-      [utxo_position, txbytes, proof, sigs],\n+      \"startStandardExit(uint192,bytes,bytes)\",\n+      [outputId, txbytes, proof],\n       opts\n     )\n   end\n \n-  def deposit(value, from, contract \\\\ nil, opts \\\\ []) do\n-    defaults = @tx_defaults |> Keyword.put(:gas, 80_000)\n+  def deposit(tx, value, from, contract \\\\ nil, opts \\\\ []) do","path":"apps/omg_eth/lib/eth/root_chain.ex","position":53,"original_position":53,"commit_id":"dfb2378fc786fc6397fd3bbea5ccb82266ae26ea","original_commit_id":"d5c7721a347485183a9a3930fde2b4753acfb734","user":{"login":"pnowosie","id":1813036,"node_id":"MDQ6VXNlcjE4MTMwMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1813036?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowosie","html_url":"https://github.com/pnowosie","followers_url":"https://api.github.com/users/pnowosie/followers","following_url":"https://api.github.com/users/pnowosie/following{/other_user}","gists_url":"https://api.github.com/users/pnowosie/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowosie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowosie/subscriptions","organizations_url":"https://api.github.com/users/pnowosie/orgs","repos_url":"https://api.github.com/users/pnowosie/repos","events_url":"https://api.github.com/users/pnowosie/events{/privacy}","received_events_url":"https://api.github.com/users/pnowosie/received_events","type":"User","site_admin":false},"body":"I might be wrong here, it looks like tx (= rlp-encoded tx_bytes) contains output which has `value` and `from` information. Right :question: \r\nDuplicating this params we risk they are unmatched and inconsistent data is passed to the contract.","created_at":"2018-12-14T15:36:49Z","updated_at":"2018-12-14T15:41:27Z","html_url":"https://github.com/omisego/elixir-omg/pull/308#discussion_r241794526","pull_request_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/308","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments/241794526"},"html":{"href":"https://github.com/omisego/elixir-omg/pull/308#discussion_r241794526"},"pull_request":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/omisego/elixir-omg/pulls/308","id":238476861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDc2ODYx","html_url":"https://github.com/omisego/elixir-omg/pull/308","diff_url":"https://github.com/omisego/elixir-omg/pull/308.diff","patch_url":"https://github.com/omisego/elixir-omg/pull/308.patch","issue_url":"https://api.github.com/repos/omisego/elixir-omg/issues/308","number":308,"state":"open","locked":false,"title":"Feature/omg 344 morevp compatibility","user":{"login":"pthomalla","id":429892,"node_id":"MDQ6VXNlcjQyOTg5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/429892?v=4","gravatar_id":"","url":"https://api.github.com/users/pthomalla","html_url":"https://github.com/pthomalla","followers_url":"https://api.github.com/users/pthomalla/followers","following_url":"https://api.github.com/users/pthomalla/following{/other_user}","gists_url":"https://api.github.com/users/pthomalla/gists{/gist_id}","starred_url":"https://api.github.com/users/pthomalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pthomalla/subscriptions","organizations_url":"https://api.github.com/users/pthomalla/orgs","repos_url":"https://api.github.com/users/pthomalla/repos","events_url":"https://api.github.com/users/pthomalla/events{/privacy}","received_events_url":"https://api.github.com/users/pthomalla/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-13T17:46:10Z","updated_at":"2018-12-14T15:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e58bdb0e0e624850f844e9529359f039229a096c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/308/commits","review_comments_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/308/comments","review_comment_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/issues/308/comments","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/dfb2378fc786fc6397fd3bbea5ccb82266ae26ea","head":{"label":"omisego:feature/OMG-344_morevp_compatibility","ref":"feature/OMG-344_morevp_compatibility","sha":"dfb2378fc786fc6397fd3bbea5ccb82266ae26ea","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":123528600,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1Mjg2MDA=","name":"elixir-omg","full_name":"omisego/elixir-omg","private":false,"owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omisego/elixir-omg","description":null,"fork":false,"url":"https://api.github.com/repos/omisego/elixir-omg","forks_url":"https://api.github.com/repos/omisego/elixir-omg/forks","keys_url":"https://api.github.com/repos/omisego/elixir-omg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/elixir-omg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/elixir-omg/teams","hooks_url":"https://api.github.com/repos/omisego/elixir-omg/hooks","issue_events_url":"https://api.github.com/repos/omisego/elixir-omg/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/elixir-omg/events","assignees_url":"https://api.github.com/repos/omisego/elixir-omg/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/elixir-omg/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/elixir-omg/tags","blobs_url":"https://api.github.com/repos/omisego/elixir-omg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/elixir-omg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/elixir-omg/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/elixir-omg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/elixir-omg/languages","stargazers_url":"https://api.github.com/repos/omisego/elixir-omg/stargazers","contributors_url":"https://api.github.com/repos/omisego/elixir-omg/contributors","subscribers_url":"https://api.github.com/repos/omisego/elixir-omg/subscribers","subscription_url":"https://api.github.com/repos/omisego/elixir-omg/subscription","commits_url":"https://api.github.com/repos/omisego/elixir-omg/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/elixir-omg/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/elixir-omg/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/elixir-omg/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/elixir-omg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/elixir-omg/merges","archive_url":"https://api.github.com/repos/omisego/elixir-omg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/elixir-omg/downloads","issues_url":"https://api.github.com/repos/omisego/elixir-omg/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/elixir-omg/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/elixir-omg/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/elixir-omg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/elixir-omg/labels{/name}","releases_url":"https://api.github.com/repos/omisego/elixir-omg/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/elixir-omg/deployments","created_at":"2018-03-02T04:05:24Z","updated_at":"2018-12-14T15:35:44Z","pushed_at":"2018-12-14T15:35:55Z","git_url":"git://github.com/omisego/elixir-omg.git","ssh_url":"git@github.com:omisego/elixir-omg.git","clone_url":"https://github.com/omisego/elixir-omg.git","svn_url":"https://github.com/omisego/elixir-omg","homepage":null,"size":6593,"stargazers_count":116,"watchers_count":116,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":13,"watchers":116,"default_branch":"master"}},"base":{"label":"omisego:master","ref":"master","sha":"ebfbfa451731ce9e32903c24f05daa67819802f1","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":123528600,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1Mjg2MDA=","name":"elixir-omg","full_name":"omisego/elixir-omg","private":false,"owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omisego/elixir-omg","description":null,"fork":false,"url":"https://api.github.com/repos/omisego/elixir-omg","forks_url":"https://api.github.com/repos/omisego/elixir-omg/forks","keys_url":"https://api.github.com/repos/omisego/elixir-omg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/elixir-omg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/elixir-omg/teams","hooks_url":"https://api.github.com/repos/omisego/elixir-omg/hooks","issue_events_url":"https://api.github.com/repos/omisego/elixir-omg/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/elixir-omg/events","assignees_url":"https://api.github.com/repos/omisego/elixir-omg/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/elixir-omg/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/elixir-omg/tags","blobs_url":"https://api.github.com/repos/omisego/elixir-omg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/elixir-omg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/elixir-omg/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/elixir-omg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/elixir-omg/languages","stargazers_url":"https://api.github.com/repos/omisego/elixir-omg/stargazers","contributors_url":"https://api.github.com/repos/omisego/elixir-omg/contributors","subscribers_url":"https://api.github.com/repos/omisego/elixir-omg/subscribers","subscription_url":"https://api.github.com/repos/omisego/elixir-omg/subscription","commits_url":"https://api.github.com/repos/omisego/elixir-omg/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/elixir-omg/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/elixir-omg/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/elixir-omg/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/elixir-omg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/elixir-omg/merges","archive_url":"https://api.github.com/repos/omisego/elixir-omg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/elixir-omg/downloads","issues_url":"https://api.github.com/repos/omisego/elixir-omg/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/elixir-omg/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/elixir-omg/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/elixir-omg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/elixir-omg/labels{/name}","releases_url":"https://api.github.com/repos/omisego/elixir-omg/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/elixir-omg/deployments","created_at":"2018-03-02T04:05:24Z","updated_at":"2018-12-14T15:35:44Z","pushed_at":"2018-12-14T15:35:55Z","git_url":"git://github.com/omisego/elixir-omg.git","ssh_url":"git@github.com:omisego/elixir-omg.git","clone_url":"https://github.com/omisego/elixir-omg.git","svn_url":"https://github.com/omisego/elixir-omg","homepage":null,"size":6593,"stargazers_count":116,"watchers_count":116,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":13,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/308"},"html":{"href":"https://github.com/omisego/elixir-omg/pull/308"},"issue":{"href":"https://api.github.com/repos/omisego/elixir-omg/issues/308"},"comments":{"href":"https://api.github.com/repos/omisego/elixir-omg/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/omisego/elixir-omg/statuses/dfb2378fc786fc6397fd3bbea5ccb82266ae26ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pnowosie"}}