{"action":"created","issue":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/1181","repository_url":"https://api.github.com/repos/amethyst/amethyst","labels_url":"https://api.github.com/repos/amethyst/amethyst/issues/1181/labels{/name}","comments_url":"https://api.github.com/repos/amethyst/amethyst/issues/1181/comments","events_url":"https://api.github.com/repos/amethyst/amethyst/issues/1181/events","html_url":"https://github.com/amethyst/amethyst/pull/1181","id":384107120,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzkzMjk4","number":1181,"title":"Fixed sprite sheet format texture coordinate loading.","user":{"login":"azriel91","id":2993230,"node_id":"MDQ6VXNlcjI5OTMyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2993230?v=4","gravatar_id":"","url":"https://api.github.com/users/azriel91","html_url":"https://github.com/azriel91","followers_url":"https://api.github.com/users/azriel91/followers","following_url":"https://api.github.com/users/azriel91/following{/other_user}","gists_url":"https://api.github.com/users/azriel91/gists{/gist_id}","starred_url":"https://api.github.com/users/azriel91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azriel91/subscriptions","organizations_url":"https://api.github.com/users/azriel91/orgs","repos_url":"https://api.github.com/users/azriel91/repos","events_url":"https://api.github.com/users/azriel91/events{/privacy}","received_events_url":"https://api.github.com/users/azriel91/received_events","type":"User","site_admin":false},"labels":[{"id":662922205,"node_id":"MDU6TGFiZWw2NjI5MjIyMDU=","url":"https://api.github.com/repos/amethyst/amethyst/labels/project:%20rendering","name":"project: rendering","color":"0e8a16","default":false},{"id":662998062,"node_id":"MDU6TGFiZWw2NjI5OTgwNjI=","url":"https://api.github.com/repos/amethyst/amethyst/labels/status:%20working","name":"status: working","color":"bfe5bf","default":false},{"id":302199476,"node_id":"MDU6TGFiZWwzMDIxOTk0NzY=","url":"https://api.github.com/repos/amethyst/amethyst/labels/type:%20bug","name":"type: bug","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-25T18:55:35Z","updated_at":"2018-11-27T05:48:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/1181","html_url":"https://github.com/amethyst/amethyst/pull/1181","diff_url":"https://github.com/amethyst/amethyst/pull/1181.diff","patch_url":"https://github.com/amethyst/amethyst/pull/1181.patch"},"body":"Discovered by `@cout970` in discord"},"comment":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/comments/441929737","html_url":"https://github.com/amethyst/amethyst/pull/1181#issuecomment-441929737","issue_url":"https://api.github.com/repos/amethyst/amethyst/issues/1181","id":441929737,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTkyOTczNw==","user":{"login":"azriel91","id":2993230,"node_id":"MDQ6VXNlcjI5OTMyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2993230?v=4","gravatar_id":"","url":"https://api.github.com/users/azriel91","html_url":"https://github.com/azriel91","followers_url":"https://api.github.com/users/azriel91/followers","following_url":"https://api.github.com/users/azriel91/following{/other_user}","gists_url":"https://api.github.com/users/azriel91/gists{/gist_id}","starred_url":"https://api.github.com/users/azriel91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azriel91/subscriptions","organizations_url":"https://api.github.com/users/azriel91/orgs","repos_url":"https://api.github.com/users/azriel91/repos","events_url":"https://api.github.com/users/azriel91/events{/privacy}","received_events_url":"https://api.github.com/users/azriel91/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T05:48:04Z","updated_at":"2018-11-27T05:48:04Z","author_association":"MEMBER","body":"> SerializedSpriteSheet should be u32 because you can't have float sizes\r\n>\r\n> &ndash; Jojo\r\n\r\n> f32 was mostly to reduce casting\r\n>\r\n> &ndash; Moxi\r\n\r\n> I'm using non-integer sprite offsets.\r\n>\r\n> ```rust\r\n> sprite.offsets = [0.0, -3.5];\r\n> ```\r\n>\r\n> On the other hand, centering 23 pixel high sprites is maybe not a common case...  \r\n> (and it is a minor annoyance that Sprite::from_pixel_values() takes integer offsets...)\r\n>\r\n> &ndash; `@Swegecko`\r\n\r\nTodo:\r\n\r\n* [ ] `u32` for x/y/w/h\r\n* [ ] `f32` for offsets (also update `from_pixel_values()` to take `f32`)\r\n* [ ] Update examples (pong, sprites_ordered)\r\n* [ ] Update book\r\n"}}
{"actor":{"display_login":"azriel91"}}