{"action":"created","comment":{"url":"https://api.github.com/repos/tox-dev/tox/pulls/comments/218974318","pull_request_review_id":157035112,"id":218974318,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk3NDMxOA==","diff_hunk":"@@ -226,20 +239,32 @@ def matching_platform(self):\n         return re.match(self.envconfig.platform, sys.platform)\n \n     def finish(self):\n-        self._getliveconfig().writeconfig(self.path_config)\n+        previous_config = CreationConfig.readconfig(self.path_config)\n+        live_config = self._getliveconfig()\n+        if previous_config is None or not previous_config.matches(live_config):\n+            self.session.report.verbosity1(\n+                \"write config to {} as {!r}\".format(self.path_config, live_config)\n+            )\n+            live_config.writeconfig(self.path_config)\n \n     def _needs_reinstall(self, setupdir, action):\n         setup_py = setupdir.join(\"setup.py\")\n         setup_cfg = setupdir.join(\"setup.cfg\")\n         args = [self.envconfig.envpython, str(setup_py), \"--name\"]\n         env = self._get_os_environ()\n         output = action.popen(args, cwd=setupdir, redirect=False, returnout=True, env=env)\n-        name = output.strip()\n-        args = [self.envconfig.envpython, \"-c\", \"import sys; print(sys.path)\"]\n+        name = next(\n+            (i for i in output.split(\"\\n\") if i and not i.startswith(\"pydev debugger:\")), \"\"","path":"src/tox/venv.py","position":137,"original_position":137,"commit_id":"3ba22cc90ddd38929dbb38986a19db511c6ee270","original_commit_id":"3ba22cc90ddd38929dbb38986a19db511c6ee270","user":{"login":"gaborbernat","id":690238,"node_id":"MDQ6VXNlcjY5MDIzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/690238?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborbernat","html_url":"https://github.com/gaborbernat","followers_url":"https://api.github.com/users/gaborbernat/followers","following_url":"https://api.github.com/users/gaborbernat/following{/other_user}","gists_url":"https://api.github.com/users/gaborbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborbernat/subscriptions","organizations_url":"https://api.github.com/users/gaborbernat/orgs","repos_url":"https://api.github.com/users/gaborbernat/repos","events_url":"https://api.github.com/users/gaborbernat/events{/privacy}","received_events_url":"https://api.github.com/users/gaborbernat/received_events","type":"User","site_admin":false},"body":"More like a small fixup 👍 Ideally people should be able to run the test suite in debug mode too with pydev (both eclipse and Pycharm). For that to work this is needed.","created_at":"2018-09-19T21:44:17Z","updated_at":"2018-09-19T21:44:18Z","html_url":"https://github.com/tox-dev/tox/pull/1000#discussion_r218974318","pull_request_url":"https://api.github.com/repos/tox-dev/tox/pulls/1000","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tox-dev/tox/pulls/comments/218974318"},"html":{"href":"https://github.com/tox-dev/tox/pull/1000#discussion_r218974318"},"pull_request":{"href":"https://api.github.com/repos/tox-dev/tox/pulls/1000"}},"in_reply_to_id":218972454},"pull_request":{"url":"https://api.github.com/repos/tox-dev/tox/pulls/1000","id":216441856,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDQxODU2","html_url":"https://github.com/tox-dev/tox/pull/1000","diff_url":"https://github.com/tox-dev/tox/pull/1000.diff","patch_url":"https://github.com/tox-dev/tox/pull/1000.patch","issue_url":"https://api.github.com/repos/tox-dev/tox/issues/1000","number":1000,"state":"open","locked":false,"title":"Add pre and post commands","user":{"login":"gaborbernat","id":690238,"node_id":"MDQ6VXNlcjY5MDIzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/690238?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborbernat","html_url":"https://github.com/gaborbernat","followers_url":"https://api.github.com/users/gaborbernat/followers","following_url":"https://api.github.com/users/gaborbernat/following{/other_user}","gists_url":"https://api.github.com/users/gaborbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborbernat/subscriptions","organizations_url":"https://api.github.com/users/gaborbernat/orgs","repos_url":"https://api.github.com/users/gaborbernat/repos","events_url":"https://api.github.com/users/gaborbernat/events{/privacy}","received_events_url":"https://api.github.com/users/gaborbernat/received_events","type":"User","site_admin":false},"body":"Resolves #167.\r\nResolves #1003.\r\nResolves #1004.\r\nFixup for #987 and #851.\r\n\r\nPS. Once we resolve and merge this we'll release ``3.4.0``.","created_at":"2018-09-18T20:57:38Z","updated_at":"2018-09-19T21:44:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad3a06c77f0f3dbadebb0da3933923f0eb0d32d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tox-dev/tox/pulls/1000/commits","review_comments_url":"https://api.github.com/repos/tox-dev/tox/pulls/1000/comments","review_comment_url":"https://api.github.com/repos/tox-dev/tox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tox-dev/tox/issues/1000/comments","statuses_url":"https://api.github.com/repos/tox-dev/tox/statuses/3ba22cc90ddd38929dbb38986a19db511c6ee270","head":{"label":"gaborbernat:167","ref":"167","sha":"3ba22cc90ddd38929dbb38986a19db511c6ee270","user":{"login":"gaborbernat","id":690238,"node_id":"MDQ6VXNlcjY5MDIzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/690238?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborbernat","html_url":"https://github.com/gaborbernat","followers_url":"https://api.github.com/users/gaborbernat/followers","following_url":"https://api.github.com/users/gaborbernat/following{/other_user}","gists_url":"https://api.github.com/users/gaborbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborbernat/subscriptions","organizations_url":"https://api.github.com/users/gaborbernat/orgs","repos_url":"https://api.github.com/users/gaborbernat/repos","events_url":"https://api.github.com/users/gaborbernat/events{/privacy}","received_events_url":"https://api.github.com/users/gaborbernat/received_events","type":"User","site_admin":false},"repo":{"id":85731189,"node_id":"MDEwOlJlcG9zaXRvcnk4NTczMTE4OQ==","name":"tox","full_name":"gaborbernat/tox","private":false,"owner":{"login":"gaborbernat","id":690238,"node_id":"MDQ6VXNlcjY5MDIzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/690238?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborbernat","html_url":"https://github.com/gaborbernat","followers_url":"https://api.github.com/users/gaborbernat/followers","following_url":"https://api.github.com/users/gaborbernat/following{/other_user}","gists_url":"https://api.github.com/users/gaborbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborbernat/subscriptions","organizations_url":"https://api.github.com/users/gaborbernat/orgs","repos_url":"https://api.github.com/users/gaborbernat/repos","events_url":"https://api.github.com/users/gaborbernat/events{/privacy}","received_events_url":"https://api.github.com/users/gaborbernat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gaborbernat/tox","description":"virtualenv management and test command line tool","fork":true,"url":"https://api.github.com/repos/gaborbernat/tox","forks_url":"https://api.github.com/repos/gaborbernat/tox/forks","keys_url":"https://api.github.com/repos/gaborbernat/tox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaborbernat/tox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaborbernat/tox/teams","hooks_url":"https://api.github.com/repos/gaborbernat/tox/hooks","issue_events_url":"https://api.github.com/repos/gaborbernat/tox/issues/events{/number}","events_url":"https://api.github.com/repos/gaborbernat/tox/events","assignees_url":"https://api.github.com/repos/gaborbernat/tox/assignees{/user}","branches_url":"https://api.github.com/repos/gaborbernat/tox/branches{/branch}","tags_url":"https://api.github.com/repos/gaborbernat/tox/tags","blobs_url":"https://api.github.com/repos/gaborbernat/tox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaborbernat/tox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaborbernat/tox/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaborbernat/tox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaborbernat/tox/statuses/{sha}","languages_url":"https://api.github.com/repos/gaborbernat/tox/languages","stargazers_url":"https://api.github.com/repos/gaborbernat/tox/stargazers","contributors_url":"https://api.github.com/repos/gaborbernat/tox/contributors","subscribers_url":"https://api.github.com/repos/gaborbernat/tox/subscribers","subscription_url":"https://api.github.com/repos/gaborbernat/tox/subscription","commits_url":"https://api.github.com/repos/gaborbernat/tox/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaborbernat/tox/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaborbernat/tox/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaborbernat/tox/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaborbernat/tox/contents/{+path}","compare_url":"https://api.github.com/repos/gaborbernat/tox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaborbernat/tox/merges","archive_url":"https://api.github.com/repos/gaborbernat/tox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaborbernat/tox/downloads","issues_url":"https://api.github.com/repos/gaborbernat/tox/issues{/number}","pulls_url":"https://api.github.com/repos/gaborbernat/tox/pulls{/number}","milestones_url":"https://api.github.com/repos/gaborbernat/tox/milestones{/number}","notifications_url":"https://api.github.com/repos/gaborbernat/tox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaborbernat/tox/labels{/name}","releases_url":"https://api.github.com/repos/gaborbernat/tox/releases{/id}","deployments_url":"https://api.github.com/repos/gaborbernat/tox/deployments","created_at":"2017-03-21T17:10:25Z","updated_at":"2018-09-18T18:44:10Z","pushed_at":"2018-09-19T20:44:44Z","git_url":"git://github.com/gaborbernat/tox.git","ssh_url":"git@github.com:gaborbernat/tox.git","clone_url":"https://github.com/gaborbernat/tox.git","svn_url":"https://github.com/gaborbernat/tox","homepage":"https://tox.readthedocs.org","size":9810,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tox-dev:master","ref":"master","sha":"cf6afcecaca22df7b509facaea43c09a15570f75","user":{"login":"tox-dev","id":20345659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ1NjU5","avatar_url":"https://avatars0.githubusercontent.com/u/20345659?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-dev","html_url":"https://github.com/tox-dev","followers_url":"https://api.github.com/users/tox-dev/followers","following_url":"https://api.github.com/users/tox-dev/following{/other_user}","gists_url":"https://api.github.com/users/tox-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-dev/subscriptions","organizations_url":"https://api.github.com/users/tox-dev/orgs","repos_url":"https://api.github.com/users/tox-dev/repos","events_url":"https://api.github.com/users/tox-dev/events{/privacy}","received_events_url":"https://api.github.com/users/tox-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":68465360,"node_id":"MDEwOlJlcG9zaXRvcnk2ODQ2NTM2MA==","name":"tox","full_name":"tox-dev/tox","private":false,"owner":{"login":"tox-dev","id":20345659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ1NjU5","avatar_url":"https://avatars0.githubusercontent.com/u/20345659?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-dev","html_url":"https://github.com/tox-dev","followers_url":"https://api.github.com/users/tox-dev/followers","following_url":"https://api.github.com/users/tox-dev/following{/other_user}","gists_url":"https://api.github.com/users/tox-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-dev/subscriptions","organizations_url":"https://api.github.com/users/tox-dev/orgs","repos_url":"https://api.github.com/users/tox-dev/repos","events_url":"https://api.github.com/users/tox-dev/events{/privacy}","received_events_url":"https://api.github.com/users/tox-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tox-dev/tox","description":"Command line driven CI frontend and development task automation tool","fork":false,"url":"https://api.github.com/repos/tox-dev/tox","forks_url":"https://api.github.com/repos/tox-dev/tox/forks","keys_url":"https://api.github.com/repos/tox-dev/tox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tox-dev/tox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tox-dev/tox/teams","hooks_url":"https://api.github.com/repos/tox-dev/tox/hooks","issue_events_url":"https://api.github.com/repos/tox-dev/tox/issues/events{/number}","events_url":"https://api.github.com/repos/tox-dev/tox/events","assignees_url":"https://api.github.com/repos/tox-dev/tox/assignees{/user}","branches_url":"https://api.github.com/repos/tox-dev/tox/branches{/branch}","tags_url":"https://api.github.com/repos/tox-dev/tox/tags","blobs_url":"https://api.github.com/repos/tox-dev/tox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tox-dev/tox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tox-dev/tox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tox-dev/tox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tox-dev/tox/statuses/{sha}","languages_url":"https://api.github.com/repos/tox-dev/tox/languages","stargazers_url":"https://api.github.com/repos/tox-dev/tox/stargazers","contributors_url":"https://api.github.com/repos/tox-dev/tox/contributors","subscribers_url":"https://api.github.com/repos/tox-dev/tox/subscribers","subscription_url":"https://api.github.com/repos/tox-dev/tox/subscription","commits_url":"https://api.github.com/repos/tox-dev/tox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tox-dev/tox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tox-dev/tox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tox-dev/tox/issues/comments{/number}","contents_url":"https://api.github.com/repos/tox-dev/tox/contents/{+path}","compare_url":"https://api.github.com/repos/tox-dev/tox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tox-dev/tox/merges","archive_url":"https://api.github.com/repos/tox-dev/tox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tox-dev/tox/downloads","issues_url":"https://api.github.com/repos/tox-dev/tox/issues{/number}","pulls_url":"https://api.github.com/repos/tox-dev/tox/pulls{/number}","milestones_url":"https://api.github.com/repos/tox-dev/tox/milestones{/number}","notifications_url":"https://api.github.com/repos/tox-dev/tox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tox-dev/tox/labels{/name}","releases_url":"https://api.github.com/repos/tox-dev/tox/releases{/id}","deployments_url":"https://api.github.com/repos/tox-dev/tox/deployments","created_at":"2016-09-17T16:54:22Z","updated_at":"2018-09-19T16:56:46Z","pushed_at":"2018-09-19T20:44:46Z","git_url":"git://github.com/tox-dev/tox.git","ssh_url":"git@github.com:tox-dev/tox.git","clone_url":"https://github.com/tox-dev/tox.git","svn_url":"https://github.com/tox-dev/tox","homepage":"https://tox.readthedocs.io","size":9822,"stargazers_count":633,"watchers_count":633,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":156,"open_issues":109,"watchers":633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tox-dev/tox/pulls/1000"},"html":{"href":"https://github.com/tox-dev/tox/pull/1000"},"issue":{"href":"https://api.github.com/repos/tox-dev/tox/issues/1000"},"comments":{"href":"https://api.github.com/repos/tox-dev/tox/issues/1000/comments"},"review_comments":{"href":"https://api.github.com/repos/tox-dev/tox/pulls/1000/comments"},"review_comment":{"href":"https://api.github.com/repos/tox-dev/tox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tox-dev/tox/pulls/1000/commits"},"statuses":{"href":"https://api.github.com/repos/tox-dev/tox/statuses/3ba22cc90ddd38929dbb38986a19db511c6ee270"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gaborbernat"}}