{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/187672580","pull_request_review_id":119506094,"id":187672580,"diff_hunk":"@@ -4008,5 +4008,60 @@\n         \"detect_code\": [\"7013\"],\n         \"release_versions\": [\"5\"],\n         \"bootloader_supported\": true\n+    },\n+    \"ARM_FM_Target\": {","path":"targets/targets.json","position":5,"original_position":5,"commit_id":"77d19295c1c72e86903a381b776dcdfd51df8853","original_commit_id":"77d19295c1c72e86903a381b776dcdfd51df8853","user":{"login":"theotherjimmy","id":685409,"avatar_url":"https://avatars2.githubusercontent.com/u/685409?v=4","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"body":"Please remove the redundant `Target`","created_at":"2018-05-11T16:55:54Z","updated_at":"2018-05-11T16:57:35Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/6862#discussion_r187672580","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6862","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/187672580"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6862#discussion_r187672580"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6862"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6862","id":187145907,"html_url":"https://github.com/ARMmbed/mbed-os/pull/6862","diff_url":"https://github.com/ARMmbed/mbed-os/pull/6862.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/6862.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6862","number":6862,"state":"open","locked":false,"title":"Fastmodels support: add FVP_MPS2 targets to mbed os","user":{"login":"jamesbeyond","id":34235743,"avatar_url":"https://avatars2.githubusercontent.com/u/34235743?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesbeyond","html_url":"https://github.com/jamesbeyond","followers_url":"https://api.github.com/users/jamesbeyond/followers","following_url":"https://api.github.com/users/jamesbeyond/following{/other_user}","gists_url":"https://api.github.com/users/jamesbeyond/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesbeyond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesbeyond/subscriptions","organizations_url":"https://api.github.com/users/jamesbeyond/orgs","repos_url":"https://api.github.com/users/jamesbeyond/repos","events_url":"https://api.github.com/users/jamesbeyond/events{/privacy}","received_events_url":"https://api.github.com/users/jamesbeyond/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n* add TARGET_ARM_FM top level folder in targets \r\n* add TARGET_FVP_MPS2 platform category\r\n* add following targets to the FVP_MPS2 category\r\n\r\n   * FVP_MPS2_M0\r\n   * FVP_MPS2_M0P\r\n   * FVP_MPS2_M3\r\n   * FVP_MPS2_M4\r\n   * FVP_MPS2_M7\r\n\r\n* add all necessary drivers for FVP_MPS2 platfrom and each target\r\n* add toolchian scripts for ARM, GCC_ARM and IAR\r\n* modify target.json enable mbed for fastmodel FVP_MPS2 targets\r\n\r\n\r\n### Pull request type\r\n\r\n    [ ] Fix\r\n    [ ] Refactor\r\n    [x] New target\r\n    [ ] Feature\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-05-10T09:40:07Z","updated_at":"2018-05-11T16:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0dfda126c72441225e98f2f205d6000e5d0e8a13","assignee":null,"assignees":[],"requested_reviewers":[{"login":"c1728p9","id":2916772,"avatar_url":"https://avatars2.githubusercontent.com/u/2916772?v=4","gravatar_id":"","url":"https://api.github.com/users/c1728p9","html_url":"https://github.com/c1728p9","followers_url":"https://api.github.com/users/c1728p9/followers","following_url":"https://api.github.com/users/c1728p9/following{/other_user}","gists_url":"https://api.github.com/users/c1728p9/gists{/gist_id}","starred_url":"https://api.github.com/users/c1728p9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c1728p9/subscriptions","organizations_url":"https://api.github.com/users/c1728p9/orgs","repos_url":"https://api.github.com/users/c1728p9/repos","events_url":"https://api.github.com/users/c1728p9/events{/privacy}","received_events_url":"https://api.github.com/users/c1728p9/received_events","type":"User","site_admin":false},{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":147112891,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6862/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6862/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6862/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/77d19295c1c72e86903a381b776dcdfd51df8853","head":{"label":"jamesbeyond:fastmodel_support","ref":"fastmodel_support","sha":"77d19295c1c72e86903a381b776dcdfd51df8853","user":{"login":"jamesbeyond","id":34235743,"avatar_url":"https://avatars2.githubusercontent.com/u/34235743?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesbeyond","html_url":"https://github.com/jamesbeyond","followers_url":"https://api.github.com/users/jamesbeyond/followers","following_url":"https://api.github.com/users/jamesbeyond/following{/other_user}","gists_url":"https://api.github.com/users/jamesbeyond/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesbeyond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesbeyond/subscriptions","organizations_url":"https://api.github.com/users/jamesbeyond/orgs","repos_url":"https://api.github.com/users/jamesbeyond/repos","events_url":"https://api.github.com/users/jamesbeyond/events{/privacy}","received_events_url":"https://api.github.com/users/jamesbeyond/received_events","type":"User","site_admin":false},"repo":{"id":129410273,"name":"mbed-os","full_name":"jamesbeyond/mbed-os","owner":{"login":"jamesbeyond","id":34235743,"avatar_url":"https://avatars2.githubusercontent.com/u/34235743?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesbeyond","html_url":"https://github.com/jamesbeyond","followers_url":"https://api.github.com/users/jamesbeyond/followers","following_url":"https://api.github.com/users/jamesbeyond/following{/other_user}","gists_url":"https://api.github.com/users/jamesbeyond/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesbeyond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesbeyond/subscriptions","organizations_url":"https://api.github.com/users/jamesbeyond/orgs","repos_url":"https://api.github.com/users/jamesbeyond/repos","events_url":"https://api.github.com/users/jamesbeyond/events{/privacy}","received_events_url":"https://api.github.com/users/jamesbeyond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesbeyond/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/jamesbeyond/mbed-os","forks_url":"https://api.github.com/repos/jamesbeyond/mbed-os/forks","keys_url":"https://api.github.com/repos/jamesbeyond/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesbeyond/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesbeyond/mbed-os/teams","hooks_url":"https://api.github.com/repos/jamesbeyond/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/jamesbeyond/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/jamesbeyond/mbed-os/events","assignees_url":"https://api.github.com/repos/jamesbeyond/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/jamesbeyond/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/jamesbeyond/mbed-os/tags","blobs_url":"https://api.github.com/repos/jamesbeyond/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesbeyond/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesbeyond/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesbeyond/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesbeyond/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesbeyond/mbed-os/languages","stargazers_url":"https://api.github.com/repos/jamesbeyond/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/jamesbeyond/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/jamesbeyond/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/jamesbeyond/mbed-os/subscription","commits_url":"https://api.github.com/repos/jamesbeyond/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesbeyond/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesbeyond/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesbeyond/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamesbeyond/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/jamesbeyond/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesbeyond/mbed-os/merges","archive_url":"https://api.github.com/repos/jamesbeyond/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesbeyond/mbed-os/downloads","issues_url":"https://api.github.com/repos/jamesbeyond/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/jamesbeyond/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesbeyond/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesbeyond/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesbeyond/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/jamesbeyond/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/jamesbeyond/mbed-os/deployments","created_at":"2018-04-13T14:03:09Z","updated_at":"2018-05-09T23:26:46Z","pushed_at":"2018-05-10T14:39:56Z","git_url":"git://github.com/jamesbeyond/mbed-os.git","ssh_url":"git@github.com:jamesbeyond/mbed-os.git","clone_url":"https://github.com/jamesbeyond/mbed-os.git","svn_url":"https://github.com/jamesbeyond/mbed-os","homepage":"https://mbed.com","size":206142,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"634774f45f8c7da0a9972d2ee15e7bd5fcd7a27f","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-05-11T11:07:18Z","pushed_at":"2018-05-11T16:30:51Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":206395,"stargazers_count":1651,"watchers_count":1651,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1449,"mirror_url":null,"archived":false,"open_issues_count":489,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1449,"open_issues":489,"watchers":1651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6862"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6862"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6862"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6862/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6862/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6862/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/77d19295c1c72e86903a381b776dcdfd51df8853"}},"author_association":"NONE"}}
{"actor":{"display_login":"theotherjimmy"}}