{"action":"closed","number":96,"pull_request":{"url":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls/96","id":191277646,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjc3NjQ2","html_url":"https://github.com/nypublicradio/nypr-ui/pull/96","diff_url":"https://github.com/nypublicradio/nypr-ui/pull/96.diff","patch_url":"https://github.com/nypublicradio/nypr-ui/pull/96.patch","issue_url":"https://api.github.com/repos/nypublicradio/nypr-ui/issues/96","number":96,"state":"closed","locked":false,"title":"Web Client Tests","user":{"login":"noslouch","id":2090382,"node_id":"MDQ6VXNlcjIwOTAzODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2090382?v=4","gravatar_id":"","url":"https://api.github.com/users/noslouch","html_url":"https://github.com/noslouch","followers_url":"https://api.github.com/users/noslouch/followers","following_url":"https://api.github.com/users/noslouch/following{/other_user}","gists_url":"https://api.github.com/users/noslouch/gists{/gist_id}","starred_url":"https://api.github.com/users/noslouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noslouch/subscriptions","organizations_url":"https://api.github.com/users/noslouch/orgs","repos_url":"https://api.github.com/users/noslouch/repos","events_url":"https://api.github.com/users/noslouch/events{/privacy}","received_events_url":"https://api.github.com/users/noslouch/received_events","type":"User","site_admin":false},"body":"This circle file patch adds a serious test suite to the repo.\r\n\r\nThe plan is that on commits to master, Circle will clone the wnyc, wqxr, new sounds, and wnyc studios web clients and run their test suites against this version of nypr-ui. \r\n\r\n~Unfortunately, YAML does not support destructuring arrays, so there is a lot of duplication in the `steps` section for each of the web client tests. I'm open to hearing other ways we can clean up this file. Each web client has a similar set of steps, but they're not all the same.~\r\n\r\nFigured out a way to reduce all the duplication and migrated this pattern to the rest of the addons.","created_at":"2018-05-29T21:39:42Z","updated_at":"2018-06-25T15:34:05Z","closed_at":"2018-06-25T15:34:05Z","merged_at":"2018-06-25T15:34:05Z","merge_commit_sha":"c3005c29e8fb327aa837356cdde18d97a3fd09d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattoberle","id":7646607,"node_id":"MDQ6VXNlcjc2NDY2MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7646607?v=4","gravatar_id":"","url":"https://api.github.com/users/mattoberle","html_url":"https://github.com/mattoberle","followers_url":"https://api.github.com/users/mattoberle/followers","following_url":"https://api.github.com/users/mattoberle/following{/other_user}","gists_url":"https://api.github.com/users/mattoberle/gists{/gist_id}","starred_url":"https://api.github.com/users/mattoberle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattoberle/subscriptions","organizations_url":"https://api.github.com/users/mattoberle/orgs","repos_url":"https://api.github.com/users/mattoberle/repos","events_url":"https://api.github.com/users/mattoberle/events{/privacy}","received_events_url":"https://api.github.com/users/mattoberle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls/96/commits","review_comments_url":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls/96/comments","review_comment_url":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nypublicradio/nypr-ui/issues/96/comments","statuses_url":"https://api.github.com/repos/nypublicradio/nypr-ui/statuses/f50107ba37d4019400b66278fe29b7dfb860547c","head":{"label":"nypublicradio:qa-build","ref":"qa-build","sha":"f50107ba37d4019400b66278fe29b7dfb860547c","user":{"login":"nypublicradio","id":1070797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzA3OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1070797?v=4","gravatar_id":"","url":"https://api.github.com/users/nypublicradio","html_url":"https://github.com/nypublicradio","followers_url":"https://api.github.com/users/nypublicradio/followers","following_url":"https://api.github.com/users/nypublicradio/following{/other_user}","gists_url":"https://api.github.com/users/nypublicradio/gists{/gist_id}","starred_url":"https://api.github.com/users/nypublicradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nypublicradio/subscriptions","organizations_url":"https://api.github.com/users/nypublicradio/orgs","repos_url":"https://api.github.com/users/nypublicradio/repos","events_url":"https://api.github.com/users/nypublicradio/events{/privacy}","received_events_url":"https://api.github.com/users/nypublicradio/received_events","type":"Organization","site_admin":false},"repo":{"id":76890430,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg5MDQzMA==","name":"nypr-ui","full_name":"nypublicradio/nypr-ui","owner":{"login":"nypublicradio","id":1070797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzA3OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1070797?v=4","gravatar_id":"","url":"https://api.github.com/users/nypublicradio","html_url":"https://github.com/nypublicradio","followers_url":"https://api.github.com/users/nypublicradio/followers","following_url":"https://api.github.com/users/nypublicradio/following{/other_user}","gists_url":"https://api.github.com/users/nypublicradio/gists{/gist_id}","starred_url":"https://api.github.com/users/nypublicradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nypublicradio/subscriptions","organizations_url":"https://api.github.com/users/nypublicradio/orgs","repos_url":"https://api.github.com/users/nypublicradio/repos","events_url":"https://api.github.com/users/nypublicradio/events{/privacy}","received_events_url":"https://api.github.com/users/nypublicradio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nypublicradio/nypr-ui","description":"Ember UI library for NYPR properties","fork":false,"url":"https://api.github.com/repos/nypublicradio/nypr-ui","forks_url":"https://api.github.com/repos/nypublicradio/nypr-ui/forks","keys_url":"https://api.github.com/repos/nypublicradio/nypr-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nypublicradio/nypr-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nypublicradio/nypr-ui/teams","hooks_url":"https://api.github.com/repos/nypublicradio/nypr-ui/hooks","issue_events_url":"https://api.github.com/repos/nypublicradio/nypr-ui/issues/events{/number}","events_url":"https://api.github.com/repos/nypublicradio/nypr-ui/events","assignees_url":"https://api.github.com/repos/nypublicradio/nypr-ui/assignees{/user}","branches_url":"https://api.github.com/repos/nypublicradio/nypr-ui/branches{/branch}","tags_url":"https://api.github.com/repos/nypublicradio/nypr-ui/tags","blobs_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nypublicradio/nypr-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/nypublicradio/nypr-ui/languages","stargazers_url":"https://api.github.com/repos/nypublicradio/nypr-ui/stargazers","contributors_url":"https://api.github.com/repos/nypublicradio/nypr-ui/contributors","subscribers_url":"https://api.github.com/repos/nypublicradio/nypr-ui/subscribers","subscription_url":"https://api.github.com/repos/nypublicradio/nypr-ui/subscription","commits_url":"https://api.github.com/repos/nypublicradio/nypr-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/nypublicradio/nypr-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/nypublicradio/nypr-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/nypublicradio/nypr-ui/contents/{+path}","compare_url":"https://api.github.com/repos/nypublicradio/nypr-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nypublicradio/nypr-ui/merges","archive_url":"https://api.github.com/repos/nypublicradio/nypr-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nypublicradio/nypr-ui/downloads","issues_url":"https://api.github.com/repos/nypublicradio/nypr-ui/issues{/number}","pulls_url":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/nypublicradio/nypr-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/nypublicradio/nypr-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nypublicradio/nypr-ui/labels{/name}","releases_url":"https://api.github.com/repos/nypublicradio/nypr-ui/releases{/id}","deployments_url":"https://api.github.com/repos/nypublicradio/nypr-ui/deployments","created_at":"2016-12-19T19:21:24Z","updated_at":"2018-06-07T20:21:29Z","pushed_at":"2018-06-25T15:34:05Z","git_url":"git://github.com/nypublicradio/nypr-ui.git","ssh_url":"git@github.com:nypublicradio/nypr-ui.git","clone_url":"https://github.com/nypublicradio/nypr-ui.git","svn_url":"https://github.com/nypublicradio/nypr-ui","homepage":null,"size":3989,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"nypublicradio:master","ref":"master","sha":"82bade052a4d1e9575bd79be9a631b516f4e8e02","user":{"login":"nypublicradio","id":1070797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzA3OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1070797?v=4","gravatar_id":"","url":"https://api.github.com/users/nypublicradio","html_url":"https://github.com/nypublicradio","followers_url":"https://api.github.com/users/nypublicradio/followers","following_url":"https://api.github.com/users/nypublicradio/following{/other_user}","gists_url":"https://api.github.com/users/nypublicradio/gists{/gist_id}","starred_url":"https://api.github.com/users/nypublicradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nypublicradio/subscriptions","organizations_url":"https://api.github.com/users/nypublicradio/orgs","repos_url":"https://api.github.com/users/nypublicradio/repos","events_url":"https://api.github.com/users/nypublicradio/events{/privacy}","received_events_url":"https://api.github.com/users/nypublicradio/received_events","type":"Organization","site_admin":false},"repo":{"id":76890430,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg5MDQzMA==","name":"nypr-ui","full_name":"nypublicradio/nypr-ui","owner":{"login":"nypublicradio","id":1070797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzA3OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1070797?v=4","gravatar_id":"","url":"https://api.github.com/users/nypublicradio","html_url":"https://github.com/nypublicradio","followers_url":"https://api.github.com/users/nypublicradio/followers","following_url":"https://api.github.com/users/nypublicradio/following{/other_user}","gists_url":"https://api.github.com/users/nypublicradio/gists{/gist_id}","starred_url":"https://api.github.com/users/nypublicradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nypublicradio/subscriptions","organizations_url":"https://api.github.com/users/nypublicradio/orgs","repos_url":"https://api.github.com/users/nypublicradio/repos","events_url":"https://api.github.com/users/nypublicradio/events{/privacy}","received_events_url":"https://api.github.com/users/nypublicradio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nypublicradio/nypr-ui","description":"Ember UI library for NYPR properties","fork":false,"url":"https://api.github.com/repos/nypublicradio/nypr-ui","forks_url":"https://api.github.com/repos/nypublicradio/nypr-ui/forks","keys_url":"https://api.github.com/repos/nypublicradio/nypr-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nypublicradio/nypr-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nypublicradio/nypr-ui/teams","hooks_url":"https://api.github.com/repos/nypublicradio/nypr-ui/hooks","issue_events_url":"https://api.github.com/repos/nypublicradio/nypr-ui/issues/events{/number}","events_url":"https://api.github.com/repos/nypublicradio/nypr-ui/events","assignees_url":"https://api.github.com/repos/nypublicradio/nypr-ui/assignees{/user}","branches_url":"https://api.github.com/repos/nypublicradio/nypr-ui/branches{/branch}","tags_url":"https://api.github.com/repos/nypublicradio/nypr-ui/tags","blobs_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nypublicradio/nypr-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/nypublicradio/nypr-ui/languages","stargazers_url":"https://api.github.com/repos/nypublicradio/nypr-ui/stargazers","contributors_url":"https://api.github.com/repos/nypublicradio/nypr-ui/contributors","subscribers_url":"https://api.github.com/repos/nypublicradio/nypr-ui/subscribers","subscription_url":"https://api.github.com/repos/nypublicradio/nypr-ui/subscription","commits_url":"https://api.github.com/repos/nypublicradio/nypr-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/nypublicradio/nypr-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/nypublicradio/nypr-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/nypublicradio/nypr-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/nypublicradio/nypr-ui/contents/{+path}","compare_url":"https://api.github.com/repos/nypublicradio/nypr-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nypublicradio/nypr-ui/merges","archive_url":"https://api.github.com/repos/nypublicradio/nypr-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nypublicradio/nypr-ui/downloads","issues_url":"https://api.github.com/repos/nypublicradio/nypr-ui/issues{/number}","pulls_url":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/nypublicradio/nypr-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/nypublicradio/nypr-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nypublicradio/nypr-ui/labels{/name}","releases_url":"https://api.github.com/repos/nypublicradio/nypr-ui/releases{/id}","deployments_url":"https://api.github.com/repos/nypublicradio/nypr-ui/deployments","created_at":"2016-12-19T19:21:24Z","updated_at":"2018-06-07T20:21:29Z","pushed_at":"2018-06-25T15:34:05Z","git_url":"git://github.com/nypublicradio/nypr-ui.git","ssh_url":"git@github.com:nypublicradio/nypr-ui.git","clone_url":"https://github.com/nypublicradio/nypr-ui.git","svn_url":"https://github.com/nypublicradio/nypr-ui","homepage":null,"size":3989,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls/96"},"html":{"href":"https://github.com/nypublicradio/nypr-ui/pull/96"},"issue":{"href":"https://api.github.com/repos/nypublicradio/nypr-ui/issues/96"},"comments":{"href":"https://api.github.com/repos/nypublicradio/nypr-ui/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nypublicradio/nypr-ui/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/nypublicradio/nypr-ui/statuses/f50107ba37d4019400b66278fe29b7dfb860547c"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"noslouch","id":2090382,"node_id":"MDQ6VXNlcjIwOTAzODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2090382?v=4","gravatar_id":"","url":"https://api.github.com/users/noslouch","html_url":"https://github.com/noslouch","followers_url":"https://api.github.com/users/noslouch/followers","following_url":"https://api.github.com/users/noslouch/following{/other_user}","gists_url":"https://api.github.com/users/noslouch/gists{/gist_id}","starred_url":"https://api.github.com/users/noslouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noslouch/subscriptions","organizations_url":"https://api.github.com/users/noslouch/orgs","repos_url":"https://api.github.com/users/noslouch/repos","events_url":"https://api.github.com/users/noslouch/events{/privacy}","received_events_url":"https://api.github.com/users/noslouch/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":45,"additions":268,"deletions":63,"changed_files":1}}
{"actor":{"display_login":"noslouch"}}