{"action":"closed","number":6921,"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/6921","id":239741329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NzQxMzI5","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/6921","diff_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/6921.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/6921.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/6921","number":6921,"state":"closed","locked":false,"title":"r/aws_securityhub: Add aws_securityhub_product_subscription resource","user":{"login":"gazoakley","id":261262,"node_id":"MDQ6VXNlcjI2MTI2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/261262?v=4","gravatar_id":"","url":"https://api.github.com/users/gazoakley","html_url":"https://github.com/gazoakley","followers_url":"https://api.github.com/users/gazoakley/followers","following_url":"https://api.github.com/users/gazoakley/following{/other_user}","gists_url":"https://api.github.com/users/gazoakley/gists{/gist_id}","starred_url":"https://api.github.com/users/gazoakley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazoakley/subscriptions","organizations_url":"https://api.github.com/users/gazoakley/orgs","repos_url":"https://api.github.com/users/gazoakley/repos","events_url":"https://api.github.com/users/gazoakley/events{/privacy}","received_events_url":"https://api.github.com/users/gazoakley/received_events","type":"User","site_admin":false},"body":"<!--- Information about referencing Github Issues: https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests --->\r\nPartly addresses #6674 \r\n\r\nChanges proposed in this pull request:\r\n\r\n* **New Resource:** `aws_securityhub_product_subscription`\r\n\r\nOutput from acceptance testing:\r\n\r\n```\r\n$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSecurityHub/ProductSubscription'\r\n==> Checking that code complies with gofmt requirements...\r\nTF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSecurityHub/ProductSubscription -timeout 120m\r\n=== RUN   TestAccAWSSecurityHub\r\n=== RUN   TestAccAWSSecurityHub/ProductSubscription\r\n=== RUN   TestAccAWSSecurityHub/ProductSubscription/basic\r\n--- PASS: TestAccAWSSecurityHub (46.97s)\r\n    --- PASS: TestAccAWSSecurityHub/ProductSubscription (46.97s)\r\n        --- PASS: TestAccAWSSecurityHub/ProductSubscription/basic (46.97s)\r\nPASS\r\nok  \tgithub.com/terraform-providers/terraform-provider-aws/aws\t47.021s\r\n```","created_at":"2018-12-19T07:52:28Z","updated_at":"2018-12-21T13:46:57Z","closed_at":"2018-12-21T13:46:56Z","merged_at":"2018-12-21T13:46:56Z","merge_commit_sha":"8a46bfb6dff12d53a3c7ca4b0df6883a1850d7ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620316276,"node_id":"MDU6TGFiZWw2MjAzMTYyNzY=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/documentation","name":"documentation","color":"fef2c0","default":false},{"id":625892945,"node_id":"MDU6TGFiZWw2MjU4OTI5NDU=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/new-resource","name":"new-resource","color":"d4c5f9","default":false},{"id":819351775,"node_id":"MDU6TGFiZWw4MTkzNTE3NzU=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/provider","name":"provider","color":"bfd4f2","default":false},{"id":1145653887,"node_id":"MDU6TGFiZWwxMTQ1NjUzODg3","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/service/securityhub","name":"service/securityhub","color":"bfd4f2","default":false},{"id":737832191,"node_id":"MDU6TGFiZWw3Mzc4MzIxOTE=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/size/XL","name":"size/XL","color":"ffffff","default":false},{"id":784095310,"node_id":"MDU6TGFiZWw3ODQwOTUzMTA=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/tests","name":"tests","color":"DDDDDD","default":false}],"milestone":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones/60","html_url":"https://github.com/terraform-providers/terraform-provider-aws/milestone/60","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones/60/labels","id":3897917,"node_id":"MDk6TWlsZXN0b25lMzg5NzkxNw==","number":60,"title":"v1.54.0","description":"","creator":{"login":"bflad","id":189114,"node_id":"MDQ6VXNlcjE4OTExNA==","avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":3,"state":"open","created_at":"2018-12-13T21:49:47Z","updated_at":"2018-12-21T13:46:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/6921/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/6921/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/6921/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/73f02d01222f1ddcd933a21fe91529f6e1df8625","head":{"label":"gazoakley:f-security-hub-product","ref":"f-security-hub-product","sha":"73f02d01222f1ddcd933a21fe91529f6e1df8625","user":{"login":"gazoakley","id":261262,"node_id":"MDQ6VXNlcjI2MTI2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/261262?v=4","gravatar_id":"","url":"https://api.github.com/users/gazoakley","html_url":"https://github.com/gazoakley","followers_url":"https://api.github.com/users/gazoakley/followers","following_url":"https://api.github.com/users/gazoakley/following{/other_user}","gists_url":"https://api.github.com/users/gazoakley/gists{/gist_id}","starred_url":"https://api.github.com/users/gazoakley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazoakley/subscriptions","organizations_url":"https://api.github.com/users/gazoakley/orgs","repos_url":"https://api.github.com/users/gazoakley/repos","events_url":"https://api.github.com/users/gazoakley/events{/privacy}","received_events_url":"https://api.github.com/users/gazoakley/received_events","type":"User","site_admin":false},"repo":{"id":101033990,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEwMzM5OTA=","name":"terraform-provider-aws","full_name":"gazoakley/terraform-provider-aws","private":false,"owner":{"login":"gazoakley","id":261262,"node_id":"MDQ6VXNlcjI2MTI2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/261262?v=4","gravatar_id":"","url":"https://api.github.com/users/gazoakley","html_url":"https://github.com/gazoakley","followers_url":"https://api.github.com/users/gazoakley/followers","following_url":"https://api.github.com/users/gazoakley/following{/other_user}","gists_url":"https://api.github.com/users/gazoakley/gists{/gist_id}","starred_url":"https://api.github.com/users/gazoakley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazoakley/subscriptions","organizations_url":"https://api.github.com/users/gazoakley/orgs","repos_url":"https://api.github.com/users/gazoakley/repos","events_url":"https://api.github.com/users/gazoakley/events{/privacy}","received_events_url":"https://api.github.com/users/gazoakley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gazoakley/terraform-provider-aws","description":"Terraform aws provider","fork":true,"url":"https://api.github.com/repos/gazoakley/terraform-provider-aws","forks_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/gazoakley/terraform-provider-aws/deployments","created_at":"2017-08-22T07:23:11Z","updated_at":"2018-09-12T07:39:32Z","pushed_at":"2018-12-21T13:24:48Z","git_url":"git://github.com/gazoakley/terraform-provider-aws.git","ssh_url":"git@github.com:gazoakley/terraform-provider-aws.git","clone_url":"https://github.com/gazoakley/terraform-provider-aws.git","svn_url":"https://github.com/gazoakley/terraform-provider-aws","homepage":"","size":63162,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"cfb1543fffbd150e4ff321e980b8ddef3edbfcd4","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93444615,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NDYxNQ==","name":"terraform-provider-aws","full_name":"terraform-providers/terraform-provider-aws","private":false,"owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-providers/terraform-provider-aws","description":"Terraform AWS provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/deployments","created_at":"2017-06-05T20:37:52Z","updated_at":"2018-12-21T13:10:42Z","pushed_at":"2018-12-21T13:46:56Z","git_url":"git://github.com/terraform-providers/terraform-provider-aws.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-aws.git","clone_url":"https://github.com/terraform-providers/terraform-provider-aws.git","svn_url":"https://github.com/terraform-providers/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":65338,"stargazers_count":1943,"watchers_count":1943,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1695,"mirror_url":null,"archived":false,"open_issues_count":2051,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1695,"open_issues":2051,"watchers":1943,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/6921"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/6921"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/6921"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/6921/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/6921/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/6921/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/73f02d01222f1ddcd933a21fe91529f6e1df8625"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bflad","id":189114,"node_id":"MDQ6VXNlcjE4OTExNA==","avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"comments":1,"review_comments":11,"maintainer_can_modify":false,"commits":3,"additions":328,"deletions":0,"changed_files":6}}
{"actor":{"display_login":"bflad"}}