{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/ledger-app/pulls/comments/226214117","pull_request_review_id":165979450,"id":226214117,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjIxNDExNw==","diff_hunk":"@@ -850,13 +852,17 @@ void handleSign(uint8_t p1, uint8_t p2, uint8_t *workBuffer, uint16_t dataLength\n     if (p2 != 0) {\n         THROW(0x6B00);\n     }\n+    if (dataLength < 0x48){","path":"src_genericwallet/main.c","position":360,"original_position":35,"commit_id":"24ae278fd7d3068a89acfa350e9f59917d8b0e32","original_commit_id":"fc849d680b3e765d71aa37cdbf49b3973da830ef","user":{"login":"CedrikNikita","id":9008074,"node_id":"MDQ6VXNlcjkwMDgwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9008074?v=4","gravatar_id":"","url":"https://api.github.com/users/CedrikNikita","html_url":"https://github.com/CedrikNikita","followers_url":"https://api.github.com/users/CedrikNikita/followers","following_url":"https://api.github.com/users/CedrikNikita/following{/other_user}","gists_url":"https://api.github.com/users/CedrikNikita/gists{/gist_id}","starred_url":"https://api.github.com/users/CedrikNikita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CedrikNikita/subscriptions","organizations_url":"https://api.github.com/users/CedrikNikita/orgs","repos_url":"https://api.github.com/users/CedrikNikita/repos","events_url":"https://api.github.com/users/CedrikNikita/events{/privacy}","received_events_url":"https://api.github.com/users/CedrikNikita/received_events","type":"User","site_admin":false},"body":"Because it's the minimum length of spend transaction","created_at":"2018-10-18T08:34:05Z","updated_at":"2018-10-18T08:34:05Z","html_url":"https://github.com/aeternity/ledger-app/pull/11#discussion_r226214117","pull_request_url":"https://api.github.com/repos/aeternity/ledger-app/pulls/11","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/aeternity/ledger-app/pulls/comments/226214117"},"html":{"href":"https://github.com/aeternity/ledger-app/pull/11#discussion_r226214117"},"pull_request":{"href":"https://api.github.com/repos/aeternity/ledger-app/pulls/11"}},"in_reply_to_id":226182652},"pull_request":{"url":"https://api.github.com/repos/aeternity/ledger-app/pulls/11","id":223500093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTAwMDkz","html_url":"https://github.com/aeternity/ledger-app/pull/11","diff_url":"https://github.com/aeternity/ledger-app/pull/11.diff","patch_url":"https://github.com/aeternity/ledger-app/pull/11.patch","issue_url":"https://api.github.com/repos/aeternity/ledger-app/issues/11","number":11,"state":"open","locked":false,"title":"Spend transaction details","user":{"login":"CedrikNikita","id":9008074,"node_id":"MDQ6VXNlcjkwMDgwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9008074?v=4","gravatar_id":"","url":"https://api.github.com/users/CedrikNikita","html_url":"https://github.com/CedrikNikita","followers_url":"https://api.github.com/users/CedrikNikita/followers","following_url":"https://api.github.com/users/CedrikNikita/following{/other_user}","gists_url":"https://api.github.com/users/CedrikNikita/gists{/gist_id}","starred_url":"https://api.github.com/users/CedrikNikita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CedrikNikita/subscriptions","organizations_url":"https://api.github.com/users/CedrikNikita/orgs","repos_url":"https://api.github.com/users/CedrikNikita/repos","events_url":"https://api.github.com/users/CedrikNikita/events{/privacy}","received_events_url":"https://api.github.com/users/CedrikNikita/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-17T07:47:55Z","updated_at":"2018-10-18T08:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de28259519279f0c87e4f1cbbfab761e32fc0c24","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/ledger-app/pulls/11/commits","review_comments_url":"https://api.github.com/repos/aeternity/ledger-app/pulls/11/comments","review_comment_url":"https://api.github.com/repos/aeternity/ledger-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/ledger-app/issues/11/comments","statuses_url":"https://api.github.com/repos/aeternity/ledger-app/statuses/24ae278fd7d3068a89acfa350e9f59917d8b0e32","head":{"label":"aeternity:spend-transaction-details","ref":"spend-transaction-details","sha":"24ae278fd7d3068a89acfa350e9f59917d8b0e32","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":149945328,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk5NDUzMjg=","name":"ledger-app","full_name":"aeternity/ledger-app","private":false,"owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aeternity/ledger-app","description":"æternity wallet application for Ledger Nano S","fork":true,"url":"https://api.github.com/repos/aeternity/ledger-app","forks_url":"https://api.github.com/repos/aeternity/ledger-app/forks","keys_url":"https://api.github.com/repos/aeternity/ledger-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/ledger-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/ledger-app/teams","hooks_url":"https://api.github.com/repos/aeternity/ledger-app/hooks","issue_events_url":"https://api.github.com/repos/aeternity/ledger-app/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/ledger-app/events","assignees_url":"https://api.github.com/repos/aeternity/ledger-app/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/ledger-app/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/ledger-app/tags","blobs_url":"https://api.github.com/repos/aeternity/ledger-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/ledger-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/ledger-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/ledger-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/ledger-app/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/ledger-app/languages","stargazers_url":"https://api.github.com/repos/aeternity/ledger-app/stargazers","contributors_url":"https://api.github.com/repos/aeternity/ledger-app/contributors","subscribers_url":"https://api.github.com/repos/aeternity/ledger-app/subscribers","subscription_url":"https://api.github.com/repos/aeternity/ledger-app/subscription","commits_url":"https://api.github.com/repos/aeternity/ledger-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/ledger-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/ledger-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/ledger-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/ledger-app/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/ledger-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/ledger-app/merges","archive_url":"https://api.github.com/repos/aeternity/ledger-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/ledger-app/downloads","issues_url":"https://api.github.com/repos/aeternity/ledger-app/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/ledger-app/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/ledger-app/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/ledger-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/ledger-app/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/ledger-app/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/ledger-app/deployments","created_at":"2018-09-23T03:42:03Z","updated_at":"2018-10-18T08:09:29Z","pushed_at":"2018-10-18T08:09:28Z","git_url":"git://github.com/aeternity/ledger-app.git","ssh_url":"git@github.com:aeternity/ledger-app.git","clone_url":"https://github.com/aeternity/ledger-app.git","svn_url":"https://github.com/aeternity/ledger-app","homepage":"","size":518,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"aeternity:master","ref":"master","sha":"96bf7bf1813280ad342fb7cf6a99cfe59959d47b","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":149945328,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk5NDUzMjg=","name":"ledger-app","full_name":"aeternity/ledger-app","private":false,"owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aeternity/ledger-app","description":"æternity wallet application for Ledger Nano S","fork":true,"url":"https://api.github.com/repos/aeternity/ledger-app","forks_url":"https://api.github.com/repos/aeternity/ledger-app/forks","keys_url":"https://api.github.com/repos/aeternity/ledger-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/ledger-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/ledger-app/teams","hooks_url":"https://api.github.com/repos/aeternity/ledger-app/hooks","issue_events_url":"https://api.github.com/repos/aeternity/ledger-app/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/ledger-app/events","assignees_url":"https://api.github.com/repos/aeternity/ledger-app/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/ledger-app/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/ledger-app/tags","blobs_url":"https://api.github.com/repos/aeternity/ledger-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/ledger-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/ledger-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/ledger-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/ledger-app/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/ledger-app/languages","stargazers_url":"https://api.github.com/repos/aeternity/ledger-app/stargazers","contributors_url":"https://api.github.com/repos/aeternity/ledger-app/contributors","subscribers_url":"https://api.github.com/repos/aeternity/ledger-app/subscribers","subscription_url":"https://api.github.com/repos/aeternity/ledger-app/subscription","commits_url":"https://api.github.com/repos/aeternity/ledger-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/ledger-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/ledger-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/ledger-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/ledger-app/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/ledger-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/ledger-app/merges","archive_url":"https://api.github.com/repos/aeternity/ledger-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/ledger-app/downloads","issues_url":"https://api.github.com/repos/aeternity/ledger-app/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/ledger-app/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/ledger-app/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/ledger-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/ledger-app/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/ledger-app/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/ledger-app/deployments","created_at":"2018-09-23T03:42:03Z","updated_at":"2018-10-18T08:09:29Z","pushed_at":"2018-10-18T08:09:28Z","git_url":"git://github.com/aeternity/ledger-app.git","ssh_url":"git@github.com:aeternity/ledger-app.git","clone_url":"https://github.com/aeternity/ledger-app.git","svn_url":"https://github.com/aeternity/ledger-app","homepage":"","size":518,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/ledger-app/pulls/11"},"html":{"href":"https://github.com/aeternity/ledger-app/pull/11"},"issue":{"href":"https://api.github.com/repos/aeternity/ledger-app/issues/11"},"comments":{"href":"https://api.github.com/repos/aeternity/ledger-app/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/ledger-app/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/ledger-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/ledger-app/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/ledger-app/statuses/24ae278fd7d3068a89acfa350e9f59917d8b0e32"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"CedrikNikita"}}