{"action":"created","issue":{"url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1042","repository_url":"https://api.github.com/repos/vulkano-rs/vulkano","labels_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1042/labels{/name}","comments_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1042/comments","events_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1042/events","html_url":"https://github.com/vulkano-rs/vulkano/issues/1042","id":360655272,"node_id":"MDU6SXNzdWUzNjA2NTUyNzI=","number":1042,"title":"Convertion to 2018 Module System","user":{"login":"NathanielAJohnson","id":380720,"node_id":"MDQ6VXNlcjM4MDcyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/380720?v=4","gravatar_id":"","url":"https://api.github.com/users/NathanielAJohnson","html_url":"https://github.com/NathanielAJohnson","followers_url":"https://api.github.com/users/NathanielAJohnson/followers","following_url":"https://api.github.com/users/NathanielAJohnson/following{/other_user}","gists_url":"https://api.github.com/users/NathanielAJohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanielAJohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanielAJohnson/subscriptions","organizations_url":"https://api.github.com/users/NathanielAJohnson/orgs","repos_url":"https://api.github.com/users/NathanielAJohnson/repos","events_url":"https://api.github.com/users/NathanielAJohnson/events{/privacy}","received_events_url":"https://api.github.com/users/NathanielAJohnson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-16T16:32:39Z","updated_at":"2018-09-17T09:29:31Z","closed_at":null,"author_association":"NONE","body":"I tried converting the Triangle example to use the [2018 Module System](https://rust-lang-nursery.github.io/edition-guide/rust-2018/module-system/index.html)  and got (surprisingly) far.  Everything imports correctly with no changes to library source until I get to the macros.  The new syntax calls for a straight `use` but I get an error that indicates the macros are private.  Hopefully this means the only src changes are to change the macros to public."},"comment":{"url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/comments/421942796","html_url":"https://github.com/vulkano-rs/vulkano/issues/1042#issuecomment-421942796","issue_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1042","id":421942796,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTk0Mjc5Ng==","user":{"login":"rukai","id":5120858,"node_id":"MDQ6VXNlcjUxMjA4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5120858?v=4","gravatar_id":"","url":"https://api.github.com/users/rukai","html_url":"https://github.com/rukai","followers_url":"https://api.github.com/users/rukai/followers","following_url":"https://api.github.com/users/rukai/following{/other_user}","gists_url":"https://api.github.com/users/rukai/gists{/gist_id}","starred_url":"https://api.github.com/users/rukai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rukai/subscriptions","organizations_url":"https://api.github.com/users/rukai/orgs","repos_url":"https://api.github.com/users/rukai/repos","events_url":"https://api.github.com/users/rukai/events{/privacy}","received_events_url":"https://api.github.com/users/rukai/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T09:29:31Z","updated_at":"2018-09-17T09:29:31Z","author_association":"MEMBER","body":"I see, so vulkano does work with rust 2018. However if we want to allow users to leave out the `#[macro_use] extern crate vulkano;` then we need to make the macros public. I'll put together a PR."}}
{"actor":{"display_login":"rukai"}}