{"action":"closed","number":997,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/997","id":180657202,"html_url":"https://github.com/Valloric/ycmd/pull/997","diff_url":"https://github.com/Valloric/ycmd/pull/997.diff","patch_url":"https://github.com/Valloric/ycmd/pull/997.patch","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/997","number":997,"state":"closed","locked":false,"title":"[READY] Clang tidy - clang analyzer","user":{"login":"bstaletic","id":7791699,"avatar_url":"https://avatars3.githubusercontent.com/u/7791699?v=4","gravatar_id":"","url":"https://api.github.com/users/bstaletic","html_url":"https://github.com/bstaletic","followers_url":"https://api.github.com/users/bstaletic/followers","following_url":"https://api.github.com/users/bstaletic/following{/other_user}","gists_url":"https://api.github.com/users/bstaletic/gists{/gist_id}","starred_url":"https://api.github.com/users/bstaletic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstaletic/subscriptions","organizations_url":"https://api.github.com/users/bstaletic/orgs","repos_url":"https://api.github.com/users/bstaletic/repos","events_url":"https://api.github.com/users/bstaletic/events{/privacy}","received_events_url":"https://api.github.com/users/bstaletic/received_events","type":"User","site_admin":false},"body":"This one is enabled by default. If we want it disabled, we need to be explicit.\r\nIt actually caught a sneaky \"`dead-code.DeadStore`\".\r\nThere are tons of checks here and a lot of those are platform specific.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/997)\n<!-- Reviewable:end -->\n","created_at":"2018-04-10T16:19:53Z","updated_at":"2018-04-17T13:16:21Z","closed_at":"2018-04-17T13:16:21Z","merged_at":"2018-04-17T13:16:21Z","merge_commit_sha":"e70f341d76112fe42f0a749629940b446691d6d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Valloric/ycmd/pulls/997/commits","review_comments_url":"https://api.github.com/repos/Valloric/ycmd/pulls/997/comments","review_comment_url":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/997/comments","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/e70f341d76112fe42f0a749629940b446691d6d5","head":{"label":"bstaletic:clang-tidy_clang-analyzier","ref":"clang-tidy_clang-analyzier","sha":"e70f341d76112fe42f0a749629940b446691d6d5","user":{"login":"bstaletic","id":7791699,"avatar_url":"https://avatars3.githubusercontent.com/u/7791699?v=4","gravatar_id":"","url":"https://api.github.com/users/bstaletic","html_url":"https://github.com/bstaletic","followers_url":"https://api.github.com/users/bstaletic/followers","following_url":"https://api.github.com/users/bstaletic/following{/other_user}","gists_url":"https://api.github.com/users/bstaletic/gists{/gist_id}","starred_url":"https://api.github.com/users/bstaletic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstaletic/subscriptions","organizations_url":"https://api.github.com/users/bstaletic/orgs","repos_url":"https://api.github.com/users/bstaletic/repos","events_url":"https://api.github.com/users/bstaletic/events{/privacy}","received_events_url":"https://api.github.com/users/bstaletic/received_events","type":"User","site_admin":false},"repo":{"id":84712149,"name":"ycmd","full_name":"bstaletic/ycmd","owner":{"login":"bstaletic","id":7791699,"avatar_url":"https://avatars3.githubusercontent.com/u/7791699?v=4","gravatar_id":"","url":"https://api.github.com/users/bstaletic","html_url":"https://github.com/bstaletic","followers_url":"https://api.github.com/users/bstaletic/followers","following_url":"https://api.github.com/users/bstaletic/following{/other_user}","gists_url":"https://api.github.com/users/bstaletic/gists{/gist_id}","starred_url":"https://api.github.com/users/bstaletic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstaletic/subscriptions","organizations_url":"https://api.github.com/users/bstaletic/orgs","repos_url":"https://api.github.com/users/bstaletic/repos","events_url":"https://api.github.com/users/bstaletic/events{/privacy}","received_events_url":"https://api.github.com/users/bstaletic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bstaletic/ycmd","description":"A code-completion & code-comprehension server - Move fast and break things fork!","fork":true,"url":"https://api.github.com/repos/bstaletic/ycmd","forks_url":"https://api.github.com/repos/bstaletic/ycmd/forks","keys_url":"https://api.github.com/repos/bstaletic/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bstaletic/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bstaletic/ycmd/teams","hooks_url":"https://api.github.com/repos/bstaletic/ycmd/hooks","issue_events_url":"https://api.github.com/repos/bstaletic/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/bstaletic/ycmd/events","assignees_url":"https://api.github.com/repos/bstaletic/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/bstaletic/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/bstaletic/ycmd/tags","blobs_url":"https://api.github.com/repos/bstaletic/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bstaletic/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bstaletic/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bstaletic/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bstaletic/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/bstaletic/ycmd/languages","stargazers_url":"https://api.github.com/repos/bstaletic/ycmd/stargazers","contributors_url":"https://api.github.com/repos/bstaletic/ycmd/contributors","subscribers_url":"https://api.github.com/repos/bstaletic/ycmd/subscribers","subscription_url":"https://api.github.com/repos/bstaletic/ycmd/subscription","commits_url":"https://api.github.com/repos/bstaletic/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bstaletic/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bstaletic/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bstaletic/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bstaletic/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/bstaletic/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bstaletic/ycmd/merges","archive_url":"https://api.github.com/repos/bstaletic/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bstaletic/ycmd/downloads","issues_url":"https://api.github.com/repos/bstaletic/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/bstaletic/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/bstaletic/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/bstaletic/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bstaletic/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/bstaletic/ycmd/releases{/id}","deployments_url":"https://api.github.com/repos/bstaletic/ycmd/deployments","created_at":"2017-03-12T08:44:41Z","updated_at":"2018-04-16T17:41:33Z","pushed_at":"2018-04-17T11:46:43Z","git_url":"git://github.com/bstaletic/ycmd.git","ssh_url":"git@github.com:bstaletic/ycmd.git","clone_url":"https://github.com/bstaletic/ycmd.git","svn_url":"https://github.com/bstaletic/ycmd","homepage":"","size":16162,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Valloric:master","ref":"master","sha":"28f46bd815a51c8c673983065843b73dcf67b95a","user":{"login":"Valloric","id":919444,"avatar_url":"https://avatars0.githubusercontent.com/u/919444?v=4","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"repo":{"id":19832415,"name":"ycmd","full_name":"Valloric/ycmd","owner":{"login":"Valloric","id":919444,"avatar_url":"https://avatars0.githubusercontent.com/u/919444?v=4","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Valloric/ycmd","description":"A code-completion & code-comprehension server","fork":false,"url":"https://api.github.com/repos/Valloric/ycmd","forks_url":"https://api.github.com/repos/Valloric/ycmd/forks","keys_url":"https://api.github.com/repos/Valloric/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Valloric/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Valloric/ycmd/teams","hooks_url":"https://api.github.com/repos/Valloric/ycmd/hooks","issue_events_url":"https://api.github.com/repos/Valloric/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/Valloric/ycmd/events","assignees_url":"https://api.github.com/repos/Valloric/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/Valloric/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/Valloric/ycmd/tags","blobs_url":"https://api.github.com/repos/Valloric/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Valloric/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Valloric/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Valloric/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/Valloric/ycmd/languages","stargazers_url":"https://api.github.com/repos/Valloric/ycmd/stargazers","contributors_url":"https://api.github.com/repos/Valloric/ycmd/contributors","subscribers_url":"https://api.github.com/repos/Valloric/ycmd/subscribers","subscription_url":"https://api.github.com/repos/Valloric/ycmd/subscription","commits_url":"https://api.github.com/repos/Valloric/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Valloric/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Valloric/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Valloric/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Valloric/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/Valloric/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Valloric/ycmd/merges","archive_url":"https://api.github.com/repos/Valloric/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Valloric/ycmd/downloads","issues_url":"https://api.github.com/repos/Valloric/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/Valloric/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/Valloric/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/Valloric/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Valloric/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/Valloric/ycmd/releases{/id}","deployments_url":"https://api.github.com/repos/Valloric/ycmd/deployments","created_at":"2014-05-15T19:30:17Z","updated_at":"2018-04-17T05:43:18Z","pushed_at":"2018-04-17T13:16:20Z","git_url":"git://github.com/Valloric/ycmd.git","ssh_url":"git@github.com:Valloric/ycmd.git","clone_url":"https://github.com/Valloric/ycmd.git","svn_url":"https://github.com/Valloric/ycmd","homepage":"https://valloric.github.io/ycmd/","size":20739,"stargazers_count":1088,"watchers_count":1088,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":587,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":587,"open_issues":36,"watchers":1088,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/997"},"html":{"href":"https://github.com/Valloric/ycmd/pull/997"},"issue":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/997"},"comments":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/997/comments"},"review_comments":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/997/comments"},"review_comment":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/997/commits"},"statuses":{"href":"https://api.github.com/repos/Valloric/ycmd/statuses/e70f341d76112fe42f0a749629940b446691d6d5"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zzbot","id":28640366,"avatar_url":"https://avatars1.githubusercontent.com/u/28640366?v=4","gravatar_id":"","url":"https://api.github.com/users/zzbot","html_url":"https://github.com/zzbot","followers_url":"https://api.github.com/users/zzbot/followers","following_url":"https://api.github.com/users/zzbot/following{/other_user}","gists_url":"https://api.github.com/users/zzbot/gists{/gist_id}","starred_url":"https://api.github.com/users/zzbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzbot/subscriptions","organizations_url":"https://api.github.com/users/zzbot/orgs","repos_url":"https://api.github.com/users/zzbot/repos","events_url":"https://api.github.com/users/zzbot/events{/privacy}","received_events_url":"https://api.github.com/users/zzbot/received_events","type":"User","site_admin":false},"comments":17,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"zzbot"}}