{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/170490599","pull_request_review_id":99181163,"id":170490599,"diff_hunk":"@@ -62,6 +60,26 @@ def _wrapfunc(obj, method, *args, **kwds):\n         return _wrapit(obj, method, *args, **kwds)\n \n \n+def _wrapreduction(obj, method, name, axis, dtype, out, **kwargs):\n+    passkwargs = {}\n+    for k, v in kwargs.items():\n+        if v is not np._NoValue:\n+            passkwargs[k] = v\n+\n+    if type(obj) is not mu.ndarray:\n+        try:\n+            reduction = getattr(obj, name)\n+        except AttributeError:\n+            pass\n+        else:\n+            if dtype is not None:","path":"numpy/core/fromnumeric.py","position":43,"original_position":43,"commit_id":"4dddfc7037596ff0dd703ee8cb392fb3d6c59d55","original_commit_id":"4dddfc7037596ff0dd703ee8cb392fb3d6c59d55","user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"This could do with a comment justifying it - especially since it wasn't needed previously","created_at":"2018-02-26T04:08:31Z","updated_at":"2018-02-26T04:08:31Z","html_url":"https://github.com/numpy/numpy/pull/10661#discussion_r170490599","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/10661","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/170490599"},"html":{"href":"https://github.com/numpy/numpy/pull/10661#discussion_r170490599"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/10661"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/10661","id":171226094,"html_url":"https://github.com/numpy/numpy/pull/10661","diff_url":"https://github.com/numpy/numpy/pull/10661.diff","patch_url":"https://github.com/numpy/numpy/pull/10661.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/10661","number":10661,"state":"open","locked":false,"title":"MAINT: Unify reductions in fromnumeric.py","user":{"login":"hameerabbasi","id":2190658,"avatar_url":"https://avatars3.githubusercontent.com/u/2190658?v=4","gravatar_id":"","url":"https://api.github.com/users/hameerabbasi","html_url":"https://github.com/hameerabbasi","followers_url":"https://api.github.com/users/hameerabbasi/followers","following_url":"https://api.github.com/users/hameerabbasi/following{/other_user}","gists_url":"https://api.github.com/users/hameerabbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/hameerabbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hameerabbasi/subscriptions","organizations_url":"https://api.github.com/users/hameerabbasi/orgs","repos_url":"https://api.github.com/users/hameerabbasi/repos","events_url":"https://api.github.com/users/hameerabbasi/events{/privacy}","received_events_url":"https://api.github.com/users/hameerabbasi/received_events","type":"User","site_admin":false},"body":"Fixes #10652.","created_at":"2018-02-25T11:48:54Z","updated_at":"2018-02-26T04:08:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4d30ba43fca70ed8fe13cd03ca98f8ad330a4d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":36825825,"url":"https://api.github.com/repos/numpy/numpy/labels/03%20-%20Maintenance","name":"03 - Maintenance","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/10661/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/10661/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/10661/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/4dddfc7037596ff0dd703ee8cb392fb3d6c59d55","head":{"label":"hameerabbasi:fix-prod-generator","ref":"fix-prod-generator","sha":"4dddfc7037596ff0dd703ee8cb392fb3d6c59d55","user":{"login":"hameerabbasi","id":2190658,"avatar_url":"https://avatars3.githubusercontent.com/u/2190658?v=4","gravatar_id":"","url":"https://api.github.com/users/hameerabbasi","html_url":"https://github.com/hameerabbasi","followers_url":"https://api.github.com/users/hameerabbasi/followers","following_url":"https://api.github.com/users/hameerabbasi/following{/other_user}","gists_url":"https://api.github.com/users/hameerabbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/hameerabbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hameerabbasi/subscriptions","organizations_url":"https://api.github.com/users/hameerabbasi/orgs","repos_url":"https://api.github.com/users/hameerabbasi/repos","events_url":"https://api.github.com/users/hameerabbasi/events{/privacy}","received_events_url":"https://api.github.com/users/hameerabbasi/received_events","type":"User","site_admin":false},"repo":{"id":118579745,"name":"numpy","full_name":"hameerabbasi/numpy","owner":{"login":"hameerabbasi","id":2190658,"avatar_url":"https://avatars3.githubusercontent.com/u/2190658?v=4","gravatar_id":"","url":"https://api.github.com/users/hameerabbasi","html_url":"https://github.com/hameerabbasi","followers_url":"https://api.github.com/users/hameerabbasi/followers","following_url":"https://api.github.com/users/hameerabbasi/following{/other_user}","gists_url":"https://api.github.com/users/hameerabbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/hameerabbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hameerabbasi/subscriptions","organizations_url":"https://api.github.com/users/hameerabbasi/orgs","repos_url":"https://api.github.com/users/hameerabbasi/repos","events_url":"https://api.github.com/users/hameerabbasi/events{/privacy}","received_events_url":"https://api.github.com/users/hameerabbasi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hameerabbasi/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/hameerabbasi/numpy","forks_url":"https://api.github.com/repos/hameerabbasi/numpy/forks","keys_url":"https://api.github.com/repos/hameerabbasi/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hameerabbasi/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hameerabbasi/numpy/teams","hooks_url":"https://api.github.com/repos/hameerabbasi/numpy/hooks","issue_events_url":"https://api.github.com/repos/hameerabbasi/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/hameerabbasi/numpy/events","assignees_url":"https://api.github.com/repos/hameerabbasi/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/hameerabbasi/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/hameerabbasi/numpy/tags","blobs_url":"https://api.github.com/repos/hameerabbasi/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hameerabbasi/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hameerabbasi/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hameerabbasi/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hameerabbasi/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/hameerabbasi/numpy/languages","stargazers_url":"https://api.github.com/repos/hameerabbasi/numpy/stargazers","contributors_url":"https://api.github.com/repos/hameerabbasi/numpy/contributors","subscribers_url":"https://api.github.com/repos/hameerabbasi/numpy/subscribers","subscription_url":"https://api.github.com/repos/hameerabbasi/numpy/subscription","commits_url":"https://api.github.com/repos/hameerabbasi/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hameerabbasi/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hameerabbasi/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hameerabbasi/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hameerabbasi/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/hameerabbasi/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hameerabbasi/numpy/merges","archive_url":"https://api.github.com/repos/hameerabbasi/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hameerabbasi/numpy/downloads","issues_url":"https://api.github.com/repos/hameerabbasi/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/hameerabbasi/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/hameerabbasi/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/hameerabbasi/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hameerabbasi/numpy/labels{/name}","releases_url":"https://api.github.com/repos/hameerabbasi/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/hameerabbasi/numpy/deployments","created_at":"2018-01-23T08:18:57Z","updated_at":"2018-01-23T08:19:03Z","pushed_at":"2018-02-25T21:11:34Z","git_url":"git://github.com/hameerabbasi/numpy.git","ssh_url":"git@github.com:hameerabbasi/numpy.git","clone_url":"https://github.com/hameerabbasi/numpy.git","svn_url":"https://github.com/hameerabbasi/numpy","homepage":"http://www.numpy.org/","size":54753,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"1ee1a4ac7f79e8c707c416f81f049fd3ac94f1e6","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-02-26T03:35:38Z","pushed_at":"2018-02-25T22:11:13Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":55670,"stargazers_count":6522,"watchers_count":6522,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2598,"mirror_url":null,"archived":false,"open_issues_count":1823,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2598,"open_issues":1823,"watchers":6522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/10661"},"html":{"href":"https://github.com/numpy/numpy/pull/10661"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/10661"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/10661/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/10661/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/10661/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/4dddfc7037596ff0dd703ee8cb392fb3d6c59d55"}},"author_association":"NONE"}}
{"actor":{"display_login":"eric-wieser"}}