{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/underreact/pulls/comments/218146846","pull_request_review_id":156013916,"id":218146846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODE0Njg0Ng==","diff_hunk":"@@ -84,32 +107,57 @@ function watchWebpack(urc, onFirstRun) {\n   compiler.watch({ ignored: [/node_modules/] }, onCompilation);\n }\n \n-function watchCss(urc) {\n+function watchCss(urc, callback) {\n+  let previousPath;\n+  const cssHandler = () => {\n+    const { compilation, output } = writeCss(urc);\n+    compilation.catch(logger.error);\n+    output\n+      .then(path => {\n+        if (previousPath && previousPath !== path) {","path":"commands/start.js","position":115,"original_position":115,"commit_id":"14af3ece7c8d7deb175525205b4558f320943d97","original_commit_id":"14af3ece7c8d7deb175525205b4558f320943d97","user":{"login":"davidtheclark","id":628431,"node_id":"MDQ6VXNlcjYyODQzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/628431?v=4","gravatar_id":"","url":"https://api.github.com/users/davidtheclark","html_url":"https://github.com/davidtheclark","followers_url":"https://api.github.com/users/davidtheclark/followers","following_url":"https://api.github.com/users/davidtheclark/following{/other_user}","gists_url":"https://api.github.com/users/davidtheclark/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtheclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtheclark/subscriptions","organizations_url":"https://api.github.com/users/davidtheclark/orgs","repos_url":"https://api.github.com/users/davidtheclark/repos","events_url":"https://api.github.com/users/davidtheclark/events{/privacy}","received_events_url":"https://api.github.com/users/davidtheclark/received_events","type":"User","site_admin":false},"body":"How does this check help? Can you explain why this is necessary in a comment?","created_at":"2018-09-17T16:53:45Z","updated_at":"2018-09-17T16:56:20Z","html_url":"https://github.com/mapbox/underreact/pull/38#discussion_r218146846","pull_request_url":"https://api.github.com/repos/mapbox/underreact/pulls/38","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/underreact/pulls/comments/218146846"},"html":{"href":"https://github.com/mapbox/underreact/pull/38#discussion_r218146846"},"pull_request":{"href":"https://api.github.com/repos/mapbox/underreact/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/underreact/pulls/38","id":215923130,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTIzMTMw","html_url":"https://github.com/mapbox/underreact/pull/38","diff_url":"https://github.com/mapbox/underreact/pull/38.diff","patch_url":"https://github.com/mapbox/underreact/pull/38.patch","issue_url":"https://api.github.com/repos/mapbox/underreact/issues/38","number":38,"state":"open","locked":false,"title":"Unify assets and html write","user":{"login":"kepta","id":6966254,"node_id":"MDQ6VXNlcjY5NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6966254?v=4","gravatar_id":"","url":"https://api.github.com/users/kepta","html_url":"https://github.com/kepta","followers_url":"https://api.github.com/users/kepta/followers","following_url":"https://api.github.com/users/kepta/following{/other_user}","gists_url":"https://api.github.com/users/kepta/gists{/gist_id}","starred_url":"https://api.github.com/users/kepta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kepta/subscriptions","organizations_url":"https://api.github.com/users/kepta/orgs","repos_url":"https://api.github.com/users/kepta/repos","events_url":"https://api.github.com/users/kepta/events{/privacy}","received_events_url":"https://api.github.com/users/kepta/received_events","type":"User","site_admin":false},"body":"It adds the following things:\r\n- A unified assets object, which handles the paths for any asset that can be needed by `index.html`\r\n- Fixes the weird bugs when running `mode=production` with `start` command.\r\n- Optimizes `css` and `copy` tasks, as they don't depend on `webpack`.\r\n- Adds a bunch of tests to improve unit testing coverage.\r\n- Improve the Html writing.\r\n\r\n@davidtheclark for review, please.\r\nNote: This each commit is individually reviewable. ","created_at":"2018-09-17T09:41:38Z","updated_at":"2018-09-17T16:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"633ca2c951543bd4219e7e44584f7f737578c9c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/underreact/pulls/38/commits","review_comments_url":"https://api.github.com/repos/mapbox/underreact/pulls/38/comments","review_comment_url":"https://api.github.com/repos/mapbox/underreact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/underreact/issues/38/comments","statuses_url":"https://api.github.com/repos/mapbox/underreact/statuses/14af3ece7c8d7deb175525205b4558f320943d97","head":{"label":"mapbox:unify-assets","ref":"unify-assets","sha":"14af3ece7c8d7deb175525205b4558f320943d97","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":139043818,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwNDM4MTg=","name":"underreact","full_name":"mapbox/underreact","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/underreact","description":"Work-in-progress React app build system","fork":false,"url":"https://api.github.com/repos/mapbox/underreact","forks_url":"https://api.github.com/repos/mapbox/underreact/forks","keys_url":"https://api.github.com/repos/mapbox/underreact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/underreact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/underreact/teams","hooks_url":"https://api.github.com/repos/mapbox/underreact/hooks","issue_events_url":"https://api.github.com/repos/mapbox/underreact/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/underreact/events","assignees_url":"https://api.github.com/repos/mapbox/underreact/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/underreact/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/underreact/tags","blobs_url":"https://api.github.com/repos/mapbox/underreact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/underreact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/underreact/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/underreact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/underreact/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/underreact/languages","stargazers_url":"https://api.github.com/repos/mapbox/underreact/stargazers","contributors_url":"https://api.github.com/repos/mapbox/underreact/contributors","subscribers_url":"https://api.github.com/repos/mapbox/underreact/subscribers","subscription_url":"https://api.github.com/repos/mapbox/underreact/subscription","commits_url":"https://api.github.com/repos/mapbox/underreact/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/underreact/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/underreact/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/underreact/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/underreact/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/underreact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/underreact/merges","archive_url":"https://api.github.com/repos/mapbox/underreact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/underreact/downloads","issues_url":"https://api.github.com/repos/mapbox/underreact/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/underreact/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/underreact/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/underreact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/underreact/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/underreact/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/underreact/deployments","created_at":"2018-06-28T16:32:57Z","updated_at":"2018-07-05T01:55:58Z","pushed_at":"2018-09-17T14:28:36Z","git_url":"git://github.com/mapbox/underreact.git","ssh_url":"git@github.com:mapbox/underreact.git","clone_url":"https://github.com/mapbox/underreact.git","svn_url":"https://github.com/mapbox/underreact","homepage":"","size":475,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":10,"watchers":2,"default_branch":"master"}},"base":{"label":"mapbox:next","ref":"next","sha":"a7b5401ffb5e37f6ec285258d08c299aaafbe39f","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":139043818,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwNDM4MTg=","name":"underreact","full_name":"mapbox/underreact","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/underreact","description":"Work-in-progress React app build system","fork":false,"url":"https://api.github.com/repos/mapbox/underreact","forks_url":"https://api.github.com/repos/mapbox/underreact/forks","keys_url":"https://api.github.com/repos/mapbox/underreact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/underreact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/underreact/teams","hooks_url":"https://api.github.com/repos/mapbox/underreact/hooks","issue_events_url":"https://api.github.com/repos/mapbox/underreact/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/underreact/events","assignees_url":"https://api.github.com/repos/mapbox/underreact/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/underreact/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/underreact/tags","blobs_url":"https://api.github.com/repos/mapbox/underreact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/underreact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/underreact/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/underreact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/underreact/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/underreact/languages","stargazers_url":"https://api.github.com/repos/mapbox/underreact/stargazers","contributors_url":"https://api.github.com/repos/mapbox/underreact/contributors","subscribers_url":"https://api.github.com/repos/mapbox/underreact/subscribers","subscription_url":"https://api.github.com/repos/mapbox/underreact/subscription","commits_url":"https://api.github.com/repos/mapbox/underreact/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/underreact/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/underreact/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/underreact/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/underreact/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/underreact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/underreact/merges","archive_url":"https://api.github.com/repos/mapbox/underreact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/underreact/downloads","issues_url":"https://api.github.com/repos/mapbox/underreact/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/underreact/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/underreact/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/underreact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/underreact/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/underreact/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/underreact/deployments","created_at":"2018-06-28T16:32:57Z","updated_at":"2018-07-05T01:55:58Z","pushed_at":"2018-09-17T14:28:36Z","git_url":"git://github.com/mapbox/underreact.git","ssh_url":"git@github.com:mapbox/underreact.git","clone_url":"https://github.com/mapbox/underreact.git","svn_url":"https://github.com/mapbox/underreact","homepage":"","size":475,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/underreact/pulls/38"},"html":{"href":"https://github.com/mapbox/underreact/pull/38"},"issue":{"href":"https://api.github.com/repos/mapbox/underreact/issues/38"},"comments":{"href":"https://api.github.com/repos/mapbox/underreact/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/underreact/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/underreact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/underreact/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/underreact/statuses/14af3ece7c8d7deb175525205b4558f320943d97"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davidtheclark"}}