{"action":"closed","number":898,"pull_request":{"url":"https://api.github.com/repos/alphagov/pay-connector/pulls/898","id":236494320,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NDk0MzIw","html_url":"https://github.com/alphagov/pay-connector/pull/898","diff_url":"https://github.com/alphagov/pay-connector/pull/898.diff","patch_url":"https://github.com/alphagov/pay-connector/pull/898.patch","issue_url":"https://api.github.com/repos/alphagov/pay-connector/issues/898","number":898,"state":"closed","locked":false,"title":"PP-4352: Refactor PaymentProvider's capture interface","user":{"login":"oswaldquek","id":9698354,"node_id":"MDQ6VXNlcjk2OTgzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9698354?v=4","gravatar_id":"","url":"https://api.github.com/users/oswaldquek","html_url":"https://github.com/oswaldquek","followers_url":"https://api.github.com/users/oswaldquek/followers","following_url":"https://api.github.com/users/oswaldquek/following{/other_user}","gists_url":"https://api.github.com/users/oswaldquek/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldquek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldquek/subscriptions","organizations_url":"https://api.github.com/users/oswaldquek/orgs","repos_url":"https://api.github.com/users/oswaldquek/repos","events_url":"https://api.github.com/users/oswaldquek/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldquek/received_events","type":"User","site_admin":false},"body":"This commit simplifies the response from the capture method bigly. From\r\nGatewayResponse<BaseCaptureResponse> -> CaptureResponse.\r\n\r\nChargeService no longer has knowledge of any specific payment provider.\r\n\r\n@oswaldquek\r\n\r\n","created_at":"2018-12-06T11:20:43Z","updated_at":"2018-12-11T17:08:24Z","closed_at":"2018-12-11T17:08:24Z","merged_at":"2018-12-11T17:08:24Z","merge_commit_sha":"90ab82e6efe9cb173ac9dd1cc483db797fc296e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/898/commits","review_comments_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/898/comments","review_comment_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/issues/898/comments","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/277deb3e79917c4fb58806728df5a1e1acab5dbc","head":{"label":"alphagov:PP-4352-refactor-capture-handler-interface","ref":"PP-4352-refactor-capture-handler-interface","sha":"277deb3e79917c4fb58806728df5a1e1acab5dbc","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":39890257,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg5MDI1Nw==","name":"pay-connector","full_name":"alphagov/pay-connector","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/pay-connector","description":"The Payments Connector in Java (Dropwizard)","fork":false,"url":"https://api.github.com/repos/alphagov/pay-connector","forks_url":"https://api.github.com/repos/alphagov/pay-connector/forks","keys_url":"https://api.github.com/repos/alphagov/pay-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-connector/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-connector/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-connector/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-connector/events","assignees_url":"https://api.github.com/repos/alphagov/pay-connector/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-connector/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-connector/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-connector/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-connector/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-connector/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-connector/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-connector/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-connector/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-connector/merges","archive_url":"https://api.github.com/repos/alphagov/pay-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-connector/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-connector/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-connector/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-connector/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-connector/deployments","created_at":"2015-07-29T11:38:35Z","updated_at":"2018-12-11T15:15:28Z","pushed_at":"2018-12-11T17:08:24Z","git_url":"git://github.com/alphagov/pay-connector.git","ssh_url":"git@github.com:alphagov/pay-connector.git","clone_url":"https://github.com/alphagov/pay-connector.git","svn_url":"https://github.com/alphagov/pay-connector","homepage":null,"size":18327,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"edec873d8546464034687a01faa775e300787ca6","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":39890257,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg5MDI1Nw==","name":"pay-connector","full_name":"alphagov/pay-connector","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/pay-connector","description":"The Payments Connector in Java (Dropwizard)","fork":false,"url":"https://api.github.com/repos/alphagov/pay-connector","forks_url":"https://api.github.com/repos/alphagov/pay-connector/forks","keys_url":"https://api.github.com/repos/alphagov/pay-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-connector/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-connector/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-connector/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-connector/events","assignees_url":"https://api.github.com/repos/alphagov/pay-connector/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-connector/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-connector/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-connector/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-connector/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-connector/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-connector/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-connector/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-connector/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-connector/merges","archive_url":"https://api.github.com/repos/alphagov/pay-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-connector/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-connector/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-connector/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-connector/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-connector/deployments","created_at":"2015-07-29T11:38:35Z","updated_at":"2018-12-11T15:15:28Z","pushed_at":"2018-12-11T17:08:24Z","git_url":"git://github.com/alphagov/pay-connector.git","ssh_url":"git@github.com:alphagov/pay-connector.git","clone_url":"https://github.com/alphagov/pay-connector.git","svn_url":"https://github.com/alphagov/pay-connector","homepage":null,"size":18327,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/898"},"html":{"href":"https://github.com/alphagov/pay-connector/pull/898"},"issue":{"href":"https://api.github.com/repos/alphagov/pay-connector/issues/898"},"comments":{"href":"https://api.github.com/repos/alphagov/pay-connector/issues/898/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/898/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/898/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/pay-connector/statuses/277deb3e79917c4fb58806728df5a1e1acab5dbc"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"oswaldquek","id":9698354,"node_id":"MDQ6VXNlcjk2OTgzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9698354?v=4","gravatar_id":"","url":"https://api.github.com/users/oswaldquek","html_url":"https://github.com/oswaldquek","followers_url":"https://api.github.com/users/oswaldquek/followers","following_url":"https://api.github.com/users/oswaldquek/following{/other_user}","gists_url":"https://api.github.com/users/oswaldquek/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldquek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldquek/subscriptions","organizations_url":"https://api.github.com/users/oswaldquek/orgs","repos_url":"https://api.github.com/users/oswaldquek/repos","events_url":"https://api.github.com/users/oswaldquek/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldquek/received_events","type":"User","site_admin":false},"comments":11,"review_comments":43,"maintainer_can_modify":false,"commits":4,"additions":358,"deletions":290,"changed_files":35}}
{"actor":{"display_login":"oswaldquek"}}