{"action":"created","issue":{"url":"https://api.github.com/repos/omu/nokul/issues/216","repository_url":"https://api.github.com/repos/omu/nokul","labels_url":"https://api.github.com/repos/omu/nokul/issues/216/labels{/name}","comments_url":"https://api.github.com/repos/omu/nokul/issues/216/comments","events_url":"https://api.github.com/repos/omu/nokul/issues/216/events","html_url":"https://github.com/omu/nokul/issues/216","id":350741367,"node_id":"MDU6SXNzdWUzNTA3NDEzNjc=","number":216,"title":"Dokku'da yanlış ruby versiyonu kuruluyor","user":{"login":"ecylmz","id":248267,"node_id":"MDQ6VXNlcjI0ODI2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/248267?v=4","gravatar_id":"","url":"https://api.github.com/users/ecylmz","html_url":"https://github.com/ecylmz","followers_url":"https://api.github.com/users/ecylmz/followers","following_url":"https://api.github.com/users/ecylmz/following{/other_user}","gists_url":"https://api.github.com/users/ecylmz/gists{/gist_id}","starred_url":"https://api.github.com/users/ecylmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecylmz/subscriptions","organizations_url":"https://api.github.com/users/ecylmz/orgs","repos_url":"https://api.github.com/users/ecylmz/repos","events_url":"https://api.github.com/users/ecylmz/events{/privacy}","received_events_url":"https://api.github.com/users/ecylmz/received_events","type":"User","site_admin":false},"labels":[{"id":842699150,"node_id":"MDU6TGFiZWw4NDI2OTkxNTA=","url":"https://api.github.com/repos/omu/nokul/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"open","locked":false,"assignee":{"login":"msdundar","id":468744,"node_id":"MDQ6VXNlcjQ2ODc0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/468744?v=4","gravatar_id":"","url":"https://api.github.com/users/msdundar","html_url":"https://github.com/msdundar","followers_url":"https://api.github.com/users/msdundar/followers","following_url":"https://api.github.com/users/msdundar/following{/other_user}","gists_url":"https://api.github.com/users/msdundar/gists{/gist_id}","starred_url":"https://api.github.com/users/msdundar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msdundar/subscriptions","organizations_url":"https://api.github.com/users/msdundar/orgs","repos_url":"https://api.github.com/users/msdundar/repos","events_url":"https://api.github.com/users/msdundar/events{/privacy}","received_events_url":"https://api.github.com/users/msdundar/received_events","type":"User","site_admin":false},"assignees":[{"login":"msdundar","id":468744,"node_id":"MDQ6VXNlcjQ2ODc0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/468744?v=4","gravatar_id":"","url":"https://api.github.com/users/msdundar","html_url":"https://github.com/msdundar","followers_url":"https://api.github.com/users/msdundar/followers","following_url":"https://api.github.com/users/msdundar/following{/other_user}","gists_url":"https://api.github.com/users/msdundar/gists{/gist_id}","starred_url":"https://api.github.com/users/msdundar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msdundar/subscriptions","organizations_url":"https://api.github.com/users/msdundar/orgs","repos_url":"https://api.github.com/users/msdundar/repos","events_url":"https://api.github.com/users/msdundar/events{/privacy}","received_events_url":"https://api.github.com/users/msdundar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-08-15T09:19:22Z","updated_at":"2018-08-15T10:00:58Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Bunun nedeni, Gemfile'dan ruby versiyonunun kaldırılması. Eğer Gemfile'da ruby versiyonu olmazsa ön tanımlı 2.3.1 kuruluyor. Mevcut deployda sıkıntı yok çünkü daha önce 2.5.1 kullanıldığını biliyor. Bu sorun yalnızca ilk deployda ortaya çıkıyor.\r\n\r\nKısacası Gemfile'a ruby versiyonu yazmak zorundayız."},"comment":{"url":"https://api.github.com/repos/omu/nokul/issues/comments/413151395","html_url":"https://github.com/omu/nokul/issues/216#issuecomment-413151395","issue_url":"https://api.github.com/repos/omu/nokul/issues/216","id":413151395,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzE1MTM5NQ==","user":{"login":"roktas","id":47842,"node_id":"MDQ6VXNlcjQ3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/47842?v=4","gravatar_id":"","url":"https://api.github.com/users/roktas","html_url":"https://github.com/roktas","followers_url":"https://api.github.com/users/roktas/followers","following_url":"https://api.github.com/users/roktas/following{/other_user}","gists_url":"https://api.github.com/users/roktas/gists{/gist_id}","starred_url":"https://api.github.com/users/roktas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roktas/subscriptions","organizations_url":"https://api.github.com/users/roktas/orgs","repos_url":"https://api.github.com/users/roktas/repos","events_url":"https://api.github.com/users/roktas/events{/privacy}","received_events_url":"https://api.github.com/users/roktas/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T10:00:58Z","updated_at":"2018-08-15T10:00:58Z","author_association":"MEMBER","body":"Buna göre 2 yol:\r\n\r\n1. Gemfile ile\r\n\r\n-  `.ruby-version` dosyasını kaldır\r\n- Ruby versiyonunu `ruby ENV['CUSTOM_RUBY_VERSION'] || '2.5.1'` olarak Gemfile'da gir\r\n- CI testlerinde `CUSTOM_RUBY_VERSION` ortam değişkenini set et\r\n\r\n2. `.ruby-version`\r\n\r\n- Gemfile'da `ruby File.read('.ruby-version')` satırı.\r\n- CI'da değişiklik yok.\r\n\r\nHer iki yol da: (1) Dokku'yu memnun ediyor, (2) CI testleri çalışıyor, (3) Tooling sorunsuz (en azından Rubocop, diğerlerini bilmiyorum; .ruby-version kullanmak bir parça daha avantajlı olabilir gelecek durumlar için)\r\n\r\nBenim oyum ilk yönteme gider.  Bir dosyadan kurtuluyoruz, daha parametrik bir çözüm.  Karar her ne olacaksa buna uygun PR yapılmalı."}}
{"actor":{"display_login":"roktas"}}