{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-azure/issues/739","repository_url":"https://api.github.com/repos/openshift/openshift-azure","labels_url":"https://api.github.com/repos/openshift/openshift-azure/issues/739/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/issues/739/comments","events_url":"https://api.github.com/repos/openshift/openshift-azure/issues/739/events","html_url":"https://github.com/openshift/openshift-azure/pull/739","id":381259833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjcxODg2","number":739,"title":"Adding support for multiple e2e make targets.","user":{"login":"kwoodson","id":1385770,"node_id":"MDQ6VXNlcjEzODU3NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"labels":[{"id":1006544929,"node_id":"MDU6TGFiZWwxMDA2NTQ0OTI5","url":"https://api.github.com/repos/openshift/openshift-azure/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1006542624,"node_id":"MDU6TGFiZWwxMDA2NTQyNjI0","url":"https://api.github.com/repos/openshift/openshift-azure/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-15T17:14:39Z","updated_at":"2018-11-16T10:48:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/739","html_url":"https://github.com/openshift/openshift-azure/pull/739","diff_url":"https://github.com/openshift/openshift-azure/pull/739.diff","patch_url":"https://github.com/openshift/openshift-azure/pull/739.patch"},"body":"Adding the ability as per @kargakis request to call multiple e2e targets and re-use the e2e-azure templates.\r\n\r\n@kargakis, is this what you had in mind?"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-azure/issues/comments/439356068","html_url":"https://github.com/openshift/openshift-azure/pull/739#issuecomment-439356068","issue_url":"https://api.github.com/repos/openshift/openshift-azure/issues/739","id":439356068,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTM1NjA2OA==","user":{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T10:48:28Z","updated_at":"2018-11-16T10:48:28Z","author_association":"MEMBER","body":"Opened https://github.com/openshift/release/pull/2157 to illustrate what I was thinking. There are a couple of different options:\r\n* add bushslicer in the [test base image](https://github.com/openshift/release/blob/a033b5dc9254ae54527cd31ac5223eb962434c32/projects/azure/base-images/test-base.yaml) we use in openshift-azure, then we would only need the `TEST_COMMAND` change in my release PR.\r\n* move forward with my release PR as is. We avoid the extra template at the expense of doing more hacks in our e2e template\r\n\r\nIdeally, we should be able to do something like the following in the ci-operator config for every repo or for periodics that need to run a test against an OSA cluster:\r\n```yaml\r\ntests:\r\n- as: e2e-azure\r\n  commands: make e2e-bushslicer\r\n  openshift_azure:\r\n    manifest: testdata/create.yaml\r\n```\r\n`make e2e-bushlicer` is the command that runs the tests you want to run. The script called by the make target and the make target are part of the repo under test. `build_root.image_stream_tag` in the ci-operator config is used as the base image for the command to run. `openshift_azure` requests an OSA cluster, which in turn uses our e2e template to stand up clusters, `manifest` is what is used by our template to create the cluster, `testdata/create.yaml` is the actual manifest found inside the repo under test.\r\n\r\n@stevekuznetsov @bbguimaraes thoughts?"}}
{"actor":{"display_login":"kargakis"}}