{"action":"created","issue":{"url":"https://api.github.com/repos/halide/Halide/issues/3498","repository_url":"https://api.github.com/repos/halide/Halide","labels_url":"https://api.github.com/repos/halide/Halide/issues/3498/labels{/name}","comments_url":"https://api.github.com/repos/halide/Halide/issues/3498/comments","events_url":"https://api.github.com/repos/halide/Halide/issues/3498/events","html_url":"https://github.com/halide/Halide/pull/3498","id":390820746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTAxMDc5","number":3498,"title":"Various fixes for apps/autoscheduler","user":{"login":"steven-johnson","id":328955,"node_id":"MDQ6VXNlcjMyODk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/328955?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-johnson","html_url":"https://github.com/steven-johnson","followers_url":"https://api.github.com/users/steven-johnson/followers","following_url":"https://api.github.com/users/steven-johnson/following{/other_user}","gists_url":"https://api.github.com/users/steven-johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-johnson/subscriptions","organizations_url":"https://api.github.com/users/steven-johnson/orgs","repos_url":"https://api.github.com/users/steven-johnson/repos","events_url":"https://api.github.com/users/steven-johnson/events{/privacy}","received_events_url":"https://api.github.com/users/steven-johnson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-13T19:16:05Z","updated_at":"2018-12-13T19:31:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/halide/Halide/pulls/3498","html_url":"https://github.com/halide/Halide/pull/3498","diff_url":"https://github.com/halide/Halide/pull/3498.diff","patch_url":"https://github.com/halide/Halide/pull/3498.patch"},"body":"(Things found while bringing up in google build env)\r\n\r\n- Mixing includes of Halide.h (the public API) and internal things like Errors.h, internal_error, etc is problematic, both from a philosphical point of view, and also from a pragmatic/packaging point of view. (I can make it legal for our build system to allow mixing these two, but it seems like a bad idea in the long run; better to stick uniformly to what's offered by Halide.h IMHO). Calls to internal_error and the like were changed to _halide_user_assert(), which is unsatisfying but the best currently offered by our public API; I'm open for better suggestions.\r\n\r\n-- revise cost_model_schedule.h to be valid C++ when compiled on its own (ie, with the proper includes, wrapped in a function), rather than relying on inclusion in the proper spot; this is good hygiene in general, and essentially required for C++ modules to work in the future. (Unless there is disagreement with this change, I intend to make a followup PR to have the C++-schedule-dumping-code do this sort of wrapping by default.)\r\n\r\n-- remove unused lamba in cost_model_generator.cpp"},"comment":{"url":"https://api.github.com/repos/halide/Halide/issues/comments/447091507","html_url":"https://github.com/halide/Halide/pull/3498#issuecomment-447091507","issue_url":"https://api.github.com/repos/halide/Halide/issues/3498","id":447091507,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzA5MTUwNw==","user":{"login":"steven-johnson","id":328955,"node_id":"MDQ6VXNlcjMyODk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/328955?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-johnson","html_url":"https://github.com/steven-johnson","followers_url":"https://api.github.com/users/steven-johnson/followers","following_url":"https://api.github.com/users/steven-johnson/following{/other_user}","gists_url":"https://api.github.com/users/steven-johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-johnson/subscriptions","organizations_url":"https://api.github.com/users/steven-johnson/orgs","repos_url":"https://api.github.com/users/steven-johnson/repos","events_url":"https://api.github.com/users/steven-johnson/events{/privacy}","received_events_url":"https://api.github.com/users/steven-johnson/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T19:31:13Z","updated_at":"2018-12-13T19:31:13Z","author_association":"CONTRIBUTOR","body":"> We could revise that model \r\n\r\nunderstood."}}
{"actor":{"display_login":"steven-johnson"}}