{"action":"created","comment":{"url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments/199727106","pull_request_review_id":133899174,"id":199727106,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTcyNzEwNg==","diff_hunk":"@@ -30,11 +28,11 @@ public void mapProofShouldBeValid() {\n \n     DbKey valueKey = DbKey.newLeafKey(secondKey);\n     MapProofEntryLeaf leaf = createLeafMapEntry(valueKey.getKeySlice(), VALUE);\n-    List<MapProofEntry> entries =\n-        Arrays.asList(\n-            createBranchMapEntry(firstKey),\n-            leaf,\n-            createBranchMapEntry(thirdKey));\n+    MapProofEntry[] entries = {","path":"exonum-java-proofs/src/test/java/com/exonum/binding/storage/proofs/map/flat/CheckedFlatMapProofTest.java","position":19,"original_position":19,"commit_id":"3f8b622fda20fe30173d16c82f5cbfdfe3a4a702","original_commit_id":"3f8b622fda20fe30173d16c82f5cbfdfe3a4a702","user":{"login":"dmitry-timofeev","id":7531824,"node_id":"MDQ6VXNlcjc1MzE4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7531824?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-timofeev","html_url":"https://github.com/dmitry-timofeev","followers_url":"https://api.github.com/users/dmitry-timofeev/followers","following_url":"https://api.github.com/users/dmitry-timofeev/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-timofeev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-timofeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-timofeev/subscriptions","organizations_url":"https://api.github.com/users/dmitry-timofeev/orgs","repos_url":"https://api.github.com/users/dmitry-timofeev/repos","events_url":"https://api.github.com/users/dmitry-timofeev/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-timofeev/received_events","type":"User","site_admin":false},"body":"I'd keep using lists here — (1) they are more convenient; (2) tests might not need any sorting.","created_at":"2018-07-03T08:39:44Z","updated_at":"2018-07-03T08:42:49Z","html_url":"https://github.com/exonum/exonum-java-binding/pull/330#discussion_r199727106","pull_request_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/330","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments/199727106"},"html":{"href":"https://github.com/exonum/exonum-java-binding/pull/330#discussion_r199727106"},"pull_request":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/330"}}},"pull_request":{"url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/330","id":197339448,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzM5NDQ4","html_url":"https://github.com/exonum/exonum-java-binding/pull/330","diff_url":"https://github.com/exonum/exonum-java-binding/pull/330.diff","patch_url":"https://github.com/exonum/exonum-java-binding/pull/330.patch","issue_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/330","number":330,"state":"open","locked":false,"title":"Add native support for flat proofs [ECR-1350]","user":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nNative getProof method.\r\nDoes not support proof of absence. \r\nDoes not includes tests (yet)\r\nFormatting and code readability is awful (yet)\r\n\r\n---\r\nSee: https://jira.bf.local/browse/XYZ\r\n\r\n\r\n### Definition of Done\r\n\r\n- [ ] There are no TODOs left in the code\r\n- [ ] Change is covered by automated [tests](../CONTRIBUTING.md#tests)\r\n- [x] The [coding guidelines](../CONTRIBUTING.md#the-code-style) are followed\r\n- [x] Public API has Javadoc\r\n- [x] Method preconditions are checked and documented in the Javadoc of the method\r\n- [ ] The [continuous integration build](https://www.travis-ci.org/exonum/exonum-java-binding) passes\r\n- [ ] Add unit tests\r\n- [x] Polish code\r\n","created_at":"2018-06-26T08:22:22Z","updated_at":"2018-07-03T08:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77e3cf952b64cf90744c2f08b358f86f5f50f92b","assignee":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"assignees":[{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"MakarovS","id":6428594,"node_id":"MDQ6VXNlcjY0Mjg1OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6428594?v=4","gravatar_id":"","url":"https://api.github.com/users/MakarovS","html_url":"https://github.com/MakarovS","followers_url":"https://api.github.com/users/MakarovS/followers","following_url":"https://api.github.com/users/MakarovS/following{/other_user}","gists_url":"https://api.github.com/users/MakarovS/gists{/gist_id}","starred_url":"https://api.github.com/users/MakarovS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakarovS/subscriptions","organizations_url":"https://api.github.com/users/MakarovS/orgs","repos_url":"https://api.github.com/users/MakarovS/repos","events_url":"https://api.github.com/users/MakarovS/events{/privacy}","received_events_url":"https://api.github.com/users/MakarovS/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/330/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/330/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/330/comments","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/3f8b622fda20fe30173d16c82f5cbfdfe3a4a702","head":{"label":"vitvakatu:ECR-1350","ref":"ECR-1350","sha":"3f8b622fda20fe30173d16c82f5cbfdfe3a4a702","user":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"repo":{"id":137995778,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5OTU3Nzg=","name":"exonum-java-binding","full_name":"vitvakatu/exonum-java-binding","owner":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitvakatu/exonum-java-binding","description":"Java Binding for the Exonum blockchain framework","fork":true,"url":"https://api.github.com/repos/vitvakatu/exonum-java-binding","forks_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/forks","keys_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/teams","hooks_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/hooks","issue_events_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/issues/events{/number}","events_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/events","assignees_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/assignees{/user}","branches_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/branches{/branch}","tags_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/tags","blobs_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/statuses/{sha}","languages_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/languages","stargazers_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/stargazers","contributors_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/contributors","subscribers_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/subscribers","subscription_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/subscription","commits_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/contents/{+path}","compare_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/merges","archive_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/downloads","issues_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/issues{/number}","pulls_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/pulls{/number}","milestones_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/milestones{/number}","notifications_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/labels{/name}","releases_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/releases{/id}","deployments_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/deployments","created_at":"2018-06-20T07:27:21Z","updated_at":"2018-06-20T07:27:41Z","pushed_at":"2018-07-02T20:26:49Z","git_url":"git://github.com/vitvakatu/exonum-java-binding.git","ssh_url":"git@github.com:vitvakatu/exonum-java-binding.git","clone_url":"https://github.com/vitvakatu/exonum-java-binding.git","svn_url":"https://github.com/vitvakatu/exonum-java-binding","homepage":"http://exonum.com","size":1482,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exonum:ECR-1164","ref":"ECR-1164","sha":"300f3debc8fa43d9c19adbcc5474573ee28f889e","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":92375988,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM3NTk4OA==","name":"exonum-java-binding","full_name":"exonum/exonum-java-binding","owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exonum/exonum-java-binding","description":"Java Binding for the Exonum blockchain framework","fork":false,"url":"https://api.github.com/repos/exonum/exonum-java-binding","forks_url":"https://api.github.com/repos/exonum/exonum-java-binding/forks","keys_url":"https://api.github.com/repos/exonum/exonum-java-binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum-java-binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum-java-binding/teams","hooks_url":"https://api.github.com/repos/exonum/exonum-java-binding/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum-java-binding/events","assignees_url":"https://api.github.com/repos/exonum/exonum-java-binding/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum-java-binding/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/tags","blobs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum-java-binding/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum-java-binding/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum-java-binding/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscription","commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum-java-binding/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum-java-binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum-java-binding/merges","archive_url":"https://api.github.com/repos/exonum/exonum-java-binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum-java-binding/downloads","issues_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum-java-binding/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum-java-binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum-java-binding/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum-java-binding/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum-java-binding/deployments","created_at":"2017-05-25T07:12:56Z","updated_at":"2018-07-02T16:53:55Z","pushed_at":"2018-07-02T20:26:51Z","git_url":"git://github.com/exonum/exonum-java-binding.git","ssh_url":"git@github.com:exonum/exonum-java-binding.git","clone_url":"https://github.com/exonum/exonum-java-binding.git","svn_url":"https://github.com/exonum/exonum-java-binding","homepage":"http://exonum.com","size":1503,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":16,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/330"},"html":{"href":"https://github.com/exonum/exonum-java-binding/pull/330"},"issue":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/issues/330"},"comments":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/3f8b622fda20fe30173d16c82f5cbfdfe3a4a702"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dmitry-timofeev"}}