{"action":"created","comment":{"url":"https://api.github.com/repos/hypothesis/h/pulls/comments/230139213","pull_request_review_id":170797481,"id":230139213,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDEzOTIxMw==","diff_hunk":"@@ -1,7 +1,23 @@\n+/**\n+ * 1. Necessary to fix IE floating footer bug","path":"h/static/styles/partials/_base.scss","position":2,"original_position":2,"commit_id":"64a81f36d807de74e312841213f67b00d784521f","original_commit_id":"64a81f36d807de74e312841213f67b00d784521f","user":{"login":"robertknight","id":2458,"node_id":"MDQ6VXNlcjI0NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"body":"It may not be clear in future what \"IE floating footer bug\" refers to. People can look at the git blame output, but including a link to the GitHub issue would be helpful. Additionally can you move the comment to just above the `display: flex` line so it doesn't get detached if for some reason additional styles are added to `html { ... }` in future.\r\n\r\nI've verified the fix works. Some Googling turned up https://github.com/philipwalton/flexbugs#flexbug-3 which I think is the issue that we ran into here, correct me if I'm wrong.","created_at":"2018-11-01T18:01:32Z","updated_at":"2018-11-01T18:11:35Z","html_url":"https://github.com/hypothesis/h/pull/5402#discussion_r230139213","pull_request_url":"https://api.github.com/repos/hypothesis/h/pulls/5402","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments/230139213"},"html":{"href":"https://github.com/hypothesis/h/pull/5402#discussion_r230139213"},"pull_request":{"href":"https://api.github.com/repos/hypothesis/h/pulls/5402"}}},"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/5402","id":227116723,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTE2NzIz","html_url":"https://github.com/hypothesis/h/pull/5402","diff_url":"https://github.com/hypothesis/h/pull/5402.diff","patch_url":"https://github.com/hypothesis/h/pull/5402.patch","issue_url":"https://api.github.com/repos/hypothesis/h/issues/5402","number":5402,"state":"open","locked":false,"title":"Bump CSS reset (normalize.css)","user":{"login":"dwolfe","id":1348738,"node_id":"MDQ6VXNlcjEzNDg3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1348738?v=4","gravatar_id":"","url":"https://api.github.com/users/dwolfe","html_url":"https://github.com/dwolfe","followers_url":"https://api.github.com/users/dwolfe/followers","following_url":"https://api.github.com/users/dwolfe/following{/other_user}","gists_url":"https://api.github.com/users/dwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/dwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwolfe/subscriptions","organizations_url":"https://api.github.com/users/dwolfe/orgs","repos_url":"https://api.github.com/users/dwolfe/repos","events_url":"https://api.github.com/users/dwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/dwolfe/received_events","type":"User","site_admin":false},"body":"_Fixes https://github.com/hypothesis/h/issues/4236_\r\n\r\nGiving our reset a bump, since Normalize 8.0.0 has been released since our last update. In addressing a few small issues that cropped up with the revised reset, I came across https://github.com/hypothesis/h/issues/4236, which I'd seen before. Adding a few styles fixes the issue, tested and working in Chrome, Firefox and Safari on macOS; and IE11 and Chrome on Win7.\r\n\r\n## Before:\r\n![screen shot 2018-10-30 at 4 12 10 pm](https://user-images.githubusercontent.com/1348738/47756812-d8f97b80-dc60-11e8-9fc1-9e0f6cb96980.png)\r\n\r\n## After:\r\n![screen shot 2018-10-30 at 4 12 45 pm](https://user-images.githubusercontent.com/1348738/47756823-deef5c80-dc60-11e8-9784-c9d172d6c63e.png)\r\n\r\nAlso, two of the mixins in `mixins/_reset.scss` were used exactly once, so I moved those into the main file. If the need to reuse them elsewhere arises, we can abstract them again.","created_at":"2018-10-30T23:44:41Z","updated_at":"2018-11-01T18:11:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fd4f8f02dfa2d71b4488611f0d26e5e9200a0f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hypothesis/h/pulls/5402/commits","review_comments_url":"https://api.github.com/repos/hypothesis/h/pulls/5402/comments","review_comment_url":"https://api.github.com/repos/hypothesis/h/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/5402/comments","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/64a81f36d807de74e312841213f67b00d784521f","head":{"label":"hypothesis:bug/h/issues/4236","ref":"bug/h/issues/4236","sha":"64a81f36d807de74e312841213f67b00d784521f","user":{"login":"hypothesis","id":1243215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDMyMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"node_id":"MDEwOlJlcG9zaXRvcnkzOTEwOTQ1","name":"h","full_name":"hypothesis/h","private":false,"owner":{"login":"hypothesis","id":1243215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDMyMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hypothesis/h","description":"Annotate with anyone, anywhere.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/h/deployments","created_at":"2012-04-02T19:56:59Z","updated_at":"2018-11-01T16:17:46Z","pushed_at":"2018-11-01T17:43:38Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":30781,"stargazers_count":1267,"watchers_count":1267,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":278,"open_issues":94,"watchers":1267,"default_branch":"master"}},"base":{"label":"hypothesis:master","ref":"master","sha":"111f18bb01413fddc2873d66f9f1ac160b9e8aa2","user":{"login":"hypothesis","id":1243215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDMyMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"node_id":"MDEwOlJlcG9zaXRvcnkzOTEwOTQ1","name":"h","full_name":"hypothesis/h","private":false,"owner":{"login":"hypothesis","id":1243215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDMyMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hypothesis/h","description":"Annotate with anyone, anywhere.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/h/deployments","created_at":"2012-04-02T19:56:59Z","updated_at":"2018-11-01T16:17:46Z","pushed_at":"2018-11-01T17:43:38Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":30781,"stargazers_count":1267,"watchers_count":1267,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":278,"open_issues":94,"watchers":1267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/5402"},"html":{"href":"https://github.com/hypothesis/h/pull/5402"},"issue":{"href":"https://api.github.com/repos/hypothesis/h/issues/5402"},"comments":{"href":"https://api.github.com/repos/hypothesis/h/issues/5402/comments"},"review_comments":{"href":"https://api.github.com/repos/hypothesis/h/pulls/5402/comments"},"review_comment":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hypothesis/h/pulls/5402/commits"},"statuses":{"href":"https://api.github.com/repos/hypothesis/h/statuses/64a81f36d807de74e312841213f67b00d784521f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robertknight"}}