{"action":"created","comment":{"url":"https://api.github.com/repos/api-platform/admin/pulls/comments/233920420","pull_request_review_id":175446344,"id":233920420,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzkyMDQyMA==","diff_hunk":"@@ -168,8 +168,9 @@ export default ({entrypoint, resources = []}, httpClient = fetchHydra) => {\n    * @returns {Object}\n    */\n   const convertReactAdminRequestToHydraRequest = (type, resource, params) => {\n-    const collectionUrl = new URL(`${entrypoint}/${resource}`);\n-    const itemUrl = new URL(params.id, entrypoint);\n+    const entrypointUrl = new URL(entrypoint, window.location.origin);","path":"src/hydra/hydraClient.js","position":6,"original_position":6,"commit_id":"7d119a8317e7cbd2982ce27d1be8dae92e92fa96","original_commit_id":"7d119a8317e7cbd2982ce27d1be8dae92e92fa96","user":{"login":"dunglas","id":57224,"node_id":"MDQ6VXNlcjU3MjI0","avatar_url":"https://avatars2.githubusercontent.com/u/57224?v=4","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"body":"```\r\n> window.location.href\r\n< \"https://github.com/api-platform/admin/pull/126\"\r\n> window.location.origin\r\n< \"https://github.com\"\r\n```\r\n\r\nWith `window.location.href`, relative path will work.","created_at":"2018-11-15T16:41:14Z","updated_at":"2018-11-15T16:41:14Z","html_url":"https://github.com/api-platform/admin/pull/126#discussion_r233920420","pull_request_url":"https://api.github.com/repos/api-platform/admin/pulls/126","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/api-platform/admin/pulls/comments/233920420"},"html":{"href":"https://github.com/api-platform/admin/pull/126#discussion_r233920420"},"pull_request":{"href":"https://api.github.com/repos/api-platform/admin/pulls/126"}},"in_reply_to_id":229901146},"pull_request":{"url":"https://api.github.com/repos/api-platform/admin/pulls/126","id":227299890,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mjk5ODkw","html_url":"https://github.com/api-platform/admin/pull/126","diff_url":"https://github.com/api-platform/admin/pull/126.diff","patch_url":"https://github.com/api-platform/admin/pull/126.patch","issue_url":"https://api.github.com/repos/api-platform/admin/issues/126","number":126,"state":"open","locked":false,"title":"Fix relative entrypoint on hydra client","user":{"login":"ginifizz","id":16579730,"node_id":"MDQ6VXNlcjE2NTc5NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/16579730?v=4","gravatar_id":"","url":"https://api.github.com/users/ginifizz","html_url":"https://github.com/ginifizz","followers_url":"https://api.github.com/users/ginifizz/followers","following_url":"https://api.github.com/users/ginifizz/following{/other_user}","gists_url":"https://api.github.com/users/ginifizz/gists{/gist_id}","starred_url":"https://api.github.com/users/ginifizz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginifizz/subscriptions","organizations_url":"https://api.github.com/users/ginifizz/orgs","repos_url":"https://api.github.com/users/ginifizz/repos","events_url":"https://api.github.com/users/ginifizz/events{/privacy}","received_events_url":"https://api.github.com/users/ginifizz/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  |no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #124\r\n| License       | MIT\r\n| Doc PR        | api-platform/doc#1234\r\n","created_at":"2018-10-31T14:08:28Z","updated_at":"2018-11-15T16:41:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c6b15b53afed4fbc9da332cf4ff9c0973ef0100","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/api-platform/admin/pulls/126/commits","review_comments_url":"https://api.github.com/repos/api-platform/admin/pulls/126/comments","review_comment_url":"https://api.github.com/repos/api-platform/admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/api-platform/admin/issues/126/comments","statuses_url":"https://api.github.com/repos/api-platform/admin/statuses/7d119a8317e7cbd2982ce27d1be8dae92e92fa96","head":{"label":"ginifizz:master","ref":"master","sha":"7d119a8317e7cbd2982ce27d1be8dae92e92fa96","user":{"login":"ginifizz","id":16579730,"node_id":"MDQ6VXNlcjE2NTc5NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/16579730?v=4","gravatar_id":"","url":"https://api.github.com/users/ginifizz","html_url":"https://github.com/ginifizz","followers_url":"https://api.github.com/users/ginifizz/followers","following_url":"https://api.github.com/users/ginifizz/following{/other_user}","gists_url":"https://api.github.com/users/ginifizz/gists{/gist_id}","starred_url":"https://api.github.com/users/ginifizz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginifizz/subscriptions","organizations_url":"https://api.github.com/users/ginifizz/orgs","repos_url":"https://api.github.com/users/ginifizz/repos","events_url":"https://api.github.com/users/ginifizz/events{/privacy}","received_events_url":"https://api.github.com/users/ginifizz/received_events","type":"User","site_admin":false},"repo":{"id":99594162,"node_id":"MDEwOlJlcG9zaXRvcnk5OTU5NDE2Mg==","name":"admin","full_name":"ginifizz/admin","private":false,"owner":{"login":"ginifizz","id":16579730,"node_id":"MDQ6VXNlcjE2NTc5NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/16579730?v=4","gravatar_id":"","url":"https://api.github.com/users/ginifizz","html_url":"https://github.com/ginifizz","followers_url":"https://api.github.com/users/ginifizz/followers","following_url":"https://api.github.com/users/ginifizz/following{/other_user}","gists_url":"https://api.github.com/users/ginifizz/gists{/gist_id}","starred_url":"https://api.github.com/users/ginifizz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginifizz/subscriptions","organizations_url":"https://api.github.com/users/ginifizz/orgs","repos_url":"https://api.github.com/users/ginifizz/repos","events_url":"https://api.github.com/users/ginifizz/events{/privacy}","received_events_url":"https://api.github.com/users/ginifizz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ginifizz/admin","description":"A fancy and fully-featured administration interface builder written in ReactJS supporting APIs documented using Hydra (including all APIs built with API Platform)","fork":true,"url":"https://api.github.com/repos/ginifizz/admin","forks_url":"https://api.github.com/repos/ginifizz/admin/forks","keys_url":"https://api.github.com/repos/ginifizz/admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ginifizz/admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ginifizz/admin/teams","hooks_url":"https://api.github.com/repos/ginifizz/admin/hooks","issue_events_url":"https://api.github.com/repos/ginifizz/admin/issues/events{/number}","events_url":"https://api.github.com/repos/ginifizz/admin/events","assignees_url":"https://api.github.com/repos/ginifizz/admin/assignees{/user}","branches_url":"https://api.github.com/repos/ginifizz/admin/branches{/branch}","tags_url":"https://api.github.com/repos/ginifizz/admin/tags","blobs_url":"https://api.github.com/repos/ginifizz/admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ginifizz/admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ginifizz/admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ginifizz/admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ginifizz/admin/statuses/{sha}","languages_url":"https://api.github.com/repos/ginifizz/admin/languages","stargazers_url":"https://api.github.com/repos/ginifizz/admin/stargazers","contributors_url":"https://api.github.com/repos/ginifizz/admin/contributors","subscribers_url":"https://api.github.com/repos/ginifizz/admin/subscribers","subscription_url":"https://api.github.com/repos/ginifizz/admin/subscription","commits_url":"https://api.github.com/repos/ginifizz/admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ginifizz/admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ginifizz/admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ginifizz/admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ginifizz/admin/contents/{+path}","compare_url":"https://api.github.com/repos/ginifizz/admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ginifizz/admin/merges","archive_url":"https://api.github.com/repos/ginifizz/admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ginifizz/admin/downloads","issues_url":"https://api.github.com/repos/ginifizz/admin/issues{/number}","pulls_url":"https://api.github.com/repos/ginifizz/admin/pulls{/number}","milestones_url":"https://api.github.com/repos/ginifizz/admin/milestones{/number}","notifications_url":"https://api.github.com/repos/ginifizz/admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ginifizz/admin/labels{/name}","releases_url":"https://api.github.com/repos/ginifizz/admin/releases{/id}","deployments_url":"https://api.github.com/repos/ginifizz/admin/deployments","created_at":"2017-08-07T15:44:40Z","updated_at":"2018-10-31T14:36:47Z","pushed_at":"2018-10-31T14:36:45Z","git_url":"git://github.com/ginifizz/admin.git","ssh_url":"git@github.com:ginifizz/admin.git","clone_url":"https://github.com/ginifizz/admin.git","svn_url":"https://github.com/ginifizz/admin","homepage":"https://api-platform.com","size":501,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"api-platform:master","ref":"master","sha":"5a6b704991caf19c6d884e7f81ae352f4817ce1c","user":{"login":"api-platform","id":13420081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDgx","avatar_url":"https://avatars3.githubusercontent.com/u/13420081?v=4","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":47120306,"node_id":"MDEwOlJlcG9zaXRvcnk0NzEyMDMwNg==","name":"admin","full_name":"api-platform/admin","private":false,"owner":{"login":"api-platform","id":13420081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDgx","avatar_url":"https://avatars3.githubusercontent.com/u/13420081?v=4","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/api-platform/admin","description":"A fancy and fully-featured administration interface builder written in ReactJS supporting APIs documented using Hydra (including all APIs built with API Platform)","fork":false,"url":"https://api.github.com/repos/api-platform/admin","forks_url":"https://api.github.com/repos/api-platform/admin/forks","keys_url":"https://api.github.com/repos/api-platform/admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/api-platform/admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/api-platform/admin/teams","hooks_url":"https://api.github.com/repos/api-platform/admin/hooks","issue_events_url":"https://api.github.com/repos/api-platform/admin/issues/events{/number}","events_url":"https://api.github.com/repos/api-platform/admin/events","assignees_url":"https://api.github.com/repos/api-platform/admin/assignees{/user}","branches_url":"https://api.github.com/repos/api-platform/admin/branches{/branch}","tags_url":"https://api.github.com/repos/api-platform/admin/tags","blobs_url":"https://api.github.com/repos/api-platform/admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/api-platform/admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/api-platform/admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/api-platform/admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/api-platform/admin/statuses/{sha}","languages_url":"https://api.github.com/repos/api-platform/admin/languages","stargazers_url":"https://api.github.com/repos/api-platform/admin/stargazers","contributors_url":"https://api.github.com/repos/api-platform/admin/contributors","subscribers_url":"https://api.github.com/repos/api-platform/admin/subscribers","subscription_url":"https://api.github.com/repos/api-platform/admin/subscription","commits_url":"https://api.github.com/repos/api-platform/admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/api-platform/admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/api-platform/admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/api-platform/admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/api-platform/admin/contents/{+path}","compare_url":"https://api.github.com/repos/api-platform/admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/api-platform/admin/merges","archive_url":"https://api.github.com/repos/api-platform/admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/api-platform/admin/downloads","issues_url":"https://api.github.com/repos/api-platform/admin/issues{/number}","pulls_url":"https://api.github.com/repos/api-platform/admin/pulls{/number}","milestones_url":"https://api.github.com/repos/api-platform/admin/milestones{/number}","notifications_url":"https://api.github.com/repos/api-platform/admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/api-platform/admin/labels{/name}","releases_url":"https://api.github.com/repos/api-platform/admin/releases{/id}","deployments_url":"https://api.github.com/repos/api-platform/admin/deployments","created_at":"2015-11-30T13:29:22Z","updated_at":"2018-11-09T05:37:44Z","pushed_at":"2018-11-15T12:27:03Z","git_url":"git://github.com/api-platform/admin.git","ssh_url":"git@github.com:api-platform/admin.git","clone_url":"https://github.com/api-platform/admin.git","svn_url":"https://github.com/api-platform/admin","homepage":"https://api-platform.com/docs/admin/","size":504,"stargazers_count":183,"watchers_count":183,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":36,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/api-platform/admin/pulls/126"},"html":{"href":"https://github.com/api-platform/admin/pull/126"},"issue":{"href":"https://api.github.com/repos/api-platform/admin/issues/126"},"comments":{"href":"https://api.github.com/repos/api-platform/admin/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/api-platform/admin/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/api-platform/admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/api-platform/admin/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/api-platform/admin/statuses/7d119a8317e7cbd2982ce27d1be8dae92e92fa96"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dunglas"}}