{"action":"closed","number":2670,"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/2670","id":187352377,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3MzUyMzc3","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/2670","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/2670.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/2670.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/2670","number":2670,"state":"closed","locked":false,"title":"[Core] Fix ScrollToPosition.MakeVisible bug","user":{"login":"myroot","id":1029155,"node_id":"MDQ6VXNlcjEwMjkxNTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1029155?v=4","gravatar_id":"","url":"https://api.github.com/users/myroot","html_url":"https://github.com/myroot","followers_url":"https://api.github.com/users/myroot/followers","following_url":"https://api.github.com/users/myroot/following{/other_user}","gists_url":"https://api.github.com/users/myroot/gists{/gist_id}","starred_url":"https://api.github.com/users/myroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myroot/subscriptions","organizations_url":"https://api.github.com/users/myroot/orgs","repos_url":"https://api.github.com/users/myroot/repos","events_url":"https://api.github.com/users/myroot/events{/privacy}","received_events_url":"https://api.github.com/users/myroot/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n Fix ScrollToPosition.MakeVisible bug\r\n - Fix `isItemVisible` condition on ScrollView\r\n\r\n### Bugs Fixed ###\r\nAs is\r\n![Image](https://user-images.githubusercontent.com/1029155/39903358-d287500e-550d-11e8-9f91-b0e6a8a925a4.gif) ![Image](https://user-images.githubusercontent.com/1029155/39903363-d64f4c32-550d-11e8-8bf3-bd23aee57dd6.gif)\r\n\r\nFixed\r\n![Image](https://user-images.githubusercontent.com/1029155/39903380-e8a3cd7c-550d-11e8-81dd-46810f0577ac.gif) ![Image](https://user-images.githubusercontent.com/1029155/39903382-ebdf1bb8-550d-11e8-99a0-086945ad0f40.gif)\r\n\r\n### API Changes ###\r\nNone\r\n\r\n### Behavioral Changes ###\r\nNone\r\n\r\n### PR Checklist ###\r\n\r\n- [x] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of the target branch at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Consolidate commits as makes sense\r\n","created_at":"2018-05-11T02:26:48Z","updated_at":"2018-06-07T07:44:59Z","closed_at":"2018-06-07T07:44:59Z","merged_at":"2018-06-07T07:44:58Z","merge_commit_sha":"c5148263a38be7c7d868381654f6116836767df4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":868986974,"node_id":"MDU6TGFiZWw4Njg5ODY5NzQ=","url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/API-change","name":"API-change","color":"fbca04","default":false},{"id":808770949,"node_id":"MDU6TGFiZWw4MDg3NzA5NDk=","url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/a/layout","name":"a/layout","color":"b2ce37","default":false},{"id":770579803,"node_id":"MDU6TGFiZWw3NzA1Nzk4MDM=","url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/p/iOS%20%F0%9F%8D%8E","name":"p/iOS 🍎","color":"ed841c","default":false},{"id":343860851,"node_id":"MDU6TGFiZWwzNDM4NjA4NTE=","url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/t/bug%20:bug:","name":"t/bug :bug:","color":"fc2929","default":false}],"milestone":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones/1","html_url":"https://github.com/xamarin/Xamarin.Forms/milestone/1","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones/1/labels","id":3321265,"node_id":"MDk6TWlsZXN0b25lMzMyMTI2NQ==","number":1,"title":"3.1.0","description":"","creator":{"login":"samhouts","id":7827070,"node_id":"MDQ6VXNlcjc4MjcwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7827070?v=4","gravatar_id":"","url":"https://api.github.com/users/samhouts","html_url":"https://github.com/samhouts","followers_url":"https://api.github.com/users/samhouts/followers","following_url":"https://api.github.com/users/samhouts/following{/other_user}","gists_url":"https://api.github.com/users/samhouts/gists{/gist_id}","starred_url":"https://api.github.com/users/samhouts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhouts/subscriptions","organizations_url":"https://api.github.com/users/samhouts/orgs","repos_url":"https://api.github.com/users/samhouts/repos","events_url":"https://api.github.com/users/samhouts/events{/privacy}","received_events_url":"https://api.github.com/users/samhouts/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":68,"state":"open","created_at":"2018-05-04T18:33:32Z","updated_at":"2018-06-07T07:44:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/2670/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/2670/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/2670/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/995eba4107a2f1af4cab5fce4f9132026907ae51","head":{"label":"myroot:fix-makevisible","ref":"fix-makevisible","sha":"995eba4107a2f1af4cab5fce4f9132026907ae51","user":{"login":"myroot","id":1029155,"node_id":"MDQ6VXNlcjEwMjkxNTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1029155?v=4","gravatar_id":"","url":"https://api.github.com/users/myroot","html_url":"https://github.com/myroot","followers_url":"https://api.github.com/users/myroot/followers","following_url":"https://api.github.com/users/myroot/following{/other_user}","gists_url":"https://api.github.com/users/myroot/gists{/gist_id}","starred_url":"https://api.github.com/users/myroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myroot/subscriptions","organizations_url":"https://api.github.com/users/myroot/orgs","repos_url":"https://api.github.com/users/myroot/repos","events_url":"https://api.github.com/users/myroot/events{/privacy}","received_events_url":"https://api.github.com/users/myroot/received_events","type":"User","site_admin":false},"repo":{"id":65427958,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQyNzk1OA==","name":"Xamarin.Forms","full_name":"myroot/Xamarin.Forms","owner":{"login":"myroot","id":1029155,"node_id":"MDQ6VXNlcjEwMjkxNTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1029155?v=4","gravatar_id":"","url":"https://api.github.com/users/myroot","html_url":"https://github.com/myroot","followers_url":"https://api.github.com/users/myroot/followers","following_url":"https://api.github.com/users/myroot/following{/other_user}","gists_url":"https://api.github.com/users/myroot/gists{/gist_id}","starred_url":"https://api.github.com/users/myroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myroot/subscriptions","organizations_url":"https://api.github.com/users/myroot/orgs","repos_url":"https://api.github.com/users/myroot/repos","events_url":"https://api.github.com/users/myroot/events{/privacy}","received_events_url":"https://api.github.com/users/myroot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/myroot/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/myroot/Xamarin.Forms","forks_url":"https://api.github.com/repos/myroot/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/myroot/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myroot/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myroot/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/myroot/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/myroot/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/myroot/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/myroot/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/myroot/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/myroot/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/myroot/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myroot/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myroot/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/myroot/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myroot/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/myroot/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/myroot/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/myroot/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/myroot/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/myroot/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/myroot/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/myroot/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/myroot/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/myroot/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/myroot/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/myroot/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myroot/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/myroot/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myroot/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/myroot/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/myroot/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/myroot/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/myroot/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myroot/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/myroot/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/myroot/Xamarin.Forms/deployments","created_at":"2016-08-11T01:23:17Z","updated_at":"2016-08-11T01:23:22Z","pushed_at":"2018-05-29T23:28:15Z","git_url":"git://github.com/myroot/Xamarin.Forms.git","ssh_url":"git@github.com:myroot/Xamarin.Forms.git","clone_url":"https://github.com/myroot/Xamarin.Forms.git","svn_url":"https://github.com/myroot/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":36261,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:3.1.0","ref":"3.1.0","sha":"012d248e2ae15076381cb1d3381fe6695099772d","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"node_id":"MDEwOlJlcG9zaXRvcnk1NDIxMzQ5MA==","name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2018-06-07T07:23:37Z","pushed_at":"2018-06-07T07:44:58Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":44648,"stargazers_count":2274,"watchers_count":2274,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":960,"mirror_url":null,"archived":false,"open_issues_count":674,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":960,"open_issues":674,"watchers":2274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/2670"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/2670"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/2670"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/2670/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/2670/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/2670/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/995eba4107a2f1af4cab5fce4f9132026907ae51"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rmarinho","id":1235097,"node_id":"MDQ6VXNlcjEyMzUwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1235097?v=4","gravatar_id":"","url":"https://api.github.com/users/rmarinho","html_url":"https://github.com/rmarinho","followers_url":"https://api.github.com/users/rmarinho/followers","following_url":"https://api.github.com/users/rmarinho/following{/other_user}","gists_url":"https://api.github.com/users/rmarinho/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarinho/subscriptions","organizations_url":"https://api.github.com/users/rmarinho/orgs","repos_url":"https://api.github.com/users/rmarinho/repos","events_url":"https://api.github.com/users/rmarinho/events{/privacy}","received_events_url":"https://api.github.com/users/rmarinho/received_events","type":"User","site_admin":false},"comments":8,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"rmarinho"}}