{"action":"created","comment":{"url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/comments/223833741","pull_request_review_id":163059190,"id":223833741,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzgzMzc0MQ==","diff_hunk":"@@ -180,10 +180,12 @@ def test_get_workflow_tasks(self, data_file):\n \n     def test_get_file_format(self):\n         assert cam.get_file_format('asdf', {}) == 'unknown'\n-        assert cam.get_file_format('asdf.bam', {'.bam': 'bam'}) == 'bam'\n-        assert cam.get_file_format('asdf.txt', {'.bam': 'bam'}) == 'unknown'\n-        assert cam.get_file_format('asdf.bam', {'.bam': 'bam', '_metrics': 'metrics'}) == 'bam'\n-        assert cam.get_file_format('asdf.foo_metrics', {'.bam': 'bam', '_metrics': 'metrics'}) == 'metrics'\n+        assert cam.get_file_format('asdf.bam', {'.bam$': 'bam'}) == 'bam'\n+        assert cam.get_file_format('asdf.txt', {'.bam$': 'bam'}) == 'unknown'","path":"pipeline_tools/tests/test_create_analysis_metadata.py","position":9,"original_position":9,"commit_id":"0a0a13e173188d53083c02d4dbfdf2461516314d","original_commit_id":"0a0a13e173188d53083c02d4dbfdf2461516314d","user":{"login":"samanehsan","id":6414394,"node_id":"MDQ6VXNlcjY0MTQzOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6414394?v=4","gravatar_id":"","url":"https://api.github.com/users/samanehsan","html_url":"https://github.com/samanehsan","followers_url":"https://api.github.com/users/samanehsan/followers","following_url":"https://api.github.com/users/samanehsan/following{/other_user}","gists_url":"https://api.github.com/users/samanehsan/gists{/gist_id}","starred_url":"https://api.github.com/users/samanehsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samanehsan/subscriptions","organizations_url":"https://api.github.com/users/samanehsan/orgs","repos_url":"https://api.github.com/users/samanehsan/repos","events_url":"https://api.github.com/users/samanehsan/events{/privacy}","received_events_url":"https://api.github.com/users/samanehsan/received_events","type":"User","site_admin":false},"body":"We may not have this situation with the SS2 outputs, but what if a file matches multiple patterns? E.g. `test_metrics.txt` ","created_at":"2018-10-09T19:31:47Z","updated_at":"2018-10-09T19:31:47Z","html_url":"https://github.com/HumanCellAtlas/pipeline-tools/pull/87#discussion_r223833741","pull_request_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/87","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/comments/223833741"},"html":{"href":"https://github.com/HumanCellAtlas/pipeline-tools/pull/87#discussion_r223833741"},"pull_request":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/87","id":221556126,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTU2MTI2","html_url":"https://github.com/HumanCellAtlas/pipeline-tools/pull/87","diff_url":"https://github.com/HumanCellAtlas/pipeline-tools/pull/87.diff","patch_url":"https://github.com/HumanCellAtlas/pipeline-tools/pull/87.patch","issue_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues/87","number":87,"state":"open","locked":false,"title":"Cw update adapter to include zarr outputs","user":{"login":"samanehsan","id":6414394,"node_id":"MDQ6VXNlcjY0MTQzOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6414394?v=4","gravatar_id":"","url":"https://api.github.com/users/samanehsan","html_url":"https://github.com/samanehsan","followers_url":"https://api.github.com/users/samanehsan/followers","following_url":"https://api.github.com/users/samanehsan/following{/other_user}","gists_url":"https://api.github.com/users/samanehsan/gists{/gist_id}","starred_url":"https://api.github.com/users/samanehsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samanehsan/subscriptions","organizations_url":"https://api.github.com/users/samanehsan/orgs","repos_url":"https://api.github.com/users/samanehsan/repos","events_url":"https://api.github.com/users/samanehsan/events{/privacy}","received_events_url":"https://api.github.com/users/samanehsan/received_events","type":"User","site_admin":false},"body":"Please ensure the following when opening a PR:\r\n- [ ] Added or updated tests\r\n- [ ] Updated documentation\r\n- [ ] Applied style guidelines\r\n- [ ] Considered generalizability beyond our own use case\r\n","created_at":"2018-10-09T19:23:01Z","updated_at":"2018-10-09T19:31:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a067a9cf250ddc4844fd6820401cd99b66f3fac7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/87/commits","review_comments_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/87/comments","review_comment_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues/87/comments","statuses_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/statuses/0a0a13e173188d53083c02d4dbfdf2461516314d","head":{"label":"HumanCellAtlas:cw-update-adapter-to-include-zarr-outputs","ref":"cw-update-adapter-to-include-zarr-outputs","sha":"0a0a13e173188d53083c02d4dbfdf2461516314d","user":{"login":"HumanCellAtlas","id":26391798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzkxNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"repo":{"id":110603502,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2MDM1MDI=","name":"pipeline-tools","full_name":"HumanCellAtlas/pipeline-tools","private":false,"owner":{"login":"HumanCellAtlas","id":26391798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzkxNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HumanCellAtlas/pipeline-tools","description":"Pipeline-tools for HCA DCP Secondary Analyses Service","fork":false,"url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools","forks_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/forks","keys_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/teams","hooks_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/hooks","issue_events_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues/events{/number}","events_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/events","assignees_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/assignees{/user}","branches_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/branches{/branch}","tags_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/tags","blobs_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/languages","stargazers_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/stargazers","contributors_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/contributors","subscribers_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/subscribers","subscription_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/subscription","commits_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/contents/{+path}","compare_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/merges","archive_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/downloads","issues_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues{/number}","pulls_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/labels{/name}","releases_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/releases{/id}","deployments_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/deployments","created_at":"2017-11-13T21:19:14Z","updated_at":"2018-10-05T20:16:15Z","pushed_at":"2018-10-09T19:23:01Z","git_url":"git://github.com/HumanCellAtlas/pipeline-tools.git","ssh_url":"git@github.com:HumanCellAtlas/pipeline-tools.git","clone_url":"https://github.com/HumanCellAtlas/pipeline-tools.git","svn_url":"https://github.com/HumanCellAtlas/pipeline-tools","homepage":"https://pipeline-tools.readthedocs.io","size":285,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"HumanCellAtlas:master","ref":"master","sha":"302eb3fb2d3c7bef360bae844aff987db2568d5f","user":{"login":"HumanCellAtlas","id":26391798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzkxNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"repo":{"id":110603502,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2MDM1MDI=","name":"pipeline-tools","full_name":"HumanCellAtlas/pipeline-tools","private":false,"owner":{"login":"HumanCellAtlas","id":26391798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzkxNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HumanCellAtlas/pipeline-tools","description":"Pipeline-tools for HCA DCP Secondary Analyses Service","fork":false,"url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools","forks_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/forks","keys_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/teams","hooks_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/hooks","issue_events_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues/events{/number}","events_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/events","assignees_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/assignees{/user}","branches_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/branches{/branch}","tags_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/tags","blobs_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/languages","stargazers_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/stargazers","contributors_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/contributors","subscribers_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/subscribers","subscription_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/subscription","commits_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/contents/{+path}","compare_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/merges","archive_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/downloads","issues_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues{/number}","pulls_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/labels{/name}","releases_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/releases{/id}","deployments_url":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/deployments","created_at":"2017-11-13T21:19:14Z","updated_at":"2018-10-05T20:16:15Z","pushed_at":"2018-10-09T19:23:01Z","git_url":"git://github.com/HumanCellAtlas/pipeline-tools.git","ssh_url":"git@github.com:HumanCellAtlas/pipeline-tools.git","clone_url":"https://github.com/HumanCellAtlas/pipeline-tools.git","svn_url":"https://github.com/HumanCellAtlas/pipeline-tools","homepage":"https://pipeline-tools.readthedocs.io","size":285,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/87"},"html":{"href":"https://github.com/HumanCellAtlas/pipeline-tools/pull/87"},"issue":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues/87"},"comments":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/HumanCellAtlas/pipeline-tools/statuses/0a0a13e173188d53083c02d4dbfdf2461516314d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samanehsan"}}