{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/fgcmcal/pulls/comments/241912730","pull_request_review_id":185312325,"id":241912730,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTkxMjczMA==","diff_hunk":"@@ -771,7 +772,7 @@ def _getConstantPhotoCalib(self, zeropoint, err, offset, scaling):\n         # Take the zeropoint, apply the absolute relative calibration offset,\n         # and whatever flat-field scaling was applied\n \n-        calibMean = 10.**(zeropoint / (-2.5)) * 10.**(offset / (-2.5)) * scaling\n+        calibMean = (offset*units.ABmag).to_value(units.nJy) * scaling","path":"python/lsst/fgcmcal/fgcmOutputProducts.py","position":22,"original_position":22,"commit_id":"c15572c2a6f1a209089304b144789e1461cc20db","original_commit_id":"c15572c2a6f1a209089304b144789e1461cc20db","user":{"login":"erykoff","id":5167891,"node_id":"MDQ6VXNlcjUxNjc4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5167891?v=4","gravatar_id":"","url":"https://api.github.com/users/erykoff","html_url":"https://github.com/erykoff","followers_url":"https://api.github.com/users/erykoff/followers","following_url":"https://api.github.com/users/erykoff/following{/other_user}","gists_url":"https://api.github.com/users/erykoff/gists{/gist_id}","starred_url":"https://api.github.com/users/erykoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erykoff/subscriptions","organizations_url":"https://api.github.com/users/erykoff/orgs","repos_url":"https://api.github.com/users/erykoff/repos","events_url":"https://api.github.com/users/erykoff/events{/privacy}","received_events_url":"https://api.github.com/users/erykoff/received_events","type":"User","site_admin":false},"body":"See above.","created_at":"2018-12-14T22:44:43Z","updated_at":"2018-12-14T22:45:04Z","html_url":"https://github.com/lsst/fgcmcal/pull/5#discussion_r241912730","pull_request_url":"https://api.github.com/repos/lsst/fgcmcal/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lsst/fgcmcal/pulls/comments/241912730"},"html":{"href":"https://github.com/lsst/fgcmcal/pull/5#discussion_r241912730"},"pull_request":{"href":"https://api.github.com/repos/lsst/fgcmcal/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/fgcmcal/pulls/5","id":238846955,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODQ2OTU1","html_url":"https://github.com/lsst/fgcmcal/pull/5","diff_url":"https://github.com/lsst/fgcmcal/pull/5.diff","patch_url":"https://github.com/lsst/fgcmcal/pull/5.patch","issue_url":"https://api.github.com/repos/lsst/fgcmcal/issues/5","number":5,"state":"open","locked":false,"title":"DM-16650: Update to nanojansky photocalib definition","user":{"login":"parejkoj","id":1606089,"node_id":"MDQ6VXNlcjE2MDYwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1606089?v=4","gravatar_id":"","url":"https://api.github.com/users/parejkoj","html_url":"https://github.com/parejkoj","followers_url":"https://api.github.com/users/parejkoj/followers","following_url":"https://api.github.com/users/parejkoj/following{/other_user}","gists_url":"https://api.github.com/users/parejkoj/gists{/gist_id}","starred_url":"https://api.github.com/users/parejkoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parejkoj/subscriptions","organizations_url":"https://api.github.com/users/parejkoj/orgs","repos_url":"https://api.github.com/users/parejkoj/repos","events_url":"https://api.github.com/users/parejkoj/events{/privacy}","received_events_url":"https://api.github.com/users/parejkoj/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-14T21:24:15Z","updated_at":"2018-12-14T22:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01a80dccb5becfe89cac76efd42c0f0a5cba6ab0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/fgcmcal/pulls/5/commits","review_comments_url":"https://api.github.com/repos/lsst/fgcmcal/pulls/5/comments","review_comment_url":"https://api.github.com/repos/lsst/fgcmcal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/fgcmcal/issues/5/comments","statuses_url":"https://api.github.com/repos/lsst/fgcmcal/statuses/c15572c2a6f1a209089304b144789e1461cc20db","head":{"label":"lsst:tickets/DM-16650","ref":"tickets/DM-16650","sha":"c15572c2a6f1a209089304b144789e1461cc20db","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":90074525,"node_id":"MDEwOlJlcG9zaXRvcnk5MDA3NDUyNQ==","name":"fgcmcal","full_name":"lsst/fgcmcal","private":false,"owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst/fgcmcal","description":"Global Photometric Calibration in LSST with FGCM","fork":false,"url":"https://api.github.com/repos/lsst/fgcmcal","forks_url":"https://api.github.com/repos/lsst/fgcmcal/forks","keys_url":"https://api.github.com/repos/lsst/fgcmcal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/fgcmcal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/fgcmcal/teams","hooks_url":"https://api.github.com/repos/lsst/fgcmcal/hooks","issue_events_url":"https://api.github.com/repos/lsst/fgcmcal/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/fgcmcal/events","assignees_url":"https://api.github.com/repos/lsst/fgcmcal/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/fgcmcal/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/fgcmcal/tags","blobs_url":"https://api.github.com/repos/lsst/fgcmcal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/fgcmcal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/fgcmcal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/fgcmcal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/fgcmcal/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/fgcmcal/languages","stargazers_url":"https://api.github.com/repos/lsst/fgcmcal/stargazers","contributors_url":"https://api.github.com/repos/lsst/fgcmcal/contributors","subscribers_url":"https://api.github.com/repos/lsst/fgcmcal/subscribers","subscription_url":"https://api.github.com/repos/lsst/fgcmcal/subscription","commits_url":"https://api.github.com/repos/lsst/fgcmcal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/fgcmcal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/fgcmcal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/fgcmcal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/fgcmcal/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/fgcmcal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/fgcmcal/merges","archive_url":"https://api.github.com/repos/lsst/fgcmcal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/fgcmcal/downloads","issues_url":"https://api.github.com/repos/lsst/fgcmcal/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/fgcmcal/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/fgcmcal/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/fgcmcal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/fgcmcal/labels{/name}","releases_url":"https://api.github.com/repos/lsst/fgcmcal/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/fgcmcal/deployments","created_at":"2017-05-02T20:21:05Z","updated_at":"2018-11-20T15:02:49Z","pushed_at":"2018-12-14T21:24:15Z","git_url":"git://github.com/lsst/fgcmcal.git","ssh_url":"git@github.com:lsst/fgcmcal.git","clone_url":"https://github.com/lsst/fgcmcal.git","svn_url":"https://github.com/lsst/fgcmcal","homepage":"","size":621,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"581de6283e6cf13db429380f5e9dc7e57a8337a0","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":90074525,"node_id":"MDEwOlJlcG9zaXRvcnk5MDA3NDUyNQ==","name":"fgcmcal","full_name":"lsst/fgcmcal","private":false,"owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst/fgcmcal","description":"Global Photometric Calibration in LSST with FGCM","fork":false,"url":"https://api.github.com/repos/lsst/fgcmcal","forks_url":"https://api.github.com/repos/lsst/fgcmcal/forks","keys_url":"https://api.github.com/repos/lsst/fgcmcal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/fgcmcal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/fgcmcal/teams","hooks_url":"https://api.github.com/repos/lsst/fgcmcal/hooks","issue_events_url":"https://api.github.com/repos/lsst/fgcmcal/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/fgcmcal/events","assignees_url":"https://api.github.com/repos/lsst/fgcmcal/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/fgcmcal/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/fgcmcal/tags","blobs_url":"https://api.github.com/repos/lsst/fgcmcal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/fgcmcal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/fgcmcal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/fgcmcal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/fgcmcal/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/fgcmcal/languages","stargazers_url":"https://api.github.com/repos/lsst/fgcmcal/stargazers","contributors_url":"https://api.github.com/repos/lsst/fgcmcal/contributors","subscribers_url":"https://api.github.com/repos/lsst/fgcmcal/subscribers","subscription_url":"https://api.github.com/repos/lsst/fgcmcal/subscription","commits_url":"https://api.github.com/repos/lsst/fgcmcal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/fgcmcal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/fgcmcal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/fgcmcal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/fgcmcal/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/fgcmcal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/fgcmcal/merges","archive_url":"https://api.github.com/repos/lsst/fgcmcal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/fgcmcal/downloads","issues_url":"https://api.github.com/repos/lsst/fgcmcal/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/fgcmcal/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/fgcmcal/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/fgcmcal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/fgcmcal/labels{/name}","releases_url":"https://api.github.com/repos/lsst/fgcmcal/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/fgcmcal/deployments","created_at":"2017-05-02T20:21:05Z","updated_at":"2018-11-20T15:02:49Z","pushed_at":"2018-12-14T21:24:15Z","git_url":"git://github.com/lsst/fgcmcal.git","ssh_url":"git@github.com:lsst/fgcmcal.git","clone_url":"https://github.com/lsst/fgcmcal.git","svn_url":"https://github.com/lsst/fgcmcal","homepage":"","size":621,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/fgcmcal/pulls/5"},"html":{"href":"https://github.com/lsst/fgcmcal/pull/5"},"issue":{"href":"https://api.github.com/repos/lsst/fgcmcal/issues/5"},"comments":{"href":"https://api.github.com/repos/lsst/fgcmcal/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/fgcmcal/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/fgcmcal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/fgcmcal/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/fgcmcal/statuses/c15572c2a6f1a209089304b144789e1461cc20db"}},"author_association":"NONE"}}
{"actor":{"display_login":"erykoff"}}