{"action":"created","comment":{"url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/comments/218291826","pull_request_review_id":156195427,"id":218291826,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODI5MTgyNg==","diff_hunk":"@@ -96,10 +99,11 @@ public void select() {\n         /* Case: mixed case command word -> rejected */\n         assertCommandFailure(\"SeLeCt 1\", MESSAGE_UNKNOWN_COMMAND);\n \n+        // TODO: when delete command is implemented\n         /* Case: select from empty address book -> rejected */\n-        deleteAllPersons();\n-        assertCommandFailure(SelectCommand.COMMAND_WORD + \" \" + INDEX_FIRST_PERSON.getOneBased(),\n-                MESSAGE_INVALID_PERSON_DISPLAYED_INDEX);\n+//        deleteAllPersons();","path":"src/test/java/systemtests/SelectCommandSystemTest.java","position":114,"original_position":114,"commit_id":"e852bfc7c3f67c40a76ff7532cd8b00641cb9091","original_commit_id":"e852bfc7c3f67c40a76ff7532cd8b00641cb9091","user":{"login":"hozongsien","id":42339979,"node_id":"MDQ6VXNlcjQyMzM5OTc5","avatar_url":"https://avatars1.githubusercontent.com/u/42339979?v=4","gravatar_id":"","url":"https://api.github.com/users/hozongsien","html_url":"https://github.com/hozongsien","followers_url":"https://api.github.com/users/hozongsien/followers","following_url":"https://api.github.com/users/hozongsien/following{/other_user}","gists_url":"https://api.github.com/users/hozongsien/gists{/gist_id}","starred_url":"https://api.github.com/users/hozongsien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hozongsien/subscriptions","organizations_url":"https://api.github.com/users/hozongsien/orgs","repos_url":"https://api.github.com/users/hozongsien/repos","events_url":"https://api.github.com/users/hozongsien/events{/privacy}","received_events_url":"https://api.github.com/users/hozongsien/received_events","type":"User","site_admin":false},"body":"Delete command not implemented","created_at":"2018-09-18T03:46:16Z","updated_at":"2018-09-18T03:46:16Z","html_url":"https://github.com/CS2103-AY1819S1-W12-3/main/pull/10#discussion_r218291826","pull_request_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/comments/218291826"},"html":{"href":"https://github.com/CS2103-AY1819S1-W12-3/main/pull/10#discussion_r218291826"},"pull_request":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/10","id":215773677,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzczNjc3","html_url":"https://github.com/CS2103-AY1819S1-W12-3/main/pull/10","diff_url":"https://github.com/CS2103-AY1819S1-W12-3/main/pull/10.diff","patch_url":"https://github.com/CS2103-AY1819S1-W12-3/main/pull/10.patch","issue_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues/10","number":10,"state":"open","locked":false,"title":"Update list & select function","user":{"login":"hozongsien","id":42339979,"node_id":"MDQ6VXNlcjQyMzM5OTc5","avatar_url":"https://avatars1.githubusercontent.com/u/42339979?v=4","gravatar_id":"","url":"https://api.github.com/users/hozongsien","html_url":"https://github.com/hozongsien","followers_url":"https://api.github.com/users/hozongsien/followers","following_url":"https://api.github.com/users/hozongsien/following{/other_user}","gists_url":"https://api.github.com/users/hozongsien/gists{/gist_id}","starred_url":"https://api.github.com/users/hozongsien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hozongsien/subscriptions","organizations_url":"https://api.github.com/users/hozongsien/orgs","repos_url":"https://api.github.com/users/hozongsien/repos","events_url":"https://api.github.com/users/hozongsien/events{/privacy}","received_events_url":"https://api.github.com/users/hozongsien/received_events","type":"User","site_admin":false},"body":"Completed port for list and select command:\r\n- testcases have been updated\r\n- a handful of testcase have been commented out awaiting other command ports.","created_at":"2018-09-15T15:11:33Z","updated_at":"2018-09-18T03:46:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b60bce1d87fdbdb7784140533ec5957f428d023","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/10/commits","review_comments_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/10/comments","review_comment_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues/10/comments","statuses_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/statuses/e852bfc7c3f67c40a76ff7532cd8b00641cb9091","head":{"label":"CS2103-AY1819S1-W12-3:Update_list_function","ref":"Update_list_function","sha":"e852bfc7c3f67c40a76ff7532cd8b00641cb9091","user":{"login":"CS2103-AY1819S1-W12-3","id":42921441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTIxNDQx","avatar_url":"https://avatars1.githubusercontent.com/u/42921441?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103-AY1819S1-W12-3","html_url":"https://github.com/CS2103-AY1819S1-W12-3","followers_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/followers","following_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/following{/other_user}","gists_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/subscriptions","organizations_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/orgs","repos_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/repos","events_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/received_events","type":"Organization","site_admin":false},"repo":{"id":147138460,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMzg0NjA=","name":"main","full_name":"CS2103-AY1819S1-W12-3/main","private":false,"owner":{"login":"CS2103-AY1819S1-W12-3","id":42921441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTIxNDQx","avatar_url":"https://avatars1.githubusercontent.com/u/42921441?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103-AY1819S1-W12-3","html_url":"https://github.com/CS2103-AY1819S1-W12-3","followers_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/followers","following_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/following{/other_user}","gists_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/subscriptions","organizations_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/orgs","repos_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/repos","events_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CS2103-AY1819S1-W12-3/main","description":"3VIA","fork":true,"url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main","forks_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/forks","keys_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/teams","hooks_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/hooks","issue_events_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues/events{/number}","events_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/events","assignees_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/assignees{/user}","branches_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/branches{/branch}","tags_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/tags","blobs_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/statuses/{sha}","languages_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/languages","stargazers_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/stargazers","contributors_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/contributors","subscribers_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/subscribers","subscription_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/subscription","commits_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/contents/{+path}","compare_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/merges","archive_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/downloads","issues_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues{/number}","pulls_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls{/number}","milestones_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/milestones{/number}","notifications_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/labels{/name}","releases_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/releases{/id}","deployments_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/deployments","created_at":"2018-09-03T01:52:21Z","updated_at":"2018-09-18T03:16:25Z","pushed_at":"2018-09-18T03:42:47Z","git_url":"git://github.com/CS2103-AY1819S1-W12-3/main.git","ssh_url":"git@github.com:CS2103-AY1819S1-W12-3/main.git","clone_url":"https://github.com/CS2103-AY1819S1-W12-3/main.git","svn_url":"https://github.com/CS2103-AY1819S1-W12-3/main","homepage":"","size":9378,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"CS2103-AY1819S1-W12-3:set-basic-functions-for-trivia","ref":"set-basic-functions-for-trivia","sha":"2857ea2e75b9a5f24823e57d0aa94edcdf7d1481","user":{"login":"CS2103-AY1819S1-W12-3","id":42921441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTIxNDQx","avatar_url":"https://avatars1.githubusercontent.com/u/42921441?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103-AY1819S1-W12-3","html_url":"https://github.com/CS2103-AY1819S1-W12-3","followers_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/followers","following_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/following{/other_user}","gists_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/subscriptions","organizations_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/orgs","repos_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/repos","events_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/received_events","type":"Organization","site_admin":false},"repo":{"id":147138460,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMzg0NjA=","name":"main","full_name":"CS2103-AY1819S1-W12-3/main","private":false,"owner":{"login":"CS2103-AY1819S1-W12-3","id":42921441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTIxNDQx","avatar_url":"https://avatars1.githubusercontent.com/u/42921441?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103-AY1819S1-W12-3","html_url":"https://github.com/CS2103-AY1819S1-W12-3","followers_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/followers","following_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/following{/other_user}","gists_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/subscriptions","organizations_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/orgs","repos_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/repos","events_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103-AY1819S1-W12-3/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CS2103-AY1819S1-W12-3/main","description":"3VIA","fork":true,"url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main","forks_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/forks","keys_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/teams","hooks_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/hooks","issue_events_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues/events{/number}","events_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/events","assignees_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/assignees{/user}","branches_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/branches{/branch}","tags_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/tags","blobs_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/statuses/{sha}","languages_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/languages","stargazers_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/stargazers","contributors_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/contributors","subscribers_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/subscribers","subscription_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/subscription","commits_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/contents/{+path}","compare_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/merges","archive_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/downloads","issues_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues{/number}","pulls_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls{/number}","milestones_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/milestones{/number}","notifications_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/labels{/name}","releases_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/releases{/id}","deployments_url":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/deployments","created_at":"2018-09-03T01:52:21Z","updated_at":"2018-09-18T03:16:25Z","pushed_at":"2018-09-18T03:42:47Z","git_url":"git://github.com/CS2103-AY1819S1-W12-3/main.git","ssh_url":"git@github.com:CS2103-AY1819S1-W12-3/main.git","clone_url":"https://github.com/CS2103-AY1819S1-W12-3/main.git","svn_url":"https://github.com/CS2103-AY1819S1-W12-3/main","homepage":"","size":9378,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/10"},"html":{"href":"https://github.com/CS2103-AY1819S1-W12-3/main/pull/10"},"issue":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues/10"},"comments":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/CS2103-AY1819S1-W12-3/main/statuses/e852bfc7c3f67c40a76ff7532cd8b00641cb9091"}},"author_association":"NONE"}}
{"actor":{"display_login":"hozongsien"}}