{"action":"closed","number":3596,"pull_request":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/3596","id":203527830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTI3ODMw","html_url":"https://github.com/matrix-org/synapse/pull/3596","diff_url":"https://github.com/matrix-org/synapse/pull/3596.diff","patch_url":"https://github.com/matrix-org/synapse/pull/3596.patch","issue_url":"https://api.github.com/repos/matrix-org/synapse/issues/3596","number":3596,"state":"closed","locked":false,"title":"Show M_NOT_FOUND when a profile could not be found.","user":{"login":"Half-Shot","id":2072976,"node_id":"MDQ6VXNlcjIwNzI5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2072976?v=4","gravatar_id":"","url":"https://api.github.com/users/Half-Shot","html_url":"https://github.com/Half-Shot","followers_url":"https://api.github.com/users/Half-Shot/followers","following_url":"https://api.github.com/users/Half-Shot/following{/other_user}","gists_url":"https://api.github.com/users/Half-Shot/gists{/gist_id}","starred_url":"https://api.github.com/users/Half-Shot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Half-Shot/subscriptions","organizations_url":"https://api.github.com/users/Half-Shot/orgs","repos_url":"https://api.github.com/users/Half-Shot/repos","events_url":"https://api.github.com/users/Half-Shot/events{/privacy}","received_events_url":"https://api.github.com/users/Half-Shot/received_events","type":"User","site_admin":false},"body":"This hopefully fixes #3585 by responding with ``M_NOT_FOUND`` when a profile could not be found locally or over federation. This will opt to fail safer by failing if either of the keys could not be found (which might not be correct behavior). ","created_at":"2018-07-24T13:31:58Z","updated_at":"2018-08-03T18:08:05Z","closed_at":"2018-08-03T18:08:05Z","merged_at":"2018-08-03T18:08:05Z","merge_commit_sha":"16d970189299c2ef83df4107e0cf1054cfb9da42","assignee":{"login":"erikjohnston","id":8428120,"node_id":"MDQ6VXNlcjg0MjgxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8428120?v=4","gravatar_id":"","url":"https://api.github.com/users/erikjohnston","html_url":"https://github.com/erikjohnston","followers_url":"https://api.github.com/users/erikjohnston/followers","following_url":"https://api.github.com/users/erikjohnston/following{/other_user}","gists_url":"https://api.github.com/users/erikjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/erikjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikjohnston/subscriptions","organizations_url":"https://api.github.com/users/erikjohnston/orgs","repos_url":"https://api.github.com/users/erikjohnston/repos","events_url":"https://api.github.com/users/erikjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/erikjohnston/received_events","type":"User","site_admin":false},"assignees":[{"login":"erikjohnston","id":8428120,"node_id":"MDQ6VXNlcjg0MjgxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8428120?v=4","gravatar_id":"","url":"https://api.github.com/users/erikjohnston","html_url":"https://github.com/erikjohnston","followers_url":"https://api.github.com/users/erikjohnston/followers","following_url":"https://api.github.com/users/erikjohnston/following{/other_user}","gists_url":"https://api.github.com/users/erikjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/erikjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikjohnston/subscriptions","organizations_url":"https://api.github.com/users/erikjohnston/orgs","repos_url":"https://api.github.com/users/erikjohnston/repos","events_url":"https://api.github.com/users/erikjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/erikjohnston/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/synapse/pulls/3596/commits","review_comments_url":"https://api.github.com/repos/matrix-org/synapse/pulls/3596/comments","review_comment_url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/synapse/issues/3596/comments","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/48f21646cd84674f9e9a67216ab39023ba092647","head":{"label":"Half-Shot:hs/profile_not_found_error","ref":"hs/profile_not_found_error","sha":"48f21646cd84674f9e9a67216ab39023ba092647","user":{"login":"Half-Shot","id":2072976,"node_id":"MDQ6VXNlcjIwNzI5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2072976?v=4","gravatar_id":"","url":"https://api.github.com/users/Half-Shot","html_url":"https://github.com/Half-Shot","followers_url":"https://api.github.com/users/Half-Shot/followers","following_url":"https://api.github.com/users/Half-Shot/following{/other_user}","gists_url":"https://api.github.com/users/Half-Shot/gists{/gist_id}","starred_url":"https://api.github.com/users/Half-Shot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Half-Shot/subscriptions","organizations_url":"https://api.github.com/users/Half-Shot/orgs","repos_url":"https://api.github.com/users/Half-Shot/repos","events_url":"https://api.github.com/users/Half-Shot/events{/privacy}","received_events_url":"https://api.github.com/users/Half-Shot/received_events","type":"User","site_admin":false},"repo":{"id":58357128,"node_id":"MDEwOlJlcG9zaXRvcnk1ODM1NzEyOA==","name":"synapse","full_name":"Half-Shot/synapse","owner":{"login":"Half-Shot","id":2072976,"node_id":"MDQ6VXNlcjIwNzI5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2072976?v=4","gravatar_id":"","url":"https://api.github.com/users/Half-Shot","html_url":"https://github.com/Half-Shot","followers_url":"https://api.github.com/users/Half-Shot/followers","following_url":"https://api.github.com/users/Half-Shot/following{/other_user}","gists_url":"https://api.github.com/users/Half-Shot/gists{/gist_id}","starred_url":"https://api.github.com/users/Half-Shot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Half-Shot/subscriptions","organizations_url":"https://api.github.com/users/Half-Shot/orgs","repos_url":"https://api.github.com/users/Half-Shot/repos","events_url":"https://api.github.com/users/Half-Shot/events{/privacy}","received_events_url":"https://api.github.com/users/Half-Shot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Half-Shot/synapse","description":"Synapse: Matrix reference homeserver","fork":true,"url":"https://api.github.com/repos/Half-Shot/synapse","forks_url":"https://api.github.com/repos/Half-Shot/synapse/forks","keys_url":"https://api.github.com/repos/Half-Shot/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Half-Shot/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Half-Shot/synapse/teams","hooks_url":"https://api.github.com/repos/Half-Shot/synapse/hooks","issue_events_url":"https://api.github.com/repos/Half-Shot/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/Half-Shot/synapse/events","assignees_url":"https://api.github.com/repos/Half-Shot/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/Half-Shot/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/Half-Shot/synapse/tags","blobs_url":"https://api.github.com/repos/Half-Shot/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Half-Shot/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Half-Shot/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/Half-Shot/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Half-Shot/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/Half-Shot/synapse/languages","stargazers_url":"https://api.github.com/repos/Half-Shot/synapse/stargazers","contributors_url":"https://api.github.com/repos/Half-Shot/synapse/contributors","subscribers_url":"https://api.github.com/repos/Half-Shot/synapse/subscribers","subscription_url":"https://api.github.com/repos/Half-Shot/synapse/subscription","commits_url":"https://api.github.com/repos/Half-Shot/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/Half-Shot/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/Half-Shot/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/Half-Shot/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/Half-Shot/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/Half-Shot/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Half-Shot/synapse/merges","archive_url":"https://api.github.com/repos/Half-Shot/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Half-Shot/synapse/downloads","issues_url":"https://api.github.com/repos/Half-Shot/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/Half-Shot/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/Half-Shot/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/Half-Shot/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Half-Shot/synapse/labels{/name}","releases_url":"https://api.github.com/repos/Half-Shot/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/Half-Shot/synapse/deployments","created_at":"2016-05-09T07:27:34Z","updated_at":"2016-05-09T07:27:36Z","pushed_at":"2018-08-03T11:35:00Z","git_url":"git://github.com/Half-Shot/synapse.git","ssh_url":"git@github.com:Half-Shot/synapse.git","clone_url":"https://github.com/Half-Shot/synapse.git","svn_url":"https://github.com/Half-Shot/synapse","homepage":"http://matrix.org","size":18411,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"cee1ae1b72bcbf5d173ca2f5eef5e947cc5e69f7","user":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":22844864,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg0NDg2NA==","name":"synapse","full_name":"matrix-org/synapse","owner":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/synapse","description":"Synapse: Matrix reference homeserver","fork":false,"url":"https://api.github.com/repos/matrix-org/synapse","forks_url":"https://api.github.com/repos/matrix-org/synapse/forks","keys_url":"https://api.github.com/repos/matrix-org/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/synapse/teams","hooks_url":"https://api.github.com/repos/matrix-org/synapse/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/synapse/events","assignees_url":"https://api.github.com/repos/matrix-org/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/synapse/tags","blobs_url":"https://api.github.com/repos/matrix-org/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/synapse/languages","stargazers_url":"https://api.github.com/repos/matrix-org/synapse/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/synapse/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/synapse/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/synapse/subscription","commits_url":"https://api.github.com/repos/matrix-org/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/synapse/merges","archive_url":"https://api.github.com/repos/matrix-org/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/synapse/downloads","issues_url":"https://api.github.com/repos/matrix-org/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/synapse/deployments","created_at":"2014-08-11T15:51:42Z","updated_at":"2018-08-03T17:41:45Z","pushed_at":"2018-08-03T18:08:05Z","git_url":"git://github.com/matrix-org/synapse.git","ssh_url":"git@github.com:matrix-org/synapse.git","clone_url":"https://github.com/matrix-org/synapse.git","svn_url":"https://github.com/matrix-org/synapse","homepage":"http://matrix.org","size":21246,"stargazers_count":3132,"watchers_count":3132,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":443,"mirror_url":null,"archived":false,"open_issues_count":943,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":443,"open_issues":943,"watchers":3132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3596"},"html":{"href":"https://github.com/matrix-org/synapse/pull/3596"},"issue":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/3596"},"comments":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/3596/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3596/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3596/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/synapse/statuses/48f21646cd84674f9e9a67216ab39023ba092647"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"richvdh","id":1389908,"node_id":"MDQ6VXNlcjEzODk5MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1389908?v=4","gravatar_id":"","url":"https://api.github.com/users/richvdh","html_url":"https://github.com/richvdh","followers_url":"https://api.github.com/users/richvdh/followers","following_url":"https://api.github.com/users/richvdh/following{/other_user}","gists_url":"https://api.github.com/users/richvdh/gists{/gist_id}","starred_url":"https://api.github.com/users/richvdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richvdh/subscriptions","organizations_url":"https://api.github.com/users/richvdh/orgs","repos_url":"https://api.github.com/users/richvdh/repos","events_url":"https://api.github.com/users/richvdh/events{/privacy}","received_events_url":"https://api.github.com/users/richvdh/received_events","type":"User","site_admin":false},"comments":4,"review_comments":6,"maintainer_can_modify":false,"commits":10,"additions":59,"deletions":31,"changed_files":2}}
{"actor":{"display_login":"richvdh"}}