{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cordova-windows/issues/270","repository_url":"https://api.github.com/repos/apache/cordova-windows","labels_url":"https://api.github.com/repos/apache/cordova-windows/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/apache/cordova-windows/issues/270/comments","events_url":"https://api.github.com/repos/apache/cordova-windows/issues/270/events","html_url":"https://github.com/apache/cordova-windows/issues/270","id":306510752,"number":270,"title":"description tag set to default instead of defined value - regression from 5.0.0","user":{"login":"mobidev111","id":7082367,"avatar_url":"https://avatars1.githubusercontent.com/u/7082367?v=4","gravatar_id":"","url":"https://api.github.com/users/mobidev111","html_url":"https://github.com/mobidev111","followers_url":"https://api.github.com/users/mobidev111/followers","following_url":"https://api.github.com/users/mobidev111/following{/other_user}","gists_url":"https://api.github.com/users/mobidev111/gists{/gist_id}","starred_url":"https://api.github.com/users/mobidev111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobidev111/subscriptions","organizations_url":"https://api.github.com/users/mobidev111/orgs","repos_url":"https://api.github.com/users/mobidev111/repos","events_url":"https://api.github.com/users/mobidev111/events{/privacy}","received_events_url":"https://api.github.com/users/mobidev111/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-19T15:26:37Z","updated_at":"2018-03-19T15:53:50Z","closed_at":null,"author_association":"NONE","body":"The `<description>` tag is set to a default value instead of the in the config.xml defined value. This is is a regression from cordova-windows 5.0.0.\r\n\r\n### situation\r\nmacOS host machine\r\ncordova-lib: 8.1.0\r\ncordova-windows 6.0.0\r\n\r\nA description is correctly set in config.xml:\r\n\r\nconfig.xml\r\n```\r\n  <description>\r\n    Demo\r\n  </description>\r\n```\r\n\r\nwhen running on a mac (or windows):\r\n```\r\ncordova prepare\r\n```\r\n\r\n### actual\r\n\r\nplatforms/windows/config.xml contains an additional description tag (with default content), in addition to the customized description tag\r\n```\r\n  <description>\r\n    A sample Apache Cordova application that responds to the deviceready event.\r\n  </description>\r\n  [...]\r\n  <description>\r\n    Demo\r\n  </description>\r\n```\r\n\r\nThe appxmanifest files contain only the default value instead of the set custom value:\r\n`platforms/windows/package.phone.appxmanifest`\r\n`platforms/windows/package.windows.appxmanifest`\r\n`platforms/windows/package.windows10.appxmanifest`\r\n```\r\n-        <Description>Demo</Description>\r\n+        <Description>A sample Apache Cordova application that responds to the deviceready event.</Description>\r\n```\r\n```\r\n-            <m2:VisualElements Description=\"Demo\" DisplayName=\"Demo\">\r\n+            <m2:VisualElements Description=\"A sample Apache Cordova application that responds to the deviceready event.\" DisplayName=\"Demo\">\r\n```\r\n### expected\r\n\r\nthe correctly set description tag gets propagated.\r\n\r\n### conditions\r\n\r\n* happens only with cordova-windows 6.0.0 - doesn't happen when using cordova-windows 5.0.0 with an otherwise unchanged setup\r\n\r\n* happens on mac & windows - however this a serious problem, as the generated code could be committed by mistake\r\n\r\n* probable cause: in 6.0.0 the `platforms/windows/cordova/defaults.xml` contains a default value for the desciption tag for the first time.\r\n\r\nThe wrong description value comes form the defaults.xml, however the `<name>` and `<author>` tags get processed correctly:\r\n`platforms/windows/cordova/defaults.xml`\r\n```\r\n    <description>\r\n        A sample Apache Cordova application that responds to the deviceready event.\r\n    </description>\r\n```"},"comment":{"url":"https://api.github.com/repos/apache/cordova-windows/issues/comments/374262476","html_url":"https://github.com/apache/cordova-windows/issues/270#issuecomment-374262476","issue_url":"https://api.github.com/repos/apache/cordova-windows/issues/270","id":374262476,"user":{"login":"mobidev111","id":7082367,"avatar_url":"https://avatars1.githubusercontent.com/u/7082367?v=4","gravatar_id":"","url":"https://api.github.com/users/mobidev111","html_url":"https://github.com/mobidev111","followers_url":"https://api.github.com/users/mobidev111/followers","following_url":"https://api.github.com/users/mobidev111/following{/other_user}","gists_url":"https://api.github.com/users/mobidev111/gists{/gist_id}","starred_url":"https://api.github.com/users/mobidev111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobidev111/subscriptions","organizations_url":"https://api.github.com/users/mobidev111/orgs","repos_url":"https://api.github.com/users/mobidev111/repos","events_url":"https://api.github.com/users/mobidev111/events{/privacy}","received_events_url":"https://api.github.com/users/mobidev111/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T15:53:50Z","updated_at":"2018-03-19T15:53:50Z","author_association":"NONE","body":"Just verified - happens as well with fresh project with `cordova create`.\r\n\r\nThe wrong content definitely comes from `platforms/windows/cordova/defaults.xml` - this files gets inconsistently handled - <description> gets the wrong treatment, but <name> and <author> tags work."}}
{"actor":{"display_login":"mobidev111"}}