{"action":"created","issue":{"url":"https://api.github.com/repos/Carthage/Carthage/issues/2478","repository_url":"https://api.github.com/repos/Carthage/Carthage","labels_url":"https://api.github.com/repos/Carthage/Carthage/issues/2478/labels{/name}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/2478/comments","events_url":"https://api.github.com/repos/Carthage/Carthage/issues/2478/events","html_url":"https://github.com/Carthage/Carthage/pull/2478","id":330471302,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDc0Njg4","number":2478,"title":"Proposed Behavior Change: Binary Only Downloads","user":{"login":"dmiluski","id":5083390,"node_id":"MDQ6VXNlcjUwODMzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5083390?v=4","gravatar_id":"","url":"https://api.github.com/users/dmiluski","html_url":"https://github.com/dmiluski","followers_url":"https://api.github.com/users/dmiluski/followers","following_url":"https://api.github.com/users/dmiluski/following{/other_user}","gists_url":"https://api.github.com/users/dmiluski/gists{/gist_id}","starred_url":"https://api.github.com/users/dmiluski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmiluski/subscriptions","organizations_url":"https://api.github.com/users/dmiluski/orgs","repos_url":"https://api.github.com/users/dmiluski/repos","events_url":"https://api.github.com/users/dmiluski/events{/privacy}","received_events_url":"https://api.github.com/users/dmiluski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-06-07T23:35:47Z","updated_at":"2018-07-13T00:45:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/2478","html_url":"https://github.com/Carthage/Carthage/pull/2478","diff_url":"https://github.com/Carthage/Carthage/pull/2478.diff","patch_url":"https://github.com/Carthage/Carthage/pull/2478.patch"},"body":"## 🔨 Issue :\r\n[Binaries are no longer pulled if using submodules](https://github.com/Carthage/Carthage/issues/2449)\r\n\r\nWhich occurred after this change: \r\nMove binary download to build process [#2342](https://github.com/Carthage/Carthage/pull/2342)\r\n\r\n## 📦 Use Case:\r\n```\r\n# Third Party\r\ngithub \"SwiftKickMobile/SwiftMessages\" ~> 4.0\r\n\r\n# Binary Only Third Party\r\nbinary \"https://raw.githubusercontent.com/dmiluski/CarthageSpecs/master/AppboyFramework.json\"\r\n```\r\nGiven this change, and use case:\r\n`carthage update --no-build --use-ssh --use-submodules`\r\n\r\nA users directly is not propagated with the binary-only dependency.\r\n\r\nA mix of submodule internal/external Carthage Dependencies, plus a few additional Carthage Binary only dependencies based on those developer's project distribution preferences. This allows us to pull in dependencies and only build required architectures while developing.\r\n\r\n## ❓ Why:\r\nGiven Binary only downloads has moved to building phase, build patterns which opt to not build do not get the benefit of being able to download BinaryOnly.\r\n\r\n## 💍 Proposal:\r\nProvide additional option to verbosely specify downloading binaries\r\n\r\n## 🗒  Options:\r\n`--download-binaries-and-skip-build`     // I felt this one could conflict with `--no-build`\r\n`--download-binaries-if-skip-build`         // Conveys we still want to download binaries even if build skipped\r\n`--download-binaries`                                // Simpler, but does this conflict with `--use-binaries`\r\n`--download-binary-only-dependencies` // Too Long?\r\n   others?\r\n\r\n## ❓ Questions:\r\nIs this a step completely separate from sync, build? ✅ \r\nWill this affect build? 🚫 \r\nIs this option naming confusing given the parameter: --use-binaries ❓\r\nWhen should this now happen: Checkout : Build : Other ❓ \r\n\r\n## Additional Comments:\r\nCurrent PR Diff does not accurately represent proposal yet\r\n\r\n## Initial Attempt: 🤧 \r\n[First Commit](https://github.com/Carthage/Carthage/pull/2478/commits)\r\nGoal:\r\nNot require --build in order to provide a buildProducer. Instead, inspect --build within buildProducer to make the determination.\r\n\r\nProblem\r\nPer @ikesyo \r\n```That’s because the build option key is already defined and consumed by UpdateCommand.Options so BuildOptions would not get the option and the default value will be used.```\r\n\r\nOption:\r\n- Pass correctly vs currying (didn't understand this part of parsing)\r\n- move forward with build approach, or use additional flag"},"comment":{"url":"https://api.github.com/repos/Carthage/Carthage/issues/comments/404692399","html_url":"https://github.com/Carthage/Carthage/pull/2478#issuecomment-404692399","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/2478","id":404692399,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDY5MjM5OQ==","user":{"login":"stale[bot]","id":26384082,"node_id":"MDM6Qm90MjYzODQwODI=","avatar_url":"https://avatars3.githubusercontent.com/in/1724?v=4","gravatar_id":"","url":"https://api.github.com/users/stale%5Bbot%5D","html_url":"https://github.com/apps/stale","followers_url":"https://api.github.com/users/stale%5Bbot%5D/followers","following_url":"https://api.github.com/users/stale%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/stale%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/stale%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stale%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/stale%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/stale%5Bbot%5D/repos","events_url":"https://api.github.com/users/stale%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/stale%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-07-13T00:45:18Z","updated_at":"2018-07-13T00:45:18Z","author_association":"NONE","body":"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"}}
{"actor":{"display_login":"stale"}}