{"action":"created","issue":{"url":"https://api.github.com/repos/wowdev/WoWDBDefs/issues/27","repository_url":"https://api.github.com/repos/wowdev/WoWDBDefs","labels_url":"https://api.github.com/repos/wowdev/WoWDBDefs/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/wowdev/WoWDBDefs/issues/27/comments","events_url":"https://api.github.com/repos/wowdev/WoWDBDefs/issues/27/events","html_url":"https://github.com/wowdev/WoWDBDefs/pull/27","id":330979566,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODMyODYx","number":27,"title":"definitions: pre-wod","user":{"login":"barncastle","id":1619104,"node_id":"MDQ6VXNlcjE2MTkxMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1619104?v=4","gravatar_id":"","url":"https://api.github.com/users/barncastle","html_url":"https://github.com/barncastle","followers_url":"https://api.github.com/users/barncastle/followers","following_url":"https://api.github.com/users/barncastle/following{/other_user}","gists_url":"https://api.github.com/users/barncastle/gists{/gist_id}","starred_url":"https://api.github.com/users/barncastle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barncastle/subscriptions","organizations_url":"https://api.github.com/users/barncastle/orgs","repos_url":"https://api.github.com/users/barncastle/repos","events_url":"https://api.github.com/users/barncastle/events{/privacy}","received_events_url":"https://api.github.com/users/barncastle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-10T15:50:06Z","updated_at":"2018-07-12T11:04:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wowdev/WoWDBDefs/pulls/27","html_url":"https://github.com/wowdev/WoWDBDefs/pull/27","diff_url":"https://github.com/wowdev/WoWDBDefs/pull/27.diff","patch_url":"https://github.com/wowdev/WoWDBDefs/pull/27.patch"},"body":"My recent labors, can't remember where I got up to as I've been waning in motivation (and sobriety) recently but everything is mapped. Definitely, definitely, 110% needs checking!\r\n\r\nProblems/Notes:\r\n- I've standardised names to camelcase except acronyms e.g. `NPCDisplayID`\r\n- I've used ranges (sorry!)\r\n  - Ranges are major.minor.build ordered\r\n  - Ranges are loose, as in, if I've a missing build and the surrounding builds are the same I've just bundled them in (bad!) - so far I've not seen a revert of a live DB build so might not be so bad...\r\n - Cata (14333)+ uses meta (except the whole signedness debacle)\r\n- IDs, Flags and Masks are `uint` everything else *should* be `int`\r\n - Everything uses the known names, mapped from either comparing known builds or looking at cores\r\n   - Core fields are done by inferring known names e.g. `FactionTemplate` Trinity = `EnemyMask` ≈ Known = `EnemyGroup`\r\n  - I couldn't always tell when a field was renamed or an unrolled array became an array so correctness won't be Blizz-like but, at the end of the day, it all means and parses the same\r\n- I've only done the super obvious foreign keys\r\n\r\nIt's probably a load of crap but you might be able to salvage something from it"},"comment":{"url":"https://api.github.com/repos/wowdev/WoWDBDefs/issues/comments/404475585","html_url":"https://github.com/wowdev/WoWDBDefs/pull/27#issuecomment-404475585","issue_url":"https://api.github.com/repos/wowdev/WoWDBDefs/issues/27","id":404475585,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDQ3NTU4NQ==","user":{"login":"barncastle","id":1619104,"node_id":"MDQ6VXNlcjE2MTkxMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1619104?v=4","gravatar_id":"","url":"https://api.github.com/users/barncastle","html_url":"https://github.com/barncastle","followers_url":"https://api.github.com/users/barncastle/followers","following_url":"https://api.github.com/users/barncastle/following{/other_user}","gists_url":"https://api.github.com/users/barncastle/gists{/gist_id}","starred_url":"https://api.github.com/users/barncastle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barncastle/subscriptions","organizations_url":"https://api.github.com/users/barncastle/orgs","repos_url":"https://api.github.com/users/barncastle/repos","events_url":"https://api.github.com/users/barncastle/events{/privacy}","received_events_url":"https://api.github.com/users/barncastle/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T11:04:40Z","updated_at":"2018-07-12T11:04:40Z","author_association":"CONTRIBUTOR","body":"e3b941d should resolved the old vs new uint standard.\r\n\r\nRanges are an ass, without them it's nigh impossible to read but with them you're encapsulating unverified/unreleased builds. I opted for the former to make defining defs easier. I can switch ranges to builds pretty easily, let me know.\r\n\r\n------\r\n\r\n - Sorry, I thought I'd caught all the _lang fields, I'll do another pass when I get some time at the weekend.\r\n - I standardised names, again, to make visually diffing defs easier. I can remap them to what we have currently, although name standardisation should probably be brought up in the issue if it hasn't already."}}
{"actor":{"display_login":"barncastle"}}