{"action":"closed","number":2796,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2796","id":171823210,"html_url":"https://github.com/dcos/dcos-ui/pull/2796","diff_url":"https://github.com/dcos/dcos-ui/pull/2796.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/2796.patch","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2796","number":2796,"state":"closed","locked":false,"title":"Improve Jenkins pipeline","user":{"login":"bstavroulakis","id":180432,"avatar_url":"https://avatars0.githubusercontent.com/u/180432?v=4","gravatar_id":"","url":"https://api.github.com/users/bstavroulakis","html_url":"https://github.com/bstavroulakis","followers_url":"https://api.github.com/users/bstavroulakis/followers","following_url":"https://api.github.com/users/bstavroulakis/following{/other_user}","gists_url":"https://api.github.com/users/bstavroulakis/gists{/gist_id}","starred_url":"https://api.github.com/users/bstavroulakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstavroulakis/subscriptions","organizations_url":"https://api.github.com/users/bstavroulakis/orgs","repos_url":"https://api.github.com/users/bstavroulakis/repos","events_url":"https://api.github.com/users/bstavroulakis/events{/privacy}","received_events_url":"https://api.github.com/users/bstavroulakis/received_events","type":"User","site_admin":false},"body":"🎉 🎈 \r\n\r\n**Description**:\r\nThis PR contains the long-awaited Jenkins release and bump process we've been working on for the past few weeks. To do this we've **added two stages** to the Jenkinsfile. Both of these stages will only run when the branch is master (this will prevent these stages from running on PRs).\r\n\r\n1. \"Upload Build\" stage: uploading the built dcos-ui artifact to an S3 bucket.\r\n2. \"Update Github\" stage: there are two paths here depending on the presence of a tag on the current commit. If there **is a tag**, then a new PR is opened on `dcos/dcos`, and the dcos-ui changelog between this tag and the previous tag is generated and formatted into the PR body. If there is **no tag**, then we will commit and push onto our [mesosphere:dcos-ui/latest](https://github.com/dcos/dcos/pull/2506) with the latest dcos-ui artifact.\r\n\r\nMore on the no tag case: The benefit of always updating the dcos-ui/latest PR is we will always have a cluster with our latest dcos-ui master. This will be really nice for the design team and other engineering teams to quickly see our changes.\r\n\r\nMore on the tag case: To be clear, this happens when there is a tag on the current commit (it checks this with `git tag -l --contains HEAD`). The new release process process will be much less cumbersome for our team. Now the whole release process will be triggered by pushing a release tag to dcos-ui. Jenkins will listen for new tag pushes (that match the release tag format ex: v1.11.0-rc.16). It will then start the Jenkins job, build, upload to S3, then generate the changelog, and open a PR for you against dcos/dcos.\r\n\r\n**Testing**:\r\nIf you comprehended the above, it should make sense that there are two cases to test - with a tag, and without a tag.\r\n\r\nTesting without a tag is easy. Go to Jenkins dashboard. Click on Frontend CI Jobs -> DCOS UI OSS Release Builder -> bill/feat/dcos-ui-cd branch -> click Build Now in the top left. This will trigger a job. We expect this job to update the dcos-ui/latest PR.\r\n\r\nTesting with a tag is a bit more difficult. First, checkout this branch. Then push the tag `test-dcos-ui-cd2`. Then navigate toe Jenkins dashboard. Click on Frontend CI Jobs -> DCOS UI OSS Release Builder -> test-dcos-ui-cd2 -> click Build Now in the top left. This will trigger a job (the same job as before). But the different now is it will take the different update-github path. Now we expect this job to open a new PR against dcos/dcos. *Note*: if existing branch on mesosphere/dcos it will fail. Make sure to delete before testing this.\r\n\r\n**Checklist**\r\n- [ ] Did you add a JIRA issue in a commit message or as part of the branch name?\r\n- [ ] Did you add new unit tests?\r\n- [ ] Did you add new integration tests?\r\n- [ ] If this is a regression, did you write a test to catch this in the future?\r\n\r\n<!-- More info can be found by clicking the \"guidelines for contributing\" link above. -->\r\n","created_at":"2018-02-28T00:20:31Z","updated_at":"2018-03-21T22:27:16Z","closed_at":"2018-03-21T22:27:16Z","merged_at":"2018-03-21T22:27:16Z","merge_commit_sha":"7c6b5a96d2a4573b3ee9188b54337b4b7381060a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":540883661,"url":"https://api.github.com/repos/dcos/dcos-ui/labels/high%20priority","name":"high priority","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2796/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2796/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2796/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/91fd9f9b60718a6057edafda47f2d190adcd1837","head":{"label":"dcos:bill/feat/dcos-ui-cd","ref":"bill/feat/dcos-ui-cd","sha":"91fd9f9b60718a6057edafda47f2d190adcd1837","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2018-03-21T20:57:03Z","pushed_at":"2018-03-21T22:27:16Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":"https://dcos.io/","size":43195,"stargazers_count":171,"watchers_count":171,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":64,"open_issues":13,"watchers":171,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"f2935c97f61a021ff8b066ebd3e9c577a5586118","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2018-03-21T20:57:03Z","pushed_at":"2018-03-21T22:27:16Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":"https://dcos.io/","size":43195,"stargazers_count":171,"watchers_count":171,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":64,"open_issues":13,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/2796"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/2796"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/2796"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/2796/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/2796/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/2796/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-ui/statuses/91fd9f9b60718a6057edafda47f2d190adcd1837"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bstavroulakis","id":180432,"avatar_url":"https://avatars0.githubusercontent.com/u/180432?v=4","gravatar_id":"","url":"https://api.github.com/users/bstavroulakis","html_url":"https://github.com/bstavroulakis","followers_url":"https://api.github.com/users/bstavroulakis/followers","following_url":"https://api.github.com/users/bstavroulakis/following{/other_user}","gists_url":"https://api.github.com/users/bstavroulakis/gists{/gist_id}","starred_url":"https://api.github.com/users/bstavroulakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstavroulakis/subscriptions","organizations_url":"https://api.github.com/users/bstavroulakis/orgs","repos_url":"https://api.github.com/users/bstavroulakis/repos","events_url":"https://api.github.com/users/bstavroulakis/events{/privacy}","received_events_url":"https://api.github.com/users/bstavroulakis/received_events","type":"User","site_admin":false},"comments":9,"review_comments":115,"maintainer_can_modify":false,"commits":1,"additions":156,"deletions":114,"changed_files":5}}
{"actor":{"display_login":"bstavroulakis"}}