{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/comments/197198314","pull_request_review_id":130896061,"id":197198314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzE5ODMxNA==","diff_hunk":"@@ -31,9 +33,11 @@ impl<'a> fmt::Debug for StrWrap<'a> {\n }\n ```\n \n-In edition 2018, you can instead write:\n+In Rust 2018, you can instead write:\n \n ```rust\n+// Rust 2018\n+\n #![feature(rust_2018_preview)]","path":"src/2018/transitioning/ownership-and-lifetimes/anonymous-lifetime.md","position":37,"original_position":37,"commit_id":"9b60fed99157108c1f441a372f9092b57c3b170b","original_commit_id":"9b60fed99157108c1f441a372f9092b57c3b170b","user":{"login":"Centril","id":855702,"node_id":"MDQ6VXNlcjg1NTcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/855702?v=4","gravatar_id":"","url":"https://api.github.com/users/Centril","html_url":"https://github.com/Centril","followers_url":"https://api.github.com/users/Centril/followers","following_url":"https://api.github.com/users/Centril/following{/other_user}","gists_url":"https://api.github.com/users/Centril/gists{/gist_id}","starred_url":"https://api.github.com/users/Centril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Centril/subscriptions","organizations_url":"https://api.github.com/users/Centril/orgs","repos_url":"https://api.github.com/users/Centril/repos","events_url":"https://api.github.com/users/Centril/events{/privacy}","received_events_url":"https://api.github.com/users/Centril/received_events","type":"User","site_admin":false},"body":"The comment and the feature gate need to be swapped lexically to make this pass the test, at least for now.","created_at":"2018-06-21T16:29:25Z","updated_at":"2018-06-21T16:29:59Z","html_url":"https://github.com/rust-lang-nursery/edition-guide/pull/23#discussion_r197198314","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/23","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/comments/197198314"},"html":{"href":"https://github.com/rust-lang-nursery/edition-guide/pull/23#discussion_r197198314"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/23","id":196493960,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDkzOTYw","html_url":"https://github.com/rust-lang-nursery/edition-guide/pull/23","diff_url":"https://github.com/rust-lang-nursery/edition-guide/pull/23.diff","patch_url":"https://github.com/rust-lang-nursery/edition-guide/pull/23.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/issues/23","number":23,"state":"open","locked":false,"title":"Lifetime section edits","user":{"login":"aturon","id":709807,"node_id":"MDQ6VXNlcjcwOTgwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"body":"A few changes here:\r\n\r\n- Rewrote the in-band lifetime section, which was incorrect (seemed to be based on the initial RFC rather than what was actually merged/implemented)\r\n\r\n- Removed references to particular compiler versions. I intend to send a separate PR introducing a table of all the 2018 features, their stabilization status, and links to tracking issues where appropriate.\r\n\r\n- Assorted minor tweaks/consistency issues.\r\n\r\nI didn't touch slice patterns yet, because I think it should be moved to a separate section (it's not particularly connected to ownership or lifetimes).","created_at":"2018-06-21T15:36:57Z","updated_at":"2018-06-21T16:29:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa456316e47e22703f56affcf2b69f03a05ef5f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/23/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/23/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/issues/23/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/statuses/9b60fed99157108c1f441a372f9092b57c3b170b","head":{"label":"aturon:lifetime-edits","ref":"lifetime-edits","sha":"9b60fed99157108c1f441a372f9092b57c3b170b","user":{"login":"aturon","id":709807,"node_id":"MDQ6VXNlcjcwOTgwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"repo":{"id":136507727,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MDc3Mjc=","name":"edition-guide","full_name":"aturon/edition-guide","owner":{"login":"aturon","id":709807,"node_id":"MDQ6VXNlcjcwOTgwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aturon/edition-guide","description":"A guide to changes between various editions of Rust","fork":true,"url":"https://api.github.com/repos/aturon/edition-guide","forks_url":"https://api.github.com/repos/aturon/edition-guide/forks","keys_url":"https://api.github.com/repos/aturon/edition-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aturon/edition-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aturon/edition-guide/teams","hooks_url":"https://api.github.com/repos/aturon/edition-guide/hooks","issue_events_url":"https://api.github.com/repos/aturon/edition-guide/issues/events{/number}","events_url":"https://api.github.com/repos/aturon/edition-guide/events","assignees_url":"https://api.github.com/repos/aturon/edition-guide/assignees{/user}","branches_url":"https://api.github.com/repos/aturon/edition-guide/branches{/branch}","tags_url":"https://api.github.com/repos/aturon/edition-guide/tags","blobs_url":"https://api.github.com/repos/aturon/edition-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aturon/edition-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aturon/edition-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/aturon/edition-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aturon/edition-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/aturon/edition-guide/languages","stargazers_url":"https://api.github.com/repos/aturon/edition-guide/stargazers","contributors_url":"https://api.github.com/repos/aturon/edition-guide/contributors","subscribers_url":"https://api.github.com/repos/aturon/edition-guide/subscribers","subscription_url":"https://api.github.com/repos/aturon/edition-guide/subscription","commits_url":"https://api.github.com/repos/aturon/edition-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/aturon/edition-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/aturon/edition-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/aturon/edition-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/aturon/edition-guide/contents/{+path}","compare_url":"https://api.github.com/repos/aturon/edition-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aturon/edition-guide/merges","archive_url":"https://api.github.com/repos/aturon/edition-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aturon/edition-guide/downloads","issues_url":"https://api.github.com/repos/aturon/edition-guide/issues{/number}","pulls_url":"https://api.github.com/repos/aturon/edition-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/aturon/edition-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/aturon/edition-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aturon/edition-guide/labels{/name}","releases_url":"https://api.github.com/repos/aturon/edition-guide/releases{/id}","deployments_url":"https://api.github.com/repos/aturon/edition-guide/deployments","created_at":"2018-06-07T17:04:03Z","updated_at":"2018-06-07T17:04:05Z","pushed_at":"2018-06-21T15:46:56Z","git_url":"git://github.com/aturon/edition-guide.git","ssh_url":"git@github.com:aturon/edition-guide.git","clone_url":"https://github.com/aturon/edition-guide.git","svn_url":"https://github.com/aturon/edition-guide","homepage":"https://rust-lang-nursery.github.io/edition-guide/","size":1385,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"5d837492bb570aac9f81597329f375eccccfbf3a","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":124572413,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ1NzI0MTM=","name":"edition-guide","full_name":"rust-lang-nursery/edition-guide","owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/edition-guide","description":"A guide to changes between various editions of Rust","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/edition-guide","forks_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/edition-guide/deployments","created_at":"2018-03-09T17:29:52Z","updated_at":"2018-06-21T15:56:09Z","pushed_at":"2018-06-21T15:57:35Z","git_url":"git://github.com/rust-lang-nursery/edition-guide.git","ssh_url":"git@github.com:rust-lang-nursery/edition-guide.git","clone_url":"https://github.com/rust-lang-nursery/edition-guide.git","svn_url":"https://github.com/rust-lang-nursery/edition-guide","homepage":"https://rust-lang-nursery.github.io/edition-guide/","size":1490,"stargazers_count":21,"watchers_count":21,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":4,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/23"},"html":{"href":"https://github.com/rust-lang-nursery/edition-guide/pull/23"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/issues/23"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/edition-guide/statuses/9b60fed99157108c1f441a372f9092b57c3b170b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Centril"}}