{"action":"created","comment":{"url":"https://api.github.com/repos/AmyAssist/Amy/pulls/comments/200963913","pull_request_review_id":135371543,"id":200963913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDk2MzkxMw==","diff_hunk":"@@ -128,26 +157,32 @@ public synchronized void loadPlugins() {\n \t\tthis.loaded = true;\n \t}\n \n-\tprivate boolean tryLoadPlugin(File pluginDir, String pluginID) {\n+\tprivate boolean tryLoadPlugin(Path pluginDir, String pluginID) {\n \t\tthis.logger.debug(\"try load plugin {}\", pluginID);\n-\t\tFile p = new File(pluginDir, pluginID);\n+\t\tPath p = pluginDir.resolve(pluginID);\n \n-\t\tif (!p.exists()) {\n-\t\t\tthis.logger.warn(\"The plugin {} does not exist in the plugin directory.\", p.getName());\n+\t\tif (!Files.exists(p)) {\n+\t\t\tthis.logger.warn(\"The plugin {} does not exist in the plugin directory.\", p);\n \t\t\treturn false;\n \t\t}\n-\t\tFile target = new File(p, \"target\");\n-\t\tif (!target.exists()) {\n-\t\t\tthis.logger.warn(\"Plugin {} has no target directory. Did you run mvn install?\", p.getName());\n+\t\tPath target = p.resolve(\"target\");\n+\t\tif (!Files.exists(target)) {\n+\t\t\tthis.logger.warn(\"Plugin {} has no target directory. Did you run mvn install?\", p);\n \t\t\treturn false;\n \t\t}\n \n-\t\tfor (File child : target.listFiles()) {\n-\t\t\tif (child.getName().endsWith(\"with-dependencies.jar\")) {\n-\t\t\t\treturn this.pluginLoader.loadPlugin(child.toURI());\n+\t\ttry {\n+\t\t\tOptional<Path> jar = Files.list(target)","path":"core/src/main/java/de/unistuttgart/iaas/amyassist/amy/core/pluginloader/PluginManagerService.java","position":166,"original_position":166,"commit_id":"d704e29aaac998c240b07a6b60b7f63fd95c4a91","original_commit_id":"d704e29aaac998c240b07a6b60b7f63fd95c4a91","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"![Bug](https://sonarsource.github.io/sonar-github/bug.png 'Bug') Bug: Use try-with-resources or close this \"Stream\" in a \"finally\" clause. ([squid:S2095](https://sonarcloud.io/organizations/amyassist/rules#rule_key=squid%3AS2095))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=de.unistuttgart.iaas.amyassist%3Aamy&pullRequest=152&issues=AWR-u5OXMt9UOhrwK9g8&open=AWR-u5OXMt9UOhrwK9g8)\n\n[ISSUE_KEY]: AWR-u5OXMt9UOhrwK9g8","created_at":"2018-07-09T11:09:49Z","updated_at":"2018-07-09T11:09:50Z","html_url":"https://github.com/AmyAssist/Amy/pull/152#discussion_r200963913","pull_request_url":"https://api.github.com/repos/AmyAssist/Amy/pulls/152","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AmyAssist/Amy/pulls/comments/200963913"},"html":{"href":"https://github.com/AmyAssist/Amy/pull/152#discussion_r200963913"},"pull_request":{"href":"https://api.github.com/repos/AmyAssist/Amy/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/AmyAssist/Amy/pulls/152","id":199782076,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NzgyMDc2","html_url":"https://github.com/AmyAssist/Amy/pull/152","diff_url":"https://github.com/AmyAssist/Amy/pull/152.diff","patch_url":"https://github.com/AmyAssist/Amy/pull/152.patch","issue_url":"https://api.github.com/repos/AmyAssist/Amy/issues/152","number":152,"state":"open","locked":false,"title":"Dockerize (Part 1)","user":{"login":"neumantm","id":27770422,"node_id":"MDQ6VXNlcjI3NzcwNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/27770422?v=4","gravatar_id":"","url":"https://api.github.com/users/neumantm","html_url":"https://github.com/neumantm","followers_url":"https://api.github.com/users/neumantm/followers","following_url":"https://api.github.com/users/neumantm/following{/other_user}","gists_url":"https://api.github.com/users/neumantm/gists{/gist_id}","starred_url":"https://api.github.com/users/neumantm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neumantm/subscriptions","organizations_url":"https://api.github.com/users/neumantm/orgs","repos_url":"https://api.github.com/users/neumantm/repos","events_url":"https://api.github.com/users/neumantm/events{/privacy}","received_events_url":"https://api.github.com/users/neumantm/received_events","type":"User","site_admin":false},"body":"Adds Dockerfile and does the first necesarry changes to be able to build a docker container.","created_at":"2018-07-06T15:39:15Z","updated_at":"2018-07-09T11:09:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3096c6cc593ec4d9ae9c11a54dd4fe0b10b78eae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AmyAssist/Amy/pulls/152/commits","review_comments_url":"https://api.github.com/repos/AmyAssist/Amy/pulls/152/comments","review_comment_url":"https://api.github.com/repos/AmyAssist/Amy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AmyAssist/Amy/issues/152/comments","statuses_url":"https://api.github.com/repos/AmyAssist/Amy/statuses/d704e29aaac998c240b07a6b60b7f63fd95c4a91","head":{"label":"AmyAssist:dockerize","ref":"dockerize","sha":"d704e29aaac998c240b07a6b60b7f63fd95c4a91","user":{"login":"AmyAssist","id":39340355,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzQwMzU1","avatar_url":"https://avatars0.githubusercontent.com/u/39340355?v=4","gravatar_id":"","url":"https://api.github.com/users/AmyAssist","html_url":"https://github.com/AmyAssist","followers_url":"https://api.github.com/users/AmyAssist/followers","following_url":"https://api.github.com/users/AmyAssist/following{/other_user}","gists_url":"https://api.github.com/users/AmyAssist/gists{/gist_id}","starred_url":"https://api.github.com/users/AmyAssist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmyAssist/subscriptions","organizations_url":"https://api.github.com/users/AmyAssist/orgs","repos_url":"https://api.github.com/users/AmyAssist/repos","events_url":"https://api.github.com/users/AmyAssist/events{/privacy}","received_events_url":"https://api.github.com/users/AmyAssist/received_events","type":"Organization","site_admin":false},"repo":{"id":134390462,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzOTA0NjI=","name":"Amy","full_name":"AmyAssist/Amy","owner":{"login":"AmyAssist","id":39340355,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzQwMzU1","avatar_url":"https://avatars0.githubusercontent.com/u/39340355?v=4","gravatar_id":"","url":"https://api.github.com/users/AmyAssist","html_url":"https://github.com/AmyAssist","followers_url":"https://api.github.com/users/AmyAssist/followers","following_url":"https://api.github.com/users/AmyAssist/following{/other_user}","gists_url":"https://api.github.com/users/AmyAssist/gists{/gist_id}","starred_url":"https://api.github.com/users/AmyAssist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmyAssist/subscriptions","organizations_url":"https://api.github.com/users/AmyAssist/orgs","repos_url":"https://api.github.com/users/AmyAssist/repos","events_url":"https://api.github.com/users/AmyAssist/events{/privacy}","received_events_url":"https://api.github.com/users/AmyAssist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AmyAssist/Amy","description":"Personal Assistance System","fork":false,"url":"https://api.github.com/repos/AmyAssist/Amy","forks_url":"https://api.github.com/repos/AmyAssist/Amy/forks","keys_url":"https://api.github.com/repos/AmyAssist/Amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AmyAssist/Amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AmyAssist/Amy/teams","hooks_url":"https://api.github.com/repos/AmyAssist/Amy/hooks","issue_events_url":"https://api.github.com/repos/AmyAssist/Amy/issues/events{/number}","events_url":"https://api.github.com/repos/AmyAssist/Amy/events","assignees_url":"https://api.github.com/repos/AmyAssist/Amy/assignees{/user}","branches_url":"https://api.github.com/repos/AmyAssist/Amy/branches{/branch}","tags_url":"https://api.github.com/repos/AmyAssist/Amy/tags","blobs_url":"https://api.github.com/repos/AmyAssist/Amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AmyAssist/Amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AmyAssist/Amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/AmyAssist/Amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AmyAssist/Amy/statuses/{sha}","languages_url":"https://api.github.com/repos/AmyAssist/Amy/languages","stargazers_url":"https://api.github.com/repos/AmyAssist/Amy/stargazers","contributors_url":"https://api.github.com/repos/AmyAssist/Amy/contributors","subscribers_url":"https://api.github.com/repos/AmyAssist/Amy/subscribers","subscription_url":"https://api.github.com/repos/AmyAssist/Amy/subscription","commits_url":"https://api.github.com/repos/AmyAssist/Amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/AmyAssist/Amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/AmyAssist/Amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/AmyAssist/Amy/issues/comments{/number}","contents_url":"https://api.github.com/repos/AmyAssist/Amy/contents/{+path}","compare_url":"https://api.github.com/repos/AmyAssist/Amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AmyAssist/Amy/merges","archive_url":"https://api.github.com/repos/AmyAssist/Amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AmyAssist/Amy/downloads","issues_url":"https://api.github.com/repos/AmyAssist/Amy/issues{/number}","pulls_url":"https://api.github.com/repos/AmyAssist/Amy/pulls{/number}","milestones_url":"https://api.github.com/repos/AmyAssist/Amy/milestones{/number}","notifications_url":"https://api.github.com/repos/AmyAssist/Amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AmyAssist/Amy/labels{/name}","releases_url":"https://api.github.com/repos/AmyAssist/Amy/releases{/id}","deployments_url":"https://api.github.com/repos/AmyAssist/Amy/deployments","created_at":"2018-05-22T09:16:34Z","updated_at":"2018-07-09T10:38:33Z","pushed_at":"2018-07-09T11:05:52Z","git_url":"git://github.com/AmyAssist/Amy.git","ssh_url":"git@github.com:AmyAssist/Amy.git","clone_url":"https://github.com/AmyAssist/Amy.git","svn_url":"https://github.com/AmyAssist/Amy","homepage":null,"size":3173,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":28,"watchers":6,"default_branch":"dev"}},"base":{"label":"AmyAssist:dev","ref":"dev","sha":"46d77694103de611362198e2a2b45ff87d38fd5f","user":{"login":"AmyAssist","id":39340355,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzQwMzU1","avatar_url":"https://avatars0.githubusercontent.com/u/39340355?v=4","gravatar_id":"","url":"https://api.github.com/users/AmyAssist","html_url":"https://github.com/AmyAssist","followers_url":"https://api.github.com/users/AmyAssist/followers","following_url":"https://api.github.com/users/AmyAssist/following{/other_user}","gists_url":"https://api.github.com/users/AmyAssist/gists{/gist_id}","starred_url":"https://api.github.com/users/AmyAssist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmyAssist/subscriptions","organizations_url":"https://api.github.com/users/AmyAssist/orgs","repos_url":"https://api.github.com/users/AmyAssist/repos","events_url":"https://api.github.com/users/AmyAssist/events{/privacy}","received_events_url":"https://api.github.com/users/AmyAssist/received_events","type":"Organization","site_admin":false},"repo":{"id":134390462,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzOTA0NjI=","name":"Amy","full_name":"AmyAssist/Amy","owner":{"login":"AmyAssist","id":39340355,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzQwMzU1","avatar_url":"https://avatars0.githubusercontent.com/u/39340355?v=4","gravatar_id":"","url":"https://api.github.com/users/AmyAssist","html_url":"https://github.com/AmyAssist","followers_url":"https://api.github.com/users/AmyAssist/followers","following_url":"https://api.github.com/users/AmyAssist/following{/other_user}","gists_url":"https://api.github.com/users/AmyAssist/gists{/gist_id}","starred_url":"https://api.github.com/users/AmyAssist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmyAssist/subscriptions","organizations_url":"https://api.github.com/users/AmyAssist/orgs","repos_url":"https://api.github.com/users/AmyAssist/repos","events_url":"https://api.github.com/users/AmyAssist/events{/privacy}","received_events_url":"https://api.github.com/users/AmyAssist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AmyAssist/Amy","description":"Personal Assistance System","fork":false,"url":"https://api.github.com/repos/AmyAssist/Amy","forks_url":"https://api.github.com/repos/AmyAssist/Amy/forks","keys_url":"https://api.github.com/repos/AmyAssist/Amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AmyAssist/Amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AmyAssist/Amy/teams","hooks_url":"https://api.github.com/repos/AmyAssist/Amy/hooks","issue_events_url":"https://api.github.com/repos/AmyAssist/Amy/issues/events{/number}","events_url":"https://api.github.com/repos/AmyAssist/Amy/events","assignees_url":"https://api.github.com/repos/AmyAssist/Amy/assignees{/user}","branches_url":"https://api.github.com/repos/AmyAssist/Amy/branches{/branch}","tags_url":"https://api.github.com/repos/AmyAssist/Amy/tags","blobs_url":"https://api.github.com/repos/AmyAssist/Amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AmyAssist/Amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AmyAssist/Amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/AmyAssist/Amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AmyAssist/Amy/statuses/{sha}","languages_url":"https://api.github.com/repos/AmyAssist/Amy/languages","stargazers_url":"https://api.github.com/repos/AmyAssist/Amy/stargazers","contributors_url":"https://api.github.com/repos/AmyAssist/Amy/contributors","subscribers_url":"https://api.github.com/repos/AmyAssist/Amy/subscribers","subscription_url":"https://api.github.com/repos/AmyAssist/Amy/subscription","commits_url":"https://api.github.com/repos/AmyAssist/Amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/AmyAssist/Amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/AmyAssist/Amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/AmyAssist/Amy/issues/comments{/number}","contents_url":"https://api.github.com/repos/AmyAssist/Amy/contents/{+path}","compare_url":"https://api.github.com/repos/AmyAssist/Amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AmyAssist/Amy/merges","archive_url":"https://api.github.com/repos/AmyAssist/Amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AmyAssist/Amy/downloads","issues_url":"https://api.github.com/repos/AmyAssist/Amy/issues{/number}","pulls_url":"https://api.github.com/repos/AmyAssist/Amy/pulls{/number}","milestones_url":"https://api.github.com/repos/AmyAssist/Amy/milestones{/number}","notifications_url":"https://api.github.com/repos/AmyAssist/Amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AmyAssist/Amy/labels{/name}","releases_url":"https://api.github.com/repos/AmyAssist/Amy/releases{/id}","deployments_url":"https://api.github.com/repos/AmyAssist/Amy/deployments","created_at":"2018-05-22T09:16:34Z","updated_at":"2018-07-09T10:38:33Z","pushed_at":"2018-07-09T11:05:52Z","git_url":"git://github.com/AmyAssist/Amy.git","ssh_url":"git@github.com:AmyAssist/Amy.git","clone_url":"https://github.com/AmyAssist/Amy.git","svn_url":"https://github.com/AmyAssist/Amy","homepage":null,"size":3173,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":28,"watchers":6,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AmyAssist/Amy/pulls/152"},"html":{"href":"https://github.com/AmyAssist/Amy/pull/152"},"issue":{"href":"https://api.github.com/repos/AmyAssist/Amy/issues/152"},"comments":{"href":"https://api.github.com/repos/AmyAssist/Amy/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/AmyAssist/Amy/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/AmyAssist/Amy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AmyAssist/Amy/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/AmyAssist/Amy/statuses/d704e29aaac998c240b07a6b60b7f63fd95c4a91"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sonarcloud"}}