{"action":"created","comment":{"url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/comments/177546891","pull_request_review_id":107437291,"id":177546891,"diff_hunk":"@@ -1,9 +1,4 @@\n-#\n-# 30ssl\n-#\n \n-# settings by https://cipherli.st/\n-SSLCipherSuite EECDH+AESGCM:EDH+AESGCM:AES256+EECDH:AES256+EDH\n SSLProtocol All -SSLv2 -SSLv3","path":"root/etc/e-smith/templates/etc/httpd/admin-conf/httpd.conf/38ssl_settings","position":null,"original_position":7,"commit_id":"2d4522004b14cecace3a4bb27631bc68a3d5f68b","original_commit_id":"2637d2f93f93d4abaab5b2df7f757b4f35425eca","user":{"login":"stephdl","id":3164851,"avatar_url":"https://avatars0.githubusercontent.com/u/3164851?v=4","gravatar_id":"","url":"https://api.github.com/users/stephdl","html_url":"https://github.com/stephdl","followers_url":"https://api.github.com/users/stephdl/followers","following_url":"https://api.github.com/users/stephdl/following{/other_user}","gists_url":"https://api.github.com/users/stephdl/gists{/gist_id}","starred_url":"https://api.github.com/users/stephdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephdl/subscriptions","organizations_url":"https://api.github.com/users/stephdl/orgs","repos_url":"https://api.github.com/users/stephdl/repos","events_url":"https://api.github.com/users/stephdl/events{/privacy}","received_events_url":"https://api.github.com/users/stephdl/received_events","type":"User","site_admin":false},"body":"`  SSLProtocol All -SSLv2 -SSLv3 `\r\nadded in all policy","created_at":"2018-03-27T19:35:06Z","updated_at":"2018-03-27T19:35:06Z","html_url":"https://github.com/NethServer/nethserver-httpd-admin/pull/26#discussion_r177546891","pull_request_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/26","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/comments/177546891"},"html":{"href":"https://github.com/NethServer/nethserver-httpd-admin/pull/26#discussion_r177546891"},"pull_request":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/26"}},"in_reply_to_id":176922287},"pull_request":{"url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/26","id":176555972,"html_url":"https://github.com/NethServer/nethserver-httpd-admin/pull/26","diff_url":"https://github.com/NethServer/nethserver-httpd-admin/pull/26.diff","patch_url":"https://github.com/NethServer/nethserver-httpd-admin/pull/26.patch","issue_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/issues/26","number":26,"state":"open","locked":false,"title":"Hardening tls following tls-policy-save","user":{"login":"stephdl","id":3164851,"avatar_url":"https://avatars0.githubusercontent.com/u/3164851?v=4","gravatar_id":"","url":"https://api.github.com/users/stephdl","html_url":"https://github.com/stephdl","followers_url":"https://api.github.com/users/stephdl/followers","following_url":"https://api.github.com/users/stephdl/following{/other_user}","gists_url":"https://api.github.com/users/stephdl/gists{/gist_id}","starred_url":"https://api.github.com/users/stephdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephdl/subscriptions","organizations_url":"https://api.github.com/users/stephdl/orgs","repos_url":"https://api.github.com/users/stephdl/repos","events_url":"https://api.github.com/users/stephdl/events{/privacy}","received_events_url":"https://api.github.com/users/stephdl/received_events","type":"User","site_admin":false},"body":"https://github.com/NethServer/dev/issues/5438\r\n\r\ncypher list based on https://bettercrypto.org/static/applied-crypto-hardening.pdf category A","created_at":"2018-03-21T17:36:17Z","updated_at":"2018-03-27T19:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7517cae7c480cce6025fce96adb12945aa146134","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/26/commits","review_comments_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/26/comments","review_comment_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/issues/26/comments","statuses_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/statuses/2d4522004b14cecace3a4bb27631bc68a3d5f68b","head":{"label":"stephdl:HardeningTLS","ref":"HardeningTLS","sha":"2d4522004b14cecace3a4bb27631bc68a3d5f68b","user":{"login":"stephdl","id":3164851,"avatar_url":"https://avatars0.githubusercontent.com/u/3164851?v=4","gravatar_id":"","url":"https://api.github.com/users/stephdl","html_url":"https://github.com/stephdl","followers_url":"https://api.github.com/users/stephdl/followers","following_url":"https://api.github.com/users/stephdl/following{/other_user}","gists_url":"https://api.github.com/users/stephdl/gists{/gist_id}","starred_url":"https://api.github.com/users/stephdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephdl/subscriptions","organizations_url":"https://api.github.com/users/stephdl/orgs","repos_url":"https://api.github.com/users/stephdl/repos","events_url":"https://api.github.com/users/stephdl/events{/privacy}","received_events_url":"https://api.github.com/users/stephdl/received_events","type":"User","site_admin":false},"repo":{"id":109611546,"name":"nethserver-httpd-admin","full_name":"stephdl/nethserver-httpd-admin","owner":{"login":"stephdl","id":3164851,"avatar_url":"https://avatars0.githubusercontent.com/u/3164851?v=4","gravatar_id":"","url":"https://api.github.com/users/stephdl","html_url":"https://github.com/stephdl","followers_url":"https://api.github.com/users/stephdl/followers","following_url":"https://api.github.com/users/stephdl/following{/other_user}","gists_url":"https://api.github.com/users/stephdl/gists{/gist_id}","starred_url":"https://api.github.com/users/stephdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephdl/subscriptions","organizations_url":"https://api.github.com/users/stephdl/orgs","repos_url":"https://api.github.com/users/stephdl/repos","events_url":"https://api.github.com/users/stephdl/events{/privacy}","received_events_url":"https://api.github.com/users/stephdl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephdl/nethserver-httpd-admin","description":"Apache instance running as admin user ","fork":true,"url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin","forks_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/forks","keys_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/teams","hooks_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/hooks","issue_events_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/issues/events{/number}","events_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/events","assignees_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/assignees{/user}","branches_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/branches{/branch}","tags_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/tags","blobs_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/languages","stargazers_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/stargazers","contributors_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/contributors","subscribers_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/subscribers","subscription_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/subscription","commits_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/contents/{+path}","compare_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/merges","archive_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/downloads","issues_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/issues{/number}","pulls_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/labels{/name}","releases_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/releases{/id}","deployments_url":"https://api.github.com/repos/stephdl/nethserver-httpd-admin/deployments","created_at":"2017-11-05T20:00:06Z","updated_at":"2017-11-05T20:00:07Z","pushed_at":"2018-03-27T19:34:00Z","git_url":"git://github.com/stephdl/nethserver-httpd-admin.git","ssh_url":"git@github.com:stephdl/nethserver-httpd-admin.git","clone_url":"https://github.com/stephdl/nethserver-httpd-admin.git","svn_url":"https://github.com/stephdl/nethserver-httpd-admin","homepage":null,"size":5105,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NethServer:master","ref":"master","sha":"0c7988bdc720d941f7f770acc424acda1d0f29f7","user":{"login":"NethServer","id":6469208,"avatar_url":"https://avatars3.githubusercontent.com/u/6469208?v=4","gravatar_id":"","url":"https://api.github.com/users/NethServer","html_url":"https://github.com/NethServer","followers_url":"https://api.github.com/users/NethServer/followers","following_url":"https://api.github.com/users/NethServer/following{/other_user}","gists_url":"https://api.github.com/users/NethServer/gists{/gist_id}","starred_url":"https://api.github.com/users/NethServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NethServer/subscriptions","organizations_url":"https://api.github.com/users/NethServer/orgs","repos_url":"https://api.github.com/users/NethServer/repos","events_url":"https://api.github.com/users/NethServer/events{/privacy}","received_events_url":"https://api.github.com/users/NethServer/received_events","type":"Organization","site_admin":false},"repo":{"id":8900208,"name":"nethserver-httpd-admin","full_name":"NethServer/nethserver-httpd-admin","owner":{"login":"NethServer","id":6469208,"avatar_url":"https://avatars3.githubusercontent.com/u/6469208?v=4","gravatar_id":"","url":"https://api.github.com/users/NethServer","html_url":"https://github.com/NethServer","followers_url":"https://api.github.com/users/NethServer/followers","following_url":"https://api.github.com/users/NethServer/following{/other_user}","gists_url":"https://api.github.com/users/NethServer/gists{/gist_id}","starred_url":"https://api.github.com/users/NethServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NethServer/subscriptions","organizations_url":"https://api.github.com/users/NethServer/orgs","repos_url":"https://api.github.com/users/NethServer/repos","events_url":"https://api.github.com/users/NethServer/events{/privacy}","received_events_url":"https://api.github.com/users/NethServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NethServer/nethserver-httpd-admin","description":"Apache instance running as admin user ","fork":false,"url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin","forks_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/forks","keys_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/teams","hooks_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/hooks","issue_events_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/issues/events{/number}","events_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/events","assignees_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/assignees{/user}","branches_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/branches{/branch}","tags_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/tags","blobs_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/languages","stargazers_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/stargazers","contributors_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/contributors","subscribers_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/subscribers","subscription_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/subscription","commits_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/contents/{+path}","compare_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/merges","archive_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/downloads","issues_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/issues{/number}","pulls_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/labels{/name}","releases_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/releases{/id}","deployments_url":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/deployments","created_at":"2013-03-20T09:10:06Z","updated_at":"2016-11-09T10:49:44Z","pushed_at":"2018-03-27T19:34:02Z","git_url":"git://github.com/NethServer/nethserver-httpd-admin.git","ssh_url":"git@github.com:NethServer/nethserver-httpd-admin.git","clone_url":"https://github.com/NethServer/nethserver-httpd-admin.git","svn_url":"https://github.com/NethServer/nethserver-httpd-admin","homepage":null,"size":5100,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":7,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/26"},"html":{"href":"https://github.com/NethServer/nethserver-httpd-admin/pull/26"},"issue":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/issues/26"},"comments":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/NethServer/nethserver-httpd-admin/statuses/2d4522004b14cecace3a4bb27631bc68a3d5f68b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stephdl"}}