{"action":"created","comment":{"url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/comments/239627946","pull_request_review_id":182464746,"id":239627946,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTYyNzk0Ng==","diff_hunk":"@@ -332,9 +332,9 @@ namespace wr\n \n \tvoid D3D12RenderSystem::StopRenderTask(CommandList* cmd_list, std::pair<RenderTarget*, RenderTargetProperties> render_target)\n \t{\n-\t\tauto n_cmd_list = static_cast<D3D12CommandList*>(cmd_list);\n-\t\tauto n_render_target = static_cast<D3D12RenderTarget*>(render_target.first);\n-\t\tauto frame_idx = GetFrameIdx();\n+\t\tauto n_cmd_list = static_cast<d3d12::CommandList*>(cmd_list);\n+\t\tauto n_render_target = static_cast<d3d12::RenderTarget*>(render_target.first);\n+\t\tunsigned int frame_idx = GetFrameIdx();","path":"src/d3d12/d3d12_renderer.cpp","position":89,"original_position":89,"commit_id":"4e191cb30303b9c6904dd83628352ce74792e1d8","original_commit_id":"4e191cb30303b9c6904dd83628352ce74792e1d8","user":{"login":"florianschut","id":9513884,"node_id":"MDQ6VXNlcjk1MTM4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9513884?v=4","gravatar_id":"","url":"https://api.github.com/users/florianschut","html_url":"https://github.com/florianschut","followers_url":"https://api.github.com/users/florianschut/followers","following_url":"https://api.github.com/users/florianschut/following{/other_user}","gists_url":"https://api.github.com/users/florianschut/gists{/gist_id}","starred_url":"https://api.github.com/users/florianschut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florianschut/subscriptions","organizations_url":"https://api.github.com/users/florianschut/orgs","repos_url":"https://api.github.com/users/florianschut/repos","events_url":"https://api.github.com/users/florianschut/events{/privacy}","received_events_url":"https://api.github.com/users/florianschut/received_events","type":"User","site_admin":false},"body":"My bad, changed that when I had some unexplainable errors which where suppressed by specifically specifying a type. Later it turned out to be caused by a different error. I’ll change this back in my next submit!","created_at":"2018-12-06T21:50:25Z","updated_at":"2018-12-06T21:50:25Z","html_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing/pull/69#discussion_r239627946","pull_request_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/69","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/comments/239627946"},"html":{"href":"https://github.com/TeamWisp/Procedural-Ray-Tracing/pull/69#discussion_r239627946"},"pull_request":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/69"}},"in_reply_to_id":239502548},"pull_request":{"url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/69","id":236469296,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NDY5Mjk2","html_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing/pull/69","diff_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing/pull/69.diff","patch_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing/pull/69.patch","issue_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues/69","number":69,"state":"closed","locked":false,"title":"Feature voidptr bridging","user":{"login":"florianschut","id":9513884,"node_id":"MDQ6VXNlcjk1MTM4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9513884?v=4","gravatar_id":"","url":"https://api.github.com/users/florianschut","html_url":"https://github.com/florianschut","followers_url":"https://api.github.com/users/florianschut/followers","following_url":"https://api.github.com/users/florianschut/following{/other_user}","gists_url":"https://api.github.com/users/florianschut/gists{/gist_id}","starred_url":"https://api.github.com/users/florianschut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florianschut/subscriptions","organizations_url":"https://api.github.com/users/florianschut/orgs","repos_url":"https://api.github.com/users/florianschut/repos","events_url":"https://api.github.com/users/florianschut/events{/privacy}","received_events_url":"https://api.github.com/users/florianschut/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-06T09:58:56Z","updated_at":"2018-12-06T21:50:25Z","closed_at":"2018-12-06T15:47:35Z","merged_at":"2018-12-06T15:47:35Z","merge_commit_sha":"e8e60d76d4ca6f5c98e47e173f5824dd0884017e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/69/commits","review_comments_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/69/comments","review_comment_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues/69/comments","statuses_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/statuses/4e191cb30303b9c6904dd83628352ce74792e1d8","head":{"label":"TeamWisp:feature_voidptr_bridging","ref":"feature_voidptr_bridging","sha":"4e191cb30303b9c6904dd83628352ce74792e1d8","user":{"login":"TeamWisp","id":43639219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjM5MjE5","avatar_url":"https://avatars2.githubusercontent.com/u/43639219?v=4","gravatar_id":"","url":"https://api.github.com/users/TeamWisp","html_url":"https://github.com/TeamWisp","followers_url":"https://api.github.com/users/TeamWisp/followers","following_url":"https://api.github.com/users/TeamWisp/following{/other_user}","gists_url":"https://api.github.com/users/TeamWisp/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamWisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamWisp/subscriptions","organizations_url":"https://api.github.com/users/TeamWisp/orgs","repos_url":"https://api.github.com/users/TeamWisp/repos","events_url":"https://api.github.com/users/TeamWisp/events{/privacy}","received_events_url":"https://api.github.com/users/TeamWisp/received_events","type":"Organization","site_admin":false},"repo":{"id":150591399,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1OTEzOTk=","name":"Procedural-Ray-Tracing","full_name":"TeamWisp/Procedural-Ray-Tracing","private":false,"owner":{"login":"TeamWisp","id":43639219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjM5MjE5","avatar_url":"https://avatars2.githubusercontent.com/u/43639219?v=4","gravatar_id":"","url":"https://api.github.com/users/TeamWisp","html_url":"https://github.com/TeamWisp","followers_url":"https://api.github.com/users/TeamWisp/followers","following_url":"https://api.github.com/users/TeamWisp/following{/other_user}","gists_url":"https://api.github.com/users/TeamWisp/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamWisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamWisp/subscriptions","organizations_url":"https://api.github.com/users/TeamWisp/orgs","repos_url":"https://api.github.com/users/TeamWisp/repos","events_url":"https://api.github.com/users/TeamWisp/events{/privacy}","received_events_url":"https://api.github.com/users/TeamWisp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing","description":"Repository for our Procedural Ray Tracing project, made by Y3 students at Breda University of Applied Science (former NHTV)","fork":false,"url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing","forks_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/forks","keys_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/teams","hooks_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/hooks","issue_events_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues/events{/number}","events_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/events","assignees_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/assignees{/user}","branches_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/branches{/branch}","tags_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/tags","blobs_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/statuses/{sha}","languages_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/languages","stargazers_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/stargazers","contributors_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/contributors","subscribers_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/subscribers","subscription_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/subscription","commits_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/contents/{+path}","compare_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/merges","archive_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/downloads","issues_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues{/number}","pulls_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls{/number}","milestones_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/milestones{/number}","notifications_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/labels{/name}","releases_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/releases{/id}","deployments_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/deployments","created_at":"2018-09-27T13:29:24Z","updated_at":"2018-12-06T15:47:39Z","pushed_at":"2018-12-06T18:54:31Z","git_url":"git://github.com/TeamWisp/Procedural-Ray-Tracing.git","ssh_url":"git@github.com:TeamWisp/Procedural-Ray-Tracing.git","clone_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing.git","svn_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing","homepage":null,"size":28212,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"TeamWisp:master","ref":"master","sha":"a6274cc30d1dac3c82f0fb62776907a7924f015b","user":{"login":"TeamWisp","id":43639219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjM5MjE5","avatar_url":"https://avatars2.githubusercontent.com/u/43639219?v=4","gravatar_id":"","url":"https://api.github.com/users/TeamWisp","html_url":"https://github.com/TeamWisp","followers_url":"https://api.github.com/users/TeamWisp/followers","following_url":"https://api.github.com/users/TeamWisp/following{/other_user}","gists_url":"https://api.github.com/users/TeamWisp/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamWisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamWisp/subscriptions","organizations_url":"https://api.github.com/users/TeamWisp/orgs","repos_url":"https://api.github.com/users/TeamWisp/repos","events_url":"https://api.github.com/users/TeamWisp/events{/privacy}","received_events_url":"https://api.github.com/users/TeamWisp/received_events","type":"Organization","site_admin":false},"repo":{"id":150591399,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1OTEzOTk=","name":"Procedural-Ray-Tracing","full_name":"TeamWisp/Procedural-Ray-Tracing","private":false,"owner":{"login":"TeamWisp","id":43639219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjM5MjE5","avatar_url":"https://avatars2.githubusercontent.com/u/43639219?v=4","gravatar_id":"","url":"https://api.github.com/users/TeamWisp","html_url":"https://github.com/TeamWisp","followers_url":"https://api.github.com/users/TeamWisp/followers","following_url":"https://api.github.com/users/TeamWisp/following{/other_user}","gists_url":"https://api.github.com/users/TeamWisp/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamWisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamWisp/subscriptions","organizations_url":"https://api.github.com/users/TeamWisp/orgs","repos_url":"https://api.github.com/users/TeamWisp/repos","events_url":"https://api.github.com/users/TeamWisp/events{/privacy}","received_events_url":"https://api.github.com/users/TeamWisp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing","description":"Repository for our Procedural Ray Tracing project, made by Y3 students at Breda University of Applied Science (former NHTV)","fork":false,"url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing","forks_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/forks","keys_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/teams","hooks_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/hooks","issue_events_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues/events{/number}","events_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/events","assignees_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/assignees{/user}","branches_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/branches{/branch}","tags_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/tags","blobs_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/statuses/{sha}","languages_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/languages","stargazers_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/stargazers","contributors_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/contributors","subscribers_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/subscribers","subscription_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/subscription","commits_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/contents/{+path}","compare_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/merges","archive_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/downloads","issues_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues{/number}","pulls_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls{/number}","milestones_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/milestones{/number}","notifications_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/labels{/name}","releases_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/releases{/id}","deployments_url":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/deployments","created_at":"2018-09-27T13:29:24Z","updated_at":"2018-12-06T15:47:39Z","pushed_at":"2018-12-06T18:54:31Z","git_url":"git://github.com/TeamWisp/Procedural-Ray-Tracing.git","ssh_url":"git@github.com:TeamWisp/Procedural-Ray-Tracing.git","clone_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing.git","svn_url":"https://github.com/TeamWisp/Procedural-Ray-Tracing","homepage":null,"size":28212,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/69"},"html":{"href":"https://github.com/TeamWisp/Procedural-Ray-Tracing/pull/69"},"issue":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues/69"},"comments":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/TeamWisp/Procedural-Ray-Tracing/statuses/4e191cb30303b9c6904dd83628352ce74792e1d8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"florianschut"}}