{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/comments/195082547","pull_request_review_id":128377225,"id":195082547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTA4MjU0Nw==","diff_hunk":"@@ -0,0 +1,48 @@\n+/*\n+ * Copyright 2017-2018 The OpenTracing Authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package io.opentracing.contrib.cassandra.QuerySpanNameProvider;\n+\n+/**\n+ * @author Jordan J Lopez\n+ *  Returns a custom prefix and the full query as the span name\n+ */\n+public class PrefixedFullQuerySpanName implements QuerySpanNameProvider {\n+  private String prefix;\n+\n+  public static class Builder implements QuerySpanNameProvider.Builder {\n+    @Override\n+    public QuerySpanNameProvider build() { return new io.opentracing.contrib.cassandra.QuerySpanNameProvider.PrefixedFullQuerySpanName(\"Cassandra\");}\n+\n+    public QuerySpanNameProvider build(String prefix) {return new io.opentracing.contrib.cassandra.QuerySpanNameProvider.PrefixedFullQuerySpanName(prefix);}","path":"src/main/java/io/opentracing/contrib/cassandra/QuerySpanNameProvider/PrefixedFullQuerySpanName.java","position":27,"original_position":27,"commit_id":"b4b54b5b40fac5763fb1300a97998cb23328917f","original_commit_id":"b4b54b5b40fac5763fb1300a97998cb23328917f","user":{"login":"malafeev","id":1412925,"node_id":"MDQ6VXNlcjE0MTI5MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1412925?v=4","gravatar_id":"","url":"https://api.github.com/users/malafeev","html_url":"https://github.com/malafeev","followers_url":"https://api.github.com/users/malafeev/followers","following_url":"https://api.github.com/users/malafeev/following{/other_user}","gists_url":"https://api.github.com/users/malafeev/gists{/gist_id}","starred_url":"https://api.github.com/users/malafeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malafeev/subscriptions","organizations_url":"https://api.github.com/users/malafeev/orgs","repos_url":"https://api.github.com/users/malafeev/repos","events_url":"https://api.github.com/users/malafeev/events{/privacy}","received_events_url":"https://api.github.com/users/malafeev/received_events","type":"User","site_admin":false},"body":"better use just `QuerySpanNameProvider.PrefixedFullQuerySpanName` without full package path","created_at":"2018-06-13T13:33:27Z","updated_at":"2018-06-13T13:33:27Z","html_url":"https://github.com/opentracing-contrib/java-cassandra-driver/pull/7#discussion_r195082547","pull_request_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/comments/195082547"},"html":{"href":"https://github.com/opentracing-contrib/java-cassandra-driver/pull/7#discussion_r195082547"},"pull_request":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/7","id":194406702,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDA2NzAy","html_url":"https://github.com/opentracing-contrib/java-cassandra-driver/pull/7","diff_url":"https://github.com/opentracing-contrib/java-cassandra-driver/pull/7.diff","patch_url":"https://github.com/opentracing-contrib/java-cassandra-driver/pull/7.patch","issue_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/issues/7","number":7,"state":"open","locked":false,"title":"Provide alternative/more informative operation names for spans","user":{"login":"JordanJLopez","id":8593393,"node_id":"MDQ6VXNlcjg1OTMzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8593393?v=4","gravatar_id":"","url":"https://api.github.com/users/JordanJLopez","html_url":"https://github.com/JordanJLopez","followers_url":"https://api.github.com/users/JordanJLopez/followers","following_url":"https://api.github.com/users/JordanJLopez/following{/other_user}","gists_url":"https://api.github.com/users/JordanJLopez/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanJLopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanJLopez/subscriptions","organizations_url":"https://api.github.com/users/JordanJLopez/orgs","repos_url":"https://api.github.com/users/JordanJLopez/repos","events_url":"https://api.github.com/users/JordanJLopez/events{/privacy}","received_events_url":"https://api.github.com/users/JordanJLopez/received_events","type":"User","site_admin":false},"body":"This PR establishes an interface for users to create custom span names for their traced queries.","created_at":"2018-06-12T21:01:33Z","updated_at":"2018-06-13T13:33:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5501383ae14a29d428f4d89aefad21429c08f89f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/7/commits","review_comments_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/7/comments","review_comment_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/issues/7/comments","statuses_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/statuses/b4b54b5b40fac5763fb1300a97998cb23328917f","head":{"label":"JordanJLopez:master","ref":"master","sha":"b4b54b5b40fac5763fb1300a97998cb23328917f","user":{"login":"JordanJLopez","id":8593393,"node_id":"MDQ6VXNlcjg1OTMzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8593393?v=4","gravatar_id":"","url":"https://api.github.com/users/JordanJLopez","html_url":"https://github.com/JordanJLopez","followers_url":"https://api.github.com/users/JordanJLopez/followers","following_url":"https://api.github.com/users/JordanJLopez/following{/other_user}","gists_url":"https://api.github.com/users/JordanJLopez/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanJLopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanJLopez/subscriptions","organizations_url":"https://api.github.com/users/JordanJLopez/orgs","repos_url":"https://api.github.com/users/JordanJLopez/repos","events_url":"https://api.github.com/users/JordanJLopez/events{/privacy}","received_events_url":"https://api.github.com/users/JordanJLopez/received_events","type":"User","site_admin":false},"repo":{"id":136515835,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MTU4MzU=","name":"java-cassandra-driver","full_name":"JordanJLopez/java-cassandra-driver","owner":{"login":"JordanJLopez","id":8593393,"node_id":"MDQ6VXNlcjg1OTMzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8593393?v=4","gravatar_id":"","url":"https://api.github.com/users/JordanJLopez","html_url":"https://github.com/JordanJLopez","followers_url":"https://api.github.com/users/JordanJLopez/followers","following_url":"https://api.github.com/users/JordanJLopez/following{/other_user}","gists_url":"https://api.github.com/users/JordanJLopez/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanJLopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanJLopez/subscriptions","organizations_url":"https://api.github.com/users/JordanJLopez/orgs","repos_url":"https://api.github.com/users/JordanJLopez/repos","events_url":"https://api.github.com/users/JordanJLopez/events{/privacy}","received_events_url":"https://api.github.com/users/JordanJLopez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JordanJLopez/java-cassandra-driver","description":"OpenTracing instrumentation for Cassandra Driver","fork":true,"url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver","forks_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/forks","keys_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/teams","hooks_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/hooks","issue_events_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/issues/events{/number}","events_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/events","assignees_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/assignees{/user}","branches_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/branches{/branch}","tags_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/tags","blobs_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/languages","stargazers_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/stargazers","contributors_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/contributors","subscribers_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/subscribers","subscription_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/subscription","commits_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/contents/{+path}","compare_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/merges","archive_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/downloads","issues_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/issues{/number}","pulls_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/labels{/name}","releases_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/releases{/id}","deployments_url":"https://api.github.com/repos/JordanJLopez/java-cassandra-driver/deployments","created_at":"2018-06-07T18:24:43Z","updated_at":"2018-06-12T20:59:58Z","pushed_at":"2018-06-12T20:59:57Z","git_url":"git://github.com/JordanJLopez/java-cassandra-driver.git","ssh_url":"git@github.com:JordanJLopez/java-cassandra-driver.git","clone_url":"https://github.com/JordanJLopez/java-cassandra-driver.git","svn_url":"https://github.com/JordanJLopez/java-cassandra-driver","homepage":"","size":530,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentracing-contrib:master","ref":"master","sha":"406bed1cc45748ec81adcb4afe0712459cff476b","user":{"login":"opentracing-contrib","id":20525934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTI1OTM0","avatar_url":"https://avatars0.githubusercontent.com/u/20525934?v=4","gravatar_id":"","url":"https://api.github.com/users/opentracing-contrib","html_url":"https://github.com/opentracing-contrib","followers_url":"https://api.github.com/users/opentracing-contrib/followers","following_url":"https://api.github.com/users/opentracing-contrib/following{/other_user}","gists_url":"https://api.github.com/users/opentracing-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing-contrib/subscriptions","organizations_url":"https://api.github.com/users/opentracing-contrib/orgs","repos_url":"https://api.github.com/users/opentracing-contrib/repos","events_url":"https://api.github.com/users/opentracing-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":88127865,"node_id":"MDEwOlJlcG9zaXRvcnk4ODEyNzg2NQ==","name":"java-cassandra-driver","full_name":"opentracing-contrib/java-cassandra-driver","owner":{"login":"opentracing-contrib","id":20525934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTI1OTM0","avatar_url":"https://avatars0.githubusercontent.com/u/20525934?v=4","gravatar_id":"","url":"https://api.github.com/users/opentracing-contrib","html_url":"https://github.com/opentracing-contrib","followers_url":"https://api.github.com/users/opentracing-contrib/followers","following_url":"https://api.github.com/users/opentracing-contrib/following{/other_user}","gists_url":"https://api.github.com/users/opentracing-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing-contrib/subscriptions","organizations_url":"https://api.github.com/users/opentracing-contrib/orgs","repos_url":"https://api.github.com/users/opentracing-contrib/repos","events_url":"https://api.github.com/users/opentracing-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing-contrib/java-cassandra-driver","description":"OpenTracing instrumentation for Cassandra Driver","fork":false,"url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver","forks_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/forks","keys_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/teams","hooks_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/hooks","issue_events_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/events","assignees_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/tags","blobs_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/languages","stargazers_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/stargazers","contributors_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/contributors","subscribers_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/subscribers","subscription_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/subscription","commits_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/merges","archive_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/downloads","issues_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/labels{/name}","releases_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/deployments","created_at":"2017-04-13T05:21:58Z","updated_at":"2018-05-31T13:06:12Z","pushed_at":"2018-06-12T21:01:34Z","git_url":"git://github.com/opentracing-contrib/java-cassandra-driver.git","ssh_url":"git@github.com:opentracing-contrib/java-cassandra-driver.git","clone_url":"https://github.com/opentracing-contrib/java-cassandra-driver.git","svn_url":"https://github.com/opentracing-contrib/java-cassandra-driver","homepage":"","size":511,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/7"},"html":{"href":"https://github.com/opentracing-contrib/java-cassandra-driver/pull/7"},"issue":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/issues/7"},"comments":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing-contrib/java-cassandra-driver/statuses/b4b54b5b40fac5763fb1300a97998cb23328917f"}},"author_association":"NONE"}}
{"actor":{"display_login":"malafeev"}}