{"action":"created","comment":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/199327014","pull_request_review_id":133430849,"id":199327014,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMyNzAxNA==","diff_hunk":"@@ -114,7 +115,7 @@ export interface VuetifyBreakpoint {\n   xsOnly: boolean\n }\n \n-export type VuetifyThemeItem = string | number\n+export type VuetifyThemeItem = string | RGB","path":"types/index.d.ts","position":13,"original_position":13,"commit_id":"5fab1ae23580d8c5fe9ba9427319ffe19c966233","original_commit_id":"5fab1ae23580d8c5fe9ba9427319ffe19c966233","user":{"login":"KaelWD","id":16421948,"node_id":"MDQ6VXNlcjE2NDIxOTQ4","avatar_url":"https://avatars2.githubusercontent.com/u/16421948?v=4","gravatar_id":"","url":"https://api.github.com/users/KaelWD","html_url":"https://github.com/KaelWD","followers_url":"https://api.github.com/users/KaelWD/followers","following_url":"https://api.github.com/users/KaelWD/following{/other_user}","gists_url":"https://api.github.com/users/KaelWD/gists{/gist_id}","starred_url":"https://api.github.com/users/KaelWD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaelWD/subscriptions","organizations_url":"https://api.github.com/users/KaelWD/orgs","repos_url":"https://api.github.com/users/KaelWD/repos","events_url":"https://api.github.com/users/KaelWD/events{/privacy}","received_events_url":"https://api.github.com/users/KaelWD/received_events","type":"User","site_admin":false},"body":"Leave this as it was, that's just complicating stuff for no reason","created_at":"2018-06-30T16:54:53Z","updated_at":"2018-06-30T16:59:21Z","html_url":"https://github.com/vuetifyjs/vuetify/pull/4351#discussion_r199327014","pull_request_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4351","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/199327014"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/4351#discussion_r199327014"},"pull_request":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4351"}}},"pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4351","id":196137544,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTM3NTQ0","html_url":"https://github.com/vuetifyjs/vuetify/pull/4351","diff_url":"https://github.com/vuetifyjs/vuetify/pull/4351.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/4351.patch","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/4351","number":4351,"state":"open","locked":false,"title":"refactor: convert theme.js to typescript","user":{"login":"jacekkarczmarczyk","id":15625235,"node_id":"MDQ6VXNlcjE1NjI1MjM1","avatar_url":"https://avatars3.githubusercontent.com/u/15625235?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekkarczmarczyk","html_url":"https://github.com/jacekkarczmarczyk","followers_url":"https://api.github.com/users/jacekkarczmarczyk/followers","following_url":"https://api.github.com/users/jacekkarczmarczyk/following{/other_user}","gists_url":"https://api.github.com/users/jacekkarczmarczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkarczmarczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkarczmarczyk/subscriptions","organizations_url":"https://api.github.com/users/jacekkarczmarczyk/orgs","repos_url":"https://api.github.com/users/jacekkarczmarczyk/repos","events_url":"https://api.github.com/users/jacekkarczmarczyk/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkarczmarczyk/received_events","type":"User","site_admin":false},"body":"## Motivation and Context\r\nlearning typescript\r\n\r\n## How Has This Been Tested?\r\nyarn lint\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [x] Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)\r\n","created_at":"2018-06-20T13:25:15Z","updated_at":"2018-06-30T16:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce05abdb743b648da34cb923489dbd77ea6c9fc5","assignee":{"login":"jacekkarczmarczyk","id":15625235,"node_id":"MDQ6VXNlcjE1NjI1MjM1","avatar_url":"https://avatars3.githubusercontent.com/u/15625235?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekkarczmarczyk","html_url":"https://github.com/jacekkarczmarczyk","followers_url":"https://api.github.com/users/jacekkarczmarczyk/followers","following_url":"https://api.github.com/users/jacekkarczmarczyk/following{/other_user}","gists_url":"https://api.github.com/users/jacekkarczmarczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkarczmarczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkarczmarczyk/subscriptions","organizations_url":"https://api.github.com/users/jacekkarczmarczyk/orgs","repos_url":"https://api.github.com/users/jacekkarczmarczyk/repos","events_url":"https://api.github.com/users/jacekkarczmarczyk/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkarczmarczyk/received_events","type":"User","site_admin":false},"assignees":[{"login":"jacekkarczmarczyk","id":15625235,"node_id":"MDQ6VXNlcjE1NjI1MjM1","avatar_url":"https://avatars3.githubusercontent.com/u/15625235?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekkarczmarczyk","html_url":"https://github.com/jacekkarczmarczyk","followers_url":"https://api.github.com/users/jacekkarczmarczyk/followers","following_url":"https://api.github.com/users/jacekkarczmarczyk/following{/other_user}","gists_url":"https://api.github.com/users/jacekkarczmarczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkarczmarczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkarczmarczyk/subscriptions","organizations_url":"https://api.github.com/users/jacekkarczmarczyk/orgs","repos_url":"https://api.github.com/users/jacekkarczmarczyk/repos","events_url":"https://api.github.com/users/jacekkarczmarczyk/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkarczmarczyk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4351/commits","review_comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4351/comments","review_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/4351/comments","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/5fab1ae23580d8c5fe9ba9427319ffe19c966233","head":{"label":"vuetifyjs:chore/theme-typescript","ref":"chore/theme-typescript","sha":"5fab1ae23580d8c5fe9ba9427319ffe19c966233","user":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk2MjY0OA==","name":"vuetify","full_name":"vuetifyjs/vuetify","owner":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vuetifyjs/vuetify","description":"Material Component Framework for Vue.js 2","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2018-06-30T16:50:47Z","pushed_at":"2018-06-30T16:43:52Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":14221,"stargazers_count":11627,"watchers_count":11627,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":962,"mirror_url":null,"archived":false,"open_issues_count":380,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":962,"open_issues":380,"watchers":11627,"default_branch":"dev"}},"base":{"label":"vuetifyjs:master","ref":"master","sha":"6e8b6b76bf65c1d5aa55140f4222bf4849d9b4f0","user":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk2MjY0OA==","name":"vuetify","full_name":"vuetifyjs/vuetify","owner":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vuetifyjs/vuetify","description":"Material Component Framework for Vue.js 2","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2018-06-30T16:50:47Z","pushed_at":"2018-06-30T16:43:52Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":14221,"stargazers_count":11627,"watchers_count":11627,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":962,"mirror_url":null,"archived":false,"open_issues_count":380,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":962,"open_issues":380,"watchers":11627,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4351"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/4351"},"issue":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/4351"},"comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/4351/comments"},"review_comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4351/comments"},"review_comment":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4351/commits"},"statuses":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/5fab1ae23580d8c5fe9ba9427319ffe19c966233"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KaelWD"}}