{"action":"created","comment":{"url":"https://api.github.com/repos/blevesearch/bleve/pulls/comments/172237059","pull_request_review_id":101219824,"id":172237059,"diff_hunk":"@@ -552,8 +552,7 @@ func persistDocValues(memSegment *mem.Segment, w *CountHashWriter,\n \t\t\tnextPosting, err2 := postingsItr.Next()\n \t\t\tfor err2 == nil && nextPosting != nil {\n \t\t\t\tdocNum := nextPosting.Number()\n-\t\t\t\tdocTermMap[docNum] = append(docTermMap[docNum], []byte(next.Term)...)\n-\t\t\t\tdocTermMap[docNum] = append(docTermMap[docNum], termSeparator)\n+\t\t\t\tdocTermMap[docNum] = append(append(docTermMap[docNum], []byte(next.Term)...), termSeparator)","path":"index/scorch/segment/zap/build.go","position":6,"original_position":6,"commit_id":"884da6f93a3c0b9a4567501ad4ddf96eea739227","original_commit_id":"884da6f93a3c0b9a4567501ad4ddf96eea739227","user":{"login":"mschoch","id":298143,"avatar_url":"https://avatars2.githubusercontent.com/u/298143?v=4","gravatar_id":"","url":"https://api.github.com/users/mschoch","html_url":"https://github.com/mschoch","followers_url":"https://api.github.com/users/mschoch/followers","following_url":"https://api.github.com/users/mschoch/following{/other_user}","gists_url":"https://api.github.com/users/mschoch/gists{/gist_id}","starred_url":"https://api.github.com/users/mschoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschoch/subscriptions","organizations_url":"https://api.github.com/users/mschoch/orgs","repos_url":"https://api.github.com/users/mschoch/repos","events_url":"https://api.github.com/users/mschoch/events{/privacy}","received_events_url":"https://api.github.com/users/mschoch/received_events","type":"User","site_admin":false},"body":"curious if this is faster or cosmetic?","created_at":"2018-03-05T16:04:53Z","updated_at":"2018-03-05T16:04:53Z","html_url":"https://github.com/blevesearch/bleve/pull/795#discussion_r172237059","pull_request_url":"https://api.github.com/repos/blevesearch/bleve/pulls/795","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/comments/172237059"},"html":{"href":"https://github.com/blevesearch/bleve/pull/795#discussion_r172237059"},"pull_request":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/795"}}},"pull_request":{"url":"https://api.github.com/repos/blevesearch/bleve/pulls/795","id":172684687,"html_url":"https://github.com/blevesearch/bleve/pull/795","diff_url":"https://github.com/blevesearch/bleve/pull/795.diff","patch_url":"https://github.com/blevesearch/bleve/pull/795.patch","issue_url":"https://api.github.com/repos/blevesearch/bleve/issues/795","number":795,"state":"open","locked":false,"title":"More scorch micro optimizations when processing mem segments","user":{"login":"steveyen","id":30640,"avatar_url":"https://avatars3.githubusercontent.com/u/30640?v=4","gravatar_id":"","url":"https://api.github.com/users/steveyen","html_url":"https://github.com/steveyen","followers_url":"https://api.github.com/users/steveyen/followers","following_url":"https://api.github.com/users/steveyen/following{/other_user}","gists_url":"https://api.github.com/users/steveyen/gists{/gist_id}","starred_url":"https://api.github.com/users/steveyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveyen/subscriptions","organizations_url":"https://api.github.com/users/steveyen/orgs","repos_url":"https://api.github.com/users/steveyen/repos","events_url":"https://api.github.com/users/steveyen/events{/privacy}","received_events_url":"https://api.github.com/users/steveyen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-03T20:01:15Z","updated_at":"2018-03-05T16:04:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"652ddfb56cb4b8616d20bb4b7a8846b3e64ca7b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abhinavdangeti","id":1863456,"avatar_url":"https://avatars2.githubusercontent.com/u/1863456?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdangeti","html_url":"https://github.com/abhinavdangeti","followers_url":"https://api.github.com/users/abhinavdangeti/followers","following_url":"https://api.github.com/users/abhinavdangeti/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdangeti/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdangeti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdangeti/subscriptions","organizations_url":"https://api.github.com/users/abhinavdangeti/orgs","repos_url":"https://api.github.com/users/abhinavdangeti/repos","events_url":"https://api.github.com/users/abhinavdangeti/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdangeti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blevesearch/bleve/pulls/795/commits","review_comments_url":"https://api.github.com/repos/blevesearch/bleve/pulls/795/comments","review_comment_url":"https://api.github.com/repos/blevesearch/bleve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blevesearch/bleve/issues/795/comments","statuses_url":"https://api.github.com/repos/blevesearch/bleve/statuses/884da6f93a3c0b9a4567501ad4ddf96eea739227","head":{"label":"steveyen:scorch-mem-optimizations","ref":"scorch-mem-optimizations","sha":"884da6f93a3c0b9a4567501ad4ddf96eea739227","user":{"login":"steveyen","id":30640,"avatar_url":"https://avatars3.githubusercontent.com/u/30640?v=4","gravatar_id":"","url":"https://api.github.com/users/steveyen","html_url":"https://github.com/steveyen","followers_url":"https://api.github.com/users/steveyen/followers","following_url":"https://api.github.com/users/steveyen/following{/other_user}","gists_url":"https://api.github.com/users/steveyen/gists{/gist_id}","starred_url":"https://api.github.com/users/steveyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveyen/subscriptions","organizations_url":"https://api.github.com/users/steveyen/orgs","repos_url":"https://api.github.com/users/steveyen/repos","events_url":"https://api.github.com/users/steveyen/events{/privacy}","received_events_url":"https://api.github.com/users/steveyen/received_events","type":"User","site_admin":false},"repo":{"id":48817605,"name":"bleve","full_name":"steveyen/bleve","owner":{"login":"steveyen","id":30640,"avatar_url":"https://avatars3.githubusercontent.com/u/30640?v=4","gravatar_id":"","url":"https://api.github.com/users/steveyen","html_url":"https://github.com/steveyen","followers_url":"https://api.github.com/users/steveyen/followers","following_url":"https://api.github.com/users/steveyen/following{/other_user}","gists_url":"https://api.github.com/users/steveyen/gists{/gist_id}","starred_url":"https://api.github.com/users/steveyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveyen/subscriptions","organizations_url":"https://api.github.com/users/steveyen/orgs","repos_url":"https://api.github.com/users/steveyen/repos","events_url":"https://api.github.com/users/steveyen/events{/privacy}","received_events_url":"https://api.github.com/users/steveyen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveyen/bleve","description":"A modern text indexing library for go","fork":true,"url":"https://api.github.com/repos/steveyen/bleve","forks_url":"https://api.github.com/repos/steveyen/bleve/forks","keys_url":"https://api.github.com/repos/steveyen/bleve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveyen/bleve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveyen/bleve/teams","hooks_url":"https://api.github.com/repos/steveyen/bleve/hooks","issue_events_url":"https://api.github.com/repos/steveyen/bleve/issues/events{/number}","events_url":"https://api.github.com/repos/steveyen/bleve/events","assignees_url":"https://api.github.com/repos/steveyen/bleve/assignees{/user}","branches_url":"https://api.github.com/repos/steveyen/bleve/branches{/branch}","tags_url":"https://api.github.com/repos/steveyen/bleve/tags","blobs_url":"https://api.github.com/repos/steveyen/bleve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveyen/bleve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveyen/bleve/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveyen/bleve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveyen/bleve/statuses/{sha}","languages_url":"https://api.github.com/repos/steveyen/bleve/languages","stargazers_url":"https://api.github.com/repos/steveyen/bleve/stargazers","contributors_url":"https://api.github.com/repos/steveyen/bleve/contributors","subscribers_url":"https://api.github.com/repos/steveyen/bleve/subscribers","subscription_url":"https://api.github.com/repos/steveyen/bleve/subscription","commits_url":"https://api.github.com/repos/steveyen/bleve/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveyen/bleve/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveyen/bleve/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveyen/bleve/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveyen/bleve/contents/{+path}","compare_url":"https://api.github.com/repos/steveyen/bleve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveyen/bleve/merges","archive_url":"https://api.github.com/repos/steveyen/bleve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveyen/bleve/downloads","issues_url":"https://api.github.com/repos/steveyen/bleve/issues{/number}","pulls_url":"https://api.github.com/repos/steveyen/bleve/pulls{/number}","milestones_url":"https://api.github.com/repos/steveyen/bleve/milestones{/number}","notifications_url":"https://api.github.com/repos/steveyen/bleve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveyen/bleve/labels{/name}","releases_url":"https://api.github.com/repos/steveyen/bleve/releases{/id}","deployments_url":"https://api.github.com/repos/steveyen/bleve/deployments","created_at":"2015-12-30T20:08:00Z","updated_at":"2016-03-11T23:49:05Z","pushed_at":"2018-03-03T19:59:10Z","git_url":"git://github.com/steveyen/bleve.git","ssh_url":"git@github.com:steveyen/bleve.git","clone_url":"https://github.com/steveyen/bleve.git","svn_url":"https://github.com/steveyen/bleve","homepage":null,"size":11817,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"blevesearch:master","ref":"master","sha":"4ebf3f1d4445e866f8385f45ceca34dcec786a18","user":{"login":"blevesearch","id":8562608,"avatar_url":"https://avatars2.githubusercontent.com/u/8562608?v=4","gravatar_id":"","url":"https://api.github.com/users/blevesearch","html_url":"https://github.com/blevesearch","followers_url":"https://api.github.com/users/blevesearch/followers","following_url":"https://api.github.com/users/blevesearch/following{/other_user}","gists_url":"https://api.github.com/users/blevesearch/gists{/gist_id}","starred_url":"https://api.github.com/users/blevesearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blevesearch/subscriptions","organizations_url":"https://api.github.com/users/blevesearch/orgs","repos_url":"https://api.github.com/users/blevesearch/repos","events_url":"https://api.github.com/users/blevesearch/events{/privacy}","received_events_url":"https://api.github.com/users/blevesearch/received_events","type":"Organization","site_admin":false},"repo":{"id":18893367,"name":"bleve","full_name":"blevesearch/bleve","owner":{"login":"blevesearch","id":8562608,"avatar_url":"https://avatars2.githubusercontent.com/u/8562608?v=4","gravatar_id":"","url":"https://api.github.com/users/blevesearch","html_url":"https://github.com/blevesearch","followers_url":"https://api.github.com/users/blevesearch/followers","following_url":"https://api.github.com/users/blevesearch/following{/other_user}","gists_url":"https://api.github.com/users/blevesearch/gists{/gist_id}","starred_url":"https://api.github.com/users/blevesearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blevesearch/subscriptions","organizations_url":"https://api.github.com/users/blevesearch/orgs","repos_url":"https://api.github.com/users/blevesearch/repos","events_url":"https://api.github.com/users/blevesearch/events{/privacy}","received_events_url":"https://api.github.com/users/blevesearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blevesearch/bleve","description":"A modern text indexing library for go","fork":false,"url":"https://api.github.com/repos/blevesearch/bleve","forks_url":"https://api.github.com/repos/blevesearch/bleve/forks","keys_url":"https://api.github.com/repos/blevesearch/bleve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blevesearch/bleve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blevesearch/bleve/teams","hooks_url":"https://api.github.com/repos/blevesearch/bleve/hooks","issue_events_url":"https://api.github.com/repos/blevesearch/bleve/issues/events{/number}","events_url":"https://api.github.com/repos/blevesearch/bleve/events","assignees_url":"https://api.github.com/repos/blevesearch/bleve/assignees{/user}","branches_url":"https://api.github.com/repos/blevesearch/bleve/branches{/branch}","tags_url":"https://api.github.com/repos/blevesearch/bleve/tags","blobs_url":"https://api.github.com/repos/blevesearch/bleve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blevesearch/bleve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blevesearch/bleve/git/refs{/sha}","trees_url":"https://api.github.com/repos/blevesearch/bleve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blevesearch/bleve/statuses/{sha}","languages_url":"https://api.github.com/repos/blevesearch/bleve/languages","stargazers_url":"https://api.github.com/repos/blevesearch/bleve/stargazers","contributors_url":"https://api.github.com/repos/blevesearch/bleve/contributors","subscribers_url":"https://api.github.com/repos/blevesearch/bleve/subscribers","subscription_url":"https://api.github.com/repos/blevesearch/bleve/subscription","commits_url":"https://api.github.com/repos/blevesearch/bleve/commits{/sha}","git_commits_url":"https://api.github.com/repos/blevesearch/bleve/git/commits{/sha}","comments_url":"https://api.github.com/repos/blevesearch/bleve/comments{/number}","issue_comment_url":"https://api.github.com/repos/blevesearch/bleve/issues/comments{/number}","contents_url":"https://api.github.com/repos/blevesearch/bleve/contents/{+path}","compare_url":"https://api.github.com/repos/blevesearch/bleve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blevesearch/bleve/merges","archive_url":"https://api.github.com/repos/blevesearch/bleve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blevesearch/bleve/downloads","issues_url":"https://api.github.com/repos/blevesearch/bleve/issues{/number}","pulls_url":"https://api.github.com/repos/blevesearch/bleve/pulls{/number}","milestones_url":"https://api.github.com/repos/blevesearch/bleve/milestones{/number}","notifications_url":"https://api.github.com/repos/blevesearch/bleve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blevesearch/bleve/labels{/name}","releases_url":"https://api.github.com/repos/blevesearch/bleve/releases{/id}","deployments_url":"https://api.github.com/repos/blevesearch/bleve/deployments","created_at":"2014-04-17T21:02:18Z","updated_at":"2018-03-05T10:47:19Z","pushed_at":"2018-03-05T11:33:23Z","git_url":"git://github.com/blevesearch/bleve.git","ssh_url":"git@github.com:blevesearch/bleve.git","clone_url":"https://github.com/blevesearch/bleve.git","svn_url":"https://github.com/blevesearch/bleve","homepage":null,"size":11789,"stargazers_count":4141,"watchers_count":4141,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":338,"open_issues":112,"watchers":4141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/795"},"html":{"href":"https://github.com/blevesearch/bleve/pull/795"},"issue":{"href":"https://api.github.com/repos/blevesearch/bleve/issues/795"},"comments":{"href":"https://api.github.com/repos/blevesearch/bleve/issues/795/comments"},"review_comments":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/795/comments"},"review_comment":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/795/commits"},"statuses":{"href":"https://api.github.com/repos/blevesearch/bleve/statuses/884da6f93a3c0b9a4567501ad4ddf96eea739227"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mschoch"}}