{"action":"created","issue":{"url":"https://api.github.com/repos/KenanY/chemical-formula/issues/29","repository_url":"https://api.github.com/repos/KenanY/chemical-formula","labels_url":"https://api.github.com/repos/KenanY/chemical-formula/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/KenanY/chemical-formula/issues/29/comments","events_url":"https://api.github.com/repos/KenanY/chemical-formula/issues/29/events","html_url":"https://github.com/KenanY/chemical-formula/pull/29","id":308311528,"number":29,"title":"Hopefully Improved Parsing","user":{"login":"sabidhasan","id":24949738,"avatar_url":"https://avatars1.githubusercontent.com/u/24949738?v=4","gravatar_id":"","url":"https://api.github.com/users/sabidhasan","html_url":"https://github.com/sabidhasan","followers_url":"https://api.github.com/users/sabidhasan/followers","following_url":"https://api.github.com/users/sabidhasan/following{/other_user}","gists_url":"https://api.github.com/users/sabidhasan/gists{/gist_id}","starred_url":"https://api.github.com/users/sabidhasan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabidhasan/subscriptions","organizations_url":"https://api.github.com/users/sabidhasan/orgs","repos_url":"https://api.github.com/users/sabidhasan/repos","events_url":"https://api.github.com/users/sabidhasan/events{/privacy}","received_events_url":"https://api.github.com/users/sabidhasan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"KenanY","id":733364,"avatar_url":"https://avatars0.githubusercontent.com/u/733364?v=4","gravatar_id":"","url":"https://api.github.com/users/KenanY","html_url":"https://github.com/KenanY","followers_url":"https://api.github.com/users/KenanY/followers","following_url":"https://api.github.com/users/KenanY/following{/other_user}","gists_url":"https://api.github.com/users/KenanY/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanY/subscriptions","organizations_url":"https://api.github.com/users/KenanY/orgs","repos_url":"https://api.github.com/users/KenanY/repos","events_url":"https://api.github.com/users/KenanY/events{/privacy}","received_events_url":"https://api.github.com/users/KenanY/received_events","type":"User","site_admin":false},"assignees":[{"login":"KenanY","id":733364,"avatar_url":"https://avatars0.githubusercontent.com/u/733364?v=4","gravatar_id":"","url":"https://api.github.com/users/KenanY","html_url":"https://github.com/KenanY","followers_url":"https://api.github.com/users/KenanY/followers","following_url":"https://api.github.com/users/KenanY/following{/other_user}","gists_url":"https://api.github.com/users/KenanY/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanY/subscriptions","organizations_url":"https://api.github.com/users/KenanY/orgs","repos_url":"https://api.github.com/users/KenanY/repos","events_url":"https://api.github.com/users/KenanY/events{/privacy}","received_events_url":"https://api.github.com/users/KenanY/received_events","type":"User","site_admin":false},{"login":"sabidhasan","id":24949738,"avatar_url":"https://avatars1.githubusercontent.com/u/24949738?v=4","gravatar_id":"","url":"https://api.github.com/users/sabidhasan","html_url":"https://github.com/sabidhasan","followers_url":"https://api.github.com/users/sabidhasan/followers","following_url":"https://api.github.com/users/sabidhasan/following{/other_user}","gists_url":"https://api.github.com/users/sabidhasan/gists{/gist_id}","starred_url":"https://api.github.com/users/sabidhasan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabidhasan/subscriptions","organizations_url":"https://api.github.com/users/sabidhasan/orgs","repos_url":"https://api.github.com/users/sabidhasan/repos","events_url":"https://api.github.com/users/sabidhasan/events{/privacy}","received_events_url":"https://api.github.com/users/sabidhasan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-03-25T00:42:22Z","updated_at":"2018-03-27T02:12:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/KenanY/chemical-formula/pulls/29","html_url":"https://github.com/KenanY/chemical-formula/pull/29","diff_url":"https://github.com/KenanY/chemical-formula/pull/29.diff","patch_url":"https://github.com/KenanY/chemical-formula/pull/29.patch"},"body":"Hello,\r\n\r\nI completely changed the formula parsing code to better handle some real-world (and some hypothetical) compounds that weren't parsed properly before. I have added new tests as well; before 6 of these tests were failing.\r\n\r\nI also updated package.json to remove unneeded lodash dependencies.\r\n\r\nThe code should be sufficiently commented to understand, but if I missed anything, please let me know. I am still very new to this game, so any advice/comment/criticism/critique/etc. is very much appreciated.\r\n\r\nThanks!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KenanY/chemical-formula/issues/comments/376372786","html_url":"https://github.com/KenanY/chemical-formula/pull/29#issuecomment-376372786","issue_url":"https://api.github.com/repos/KenanY/chemical-formula/issues/29","id":376372786,"user":{"login":"sabidhasan","id":24949738,"avatar_url":"https://avatars1.githubusercontent.com/u/24949738?v=4","gravatar_id":"","url":"https://api.github.com/users/sabidhasan","html_url":"https://github.com/sabidhasan","followers_url":"https://api.github.com/users/sabidhasan/followers","following_url":"https://api.github.com/users/sabidhasan/following{/other_user}","gists_url":"https://api.github.com/users/sabidhasan/gists{/gist_id}","starred_url":"https://api.github.com/users/sabidhasan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabidhasan/subscriptions","organizations_url":"https://api.github.com/users/sabidhasan/orgs","repos_url":"https://api.github.com/users/sabidhasan/repos","events_url":"https://api.github.com/users/sabidhasan/events{/privacy}","received_events_url":"https://api.github.com/users/sabidhasan/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T02:12:35Z","updated_at":"2018-03-27T02:12:35Z","author_association":"NONE","body":"Travis CI now passes all checks."}}
{"actor":{"display_login":"sabidhasan"}}