{"action":"created","comment":{"url":"https://api.github.com/repos/influxdata/chronograf/pulls/comments/199302706","pull_request_review_id":133403131,"id":199302706,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMwMjcwNg==","diff_hunk":"@@ -56,7 +57,12 @@ class TemplateMetaQueryPreview extends PureComponent<Props> {\n         <p className=\"temp-builder--validation\">\n           Meta Query returned <strong>{items.length}</strong> value{pluralizer}\n         </p>\n-        {items.length > 0 && <TemplatePreviewList items={items} />}\n+        {items.length > 0 && (","path":"ui/src/tempVars/components/TemplateMetaQueryPreview.tsx","position":27,"original_position":27,"commit_id":"de546b78943f52318a9e4a76a849ac7e6eccab08","original_commit_id":"de546b78943f52318a9e4a76a849ac7e6eccab08","user":{"login":"alexpaxton","id":2433762,"node_id":"MDQ6VXNlcjI0MzM3NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2433762?v=4","gravatar_id":"","url":"https://api.github.com/users/alexpaxton","html_url":"https://github.com/alexpaxton","followers_url":"https://api.github.com/users/alexpaxton/followers","following_url":"https://api.github.com/users/alexpaxton/following{/other_user}","gists_url":"https://api.github.com/users/alexpaxton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpaxton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpaxton/subscriptions","organizations_url":"https://api.github.com/users/alexpaxton/orgs","repos_url":"https://api.github.com/users/alexpaxton/repos","events_url":"https://api.github.com/users/alexpaxton/events{/privacy}","received_events_url":"https://api.github.com/users/alexpaxton/received_events","type":"User","site_admin":false},"body":"What do you think about making this into a getter to keep logic like this out of the render function?","created_at":"2018-06-29T23:41:20Z","updated_at":"2018-06-29T23:49:00Z","html_url":"https://github.com/influxdata/chronograf/pull/3802#discussion_r199302706","pull_request_url":"https://api.github.com/repos/influxdata/chronograf/pulls/3802","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/comments/199302706"},"html":{"href":"https://github.com/influxdata/chronograf/pull/3802#discussion_r199302706"},"pull_request":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/3802"}}},"pull_request":{"url":"https://api.github.com/repos/influxdata/chronograf/pulls/3802","id":198375383,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Mzc1Mzgz","html_url":"https://github.com/influxdata/chronograf/pull/3802","diff_url":"https://github.com/influxdata/chronograf/pull/3802.diff","patch_url":"https://github.com/influxdata/chronograf/pull/3802.patch","issue_url":"https://api.github.com/repos/influxdata/chronograf/issues/3802","number":3802,"state":"open","locked":false,"title":"Tempvars/select default","user":{"login":"OfTheDelmer","id":4994741,"node_id":"MDQ6VXNlcjQ5OTQ3NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4994741?v=4","gravatar_id":"","url":"https://api.github.com/users/OfTheDelmer","html_url":"https://github.com/OfTheDelmer","followers_url":"https://api.github.com/users/OfTheDelmer/followers","following_url":"https://api.github.com/users/OfTheDelmer/following{/other_user}","gists_url":"https://api.github.com/users/OfTheDelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/OfTheDelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfTheDelmer/subscriptions","organizations_url":"https://api.github.com/users/OfTheDelmer/orgs","repos_url":"https://api.github.com/users/OfTheDelmer/repos","events_url":"https://api.github.com/users/OfTheDelmer/events{/privacy}","received_events_url":"https://api.github.com/users/OfTheDelmer/received_events","type":"User","site_admin":false},"body":"Closes #3635\r\nCloses #3639\r\n\r\n_What was the problem?_\r\nAll changes to template variables were being persisted, but should only be persisted through selection in the template variable editor. CSV template variable editor did not allow uploading files.\r\n\r\n_What was the solution?_\r\nRemove persisting of URL query params and updated trigger by dropdown selections by creating a `picked` property for template values that is used in App and query strings. The `picked` property is not stored in the database and defaults to the `selected` property when a query value is not present in the URL. \r\n\r\nAdded an option to  upload CSV files to create csv template variable values. \r\n\r\n  - [ x ] Rebased/mergeable\r\n  - [x] Tests pass","created_at":"2018-06-29T17:13:33Z","updated_at":"2018-06-29T23:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7ad16fcf9acaa0732ce9d07dd3be0730bc6acc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/influxdata/chronograf/pulls/3802/commits","review_comments_url":"https://api.github.com/repos/influxdata/chronograf/pulls/3802/comments","review_comment_url":"https://api.github.com/repos/influxdata/chronograf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/influxdata/chronograf/issues/3802/comments","statuses_url":"https://api.github.com/repos/influxdata/chronograf/statuses/de546b78943f52318a9e4a76a849ac7e6eccab08","head":{"label":"influxdata:tempvars/select-default","ref":"tempvars/select-default","sha":"de546b78943f52318a9e4a76a849ac7e6eccab08","user":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":66506962,"node_id":"MDEwOlJlcG9zaXRvcnk2NjUwNjk2Mg==","name":"chronograf","full_name":"influxdata/chronograf","owner":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/chronograf","description":"Open source monitoring and visualization UI for the TICK stack","fork":false,"url":"https://api.github.com/repos/influxdata/chronograf","forks_url":"https://api.github.com/repos/influxdata/chronograf/forks","keys_url":"https://api.github.com/repos/influxdata/chronograf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/chronograf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/chronograf/teams","hooks_url":"https://api.github.com/repos/influxdata/chronograf/hooks","issue_events_url":"https://api.github.com/repos/influxdata/chronograf/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/chronograf/events","assignees_url":"https://api.github.com/repos/influxdata/chronograf/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/chronograf/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/chronograf/tags","blobs_url":"https://api.github.com/repos/influxdata/chronograf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/chronograf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/chronograf/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/chronograf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/chronograf/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/chronograf/languages","stargazers_url":"https://api.github.com/repos/influxdata/chronograf/stargazers","contributors_url":"https://api.github.com/repos/influxdata/chronograf/contributors","subscribers_url":"https://api.github.com/repos/influxdata/chronograf/subscribers","subscription_url":"https://api.github.com/repos/influxdata/chronograf/subscription","commits_url":"https://api.github.com/repos/influxdata/chronograf/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/chronograf/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/chronograf/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/chronograf/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/chronograf/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/chronograf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/chronograf/merges","archive_url":"https://api.github.com/repos/influxdata/chronograf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/chronograf/downloads","issues_url":"https://api.github.com/repos/influxdata/chronograf/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/chronograf/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/chronograf/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/chronograf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/chronograf/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/chronograf/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/chronograf/deployments","created_at":"2016-08-24T23:28:56Z","updated_at":"2018-06-29T22:47:29Z","pushed_at":"2018-06-29T23:48:29Z","git_url":"git://github.com/influxdata/chronograf.git","ssh_url":"git@github.com:influxdata/chronograf.git","clone_url":"https://github.com/influxdata/chronograf.git","svn_url":"https://github.com/influxdata/chronograf","homepage":"https://www.influxdata.com/time-series-platform/chronograf/","size":62011,"stargazers_count":676,"watchers_count":676,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":665,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":136,"open_issues":665,"watchers":676,"default_branch":"master"}},"base":{"label":"influxdata:master","ref":"master","sha":"0da1e95dd82f833dcb8f305e85398c8e2e4a7b1c","user":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":66506962,"node_id":"MDEwOlJlcG9zaXRvcnk2NjUwNjk2Mg==","name":"chronograf","full_name":"influxdata/chronograf","owner":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/chronograf","description":"Open source monitoring and visualization UI for the TICK stack","fork":false,"url":"https://api.github.com/repos/influxdata/chronograf","forks_url":"https://api.github.com/repos/influxdata/chronograf/forks","keys_url":"https://api.github.com/repos/influxdata/chronograf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/chronograf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/chronograf/teams","hooks_url":"https://api.github.com/repos/influxdata/chronograf/hooks","issue_events_url":"https://api.github.com/repos/influxdata/chronograf/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/chronograf/events","assignees_url":"https://api.github.com/repos/influxdata/chronograf/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/chronograf/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/chronograf/tags","blobs_url":"https://api.github.com/repos/influxdata/chronograf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/chronograf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/chronograf/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/chronograf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/chronograf/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/chronograf/languages","stargazers_url":"https://api.github.com/repos/influxdata/chronograf/stargazers","contributors_url":"https://api.github.com/repos/influxdata/chronograf/contributors","subscribers_url":"https://api.github.com/repos/influxdata/chronograf/subscribers","subscription_url":"https://api.github.com/repos/influxdata/chronograf/subscription","commits_url":"https://api.github.com/repos/influxdata/chronograf/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/chronograf/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/chronograf/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/chronograf/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/chronograf/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/chronograf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/chronograf/merges","archive_url":"https://api.github.com/repos/influxdata/chronograf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/chronograf/downloads","issues_url":"https://api.github.com/repos/influxdata/chronograf/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/chronograf/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/chronograf/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/chronograf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/chronograf/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/chronograf/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/chronograf/deployments","created_at":"2016-08-24T23:28:56Z","updated_at":"2018-06-29T22:47:29Z","pushed_at":"2018-06-29T23:48:29Z","git_url":"git://github.com/influxdata/chronograf.git","ssh_url":"git@github.com:influxdata/chronograf.git","clone_url":"https://github.com/influxdata/chronograf.git","svn_url":"https://github.com/influxdata/chronograf","homepage":"https://www.influxdata.com/time-series-platform/chronograf/","size":62011,"stargazers_count":676,"watchers_count":676,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":665,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":136,"open_issues":665,"watchers":676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/3802"},"html":{"href":"https://github.com/influxdata/chronograf/pull/3802"},"issue":{"href":"https://api.github.com/repos/influxdata/chronograf/issues/3802"},"comments":{"href":"https://api.github.com/repos/influxdata/chronograf/issues/3802/comments"},"review_comments":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/3802/comments"},"review_comment":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/3802/commits"},"statuses":{"href":"https://api.github.com/repos/influxdata/chronograf/statuses/de546b78943f52318a9e4a76a849ac7e6eccab08"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexpaxton"}}