{"action":"created","issue":{"url":"https://api.github.com/repos/wallabag/wallabag/issues/3711","repository_url":"https://api.github.com/repos/wallabag/wallabag","labels_url":"https://api.github.com/repos/wallabag/wallabag/issues/3711/labels{/name}","comments_url":"https://api.github.com/repos/wallabag/wallabag/issues/3711/comments","events_url":"https://api.github.com/repos/wallabag/wallabag/issues/3711/events","html_url":"https://github.com/wallabag/wallabag/issues/3711","id":356222972,"node_id":"MDU6SXNzdWUzNTYyMjI5NzI=","number":3711,"title":"Remove response returned by API's delete entry call","user":{"login":"Kdecherf","id":226063,"node_id":"MDQ6VXNlcjIyNjA2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/226063?v=4","gravatar_id":"","url":"https://api.github.com/users/Kdecherf","html_url":"https://github.com/Kdecherf","followers_url":"https://api.github.com/users/Kdecherf/followers","following_url":"https://api.github.com/users/Kdecherf/following{/other_user}","gists_url":"https://api.github.com/users/Kdecherf/gists{/gist_id}","starred_url":"https://api.github.com/users/Kdecherf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kdecherf/subscriptions","organizations_url":"https://api.github.com/users/Kdecherf/orgs","repos_url":"https://api.github.com/users/Kdecherf/repos","events_url":"https://api.github.com/users/Kdecherf/events{/privacy}","received_events_url":"https://api.github.com/users/Kdecherf/received_events","type":"User","site_admin":false},"labels":[{"id":478833358,"node_id":"MDU6TGFiZWw0Nzg4MzMzNTg=","url":"https://api.github.com/repos/wallabag/wallabag/labels/API","name":"API","color":"eaa760","default":false},{"id":34427666,"node_id":"MDU6TGFiZWwzNDQyNzY2Ng==","url":"https://api.github.com/repos/wallabag/wallabag/labels/Improvement","name":"Improvement","color":"ffff00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-01T18:21:29Z","updated_at":"2018-09-05T09:08:17Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Issue details\r\n\r\nThis issue is a follow up of #3608, failed fix #3516 and https://github.com/wallabag/android-app/issues/646.\r\n\r\nWhen an API client deletes an entry (`DELETE /api/entries/{id}.json`), the server returns the full entry but its id, example:\r\n\r\n``` json\r\n{\"is_archived\":0,\"is_starred\":0,\"user_name\":\"kdecherf\",\"user_email\":\"kevin@kdecherf.com\",\"user_id\":1,\"tags\":[],\"is_public\":false,\"id\":null,\"uid\":null,\"title\":\"…\r\n```\r\n\r\nThe `null` value currently triggers an exception on the Android app, which leads to another side-effect: the client emits two `DELETE` requests for the same entry (see #3608).\r\n\r\nIt seems that #3516 does not restore the missing id at all.\r\n\r\nWhile checking network packets I saw that the actual content of the entry was also sent. In my case the response to the delete request had a body of 70 KB which may degrade clients' performance on lossy connections.\r\n\r\nI don't see any value in sending back the entity when deleting it, so I would like to remove any content sent by this call. The API would then return a `204 No content` for successful deletion, which also fixes https://github.com/wallabag/android-app/issues/646 (_tested here_).\r\n\r\n@wallabag/android @wallabag/core do you have any objection?\r\n\r\n### Environment\r\n\r\n* wallabag version (or git revision) that exhibits the issue: _2.3.3_\r\n* How did you install wallabag? Via `git clone` or by downloading the package? _git_\r\n* Last wallabag version that did not exhibit the issue (if applicable): _N/A_\r\n* php version: _7.0_\r\n* OS: _Debian_\r\n* type of hosting (shared or dedicated): _dedicated_\r\n* which storage system you choose at install (SQLite, MySQL/MariaDB or PostgreSQL): _PostgreSQL_"},"comment":{"url":"https://api.github.com/repos/wallabag/wallabag/issues/comments/418657014","html_url":"https://github.com/wallabag/wallabag/issues/3711#issuecomment-418657014","issue_url":"https://api.github.com/repos/wallabag/wallabag/issues/3711","id":418657014,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODY1NzAxNA==","user":{"login":"Kdecherf","id":226063,"node_id":"MDQ6VXNlcjIyNjA2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/226063?v=4","gravatar_id":"","url":"https://api.github.com/users/Kdecherf","html_url":"https://github.com/Kdecherf","followers_url":"https://api.github.com/users/Kdecherf/followers","following_url":"https://api.github.com/users/Kdecherf/following{/other_user}","gists_url":"https://api.github.com/users/Kdecherf/gists{/gist_id}","starred_url":"https://api.github.com/users/Kdecherf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kdecherf/subscriptions","organizations_url":"https://api.github.com/users/Kdecherf/orgs","repos_url":"https://api.github.com/users/Kdecherf/repos","events_url":"https://api.github.com/users/Kdecherf/events{/privacy}","received_events_url":"https://api.github.com/users/Kdecherf/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T09:08:17Z","updated_at":"2018-09-05T09:08:17Z","author_association":"CONTRIBUTOR","body":"The android app seems to be working like a charm with the `204 No Content` return code."}}
{"actor":{"display_login":"Kdecherf"}}