{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/228964472","pull_request_review_id":169315419,"id":228964472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODk2NDQ3Mg==","diff_hunk":"@@ -235,9 +238,10 @@ public RocksDBStateBackend(StateBackend checkpointStreamBackend) {\n \t * @param checkpointStreamBackend The backend write the checkpoint streams to.\n \t * @param enableIncrementalCheckpointing True if incremental checkpointing is enabled.\n \t */\n-\tpublic RocksDBStateBackend(StateBackend checkpointStreamBackend, TernaryBoolean enableIncrementalCheckpointing) {\n+\tpublic RocksDBStateBackend(StateBackend checkpointStreamBackend, TernaryBoolean enableIncrementalCheckpointing, int restoreThreadNum) {","path":"flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java","position":24,"original_position":24,"commit_id":"d949520fb4be25b35b0fae3d77b42cc3e86f3540","original_commit_id":"d949520fb4be25b35b0fae3d77b42cc3e86f3540","user":{"login":"azagrebin","id":10573485,"node_id":"MDQ6VXNlcjEwNTczNDg1","avatar_url":"https://avatars3.githubusercontent.com/u/10573485?v=4","gravatar_id":"","url":"https://api.github.com/users/azagrebin","html_url":"https://github.com/azagrebin","followers_url":"https://api.github.com/users/azagrebin/followers","following_url":"https://api.github.com/users/azagrebin/following{/other_user}","gists_url":"https://api.github.com/users/azagrebin/gists{/gist_id}","starred_url":"https://api.github.com/users/azagrebin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azagrebin/subscriptions","organizations_url":"https://api.github.com/users/azagrebin/orgs","repos_url":"https://api.github.com/users/azagrebin/repos","events_url":"https://api.github.com/users/azagrebin/events{/privacy}","received_events_url":"https://api.github.com/users/azagrebin/received_events","type":"User","site_admin":false},"body":"I would also leave the previous method without restoreThreadNum:\r\n```\r\npublic RocksDBStateBackend(StateBackend checkpointStreamBackend, TernaryBoolean enableIncrementalCheckpointing) {\r\n    this(checkpointStreamBackend, enableIncrementalCheckpointing, -1);\r\n}\r\n```\r\nthis way we do not break existing code, including other methods here, like this modification which is not needed then and other similar ones:\r\n```\r\npublic RocksDBStateBackend(StateBackend checkpointStreamBackend) {\r\n\t\tthis(checkpointStreamBackend, TernaryBoolean.UNDEFINED, 1);\r\n\t}\r\n```\r\n\r\nand I would rather keep it undefined here, e.g. `-1`, similar to `TernaryBoolean.UNDEFINED` for `enableIncrementalCheckpointing`. It can be resolved then in `private RocksDBStateBackend(RocksDBStateBackend original, Configuration config)` and `getRestoreThreadNum`.","created_at":"2018-10-29T15:03:05Z","updated_at":"2018-10-29T15:31:31Z","html_url":"https://github.com/apache/flink/pull/6777#discussion_r228964472","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6777","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/228964472"},"html":{"href":"https://github.com/apache/flink/pull/6777#discussion_r228964472"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6777"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6777","id":219119725,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTE5NzI1","html_url":"https://github.com/apache/flink/pull/6777","diff_url":"https://github.com/apache/flink/pull/6777.diff","patch_url":"https://github.com/apache/flink/pull/6777.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6777","number":6777,"state":"open","locked":false,"title":"[FLINK-10461] [State Backends, Checkpointing] Speed up download files when restore from DFS","user":{"login":"klion26","id":1425623,"node_id":"MDQ6VXNlcjE0MjU2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1425623?v=4","gravatar_id":"","url":"https://api.github.com/users/klion26","html_url":"https://github.com/klion26","followers_url":"https://api.github.com/users/klion26/followers","following_url":"https://api.github.com/users/klion26/following{/other_user}","gists_url":"https://api.github.com/users/klion26/gists{/gist_id}","starred_url":"https://api.github.com/users/klion26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klion26/subscriptions","organizations_url":"https://api.github.com/users/klion26/orgs","repos_url":"https://api.github.com/users/klion26/repos","events_url":"https://api.github.com/users/klion26/events{/privacy}","received_events_url":"https://api.github.com/users/klion26/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nThis PR speed up the download files when restore from DFS using multi-thread.\r\n\r\n## Brief change log\r\nUse multi-thread from download files when restore from DFS.\r\n\r\n## Verifying this change\r\n\r\nAdd a UT for test exception rethrow in thread pool\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (**no**)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)\r\n  - The serializers: (**no**)\r\n  - The runtime per-record code paths (performance sensitive): (**no**)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)\r\n  - The S3 file system connector: (**no**)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (**no)\r\n  - If yes, how is the feature documented? (**not applicable**)\r\n","created_at":"2018-09-29T02:34:23Z","updated_at":"2018-10-29T15:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be633372be5df03dd0bca6c0c525df00a59b7cab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6777/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6777/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6777/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/d949520fb4be25b35b0fae3d77b42cc3e86f3540","head":{"label":"klion26:multil_thread_restore","ref":"multil_thread_restore","sha":"d949520fb4be25b35b0fae3d77b42cc3e86f3540","user":{"login":"klion26","id":1425623,"node_id":"MDQ6VXNlcjE0MjU2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1425623?v=4","gravatar_id":"","url":"https://api.github.com/users/klion26","html_url":"https://github.com/klion26","followers_url":"https://api.github.com/users/klion26/followers","following_url":"https://api.github.com/users/klion26/following{/other_user}","gists_url":"https://api.github.com/users/klion26/gists{/gist_id}","starred_url":"https://api.github.com/users/klion26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klion26/subscriptions","organizations_url":"https://api.github.com/users/klion26/orgs","repos_url":"https://api.github.com/users/klion26/repos","events_url":"https://api.github.com/users/klion26/events{/privacy}","received_events_url":"https://api.github.com/users/klion26/received_events","type":"User","site_admin":false},"repo":{"id":95559396,"node_id":"MDEwOlJlcG9zaXRvcnk5NTU1OTM5Ng==","name":"flink","full_name":"klion26/flink","private":false,"owner":{"login":"klion26","id":1425623,"node_id":"MDQ6VXNlcjE0MjU2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1425623?v=4","gravatar_id":"","url":"https://api.github.com/users/klion26","html_url":"https://github.com/klion26","followers_url":"https://api.github.com/users/klion26/followers","following_url":"https://api.github.com/users/klion26/following{/other_user}","gists_url":"https://api.github.com/users/klion26/gists{/gist_id}","starred_url":"https://api.github.com/users/klion26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klion26/subscriptions","organizations_url":"https://api.github.com/users/klion26/orgs","repos_url":"https://api.github.com/users/klion26/repos","events_url":"https://api.github.com/users/klion26/events{/privacy}","received_events_url":"https://api.github.com/users/klion26/received_events","type":"User","site_admin":false},"html_url":"https://github.com/klion26/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/klion26/flink","forks_url":"https://api.github.com/repos/klion26/flink/forks","keys_url":"https://api.github.com/repos/klion26/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klion26/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klion26/flink/teams","hooks_url":"https://api.github.com/repos/klion26/flink/hooks","issue_events_url":"https://api.github.com/repos/klion26/flink/issues/events{/number}","events_url":"https://api.github.com/repos/klion26/flink/events","assignees_url":"https://api.github.com/repos/klion26/flink/assignees{/user}","branches_url":"https://api.github.com/repos/klion26/flink/branches{/branch}","tags_url":"https://api.github.com/repos/klion26/flink/tags","blobs_url":"https://api.github.com/repos/klion26/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klion26/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klion26/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/klion26/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klion26/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/klion26/flink/languages","stargazers_url":"https://api.github.com/repos/klion26/flink/stargazers","contributors_url":"https://api.github.com/repos/klion26/flink/contributors","subscribers_url":"https://api.github.com/repos/klion26/flink/subscribers","subscription_url":"https://api.github.com/repos/klion26/flink/subscription","commits_url":"https://api.github.com/repos/klion26/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/klion26/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/klion26/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/klion26/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/klion26/flink/contents/{+path}","compare_url":"https://api.github.com/repos/klion26/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klion26/flink/merges","archive_url":"https://api.github.com/repos/klion26/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klion26/flink/downloads","issues_url":"https://api.github.com/repos/klion26/flink/issues{/number}","pulls_url":"https://api.github.com/repos/klion26/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/klion26/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/klion26/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klion26/flink/labels{/name}","releases_url":"https://api.github.com/repos/klion26/flink/releases{/id}","deployments_url":"https://api.github.com/repos/klion26/flink/deployments","created_at":"2017-06-27T13:09:41Z","updated_at":"2018-10-12T07:19:43Z","pushed_at":"2018-10-19T16:20:12Z","git_url":"git://github.com/klion26/flink.git","ssh_url":"git@github.com:klion26/flink.git","clone_url":"https://github.com/klion26/flink.git","svn_url":"https://github.com/klion26/flink","homepage":null,"size":162996,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d2480af40f5145d865196a95ec58a415482d8cff","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-10-29T13:05:22Z","pushed_at":"2018-10-29T14:27:00Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":168474,"stargazers_count":4741,"watchers_count":4741,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3040,"mirror_url":null,"archived":false,"open_issues_count":399,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3040,"open_issues":399,"watchers":4741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6777"},"html":{"href":"https://github.com/apache/flink/pull/6777"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6777"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6777/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6777/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6777/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/d949520fb4be25b35b0fae3d77b42cc3e86f3540"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"azagrebin"}}