{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13096","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13096/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13096/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13096/events","html_url":"https://github.com/civicrm/civicrm-core/pull/13096","id":381060187,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTE0NTEy","number":13096,"title":"Permit Checkbox price set options to be deselected if they are full","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-15T08:58:16Z","updated_at":"2018-11-19T11:19:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13096","html_url":"https://github.com/civicrm/civicrm-core/pull/13096","diff_url":"https://github.com/civicrm/civicrm-core/pull/13096.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/13096.patch"},"body":"Overview\r\n----------------------------------------\r\n\r\nReplaces https://github.com/civicrm/civicrm-core/pull/10804\r\n https://issues.civicrm.org/jira/browse/CRM-17267\r\n\r\nBefore\r\n----------------------------------------\r\n![screenshot 2018-04-04 20 33 50](https://user-images.githubusercontent.com/336308/38297122-8a9dc29c-3847-11e8-897c-d96cb22c8df3.png)\r\n\r\nAfter\r\n----------------------------------------\r\n![screenshot 2018-04-04 20 34 53](https://user-images.githubusercontent.com/336308/38297162-a70764a6-3847-11e8-87be-9aa3ccdd00d1.png)\r\n\r\nTechnical Details\r\n----------------------------------------\r\nThe functionality is already there for some types of fields (Select, Radio?) but doesn't work for Checkboxes - partly because the Checkboxes aren't handled, but also code that determines which are selected ignores the fact that qty could be 0 - that likely affects multiple field types\r\n\r\nComments\r\n----------------------------------------\r\n@JKingsnorth @monishdeb \r\n"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/439859165","html_url":"https://github.com/civicrm/civicrm-core/pull/13096#issuecomment-439859165","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13096","id":439859165,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTg1OTE2NQ==","user":{"login":"JKingsnorth","id":5212601,"node_id":"MDQ6VXNlcjUyMTI2MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5212601?v=4","gravatar_id":"","url":"https://api.github.com/users/JKingsnorth","html_url":"https://github.com/JKingsnorth","followers_url":"https://api.github.com/users/JKingsnorth/followers","following_url":"https://api.github.com/users/JKingsnorth/following{/other_user}","gists_url":"https://api.github.com/users/JKingsnorth/gists{/gist_id}","starred_url":"https://api.github.com/users/JKingsnorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKingsnorth/subscriptions","organizations_url":"https://api.github.com/users/JKingsnorth/orgs","repos_url":"https://api.github.com/users/JKingsnorth/repos","events_url":"https://api.github.com/users/JKingsnorth/events{/privacy}","received_events_url":"https://api.github.com/users/JKingsnorth/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T11:19:17Z","updated_at":"2018-11-19T11:19:17Z","author_association":"CONTRIBUTOR","body":"With or without the patch select fields are still changeable, and do not display any notification that the option is sold out.\r\n\r\nMy original patch does fix the display for checkboxes and radios:\r\n\r\n![image](https://user-images.githubusercontent.com/5212601/48703812-d3061300-ebec-11e8-9340-d322e34bb9ec.png)\r\n\r\nSo I'm going to tidy up my original PR for review again, and get rid of some of the 'unnecessary' changes from it."}}
{"actor":{"display_login":"JKingsnorth"}}