{"action":"created","comment":{"url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/comments/198098918","pull_request_review_id":131964712,"id":198098918,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODA5ODkxOA==","diff_hunk":"@@ -29,20 +69,33 @@ else\n     fi\n fi\n \n-DEBIAN_FRONTEND=noninteractive apt-get install -y cri-o-$CRIO_VERSION\n-systemctl enable crio\n-# remove unnecessary cni plugins\n-rm /etc/cni/net.d/100-crio-bridge.conf /etc/cni/net.d/200-loopback.conf || true\n-systemctl start crio\n+if [ ! \"$(cat /etc/crio/.version)\" = \"$CRIO_VERSION\" ]; then\n+    DL_URL=\"https://dl.bintray.com/kontena/pharos-bin/cri-o/cri-o-v${CRIO_VERSION}-linux-amd64.tar.gz\"\n+    curl -sSL $DL_URL -o /tmp/cri-o.tar.gz\n+    curl -sSL \"${DL_URL}.asc\" -o /tmp/cri-o.tar.gz.asc","path":"lib/pharos/host/ubuntu/scripts/configure-cri-o.sh","position":77,"original_position":77,"commit_id":"8409b0361683755b02f4b4cafaa270cc41e5186f","original_commit_id":"8409b0361683755b02f4b4cafaa270cc41e5186f","user":{"login":"SpComb","id":3950373,"node_id":"MDQ6VXNlcjM5NTAzNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3950373?v=4","gravatar_id":"","url":"https://api.github.com/users/SpComb","html_url":"https://github.com/SpComb","followers_url":"https://api.github.com/users/SpComb/followers","following_url":"https://api.github.com/users/SpComb/following{/other_user}","gists_url":"https://api.github.com/users/SpComb/gists{/gist_id}","starred_url":"https://api.github.com/users/SpComb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpComb/subscriptions","organizations_url":"https://api.github.com/users/SpComb/orgs","repos_url":"https://api.github.com/users/SpComb/repos","events_url":"https://api.github.com/users/SpComb/events{/privacy}","received_events_url":"https://api.github.com/users/SpComb/received_events","type":"User","site_admin":false},"body":"The tmpfiles leak:\r\n\r\n```\r\nroot@terom-bionic-test:~# ls -la /tmp/cri-o.tar.gz*\r\n-rw-r--r-- 1 root root 29775782 Jun 26 08:47 /tmp/cri-o.tar.gz\r\n-rw-r--r-- 1 root root      821 Jun 26 08:47 /tmp/cri-o.tar.gz.asc\r\n```","created_at":"2018-06-26T10:50:46Z","updated_at":"2018-06-26T10:50:47Z","html_url":"https://github.com/kontena/pharos-cluster/pull/449#discussion_r198098918","pull_request_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/449","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/comments/198098918"},"html":{"href":"https://github.com/kontena/pharos-cluster/pull/449#discussion_r198098918"},"pull_request":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/449","id":197067349,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDY3MzQ5","html_url":"https://github.com/kontena/pharos-cluster/pull/449","diff_url":"https://github.com/kontena/pharos-cluster/pull/449.diff","patch_url":"https://github.com/kontena/pharos-cluster/pull/449.patch","issue_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/449","number":449,"state":"open","locked":false,"title":"Install cri-o from pharos binary repo","user":{"login":"jakolehm","id":1446224,"node_id":"MDQ6VXNlcjE0NDYyMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1446224?v=4","gravatar_id":"","url":"https://api.github.com/users/jakolehm","html_url":"https://github.com/jakolehm","followers_url":"https://api.github.com/users/jakolehm/followers","following_url":"https://api.github.com/users/jakolehm/following{/other_user}","gists_url":"https://api.github.com/users/jakolehm/gists{/gist_id}","starred_url":"https://api.github.com/users/jakolehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakolehm/subscriptions","organizations_url":"https://api.github.com/users/jakolehm/orgs","repos_url":"https://api.github.com/users/jakolehm/repos","events_url":"https://api.github.com/users/jakolehm/events{/privacy}","received_events_url":"https://api.github.com/users/jakolehm/received_events","type":"User","site_admin":false},"body":"## Todo:\r\n\r\n- [x] Ubuntu\r\n- [x] CentOS/RHEL\r\n- [x] handle Ubuntu Xenial upgrade","created_at":"2018-06-25T10:24:34Z","updated_at":"2018-06-26T10:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51bfbc604d6f52f84302bb9b385b4a7da347d915","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":844668573,"node_id":"MDU6TGFiZWw4NDQ2Njg1NzM=","url":"https://api.github.com/repos/kontena/pharos-cluster/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":{"url":"https://api.github.com/repos/kontena/pharos-cluster/milestones/10","html_url":"https://github.com/kontena/pharos-cluster/milestone/10","labels_url":"https://api.github.com/repos/kontena/pharos-cluster/milestones/10/labels","id":3325383,"node_id":"MDk6TWlsZXN0b25lMzMyNTM4Mw==","number":10,"title":"1.2.0","description":"","creator":{"login":"jakolehm","id":1446224,"node_id":"MDQ6VXNlcjE0NDYyMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1446224?v=4","gravatar_id":"","url":"https://api.github.com/users/jakolehm","html_url":"https://github.com/jakolehm","followers_url":"https://api.github.com/users/jakolehm/followers","following_url":"https://api.github.com/users/jakolehm/following{/other_user}","gists_url":"https://api.github.com/users/jakolehm/gists{/gist_id}","starred_url":"https://api.github.com/users/jakolehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakolehm/subscriptions","organizations_url":"https://api.github.com/users/jakolehm/orgs","repos_url":"https://api.github.com/users/jakolehm/repos","events_url":"https://api.github.com/users/jakolehm/events{/privacy}","received_events_url":"https://api.github.com/users/jakolehm/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":25,"state":"open","created_at":"2018-05-07T12:31:18Z","updated_at":"2018-06-26T08:28:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/449/commits","review_comments_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/449/comments","review_comment_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/449/comments","statuses_url":"https://api.github.com/repos/kontena/pharos-cluster/statuses/8409b0361683755b02f4b4cafaa270cc41e5186f","head":{"label":"kontena:feature/crio-from-binaries","ref":"feature/crio-from-binaries","sha":"8409b0361683755b02f4b4cafaa270cc41e5186f","user":{"login":"kontena","id":10419574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE5NTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10419574?v=4","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"repo":{"id":122439193,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0MzkxOTM=","name":"pharos-cluster","full_name":"kontena/pharos-cluster","owner":{"login":"kontena","id":10419574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE5NTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10419574?v=4","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kontena/pharos-cluster","description":"The simple, solid, certified Kubernetes distribution that just works.","fork":false,"url":"https://api.github.com/repos/kontena/pharos-cluster","forks_url":"https://api.github.com/repos/kontena/pharos-cluster/forks","keys_url":"https://api.github.com/repos/kontena/pharos-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontena/pharos-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontena/pharos-cluster/teams","hooks_url":"https://api.github.com/repos/kontena/pharos-cluster/hooks","issue_events_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/kontena/pharos-cluster/events","assignees_url":"https://api.github.com/repos/kontena/pharos-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/kontena/pharos-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/kontena/pharos-cluster/tags","blobs_url":"https://api.github.com/repos/kontena/pharos-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontena/pharos-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontena/pharos-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontena/pharos-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontena/pharos-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/kontena/pharos-cluster/languages","stargazers_url":"https://api.github.com/repos/kontena/pharos-cluster/stargazers","contributors_url":"https://api.github.com/repos/kontena/pharos-cluster/contributors","subscribers_url":"https://api.github.com/repos/kontena/pharos-cluster/subscribers","subscription_url":"https://api.github.com/repos/kontena/pharos-cluster/subscription","commits_url":"https://api.github.com/repos/kontena/pharos-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontena/pharos-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontena/pharos-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontena/pharos-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/kontena/pharos-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontena/pharos-cluster/merges","archive_url":"https://api.github.com/repos/kontena/pharos-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontena/pharos-cluster/downloads","issues_url":"https://api.github.com/repos/kontena/pharos-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/kontena/pharos-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/kontena/pharos-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontena/pharos-cluster/labels{/name}","releases_url":"https://api.github.com/repos/kontena/pharos-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/kontena/pharos-cluster/deployments","created_at":"2018-02-22T06:23:53Z","updated_at":"2018-06-26T08:29:02Z","pushed_at":"2018-06-26T10:42:36Z","git_url":"git://github.com/kontena/pharos-cluster.git","ssh_url":"git@github.com:kontena/pharos-cluster.git","clone_url":"https://github.com/kontena/pharos-cluster.git","svn_url":"https://github.com/kontena/pharos-cluster","homepage":"https://pharos.sh","size":801,"stargazers_count":80,"watchers_count":80,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":49,"watchers":80,"default_branch":"master"}},"base":{"label":"kontena:master","ref":"master","sha":"bdf9fa105dcb3392e075db23db8f92e50398169a","user":{"login":"kontena","id":10419574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE5NTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10419574?v=4","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"repo":{"id":122439193,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0MzkxOTM=","name":"pharos-cluster","full_name":"kontena/pharos-cluster","owner":{"login":"kontena","id":10419574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE5NTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10419574?v=4","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kontena/pharos-cluster","description":"The simple, solid, certified Kubernetes distribution that just works.","fork":false,"url":"https://api.github.com/repos/kontena/pharos-cluster","forks_url":"https://api.github.com/repos/kontena/pharos-cluster/forks","keys_url":"https://api.github.com/repos/kontena/pharos-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontena/pharos-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontena/pharos-cluster/teams","hooks_url":"https://api.github.com/repos/kontena/pharos-cluster/hooks","issue_events_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/kontena/pharos-cluster/events","assignees_url":"https://api.github.com/repos/kontena/pharos-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/kontena/pharos-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/kontena/pharos-cluster/tags","blobs_url":"https://api.github.com/repos/kontena/pharos-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontena/pharos-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontena/pharos-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontena/pharos-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontena/pharos-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/kontena/pharos-cluster/languages","stargazers_url":"https://api.github.com/repos/kontena/pharos-cluster/stargazers","contributors_url":"https://api.github.com/repos/kontena/pharos-cluster/contributors","subscribers_url":"https://api.github.com/repos/kontena/pharos-cluster/subscribers","subscription_url":"https://api.github.com/repos/kontena/pharos-cluster/subscription","commits_url":"https://api.github.com/repos/kontena/pharos-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontena/pharos-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontena/pharos-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontena/pharos-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/kontena/pharos-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontena/pharos-cluster/merges","archive_url":"https://api.github.com/repos/kontena/pharos-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontena/pharos-cluster/downloads","issues_url":"https://api.github.com/repos/kontena/pharos-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/kontena/pharos-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/kontena/pharos-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontena/pharos-cluster/labels{/name}","releases_url":"https://api.github.com/repos/kontena/pharos-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/kontena/pharos-cluster/deployments","created_at":"2018-02-22T06:23:53Z","updated_at":"2018-06-26T08:29:02Z","pushed_at":"2018-06-26T10:42:36Z","git_url":"git://github.com/kontena/pharos-cluster.git","ssh_url":"git@github.com:kontena/pharos-cluster.git","clone_url":"https://github.com/kontena/pharos-cluster.git","svn_url":"https://github.com/kontena/pharos-cluster","homepage":"https://pharos.sh","size":801,"stargazers_count":80,"watchers_count":80,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":49,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/449"},"html":{"href":"https://github.com/kontena/pharos-cluster/pull/449"},"issue":{"href":"https://api.github.com/repos/kontena/pharos-cluster/issues/449"},"comments":{"href":"https://api.github.com/repos/kontena/pharos-cluster/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/kontena/pharos-cluster/statuses/8409b0361683755b02f4b4cafaa270cc41e5186f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"SpComb"}}