{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/218023123","pull_request_review_id":155867323,"id":218023123,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODAyMzEyMw==","diff_hunk":"@@ -876,6 +876,12 @@\n     <rule IddField=\"Outlet Node Name\" Access=\"HIDDEN\"/>\n     <rule IddField=\"Heating Coil Name\" Access=\"HIDDEN\"/>\n   </POLICY>\n+  <POLICY IddObjectType=\"OS_ZoneHVAC_EquipmentList\">","path":"openstudiocore/src/openstudio_lib/library/OpenStudioPolicy.xml","position":4,"original_position":4,"commit_id":"99c43fba83afe330ab449fa971541ba89da91bc7","original_commit_id":"99c43fba83afe330ab449fa971541ba89da91bc7","user":{"login":"jmarrec","id":5479063,"node_id":"MDQ6VXNlcjU0NzkwNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5479063?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarrec","html_url":"https://github.com/jmarrec","followers_url":"https://api.github.com/users/jmarrec/followers","following_url":"https://api.github.com/users/jmarrec/following{/other_user}","gists_url":"https://api.github.com/users/jmarrec/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarrec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarrec/subscriptions","organizations_url":"https://api.github.com/users/jmarrec/orgs","repos_url":"https://api.github.com/users/jmarrec/repos","events_url":"https://api.github.com/users/jmarrec/events{/privacy}","received_events_url":"https://api.github.com/users/jmarrec/received_events","type":"User","site_admin":false},"body":"Here's with 3262 merged in: \r\n\r\n![image](https://user-images.githubusercontent.com/5479063/45618866-89c40680-ba77-11e8-9543-b9da81d0da6c.png)\r\n\r\nBecause that field isn't explicitly set in CTor for ZoneHVACEquipmentList, it shows up as blue.","created_at":"2018-09-17T10:46:08Z","updated_at":"2018-09-17T10:46:09Z","html_url":"https://github.com/NREL/OpenStudio/pull/3269#discussion_r218023123","pull_request_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/3269","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/218023123"},"html":{"href":"https://github.com/NREL/OpenStudio/pull/3269#discussion_r218023123"},"pull_request":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/3269"}},"in_reply_to_id":217770671},"pull_request":{"url":"https://api.github.com/repos/NREL/OpenStudio/pulls/3269","id":215633303,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjMzMzAz","html_url":"https://github.com/NREL/OpenStudio/pull/3269","diff_url":"https://github.com/NREL/OpenStudio/pull/3269.diff","patch_url":"https://github.com/NREL/OpenStudio/pull/3269.patch","issue_url":"https://api.github.com/repos/NREL/OpenStudio/issues/3269","number":3269,"state":"open","locked":false,"title":"Fix #3268 orphaned zone eq list in building.remove","user":{"login":"jmarrec","id":5479063,"node_id":"MDQ6VXNlcjU0NzkwNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5479063?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarrec","html_url":"https://github.com/jmarrec","followers_url":"https://api.github.com/users/jmarrec/followers","following_url":"https://api.github.com/users/jmarrec/following{/other_user}","gists_url":"https://api.github.com/users/jmarrec/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarrec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarrec/subscriptions","organizations_url":"https://api.github.com/users/jmarrec/orgs","repos_url":"https://api.github.com/users/jmarrec/repos","events_url":"https://api.github.com/users/jmarrec/events{/privacy}","received_events_url":"https://api.github.com/users/jmarrec/received_events","type":"User","site_admin":false},"body":"Fix #3268 orphaned zone eq list in building.remove\r\n\r\nChangelog:\r\n* Make ZoneHVACEqList a child\r\n* Update OpenStudioPolicy to hide all fields but the name and the (future, see #3262) load distribution field because now it'll show up in OS App if you click a ThermalZone on an AirLoopHVAC. That'll allow you to have a (bad) place to set it in the OS app. Note: ability to set it should be added somewhere in the UI in the ThermalZones tab.\r\n\r\nReview: @kbenne ","created_at":"2018-09-14T15:35:14Z","updated_at":"2018-09-17T10:46:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55b262253034ee49121fe6609a1b3e6c460e5ebb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/3269/commits","review_comments_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/3269/comments","review_comment_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/issues/3269/comments","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/99c43fba83afe330ab449fa971541ba89da91bc7","head":{"label":"jmarrec:PR_opened/Fix_3268_OrphanedZoneEqList","ref":"PR_opened/Fix_3268_OrphanedZoneEqList","sha":"99c43fba83afe330ab449fa971541ba89da91bc7","user":{"login":"jmarrec","id":5479063,"node_id":"MDQ6VXNlcjU0NzkwNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5479063?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarrec","html_url":"https://github.com/jmarrec","followers_url":"https://api.github.com/users/jmarrec/followers","following_url":"https://api.github.com/users/jmarrec/following{/other_user}","gists_url":"https://api.github.com/users/jmarrec/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarrec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarrec/subscriptions","organizations_url":"https://api.github.com/users/jmarrec/orgs","repos_url":"https://api.github.com/users/jmarrec/repos","events_url":"https://api.github.com/users/jmarrec/events{/privacy}","received_events_url":"https://api.github.com/users/jmarrec/received_events","type":"User","site_admin":false},"repo":{"id":33243342,"node_id":"MDEwOlJlcG9zaXRvcnkzMzI0MzM0Mg==","name":"OpenStudio","full_name":"jmarrec/OpenStudio","private":false,"owner":{"login":"jmarrec","id":5479063,"node_id":"MDQ6VXNlcjU0NzkwNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5479063?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarrec","html_url":"https://github.com/jmarrec","followers_url":"https://api.github.com/users/jmarrec/followers","following_url":"https://api.github.com/users/jmarrec/following{/other_user}","gists_url":"https://api.github.com/users/jmarrec/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarrec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarrec/subscriptions","organizations_url":"https://api.github.com/users/jmarrec/orgs","repos_url":"https://api.github.com/users/jmarrec/repos","events_url":"https://api.github.com/users/jmarrec/events{/privacy}","received_events_url":"https://api.github.com/users/jmarrec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jmarrec/OpenStudio","description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","fork":true,"url":"https://api.github.com/repos/jmarrec/OpenStudio","forks_url":"https://api.github.com/repos/jmarrec/OpenStudio/forks","keys_url":"https://api.github.com/repos/jmarrec/OpenStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmarrec/OpenStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmarrec/OpenStudio/teams","hooks_url":"https://api.github.com/repos/jmarrec/OpenStudio/hooks","issue_events_url":"https://api.github.com/repos/jmarrec/OpenStudio/issues/events{/number}","events_url":"https://api.github.com/repos/jmarrec/OpenStudio/events","assignees_url":"https://api.github.com/repos/jmarrec/OpenStudio/assignees{/user}","branches_url":"https://api.github.com/repos/jmarrec/OpenStudio/branches{/branch}","tags_url":"https://api.github.com/repos/jmarrec/OpenStudio/tags","blobs_url":"https://api.github.com/repos/jmarrec/OpenStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmarrec/OpenStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmarrec/OpenStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmarrec/OpenStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmarrec/OpenStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/jmarrec/OpenStudio/languages","stargazers_url":"https://api.github.com/repos/jmarrec/OpenStudio/stargazers","contributors_url":"https://api.github.com/repos/jmarrec/OpenStudio/contributors","subscribers_url":"https://api.github.com/repos/jmarrec/OpenStudio/subscribers","subscription_url":"https://api.github.com/repos/jmarrec/OpenStudio/subscription","commits_url":"https://api.github.com/repos/jmarrec/OpenStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmarrec/OpenStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmarrec/OpenStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmarrec/OpenStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmarrec/OpenStudio/contents/{+path}","compare_url":"https://api.github.com/repos/jmarrec/OpenStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmarrec/OpenStudio/merges","archive_url":"https://api.github.com/repos/jmarrec/OpenStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmarrec/OpenStudio/downloads","issues_url":"https://api.github.com/repos/jmarrec/OpenStudio/issues{/number}","pulls_url":"https://api.github.com/repos/jmarrec/OpenStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/jmarrec/OpenStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/jmarrec/OpenStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmarrec/OpenStudio/labels{/name}","releases_url":"https://api.github.com/repos/jmarrec/OpenStudio/releases{/id}","deployments_url":"https://api.github.com/repos/jmarrec/OpenStudio/deployments","created_at":"2015-04-01T11:14:31Z","updated_at":"2018-09-14T22:14:36Z","pushed_at":"2018-09-17T09:16:25Z","git_url":"git://github.com/jmarrec/OpenStudio.git","ssh_url":"git@github.com:jmarrec/OpenStudio.git","clone_url":"https://github.com/jmarrec/OpenStudio.git","svn_url":"https://github.com/jmarrec/OpenStudio","homepage":"https://www.openstudio.net/","size":296310,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"05a8efce339e3267b3fb7bfa0aed2307d99581a6","user":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":11159552,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE1OTU1Mg==","name":"OpenStudio","full_name":"NREL/OpenStudio","private":false,"owner":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NREL/OpenStudio","description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","fork":false,"url":"https://api.github.com/repos/NREL/OpenStudio","forks_url":"https://api.github.com/repos/NREL/OpenStudio/forks","keys_url":"https://api.github.com/repos/NREL/OpenStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/OpenStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/OpenStudio/teams","hooks_url":"https://api.github.com/repos/NREL/OpenStudio/hooks","issue_events_url":"https://api.github.com/repos/NREL/OpenStudio/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/OpenStudio/events","assignees_url":"https://api.github.com/repos/NREL/OpenStudio/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/OpenStudio/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/OpenStudio/tags","blobs_url":"https://api.github.com/repos/NREL/OpenStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/OpenStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/OpenStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/OpenStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/OpenStudio/languages","stargazers_url":"https://api.github.com/repos/NREL/OpenStudio/stargazers","contributors_url":"https://api.github.com/repos/NREL/OpenStudio/contributors","subscribers_url":"https://api.github.com/repos/NREL/OpenStudio/subscribers","subscription_url":"https://api.github.com/repos/NREL/OpenStudio/subscription","commits_url":"https://api.github.com/repos/NREL/OpenStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/OpenStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/OpenStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/OpenStudio/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/OpenStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/OpenStudio/merges","archive_url":"https://api.github.com/repos/NREL/OpenStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/OpenStudio/downloads","issues_url":"https://api.github.com/repos/NREL/OpenStudio/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/OpenStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/OpenStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/OpenStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/OpenStudio/labels{/name}","releases_url":"https://api.github.com/repos/NREL/OpenStudio/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/OpenStudio/deployments","created_at":"2013-07-03T19:34:37Z","updated_at":"2018-09-15T02:32:59Z","pushed_at":"2018-09-15T02:35:58Z","git_url":"git://github.com/NREL/OpenStudio.git","ssh_url":"git@github.com:NREL/OpenStudio.git","clone_url":"https://github.com/NREL/OpenStudio.git","svn_url":"https://github.com/NREL/OpenStudio","homepage":"https://www.openstudio.net/","size":293650,"stargazers_count":207,"watchers_count":207,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":608,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":108,"open_issues":608,"watchers":207,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/3269"},"html":{"href":"https://github.com/NREL/OpenStudio/pull/3269"},"issue":{"href":"https://api.github.com/repos/NREL/OpenStudio/issues/3269"},"comments":{"href":"https://api.github.com/repos/NREL/OpenStudio/issues/3269/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/3269/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/3269/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/OpenStudio/statuses/99c43fba83afe330ab449fa971541ba89da91bc7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmarrec"}}