{"action":"created","comment":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/comments/217549885","pull_request_review_id":155291974,"id":217549885,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzU0OTg4NQ==","diff_hunk":"@@ -119,3 +119,27 @@ ensure_dir <- function(...) {\n             fatal(\"Failed to create directory '%s'\\n\", dir)\n    }))\n }\n+\n+replace_one_line = function(filepath, orig_line, new_line) {\n+   new_file <- tempfile()\n+   unlink(new_file)\n+   con <- file(filepath, \"r\")\n+   found_line <- FALSE\n+   while (TRUE) {\n+      line = readLines(con, n = 1)\n+      if (length(line) == 0) {\n+         break\n+      }\n+      if (!found_line && line == orig_line) {\n+         line <- new_line\n+         found_line <- TRUE\n+      }\n+      write(line, file=new_file, append=TRUE)\n+   }\n+   close(con)\n+   if (!found_line) {\n+      fatal(\"Failed to locate expected line '%s' in '%s'.\", orig_line, filepath)","path":"dependencies/windows/tools.R","position":23,"original_position":23,"commit_id":"08f39cc9b74bd4b0e3c80a096982c92e2691addc","original_commit_id":"08f39cc9b74bd4b0e3c80a096982c92e2691addc","user":{"login":"kevinushey","id":1976582,"node_id":"MDQ6VXNlcjE5NzY1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1976582?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"body":"Does this really need to be fatal?","created_at":"2018-09-13T22:11:36Z","updated_at":"2018-09-13T22:11:36Z","html_url":"https://github.com/rstudio/rstudio/pull/3480#discussion_r217549885","pull_request_url":"https://api.github.com/repos/rstudio/rstudio/pulls/3480","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/comments/217549885"},"html":{"href":"https://github.com/rstudio/rstudio/pull/3480#discussion_r217549885"},"pull_request":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/3480"}}},"pull_request":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/3480","id":215420415,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDIwNDE1","html_url":"https://github.com/rstudio/rstudio/pull/3480","diff_url":"https://github.com/rstudio/rstudio/pull/3480.diff","patch_url":"https://github.com/rstudio/rstudio/pull/3480.patch","issue_url":"https://api.github.com/repos/rstudio/rstudio/issues/3480","number":3480,"state":"open","locked":false,"title":"rebuild boost to fix warnings with newer MSVC","user":{"login":"gtritchie","id":10569626,"node_id":"MDQ6VXNlcjEwNTY5NjI2","avatar_url":"https://avatars3.githubusercontent.com/u/10569626?v=4","gravatar_id":"","url":"https://api.github.com/users/gtritchie","html_url":"https://github.com/gtritchie","followers_url":"https://api.github.com/users/gtritchie/followers","following_url":"https://api.github.com/users/gtritchie/following{/other_user}","gists_url":"https://api.github.com/users/gtritchie/gists{/gist_id}","starred_url":"https://api.github.com/users/gtritchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtritchie/subscriptions","organizations_url":"https://api.github.com/users/gtritchie/orgs","repos_url":"https://api.github.com/users/gtritchie/repos","events_url":"https://api.github.com/users/gtritchie/events{/privacy}","received_events_url":"https://api.github.com/users/gtritchie/received_events","type":"User","site_admin":false},"body":"Modified scripts to patch the two issues that are throwing several hundred warnings during build of IDE on Windows. I chose to make these small tweaks on the current version of Boost we are using, and not upgrading. Safer to upgrade Boost early in 1.3.\r\n\r\nOne fix is to comment out pragma message complaining about unknown compiler version; this is what newer Boost does (literally comments this line out rather than continuing to track MSVC versions).\r\n\r\nOther fix ia a pre-proc tweak to prevent use of a non-standard STL method in iostreams that recent MSVC warns about.\r\n\r\nBetween these, on my machine, a release build of the IDE goes from 816 warnings to 402. The remainder are more significant (size_t vs. int, that sort of thing, and will be easier to look at them when we decide to work on this).\r\n\r\nNote that debug builds still throw a bunch more warnings due to missing PDBs, there's a separate issue open on that #3477.\r\n\r\nThis also removed the 32-bit boost builds, so archive is half the size it used to be. The script was changed to do this a while ago but didn't rebuild boost at that time.\r\n\r\nBuilt and uploaded boost archive to S3, using same name as previous archive (boost-1.65.1-win-msvc141.zip); the previous archive is renamed to boost-1.65.1-win-msvc141_warnings.zip in case there's a reason to put it back.\r\n\r\n### Dev Action Needed\r\n\r\nTo get this updated boost on a dev box, need to blow away the boost folders under dependencies\\windows and rerun install-dependencies.cmd. Likely need to do same on Jenkins build environment (I _think_ we preserve the dependencies\\windows between builds). Not urgent in either case. No expected change in the build output, just the compile-time warnings.\r\n\r\nFixes #3140 \r\n","created_at":"2018-09-13T21:23:26Z","updated_at":"2018-09-13T22:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fcefa8847cf67996728ac6e2ee08eaa036d98d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rstudio/rstudio/pulls/3480/commits","review_comments_url":"https://api.github.com/repos/rstudio/rstudio/pulls/3480/comments","review_comment_url":"https://api.github.com/repos/rstudio/rstudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rstudio/rstudio/issues/3480/comments","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/08f39cc9b74bd4b0e3c80a096982c92e2691addc","head":{"label":"rstudio:bugfix/win-boost-warnings","ref":"bugfix/win-boost-warnings","sha":"08f39cc9b74bd4b0e3c80a096982c92e2691addc","user":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":1147463,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDYz","name":"rstudio","full_name":"rstudio/rstudio","owner":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rstudio/rstudio","description":"RStudio is an integrated development environment (IDE) for R","fork":false,"url":"https://api.github.com/repos/rstudio/rstudio","forks_url":"https://api.github.com/repos/rstudio/rstudio/forks","keys_url":"https://api.github.com/repos/rstudio/rstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/rstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/rstudio/teams","hooks_url":"https://api.github.com/repos/rstudio/rstudio/hooks","issue_events_url":"https://api.github.com/repos/rstudio/rstudio/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/rstudio/events","assignees_url":"https://api.github.com/repos/rstudio/rstudio/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/rstudio/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/rstudio/tags","blobs_url":"https://api.github.com/repos/rstudio/rstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/rstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/rstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/rstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/rstudio/languages","stargazers_url":"https://api.github.com/repos/rstudio/rstudio/stargazers","contributors_url":"https://api.github.com/repos/rstudio/rstudio/contributors","subscribers_url":"https://api.github.com/repos/rstudio/rstudio/subscribers","subscription_url":"https://api.github.com/repos/rstudio/rstudio/subscription","commits_url":"https://api.github.com/repos/rstudio/rstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/rstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/rstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/rstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/rstudio/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/rstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/rstudio/merges","archive_url":"https://api.github.com/repos/rstudio/rstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/rstudio/downloads","issues_url":"https://api.github.com/repos/rstudio/rstudio/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/rstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/rstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/rstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/rstudio/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/rstudio/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/rstudio/deployments","created_at":"2010-12-07T19:10:25Z","updated_at":"2018-09-13T22:05:58Z","pushed_at":"2018-09-13T22:05:55Z","git_url":"git://github.com/rstudio/rstudio.git","ssh_url":"git@github.com:rstudio/rstudio.git","clone_url":"https://github.com/rstudio/rstudio.git","svn_url":"https://github.com/rstudio/rstudio","homepage":"https://www.rstudio.com/products/rstudio/","size":99185,"stargazers_count":2413,"watchers_count":2413,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":610,"mirror_url":null,"archived":false,"open_issues_count":772,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":610,"open_issues":772,"watchers":2413,"default_branch":"master"}},"base":{"label":"rstudio:master","ref":"master","sha":"4fe0fc3433822108c3b9f4a9d7c27496c0970973","user":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":1147463,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDYz","name":"rstudio","full_name":"rstudio/rstudio","owner":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rstudio/rstudio","description":"RStudio is an integrated development environment (IDE) for R","fork":false,"url":"https://api.github.com/repos/rstudio/rstudio","forks_url":"https://api.github.com/repos/rstudio/rstudio/forks","keys_url":"https://api.github.com/repos/rstudio/rstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/rstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/rstudio/teams","hooks_url":"https://api.github.com/repos/rstudio/rstudio/hooks","issue_events_url":"https://api.github.com/repos/rstudio/rstudio/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/rstudio/events","assignees_url":"https://api.github.com/repos/rstudio/rstudio/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/rstudio/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/rstudio/tags","blobs_url":"https://api.github.com/repos/rstudio/rstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/rstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/rstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/rstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/rstudio/languages","stargazers_url":"https://api.github.com/repos/rstudio/rstudio/stargazers","contributors_url":"https://api.github.com/repos/rstudio/rstudio/contributors","subscribers_url":"https://api.github.com/repos/rstudio/rstudio/subscribers","subscription_url":"https://api.github.com/repos/rstudio/rstudio/subscription","commits_url":"https://api.github.com/repos/rstudio/rstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/rstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/rstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/rstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/rstudio/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/rstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/rstudio/merges","archive_url":"https://api.github.com/repos/rstudio/rstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/rstudio/downloads","issues_url":"https://api.github.com/repos/rstudio/rstudio/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/rstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/rstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/rstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/rstudio/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/rstudio/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/rstudio/deployments","created_at":"2010-12-07T19:10:25Z","updated_at":"2018-09-13T22:05:58Z","pushed_at":"2018-09-13T22:05:55Z","git_url":"git://github.com/rstudio/rstudio.git","ssh_url":"git@github.com:rstudio/rstudio.git","clone_url":"https://github.com/rstudio/rstudio.git","svn_url":"https://github.com/rstudio/rstudio","homepage":"https://www.rstudio.com/products/rstudio/","size":99185,"stargazers_count":2413,"watchers_count":2413,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":610,"mirror_url":null,"archived":false,"open_issues_count":772,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":610,"open_issues":772,"watchers":2413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/3480"},"html":{"href":"https://github.com/rstudio/rstudio/pull/3480"},"issue":{"href":"https://api.github.com/repos/rstudio/rstudio/issues/3480"},"comments":{"href":"https://api.github.com/repos/rstudio/rstudio/issues/3480/comments"},"review_comments":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/3480/comments"},"review_comment":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/3480/commits"},"statuses":{"href":"https://api.github.com/repos/rstudio/rstudio/statuses/08f39cc9b74bd4b0e3c80a096982c92e2691addc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kevinushey"}}