{"action":"closed","number":8198,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/8198","id":237157233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTU3MjMz","html_url":"https://github.com/zfsonlinux/zfs/pull/8198","diff_url":"https://github.com/zfsonlinux/zfs/pull/8198.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/8198.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/8198","number":8198,"state":"closed","locked":false,"title":"Issue 8131: Seeing negative values for wlentime","user":{"login":"richardelling","id":867533,"node_id":"MDQ6VXNlcjg2NzUzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/867533?v=4","gravatar_id":"","url":"https://api.github.com/users/richardelling","html_url":"https://github.com/richardelling","followers_url":"https://api.github.com/users/richardelling/followers","following_url":"https://api.github.com/users/richardelling/following{/other_user}","gists_url":"https://api.github.com/users/richardelling/gists{/gist_id}","starred_url":"https://api.github.com/users/richardelling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardelling/subscriptions","organizations_url":"https://api.github.com/users/richardelling/orgs","repos_url":"https://api.github.com/users/richardelling/repos","events_url":"https://api.github.com/users/richardelling/events{/privacy}","received_events_url":"https://api.github.com/users/richardelling/received_events","type":"User","site_admin":false},"body":"Linux kstat IO and TIMER printed values as signed. However the counters\r\nonly increment. Thus humans looking at the data can be confused when\r\nthe counters roll over.\r\n\r\nNote: The recommended use of these values is to monitor the derivative,\r\nwhich don't really care about the sign. See explanations related to\r\nnon-negative derivatives in the various time-series databases.\r\n\r\nSigned-off-by: Richard Elling <Richard.Elling@RichardElling.com>\r\n\r\n<!--- Please fill out the following template, which will help other contributors review your Pull Request. -->\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n<!---\r\nDocumentation on ZFS Buildbot options can be found at\r\nhttps://github.com/zfsonlinux/zfs/wiki/Buildbot-Options\r\n-->\r\n\r\n### Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n### Description\r\n<!--- Describe your changes in detail -->\r\n\r\n### How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n<!--- If your change is a performance enhancement, please provide benchmarks here. -->\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Performance enhancement (non-breaking change which improves efficiency)\r\n- [ ] Code cleanup (non-breaking change which makes code smaller or more readable)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Documentation (a change to man pages or other documentation)\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the ZFS on Linux [code style requirements](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md#coding-conventions).\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [**contributing** document](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md).\r\n- [ ] I have added [tests](https://github.com/zfsonlinux/zfs/tree/master/tests) to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [x] All commit messages are properly formatted and contain [`Signed-off-by`](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md#signed-off-by).\r\n","created_at":"2018-12-09T21:07:26Z","updated_at":"2018-12-11T21:56:55Z","closed_at":"2018-12-11T21:56:55Z","merged_at":"2018-12-11T21:56:55Z","merge_commit_sha":"a48cd034c8df96ab751179b0c15bf84c6e178967","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1007099007,"node_id":"MDU6TGFiZWwxMDA3MDk5MDA3","url":"https://api.github.com/repos/zfsonlinux/zfs/labels/Status:%20Accepted","name":"Status: Accepted","color":"00b33c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/8198/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/8198/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/8198/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/3ef07b0039dd92b187a8ab53b1c786dd53cf2eaf","head":{"label":"richardelling:issue-8131","ref":"issue-8131","sha":"3ef07b0039dd92b187a8ab53b1c786dd53cf2eaf","user":{"login":"richardelling","id":867533,"node_id":"MDQ6VXNlcjg2NzUzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/867533?v=4","gravatar_id":"","url":"https://api.github.com/users/richardelling","html_url":"https://github.com/richardelling","followers_url":"https://api.github.com/users/richardelling/followers","following_url":"https://api.github.com/users/richardelling/following{/other_user}","gists_url":"https://api.github.com/users/richardelling/gists{/gist_id}","starred_url":"https://api.github.com/users/richardelling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardelling/subscriptions","organizations_url":"https://api.github.com/users/richardelling/orgs","repos_url":"https://api.github.com/users/richardelling/repos","events_url":"https://api.github.com/users/richardelling/events{/privacy}","received_events_url":"https://api.github.com/users/richardelling/received_events","type":"User","site_admin":false},"repo":{"id":69401178,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMTE3OA==","name":"zfs","full_name":"richardelling/zfs","private":false,"owner":{"login":"richardelling","id":867533,"node_id":"MDQ6VXNlcjg2NzUzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/867533?v=4","gravatar_id":"","url":"https://api.github.com/users/richardelling","html_url":"https://github.com/richardelling","followers_url":"https://api.github.com/users/richardelling/followers","following_url":"https://api.github.com/users/richardelling/following{/other_user}","gists_url":"https://api.github.com/users/richardelling/gists{/gist_id}","starred_url":"https://api.github.com/users/richardelling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardelling/subscriptions","organizations_url":"https://api.github.com/users/richardelling/orgs","repos_url":"https://api.github.com/users/richardelling/repos","events_url":"https://api.github.com/users/richardelling/events{/privacy}","received_events_url":"https://api.github.com/users/richardelling/received_events","type":"User","site_admin":false},"html_url":"https://github.com/richardelling/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/richardelling/zfs","forks_url":"https://api.github.com/repos/richardelling/zfs/forks","keys_url":"https://api.github.com/repos/richardelling/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardelling/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardelling/zfs/teams","hooks_url":"https://api.github.com/repos/richardelling/zfs/hooks","issue_events_url":"https://api.github.com/repos/richardelling/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/richardelling/zfs/events","assignees_url":"https://api.github.com/repos/richardelling/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/richardelling/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/richardelling/zfs/tags","blobs_url":"https://api.github.com/repos/richardelling/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardelling/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardelling/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardelling/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardelling/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/richardelling/zfs/languages","stargazers_url":"https://api.github.com/repos/richardelling/zfs/stargazers","contributors_url":"https://api.github.com/repos/richardelling/zfs/contributors","subscribers_url":"https://api.github.com/repos/richardelling/zfs/subscribers","subscription_url":"https://api.github.com/repos/richardelling/zfs/subscription","commits_url":"https://api.github.com/repos/richardelling/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardelling/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardelling/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardelling/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardelling/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/richardelling/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardelling/zfs/merges","archive_url":"https://api.github.com/repos/richardelling/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardelling/zfs/downloads","issues_url":"https://api.github.com/repos/richardelling/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/richardelling/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/richardelling/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/richardelling/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardelling/zfs/labels{/name}","releases_url":"https://api.github.com/repos/richardelling/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/richardelling/zfs/deployments","created_at":"2016-09-27T21:42:18Z","updated_at":"2018-12-09T19:35:58Z","pushed_at":"2018-12-09T21:06:01Z","git_url":"git://github.com/richardelling/zfs.git","ssh_url":"git@github.com:richardelling/zfs.git","clone_url":"https://github.com/richardelling/zfs.git","svn_url":"https://github.com/richardelling/zfs","homepage":"http://zfsonlinux.org/","size":50598,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"900d09b285107e13fa0bdb8378274dff89347181","user":{"login":"zfsonlinux","id":575083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTA4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/575083?v=4","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcwMTE=","name":"zfs","full_name":"zfsonlinux/zfs","private":false,"owner":{"login":"zfsonlinux","id":575083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTA4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/575083?v=4","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2018-12-11T11:19:53Z","pushed_at":"2018-12-11T21:56:55Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"https://zfsonlinux.org/","size":50207,"stargazers_count":3654,"watchers_count":3654,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":857,"mirror_url":null,"archived":false,"open_issues_count":1015,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":857,"open_issues":1015,"watchers":3654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/8198"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/8198"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/8198"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/8198/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/8198/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/8198/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/3ef07b0039dd92b187a8ab53b1c786dd53cf2eaf"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"behlendorf","id":148917,"node_id":"MDQ6VXNlcjE0ODkxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/148917?v=4","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"behlendorf"}}