{"action":"created","comment":{"url":"https://api.github.com/repos/apache/aurora/pulls/comments/218591193","pull_request_review_id":156564478,"id":218591193,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODU5MTE5Mw==","diff_hunk":"@@ -143,8 +148,28 @@ public IJobUpdate backFillJobUpdate(JobUpdate update) {\n       backfillTask(instructions.getDesiredState().getTask());\n     }\n \n+    backfillUpdateStrategy(instructions.getSettings());\n+\n     instructions.getInitialState().forEach(e -> backfillTask(e.getTask()));\n \n     return IJobUpdate.build(update);\n   }\n+\n+  private void backfillUpdateStrategy(JobUpdateSettings settings) {","path":"src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java","position":33,"original_position":33,"commit_id":"118376ff13aab5e04d857003230ede30cb9526fb","original_commit_id":"118376ff13aab5e04d857003230ede30cb9526fb","user":{"login":"rdelval","id":1643994,"node_id":"MDQ6VXNlcjE2NDM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1643994?v=4","gravatar_id":"","url":"https://api.github.com/users/rdelval","html_url":"https://github.com/rdelval","followers_url":"https://api.github.com/users/rdelval/followers","following_url":"https://api.github.com/users/rdelval/following{/other_user}","gists_url":"https://api.github.com/users/rdelval/gists{/gist_id}","starred_url":"https://api.github.com/users/rdelval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdelval/subscriptions","organizations_url":"https://api.github.com/users/rdelval/orgs","repos_url":"https://api.github.com/users/rdelval/repos","events_url":"https://api.github.com/users/rdelval/events{/privacy}","received_events_url":"https://api.github.com/users/rdelval/received_events","type":"User","site_admin":false},"body":"Thanks for the input @DavidMcLaughlin, I'll create a PR with just the Thrift changes in that case.","created_at":"2018-09-18T20:53:56Z","updated_at":"2018-09-18T20:53:56Z","html_url":"https://github.com/apache/aurora/pull/37#discussion_r218591193","pull_request_url":"https://api.github.com/repos/apache/aurora/pulls/37","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/aurora/pulls/comments/218591193"},"html":{"href":"https://github.com/apache/aurora/pull/37#discussion_r218591193"},"pull_request":{"href":"https://api.github.com/repos/apache/aurora/pulls/37"}},"in_reply_to_id":217960469},"pull_request":{"url":"https://api.github.com/repos/apache/aurora/pulls/37","id":214471961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDcxOTYx","html_url":"https://github.com/apache/aurora/pull/37","diff_url":"https://github.com/apache/aurora/pull/37.diff","patch_url":"https://github.com/apache/aurora/pull/37.patch","issue_url":"https://api.github.com/repos/apache/aurora/issues/37","number":37,"state":"open","locked":false,"title":"Staggered (Variable batch) Updates","user":{"login":"rdelval","id":1643994,"node_id":"MDQ6VXNlcjE2NDM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1643994?v=4","gravatar_id":"","url":"https://api.github.com/users/rdelval","html_url":"https://github.com/rdelval","followers_url":"https://api.github.com/users/rdelval/followers","following_url":"https://api.github.com/users/rdelval/following{/other_user}","gists_url":"https://api.github.com/users/rdelval/gists{/gist_id}","starred_url":"https://api.github.com/users/rdelval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdelval/subscriptions","organizations_url":"https://api.github.com/users/rdelval/orgs","repos_url":"https://api.github.com/users/rdelval/repos","events_url":"https://api.github.com/users/rdelval/events{/privacy}","received_events_url":"https://api.github.com/users/rdelval/received_events","type":"User","site_admin":false},"body":"Adding support for variable group sizes when executing an update.\r\n\r\nDesign doc for this change is here: \r\nhttps://docs.google.com/document/d/1xGk4ueH8YlmJCk6hQJh85u4to4M1VQD0l630IOchvgY/edit#heading=h.lg3hty82f5cz\r\n\r\nTesting done:\r\nJenkins integration test passed.\r\nEnd to end tests passed.\r\n\r\nFeedback from https://reviews.apache.org/r/66192/ addressed. \r\n\r\nUI Change below:\r\n![image](https://user-images.githubusercontent.com/1643994/45329549-d22e7200-b515-11e8-92d9-eefc31b793b8.png)\r\n![image](https://user-images.githubusercontent.com/1643994/45329562-deb2ca80-b515-11e8-9b76-10ca1945b7f7.png)\r\n![image](https://user-images.githubusercontent.com/1643994/45329565-e4101500-b515-11e8-8a97-bb904bf77ceb.png)\r\n\r\nTests added for UI, Thrift change, and Pystachio changes.\r\n\r\nMoving this over to Github since reviewboard decided to act up.\r\n\r\n","created_at":"2018-09-10T23:25:55Z","updated_at":"2018-09-18T20:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c9af2d7f86233c5cd1e35b459647ae5133b0db3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jordanly","id":3536462,"node_id":"MDQ6VXNlcjM1MzY0NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3536462?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanly","html_url":"https://github.com/jordanly","followers_url":"https://api.github.com/users/jordanly/followers","following_url":"https://api.github.com/users/jordanly/following{/other_user}","gists_url":"https://api.github.com/users/jordanly/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanly/subscriptions","organizations_url":"https://api.github.com/users/jordanly/orgs","repos_url":"https://api.github.com/users/jordanly/repos","events_url":"https://api.github.com/users/jordanly/events{/privacy}","received_events_url":"https://api.github.com/users/jordanly/received_events","type":"User","site_admin":false},{"login":"shanmugh","id":4767980,"node_id":"MDQ6VXNlcjQ3Njc5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/4767980?v=4","gravatar_id":"","url":"https://api.github.com/users/shanmugh","html_url":"https://github.com/shanmugh","followers_url":"https://api.github.com/users/shanmugh/followers","following_url":"https://api.github.com/users/shanmugh/following{/other_user}","gists_url":"https://api.github.com/users/shanmugh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanmugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanmugh/subscriptions","organizations_url":"https://api.github.com/users/shanmugh/orgs","repos_url":"https://api.github.com/users/shanmugh/repos","events_url":"https://api.github.com/users/shanmugh/events{/privacy}","received_events_url":"https://api.github.com/users/shanmugh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/aurora/pulls/37/commits","review_comments_url":"https://api.github.com/repos/apache/aurora/pulls/37/comments","review_comment_url":"https://api.github.com/repos/apache/aurora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/aurora/issues/37/comments","statuses_url":"https://api.github.com/repos/apache/aurora/statuses/118376ff13aab5e04d857003230ede30cb9526fb","head":{"label":"rdelval:staggeredUpdates","ref":"staggeredUpdates","sha":"118376ff13aab5e04d857003230ede30cb9526fb","user":{"login":"rdelval","id":1643994,"node_id":"MDQ6VXNlcjE2NDM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1643994?v=4","gravatar_id":"","url":"https://api.github.com/users/rdelval","html_url":"https://github.com/rdelval","followers_url":"https://api.github.com/users/rdelval/followers","following_url":"https://api.github.com/users/rdelval/following{/other_user}","gists_url":"https://api.github.com/users/rdelval/gists{/gist_id}","starred_url":"https://api.github.com/users/rdelval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdelval/subscriptions","organizations_url":"https://api.github.com/users/rdelval/orgs","repos_url":"https://api.github.com/users/rdelval/repos","events_url":"https://api.github.com/users/rdelval/events{/privacy}","received_events_url":"https://api.github.com/users/rdelval/received_events","type":"User","site_admin":false},"repo":{"id":37544211,"node_id":"MDEwOlJlcG9zaXRvcnkzNzU0NDIxMQ==","name":"aurora","full_name":"rdelval/aurora","private":false,"owner":{"login":"rdelval","id":1643994,"node_id":"MDQ6VXNlcjE2NDM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1643994?v=4","gravatar_id":"","url":"https://api.github.com/users/rdelval","html_url":"https://github.com/rdelval","followers_url":"https://api.github.com/users/rdelval/followers","following_url":"https://api.github.com/users/rdelval/following{/other_user}","gists_url":"https://api.github.com/users/rdelval/gists{/gist_id}","starred_url":"https://api.github.com/users/rdelval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdelval/subscriptions","organizations_url":"https://api.github.com/users/rdelval/orgs","repos_url":"https://api.github.com/users/rdelval/repos","events_url":"https://api.github.com/users/rdelval/events{/privacy}","received_events_url":"https://api.github.com/users/rdelval/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rdelval/aurora","description":"Fork of Apache Aurora","fork":true,"url":"https://api.github.com/repos/rdelval/aurora","forks_url":"https://api.github.com/repos/rdelval/aurora/forks","keys_url":"https://api.github.com/repos/rdelval/aurora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdelval/aurora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdelval/aurora/teams","hooks_url":"https://api.github.com/repos/rdelval/aurora/hooks","issue_events_url":"https://api.github.com/repos/rdelval/aurora/issues/events{/number}","events_url":"https://api.github.com/repos/rdelval/aurora/events","assignees_url":"https://api.github.com/repos/rdelval/aurora/assignees{/user}","branches_url":"https://api.github.com/repos/rdelval/aurora/branches{/branch}","tags_url":"https://api.github.com/repos/rdelval/aurora/tags","blobs_url":"https://api.github.com/repos/rdelval/aurora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdelval/aurora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdelval/aurora/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdelval/aurora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdelval/aurora/statuses/{sha}","languages_url":"https://api.github.com/repos/rdelval/aurora/languages","stargazers_url":"https://api.github.com/repos/rdelval/aurora/stargazers","contributors_url":"https://api.github.com/repos/rdelval/aurora/contributors","subscribers_url":"https://api.github.com/repos/rdelval/aurora/subscribers","subscription_url":"https://api.github.com/repos/rdelval/aurora/subscription","commits_url":"https://api.github.com/repos/rdelval/aurora/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdelval/aurora/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdelval/aurora/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdelval/aurora/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdelval/aurora/contents/{+path}","compare_url":"https://api.github.com/repos/rdelval/aurora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdelval/aurora/merges","archive_url":"https://api.github.com/repos/rdelval/aurora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdelval/aurora/downloads","issues_url":"https://api.github.com/repos/rdelval/aurora/issues{/number}","pulls_url":"https://api.github.com/repos/rdelval/aurora/pulls{/number}","milestones_url":"https://api.github.com/repos/rdelval/aurora/milestones{/number}","notifications_url":"https://api.github.com/repos/rdelval/aurora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdelval/aurora/labels{/name}","releases_url":"https://api.github.com/repos/rdelval/aurora/releases{/id}","deployments_url":"https://api.github.com/repos/rdelval/aurora/deployments","created_at":"2015-06-16T17:07:40Z","updated_at":"2018-09-14T22:44:27Z","pushed_at":"2018-09-11T18:18:35Z","git_url":"git://github.com/rdelval/aurora.git","ssh_url":"git@github.com:rdelval/aurora.git","clone_url":"https://github.com/rdelval/aurora.git","svn_url":"https://github.com/rdelval/aurora","homepage":"","size":30121,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0e5c7c5753520e6c97d08057d6b81488ae235dc5","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135467,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzNTQ2Nw==","name":"aurora","full_name":"apache/aurora","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/aurora","description":"Apache Aurora - A Mesos framework for long-running services, cron jobs, and ad-hoc jobs","fork":false,"url":"https://api.github.com/repos/apache/aurora","forks_url":"https://api.github.com/repos/apache/aurora/forks","keys_url":"https://api.github.com/repos/apache/aurora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/aurora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/aurora/teams","hooks_url":"https://api.github.com/repos/apache/aurora/hooks","issue_events_url":"https://api.github.com/repos/apache/aurora/issues/events{/number}","events_url":"https://api.github.com/repos/apache/aurora/events","assignees_url":"https://api.github.com/repos/apache/aurora/assignees{/user}","branches_url":"https://api.github.com/repos/apache/aurora/branches{/branch}","tags_url":"https://api.github.com/repos/apache/aurora/tags","blobs_url":"https://api.github.com/repos/apache/aurora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/aurora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/aurora/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/aurora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/aurora/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/aurora/languages","stargazers_url":"https://api.github.com/repos/apache/aurora/stargazers","contributors_url":"https://api.github.com/repos/apache/aurora/contributors","subscribers_url":"https://api.github.com/repos/apache/aurora/subscribers","subscription_url":"https://api.github.com/repos/apache/aurora/subscription","commits_url":"https://api.github.com/repos/apache/aurora/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/aurora/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/aurora/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/aurora/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/aurora/contents/{+path}","compare_url":"https://api.github.com/repos/apache/aurora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/aurora/merges","archive_url":"https://api.github.com/repos/apache/aurora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/aurora/downloads","issues_url":"https://api.github.com/repos/apache/aurora/issues{/number}","pulls_url":"https://api.github.com/repos/apache/aurora/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/aurora/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/aurora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/aurora/labels{/name}","releases_url":"https://api.github.com/repos/apache/aurora/releases{/id}","deployments_url":"https://api.github.com/repos/apache/aurora/deployments","created_at":"2013-11-05T08:00:13Z","updated_at":"2018-09-06T20:56:34Z","pushed_at":"2018-09-11T03:57:28Z","git_url":"git://github.com/apache/aurora.git","ssh_url":"git@github.com:apache/aurora.git","clone_url":"https://github.com/apache/aurora.git","svn_url":"https://github.com/apache/aurora","homepage":"https://aurora.apache.org","size":29992,"stargazers_count":569,"watchers_count":569,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":217,"open_issues":5,"watchers":569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/aurora/pulls/37"},"html":{"href":"https://github.com/apache/aurora/pull/37"},"issue":{"href":"https://api.github.com/repos/apache/aurora/issues/37"},"comments":{"href":"https://api.github.com/repos/apache/aurora/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/aurora/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/aurora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/aurora/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/apache/aurora/statuses/118376ff13aab5e04d857003230ede30cb9526fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rdelval"}}