{"action":"created","comment":{"url":"https://api.github.com/repos/vindi/vindi-magento/pulls/comments/195588046","pull_request_review_id":128989345,"id":195588046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTU4ODA0Ng==","diff_hunk":"@@ -190,17 +190,34 @@ protected function createPaymentProfile($customerId)\n             'payment_method_code'  =>  $this->getPaymentMethodCode()\n         ];\n \n-        $paymentProfileId = $this->api()->createCustomerPaymentProfile($creditCardData);\n+        $paymentProfile = $this->api()->createCustomerPaymentProfile($creditCardData);\n \n-        if ($paymentProfileId === false) {\n+        if ($paymentProfile === false) {\n             Mage::throwException('Erro ao informar os dados de cartão de crédito. Verifique os dados e tente novamente!');\n \n             return false;\n         }\n \n-        return $paymentProfileId;\n+        $verifyMethod = Mage::getStoreConfig('vindi_subscription/general/verify_method');\n+\n+        if ($verifyMethod && !$this->verifyPaymentProfile($paymentProfile['payment_profile']['id'])) {","path":"src/app/code/community/Vindi/Subscription/Model/CreditCard.php","position":17,"original_position":17,"commit_id":"7d25683302439a02a7f19a40d6628667c110302a","original_commit_id":"c4cecc8d64c296c9f0eced2bcdbad33e60b90fdc","user":{"login":"laerte-guimaraes","id":31661772,"node_id":"MDQ6VXNlcjMxNjYxNzcy","avatar_url":"https://avatars1.githubusercontent.com/u/31661772?v=4","gravatar_id":"","url":"https://api.github.com/users/laerte-guimaraes","html_url":"https://github.com/laerte-guimaraes","followers_url":"https://api.github.com/users/laerte-guimaraes/followers","following_url":"https://api.github.com/users/laerte-guimaraes/following{/other_user}","gists_url":"https://api.github.com/users/laerte-guimaraes/gists{/gist_id}","starred_url":"https://api.github.com/users/laerte-guimaraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laerte-guimaraes/subscriptions","organizations_url":"https://api.github.com/users/laerte-guimaraes/orgs","repos_url":"https://api.github.com/users/laerte-guimaraes/repos","events_url":"https://api.github.com/users/laerte-guimaraes/events{/privacy}","received_events_url":"https://api.github.com/users/laerte-guimaraes/received_events","type":"User","site_admin":false},"body":"O valor default no Magento para as outras funções é 0;\r\nDesse modo, de acordo com os testes a regra está sendo mantida.","created_at":"2018-06-14T22:16:09Z","updated_at":"2018-06-14T22:16:09Z","html_url":"https://github.com/vindi/vindi-magento/pull/47#discussion_r195588046","pull_request_url":"https://api.github.com/repos/vindi/vindi-magento/pulls/47","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/comments/195588046"},"html":{"href":"https://github.com/vindi/vindi-magento/pull/47#discussion_r195588046"},"pull_request":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/47"}},"in_reply_to_id":195584758},"pull_request":{"url":"https://api.github.com/repos/vindi/vindi-magento/pulls/47","id":194421174,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDIxMTc0","html_url":"https://github.com/vindi/vindi-magento/pull/47","diff_url":"https://github.com/vindi/vindi-magento/pull/47.diff","patch_url":"https://github.com/vindi/vindi-magento/pull/47.patch","issue_url":"https://api.github.com/repos/vindi/vindi-magento/issues/47","number":47,"state":"open","locked":false,"title":"Adição da Transação de Verificação","user":{"login":"laerte-guimaraes","id":31661772,"node_id":"MDQ6VXNlcjMxNjYxNzcy","avatar_url":"https://avatars1.githubusercontent.com/u/31661772?v=4","gravatar_id":"","url":"https://api.github.com/users/laerte-guimaraes","html_url":"https://github.com/laerte-guimaraes","followers_url":"https://api.github.com/users/laerte-guimaraes/followers","following_url":"https://api.github.com/users/laerte-guimaraes/following{/other_user}","gists_url":"https://api.github.com/users/laerte-guimaraes/gists{/gist_id}","starred_url":"https://api.github.com/users/laerte-guimaraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laerte-guimaraes/subscriptions","organizations_url":"https://api.github.com/users/laerte-guimaraes/orgs","repos_url":"https://api.github.com/users/laerte-guimaraes/repos","events_url":"https://api.github.com/users/laerte-guimaraes/events{/privacy}","received_events_url":"https://api.github.com/users/laerte-guimaraes/received_events","type":"User","site_admin":false},"body":"## Motivação\r\nAtualmente o módulo da Vindi para Magento não possui a transação de verificação, o que impossibilita os clientes Vindi de instalarem/utilizaram essa funcionalidade.\r\nEssa extensão pode ser indicada como um diferencial para os clientes, aumentando a confiabilitade do negócio dele tanto quanto um ganho de receita para a Vindi.\r\n\r\n## Solução proposta\r\nEsse PR adiciona uma opção para habilitar a função de transação de verificação da Vindi no módulo Magento, que impede a compra nas verificações rejeitadas.","created_at":"2018-06-12T22:06:48Z","updated_at":"2018-06-14T22:16:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8df0599ad2e9078049bdba36646ff93b7fd0411b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rtakauti","id":5501740,"node_id":"MDQ6VXNlcjU1MDE3NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/5501740?v=4","gravatar_id":"","url":"https://api.github.com/users/rtakauti","html_url":"https://github.com/rtakauti","followers_url":"https://api.github.com/users/rtakauti/followers","following_url":"https://api.github.com/users/rtakauti/following{/other_user}","gists_url":"https://api.github.com/users/rtakauti/gists{/gist_id}","starred_url":"https://api.github.com/users/rtakauti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtakauti/subscriptions","organizations_url":"https://api.github.com/users/rtakauti/orgs","repos_url":"https://api.github.com/users/rtakauti/repos","events_url":"https://api.github.com/users/rtakauti/events{/privacy}","received_events_url":"https://api.github.com/users/rtakauti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vindi/vindi-magento/pulls/47/commits","review_comments_url":"https://api.github.com/repos/vindi/vindi-magento/pulls/47/comments","review_comment_url":"https://api.github.com/repos/vindi/vindi-magento/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vindi/vindi-magento/issues/47/comments","statuses_url":"https://api.github.com/repos/vindi/vindi-magento/statuses/7d25683302439a02a7f19a40d6628667c110302a","head":{"label":"laerte-guimaraes:feature/verify","ref":"feature/verify","sha":"7d25683302439a02a7f19a40d6628667c110302a","user":{"login":"laerte-guimaraes","id":31661772,"node_id":"MDQ6VXNlcjMxNjYxNzcy","avatar_url":"https://avatars1.githubusercontent.com/u/31661772?v=4","gravatar_id":"","url":"https://api.github.com/users/laerte-guimaraes","html_url":"https://github.com/laerte-guimaraes","followers_url":"https://api.github.com/users/laerte-guimaraes/followers","following_url":"https://api.github.com/users/laerte-guimaraes/following{/other_user}","gists_url":"https://api.github.com/users/laerte-guimaraes/gists{/gist_id}","starred_url":"https://api.github.com/users/laerte-guimaraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laerte-guimaraes/subscriptions","organizations_url":"https://api.github.com/users/laerte-guimaraes/orgs","repos_url":"https://api.github.com/users/laerte-guimaraes/repos","events_url":"https://api.github.com/users/laerte-guimaraes/events{/privacy}","received_events_url":"https://api.github.com/users/laerte-guimaraes/received_events","type":"User","site_admin":false},"repo":{"id":137126325,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMjYzMjU=","name":"vindi-magento","full_name":"laerte-guimaraes/vindi-magento","owner":{"login":"laerte-guimaraes","id":31661772,"node_id":"MDQ6VXNlcjMxNjYxNzcy","avatar_url":"https://avatars1.githubusercontent.com/u/31661772?v=4","gravatar_id":"","url":"https://api.github.com/users/laerte-guimaraes","html_url":"https://github.com/laerte-guimaraes","followers_url":"https://api.github.com/users/laerte-guimaraes/followers","following_url":"https://api.github.com/users/laerte-guimaraes/following{/other_user}","gists_url":"https://api.github.com/users/laerte-guimaraes/gists{/gist_id}","starred_url":"https://api.github.com/users/laerte-guimaraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laerte-guimaraes/subscriptions","organizations_url":"https://api.github.com/users/laerte-guimaraes/orgs","repos_url":"https://api.github.com/users/laerte-guimaraes/repos","events_url":"https://api.github.com/users/laerte-guimaraes/events{/privacy}","received_events_url":"https://api.github.com/users/laerte-guimaraes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laerte-guimaraes/vindi-magento","description":"Módulo de cobrança recorrente para Magento","fork":true,"url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento","forks_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/forks","keys_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/teams","hooks_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/hooks","issue_events_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/issues/events{/number}","events_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/events","assignees_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/assignees{/user}","branches_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/branches{/branch}","tags_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/tags","blobs_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/languages","stargazers_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/stargazers","contributors_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/contributors","subscribers_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/subscribers","subscription_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/subscription","commits_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/contents/{+path}","compare_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/merges","archive_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/downloads","issues_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/issues{/number}","pulls_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/labels{/name}","releases_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/releases{/id}","deployments_url":"https://api.github.com/repos/laerte-guimaraes/vindi-magento/deployments","created_at":"2018-06-12T20:50:34Z","updated_at":"2018-06-12T20:50:35Z","pushed_at":"2018-06-14T22:14:43Z","git_url":"git://github.com/laerte-guimaraes/vindi-magento.git","ssh_url":"git@github.com:laerte-guimaraes/vindi-magento.git","clone_url":"https://github.com/laerte-guimaraes/vindi-magento.git","svn_url":"https://github.com/laerte-guimaraes/vindi-magento","homepage":"https://www.vindi.com.br","size":198,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vindi:master","ref":"master","sha":"43427a64d60bc1414dabcfcd32169b71af6daafa","user":{"login":"vindi","id":6664923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2NjQ5MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6664923?v=4","gravatar_id":"","url":"https://api.github.com/users/vindi","html_url":"https://github.com/vindi","followers_url":"https://api.github.com/users/vindi/followers","following_url":"https://api.github.com/users/vindi/following{/other_user}","gists_url":"https://api.github.com/users/vindi/gists{/gist_id}","starred_url":"https://api.github.com/users/vindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindi/subscriptions","organizations_url":"https://api.github.com/users/vindi/orgs","repos_url":"https://api.github.com/users/vindi/repos","events_url":"https://api.github.com/users/vindi/events{/privacy}","received_events_url":"https://api.github.com/users/vindi/received_events","type":"Organization","site_admin":false},"repo":{"id":37740683,"node_id":"MDEwOlJlcG9zaXRvcnkzNzc0MDY4Mw==","name":"vindi-magento","full_name":"vindi/vindi-magento","owner":{"login":"vindi","id":6664923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2NjQ5MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6664923?v=4","gravatar_id":"","url":"https://api.github.com/users/vindi","html_url":"https://github.com/vindi","followers_url":"https://api.github.com/users/vindi/followers","following_url":"https://api.github.com/users/vindi/following{/other_user}","gists_url":"https://api.github.com/users/vindi/gists{/gist_id}","starred_url":"https://api.github.com/users/vindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindi/subscriptions","organizations_url":"https://api.github.com/users/vindi/orgs","repos_url":"https://api.github.com/users/vindi/repos","events_url":"https://api.github.com/users/vindi/events{/privacy}","received_events_url":"https://api.github.com/users/vindi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vindi/vindi-magento","description":"Módulo de cobrança recorrente para Magento","fork":false,"url":"https://api.github.com/repos/vindi/vindi-magento","forks_url":"https://api.github.com/repos/vindi/vindi-magento/forks","keys_url":"https://api.github.com/repos/vindi/vindi-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vindi/vindi-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vindi/vindi-magento/teams","hooks_url":"https://api.github.com/repos/vindi/vindi-magento/hooks","issue_events_url":"https://api.github.com/repos/vindi/vindi-magento/issues/events{/number}","events_url":"https://api.github.com/repos/vindi/vindi-magento/events","assignees_url":"https://api.github.com/repos/vindi/vindi-magento/assignees{/user}","branches_url":"https://api.github.com/repos/vindi/vindi-magento/branches{/branch}","tags_url":"https://api.github.com/repos/vindi/vindi-magento/tags","blobs_url":"https://api.github.com/repos/vindi/vindi-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vindi/vindi-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vindi/vindi-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/vindi/vindi-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vindi/vindi-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/vindi/vindi-magento/languages","stargazers_url":"https://api.github.com/repos/vindi/vindi-magento/stargazers","contributors_url":"https://api.github.com/repos/vindi/vindi-magento/contributors","subscribers_url":"https://api.github.com/repos/vindi/vindi-magento/subscribers","subscription_url":"https://api.github.com/repos/vindi/vindi-magento/subscription","commits_url":"https://api.github.com/repos/vindi/vindi-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/vindi/vindi-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/vindi/vindi-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/vindi/vindi-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/vindi/vindi-magento/contents/{+path}","compare_url":"https://api.github.com/repos/vindi/vindi-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vindi/vindi-magento/merges","archive_url":"https://api.github.com/repos/vindi/vindi-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vindi/vindi-magento/downloads","issues_url":"https://api.github.com/repos/vindi/vindi-magento/issues{/number}","pulls_url":"https://api.github.com/repos/vindi/vindi-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/vindi/vindi-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/vindi/vindi-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vindi/vindi-magento/labels{/name}","releases_url":"https://api.github.com/repos/vindi/vindi-magento/releases{/id}","deployments_url":"https://api.github.com/repos/vindi/vindi-magento/deployments","created_at":"2015-06-19T19:05:36Z","updated_at":"2018-04-11T21:28:55Z","pushed_at":"2018-06-14T22:14:44Z","git_url":"git://github.com/vindi/vindi-magento.git","ssh_url":"git@github.com:vindi/vindi-magento.git","clone_url":"https://github.com/vindi/vindi-magento.git","svn_url":"https://github.com/vindi/vindi-magento","homepage":"https://www.vindi.com.br","size":172,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/47"},"html":{"href":"https://github.com/vindi/vindi-magento/pull/47"},"issue":{"href":"https://api.github.com/repos/vindi/vindi-magento/issues/47"},"comments":{"href":"https://api.github.com/repos/vindi/vindi-magento/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/vindi/vindi-magento/statuses/7d25683302439a02a7f19a40d6628667c110302a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laerte-guimaraes"}}