{"action":"created","comment":{"url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/comments/198107689","pull_request_review_id":131974739,"id":198107689,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODEwNzY4OQ==","diff_hunk":"@@ -903,19 +937,33 @@ private boolean handleJmxNotificationForCassandra21(\n         break;\n \n       case SESSION_FAILED:\n-        LOG.warn(\"repair session failed for segment with id '{}' and repair number '{}'\", segmentId, repairNumber);\n+        LOG.warn(\n+            \"repair session failed for segment with id '{}' and repair number '{}'\",\n+            segmentId,\n+            repairNumber);\n         failOutsideSynchronizedBlock = true;\n+        // Since we can get out of order notifications,\n+        // we need to exit if we already got the COMPLETE notification.","path":"src/server/src/main/java/io/cassandrareaper/service/SegmentRunner.java","position":93,"original_position":93,"commit_id":"9ebf7105eca560557d128c1312b649bfa0d9dcb2","original_commit_id":"9ebf7105eca560557d128c1312b649bfa0d9dcb2","user":{"login":"michaelsembwever","id":559444,"node_id":"MDQ6VXNlcjU1OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/559444?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelsembwever","html_url":"https://github.com/michaelsembwever","followers_url":"https://api.github.com/users/michaelsembwever/followers","following_url":"https://api.github.com/users/michaelsembwever/following{/other_user}","gists_url":"https://api.github.com/users/michaelsembwever/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelsembwever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelsembwever/subscriptions","organizations_url":"https://api.github.com/users/michaelsembwever/orgs","repos_url":"https://api.github.com/users/michaelsembwever/repos","events_url":"https://api.github.com/users/michaelsembwever/events{/privacy}","received_events_url":"https://api.github.com/users/michaelsembwever/received_events","type":"User","site_admin":false},"body":"can we add an `assert` here that success hasn't already been marked true.","created_at":"2018-06-26T11:27:19Z","updated_at":"2018-06-26T11:28:05Z","html_url":"https://github.com/thelastpickle/cassandra-reaper/pull/449#discussion_r198107689","pull_request_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/449","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/comments/198107689"},"html":{"href":"https://github.com/thelastpickle/cassandra-reaper/pull/449#discussion_r198107689"},"pull_request":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/449","id":195881482,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODgxNDgy","html_url":"https://github.com/thelastpickle/cassandra-reaper/pull/449","diff_url":"https://github.com/thelastpickle/cassandra-reaper/pull/449.diff","patch_url":"https://github.com/thelastpickle/cassandra-reaper/pull/449.patch","issue_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues/449","number":449,"state":"open","locked":false,"title":"Handle out of order repair notifications","user":{"login":"adejanovski","id":5096002,"node_id":"MDQ6VXNlcjUwOTYwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5096002?v=4","gravatar_id":"","url":"https://api.github.com/users/adejanovski","html_url":"https://github.com/adejanovski","followers_url":"https://api.github.com/users/adejanovski/followers","following_url":"https://api.github.com/users/adejanovski/following{/other_user}","gists_url":"https://api.github.com/users/adejanovski/gists{/gist_id}","starred_url":"https://api.github.com/users/adejanovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adejanovski/subscriptions","organizations_url":"https://api.github.com/users/adejanovski/orgs","repos_url":"https://api.github.com/users/adejanovski/repos","events_url":"https://api.github.com/users/adejanovski/events{/privacy}","received_events_url":"https://api.github.com/users/adejanovski/received_events","type":"User","site_admin":false},"body":"In the case repair sessions end in a very short time (within a few 10s of milliseconds) we can get out of order notifications from Cassandra :\r\nInstead of `START -> SUCCESS -> COMPLETE`, we get `START -> COMPLETE -> SUCCESS`\r\nThis commit handles this case by not signaling the wait condition of the segment unless we have both a `SUCCESS` or an `ERROR` notification plus a `COMPLETE` one.","created_at":"2018-06-19T16:10:45Z","updated_at":"2018-06-26T11:28:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7211c8c3aeab5ac94d8b4726a55386e52040677","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/449/commits","review_comments_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/449/comments","review_comment_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues/449/comments","statuses_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/statuses/9ebf7105eca560557d128c1312b649bfa0d9dcb2","head":{"label":"thelastpickle:alex/handle_out_of_order_notifications","ref":"alex/handle_out_of_order_notifications","sha":"9ebf7105eca560557d128c1312b649bfa0d9dcb2","user":{"login":"thelastpickle","id":30403496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNDAzNDk2","avatar_url":"https://avatars2.githubusercontent.com/u/30403496?v=4","gravatar_id":"","url":"https://api.github.com/users/thelastpickle","html_url":"https://github.com/thelastpickle","followers_url":"https://api.github.com/users/thelastpickle/followers","following_url":"https://api.github.com/users/thelastpickle/following{/other_user}","gists_url":"https://api.github.com/users/thelastpickle/gists{/gist_id}","starred_url":"https://api.github.com/users/thelastpickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelastpickle/subscriptions","organizations_url":"https://api.github.com/users/thelastpickle/orgs","repos_url":"https://api.github.com/users/thelastpickle/repos","events_url":"https://api.github.com/users/thelastpickle/events{/privacy}","received_events_url":"https://api.github.com/users/thelastpickle/received_events","type":"Organization","site_admin":false},"repo":{"id":70856121,"node_id":"MDEwOlJlcG9zaXRvcnk3MDg1NjEyMQ==","name":"cassandra-reaper","full_name":"thelastpickle/cassandra-reaper","owner":{"login":"thelastpickle","id":30403496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNDAzNDk2","avatar_url":"https://avatars2.githubusercontent.com/u/30403496?v=4","gravatar_id":"","url":"https://api.github.com/users/thelastpickle","html_url":"https://github.com/thelastpickle","followers_url":"https://api.github.com/users/thelastpickle/followers","following_url":"https://api.github.com/users/thelastpickle/following{/other_user}","gists_url":"https://api.github.com/users/thelastpickle/gists{/gist_id}","starred_url":"https://api.github.com/users/thelastpickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelastpickle/subscriptions","organizations_url":"https://api.github.com/users/thelastpickle/orgs","repos_url":"https://api.github.com/users/thelastpickle/repos","events_url":"https://api.github.com/users/thelastpickle/events{/privacy}","received_events_url":"https://api.github.com/users/thelastpickle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thelastpickle/cassandra-reaper","description":"Automated Repair Awesomeness for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/thelastpickle/cassandra-reaper","forks_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/forks","keys_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/teams","hooks_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/hooks","issue_events_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues/events{/number}","events_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/events","assignees_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/assignees{/user}","branches_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/branches{/branch}","tags_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/tags","blobs_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/refs{/sha}","trees_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/statuses/{sha}","languages_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/languages","stargazers_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/stargazers","contributors_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/contributors","subscribers_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/subscribers","subscription_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/subscription","commits_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/commits{/sha}","git_commits_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/commits{/sha}","comments_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/comments{/number}","issue_comment_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues/comments{/number}","contents_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/contents/{+path}","compare_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/merges","archive_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/downloads","issues_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues{/number}","pulls_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls{/number}","milestones_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/milestones{/number}","notifications_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/labels{/name}","releases_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/releases{/id}","deployments_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/deployments","created_at":"2016-10-13T23:25:17Z","updated_at":"2018-06-21T13:48:45Z","pushed_at":"2018-06-26T11:24:21Z","git_url":"git://github.com/thelastpickle/cassandra-reaper.git","ssh_url":"git@github.com:thelastpickle/cassandra-reaper.git","clone_url":"https://github.com/thelastpickle/cassandra-reaper.git","svn_url":"https://github.com/thelastpickle/cassandra-reaper","homepage":"http://cassandra-reaper.io/","size":25094,"stargazers_count":179,"watchers_count":179,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":85,"open_issues":84,"watchers":179,"default_branch":"master"}},"base":{"label":"thelastpickle:master","ref":"master","sha":"c4feb99a34c1621282717494d18aac868aa92194","user":{"login":"thelastpickle","id":30403496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNDAzNDk2","avatar_url":"https://avatars2.githubusercontent.com/u/30403496?v=4","gravatar_id":"","url":"https://api.github.com/users/thelastpickle","html_url":"https://github.com/thelastpickle","followers_url":"https://api.github.com/users/thelastpickle/followers","following_url":"https://api.github.com/users/thelastpickle/following{/other_user}","gists_url":"https://api.github.com/users/thelastpickle/gists{/gist_id}","starred_url":"https://api.github.com/users/thelastpickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelastpickle/subscriptions","organizations_url":"https://api.github.com/users/thelastpickle/orgs","repos_url":"https://api.github.com/users/thelastpickle/repos","events_url":"https://api.github.com/users/thelastpickle/events{/privacy}","received_events_url":"https://api.github.com/users/thelastpickle/received_events","type":"Organization","site_admin":false},"repo":{"id":70856121,"node_id":"MDEwOlJlcG9zaXRvcnk3MDg1NjEyMQ==","name":"cassandra-reaper","full_name":"thelastpickle/cassandra-reaper","owner":{"login":"thelastpickle","id":30403496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNDAzNDk2","avatar_url":"https://avatars2.githubusercontent.com/u/30403496?v=4","gravatar_id":"","url":"https://api.github.com/users/thelastpickle","html_url":"https://github.com/thelastpickle","followers_url":"https://api.github.com/users/thelastpickle/followers","following_url":"https://api.github.com/users/thelastpickle/following{/other_user}","gists_url":"https://api.github.com/users/thelastpickle/gists{/gist_id}","starred_url":"https://api.github.com/users/thelastpickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelastpickle/subscriptions","organizations_url":"https://api.github.com/users/thelastpickle/orgs","repos_url":"https://api.github.com/users/thelastpickle/repos","events_url":"https://api.github.com/users/thelastpickle/events{/privacy}","received_events_url":"https://api.github.com/users/thelastpickle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thelastpickle/cassandra-reaper","description":"Automated Repair Awesomeness for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/thelastpickle/cassandra-reaper","forks_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/forks","keys_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/teams","hooks_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/hooks","issue_events_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues/events{/number}","events_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/events","assignees_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/assignees{/user}","branches_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/branches{/branch}","tags_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/tags","blobs_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/refs{/sha}","trees_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/statuses/{sha}","languages_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/languages","stargazers_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/stargazers","contributors_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/contributors","subscribers_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/subscribers","subscription_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/subscription","commits_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/commits{/sha}","git_commits_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/git/commits{/sha}","comments_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/comments{/number}","issue_comment_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues/comments{/number}","contents_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/contents/{+path}","compare_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/merges","archive_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/downloads","issues_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues{/number}","pulls_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls{/number}","milestones_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/milestones{/number}","notifications_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/labels{/name}","releases_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/releases{/id}","deployments_url":"https://api.github.com/repos/thelastpickle/cassandra-reaper/deployments","created_at":"2016-10-13T23:25:17Z","updated_at":"2018-06-21T13:48:45Z","pushed_at":"2018-06-26T11:24:21Z","git_url":"git://github.com/thelastpickle/cassandra-reaper.git","ssh_url":"git@github.com:thelastpickle/cassandra-reaper.git","clone_url":"https://github.com/thelastpickle/cassandra-reaper.git","svn_url":"https://github.com/thelastpickle/cassandra-reaper","homepage":"http://cassandra-reaper.io/","size":25094,"stargazers_count":179,"watchers_count":179,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":85,"open_issues":84,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/449"},"html":{"href":"https://github.com/thelastpickle/cassandra-reaper/pull/449"},"issue":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues/449"},"comments":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/thelastpickle/cassandra-reaper/statuses/9ebf7105eca560557d128c1312b649bfa0d9dcb2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"michaelsembwever"}}