{"action":"created","comment":{"url":"https://api.github.com/repos/QwantResearch/idunn/pulls/comments/204668651","pull_request_review_id":139785935,"id":204668651,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDY2ODY1MQ==","diff_hunk":"@@ -24,7 +24,7 @@ To run the api you need to do:\n `pipenv install`\n \n and then\n-`IDUNN_ES_URL=<url_to_elasticsearch> pipenv run python app.py`\n+`IDUNN_MIMIR_ES=<url_to_elasticsearch> IDUNN_WIKI_ES=<url_to_WIKI_ES> pipenv run python app.py`","path":"README.md","position":5,"original_position":5,"commit_id":"8afcef0466640a957213bf873c59cea471e6b895","original_commit_id":"8afcef0466640a957213bf873c59cea471e6b895","user":{"login":"antoine-de","id":3987698,"node_id":"MDQ6VXNlcjM5ODc2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3987698?v=4","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"I think `<url_to_elasticsearch>` is now a bit vague","created_at":"2018-07-24T08:35:48Z","updated_at":"2018-07-24T08:40:15Z","html_url":"https://github.com/QwantResearch/idunn/pull/17#discussion_r204668651","pull_request_url":"https://api.github.com/repos/QwantResearch/idunn/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/QwantResearch/idunn/pulls/comments/204668651"},"html":{"href":"https://github.com/QwantResearch/idunn/pull/17#discussion_r204668651"},"pull_request":{"href":"https://api.github.com/repos/QwantResearch/idunn/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/QwantResearch/idunn/pulls/17","id":202875716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODc1NzE2","html_url":"https://github.com/QwantResearch/idunn/pull/17","diff_url":"https://github.com/QwantResearch/idunn/pull/17.diff","patch_url":"https://github.com/QwantResearch/idunn/pull/17.patch","issue_url":"https://api.github.com/repos/QwantResearch/idunn/issues/17","number":17,"state":"open","locked":false,"title":"Bypass Wikipedia API","user":{"login":"jbgriesner","id":33450151,"node_id":"MDQ6VXNlcjMzNDUwMTUx","avatar_url":"https://avatars3.githubusercontent.com/u/33450151?v=4","gravatar_id":"","url":"https://api.github.com/users/jbgriesner","html_url":"https://github.com/jbgriesner","followers_url":"https://api.github.com/users/jbgriesner/followers","following_url":"https://api.github.com/users/jbgriesner/following{/other_user}","gists_url":"https://api.github.com/users/jbgriesner/gists{/gist_id}","starred_url":"https://api.github.com/users/jbgriesner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbgriesner/subscriptions","organizations_url":"https://api.github.com/users/jbgriesner/orgs","repos_url":"https://api.github.com/users/jbgriesner/repos","events_url":"https://api.github.com/users/jbgriesner/events{/privacy}","received_events_url":"https://api.github.com/users/jbgriesner/received_events","type":"User","site_admin":false},"body":"Our intern elastic contains enough POI information to bypass the Wikipedia API.\r\nIf the request language belongs to the (comma separated string) list ES_WIKI_LANG, then we fetch this elastic, otherwise we request the Wikipedia API as we did before.","created_at":"2018-07-20T15:01:53Z","updated_at":"2018-07-24T08:40:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4125e95c6cfb90691ea62092fd40240b5a8bf7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QwantResearch/idunn/pulls/17/commits","review_comments_url":"https://api.github.com/repos/QwantResearch/idunn/pulls/17/comments","review_comment_url":"https://api.github.com/repos/QwantResearch/idunn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QwantResearch/idunn/issues/17/comments","statuses_url":"https://api.github.com/repos/QwantResearch/idunn/statuses/8afcef0466640a957213bf873c59cea471e6b895","head":{"label":"jbgriesner:ES_nice_IA","ref":"ES_nice_IA","sha":"8afcef0466640a957213bf873c59cea471e6b895","user":{"login":"jbgriesner","id":33450151,"node_id":"MDQ6VXNlcjMzNDUwMTUx","avatar_url":"https://avatars3.githubusercontent.com/u/33450151?v=4","gravatar_id":"","url":"https://api.github.com/users/jbgriesner","html_url":"https://github.com/jbgriesner","followers_url":"https://api.github.com/users/jbgriesner/followers","following_url":"https://api.github.com/users/jbgriesner/following{/other_user}","gists_url":"https://api.github.com/users/jbgriesner/gists{/gist_id}","starred_url":"https://api.github.com/users/jbgriesner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbgriesner/subscriptions","organizations_url":"https://api.github.com/users/jbgriesner/orgs","repos_url":"https://api.github.com/users/jbgriesner/repos","events_url":"https://api.github.com/users/jbgriesner/events{/privacy}","received_events_url":"https://api.github.com/users/jbgriesner/received_events","type":"User","site_admin":false},"repo":{"id":135319273,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMTkyNzM=","name":"idunn","full_name":"jbgriesner/idunn","owner":{"login":"jbgriesner","id":33450151,"node_id":"MDQ6VXNlcjMzNDUwMTUx","avatar_url":"https://avatars3.githubusercontent.com/u/33450151?v=4","gravatar_id":"","url":"https://api.github.com/users/jbgriesner","html_url":"https://github.com/jbgriesner","followers_url":"https://api.github.com/users/jbgriesner/followers","following_url":"https://api.github.com/users/jbgriesner/following{/other_user}","gists_url":"https://api.github.com/users/jbgriesner/gists{/gist_id}","starred_url":"https://api.github.com/users/jbgriesner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbgriesner/subscriptions","organizations_url":"https://api.github.com/users/jbgriesner/orgs","repos_url":"https://api.github.com/users/jbgriesner/repos","events_url":"https://api.github.com/users/jbgriesner/events{/privacy}","received_events_url":"https://api.github.com/users/jbgriesner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbgriesner/idunn","description":"poi API over mimir (ElasticSearch database) for QwantMaps","fork":true,"url":"https://api.github.com/repos/jbgriesner/idunn","forks_url":"https://api.github.com/repos/jbgriesner/idunn/forks","keys_url":"https://api.github.com/repos/jbgriesner/idunn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbgriesner/idunn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbgriesner/idunn/teams","hooks_url":"https://api.github.com/repos/jbgriesner/idunn/hooks","issue_events_url":"https://api.github.com/repos/jbgriesner/idunn/issues/events{/number}","events_url":"https://api.github.com/repos/jbgriesner/idunn/events","assignees_url":"https://api.github.com/repos/jbgriesner/idunn/assignees{/user}","branches_url":"https://api.github.com/repos/jbgriesner/idunn/branches{/branch}","tags_url":"https://api.github.com/repos/jbgriesner/idunn/tags","blobs_url":"https://api.github.com/repos/jbgriesner/idunn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbgriesner/idunn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbgriesner/idunn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbgriesner/idunn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbgriesner/idunn/statuses/{sha}","languages_url":"https://api.github.com/repos/jbgriesner/idunn/languages","stargazers_url":"https://api.github.com/repos/jbgriesner/idunn/stargazers","contributors_url":"https://api.github.com/repos/jbgriesner/idunn/contributors","subscribers_url":"https://api.github.com/repos/jbgriesner/idunn/subscribers","subscription_url":"https://api.github.com/repos/jbgriesner/idunn/subscription","commits_url":"https://api.github.com/repos/jbgriesner/idunn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbgriesner/idunn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbgriesner/idunn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbgriesner/idunn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbgriesner/idunn/contents/{+path}","compare_url":"https://api.github.com/repos/jbgriesner/idunn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbgriesner/idunn/merges","archive_url":"https://api.github.com/repos/jbgriesner/idunn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbgriesner/idunn/downloads","issues_url":"https://api.github.com/repos/jbgriesner/idunn/issues{/number}","pulls_url":"https://api.github.com/repos/jbgriesner/idunn/pulls{/number}","milestones_url":"https://api.github.com/repos/jbgriesner/idunn/milestones{/number}","notifications_url":"https://api.github.com/repos/jbgriesner/idunn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbgriesner/idunn/labels{/name}","releases_url":"https://api.github.com/repos/jbgriesner/idunn/releases{/id}","deployments_url":"https://api.github.com/repos/jbgriesner/idunn/deployments","created_at":"2018-05-29T15:50:06Z","updated_at":"2018-07-16T09:01:50Z","pushed_at":"2018-07-23T15:22:14Z","git_url":"git://github.com/jbgriesner/idunn.git","ssh_url":"git@github.com:jbgriesner/idunn.git","clone_url":"https://github.com/jbgriesner/idunn.git","svn_url":"https://github.com/jbgriesner/idunn","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QwantResearch:master","ref":"master","sha":"3233a119ce80ed49a655fdb155317455cab01936","user":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":133823727,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM4MjM3Mjc=","name":"idunn","full_name":"QwantResearch/idunn","owner":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QwantResearch/idunn","description":"poi API over mimir (ElasticSearch database) for QwantMaps","fork":false,"url":"https://api.github.com/repos/QwantResearch/idunn","forks_url":"https://api.github.com/repos/QwantResearch/idunn/forks","keys_url":"https://api.github.com/repos/QwantResearch/idunn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QwantResearch/idunn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QwantResearch/idunn/teams","hooks_url":"https://api.github.com/repos/QwantResearch/idunn/hooks","issue_events_url":"https://api.github.com/repos/QwantResearch/idunn/issues/events{/number}","events_url":"https://api.github.com/repos/QwantResearch/idunn/events","assignees_url":"https://api.github.com/repos/QwantResearch/idunn/assignees{/user}","branches_url":"https://api.github.com/repos/QwantResearch/idunn/branches{/branch}","tags_url":"https://api.github.com/repos/QwantResearch/idunn/tags","blobs_url":"https://api.github.com/repos/QwantResearch/idunn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QwantResearch/idunn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QwantResearch/idunn/git/refs{/sha}","trees_url":"https://api.github.com/repos/QwantResearch/idunn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QwantResearch/idunn/statuses/{sha}","languages_url":"https://api.github.com/repos/QwantResearch/idunn/languages","stargazers_url":"https://api.github.com/repos/QwantResearch/idunn/stargazers","contributors_url":"https://api.github.com/repos/QwantResearch/idunn/contributors","subscribers_url":"https://api.github.com/repos/QwantResearch/idunn/subscribers","subscription_url":"https://api.github.com/repos/QwantResearch/idunn/subscription","commits_url":"https://api.github.com/repos/QwantResearch/idunn/commits{/sha}","git_commits_url":"https://api.github.com/repos/QwantResearch/idunn/git/commits{/sha}","comments_url":"https://api.github.com/repos/QwantResearch/idunn/comments{/number}","issue_comment_url":"https://api.github.com/repos/QwantResearch/idunn/issues/comments{/number}","contents_url":"https://api.github.com/repos/QwantResearch/idunn/contents/{+path}","compare_url":"https://api.github.com/repos/QwantResearch/idunn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QwantResearch/idunn/merges","archive_url":"https://api.github.com/repos/QwantResearch/idunn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QwantResearch/idunn/downloads","issues_url":"https://api.github.com/repos/QwantResearch/idunn/issues{/number}","pulls_url":"https://api.github.com/repos/QwantResearch/idunn/pulls{/number}","milestones_url":"https://api.github.com/repos/QwantResearch/idunn/milestones{/number}","notifications_url":"https://api.github.com/repos/QwantResearch/idunn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QwantResearch/idunn/labels{/name}","releases_url":"https://api.github.com/repos/QwantResearch/idunn/releases{/id}","deployments_url":"https://api.github.com/repos/QwantResearch/idunn/deployments","created_at":"2018-05-17T14:16:14Z","updated_at":"2018-07-16T09:00:08Z","pushed_at":"2018-07-24T08:30:03Z","git_url":"git://github.com/QwantResearch/idunn.git","ssh_url":"git@github.com:QwantResearch/idunn.git","clone_url":"https://github.com/QwantResearch/idunn.git","svn_url":"https://github.com/QwantResearch/idunn","homepage":null,"size":96,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QwantResearch/idunn/pulls/17"},"html":{"href":"https://github.com/QwantResearch/idunn/pull/17"},"issue":{"href":"https://api.github.com/repos/QwantResearch/idunn/issues/17"},"comments":{"href":"https://api.github.com/repos/QwantResearch/idunn/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/QwantResearch/idunn/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/QwantResearch/idunn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QwantResearch/idunn/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/QwantResearch/idunn/statuses/8afcef0466640a957213bf873c59cea471e6b895"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"antoine-de"}}