{"action":"created","issue":{"url":"https://api.github.com/repos/desihub/desitarget/issues/309","repository_url":"https://api.github.com/repos/desihub/desitarget","labels_url":"https://api.github.com/repos/desihub/desitarget/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/desihub/desitarget/issues/309/comments","events_url":"https://api.github.com/repos/desihub/desitarget/issues/309/events","html_url":"https://github.com/desihub/desitarget/pull/309","id":318309196,"number":309,"title":"New qso rf strategy","user":{"login":"CAClaveau","id":25028503,"avatar_url":"https://avatars1.githubusercontent.com/u/25028503?v=4","gravatar_id":"","url":"https://api.github.com/users/CAClaveau","html_url":"https://github.com/CAClaveau","followers_url":"https://api.github.com/users/CAClaveau/followers","following_url":"https://api.github.com/users/CAClaveau/following{/other_user}","gists_url":"https://api.github.com/users/CAClaveau/gists{/gist_id}","starred_url":"https://api.github.com/users/CAClaveau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAClaveau/subscriptions","organizations_url":"https://api.github.com/users/CAClaveau/orgs","repos_url":"https://api.github.com/users/CAClaveau/repos","events_url":"https://api.github.com/users/CAClaveau/events{/privacy}","received_events_url":"https://api.github.com/users/CAClaveau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-27T07:42:50Z","updated_at":"2018-04-28T06:30:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/desihub/desitarget/pulls/309","html_url":"https://github.com/desihub/desitarget/pull/309","diff_url":"https://github.com/desihub/desitarget/pull/309.diff","patch_url":"https://github.com/desihub/desitarget/pull/309.patch"},"body":"Added two new QSO RF trained over DR5 and updated 'isQSO_randomforest_north/south' functions\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/desihub/desitarget/issues/comments/385145242","html_url":"https://github.com/desihub/desitarget/pull/309#issuecomment-385145242","issue_url":"https://api.github.com/repos/desihub/desitarget/issues/309","id":385145242,"user":{"login":"Cyeche","id":22040400,"avatar_url":"https://avatars1.githubusercontent.com/u/22040400?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyeche","html_url":"https://github.com/Cyeche","followers_url":"https://api.github.com/users/Cyeche/followers","following_url":"https://api.github.com/users/Cyeche/following{/other_user}","gists_url":"https://api.github.com/users/Cyeche/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyeche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyeche/subscriptions","organizations_url":"https://api.github.com/users/Cyeche/orgs","repos_url":"https://api.github.com/users/Cyeche/repos","events_url":"https://api.github.com/users/Cyeche/events{/privacy}","received_events_url":"https://api.github.com/users/Cyeche/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T06:30:50Z","updated_at":"2018-04-28T06:30:50Z","author_association":"CONTRIBUTOR","body":"Hi,\n\nI have a problem with the footprint which is not the same. It is particularly visible with DR6. The edge of the footprint are not the same if we compare the two QA plots\n\nhttp://portal.nersc.gov/project/desi/users/adamyers/desitargetQA-dr6.0-NEW_QSO_RF_STRATEGY/QSO.html <http://portal.nersc.gov/project/desi/users/adamyers/desitargetQA-dr6.0-NEW_QSO_RF_STRATEGY/QSO.html>\nhttp://portal.nersc.gov/project/desi/users/adamyers/desitargetQA-dr6-0.20.0/QSO.html\n\nWe should understand if it is due to the fact that we relax a cut such as (g>0 & r>0& ….) in the QSO selection or that the definition of the footprint has changed. \n\nNote that we have something similar with DR6 but less pronounced.\n\n\n\n> \n> @geordie666 requested changes on this pull request.\n> \n> Code looks OK...see request for @Cyeche <https://github.com/Cyeche> to look at the QA output.\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub <https://github.com/desihub/desitarget/pull/309#pullrequestreview-116091455>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVBPUGIYigirs5QDlRg4yaRchw_OblIHks5ts5CTgaJpZM4Tp61G>.\n> \n\n"}}
{"actor":{"display_login":"Cyeche"}}