{"action":"created","issue":{"url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1456","repository_url":"https://api.github.com/repos/webtorrent/webtorrent","labels_url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1456/labels{/name}","comments_url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1456/comments","events_url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1456/events","html_url":"https://github.com/webtorrent/webtorrent/pull/1456","id":346823776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTkzNzky","number":1456,"title":"Indexeddb chunk store in browser","user":{"login":"KayleePop","id":34007889,"node_id":"MDQ6VXNlcjM0MDA3ODg5","avatar_url":"https://avatars0.githubusercontent.com/u/34007889?v=4","gravatar_id":"","url":"https://api.github.com/users/KayleePop","html_url":"https://github.com/KayleePop","followers_url":"https://api.github.com/users/KayleePop/followers","following_url":"https://api.github.com/users/KayleePop/following{/other_user}","gists_url":"https://api.github.com/users/KayleePop/gists{/gist_id}","starred_url":"https://api.github.com/users/KayleePop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KayleePop/subscriptions","organizations_url":"https://api.github.com/users/KayleePop/orgs","repos_url":"https://api.github.com/users/KayleePop/repos","events_url":"https://api.github.com/users/KayleePop/events{/privacy}","received_events_url":"https://api.github.com/users/KayleePop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-02T01:14:15Z","updated_at":"2018-08-02T01:17:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/webtorrent/webtorrent/pulls/1456","html_url":"https://github.com/webtorrent/webtorrent/pull/1456","diff_url":"https://github.com/webtorrent/webtorrent/pull/1456.diff","patch_url":"https://github.com/webtorrent/webtorrent/pull/1456.patch"},"body":"Here's the chunk store used https://github.com/KayleePop/idbkv-chunk-store\r\nwhich is built on this IndexedDB wrapper https://github.com/KayleePop/idb-kv\r\n\r\n`npm run size` shows this branch's bundle to be `85,906 bytes` which compared to the `85,234 bytes` of master is a .8% increase or 672 bytes larger\r\n\r\n&nbsp;\r\n\r\nHere's a deployment of instant.io using this PR's code for demo and smoke testing https://spiritual-tenor.glitch.me/ (glitch.com is awesome)\r\n\r\nThings to test (please share results :smile: ):\r\n- Very large files\r\n- Concurrent downloads of different torrents\r\n- Multiple browser tabs (they use the same indexeddb database)\r\n- RAM usage\r\n- Speed compared to https://instant.io\r\n  - Speed of completing download\r\n  - downloading the file to disk\r\n- Streaming\r\n- Different browsers\r\n  "},"comment":{"url":"https://api.github.com/repos/webtorrent/webtorrent/issues/comments/409774080","html_url":"https://github.com/webtorrent/webtorrent/pull/1456#issuecomment-409774080","issue_url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1456","id":409774080,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTc3NDA4MA==","user":{"login":"KayleePop","id":34007889,"node_id":"MDQ6VXNlcjM0MDA3ODg5","avatar_url":"https://avatars0.githubusercontent.com/u/34007889?v=4","gravatar_id":"","url":"https://api.github.com/users/KayleePop","html_url":"https://github.com/KayleePop","followers_url":"https://api.github.com/users/KayleePop/followers","following_url":"https://api.github.com/users/KayleePop/following{/other_user}","gists_url":"https://api.github.com/users/KayleePop/gists{/gist_id}","starred_url":"https://api.github.com/users/KayleePop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KayleePop/subscriptions","organizations_url":"https://api.github.com/users/KayleePop/orgs","repos_url":"https://api.github.com/users/KayleePop/repos","events_url":"https://api.github.com/users/KayleePop/events{/privacy}","received_events_url":"https://api.github.com/users/KayleePop/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T01:17:48Z","updated_at":"2018-08-02T01:17:48Z","author_association":"CONTRIBUTOR","body":"One thing I noticed is that everything breaks in Firefox's private browsing mode (ctrl+shift+P). This is because Firefox simply disables indexeddb in that mode.\r\n\r\nMaybe this could be fixed by allowing immediate-chunk-store to act like memory-chunk-store if there are errors returned from put()\r\n\r\nRight now it's deleting the data if the put() callback is called with an error https://github.com/feross/immediate-chunk-store/blob/master/index.js#L20"}}
{"actor":{"display_login":"KayleePop"}}