{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acr-builder/pulls/comments/207618193","pull_request_review_id":143273340,"id":207618193,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzYxODE5Mw==","diff_hunk":"@@ -90,48 +82,39 @@ func (b *Builder) RunAllBuildSteps(ctx context.Context, pipeline *graph.Pipeline\n \t\treturn err\n \t}\n \n-\tfor k, v := range pipeline.Dag.Nodes {\n-\t\tif k == graph.RootNodeID {\n+\tvar deps []*models.ImageDependencies\n+\tfor _, n := range pipeline.Dag.Nodes {\n+\t\tstep := n.Value\n+\t\tlog.Printf(\"Step ID %v marked as %v (elapsed time in seconds: %f)\\n\", step.ID, step.StepStatus, step.EndTime.Sub(step.StartTime).Seconds())\n+\n+\t\tif !step.IsBuildStep() { // If the step isn't a build step, it won't have dependencies from the scanner.","path":"builder/builder.go","position":null,"original_position":85,"commit_id":"f8f150bc0c4c23fe7c3e0705819ed58fe9f48e57","original_commit_id":"33bc2108d8d21ec915a362aa96d1c574262e37b8","user":{"login":"ehotinger","id":1822836,"node_id":"MDQ6VXNlcjE4MjI4MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1822836?v=4","gravatar_id":"","url":"https://api.github.com/users/ehotinger","html_url":"https://github.com/ehotinger","followers_url":"https://api.github.com/users/ehotinger/followers","following_url":"https://api.github.com/users/ehotinger/following{/other_user}","gists_url":"https://api.github.com/users/ehotinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ehotinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehotinger/subscriptions","organizations_url":"https://api.github.com/users/ehotinger/orgs","repos_url":"https://api.github.com/users/ehotinger/repos","events_url":"https://api.github.com/users/ehotinger/events{/privacy}","received_events_url":"https://api.github.com/users/ehotinger/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-08-03T17:43:38Z","updated_at":"2018-08-03T17:43:38Z","html_url":"https://github.com/Azure/acr-builder/pull/189#discussion_r207618193","pull_request_url":"https://api.github.com/repos/Azure/acr-builder/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/comments/207618193"},"html":{"href":"https://github.com/Azure/acr-builder/pull/189#discussion_r207618193"},"pull_request":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/189"}},"in_reply_to_id":207555999},"pull_request":{"url":"https://api.github.com/repos/Azure/acr-builder/pulls/189","id":205956745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTU2NzQ1","html_url":"https://github.com/Azure/acr-builder/pull/189","diff_url":"https://github.com/Azure/acr-builder/pull/189.diff","patch_url":"https://github.com/Azure/acr-builder/pull/189.patch","issue_url":"https://api.github.com/repos/Azure/acr-builder/issues/189","number":189,"state":"open","locked":false,"title":"Aggregate image dependencies across multiple build steps","user":{"login":"ehotinger","id":1822836,"node_id":"MDQ6VXNlcjE4MjI4MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1822836?v=4","gravatar_id":"","url":"https://api.github.com/users/ehotinger","html_url":"https://github.com/ehotinger","followers_url":"https://api.github.com/users/ehotinger/followers","following_url":"https://api.github.com/users/ehotinger/following{/other_user}","gists_url":"https://api.github.com/users/ehotinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ehotinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehotinger/subscriptions","organizations_url":"https://api.github.com/users/ehotinger/orgs","repos_url":"https://api.github.com/users/ehotinger/repos","events_url":"https://api.github.com/users/ehotinger/events{/privacy}","received_events_url":"https://api.github.com/users/ehotinger/received_events","type":"User","site_admin":false},"body":"**Purpose of the PR:**\r\n\r\n- Aggregate all image dependencies across multiple `build` steps and flush this information once at the end of the entire pipeline. \r\n- Simplify DAG traversal by first-classing the root node; `Nodes` will consist of all other vertexes, making a `range` loop easier.\r\n- Update dockerignore to add a few additional files\r\n- When querying digest, use `buf` instead of `os.StdErr`, this is a bug.\r\n- Remove unused mutex from `builder`\r\n- Misc. small refactorings\r\n- Add a test for `getRepoDigest`\r\n- Update README\r\n- Use `log` instead of `fmt` in several places to add timing information in critical sections.\r\n- Ignore errors in several places which are unrecoverable\r\n\r\n**Fixes #184**","created_at":"2018-08-03T08:13:38Z","updated_at":"2018-08-03T17:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9b23790f1c7891c789f54da6c2b4311c50b792d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sajayantony","id":1821104,"node_id":"MDQ6VXNlcjE4MjExMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1821104?v=4","gravatar_id":"","url":"https://api.github.com/users/sajayantony","html_url":"https://github.com/sajayantony","followers_url":"https://api.github.com/users/sajayantony/followers","following_url":"https://api.github.com/users/sajayantony/following{/other_user}","gists_url":"https://api.github.com/users/sajayantony/gists{/gist_id}","starred_url":"https://api.github.com/users/sajayantony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajayantony/subscriptions","organizations_url":"https://api.github.com/users/sajayantony/orgs","repos_url":"https://api.github.com/users/sajayantony/repos","events_url":"https://api.github.com/users/sajayantony/events{/privacy}","received_events_url":"https://api.github.com/users/sajayantony/received_events","type":"User","site_admin":false},{"login":"mnltejaswini","id":8011073,"node_id":"MDQ6VXNlcjgwMTEwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8011073?v=4","gravatar_id":"","url":"https://api.github.com/users/mnltejaswini","html_url":"https://github.com/mnltejaswini","followers_url":"https://api.github.com/users/mnltejaswini/followers","following_url":"https://api.github.com/users/mnltejaswini/following{/other_user}","gists_url":"https://api.github.com/users/mnltejaswini/gists{/gist_id}","starred_url":"https://api.github.com/users/mnltejaswini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnltejaswini/subscriptions","organizations_url":"https://api.github.com/users/mnltejaswini/orgs","repos_url":"https://api.github.com/users/mnltejaswini/repos","events_url":"https://api.github.com/users/mnltejaswini/events{/privacy}","received_events_url":"https://api.github.com/users/mnltejaswini/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acr-builder/pulls/189/commits","review_comments_url":"https://api.github.com/repos/Azure/acr-builder/pulls/189/comments","review_comment_url":"https://api.github.com/repos/Azure/acr-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acr-builder/issues/189/comments","statuses_url":"https://api.github.com/repos/Azure/acr-builder/statuses/f8f150bc0c4c23fe7c3e0705819ed58fe9f48e57","head":{"label":"ehotinger:ehotinger/do","ref":"ehotinger/do","sha":"f8f150bc0c4c23fe7c3e0705819ed58fe9f48e57","user":{"login":"ehotinger","id":1822836,"node_id":"MDQ6VXNlcjE4MjI4MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1822836?v=4","gravatar_id":"","url":"https://api.github.com/users/ehotinger","html_url":"https://github.com/ehotinger","followers_url":"https://api.github.com/users/ehotinger/followers","following_url":"https://api.github.com/users/ehotinger/following{/other_user}","gists_url":"https://api.github.com/users/ehotinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ehotinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehotinger/subscriptions","organizations_url":"https://api.github.com/users/ehotinger/orgs","repos_url":"https://api.github.com/users/ehotinger/repos","events_url":"https://api.github.com/users/ehotinger/events{/privacy}","received_events_url":"https://api.github.com/users/ehotinger/received_events","type":"User","site_admin":false},"repo":{"id":118508589,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1MDg1ODk=","name":"acr-builder","full_name":"ehotinger/acr-builder","owner":{"login":"ehotinger","id":1822836,"node_id":"MDQ6VXNlcjE4MjI4MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1822836?v=4","gravatar_id":"","url":"https://api.github.com/users/ehotinger","html_url":"https://github.com/ehotinger","followers_url":"https://api.github.com/users/ehotinger/followers","following_url":"https://api.github.com/users/ehotinger/following{/other_user}","gists_url":"https://api.github.com/users/ehotinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ehotinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehotinger/subscriptions","organizations_url":"https://api.github.com/users/ehotinger/orgs","repos_url":"https://api.github.com/users/ehotinger/repos","events_url":"https://api.github.com/users/ehotinger/events{/privacy}","received_events_url":"https://api.github.com/users/ehotinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehotinger/acr-builder","description":"Azure Container Registry Build Runner","fork":true,"url":"https://api.github.com/repos/ehotinger/acr-builder","forks_url":"https://api.github.com/repos/ehotinger/acr-builder/forks","keys_url":"https://api.github.com/repos/ehotinger/acr-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehotinger/acr-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehotinger/acr-builder/teams","hooks_url":"https://api.github.com/repos/ehotinger/acr-builder/hooks","issue_events_url":"https://api.github.com/repos/ehotinger/acr-builder/issues/events{/number}","events_url":"https://api.github.com/repos/ehotinger/acr-builder/events","assignees_url":"https://api.github.com/repos/ehotinger/acr-builder/assignees{/user}","branches_url":"https://api.github.com/repos/ehotinger/acr-builder/branches{/branch}","tags_url":"https://api.github.com/repos/ehotinger/acr-builder/tags","blobs_url":"https://api.github.com/repos/ehotinger/acr-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehotinger/acr-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehotinger/acr-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehotinger/acr-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehotinger/acr-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/ehotinger/acr-builder/languages","stargazers_url":"https://api.github.com/repos/ehotinger/acr-builder/stargazers","contributors_url":"https://api.github.com/repos/ehotinger/acr-builder/contributors","subscribers_url":"https://api.github.com/repos/ehotinger/acr-builder/subscribers","subscription_url":"https://api.github.com/repos/ehotinger/acr-builder/subscription","commits_url":"https://api.github.com/repos/ehotinger/acr-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehotinger/acr-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehotinger/acr-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehotinger/acr-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehotinger/acr-builder/contents/{+path}","compare_url":"https://api.github.com/repos/ehotinger/acr-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehotinger/acr-builder/merges","archive_url":"https://api.github.com/repos/ehotinger/acr-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehotinger/acr-builder/downloads","issues_url":"https://api.github.com/repos/ehotinger/acr-builder/issues{/number}","pulls_url":"https://api.github.com/repos/ehotinger/acr-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/ehotinger/acr-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/ehotinger/acr-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehotinger/acr-builder/labels{/name}","releases_url":"https://api.github.com/repos/ehotinger/acr-builder/releases{/id}","deployments_url":"https://api.github.com/repos/ehotinger/acr-builder/deployments","created_at":"2018-01-22T20:06:14Z","updated_at":"2018-08-03T06:21:03Z","pushed_at":"2018-08-03T17:41:41Z","git_url":"git://github.com/ehotinger/acr-builder.git","ssh_url":"git@github.com:ehotinger/acr-builder.git","clone_url":"https://github.com/ehotinger/acr-builder.git","svn_url":"https://github.com/ehotinger/acr-builder","homepage":null,"size":2414,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"75d444e157b39c1f3e8537b1d764c0825b1ae1db","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":98698223,"node_id":"MDEwOlJlcG9zaXRvcnk5ODY5ODIyMw==","name":"acr-builder","full_name":"Azure/acr-builder","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acr-builder","description":"Azure Container Registry Build Runner","fork":false,"url":"https://api.github.com/repos/Azure/acr-builder","forks_url":"https://api.github.com/repos/Azure/acr-builder/forks","keys_url":"https://api.github.com/repos/Azure/acr-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acr-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acr-builder/teams","hooks_url":"https://api.github.com/repos/Azure/acr-builder/hooks","issue_events_url":"https://api.github.com/repos/Azure/acr-builder/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acr-builder/events","assignees_url":"https://api.github.com/repos/Azure/acr-builder/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acr-builder/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acr-builder/tags","blobs_url":"https://api.github.com/repos/Azure/acr-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acr-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acr-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acr-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acr-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acr-builder/languages","stargazers_url":"https://api.github.com/repos/Azure/acr-builder/stargazers","contributors_url":"https://api.github.com/repos/Azure/acr-builder/contributors","subscribers_url":"https://api.github.com/repos/Azure/acr-builder/subscribers","subscription_url":"https://api.github.com/repos/Azure/acr-builder/subscription","commits_url":"https://api.github.com/repos/Azure/acr-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acr-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acr-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acr-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acr-builder/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acr-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acr-builder/merges","archive_url":"https://api.github.com/repos/Azure/acr-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acr-builder/downloads","issues_url":"https://api.github.com/repos/Azure/acr-builder/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acr-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acr-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acr-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acr-builder/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acr-builder/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acr-builder/deployments","created_at":"2017-07-29T00:44:12Z","updated_at":"2018-08-02T22:38:13Z","pushed_at":"2018-08-03T17:41:43Z","git_url":"git://github.com/Azure/acr-builder.git","ssh_url":"git@github.com:Azure/acr-builder.git","clone_url":"https://github.com/Azure/acr-builder.git","svn_url":"https://github.com/Azure/acr-builder","homepage":null,"size":2278,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":9,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/189"},"html":{"href":"https://github.com/Azure/acr-builder/pull/189"},"issue":{"href":"https://api.github.com/repos/Azure/acr-builder/issues/189"},"comments":{"href":"https://api.github.com/repos/Azure/acr-builder/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acr-builder/statuses/f8f150bc0c4c23fe7c3e0705819ed58fe9f48e57"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ehotinger"}}