{"action":"opened","number":1402,"pull_request":{"url":"https://api.github.com/repos/archivesspace/archivesspace/pulls/1402","id":230251128,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjUxMTI4","html_url":"https://github.com/archivesspace/archivesspace/pull/1402","diff_url":"https://github.com/archivesspace/archivesspace/pull/1402.diff","patch_url":"https://github.com/archivesspace/archivesspace/pull/1402.patch","issue_url":"https://api.github.com/repos/archivesspace/archivesspace/issues/1402","number":1402,"state":"open","locked":false,"title":"ANW-702: Frontend accessibility improvements","user":{"login":"lorawoodford","id":15144646,"node_id":"MDQ6VXNlcjE1MTQ0NjQ2","avatar_url":"https://avatars1.githubusercontent.com/u/15144646?v=4","gravatar_id":"","url":"https://api.github.com/users/lorawoodford","html_url":"https://github.com/lorawoodford","followers_url":"https://api.github.com/users/lorawoodford/followers","following_url":"https://api.github.com/users/lorawoodford/following{/other_user}","gists_url":"https://api.github.com/users/lorawoodford/gists{/gist_id}","starred_url":"https://api.github.com/users/lorawoodford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorawoodford/subscriptions","organizations_url":"https://api.github.com/users/lorawoodford/orgs","repos_url":"https://api.github.com/users/lorawoodford/repos","events_url":"https://api.github.com/users/lorawoodford/events{/privacy}","received_events_url":"https://api.github.com/users/lorawoodford/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nFirst pass at addressing some of the worst accessibility issues on the staff-side interface.\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nChanges focus on three major areas:\r\n\r\n1. Adding hidden/screen-reader only labels to empty table headings;\r\n2. Changing empty `<a href`'s to buttons (with labels) when appropriate; and,\r\n3. Ensuring form-fields (particularly comboboxes with textual and dropdown input fields) have appropriate labels.\r\n\r\n## Related JIRA Ticket or GitHub Issue\r\n<!--- Please link to the JIRA Ticket or GitHub Issue here: -->\r\nPartial fix to https://archivesspace.atlassian.net/browse/ANW-702\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nAddresses accessibility concerns.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nExisting tests passed.  Visually inspecting known impacted pages.\r\n\r\n## Screenshots (if appropriate):\r\n\r\nHome page before:\r\n<img width=\"1434\" alt=\"current_archivesspace___home\" src=\"https://user-images.githubusercontent.com/15144646/48371974-2f1be500-e68b-11e8-9fff-5081668a5792.png\">\r\n\r\nHome page after:\r\n<img width=\"1435\" alt=\"fixed_archivesspace___home\" src=\"https://user-images.githubusercontent.com/15144646/48371980-32af6c00-e68b-11e8-866e-100ab004ffae.png\">\r\n\r\nBrowse list before:\r\n<img width=\"1436\" alt=\"current_archivesspace___resources\" src=\"https://user-images.githubusercontent.com/15144646/48371990-393de380-e68b-11e8-941e-03cf87db5a2e.png\">\r\n\r\nBrowse list after:\r\n<img width=\"1431\" alt=\"fixed_archivesspace___resources\" src=\"https://user-images.githubusercontent.com/15144646/48372036-55da1b80-e68b-11e8-96e0-1998da5b6907.png\">\r\n\r\nNew record before:\r\n<img width=\"1439\" alt=\"current_archivesspace___resources___new\" src=\"https://user-images.githubusercontent.com/15144646/48372010-4955c300-e68b-11e8-9cc8-4314797afa88.png\">\r\n\r\nNew record after:\r\n<img width=\"1437\" alt=\"fixed_archivesspace___resources___new\" src=\"https://user-images.githubusercontent.com/15144646/48371996-3e029780-e68b-11e8-9b1a-042a379bd6bc.png\">\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2018-11-12T19:58:38Z","updated_at":"2018-11-12T19:58:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/archivesspace/archivesspace/pulls/1402/commits","review_comments_url":"https://api.github.com/repos/archivesspace/archivesspace/pulls/1402/comments","review_comment_url":"https://api.github.com/repos/archivesspace/archivesspace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/archivesspace/archivesspace/issues/1402/comments","statuses_url":"https://api.github.com/repos/archivesspace/archivesspace/statuses/7956df016e704d98e10f36804ed4f8673c0bf786","head":{"label":"lorawoodford:ANW-702","ref":"ANW-702","sha":"7956df016e704d98e10f36804ed4f8673c0bf786","user":{"login":"lorawoodford","id":15144646,"node_id":"MDQ6VXNlcjE1MTQ0NjQ2","avatar_url":"https://avatars1.githubusercontent.com/u/15144646?v=4","gravatar_id":"","url":"https://api.github.com/users/lorawoodford","html_url":"https://github.com/lorawoodford","followers_url":"https://api.github.com/users/lorawoodford/followers","following_url":"https://api.github.com/users/lorawoodford/following{/other_user}","gists_url":"https://api.github.com/users/lorawoodford/gists{/gist_id}","starred_url":"https://api.github.com/users/lorawoodford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorawoodford/subscriptions","organizations_url":"https://api.github.com/users/lorawoodford/orgs","repos_url":"https://api.github.com/users/lorawoodford/repos","events_url":"https://api.github.com/users/lorawoodford/events{/privacy}","received_events_url":"https://api.github.com/users/lorawoodford/received_events","type":"User","site_admin":false},"repo":{"id":107690148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc2OTAxNDg=","name":"archivesspace","full_name":"lorawoodford/archivesspace","private":false,"owner":{"login":"lorawoodford","id":15144646,"node_id":"MDQ6VXNlcjE1MTQ0NjQ2","avatar_url":"https://avatars1.githubusercontent.com/u/15144646?v=4","gravatar_id":"","url":"https://api.github.com/users/lorawoodford","html_url":"https://github.com/lorawoodford","followers_url":"https://api.github.com/users/lorawoodford/followers","following_url":"https://api.github.com/users/lorawoodford/following{/other_user}","gists_url":"https://api.github.com/users/lorawoodford/gists{/gist_id}","starred_url":"https://api.github.com/users/lorawoodford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorawoodford/subscriptions","organizations_url":"https://api.github.com/users/lorawoodford/orgs","repos_url":"https://api.github.com/users/lorawoodford/repos","events_url":"https://api.github.com/users/lorawoodford/events{/privacy}","received_events_url":"https://api.github.com/users/lorawoodford/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lorawoodford/archivesspace","description":"The ArchivesSpace archives management tool","fork":true,"url":"https://api.github.com/repos/lorawoodford/archivesspace","forks_url":"https://api.github.com/repos/lorawoodford/archivesspace/forks","keys_url":"https://api.github.com/repos/lorawoodford/archivesspace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorawoodford/archivesspace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorawoodford/archivesspace/teams","hooks_url":"https://api.github.com/repos/lorawoodford/archivesspace/hooks","issue_events_url":"https://api.github.com/repos/lorawoodford/archivesspace/issues/events{/number}","events_url":"https://api.github.com/repos/lorawoodford/archivesspace/events","assignees_url":"https://api.github.com/repos/lorawoodford/archivesspace/assignees{/user}","branches_url":"https://api.github.com/repos/lorawoodford/archivesspace/branches{/branch}","tags_url":"https://api.github.com/repos/lorawoodford/archivesspace/tags","blobs_url":"https://api.github.com/repos/lorawoodford/archivesspace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorawoodford/archivesspace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorawoodford/archivesspace/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorawoodford/archivesspace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorawoodford/archivesspace/statuses/{sha}","languages_url":"https://api.github.com/repos/lorawoodford/archivesspace/languages","stargazers_url":"https://api.github.com/repos/lorawoodford/archivesspace/stargazers","contributors_url":"https://api.github.com/repos/lorawoodford/archivesspace/contributors","subscribers_url":"https://api.github.com/repos/lorawoodford/archivesspace/subscribers","subscription_url":"https://api.github.com/repos/lorawoodford/archivesspace/subscription","commits_url":"https://api.github.com/repos/lorawoodford/archivesspace/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorawoodford/archivesspace/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorawoodford/archivesspace/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorawoodford/archivesspace/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorawoodford/archivesspace/contents/{+path}","compare_url":"https://api.github.com/repos/lorawoodford/archivesspace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorawoodford/archivesspace/merges","archive_url":"https://api.github.com/repos/lorawoodford/archivesspace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorawoodford/archivesspace/downloads","issues_url":"https://api.github.com/repos/lorawoodford/archivesspace/issues{/number}","pulls_url":"https://api.github.com/repos/lorawoodford/archivesspace/pulls{/number}","milestones_url":"https://api.github.com/repos/lorawoodford/archivesspace/milestones{/number}","notifications_url":"https://api.github.com/repos/lorawoodford/archivesspace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorawoodford/archivesspace/labels{/name}","releases_url":"https://api.github.com/repos/lorawoodford/archivesspace/releases{/id}","deployments_url":"https://api.github.com/repos/lorawoodford/archivesspace/deployments","created_at":"2017-10-20T14:46:39Z","updated_at":"2018-11-12T18:00:29Z","pushed_at":"2018-11-12T18:21:19Z","git_url":"git://github.com/lorawoodford/archivesspace.git","ssh_url":"git@github.com:lorawoodford/archivesspace.git","clone_url":"https://github.com/lorawoodford/archivesspace.git","svn_url":"https://github.com/lorawoodford/archivesspace","homepage":"http://archivesspace.org/","size":102006,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"archivesspace:master","ref":"master","sha":"35b599693482e293ed28e49f2dcdca47853dafc9","user":{"login":"archivesspace","id":1311559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE1NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1311559?v=4","gravatar_id":"","url":"https://api.github.com/users/archivesspace","html_url":"https://github.com/archivesspace","followers_url":"https://api.github.com/users/archivesspace/followers","following_url":"https://api.github.com/users/archivesspace/following{/other_user}","gists_url":"https://api.github.com/users/archivesspace/gists{/gist_id}","starred_url":"https://api.github.com/users/archivesspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archivesspace/subscriptions","organizations_url":"https://api.github.com/users/archivesspace/orgs","repos_url":"https://api.github.com/users/archivesspace/repos","events_url":"https://api.github.com/users/archivesspace/events{/privacy}","received_events_url":"https://api.github.com/users/archivesspace/received_events","type":"Organization","site_admin":false},"repo":{"id":4989765,"node_id":"MDEwOlJlcG9zaXRvcnk0OTg5NzY1","name":"archivesspace","full_name":"archivesspace/archivesspace","private":false,"owner":{"login":"archivesspace","id":1311559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE1NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1311559?v=4","gravatar_id":"","url":"https://api.github.com/users/archivesspace","html_url":"https://github.com/archivesspace","followers_url":"https://api.github.com/users/archivesspace/followers","following_url":"https://api.github.com/users/archivesspace/following{/other_user}","gists_url":"https://api.github.com/users/archivesspace/gists{/gist_id}","starred_url":"https://api.github.com/users/archivesspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archivesspace/subscriptions","organizations_url":"https://api.github.com/users/archivesspace/orgs","repos_url":"https://api.github.com/users/archivesspace/repos","events_url":"https://api.github.com/users/archivesspace/events{/privacy}","received_events_url":"https://api.github.com/users/archivesspace/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/archivesspace/archivesspace","description":"The ArchivesSpace archives management tool","fork":false,"url":"https://api.github.com/repos/archivesspace/archivesspace","forks_url":"https://api.github.com/repos/archivesspace/archivesspace/forks","keys_url":"https://api.github.com/repos/archivesspace/archivesspace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/archivesspace/archivesspace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/archivesspace/archivesspace/teams","hooks_url":"https://api.github.com/repos/archivesspace/archivesspace/hooks","issue_events_url":"https://api.github.com/repos/archivesspace/archivesspace/issues/events{/number}","events_url":"https://api.github.com/repos/archivesspace/archivesspace/events","assignees_url":"https://api.github.com/repos/archivesspace/archivesspace/assignees{/user}","branches_url":"https://api.github.com/repos/archivesspace/archivesspace/branches{/branch}","tags_url":"https://api.github.com/repos/archivesspace/archivesspace/tags","blobs_url":"https://api.github.com/repos/archivesspace/archivesspace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/archivesspace/archivesspace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/archivesspace/archivesspace/git/refs{/sha}","trees_url":"https://api.github.com/repos/archivesspace/archivesspace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/archivesspace/archivesspace/statuses/{sha}","languages_url":"https://api.github.com/repos/archivesspace/archivesspace/languages","stargazers_url":"https://api.github.com/repos/archivesspace/archivesspace/stargazers","contributors_url":"https://api.github.com/repos/archivesspace/archivesspace/contributors","subscribers_url":"https://api.github.com/repos/archivesspace/archivesspace/subscribers","subscription_url":"https://api.github.com/repos/archivesspace/archivesspace/subscription","commits_url":"https://api.github.com/repos/archivesspace/archivesspace/commits{/sha}","git_commits_url":"https://api.github.com/repos/archivesspace/archivesspace/git/commits{/sha}","comments_url":"https://api.github.com/repos/archivesspace/archivesspace/comments{/number}","issue_comment_url":"https://api.github.com/repos/archivesspace/archivesspace/issues/comments{/number}","contents_url":"https://api.github.com/repos/archivesspace/archivesspace/contents/{+path}","compare_url":"https://api.github.com/repos/archivesspace/archivesspace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/archivesspace/archivesspace/merges","archive_url":"https://api.github.com/repos/archivesspace/archivesspace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/archivesspace/archivesspace/downloads","issues_url":"https://api.github.com/repos/archivesspace/archivesspace/issues{/number}","pulls_url":"https://api.github.com/repos/archivesspace/archivesspace/pulls{/number}","milestones_url":"https://api.github.com/repos/archivesspace/archivesspace/milestones{/number}","notifications_url":"https://api.github.com/repos/archivesspace/archivesspace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/archivesspace/archivesspace/labels{/name}","releases_url":"https://api.github.com/repos/archivesspace/archivesspace/releases{/id}","deployments_url":"https://api.github.com/repos/archivesspace/archivesspace/deployments","created_at":"2012-07-11T14:00:20Z","updated_at":"2018-11-08T23:14:31Z","pushed_at":"2018-11-10T00:07:04Z","git_url":"git://github.com/archivesspace/archivesspace.git","ssh_url":"git@github.com:archivesspace/archivesspace.git","clone_url":"https://github.com/archivesspace/archivesspace.git","svn_url":"https://github.com/archivesspace/archivesspace","homepage":"http://archivesspace.org/","size":102151,"stargazers_count":172,"watchers_count":172,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":135,"open_issues":39,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/archivesspace/archivesspace/pulls/1402"},"html":{"href":"https://github.com/archivesspace/archivesspace/pull/1402"},"issue":{"href":"https://api.github.com/repos/archivesspace/archivesspace/issues/1402"},"comments":{"href":"https://api.github.com/repos/archivesspace/archivesspace/issues/1402/comments"},"review_comments":{"href":"https://api.github.com/repos/archivesspace/archivesspace/pulls/1402/comments"},"review_comment":{"href":"https://api.github.com/repos/archivesspace/archivesspace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/archivesspace/archivesspace/pulls/1402/commits"},"statuses":{"href":"https://api.github.com/repos/archivesspace/archivesspace/statuses/7956df016e704d98e10f36804ed4f8673c0bf786"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":113,"deletions":82,"changed_files":47}}
{"actor":{"display_login":"lorawoodford"}}