{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/299","repository_url":"https://api.github.com/repos/Microsoft/oxa-tools","labels_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/299/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/299/comments","events_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/299/events","html_url":"https://github.com/Microsoft/oxa-tools/pull/299","id":301621708,"number":299,"title":"Provide various DDoS mitigations","user":{"login":"btelnes","id":21182799,"avatar_url":"https://avatars3.githubusercontent.com/u/21182799?v=4","gravatar_id":"","url":"https://api.github.com/users/btelnes","html_url":"https://github.com/btelnes","followers_url":"https://api.github.com/users/btelnes/followers","following_url":"https://api.github.com/users/btelnes/following{/other_user}","gists_url":"https://api.github.com/users/btelnes/gists{/gist_id}","starred_url":"https://api.github.com/users/btelnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btelnes/subscriptions","organizations_url":"https://api.github.com/users/btelnes/orgs","repos_url":"https://api.github.com/users/btelnes/repos","events_url":"https://api.github.com/users/btelnes/events{/privacy}","received_events_url":"https://api.github.com/users/btelnes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-02T01:30:47Z","updated_at":"2018-03-07T00:38:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/299","html_url":"https://github.com/Microsoft/oxa-tools/pull/299","diff_url":"https://github.com/Microsoft/oxa-tools/pull/299.diff","patch_url":"https://github.com/Microsoft/oxa-tools/pull/299.patch"},"body":"#### What does this PR do? Please provide some context\r\n\r\nProvides various DDoS mitigations.\r\n\r\n#### Where should the reviewer start?\r\n\r\nYou can start with any of the files.\r\n\r\n#### How can this be manually tested? (brief repro steps and corpnet-URL with change)\r\n\r\nDeploy STAMP then attempt to:\r\n\r\n- From a single IP address, attempt to create more than the number connections of connections specified by EDXAPP_CONNECTIONS_PER_ADDRESS_LIMIT\r\n- From a single IP address, attempt to flood the site with more requests than specified by EDXAPP_SITE_REQUEST_RATE\r\n- From a single IP address, attempt to flood the login endpoint with more requests than specified by EDXAPP_LOGIN_REQUEST_RATE\r\n- From a single IP address, attempt to keep connections open longer than specified by EDXAPP_CLIENT_BODY_TIMEOUT and EDXAPP_CLIENT_HEADER_TIMEOUT \r\n\r\n#### What are the relevant TFS items? (list id numbers)\r\n\r\nTask 109524\r\n\r\n#### Definition of done:\r\n- [ ] Title of the pull request is clear and informative\r\n- [ ] Add pull request hyperlink to relevant TFS items\r\n- [ ] For large or complex change: schedule an in-person review session\r\n- [ ] This change has appropriate test coverage\r\n- [ ] Get at least two approvals\r\n\r\n#### Reminders DURING merge\r\n1. If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then \"Squash and merge\" to keep our history clean.\r\n1. If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then \"Create merge commit\" to preserve individual commits.\r\n\r\n[//]: # ( fyi: This content was heavily inspired by )\r\n[//]: # ( 1 Our team's policies and processes )\r\n[//]: # ( 2 https://github.com/sprintly/sprint.ly-culture/blob/master/pr-template.md )\r\n[//]: # ( 3 The book \"The Checklist Manifesto: How to Get Things Right\" by Atul Gawande )\r\n[//]: # ( 4 https://github.com/Azure/azure-event-hubs/blob/master/.github/PULL_REQUEST_TEMPLATE.md )\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/comments/370980604","html_url":"https://github.com/Microsoft/oxa-tools/pull/299#issuecomment-370980604","issue_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/299","id":370980604,"user":{"login":"sdolenc","id":21182133,"avatar_url":"https://avatars2.githubusercontent.com/u/21182133?v=4","gravatar_id":"","url":"https://api.github.com/users/sdolenc","html_url":"https://github.com/sdolenc","followers_url":"https://api.github.com/users/sdolenc/followers","following_url":"https://api.github.com/users/sdolenc/following{/other_user}","gists_url":"https://api.github.com/users/sdolenc/gists{/gist_id}","starred_url":"https://api.github.com/users/sdolenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdolenc/subscriptions","organizations_url":"https://api.github.com/users/sdolenc/orgs","repos_url":"https://api.github.com/users/sdolenc/repos","events_url":"https://api.github.com/users/sdolenc/events{/privacy}","received_events_url":"https://api.github.com/users/sdolenc/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T00:38:17Z","updated_at":"2018-03-07T00:38:17Z","author_association":"MEMBER","body":"Disregard my previous comment. You should still resolve the merge conflict, but I don't believe tests will run on this PR (for now). The fundamental problem with how circle ci handles branch filtering still exists. Therefore,\r\n- I've shared a small repro with circleCi's support team https://github.com/sdolenc/circle_ci_experiments/pull/4 and\r\n- I'm almost finished building a workaround that we can use"}}
{"actor":{"display_login":"sdolenc"}}