{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/175426476","pull_request_review_id":104950994,"id":175426476,"diff_hunk":"@@ -422,6 +422,15 @@ Linear, kernelized and related models\n   better for unscaled features. :issue:`8361` by :user:`Gaurav Dhingra <gxyd>`\n   and :user:`Ting Neo <neokt>`.\n \n+Feature Extraction\n+\n+- Deprecate ``stop_words='english'`` parameter in \n+  :class:`feature_extraction.text.CountVectorizer`, \n+  :class:`feature_extraction.text.TfidfVectorizer`, \n+  :class:`feature_extraction.text.HashingVectorizer` as the current list is \n+  broken, leading to unexpected results. :issue:`10735` ","path":"doc/whats_new/v0.20.rst","position":10,"original_position":10,"commit_id":"6236e983e2c760e2a1a8ad32178948bdf2061e7f","original_commit_id":"56afa88044e5fd1c0d480eaa969de44ee05d9bc5","user":{"login":"rth","id":630936,"avatar_url":"https://avatars0.githubusercontent.com/u/630936?v=4","gravatar_id":"","url":"https://api.github.com/users/rth","html_url":"https://github.com/rth","followers_url":"https://api.github.com/users/rth/followers","following_url":"https://api.github.com/users/rth/following{/other_user}","gists_url":"https://api.github.com/users/rth/gists{/gist_id}","starred_url":"https://api.github.com/users/rth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rth/subscriptions","organizations_url":"https://api.github.com/users/rth/orgs","repos_url":"https://api.github.com/users/rth/repos","events_url":"https://api.github.com/users/rth/events{/privacy}","received_events_url":"https://api.github.com/users/rth/received_events","type":"User","site_admin":false},"body":"@shaz13 The CountVectorizer / HashingVectorizer docs are generated from from the corresponding docstrings. \r\nThe TFIDF documentation can be modifed in https://github.com/scikit-learn/scikit-learn/blob/master/doc/modules/feature_extraction.rst","created_at":"2018-03-19T13:06:34Z","updated_at":"2018-03-19T13:17:09Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10818#discussion_r175426476","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10818","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/175426476"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10818#discussion_r175426476"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10818"}},"in_reply_to_id":175252174},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10818","id":175474842,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/10818","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/10818.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/10818.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10818","number":10818,"state":"open","locked":false,"title":"[MRG+1] Deprecate stop_words='english'","user":{"login":"shaz13","id":24438869,"avatar_url":"https://avatars0.githubusercontent.com/u/24438869?v=4","gravatar_id":"","url":"https://api.github.com/users/shaz13","html_url":"https://github.com/shaz13","followers_url":"https://api.github.com/users/shaz13/followers","following_url":"https://api.github.com/users/shaz13/following{/other_user}","gists_url":"https://api.github.com/users/shaz13/gists{/gist_id}","starred_url":"https://api.github.com/users/shaz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaz13/subscriptions","organizations_url":"https://api.github.com/users/shaz13/orgs","repos_url":"https://api.github.com/users/shaz13/repos","events_url":"https://api.github.com/users/shaz13/events{/privacy}","received_events_url":"https://api.github.com/users/shaz13/received_events","type":"User","site_admin":false},"body":"Fixes  #10735 \r\n\r\n- Added deprecation warnings\r\n- Implemented the same in docstrings","created_at":"2018-03-16T09:07:22Z","updated_at":"2018-03-19T13:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"330beb9e366823bd6ed7366ec09b72b7ad7d9c40","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10818/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10818/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10818/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/6236e983e2c760e2a1a8ad32178948bdf2061e7f","head":{"label":"shaz13:deprecate-stop-words","ref":"deprecate-stop-words","sha":"6236e983e2c760e2a1a8ad32178948bdf2061e7f","user":{"login":"shaz13","id":24438869,"avatar_url":"https://avatars0.githubusercontent.com/u/24438869?v=4","gravatar_id":"","url":"https://api.github.com/users/shaz13","html_url":"https://github.com/shaz13","followers_url":"https://api.github.com/users/shaz13/followers","following_url":"https://api.github.com/users/shaz13/following{/other_user}","gists_url":"https://api.github.com/users/shaz13/gists{/gist_id}","starred_url":"https://api.github.com/users/shaz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaz13/subscriptions","organizations_url":"https://api.github.com/users/shaz13/orgs","repos_url":"https://api.github.com/users/shaz13/repos","events_url":"https://api.github.com/users/shaz13/events{/privacy}","received_events_url":"https://api.github.com/users/shaz13/received_events","type":"User","site_admin":false},"repo":{"id":102265347,"name":"scikit-learn","full_name":"shaz13/scikit-learn","owner":{"login":"shaz13","id":24438869,"avatar_url":"https://avatars0.githubusercontent.com/u/24438869?v=4","gravatar_id":"","url":"https://api.github.com/users/shaz13","html_url":"https://github.com/shaz13","followers_url":"https://api.github.com/users/shaz13/followers","following_url":"https://api.github.com/users/shaz13/following{/other_user}","gists_url":"https://api.github.com/users/shaz13/gists{/gist_id}","starred_url":"https://api.github.com/users/shaz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaz13/subscriptions","organizations_url":"https://api.github.com/users/shaz13/orgs","repos_url":"https://api.github.com/users/shaz13/repos","events_url":"https://api.github.com/users/shaz13/events{/privacy}","received_events_url":"https://api.github.com/users/shaz13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shaz13/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/shaz13/scikit-learn","forks_url":"https://api.github.com/repos/shaz13/scikit-learn/forks","keys_url":"https://api.github.com/repos/shaz13/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaz13/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaz13/scikit-learn/teams","hooks_url":"https://api.github.com/repos/shaz13/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/shaz13/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/shaz13/scikit-learn/events","assignees_url":"https://api.github.com/repos/shaz13/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/shaz13/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/shaz13/scikit-learn/tags","blobs_url":"https://api.github.com/repos/shaz13/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaz13/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaz13/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaz13/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaz13/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/shaz13/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/shaz13/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/shaz13/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/shaz13/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/shaz13/scikit-learn/subscription","commits_url":"https://api.github.com/repos/shaz13/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaz13/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaz13/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaz13/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaz13/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/shaz13/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaz13/scikit-learn/merges","archive_url":"https://api.github.com/repos/shaz13/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaz13/scikit-learn/downloads","issues_url":"https://api.github.com/repos/shaz13/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/shaz13/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/shaz13/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/shaz13/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaz13/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/shaz13/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/shaz13/scikit-learn/deployments","created_at":"2017-09-03T13:08:07Z","updated_at":"2018-03-16T08:52:27Z","pushed_at":"2018-03-17T10:21:04Z","git_url":"git://github.com/shaz13/scikit-learn.git","ssh_url":"git@github.com:shaz13/scikit-learn.git","clone_url":"https://github.com/shaz13/scikit-learn.git","svn_url":"https://github.com/shaz13/scikit-learn","homepage":"http://scikit-learn.org","size":88873,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"4900e5c46f51a674f53624869a898948f1d14152","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-03-19T12:59:54Z","pushed_at":"2018-03-19T13:01:37Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":89604,"stargazers_count":26662,"watchers_count":26662,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13433,"mirror_url":null,"archived":false,"open_issues_count":1586,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13433,"open_issues":1586,"watchers":26662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10818"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10818"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10818"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10818/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10818/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10818/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/6236e983e2c760e2a1a8ad32178948bdf2061e7f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rth"}}