{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls/26","id":169432381,"html_url":"https://github.com/Dan2552/SublimeTextSwiftAutocomplete/pull/26","diff_url":"https://github.com/Dan2552/SublimeTextSwiftAutocomplete/pull/26.diff","patch_url":"https://github.com/Dan2552/SublimeTextSwiftAutocomplete/pull/26.patch","issue_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/issues/26","number":26,"state":"open","locked":false,"title":"A few updates and improvements","user":{"login":"nettlep","id":7917889,"avatar_url":"https://avatars3.githubusercontent.com/u/7917889?v=4","gravatar_id":"","url":"https://api.github.com/users/nettlep","html_url":"https://github.com/nettlep","followers_url":"https://api.github.com/users/nettlep/followers","following_url":"https://api.github.com/users/nettlep/following{/other_user}","gists_url":"https://api.github.com/users/nettlep/gists{/gist_id}","starred_url":"https://api.github.com/users/nettlep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nettlep/subscriptions","organizations_url":"https://api.github.com/users/nettlep/orgs","repos_url":"https://api.github.com/users/nettlep/repos","events_url":"https://api.github.com/users/nettlep/events{/privacy}","received_events_url":"https://api.github.com/users/nettlep/received_events","type":"User","site_admin":false},"body":"First, great job on this!\r\n\r\nWhen I loaded it up, the first thing it did was to throw an exception complaining about an ASCII code. It turns out there was a copyright symbol in one of the source files that was tripping it up when trying to convert to raw ASCII for writing to a text file. So 08d213e converts it to utf-8 and writes that stream to a binary file. With that out of the way, I was able to see the awesomeness that is SubllimeTextSwiftAutocomplete.\r\n\r\nThe next issue I ran into came when hovering over `MemoryLayout<SomeClass>.size`. This one, too, caused an exception. It turns out that the tag parsing wasn't taking into account that CDATA blocks can have tags in them without escaping the leading`<`. So d392249 was created to locate CDATA blocks, escape the tags with `<` and then rip out the CDATA head/tail.\r\n\r\nNext was the root directory. I have a rather extensive directory tree for my project (with documents, large PSDs, a good number of video files, etc.) and the Swift code is in one subdirectory. So in 5639bc9, I added the ability to create a setting called `stsa.project_root` to specify the root. I put mine in my project settings. If that setting is not present, it will revert to the original behavior.\r\n\r\nAnd finally, no documentation showed up for me. After some investigation, it looked like it might work in some cases, but not in my case (not really sure why - maybe a tools version issue?) So I did some work to parse out the Abstract and Discussion bits separately in order to display them as first-class citizens in the popup and e0e0e31 was born. To accomplish this, I had to add filter regex patterns to `_popup_section_from_dict` so that it could generate sections for specific subsets of the input XML. This also includes some cleanup work to `<CodeListing>` sections, which included simulating pre-formatted text blocks (ST3 doesn't support this natively) by setting a monospace font and swapping tabs/spaces with Unicode `NO-BREAK SPACE` characters that aren't filtered out by the HTML renderer. That last bit feels a bit hacky to me, but it was the only thing that produced correct results.\r\n\r\nThe end result looks a like this:\r\n\r\n<img width=\"588\" alt=\"screen shot 2018-02-15 at 10 42 53 am\" src=\"https://user-images.githubusercontent.com/7917889/36269653-47ebd5c0-123f-11e8-9eb5-3cd6403fda32.png\">\r\n","created_at":"2018-02-15T17:14:28Z","updated_at":"2018-02-15T17:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/issues/26/comments","statuses_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/statuses/e0e0e311a66642262246370e245c9836f941af13","head":{"label":"nettlep:master","ref":"master","sha":"e0e0e311a66642262246370e245c9836f941af13","user":{"login":"nettlep","id":7917889,"avatar_url":"https://avatars3.githubusercontent.com/u/7917889?v=4","gravatar_id":"","url":"https://api.github.com/users/nettlep","html_url":"https://github.com/nettlep","followers_url":"https://api.github.com/users/nettlep/followers","following_url":"https://api.github.com/users/nettlep/following{/other_user}","gists_url":"https://api.github.com/users/nettlep/gists{/gist_id}","starred_url":"https://api.github.com/users/nettlep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nettlep/subscriptions","organizations_url":"https://api.github.com/users/nettlep/orgs","repos_url":"https://api.github.com/users/nettlep/repos","events_url":"https://api.github.com/users/nettlep/events{/privacy}","received_events_url":"https://api.github.com/users/nettlep/received_events","type":"User","site_admin":false},"repo":{"id":121552330,"name":"SublimeTextSwiftAutocomplete","full_name":"nettlep/SublimeTextSwiftAutocomplete","owner":{"login":"nettlep","id":7917889,"avatar_url":"https://avatars3.githubusercontent.com/u/7917889?v=4","gravatar_id":"","url":"https://api.github.com/users/nettlep","html_url":"https://github.com/nettlep","followers_url":"https://api.github.com/users/nettlep/followers","following_url":"https://api.github.com/users/nettlep/following{/other_user}","gists_url":"https://api.github.com/users/nettlep/gists{/gist_id}","starred_url":"https://api.github.com/users/nettlep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nettlep/subscriptions","organizations_url":"https://api.github.com/users/nettlep/orgs","repos_url":"https://api.github.com/users/nettlep/repos","events_url":"https://api.github.com/users/nettlep/events{/privacy}","received_events_url":"https://api.github.com/users/nettlep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nettlep/SublimeTextSwiftAutocomplete","description":"Swift autocompletion in Sublime Text using SourceKitten","fork":true,"url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete","forks_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/forks","keys_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/teams","hooks_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/hooks","issue_events_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/issues/events{/number}","events_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/events","assignees_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/assignees{/user}","branches_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/branches{/branch}","tags_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/tags","blobs_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/git/refs{/sha}","trees_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/statuses/{sha}","languages_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/languages","stargazers_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/stargazers","contributors_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/contributors","subscribers_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/subscribers","subscription_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/subscription","commits_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/commits{/sha}","git_commits_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/git/commits{/sha}","comments_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/comments{/number}","issue_comment_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/issues/comments{/number}","contents_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/contents/{+path}","compare_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/merges","archive_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/downloads","issues_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/issues{/number}","pulls_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/pulls{/number}","milestones_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/milestones{/number}","notifications_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/labels{/name}","releases_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/releases{/id}","deployments_url":"https://api.github.com/repos/nettlep/SublimeTextSwiftAutocomplete/deployments","created_at":"2018-02-14T19:31:09Z","updated_at":"2018-02-14T19:31:10Z","pushed_at":"2018-02-15T16:56:46Z","git_url":"git://github.com/nettlep/SublimeTextSwiftAutocomplete.git","ssh_url":"git@github.com:nettlep/SublimeTextSwiftAutocomplete.git","clone_url":"https://github.com/nettlep/SublimeTextSwiftAutocomplete.git","svn_url":"https://github.com/nettlep/SublimeTextSwiftAutocomplete","homepage":"","size":912,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Dan2552:master","ref":"master","sha":"9a9cdf9f2752e002588b76091da96484213a3cf7","user":{"login":"Dan2552","id":1478221,"avatar_url":"https://avatars3.githubusercontent.com/u/1478221?v=4","gravatar_id":"","url":"https://api.github.com/users/Dan2552","html_url":"https://github.com/Dan2552","followers_url":"https://api.github.com/users/Dan2552/followers","following_url":"https://api.github.com/users/Dan2552/following{/other_user}","gists_url":"https://api.github.com/users/Dan2552/gists{/gist_id}","starred_url":"https://api.github.com/users/Dan2552/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dan2552/subscriptions","organizations_url":"https://api.github.com/users/Dan2552/orgs","repos_url":"https://api.github.com/users/Dan2552/repos","events_url":"https://api.github.com/users/Dan2552/events{/privacy}","received_events_url":"https://api.github.com/users/Dan2552/received_events","type":"User","site_admin":false},"repo":{"id":76993446,"name":"SublimeTextSwiftAutocomplete","full_name":"Dan2552/SublimeTextSwiftAutocomplete","owner":{"login":"Dan2552","id":1478221,"avatar_url":"https://avatars3.githubusercontent.com/u/1478221?v=4","gravatar_id":"","url":"https://api.github.com/users/Dan2552","html_url":"https://github.com/Dan2552","followers_url":"https://api.github.com/users/Dan2552/followers","following_url":"https://api.github.com/users/Dan2552/following{/other_user}","gists_url":"https://api.github.com/users/Dan2552/gists{/gist_id}","starred_url":"https://api.github.com/users/Dan2552/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dan2552/subscriptions","organizations_url":"https://api.github.com/users/Dan2552/orgs","repos_url":"https://api.github.com/users/Dan2552/repos","events_url":"https://api.github.com/users/Dan2552/events{/privacy}","received_events_url":"https://api.github.com/users/Dan2552/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dan2552/SublimeTextSwiftAutocomplete","description":"Swift autocompletion in Sublime Text using SourceKitten","fork":false,"url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete","forks_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/forks","keys_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/teams","hooks_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/hooks","issue_events_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/issues/events{/number}","events_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/events","assignees_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/assignees{/user}","branches_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/branches{/branch}","tags_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/tags","blobs_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/statuses/{sha}","languages_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/languages","stargazers_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/stargazers","contributors_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/contributors","subscribers_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/subscribers","subscription_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/subscription","commits_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/contents/{+path}","compare_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/merges","archive_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/downloads","issues_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/issues{/number}","pulls_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls{/number}","milestones_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/milestones{/number}","notifications_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/labels{/name}","releases_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/releases{/id}","deployments_url":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/deployments","created_at":"2016-12-20T21:37:08Z","updated_at":"2018-02-01T09:42:43Z","pushed_at":"2018-02-15T15:54:11Z","git_url":"git://github.com/Dan2552/SublimeTextSwiftAutocomplete.git","ssh_url":"git@github.com:Dan2552/SublimeTextSwiftAutocomplete.git","clone_url":"https://github.com/Dan2552/SublimeTextSwiftAutocomplete.git","svn_url":"https://github.com/Dan2552/SublimeTextSwiftAutocomplete","homepage":"","size":904,"stargazers_count":161,"watchers_count":161,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":11,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls/26"},"html":{"href":"https://github.com/Dan2552/SublimeTextSwiftAutocomplete/pull/26"},"issue":{"href":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/issues/26"},"comments":{"href":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Dan2552/SublimeTextSwiftAutocomplete/statuses/e0e0e311a66642262246370e245c9836f941af13"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":112,"deletions":15,"changed_files":4}}
{"actor":{"display_login":"nettlep"}}