{"action":"created","comment":{"url":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/comments/234402234","pull_request_review_id":176047276,"id":234402234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQwMjIzNA==","diff_hunk":"@@ -24,7 +24,7 @@\n \n <!-- author & description & keywords  -->\n {{- if or .Params.author .Site.Author.name -}}\n-<meta name=\"author\" content=\"{{ if .Params.author }}{{ .Params.author | safeHTML }}{{ else }}{{ .Site.Author.name | safeHTML }}{{ end }}\" />\n+<meta name=\"author\" content=\"{{ (index .Site.Data.authors (.Params.author | default .Site.Author.name)).name.display | default .Params.author | default .Site.Author.name | safeHTML }}\" />","path":"layouts/partials/head.html","position":5,"original_position":5,"commit_id":"37f5418768e955444e729808949ed2c49e8b0172","original_commit_id":"37f5418768e955444e729808949ed2c49e8b0172","user":{"login":"xianmin","id":2177570,"node_id":"MDQ6VXNlcjIxNzc1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2177570?v=4","gravatar_id":"","url":"https://api.github.com/users/xianmin","html_url":"https://github.com/xianmin","followers_url":"https://api.github.com/users/xianmin/followers","following_url":"https://api.github.com/users/xianmin/following{/other_user}","gists_url":"https://api.github.com/users/xianmin/gists{/gist_id}","starred_url":"https://api.github.com/users/xianmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xianmin/subscriptions","organizations_url":"https://api.github.com/users/xianmin/orgs","repos_url":"https://api.github.com/users/xianmin/repos","events_url":"https://api.github.com/users/xianmin/events{/privacy}","received_events_url":"https://api.github.com/users/xianmin/received_events","type":"User","site_admin":false},"body":"There is a problem here:\r\n\r\n```\r\n(index .Site.Data.authors (.Params.author | default .Site.Author.name)).name.display\r\n```\r\n\r\nIf I don't have an **\"author data file\"** in the **Site root** , example **/data/authors/example_author.toml** . Then, Hugo will output **ERROR: error calling index: index of untyped nil**.\r\n\r\nIs there a better function to avoid this problem?","created_at":"2018-11-17T09:15:35Z","updated_at":"2018-11-17T09:15:35Z","html_url":"https://github.com/xianmin/hugo-theme-jane/pull/147#discussion_r234402234","pull_request_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/147","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/comments/234402234"},"html":{"href":"https://github.com/xianmin/hugo-theme-jane/pull/147#discussion_r234402234"},"pull_request":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/147","id":231690655,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjkwNjU1","html_url":"https://github.com/xianmin/hugo-theme-jane/pull/147","diff_url":"https://github.com/xianmin/hugo-theme-jane/pull/147.diff","patch_url":"https://github.com/xianmin/hugo-theme-jane/pull/147.patch","issue_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/issues/147","number":147,"state":"open","locked":false,"title":"add authors page","user":{"login":"shaform","id":367172,"node_id":"MDQ6VXNlcjM2NzE3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/367172?v=4","gravatar_id":"","url":"https://api.github.com/users/shaform","html_url":"https://github.com/shaform","followers_url":"https://api.github.com/users/shaform/followers","following_url":"https://api.github.com/users/shaform/following{/other_user}","gists_url":"https://api.github.com/users/shaform/gists{/gist_id}","starred_url":"https://api.github.com/users/shaform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaform/subscriptions","organizations_url":"https://api.github.com/users/shaform/orgs","repos_url":"https://api.github.com/users/shaform/repos","events_url":"https://api.github.com/users/shaform/events{/privacy}","received_events_url":"https://api.github.com/users/shaform/received_events","type":"User","site_admin":false},"body":"So I am trying to add a more prominent author information section into the post page. But I guess it's useful to implement #114 as a first step. Currently, `data/authors` only has a display name field, but I am planning to add more things to it in the future.\r\n\r\nHowever, there is something to discuss:\r\n\r\nI personally feel that rather than keeping using the `author` field, it would be best to use an `authors` field, which takes a list of authors as its value. Because this would match the convention of `tags` and `categories`, and it's also potentially possible that an article might have multiple authors. However, there is already a singular `author` field in the past. So simply removing it might cause some compatibility issues. On the other hand, if we support both fields, it would be a little bit cumbersome. Not sure what is the best strategy here.","created_at":"2018-11-17T00:24:16Z","updated_at":"2018-11-17T09:15:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4514e7d79de5d90ab6adb78b94426992b7e41ec9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/147/commits","review_comments_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/147/comments","review_comment_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/issues/147/comments","statuses_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/statuses/37f5418768e955444e729808949ed2c49e8b0172","head":{"label":"shaform:authors","ref":"authors","sha":"37f5418768e955444e729808949ed2c49e8b0172","user":{"login":"shaform","id":367172,"node_id":"MDQ6VXNlcjM2NzE3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/367172?v=4","gravatar_id":"","url":"https://api.github.com/users/shaform","html_url":"https://github.com/shaform","followers_url":"https://api.github.com/users/shaform/followers","following_url":"https://api.github.com/users/shaform/following{/other_user}","gists_url":"https://api.github.com/users/shaform/gists{/gist_id}","starred_url":"https://api.github.com/users/shaform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaform/subscriptions","organizations_url":"https://api.github.com/users/shaform/orgs","repos_url":"https://api.github.com/users/shaform/repos","events_url":"https://api.github.com/users/shaform/events{/privacy}","received_events_url":"https://api.github.com/users/shaform/received_events","type":"User","site_admin":false},"repo":{"id":140421628,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MjE2Mjg=","name":"hugo-theme-jane","full_name":"shaform/hugo-theme-jane","private":false,"owner":{"login":"shaform","id":367172,"node_id":"MDQ6VXNlcjM2NzE3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/367172?v=4","gravatar_id":"","url":"https://api.github.com/users/shaform","html_url":"https://github.com/shaform","followers_url":"https://api.github.com/users/shaform/followers","following_url":"https://api.github.com/users/shaform/following{/other_user}","gists_url":"https://api.github.com/users/shaform/gists{/gist_id}","starred_url":"https://api.github.com/users/shaform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaform/subscriptions","organizations_url":"https://api.github.com/users/shaform/orgs","repos_url":"https://api.github.com/users/shaform/repos","events_url":"https://api.github.com/users/shaform/events{/privacy}","received_events_url":"https://api.github.com/users/shaform/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shaform/hugo-theme-jane","description":"A readable & concise theme for Hugo","fork":true,"url":"https://api.github.com/repos/shaform/hugo-theme-jane","forks_url":"https://api.github.com/repos/shaform/hugo-theme-jane/forks","keys_url":"https://api.github.com/repos/shaform/hugo-theme-jane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaform/hugo-theme-jane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaform/hugo-theme-jane/teams","hooks_url":"https://api.github.com/repos/shaform/hugo-theme-jane/hooks","issue_events_url":"https://api.github.com/repos/shaform/hugo-theme-jane/issues/events{/number}","events_url":"https://api.github.com/repos/shaform/hugo-theme-jane/events","assignees_url":"https://api.github.com/repos/shaform/hugo-theme-jane/assignees{/user}","branches_url":"https://api.github.com/repos/shaform/hugo-theme-jane/branches{/branch}","tags_url":"https://api.github.com/repos/shaform/hugo-theme-jane/tags","blobs_url":"https://api.github.com/repos/shaform/hugo-theme-jane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaform/hugo-theme-jane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaform/hugo-theme-jane/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaform/hugo-theme-jane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaform/hugo-theme-jane/statuses/{sha}","languages_url":"https://api.github.com/repos/shaform/hugo-theme-jane/languages","stargazers_url":"https://api.github.com/repos/shaform/hugo-theme-jane/stargazers","contributors_url":"https://api.github.com/repos/shaform/hugo-theme-jane/contributors","subscribers_url":"https://api.github.com/repos/shaform/hugo-theme-jane/subscribers","subscription_url":"https://api.github.com/repos/shaform/hugo-theme-jane/subscription","commits_url":"https://api.github.com/repos/shaform/hugo-theme-jane/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaform/hugo-theme-jane/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaform/hugo-theme-jane/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaform/hugo-theme-jane/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaform/hugo-theme-jane/contents/{+path}","compare_url":"https://api.github.com/repos/shaform/hugo-theme-jane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaform/hugo-theme-jane/merges","archive_url":"https://api.github.com/repos/shaform/hugo-theme-jane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaform/hugo-theme-jane/downloads","issues_url":"https://api.github.com/repos/shaform/hugo-theme-jane/issues{/number}","pulls_url":"https://api.github.com/repos/shaform/hugo-theme-jane/pulls{/number}","milestones_url":"https://api.github.com/repos/shaform/hugo-theme-jane/milestones{/number}","notifications_url":"https://api.github.com/repos/shaform/hugo-theme-jane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaform/hugo-theme-jane/labels{/name}","releases_url":"https://api.github.com/repos/shaform/hugo-theme-jane/releases{/id}","deployments_url":"https://api.github.com/repos/shaform/hugo-theme-jane/deployments","created_at":"2018-07-10T11:24:53Z","updated_at":"2018-11-16T17:53:57Z","pushed_at":"2018-11-17T00:14:46Z","git_url":"git://github.com/shaform/hugo-theme-jane.git","ssh_url":"git@github.com:shaform/hugo-theme-jane.git","clone_url":"https://github.com/shaform/hugo-theme-jane.git","svn_url":"https://github.com/shaform/hugo-theme-jane","homepage":"http://en.xianmin.org/hugo-theme-jane/","size":2189,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xianmin:master","ref":"master","sha":"8c4c06baa0b0c4dc70a9e7bd3b3253650d10a7c5","user":{"login":"xianmin","id":2177570,"node_id":"MDQ6VXNlcjIxNzc1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2177570?v=4","gravatar_id":"","url":"https://api.github.com/users/xianmin","html_url":"https://github.com/xianmin","followers_url":"https://api.github.com/users/xianmin/followers","following_url":"https://api.github.com/users/xianmin/following{/other_user}","gists_url":"https://api.github.com/users/xianmin/gists{/gist_id}","starred_url":"https://api.github.com/users/xianmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xianmin/subscriptions","organizations_url":"https://api.github.com/users/xianmin/orgs","repos_url":"https://api.github.com/users/xianmin/repos","events_url":"https://api.github.com/users/xianmin/events{/privacy}","received_events_url":"https://api.github.com/users/xianmin/received_events","type":"User","site_admin":false},"repo":{"id":124070868,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwNzA4Njg=","name":"hugo-theme-jane","full_name":"xianmin/hugo-theme-jane","private":false,"owner":{"login":"xianmin","id":2177570,"node_id":"MDQ6VXNlcjIxNzc1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2177570?v=4","gravatar_id":"","url":"https://api.github.com/users/xianmin","html_url":"https://github.com/xianmin","followers_url":"https://api.github.com/users/xianmin/followers","following_url":"https://api.github.com/users/xianmin/following{/other_user}","gists_url":"https://api.github.com/users/xianmin/gists{/gist_id}","starred_url":"https://api.github.com/users/xianmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xianmin/subscriptions","organizations_url":"https://api.github.com/users/xianmin/orgs","repos_url":"https://api.github.com/users/xianmin/repos","events_url":"https://api.github.com/users/xianmin/events{/privacy}","received_events_url":"https://api.github.com/users/xianmin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xianmin/hugo-theme-jane","description":"A readable & concise theme for Hugo","fork":false,"url":"https://api.github.com/repos/xianmin/hugo-theme-jane","forks_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/forks","keys_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/teams","hooks_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/hooks","issue_events_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/issues/events{/number}","events_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/events","assignees_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/assignees{/user}","branches_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/branches{/branch}","tags_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/tags","blobs_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/git/refs{/sha}","trees_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/statuses/{sha}","languages_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/languages","stargazers_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/stargazers","contributors_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/contributors","subscribers_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/subscribers","subscription_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/subscription","commits_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/commits{/sha}","git_commits_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/git/commits{/sha}","comments_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/comments{/number}","issue_comment_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/issues/comments{/number}","contents_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/contents/{+path}","compare_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/merges","archive_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/downloads","issues_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/issues{/number}","pulls_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls{/number}","milestones_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/milestones{/number}","notifications_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/labels{/name}","releases_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/releases{/id}","deployments_url":"https://api.github.com/repos/xianmin/hugo-theme-jane/deployments","created_at":"2018-03-06T11:48:50Z","updated_at":"2018-11-16T14:47:50Z","pushed_at":"2018-11-17T00:24:17Z","git_url":"git://github.com/xianmin/hugo-theme-jane.git","ssh_url":"git@github.com:xianmin/hugo-theme-jane.git","clone_url":"https://github.com/xianmin/hugo-theme-jane.git","svn_url":"https://github.com/xianmin/hugo-theme-jane","homepage":"http://en.xianmin.org/hugo-theme-jane/","size":2694,"stargazers_count":150,"watchers_count":150,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":70,"open_issues":19,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/147"},"html":{"href":"https://github.com/xianmin/hugo-theme-jane/pull/147"},"issue":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/issues/147"},"comments":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/xianmin/hugo-theme-jane/statuses/37f5418768e955444e729808949ed2c49e8b0172"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"xianmin"}}