{"action":"created","comment":{"url":"https://api.github.com/repos/brave/browser-ios/pulls/comments/173324052","pull_request_review_id":102498243,"id":173324052,"diff_hunk":"@@ -172,6 +172,18 @@ extension BrowserViewController: WKCompatNavigationDelegate {\n         //history.setTopSitesNeedsInvalidation()\n     }\n \n+    func handleExternalURL (_ url: URL) -> Void {\n+        let alertController = UIAlertController(title: \"\", message: \"Allow '\" + url.relativeString + \"' to open external application?\", preferredStyle: UIAlertControllerStyle.alert)","path":"Client/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift","position":5,"original_position":5,"commit_id":"047d2ec32954da2a21aab90a9fdf05a56ba0347c","original_commit_id":"047d2ec32954da2a21aab90a9fdf05a56ba0347c","user":{"login":"diracdeltas","id":549654,"avatar_url":"https://avatars1.githubusercontent.com/u/549654?v=4","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"body":"@flamsmark i think it's more important to show the URL of the page that is about to be opened in an external app than the URL of the embedding page (what you refer to as second-level domain). \r\n\r\nwe show the embedder URL in desktop because there the embedder is granted a permission to open other external URLs in the future (which is bad UX that we are hopefully getting rid of soon); however that doesn't apply to mobile. on mobile, i don't see any reason to show the embedder URL. \r\n\r\nfor now I think  \"Allow $URL to be opened in an external application?\" is sufficient, where `$URL` is the URL that is about to be opened.","created_at":"2018-03-08T23:22:35Z","updated_at":"2018-03-08T23:22:36Z","html_url":"https://github.com/brave/browser-ios/pull/1478#discussion_r173324052","pull_request_url":"https://api.github.com/repos/brave/browser-ios/pulls/1478","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/brave/browser-ios/pulls/comments/173324052"},"html":{"href":"https://github.com/brave/browser-ios/pull/1478#discussion_r173324052"},"pull_request":{"href":"https://api.github.com/repos/brave/browser-ios/pulls/1478"}},"in_reply_to_id":173010321},"pull_request":{"url":"https://api.github.com/repos/brave/browser-ios/pulls/1478","id":173371819,"html_url":"https://github.com/brave/browser-ios/pull/1478","diff_url":"https://github.com/brave/browser-ios/pull/1478.diff","patch_url":"https://github.com/brave/browser-ios/pull/1478.patch","issue_url":"https://api.github.com/repos/brave/browser-ios/issues/1478","number":1478,"state":"open","locked":false,"title":" Request confirmation from user before opening apps using custom urls","user":{"login":"jumde","id":1903815,"avatar_url":"https://avatars0.githubusercontent.com/u/1903815?v=4","gravatar_id":"","url":"https://api.github.com/users/jumde","html_url":"https://github.com/jumde","followers_url":"https://api.github.com/users/jumde/followers","following_url":"https://api.github.com/users/jumde/following{/other_user}","gists_url":"https://api.github.com/users/jumde/gists{/gist_id}","starred_url":"https://api.github.com/users/jumde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumde/subscriptions","organizations_url":"https://api.github.com/users/jumde/orgs","repos_url":"https://api.github.com/users/jumde/repos","events_url":"https://api.github.com/users/jumde/events{/privacy}","received_events_url":"https://api.github.com/users/jumde/received_events","type":"User","site_admin":false},"body":"See here: https://hackerone.com/reports/321896","created_at":"2018-03-07T07:26:12Z","updated_at":"2018-03-08T23:22:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af96511ad8437370244d2723df72ce541e60a14f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jhreis","id":2781690,"avatar_url":"https://avatars3.githubusercontent.com/u/2781690?v=4","gravatar_id":"","url":"https://api.github.com/users/jhreis","html_url":"https://github.com/jhreis","followers_url":"https://api.github.com/users/jhreis/followers","following_url":"https://api.github.com/users/jhreis/following{/other_user}","gists_url":"https://api.github.com/users/jhreis/gists{/gist_id}","starred_url":"https://api.github.com/users/jhreis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhreis/subscriptions","organizations_url":"https://api.github.com/users/jhreis/orgs","repos_url":"https://api.github.com/users/jhreis/repos","events_url":"https://api.github.com/users/jhreis/events{/privacy}","received_events_url":"https://api.github.com/users/jhreis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/browser-ios/pulls/1478/commits","review_comments_url":"https://api.github.com/repos/brave/browser-ios/pulls/1478/comments","review_comment_url":"https://api.github.com/repos/brave/browser-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-ios/issues/1478/comments","statuses_url":"https://api.github.com/repos/brave/browser-ios/statuses/047d2ec32954da2a21aab90a9fdf05a56ba0347c","head":{"label":"brave:hackerone_321896","ref":"hackerone_321896","sha":"047d2ec32954da2a21aab90a9fdf05a56ba0347c","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":44764615,"name":"browser-ios","full_name":"brave/browser-ios","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-ios","description":"Brave iOS Browser","fork":false,"url":"https://api.github.com/repos/brave/browser-ios","forks_url":"https://api.github.com/repos/brave/browser-ios/forks","keys_url":"https://api.github.com/repos/brave/browser-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-ios/teams","hooks_url":"https://api.github.com/repos/brave/browser-ios/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-ios/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-ios/events","assignees_url":"https://api.github.com/repos/brave/browser-ios/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-ios/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-ios/tags","blobs_url":"https://api.github.com/repos/brave/browser-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-ios/languages","stargazers_url":"https://api.github.com/repos/brave/browser-ios/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-ios/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-ios/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-ios/subscription","commits_url":"https://api.github.com/repos/brave/browser-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-ios/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-ios/merges","archive_url":"https://api.github.com/repos/brave/browser-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-ios/downloads","issues_url":"https://api.github.com/repos/brave/browser-ios/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-ios/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-ios/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-ios/deployments","created_at":"2015-10-22T18:19:43Z","updated_at":"2018-03-05T15:36:34Z","pushed_at":"2018-03-07T21:19:54Z","git_url":"git://github.com/brave/browser-ios.git","ssh_url":"git@github.com:brave/browser-ios.git","clone_url":"https://github.com/brave/browser-ios.git","svn_url":"https://github.com/brave/browser-ios","homepage":"https://www.brave.com","size":504181,"stargazers_count":792,"watchers_count":792,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":362,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":151,"open_issues":362,"watchers":792,"default_branch":"development"}},"base":{"label":"brave:development","ref":"development","sha":"644936c2b46a82438ebda3353ab05e69c8ecf5c4","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":44764615,"name":"browser-ios","full_name":"brave/browser-ios","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-ios","description":"Brave iOS Browser","fork":false,"url":"https://api.github.com/repos/brave/browser-ios","forks_url":"https://api.github.com/repos/brave/browser-ios/forks","keys_url":"https://api.github.com/repos/brave/browser-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-ios/teams","hooks_url":"https://api.github.com/repos/brave/browser-ios/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-ios/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-ios/events","assignees_url":"https://api.github.com/repos/brave/browser-ios/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-ios/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-ios/tags","blobs_url":"https://api.github.com/repos/brave/browser-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-ios/languages","stargazers_url":"https://api.github.com/repos/brave/browser-ios/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-ios/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-ios/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-ios/subscription","commits_url":"https://api.github.com/repos/brave/browser-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-ios/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-ios/merges","archive_url":"https://api.github.com/repos/brave/browser-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-ios/downloads","issues_url":"https://api.github.com/repos/brave/browser-ios/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-ios/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-ios/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-ios/deployments","created_at":"2015-10-22T18:19:43Z","updated_at":"2018-03-05T15:36:34Z","pushed_at":"2018-03-07T21:19:54Z","git_url":"git://github.com/brave/browser-ios.git","ssh_url":"git@github.com:brave/browser-ios.git","clone_url":"https://github.com/brave/browser-ios.git","svn_url":"https://github.com/brave/browser-ios","homepage":"https://www.brave.com","size":504181,"stargazers_count":792,"watchers_count":792,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":362,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":151,"open_issues":362,"watchers":792,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-ios/pulls/1478"},"html":{"href":"https://github.com/brave/browser-ios/pull/1478"},"issue":{"href":"https://api.github.com/repos/brave/browser-ios/issues/1478"},"comments":{"href":"https://api.github.com/repos/brave/browser-ios/issues/1478/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-ios/pulls/1478/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-ios/pulls/1478/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-ios/statuses/047d2ec32954da2a21aab90a9fdf05a56ba0347c"}},"author_association":"NONE"}}
{"actor":{"display_login":"diracdeltas"}}