{"action":"created","issue":{"url":"https://api.github.com/repos/ESCOMP/ctsm/issues/389","repository_url":"https://api.github.com/repos/ESCOMP/ctsm","labels_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/389/comments","events_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/389/events","html_url":"https://github.com/ESCOMP/ctsm/issues/389","id":324224033,"number":389,"title":"Post data-assimilation processing broken with multi-driver","user":{"login":"gold2718","id":1588651,"avatar_url":"https://avatars3.githubusercontent.com/u/1588651?v=4","gravatar_id":"","url":"https://api.github.com/users/gold2718","html_url":"https://github.com/gold2718","followers_url":"https://api.github.com/users/gold2718/followers","following_url":"https://api.github.com/users/gold2718/following{/other_user}","gists_url":"https://api.github.com/users/gold2718/gists{/gist_id}","starred_url":"https://api.github.com/users/gold2718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gold2718/subscriptions","organizations_url":"https://api.github.com/users/gold2718/orgs","repos_url":"https://api.github.com/users/gold2718/repos","events_url":"https://api.github.com/users/gold2718/events{/privacy}","received_events_url":"https://api.github.com/users/gold2718/received_events","type":"User","site_admin":false},"labels":[{"id":831439459,"url":"https://api.github.com/repos/ESCOMP/ctsm/labels/type:%20bug%20-%20other","name":"type: bug - other","color":"cc0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ESCOMP/ctsm/milestones/3","html_url":"https://github.com/ESCOMP/ctsm/milestone/3","labels_url":"https://api.github.com/repos/ESCOMP/ctsm/milestones/3/labels","id":3082724,"number":3,"title":"cesm2","description":null,"creator":{"login":"billsacks","id":6266741,"avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":28,"state":"open","created_at":"2018-02-02T02:43:01Z","updated_at":"2018-05-22T18:11:34Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-05-17T23:51:33Z","updated_at":"2018-05-24T03:20:53Z","closed_at":null,"author_association":"NONE","body":"While I have not tested this in CTSM, CAM has a similar issue. When using multiple instances without multi-driver, `num_inst_lnd == NINST_LND` and each instance has a unique instance number, `inst_index`. However, when multi-driver is on, `num_inst_lnd == 1` but each instance still has a unique `inst_index`.\r\nThis becomes a problem in line 686 of lnd_comp_mct.F90:\r\nhttps://github.com/ESCOMP/ctsm/blob/e739c2c08ca84dcc71d5b9da58051ac4c07ccf59/src/cpl/lnd_comp_mct.F90#L686\r\nwhich walks off the end of the `lnd_resume` array. I suggest making the following fix:\r\n```\r\n if ( len_trim(lnd_resume(MIN(num_inst_lnd,inst_index))) == 0 )then\r\n```"},"comment":{"url":"https://api.github.com/repos/ESCOMP/ctsm/issues/comments/391575398","html_url":"https://github.com/ESCOMP/ctsm/issues/389#issuecomment-391575398","issue_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/389","id":391575398,"user":{"login":"ekluzek","id":11545792,"avatar_url":"https://avatars1.githubusercontent.com/u/11545792?v=4","gravatar_id":"","url":"https://api.github.com/users/ekluzek","html_url":"https://github.com/ekluzek","followers_url":"https://api.github.com/users/ekluzek/followers","following_url":"https://api.github.com/users/ekluzek/following{/other_user}","gists_url":"https://api.github.com/users/ekluzek/gists{/gist_id}","starred_url":"https://api.github.com/users/ekluzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekluzek/subscriptions","organizations_url":"https://api.github.com/users/ekluzek/orgs","repos_url":"https://api.github.com/users/ekluzek/repos","events_url":"https://api.github.com/users/ekluzek/events{/privacy}","received_events_url":"https://api.github.com/users/ekluzek/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T03:20:53Z","updated_at":"2018-05-24T03:20:53Z","author_association":"CONTRIBUTOR","body":"OK, I have a test case that correctly fails as expected as follows...\r\n\r\n```\r\n2407:forrtl: severe (408): fort: (2): Subscript #1 of the array LND_RESUME has value 2 which is greater than the upper bound of 1\r\n2407:\r\n2407:Image              PC                Routine            Line        Source\r\n2407:cesm.exe           00000000041584B6  Unknown               Unknown  Unknown\r\n2407:cesm.exe           000000000084AC2D  lnd_comp_mct_mp_l         686  lnd_comp_mct.F90\r\n2407:cesm.exe           0000000000844747  lnd_comp_mct_mp_l         262  lnd_comp_mct.F90\r\n2407:cesm.exe           000000000045362E  component_mod_mp_         267  component_mod.F90\r\n2407:cesm.exe           0000000000419BB1  cime_comp_mod_mp_        1181  cime_comp_mod.F90\r\n2407:cesm.exe           0000000000449583  MAIN__                     92  cime_driver.F90\r\n2407:cesm.exe           000000000040819E  Unknown               Unknown  Unknown\r\n2407:libc-2.19.so       00002AAAB04DCB25  __libc_start_main     Unknown  Unknown\r\n2407:cesm.exe           00000000004080A9  Unknown               Unknown  Unknown\r\n```"}}
{"actor":{"display_login":"ekluzek"}}