{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20643","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20643/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20643/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20643/events","html_url":"https://github.com/nodejs/node/pull/20643","id":321732267,"number":20643,"title":"net,http2: refactor _write and _writev in net.Socket and http2.Http2Stream","user":{"login":"ryzokuken","id":13121330,"avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"labels":[{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"eb6420","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":647282877,"url":"https://api.github.com/repos/nodejs/node/labels/http2","name":"http2","color":"c2e0c6","default":false},{"id":155435815,"url":"https://api.github.com/repos/nodejs/node/labels/net","name":"net","color":"eb6420","default":false}],"state":"closed","locked":false,"assignee":{"login":"ryzokuken","id":13121330,"avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"assignees":[{"login":"ryzokuken","id":13121330,"avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false}],"milestone":null,"comments":33,"created_at":"2018-05-09T21:25:51Z","updated_at":"2018-05-19T20:36:49Z","closed_at":"2018-05-19T20:36:49Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20643","html_url":"https://github.com/nodejs/node/pull/20643","diff_url":"https://github.com/nodejs/node/pull/20643.diff","patch_url":"https://github.com/nodejs/node/pull/20643.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n### Roadmap\r\n\r\n- [x] Remove inconsistencies between `http2.Http2Stream._write` and `http2.Http2Stream._writev`\r\n- [x] Move all logic into a new method `http2.Http2Stream._writeGeneric`\r\n- [ ] Remove inconsistencies between `net.Socket._writeGeneric` and `http2.Http2Stream._writeGeneric`\r\n- [ ] Refactor common logic into a method in the base class/method, possibly `writeGeneric` from `internal/stream_base_commons`.\r\n\r\n/cc @addaleax @nodejs/http2 @nodejs/net "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/390431056","html_url":"https://github.com/nodejs/node/pull/20643#issuecomment-390431056","issue_url":"https://api.github.com/repos/nodejs/node/issues/20643","id":390431056,"user":{"login":"ryzokuken","id":13121330,"avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"created_at":"2018-05-19T20:36:49Z","updated_at":"2018-05-19T20:36:49Z","author_association":"MEMBER","body":"Landed in a7fa0db"}}
{"actor":{"display_login":"ryzokuken"}}