{"action":"created","comment":{"url":"https://api.github.com/repos/windup/windup/pulls/comments/216239351","pull_request_review_id":153673034,"id":216239351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIzOTM1MQ==","diff_hunk":"@@ -145,5 +147,18 @@ private void createReportModel(GraphContext context, FileModel input, String rep\n             ReportService reportService = new ReportService(context);\n             reportService.setUniqueFilename(applicationReportModel, \"tattletale\" + \"_\" + inputProjectModel.getName(), \"html\");\n         }\n+\n+        private boolean isTattleTaleReportGenerationEnabled(GraphRewrite event)\n+        {\n+            Boolean enableReport = (Boolean) event.getGraphContext().getOptionMap().get(EnableTattletaleReportOption.NAME);","path":"rules-tattletale/addon/src/main/java/org/jboss/windup/rules/apps/tattletale/TattletaleRuleProvider.java","position":37,"original_position":37,"commit_id":"70f9bcf6eb63aea5c5a7dab842f9fcf469507d06","original_commit_id":"70f9bcf6eb63aea5c5a7dab842f9fcf469507d06","user":{"login":"mrizzi","id":7288588,"node_id":"MDQ6VXNlcjcyODg1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/7288588?v=4","gravatar_id":"","url":"https://api.github.com/users/mrizzi","html_url":"https://github.com/mrizzi","followers_url":"https://api.github.com/users/mrizzi/followers","following_url":"https://api.github.com/users/mrizzi/following{/other_user}","gists_url":"https://api.github.com/users/mrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrizzi/subscriptions","organizations_url":"https://api.github.com/users/mrizzi/orgs","repos_url":"https://api.github.com/users/mrizzi/repos","events_url":"https://api.github.com/users/mrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/mrizzi/received_events","type":"User","site_admin":false},"body":"I'm afraid this would lead to a NPE in case there's no such a key due to the unboxing done on `null`","created_at":"2018-09-10T08:38:40Z","updated_at":"2018-09-10T08:38:40Z","html_url":"https://github.com/windup/windup/pull/1330#discussion_r216239351","pull_request_url":"https://api.github.com/repos/windup/windup/pulls/1330","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/windup/windup/pulls/comments/216239351"},"html":{"href":"https://github.com/windup/windup/pull/1330#discussion_r216239351"},"pull_request":{"href":"https://api.github.com/repos/windup/windup/pulls/1330"}},"in_reply_to_id":216227649},"pull_request":{"url":"https://api.github.com/repos/windup/windup/pulls/1330","id":210487074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDg3MDc0","html_url":"https://github.com/windup/windup/pull/1330","diff_url":"https://github.com/windup/windup/pull/1330.diff","patch_url":"https://github.com/windup/windup/pull/1330.patch","issue_url":"https://api.github.com/repos/windup/windup/issues/1330","number":1330,"state":"open","locked":false,"title":"WINDUP-2018 Enable tattletale by default","user":{"login":"mrizzi","id":7288588,"node_id":"MDQ6VXNlcjcyODg1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/7288588?v=4","gravatar_id":"","url":"https://api.github.com/users/mrizzi","html_url":"https://github.com/mrizzi","followers_url":"https://api.github.com/users/mrizzi/followers","following_url":"https://api.github.com/users/mrizzi/following{/other_user}","gists_url":"https://api.github.com/users/mrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrizzi/subscriptions","organizations_url":"https://api.github.com/users/mrizzi/orgs","repos_url":"https://api.github.com/users/mrizzi/repos","events_url":"https://api.github.com/users/mrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/mrizzi/received_events","type":"User","site_admin":false},"body":"- Tattletale report generation enabled by default without any need to provide option\r\n- deprecated `--enableTattletale` option with the following console warning:\r\n```\r\nWARNING: (DEPRECATED) --enableTattletale option is not necessary anymore since Tattletale report generation is enabled by default. Use only --disableTattletale option if you want to disable it.\r\n```\r\n- added `--disableTattletale` option\r\n- check before executing analysis' execution that not both options (`--enableTattletale` and `--disableTattletale`) are provided. If that's the case the executions stops with the following message:\r\n```\r\nERROR: Do NOT use --enableTattletale and --disableTattletale options together. Tattletale report generation is enabled by default so --enableTattletale option should be removed.\r\n```\r\n- created new tests for different use cases (no option, only `--enableTattletale`, only `--disableTattletale`, both options)\r\n- this change works also in the Web UI without any needed change\r\n- Tattletale report: add the standard header (with tooltip, application name and paddings) we have in all the other reports (and removing the standard border the browser adds to iframes)\r\n![screenshot from 2018-08-23 19-23-45](https://user-images.githubusercontent.com/7288588/44541710-1c88b400-a70b-11e8-8724-03359b2cfec4.png)\r\n","created_at":"2018-08-23T15:24:53Z","updated_at":"2018-09-10T08:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f863dc80ad30bdfbd1540834ea4825cd7107ba6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":120223193,"node_id":"MDU6TGFiZWwxMjAyMjMxOTM=","url":"https://api.github.com/repos/windup/windup/labels/Ready%20to%20Review","name":"Ready to Review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/windup/windup/pulls/1330/commits","review_comments_url":"https://api.github.com/repos/windup/windup/pulls/1330/comments","review_comment_url":"https://api.github.com/repos/windup/windup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windup/windup/issues/1330/comments","statuses_url":"https://api.github.com/repos/windup/windup/statuses/70f9bcf6eb63aea5c5a7dab842f9fcf469507d06","head":{"label":"mrizzi:WINDUP-2018","ref":"WINDUP-2018","sha":"70f9bcf6eb63aea5c5a7dab842f9fcf469507d06","user":{"login":"mrizzi","id":7288588,"node_id":"MDQ6VXNlcjcyODg1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/7288588?v=4","gravatar_id":"","url":"https://api.github.com/users/mrizzi","html_url":"https://github.com/mrizzi","followers_url":"https://api.github.com/users/mrizzi/followers","following_url":"https://api.github.com/users/mrizzi/following{/other_user}","gists_url":"https://api.github.com/users/mrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrizzi/subscriptions","organizations_url":"https://api.github.com/users/mrizzi/orgs","repos_url":"https://api.github.com/users/mrizzi/repos","events_url":"https://api.github.com/users/mrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/mrizzi/received_events","type":"User","site_admin":false},"repo":{"id":85212227,"node_id":"MDEwOlJlcG9zaXRvcnk4NTIxMjIyNw==","name":"windup","full_name":"mrizzi/windup","owner":{"login":"mrizzi","id":7288588,"node_id":"MDQ6VXNlcjcyODg1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/7288588?v=4","gravatar_id":"","url":"https://api.github.com/users/mrizzi","html_url":"https://github.com/mrizzi","followers_url":"https://api.github.com/users/mrizzi/followers","following_url":"https://api.github.com/users/mrizzi/following{/other_user}","gists_url":"https://api.github.com/users/mrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrizzi/subscriptions","organizations_url":"https://api.github.com/users/mrizzi/orgs","repos_url":"https://api.github.com/users/mrizzi/repos","events_url":"https://api.github.com/users/mrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/mrizzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrizzi/windup","description":"Windup - JBoss Automated Migration Tool","fork":true,"url":"https://api.github.com/repos/mrizzi/windup","forks_url":"https://api.github.com/repos/mrizzi/windup/forks","keys_url":"https://api.github.com/repos/mrizzi/windup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrizzi/windup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrizzi/windup/teams","hooks_url":"https://api.github.com/repos/mrizzi/windup/hooks","issue_events_url":"https://api.github.com/repos/mrizzi/windup/issues/events{/number}","events_url":"https://api.github.com/repos/mrizzi/windup/events","assignees_url":"https://api.github.com/repos/mrizzi/windup/assignees{/user}","branches_url":"https://api.github.com/repos/mrizzi/windup/branches{/branch}","tags_url":"https://api.github.com/repos/mrizzi/windup/tags","blobs_url":"https://api.github.com/repos/mrizzi/windup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrizzi/windup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrizzi/windup/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrizzi/windup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrizzi/windup/statuses/{sha}","languages_url":"https://api.github.com/repos/mrizzi/windup/languages","stargazers_url":"https://api.github.com/repos/mrizzi/windup/stargazers","contributors_url":"https://api.github.com/repos/mrizzi/windup/contributors","subscribers_url":"https://api.github.com/repos/mrizzi/windup/subscribers","subscription_url":"https://api.github.com/repos/mrizzi/windup/subscription","commits_url":"https://api.github.com/repos/mrizzi/windup/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrizzi/windup/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrizzi/windup/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrizzi/windup/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrizzi/windup/contents/{+path}","compare_url":"https://api.github.com/repos/mrizzi/windup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrizzi/windup/merges","archive_url":"https://api.github.com/repos/mrizzi/windup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrizzi/windup/downloads","issues_url":"https://api.github.com/repos/mrizzi/windup/issues{/number}","pulls_url":"https://api.github.com/repos/mrizzi/windup/pulls{/number}","milestones_url":"https://api.github.com/repos/mrizzi/windup/milestones{/number}","notifications_url":"https://api.github.com/repos/mrizzi/windup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrizzi/windup/labels{/name}","releases_url":"https://api.github.com/repos/mrizzi/windup/releases{/id}","deployments_url":"https://api.github.com/repos/mrizzi/windup/deployments","created_at":"2017-03-16T15:34:25Z","updated_at":"2018-08-13T17:37:18Z","pushed_at":"2018-09-07T16:31:45Z","git_url":"git://github.com/mrizzi/windup.git","ssh_url":"git@github.com:mrizzi/windup.git","clone_url":"https://github.com/mrizzi/windup.git","svn_url":"https://github.com/mrizzi/windup","homepage":"","size":120284,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"windup:master","ref":"master","sha":"fbd45ca6072f832b3bbfc490edda1ea4386c277e","user":{"login":"windup","id":4266383,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjYzODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4266383?v=4","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":9702026,"node_id":"MDEwOlJlcG9zaXRvcnk5NzAyMDI2","name":"windup","full_name":"windup/windup","owner":{"login":"windup","id":4266383,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjYzODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4266383?v=4","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup","description":"Windup - Application Migration and Assessment Tool","fork":false,"url":"https://api.github.com/repos/windup/windup","forks_url":"https://api.github.com/repos/windup/windup/forks","keys_url":"https://api.github.com/repos/windup/windup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup/teams","hooks_url":"https://api.github.com/repos/windup/windup/hooks","issue_events_url":"https://api.github.com/repos/windup/windup/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup/events","assignees_url":"https://api.github.com/repos/windup/windup/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup/tags","blobs_url":"https://api.github.com/repos/windup/windup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup/languages","stargazers_url":"https://api.github.com/repos/windup/windup/stargazers","contributors_url":"https://api.github.com/repos/windup/windup/contributors","subscribers_url":"https://api.github.com/repos/windup/windup/subscribers","subscription_url":"https://api.github.com/repos/windup/windup/subscription","commits_url":"https://api.github.com/repos/windup/windup/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup/issues/comments{/number}","contents_url":"https://api.github.com/repos/windup/windup/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup/merges","archive_url":"https://api.github.com/repos/windup/windup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup/downloads","issues_url":"https://api.github.com/repos/windup/windup/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup/releases{/id}","deployments_url":"https://api.github.com/repos/windup/windup/deployments","created_at":"2013-04-26T18:52:08Z","updated_at":"2018-09-06T02:32:15Z","pushed_at":"2018-09-07T16:31:46Z","git_url":"git://github.com/windup/windup.git","ssh_url":"git@github.com:windup/windup.git","clone_url":"https://github.com/windup/windup.git","svn_url":"https://github.com/windup/windup","homepage":"","size":130216,"stargazers_count":86,"watchers_count":86,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":92,"open_issues":45,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windup/windup/pulls/1330"},"html":{"href":"https://github.com/windup/windup/pull/1330"},"issue":{"href":"https://api.github.com/repos/windup/windup/issues/1330"},"comments":{"href":"https://api.github.com/repos/windup/windup/issues/1330/comments"},"review_comments":{"href":"https://api.github.com/repos/windup/windup/pulls/1330/comments"},"review_comment":{"href":"https://api.github.com/repos/windup/windup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windup/windup/pulls/1330/commits"},"statuses":{"href":"https://api.github.com/repos/windup/windup/statuses/70f9bcf6eb63aea5c5a7dab842f9fcf469507d06"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mrizzi"}}