{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls/11","id":222447784,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDQ3Nzg0","html_url":"https://github.com/resin-io-projects/resin-rust-hello-world/pull/11","diff_url":"https://github.com/resin-io-projects/resin-rust-hello-world/pull/11.diff","patch_url":"https://github.com/resin-io-projects/resin-rust-hello-world/pull/11.patch","issue_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues/11","number":11,"state":"closed","locked":false,"title":"Fix building on architectures other than armv7","user":{"login":"cyplo","id":217899,"node_id":"MDQ6VXNlcjIxNzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/217899?v=4","gravatar_id":"","url":"https://api.github.com/users/cyplo","html_url":"https://github.com/cyplo","followers_url":"https://api.github.com/users/cyplo/followers","following_url":"https://api.github.com/users/cyplo/following{/other_user}","gists_url":"https://api.github.com/users/cyplo/gists{/gist_id}","starred_url":"https://api.github.com/users/cyplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyplo/subscriptions","organizations_url":"https://api.github.com/users/cyplo/orgs","repos_url":"https://api.github.com/users/cyplo/repos","events_url":"https://api.github.com/users/cyplo/events{/privacy}","received_events_url":"https://api.github.com/users/cyplo/received_events","type":"User","site_admin":false},"body":"Fixes #10, #2 \r\n\r\nAdded separate Dockerfiles per architecture.\r\nRight now the files are copies of the previous version of the template, with a very small change. Probably would be best to avoid duplication and have one place for the common contents of the Dockerfile - probably a separate PR for removing the duplication ?\r\n\r\nPlease note that I have added a `armv7hf` file but actually it compiles with `armv7l`, as `rustup` does not recognise `armv7hf` as a separate target.\r\nPlease see https://forge.rust-lang.org/platform-support.html for the list of supported platforms for Rust.\r\n\r\nI have tested on raspi3 and intel NUC (virtual) and seems happy. \r\n`.rpi` a.k.a `armv6l` is **untested** as I lack the hardware to test.\r\n","created_at":"2018-10-12T12:19:03Z","updated_at":"2018-10-12T13:36:20Z","closed_at":"2018-10-12T13:36:20Z","merged_at":"2018-10-12T13:36:20Z","merge_commit_sha":"68dfe351675791bdd1244963d87371a7b3de85ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls/11/commits","review_comments_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls/11/comments","review_comment_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues/11/comments","statuses_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/statuses/96800073f351b6cbe2872fbd98e4943bb449f638","head":{"label":"resin-io-projects:fix-other-archs","ref":"fix-other-archs","sha":"96800073f351b6cbe2872fbd98e4943bb449f638","user":{"login":"resin-io-projects","id":11962351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTYyMzUx","avatar_url":"https://avatars0.githubusercontent.com/u/11962351?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-projects","html_url":"https://github.com/resin-io-projects","followers_url":"https://api.github.com/users/resin-io-projects/followers","following_url":"https://api.github.com/users/resin-io-projects/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-projects/subscriptions","organizations_url":"https://api.github.com/users/resin-io-projects/orgs","repos_url":"https://api.github.com/users/resin-io-projects/repos","events_url":"https://api.github.com/users/resin-io-projects/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":59838676,"node_id":"MDEwOlJlcG9zaXRvcnk1OTgzODY3Ng==","name":"resin-rust-hello-world","full_name":"resin-io-projects/resin-rust-hello-world","private":false,"owner":{"login":"resin-io-projects","id":11962351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTYyMzUx","avatar_url":"https://avatars0.githubusercontent.com/u/11962351?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-projects","html_url":"https://github.com/resin-io-projects","followers_url":"https://api.github.com/users/resin-io-projects/followers","following_url":"https://api.github.com/users/resin-io-projects/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-projects/subscriptions","organizations_url":"https://api.github.com/users/resin-io-projects/orgs","repos_url":"https://api.github.com/users/resin-io-projects/repos","events_url":"https://api.github.com/users/resin-io-projects/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/resin-io-projects/resin-rust-hello-world","description":"Example of how to deploy Rust code on a resin.io supported device.","fork":false,"url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world","forks_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/forks","keys_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/teams","hooks_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/hooks","issue_events_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/events","assignees_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/tags","blobs_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/languages","stargazers_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/stargazers","contributors_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/contributors","subscribers_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/subscribers","subscription_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/subscription","commits_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/merges","archive_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/downloads","issues_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/deployments","created_at":"2016-05-27T14:04:34Z","updated_at":"2018-10-08T15:39:35Z","pushed_at":"2018-10-12T13:36:20Z","git_url":"git://github.com/resin-io-projects/resin-rust-hello-world.git","ssh_url":"git@github.com:resin-io-projects/resin-rust-hello-world.git","clone_url":"https://github.com/resin-io-projects/resin-rust-hello-world.git","svn_url":"https://github.com/resin-io-projects/resin-rust-hello-world","homepage":"","size":1460,"stargazers_count":9,"watchers_count":9,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"resin-io-projects:master","ref":"master","sha":"967973dff969b18f64136a223d3866915bcdf827","user":{"login":"resin-io-projects","id":11962351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTYyMzUx","avatar_url":"https://avatars0.githubusercontent.com/u/11962351?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-projects","html_url":"https://github.com/resin-io-projects","followers_url":"https://api.github.com/users/resin-io-projects/followers","following_url":"https://api.github.com/users/resin-io-projects/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-projects/subscriptions","organizations_url":"https://api.github.com/users/resin-io-projects/orgs","repos_url":"https://api.github.com/users/resin-io-projects/repos","events_url":"https://api.github.com/users/resin-io-projects/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":59838676,"node_id":"MDEwOlJlcG9zaXRvcnk1OTgzODY3Ng==","name":"resin-rust-hello-world","full_name":"resin-io-projects/resin-rust-hello-world","private":false,"owner":{"login":"resin-io-projects","id":11962351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTYyMzUx","avatar_url":"https://avatars0.githubusercontent.com/u/11962351?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-projects","html_url":"https://github.com/resin-io-projects","followers_url":"https://api.github.com/users/resin-io-projects/followers","following_url":"https://api.github.com/users/resin-io-projects/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-projects/subscriptions","organizations_url":"https://api.github.com/users/resin-io-projects/orgs","repos_url":"https://api.github.com/users/resin-io-projects/repos","events_url":"https://api.github.com/users/resin-io-projects/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/resin-io-projects/resin-rust-hello-world","description":"Example of how to deploy Rust code on a resin.io supported device.","fork":false,"url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world","forks_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/forks","keys_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/teams","hooks_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/hooks","issue_events_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/events","assignees_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/tags","blobs_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/languages","stargazers_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/stargazers","contributors_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/contributors","subscribers_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/subscribers","subscription_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/subscription","commits_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/merges","archive_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/downloads","issues_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/deployments","created_at":"2016-05-27T14:04:34Z","updated_at":"2018-10-08T15:39:35Z","pushed_at":"2018-10-12T13:36:20Z","git_url":"git://github.com/resin-io-projects/resin-rust-hello-world.git","ssh_url":"git@github.com:resin-io-projects/resin-rust-hello-world.git","clone_url":"https://github.com/resin-io-projects/resin-rust-hello-world.git","svn_url":"https://github.com/resin-io-projects/resin-rust-hello-world","homepage":"","size":1460,"stargazers_count":9,"watchers_count":9,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls/11"},"html":{"href":"https://github.com/resin-io-projects/resin-rust-hello-world/pull/11"},"issue":{"href":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues/11"},"comments":{"href":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io-projects/resin-rust-hello-world/statuses/96800073f351b6cbe2872fbd98e4943bb449f638"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cyplo","id":217899,"node_id":"MDQ6VXNlcjIxNzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/217899?v=4","gravatar_id":"","url":"https://api.github.com/users/cyplo","html_url":"https://github.com/cyplo","followers_url":"https://api.github.com/users/cyplo/followers","following_url":"https://api.github.com/users/cyplo/following{/other_user}","gists_url":"https://api.github.com/users/cyplo/gists{/gist_id}","starred_url":"https://api.github.com/users/cyplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyplo/subscriptions","organizations_url":"https://api.github.com/users/cyplo/orgs","repos_url":"https://api.github.com/users/cyplo/repos","events_url":"https://api.github.com/users/cyplo/events{/privacy}","received_events_url":"https://api.github.com/users/cyplo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":5,"additions":183,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"cyplo"}}