{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/comments/242803308","pull_request_review_id":186398801,"id":242803308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjgwMzMwOA==","diff_hunk":"@@ -0,0 +1,411 @@\n+// @public\n+interface AmqpError {\n+  condition?: string;\n+  description?: string;\n+  info?: any;\n+  value?: any[];\n+}\n+\n+// @public\n+interface ConnectionConfig {\n+}\n+\n+// @public\n+interface CorrelationFilter {\n+  contentType?: string;\n+  correlationId?: string;\n+  label?: string;\n+  messageId?: string;\n+  replyTo?: string;\n+  replyToSessionId?: string;\n+  sessionId?: string;\n+  to?: string;\n+  userProperties?: any;\n+}\n+\n+// @public\n+interface DataTransformer {\n+  decode: (body: any) => any;\n+  encode: (body: any) => any;\n+}\n+\n+// @public\n+interface DeadLetterOptions {\n+  deadLetterErrorDescription: string;\n+  deadletterReason: string;\n+}\n+\n+// @public\n+class DefaultDataTransformer implements DataTransformer {\n+  decode(body: any): any;\n+  encode(body: any): any;\n+}\n+\n+// @public\n+export function delay<T>(t: number, value?: T): Promise<T>;\n+\n+// @public (undocumented)\n+interface Delivery {","path":"etc/service-bus.api.ts","position":48,"original_position":48,"commit_id":"77a6d7b10bd1fad5b082bfec5801b115cd3bd02d","original_commit_id":"77a6d7b10bd1fad5b082bfec5801b115cd3bd02d","user":{"login":"amarzavery","id":4521223,"node_id":"MDQ6VXNlcjQ1MjEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4521223?v=4","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"body":"This type is exported from rhea. Hence the documentation for Delivery in rhea typings should be updated.","created_at":"2018-12-19T06:31:46Z","updated_at":"2018-12-19T06:53:50Z","html_url":"https://github.com/Azure/azure-service-bus-node/pull/77#discussion_r242803308","pull_request_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/77","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/comments/242803308"},"html":{"href":"https://github.com/Azure/azure-service-bus-node/pull/77#discussion_r242803308"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/77","id":238148196,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTQ4MTk2","html_url":"https://github.com/Azure/azure-service-bus-node/pull/77","diff_url":"https://github.com/Azure/azure-service-bus-node/pull/77.diff","patch_url":"https://github.com/Azure/azure-service-bus-node/pull/77.patch","issue_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/77","number":77,"state":"open","locked":false,"title":"Add api-extractor for dts rollups and API reviews","user":{"login":"bterlson","id":11236,"node_id":"MDQ6VXNlcjExMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/11236?v=4","gravatar_id":"","url":"https://api.github.com/users/bterlson","html_url":"https://github.com/bterlson","followers_url":"https://api.github.com/users/bterlson/followers","following_url":"https://api.github.com/users/bterlson/following{/other_user}","gists_url":"https://api.github.com/users/bterlson/gists{/gist_id}","starred_url":"https://api.github.com/users/bterlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bterlson/subscriptions","organizations_url":"https://api.github.com/users/bterlson/orgs","repos_url":"https://api.github.com/users/bterlson/repos","events_url":"https://api.github.com/users/bterlson/events{/privacy}","received_events_url":"https://api.github.com/users/bterlson/received_events","type":"User","site_admin":false},"body":"This commit adds API extractor and an npm task `extract-api`. It does\r\nthe following:\r\n\r\n* Generates a dts rollup file of this library's entire surface area.\r\n  This is presently being saved to /typings/index-rollup.d.ts, but\r\n  should probably go into a different place eventually.\r\n* Adds API baselines under ./etc. Every run of `extract-api` will check\r\n  if the public surface area changed, and if so, say something on the\r\n  console. A git diff of ./etc/service-bus.api.ts shows pretty clearly\r\n  what APIs have changed.\r\n\r\nA lot of warnings are generated here. Most seem to be due to different\r\ndoc tag conventions, but a few suggest maybe some pieces need to be\r\nexported. Check the generated API file for more details (search for\r\n\"WARNING:\").\r\n\r\nBefore accepting this PR, we should at least:\r\n\r\n* [ ] Decide if we want to enable the API Review workflow or turn it off\r\n* [ ] Confirm the rollup is accurate and if so replace the typings folder","created_at":"2018-12-12T19:05:10Z","updated_at":"2018-12-19T06:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceed1880b3d86964e0fcc16cea778297159c44c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/77/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/77/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/77/comments","statuses_url":"https://api.github.com/repos/Azure/azure-service-bus-node/statuses/77a6d7b10bd1fad5b082bfec5801b115cd3bd02d","head":{"label":"bterlson:api-extractor","ref":"api-extractor","sha":"77a6d7b10bd1fad5b082bfec5801b115cd3bd02d","user":{"login":"bterlson","id":11236,"node_id":"MDQ6VXNlcjExMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/11236?v=4","gravatar_id":"","url":"https://api.github.com/users/bterlson","html_url":"https://github.com/bterlson","followers_url":"https://api.github.com/users/bterlson/followers","following_url":"https://api.github.com/users/bterlson/following{/other_user}","gists_url":"https://api.github.com/users/bterlson/gists{/gist_id}","starred_url":"https://api.github.com/users/bterlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bterlson/subscriptions","organizations_url":"https://api.github.com/users/bterlson/orgs","repos_url":"https://api.github.com/users/bterlson/repos","events_url":"https://api.github.com/users/bterlson/events{/privacy}","received_events_url":"https://api.github.com/users/bterlson/received_events","type":"User","site_admin":false},"repo":{"id":160403266,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDMyNjY=","name":"azure-service-bus-node","full_name":"bterlson/azure-service-bus-node","private":false,"owner":{"login":"bterlson","id":11236,"node_id":"MDQ6VXNlcjExMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/11236?v=4","gravatar_id":"","url":"https://api.github.com/users/bterlson","html_url":"https://github.com/bterlson","followers_url":"https://api.github.com/users/bterlson/followers","following_url":"https://api.github.com/users/bterlson/following{/other_user}","gists_url":"https://api.github.com/users/bterlson/gists{/gist_id}","starred_url":"https://api.github.com/users/bterlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bterlson/subscriptions","organizations_url":"https://api.github.com/users/bterlson/orgs","repos_url":"https://api.github.com/users/bterlson/repos","events_url":"https://api.github.com/users/bterlson/events{/privacy}","received_events_url":"https://api.github.com/users/bterlson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bterlson/azure-service-bus-node","description":null,"fork":true,"url":"https://api.github.com/repos/bterlson/azure-service-bus-node","forks_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/forks","keys_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/teams","hooks_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/hooks","issue_events_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/issues/events{/number}","events_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/events","assignees_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/assignees{/user}","branches_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/branches{/branch}","tags_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/tags","blobs_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/statuses/{sha}","languages_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/languages","stargazers_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/stargazers","contributors_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/contributors","subscribers_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/subscribers","subscription_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/subscription","commits_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/contents/{+path}","compare_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/merges","archive_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/downloads","issues_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/issues{/number}","pulls_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/pulls{/number}","milestones_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/milestones{/number}","notifications_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/labels{/name}","releases_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/releases{/id}","deployments_url":"https://api.github.com/repos/bterlson/azure-service-bus-node/deployments","created_at":"2018-12-04T18:44:21Z","updated_at":"2018-12-04T18:44:24Z","pushed_at":"2018-12-19T05:28:03Z","git_url":"git://github.com/bterlson/azure-service-bus-node.git","ssh_url":"git@github.com:bterlson/azure-service-bus-node.git","clone_url":"https://github.com/bterlson/azure-service-bus-node.git","svn_url":"https://github.com/bterlson/azure-service-bus-node","homepage":null,"size":450,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"99b6bff5566f3f8499c8f38a97c7e9f37471cc55","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":71311975,"node_id":"MDEwOlJlcG9zaXRvcnk3MTMxMTk3NQ==","name":"azure-service-bus-node","full_name":"Azure/azure-service-bus-node","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-service-bus-node","description":null,"fork":false,"url":"https://api.github.com/repos/Azure/azure-service-bus-node","forks_url":"https://api.github.com/repos/Azure/azure-service-bus-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-service-bus-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-service-bus-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-service-bus-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-service-bus-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-service-bus-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-service-bus-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-service-bus-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-service-bus-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-service-bus-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-service-bus-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-service-bus-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-service-bus-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-service-bus-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-service-bus-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-service-bus-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-service-bus-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-service-bus-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-service-bus-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-service-bus-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-service-bus-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-service-bus-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-service-bus-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-service-bus-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-service-bus-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-service-bus-node/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-service-bus-node/deployments","created_at":"2016-10-19T02:42:46Z","updated_at":"2018-12-18T04:18:39Z","pushed_at":"2018-12-19T05:28:04Z","git_url":"git://github.com/Azure/azure-service-bus-node.git","ssh_url":"git@github.com:Azure/azure-service-bus-node.git","clone_url":"https://github.com/Azure/azure-service-bus-node.git","svn_url":"https://github.com/Azure/azure-service-bus-node","homepage":null,"size":437,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":42,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/77"},"html":{"href":"https://github.com/Azure/azure-service-bus-node/pull/77"},"issue":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/77"},"comments":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/statuses/77a6d7b10bd1fad5b082bfec5801b115cd3bd02d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amarzavery"}}