{"action":"created","issue":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/954","repository_url":"https://api.github.com/repos/jetstack/cert-manager","labels_url":"https://api.github.com/repos/jetstack/cert-manager/issues/954/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/954/comments","events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/954/events","html_url":"https://github.com/jetstack/cert-manager/pull/954","id":369612568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTEzNjcx","number":954,"title":"Add ACME challenge scheduler","user":{"login":"munnerz","id":203583,"node_id":"MDQ6VXNlcjIwMzU4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"labels":[{"id":1041273320,"node_id":"MDU6TGFiZWwxMDQxMjczMzIw","url":"https://api.github.com/repos/jetstack/cert-manager/labels/dco-signoff:%20yes","name":"dco-signoff: yes","color":"ededed","default":false},{"id":728589163,"node_id":"MDU6TGFiZWw3Mjg1ODkxNjM=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":728244369,"node_id":"MDU6TGFiZWw3MjgyNDQzNjk=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-12T15:59:54Z","updated_at":"2018-10-12T17:45:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/954","html_url":"https://github.com/jetstack/cert-manager/pull/954","diff_url":"https://github.com/jetstack/cert-manager/pull/954.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/954.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nAdds a basic ACME challenge scheduler.\r\n\r\nAs discussed with @kragniz, this does not perform particularly well in clusters with a large number of certificate resources.\r\n\r\nWe will implement some scale tests on this as a follow up, that verifies the performance so we have something to benchmark against for improvements.\r\n\r\n**Which issue this PR fixes**: fixes #951 \r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments/429405485","html_url":"https://github.com/jetstack/cert-manager/pull/954#issuecomment-429405485","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/954","id":429405485,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQwNTQ4NQ==","user":{"login":"jetstack-bot","id":32282838,"node_id":"MDQ6VXNlcjMyMjgyODM4","avatar_url":"https://avatars1.githubusercontent.com/u/32282838?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack-bot","html_url":"https://github.com/jetstack-bot","followers_url":"https://api.github.com/users/jetstack-bot/followers","following_url":"https://api.github.com/users/jetstack-bot/following{/other_user}","gists_url":"https://api.github.com/users/jetstack-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack-bot/subscriptions","organizations_url":"https://api.github.com/users/jetstack-bot/orgs","repos_url":"https://api.github.com/users/jetstack-bot/repos","events_url":"https://api.github.com/users/jetstack-bot/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack-bot/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T17:45:07Z","updated_at":"2018-10-12T17:45:07Z","author_association":"COLLABORATOR","body":"@munnerz: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-cert-manager-e2e-v1-11 | 123b807098d061e0d23b6acf513d06d1edd5ed31 | [link](https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/954/pull-cert-manager-e2e-v1-11/237/) | `/test e2e v1.11`\npull-cert-manager-codegen | fa00c89811aad27ad83940c9a166ef9c4bc2cc0b | [link](https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/954/pull-cert-manager-codegen/231/) | `/test codegen`\npull-cert-manager-unit | fa00c89811aad27ad83940c9a166ef9c4bc2cc0b | [link](https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/954/pull-cert-manager-unit/228/) | `/test unit`\n\n[Full PR test history](https://jetstack-build-infra.appspot.com/pr/jetstack_cert-manager/954). [Your PR dashboard](https://jetstack-build-infra.appspot.com/pr/munnerz). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/jetstack/cert-manager/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"jetstack-bot"}}