{"action":"created","issue":{"url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1330","repository_url":"https://api.github.com/repos/freqtrade/freqtrade","labels_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1330/labels{/name}","comments_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1330/comments","events_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1330/events","html_url":"https://github.com/freqtrade/freqtrade/pull/1330","id":381012571,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDc3ODY1","number":1330,"title":"Add support for different order types","user":{"login":"xmatthias","id":5024695,"node_id":"MDQ6VXNlcjUwMjQ2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5024695?v=4","gravatar_id":"","url":"https://api.github.com/users/xmatthias","html_url":"https://github.com/xmatthias","followers_url":"https://api.github.com/users/xmatthias/followers","following_url":"https://api.github.com/users/xmatthias/following{/other_user}","gists_url":"https://api.github.com/users/xmatthias/gists{/gist_id}","starred_url":"https://api.github.com/users/xmatthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmatthias/subscriptions","organizations_url":"https://api.github.com/users/xmatthias/orgs","repos_url":"https://api.github.com/users/xmatthias/repos","events_url":"https://api.github.com/users/xmatthias/events{/privacy}","received_events_url":"https://api.github.com/users/xmatthias/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-15T06:01:44Z","updated_at":"2018-11-17T17:09:33Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1330","html_url":"https://github.com/freqtrade/freqtrade/pull/1330","diff_url":"https://github.com/freqtrade/freqtrade/pull/1330.diff","patch_url":"https://github.com/freqtrade/freqtrade/pull/1330.patch"},"body":"## Summary\r\nAs mentioned in #1326, there is a pretty simple way to support different order types.\r\n\r\nSolves issue: #893\r\n\r\n## Quick changelog\r\n\r\n- Add order mapping between buy/sell/stoploss - allowing different types for each order\r\n\r\n## still todo\r\n\r\nthis is a very quick drawup on how i immagine this to work, and it's nowhere near production ready.\r\n\r\n* [x] documentation\r\n* [x] add tests to verify that parameter is passed to ccxt correctly\r\n* [x] allow setting this in configuration\r\n* [x] add to default sample strategy\r\n* [x] add test to check strategy validity\r\n* [x] fix tests"},"comment":{"url":"https://api.github.com/repos/freqtrade/freqtrade/issues/comments/439631945","html_url":"https://github.com/freqtrade/freqtrade/pull/1330#issuecomment-439631945","issue_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1330","id":439631945,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTYzMTk0NQ==","user":{"login":"mishaker","id":939309,"node_id":"MDQ6VXNlcjkzOTMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/939309?v=4","gravatar_id":"","url":"https://api.github.com/users/mishaker","html_url":"https://github.com/mishaker","followers_url":"https://api.github.com/users/mishaker/followers","following_url":"https://api.github.com/users/mishaker/following{/other_user}","gists_url":"https://api.github.com/users/mishaker/gists{/gist_id}","starred_url":"https://api.github.com/users/mishaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishaker/subscriptions","organizations_url":"https://api.github.com/users/mishaker/orgs","repos_url":"https://api.github.com/users/mishaker/repos","events_url":"https://api.github.com/users/mishaker/events{/privacy}","received_events_url":"https://api.github.com/users/mishaker/received_events","type":"User","site_admin":false},"created_at":"2018-11-17T17:09:33Z","updated_at":"2018-11-17T17:09:33Z","author_association":"MEMBER","body":"> These two lines should be bypassed in case of market:\r\nsell_rate = self.exchange.get_ticker(trade.pair)['bid']\r\nbuy_limit = self.get_target_bid(pair, self.exchange.get_ticker(pair))\r\n\r\nIn that case you may want to get the ticker instead of get_target_bid for buy_limit ?\r\n"}}
{"actor":{"display_login":"mishaker"}}