{"action":"created","issue":{"url":"https://api.github.com/repos/xcat2/xcat-core/issues/4906","repository_url":"https://api.github.com/repos/xcat2/xcat-core","labels_url":"https://api.github.com/repos/xcat2/xcat-core/issues/4906/labels{/name}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/issues/4906/comments","events_url":"https://api.github.com/repos/xcat2/xcat-core/issues/4906/events","html_url":"https://github.com/xcat2/xcat-core/issues/4906","id":303531419,"node_id":"MDU6SXNzdWUzMDM1MzE0MTk=","number":4906,"title":"Goconserver.pm creates invalid format in comments in server.conf file for goconserver","user":{"login":"whowutwut","id":10049070,"node_id":"MDQ6VXNlcjEwMDQ5MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/10049070?v=4","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"labels":[{"id":243854974,"node_id":"MDU6TGFiZWwyNDM4NTQ5NzQ=","url":"https://api.github.com/repos/xcat2/xcat-core/labels/priority:high","name":"priority:high","color":"e11d21","default":false},{"id":400624883,"node_id":"MDU6TGFiZWw0MDA2MjQ4ODM=","url":"https://api.github.com/repos/xcat2/xcat-core/labels/status:won't%20fix","name":"status:won't fix","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":{"login":"chenglch","id":7165199,"node_id":"MDQ6VXNlcjcxNjUxOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7165199?v=4","gravatar_id":"","url":"https://api.github.com/users/chenglch","html_url":"https://github.com/chenglch","followers_url":"https://api.github.com/users/chenglch/followers","following_url":"https://api.github.com/users/chenglch/following{/other_user}","gists_url":"https://api.github.com/users/chenglch/gists{/gist_id}","starred_url":"https://api.github.com/users/chenglch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenglch/subscriptions","organizations_url":"https://api.github.com/users/chenglch/orgs","repos_url":"https://api.github.com/users/chenglch/repos","events_url":"https://api.github.com/users/chenglch/events{/privacy}","received_events_url":"https://api.github.com/users/chenglch/received_events","type":"User","site_admin":false},"assignees":[{"login":"chenglch","id":7165199,"node_id":"MDQ6VXNlcjcxNjUxOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7165199?v=4","gravatar_id":"","url":"https://api.github.com/users/chenglch","html_url":"https://github.com/chenglch","followers_url":"https://api.github.com/users/chenglch/followers","following_url":"https://api.github.com/users/chenglch/following{/other_user}","gists_url":"https://api.github.com/users/chenglch/gists{/gist_id}","starred_url":"https://api.github.com/users/chenglch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenglch/subscriptions","organizations_url":"https://api.github.com/users/chenglch/orgs","repos_url":"https://api.github.com/users/chenglch/repos","events_url":"https://api.github.com/users/chenglch/events{/privacy}","received_events_url":"https://api.github.com/users/chenglch/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-03-08T15:56:56Z","updated_at":"2018-06-19T21:10:57Z","closed_at":"2018-06-19T21:10:57Z","author_association":"MEMBER","body":"@chenglch  the `makegocons` script will create a server.conf in /etc/goconserver, the formatting is incorrect. \r\n\r\nHere's an example of the resulting file: \r\n\r\n```\r\n...\r\n  logger:                                              # multiple logger targets could be specified\r\n    file:                                              # file logger, valid fields: name,logdir. Accept array in yaml format\r\n       - name: default                                 # the identity name customized by user\r\n         logdir: /var/log/consoles                   # default log directory of xcat\r\n    #  - name: goconserver\r\n    #    logdir: /var/log/goconserver/nodes\r\n  # tcp:                                               # valied fields: name, host, port, timeout, ssl_key_file, ssl_cert_file, ssl_ca_cert_file, ssl_insecure\r\n     # - name: logstash\r\n     #   host: 127.0.0.1\r\n     #   port: 9653\r\n     #   timeout:  3                                   # default 3 second\r\n     # - name: filebeat\r\n     #   host: <hostname or ip>\r\n     #   port: <port>\r\n  # udp:                                               # valid fiedls: name, host, port, timeout\r\n     # - name: rsyslog\r\n     #   host:\r\n     #   port:\r\n     #   timeout:                                      # default 3 second\r\n```\r\n\r\nThe problem here is that `tcp:` is lined up with `file:` but if someone deletes the `#`, the formatting is invalid and TCP logging will not happen.  \r\n\r\nThe attributes under TCP are in such a way that deleting the `#` comment, results in it being in the correct indentation\r\n\r\n\r\nHere's what happens if I remove the comments in the `tcp:` section....  \r\n\r\n\r\n```\r\n  logger:                                              # multiple logger targets could be specified\r\n    file:                                              # file logger, valid fields: name,logdir. Accept array in yaml format\r\n       - name: default                                 # the identity name customized by user\r\n         logdir: /var/log/consoles                   # default log directory of xcat\r\n    #  - name: goconserver\r\n    #    logdir: /var/log/goconserver/nodes\r\n   tcp:                                               # valied fields: name, host, port, timeout, ssl_key_file, ssl_cert_file, ssl_ca_cert_file, ssl_insecure\r\n      - name: logstash\r\n        host: 127.0.0.1\r\n        port: 9653\r\n        timeout:  3                                   # default 3 second\r\n     # - name: filebeat\r\n     #   host: <hostname or ip>\r\n     #   port: <port>\r\n  # udp:                                               # valid fiedls: name, host, port, timeout\r\n     # - name: rsyslog\r\n     #   host:\r\n     #   port:\r\n     #   timeout:                                      # default 3 second\r\n```\r\n\r\nSee how the TCP is indented wrongly, the -name field is in the right place. \r\n\r\nThere's no error message to the users, TCP output just does not occur.  (OR is there? where is the error logged?) \r\n\r\nWhy can't we use the server.conf  that's shipped with goconserver and modify the lines in there, why do we duplicate this writing of the server.conf file in Goconserver.pm?  "},"comment":{"url":"https://api.github.com/repos/xcat2/xcat-core/issues/comments/398547244","html_url":"https://github.com/xcat2/xcat-core/issues/4906#issuecomment-398547244","issue_url":"https://api.github.com/repos/xcat2/xcat-core/issues/4906","id":398547244,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODU0NzI0NA==","user":{"login":"whowutwut","id":10049070,"node_id":"MDQ6VXNlcjEwMDQ5MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/10049070?v=4","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T21:10:57Z","updated_at":"2018-06-19T21:10:57Z","author_association":"MEMBER","body":"Ok, sure. "}}
{"actor":{"display_login":"whowutwut"}}