{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/180508605","pull_request_review_id":110940299,"id":180508605,"diff_hunk":"@@ -282,16 +282,19 @@ ConvertedResult OnnxExporter::CreateConvPoolNodes(\n     CAFFE_ENFORCE(\n         node.op_type().size() >= 4 &&\n         (node.op_type().rfind(\"Pool\") == node.op_type().size() - 4));\n-    CAFFE_ENFORCE(!global);\n     const auto& input_size = shapes.at(node.input(0));\n     const auto& output_size = shapes.at(node.output(0));\n     CAFFE_ENFORCE(output_size.dims().size() == 4);\n-    if (legacy_pad_attr.i() ==\n+    if (node.op_type().find(\"Global\") == 0) {\n+      // No special handling, since global pool does not care about the pad.\n+    } else if (legacy_pad_attr.i() ==\n+        static_cast<int64_t>(caffe2::LegacyPadding::NOTSET)) {","path":"caffe2/onnx/onnx_exporter.cc","position":null,"original_position":12,"commit_id":"3f24af0c409b33bf3fa8856cc0f7ba8795c3f1f9","original_commit_id":"951b95ace2fbc5e076e83d2571204fc733079f8a","user":{"login":"houseroad","id":30275821,"avatar_url":"https://avatars0.githubusercontent.com/u/30275821?v=4","gravatar_id":"","url":"https://api.github.com/users/houseroad","html_url":"https://github.com/houseroad","followers_url":"https://api.github.com/users/houseroad/followers","following_url":"https://api.github.com/users/houseroad/following{/other_user}","gists_url":"https://api.github.com/users/houseroad/gists{/gist_id}","starred_url":"https://api.github.com/users/houseroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houseroad/subscriptions","organizations_url":"https://api.github.com/users/houseroad/orgs","repos_url":"https://api.github.com/users/houseroad/repos","events_url":"https://api.github.com/users/houseroad/events{/privacy}","received_events_url":"https://api.github.com/users/houseroad/received_events","type":"User","site_admin":false},"body":"good catch","created_at":"2018-04-10T17:39:29Z","updated_at":"2018-04-10T17:39:29Z","html_url":"https://github.com/pytorch/pytorch/pull/6473#discussion_r180508605","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6473","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/180508605"},"html":{"href":"https://github.com/pytorch/pytorch/pull/6473#discussion_r180508605"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6473"}},"in_reply_to_id":180506780},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/6473","id":180671859,"html_url":"https://github.com/pytorch/pytorch/pull/6473","diff_url":"https://github.com/pytorch/pytorch/pull/6473.diff","patch_url":"https://github.com/pytorch/pytorch/pull/6473.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/6473","number":6473,"state":"open","locked":false,"title":"Fix the legacy padding handling on global pool case","user":{"login":"houseroad","id":30275821,"avatar_url":"https://avatars0.githubusercontent.com/u/30275821?v=4","gravatar_id":"","url":"https://api.github.com/users/houseroad","html_url":"https://github.com/houseroad","followers_url":"https://api.github.com/users/houseroad/followers","following_url":"https://api.github.com/users/houseroad/following{/other_user}","gists_url":"https://api.github.com/users/houseroad/gists{/gist_id}","starred_url":"https://api.github.com/users/houseroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houseroad/subscriptions","organizations_url":"https://api.github.com/users/houseroad/orgs","repos_url":"https://api.github.com/users/houseroad/repos","events_url":"https://api.github.com/users/houseroad/events{/privacy}","received_events_url":"https://api.github.com/users/houseroad/received_events","type":"User","site_admin":false},"body":"Add the missing logic back.","created_at":"2018-04-10T17:17:27Z","updated_at":"2018-04-10T17:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e5cd0f064da29d237f4ced8796a97cb42908e2c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yinghai","id":1100089,"avatar_url":"https://avatars1.githubusercontent.com/u/1100089?v=4","gravatar_id":"","url":"https://api.github.com/users/yinghai","html_url":"https://github.com/yinghai","followers_url":"https://api.github.com/users/yinghai/followers","following_url":"https://api.github.com/users/yinghai/following{/other_user}","gists_url":"https://api.github.com/users/yinghai/gists{/gist_id}","starred_url":"https://api.github.com/users/yinghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yinghai/subscriptions","organizations_url":"https://api.github.com/users/yinghai/orgs","repos_url":"https://api.github.com/users/yinghai/repos","events_url":"https://api.github.com/users/yinghai/events{/privacy}","received_events_url":"https://api.github.com/users/yinghai/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6473/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6473/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/6473/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/3f24af0c409b33bf3fa8856cc0f7ba8795c3f1f9","head":{"label":"houseroad:sony","ref":"sony","sha":"3f24af0c409b33bf3fa8856cc0f7ba8795c3f1f9","user":{"login":"houseroad","id":30275821,"avatar_url":"https://avatars0.githubusercontent.com/u/30275821?v=4","gravatar_id":"","url":"https://api.github.com/users/houseroad","html_url":"https://github.com/houseroad","followers_url":"https://api.github.com/users/houseroad/followers","following_url":"https://api.github.com/users/houseroad/following{/other_user}","gists_url":"https://api.github.com/users/houseroad/gists{/gist_id}","starred_url":"https://api.github.com/users/houseroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houseroad/subscriptions","organizations_url":"https://api.github.com/users/houseroad/orgs","repos_url":"https://api.github.com/users/houseroad/repos","events_url":"https://api.github.com/users/houseroad/events{/privacy}","received_events_url":"https://api.github.com/users/houseroad/received_events","type":"User","site_admin":false},"repo":{"id":98844631,"name":"pytorch","full_name":"houseroad/pytorch","owner":{"login":"houseroad","id":30275821,"avatar_url":"https://avatars0.githubusercontent.com/u/30275821?v=4","gravatar_id":"","url":"https://api.github.com/users/houseroad","html_url":"https://github.com/houseroad","followers_url":"https://api.github.com/users/houseroad/followers","following_url":"https://api.github.com/users/houseroad/following{/other_user}","gists_url":"https://api.github.com/users/houseroad/gists{/gist_id}","starred_url":"https://api.github.com/users/houseroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houseroad/subscriptions","organizations_url":"https://api.github.com/users/houseroad/orgs","repos_url":"https://api.github.com/users/houseroad/repos","events_url":"https://api.github.com/users/houseroad/events{/privacy}","received_events_url":"https://api.github.com/users/houseroad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/houseroad/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/houseroad/pytorch","forks_url":"https://api.github.com/repos/houseroad/pytorch/forks","keys_url":"https://api.github.com/repos/houseroad/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/houseroad/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/houseroad/pytorch/teams","hooks_url":"https://api.github.com/repos/houseroad/pytorch/hooks","issue_events_url":"https://api.github.com/repos/houseroad/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/houseroad/pytorch/events","assignees_url":"https://api.github.com/repos/houseroad/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/houseroad/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/houseroad/pytorch/tags","blobs_url":"https://api.github.com/repos/houseroad/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/houseroad/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/houseroad/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/houseroad/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/houseroad/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/houseroad/pytorch/languages","stargazers_url":"https://api.github.com/repos/houseroad/pytorch/stargazers","contributors_url":"https://api.github.com/repos/houseroad/pytorch/contributors","subscribers_url":"https://api.github.com/repos/houseroad/pytorch/subscribers","subscription_url":"https://api.github.com/repos/houseroad/pytorch/subscription","commits_url":"https://api.github.com/repos/houseroad/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/houseroad/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/houseroad/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/houseroad/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/houseroad/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/houseroad/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/houseroad/pytorch/merges","archive_url":"https://api.github.com/repos/houseroad/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/houseroad/pytorch/downloads","issues_url":"https://api.github.com/repos/houseroad/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/houseroad/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/houseroad/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/houseroad/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/houseroad/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/houseroad/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/houseroad/pytorch/deployments","created_at":"2017-07-31T03:31:00Z","updated_at":"2018-04-03T04:23:20Z","pushed_at":"2018-04-10T17:39:22Z","git_url":"git://github.com/houseroad/pytorch.git","ssh_url":"git@github.com:houseroad/pytorch.git","clone_url":"https://github.com/houseroad/pytorch.git","svn_url":"https://github.com/houseroad/pytorch","homepage":"http://pytorch.org","size":48395,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"038b66ee074c49d4a6e14ac030312cf6f6e78ca7","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-04-10T17:37:32Z","pushed_at":"2018-04-10T17:39:24Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":48832,"stargazers_count":13886,"watchers_count":13886,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3037,"mirror_url":null,"archived":false,"open_issues_count":923,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3037,"open_issues":923,"watchers":13886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6473"},"html":{"href":"https://github.com/pytorch/pytorch/pull/6473"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/6473"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/6473/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6473/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6473/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/3f24af0c409b33bf3fa8856cc0f7ba8795c3f1f9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houseroad"}}